labofsahil/github-event-dataset-2012 huggingface dataset:
Just a comment: about everything that adds to the SLOC, better it gives some concrete advantage, otherwise it will become an extra maintenance point and we'll pay a price for it later on... (thinking of the whole family of easyblocks together)
In that case it's fine as it is.  (I wasn't certain if the https only worked internally if you had a login.)
Instead, you might do the following, and be able to avoid the GetRows call:
<pre>$rs = PSU::db( 'hub' )->GetAll( $sql, array( $id ) );</pre>
Think this will suffice?
this property is never used in your example below. You should explain its purpose IMO
Maybe we can swap arrays instead ?
I think in other pieces of Javascript code, we stopped using the 'in' keyword, and used standard index iteration, specifically for this reason. Hopefully these changes fix all the IE issues, but if not, we should try making this change.

What do we still use Prototype for? I thought we (tried to) standardize everything around jQuery?
This function (copy_class_subject) doesn't appear to be used anymore, I take it that's because the existing ClassCreationController logic takes care of any necessary copying?  If so, can you remove it (and the import of deepcopy)?
Forgot to mention this in the commit, but this extra line just lets the email client know that it was sent by a PHP script. This can be handy primarily for sorting emails, but in general I feel it's good practice to send more information than is needed just in case it needs to be used in the future.
Ты наркоман шоле? Постарайся найти все же из `actions`.
What was the reason for using the native JavaScript onClick instead of the jQuery click event?
Since we modified this line, can we use single quotes instead?
Why the redundant comment?
MINOR: Personal preference - two statements on one line
The WARN at the top of doSendAndReceiveWithNamedReplyToDestination says that with an explicit correlation key, the consumer is created before the send, to avoid the race condition, when the replyTo is a topic
Way ahead of you ;)
This is autogenerated.
@lsmith77 how can we handle the login and password for the site on production? I went for the memory providers since it's the easiest way to deal with user authentication. To login, you just need to go to the URL cmf.symfony.com/login. Don't hesitate to tell me if you see a better way to do it.
Maybe say

@return this for chaining

?
Use [example.com](http://en.wikipedia.org/wiki/Example.com) instead of a possible real domain.  Applies to other instance below too.
why is this wrapped in an IIFE? it would be easier to just

```js
var index;
if (options && options.index){
  index = options.index;
} else {
  index = 0;
}
```
This might be slightly less clunky as:

Spaces in installation path names are not currently supported.
Noted. I'm now curious about the *.Fody.dll versus Fody.*.dll conventions but that's a discussion for another time.
Ideea e ca broser-ul are un mesaj standard. Please math the requested
format: si titlul pe care il dau eu.

On Wed, Feb 29, 2012 at 4:58 PM, Alex Morega <
reply@reply.github.com
> wrote:

> >
> >          CommonString.named("phone") \
> > -                    .using(label=u"Phone"),
> > +                    .using(label=u"Phone") \
> > +                    .with_properties(attr={
> > +                        "type": "tel",
> > +                        "pattern": "^\d+ \d+ \d+$",
> > +                        "title": "(999 000 555)",
>
> zi mai specific, `example: (999 ...`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/eaudeweb/cites-meetings/pull/2/files#r501558
>
Yes. It was when I was trying to download 
http://ccmc.gsfc.nasa.gov/ccmc-google_earth/PolarCap.png
We, as a team, can not make these decisions for the user at such a high level.  When we are down in the weeds, yes, we can make judgement calls about what things are bad ideas things we can't support because of implementation issues.  However, at the API/schema level, we need to be as flexible as possible.  We can't know with 100% certainty how users will need to use the feature.  For example, what if there is a file with non-time tagged (i.e. static) but I need that data to update every 30 seconds with the latest version, I want objects to be transient and not be maintained across polling updates.  That's a valid use case that would require polling not to be additive.
Trying to deal with some exceptional usecases ( but making more changes 
now );

I'm assuming each agent manages their own grid, in order to shut it down 
when the agent gets undeployed.

So, these scenarios are problematic:

1)
Agent A creates his own grid with nodes N1 and N2
Agent B creates his own grid with nodes B1 and N2

Now, agents end up sharing a node, so there's a problem on destruction :(
I may need to make that gridId part of the primary key, or use reference 
counting :(

2)
Agent A dies abruptly before it can remove the node from the WPs.
When A comes back, the WPs are dirty.. I'm using the gridId to safely
recycle the table row.
Davide



On 06/28/2012 03:50 PM, Salaboy wrote:
>> @@ -76,11 +76,11 @@ public static Object sendMessage(ConversationManager conversationManager,
>>           }
>>       }
>>
>> -    public GridServiceDescription create(String serviceDescriptionId) {
>> +    public GridServiceDescription create( String serviceDescriptionId, String ownerId ) {
> Can you explain me what is the function of the ownerId, I'm checking it, but to understand why you add it here.
> I've also notice that most of the changes are formatting changes which complicates a lot the revision. Instead of looking at 3 classes I need to check 50
> :(
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/droolsjbpm/droolsjbpm-integration/pull/28/files#r1072762
>
Because it represents a property and not an action. It does not do anything to the data, only gathers it.
If it had to do any massive manipulation to the data and/or recieve arguments then a method is the way to go.
It will also allow better refactoring because you might allow a set operation someday and adding a set_authentications method will change the class' interface thus violating OCP. Adding a setter does violate OCP in C# since the whole interface changes but I'm not sure it is so in python.
I'm inclined to think it does not.
Turning this method to a property will allow subclasses to fetch the authentication in a different way by using another method.
Overriding this method alone makes it hard to fetch the authentication since the authentications will always need to be a list of `[a(self) for a in self.authentication_classes]`
Same here, is the `unicode` necessary?
the "e" of the method name is not correctly formatted.
Can you comment on what each of this repo is used for ? We should minimize the use of 3d-party repo (in an ideal world we would only depend on Maven Central), so having such info will help maintaining the list of repo, and removing those which are no longer needed.
I think "as follow" is not a valid form, it should be "as follows". ([ref](http://www.englishforums.com/English/AsFollowsOrAsFollow/cgrjw/post.htm))
I think you can remove lines 51 and 52 as presumably you were just using them for debugging? (PS for legitimate logging code, don't use print using the logging api)
data-mode=scroll seems to be using a  non-standard mechanism to declare that something is scrollable. I think this should be done with CSS or with ARIA roles  but not with a data attribute.
Yes, it is a bit crazy, but I'm not sure there is that much that we can unify because the point is that they are (mostly) different rather than redundant.

There may be something we can do about the four or so different ways of passing a location in the url (but back compatibility is a big issue here) but with one exception (bbox vs minlon/minlat/maxlon/maxlat) they all exist for a reason.

Assuming there is nothing in the URL then we look to cookies, then to the user's home location, then to geoip and finally to a fixed default.
As with createRecord, this links vs taking ownership, but I see there's a createAliasOwn in this case.
Still would be nicer if consistent.
Hi Evan,

that could be solved like that:

$browser = Locale::acceptFromHttp($_SERVER['HTTP_ACCEPT_LANGUAGE']);
$locale = Locale::lookup(array_keys($languageList), $browser, 'en_US');

since Zend\Locale\Locale::getBrowser() has been removed, but this would cause a direct depandancy to php5-intl extension, which isn't activated/loaded on the half of isp's in Germany, i don't know what is givven in the us
does it really matter? i pushed this file by mistake god knows when :) am deleting it anyway
I disagree. This new zip is in a format that's more useful for Eclipse users because it's <20M and isn't bloated w/ uninstallable stuff they can't use. And the new zip can be used w/o being unpacked first, since p2 understands its format OOTB.
If this is kept, don't call it `mixIn`, please call it `mixin`
I just wonder why? I would say this is perfect example on how to allow caching.
У вас возникнет конфликт - искать в post.Msg ыыражение aib.xMsg
тут нужен тогда иле self, или что-то еще.
А що там было не так?
How did we missed "this"?
This way it is "removing" the first found element and leaving a position as "undefined", so our arrays ended up empty, and program still run
how can this thread ever quit?
Actually in JS -1 is true, only 0 is false
yeah .. i don't know the details, but the interface changed, so we have no choice but to follow

see https://github.com/symfony/symfony/blob/master/UPGRADE-2.1.md for more details
Reusing precalculated value
Don't take this change.  It was done just so I could make my own managed package.  Sorry for not telling you which specific files to take.