labofsahil/github-event-dataset-2012 huggingface dataset:
Okay not exactly one stack frame. 

What I wanted to say is that `MacroBodyTypecheckException` is thrown only by the (non-recursive!) code called by `MacroTyper` and is caught one stack frame up in `typedMacroBody`.
given the comment above, shouldn't this be
cond = (skew <= 0)
The dimension check for ``mode == 'valid'`` occurs 4 times in this file, can you factor it out as ``_check_valid_mode_inputs()`` or something like that?
@mrocklin, the last `else` statement required different semantics than `MatrixBase` and also it did not permit the use of `SparceMatrix(Matrix(...))`. I will revert the deletion of the special cases but I will leave the final `else` statement as it is in my branch.
> I'm not sure why you think the : part is broken; I think I showed that it computes the correct min,max,step tuple (0, 0, None).

This is because I looked at where the code went (actually, just the traceback), and it's coming form a function that converts slices to ranges.  The slice is converted to the range [0, -1] (i.e., "does 0 satisfy 0 <= 0 < 0"), which is not true.  The -1 part is converted to "2 in the range [0, 2]", which is just fine. 

> The bottom line is: if you index a matrix with integers you get elements. When you use slices you get sub matrices.

You get sub-matrices if any of the parts of the key is a slice, even if the other part is an integer.  I agree that if both keys are integers that you can never get something out of an empty matrix.
I do not understand this. Firstly you need to wrap `5/16` as `S(5)/16`. Secondly the rhs evaluate to `oo`, just as expected.
Will change the tests over there in another pull request.
constant. -2 * constant.
added customQuery to the prototype of this class
This line will fail if the destination root contains a character that is part of the regexp subset. In other words, you should escape the path before asserting. I have already pushed a fix to master.
Explicit space before and after `=`.
Sorry, I am still not used to the .h/.c separation of C/C++. Now I understand that, if the header is only included from a .c, that header will not need to be installed. I will fixe it, and try to squash all the commits into a single one.
Just being the boring reviewer here: can't you increment the passInfo after the sigabort handling? then you don't need to decrement it there
I personally would have done with a switch statement :p
I mean they need a section with the title "Returns", just like this has a section "Parameters".  This is all detalied in the documentation guidelines (in turn taken from the numpy/scipy guidelines).  That is, it is not just convention - it's used by the sphinx extensions to properly format the API documentation.
а это `PROFILER_STAGES` где добавляется?
I can't think of anything short of turning the row adding in to some kind of widget that has a control that knows how to set the focus on something relative to itself.
Also, [we need an upper bound to the limit](https://bugzilla.mozilla.org/show_bug.cgi?id=809528#c3), so that `?limit=999999` doesn't fetch ALL the things. Even if that request times out, repeat attempts can turn into a DoS vector.
I used display:none; for a few reasons:

1.  The top bar "jumped"; you could quickly see the dropdown content and then it was gone;  a bit ugly.

2.  The "share" piece is non-essential content, and in the rare case that someone didn't have JS turned on, no/little page value was lost.

3.  There's a really funky bug going on in Chrome where the "Report a Problem" link is showing ~100px to the right of the "Share It" link.  (Doesn't happen in Safari)

Recognizing now that we want that menu to be visible for no-js users, can I propose that we use a NOSCRIPT tag to display the menu?  That will prevent the 3 issues above from happening and ensure no-js folks can use the share menu.  JS makes that menu display:none; at the outset anyway, so my proposed solution just makes the entire process smoother.

Let me know your thoughts and thanks for taking the time Craig!
need to update/remove preceding comment now that this is fixed?
do you have more than one id named #searchfield? if not, you can just simplify and call $('#searchfield') instead
Please don't abbreviate unnecessarily. I don't know what `_n` and `_u` mean.
I'm not sure about that. It is a full rewrite, so probably changing first number would make more sense.
An interface cannot depend on its implementation. If "custom html" is part of the interface you need to rewrite this sentence to make sense by itself. Alternatively what you wrote was not what you meant.
Assert that response is success.
Filter out invalid attachments here. `if (!extension_allowed($row['forum_id'], $attachment['extension'], $extensions)) { continue; }` You can get the forum_id from the post or topic table. When the download is for a PM, set the forum id to false. Inititalise $extensions to empty array before the loop.
yes- will get to it later
Is there a reason you don't want to throw an error here?
Bucata asta de cod nu ar trebui să fie aici. Nu poți presupune că ajunge în hub, doar pentru că by default e redirectat acolo după login.

Un loc mai bun pentru salvarea în sesiune de informații este in wouso.middleware.<un modul anume, poate security>.
это в модуле woman ;)
This should have been done via ```$player->getAlliance()->getLeaderID() == $player->getAccountID()``` similar to what you did in alliance planets, generally I try to avoid writing database queries outside of the libs directory as most can/will be reused elsewhere (or may already have easy methods to do the equivalent)
Looking a bit deeper I found the `run` method (I’m now assuming `createRenderer` is private and therefore not documented). https://github.com/iamdustan/bonsai/blob/cb6ed0f511ea50b0b4510d144b357651bb8ca139/src/bootstrapper/player.js#L90

I moved the method overloading there as it seems to be a better fit (and it’s already jsdoc’d)
I'm pretty sure this should be `:lexer` not `:lexar`
Отступы,
Could you move the helper types to the bottom, after the tests? Thanks!
avoid magic numbers -- why is 3 so special? It's better to clarify by used of a constant. Then if someone adds another Store, they'll realize that they need to update this number. Something like:
```TOTAL_STORES_TO_LOAD = 3;```

but please name it whatever YOU think is most clear. Don't just use my suggested variable name if it's not the most accurate name.
Ya , it is 25 in Openmrs
If we place this with the views of the login app, this should work. But might cause some issues as the topbar will be common throughout the app.
这种一堆function () {}的。var noop = function () {}; 然后 areaHoverIn: noop, areaHoverOut: noop
Line number alone is not enough as this will change in the futur. Can you add the test name as nosetests need ([class_name.]function_name)?
should it be dev[6:]? If not, can you put into comment an example?
else: unnecessary after ``return``
if everything is ok
без него процесс все-таки не завершается
Lists users doesn't sound right
I'm not familiar with composer so much.  But Is it possible using a separate composer.json, perhaps in the Plugins/Foo/composer.json?

Perhaps this is better discussed in #croogo.
Please remove any trailing whitespaces.
Being an end-to-end I would test directly the nrml artifact produced. Since results written to nrml are taken from database, this implies also they are stored correctly.
You can remove the pass
Well, we can leave it here for now and then try to demo up some use cases with this new stuff and see if we get upset that its missing.... Its easy enough to put it back in.
isn't "hit recovery" usually how fast you recover from being stunned or interrupted attack?
How will this failure propagate up to MPD etc? Is it ok that we crash mopidy if this fails, or should we be raising an exception instead?
The patch makes things work. I don't think this is an objectionable goal. The formula works, and will continue to work in the future, with this patch. The application works with this formula, and will continue to work in the future, with this formula.
done

The reason I put this here is that the download link on this page is ONLY to an unversioned archive: http://golem.ph.utexas.edu/~distler/blog/itex2MML.html -- there is a version mentioned in text on the page but it is out-of-date.

The directory: http://golem.ph.utexas.edu/~distler/blog/files/ is not listable so I couldn't just see if there were versioned archives there.

I put those comments there because I fifn't think *I* would remember how to get the version number if I just went to Jacques page.
`=> :universal` doesn't exist yet, but we can't depend on mysql directly anyway; see e.g. the `mysql-proxy` formula for how an external dependency on mysql is handled.
Any reply to the mail?
Sorry it's called `api_request_delay`: https://github.com/praw-dev/praw/blob/master/praw/praw.ini#L4
>> Всё зависит от направления стрелок.

> По-моему, независимо от направления стрелок противоестественно называть потомками тех, кто существовал раньше, а родителями тех, кто появился позже.

Хехе. Ну всё же есть устоявшаяся терминология в теории графов. А тут история -- это и есть ориентированный граф, у которого все стрелки идут в одну сторону. Поэтому тут вполне можно говорить об отношениях отец-сын и предок-потомок. Как мы этот граф строили не имеет особого значения.

>> Дело в том, что ветка -- это по сути и есть просто sha1 некоторого коммита. Опять же никто не мешает вам слить в свою ветку произвольный коммит, на который ни одна из веток не указывает.

> И всё же ветка — это не коммит, а всего лишь именованный указатель на него. Для слияния непременно нужна ветка, чтобы было какой указатель двигать

Нет. Сливать тоже можно в произвольный коммит. Я понимаю, что смысла в этом может быть особого и нет, но всё же. Если HEAD не указывает на ветку, то при слиянии сдвинется только HEAD, ветки останутся на своих местах в этом случае.

> Вариант объяснения с движением по истории коммита и перемещением указателя мне не нравится тем, что он допускает двусмысленность в понимании, о каком коммите в каждом случае идёт речь (чья история и чей указатель)

Так двусмысленность можно исправить как-нибудь так "Так как ветка, которую мы слили, указывала на коммит, являющийся прямым родителем коммита, на котором мы сейчас находимся, Git просто сдвинул ЕЁ указатель вперёд."

А вот в предложении "Так как мы слили master с веткой hotfix, ...", не глядя на пример, не ясно даже какую ветку и куда слили. С потомками опять же я считаю, что если есть стрелки, то отец -- начало ребра, сын -- конец ребра.
Hmm hier wird ein pfad erwartet..?
This is a generic component, this condition "showUnknownContacts" shoudn't be checked here
我看到PATH问题顺便帮你添加一下，初学者确实应该不知道那是啥东西。
What about `Tmdb.api_key = file.read.chomp`? `chomp!` returns nil if nothing was removed. It was causing some fails here.
Yes. Thanks for spotting. Will push an update right now.
The times that I've revisited this code I've chosen to flatten the case statement into a `if` `else if` `else` instead of the `if` `else` `if` `else`. Do as you wish but I find it more readable that way.
uh yes totally, that's redonkulous that it doesn't!
Why the foo in the url it's parsing?
Yep, error will still break this. Need to fix that.
Whoops, I don't think you meant to set this to true for the pull request.
I thought it was then referencing a method of the undefined object, but I must have misread the code.
There's still a reference to `promise` here.  I'm fine with removing the var though.
Nope. Removed. Also moved the removal of the `template` class from the clone into `showModalDialog()` since it shouldn't apply if you're passing an actual template.
I think this comment got misplaced after my last change. See line 61.
Wouldn't it be nicer to do `path.join(__dirname, "..", "plugins-client")` ?
You don't. If you just add the clients below to one list then you can use type information to create a queue for each client type.
This is not something I really care about, and I'm willing to admit it falls within the realm of subjective preference, but just for the sake of sharing, I prefer

```
{% block %}
<script>
$(function()
```

as it was, to

```
{% block %}
    <script>
        $(function()
```

Because I think for a template where all the text is within some block, and for a block where there's probably only one script tag, the readability benefit of indentation is outweighed by the fact of not having every line indented two more indents than it could be.
Generally if there's no else clause to the conditional, you use `when` instead of `if`. Just a stylistic thing.
Hi Kevin,

Are you referring just to the last line of this piece of code?

 <string name="tab_repositories">Repository</string>

 I left the singular form because in Italian we don't change the form
of a foreign word. We say "Un (One) repository", "Due (Two)
repository".

Let me know if you have any more doubts.

I also checked the other lines you copy and pasted into your email and
they seem correct.

Regards,

Chiara.

2012/10/23 Kevin Sawicki <notifications@github.com>

> In app/res/values-it/strings.xml:
>
> > +    <string name="authored">Inserito tra gli autori</string>
> > +    <string name="committed">Eseguito Commit</string>
> > +    <string name="diff_line_message">Cosa vuoi fare?</string>
> > +    <string name="comment_on_line">Commenta la riga</string>
> > +    <string name="view_entire_file">Visualizza il file per intero</string>
> > +    <string name="comparing_commits">Confronta {0} commits</string>
> > +    <string name="enable_wrapping">Abilita il wrapping</string>
> > +    <string name="disable_wrapping">Disabilita il wrapping</string>
> > +    <string name="code">Codice</string>
> > +    <string name="following_user">Caricamento tra i following...</string>
> > +    <string name="unfollowing_user">Cancellazione dai following...</string>
> > +    <string name="starring_repository">Caricamento tra i preferiti...</string>
> > +    <string name="unstarring_repository">Cancellazione dai preferiti...</string>
> > +
> > +    <!-- Tab titles, should be as short as possible -->
> > +    <string name="tab_repositories">Repository</string>
>
> Is this really correct for the plural form of repositories?
>
> Just want to double check.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/android/pull/259/files#r1910647>.
>
>
I think you want to create a `validators` folder and put all these validators into separate files.
But LiftResponse doesnt have code, only  toResponse. So we end up calling toResponse twice (here and where the response is actually sent)

I'm unsure why this is so but assumes there's a reason :-)
Hm, if you're only using this function once, why not do it inline on line 245?
Any reason to not make this a prototype?
I think the shortform syntax is preferable i.e.
.animation( @animation ) {
-webkit-animation: @animation;
etc.
}
Moved to `/src/editor/trackevent-editor.js`.
I'm fairly certain this doesn't need to be here.
alternatively we could consider making --all the default option here
Le log de la commande est fait en dessous.
Je pense que cette ligne est en trop : surtout qu'elle écrit dans le log de l'API.
Missing javadocs :-(
Change this description
Is this match needed? I don't know if Scalding supports it but normally you can do things like:

collection foreach { case (traceId: Long, spanId: Long) => println(traceId) }

or something similar.
Plural-Forms není hlavička, jen součást hlavičky.
Tuhle formu je zakázané používat. Povinný styl je "Probíhá něco něčeho", přičemž pokud je řetězec použit v záhlaví okna nebo ve stavovém řádku, tak se použije stejný tvar ale povinně se vynechá "probíhá". Takže pokud to není použito v záhlaví nebo stavovém řádku, tak tady má být "Probíhá automatický překlad...".
Could you use the existing tree implementation in `examples/tree.jl` instead?
Please surround the loop content with { }, even on single line statements.
Instead of just `mkdtemp()` how about adding a specific `prefix=` or `suffix=` argument. I always like using those to clarify what a temp directory was created *for* in case it doesn't get deleted automatically.  Maybe something like `prefix=astropy-test-`.
It looks like the add/sub/mul/div methods are the same? Is this intended?
it's not.. I've removed this and made a new fixup commit now.
I can take this out if you want me to, but I don't see the point. A priority bump of just 1 has no practical effect on the overall priority comparison, but could be used to whitelist against the fee requirements, and the priority is entirely ignored if a transaction doesn't meet the fee requirements, so it makes  no sense to increase the priority while not overriding the fee requirements, IMO.
Even though there are a lot, at least it makes it possible to see the changes. Now it has to be compared manually....
I read that as an ACK for that change ;)? If SHGetSpecialFolderPathA() fails there is a serious problem, so fllback should not matter in that case + current version is not Win >= Vista compatible.
Why do we have this `loop` macro? (defined as `for(;;)`). It's pretty confusing and doesn't add anything to the simple C syntax, does it?
Yes, because it IS unused ;). I thought it could be useful for others / later, that's why I added it.
```
if ($instance)) {
	$this->_validator = $instance;
} elseif (!$this->_validator) {
	$this->_validator = new ModelValidator($this);
}
```

would be sufficient then, as type hinting assures $instance can only be null or ModelValidator instance
I wouldn't recommend using `setHash()` instead why not recommend `$hash = Security::hash($password, 'blowfish');`
You don't need `%s` in error messages with PHPUnit, the remaining ones are left over from the simpletest upgrade.
end() takes its parameter by reference, this will make strict errors.
meh, not too important—i'm removing the last one.
This query will cause a segfault if commod_ is not initially set to anything. To avoid this, set commod_ to NULL somewhere and check `if (commod_!= NULL)` instead.
Because now we don't have to hide the button, all browser now (kinda) support the notifications
Yes. This is one of the things I was considering originally.
The point here is whether we should do that or not. If it's not cancellable, then it should still execute the default behavior, not block it. Sometimes I think we should just ignore, others we should shout at user.
The way that CallableEventListener is implemented, it automatically triggers preventDefault if user defined to return a value there. This may heavily affect this behavior if we throw Exception. I don't know....
Should it be hardcoded?
Remove the git commit sha from git-tfs's version string. I dropped it on master, because it has caused problems for contributors in the past.
Thanks for the comments! I have changed the code accordingly.
If the question is locked, this looks weird.
Actually, like your `web.webapi.rawinput` below, you might just want to do `for name, value in form.iteritems()`
That function is part of my refactoring of all external resource access from Socorro.  I'm likely to refactor this entire script sometime in the future.  It is doing a lot of database/connection/cursor management manually that has been abstracted into the class socorro.external.postgresql.connection_context.ConnectionContext.
you've heard of "butt dialing"?  I think that was "butt pasting"
bid.authenticate throws an AttributeError if the assertion is invalid.
I would put this block in a try/finally block to be sure that everything is reset as it was previously. I even think that we could make an utility for this and remove it from the body of this method, we could for instance use a context manager for this?
yes, if get_or_create returns that the record has been created then call create_django_user etc.
This should be rewritten fully to store a single map of QString -> connection structure, and not have identical maps for the same data. What do the keys correspond to? And the values?

E.g. the old comment for serverIp said
/// This variable stores the server ip address we are desiring to connect to.
/// This is used to remember where we need to reconnect in case the connection goes down.
The new comment says
/// Messageconnection properties array: IP

It would be very good to retain the relevant comments that describe why a certain piece of state exists, what it is used for, what extraneous considerations/preconditions/invariants apply? The trivial comments int port; /* port */ are useless text filler.
This can't just be a set operation.  What if I wanna chain `params` multiple times?  I think it needs to be a `merge!`.

```ruby
self.call_runner.tap{|r| r.params_value.merge!(hash)}
```
For header, doing it HTTP format is probably best. (The `Header[key=k]` format is lowest-common-denominator)
цього не потрібно
I think we're missing an author here ;)
if you use composer to install the deps, simply use the composer autoloader
indeed, otherwise ``null`` values will not be validated.
this command needs more work
don't ?
Performance looks about the same between `/(LT|L{1,4})/g` and `/(LT|LL?L?L?)/g`. The saved byte is good though!

http://jsperf.com/regex-optional-vs-length
I agree, but I wanted to stay consistent with the existing code where all events are defined inline.
As above, would like to see the URL built off kLinkedInAPIUrl
in daghighan chiziye ke shoma to index.jade dar 1schools.github.com zadin
`!!! 5 SYSTEM "about:legacy-compat"`
zamani ke jade ro be html convert mikonam ino mide`<!DOCTYPE 5 system "about:legacy-compat">`
din cauza lui nu se poate face automatic merge?
The problem with that approach is that if the timeout is not working (exemple: the bug with the ssl handshake that hangs out), it would stuck the whole collector.
Please add copyright notices.
ah.. cool, das stand auch in irgendeinem Fragekatalog von mir:
 Wie bekomme ich Messages aus dem Backend zum User :)

 cool... danke

----- Ursprüngliche Nachricht -----
Von: Daniel Mecke
Gesendet: 22.11.12 12:30 Uhr
An: Pogrim/snowboard
Betreff: Re: [snowboard] made signup page new landingpage and embedded login form (#13)

 null
 In app/Resources/views/base.html.twig:
 > + <div>{{ flash }}</div> > +{% endfor %} > + </div> > + <script type="text/javascript"> > + if ($('#flashes').children().length != '') { > + $(function() { > + $('#flashes').dialog({ > + buttons: { > + Ok: function() { > + $(this).dialog('close'); > + } > + } > + }) > + }); > + } > + </script> 
 "flashes" sind werte, die fuer einen Request lang in der Session gespeichert werden. Sie sind also vor allem fuer Fehlermeldungen etc. gemacht. Das FOSUserBundle nutzt sie genau dafuer. Mit jQueryUI zeige ich sie hier in einem Dialog an. Liesse sich also auch fuer alle eigenen Meldungen wiederverwenden. Dazu einfach
 $request->getSession()->setFlash('key', 'value');
 ausfuehren.
 —
 Reply to this email directly or view it on GitHub https://github.com/Pogrim/snowboard/pull/13/files#r2204780 .
This will want to be changed to remove the "mpl" directory. I suggest we do that in another PR (as all the image results will have to move).
This should probably be VanillaPlayer, and you could change the message below to "you must be a vanilla player ..." :)
Other than that, looks fine!
You don't need this, as ``remote_rev`` is only used after cloning. The way you clone asserts that ``'HEAD'='origin/'+self.label``.
move this one above $(init) and the init declaration
Oops; extraneous " and."
At creation time it will all be the same thread. When the reference count is decreased though it is possible (although maybe unlikely) that different threads will be destroying different EJB's.
please use `calc` instead of `-moz-calc`
The container of menu(s) will be recursively created, so I don't think it should be put in html file.
Actually, they are already corrected in master at e298162b ...
is it needed here? progress activity defined the spinner to load ev.me, are you using for bookmark form? thanks
...Nothing, forget it. I remember that I faced an issue caused by traversing `querySelectorAll` result before. But not this case.
I think this function is totally wrong for two reasons: 1/ If you need to reset the dialog, you should do that in an specific function. 2/ The nodes of the DOM and the document itself can be cached and only need to query for them one time
Also doing this always is not necessary, will invoque it just when we are not searching already :)
Nit: `menu button[disabled]` — `disabled` being a boolean attribute, I don’t think it must have an explicit value.
`md_prompt`
I personally would create a function for this since it seems to be used three times.

```js
//ok this is a bad name but you get the idea...
function hasNoTrailingTime(subject) {
  assert.equal(subject.getHours(), 0);
  assert.equal(subject.getMinutes(), 0);
  assert.equal(subject.getSeconds(), 0);
  assert.equal(subject.getMilliseconds(), 0);
}
````

I would put that at the top of suite around [Line #4](https://github.com/mozilla-b2g/gaia/pull/1722/files#L4R4)
Ups, sorry, I wrote it in andalusian... :D Thanks! Good catch!
the same , hardcoded
Yes, I'll refine it.
I'm guessing you're going to have to parse some JSON here or something.
you are right.   StreamReader.ReadLine() does seem anticipate it (only '\r' is used).  I will adjust the codes so we are in par.
Instead of catch all (CLR or not), is there any reason not to catch (Exception e) and Tracer.TraceErrro(e); ?
You're right, thanks for pointing that out. I pushed a fix for it.
You meant `(p.id / \-).pop!`, right?

While we're into micro-optimizations, I'd say that `(p.id / \-)[*-1]` is better, since it avoids a method call. Speaking of which, coco really needs a shortcut for `[*-1]`, which seems overall more useful than `* = item.length`.
@brunomachado, shouldn't these styles be together with `.help-central-header h2` at line 10?

Why do they need to be inside a `.help-central-header .title`?
可以单独定义 只返回秒 ....   单独的返回 比如
1小时0分0秒0毫秒
 也可以
3600秒
这样的 如果不用tpl 不能自定义
This seems to do pretty much the exact same thing as `Equalizer`. Why not make sure the model and relationship objects use it, and you should get this behavior mostly for free?
What about using the `toHaveBeenCalledOnce()` matcher?
there should be two new lines before each comment
body p { margin-bottom: 0cm; margin-top: 0pt; } 
    On 9/7/2012 18:01, Argyris Zymnis
      wrote:
    
      
        @@ -0,0 +1,54 @@
+package com.twitter.scalding
+
+import cascading.tap.Tap
+import cascading.tuple.Fields
+import com.twitter.maple.hbase.HBaseScheme

      
      
The style we try to follow is to group up to 6 imports together like this:

```scala
import com.twitter.maple.hbase.{HBaseScheme, HBaseTap}
```

---
Reply to this email directly or view it on GitHub:
https://github.com/twitter/scalding/pull/121/files#r1122832

    
    o.k. just a result of a weird setup in my new Eclipse Juno
Wait why aren't we recording to any codecs?
Use `&times;` instead of `X`.
I switched the constant string over to using dictionary-based formatting.
What do you mean by that? It is actually fine, no need for `@todo` :)
Thought I removed all that. I'll take a look and fix.



On Mar 24, 2012, at 9:37 AM, "Dustin J. Mitchell"<reply@reply.github.com> wrote:

>> +        
>> +    def test_extra_args(self):
>> +        extra_args = ['--no-auth-cache',]
>> +        base = "svn+ssh://svn.twistedmatrix.com/svn/Twisted/trunk"
>> +
>> +        s = self.attachSVNPoller(svnurl=base, extra_args=extra_args)
>> +        self.failUnlessEqual(s.extra_args, extra_args)
>> +        
>> +    def test_extra_args_propagates_get_logs(self):
>> +        extra_args = ['--no-auth-cache',]
>> +        base = "svn+ssh://svn.twistedmatrix.com/svn/Twisted/trunk"
>> +        s = self.attachSVNPoller(svnurl=base, extra_args=extra_args)
>> +        self.addGetProcessOutputResult(
>> +                self.gpoCommandArgsMatch(matchArgs=extra_args),
>> +                result)
>> +        #self.gpoCommandArgsMatch(matchArgs=extra_args)
> 
> I'm not sure what's going on here -- is `gpoCommandArgsMatch` a pattern function like `gpoSubcommandPattern`?  In any case, commenting out code or using `print` in tests is good for debugging, but not in committed code, and I think that in this case your test isn't actually asserting anything..
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/buildbot/buildbot/pull/364/files#r600262
If we are going to error on adding existing records, we should test that here.
Is it? I'm not really familiar with OpenGL programming, but what I've read is that GL_SRC_ALPHA_SATURATE can be used for both RGB and alpha blending factors.
Correct me if I'm wrong.
Source: http://www.khronos.org/opengles/sdk/docs/man/xhtml/glBlendFuncSeparate.xml
Having the type field adds another level to already deep metric trees... we're using it without type successfully today.  It helps non-technical users find the metrics they care about.

This option would obviously default to true, but we'd like to have the option :)
You are right. 
Either rename Sty.c to Sty.c.cpp and use preprocessor directives or provide a CSS file (tank.c.m4) for your module with the following header:

```m4
ifdef(`conf_TANKLEVEL', `', `m4exit(1)')dnl
ifdef(`conf_TANKLEVEL_INLINE', `', `m4exit(1)')dnl
```

After all, Sty.c should be cleaned up and things like `.adc_graph` or `svg` moved to seperate files.
"A state is something that augments and overrides all other styles. For example, an accordion section may be in a collapsed or expanded state. A message may be in a success or error state."
'color' Vs 'selected' or 'active'?
You don't need this because `comment.message` is in markdown, not HTML. The definition of `markdown` above includes `safe_mode="escape"`, which means any HTML in the message will be automatically escaped. Bleach isn't required here.
If ````Row#exists?```` would check for all locators and not just index, then you could delete this method, since ````has_many```` already creates it and checks against ````#exists?````.
Not sure why this was changed or whether what referenced it was changed. Also not sure why all this was deleted (and then added again - see further down)
Cool, will definitely use this in the next iteration.

On Mon, Oct 22, 2012 at 12:21 PM, inothnagel <notifications@github.com>wrote:

> In lib/mxit_api/client.rb:
>
> > @@ -198,7 +198,11 @@ def recommend_app(callback_url, from_user_id, to_user_id, message, options={ aut
> >        handle_response(response)
> >      end
> >
> > -    def batch_notify_users(mxit_ids, message, contains_markup)
> > +    # When the Mxit API returns 400::Bad Request due to a non-existent Mxit ID in the batch the rest
> > +    # of the IDs still receive the message.
> > +    def batch_notify_users(mxit_ids, message, contains_markup, options={ spool: true,
> > +      spool_timeout: 60*60*24*7 })
>
> This page also lists a few idioms for handling default options:
> http://blog.leshill.org/blog/2009/06/10/default-options-with-ruby.html
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linsen/mxit-rails/pull/14/files#r1902132>.
>
>
Explicit return is preferred: use 'return true'
it's probably returning `undefined`, which would get "stored" in the session (but of course assigning `undefined` to a property is a nop). My intention with that code was to skip the comparison if the DB returns 0 or `undefined`, since that would mean the DB row pre-dates this code (and I didn't want to gratuitously expire sessions when this code first deploys). Somehow the check for that disappeared while I was merging/rebasing this.. I'll add it back.
Looks good.

Tests pass http://travis-ci.org/#!/mozilla/browserid/builds/1162509

r+
looks like this was copy-pasted and not updated from key to secret?
That's a fair point, actually. Keeping it simple is full of merit.
Since I decided against the onload idea, I kept this but changed it to query for data-tooltip in the latest commit.
Just wondering if we should remove a created log file even if it's the temporary folder.
I suppose this could be reworded as: "Buffer's length should stay the same".
This is where the user's code (effectively) starts. I thought the boilerplate thing suggested the use of an all-encompasing table with id backgroundTable and just one tr and td inside it that has everything else in it. Maybe I misunderstood?
Maybe this could be remove because we force Base as a subdirectory the configuration is not necessary and I am not sure that it could work with a different parametter
You can use more than one line to declare these classes :)
This entire patch is great.  My only comment is that the commit message doesn't closely align with the implementation.  True, this patch provides regular expression confinement functionality, but it does so by implementing Case Equality matching, of which regular expression matching is a subset.

I've simply updated the commit message to more closely align the change in code with the description of what we're changing.  No action required to get this merged.
Is `puppetd` a typo?  We should either stop using the `puppetd` executable or we should use it as the exclusive way to start the agent.  Having two executables is a burden to maintain.
@daniel-pittman I ran into some surprises with some of the win32 gems I was using. It automatically converts 'B' boolean return values to true/false instead of 0/non-zero, so my code never detected a failed win API call. I'm not sure if the same thing will happen using the windows-pr gem directly, but something to check.
@daniel-pittman my thought was that it would protect us better from errors on our part. Rather than silently ignoring our mistakes it would cause an error.
@vrthra probably better to just use facter to get the fully qualified hostname. See <https://projects.puppetlabs.com/issues/12407>
Thanks, I'll change that (I'll wait a bit in case there's more feedback). I'm glad I got the pattern right by the way – I looked around Melbourne a bit but did not find it anywhere. Maybe this would be a useful test to have as method in the Rubinius namespace?
We usually use the style raise Errno::EPROTONOSUPPORT, "socketpair(2)". Another thing is that it's easy to make it more descriptive by including the name.

Also probably best to use !type.kind_of? Integer, because other objects also don't work and could you add a spec for 1.8 mode too?
Pushed a change to it, awesome hint IMO, I somehow always use the stringified opening modes and forget about the integer ones :-)
Any reason to use the git instead of the rubygems repository version?
The gem version doesn't work with Rails 3.2 and uses an older version of Formtastic
The ``msg_type`` isn't a list, so even though this works (although not exclusively; ``stuff_before_the_execute_request_with_more_stuff_here`` would also match) because strings are really character arrays, you should use ``==``.
I think you can use .call(this, message); Then no need to set below.
$match may be a string or array (elements vs fieldsets essentially), will update docs accordingly
This shouldn't be necessary after running composer, as it will add a PSR-0 loader for the Zend namespace.
s/class/annotation/
Yes -- but for now, keep it to keep BC.
This should be in the format "// CraftBukkit start - description"

You should also commit fully on the line below; if you're going to change the functionality, change it, don't leave unused code
:D 

I'll fix that when I get access to a non-phone device :P
I don't really know how the component system works, but wouldn't this then make the sheep tick only if it can eat grass?
build_edition was already a before_filter that ran on new and create actions (defined in editions_controller.rb). Redefining it here moves it to the end of the list of filters, unfortunately other before_filters for the new action defined in editions_controller.rb expected it to be run before they did so there was an @edition available for them to play with.

Using skip_before_filter achieves the desired result of only running it in the new action without moving it's position in the list of filters.
Is it me or is the HTMLReader present two times?
iit -> it
@anti t-funkakrit ja $browlielet kuntoon!
Right, it makes sense then.

Btw, run is exactly the same as scan, except that scan has `global` set to true. So I guess we don't need a global option?
I would set this to None by default rather than having it an empty dict.
I'm wondering why we want to have the <!--# delimiter. I would go for `<!--` only (without the `#'). What do you think?
* Unnecessary "render" and needs new hash syntax
* Rename this partial. `tags/tags` will become tough to locate in the future. Also give it a descriptive name.
This stops the `is_vouched` flag from being doing anything.
I would have done this the opposite way:
```js
if (!body.recipient.match(/@/))
  body.recipient = user.get('email');
```
but this is probably fine.
Ah, interesting. So given that, look at the comment on line 4381, which I initially thought was correct.
Yeah, I'm not aware of anything that uses it. @lalinsky might remember where it was used before, but it looks like it can be removed.
Ditto. I
nit: please fix the indentation.
Oops, I forgot.
ACK, fixed
href style!
You're leaking the `i`
We have the function: `Berkshelf.mktmpdir` for creating tmp directories within the Berkshelf scratch directory (by default located at "~/.berkshelf/tmp". I like the idea of keeping the working files for Berkshelf within there. What do you think?
_("Port already closed :") + port
I would ask @daniell to see if he remembers what it was.
There looks to be an error in indentation here. I believe the correct indentation was as it was before
This could be done with one str-replace call and array arguments! But even better would be strtr()
Does a mime type have to contain a "/" .Does it make to sense fallback on the first part if there is no slash? ANyways, i think the heuristic makes sense, no objection to changing it.
это же указатель? зачем его мувать
а на поток тесты?
We could rename the `addRole` to `setRole` ?
This function is deprecated and the new function is documented.
What is the use-case for publicly exposing the `generateSizes` method? Is it so that in the case of failure, it can be re-attempted? To re-crop the thumbnails for the existing profile picture? All of the above?
Wouldn't it make sense to move them out in the enclosing collector class?
It uses a BasicConfiguration that is removed. Overall this is a whitebox test that relies on the internals of the implementation.
I have a problem with logger.debug("Not interested in ... runs amok on my logfiles generating mb/s files. 
I cant find a way to disable debug logging in eclipse though -- so please lower that level.
I've come up with a fix- basically, the new `_type_node` needs to be a class method as well. Pushing now.
Actually after reading the methods below I would move them to the `NotificatonMailer` and simply call `NotificationMailer.mail_notification(@notification).deliver`.

It is all notification logic after all. And the `_and_update` part is misleading
Dit is erg onleesbaar en heeft veel herhaling. Ik zou sommige dingen uit de if statements halen en versimpelen:

```js
var mouseOnLeft = (ig.input.mouse.x + ig.game.screen.x) > this.center().x;
var movingLeft  =  this.vel.x < 0;
```

Dan kan je ook zoiets doen:
```js
this.flip = (this.sprinting && moving_left) && (!this.sprinting && mouse_left)
```
OK, so another rename done. :)
I'm not a fan of the PERL-style inlining there, either, but it's up to you. Right now, the requested change is in my buffer and ready to go.
Указывать init здесь излишне, т.к. он уже объявлен для родительского класса NSObject, а в Cell.m мы просто изменяем процесс инициализации.
Каюсь. Облажался.
Уважаемый @derats, прошу вас, пересмотрите лекцию 2. В ней вы увидите, что категория без названия - это расширение класса, и да, в нём можно объявлять переменные класса. В категории можно объявлять и реализовывать только методы вашего объекта (или класса). Так же не помню точно, рассматривалось это в лекциях, или нет, но id - это "контейнер" для объекта. То есть, это, по сути, объект любого класса. Я подчёркиваю - объект класса! Переменная типа int - это не объект. Чтобы, например, проверить, есть ли в вашем массиве/множестве объект по заданному методу, нужно сделать примерно следующее (в случае переменной i):

```
    [DNA containsObject:[NSNumber numberWithInt:i]];
```
Я сделал это для своего же удобства, и это используется активно в двух методах.
Всё хорошо, но вместо числа 100 лучше объявить переменную, задать ей значение в конструкторе класса и использовать во всём проекте. В будущем при необходимости внести изменения в проект это облегчит вашу жизнь.
не вижу где константа, в начале m файла должна быть, незачем делать ее глобальной
No, this is pending, I'm not really sure about that and I thought to go ahead as it is now.
$view não é utilizada em lugar nenhum
we want `===` here to compare to `null` and `undefined`
That's clever.

This feature is a duplicate of [cli.feature#95](https://github.com/cucumber/cucumber-js/blob/master/features/cli.feature#L95) anyway. Let's kill it!
This isn't thread-safe and might cause race conditions in the unit test. We should use OSAtomic or always deliver on the main scheduler.
Isn't pthreads great?
> nope.. we have to update the scripts and re-create the tar file for that :(

ok… we should do this before next release.

I've just added to mne-scripts the necessary lines
Strange I don't have the bug.
When / where did you get it?

2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> > +            raise ValueError('No ECG channel available. Please '
> > +                             'select a channel resembling the ECG.')
> > +    else:
> > +        pick = pick_channels(container.ch_names, include=[target])
> > +        if len(pick) == 0:
> > +            raise ValueError('%s not in channel list (%s)' %
> > +                              (target, container.ch_names))
> > +    return pick
> > +
> > +
> > +def _find_sources(sources, target, score_func):
> > +    """Helper Function"""
> > +    if isinstance(score_func, str):
> > +        score_func = score_funcs.get(score_func, score_func)
> > +    if not callable(score_func):
> > +        raise ValueError('%s is not a valid score_func.')
>
> I don't know what happened the bug is here: ValueError('%s is not a valid
> score_func.' % score_func)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1966014>.
>
>
use a nested import to avoid the hard dependency on sklearn
Why not just go... `process.cwd()`?
I'm not even sure it works. I'll write up a test to make sure it works and if so, document it. If not, I'll fix it so it works and then document it.
This should be: https://developer.mozilla.org/en-US/docs/DOM/HTMLMediaElement
This is done intentionally. It looks nice when we have one import. (I am not sure this with openmrs coding standards)
No, the default is to use StandardAnalyzer with a tokenizer.
You're missing break; here. If you find one non blank description, you can stop iteration.
I think users are more likely to use the Html, Xml etc. classes directly, so I was worried it would break user code.   I occassionaly
Can you add a comment explaining that some (or all) of these things are optional and may not be present?
Done, you can see it in the next pull.
I think this should be:

    $request = new Request(
        ...,
        $_SERVER
    );
remove itself
@bschussek ha-ha, good catch :D Fixed wording a bit!
<header>X-Accel-Limit-Rate</header>设置响应到客户端的<link doc="ngx_http_core_module.xml" id="limit_rate">传输速率限制</link>；
设置对应的共享内存和允许被处理的最大请求数阈值。
=>
设置对应的共享内存和允许处理的最大过速请求数。
Fixing this would mean passing `system` to `MailboxType` in the constructor, which would potentially make sense. Yes, I think I will do that.
should this be c: or / ?
Spaces around the '+' would make this more readable.
Вот весь плагин и офф, а сабплагины вполне можно включать.
檔案命名同 post
On 28.08.2012 10:10, Oskar Hahn wrote:
> In openslides/main.py:
> 
>> @@ -249,6 +252,47 @@ def f():
>>      t = threading.Thread(target=f)
>>      t.start()
>>  
>> +def win32_portable_main(argv=None):
>> +    """special entry point for the win32 portable version"""
>> +    import tempfile
>> +
>> +    # NOTE: sys.executable will be the path to openslides.exe
>> +    #       since it is essentially a small wrapper that embeds the
>> +    #       python interpreter
>> +    portable_dir = os.path.dirname(os.path.abspath(sys.executable))
>> +    try:
>> +        fd, test_file = tempfile.mkstemp(dir = portable_dir)
> 
> pep8: Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value.
Thats one of the few things where I disagree with pep8 (because it's stupid :P ),
but sure, I'll change it when I get home from work
No need to change now, but if you want to use compact expressions, stackoverflow is a good place to look. In this particular case, list comprehensions may come in handy:

http://stackoverflow.com/questions/9835762/find-and-list-duplicates-in-python-list
Why check the signal type ?
These needed to be initialized.  That means that you have to give them a value.  I didn't want to give them a real value, so instead I called them null. I can check to see if the below code worked now by checking if these are still null.
This variable is set only once during the entire runtime of the program, therefore in order to make a changed setting work, you need to kill c:geo.
You are wrong. Currently the smallest of --zoom, --fit-width/document_width and --fit-height/document_width is used to get text_scale_factors for every page.

In my modification if you remove param->zoom check, then for every page the smallest of --zoom, --fit-width/page_width and --fit-height/page_width will be used, which would be a stupid behavior. :)
@ed- that is really ugly
updated_at:?
We no longer have a wheel now, do we? My understanding is that each segment is a "monotonic" subset of size Integer.MAX_INT/numSegment and we no longer do an mod(hashSpace). 
Also why would it ignore the number of segments?
I think this would be a temporary measure, Tristan had some nice ideas to avoid the need of wrapper classes around keys or values...
We should strive to keep *Configuration and *ConfigurationBuilder classes as clean as possible with only methods that are relevant for configuration building. This methods are not relevant to the user, they do not configure any particular functionality in Infinispan. This really is an internal flag for us to know whether we need to validate the config or not. 

So, -1 to these methods being public. If possible, I'd get rid of them too actually.

Having thought a bit further about this, I'd rather get rid of validateBeforeBuild and have an overloaded build(boolean validate) method in ConfigurationBuilder, hopefully in protected/default visibility. ConfigurationBuilderHolder would call dfb.build(false), and the existing build() impl would call the internal build(true). This avoids unnecessary validateBeforeBuild instance variable. WDYT?
This method is weird, and seems to only be for SHA -> object ID errors. Can you please use `git_errorFor:withAdditionalDescription:` instead?
That's fair… although it's worth noting that libgit2 doesn't type it as `mode_t` (albeit for compatibility reasons).
this is still new.

Can you add a comment in the Bug saying it's started to pass
@dcrosta wrote that stanza to enable the existing EPEL repo that is provided on Amazon Linux AMI images.
Thanks for the pull request. Sorry, to bug you about such a small thing. Can you add this empty line back? (just for readability)
My project won't compile with them uncommented.  I will open an issue.
Sounds great to me. On it.
this line is needed - otherwise serialization won't know the type - please uncomment.