labofsahil/github-event-dataset-2012 huggingface dataset:
This syntax is weird , but I don't think it's a bug. dvals is a thread local variable. The lambda argument states (I want the value of this variable, if it's never been initialized, call this lambda to get the initial value). 

So we don't want to create a new Frame every single time we call get. Instead we only want to get a Frame if its never been initialized before. There may be a better way of doing it, but this seem to work.
Unrelated to documentation; is this for-sure what you decided to do for serialization? Same thing I did before with something like a default execution context?
we needed that for .fetch() to work correctly
I think this a good idea , what about moving some examples like this ? 
Or keeping a full example in example folder of each package ?
This was as a result of running through the CXF tutorial on Karaf 2.2.5.
que va tio, si llevo semanas sin jugar, fue un reporte de un amigo xD
I have added a note on this in my Wiki, possible further findings and documentation can be found there: https://logiclab.jira.com/wiki/display/OPEN/Stackato#Stackato-Requirementstxt
main switch is to get rid of Supplier\<Server\> in favor of Server
IMO Using pointers and new/delete operators is always good practice.
Better memory usage is one thing indeed. 
It also reduces dependency to compiler/runtime specific implementation of memory allocation/deallocation for classes, calling convention for constructors/destructors, etc...
So the code gets more understandable when you actually see the new/delete operators in the code. (At least that's my opinion)
One thing to really keep in mind is that no memory leaks are introduced however, so some kind of test for memory leaks might be a good
idea to add to standard testing, if this is not already in there.
Yes, of course :)
It doesn't relate to array dereferencing if this is what confuses you.
Thanks!   I'm happy to contribute, and I hope people are able to benefit
from it.  I think it has potential to significantly enhance games & media
experiences built with phonegap.




On 1/26/12 10:21 AM, "macdonst"
<reply+z-59492-82eb4473741e731e188191e9032eb7882b492ef4-974294@reply.github
.com> wrote:

>Merge pull request #337 from triceam/master
>
>Added a low-latency audio plugin for Android & iOS
>
>This is completely utterly awesome. Thanks for contributing back to the
>community @triceam. I bet a lot of PhoneGap Android and iOS developers
>will love you for this.
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/phonegap/phonegap-plugins/commit/039636bab87879055b28cf
>768fb61e1faa5343aa#comments
Would a solution using Grand Central Dispatch and `dispatch_async()` etc perform a similar function? Apple's concurrency guide largely recommends against using NSThread anymore in favor of GCD.
Note: commit message is missing "omero.web.apps", i.e.:

```
 bin/omero config set '["webpublic"]'
```

becomes

```
 bin/omero config set omero.web.apps '["webpublic"]'
```
Can undervolt lower speeds too, this is what I've got,

{ 1, 122880, ACPU_PLL_1, 1, 1, 61440, 1, 0, 61440 },
{ 1, 200000, ACPU_PLL_2, 2, 5, 66667, 2, 1, 61440 },
{ 1, 245760, ACPU_PLL_1, 1, 0, 122880, 1, 2, 61440 },
{ 1, 320000, ACPU_PLL_0, 4, 2, 160000, 1, 3, 122880 },
{ 1, 480000, ACPU_PLL_0, 4, 1, 240000, 1, 5, 240000 },

Best to test the overclocking first & make sure there's no instability caused by that. Second to last number on each row is the voltage, set levels from 0-7.
Again, refer them to the docs for why.
this returns unauthorized on resources with ReadOnlyAuthorization
Yeah, if that's how you want to do it, you need to convert int to byte first. I think Byte might already a wrapper for integers. At least I know ByteWrapper does. You'll have to import it though.
Sounds good to me.

On 1/21/2012 3:52 AM, Richard Webb wrote:
> Would it be reasonable to assume that 64bit Windows always uses the W functions, and just do something like
>
> version (Win64)
>     enum useWfuncs = true?
>
> ?
>
Example of required documentation: `size` of what?

Also, generally, for size, type `size_t` is recommended.
Do we actually want layouts too? Or do grids replace those? I could actually see a layout fitting in a grid, so if a grid has 3 columns, a layout could be a collection of modules within that column... thoughts?
Yes... Where they are?
you guys are right.
Looking good. Yeah it would be good to make sure the file passes jslint too.

I like the idea of using a template file for manifest.appcache in tools/ where it could be structured like so:


```text
CACHE MANIFEST
# {stamp}

CACHE:
js/app.js
js/require.js
{files}

# catch-all for anything else
NETWORK:
*
http://*
https://*

```

Then use v.template() to have the {tokens} replaced. This would then allow the developer a way to add custom things to the file if they wanted.

I would also skip anything in the .js directory with getFilteredFileList(), there is an exclusion regexp you can pass, so maybe 'www-built/js/' as the exclusion, and then rely on all the JS files being built into app.js by the build.

That's all I have for now. Thanks!
Why? It helps track which phones are on which keys. That way you can pester your friend with expired keys to use siri.
yeah, saw it ... tnx
why should we wait? what if vmware tools are not installed etc? imho, this logic is better handled in the server class rather then in the request.
There's no harm in changing this link to work over HTTPS since that's where it ends up going.
The second clause of this sentence is social commentary. Maybe we could just end this sentence at the semi-colon?
To summarize, the advantage with a detect-only method I find is that I no longer have to assume. The code should expect a valid id to come in for this case and I dont really have a default value for it anyway. Which service should I default into, in case the client didn't provide a valid service id? That bit is expected, I suppose, hence the original check.

With evaluation orders, as described above, it's a bit different because I can probably assume a INTEGER.MAX_VALUE or something alike in case invalid input comes in, but I'd rather the client is notified to take care of bad input first, specially an attribute that determines, well, the evaluation order of services. 

Hope this makes sense.
Sorry, about that. I didn't mean to say that I speeded up this test step. The preceding test step is slow.
As this is part of the build, I’d prefer having one script which does it all, and which can be invoked by a task from SBT. Obviously this would not be run by default as that would require everyone to install `protoc`.
Add a comment that points to the 9-lines-down comment :-)
remove the use of addresses.head and instead create a method called defaultAddress and use that
Same here (i.e. we wouldn’t know how to do the ask timeout thing). Essentially the underlying reason is that ActorRefProvider does not expose a reference to its ActorSystem, which is a good idea because of initialization order.
How about making these two `lazy val`, depending on the `addressesPromise` which would go here as a simple `private val`? That obviously documents the write-once semantics.
Should I use 'interval' instead? 
E.g. rename the config option to ' leader-actions-interval'?
agreed. I hate using underscores but didn't want to touch Patrik's code. I'll see if he minds :)
Ok, as far as I can see it does, and testing agrees. ;-)
Comment is till valid :-)
The reason I was using unicode constants rather than string constants was to be consistent with the values in the response dict that are populated by the SAX parser.  Were these causing a particular problem for you?
BTW - the new snake-brain image looks like that snake is farting lightning
bolts. I liked the old logo better.


On Thu, Dec 13, 2012 at 5:59 AM, Ariel Rokem <arokem@gmail.com> wrote:

> Did not work for me. I don't have vtk installed on my laptop, so I can't
> run the examples.
>
>
> On Wed, Dec 12, 2012 at 8:01 PM, Eleftherios Garyfallidis <
> notifications@github.com> wrote:
>
>> In doc/examples/nii_2_tracks.py:
>>
>> >
>> > -**This example gives a tour of some simple features of dipy.**
>> > +We will show how to generete streamlines with Dipy. First we will reconstruct
>>
>> @arokem <https://github.com/arokem> Sorry, I mean to run the examples.
>> And/or generate the html? Did it work for you?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/103/files#r2402321>.
>>
>>
>
>
toolkit is p.toolkit so not really worth importing it separately in  my opinion but not a deal breaker
I'm not sure we want to declare that the install at the platform level is idempotent. I think it more applies at the handler level. I don't have a good use case as to why the handler would error on a duplicate install request, but I don't think we can make an assumption about all installs at the platform level and instead leave it up to the handler to decide.
All of the other pulp.client commands have called the default behavior run(). It's not the worst thing in the world if this doesn't, it was just a nice level of consistency across all of them.
raise MetadataException(msg), None, sys.exec_info()[2] ???
For now yes...since the map is string,any but we deal with a java lib that wants a anyref
A simple return i->second == DB_READY; should be enough?
The advantage of giving it its own class is to have a meaningful name for the class and the 3 fields.
As I said, send a PR.
Yes, the expression is misleading.
I meant:
"familiarity with mathematical concepts behind e.g. Range coding - and additional familiarity with e.g. colorspaces".

I assume that there are more things a reader should be familiar with?
If so, it might be easier to rephrase this sentence.
What is the purpose of this added code block?
please use wrapper types (Double instead of double)
this looks like it will fail for a HTTP request that's not cross-origin since the if's are nested wrong
I didn't look at this because I didn't look into whether the env->getExtension() method differs at runtime vs build time (+ non of our custom functions are using Twig_Function_Method).
Yep, understood, more overhead.
@joshaber Done. I'll open another pull request at some point for the other categories that aren't prefixed yet.
/Se/See/
Tady ale bacha, protoze tady je *pole poli* (array of arrays), takze `IMacro[]` neni spravne
Let's not add Javadoc for overridden methods because it's redundant.
But if that's a good idea, then it's also a good idea for sys.excepthook to be called when there's an exception in a ctypes callback, a cython callback, a __del__ method, a weakrefs callback, etc. And who knows, maybe it is. But this just doesn't seem like a good place to be trying to second-guess and "fix" the Python interpreter's standard behavior.
This should probably call alloc_log_clear (so just `return alloc_log_clear(NULL);`)
Added initialConfig.feeds documentation
declare it with static if you don't want intentionally expose it.
Change
    ```char *strcatalloc(const char *a, const char *b)    ```
to something like
    ```char *strcatalloc(const char *a, size_t a_len, const char *b, size_t b_len)```
Комментам в мастере не место
@mmozuras sorry, posted without refreshing - should we close the request?
I think `column` should respond to `type_cast`, and *should* Do The Right Thing™.  Don't we have column type specific to arrays for PG?
We could probably use `locales.uniq!` too. Besides this, everything else looks great.
@rafaelfranca, pull request updated. 

P.S. There is one fail in activesupport tests which related to #8185
This public status is only valid in the current compilation run, right? We need to check that the pickled signature says it's private, else the next compilation run will link against members which are not always public, depending on how you compile.
That's a very good suggestion! Thanks and done.
Spacing here around the equals please.
I vote for `groupby`.  Conceptually, the `groupby` you implement in this pull request and `itertools.groupby` do the _same_ thing.  Essentially, up to the ordering, `groupby` works like `itertools.groupby` would on a sorted input collection.  `itertools.groupby` tries to be clever and not consume all of the supplied generator immediately; this makes it slightly more general in terms of what it can accept as arguments, but less general in terms of valid input expressions.  Nevertheless, as I have said, _conceptually_, the two functions are the same.
It doesn't check the distance of the indents, only that they are spaces and not tabs, so nothing in the test suite checks it. I remember seeing Ronan posting a PR where he'd run a script to fix code quality errors like this (among other things).
It appears that the `else` clause and the pairing with `unpack` unnecessary. Nevertheless if you may leave `rm_id` acting in this way, please update the docstring.
Yes. So maybe it's a good time to list up all possible interface of scale_XXX.
I don't think `$keepBC` needed. We can always check for 'js:'.
@cebe Thank you for catch. Will fix it.
my bad, i meant catching not caching....
You will need to make a separate PR since this PR was merged already.
Makes sense.

Would it be adequate to (1) Check for a 'visible' key and (2) verify it's Boolean?
As it stands, any other key is simply ignored, so I think it would be overkill to somehow try and cleanse the input.
it IS kinda gnarly! i normally avoid methods that do more than one thing, or doing anything clever like this. my one exception is library code. this api feels pleasant and easy to remember. `assert_raises_context_manager` feels ugly and too long for something that'll be used in so many places.

it's kinda like how `open`'s return value can act like a context manager. [unittest](http://docs.python.org/library/unittest.html#unittest.TestCase.assertRaises) and [py.test](http://pytest.org/latest/assert.html#assertions-about-expected-exceptions) have the same behavior in their assertions :)
internal feature, it's okay to filter on some threshold value, which is fixed value.
@henrikbjorn Your code breaks when the callable is not an array (which happens often in Silex as the doc uses closures everywhere). This will work:

```php
$controller = parent::createController();

if (is_array($controller) && $controller[0] instanceof AbstractController) {
    $controller[0]->setApplication($this->app);
}

return $controller;
```
This is done because these are equivalent on AIX.
C99 style declaration.
I don't believe I wrote this originally. My guess is something like scale column?
yes, I remember this now. I think I wrote this before we talked about the difference between Logon and Login...
also why are we recommending using mongoimport?
Lines 24-42 are redundant to: http://docs.mongodb.org/manual/reference/limits/#Restriction%20on%20Collection%20Names (if there are oversights in that section we should edit that...)
The modification will not affect other test cases, now all the "xmlns" doesn't have the “/" at the end.
I was getting to that :)

If it's needed then docs should explain how to set this up for other web servers. Otherwise comment out by default.
See changes in develop/create_schema_files.php

Directory names use only following characters: /a-z0-9_\-/
so unicode isn't needed.
The first variable should be in single quotes. The second variable should probably be an integer, but I'm not sure what set() expects.
Spaces around parens, braces, and punctuation below.
Additional phpbb prefix on all global functions.

For this function, consider dropping sphinx prefix and moving it into one of general files.

Alternatively, instead of taking a pattern this function could take a function as an argument which would be invoked to determine whether to delete each found file. Then this could be used for e.g. deleting everything but index.htm.
I still don't understand what is intended here. Can someone double check this before this gets merged?
nice catch. fixed in bac32e8
yea i know.
We _must_ have index.js for Manhattan, but we don't want it to be full of "real code" or it becomes a mess for every other environment. Hence we have mojito.js with the real logic and both the server.js (which is what npm start uses by default) and the index.js (which is what Manhattan requires) simply point to the real code.
Might be nice to take 'autoload', 'yui_modules', 'tests' here and make them members in an 'ignore array', which could then perhaps also include other dirs such as 'artifacts' or dirs which the mojito app developer wants hidden.
It was part of previously committed code. Check "Blame" on file to track who did it :P
I believe we also should remove loggedInUser from localStorage here (stores uuid of current user)
How about testing whether the units are the same as self.cube.coord('delta'). I believe that's the behaviour we want. If you want to test for pressure units how about ```coord.units.convertible('Pa')``` instead? Dow we want to raise an exception if the derived units are not 'convertible' so as to avoid standard_name and units being inconsistent?
>  or if you want to, obtain the latest git version.

Not  sure what this sentence means.
あ、ちなみに階層深いものから消す為に逆順でfor文をまわしてるのでちゃんと動きますよ。
shouldn't expire_time take into account delivery_time ? Otherwise a mail could expire before it's delivered, right?
what is the Team variable used for ?
Typo on "parameter", this should read... "parameter that specifies that"
OK, I agree. 
I wasn't sure if there was a standard here.
Can you go into more detail? What kind of abuse do you think this will cause?

Adding this filter was the main motivation behind me making my changes. You have two users vocal enough to ask for this feature (me and @johnduffell). Comment driven filtering is even suggested on the filters wiki page: https://github.com/jacoco/jacoco/wiki/FilteringOptions
No big deal. I was only mentioning it because I wanted you to know there was more that can be done! No one owns the code ;-)
cmsketch only supports int8 type, I've already removed unnecessary fields in cmtransval.
Maybe we can call the current label name current_label or something? I'm having trouble parsing this in my head.
You can amend the current commit, then `git push -f` back to this branch on Github, and the pull request will be automatically updated to reflect your changes.
Still need a blank line between deps and fails_with.
I don't think it's necessary. We've already ensured `git` is installed at this point, and the `-q` option to `git symbolic-ref` ensures that if HEAD is detached, `git` exits quietly. So the worst-case scenario is that `branch_name` is empty.
This line is rather long.
Check the indent here (should be 2 sp).
Maybe use `startswith()` and slicing?
Is there a plan to have a screenshot of that somewhere? It'd be useful to link into that to show how it's done.
Use "RAIN" instead of "Rain" and "must" instead of "should".
Because it's the outline that appears, there is no border.
Almost there, split this into:

 * `protected function setupGitRepo()`
 * `protected function setupPackage() // returns the MemoryPackage`
 * `getPackageFileName(PackageInterface $package) // returns the preg_replace`
The indentation looks off here (tabs vs. spaces?).
Could we just make nameFor a protected method on this class, and use it here?
Yup, i have this in a follow up commit inbound
Like I said, I totally agree about the name. If we have a better name, I'd love to change it to something a bit more concise.
Why are the batches 1x1x1?
That is what I'm doing, but when I write the line as you've suggested:

    this.adapter = dojo.hitch(this, '_getAdapter', store.getValue(item, 'adapter'));

the tests fail. Evidently these statements aren't quite equivalent? I'm not sure why, but I'm inclined to just leave it alone as it works currently...
I think this class needs some comments explaining from a high-level what it's purpose is. What's it for? When would you extend it? Perhaps the name could be made more specific too. `mulberry._Adapter` doesn't say *what* it's adapting. Perhaps `_ModelAdapter`?
Actually, this whole thing can be a lot simpler if we don't have to branch based on PhoneGap's presence or absence ...
If rename input field is partially off the screen, it is only scrolled into view when it's at the top of the side bar. It doesn't get scrolled into view if it's on the left, right, or bottom.
We should use Async.doSequentially() here.  This code basically reimplements the Async.doInParallel() pattern, but since each individual doOpen() could show an error dialog we shouldn't run them all in parallel.  This change should also make the code easier to read.

See saveAll() for an example of similar doSequentially() usage.
``window`` is unused. remove this jslint config option.
I think we should move this block up, so it's just after the `if (command)` closes.  That way you'll also get a warning (instead of a silent no-op) when passing an id that doesn't map to any command at all.
Any reason one of these is toBe() and the other is toEqual()?
If `path` contains a single quote, this will fail. I think we need to escape these calls as well, because the actual value in the attributes now is escaped as well.
I think these three classes should be `DocumentSchema`s, since they're just JSON schemas and it's perfect for defining those. You can leave a comment describing that they're not just a subsection of some other document and how it's just a wrapper for something emitted by a view. (That's what's going on, right?)

Ps. you can even rename properties like

```python
    location_path = StringListProperty(name='location_')
```
it makes me a little uneasy that this modifies the input in place and returns it. if you mean to do in-place modification seems safer to return nothing, otherwise just start with copy.copy(doc_dict)
Is this the only point where asset_output is updated?
toArray asInstanceOf is nasty. You have an ArrayList to begin with, just use toList
Why overriding fulltitle? Why not setting only title to *Login*?
Was this just something we didn't need anymore?

Curious as to why this was removed. I doubt it's because of the intent of the ticket.
Instead of this guy, can we just use the built-in function? http://stackoverflow.com/questions/2614862/how-can-i-beautify-json-programmatically
in the regex you set, :id must always be set so you don't need to check for this condition
This needs a general comment to explain the algorithm, what's expected, what's returned.
sparkles :D \0/
re https://github.com/mozilla/butter/pull/1045/files#L0R91
But I figure if it fails ... at worst it's just a blank iframe, and not some kind of XSS attack?
Another .length.
could be line break (\r\n vs \n)
I think the "0xffffffff == don't care" semantics should go away either way (just don't add the field instead)

The rest i think is quite ok. adding some kind of capabilities field to HTSP is probably also the way to go I think.
add one more blank line above this line.
Please list all files that are not needed, beside things like a README and LICENSE file.
Yeah, I actually prefer the longer notation.  IMO, it is cleaner in the long run.  Also, although we only have 1 action on a view right now, I could envision more in the future.  For example, as we make refresh asynchronous, we'll likely have a 'status' action on a view to determine when the refresh is completed.
Oh yeah, very good point, and a better solution than mine.
So this can not be caught by the try except block because numpy is happy to do it. I am quite unhappy, but there is nothing to be done. Your solution seems the optimal one. A comment can be more detailed, but we will get to that later.
We probably need to simply update our docs to say this. We got rid of 2-staged pushing back in 1.6. We left the command around to not break people's CI build processes, might be about time we make the switch and remove the command in entirety.
I suppose he's following the code guidelines - you know, the contents of doc/coding.txt? ;)
Is this include needed? (it causes a circular dependency, as ui_interface.h also includes util.h)
This would be no longer used
I think a space is missing after `in the `.
If Log_DEBUG is not defined, Log_debug() is defined as nothing.
Compare:
`cat ./net/DefaultInterfaceController.c | cpp -I . -DCJDNS_MAX_PEERS=255 -DLog_DEBUG | grep Log_internal`
`cat ./net/DefaultInterfaceController.c | cpp -I . -DCJDNS_MAX_PEERS=255 | grep Log_internal`
Fixed on 77e0857
If we set weight in `hook_update_N()` we also need to do it in `hook_install()`. Also: Why is this needed?
Again, I'd suggest a different way of structuring this. A shared_context seems like the most obvious way of doing things... but there might be a better way.
Typo. Should be `'TraitsItem'`
Use for loop
just out of curiosity: Is there any particular reason why this line is commented out?
Thanks for the tip. I also updated the instructions at the top of the file accordingly.
New commits are fine - the only reason to amend would be when you feel a compulsion towards cleanliness, or you commit large and/or private data that shouldn't show up in the repo.  The Pull Request is all yours, treat it as harshly or conservatively as you like.  The only request we make is that you avoid upstream merge commits.  Any force pushes / rebases / clobbers, etc. are totally up to you.
Is there a better way to abort? The traceback takes up the entire screen making the error message mostly invisible.
This should be `self.notebook_dir`, not `self.notebook_manager.notebook_dir`
Correct, might as well fix that now since I *am* changing that file, thanks.  In my defense, I wrote this before we had the discussion :)
you going to have "id"  undefined here.  ( you remove var id, then keep the playhead reference? ) 
This should instead call the core embedPlayer.hideSpinnerAndPlayBtn(); and we should remove that old-school ( metavid era ) id discovery method that is probably broken. 

Also you set _this.userSlide we want to set  embedPlayer.userSlide = true; this affects things like syncCurrentTime method in EmbedPlayer
Why the extra call to a new function when `git__strdup(branch_name + strlen(GIT_REFS_REMOTES_DIR))` and `git__strdup(branch_name + strlen(GIT_REFS_DIR))` work just as well and allow the compiler to optimise the `strlen` call away to a constant?
Slightly rebellious alignment here.
2 comments

the expressions should support dynamic args such as the $idx in the loop or even the value in the context/ JSON ( so we should use the tap method )

I really dont see a use case yet where this comes handy,

can you tell me about your use case where this helper comes handy
What does this have to do with the pull request?
Agreed - that is much nicer
Instead of repeating this callback three times and replacing a few values, you should make a function that takes in the values you want to replace and returns this callback, referencing those values. Something like:

```javascript
function waypointCallback(current, previous) {
    return function(event, direction) {
        if (fixed) {
            if (direction == 'down') {
                $nav.attr('class', 'fixed ' + current);
```
... and so on. Then,

```javascript
$('#mobilized').waypoint(waypointCallback('mobilized', 'welcome'));
$('#action').waypoint(waypointCallback('action', 'mobilized'));
$('#community').waypoint(waypointCallback('community', 'action'));
```
Oh, thanks for cleaning all these up.
Shouldn't make a difference imo.
There are java libs which allow to configure the servlets within java code.
Having public constants allows user of such libraries to use the constants when configuring the filter
Normally the set functions overwrite and reset all existing values. Here all are overwritten but existing ones which are not overwritten, still exists. Do you see an easy way, how we could reset the existing ones? The problem is, we cannot just reset all params.
Technically they should be Debug-calls, but LOG() might have a place for generic script issues still.
I would right here

    if (event.value != null)
At ValidatorInterface::validateProperty() the same variable as $container is called $containingValue. I think the naming should be consistent here.
typo => container
Le 9 déc. 2012 15:07, "Christophe Coevoet" <notifications@github.com> a
écrit :

> In src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php:
>
> >  {
> > +    protected $dispatcher;
>
> why the dispatcher here ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/6124/files#r2358459>.
>
>
@drak your code suffers from exactly the same bug than the one described in the comment on which you replied. Look at the current code of the PR instead for a fixed version
thinking about it more, it makes sense, we already have a convention to support two different `color` spellings, so a `datePrefix` being different seems consistent to me
Need an explicit charset. I suggest that we require UTF-8 on both sides.
Or:
```ruby
File.open proxy_config_file, 'r' do |file|
  file.each_line  do |line|
```
which reads the file by lines. The "\n" is the default line separator stored in $/
It locks the app and you can't do anything without interacting with the UIAlertView first.
Yep this is done clientside now so I added a jasmine spec https://github.com/yammer/sched.do/commit/8136874880d67248f1a0db52d8a8d89c68e5aa65
Aliiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii !!!!
ye bar ba sublime umadim benevisim :D
chera nemibande tag hayi ke to khodeshon close mishan ro?
Use also null: false
delete commented out code. this is just cruft. in the future add a debug logging statement, then you don't have to remove it later on.
> GeoreferencedImage seem attractive though.

I definitely agree with that! I have the beginnings of something like that, but it is currently tied up in the ```image_nest``` code. It is actually what I used to figure out those extents in the first place!
My preference would be to do a ```ring.is_ccw is not is_ccw```...
Can't find any guidance, but personally, yes, I prefer a space... it *is* just a space though :smile:
soy idiom that i'm used to, happy to use leading since we do that in JS. probably makes sense.
Apparently not.  Oh well :(
``if False..``?
I almost made a joke about `options.fetch :context {{}}` but.....yeah.
fat arrow to keep context so you don't need the ugly hanging comma
yes, the next repo update has integration with configadmin
I hate to be the bearer of bad news, but it seems it is time for urn:jboss:domain:ejb3:1.3.
Why do we need such an arbitrary class here?
I don't believe it. Changing it now.
`function fillAlarm(alarm)` 

function name and remove index parameter
this line is invalid, please remove it
you have to put back downloaderror and downloadsuccess as well, right ,

Right now it doesn't work if I cancel the download twice.
`rv_lazilyCheckMozHidden()` ->  `rv_checkMozHidden()`
We check now settings here in order to store the message properly, letting user to resend later.
If possible, please help add function name to the callback function for better debugging.
delete out var

if (!urls)
   return;

add return aurl.value;

delete return out;
Does init is called multiple times? If not why do you have to reset the classes there ? (also you may prefer to use classlist)
nit: difital -> digital. And the second comment seems to not be at the right place (difital for the analog clock).
Do not inline rules, expand them on multiples lines.
Makes sense. I'll do it
The 'onerror' function is called but you cannot access 'retryCount' member since the error event is not fired properly. Also we are redefining error report police so I'll you update about the changes and decisions. Patch is comming. See https://bugzilla.mozilla.org/show_bug.cgi?id=783525.
The fail property is set for files that failed metadata parsing. If there are any, then the value returned by count() will be wrong, and the numbers used by this method will be off, too.  The way you use it in the music app it should be okay because you only search for records that have metadata...  But this is a weakness of this method.
When should I use LOG.info instead of LOG.debug?
Resolve the binding once and reuse it instead of doing Bindings.First() twice. Same for resolving the site url. This logic for getting the dev site url should be share between this and getting the actual site url.
You should remove all these brackets without sense in your whole fix
Originally state was going to be maintained in the node object in early design. This was replaced with models containing state which allowed for model-defined state machine. #next_state is obsolete and commented out now.
Decided not to throw for now. Future direction for Swiz is probably to remove this functionality entirely.
JS does not need getters.
you got me! :-D
Please check
Honestly I'm not sure. Or you can just copy it into the module.
you dont need parens around functions, and here you dont need String at all, just `result = '0' + result` is fine
This is  a temporary solution(compute result and re-correct ),  grace method needs to be considered.

I described this in perf regression testing wiki, I will add some comment in the code later.
What happens when $errors or  $path contain spaces? I'm pretty sure *nix systems will have errors.
`if event.target.nodeName isnt "A"`
Docuemnted it in the other pull request
protected or private
Please use relative require.
@jedp: if you can hack it together, #1 sounds great. And I totally agree with #2.
hmm.  that's odd.  would it be better to have *no* redirect for native implementations until they implement it?
In general we should place those imports before any other declarations. So do you mind moving it up even before the require line?
You can nix this--it's boilerplate.
i purposely make the line-height to 20px. cause its looks better in linux. maybe you change this.
are you intentionally leaving this commented line in place?  if so, perhaps a doc comment explaining why?
I am really worried by this line: if we fail to read we end up with an empty set of records?  That seems like it could wipe out existing content in the face of any number of errors, including things like "reading the file failed".  That isn't good, I think.

I think that the only sane way to approach this is a "whitelist" of exceptions that are safe to wipe the content out with, and otherwise just reflect the failure up.
From *other* solr schema: bundles/search/impl/src/main/resources/SLING-INF/home/solr/schema.xml
Yeah it's not pretty. http://blog.golang.org/2011/07/error-handling-and-go.html suggests handling errors by either providing a solution or doing a fatal. Or maybe handling and passing a new error up the stack. (i.e. TRIED EVERYTHING BUT STILL SVN)
(hunt and peck for the "outdated diff" so GitHub will let you respond)
.bind(this) here too?
I think $pvalue should be $predicate
It might be a good idea to use `DIRECTORY_SEPARATOR` here, which will contain `\` on Windows.
Just before this line, I've forgot the following

$nameOrAlias = $this->$this->canonicalizeName($nameOrAlias);
I mean: 

- import `Zend\Json\Json` instead of `Zend\Json\Decoder`
- Use `Json::decode()` instead of `Decoder::decode()`

In other words, continue with automated decoding, just change the mechanism. :)
Why are the above lines necessary?
Unfortunately you can't use the shorthand ternary like this, as isset() returns a boolean. :-(
And use a dataProvider with each test when you do so.
Yes, but the file isn't.
No, only empty
Please revert that.
SQL statements embedded in code are notoriously long-term bug farms; there's no forced maintenance of them if the model changes.

And yeah, you should be able to write a LINQ equivalent of what you have here.  I could probably help on this later.
Ah, that's an even better idea.
If you have two documents open, each with a different zoom setting, the cursor doesn't get updated if you switch to another document. You probably need an event listener somewhere for PintaCore.Workspace.ActiveDocumentChanged
Ok, didn't know that, this is how PHPStorm accepts it at least, never tried the other way as inline @\var is not documented on phpDoc site, and the block one documentes ´´´/** @var Type */´´´, and since param also have this order I assumed this was most correct.

So Eclipse / NetBeans does not accept this way?
two empty lines before class def
fix indentation: align this '}' in the same column as the opening '{'
Actually this should be find.
Docstrings should be imperative.
I do see them.
Pete, I think you're looking at the old code base, although the new code 
base may contain the same code. :-)

On 03/19/2012 07:49 AM, Sherif Makary wrote:
>> +	
>> +	/**
>> +	 *<p>
>> +	 * sample Secured ejb method using security annotations
>> +	 *</p>
>> +	 *
>> +	 */	
>> +	
>> +	@Override
>> +	@RolesAllowed({"gooduser"})
>> +	public String getSecurityInfo()
>> +	   {
>> +		//Session context injected using the resource annotation
>> +		principal = ctx.getCallerPrincipal();
>> +		
>> +   		return principal.toString();
> Yes, I did, and I sent few emails about this, and I haven't changed anything since then, not sure why you don't see the new branches.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/131/files#r573557
Docstring rather than comment?
the has to be a space between : and '
I dont see this used anywhere so you can remove it
It does, but only if you're using `staticfiles` instead of the media directory, which Mozillians isn't. In the future you can just use the form media for `browserid_form` to include both the JS and the shim.
CSS should be in a `.css` file, and does this really need two blank lines and a third with 4 spaces on it? It looks like the script is immediately going to populate this with content, so it seems like it could just be `<pre ...></pre>`.
It's an easy way to change the active link in the menu using the line
above it. But feel free to do that anyway that doesn't rely on the
view setting it.
Interesting, I got the sense that the preference was for using the events hash, which I find nice and clear and un-insane. I don't really have enough backbone experience to know if one way is really preferable to the other though in the long run.
Sure can! Thanks Rick
As all those seem to be constant you should probably define them as const outside of this function and not set them to NULL and then immediately set them to their const value again.
The difference is that we don't have show and override parameters code for hosts-group yet.
1. in the link_to_remove_puppetclass host shoud be renamed to obj (as it is a host or a host-group). code is fine, name is wrong.
2. in the link_to_add_puppetclass it is nil for host-group, code is ok, at least until we add override params to the host-group.
I'm not sure how to to exclude changes specific to my own fork. Needless to say the version change is not part of this request.
Use ActiveSupport for this: `"day".pluralize(d)`
Either from query string, or data-id from the problemBag.
I need comments about this code.
Since we have this in version control, let's make sure there aren't any comments.
MIME types are required to have a slash (both the "type" and "subtype" parts are mandatory, and a slash separates them. - see http://tools.ietf.org/html/rfc2045#section-5.1 for the details.) However, we just represent them as Strings so it's technically possible for a slash-less value to sneak in through a programming mistake.  I can implement a check for it if you think it's necessary.
лучше auto
и не надо в функциях классы объявлять. как это читать-то?
i am imagining this is probably the change that made the biggest difference in your diff.
I can't think of a better way than failing pretty loudly like this. The error that is thrown here might be too cryptic, though. Can you throw something like a `new Error('Could not find storage back-end....')` rather than the 'requires' error that would be thrown otherwise?
Might be worth adding here who can create a comment (all logged in users who can see the content).
/api/config/:tenantId would make more sense as an endpoint

Then tenants can just have /api/config to get the config of the current tenant.
I've added a comment here explaining why only id and created comes back.
Since the login strategies are now retrieved together with the full config this test is no longer needed.
Fair enough. I would still prefer to be consistent though. We should switch `_.isArray` to `Array.isArray` or use underscore here.
lastModified can go for now.
K. Thanks guys.
You may have visibility issues here. The problem is that the actor's thread may never see the updated value of ``scalaStep``, which is initialized *after* creating the ``ScalaStepIntoActor`` instance. You need to either declare it ``volatile``, or make this field a ``val``, e.g.:

```scala
object ScalaStepInto {
  def apply(): ScalaStep = {
    ...
    val actor = new ScalaStepIntoActor(scalaStackFrame.debugTarget, scalaStackFrame.thread, stepIntoRequest, stepOutRequest, scalaStackFrame.thread.getStackFrames.indexOf(scalaStackFrame), scalaStackFrame.stackFrame.location.lineNumber) {
      override val scalaStep: ScalaStepInto = new ScalaStepInto(this)
    }
    actor.start()
    actor.scalaStep
  }
}

private[command] abstract class ScalaStepIntoActor(...) {
  val scalaStep: ScalaStepInto
}
```
The `initialize` can safely be removed, it's been done in scala-refactoring for quite some time now.

About the complexity: `index.allSymbols` is cheap, when the index is created, the AST is traversed and two maps are created:

    def definitions: Map[Symbol, List[DefTree]]
    def references:  Map[Symbol, List[Tree]]

and `allSymbols` is then simply:

    def allSymbols = cus.flatMap(cu => cu.definitions.keys ++ cu.references.keys)

where `cus` has only one element in this case here. Does this ease your concerns? :-)
Great documentation! This should stand as an example for all of us.

Can I ask you just one more addition: could you add a note on thread-safety, i.e., are subclasses required to be thread-safe?
title -- the api accepts multiples, we just only give it one
Can we get away from using statics everywhere like this?

If we need to resolve something on the fly, we can use a ctor parameter Func<T> to acheive the equivalent behaviour.
Можно использовать [NSException raise: format:] - сгенерируется исключение
`NSAssert(mutatePercent > 100 || mutatePercent < 0)` :)
счетчик для for можно объявлять прямо в теле цикла
Style nit. (...*)foo with no space.
The code to set the menus and accelerators both need this setting, so I was setting setting.locale in the AppGetSettings() during startup. That code has been backed out, so look at the first commit in my pull request.
don't create mapping array on every method call
Can you remove any trailing whitespace throughout the PR?
We should note that these streams must all be instances of the same concrete class (similar to the note on `concat:`).
Can you please add spaces around `RACDisposable *`?
This should probably be checked at initialization time, so we don't have to do this everywhere.
Implementing deserialization isn't hard, it's just more effort than using `Data`.
I will remove the null check here.
Although I will say, to my mind, it's clearer to have a single function instead of duplicating lines, because then you can tell when / where identical computations are taking place...
fixed. It's actually the dipolar moments
Ok, units documented upstream.


On Sun, Dec 16, 2012 at 10:31 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> damn it. I fear I spent too much time with this, after some while you stop
> seeing things....
>
>
> On Sun, Dec 16, 2012 at 10:30 PM, Alexandre Gramfort <
> notifications@github.com> wrote:
>
>> In mne/viz.py:
>>
>> > @@ -1109,6 +1114,8 @@ def plot_image_epochs(epochs, picks, sigma=0.3, vmin=None,
>> >          (data.shape[1] == len(times))
>> >      show : bool
>> >          Show or not the figure at the end
>>
>> units is not documented :)
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2430689>.
>>
>>
>
>
Or, on second thought, how about adding a fun-head to set_public_key that does nothing if `Public_key =:= undefined`?
I prefer to put the `:class:...` part on a new line.
should still be default values :)
I don't think I understand what you mean? I don't really get what you mean by standard sizes. Is this the size=60 in the vertical form document ?

It will break the look **only where there is a size="N" specified** in an input, yes, that's the intend. The idea is that the length of such inputs carries sense. For example for credit card blocks, for a ZIP code, etc.
I don't think so.  There are already native default values in the rabbitmq client code.  See ConnectionFactory (http://www.rabbitmq.com/releases/rabbitmq-java-client/v2.7.1/rabbitmq-java-client-javadoc-2.7.1/).  The default broker then would be localhost.  I'd rather let the user of the extension define their own app params if they want to have those type of defaults.  Sound reasonable or am I crazy?
__cmp__ and __gt__ are uncovered.
Ну, энивей, я бы на твоем месте всегда показывал иконку, если опция в
настройках включена. Согласись, юзкейс с управлением через иконку
вполне имеет место быть.
ehh... I guess getters/setters can have a pass...
Si lo que está abajo queda fuera del proyecto, la forma de redactarlo puede estar algo confusa, que proponés?
Yeah, you're right.  I mistyped the doc.  I'll update.
please rename this to `readNotifications`

BTW, verb read : 

read read read


for example : this book has been read 100 times
need here compact('htmlOptions','name') //add name var., or maybe in view form (https://github.com/clevertech/YiiBooster/blob/master/views/fileupload/form.php#L10) use htmlOptions['name'], i mean pass name not as single var, but as htmlOptions, because if it will be a single var we can overrite users var named ```name``` when users view will be set in property. @tonydspaniard what do u think?
You could have used the `seq-max` here:
~~~clojure
(reduce seq-max (first a-seq) (rest a-seq))
~~~
I removed this line.

Now the application only take an environment. and now it's the responsabily to the application to load the conf.

Less code == Less bug
:+1: to going 10.7+
I think it would look slightly neater if these two inline comments lined up vertically.
That's correct and (I believe) this is how matplotlib behaved previously. transform=None was different than specifying nothing, which fell back to data coordinates.
```orientations``` is still mutable.
Should we remove 'esr'?
This test was failing in the past because of the lack of data, so we agreed that at that time we should only run it against prod, until the issue is fixed.
I just 'took' this code from @malini's pull on the old repo. Malini can you comment?
Just reordered penalty and routingPenalty
Hardcoded CMS logic on a class with a quite generic name. At the very least, explain in the class documentation what it does, and which assumptions it makes around the CMS markup, JavaScript etc.
Same deal here couldnt know this, and in this code here it looks unlogical, as the =='Users' is just a few lines after the !='Users' so it makes no sense in the CE code.
Below comment should have been on this. Should I rebase this edit out? It was my IDE being clever, but it was irrelevant and will conflict with the AJAX PR.
The assignment to ``$client`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Are you sure the class "CHttpCookie" actually exists, or did you maybe forget to add a USE statement?