labofsahil/github-event-dataset-2012 huggingface dataset:
done!
On Aug 20, 2012, at 8:51 AM, jao <notifications@github.com> wrote:

> In tests/features/create_prediction.feature:
> 
> > @@ -29,3 +29,18 @@ Feature: Create Predictions
> >          Examples:
> >          | url                | time_1  | time_2 | time_3 | data_input    | objective | prediction  |
> >          | s3://bigml-public/csv/iris.csv | 10      | 10     | 10     | {"petal length": 1} | 000004    | Iris-setosa |
> > +
> > +    Scenario: Successfully creating a prediction from a asynchronous uploaded file:
> > +        Given I create a data source uploading a "<data>" file in asynchronous mode
> > +        And I wait until the source has been created less than <time_1> secs
> > +        And I wait until the source is ready less than <time_2> secs
> > +        And I create a dataset
> > +        And I wait until the dataset is ready less than <time_3> secs
> > +        And I create a model
> > +        And I wait until the model is ready less than <time_4> secs
> > +        When I create a prediction for "<data_input>"
> > +        Then the prediction for "<objective>" is "<prediction>"
> > +
> > +        Examples:
> > +        | data                | time_1  | time_2 | time_3 | time_4 | data_input    | objective | prediction  |
> > +        | ../data/iris.csv | 10      | 10     | 10     | 10     | {"petal length": 1} | 000004    | Iris-setosa || time_3 |
> It would be could to have tests that use the locally generated predictor and compares its results with the remote ones.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
It's a first-time stable release: it's built off master, not a stable branch.

I wouldn't suggest touching the user's PGP setup, but verifying without touching it. If GPG really needs to keep keys somewhere, ~/.bitcoin/.gnupg or similar makes sense.

contrib/gitian-downloader contains PGP keys. There's also a git repository here on GitHub with signatures of multiple developers for most releases which would be better to use than the SHA256SUMS file (which can only have one signature).
All other strings are using __d, why not this one?
Instead of all these checks just make defaults array and merge passed options with defaults.

    $defaults = array('separator' => null);
    $options += $defaults;
Follow cake's coding conventions. There should be a space after "if"
Your right, corrected.
Yes, that's possible, but it would be a major simulation change. It's would
be part of a fundamental simulation expectation. I'm not saying we
shouldn't do it, I'm just saying we've never thought about it.


On Mon, Oct 29, 2012 at 7:48 PM, Paul Wilson <notifications@github.com>wrote:

> In src/Models/Facility/EnrichmentFacility/EnrichmentFacility.cpp:
>
> > +       throw CycOverrideException("Can't process a resource as a non-material");
> > +
> > +      mat_rsrc_ptr rsrc = dynamic_pointer_cast<Material>(prsrc);
> > +
> > +      LOG(LEV_DEBUG1, "EnrFac") << "Processing material: ";
> > +      rsrc->print();
> > +
> > +      Assays assays = getAssays(rsrc);
> > +      double product_qty = uranium_qty(rsrc);
> > +      remove_total += feed_qty(product_qty,assays);
> > +
> > +      if (remove_total < inventory_.quantity())
> > +        {
> > +          trans.approveTransfer();
> > +        }
> > +      // else
>
> Not sure what method(s) call this, so this may not make sense but.... we
> could catch the exception and handle it without crashing the simulation.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cycamore/pull/84/files#r1974091>.
>
>
since goes before or after the author, in the above classes it was different ?
Time.stub(:now => 2.days.ago)
Be aware that using autoformatting causes havoc in versioning. I can't tell witch lines were modified.
Oh yes, my bad. :/  You are correct.
I think we should consider removing the args/kw capability in `TryNext`.  It's been present, in its current form, since the dawn of time (or at least since <a href="https://github.com/ipython/ipython/blob/2f09c2ab3c6929cc9fa266fe666d312643264823/IPython/ipapi.py#L76">2f09c2a</a> which is the start of the history in git).
You might want to anonymize these email addresses, although its probably to late since its in the rev history anyway :-P
I think you need to check for NULL and return an error here.
This would skip e.g. `origin/HEAD` or any symrefs that you may have created. Is this on purpose?
It used to be next to the Zlib finding. It's earlier because I started earlier and I'd rather use that one. I'll change the order.
Gotcha. As an interim step couldn't we just do this in the sinatra route block (or whatever it's called)

```ruby

get '/some_messages/' do
  @messages = get_me_some_messages
  @channel = @message.first.channel if @messages.first
  
  # Do the rendering
end
```

Of course getting a proper ORM in place does solve this problem. So maybe we can wait on this.
The anchor is already added above, thus these webtrends parameters won't get passed in. (plus the php website doesn't need the anchor)

Recommend adding webtrends parameters in variable above. :D
again, looks like an extra tab indented here.
You will need to change the makefile to make it replace ``CURRENT_SOCORRO_REVISION`` with the actual revision number. I guess that would happen in the config file generated from this app? And same for the following ``CURRENT_BREAKPAD_REVISION``.
This is the pattern I've observed elsewhere. Since there tend to be side effects with a number of calls such as these, I figure it's safer to follow patterns than make assumptions.
Do these tests make any network requests? If so, they will fail in CI because we use [nose-blockage](http://pypi.python.org/pypi/nose-blockage)
When we want to remove the job, we would be unable to remove it based only on the score as there may be multiple jobs scheduled for the same time. Thus, we store the payload in the list with key "schedule:*timestamp*" and can remove it like so: `removed = Sidekiq.redis { |conn| conn.lrem("schedule:#{timestamp}", 0, payload) }`
Since we don't expect users to declare their own Setting types, or even instantiate their own Setting objects, having a public API for the default value is counter productive.
And yeah, delete_object looks like it needs a little 3-argument love.
Heroku is a Bronze sponsor, yes? Shouldn't there be an extra heading for them after silver, instead of bunched in with the PSF under Venue Sponsor?
What about Dir.glob("**/.graph") or something to make this nice and clean?
Not as much a fan of this but I can live with it.
it looks like you forgot to commit this class
This looks good but leads to rspec output that reads funny:

```
Interpol::EndpointDefinition
  returns query_params when initialized
  returns path_params when initialized
  returns an empty hash if not initialized with 'query_params'
  returns an empty hash if not initialized with 'path_params'
```

Maybe the doc strings could be revised so they say something like this?

``` ruby
it "initializes #{attr} to the provided value"
it "initializes #{attr} to an empty hash if no value is provided"
```
yep, removed
duplicated ``it`` there
This will only work for the ``Twig_ExistsLoaderInterface``, not with ``Twig_LoaderInterface``
there is a missing space after the `if` keyword.
you should simply use ``if`` as the previous block throws an exception
Because you can not guess the max length of a float... may be it should not return anything after all
Thanks, it went in there by mistake. Going to fix this tomorrow.
the comment is wrong :)
Style: I generally prefer `event_id: event.id` in the `where` clause.
s/Qitta/Qiita/ :)
We should be clear that you can only take the rate of monotonically increasing numbers. Also, should we handle these exceptional conditions more meaningfully or just return an empty list? Does it make sense to take down an entire check if one metric is incorrect?
I'd be tempted to do something like (untested, and I can never remember the semantics of ```for...break..else```):

```
def __init__(...):
    ....
    self._epsg = None
    """A place to store a previously determined epsg code."""

def as_wms_srs(self):
    if self._epsg is None:
        for epsg, proj in KNOWN_EPSG.iteritems():
            if proj == self:
                self._epsg = epsg
                break
         else:
              raise cartopy.exceptions.UnhandledEpsgError("Projection {} not '
                                                  'mapped to an epsg code.".format(self))
    return self._epsg

```


or even better:

```
EPSG_TO_CRS = KNOWN_EPSG
CRS_TO_EPSG = {value: key for key, value in EPSG_TO_CRS.iteritems}

def as_wms_srs(self):
    """Returns the epsg code of this crs, or raises a KeyError"""
    return CRS_TO_EPSG[self]
```

Obviously, you might like to handle exceptions a little nicer (or just return None?)...
I suppose I should have named this `profiling?` with a question mark.
Extra space after +=
I think it's fine to collapse this down to:
```
if (!access::can("view", $album)) {
  ...
}
```

because it's a documented property of can() that it requires the album to be loaded and will seek the nearest parent album (inclusive).  ORM::factory() always returns an object so the "!$album" test will never fail.
where("status='false'") 
милый синтаксис :D
MODULE.resolveModelAttribute(context, operation).asString();
The case check for 1.4 is not required at the moment, by this point we have exhausted the check for previous versions so we know it is 1.4 and can leave it to be handled by default.
doesn't the transformation target give you the version needed?
no need for quotes here, spacing inside parens
Never use `el`, use `element`. This is also never declared.
You can use `assert.includes` which throws much much descriptive error messages.
I was checking but I should to modify a lot of things in the library, and I think is out of the scope... We should focus on testing it in Brazil as soon it will be landed because there are a lot of issues with E164 there. 
Otherwise I agree that we should modify a lot of things for having it ready to include it in Gecko.
Do we need this block?
we shouldn't be able to be connected from the beginning on FTU, as the app only is launched once and doesn't load any saved values from settings.
To put it another way, I’m OK to use `window.alert()` as long as the related info is relevant for the user, i.e. properly localized + not a debug message.
`var dayNames = [ ... ]`
that also make sense. or if we are throwing mouse events away then we don't need to work on this anymore.
We are using among all of our BB this images files structure, for managing easily the ui in different sizes.
images/ui/ => always for images that are used as backgrounds, shadows, etc..
images/icons/ => Only for icons

Doing in that way, if we need to provide any other size of icons per dpi device, we can do easily without messing with a lot of images.
Just wondering, could we put the `shared` directory at the top-level instead? (i.e. at the same level as the `apps` directory)
Both should be in finally close! See Alogrithms.closeStream()
remove per my above comment
You might want to fully qualify this to /opt/puppet/bin/puppet, or use the symlink /usr/local/bin/puppet. q_puppet_symlinks_install=y will drop the symlink, but if /usr/local/bin isn't in $PATH this will fail.
Oops ! ;)
Nothing that matches ` #sendRequest` actually exists - this may be left over from early comm testing
Is there a `profile_count` option?  (Or should we use that as the option name instead, maybe?)
Is this supposed to be "PVR" or "MyPVR"?  Just making sure this isn't a typo.
I can´t find any specs for those lines (42-48). Am I missing anything?
should we make L2 and L1:
```scala
def L2Iterable[V] = minkowskiIterable[V](2.0)
```
maybe rename `withNS` to just `namespace`
On retrospect, I rather prefer to use ``history`` or ``log`` for this.
Does this `return` here mean that you never call `self.finish()`?
Instead of making a note here that we will forget, make this a TODO and open an issue for this on GitHub.
A bit more docs.
Remove this and use $message->publish(KunenaForum::DELETED) instead.
See KunenaUser::getLink() instead..
Should be in markdown instead of html
For full disclosure, this'll be the first time someone's tried it with an affiliated package... so you're sort of a guinea pig :) - let me know if anything doesn't seem to be working right.
socket module imported twice?
Yes, that's what we discussed; it just needs to be implemented :)

(I say this without looking at the latest pushes, so pardon me if I'm saying so too late)
That sounds like a good plan.  If it recurs, we can try to reliably reproduce it and fix it.
No idea either, that code was implemented by Saj.
I'll have a look.
Except that the state can change between when we check the current state and where we update the new state. (For example, if the relevant master *just* started up. In which case this code erroneously sets the master inactive)
# and unlinked after the block is executed
Pretty sure I can get rid of this, this was me just playing around and I was getting errors if the global file did not exist. I'll clean a lot of this up when I get some time later.
Oops, I didn't mean we need it to validate the cert. You're right, that's done by openssl. But in the event that it's not trusted yet, won't we need the chain to add the proper one to the trusted CA bundle before trying the request again?
Also maybe a note saying that this really shouldn't be used too often, especially in reusable libraries, it's more a temporary solution to use a bugfix when your application depends on it.
this can just be [commons-io "2.2"] because the group and artifact names are the same
I have no idea. I won't ever do that, so if you prefer I can change it to just

```coffeescript
(name = p.value; break) for p in ast.properties when p.name is "name"
```
For clarity, this is sending the time it took to run that function back to Matt's logging pixel. The time to add the fonts ranges from 10ms (desktop Chrome) to 200ms (iPhone 4S Safari).
I've yet to read @avdi's book, but someone introduced me to the technique below and I think it might be appropriate here.

```ruby
module Grocer
  CertificateExpiredError = Module.new
end
```

```ruby
rescue StandardError, Errno::EPIPE => e
  if e.class == OpenSSL::SSL::SSLError && e.message =~ /certificate expired/i
    $!.extend(CertificateExpiredError)
    raise
  end

  # ...
end
```

This way the details of the original exception are retained, but the error also matches as a `CertificateExpiredError`.
BUILD_UNIX_SOCKET instead?
This should probably have ifdefs for jansson and/or unixsock
I try to avoid massive indentations like this

In cases where one condition is simply one action, try breaking early. In this case, why not 'return value' instead?
You should document the return value. At first I thought it was an event propagation flag but it appears to be the final state of the button.
`resoved` -> `resolved`
If `selection` won't be a `nsISelectionPrivate` we won't add the selection's listener of course, because there is no selection that we can handle.
I was the one that added the `select` event, but doing that outside the `if` could bring to inconsistency – as I explained in the comment – that's  why I decided to move inside the block: so we don't have mix situation where the selection works on texarea but not on the document itself.

If the selection doesn't match this interface it's probably `null` as I added in the comment, therefore we don't need to do anything on this window.
"overlapping mappings" makes more sense I think
`api-utils/deprecate` should have a helper for this
This is breaking change that does not gives enough benefits to make it, also I'm not sold on idea of renaming type to topic. I can buy into additionally adding topic property to an event object here, but -1 on removing type.
I am calling the local version of setImplicitWaitTimeout - the local version will only set the implicit timeout if it is different than the current setting. This allows us to re-introduce the implicit timeout in configuration without changing code.
Hmm, what's the reason for creating the secret using uuid3? In my tests, uuid3 is deterministic (and thus trivial to regenerate) if you know the two components that went into it. My understanding of OAuth (which could be wrong) was that the key can be public but the secret must be private - but this means that anyone who knows a key and a project name can trivially recreate the secret. That seems like a bad thing.

Why not just use independent uuid4 values for both?
mind flipping the condition for easier understanding? It's always better to compare to true.
Chatted with unfocused about it and as he mentioned we can even safely make use of Components.Exception in our js modules. So we are good here.
no longer needs user
interesting choice of case here
move this into a createActivity function outside so you can reuse it for the non import stuff
rename to `best_warp_*`, maybe with a kwarg `greedy`
I think you should use <label> and <span> attribute rather than top bottom.
I'm not sure about your concern. Do you want to remove the additional `/sbin` and `/usr/sbin` in `search_paths` or just flip the order?

Solaris: Suddenly finding an executable in `/sbin` we formally expected not to find on the system at all seems a bit unlikely. If solaris has a binary in `/sbin` we can't work with, the fact should not put `:sunos` in the confine list.
I updated the error message. Does `Puppet::DSL::LogicError` make sens here?
There's still one call to `obfuscate` in this class - must not be tested?
rename `src/moment/moment.js` to `src/moment/moment-1.6.2.js` and change this to:

            "./moment": "./moment/moment-1.6.2",
You're right, I postponed that for when the simple case will be working… :)
`indexOf` would work too. They're identical. But perhaps `lastIndexOf` is most performant

```javascript
'string'.indexOf('s') === 'string'.lastIndexOf('s', 0)
// => true
```
sorry for that. but the real problem here is, that the method is static, so there is no $this in here.
Indeed, this should be $newUri… although, I don't like that name either ;)
Can't you just say $uri = new HttpUri($uri); ?
You must use a long argument name like `$event`

Vars with only one letter are reserved for loops and exceptions
sorry, i don't see no difference. the code is the same.
I had to try it out: https://gist.github.com/1855943

As expected, the hand-coded state machine outperforms the others by a large margin in the contrived `@invalid..............@keyframes` case, but surprisingly enough the lastIndex + substring approach wins when I run the benchmark without that test case included.
@jtdaugherty Why the increase from 16k to 64k?  Did you find that you were producing large SAML messages?

@pames What would you think of a realloc loop dynamically resizing up to CAS_MAX_RESPONSE_SIZE ?  We could start at (e.g.) 4k, resize to 64k if necessary, reducing memory overhead.  Given that this is an HTTP read, I don't think the performance hit of realloc would be noticed.
Rebase killed the comments but this was changed to reflect the actual name of the curated feed.
サルが九州弁！！
We will prepare the changes you request here shortly
You're missing a logged-in check here and for other methods. Either you need to add annotations or move those to another controller that extends LoggedInController.
Also you're missing checks that you're editing your own user (unless you're an admin).
And finally, `@Required` doesn't _do_ anything, so it might still be null: you need to figure it out with `validationFailed()` before using the `username` value.
This is wrong. The base query builder uses some fetch joins so the pagination will be wrong when using a naive LIMIT in the SQL query.
you will need to use the ORM Pagination tool to be able to paginate this query properly.
shouldn't be a space after the if (and a few more of those just below)
yes thats the Common API that is already merged.
It is when you're working alone. So for instance I might do this on a feature branch that I'm developing that I know no one is also working on. But for this project it might be good to think of this as something you might be sharing with others. That will give you some better real world practice.
spaces after :
If you use the -with-tools BOM from http://www.jboss.org/jdf/stack/jboss-bom/jboss-javaee-6.0-with-tools/ you can then omit the version here.
Got it, thanks for the clarification.

On Sat, Apr 7, 2012 at 1:15 AM, Alon Zakai <
reply@reply.github.com
> wrote:

> > @@ -36,6 +36,15 @@ var LibraryGLUT = {
> >      },
> >
> >      onMousemove: function(event) {
> > +      /* Pierre: Send motion event only if the motion changed, prevents
> > +       * spamming our app with uncessary callback call. It does happen
> in
> > +       * Chrome on Windows.
> > +       */
> > +      var newX = event['clientX'] - Module['canvas'].offsetLeft;
> > +      var newY = event['clientY'] - Module['canvas'].offsetTop;
> > +      if (newX == GLUT['lastX'] && newY == GLUT['lastY'])
>
> Note that accessing as strings and not as `GLUT.lastX` is not necessary
> here. Strings are only necessary when connecting between code compiled with
> closure and code not compiled with closure. So `event` comes from the
> browser, which is not compiled with closure, and needs strings, but
> GLUT.lastX is entirely in closure compiled code.
>
> I'll fix this after I merge, just mentioning this here for future stuff.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kripken/emscripten/pull/349/files#r655740
>
Yes, they are new properties.  And you're right, using expando properties is probably a better idea.  I'll do that.
Remind me to make a dev milestone for next quarter where we remove all these nasty fixtures and use helper methods instead.
I'd prefer to make it clear that --firefoxpath is optional or in the majority of cases not required. (thinking of beginner users here)
Your changes to pid handling should not linked to opus changes, right?
Could you update this PR to not include submodule changes?
む．本当?
db/schema.rb 人によって違う可能性があるほうがやばいので **ignore してはいけない** と思ってる.


よく議論になるけど（たとえば） http://stackoverflow.com/questions/6520017/is-a-good-idea-to-put-db-schema-rb-to-gitignore-list
The correct plural form of "path" is "paths".
of course we rarely change these settings in conf.
Actually your patch moved m_bIsAllocated = false to Deinitialize(). That's why I'm asking. Perhaps it should be just moved back to Close()?
We should probably fill this in with appropriate details - system name and timestamps in this case.
Excellent point. Thanks (fixing)
what happens if the user closes their browser while this is going on? how is session handled in drupal? batches an continue, but I'm not sure what happens to sessions. this makes me pretty nervous.
I don't think it's used, You can keep it in for now since we require a major rework anyway.
Uncertainty should be a class like `NDStandardDeviationError` in the `NDError` framework (discussion of renaming, after we make things consistent).
Flex library no longer needed by compiler due to removal of yywrap.
Will this be fixed?
ha yea my guess is typo, ill change it next time im in there
It will @tobbi , but it will always work, even when logout not visible, that's why we decided to change it
One declaration per line is preferred (because it avoids misplacing *s, and to make diffs easier to read).
It's probably worth adding that the uri is used first to make sure that old files can still be served if the storage back-end is changed at some point.
Not sure if RestUtil is the right place to put the timeout, but I can see why it's here.
Making this change has uncovered a bug in our pubsub code. Every time we publish an event, all pusub listeners will be triggered, even the ones that listen to a different event.
Why the upper case style? I think this should be simply ``threadName``
in background, only added: function checkNotification(service)
Use ObjectGenerator.GetGenerator().location(MCLocation) instead of building the array yourself.
Actually, the more I look at it, the less convinced I am that it is going to do what I want it to.  Once the first replacement is made, any subsequent replacements would be in a different starting position.  so if the preg_match_all identified a line feed at 4 and 200, once I strip the one at position 4, the next one is now at position 199.  Does that sound right, or am I over-thinking this?
I am adding extra line, to make sure. But imo, if they dont have exec permission, then `set_realpath` was useless and nothing than just checking whether the supplied argument was either a valid filepath or dirpath.

So the improvement on this pull, basically only to make `set_realpath` works inheren with `realpath`, means its not adding additional directory separator if the supplied argument was a valid filepath (as you may already aware).
capacity можно изменить но массив не может иметь отрицательную размерность
can't you just add this to the .gemspec dependencies?
This is another place that the app name should be parameterized as tracked in issue #51.
There is no need to check if RTMPStream is usable here since there are only RTMP streams available. This check is only needed when there are multiple streaming technologies mixed and the plugin can provide one without the other.
Fixed in 1de7843eb88d5758e2fbeb249b2a376c624c21d8
Rename this to `+flatten:`?
@Coneko Could you create an issue to discuss this instead of doing it here?
$field_value is not returned, correct to $val .
I have been unable to find any reference to how the exit function works in MCL. The documentation doesn't mention it at all.
You're right ! I was reading the page numbers all wrong
should the scaling be mentioned in the doscstring?
New lines in a paragraph need a leading space to render correctly.
This code is in two spots
Use a fat arrow here also.
Is that part of the standards? I thought operators should always be surrounded by spaces
This must be reverted, because it is used in the next code block (and this code is included there because of the `...`).

Or, maybe better, place this line in the next code block. I think that's the best option.
Extract this `if` into a method, and use `&&` and `!` instead of `and` or `not`.
This line is missing in the latest version, causing `uploaded_file` always nil.
Is this intended?
Removed.  Bring your own system and fire up an AMQPActor.
Ну и что?

    auto index = ..currentIndex ();
    index = index.sibling (index.row (), 0);
Если ты почитаешь код connect'а и, в частности, функции normalizedSignature
(или как-то так), то увидишь, что const T& она приводит к T.
Ты, вероятно, не так задал вопрос.
I should probably update the doc in success? and error? as well.
Good point.  Don't know why I didn't notice that.  I'll change it.
Why moving from constant to regular string ?
A translatable="false" string should not be here.
Did a quick test with 30 map files - gives 180-200 millis for the loop over all 30 maps and no noticeable delay on my HTC Incredible S (1GHz CPU) - so I would say it is OK having in mind that it presents a better view to the user (no unusable maps to select).
Maybe remove 'only' - since this would now support both repositories.
commented out, do we need?
How about I just delete the file? :)
I think we should take off the _ from here and the next two examples. My reasoning is that the interface of these types do not guarantee they will evaluate to message IDs, so we shouldn't pass them just in case. 

In particular if we want to localize the exceptions we should do it in their __init__ function, when we have access to the arguments.
You could also map over the hash-map, using a helper function like this:
~~~clojure
(fn [[key value]] (repeat value key))
~~~
Again, I was thinking of embedded mode. Maybe "interoperability with other HotRod clients" would have made it clearer for me, but this is good enough :)
the package name is wrong here
If the user sets a absolute filepath, the HTMLEmbed is not returned.  As for the separate PR< I think that is overkill.  This is really minimally invasive.  What is returned looks like a string (inherits from string) and only ipython will care about doing something with the _repr_html_
Cut and paste error. Thanks for pointing out.  I'll fix it as soon as I can.
k0s <reply@reply.github.com> schrieb:

>> @@ -132,29 +129,34 @@ def create(cls, results=None,
>jsbridge_timeout=JSBRIDGE_TIMEOUT, handlers=(),
>>          return cls(runner, jsbridge_port, results=results,
>>                     jsbridge_timeout=jsbridge_timeout,
>handlers=handlers)
>>  
>> -    def __init__(self, runner, jsbridge_port, results=None,
>> -                 jsbridge_timeout=JSBRIDGE_TIMEOUT, handlers=()):
>> +    def __init__(self, runner, jsbridge_port,
>> +                 handlers=(),
>> +                 jsbridge_timeout=JSBRIDGE_TIMEOUT,
>> +                 results=None,
>> +                 ):
>
>AFAIK the only consumer of mozmill is mozmill-automation/mozmill-ci,
>but reordering of the arguments is an API change.  We shouldn't make
>API changes just for the sake of readability.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/mozautomation/mozmill/pull/54/files#r1027370

We haven't released mozmill 2 yet and are still in beta. Is that really that important? I agree for releases. 
-- 
Henrik Skupin
Software Engineer in Test 
Mozilla Corporation
Looks good - however can you add a reason for the xfail :)
missed the `audioTag` in this and the other asserts
Look, I'm 16, and I translated this pretty quickly. Seeing as this is the finished one, why not work on this one then? You would have less work.
It should in anycase be `boolean` the shortcuts dosent make sense as there isnt a short version for all types like `float`
`? true : false;` is redundant in this case, so it is not needed.
I think "keyboard" instead of "eventKey" would be a better name for the option.
You are right - missed that one.
`==` -> `===` here and throughout your changes.
Why is the line deleted again?
the content of the edit_question_set.jsp and edit_questionSet.jsp files 
are the same. we just changed the file's name to figure out "name mixing 
'_' delimitation with camel case problem".


            --Sara,Andy



于 2012/7/16 18:40, Samuel Kong 写道:
>> @@ -0,0 +1,56 @@
> What the difference between this file and edit_questionSet.jsp?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/samuelkong/plugins-cn/pull/6/files#r1167792
>
something is still weird with spaces ... mixture of tabs and whitespaces perhaps?
please use the CMath::qsort_index function here (at least inside this function)
in case of landscape image there is too much space below image and link, can it go right after with float & clear ?
This might be a little clearer as `\n\t` at the end of each string.

Also, shouldn't "dumpfile" be gone from that list?  It might be easier to maintain that file with a single list of `{ command, description, func }` triples that can be shared between the main loop and the usage function.
Likewise, this seems fine to get started with.  What we really want here is to look at the avail list and figure out the point in the file where the in-use blocks with larger addresses take up more space than the available blocks with smaller addresses.  It's only ever going to be approximate, of course, because the available blocks will usually be fragmented.
`@test` is missing.
The gitingore is just for project specific files.

.DS_Store, destop.ini and files like this have to be in the .gitignore_global
https://help.github.com/articles/ignoring-files

@ccandreva can you update this?
I don't think we want to run checks which have for example been scheduled to run 3 hours ago, but for some reason haven't run yet. This means we need some kind of `maxAge` threshold.

Ideally this threshold would take check interval in affect, but this would add extra complexity since the interval can change.
was'nt -> wasn't

And why the deepEqual?
It would be better to test `(not (empty? ...))` because `count` is can be costly.
If we'd make this protected instead of private we wouldn't have to pass the cursor to fetchCount(), fetchObject() and freeResult(). Not sure if there's a benefit to this approach I'm overlooking.
Thanks, I'll correct the comment.

It's not that what's in the manual doesn't apply, I think the original situation arose out of a misunderstanding of the docs.
An order clause will have no effect when applied to one of the clauses, but it works just fine when applied to the entire result set, ie after any sub-clauses have been evaluated.  It has always been like this.
`path+=/usr/textbin`
Aha. Yes, this is reasonable if you have button on every page. But because we will move this to login page, we do not need this anymore.
But it is good for now.
But here `prop` is good.

Why `()` around `checkbox`?
I was thinking about the same but that would, IMO, ask for a bigger rewrite anyway. One Pkg::SourceSaveAll() rules them all.
The feature branch for AutoNSubstitute is based on the branch of this pull request, thus containing the changes introduced here.
What we would really need here is a new instance of a `NSubstituteMethodQuery` type.
$localModel['model']->get($this->getProperty()->getName());
Could we put the upload XSLT options in a fieldset?
and need initialize
The whitespace here is messed up.
Is there a mapping available between these mesh terms and the mesh identifiers/URIs?
ahah ok ! just wondering if i were crazy of seeing a new constant without using it :)
It doesn't look necessary to instantiate a logger here.
For RHEL5 no way to use ipset , for RHEL6 , ipset is in the spec
``
/** 
 *
 */
``
html => li ; HTML => List
@marcw you should keep the upper bound. Having unbound constraint forbids you to release a version (as tags cannot be changed if 2.2 breaks BC)
This is a bug, thanks for catching it.
the naming looks weird. This function does not filter the address but matches the address against the whitelist
I didn't have any problem. I fixed that, please check if it is OK now.
"psf" seems like too general a name.
Thanks for taking care of that, and sorry for the simultaneous edit!  Fortunately we didn't try to address the same exact thing...
getGal-->getPSF
It doesn't matter much, I suppose, but this gives PSF ellipticity = 0.4 at the edges of the image.  This is rather large compared to real images.  Did you have a particular reason to choose this relatively large value?  Would it be worthwhile to use something more realistic?
I have the same concern about this warning as I mentioned above...
While the above code works, it could be improved by using the `days` and `seconds` units that are stored internally in `timedelta` objects.
E.g., `days_passed = uptime.days`

Read here for more information: http://docs.python.org/library/datetime.html#datetime.timedelta
All variable definitions needs to be placed at the top of the template, this makes templates more beauty :)
Hi Alex. The inboundPorts setting is not working for me at all. that is why I manually add a firewall rule:
l.exec(asList("iptables -I INPUT -p tcp --dport 3306 -j ACCEPT"))

I looked at:
CarrenzaLocationLiveTest
AwsEc2LocationWindowsLiveTest
In both test the inboudPorts is set explicitly.. and there is no prefix I see. So perhaps I'm doing it wrong and that is why the firewall wasn't opened. But.. when I look in the jclouds logging.. I see that an machine is going to be started with the desired ports.. the problem is that the port is not opened.. no matter what the logging says.
astonishing that these were missing!  great to have them.

do they belong here, or in WebAppService interface, or JavaWAS ?
(suppose it doesn't matter too much...)
You can run the `buildInfo` command against the server:

```
> db.runCommand({buildInfo:1}).version
2.1.0
```

Alternatively, it might be available via the wire protocol; however, I don't think there'd be a reliable way to surface that through the extension since our connected hosts might not all share the same version.
I'll fix it, ignore my other comment.
Preventing empty baskets is done at the very end, when we call the submit method.
Why the frequency change?
What are the rules on how this is "no supported"? Is the function outright missing, or is it based on a PHP setting? 

It would be a good idea to use `readfile()` if possible as it handles file chunking, making it more memory efficient.

Also of course `header('X-Sendfile: ' . $file);` is way more efficient than either if `mod_proxy` is enabled. I love fallbacks! :)
As long as you're doing this, might as well make it something like:

std::string filename = basename + "D" + tempDepth + "NT" + tempNTrees;
if( !itksys::SystemTools::FileExists(filename.c_str() )
  {
  filename += ".gz";
  }

This would make it backwards compatible with the uncompressed file.
is_floaty is used to prevent floaty_process() being called multiple times while the mob is still "floating"
Also you need to check here if we have PM open with the player. This should always return false on that occasion.
ic, this was a spec that was broken so I was just trying to get it passing before I submitted the PR.  I think @garylin is aware of the  inconsistency.
you can simplify with
```ruby
opts.merge!(:filter => ["in_flight", "in_stock"] )
```

here making https://github.com/demandchain/galaxy-client/blob/master/lib/galaxy/deal.rb#L21 unnecessary, and this also more efficient
А чем iterator() не угодил у List?
I do this a lot, and am doing it, and I have had no problems so far.
please remove unused code.
Oh, right. I think that's actually funfactory, but it's just console noise. People can see where to turn it off in the error message. This makes it sound required, and I like fewer required steps in READMEs.
I think rather than saying "... the Var simply behaves like a global binding to that value" I would use the preferred term "root binding" and say something like:

"... the Var refers to the root binding value if accessed from another thread."
Also link to the OME model documentation here?
no need to use `Array.wrap`
I think basic Producer from ch2 is not doing confirm selects. If your intention was to implement this https://github.com/rabbitinaction/sourcecode/blob/master/python/chapter-2/hello_world_producer_pubconfirm.py then you might want to rename the class/file
I think the commented lines should either be uncommented or removed.
On Sun, Oct 14, 2012 at 12:25:50PM -0700, Olivier Grisel wrote:
> It used to be the case that score was not part of the required API: if you just
> implement your own fit / predict estimator you might have expected to be able
> to use the grid search tools on it.

In my mind, it still is the case.
Maybe use a list environment?
I think the code would be clearer, though, if in the loop, you would first allocate, then perform work on the new array, instead of reusing `X_step` for that.
I was wondering about that.
Usually we don't try that. And the reference implementation (I linked to sminchisescu but the code is actually from Christoph Lampert) does it like I do it.

Btw, Christoph has sse optimized vectorized code that we could include if we wanted. Didn't think that was necessary for the moment.
The problem here is that the `Bulb` class does not know about the actual `Switch` instance (which has the state). So you try to access the `state` on the class which does not have such a method. Remember that there's a difference between class and instance level methods. Most of the time you will want to call methods on the actual instances, not the class.

So I guess it's about time to figure out how `Lamp`, `Switch` and `Bulb` should be weird up. There's no "right" answer about that. It's what you have to decide or "design" as a programmer. So lean back and think about how real lamps, switches and bulbs work and what would make sense in your context. Who knows what (ie. what instance variables are there)? And who can do what (ie. what methods do your classes have)?

How about something like this:

A lamp knows both about a switch and a bulb (because it is assembled of these parts) and it can create these parts. It has a method to flip the switch which will just flip the switch no matter what its state was. It also has a method to query the state. And it can be shaken which then will break the bulb.

A switch knows about a bulb and its own state. But it can not create it but it needs to be passed a bulb when created. A switch also has a state (on and off). Whenever it is flipped it will set the current state to the bulb.

A bulb does not know about anything else but its own state. But it has methods for turning it "on", turning it "off" and for breaking it. E.g.

```ruby
class Lamp
  def initialize
    @bulb = Bulb.new
    @switch = Switch.new(bulb)
  end

  def flip_switch
    @switch.flip
  end
end

class Switch
   def initialize(bulb)
     @bulb = bulb
    end
 
    # what would go here?
end

class Bulb
  def state
    @state ||= :off # what do you think will this line do?
  end

  def on
    @state = :on
  end

  def off
    @state = :off
  end

  def break
    @state = :broken
   end
end
```
If this doesn't happen in Chrome, suggest filing a bug.
so, maybe we should move travis/testing to travis/support?
See above, use `@expect` for this.
I don't think so as it wount be parsed by python, we need to pass the url from the view and we can only use reverse with the survey's instance so I suggest we add a url to each gps point.
this call should be removed as it is forbidden on prototyped array nodes in 2.1 (and useless in 2.0)
psr?
Throwing exception, if something went wrong
What's the reason for switching from NUnit to XUnit?
You forgot the backslash... I would change it to something like:
                        <xsl:with-param name="path" select="translate($outputFilePath, '\$', '/:')"/>
Return type from rowCapacity() should be a rowidx_t
I think it should be a superset. You don't want to have to recreate the hash table every time you load a dataset containing a hash table from the disk.

I would take the current boolean group-follows flag, and extend it so it is a count of the number of blanks to follow.  (Using 255 as an escape for >=255 blanks).
Add BigHeapletBase * next = getNext(finger) and use here and in the else
Can we please keep it pep8?
@peterbe I wouldn't be able to create anything in /usr/local as a regular user without sudo...
Don't you want to test that your plot data is well created? (I'm just asking, if you consider it's trivial enough not to have a test for it, that's fine. )
You'd still need to insert your hack with `form_selection` in there.
I don't think this is good default behaviour. 

@steveandroulakis What do you think?
Пожалуй даже, важнее чтобы было не короче, а "красивее", но это бывает слишком субъективно. И всё же некоторые иногда недовольны, когда проскальзывает что-то несимпотишное или явно лишнее. Не обязательно в этом месте, в этом методе, бывают места и пострашнее, в том числе и у нас ( ._.)\
а чому саме behat? фікстури підходять для всього
By the way, this `discard_cache` attribute seems far from its family. Can't we move it to contrib?
I would say by passing corresponding widget options, cause reading this left me under impression that I could:

```js
mywidget.click = funciton() { } 
```
Yeah, I think Module#name is exactly  so as you said.. Anyway, thanks for picking this issue! I'm looking forward to your commit. :) Yay!!
indentation fail.  should set your editor to expand tabs.
Okay, I understand the naming scheme here. the currencies are named Currency, and then when you create the drop down objects those are named "Currencies".

Since these are going to be an enumerated int list in the database, I'd suggest storing the currencies in an array for ease of use without a long block of else-ifs.
The comment is mentioning connection string and it's not considered in the code
String is now a dependency of aria.core.Log
Remove this one. It is provider by the base page.
WHATS UP
Should do nil checking here before calling to_i on flatten[0]
if ret or ret.length < 4
I think this is now 0.16?
s/mainly//
This is a breaking change in a popular class.  Give an example of how users will have to change their code like done in other places in CHANGES.me.
this kind of test make impossible to use the function with other iterables than list.

I think it would be better to try to doesn't test the type here, to execute the code, and to "try ... except ..." the part which can fail.
Remove parenthetical. The average user is unlikely to know who Blain and Steve are. 

Alternatively, include your cell number so they can tell you in person.
Agreed, will include this change in a future PR.
has been moved?
This should be "RGVjb2Rpbmcgc3VjY2Vzc2Z1bCE=", not "+RGVjb2Rpbmcgc3VjY2Vzc2Z1bCE=". The plus sign is throwing off the base64 decoding. I tested a couple other decoders and none of them recognize the + at the beginning.
Спасибо за ссылку. В 5том задании документацию исправлю.
No more triple equal?
You should just remove it then
You need to update the artifactId as well. The point is that you want to make base-mantychore the parent. Just changing the relative path isn't enough.
You can two these two in one line.
It doesn't matter a whole lot here, because there's nothing after the for loop in the enclosing scope, but it would be cleaner to declare both `currIndex` and `nextIndex` in the first part of the for loop. If there were more in the scope after the for loop, then it would _really_ be a good idea, because then it avoids having the variables exist for longer than they need to.
This is also there? I'm confused.
inconsistent with Clock. I'd just make a see link to Clock class and document it there to avoid redundancy.
Let's start with a header that doesn't tie us to a future version number:

e.g.: Changes since 0.2.6+1

When we update the version locally and do an upload to pub, we could indicate that these changes are bundled in version 0.2.7 or 0.3.0

Also - do we have an agreement on the format and name of this file with pub so that it becomes visible there?
You should just do 1 acorn_crush sfx call, after this if statement block
I assume we don't need this `System.err.println()`?
This readonly stuff is only useful for form-based apps. I wouldn't include it in the generic startapp.
Got it. This is a private member visible only to the class members; it won't be included into any autogenerated documentation. Adding a standard header here would be an overkill.
I chatted some with @ogail about the intent of the IXmlSerializer, and he said that it should have *instance* methods, not static. Hopefully, he can explain more about the intent and verify if this change is correct, or how to make it correct.
I agree with a slightly stricter version of what you sugguest:

> Having cascading checks in one assert is not good practice

That is, something like this, where one clause if predicated on another, is bad:

    assertTrue(!is_null($foo) && !is_null($foo->getFoo2()))

The piece of code in question here is checking for one concept, nullable-String, which has an **or** relation (null or string).  It seems reasonable to me, as a single concept. I also was unable to figure out how to refactor into separate asserts. 

If you have a suggestion for how to separate into two (or more) asserts, I'd be happy to hear it, but I think that would only work for an **and** check.
I don't think that this is checking two conditions.
They are required for ```#define_method```:

> implicit argument passing of super from method defined by define_method() is not supported. Specify all arguments explicitly.
you should use ``count()`` instead of ``sizeof()`` which is only an alias for count
не понял
I moved this out to an ImporResult object.  I'd be interested on your take of my approach here.  I couldn't decide if you'd love it or hate it...  :)
Upgrade to tabs. Sounds like evolution to me.
Can combine this line and the previous via chaining the `.off` and `.on`
I use `@@@` comments rather than `TODO`. No particular reason, but if we stay consistent it makes it easier to search for these things.
If one of the values in the date range filters is a star (*), another solr call is needed to calculate the max or min date. This is done by sorting the results.
Created ticket for this here: https://tickets.openmrs.org/browse/HLQRY-41
This is worse than no comment, imho