labofsahil/github-event-dataset-2012 huggingface dataset:
@chdemars : Do you keep a blog? I think writing an article about matplotlib & mapnik would be a massive hit. If not, you could always create a small git repo with the contents, maybe even use github's free hosting...
If you want to discuss these options with me, feel free to email me personally.
Maybe this stuff should be refactored into a internal function (i.e., one that has a name that starts with an underscore) so that it is not repeated twice?
Either a comment, or replace

`for c in self._cells` -> `for c in _self.cells.keys()`

Which do you think is better?
PEP8: please use parentheses, not backslash, for line continuation.
This fixes all the counting problems
Yeah loads more readable from the test side.
suggestion -- change the method name to <code>select_random_featured_version()</code>
the example just uses a key with a string which is the url
Not sure what you are saying, but what I meant was maybe not clear. If the constants were on the interface, it would prevent it from being implemented by libraries that also define the same constants (unless they break BC, which isn't nice for adoption of the PSR). Now that the constants are split off, it's possible to implement the LoggerInterface anywhere. We need to compromise and take the existing ecosystem into account if we are to create successful PSRs.
Add `size=16` to these boxes.
Added issue #105 for this todo.
@apex13 Can we remove the sitespages styles we don't really use that anymore
Always assign a value on the same line for readability.
Removing the `bindCleaner` and `unbindCleaner` from this class caused the following build issue. It looks like these methods just need to be added to `SakaiDocPagePublishOperation`.

```
[ERROR] @Reference: Missing method bindCleaner for reference moveCleaners at Java annotations in org.sakaiproject.nakamura.resource.lite.servlet.post.operations.SakaiDocPagePublishOperation:69
[ERROR] @Reference: Missing method unbindCleaner for reference moveCleaners at Java annotations in org.sakaiproject.nakamura.resource.lite.servlet.post.operations.SakaiDocPagePublishOperation:69
[ERROR] Failed to execute goal org.apache.felix:maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) on project org.sakaiproject.nakamura.resource: SCR Descriptor parsing had failures (see log) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.felix:maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) on project org.sakaiproject.nakamura.resource: SCR Descriptor parsing had failures (see log)
```
index.html already loads these scripts. Why are they in the template as well?
We use BSD/Allman bracketing so the opening curly-brace should be on a new line .. https://wiki.ushahidi.com/display/WIKI/Coding+Style+Guide
will this break things for existing devs?
There's a comment above this code that needs to change, the eviction server no longer walks the file to sync it.
Slug staat niet in het woordenboek
Any chance we can not have markup in php files?
done.  First line of the file will be the version.  Version==1 includes a provision for a variable number of header lines to demonstrate the feature.
Loading the environment this way (i.e. via JSON) is a bit messy to me.  My typical way for going about adding these items is to look at knife and see how Opscode is doing it.  I'll then boil it down to the basics, since that's all we need in our `load_` methods.
- Could you add a ``@return`` annotation? Please also check line 236.
- Is it possible to add a ``@param`` annotation for parameter ``$path`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? I also found this on lines 221, and 236.
Yes, I fixed this already.
JCryptPasswordSimple::create isn't a static method so you shouldn't be calling it as one.  Instead, you want to invoke the method on the supplied dependency.  Also, you shouldn't hard code it to JCryptPassword::JOOMLA.  The preferred hash type should either be adding to JCryptPassword or set as a configuration value in JUser.  The default for the platform should probably be blowfish and if other applications really want to keep using an outdated hashing scheme they can choose to.  The CMS should also consider switching to blowfish as well.  The way the library works makes this very easy to do (i.e. it can verify passwords in the old format but create new hashes in a different format).
Keep sprintf but delete remove JText
This implementation forces single events to be submitted. I believe other SDKs allow *multiple* events to be submitted using their `submit` methods. I would check to make sure the semantics are consistent here between SDKs.

Also, I don't recommend using a PrintStream here. It swallows IOExceptions. `OutputStream.write` should work just fine.
just noticed this, we shouldn't ever do this I dont wan't to buffer data and this will not support streams etc
Why not `BrowserIDVerifyView`?
Write Google with upper case first letter.
Sorry, I didn't notice your last comment :-)
Constant strings, use `'`.

Why you have second argument `"PiplMesh"`? Is is needed?

Write out all argument of callback function.

Space after `)`.
*confirming your e-mail* -> *confirming your e-mail address*
You have to break this. In general, you can move common things somewhere else. But in your case you can maybe have a list of signs in models as tuple of tuples. ;-) And then use that for creating a dict in `horoscope.py`.
I just tried it and it works for me?

```
def default_panels():
    return {panel.get_name(): Panel() for panel in piplmesh_panels.panels_pool.get_all_panels()}
```

I removed `reset_panels` and `get_all_panels` methods and using `self.request.user.get_panels` instead of `self.request.user.get_all_panels` in view.
Yes, I would set only this. But also here you have the same issue, maybe somebody already set it to `False`.

What I would do is check those conditions above in MongoDB, so make an atomic query which sets `is_online` to `False`, if `is_online` is `True`, `connections` is `[]` and `connection_last_unsubscribe` is old enough. If atomic query succeeds, you send an update to users.

If not, you try another atomic query, bellow.
i don't remember as it was a while ago :-/ at that time i didnt fully understand how views work so i could have made some stupid mistake... but isn't this code i wrote ok? :( in the description of issue is written that it is ok to write my own code..
??? Why TODO here? It should be down there with celsius line.
It's necessary
thx, corrected. Its pretty good if thats the biggest flaw youve found :p
sorry, i typed too fast.  i will correct that and add the DI tests.
We're only probabilistically sure that the boundary won't occur in the data. With only 116 bits of noise in the boundary, that's… relatively sure, but I'd rather be 100% sure. RFC 2822 (and my previous remark about having a library for this) covers this in more detail.
OK, last commit provides the requested refactoring

2012/9/3 Giuseppe Vallarelli <notifications@github.com>

> In tests/test_harmoniser.py:
>
> > +        (in a single magnitude scales), and an empirical magnitude
> > +        scaling relationship (between a native scale mb and the
> > +        considered target scale), an Harmoniser should convert to the
> > +        target scale only the measure in that native scale
> > +        """
> > +
> > +        mismatches = self.number_of_measures / 3
> > +
> > +        h = Harmoniser(target_scale=self.target_scale)
> > +        h.add_conversion_formula_from_model(self.a_model)
> > +        converted, unconverted = h.harmonise(self.measures)
> > +
> > +        self.assertEqual(self.number_of_measures - mismatches,
> > +                         len(converted))
> > +        self.assertEqual(len(unconverted), mismatches)
> > +        for measure in self.measures:
>
> If you want, you can wrap this logic in a method assertSomething related
> to measure scale.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gem/oq-eqcatalogue-tool/pull/16/files#r1516219>.
>
>
No upper case then. That's cool.
I've add you to my collaborator list. Thanks!
Optioneel maken met `$options['translate_text']` oid. Je hebt dan `false` => gebruik `Locale::getDefault()` en `true` => `$supported`
绝对不可使用sys.exit()
heh, triple "e" here. should be "exceed" no?
It should not be used as a singelton, no.
Fair enough. Pushed a fix for `Box`. There's a couple of other places in UI where I've used `size_t`, but I'll fix those another time.
just replace "return this;" with "this.jumpTo(0);" - works fine for me
for the large sample case, when we split the data into subsamples, I thought we can just run the entire algorithm on different subsets, that is split the data and call LTS for each subsample, and then merge and refine/concentrate again. I haven't tried to implement it yet.
I don't expect that we gain much from working on all subsamples at the same time.  "mask of a mask" not inside LTS, but the method that is doing the split has to be able to merge the indices of the subsample LTS's correctly.
That seems fine. Current version looks like it's the wrong way around.
Is this still the correct API for this? Or should this be `HighVoltage.root_drawer = HighVoltage::RootRouteDrawer`?
On closer inspection, it seems like this is something that `UnicodeData#for_code_point` should handle, since the "missing" code points I'm trying to handle by using `Array.new(size=15, obj="")` actually `do` exist, but are not explicitly specified. I've detailed my reasoning in Issue #18.
We may want to be more specific and check the length here, there are other reasons why an IOE could be thrown.
Should this be an assertion? I don't know what the functionality of this should be when the delegate is null.
I'm 60/40 in favor of pull up.  if you see a stack trace, you're going to have the line numbers and be doing an investigation.  It would be clear that store() is the problem.
Good idea, will fix!
Maybe we should just make a section somewhere that list contributors instead of cramming this all into a message box
You can probably do this (a bit shorter)
 ````
while (t != null && shouldRequeue){
	shouldRequeue = !(t instanceof AmqpRejectAndDontRequeueException);
	t = t.getCause();
}
````
It's not your fault but sadly it does not compile in eclipse as `getBytes(Charset)` is not available in java 5 (but in java 6).
I think we can use `getBytes()` as it will use the default charset, if you want to be explicit you can use `getBytes(Charset.defaultCharset().name())` instead.

We have a check in our maven build to assure that the produced jar is java 5 compatible but the check is only performed over main source code not in test code - it fails in my eclipse since I have configured the project to use only java 5 classes.
I have opened an issue in animal-sniffer plugin that perform the check (https://jira.codehaus.org/browse/MANIMALSNIFFER-28).
The code does compile :) It is a way to force doing static initialization for the ROOT_URL field. It isn't allowed in an interface to have a static initializer, so I placed the behavior in the RootUrl class, which has package visibility. So not visible to the outside world. 

To me it doesn't matter if it is an internal class of the interface or something with package visibility. So say which one you want and I'll fix it.
Ok, I'll take a look at this as well.
```js
var num = new Number(5);
typeof obj === 'number' && isFinite(obj);
// => false
```
You are still var_dump()ing $c after having removed it
Could you add parenthesis here?
I would add a new line after the left `{` to improve readability
Lets just use setters :) ->m_* looks bad :)
Again, language.
Just curious - why no more cookie plugin?
Oh, yes, I definitely forgot to rename the class.

I thought though that someone might want to use a different version of petsc than this, and it seemed reasonable to pick a name allowing multiple versions that a person can choose.
add the butons to the "armyBar" with its locations
是等价的，习惯不写括号了 :)
Это может не работать для платформ, у которых разделитель \r, например.
А если это "плохой" NullPointerException? Где-то внутри parseInt бага, например?
Yes, and should probably be disabled in settings page.
Providing helpful messages without a link to the help file seems less than ideal. Maybe throw your error message with something describing the actual error, "Attempting to create an instance of a Static Class. Use TargetFactory.new..." or something.
please use RETURN_DefaultObjectValue()
OK. I agree.
you don't need to write this if all you do is call the parent's __init__
the name of this method needs to specify what it's clicking on
Could you add the eclipse dir to the gitignore file?
these are already translated in xbmc. you can get the translation from xbmc via GetLocalizedString() https://github.com/opdenkamp/xbmc-pvr-addons/blob/master/xbmc/libXBMC_addon.h#L295
Bullet point?
Fixed it in the next push.
reused dir
-- 
Robbie Bardijn
Front-end Developer

Mobile: 0472 / 79.88.63
robbie.bardijn@gmail.com

On 3-mei-2012, at 11:50, Pieter Michels wrote:

>> +// @optional = $$dirname
>> +// @optional = $scan_direction 1 or 0
>> +// @optional = $opt_ext for filtering on extension (ex: pdf, mov, etc)
>> +// =========================================================================================
>> +function scanProjectDir($dirname = "", $scan_direction = 1, $opt_ext = ""){
>> +	$dir = $_SERVER["DOCUMENT_ROOT"] . BASE_PATH . $dirname;
>> +	$scaned_files = scandir($dir,$scan_direction);
>> +	$files = array();
>> +	foreach($scaned_files as $file) { 
>> +		if($file !== '.' && $file !== '..'  && $file !== '.DS_Store') {
>> +			$file_to_use = array();
>> +			$file_to_use["filename"] = $file;
>> +			$exploded = explode(".", $file);
>> +			$file_to_use["name"] = $exploded[0];
>> +			$file_to_use["ext"] = $exploded[1];
>> +			if(filesize($_SERVER["DOCUMENT_ROOT"] . BASE_PATH . $dirname . $file) / 1024 > 1024){
> 
> Maybe make this if statement a little more readable (eg extra vars)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/proximitybbdo/proximinade/pull/10/files#r767180
I think there is already a way to do that. Could you have a look at the sparse tests in sklearn/tests/test_common.py?
hi @GaelVaroquaux, i have to disagree with the variant statement. i think that's precisely what you want to do is to allow variants, unless things become practically unmanageable, which we are not close to reaching and giving users choices is the point of a library, not to constrain it. 

in general people apply a "novel" variant because that's how they get publications, without necessarily systematically comparing things across different practical scenarios. fortunately, in this particular case, the diffusion map embedding has both theoretical and practical implications that are not captured by the current spectral embedding method and has a growing literature behind it. they are related for sure, but they are not identical. 

so going to practical terms:
- computational time is not going to be very different because the only extra bit is the multiplication of the eigenvalues (raised to t) and the left/right eigenvectors. if you look at the equations, it's really not that much more work.
- performance (this is so application dependent, that i can't say anything more than the publications to which diffusion maps have been applied - things from text clustering, to diffusion imaging, to image segmentation)
- saying that the current spectral embedding generates a diffusion map is a little misleading if our point is to be precise

just to keep things separate and to demonstrate it's efficacy in some domains, i'll put some work into this and submit as a separate estimator. we can always refactor after looking at the practical implications.
It will be great if there is some other neat ways to achieve this :)
I see - my bad - thx
tell me if it fixes the problem
не работает. 
[InvalidArgumentException]                            
Cannot create a DBRef, the document is not an object
Why is the bug tracker being readded?
Please leave the D1 code.
It makes it simpler for @WalterBright to maintain the trees.
I'm not sure this works because `#readpartial` can potentially cut off output in the middle of a string that could satisfy the grep expression.  `#readlines` is probably better.
Added todo. Fix comparison warning.
this method has been removed
Cf à remarque précédente : Enregistrement ou item ?
En bon français ne faudrait il pas privilégier le terme Enregistrement
Hi @FabioBatSilva, is it possible to wrap lines to 78 chrs please ;)
Here's where I start the "weird stuff": changing username label and its validators.
There should be a warning here (or ealier), that #subfiles != "@numsubfiles"
Why not using nodeGroup->ordinality() here ?
Disconnect shouldn't... I'll have to think about connectWatcher . In practice this code is all moot since daliHelper is never freed once created.
Given that this change is delicate, I'd rather not mess up with what's working and has little relevance / is matter of style, on a path that is seldom crossed.
Why compare booleans? Why not just `if (!showAdvFilter && ...`?
I originally thought it had something to do with `MappedLoginService`.  I'll remove it.
It's useless to define a `$destructor` if then you simply call the parent
What are you trying to swallow here? Why?
@shacker can we avoid this change?
@shacker  suppress return code errors if the settings.local.yml file didn't exist in the first place. I'll do the -f.
This is the same as

~~~clojure
(and (= (apply max (vals (frequencies (map (fn [x] (rank x)) hand)))) 3)
     (= (apply min (vals (frequencies (map (fn [x] (rank x)) hand)))) 2))
~~~
You can optionally pass in the timeout value too.
if the backupuser/dir/password are required, why not just not supply parameter defaults?

class mysql::backup (
  $backupuser,
  $backuppassword,
  $backupdir,
  $ensure => present
) {
Definitely aliases, otherwise aliasing a system command has no effect, right?
"with an array where we cannot determine a value that it does not include", perhaps?
Oops - agreed.
Possibly I did something wrong here - if I use CDI here I get two different instances of FileUploadBean - one created when it is injected into servlet, second created by JSF.
Need to extend EMF AdapterFactoryContentProvider so you can listen to notifyChanged Notification objects ...
I want to say that it will be faster for sure, but I'm not positive.  I think it's worth trying and profiling.  @shunter any intuition based on what you know about typed array implementations?
Even if we take out the console.error calls, 404s show up as errors in the log, with no way to avoid them.  One solution here is to always generate complete tile trees, even if that means lots of blank files.
Actually, I don't care that much - `Rectangle` is more friendly for some users even though it will require code like `x + width`, etc.  Just pick one and go with it.  Let's get the request merged soon.
Are these the same default color and outline color as before?  If not, why change them?
Although we have a bunch of grandfathered code with `DOC_TBA` (where I assume you copied this from), all new code has full reference doc.  Let's update the doc for `setFrameNumber` and `getFrameNumber`.
Is it possible to check to make sure the style is correct instead of just making sure it doesn't throw an exception?  (we might not expose it, but was just curious)
'success' callback function
For whatever reason, the row selection still doesn't animate out smoothly, even with this in place - this may be a tableview bug.
This var should just be added to the variables above.
Same comment might apply to these memory debug log lines. Again, don't know if it would helpful to have a common prefix for these. Feel free to ignore this comment.
@fredj are you sure this statement won't fail on the legacy 8.x postgresql instances we still have to support ? Maybe we should put this resource inside a `if versioncmp()` ?
Sorry. fixed it.
Change order and use else if construct?
I'm slightly uncomfortable with configuration duplication, it just invites unpredictable behaviour that is hard to debug. The better (even if still slightly hacky) way is to do some bad things to the pythonpath and then import `settings.py` from `django/src/routemap/common`.
See https://github.com/lonvia/waymarked-trails-site/blob/master/django/apache/django_hiking.wsgi#L6 for an example of manipulating pythonpath.
I was just thinking about the placement of that bullet this morning. I agree that it's a better fit in the chaining section.

The second code snippet seemed a natural place to start a new section to me, since it was providing a reference for subsequent bullets, just as the initial snippet. Also, the bullets below it nested deeper than previous bullets.

I've spent way too much time writing and deleting in this editor, so I'm moving on. I'll let others weigh in on the split vs combined and proceed accordingly.
didn't see test for this
Double quotes :)
Are the buttons in the for-loop below being appended to `container`, or still to `this.controls`?
нееее.. там сложно. могу попробовать рассказать. ну или почитай как там сделано
This comment seems to be missplaced?
This method is internal to the private Payload struct, the constraint should already be validated in the public "seed(*)" methods. It could warrant an internal static assert for sanity though
Well, I figured that since ˋopDollarˋ is pretty much the same as ˋlengthˋ, bot deserved to be anotated/qualiffied the same way.

I also *did* copy paste from sequence, so I'll fix both.
This is not the correct code styling
Yeah, why not.
I'll do it.
Remove this part of the comment, now that mutation observers work in dartium :)
make this line `var selectedValue, fn, me, s, d;` ...
Same as above function, try using GetAll()
Correct, that'd be a broader sweeping change that should be done at some point but will involve a LOT more changes.
yes the event sender in core cannot do anything with errors, all we need to do here is close the socket
I don't think we should say this. first it assumes that you have SensioGeneratorBundle, and second it assumes that you want a new bundle for this instead of using your own bundle.
This name is not helpful. What does this do?
To avoid this, you should use a Rails partial counter.
Well
```
configure: error: 
********************************************************************************
* Could not find the Tcl header files (tcl.h).                                 *
* Please add the include path to CPPFLAGS                                      *
* (e.g. configure CPPFLAGS=-I/usr/include)!               
```
So it should be...
This definitely won't do what you want it to do. mystruct is a type, not a variable.

Also, please use a better name than "mystruct".
I went ahead and fixed it in a few places in this file.
additional blank line here, two between methods
Where was this progress indicator shown? If not within this function, then we should probably utilize a callback and have it shown and hidden inside the same function, so the chain of calls to it isn't confusing.
I've made these references optional, so when `DocMigrator` is not enabled, this servlet behaves exactly as it did before.
Hi, Amol!
Thank you for you attention. If you take a look into code, not just on this line, you'll see I'm interested in the exception's message.
We've had a lot of discussions about  `@test(expected=...)` before and also there were several bugs about lost 
exception's messages. So, we concluded: there is should be assertion for exception's message, if it is posible.
I think: Gary confirms.
E.g. https://jira.springsource.org/browse/INT-2392 and his PR
+1 to IntegrationResourceHolder, change it if you can.
Its your choice, but personally looking at the code I'd name this method 'produceConnection' or 'renderConnection' . . . up to you.
Having the requirement for authentication stated on a separate line would look better, imho. The easiest way to do that is to add a blank line between this one and the preceding one.
Trying to make the class a little more suitable for general-use
Okay cool. I'll re-edit that sometime later and send you another request.
This won't work, and is redundant anyways.

All `Backbone.View` objects are by definition a function. This is why we had previously not implemented this feature request. There's no solid way of knowing whether or not it's a View type or just a function, without ugly hacks that would be potentially limiting.

It would be better / easier / less problematic to assume that `this.itemView` and `this.options.itemView` are Backbone.View objects. The `getItemView` function itself will provide the ability to return a Backbone.View from a function while `itemView` declaration remains a static reference.
Было `public`, что конечно же неправильно, т.к. сигнатура/прототип метода по иерархии выше именно `protected`.
о да! я тут счет виду сколько еще будет неразберихи с этой темой :D
The wrapper script is used by a lot of Gradle projects, like hibernate and spring, to provide bootstrap developers so that they don't have to download gradle explicitly. Likewise, it offers some isolation, since it's locked down to a specific version of gradle and each project could customize the startup. We use the wrapper for both those reasons, we need to inject our corporate environment via an init script and that's not possible if each developer has their own Gradle. I'd say in the gradle eco-system, the wrapper is critical.

I think three options is the way to go. I opened the door to this in the jelly scripts, so it should be straightforward to add. I like the idea of calling Gradle directly via java invocation. It could even be possible to directly call the wrapper via java invocation (though I personally wouldn't use it, since we've customized the gradlew script).
change to font-italic
Well that's one way to speed things up.
Do they use lists in tastypie?
This seems redundant to the __toString method, no?
there are some leftovers from conflicts here. Please remove these lines...
framework**s**
I c what you are doing, even though I don't like it but I don't think there is another solution
Why does the zip need to be passed to the callback function? Isn't it already in scope?
Always start a comment with upper cased chars. =)
This will create a new answer set for every question you answer, you should only have one AnswerSet for each questionnaire, and then add QuestionAnswers to it
String concat vs array: I just did the same like it is done with `labelClasses`, where it is done as an array. If you prefer concatting strings, I can update it.
Can we please be consistent and source braces everywhere? It would make me really happy.
Yeah, this could be an allback since everything is named.  (And someday, perhaps, promises.)  Will do.
In android, default title is "title"
"". If the user passes undefined, the value is ignored. The idea is that if the user only wants to change one of the four values, but leave the others unchanged, they leave them as undefined. If, however, the user wants to reset the size back to the default, they pass in "". We don't want to unitize "" obviously.
This appears to be at odds with the `vzIndex` property. What's the difference?
I guess I can make it into a qunit tests. But maybe I should just remove it, do we have such tests for other tokenizers? I guess they are pretty stable once reviewed.
typo `absolve`
how are you making sure that this file is not integrated with the actual build?
should not be using global functions if they are not needed
m_p for pointer variables
If you do one, shouldn't we do all 3?
both are Ms-PL (http://htmlagilitypack.codeplex.com/license and http://dotnetzip.codeplex.com/license)

i guess the important parts from the licence for us are in §3

(C) If you distribute any portion of the software, you must retain all copyright, patent, trademark, and attribution notices that are present in the software.

(D) If you distribute any portion of the software in source code form, you may do so only under this license by including a complete copy of this license with your distribution. If you distribute any portion of the software in compiled or object code form, you may only do so under a license that complies with this license.

(E) The software is licensed "as-is." You bear the risk of using it. The contributors give no express warranties, guarantees or conditions. You may have additional consumer rights under your local laws which this license cannot change. To the extent permitted under your local laws, the contributors exclude the implied warranties of merchantability, fitness for a particular purpose and non-infringement. 


@D - according to http://www.apache.org/legal/resolved.html - we could also stick to the ASL 2.0
As I see, ODM, haven't  any optional field for precision, I haven't idea
(* -1 x) = (- x)