labofsahil/github-event-dataset-2012 huggingface dataset:
Mr. Quarx2k  . Many thanks for your reply. i found your build is newer than tpruvot so i try to build his first for defer who  need cm9 base on 2.3

Thanks your great job
Fuengirola Rentals
+ android:defaultValue="#ff111111"

 beneficial
`apw`
This doesn't seem to quite fit with other fog patterns.  For consistency it should probably have an `internet_services` method that would return a new InternetServices collection which you could then do normal fog operations on.  You can see examples of this pattern in the storage providers, for example the files references in directory here: https://github.com/fog/fog/blob/master/lib/fog/aws/models/storage/directory.rb#L50
I could see different usages, that can probably be broken down into weather you are using tools or not.

I guess we could extend it to check if the tools are installed and then based on that, also, does vmware keeps the ip address when the vm is down?
An upside of presenting the `(use --upgrade-recursive to upgrade)` notice is that it might ease confusion for people expecting the previous `pip install -U` behavior.
Why use `add()` here and not `reset()`?
Default value should be "right" or setting iconpos to "left" will have no effect.
I would think if we could send additional table data as second element in array to entity_row_to_elggstar or second parameter. This would avoid merging the data and hacky tests like one below. Additionally it would make easier in future to possibly introduce 3rd table with attributes or particular subtype? (not sure if it was discuissed, but seems like natural continuation)
Awesome, and now we have a new interview question on classloading if we want to confuse any potential candidates ;-)
I may be missing something, but I don't see the maven-site-plugin ?
Shouldn't this be called "ResetNavBar".  Ignoring would imply that no matter what it's going to ignore the bar.
Ok, so the solution is the change from node(third) / "user" / ... --> user/...?
same here, or add a comment why not
I agree. But maybe we should flesh it out in _The General Rules_ where we now only mention _at most once_?
Do we really need this? The main difference it causes seems to be whether we clone via https, or ssh. But as a matter of fact, a developer can use a https clone just fine for pushing, too. So perhaps we should just always use the https URL?

Or alternatively, rephrase the question to more clearly explain what the user is choosing between (HTTPS via SSH access).
i don't get an error ther e:/
this should be ckan.logic.get_action('group_activity_list_html') so it can be overridden and should probably be done when the function is actually needed so that plugins are taken into account.
Removed e.g.
Good descriptions on all three sections.
Why change these? (not a fault, just curious)
We could try that but doing all that work doesn't justify you just needing to return the proper object in inherited_ssl_listener.
this is what i meant above about exporting `COMPILER_PATH` -- definitely don't want to change this -- i would suggest changing `COMPILER_PATH` back to `COMPILER` and keeping this piece intact; this maintains backwards compatibility.  you could detect the user's OS and output accordingly or just output instructions for both at the same time.
IMO file size is kinda useless - unless there's a bunch of clients that rely on it, I'd drop that.
free(NULL) is defined and safe afaik.
Move these to where they're used (reduce scope)
from General.cpp
`m().terminate_job_flow.called` tests the actual function call.
Since we expose the steps format, I don't really see the point of having symbolic constants for these. It's not like someone is ever going to want to set `MAPPER` to anything other than `'mapper'`.

(And I don't think potentially catching typos with some sort of compile-type check is worth the level of indirection.)
Not entirely sure I like this exact addition, but I'll let it enter along with the rest if you add tests for the pullreq :)
This api shift is to separate the creation of the account object (User only in current code), and the card object from binding and saving them (save_card, a method on the User (hence handled by the plugin class in the end).
We should be careful with this: overloading the () operator in this way could make it hard for people to read/follow the code as they go searching for the implementation or interface to the function myfunc().  Not that we shouldn't do it, but think about the unintended consequences.
@PerilousApricot If we move this here and the self.executeCommand fails then it would stop retrying as usual. Maybe the the except StageOutInvalidPath should try to create the directory (if that fails I don't really see a point in retrying since that was already retried before) and do the same check on the retries?
Why is this here? Formatting error?
My thought with additional backends was to move backend-specific configuration options under a top-level backend hash, like:

```
ganglia:
  host:
  port:
  spoof:
  useHost:
```

Instead of polluting the top-level with these. I didn't do this with graphite as that would have broke too many existing configs, but figured it would be a good idea to move to the pattern for new backends.

Thoughts?
{{ ... %} -> {{ .. }} ?
I want to keep this warning.
We could just add a small `NSObject` category to make this more friendly looking with `NSInvocation`...?
Em 03-07-2012 14:29, Dickson S. Guedes escreveu:
>> +		
>> +		if [ $TARGET  == $i  ]
>> +		then
>> +			echo -e "Removing Postgres installed by PGVM!\n"
>> +		   	echo -e "	$i\n"
>> +			rm -rf $pgvm_home/environments/$i
>> +			exit 0
>> +		elif [ $TARGET == "--all" ]
>> +		then
>> +			echo -e "Removing all Postgres installed by PGVM!\n"
>> +			echo -e "$VERSIONS"
>> +			rm -rf $pgvm_home/environments/*
>> +			exit 0
>> +		elif [ $TARGET == "--purge" ]
>> +		then
>> +			echo -e "Removing all Postgres installed and source by PGVM!\n"
>
> We should accept purging specific versions too. We could support something like:
>
> pgvm uninstall --purge X.Y.Z
> pgvm uninstall --purge --all
>

    I think is better to purge all:

   pgvm uninstall --purge all.

   Right?

-- 
Fernando Ike
http://midstorm.org/~fike/weblog
NGROUPS_MAX is not necessarily constant and it could be large, using it for stack-based allocations is not a good idea.
2012/8/29 Ryan Phillips <notifications@github.com>
>
> In src/utils.h:
>
> > @@ -58,6 +59,13 @@
> >    uv_handle_t* handle; /* The actual uv handle. memory managed by luv
> > */
> >    int refCount;        /* a count of all pending request to know
> > strength */
> >    lua_State* L;        /* L and ref together form a reference to the
> > userdata */
> > +  int threadref;       /* if handle is created in a coroutine(not main
> > thread), threadref is
>
> put spaces!

+1 for spaces!
Maybe we should write coding conventions for C.
I would like to omit semi-colons. However we cannot.
If I remove this semi-colons, I get a runtime error:
```
/usr/local/lib/luvit/luvit.lua:221: /usr/local/lib/luvit/module.lua:57: /Users/hnakamur/mysrc/luvit/luvit/tests/test-fs-mkdir.lua:48: ambiguous syntax (function call x new statement) near '('
stack traceback:
        [C]: in function 'assert'
        /usr/local/lib/luvit/module.lua:57: in function 'myloadfile'
        /usr/local/lib/luvit/luvit.lua:321: in function </usr/local/lib/luvit/luvit.lua:221>
        [C]: in function 'xpcall'
        /usr/local/lib/luvit/luvit.lua:221: in main chunk
        [C]: in function 'require'
        [string "    local path = require('uv_native').execpat..."]:1: in main chunk
```
Tu n'as pas à mettre `.js.coffee` dans les requires. Même chose pour la ligne en dessous.
Redundant.  `@Before` already tells enough information.
tl;dr We're confusing 2to3. Py3 builds of this branch against Git result in failure. Py3 builds against a source dist work fine.

I've just had another look at this. This code removal is unrelated to the Py3 errors. The problem is related to the 2to3 tool.

When a Py3 build is run directly from the repository, the 2to3 tool doesn't refactor the relative imports (e.g. `from polynomial import Polynomial`) in `numpy/polynomial/__init__.py` (presumably because the files don't exist at the time 2to3 is run and the tool must therefore assume they are meant to be external imports).

When a Py3 build is run from a source distribution, the `numpy/polynomial/polynomial.py` etc. files already exist and the relative imports can be correctly generated in `numpy/polynomial/__init__.py`. This explains why testing with tox works on my machine - the build and test cycle for each Py version is based on a single sdist created by the system python and cached at ~/.tox/distshare/

Travis CI farms out the build tasks and runs the build and test for each Py version against a fresh Git checkout - hence the reported Py3 failures.

To fix, `numpy/polynomial/__init__.py` also needs to be regenerated at build time for Py3...
PEM_write_bio call doesn't matter, what matters you are returning without freeing structured that you have allocated.
подвинуть инклуд вниз
переименовать в intersectsWith()
@guilleiguaran Hey, I'm done with `ActionController::Parameters` documentation. Can you review it while i write the `StrongParameters` module documentation? Thanks :)
I'm sorry, that should not be here.
Thanks, but I have to bother you once again before merging :). Please move the changelog line to the top of the list, we usually add them to the top. Also, I think a single backtick around the code would be enough.
we don't need this blank line
Doing it this way changes the `?` method to be no longer asynchronous. It should be asynchronous, though, because that's the reason for returning a future in the first place. Just like before, I would wrap the code inside a `future { ... }`. Moreover, to properly manage the blocking of the `!?` method, I would use

    scala.concurrent.blocking {
      actor !? (dur, message)
    } match {
      ...
    }

So, taken together you could do:

    val replyPromise = Promise[Any]()
    scala.concurrent.future {
      val dur = if (timeout.isFinite()) timeout.toMillis else (java.lang.Long.MAX_VALUE >> 2)
      scala.concurrent.blocking {
        actor !? (dur, message)
      } match {
        case Some(x) => replyPromise success x
        case None => replyPromise failure new AskTimeoutException("? operation timed out.")
      }
    }
    replyPromise.future
Also, these two lines are useless.
This just moves the begin/rescue logic out of the state machine and into this method, which I think is neater.
On Sun, May 27, 2012 at 10:19 AM, Aaron Meurer
<reply@reply.github.com>
wrote:
>> @@ -264,6 +264,16 @@ def test_partitions():
>>      assert [p.copy() for p in partitions(8, k=4, m=3)] == [{4: 2},\
>>      {1: 1, 3: 1, 4: 1}, {2: 2, 4: 1}, {2: 1, 3: 2}]
>>
>> +    assert [p.copy() for p in partitions(S(3), 2)] == \
>> +    [{3: 1}, {1: 1, 2: 1}]
>> +
>> +    # this doesn't work, so wrap it in a try-except block
>> +    # assert raises(ValueError, 'list(partitions(3, 0))')
>
> I don't understand. Why aren't you just using raises()?

I got bit by "assert raises" rather than writing simply "raises". This
has been fixed.
or just replace `align_char` with `self._alignment` if the change is made above
should level one be "L1"?
This again is wrong. Whether a Pow is real or imaginary depend both on the base and the exponent, not one or the other.
Again, white space.
Probably another good use of isinstance
In this line I mean `Add(y, x)` indeed.

Because  when I debugged this test, then the code above like this line `c = y + x + z` created at first `Add(y, x)` then created the `(Add(y, x), z)` then flatten collect nested `Add` to the single one `Add( y, x, z)`.

But suppose that sometime before in this test file one created lines like 'x + y', that is Add(x, y) was created from string. 
Ind will see what will be occured in our code.

When we again try to create `Add(y, x)` then `@cached` method `__new__` of base  AssosOp called.
And as it cached upon the sorted arguments, then it just  pull out the `Add(x, y)` object from cache, which has the stricly defined order of argument (x, y).

That is, further flatting of  ``(Add(y, x), z)` will use incorrect args of `Add(y, x)`.

That was the probem, so I insert `cleare_cache`

But  when we construct the same expression with the help of `Add(y, x, z)` constructor, that is without nested Add's, then we have no problem like I describe.

May be more detailed comment must be inserted here (and in the core description)
This is fixed in a separate PR. I suspect that one will be merged before this. I'll rebase when it's done.
i think, this line should be above previous one. If the data pass above condition, than this one is useless.

What about to change it to: 
```
raise "Missing specified file" unless File.exists?( @file_path)
```
Should be `NUMBER_OF_METHODS_IN_INVESTIGATED_CLASS` (typo).
You actually do not need these newline escapes.  Python provides them automatically for for stuff inside { }, [ ], ( )
`_is_leap_year()` can be replaced by `calendar.isleap()`.
oh my bad, don't merge my code for that transition
Did you check on Linux what all works?
Did you check on Linux test works?
`ensureSettingsURLFormat` - by the looks of it, it currently won't indicate which field has the faulty value.
"logging" feels like it has a meaning in a technical context, and I don't think we want to document this as such, the profiler captures information about database operations. I think capturing or reporting are the words we want.
s/on/in/ 

the last sentence should: The operation adds a slight overhead to the operation of :dbcommand:`geoNear`. 

there's no reason to distinguish between computational load and other kinds of load in the context of a command returning.
I believe so, comment should be removed
Just in case someone tries to get user information without actually loading any user first, in which case no user, including the anonymous user, would have been loaded (causing some unexpected behavior).
You misspelled license, which is probably why composer complains about it.
At the very least each property should be on its own line.
A comment here also.
Esti sigur că asta repară problema? Ei ziceau că in loc să arate de altă rasă, arată la target pe toti din vecinatatea clasamentului.
Maybe add some meaningful value for when this is empty?
This breaks the navbar font in Firefox.
Small small thing:  what does the `|| []` do here?  Doesn't `slice()` always return an array?
Давай лучше скрипты в одно место. Наверно все-таки потом нужно будет сделать AMD, для красоты кода
Please follow lexicographical ordering within a category within all-packages.nix unless grouping similar packages together. lv2 comes before lxdvdrip.
This version would need a patch to support saving. @bblay might have some more info.
1 too many newlines.
I don't have a strong preference on variable names, but I don't think the new name would be an improvement either.
Ok, thanks for double-checking.
maybe we should use static final strings for sysproc, defaultproce, and adhoc? Are they defined somewhere else?
Cool.  I still think it might make sense to offer a bulk API in the `mem3_nodes` API to reduce this thing down to a single `gen_server:call`.  But I'm ok to merge it as-is.
Yeah, I'm not sure what the original requester needed but I based mine off of the old [emma-maven-plugin](http://mojo.codehaus.org/emma-maven-plugin/check-mojo.html) simply because I'm trying to convince my organization to stop using it and the main reason they didn't want to switch was because the jacoco-maven-plugin is missing the check mojo.  I think this is a good first step. Maybe extending the capabilities should be another issue?  I'm willing to make some changes though if you have some suggestions.
I *think* this should be

``` clojure
(empty [this]
  (ORSet. #{} #{}))
```

Eg clojure.walk/walk uses

```
(into (empty c) (map f c))
```

to map over arbitrary collections, so we probably want to get an ORSet back.
Yeah :-/. That'll work, although ill hold my nose a bit while doing it. It just feels a bit too obfuscated to pass `false, ""` to a function and that means "don't force a number but try a number.". If that doesn't save more than few bytes over just reverting this, than i'll probably just revert and sacrifice the bytes for the clarity.
Why? https://github.com/gibson042/jquery/blob/db2356ee61673ac4597d83d1228216031d27cc32/test/data/testrunner.js#L144

Is it in case globals are not checked for? I don't really get what we're trying to fix in the test here.
Better still would be `core_rnotwhite.test("\uFEFF\xA0") ? /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g : /^\s+|\s+$/g`
Exposed then removed?
Please don't use catch alls. There are only very few places where their use is legitimate.
Is there a good reason to use avg over min?
Seems more like "Check whether the _id is a BSON ObjectId", if I understand correctly, right?
RandomDirection() is well suited to do this. Also, the userFacing calculation isn't used here at all, same for SummonMonsterOn()
Shouldn't the format string use a / instead of \ ? As it is the path ends up being something screwey like "Data Source=C:\mooege\Assets/account.db"
The mixer uses 0..100, while the `NadTalker` class internally converts to 0..40. This part of the code is unchanged from the old NAD mixer implementation.
The _do_domain_checks and _do_config_checks seem pretty long to just stuff in views.py.  I think we should put them in configChecks instead, and just import those two.
By group you mean: make it separate options or remove empty line ?
@samueljohn Thanks! It succeeds with `--env=std` but with `env :userpaths` it is not required :)
 Should I use `ENV.j1` or `ENV.deparallelize` below? Any hints into how can I improve/remove setting the MPI environment variables below?
Only types that should be part of sqerl's external interface should go here. I'm wondering if some of these new types are really internal only. If that's the case, then they can be moved to a `src/sqerl_internal.hrl` to be shared among modules. If we think some of these belong in the external interface, then we should probably prefix the names with `sqerl_`.
I know we don't need it but my question is if this would be a sensible safe guard to add? I'd rather have a bit more upfront effort in writing a migration if it reduces the chances of bad migrations in the wild.
I kind of like the dotted names because they namespace the sub-values nicely but I'm open to alternative suggestions.
Before this gets released into the wild, would it be possible to limit this to `POST` only?
Tenhle secret string musíme nějak chránit nebo ne?
Like TLS and MockOS, CloseGuard is another important testing feature that's completely missing on HotSpot
Actually, I would totally prefer this as it flows/reads way more "naturally" to me. I was just trying to stick within the conventions that were already in place. Now that I know you're down with the == null then I'll totally clean it up when I get a chance. ;)
@stephenc 
yes, i agree with you. I vote for simplicity.
More and more thepeople want to be isolated from hamcrest and control the version by themselve. That's maybe the reason why many proposals come.

IMHO at some later time we may propose modular junit. I think it would help to devs and users as well, keeping junit:junit library unchanged.
@stefanbirkner @stephenc are you open for this idea? Maybe we should discuss it in junit2yahoo.
Addressed all the comments! Thanks!

On Fri, Jun 29, 2012 at 4:04 PM, Kristján Pétursson <
reply@reply.github.com
> wrote:

> >  exports.defaults = {
> > -  self: 'user'
> > +  self: 'user',
> > +  fitness_acts: 'activity',
> > +  strength_acts: 'activity',
> > +  background_acts: 'activity',
>
> I'd recommend calling these `*_activities` so we don't have two forms of
> the word running around to confuse people. Nesting like `activities/*`
> might be cool, but I don't know if the harness supports that kind of thing.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Singly/hallway/pull/412/files#r1079632
>
I could have sworn requestAnimationFrame was supported in iOS 5, but it's not. WTF.
This should include the small swatches too -- otherwise, after you click one of those you can't use Esc to close the colorpicker.
ColorEditor has properties for these modes, e.g. ``colorEditor.$rgbaButton``. Can we rewrite this similar to what you have later: ``colorEditor[modeMember]`` passing in ``$rgbaButton``.
I don't think so. getHints may be called repeatedly throughout a hinting session, and I don't think it makes sense to cycle through providers within a session. Different providers might provide different classes of hints, and it might be jarring to have the hint list change wildly on each key press. 

Also note that if hints are requested again, either implicitly or explicitly, a new session will be created, and so all providers for the mode will be polled for results from highest to lowest priority. So unless a higher priority provider is completely broken, the lower priority providers will have another opportunity to provide hints.
Nope, it's not. Left over from testing. Removed.
Do we also want "right-click selects object under mouse" functionality in the project panel?
Wouldn't it be possible to do this in a more generic way? E.g., have a central list of all these process types, and have each extension add their own to that list? Right now, if you want to add something, it seems you have to change this file?
This special case is the whole point of highlightSeriesOpts! It is documented, if only at http://dygraphs.com/options.html#highlightSeriesOpts
Generally speaking, in the future, open separate ones. If @hone cares, then you can use `git rebase` to remove adf71e9, since you did the right thing and kept it a separate commit! Or he can cherry-pick the other ones, which is some work too.

We'll wait till he weighs in.
yes, it's domain. ok i'll change it.

On Sep 13, 2012, at 2:56 PM, Cory Zue wrote:

> In corehq/apps/adm/models.py:
> 
> > +            return default_value
> > +        return days if days > 0 else 0
> > +
> > +    def clean_value(self, value):
> > +        return value if value >= 0 else -1
> > +
> > +    def html_value(self, value):
> > +        return "%s" % value if value is not None else "--"
> > +
> > +
> > +class ConfigurableADMColumn(ADMColumn):
> > +    """
> > +        Use this for columns that will be end-user configurable.
> > +        Default versions of this column, which are only superuser configurable, will have project = ""
> > +    """
> > +    project = StringProperty()
> 
> is this domain? even though we call them "projects" in the UI now it sorta feels like we should be consistent in the code and stick with domani
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Could we rename this to XMLRPCDefaultEncoder? I never liked the *Impl naming convention.
Check [LanguageField](http://dev.wlan-si.net/browser/nodewatcher/nodewatcher/web/account/geo_fields.py#L340). You will also need [initial_accepts_request](http://dev.wlan-si.net/browser/nodewatcher/nodewatcher/web/account/utils.py).
Yeah, i thought that there is a problem ;)
So what is this variable for? Can you copy me here its description?
Thanks, that was very helpful. I made it now using just one class for the `<ul>` which holds radio buttons. Hope this is OK.
This seems like a fine place. Can you remove the fixme.
Ага, я когда кодил тоже об этом думал :) Но поленился встраивать проверку, вообще не известно примут ли пулреквест, изза патча нужно версию ноды поднять и вид уже не в миллисекундах а в эрее.
I will fix it asap.
I added an explanation in manual.txt. But not sure it is enough. I added exclude.meta file in galleries folder for showing the idea. Refer to commit c7cae16.
Fixed in 7ca8a7ec
all committed seperately but the changelog should least summarize that. peek at 
https://github.com/saltstack/salt/tree/develop/debian for details and/or I can list 
commits in the changelog comments if you think it's needed.
Can't locate the symbol of module \"%V\" in \"%V\", &module_name, &module_path
No, I've never actually seen it happen. It's mostly a sanity check--in case for some reason the phone fails to update the call logs, we don't want to re-remind about an older missed call.
Well, i do not expect a backend to do the correct thing and only return the record i asked for. If i can assume that, then the code changes a bit.
I don't use getSOA because that doesn't return a DNSResourceRecord which i later use/copy for the actual update.

So, if i do lookup(QType(QType::SOA), rLabel); can i assume that it returns ONLY soa records?
You are one year behind.
How can i change that afterwards?
I also tend to avoid function-terminal else, *except* when it's a short and parallel code structure as I have here.

I would've used ?: but it wouldn't fit in a single 80-column line. (I'll exceed 80 columns, but only when it seems to be particularly helpful.)
Don't use `Predicate<T>`  use `Func<T, bool>`
Agreed. Changed it to _get_container_path()
That's not available in version < 2.7 so you can't do that.
Good catch, I think it just keeps a ref.
我觉得这个这个try-catch 容易让人误解，不知道是哪里会抛异常出来
Again, why the composite index?
I love speaking names ... that's kind of a fetishI have ;), sorry ^^.
This is redundant, boost already deals with this for us, see message_queue.hpp:501 (in 1.49)
"//Check if buffer is smaller than maximum allowed"
Sorry, I'll correct that
or that "FAR" might be removed by mistake. Anyway, although I doubt 32bit stuffs don't care about FAR, maybe I should review the diff again...?
:-1: to this the old code was hard enough to read.
This is a very clever solution to that problem :)
Do not suppress errors.
I tried using https on the spotify open link and didn't get any response so I assume they don't support it. Which is why I only match on http.
This is fixed in the seperate repo: https://github.com/forkcms/library/commit/8b0a1ffa429c608c33f1ce7717db4033f652720f
Thanks for these typos (so much for tests!!! :-) ) .. I'll include them in
tomorrow for your review ..

Tim

On 15 March 2012 18:54, Thomas Kluyver <
reply@reply.github.com
> wrote:

> > @@ -44,49 +44,39 @@ def dir2(obj):
> >      have such bugs).
> >      """
> >
> > +    # If the object has the __all__ attribute, return the given list
> > +    try:
> > +        return getattr(obj, '__all__')
>
> A couple of minor things. I've learnt something, I didn't know about
> overriding `__dir__()`.
>
> It's OK to return wrong names if they're wrong in the module, but we
> should make sure it doesn't crash IPython.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1497/files#r564718
>
Can you add timeInSeconds to signRemoveBlob for completeness?
Actually, this was a test I started and then removed...but not fully.  Crap, I'll fix it.
since deleted elements are so simple (ex. just Key), I'd probably delete that class and just parse it here
Heh, yeah, that looks like a bug to me.  Not good java code anyway.
Maybe include `wrong` in the pattern. Just to differentiate from the other file (`valid_hashrocket.rb` vs. `wrong_hashrocket.rb`).
This random value is going to cause a lot of excess memory allocation for pools, I think. Maybe 4k or so might be a better value? These pools are mostly used for storing sets of small strings, so a really large allocation is not needed. Also, we try to avoid // comments in libgit2.
I think nulls should be dropped (i.e., they are NAs), not counted as 0. Thoughts?
We use the `cached_db` session store backend. Which means the sessions key/values are stored in the database and cached in our cache backend. The only cookie is the session id cookie.
Seems like this just tests the implementation and not of the behavior since the way we calculate the expected output is exactly how get_absolute_url() is implemented.

I think we could ditch this and similar tests.
`jingo.render` is deprecated now, and `django.shortcuts.render` is hooked by Jingo now.
Oops! ^^^
Isn't a tuple? The word `set` puts me off. I would just call it `self._crashes`.
Nit-ignorable.
There's nothing added to doing that that can't be done in `WebServerBase`. See above.
I'm trying to reduce the chattiness of code in the logs.  I deemed this log message superfluous but left it in for future debugging if necessary
This needs to run in a transaction otherwise you might get orphans between django/amo user rows. You can decorate it in ``@django.db.transaction.commit_on_success``
Use a StringBuffer instead.
I don't think list reversal is needed here, given that checksums don't have any inherent order.
Sorry to be a stickler for formatting but it should be formatted like this:

     if (isset($module->installed) and $module->installed == 1) ? true : false;

But this looks like a useful function!

Adam
This can go, as we shouldnt be using $this->ci anyway.
moving this up here is useless
Setting the pattern as `htmlPattern=""` will result in the same as `htmlPattern=false` which disables client-side validation.

Setting as `htmlPattern=null` will do nothing, as if it was not specified; the fallback on `pattern` will be used.

To test for empty string, set as `htmlPattern="^$"` but this is a bit useless
You should also add a phpdoc here.
@bschussek why adding this option ? It does not seem to be used anywhere
`strtr` ?
@weaverryan I think @Tobion literally means shouldn't it be "are" instead of "is" in `There is %%count%% apples`. ;)
this should chain to once of the creates below
Since we know that this will happen if the original post is not there can we either 
(A) log out a more helpful exception
(B) handle it without the try catch (using NSNotFound) and then just discard the reply if we don't have the original
Minor formatting: move the "}" inline with the `html_options`, then close the ruby tag on the next line.
一会有空格分开一会没有，风格不统一啊。
width: 500px;
width:200px;
bei jedem deploy wird nun das komplette repository geladen anstatt nur die aenderungen. ich hatte das gefuehl, dass es da probleme gab.
`polygon` -> `MultiLineString`

... and I don't think we need the text in parentheses at all.
Just use ```self == other```?
did the build file get deleted from the solution items folder?
is that just a best guess or something informed?
because:

current_page = SimpleLazyObject(lambda: get_page(request))

def get_page(request):
     return None

if current_page:
    print "should never happen"

but it does!
Maybe a little more verbose (and i18n'ed?) message like ``You do not have permission to publish this page`` would be more appropriate.
eran pruebas para que funcionara, se va
Now using the new Session when creating a new session, instead of trying to overwrite the current session. it is also useing the new model's function setAsCurrentSession
Please look at writing doc comment :-) http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format
эм, так они же для Comment ? как-то не логично. CommentPermissonService создавать?
type, -> `width`
FM Raio -> FM Radio
well done clearly document it!
Do we need to querySelector every time? Can we cache this info when painting? I think that will reduce significantly the latency.
`function sendCompositekey`
Makes sense. I'll fix that
Agree, sorry for not being awake this morning
Nit, but alphabetical import ordering is preferred.
See comment on Windows -- not an option for these folks
I thought about that, based on the code it looked like it was building a "default" command that was to be used if the user hadn't specified one, and used the noun instead because it seemed better to me. Would you prefer the change?
`point` instead of `result` ?
password gets deleted later in the file, if someone is doing development and playing around, they could make a userobj in a file and pass that into loadUserFunc and get a mysterious and unhelpful error.
A minor thing, but could you not use Joiner.on(separator).join(messages) ?
why not "sage"?
There's more than just one child though.
https://boards.4chan.org/g/res/29875552#p29880247
A good pythonic way of dealing with instead of a while True: break situation is to create a [generator](http://wiki.python.org/moin/Generators) that loops through the pages. That allows you to just iterate through things in the outer code.
message is set later, this is just a check to make sure the format string has all the needed placeholders. That way the event's message can be changed later without having to call setFromat again.
according to http://www.phpunit.de/manual/3.2/en/writing-tests-for-phpunit.html
dataprovder must be public and static
Please remove trailing whitespaces in all the empty lines. Given the change you made, this PR should be a 1-line diff.
There is some end of line whitespace here, mind nuking it?
has someone an idea how the number of buttons could automatically be derived from the following config.
would be sleek, but this is beyond my m4 knowledge.
Remove this lines if they are useless, don't add new comments
```bash
vagrant:/vagrant/gitlabhq system-to-fileutils 
→ rails c  
Loading development environment (Rails 3.2.9)
1.9.3-p327 :001 > FileUtils.mkdir( '/tmp/mkdir_fileutils2', :mode => 0770 )
 => ["/tmp/mkdir_fileutils2"] 
1.9.3-p327 :002 > exit

vagrant:/vagrant/gitlabhq system-to-fileutils 
→ stat /tmp/mkdir_fileutils2
  File: `/tmp/mkdir_fileutils2'
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: fc00h/64512d	Inode: 1048616     Links: 2
Access: (0770/drwxrwx---)  Uid: ( 1000/ vagrant)   Gid: ( 1000/ vagrant)
Access: 2012-12-07 10:37:06.269298460 +0000
Modify: 2012-12-07 10:37:06.269298460 +0000
Change: 2012-12-07 10:37:06.269298460 +0000
 Birth: -
```
Nitpicking: Could put the `renderArticle` into `promiseOfArticle` instead so the templating is done on the future's actor rather than the dispatch completion's actor.
Even non `py` needs to end with new lines ?.
warn?
Is there any particular reason to use bind(null) ?
Can't we do:

    exports.clearTimeout = unsetTimer;
    exports.clearInterval = unsetTimer;
got it 07540b35421c21e0a3e09c9e0454dab45d0ab576.
I don't see a commit for `secondaryTransitionPassword` in the Mock xhr.
I like this short-circuiting.
I somehow convinced myself that was necessary.  But Yes, when I'm already creating a new `Error`, there's no point.  Thanks for the catch!
Page templates are rendered on the server though, and I don't see this partial used by a dialog template...

Plus, there won't even **be** a client-side EJS once #2455 merges.
It was a deliberate action executed out of total ignorance.  Removing it.
I think `lock_rows` is a misleading name for this argument. It's not actually locking anything at the SQL level. Maybe `claim_rows` instead?
Mind changing all the 'attempts' to 'activity'? We don't only attempt to run GC or whatever else, but we do it for real.
Please ensure that you check that options is a hash. If not set it to {}. Otherwise it will break if no parameter is specified.
I change this but I don't think the old code was good : $const could never be used
@fzaninotto @willdurand 
maybe this code is dead ?
Mmmm.  Fair enough.  At least it is completely local, so it doesn't introduce any new thread headaches despite the magic.
e.g.:

/*
 * Manual network card setup help 2/4
 * translators: do not translated udev, MAC, BusID
 */
Yes, thanks - Will change.
I was thinking that after the meeting and the discussions doctrine/commont won't be a requirement for zf2
"The is_string() check handles the $location undefined condition, raising a notice, but returning a boolean correctly and not failing"
-> The method shouldn't raise a notice - it should be checked if $location exists before:
{code}
isset($location) && is_string($location) ? $location : 'unexpected type: ' . gettype($map)
{code}
Because we have a new Zend\Math proposal coming I think makes no sense now to spend time to refactor that interface.
I don't see the need for import this.
"UNDERLINE_DOUBLE"? Do you mean "INTENSITY_BOLD "? :P
And space after //
I totally agree. This is only there because I didn't want to diverge too much from the demo I based this code on (shiny-teapot) which _does_ do several error checks in the draw loop. :(

https://github.com/KhronosGroup/WebGL/blob/master/sdk/demos/google/shiny-teapot/demo.js#L271

I'll remove the checks from this demo, and we'll want to revisit the other ones soon.
--min-version 1.0.2
?
Rename this to `staging`
We shouldn't be changing the name of the curated feed.  It's already "windows8-packages" right?
You use push on one array and preallocation on the other... Why not use the same for both?
deprecation notice. deprecatd na yung "Given, When, Then" sa loob ng mga steps. dapat "step" na
Ok, I see what you mean :)
`propertyNames` is being looped through twice here.  I think it makes sense to write a custom function that will loop through `propertyNames` once and divide it up in an equivalent manner.  Since `propertyNames` is not likely to be a large Array, this optimization can wait until after this Pull Request is merged.  Please add a TODO to optimize this.
Yes.  When compiling glyphy for example, in my link line I have:

-lbz2 -lz /opt/local/lib/libfreetype.dylib

Now, what I want to happen is that I drop the bitcode for those three files in emscripten/system/lib and everything just work.  It was working for the first two because I added emscripten/system/lib to libdirs.  For the latter, this change was necessary to convert it to a -lfreetype style essentially.

Humm.  I haven't groked the test suite yet.  If it's easier for you or @ehsan to do, go ahead.  Otherwise I look into it later.
I'm not sure we need for two loops here. I believe you just need the `sum` and `sum_of_squares` to get mean and std (one loop => higher arithmetic intensity).
So we can save a bookmark for ourselves from a /works/####/bookmarks page (lines 39-42 add the form that pops up).
I'll test!
cool, good to know
Also, here I would like to see a comment that says something like:
```The badges only apply in the manage app so there's no point going on if you're anonymous```

However, What if you ARE logged in but not browsing the manage pages? Then we have to do all of these Approval queries for nothing. No?
Actually, wait disregard that comment. I see what you are doing now.
> It would be insightful for me to hear the arguments for defining the class inline as I would have chosen to make another file (I like small files).

I don’t like very small files if that means I have to find a file that contains code that’s logically related to the file I’m looking at. Classes in Ruby are cheap to write and we have proper namespaces, so an inline class is sometimes more clear as it’s visibly a composition thing (i.e. extracted code), without given the illusion that the class is really useful on its own.

Having said that, I’m in no way a fan of large files either, so if it’s more readable to move it to its own file, then please go for it :) Just make sure to namespace it under the current class to ensure people understand it’s probably a part of it.

> It would be also helpful to hear if you have any other stylistic critic/observation to point out, even nitpicks :-)

Don’t worry about it, I _will_ given critique, even when not asked for it ;) I just try to balance it out, as there’s no point in me trying to have influence over *each line* of code. It only takes time away that I could have spent on other things and also does not help in motivating collaborators imo.

So I try to maintain a balance between what’s actually important now and give little hints/tips here and there, to keep people motivated. Over time that means that we will cover most issues, as I don’t generally need to repeat myself.

Anyways, sooner or later I will come across some code that I have to change anyways, at which time I will ;)
The issue was that you were mutating the collection while enumerating it? Hence the `files.dup` call?
You don't need to set .site or clear it in the ensure block below. That's done in activate_session and clear_session
Isn't this file a duplicate?
No, that was a bad merge of mine. Scrumbled it up by using TortoiseMerge and different line endings, sorry for that. I'll come up with a fix for that in an hour or two. Did a recheck of things while merging with lenis0012's request and found this error as well.
"Connected !" -> "Connected!"
probably safe to assume if `css.length` is 0 that we never had the css file at all IMO, not a huge deal if the user somehow removes all their css everywhere and it ends up being empty after that
CS: No need to have blank lines here (only after `break` instructions)
Please fprmat this the same as the rest of the file.
This is a surprisingly expensive line of code.  If you can use a more regular class, or avoid all the meta-magic that is implicit in Strict, that might actually be better...
feedback implemented in f99f6decbc1bef3e6b97beb1ddc0865a4dafcd5e
We've been using oae-util castToBoolean in other places.
Should be above principalAPI
What happens if not every app node across the clusters agrees within 1 second?
+1. My personal preference though would be to use `forEach(function(p) {...}`
I don't think I'll change this just so it's clearer in **our** code what the default is without having to dig into helenus source.
Wouldn't it be the case that if configToExtend[colHash[0]] && configToExtend[colHash[0]][colHash[1]] && configToExtend[colHash[0]] &&[colHash[1]].elements[colHash[2]] didn't exist, the config option would no longer exist and we can ignore it, causing the filter function below to no longer be necessary?
This pattern comes back on line 201. Any chance it can be wrapped in an updateQuery function in OAE.js ?
Ah, sorry, I see what you mean now. Yes, we can move it outside.
暂时的方案是把验证全交给 `validate` 处理，`validateReturn` 只处理样式和返回值相关。
Seems its handled already as you mentioned. Let's do this.. leave the ClosedSelectorException handling code as it is. I will pull in the null check alone? Please open a pull request for the leak, if you reproduce it again and include detailed information on how you reproduced it.
:+1: So let's remove array_merge from here :)
and initialize it
Haal de comment weg
предлагаю сортировать прям в запросе. так быстрее и очевиденее, что ли

    @question.answers.order(:created_at)
Yes, I also thought we could __later__ add a user setting for choosing .

But anyway, each kind of build needs a default behavior regarding . So doing it this way is logical and harmless.
You can also consider this hack as a feature request for autorevision :smile:
"...are Base64-encoded and enclosed in the strings:"
instead of doing this along with `@hook_mongoid`, why not just call it at the end of the file? Then it should only be run when the file is loaded right?
why do you need an ``x-slides`` parent element? Isn't ``x-slideshow`` enough?
Can't this go as well?
This should be `[NSDate date]`, since it returns a unique object each time (unlike, e.g., `RACScheduler.mainThreadScheduler`).
Great, sounds like a good idea. Should I make these changes?

Best,

Jonny

--
http://jonnycampbell.com
@jonnycampbell
+44(07)516 060 168
On Saturday, 20 October 2012 at 17:56, Josh Nichols wrote: 
> In src/scripts/hubotagainsthumanity.coffee:
> > + "Glenn Beck catching his scrotum on a curtain hook", > + "A big hoopla about nothing", > + "Peeing a little bit", > + "The Hustle", > + "Ghosts", > + "Bananas in Pajamas", > + "Active listening", > + "Dry heaving", > + "Kamikaze pilots", > + "The Force", > + "Anal beads", > + "The Make-A-Wish Foundation" > +] > + > +module.exports = (robot) -> > + robot.hear /(card me)/i, (msg) -> 
> This and /card 2/ can probably be combined to allow 1 or more cards. Like:
> robot.hear /card(?: me)?(?: (\d+))?/i count = if msg.match[1] parseInt(msg.match[1]) else 1 for i in [0..count] by 1 msg.send msg.random answers 
> May need some testing, but you get the idea.
>  —
>  Reply to this email directly or view it on GitHub.
As a side note: You might want to disable dumping hubots brain since it will contain the passwords in clear.
The `.*` and the start and front aren't required.
`|| uploader.identifier.blank?` is our problem here. It's returning if it's blank before checking if it should write an empty string when remove gets set.
Adding some string to mean no error doesn't sound right. When there is no error, the message to show (if you even show it) depends completely on how your application chooses to show data (e.g. git will show the old and new hashes alongside the branch name). A particular string from the bindings which could change (and becomes untranslatable) smells too  much like a hack with a lot of potential for biting everyone in the arse.

The way I've implemented this elsewhere is to only return the errors. You know which references you wanted to update to which hash because you just asked for it so you can report the rest went well. I suppose this might need coordination with the library proper.

Or you could add a `bool EverythingWentFineDontWorryAboutIt` to `PushStatusUpdate` (or conversely `bool OMGTheWorldAlmostEnded` which if set would let you know to look in the message so you can pass the string to the user).
Great. So let's throw if it's empty, then :bangbang:
ıt is [] as default. the tagreader wouid return None if no int is written...

On 28.12.2012, at 15:46, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
> 
> > @@ -1203,7 +1203,7 @@ def read_ica(fname):
> >      ica.pca_explained_variance_ = pca_explained_variance
> >      ica.unmixing_matrix_ = unmixing_matrix
> >      ica.mixing_matrix_ = linalg.pinv(ica.unmixing_matrix_).T
> > -    ica.exclude = exclude.tolist()
> > +    ica.exclude = [] if exclude is None else exclude.tolist()
> this suggests me that exclude should default to [] and not None and never be None. Rather than tolist() that will only work on np.array use "list(exclude)" that would work on any iterable object.
> 
> —
> Reply to this email directly or view it on GitHub.
>
i forgot to change it 
:(
Ahh, got it! Ok, thanks!
But the call to Context.getAdministrationService() will still fail and also a call like Context.getLocale that doesn't get to the serviceContext will be get trickier, i find stub cleaner since it is only one line
I think we also need to do this upon contextRefreshed(), because it seems likely that a module will end up storing this token on some class that is reloaded when the application context is refreshed.
"Per default" should be "By default"
I don't know what the official style is, but I'm not a fan of blocks not being the last variable passed.  If that's correct it's cool, but I would prefer to have the block passed last.
This isn't needed anymore. Forgot to delete. My bad.
This should probably not have been deleted, but `__alignx` is only a compiler hint about alignment properties to aid with automatic vectorization, so this shouldn't break anything.
spot 同理
No quisieras ni siquiera implementar la interfaz de `IRegisteredObject`? Me preocupa que se venga abajo la app en general y ya no funcione más esto. La otra opción es ir por una app de consola. Me parece simple, pero perdemos AppHarbor.
If its intended as a `System.Windows.MessageBox` replacement, it should replicate that behaviour, which doesn't show anything in the tray/taskbar/whatever the actual setting is.
I think I copied and pasted the doc from the previous predicates...
space II: space harder
Could you make this step default to the ';' separator and update the scenarios accordingly?
When I have to create methods which raise a specific exception type over methods that don't, I often call them "blah_or_raise" to distinguish them from the other ones. 

In this case the method being wrapped does raise, it just raises a different type, so I guess it only is more readable to me because I'm used to that pattern which isn't even being applied here. I guess taking "or_raise" off makes sense.
Ois kiva jos olisi tehty merge ihan ite, ilman `sort`:a.
I wasn't sure what switching to 1.2 would entail, so I stuck with version 1.1 (I also kept the 11 in the name of the test).
added pNoDiacr argument to ptest() which contains the keword regex without diacritics. 
This way there is a handle to know whether the matched keyword is the real one or the diacritics counterpart (with or without diacr).
It's minor like many PEP8 and related style changes, but to me, "2.0" is *much* better style than "2."