labofsahil/github-event-dataset-2012 huggingface dataset:
This caption element should not be empty. The point of a caption is to provide an accessible title for the table, i.e. to enable users to quickly identify the purpose of the table. Since these tables are in the admin section of the site and the administrators have inside knowledge then in this context this isn't such a big deal, however I think it is good practice to always include the caption and also a summary, these elements should always be present for tables presented to the public. A table summary is an attribute on the table element and provides information on the purpose and structure of the table to help users interpret the tables contents. For more information on accessible data tables check out http://webaim.org/techniques/tables/data
I put it there (in plugin cleanup) because it is the way it's done in geany's filebrowser plugin.
But I agree it would be better to save the state at the end of configure response.
我要保存文件到gridfs,但是不知道怎么写,上面那个示例我试过,不知道那示例意思是不是创建一个test.txt然后上传到gridfs.如果是这样,那我没有成功过.另外我做个人网博客想把html保存到gridfs不知道是不是好注意.
update these to the 5.1 schema
Using table names in the class Meta *is* letting the models get out of sync with the tables. Even though it is clearly stated, and less disruptive than say db_column, it introduces an element of redirection that I would rather not have. I'm pretty sure that the main reason table_name exists is that django doesn't ship with a schema alteration api. Since we're using south, that doesn't really apply to us.

Still, in the interest of not causing a service interruption, I would be fine with using table_name in the short term, until the admin_refactor comes through.
Sorry , I was talking about types.h but the interface seems to delete what's between brackets...

The error reported by TheMaister seemed to indicate there was a conflict with another types.h file (/usr/include/sys/types.h ?) and stdlib.h.

types.h is unused anyway so it shouldn't be there (I accidentally added it in some commit while working with C89 changes)
Setting hq_fm to 0 gives me slightly better sound that sounds at least remarkably like a Mega Drive/Genesis, but still very scratchedy. 

I'll upload a WAV recording of this for you.
І так далі по спекам
un selecteur par ligne (plus simple d'en ajouter ou retirer, + de clarté lors d'un changement pour voir le diff)
Wouldn't ```sorted.getClear()``` be better?
ftr: follow up discussion in https://github.com/liip/LiipVieBundle/issues/9
these guys work independent on each other... you can't blame leak for mess caused by megamage (if there is some mess)
After this is bugged pet react, they doesn't attack while has passive or defensive react...
a bit of formatting, making things easier to see in first sight 
some lines got shorter, in general I should keep a maximum width of 120 character per line
up to 110 chars looks good, everything above that should be shorter
It is indeed. I fixed it initially in my working copy and only then cloned the repo and made the change again, should have retested it though. =\
This introduced an annoying side-effect. When you press enter in a comment block it indents the new line.

```coffeescript

# four score
  # and seven years ago
```
This commit is the epitome of perfection in complexity...in code.
This will fix the problem, but this method seems brittle to me.

Shouldn't we be doing some attribute exclusivity testing? (Of course, this would be a breaking change so probably not possible in 2,1)


	<aggregator id="aggregatorWithExpressionsAndPojoAggregator"
		input-channel="aggregatorWithExpressionsAndPojoAggregatorInput"
		output-channel="aggregatorWithExpressionsAndPojoAggregatorOutput"
		ref="aggregatorBean"
		release-strategy="releaseStrategy"
		release-strategy-expression="size() == 2"
		correlation-strategy-expression="headers['foo']"/>

is allowed, but the ref always wins regardless of the sequence...


	<aggregator id="aggregatorWithExpressionsAndPojoAggregator"
		input-channel="aggregatorWithExpressionsAndPojoAggregatorInput"
		output-channel="aggregatorWithExpressionsAndPojoAggregatorOutput"
		ref="aggregatorBean"
		release-strategy-expression="size() == 2"
		release-strategy="releaseStrategy"
		correlation-strategy-expression="headers['foo']"/>
> That's simply meaningless: it breaks cross-validation where the number of
> samples vary accross folds, or between parameter tuning and training the
> final model.

It would also break the refit at the end (with the entire dataset).

I wonder if scaling_C makes sense only for unconstrained primal
algorithms or also for box-constrained dual algorithms...
Um, I know it's well intentioned, but please, don't *ever* do this. You should put it in `buildout-dev.cfg` instead.

eg. for postgresql sites needing psycopg2:

    [buildout]
    extends = buildout.cfg
    eggs += psycopg2
I believe that this is better. Never is it more add exceptions. 

The error was mine. The code is clean and easy to understand. In agreement!. 

Im agree!
why did you take off `default=datetime.now`? What purpose was it originally serving?
对，可以写个导弹攻击。
Typo here, "eslif" => "elsif"
Can we have some pro's & con's about this one versus opening brace on the same line?
It looks rather like a preference rather than based on technical details.
In the absence of true technical merits on one vs the other, I would like to propose to base this on the popularity of both schemes as well as on a votes.
If it was the bug you were talking about, then I think this fixes it.
@dirtyvagabond
BTW, no one dies if you will be more informative on your presentation...
Something else you should provide:

adb shell cat /sys/bus/sdio/devices/*/* | grep -B3 MODALIAS

If it doesn't repeat identically, paste it all, otherwise paste one of the blocks.
Hey Felipe, please commit the CSS in the same commit as the SCSS changes, to ensure we don't get into unnecessary merging trouble.
Bliver sjovt at printe hvis animation.
Yes, let me fix :)
It's only been a handful of dists, and I think the change is a good one overall. It's not like this is a complicated change.
>post.Visib
>.Visib
Мде.
Hello,

I have this working on Mac Snow Leopard. (Awesome btw) Using macports was the way to go:
sudo port install opencv +python26
sudo port install py26-pil
sudo port install py26-wxpython
My other patch which Arif did not commit and dismissed would add hdpi to locales after the language so we wouldn't have bogus language but hdpi resources would still be compiled in.
Just add the following (don't have my PC now)

PRODUCT_LOCALES += hdpi

Bit make sure to add it after en_US
you need to update the vendor/cm project, i will double check this, but cm9 repos were moving fast and i don't had the time to replicate all the temporary stuff on github ...
Do you have any video tutorial about this.
That I can easily use this library.
qwerty.kl is a stock file, and it's built into the system by default. msm_touchscreen wasn't touched, and copying qwerty into a kl file (which is what was done to generate swift_keypad) only serves to silence a log warning (it's the default behavior, too).

Have you tried this at all?
Overall I'm having a hard time piecing togther what happened in this class.  It looks like a method was copied several months ago that was sensible but I'm not understanding what's going on with it since then.  It's seems to be making less sense.  See my comments further down but I think methods aren't encapsulated well (or named well if they're encapsulated right), we're declaring variables in methods we're not using and drifting from an originally sound design.
These files are not needed to support OpenGL.
Good move forward on the button change, makes it a lot easier to add new buttons. However, I think this should be taken another step forward to allow different types of buttons to be generated with the same Button.java class.

Changing the method to enable different sizes and background images to be used would be my suggestion.

I'm willing to make those changes if everyone agrees.
This seems like it could have dangerous unintended consequences.

    file.metadata =  { 'Content-Length' => 0 }

If you go with the above approach where you use an instance variable, you could just set that instance variable and not worry about dangerous consequences with merging directly into attributes.
I would not sign DbUp, strong signing breaks NuGet pretty badly.
Following commit does the trick in better way. In general it makes problems if we extend views while first processing the start.php file, as the extensions will be saved to filepath cache and re-extended on second display after filepath cache refresh.

According to ticket, I didn't create one, as it was only annoying to me and obviously trivial fix. Should I create tickets for each change?
It's the curse of the multiple inheritance. The diff we get back is only indicative of which keys have changed, and we then need to find all values for those keys in the whole tree, since a key can exist in multiple places and have different values in those different places.
Ok, if you are sure then you can of coruse remove it.
This is not a strategy, it's a Directive
This could also get problematic.
no, that doesn't work
if you in 2.2 want to include 2.1 migration guide it will break
also, it's not possible to include the 2.0 snippets in this one
Verrrry niiiice
and then remove these helpers, because the result would be one-liners
We could also look to see if the first character is `{` to know it's json and then embed the actual nsqd version somewhere in the metadata. That might give a little more ability to pivot w/ a little more specific context as to what version wrote out the data.
added tests for the insert-TO selector cases for completeness' sake
containsSequence : one nice feature of fest :)
This should be the latest, definitive reference: https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt
If the test is that simple, can we add it in now?
Again reformat - thanks
Agreed, I'll revert this (it's a little fiddly for something that actually didn't need fixing as the horizontal scrollbar appearing was fixed with the moving from `animate` to `css` as well)
This also sets the content-length for GET requests (and other requests that don't have a body).

I think this should also check REQUEST_HAS_BODY.

See this for an example:

```ruby
require 'net/http'

h = Net::HTTP.new 'localhost', 8000
h.set_debug_output $stderr

h.get '/'

```
It defaults to DIR_CACHE_ONE (and the function is now gone), so nope :)
strtok(3) and strtok_r(3) destroy strings. You should be duplicating entry->vardata (via mowgli_strdup). You would also need to have an additional pointer to the start of the strdup'd string, so the memory allocated to the string can be freed at the end of the function.
There should be an empty line here, too.
:+1: Fair enough.
`memset(groupList, 0, sizeof(groupList));`
I think this works as is.  Since AccumulableParam is the base trait, every AccumulatorParam has to implement both addInPlace and addToAccum.  My version of AccumulatorParam just provides a default definition of addToAccum, so the user doesn't have to -- existing code will still work.

You can see I didn't change IntAccumulatorParam at all (it only defines addInPlace, as before) and the tests in AccumulatorSuite verify it still works.

I thought this is what you were thinking of when you suggested changing the hierarchy around -- did you have something else in mind?
This looks much too complicated, why not simply

```
(double) large_int.QuadPart
```
разбил на два
Should not this a bullet point?
Looks like most browser still show the time input as a normal text field, so the formatted value is shown verbatim. Ugly!

It'd make sense to provide full-resolution time value, then rely on `step` to indicate its granularity.
Originally there was a complex expression that had escapes. This was a quick way to make it easier to read. My refactor removed the need for he complex expression, but forgot to remove the change in syntax.

On Nov 7, 2012, at 1:35 PM, Benjamin Quorning <notifications@github.com> wrote:

> In actionpack/lib/action_controller/metal/http_authentication.rb:
> 
> >          end
> >        end
> >  
> > +      def token_params_from(authorization)
> > +        raw = authorization.sub(%r/^Token /, '').split %r/"\s*(?:,|;|\t+)\s*/
> 4 times in this diff you're using %r/.../ do declare a regular expression. Why not just /.../?
> 
> In my code, I only use %r when I don't want to escape forward slashes in my regex, e.g.
> 
> url =~ %r{^http://.*$}
> —
> Reply to this email directly or view it on GitHub.
>
Perhaps ?limit=x, limit = (params[:limit] ? params[:limit].to_i : 10), type validation would be require.
I have to confess here I'm not totally familiar with how CanCan works.

I'm using `:update` because it seems like `:show` is available all registered users (according to Spree::Ability).  The third argument is absolutely unnecessary, I misunderstood what it was for.  I've removed it in a follow-up commit.
i think it was mostly legacy, i preferred the java indent myself. up to you though, i don't feel too strongly. we could just allow either.
Extra parentheses.
With the representation `i` for contravariant index and `-i` for covariant index, the contravariant index "comes first" so `is_contravariant` seems to me more natural.
Let's leave that for a different PR. They aren't Xpassing here or on the bot.
The test for `conjugate(x) == x` is done elsewhere, so I think this is just fine.
Please, wrap the long lines around the ~80 character boundary and use full stops at the ends of the sentences.  Also, the first two sentences seem to belong to the same paragraph.
```
list.sort(reverse=True)
```
```
>>> r=range(10)
>>> r.sort(reverse=True)
>>> r
[9, 8, 7, 6, 5, 4, 3, 2, 1, 0]
```
I would suggest adding two more lines involving `B - 2*C` and `B + 2*C`.
You should do `map(ZZ, [....])` for each list, so that the elements are part of the ground types (gmpy if gmpy is installed, otherwise Python).
os.name for OS X is actually "Mac OS X" we should remove this setting altogether and rely on default value ${os.name} defined at the top of the file
sorry just another minor point - MAX_BOUNDARY_CONDITION_NUMBER=18, only brought it up since DOF_COUNTS allocated with MAX_BOUNDARY_CONDITION_NUMBER is communicated across nodes.
Again, I think this should be `AngularCoordinateBase` -- we don't want to be restrictive if someone in the future wants to implement some generic `Coordinate` class that handles complex geometries, etc. In fact, if you're restricting it to two angles, it should be `Angular2DCoordinateBase` or something, or maybe we need to think about the class structure in a little more detail.
Bad name, use something like `select_async`.
Drop the redundant `type` attribute. Has never been needed in any browser (and now also finally specified as such in HTML5).
See section 1 in style guid: https://sites.google.com/site/rndbbnorth/cheat-sheet/code-styling?pli=1
 Pls addthe file author and short run description
The comment about the reserved word is good, but I think I would put it into the migration step as opposed to the Hibernate mapping, since Hibernate is going to get removed. Generally speaking our DB column names are not camel cased, rather they are underscore separated.
Agreed, but I'm not sure if this is necessary at this point.
I would try to either put this in a .. seealso:: block or make it into a more clear sentence.
Looks like this test is missing some changes, maybe?
`jinja2.escape` is probably faster unless you need some behavior from sax.
Shouldn't these be template paths now?
Space after ).
Does not actually destroy anything?

Comment should state that nothing needs to be destroyed if this is correct.
Please delete this code instead of commenting it out.
A comment explaining why this is needed would be nice.
就叫 username
K, but that's a strange comment. At least it is not informative :)
Yes, as is, it leaves out groupings with NAs. That's the approach that Wes took with pandas. I think he started including NAs then later in development, he excluded them.
I couldn't specify a desired path to the i18n source files. Sencha is loading the files from a predefined path. I had to duplicate the files for the same.
added the required and deleted the unnecessary.
Is it your intention that this will always be the case?
sem_name should have the same scope as sem (just in case some version of sem_open doesn't create its own copy of sem_name)
"inserstion" hurts just to read it.
shouldn't that be `typeof(date) === 'undefined'`, or is that old school?
Yeah, but since the `OtherModel` should be a constructor, I've uppercased it.
This should be under a `versionadded` 1.5 clause.
I like @jaubourg's proposition better:

    !/^margin/.test( prop )
the text file is removed.
The period is missing.... should be *.xml right?
Please avoid unrelated whitespace changes.
s/functions/site-functions/ ?
All of this is moved into rhc/rest.rb to reduce complications and scoping conflicts.
It wasn't indented 4chars, happy to change back though.
Would we not want to put an expiry on individual messages? It can get tricky as we'll need to send a failed delivery report type of thing to notify Vumi of the failed send, say after a week or so. It's likely that this will happen if people run out of airtime.
Why the white space around the parenthesis?
Mas pravdu Lukasi, tohle vidim jako nejlepsi reseni.

Dne 27. srpna 2012 14:44 Lukáš Lánský <notifications@github.com> napsal(a):

> In progma/users.coffee:
>
> > +      # User already exists.
> > +      if exists
> > +        return callback(new errors.UserAlreadyExistsError(), null)
> > +
> > +      # Create salt and password
> > +      salt = new Date().getTime()
> > +      passwordHash = exports.hashPassword(salt, password)
> > +
> > +      # Create new user.
> > +      user =
> > +        id: userId
> > +        displayName: displayName
> > +        salt: salt
> > +        password: passwordHash
> > +        email: email
> > +        courses: []
>
> Já si to od začátku představoval tak, že objekt uživatele bude obsahovat
> všechno až na velké řetězce (submity), které budou uloženy jako zvláštní
> dokumenty a bude se na ně jen odkazovat. Tak by to IMHO bylo právě dost
> rychlé (přehazovat si megabajtové objekty jen pro přihlášení nezní moc
> prakticky) a právě dost pohodlné (však zvaž, při jakých příležitostech
> saháš na submity – na dva zvláštní HTTP požadavky „dej mi submit“ a „ulož
> mi submit“).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/progma/progma/pull/7/files#r1463739>.
>
>
rebase accident I guess
I would probably change the local variable in this example to `datetime`.
So you need to fix this, commit, and push again.
And yet, when examined carefully, you should find that it isn't. ;)
Technically the dollarsign is a part of the suffix!
How is this method different from dagger.internal.codegen.CodeGen#rawTypeToString ?
I'd make this a constant up top
Shouldn't _currentEditor be passed as the "previous" editor?
I know these test were not part of the task, but a couple common success cases might help to catch errors quicker. Such as:
1. Generic case, "div" exists in list
2. Filtered case by "s" and "span" exists in list.
Why do you need to check for (ctx.token.className === "tag") here? Seems like we would want to bail out whenever (editor.getModeForSelection() !== "html") ?
Ok, that line of reasoning makes sense
OK, but sessionEditor is initialized to null so unless the EditorManager provides an undefined editor there is no reason for sessionEditor to ever be undefined. I'm not sure it's worthwhile to guard against such exceptional behavior, but I suppose it won't hurt anything either.
Looks like indentation got screwed up here
What is the reason for not convolving the gaussian with the entire dirac waveform ?
Right that was my question (we maybe haven't been on skype at the same time
for a while). It turns out you're right:
http://stackoverflow.com/a/4222432/240553, that Django doesn't do anything
clever to stream large SQL querysets. I'll add this before you merge



2012/12/21 Cory Zue <notifications@github.com>

> In corehq/apps/reports/views.py:
>
> > @@ -453,9 +455,17 @@ def _key_to_val(formdata, key):
> >              else:              return getattr(formdata, key)
> >          return [_key_to_val(formdata, key) for key in headers]
> >
> > -    temp = StringIO()
> > +    fd, path = tempfile.mkstemp()
> > +
> >      data = (_form_data_to_row(f) for f in HQFormData.objects.filter(domain=domain))
>
> I suspect that the memory problems were on this line, not the StringIO, no?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/core-hq/pull/416/files#r2489350>.
>
>
assume that you searched for all references and made sure you didn't break them since you're changing the default api?
You could just do `Array.wrap(options.delete(:on_server_roles))` to ensure an array and then you wouldn't need the line below.
I broke indent :) How should it be?
Ok so i remove initialization in DB? Anything else?
yeah, good idea
Remove `window`
Can you indent this whole block properly? Hard to tell where the next div is supposed to start, or if you closed your divs properly.
Can we do all the above var declarations at the top ( where we can ) instead of broken up like this?
I'll solve this. I didn't saw this part. But I thought you say look at the tree,not looking at the candy?
13fb3d812de82a11fd621da0b24486e34f7161a9
huh? why exit?
that's my point, just deploy the zip files instead, nvm I'll do it
This shouldn’t be needed, because it’s specified as a library underneath. Did you need to add this to get it to work?
I think the caches are TTL aware now :)
is this line necessary if setup defines @dev_key?
It seems like the default behavior should be ":notify => true, :async => true".  In other words, we shouldn't need to pass anything in this case, but in those other cases where we do not want to generate notices, we'd pass in something like ":notify => false".

I agree with the statements and goal that ultimately we should and need to generate notices for CLI/API actions.  It will allow us a level of auditing/tracing that we do not have today.  When that time comes, by default, we won't want UI popups for CLI/API (this can be controlled today through the 'viewed' attribute on a notice); however, we should allow for the possibility that CLI/API may need to generate a popup for some 'special' case (not sure what that may be at this point).  In addition, we may want to add an element to the notice to indicate if it originated from UI or API.  This may allow for improved debugging to determine how some action was performed.
These block references should be copied, but released afterward.
Thanks Alex, Brad mentioned this too. I'm going to do that now and then update the CSS.
leftover, this will break |make offline|
Maybe filterclear '*' instead of separate filterclearall ?
all changes like this  grammar change should have been in its own commit, separate from all other commits
Can those 2 be merged into 1 line without breaking any other important infos? Would be a nice thing.
Yes it is but no one looks in the startup menu, and if they do they see 'Bitcoin' they can guess it's the UI. No need to fix what is not broken.
@laanwj Alright, as you did not respond, let me re-phrase, are there any further comments left, when I revert that single change :)?
Should be 'AuthComponent'
Using functions inside strings this way is bad.
Why commented.
Moet dit eigenlijk niet altijd een 302 zijn? Want als de default-taal switched is het eigenlijk niet correct.
I see that you are using a list of regular expressions, but each list has one element.  Do you think we really need the list?  It would simplify the code if there was just one regexp per mode.
Yes, I presume it's something that changed in matplotlib.
Something not *quite* black is always easier to read. How about `#222` instead?
This is not a trivial amount of memory. Why are you bumping the size of the buffer?
As `git clone` also has a big bunch of command line options, do you plan on something like arrbee's `git_repository_init_ext` (#844)?
Please don't include whitespace-only changes :)
This url is wrong, and it also should use url()

{{ url('mozorg.mission') }}
Usually we use template helpers to generate hardcoded URLs, but not I'm not sure it's worth it to go through all of here and do that.
shhh, i hate putting CSS in the HTML but I don't see any other good option here :-)
What happened to this text? It gets removed here, but doesn't get added elsewhere as far as I can see. The bug doesn't talk about removing it.
s/when/WHEN
That strategy is also explained here: http://docs.python.org/py3k/howto/pyporting.html#capturing-the-currently-raised-exception
Debian does not use PHP GC by default because of access rights. Settings some defaults will not solve the issue with access rights, it has to be solved at a system wide level.
we should check that Finfo is actually available.
or go all out with Relfection if method_exists() fails .. it would only be done in the constructor ..
It could be another configuration param ?
Should be ```!==```
``the bug`` ? Which one ? Keep in mind that the phpdoc is meant to be useful also (and even mainly) after code is merged
throws docblocks goes after return
this is wrong. The constructor needs to receive the input and the output to call the parent constructor, otherwise getInput and getOuput will return ``null``
This is wrong as it means that the user cannot change the translation domain in a subform even when passing the option explicitly
@fabpot but is gc enabled locally ?
http://kerryb.github.com/iprug-rspec-presentation/
この資料とか
"RSpec を使い始める人が読むべき N 個のドキュメント | Aiming 開発者ブログ" http://developer.aiming-inc.com/rails/rspec-references/
など読むといいかもです。（t_wadaさんのやつとか。
あ、あとこれ
"RSpecによるユニットテストの書き方 - tech.recompile.net" http://tech.recompile.net/post/21340599029/rspec
simplify to `runtime`?
It was originally that way, not sure why. After refactoring per your suggestion below, not sure that does anything, so removing.
i generally leave the ? and :  as the last character on the previous line.. dunno if there is an accepted standard for this tho.
Does this (plus the code below) not mean that the dbg value is always "startup"? I expected the dbg value to come out of the parameters of the V6api calls.
Prefer use of `update_attributes!` here.
Oh right. Good point.
I wasn't getting group invitation private messages. That's what led me to the omission.
I think group invitations controller got forgotten, but I could be mistaken. Definitely worth taking a look at, though.
Not checking expiration of the mask
odd-looking indenting here
You don't need to install Mocha globally, my guess is npm install doesn't automatically install the dev dependencies for you.  It's specified in package.json as a development dependency so it doesn't have to get installed when pushing to a production server.
This should really be dashboard.get('navigationAreaView'), in case that property ever becomes watched for whatever reason.
You can use Flame's prefixed bindings here, which simplifies this to

```javascirpt
isVisibleBinding: '^isResizable',
```
You are right, I think it was bug in compare that misled me! https://gist.github.com/3783892#L117
I like the standalone.bat and standalone.sh changes but not sure we should remove the .conf templates as these are also useful if you don't want to pass in additional parameters to the script.
On 02/08/2012 08:41, Cristian Rodriguez wrote:
>> @@ -43,13 +43,8 @@ const Homescreen = (function() {
>>             Permissions.hide();
>>           } else {
>>             var num = GridManager.pageHelper.getCurrentPageNumber();
>> -          switch (num) {
>> -            case 1:
>> -              GridManager.goToPage(0);
>> -              break;
>> -            default:
>> -              GridManager.goToPage(1);
>> -              break;
>> +          if (num !== 0) {
>> +            GridManager.goToPage(0);
> Sorry, from my point of view I like the previous alternative but talking about it with Ricarco, @rafaelrebolleda , etc said to me that it is the correct behavior, 1click -> landing page, more clicks -> stay in landing page

Can he explains the rationale? I can imagine myself clicking on the home 
key a few times to key out of an application and accidentaly hit the 
home key on the homescreen. Then it sounds buggy it you have to touch 
the screen to go back to your main page. Summoning @joshcarpenter to see 
if he has something to say :)
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla-b2g/gaia/pull/3038/files#r1290533
custom-tag is already defined, right?
I don’t think we can use this selector to define a sidebar/drawer. I’d prefer to use something more specific, e.g. `<section role="region" data-type="sidebar">`.

@etiennesegonzac @vingtetun any opinion on this?
yes, but I'm already using those BBs, that's why I prefer to have those files under that folder. Are you ok if this PR also moves the files to shared/style?
Since this is temporary I will just throw on this end of file and land.
maybe you could use a `hidden` attribute instead?
add spaces based on the indentation level
No problem~
I dislike having returns in the middle of a function like that.

and BTW I don't understand why there is a return... you don't want to render the text of the icon ?
woouldn't be sufficient with assigning selectedContacts to selectableFriends as it was before?
With this test, you cannot type "unknown" to search for unknown artists, albums and songs.  That shouldn't prevent you from landing, but you might want to file a bug to add that feature later on.
Seeing that we're re-parsing the URI multiple times in here makes me think it might be good to expose a `parsed_uri` method off of `VCR::Request` that these can use.  Thoughts?
If this is deprecated, it needs to print a warning at least. Maybe Q_DECL_DEPRECATED too?
You don't have to create it each time,
Also you can use the same one to serialize.
This is my mistake. Hospital wireless only loaded part of the page on github.

I finally got a clone of your branch and see the path. Thought this was in the bin. Now see it is in the path as a lib.

Fine with this, my apologies for confusion.
Why is the code for dangle in Movable? Please move the whole dangle logic into an e.g '''Dangleable''' mixin to keep the file size small and the code testable!
shouldn't be *is_interrupted = false
Put your name first since you're the primary maintainer of this code.
This is fine for a test function for this class but I think you should also create a startup script in the /src directory just like the others startup scripts.
You don't need the %s in the string - passing the exception as the second parameter to logging.exception does the right thing.
а что произойдет если else?
будет пытаться отрендериться вью update.html
that is fine IMHO..  the source will normally NOT talk in more than one channel at the same time, I would assume that the source would perhaps talk in a global chat channel and the irc channel... in which case you would want to talk to both channels.

of course there is the issue that a plugin (or several plugins together) could cause such an issue, but that would be an issue or the plugin.

at least I don't know any other way atm to work around that.
Why not just 

    node['nagios']['conf_dir']
probably better to do this via a single regexp, and modify the chunking algorithm? If this works without a performance hit, I'm fine with it.
Oops, yes indeed. corrected in the commit just below.
``array|string|null`` if you don't like ``mixed``
Here: https://github.com/jnicklas/capybara/blob/master/lib/capybara/spec/session/has_text_spec.rb
Need config comment docs, see above
Here and in Factory, options.Component should be mandatory.
As we discussed in last review on xpcom module, components instances created by Factory/Service should be completely different objects.
For example xpcom instances created by Factory/Service are going to contain unexpected `id`, `contract`, `register`, `unregister` attributes.
I know some code does that and works but it isn't correct.
This claims that the error was in `verify_request`. If that's the only call in the above section that can actually raise `oauth.Error`, then the rest of the lines should be moved outside the `try` block. Otherwise, this error message shouldn't claim to know something it can't know for sure.
Yep, thats cool. I just reused your test, but I'll use the `responds_to?(:times)`
this directroy will move
Hrm; @zaphod42, I don't see the value of that - can you explain why a constant is better here?
So is this a JSON or a PSON terminus? I thought there was a slight difference between JSON and PSON. It also looks like everything else is from _pson()
@zaphod42, can you clarify why that is better?
不得修改 Config.UP_HOST
Why not just always use rb+? Is there a need to do this conditionally? I'd prefer the simplicity here of using just a single mode instead of trying to be clever.
Don't overcomplexify it. If anything is missing, show confirm page. Nothing missing => don't show this page, and nobody gets disappointed.  

--  
oleg dashevskii
Отправлено при помощи Sparrow (http://www.sparrowmailapp.com/?sig)


среда, 25 июля 2012 г. в 18:05, Anton Petrunich написал:

> > export_datetime = begin
> > Time.parse(params[:import][:csv].original_filename.split('-').last)
> > + # FIXME you can't rely on the filename
> >  
>  
>  
> Agreed, but timestamp based update/delete is a part of requirements.
>  
> For my opinion, will be better allow only change/add records via import and add separate option to override all phonebook content with CSV.
>  
> Also we can add second step for import. On first step user select and upload CSV file, system will perform update/creation and collect list of records that not present in file.
> On second step user can review list of all records for deletion and confirm or reject all/individual records.  
> But, i think, all users will be disappointed to review a batch of numbers each time when he want import few new records.
>  
> So, can we use implement add/override mode, or should i implement two steps import?
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/solenko/phonebook/pull/1/files#r1233913
>  
>
I would just use count here.
Because we have only three options here and because I used the standard values of many shell commands  I think it's not a good idea. Generally speaking you are right but in this case I think is not so necessary.
Why the change in visibility?
all `@package` must use underscore `_`
No need for the space
whaaaat?
Not sure if it's a good idea to create a remote object in the initializer...?
If this is a boolean, it really should check the boolean value. As it is, setting allowTerminatedCages to false will not actually filter out the terminated cages.
Ok, comment here please.
Meh, it's a problem there too. Needs further investigation.
@crigor ginaya ko lang siya dun sa time_left method specifically yung line na to:

seconds = start_date_and_time - Time.now

So kung > 0 yung seconds may time left pa?
yes, i think dropping NONE makes sense, two values for the same thing are confusing. PHPCR_NODE says exactly what to expect
I don't get why this fixes the problem. The call to the mkdirs function in Java is already recursively creating all the parent directories if necessary.
Yes, fully agreed. Handling multiple different signals in a single slot should be considered bad practice. I'll add a note to the documentation.
Do we still need the `value` accessor? I think this makes the design only more complex. I would suggest to keep the current `BlockMapping` just for backwards compatibility. I like the Idea of only having WildcardBlocks with a proper description in the future, so I would not extend the functionality of the legacy block. @stmichael what do you think?
Well, if we don't have any reason to use it (I don't think that because 
gimp did it it makes more sense), we should probably use what seems to 
be the best for us. So I would say without the `#` then :)
Fine, the spec should be followed.
I thought the feedgenerator would be in charge of generating a valid feed, but it seems it not the case, so +1 with this patch.
use looseversion here?
On Mon, Sep 17, 2012 at 6:14 PM, Jens Timmerman
<notifications@github.com> wrote:
> Please add a proper sanitycheckpath.

Done
This is certainly the wrong namespace to use, jboss.com has been retired. Do we have guidelines about what namespaces should be used for web services? I guess ideally we would use a URN here, or possibly an example domain like acme.
Because emlibtool is a bit TODO, check it.  Plus, configure doesn't listen to LIBTOOL envvar.
I think there was a reason I chose to left it out of there but I can't recall. So go for it.

Can you add a comment explaining that only production banners should go there. And maybe a how to override banners in `settings/locals.py`.
I love the refactoring... it looks splendid!
Can we fix the tests, then, to follow the 301s?  That's important.  It's why we're testing redirects, after all...
`commit.`
Remove Extra Line
+1 to this. Once the pull request is updated let me know and I'll move along to SR
You probably had it at one point, but with the nonsense of finding the pause/play hack, and how many times you had to iterate on it during testing, I am not surprised it got fragmented and removed. I have done stuff like this with things like youtube.
This seems very high; is it worth having a limit so high?
I mean the property. It should be `is_return_to_page_visible`.
I don't actually know! I didn't actually write that part of the code, I just moved it here from  work.rb as it wasn't getting invoked properly on work deletion.  From the comment, it deletes the first 5 cached pages, but I don't know why.
I might be missing something but where is Controller._get_guest_info called?
This line should probably be:

```
#   @mock.expect(:do_something_else) do |*args|
```
The proper way to check the exception message is with something like this:

```ruby
e = assert_raises MockExpectationError do
   mock.expect(:not_defined_method, 42)
end

assert_equal "expected DefinedConstant to define `not_defined_method`, but it doesn't", e.message
```
Ah, right. My bad. It's a leftover from trying couple different variations.
(Actually thought I'd mention that you should check if the xgb Screen() implementation looks clean enough)
No worries.  You gotta start somewhere. :)
Well, if you dont have a uuid, you dont use a token right?

+1 for doing the short-term list :) I think it would be quicker :)
Yeah... I figured. The chalenge was to keep different loadHandlers isolated (if you bind to load:start event several different loadHandlers) and at the same time keep using "self" to track load progress (because of the reason you described). Just committed another attempt to fix this. It does fix global loading indicator issue without breaking unit tests. More unit tests (to cover loadHandlers  isolation) are coming.
I recommend:

if (connection.isEmpty) connect
dependencyManagement is usually used with parent-poms, not in standalone poms like this. So the version could just be explicit in the dependency section.
Minor comment on the wording here.. perhaps instead of saying "pile", we could say "diagram". I know these problems are called pile patterns, but not all of them look like "piles" and it could be confusing to some students what the question is asking.
in DboSource it is used to set original value back, whihc is missing here.

see
https://github.com/cakephp/cakephp/blob/master/lib/Cake/Model/Datasource/DboSource.php#L1132
No need for the exclamation mark here.
Why the blockquote?
Indeed. For now this is lightway way to designate one use as admin which doesn't involve changing the DB models in either the smart server or the UI server, which keeps this app completely decoupled from them. One thing that would be good here is if I change this to a list, so that more than one user can get the privilege.
наружу.
incase you can't read that last comment, I'm saying that "I know that" and that:

    it_is = default if it_is.empty?

Will always return 'nil':

    1.9.2p320 :008 > it_is.empty?
     => false 
    1.9.2p320 :009 > default if it_is.empty?
     => nil 
    1.9.2p320 :010 > puts if it_is.empty?
     => nil
Ok, done in commit  35d9567.
please remove these //rht comments
If you're already changing the call in this branch, why not change this too?
I believe this should be  ``makro`` at the moment, and it will likely be changed to ``macros`` before 2.10 final release
This check is not required. I would just check for `anonymous?~
This shouldn't have been changed from lookup to fetch. Looks like maybe a find and replace all that was a bit too eager.
$('#toggle-uploads-view').change( updateUploadsView ); cleaner
actually it only creates part of the confirmation message.
While the `for()` loop was functionally needed with the 3 arrays, it's also typically faster and there's no reason to change it to a `foreach()`.
Функция mutate написана своеобразно.

Несколько замечаний:

1) непонятна цель вынесения count из метода.
2) неправильно: нет проверки что изменяемый элемент DNA после генерации нового рандомного индекса ИЗМЕНИТСЯ, вполне возможна генерация ТОГО ЖЕ значения для этого элемента.
3) зачем нужен default в switch?
4) нет проверки что x >=0 и x <=100
Я первую версию смотрел, не финальную )
По заданию таких указаний не было. Элементов в массиве 100 - соответственно и процентное соотношение 1 к 1. 
Делать проверки переданного значения и устанавливать минимальные \максимальные значения - не правильно. Нужно выбрасывать исключения. 
Как я понял, цель проекта - ознакомление с элементами языка и выполнение формализованных требований. В противном случае,  в проект можно было бы включить еще кучу фич, будь то обработка ошибок или минимизация используемой памяти за счёт использования примитивных типов.
Я не ставил перед собой цель написать идеальное приложение, а определение критериев для оценки проекта - это уже дело проверяющего. :)
Каким образом?! Х это процент! От 0 до 100! Если в ДНК 500 ячеек, то 500=100%!
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
опять магические константы (везде по проекту). понятно конечно, что они значат, но с любым ростом проекта - это есть зло.
The Linux manpage says that the function is simply called multiple times, which isn't a problem.
Done and pushed, thanks.
This one for example you would leave public.
This seems to duplicate a lot of the logic of `RACAsyncSubject`/`RACReplaySubject`. It might make more sense to write this using a replay subject with capacity 1, which is temporarily subscribed to when `sampler` sends values.
Most PDFs need to be reflowed to have a barely satisfactory reading experience in K3. So I think it is wise to turn reflow mode on by default.
I'd move these to vote scopes.  Also, the method name is a little misleading.  Maybe `reputation`.
Isn't the whole point of this PR to avoid this?
Yes, as I wrote above I made all these changes after prepending "use strict"; to jquery mobile and having a look at Chrome's errors and warnings.
In strict mode, functions have to be declared at the top of the scope to avoid unintended hoisting. Assigning it to a variable is ok. I could have moved it to the beginning of _create(), but I felt this was less invasive.
http://pastebin.com/bS0TGKwB

this worked for me on a germen debian vm

pleace notice that i have to remove the libjpeg-dev dependency, because it is a virtual package. I don't know why it does not work with that.
Would `InvalidOperationException` or `NotSupportedException` be better options? It's not really a git-related exception, it's just not valid for the current `Repository`.
this tells me that we should have 2 news params that are units and scalings with 

`units = dict(eeg='uV', etc.), scalings=dict(eeg=1e6, etc.`

so no special case for misc

and if a channel type is present and units is not None and not defined for this type of sensor raise an error
so bool

2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> >          include : list-like | None
> >              The source indices to use. If None all are used.
> >          exclude : list-like | None
> >              The source indices to remove. If None  all are used.
> > -        copy : bool
> > +        copy : boolean
>
> In [17]: type(True)
> Out[17]: bool
>
> so I would say "bool"
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1966027>.
>
>
I don't think sample_audvis_ecg_proj.fif is included in the sample data.
Compute sparse inverse solution
true...
options の引数を追加する場合、拡張性を考えてハッシュである方がよいかと思います
same here you need to return after the reject.
```ruby
summary_data.keys.max_by(&:size) + 2
```
?
Please break all the lines approximately after the first word that crosses 72nd character
I actually didn't know that you could work around this problem by changing the output to a path in the bundle. It's interesting, but I think that we should just tell people to *not* use the `@MyBundle` shortcut at all, mention the problem with `cssrewrite` and that's it. Your timing is actually pretty awesome, I had just changed the `stylesheets` example in this doc yesterday to not use the `@MyBundle` syntax.

So, can you rebase against the latest changes, then simple mention the problem with using the `@MyBundle` shortcut syntax? I just want to show people the right way of doing it, and make sure they know quickly when the other way will cause them issues.

Thanks!
It's better to add a newline at the end of file as posix systems love them :)
This I don't like much. Half the point of the filename was that if you have nothing but a folder of JPEGs, you still have a sortable dated list of titled photos. I accept that the JSON/HTML makes this stuff recoverable, but I'd prefer to do that _and_ keep the nice filenames.
Really, I would just send the coverage data once (say as a part of the "complete" event, once all specs are finished) and write generated coverage once as well.

Is there any downside of it ?
$continue would be much better...
¿No convendría agregar cuáles son los story points de cada una de estas tareas?
That is the point of this pull request. The comments you made are in the "OldMessage()" method which I just left in place for now. The method was replaced with the new Message() method in this pull request. OldMessage() is not used at all and can/should be removed, I left it so the active maintainer can make that call.
You should give a CSS definition for bbc_tt that provides the same styling as <tt> if you are going to change the tag.
*sigh* why do people insist on writing the path themselves. You can let Java do this for you with

new File(this.getGame().getDataFolder(), "bukkitplugins");

Much cleaner, and Java handles the separator.
In fact, is more like a factory, since you need to define the type you want to check... :-P
Added XYLineChart with zooming functionality.
That already happens look a few lines above. This stop_service was for the gridcentric service and is just a remnant of this being a moved file in git.
Was there a reason this was rewritten to not use pexpect? I know we've had problems with the pkg module on RDL, but the cowsay tests were running successfully against this for a year, so I'm surprised it was that bad.
Tim said he was working on that. I'm not touching it just to muck w his code :)

Sent from my digital shackles. 

On Apr 4, 2012, at 10:28 PM, Nirmal Ranganathan<reply@reply.github.com> wrote:

>> @@ -133,7 +154,9 @@ def create(cls, context, name, flavor_ref, image_id):
>>             status=ServiceStatuses.NEW)
>>         # Now wait for the response from the create to do additional work
>>         guest = create_guest_client(context, db_info.id)
>> -        guest.prepare(512, [])
>> +        # populate the databases
>> +        model_schemas = populate_databases(databases)
>> +        guest.prepare(512, model_schemas)
> 
> Why is the memory hardcoded... I suppose we were waiting for flavors. Might be good to add it now.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/59/files#r648779
Hmmmm, why do you need this?

What's wrong with returning 'this' ?