labofsahil/github-event-dataset-2012 huggingface dataset:
This should be `copy` to indicate that the path won't mutate.
This example always bothers me. Could we not change it to use the pyplot interface and leave it to simply mention that this can be done in 2 lines with ipython?
Given the lack of definitiveness of this issue in PEP8, I decided to go looking elsewhere in the python documentation to see how it is done.  Indeed, it is never actually stated anywhere how to properly break up the comprehension, but it appears that others also put the break *before* the operator.  I take back my comments and give in to the crowd.
We should use triple double quotes (" " ") for docstrings.
Could you please format this document at around 80 characters?
Done in @f1932b8
Addressed in 88007c8
fixed in 76f8f47
All CSS classes should use dashes instead of underscores, and should be prefixed with either oae- or widgetname-.
This used to avoid failing star searches according to the JIRA associated with it
that code will no longer compile...
"the Extension" doesn't make sense as there's more than one extension, "an Extension" (or "an Extension class") is more accurate. Why was this changed?
Yes @Seldaek, you're right.
Thank you!
again - match the parameter types on the default values
```
customforms::get_custom_form_fields(FALSE,$form->id,FALSE);
```
For some reason I was thinking of text wrapping on phones... Doh. Will change it.
We just set pool_name to NULL, why won't this drop core?
Dealt with: now set illumina2bam.version here.
ahh yes, totally blanked out and forgot about that operator. should I make the change?
I'd suggest just reverting this file...
HEY, YOU TRY THINKING OF SYNONYM FOR MIST THAT ISN'T ITS WHITE TRASH COUSIN "FOG"
typo: creation
We can only accept code licensed with the Apache 2.0 License.
`node.rel` should be `rel.index` ?
also: I think all read-only runtime reflection APIs work (as long as you aren't reflecting over SecurityCritical code). Might be worth adding a C# reflection example, once we get a mirror example in Dart. That'll be a nice way to show how mirror APIs are nicer than the somewhat braindead System.Reflection :)
It seems it will not be called, unless you put this part of code.
реальный автор кто?
might be good to do:

persistence = Flapjack::Web.persistence
check for E_WARNING
That good for me, the arrow you've used seems good, it's not too long.
ups, did not notice that :D -> fixed!
You still do not break .each loop properly. Read documentation how to do that. Just doing `return` continues with iteration.
Why third parameter `''`? Why not without it?
Add all arguments to the callback.
No, CSRF protection through Ajax is done differently in Django.
Have the same style as elsewhere.
Also comment here above, between what this maps.
Push push push. But fix the rest first. :-)
This sentence should be reworded entirely as Sahi is not the recommended JS driver anymore since its development kinda stopped.
You're right. A better name for this property would be `isExpression`. Too bad it's out of our hands.
это не надо
Invalid params. И надо поправить докуентацию к API
+CreatureAI* GetAI(Creature* creature) const
WorldLocation const loc 
Codestyle
Maybe we should just define DISABLE_AOT under native client?
To be consistent with other controllers, we should return code 500. 

raise Aeolus::Conductor::API::Error.new(500, deployablet.errors.full_messages.join(', '))
Sorry, Steven. I don't understand this comment. Why using mean value won't
really look like a default value? Other than this, I have made
modifications according to all your comments. Thank you very much!

Best,
Chen

On Fri, Aug 31, 2012 at 3:38 AM, bethard <notifications@github.com> wrote:

> In src/main/java/org/apache/ctakes/feature/extractor/WordValExtractor.java:
>
> > +import org.apache.uima.jcas.tcas.Annotation;
> > +import org.cleartk.classifier.Feature;
> > +import org.cleartk.classifier.feature.extractor.CleartkExtractorException;
> > +import org.cleartk.classifier.feature.extractor.simple.SimpleFeatureExtractor;
> > +
> > +
> > +
> > +public class WordValExtractor implements SimpleFeatureExtractor {
> > +	
> > +	private Hashtable<String, Float> word_val;
> > +	private Float default_val;
> > +
> > +	public WordValExtractor(Hashtable<String, Float> wordVal) {
> > +		super();
> > +		this.word_val = wordVal;
> > +		this.default_val = calDefault();
>
> Well, at the moment, you're just using new Feature(num), so the mean
> won't really look like a default value, it will look like a different
> feature. I think you probably want to use new Feature("WordVal", num) so
> that all the features have the same name. Then, sure, using the mean seems
> reasonable to me.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bethard/ctakes-temporal/pull/1/files#r1504648>.
>
>
It should be a @classmethod, right?
The label `descend` is slightly counterintuitive to me. It sounds like it recurses down the tree rather than up.  The family tree metaphor tends to confuse me because of this very issue, and I use terms like `leafward / rootward` in my own code.  Can we switch this to something like `subtrees`?
Shouldn't this be `crypt($passwordGiven)` or `crypt($passwordGiven, $someSalt)`?
It's not a problem. Now we have `User impliments UserInterface` and `Social_OpenId` entities. 1:n

```php
<?php
class Social_OpenIdRepository extends EntityRepository // this class should impliments UserProviderInterface
{
	public function loadUserByIdentifier($identifier) // actual this is UserProviderInterface::loadUserByUsername method
	{
		$userOpenId = $this
			->createQueryBuilder('o')
			->join('o.user', 'u')
			->addSelect('u')
			->where('o.identifier = :identifier')
			->setParameter('identifier', $identifier)
			->getQuery()
			->getOneOrNullResult();

		if (!$userOpenId) {
			throw new UsernameNotFoundException(sprintf('User with identifier = %s has not account', $identifier));
		}

		return $userOpenId->getUser(); //NB! we return user, not his openid entity
	}
}
```

Now we provide support multiple connected accounts for user: mailru, yandex, livejournal.
Ok, thank you. I think `identifier` is unique and it can act as `username`.
With OpenVas, we used to keep the report on the server as an "archive" purpose... don't know if this could be benefic...
I think we should allow a Hash to be returned here, empty or not.
This is incorrect, you never want to compare zero decimals. For integer arrays, use ``assert_array_equal`` instead:

    In [26]: x = np.arange(3)

    In [27]: assert_almost_equal(x, x-1, decimal=0)  # should fail, but doesn't

    In [28]: assert_array_equal(x, x-1)
    ---------------------------------------------------------------------------
    AssertionError                            Traceback (most recent call last)
    ...
    (mismatch 100.0%)
     x: array([0, 1, 2])
     y: array([-1,  0,  1])

    In [29]: assert_array_equal(x, x)
@vincentarelbundock 

Is there a reason that you used explicit html links instead of ``toctree``
below I used ``toctree`` for ``importpaths`` and ``pitfalls`` and the rendering is the same
import what you need instead of *
from stats.kstest that tries to cover lot's of cases (no eval please)

```
    if isinstance(rvs, basestring):
        #cdf = getattr(stats, rvs).cdf
        if (not cdf) or (cdf == rvs):
            cdf = getattr(distributions, rvs).cdf
            rvs = getattr(distributions, rvs).rvs
        else:
            raise AttributeError('if rvs is string, cdf has to be the same distribution')


    if isinstance(cdf, basestring):
        cdf = getattr(distributions, cdf).cdf
    if callable(rvs):
        kwds = {'size':N}
        vals = np.sort(rvs(*args,**kwds))
    else:
        vals = np.sort(rvs)
        N = len(vals)
    cdfvals = cdf(vals, *args)
```
I'm never sure whether we should cover everything, it looks a little bit messy.
Is there a reason to return matrices instead of arrays? We don't really use matrices anywhere. This could be very confusing.
Where is 1.5.1 and others?
Why not just put all the properties into the list below (starting at line 207?)
Nobody cares about IE6
Ohhh, the suspense!
No problem.  I'm happy to fix any typos you find.. :)
> ... took the input galaxy positions and converted to radians

I agree.  Which is why I was originally suggesting that you do exactly that.  But you said you didn't want to do that, so this was my proposed compromise.

What I really want is the getShear function to take positions in the current physical units that the user has adopted for the image (i.e. typically arcsec).

This means either having the k values in the `*_power_funcion`'s be <physical units>^-1, or `getShear` converting from physical units to whatever these functions assume about k.
consumer's credits can? be applied.

This is ambigious whether a validation will fail if the consumer doesn't have enough credits.
Hmmm... what's this doing here?
But I just realized it may look like it came in from master because you merged my other PRs which also had this commit on them, so it may have derived from someplace else originally.  The other likely candidate is perhaps this change made it into dca_work_new right before I pulled. That makes sense actually because he was starting to work on the exam things on this branch just as I was setting up to work on parent/child, and I wasn't particularly discriminant about which commits I pulled in from him.

There must be some one-liner to say 'follow this commit back and tell me where it started from, no really'.
again, the input parameter should be `group_items`, no?
the code is not formatted according to fest formatter
I'm confused by the terminology here. Is "AbstractCatalogItem" only for DTOs (which it seems to be based on what extends it). Perhaps it should be renamed to AbstractCatalogItemDto then?
A shame we have to do this. Let's see what comes back from http://stackoverflow.com/questions/12819003/guava-throwables-propagate-and-interruptedexception
Duplicate code? Old code?
When the 20th element of the array is actually relevant to me this will frustrating that we have the info but won't reveal it - it would be nice if there were some way to expand this (even sending it to the console for inspection). Do we plan to show event properties in the right panel? At some point if this is shown there we can have a link to send to the console.
Ok. Check the error message though, its clumsy :)
The filename is still `mongocollection-setreadpreference-002.phpt`. Should that be renamed as well?
three spaces indent
Yeah. I get what you're saying regarding constants. I should clarify the argument that by convention I don't change `SCREAMING_SNAKECASE` constants. I agree that Matz didn't really intend there to be true static constants in Ruby. It's more of a community convention that I try to follow.
it's a todo essentially.
The first line here is a full sentence and should end in a full stop. I'm also not crazy about returning `NULL` on failure. If something fails, we should be throwing an exception and letting the caller catch it if the want. If we really need to return `NULL` here that should be indicated in the return type (i.e. `User|null`) and it should be lowercase as indicated by [PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#25-keywords-and-truefalsenull).
This should not be required, and if, at most, should not be put here.  Space checks should be put in the Cleanup proc, which is called right before this anyways.
This functions looks like a utility function, how storage APIs deal with getting environment variables? If their approach is good then it'd be good to align with them if you think that yours is better then this function can be placed in other place so new services can take the advantage of it.
Should even be: `public SpellLoader SpellLoader = new SpellLoader(this);` to avoid confusion
This looks a little fragile, could we simplify it? Also, it's a sub-element of the footer, so we should find the footer, and then find this element. This would simplify the locator too.
Maybe you could also demonstrate the precomputed method here too when the number of samples `X.shape[0]` is small enough for the whole kernel matrix to fit be able to fit in memory:

```
>>> K = chi2_kernel(X)
>>> K
# Display output to be able to check the diagonal elements and the fact that the first 2 samples in X are very dissimilar
>>> svm = SVC(kernel='precomputed').fit(K, y)
>>> svm.predict(X)
array([ 0.,  1.,  0.,  1.])
```
Shouldn't we also update the `score` function of `DecisionTreeRegressor` and of the corresponding ensemble models?
It used to be the case that score was not part of the required API: if you just implement your own fit / predict estimator you might have expected to be able to use the grid search tools on it.
I think it should be "in" not "into".
I would rather use plt.show() instead to be consistent with other benchmarking scripts.
On Thu, Apr 26, 2012 at 19:55, Ohad Levy
<reply@reply.github.com>
wrote:
>> @@ -49,6 +49,5 @@
>>    }
>>
>>    if $foreman::params::reports { include foreman::config::reports }
>> -  if $foreman::params::enc     { include foreman::config::enc }
>
> where do you include the foreman::puppetmaster class? in the puppet server class instead?
>

Yes, although I already had a class for my puppetmaster with some
other stuff in it as well so I didn't use the foreman-installer module
for that. But I can fix it there as well and send a patch for it,
definitely makes sense to fix that there.

-- 
Erik Dalén
I removed the patterns in 82e80f28d62ca8126b5b0dcec0ed1a5d650b4eec :)
that is obviously wrong, lemme fix
wrong comment -> it returns angle in degrees
add (unit) to describe
Only need to implement the ones needed for anvil, the rest will be implemented in TIMOB-9542
This line will possibly break with LN Builds due to the "."
I partly confused, by thinking and stating that helper->numRows() was already 64bit and hence currentRow/lastRow should be.

Since in fact it is only 32bit, then 1. was ok.

But really 32bits isn't enough for creating large test datasets with this syntax, which is shame, as it would be quite useful for just that.
Well, it's a retry (which cleans the current state for another "run()", so I think it's pretty obvious why renaming back to the original name...
Erp. Never mind, I apparently can't read. Scratch that and reverse it =)
good catch -- I was playing with the available formats and forgot to remove that line
CS -- no spaces required
You're right, I overlooked this, ad42b70 solves this now
bump v to 0.3.2?
@shacker Awesome, this even looks better when resizing now.
@shacker Can we alphabetize these?
Were you able to get the spec's running on your computer?
You can compare sequences to vectors with `=`.
`(first auths)` palauttaa sopivasti `nil` jos `auths` on tyhjä.
if your display label is "nicola de filippo", and you search for "de fil" - to start matching everyone in your family... then your current code won't match anyone.
typo

Also, if !success

Or if not success if you are feeling verbose
Please change this to something more descriptive like "Something already loaded Test::Unit"
`if( !Popcorn.youtube ){` => `if ( !Popcorn.youtube ) {`
Doing this to save and restore the viewport for the viewport quad totally sucks.  We are almost certainty going to move the viewport into the render state, but let me think about all the implications first.
These comments like `// Diffuse Map Material` are almost as good as `i++ // add one to i`.  I would remove them.  If you really want separation between materials, you could fill 80 characters of `///////////////////////....`.
When you merge in master, you'll see the new polygon hierarchy to support nested polygons with holes.  Since all children are within the root, just put the bounding sphere around the root.

Also, add a comment somewhere that says that the bounding volume is just around the boundary points, so there could be cases for contrived polygons on contrived ellipsoids - very oblate ones - where the bounding volume doesn't cover the polygon.

Wait till we add terrain to the mix...
That works?  I didn't know tar could deal with zip ("pkzip") archive files.
split android/builder.py into separate args to path.join
For the second comment: 

If that is the case, then maybe you should check explicitly that it's not 'true' instead of checking for undefined and null.
Typo `statue`->`state`. Might mention that apps in this state might be terminated if a low memory situation occurs
Maybe we should check first if `modpath` is already part of `MODULEPATH`, and only add it if it's not?

Also, add a comment to explain why we need to do this, i.e. to ensure that we're installing the extensions in the correct environment (the module for the 'parent' environment is loaded somewhere later, right?).
can you plesae mention that it is alternatively possible to change the database to use?
Yes the footer part should be kept in the new template.
I don't think this can ever be false now that we have UFCS. if `put(r, e)` works, `r.put(e)` should too under all circumstances.
OK @jmdavis, since you're here and you're so prolific let's finally fix this string check crap. Here's how I was thinking: commonPrefix should have two overloads, one with an alias predicate and one without. The one without the alias predicate does the algorithm with the assumption of the equality comparisons, and the other is conservative. What do you think?
But perhaps you intentionally made it work this way to always pick the largest possible alignment on any system? If so, should document that.
Shouldn't this be Pascal-cased, as it returns a template?
It's a tiny little nitpick, but drop the word 'different' please.  There's nothing wrong with exec'ing the exact same command, even if a tad unusual.
Not sure if this is the right location for this example file.
Why not `folderParents`?
this is done in the constructor already
If `doc` is a XUL document already, you don't need the call to `createElementNS`. It's only if you want to create an element in a different namespace, say, a XUL element if you're in an HTML document. Unless simple prefs are HTML documents?
I'd rather change the `oauth/authorization/token.rb:17` to return the fragment with the `AccessToken#expires_in` instead of `#time_left`.

Mainly because `expires_in` response is in seconds and it does not seem right to return seconds with decimals (like 3659.01231).

The OAuth spec is not clear about that, but it seems right given the example. http://tools.ietf.org/html/draft-ietf-oauth-v2-23#section-5.1
That's because we don't have the how-to yet. When we get it this content will appear here too.
The change is great! I think it'd be great if you can:
- Move this method to `WindowsAzure/Common/Internal/Utilities.php`
- Add the function to underscored prefix to function name `_getGuid()`
- Add a header comment to mention that this is replacement for `com_create_guid()` because it's windows specific.

If you don't have time i could do these things and I'd appreciate if we can get that from the start.
make this more explicit.. like if I'm on the iPhone or something
`Array.concat()` does not modify the array in-place, but rather returns a new array containing the concatenation.
Also, since `.getNodes()` is just an xquery on an element, please try to construct a single query which will pull url/metaurl at once and by that avoids some of the intermediate arrays.
add custom sanity check
Lack of coffee when that line was cut and pasted.
lo que voy a hacer es agregar otro metodo que use ese, así:

public Asiento adaptarNuevoAsientoConPrecioPara(Usuario usuario){
//ok, nombre de mierda, hay que pensar uno mejor
Asiento asientoAdaptado = new Asiento(this.vuelo, this.aerolinea), //no se si se puede hacer esto, es como inception de asientos xD
asientoAdaptado.adaptarPrecioPara(usuario);
return asientoAdaptado;
}

y ese mensaje sería el que habría que usar en el for en la agencia. Así tenés otra collection nueva con asientos nuevos modificados, y el hecho de mostrar el precio final no tiene efecto sobre los asientos originales
код был украден и вставлен
again, "map" feels weird. I don't think this comment adds anything useful, I'd just remove it.
Can we use `.hide()` instead?
An out parameter would be appropriate but we can't change the signature of `rt_init`.
I think you could use a common D function.
```d
bool rt_init(ExceptionHandler dg, out bool passedTests)
{
  // rt_init code
}

extern(C) bool rt_init(ExceptionHandler dg=null)
{
  bool ignore;
  rt_init(dg, ignore);
}

int main()
{
  bool passedTests;
  if (rt_init(null, passedTests) && passedTests)
    tryExec(&runMain);
  else
    result = EXIT_FAILURE;
  rt_term(null);
}
```
My first thought based on some other places we've implemented pools is that the returned object itself would be a wrapper.

For example, when dealing with "Connection" instances we can often use a proxy, implementing the same interface, but then modify the behavior on close ON THE ITEM so that it releases. Obviously, that's not a generic solution and therefore wouldn't really apply to this simple pool concept.

Seems like "tracking" is the only real option if we truly want to *enforce* the behavior. Since a sized pool is bounded by definition, maybe it's not a bad idea to maintain references to allocated items?
Should comment that setIsFunction() is the replacement.
Why is this debug line here
this shold be definaed as an interface, you're preventing classes extending it form extending other classes
And you ;)
The Paypal digital goods are exactly the same as regular express, except it requires the digital goods item category, and should have noshipping set, since you can't ship digital goods.
Mixed tabs and spaces throughout?
What would you think about that?

```python
possible_states = (PRODUCTION.STATES.done, PRODUCTION.STATES.none, PRODUCTION.STATES.paused)
return len(self.production_queue) > 0 and state in possible_states
```
"The item **must not** have an id."
I think it should be 'in San Francisco'
more strictly speaking and to be fully accessible this should be something like

```
<ul role="listbox" aria-miltiselectable="true">
   <li role="option" aria-labelledby="so1"><input type="check" role="presentation"><span id="so1">Option 1</span></li>
</ul>
```

that can be a good reason to try to simplify and have

```
<ul role="listbox" aria-miltiselectable="true">
   <li role="option">Option 1<input type="check" role="presentation"></li>
</ul>

```

thus we can save the aria-labelledby and as a result be more concise
This phone number RegEx makes a few wrong assumptions about telephone numbers.

Country codes are 1 to 3 digits.

Country codes begin 1 to 9, never 0.

Country codes should be written with a + sign, like +1, +20, +44, +682, etc.

The + sign might be replaced by an international dial prefix such as 00, 011, or others.

Area codes can be 1 to 6 digits long.

Some countries don't use area codes.   The shortest valid number is of the form +290 3555.

 The longest number should be no more than 15 digits, including country code.
This should be calling ``filter_or``.
No. But no user should be overriding `TiAnimation` in the first place. If the module API doc is for overriding only, it should not contain many of these classes or protocols. If it serves as documentation regarding what is available, then that is a different target.
I'll need to update the plist template to change value to string with default set to cloud.
Eiether way the in place upgrade will work with the existing BOOL values.
do requirements really have a priority
please use `wp_redirect()` instead of `header()`
Can we use something more descriptive than 1 and 0?
@tohman -  added another console.log
`_calabash` ist schön nichtssagend, ggf. `calabash_bin_path` oder so ?
`$(D std.typecons.Typedef)`
This won't achieve the same behavior, will just result in method, args and kwargs as 3 positional arguments.

In addition, I don't think saving a newline by creating the task and populating on the same line is worth the loss of information (first task, then populate task with work).