labofsahil/github-event-dataset-2012 huggingface dataset:
let's add second parameter to the lastIndexOf: `lastIndexOf('/', end)`
In tests, i'm listening to the OutputStream with something like : 
```
$output = $this->getMock('React\Stomp\IO\OutputStreamInterface')->getMock();
$output->on('data', function ($data) use (&collector) { $collector[] = $data; });
```

which fails as the interface does not have the "on" method
I think that we should clean up state as a best effort here, since we can't cover all cases. When we see a `ConnectionError`, we know the connection is gone and thereby state is gone and we don't need to call `#unwatch`. When we see any other error, we should make an attempt to clean up state. A user may raise his/her own error based on `StandardError`. A corrected version of my earlier snippet becomes:

```ruby
begin
  yield
rescue ConnectionError
  raise # Re-raise without doing anything
rescue StandardError
  unwatch
  raise
end
```
Wywali komentarz, niepotrzebny jest
How about 'concat_ignore_file_error'?
Does it really make sense to use an anonymous function here to implement this? I feel like this would make more sense to live in the RELS classes, so that it could be used for other things, say copying rels statements from one item to another.
This should be `ifeq( $(USE_LIB64), 1)`, no?
I do not think we had consonsus whether to remove, or keep and point to something.
My vote is to remove Disclaimer and keep rest of link.
Point "Terms of Use" to:
http://www.redhat.com/legal/legal_statement.html
import os is not used
well it's really a function, which is why i didn't really cal it template. i'll rename to templateFunction
For some reason the command doesn't work if I create it in the callback...not sure why. I came up with an alternative solution though.
The command becomes:
            SendMessageCommand = new RelayCommand(
                () => SendMessage(NewMessage),
                () => CanSendMessage());
CanSendMessage is:
(_connection != null && _connection.State == ConnectionState.Connected)

Hopefully this is a bit cleaner, and it's a better way to do it, as the RelayCommand takes a CanExecute function in the ctor.
ok, I didn't remember how broken Perl was... you're right!
Ditto here and below on the missing `object` base class.  It really doesn't likely make a difference but it can't hurt either. Old-style classes do have some differences and I occasionally get confused when I encounter one in the wild.
maybe you should give this `urlopen` call a timeout?  You'd want to get the time from a configuration item.
I agree, though as I mentioned above, this is actually how autosummary stores its templates, and I couldn't find a better way to do it. If you figure it out, open a pull request on my fork and we can merge that in to this PR.
I only have one live wallet with RPC access at the moment, so I wasn't able to test your setup exactly.  But I did create 10 new keys in my wallet, and I made a sendtomany raw transaction that sent something to each of them, then signed it offline and relayed it through a different node.

http://blockexplorer.com/tx/7650e6a4ef61485a3f6c44fbeaa1063c6ea0bbe4bf040fb91c6fd71888a81677

That transaction triggered walletnotify exactly twice on my box, once when it entered the memory pool, and once when the block containing it arrived.  It doesn't trigger for each input or each output of a transaction, just for each transaction-event.

I like the named pipe thing too.  I'll look into it.
And this are still only 2 spaces ^^.
Method name should be `next` instead of `Next`.
Should be ```@requires``.
Should we user an "https" URL (as for the other submodules) rather than a "git" one?
I would like to see a comment over each of these fields explaining what it means, especially "state" which should tell me the different states.
In other places in the code, there are defines similar to `#define SockName_state_UNASSOCIATED 1` over the structure definition to make it easier to keep track of the states.
Missing lie break between param and return
As in... we don't need the if statement.
Thanks for the feedback. That all makes sense to me.

I've never used mocks myself. Any chance you could refactor a test or two to include a mock? And/or send a link explaining how and when to use mocks? I'm wondering if you're suggesting we change all of the controller specs to be using mocks, or just this spec? And what about model specs? So many questions...
find('row')
I looked more at this point and, changing the signature from

```scala
object ELParser extends Logging {
	def apply[T: ClassManifest](string: String): List[Part[Any]] = {...}
}
```
to :
```scala
object ELParser extends Logging {
	def apply[T: ClassManifest](string: String): Validation[E, List[Part[Any]]] = {...}
}
```
has a huge impact !

For instance here :
```scala
abstract class AbstractHttpRequestBuilder[B <: AbstractHttpRequestBuilder[B]](httpAttributes: HttpAttributes) {
    def queryParam(key: String): B = queryParam(Expression[String](key), (s: Session) => s.getAs[String](key))
```

then, queryParam() would need to return a Validation[E, B] etc ... so, at the end, I really don't see the point of it. 

It seems OK for me to assume that the construction of the Simulation with the DSL can throw some Exceptions. 
We may just want to catch our own exceptions and display a nice message. 

What do you think ?
Thomas Kluyver skrev 2012-05-09 21:38:
>
> We can get rid of `with_statement` here - we already dropped Python 2.5 support, and it's native in 2.6+.
>
ok I'll remove it
Cleanup stray debug code here.
> then just have a static module-level default_encoding variable, rather than calling getdefaultencoding() each time

`utils.py3compat.default_encoding` or `utils.encoding.default_encoding`

If the latter, then I should probably change all the calls to `encoding.getdefaultencoding()` to references to `encoding.default_encoding`, correct?
Same here, this should be a string, not a list.
You were right. The code is now much simpler. Thanks!
A `done` state sounds superfluous, specially if it's only going to set `keep_looping`. You can just skip it.

```
while (!finished) {
  ...
  if (something) {
    finished = 1;
  }
  ...
}
```
OK. I don't see that in the style guide anywhere, but I'll trust you.
You shouldn't need to check if these exist before attempting to change the attributes or removing them, doesn't jQuery just do nothing if the selector doesn't match anything?
In this case, we use the error message in the UI to tell actual human users what prevented their product to be added. A lot of the validation is done directly in the SQL function we use, and that function raises humanly understandable errors that we want to return to the UI.
There is a typo at line 87
Scopes please!
The code of the test is exactly the same than the previous one. Simply merge both data providers together
it could, yes. It depends if you want to ensure there is a deprecation warning here. But the drawbacks is that you would hide a NOTICE or an ERROR too
Why do you have an array here? You never register more than one error handler.
I don't think ``INF`` is a sensible default for the limit on the while loop
This one is wrong IMO. This class is a BC adapter so you should be warned if you pass a factory implementing only the deprecated interface (and you won't be warned byyour own implementation generally)
A way to do it more efficiently and without having to use the array by reference (and used in some other places)
This is not part of this PR - the method were just moved within the file.
let's measure first, cut later.
I will add it, if only because of the lame example :tangerine:.  I just don't see why, if the divider is not even a subview of the splitview, that anyone in their right mind would want to reference it in the draw block.
@remh spaces between arguments.
SocketOutput::send_header_to_server appears to include the null terminator in the length, which would make the +1 here unnecessary.
Nice. Changing it to that.

On Thu, Sep 20, 2012 at 1:40 PM, John Ledbetter <notifications@github.com>wrote:

> In server.js:
>
> > @@ -41,7 +42,15 @@ io.sockets.on('connection', function (client) {
> >
> >      // info/err msg listener
> >      ircClient.addListener('raw', function(message){
> > -      if (message.rawCommand.match(/^\d+$/)) {
> > +      if (message.rawCommand == '331') {
> > +        client.emit('raw', message);
> > +      } else if (message.rawCommand == '332') {
> > +        client.emit('raw', message);
> > +      } else if (message.rawCommand == '353') {
> > +        client.emit('raw', message);
> > +      } else if (message.rawCommand == '366') {
> > +        client.emit('raw', message);
> > +      } else if (message.rawCommand.match(/^\d+$/)) {
> >          // "Is it numeric" - is this the best characterization of a info/err message?
>
> how about
>
> switch(message.rawCommand) {
>   case '331':
>   case '332':
>   case '353':
>   case '366':
>     client.emit('raw', message);
>     break;
>   default:
>     if (message.rawCommand.match(/^\d+$/)) {
>       ...
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/cjstewart88/nirc/pull/9/files#r1653326>.
>
>
The referenced ticket provides a more elaborate reasoning behind why this cleanup is necessary. I would like to have this documented in the code comments as well.

If this is a general problem consider submitting this as a patch for the DIBS module instead of implementing it here.
serializization => serialization
I agree that Git is kind of a lingua franca from collaborative development these days and everybody developing should at least know if not generally use it. Technically there is but no direct implication from (web-)developing (in javascript) and using/knowing Git. I would consider imposing such an unnecessary requirement bad, because it might be too high of a hurdle for some users. Less users in turn means less spread of use which lessens the projects value.

To clarify: By users I mean users of chosen, which may in turn be most likely developers of something else, but that is another topic. From the perspective of this project, there are people who work on chosen and people who do not. For the former, the project can/should/does set a version control system and through that a directory structure. For the latter, it does not.
It is still a private module that they should not be using as though it is public - by flagging as private it is flagged that it is subject to change, anyone who needs a stable API to reference these services should have already contacted us to request that.
Use `this` inside event handlers.
instead of inline code this should be in a separate function
You may want to do this check once in the constructor and store a flag.
instead of deltaX -> direction
It's not in the diff here, but createTab sets iframe.src for popup windows.  This also nukes potential POST data to the popup, so you shouldn't do it for windows opened via window.open.
nit: ChangeSelectByValue -> changeSelectByValue to follow the function naming convention.
Not sure if the lighter format should be "200" could you double check?
I would imagine you could listen to some hacky event like when the DOM element is being inserted or the attribute is being updated or something...
I don't see how it would work...
If I have the contact, I have the mozContacts permission and can add the number myself.

If I need a PICK activity first and then add the phone number with an EDIT one it looks like a really complicated user flow...

What we could do is have only the `new` activity, and in the contact app handler ask the user if he wants to create a new contact or add the data do an existing one (this could be done in a follow up pull request ;)).
Yesterday i've done a PR to upgrade custom_dialog.js and confirm.css with the latest specs, so as soon that PR lands we should take care un updating this code:

https://github.com/mozilla-b2g/gaia/pull/6220

This will be generayed on the fly instead of having it hidden on the DOM

For now, looks ok!
Quasi-nit, recognizing that this code is copied from elsewhere.  It might be advisable to use hasOwnProperty instead of "in" in this case or to use __proto__: null or its Object.create equivalent.  Specifically, since you're using it as a dictionary that does not seem to have tightly constrained domain constraints, you might find things get broke because of stupid attributes that exist on Object.prototype.  Like, .emit('watch') on SpiderMonkey should still betray you, I think.
because its no longer wrapped by an `<a>` tag the header BB does not do its thing. Please change this to a `<button>`.
Yes, unfortunately, that's why I need this function :(
// it means that alarm screen is underneath the oncall screen.
                                  ^^
Actually it is not the best to implement comparator in that way. If you need especially this sorting then it is better to define next to Set it is used. The problem of that compareTo  is not that someone will use it wrong, but  the function is incorrect for Comparator! Imagine A contain B but C doesn't intersect with A.
So comp(C,A) = 0, comp(C,B)=0 but comp(A, B) = 1. I suggest you never do such comparisons and sorting because it highly depends on the sorting algorithm because you function is not transitive. So some algorithms can give your result [B,A,C] - expected but some can give (!) [B, C, A] !!

The good way to implement compareTo when you can convert object to a number and then compare numbers!
P.S.: I already have one of that weird issue in production so be attentive with compareTo ;)
How to reproduce the crash?
What that file for?
This needs to be here, someone needs to own that directory and common is required by all of the other site package related RPMs. Double check that it doesn't make it include all source, but if it does then we have the same issue in the RPM support as well.
That isn't a bad idea. Except that is a LOT of logic to move into the razor bin away from core Slice logic. The problem becomes looking at everything like a CLI. Which doesn't work well with API logic.

A Slice return may for API (XML/JSON), iPXE (Script), CLI etc. All of which is determined within the Slice right now except for CLI vs. API.

We have a single place for Slice printing in slice_util. It isn't determined in the Slices right now directly. What is determined in the Slice is what objects and what order the objects need to be returned. I am strongly against overloading the razor bin vs. more elegant middle abstraction around slices.

I honestly don't see what the problem is here that would require anything drastic yet. But likewise open for discussion. We just have a lot of working functionality to jack with for a small return with this one issue.

Would rather focus on the feature adding.
fwiw, I don't think ivars within an object need to have leading underscores. Pretty much the only time I use this is when I'm adding something from an external source to an object; but something that I do not want the object's methods to use directly. In this case the list of mappers is part of the registry state, so I think it should be named how you'd expect.
Мне кажеться, что было бы лучше написать **"Отправить"** вместо **"Послать".**
I use this style to express that the view only knows about the intent of the user, not what should be done with that. `signUp` is the domain of the model, there it doesn't matter if the user clicked a button or something like that. 

Each domain has its own terminology:

* templates -> view: onXClicked / onXChecked etc. (expresses events in the DOM)
* views -> controllers: userWantsToDoX (expresses user action and intent)
* controllers -> model: signUp / rasterize / save / delete etc. (expresses business logic)

does this make things clearer? :-)
Thanks.  Wasn't there a way to parse the decimal part into something meaningful, though?
@skaes maybe we could just wrap the code in:

    if [[ " ${rvm_configure_flags[*]}" =~ " --with-opt-dir=" ]]
    then
      rvm_warn "Please note that you are using your own ' --with-opt-dir=', make sure 'libyaml' is installed and available for ruby compilation."
    else
      if ! libyaml_installed
      then libyaml # Installs libyaml
      fi
      rvm_configure_flags="${rvm_configure_flags:-} --with-libyaml-dir=${rvm_path}/usr"
    fi

It's the simplest solutions which provides only warning for users wanting to use they own optional packages location.
Erase these lines, since they appear to do nothing.
DU VOLLIDIOT
```
$form['foo'] = array(
  '#theme' => 'table',
  '#rows' => $rows,
  '#header' => $header,
);
```
This is fine, but for what its worth named functions are often nicer since errors include the function name in the stack trace of errors.

```
> var whoami = function () { throw Error('arg') }
> function named() { throw Error('woo') }
> whoami()
Error: arg
    at Error (unknown source)
    at repl:1:34
    at repl:1:2

> named()
Error: woo
    at Error (unknown source)
    at named (repl:1:26)
    at repl:1:2
```
Rather than throwing in br's, you're generally better of creating another paragraph.
please remove this, it is downgrading evernote
Instead of `AMQP_UNUSED` why not just not give the argument a name (just a type)?

That will squash any kind of warnings about unused variables (portably), though readability suffers.
technically should probably add a 'break' here
Right. So, originally, this is was my reasoning: "EC2VMManager should only allocate _something_, not necessarily a VM object, the instance should be created only when you call the obj.create() method". At first it made sense to allocate the AMI information, but then that made importing existing instances weird (the image may no longer exist?) and then later updating the allocation information was weird (how do I add the _instance_ info to the existing _image_ info?). In theory I could deallocate and then allocate with the whole dict, but that seemed hacky. I totally agree this does not feel like we're allocating stuff, but now you know what I was trying to do.
As I know, <code>-Wl, -rpath</code> needs to depend on *exe* file's position.
If using *Makefile* to build linux project. The *exe* file will be generated at **cocos2d-x/samples/HelloCpp/proj.linux/bin/debug/HelloCpp**.
Therefore, we need to go back 5 folders rather than 3 folders. Right?
I don't know if that was done automatically or by you, but it's not correct. The extra spaces were there to align with the array below. Please revert (same for the line 22 change)
we should vendor this file.
It looks like all branches except *sbinary* and *sbt* are incorrectly printed. Shouldn't you print the $`SCALARIFORM_BRANCH` instead of `$scalariform_branch`?
we call
Rails has [Date#past?](http://api.rubyonrails.org/classes/Date.html#method-i-past-3F) for that ;)
Yes, but I think there is a corruption which is seen in this particular code.
Nit: Formatting comment made in other cases.
The question was about our own sessionstore entry for NTT. Per default the sessionstore.js file will contain the list of all the windows, tabs, and groups. So if we would query the session store service we probably could retrieve the last active group on startup, whereby we wouldn't have to store our own property.
What happens if no tab group exists anymore? Would we carry around the last name forever? Or is there at least one group in any case?
Fixed in https://github.com/puppetlabs/puppet/pull/629
This is actually quite costly, since it does a lot more work than just extracting the canonical name of the type.  It would be better to go over into `Puppet::Resource` (or `Puppet::Type`) and extract the code in there that does the canonicalization, then call that.
Sure, can't see any problems in that
Rescue accepts a PartialFunction, so you can remove `e => e match {...}` and just use case statements in the body of the block.
'surf' is the name of a module. 
Will change the name now to distance_surf, which is more descriptive
@denixport only `extends` was affected by that note
No, i don't think because abstracthydrator check strategy with hasStrategy() :

array_key_exists($name, $this->strategies)
               || array_key_exists('*', $this->strategies);

If strategy don't exist for $name, it will be exist for wildcard. I see you have added check and exception for more precaution. Thanks :)
ah of course, i was having a 'senior moment'!
The list of params doesn't match with the method signature
even if there is this will be cleaned by a commit for updating vendors so not a real problem
After looking in more detail, I think listening to the CanvasSizeChanged event would cover both the normal zoom case and the document switching case.

That event is triggered in MainWindow.ActiveDocumentChanged and from changing the CanvasSize on line 102 of DocumentWorkspace.
these two methods meant to be only proxies to service $this->events() method. Service itself it's not event collection itself.
Sorry for my English :)
So, should I change it or all is ok with it?
This is not required, it's set by default to this value.
To make a link in markdown, do something like this:

```
See [this page](http://...)
```
Yes not clear yet, but basically even if you move a document before you can still reorder its children afterwards without problem ...
@lsmith77 I think MOVE and REORDERED have nothing to do in the state. These documents are still managed.
On Fri, Oct 5, 2012 at 1:19 PM, Edi Modric <notifications@github.com> wrote:

> Can't find it ATM, but I think that somehow setStatus is called before the
> status from Message is processed, so Message can't overwrite it.
>
This is a todo anyway. It'd be great if you could find it :-)

--
Bertrand Dunogier
Lead Engineer Extensions
eZ Systems AS | skype:bertrand-dunogier | http://www.ez.no/
---------------------------------------------
Freedom to Create Your Experience - Join us at this year's Conference
http://cologne2012.ez.no

eZ Publish Enterprise 4.7 Available
http://ez.no/About-eZ/Events-News/News/eZ-Publish-Enterprise-4.7
Code style: space after comma
can't you use the 'sources' setting here?
or at least the name-version
In toolkit it's log.debug, but after checking, it seems there isn't really a reason for that... Fixing.
`os.listdir` might add a big overhead.
There is no need to be generic here, since we know what we are doing, other people using a different scheme will also know what it is.

I suspect people will want to either use one directory, or adopt our a-z + 0 scheme. 
I'll add a short description of why we do this + an explenation to the FAQ  about this.
*nods and tries to look intelligent* I don't /think/ it's an HTML thing (it's for Rails 3.2.5+), but I have no real way of testing it out as I'm not sure whether or not my browser is HTML5-literate. (It's Chrome. I've had it for ~2 years, although it might have done some fiddly automatic updating that I didn't notice.) The older version of 'data-disable-with' is ':disable-with', so I guess I could try that if the newer one doesn't work for older browsers.

Where do you want the third suspension point? I can stick it in.
You could stack these array assignments if you're all about that kind of stuff:

```java
flags[x][0] = flags[x][ly] = -1;
```
Duplicating the code and the event execution.
Not that it matters much, but the `ZU` shorthand and the `ZU.xpath()` function are 2.1.something and up (iirc).
`s/destroy_build_older_than/destroy_builds_older_than/g` :)
上面的简单啊
Ah.  good point.  Thanks.  Will refactor and resubmit.
Move this method/code to a page inside the plugin pmReports
Well they evaluate left to right, but I think that you'd want to be sure of the object type before you call a method on it, though I should probably be asking for a base'r or parent class. Either way this was a pain in the butt when it happened :)

with 5.1 in mind i guess i should have used is_a() ?

-Scott
maybe we can pull out most of this functionality to another utility so we can call it from other places (fab deploy would be the first obvious thing)
_Uw_ and _nieuwe_ are mistakes, I've corrected those. 

Though quite long, _wachtwoordversleuteling_ is still a [compound][1] and hence a single word. Compare _[langetermijnplanning][2]_, _[hogesnelheidslijn][3]_

[1]: http://woordenlijst.org/leidraad/6/2/ "Compounds, Official Word List of the Dutch language (Het Groene Boekje), Dutch Language Union"
[2]: http://woordenlijst.org/zoek/?q=langetermijnplanning&w=w "Langetermijnplanning, Official Word List of the Dutch language (Het Groene Boekje), Dutch Language Union"
[3]: http://woordenlijst.org/zoek/?q=hogesnelheidslijn&w=w "Hogesnelheidslijn, Official Word List of the Dutch language (Het Groene Boekje), Dutch Language Union"
If the local authentication fails it will return with:
 * statuscode: 401
 * body: `Unauthorized`
This should check for err as well. If the provided contentId can't be found, hasAccess will return an error.
As implemented currently, `macro` is a keyword only in certain contexts; in other contexts, it can still be used as an identifier. My suggestion is that we use a simple heuristic to guess when doing the basic syntax cololuring, because we can get it right 99% of the time (and `macro` will become deprecated as an identifier over time).
len already declared
Just for me ... is that coding style or any further stuff behind?
ik zal font er nog even uithalen
если массив инициализирован с еденицы, индекс последнего элемента (100) не будет использован.
cвойства инициализуются в getter и обращаются к ним через .
Ну, есть и такие, кто NSSet случайными индексами заполняет с проверкой, не содержится ли он уже там
Но я бы посмотрел, сколько итераций такой алгоритм бы попадал в последний индекс при необходимости 100% мутации
As we discussed in the email, we do not need assignment_id, since we can get the assignment by the submission_id.
Technically it should only be specified during `configure`, not `build`.
and what about process.platform == 'freebsd' ?
I think a better way to handle this is to use 302 temporary redirects on the website and keep the actual files on the sf file upload portion (this assumes that sparkle works with 302s but I seem to recall that it does).

Furthermore when there is not a beta `changelog_beta.xml` should be a symlink to `changelog_rc.xml` and when there is not a release candidate `changelog_rc.xml` should be a symlink to `changelog.xml`
Shouldn't need this anymore. Version number is populated from package.json
multiple servers; each server used in a search MUST receive the same search ID.
As above, this can be obtained from the invocation's `methodSignature`.
set "new.fids = []", otherwise calling new.close() fill close the files associated with self
Of course another obvious option is to write and delete the file on testing..
yes it is, I'll move it to raw.py and make sure it's the same function in both PRs
the same for this statement. Why is it here and what does it do?
See above re: magic number
The test would even be better with at least 2 properties getting added
Well the OpenmrsData interface defines setters and getters for uuids. It's your responsibility to map them in a hbm or with an annotation. BaseOpenmrsData is not different here, unless we start to do it properly and annotate BaseOpenmrsData with @MappedSuperclass to enforce the uuid property.
tipically vs typically
I called the function _read_timestamp, I also added a begin/rescue/end block, in case the timestamp is malformed. Feel free to pull in the changes and then rename/refactor as you see fit,
Unfortunately if you do this, you will change the global state which may affect other tests.

We usually don't test such hooks, so feel free to skip the tests.
Yes that would be simpler -- I was just following as close as possible the actionrecord uniqueness validation code, which has ````record.send(:id)````:

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/validations/uniqueness.rb#L26
Removing this is wrong. The autoloader won't work if it is not loaded
yes. it's no problem.
I should have added a comment. There is a good reason for it. The include is treated after the velocity, so the $doc.use($debobj) is not contextual to the foreach loop. The same object was displaying three times.
hmm, this method now has a rather large discrepancy between what it says and what it does. I think it should just unstashAll() and super.preRestart(), in that order. Then if the queue is full the supervisor will have to decide whether to kill the guy or not. I don’t think it should silently swallow exceptions here, and special-casing AkkaException sounds rather arbitrary.

(in case you wonder: ActorCell will catch any exception thrown from here and wrap it inside ActorInitializationException before telling the supervisor of this failure)
Please consider renaming it to be renderItem or renderAttribute. Thanks.
Es que no hay basura, todo se vuelve a utilizar en algún punto.
Good idea. Should use render_json_response for simple objects such as a dict. render_json_object_response is for serializing Django models. Wanted to preserve the previous functionality for those that are utilizing render_json_response.

With that said, I'll be committing changes shortly.
wh``at?
No we do not. Good catch, I've updated the code.
How do you know that the upgrade operation worked fine? I guess you need some asserts here?
@maniksurtani  if there are edge cases where it is valid that a non-owner attempts to unlock then we should document them and not log any warning. As far as I can think of there's no such situation. Are there any suite failures if the exception is re-thrown?
Ok, makes sense @mmarkus . I'll include it in new commit with a JIRA attached to it.
@idan In fact there does not exist "multipart/form-encoded", but only "multipart/form-data".
Should I modify this to "numpy" syntax or leave it as it is? The only modification I've done here is set the 79 caracter limit.
Huh, looks like I just patched the code directly in there. Good enough for me; merge away.
забыли.
используется при сеттинге параметров очередей. например, для указания нод, на которые миррорятся очереди.
Well I prefered the return too but that had to do with the cxf plugin. When I remove this part totally, I can rewrite this to a beautifull way
I don't feel that this statement is clear | intuitive. We've talked several times about this feature, and when i read this, I'm not really sure what exactly this means. *Truthfully, I think we need to start some detailed documentation on how to properly configure and utilize osTicket*
Do you want that in this pull req or another?
@bp323 done in a follow up commit
whitespace missing: trainlab, int32_t itr)
set or get?
html5shiv doesn't add `addEventListener`, just the new html5 tags (and default styles). It'd have to be something specific for adding `HTMLElement.prototype.addEventListener`, I didn't know if you were adding that in somewhere else or if CodeMirror does it. But yeah, using `$.fn.on` is probably The Right Thing To Do (TM) in this case.
As you can see, dump was a couple of revisions back: "filename" was replaced by "file", which was replaced by "source", AFAICT.

I'm not sure I should be looking up all "source" entries, but that's what I did -- essentially, instead of looking up "filename", I look up "source" and dump out its value.  It seems to work, but I wasn't sure it was correct.
Please add "true" as parameter to leave out entries that are not within the time frame
I usually do that, but not when the block is inside a loop. If we move this declaration to line 697, it means AVM will destroy and create that variable every iteration. I don't  know how bad it is, but if I can save that small performance breath, I choose to do it :)
makepkg is correct. It's an ArchLinux command to build PKGBUILDs. You run it in the same directory that a PKGBUILD file exists.
Are you sure the method ``setMinimize`` can be called on ``$this->filter`` (of type ``object<Assetic\Filter\HandlebarsFilter>|null``)?
Please try to maintain the original formatting
Even though global.hostSeenMOTD isn't defined if you haven't started a server (this runs when any map starts), this will work fine due to the 'and' operator being exclusive, thus the check would end at global.isHost.
I'd like to keep styling preferences out of the JS, so please remove lines 100-109.  

This is just the sort of thing that users might want to vary from instance to instance, so they can just throw their prefs in CSS.
`before` code-quoted
algorithm -> an algorithm
смотри комментарий к PR#7
A more explicit test here, then, would be testing that NormalizedVideoList works as expected, which we also do elsewhere, or that SearchQuerySets work correctly. I suppose that I could just assert the length of the popular videos list.
This was just here because if someone goes straight to the rubycas server they just get a page saying they are logged in. I actually wanted them to go to something more useful like our main service. Also if they were already logged in and went straight to the rubycas server the same thing happens.

So if you had https://sso.example.com someone can go directly to that page and they get stuck.

Mos tof the time you want users to log in via a service such as https://service.example.com but they might not. This way you can default where they should go if they go straight to https://sso.example.com

I think as you point out below this was because continue_url was not coded correctly, and I can't remember what the specs say on that.

I've rolled my own solution since my initial playing around with rubycas-server so might be best to close this and submit a new cleaner patch. This patch was just a stepping stone that got it working for me how I needed it to work.
comments should be at the same level as the code, and start with a single #
This paragraph contains duplicate information as last paragraph. You should somehow resolve this.
Good idea. But go to lower case. ;-)
So it can not set a choices??
No markdown parser supports smarty highlighting so it's better to remove `smarty`. Also there shold be newline before `~~~`.
Need to pass `std_cmake_parameters` to cmake here, which, among other things, will instruct it to install into Homebrew's Cellar rather than whatever its default install location is.

```ruby
system "cmake #{std_cmake_parameters} ."
```
If the context can not supply an instance of the `RandomNumericSequenceLimit` type the result will be a NoSpecimen request. The other case is to setup a Stub in order to return an instance of that type (instead of `null`).
I did. For some strange reason, though, Sublime kept on changing it.
Combine conditionals to use elseif
Please use more spaces :)
85285?
There should be "password" in this sentence instead of "username".
CheckArgumentNull
Yeah, definitely, but I talked to the author at ADASS and he was quite interested.  I'm thinking we wait until 0.2 comes out (and we update the package template) and use this as an test/example of how to "re-package" existing work into the template.
I'm liking it actually! There's some batshit insane stuff I had to do for the sinatra tests to have something run before everything and after everything (no before :all). This here though is using RSpec mocks in MiniTest, not that surprising it doesn't work. MiniTest even has mocks just the latest isn't included in Ruby.
Don't use a `button` outside a `form`.  Simply convert it to a link:

`<a class="btn" id="startMySQL" href="[% c.uri_for('/db/start') %]">[% l('Start MySQL') %]</a>`
Since the user should *really* start mysqld, you could remove the dismiss button.
Why implement LoadMetadata if none of the methods are implemented? Would a subclass potentially want to not implement getSchema? If so, we shouldn't force them to here.
Victory, you have finally fixed that grammar error :)
This surely is extraneous...
I think this should not be limited to `th`, .not-content is also used for some messages, like missing headers, or when we can't display data of a certain type. I should probably add a test, but you can see it when you follow the steps in https://bugs.opera.com/browse/DFL-3590
It's a bit weird to have `request_id` just next to things like `resource_id` and `document_id`, because `resource_id` is almost like a constant, as soon as it's set it will never change. `request_id` is just for mapping the right events to the entry, and can change.

But I guess `resource_id` and `document_id` aren't constants either, since their final value is not defined in the constructor, right?
Let's namespace these under server, similar to client, above.

`default['mysql']['server']['packages']`
Shouldn't all these `ngx_fetcher` files actually be `ngx_fetch`?
`InitRequest()`
It looks like the only param that is used is cf.
Yes, because you removed it. Please add the "libtorrent::" to get rid of these useless changes in the patch.
Oh, I see. The only issue then is that your `virtualenvwrapper.sh` needs to be executable (`+x`), otherwise it won't be picked up by `$+commands`.

As you only source this file, it would be better to just check if the file is in `$path` (don't know yet how to do just that, I'll look into it).
# TODO: documentation
( + maybe move `fit` before `fit_exact` and `fit_random` so that a new developer can understand the purpose of these three methods just by reading the code straightforwardly).
so you could end up with aaa,bbb,ccc ddd in the log files? meaning this message was related to three transactions?
BigInteger payloadSize = new BigInteger("0");
for (theContentObject) {
  if (stuffIsNull) { break }
  payloadSize = payloadSize.add(message.getNonXMLContent().getSize();
}
If you agree with me on the above two points, then this is the only thing left in RadialProfile.  Does it still make sense as a base class?  Or should we just define this function as a bare function for helping to deal with the multiple sizes?  Are there other advantages to having an intermediate base class for radial profiles?
Likewise on the next line.
```
Ellipse e(s)
```
Ah, I see now.  Yes, I think you are correct.  It looks like this will be the size passed to the numpy fft functions.  That's probably not so good.
I'll leave it up to you but you can rely on the same UUID generation strategy as MessageHeaders by accessing static filed  idGenerator from MessageHeaders and than generate the id using it if its not null otherwise random.
Should mention somewhere in here `gradlew eclipse`, `gradlew idea`, etc.
You mean to use a ".*" version?
same as previously, variable definition shoulb be placed at the top of template.
Should be `Collection<? extends Location>`.
These static conveniences really do feel like a code smell, but not certain what a better pattern is and at least it's in one place.
If we were worried about speed, wouldn't we be testing `typeof a.equal == "function"` instead? It's really fast, and it tests what we really want -- "is it safe to invoke this function?".
Nightmare code xDDD
작업을 액션이라고 부를께요. 개발자들 사이에서 액션바의 Action과 Action overflow등은 대체로 그냥 음역을 했던 경우가 많은 것 같습니다.
this pattern can be condensed to

````ruby
def foo(blah)
   code
   code
   code
rescue Exception => e
   blah blah
end
Ahhh, now I see. Yeah, the message should reflect that, as it is now it looks just like all the other expected ones
Couldn't see any other read ops for it :)
I think I may just switch it to `is_int || is_float`.  Any issues with that?  I think it's more clear all around.
search on the service object is a utility function to start a new job.
If I understand the comment correctly, a `ValueError` is being ignored that is thought to be impossible to occur. If this assumption is incorrect, then the bogus exception will be ignored silently.

Why not let this unexpected case bubble up and make the test fail to notify us of the incorrect assumption?
any particular reason for adding try catch here. Not against it, might be required at more places too.
Keep as it was after discussed with habib - pzp.config.name is not used here
Hmmm, I guess yes.
This is still a temporary hack until mrbkap’s wifi backend attaches an ssid property to evey 'network' object. There’s a lot of idiot-looking code in this file because of this ssid bug.
and btw, your check for the case where ``$this->property`` is null is wrong: you do the opposite of what would be logical according to loadUserByUsername
Yeah a good solution would be
HwSettingsBoardName so they still group together.  I'd prefer not to block this issue for it but will if you guys feel strongly.
Nice!  I was just thinking this would be a nice other flag to have
Сделай тест, в котором будет вставлять несколько значений (несколько параметров). Увидишь баг.
Prefer 2 lines for clarity:

int singleBenchmarkRanking = 0;
int sameRankCount = 0;
Why are we using search_term as a global variable like this? We use other apps for search in the other test files, so there is no need to access them from other modules.
you don't need the parentheses
For standard barewords like `present` and `absent`, adding quotes doesn't really improve readability. The style guide doesn't say what to do here, but I prefer to *not* add the quotes.
Hm, the current convention I followed all the time is to leave out the default parameter value as it is directly visible in the function signature - in correspondence with @tonysyu. Both visible in the documentation and when you use `help()`.
By default, a decision tree should not be random. Hence `max_features=None`. 

Note however that `max_features="auto"` by default in forests.
Hi, Satra, thanks for all your feedback. It is very valuable!

On Tue, Oct 09, 2012 at 08:50:39AM -0700, Satrajit Ghosh wrote:
> shouldn't this conversion be done in the code that's doing the eigen
> decomposition? it seems out of place in a set_diag function.

Maybe the name is not well chosen, however it does make sens to do the
conversion here, as it is code that is factored out in situations that
need to control the diagonal and prepare the matrix for and eigen value
decomposition.

I'll add a docstring, and if you have a suggestion for a better name, I
am all ears.
I still think this should be called `X`. We follow our own naming conventions rather than those of [fill in subfield of ML here], since otherwise practically every module would have to follow different conventions.
No uppercase after the `_` in the lowercase variable naming convention. And same remark as above: I think `positive` is specific enough. Also this should be a constructor parameter rather that a fit parameter, see:  http://scikit-learn.org/dev/developers/index.html#coding-guidelines and it particular: http://scikit-learn.org/dev/developers/index.html#apis-of-scikit-learn-objects
Just curious: this is the first time I see this kind of she-bang line in a  Cython file. What is it supposed to do?
Is there a preferred format for author infos?
Please, don't call it Activity, Activities in android have other meaning, it is confusing. measurmentHelper, or something like this.
Yes, this is very valid and intentional (non-accidental) assignment. This is a common idiom to test match _and_ capture it's results for further processing. This could always be replaced with more verbose:

m = /.../
if m
  firstnames = m.post_match
else
  m = /.../
  if m
    ...
  end
end

might be clearner, but probably the verbosity is also harder to understand and easier to break later...
This is a lot of code to duplicate. Is there a way to make no_null and no_fail to create a set of boolean flags/pointers and fall-through, so that the next implementation can use it?
Ah, yes of course.
same here - I suspect this doesn't compile on windows.
row was a better name for this variable - my objection was to using it in the inlinetable when it isn't a row.  Just use a different variable.
No, it is UNIMPLEMENTED - that whole class is yet to be implemented, but it is the next thing I want to work on.

Once that is in place I can create an expression from an expression and verify the result is the same.
Is this correct? Is DLL any binary (including pre-loaded queries) or just stand alone DLLs?
No pull request would be accepted which reformats code wantonly like this.
Could use a better name?
This is placed incorrectly. It should be outside the for loop.
Please at least wrap this in a `try`...`except` closure to handle the absence of MicroTardis.
Is there anyway to store these html fragments in index.html? This way we get more sane HTML validation. If it can be done, then that would be great. If not, can you put a comment or something to explain why this has to be done in the JS?
There is nothing explicitly testing that mutation is not occurring, however both the 9-character test and the "should be a combination of two 4-letter dictionary words joined by a numeric character" reg expression should assure that generate simple is doing what's intended.
especially for a package which cannot be installed easily by composer as its dependency is not on packagist according to what you added below
why use typeof? replacement is defined in the line above. This is equivalent:
return replacement !== undefined ? replacement : token;
Hrmmm, i think i forgot to populate a few pieces. I'll fix the pull
I was thinking about doing it in the template because, for example, if you have a list that appears twice on screen, one a->z the other z->a, you want to only reverse it once in the template as opposed to twice? I don't know.
some code after the return statement ? really ?
This is my only concern. File should not be deleted inside the fastimport object Data. 

I expect the user would not want to delete his file since it could be an important one which he is only importing with the help of the fast import.

This should be moved inside the GitImporter.
Just return ? maybe exception handling is not going to work as expected on run_host
this is the same comment pattern as previous comments in the file and in some other posix meterpreter files
Good choice of default.
I know the code didn't do this to begin with, but we should probably check `typeof` and throw and exception since the argument is required.
This is just some old code I moved. Yeah I agree it's pretty bad, but it's a hack to detect the HTC camera application.
Should this be "in its own secure storage *to* maintain a login session"?
IMHO, there is a stack of windows if they are created as lightweight windows.
So we don't want to associate proxies here, but we still want to create it for measuring purposes during the measure pass.  Maybe we could leave a note here (or somewhere else more appropriate) to describe that
Use a blank line before comments like this.
I have no idea, you told me to do it like this.
`event.preventDefault()` instead of `return false` unless you actually need to stop propagation.
Doing the `unset()` inside the `var_export()` is not valid, because `unset()` doesn't return a value.
У нас Raphael.js подключается ради одной анимации, кстати :)
hey, are these very common names at top public level?
and range.length - mid here...
Then I guess it should rather say: »Inside _a_ compound format specifier«… ;)
How about `writefln("[%([%(%d %)]%|\n %)]", mat);` (a space after \n) to decorate output?
"soundSuffix" instead of "sountSuffix"
You will be presented with a form that contains two buttons. One button throws the exception MyException. The other button throws the exception MyOtherException.
My IDE seems to have removed all the whitespaces at the ends of lines...
@ofTheo Yes, there was a warning about a multi-line-comment generated [-Wcomment]. I erroneously thought that's because of the comment style, but I read up and it turns out that the `\` a the end of the line is really dangerous because it escapes the newline (and this happens before comments are stripped from the source). That way, 
```
\\A comment \
printf("My message\n");
``` 
does not print the message.
I have fixed this properly now.
This is a reversion to "Merge pull request #109 from melissalinkert/4.4.1-version-number"
missing one indentation level
Is this line really necessary?  Couldn't the logging statement in the next line be moved down one line, and use the results of the "{ok" match?
Revert, as DOMParser is no longer required and should be dropped (see previous comment)
Confirmed, patch file is renamed in same commit.
But currently this .eb file needs manual intervention, and will break the regtest.

However, it would be technically ok if you comment out the source_urls, so the regtest doesn't try to download it and get 404's but it will skip the build if the sources are not available with the right name.
И где оно используется?