labofsahil/github-event-dataset-2012 huggingface dataset:
yup, fixed in my next pull request.

/kzu

--
Daniel Cazzulino | Developer Lead | XML MVP | Clarius Consulting | +1
425.329.3471


On Mon, Mar 12, 2012 at 21:23, Craig Wilson <
reply@reply.github.com
> wrote:

> > +    /// <summary>
> > +    /// Processes incoming messages from the bus and routes them to the
> appropriate
> > +    /// handlers.
> > +    /// </summary>
> > +    public class CommandProcessor : IListener, IDisposable
> > +    {
> > +        private List<ICommandHandler> handlers = new
> List<ICommandHandler>();
> > +        private IMessageReceiver receiver;
> > +        private ISerializer serializer;
> > +
> > +        public CommandProcessor(IMessageReceiver receiver, ISerializer
> serializer)
> > +        {
> > +            this.receiver = receiver;
> > +            this.serializer = serializer;
> > +
> > +            this.receiver.MessageReceived += this.OnMessageReceived;
>
> While you have hooked up the listener here, it is not removed.  I've found
> this to be a memory leak issue...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mspnp/cqrs-journey-code/pull/12/files#r549250
>
Fixed in #339
This isn't a Boolean anymore.
Add an enforcer rule to make sure we won't drag plexus-ehcache into nexus.
Shouldn't this be returning true?
I notice you don't show the ```Cosmology``` keyword.  It might be worth showing it explicitly with the default cosmology specified, mentioning that this is the default but it's possible to choose other combinations of Omegam/Omegalam (similar to how you have more comments on this in the YAML/JSON scripts).
Or maybe you meant that to mean index number.  Sorry.  # means comment to me in python, even though this one is in a string it still looks wrong.  Probably worth removing even though it isn't actually wrong as I first thought.
Let's just leave it as is then.
this was added last night, now removed again?
umm, isn't this a public repo?
Can we move this -- including the DISABLE_REQUIRETTY to its own class, in or near CommonCommands ?

Smelly having it here!  Perhaps should be a property on the location, ultimately?
I think that's mandatory to make this useful. I will create a mechanism designed for async job execution & tracking in a new pull request.
Much stuff missing. Do we do short-syntax, where it is possible?

For example border: 0 px instead of the long form?

You say colors in hex - but do we want colors hard-coded?
feels like _unicodify should probably take errors, too, now that I think of it.  Hmm.
On Mon, 24 Sep 2012, Hannes Magnusson wrote:

> > @@ -21,10 +21,9 @@ CON     INFO: mongo_get_read_write_connection: finding a STANDALONE connection
> >  CON     INFO: connection_create: creating new connection for %s:%d
> >  CON     INFO: get_server_flags: start
> >  CON     FINE: send_packet: read from header: 36
> > -CON     FINE: send_packet: data_size: 51
> > +CON     FINE: send_packet: data_size: 70
> 
> That should probably be %d as it is the length of the servername, right?

Nope - it doesn't matter - but I'm happy to change it.

cheers,
Derick

-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
arrumar o retorno de List para Voo
What if the job has no results at all? Will it return a 204 then?

Also, this will loop forever in the case of real time searches. We should alert the user.
The full method is this:
```javascript
    isLoggedIn : function(options) {
      if ( options && (options['yes'] || options['no']) ){
        options = buildCallbacks(options, function(result) {
          if (typeof result !== "undefined") options['yes'](result);
          else options['no']();
        }, options['no']);
        this.hasValidOAuth(options);
      } else {
        return (!this.isLoggedOut()) || this.hasValidOAuth(options);
      }
    },
```

i don't require a 'yes' callback, you only need to supply one of 'yes' or 'no'. just in case you only want to handle one of them
Can you also add the dummy bluetooth implementation in your pull request? I will revert my changes back to the original state after that in order to avoid any conflicts.
IMO (looking at last problems with `is_a`) safer would be simple: `$dateTimeClass instanceof \DateTime`
Put $this in argument is required ?
Clowns may not be in BS12, but clumsiness is a thing. Please don't remove this adminlog.
I know that they do. Before I only had try catch around removeAccount because removeAccount requires ` MANAGE_ACCOUNT` permission. I still saw the following exception:

`INSTRUMENTATION_RESULT: longMsg=android.database.sqlite.SQLiteException: cannot rollback - no transaction is active (code 1)`
Any reason you don't use coffeescript interpolation here?
Я больше никогда не буду использовать автореплейс.
Полезно такие проверки в отдельный метод выносить. Вдруг я попрошу ещё несколько операторов добавить -- можно забыть где-то добавить,
Помимо f нужно поддержать e
Здесь надо использовать Character.isWhitespace. Там ведь могут быть не только пробелы.
Проще использовать статический метод Integer.valueOf. Но так тоже можно.
This is about as simple of an object as you can imagine, but it's mostly because I didn't really add any abstraction at all. It probably can be the home of more interesting level specific logic later.
could use array_shift($files) instead
Environment script call removed and the SBT configuration rolled in. The environment setup script won't be necessary with Vagrant because required software dependencies will be provisioned in box puppet definitions.
done and updated
You're right, I'll optimize this.
I know... but when this statement is reached we're fine :-)
> My point is that ''False is not None'' is a false statement while ''not False is None'' is a true statement.

<pre>
In [1]: False is not None
Out[1]: True

In [2]: not False is None
Out[2]: True
</pre>

I think that the confusion comes from the fact that the Python
developers hacked the Python synthax for this to work.
I find it more readable to say

    if out_dim is not None:
shouldn't we check that the result is the same with and without permutation?
You can use `matrix .toarray()` instead.
I would prefer:

```
"""Predict decision function values for each sample in X.

X is assumed to be either sparse matrix or array-like.

"""
```

Keeping the first line a oneliner makes for better integration in IDEs and other documentation tools. See [Multiline Docstrings in PEP-257](http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings).
I don't think you can elegantly solve this with a function. It would require two functions (one for `double` and one for `int`) and pointers-to-pointer (`int **` etc.).
isDeployableProject still in used?
nope :-D
Please insert  separator comment between each tests.
I actually checked doc.c code again and I was wrong. The function I wrote doesn't search the global scope, it searches the correct scope because doc.c pushes/pops scopes as it traverses the nested members. The only occasion a search can fail is because of template parameters: they are not declared in the scope like what is done in the semantic phase. But that's not a big deal. A future pull request con solve this.
We'll ignore it. Added StringObject suuport
This can be done before and used in fullPath so there's less conversion
this is another inconsistency with the "official" (1) style. Sorry to point it out.. If you keep reformatting whole files we need to define this level of precision.
if addRow causes OOM callback, the index array will already be large enough to handle the rows that are already successfully added (from previous calls to this method) so it will be ok
I don't think so. This is only called for an initializer list
actually sorry, was thinking of the ->init above on line 2308
extracting the HTTP version `1.1` in a separate field will enable users to change the HTTP version easily in the future.
"-g" makes it try to create:
/usr/local/lib/node_modules/less

This doesn't work on my system (ubuntu). Why wouldn't we do it without -g if we want it to work without sudo?
This seems just wrong. To keep changing this outer scoped variable back end forth within the functions. 
If each function depends on it differently, then make it a parameter to the function.
Then that should all be in `~/.gitignore_global`. That's how it's almost always done on projects.
I would've preferred to do this in a single line, but patsubst only substitutes the first "%", and I felt that using sed was a tad too much.
Woops, this was pulled in from some other commits I merged into this branch.
This doesn't look right.

```
xxxx = { source : 'la di da' }
Object
typeof(xxxx.source === 'string')
"boolean"
typeof(this.source === 'string') ? 'true' : 'false'
"true"
typeof(this.source === 'magic') ? 'true' : 'false'
"true"
```
On Mar 1, 2012, at 13:41 , Matthew Weier O'Phinney wrote:

>>     {
>> -        $this->_count++;
>> -        $output = "I have seen 'The Jerk' {$this->_count} time(s).";
>> +        $this->count++;
>> +        $output = sprintf("I have seen 'The Jerk' %d time(s).", $this->count);
> 
> I didn't. That's @pmjones who wrote that originally. :)

Sounds like me. ;-)



-- 

Paul M. Jones
http://paul-m-jones.com/
This is an interesting construct... is this just a Ruby way of doing a filtered "lookup" into a Hash? In other words, ip_address will contain the first interface_node element that has its family key equal to "inet"?
@shacker indeed, that was also the intention, we're hiding the google button for now, see the commit message.
@christianv Either way, both services should use the same logical layout here.
`(map get-authors books)` could also be written simply with `(map :authors books)`
what if variable is initialized to `false`? use `attr in object` check instead
I'm still not thrilled about the sheer length of this method.  I'd prefer each of the `#Recalculate` blocks be moved to separate methods that can be tested individually, so `recalculate_singles` and `recalculate_stagers`.
files that are used directly should not live in external/source/.  Move this to data/
At this poing, there should be response. Anyway maybe "if not res or res.body.empty?" would be a more complete check.
should be:
     connected = false
This comes from my hpc background, multiplying is faster that dividing. The only place I guess this would matter is if you were calling the functions in a large loop. Having _inv_xref defined would save you calculations if you were doing a lot of them. I can go either way on this.
I'd do `matcher = delegate_method(....)` on its own line to prevent this wrapping.
Okay, you're right, so the data property itself should  be immutable but the instance assigned to the data property does not have to be, correct?
Perhaps the bounding volume classes should have an expand function to include a point.  Here, we are assuming the bounding volume is a sphere, i.e., it has a radius, perhaps we can abstract that away.
the bracket should be on the same line as the if statement :)
That is exactly it. For some...unfortunate...reading on the subject, checkout https://jira.appcelerator.org/browse/TIMOB-1713
On Android, 'blur' is fired when the tab loses focus.
Is this documented? i.e click event is fired when enter key is pressed.
I think it looks nicer if all line comments have a blank line above them. I don't feel super strongly about this.
I think it can be your choice to support 1.4 or not (then you can update setup.py). But here, I would rather use a try: import ... except ImportError: import... structure.
line too long (however, this is not python)
Typo: "iteration"
got to love IE :)
Чтобы не дублировать код в каждом наследнике, лучше сделать  по аналогии с boost_iterator_facade.
условно говоря: там есть приватные виртуальные методы: advance, decrease и т. п.
и уже не виртуальные публичные операторы. Таким образом у тебя виртуальными будут только приватные методы.
А логика операторов и их хитрости будут только в одном классе
> Did you mean unions instead of enums? You are missing this case:

Yes, and Yes.

:(

What a pain!
First: copy(b, copy(a, c)); 
here in call to copy(a, c)  c is modified to be a slice of c[a.length..$]. Then indeed a non-ref version is called.

Second:
copy(filter!("(a & 1) == 1")(a), b);
here again b is modifed and thus holds c.length elements after call to copy (where c is leftover of b).

AFAIK put does change array if we use ref param. If put takes range by copy it won't help by-ref ranges.
Where is this code exactly? In one of your other pull requests, I assume? This behavior seems fundamentally broken, and at the moment, I would be inclined to argue that the code using this needs to be changed. I'd have to see the other code to make a fully educated judgement, but what what you're doing here seems like when a boolean function chooses to return `false` rather than throwing an exception when it hits an error condition that prevents it from actually determining the correct answer, and that's very broken behavior.
Well, of course it's an algorithm. Otherwise, you'd just be calling `length`. Its whole schtick is that it'll iterate over the whole range to count it if the range doesn't define `length`, and naturally, that'll empty reference type ranges. We definitely need to do a better job at handling reference type ranges, but I don't think that the comment about `walkLength` possibly consuming the range is helpful. It's providing information that's obvious to anyone who understands the problem and which requires considerably more explanation for anyone who doesn't (and because it's a general issue with ranges and not something specific to `walkLength`, `walkLength` is not the appropriate place for an explanation).
This sounds rather dangerous. What use cases are motivating this?
You could also do `defined? ActionMailer::Base`
Changed that in https://github.com/antekpiechnik/doorkeeper/commit/b18be79622bd0596f46fb4d9c17907208a80fd7f
This should move inside of the **if** clause, because the property should only be set if the decoded value is scalar. The customer properties are not a mechanism to gain access to all headers; it is a way to communicate a specific set of values to/from the Rules Filters/Actions.
Ich denke ja....
Und wenn wir das ändern müssen, dann ändern wir es eben wieder...

Einzig bei Pricing zögere ich... Aber nicht wegen dem Kaufen...
sondern wegen dem Admin-Backend....

Was ist, wenn eine Korrektur Beanstandet wird? Muss dann auch das Pricing-Model 
angepasst werden können (ich denke da vorallem an die Deadline....)

Oder wir erweitern den Auftrag um ein Feld "Deadline" welches sich bei im Konstruktor 
aus Pricing und CreatetAt errechnet... im Adminbereich dann aber verstellt werden kann... 
Ich glaube, das wäre sinnvoll....
Please use two different functions instead of jumping to an offset.
context is already a `CONTEXT*`, the cast isn't needed here.
MINOR: comment refers to file as "main.cpp", but actually called "01-basic.cpp"
is this possible?
But, the poll() should remove the message, right?
````

	public Message<?> pollMessageFromGroup(Object groupId) {
		String key = getKey(groupId);

		Message<?> polledMessage = this.doPollForMessage(key);
		if (polledMessage != null){
			this.removeMessageFromGroup(groupId, polledMessage);
		}
		return polledMessage;
	}
````
Yeah, i just noticed that as well
will fix
Why do these now start with "v"?
I was advised to use the smallest possible version, but if the first Jenkins version is better, I can do that of course.
опечатка "означате"
In this case, `ostype` should be `unix`, which is a hard class defined by CFEngine on any Unix-style operating system. The `author` should preferably be `Name <email@address.com>`.

Indeed the idea is that we'll have a tool that can validate and submit sketches, and also one to install them.
I wonder if we should just port visionmedia/node-querystring to the client so both can be consistent
Encoding changes, should be fixed
Placement of "Options menu" is different between https://www.openmicroscopy.org/site/support/omero4-develop/sysadmins/windows/server-installation.html and https://www.openmicroscopy.org/site/support/omero4-staging/sysadmins/windows/server-installation.html

Any ideas why?
Can you rename the event ``sonata.collection-item-deleted`` ?
s/entties/entities/

also in line 46 and 54
I created a pull request in your repo, Marcus, which removes the xcodeProjectDirectory everywhere since we can use the resolved SRC_ROOT now...
That would be ideal, but given the way things are structured and the public-facing apis we can't change, I don't think that would make things any cleaner. We wouldn't be able to get rid of the enum, since it's used in other places like StackMobRequest which would be more difficult to replace with inheritance.
Le 20 septembre 2012 19:05, Cyril Lacôte <notifications@github.com> a écrit
:

> In _includes/themes/twitter/post.html:
>
> > +      {% if page.previous %}
> > +        <li class="prev"><a href="{{ BASE_PATH }}{{ page.previous.url }}" title="{{ page.previous.title }}">&larr; Précédent</a></li>
> > +      {% else %}
> > +        <li class="prev disabled"><a>&larr; Précédent</a></li>
> > +      {% endif %}
> > +        <li><a href="{{ BASE_PATH }}{{ site.JB.archive_path }}">Archive</a></li>
> > +      {% if page.next %}
> > +        <li class="next"><a href="{{ BASE_PATH }}{{ page.next.url }}" title="{{ page.next.title }}">Suivant &rarr;</a></li>
> > +      {% else %}
> > +        <li class="next disabled"><a>Suivant &rarr;</a>
> > +      {% endif %}
> > +      </ul>
> > +    </div>
> > +    <hr/>
> > +  </div>
> > +  <div class="span8">
>
> span10 plutôt, non? La colonne "content" d'un post est sur 10 colonnes,
> le layout général gardant 1 colonnes à gauche et une à droite pour des
> espacements. J'sais pas s'il est visuellement plus joli d'aligner le bloc
> de commentaires sur la largeur du texte ou sur toute la largeur du contenu
> blanc.
>
J'ai gardé l'aspect précédent, où les commentaires et la pagination avaient
la même largeur que le contenu. Mais pourquoi pas laisser les commentaires
aller jusqu'au bout à droite. Je n'y vois pas d'inconvénient.


> C'est aussi un peu bizarre d'enchainer deux colonnes de 8 sur une largeur
> de 10.
> Peut-être vaudrait-il mieux un truc genre :
>
> <div class="row">
>   <div class="span10">
>     <div class="pagination">
>       ...
>     </div>
>     <hr/>
>   </div></div><div class="row">
>   <div class="span10">
>     {% include JB/comments %}
>   </div></div>
>
> Mais bon, ça marche très bien comme ça, la seconde colonne ne tenant pas
> en largeur s'affiche à la ligne.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Ninja-Squad/ninja-squad.github.com/pull/13/files#r1652980>.
>
>
I find this odd... but whatever...

+1 to get this in and basically make hidden pointless.
We did discuss this a bit before we settled on a name, but it is not entirely accurate.

DOM4 call them "inclusive ancestor", see http://www.w3.org/TR/dom/#trees. `get_inc_ancestor()` is not much longer, but not that pretty maybe. We could also scrap the word "ancestor" altogether and find some other name. Or just live with it. :)

@poi
>> it can return the element itself

> Just like `querySelector` and `querySelectorAll`.

I don't think so, they return node(s) in the subtree. No? :)
If I got it right, the walk will never re-start or jump to another location (ie. querying older nodes or nodes in a separate branch of the graph), so caching only the last node is ok.
That's one of the ugly points I was referring to in the first description. But by design I couldn't do it in any other way. Constructor is final, and the SQLFilter::$em property is private. We could suggest to doctrine developers to change at least this property to protected? filters are too limited if we can't access at least the em (or provide our own constructor and let us instantiate the filter).
You aren't using the messageId because the body parts are fully named, so it should probably just be removed, including passing it to _downloadAttachments.  If we pass something through for debugging purposes, I think the suid is probably the better choice.
Oh, great. I will make the yml file more generic.
Only used on "IOS" platform ie iPhone, iPad
On iOS, if you provide no buttons, an OK is provided for you.
Rename to `UserManager` and move outside of of the `MailChimp` namespace
There are two events we fire: MainActivityCreateComplete and RenditionComplete
MainActivityCreateComplete is just a convenient way to get a handle to the activity (but one could just use an ActivityMonitor to achieve the same purpose).
One should wait for the RenditionComplete to try and access the UI since the login flow might be kicked off if the user is not already logged in.
Shouldn't we move this code into `application.js`? So that we could keep view file clean:

```javascript
$(function (){ 	
  $('.datepicker').datepicker({	
    dateFormat: 'yy-mm-dd'	
  });	
});
```
Then add class `.datepicker` to the text field.
Don't autocreate
`take-while` ja `drop-while` olisivat luonnollisemmat.
108-116<b>::</b> Set the [CSSTidy](http://csstidy.sourceforge.net/usage.php) to be CSS optimized such as phpBB
118<b>::</b> Optimize the Cascade Style Sheet
119<b>::</b> Take the plain CSS not the HTML output
120<b>::</b> Because in some way is removed ```"``` from URLs with ```preg_replace``` I get the ```"``` back
Ah ok sorry.
Unit test has been added to the test/unit/lib/controllerWebView.js
Nitpick: Punctuation.