labofsahil/github-event-dataset-2012 huggingface dataset:
done, please take a look

-------- Original Message --------
Subject: Re: [karaf] 1) demos poms 2) karaf plugin "install" 3) karaf
features xmlns version (#6)
From: Andreas Pieber <notifications@github.com>
To: apache/karaf <karaf@noreply.github.com>
Cc: Andrei Pozolotin <Andrei.Pozolotin@gmail.com>
Date: Fri 17 Aug 2012 11:58:01 PM CDT
>
> In
> features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespace.java:
>
> > @@ -0,0 +1,19 @@
> > +package org.apache.karaf.features.internal;
> > +
> > +import javax.xml.namespace.QName;
> > +
> > +public interface FeaturesNamespace {
>
> FeaturesNamespaceS (plural) + a jdoc pls
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/karaf/pull/6/files#r1408434>.
>
@royaltm  We should log it somewhere some day. I created an issue for that #2.
Well, switching the container to the Symfony2 one means rewriting your own micro-framework instead of using Silex. Silex is quite tied to Pimple.
ok, use the same pull request (i.e. just commit to the branch).

On Tue, May 22, 2012 at 9:12 AM, Slava <
reply@reply.github.com
> wrote:

> >  require 'digest'
> > +require 'file_utils/file_generator/file_generator_parameters'
> > +require 'fileutils'
> > +require 'params'
>
> I thought to use.
> I'll use this or delete this in the next commit today.
>
> -----Original Message-----
> From: kolmanv [mailto:reply@reply.github.com]
> Sent: Tuesday, May 22, 2012 8:47 AM
> To: Slava
> Subject: Re: [bbfs] Fixed file generator utility after code review (#34)
>
> >  require 'digest'
> > +require 'file_utils/file_generator/file_generator_parameters'
> > +require 'fileutils'
> > +require 'params'
>
> Why did you add the library if you are not using it?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kolmanv/bbfs/pull/34/files#r858259
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kolmanv/bbfs/pull/34/files#r858298
>
Both. This is tested via the EscalationDefValidationTest, as it is the backing implementation for the EscalationDef.validate method. I put it in a static method here since it made more sense to isolate the rule parsing within the EscalationManager.
The important part at the beginning of this is: 

Many internal sharding operations, like chunk migrations and splits, originate or are initated (fix passive) from a single `mongos` instance in the cluster. To coordinate this activity, the mongos instances use a distributed lock coordinated by the config servers, as a document in the `<namespace>` collection.
Code inside "if" is indented. Agreed that "if" is on the same column as "block" (i.e. not indented) but this a pattern we follow on all htmls in this project.
Get rid of this file: `git rm npm-debug.log`
What's the guard here for? If it's just to make the warning pretty, maybe we could just warn twice:
```ruby
Chef::Log.warn("resource cloning is bad mmkay")
Chef::Log.warn("From #{resource.source_line}")
```
Should this be a separate PR?
Should not be using @ to suppress errors.
Should be a separate change indeed.
I wasn't aware using square brackets was 'old' syntax so much as alternative syntax. I thought they just overloaded the getter and setter methods in the storage interface.
If the prevailing coding style is to use ==, then == should be used.
And do they not?
Apparently there is other module data in installer. I don't know if that is what we want but I will accept putting more module data into installer.
Camelcase, should be `handle_output_data`
are you going to fix this todo?
that doesn't tell the stream to end internally.
Because -1 is not always 0xff. This is platform-dependant.

If you want to fill memory with '1' bits, please use 0xff.
oh, no. that's wrong. S8.split has to happen on the decoded (from base64) plaintext bytestring
Sorry - started as just the constructor.  I went for appendBoilerplate().  Still want to make this a template someday.
It's probably because your not using `loader.resolve` to resolve the deps. 

You can either put that line back, or switch to calling resolve & getting the modules from the return.
Yeah, I should have dug through the docs more.

Unfortunately, it's still tunneling the requirements from a previous, and I have to resort to the `delete YUI.Env._renderedMods` hack to prevent that.
I don't understand what this message means.
Это пишется в одну строку гораздо проще
return util.format(CODE, this.name, this.image_type == 'local' ? imageServer : '' + this.imageUrl, this.name);
the indentation should use 4 spaces per level
Yes, it doesn't work on just data. It needs a dataset.
On Jul 20, 2012 9:35 PM, "Yaroslav Halchenko" <
reply@reply.github.com>
wrote:

> > +    ds2 = AddAxisMapper(pos=2)(ds)
> > +    assert_array_equal(ds2.shape, (2, 3, 1, 4))
> > +    # no change to attribute collections
> > +    assert_equal(ds2.sa, ds.sa)
> > +    assert_equal(ds2.fa, ds.fa)
> > +    # append an axis
> > +    ds3 = AddAxisMapper(pos=3)(ds)
> > +    assert_array_equal(ds3.shape, ds.shape + (1,))
> > +    # reverse indexing
> > +    ds_1 = AddAxisMapper(pos=-1)(ds)
> > +    assert_array_equal(ds3.samples, ds_1.samples)
> > +    assert_equal(ds3.sa, ds_1.sa)
> > +    assert_equal(ds3.fa, ds_1.fa)
> > +    # add multiple axes
> > +    ds4 = AddAxisMapper(pos=4)(ds)
> > +    assert_array_equal(ds4.shape, ds.shape + (1, 1))
>
> thought to smoke test on some more 'real world' examples:
>
> ```Python
>
> from mvpa2.testing import sweepargs
> @sweepargs(ds=datasets)
> @sweepargs(axis=(0,1,2))
> def test_addaxis_sweep(ds, axis):
>     from mvpa2.mappers.shape import AddAxisMapper
>     print ds, axis
>     ds1 = AddAxisMapper(pos=axis)(ds)
> ```
>
> Fails right away with:
> ```
> mvpa2.tests.test_mapper.test_addaxis_sweep ... uni4small 0
> ERROR
>
> ======================================================================
> ERROR: mvpa2.tests.test_mapper.test_addaxis_sweep
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in
> runTest
>     self.test(*self.arg)
>   File "/usr/lib/python2.7/dist-packages/nose/util.py", line 622, in
> newfunc
>     return func(*arg, **kw)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/testing/sweepargs.py", line 67,
> in do_sweep
>     method(*args_, **kwargs_)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/testing/sweepargs.py", line 67,
> in do_sweep
>     method(*args_, **kwargs_)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/tests/test_mapper.py", line
> 371, in test_addaxis_sweep
>     ds1 = AddAxisMapper(pos=axis)(ds)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/base/learner.py", line 235, in
> __call__
>     return super(Learner, self).__call__(ds)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/base/node.py", line 84, in
> __call__
>     result = self._call(ds)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 247, in
> _call
>     return self.forward(ds)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 181, in
> forward
>     return self._forward_data(data)
>   File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 70, in
> _forward_data
>     raise NotImplementedError
> ```
>
> is that me misunderstanding capabilities?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/PyMVPA/PyMVPA/pull/88/files#r1208489
>
thought to smoke test on some more 'real world' examples:

```Python

from mvpa2.testing import sweepargs
@sweepargs(ds=datasets)
@sweepargs(axis=(0,1,2))
def test_addaxis_sweep(ds, axis):
    from mvpa2.mappers.shape import AddAxisMapper
    print ds, axis
    ds1 = AddAxisMapper(pos=axis)(ds)
```

Fails right away with:
```
mvpa2.tests.test_mapper.test_addaxis_sweep ... uni4small 0
ERROR

======================================================================
ERROR: mvpa2.tests.test_mapper.test_addaxis_sweep
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/lib/python2.7/dist-packages/nose/util.py", line 622, in newfunc
    return func(*arg, **kw)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/testing/sweepargs.py", line 67, in do_sweep
    method(*args_, **kwargs_)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/testing/sweepargs.py", line 67, in do_sweep
    method(*args_, **kwargs_)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/tests/test_mapper.py", line 371, in test_addaxis_sweep
    ds1 = AddAxisMapper(pos=axis)(ds)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/base/learner.py", line 235, in __call__
    return super(Learner, self).__call__(ds)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/base/node.py", line 84, in __call__
    result = self._call(ds)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 247, in _call
    return self.forward(ds)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 181, in forward
    return self._forward_data(data)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa2/mappers/base.py", line 70, in _forward_data
    raise NotImplementedError
```

is that me misunderstanding capabilities?
Shouldn't duplicate code from earlier search.
use the new default_action function instead of this hacky bit
map_setup will be removed.
Those boundaries will have to be redefined at some point, but we're not there.
My feeling is that as long as a "canonicalizing" optimization makes the graph simple/better/faster, and has no reason to be undone during the "specialize" phase, we might as well register it in specialize as well. That's what we do for a lot of simplifications, like neg(neg(x)).
Anyway, since I can't think of an optimization introducing new CAReduce nodes that reduce over broadcastable dimensions, I don't think it makes a difference for now.
I get it.  I do not put too much attention on the sql exception to do error checking. Fix it. Thanks.
Yeah. I thought I would need this, but it turns out I didn't. I left it in because it will certainly be needed soon.

I gave up on removing a unique index because there were a small number of issues and I wanted to make sure the ticket as written got done. Modifying non-unique indexes and and adding columns to unique indexes should also work, but don't yet.
It would be nicer to move this ``except`` to line 136 and handle the rest in an ``else`` block.
Might be useful in the future. I'll leave it in for now.
This needs to be configurable like our other data dirs.
This should read... "are laid sequentially on-disk"
These whitespace-only changes would be clearer in a separate commit (i.e. not part of the pull request).
Unnecessary.  Non-pointer members are initialized automatically upon allocation/construction.
What is the model doing here?
This loop always runs over a single element.
Should probably just remove the reset(), rather than commenting it out. Samples should be clear about the right way to do things.
Have you tested it with a large calculation (lots of assets, big region constraint)?

My concern about this is that, especially for larger calculations, the progress reporting is not very good. If you have only 4 tasks (or 8, or 16, or whatever), that means you only have that many progress increments. With 4, you have 25%, 50%, 75%, and 100%. That's it. If you have a really big calculation, you would have to adjust the config every time so you have a reasonable sample rate for progress reporting.

Aside from progress reporting, fixing the task size also means that your tasks become more monolithic. Given what we've experienced over the last 1.5 years in dealing with big calculations, we have discovered that large, monolithic tasks are _bad_ and smaller tasks are _good_.

Finally, this is not consistent with the way the hazard engine is configured. I understand, and you understand it, but I think this would be very confusing for the users.
Where's the SQLAlchemy init? If it's in models, confirm that it works if models is imported before configuration.
`noSubmit` should be removed with `.off` in the cleanup step.
Lastly (I promise!), you can do 

```
offsetSupport.zeroOffset = false;
```

before the `if` and ignore having an `else` altogether! Should save a few bytes actually.
Probably want to add u'' as well.
This is just repeating what `brew options` or `brew info` already says, so we don't want it in the caveats.
so what should I use if sbin isn't in my path?
`brew audit` complains that this is an alias for boost-build; so it should be: `depends_on 'boost-build' => :build`
How about cleaning this up a bit?

```JavaScript
obj.newInstanceOf = function(prop) {
    var name = prop.name ? prop.name.toLowerCase() : undefined;
    if (name && entityClass[name]) {
        // FIXME: I should pass the entity ownProperty instead of the object itself
        return new entityClass[name](prop.x, prop.y, prop);
    }

    // Tile objects can be created with a GID property;
    // The TMX parser will use it to create the image property.
    if (prop.image) {
        return new me.SpriteObject(prop.x, prop.y, prop.image);
    }

    console.error("Cannot instantiate entity of type '" + name
        + "': Class not found!");
    return null;
};
```
happen should be happens
The `find_missing_keys` method only appears to be called from a test - is it purely for testing?
Just 'binding'. All bindings are solo. If we add chocolate bindings I don't want to have to rename the other callsites to unityVanillaBinding
don't bump the version
Well, except it's supposedly about links to files in different directories—WPD flattens everything, but that doesn't mean the original links are to the same directory.
Yeah, but I only need to look things up that one way, so why expose the
actual HashMap?

Seamless improvements!
Typo -- the event is "panelResizeStart"
This line reverses the order of CSS rules in the browser menu, which represents the natural order of CSS rules from most to least precise.
Late coming in here (the request has already been merged), but this won't work as expected if spec is null. It would be simpler to just do:
```
var queryString = spec ? "?spec=" + spec : "";
```
Yup, I had a brain fart.
showDetail should use the sorted set, the rest of the code is specific to add or edit
it looks like this will fail hard if 'key' gets assigned the default value of []. should fail more explicitly when not passed in if you always assume key is at least 2 items long
I think so, because sometimes the program will be set to the root, and the location will not, and vice versa, so one table will need to display the link, but the other will not.
Should it be internationalized ?
Relevant with r637870.
You could of course do that even with shared error messages. For your current code:

```
default_error_messages = fields.error_messages
```

:-)
Why are you overriding `get` and not `get_redirect_url`?
Class based views?
Why is this here? Does something conflict when it's not?
If I move the scrubber.update calls into the event listeners, then that means I need to duplicate the containerWidth calculations into both functions. That doesn't sound like a win to me.

I will remove the _lastZoom member though, as the scrubber already stores the previous zoom level
We don't need to set empty defaults, we do this in trackevent.js if there is no default
Is it possible to remove this empty start() function?
Should we link to something we own?
Instead of getting a new DOMFragment for each one of these, you can probably just generate one DOMFragment for the whole layout, and querySelector pieces from it.
MIssed the python manage.py migrate
Something to tries to draw using primitives shall not be in the core.js. It may be placed into different file and exposed via API. Also, there is no point in polluting the operators list with commands that can be directly addressed/executed on canvas.
Эта ветка лишняя, не будет компонентов пути `..` после выполнения `PATH.resolve()`
Did you forget changing this one or was it kept like this on purpose?
ino div kon dakhelesho section
Can you undo these JavaDoc changes please?
do not do exit inside this method. Just return. exit should be only in main() function
Btw, the reason for that behavior is simply that it's what the underlying LLVM operation does.
return the org not  org.id
Take a look at the behavior of this.  The env_select was unnecessarily setting the z-index.  Feel free to pull this down and test, I obviously don't want to break things, but in my testing it worked well.
The idiomatic Ruby way is:

    packages ||= []
wow, defineProperty and friends look quite useful.
On 12/04/2012 07:26, James Lal wrote:
>> +    launch: function(){
>> +      var event = document.createEvent('CustomEvent');
>> +      event.initCustomEvent('mozChromeEvent', true, true, this.getDetails());
>> +
>> +      window.dispatchEvent(event);
>> +    }
>> +  };
>> +
>> +  function MozAppGetAll(){
>> +    setTimeout(this._loadManifest.bind(this), 0);
>> +  }
>> +
>> +  MozAppGetAll.prototype = {
>> +
>> +    //relative to homescreen
>> +    appManifestFallback: './apps-manifest-fallback.json',
> We could do that but I feel like webapi.js is already huge and like you mentioned this code is only useful in mainstream FF.
> I personally prefer to keep the fallback data in a separate file. The getAll mechanism for app loading is already async so waiting for the XHR request has no real downside.

I'm not worried about performance here, I'm worried about spreading 
'compatibity' code.
If you use |yield| you don't really need waitForExplicitFinish() nor finish() I think.
Should the expected behavior be that if you give an n-dimensional array in, you should get an n-dimensional array out when converting? If so, maybe you should remember the shape here (if an array), and reshape later on output?
typo: download (no s)
This is actually surprisingly difficult - the reason being that if the default is to set these to ``True``, then it is impossible to have access to the original built-in ``showwarning`` and ``excepthook`` functions, because these get overwritten before ``test_logging.py`` is even executed. So it's as if when I import ``log`` from the logger, it's the second time it's being executed, and so the 'original' showwarnings and excepthook functions are actually the overridden ones... (if that makes sense). Basically, it's much easier to have these disabled by default for the purpose of testing. Is it possible to have these enabled for users, but disabled for testing? Can you see any other solution?
Changed glob to wildcard pattern.
If you want to use duck-typing, maybe the following would be better?

```
try:
    return self.value == other.to(self.unit).value
except AttributeError:
    return False
```

? Regardless, is this duck-typing safe, or should we require ``other`` to be an actual ``Quantity`` instance?
Please ignore me while I confuse sizeof(char) with CHAR_BITS, sorry.
it passes pep8 but I can change it to

        for model in self.models:
            predictions_files.append((model, csv.reader(open(
                get_predictions_file_name(model.resource_id,
                                          predictions_file_path), "U"),
                lineterminator="\n")))
It's not directly tested and it being protected implies the end developer doesn't need to/shouldn't use it. In other words: you don't need to bother with salts.
This line needs to be removed.  A `@see` to itself doesn't make sense.
so then are we saying that in-browser-window toast feature === desktop-notification-toast?
This function was added in version "3.1.4" while "apc_fetch" exists since "3.0.0".

Do we make any guarantee what version of APC we support?
Is it by design that you cannot add the same listener twice?
`foreach` requires blank line before and after it
An Enaml `Signal` that is, not a Qt Signal.
Yes, the type/subject issue is not solved in a satisfactory way right now. It's been on my list for a while now, but the one working site i have with CreatePHP has such a specific way to use types in relation to models that it's almost impossible to generalize from there. But like I said, Maybe tying the loader and mapper might be a step into the right direction. The mapper is available on all levels anyways, and it handles talking to the storage, so it would be the logical next step to make it handle loading as well (but then it will of course have to have some way of seeing which types are available).

As far as the subject is concerned: @bergie recently mentioned that DELETE requests are actually supposed to send JSON-LD (see https://github.com/bergie/create/issues/88), so maybe this issue will in fact go away once that is fixed in Create.js. I'm not sure about the workflows, though. On the one hand, it would be a lot more consistent if they would receive JSON-LD, but on the other hand, they would then need to have access to the jsonldEncode/Decode functions. But we'll have to ask bergie for feedback here first
Shouldn't this have the setObject() signature as well?
Nit: se_n_tence
Probably should say that it returns a sequence not a list.
Looking at this, I think the `.get()` call should fall back to an empty string, rather than the default of `None`.
Yes, I'm getting used to a new editor, and one thing that it doesn't do automatically is hard line breaks.  Does the javascript follow an 80 character line break?
Should I cleanup `timout` as well? That's where I C&P from :-)
I changes to initial values to `0.0`so this should work under Python 3.
This whole section of changes, generateDocumentation* shouldn't exist.  There should continue to be one implementation of generateDocumentation, and it should take the same parameters as before.  If you need to pass additional data to the function, it should be stored on the `config` object.
move this comment to javadoc on the api method
This should only be a restriction if git also does this, but I doubt it does.
thanks @sclatter , we shall resolve this tomm meeting for sure.
woo! this is great, straightforward documentation.
This too should be able to be a multiline entry.
"모든 재정리 가능한 ePUB 컨텐츠의 페이지를 작성"
should be
"모든 리플로우 컨텐츠의 페이지네이션"
See 'h' above.
This should be removed as this is done when we release
shouldn't you call the ``buildViewBottomUp`` method in it for BC ?
@stof - typehinting properties is really important.
you could simply return. You don't need to return a boolean value here.
I just recognize RequestContextAwareInterface doesn't even have a getContext in 2.0
So we cannot inherit anything. Will make a new PR for master.

And we remove `@api` from subclasses if the parent has an api tag?
This is wrong: you are not using the configured annotation reader but creating a new one
I would document it as ``\Mongo|\MongoClient``
is there a phpcs xml configuration for symfony coding standard over the web?
Can we query ohai to see which package version is installed and then do something logical automatically? We should definitely include something in the Readme as well.
Why has this method has been deleted?
I know we had issues with newer version of protocol buffers (but I think it was related to includes, which we're not using here), have you tested with > 2.0.11?
Unfortunately, that is the exact file we need!  We could move `Draper.validate_options` into its own file, but since core support logic that is shared by a number of classes (`Decorator`, `DecoratedAssociation`, and `CollectionDecorator`), in the end I decided that `draper.rb` was the most logical place.  But if you have a better idea on where to put it, I concur!
That's true that I saw this file on CentOS 6.2 and havn't thinked to look at 5.X.

In all cases, RHEL and CentOS are similar and should works identically (and if it's a problem, I guess it must read redhat-release and parse it.
this is the fullscreen file, not the embedded file i think hisakonog had to have unique id for the accordians to work, this probably needs to go back in.
You have to call completeStep() after calling context.getFailureDescription().set(...). You always have to either call completeStep or throw an exception.

The else block could just throw OperationFailedException, which the OperationContext handles by setting the failure description and calling completeStep. That's the more "standard" thing to do since it's more intuitively obvious. I wasn't sure why this handler didn't do that and instead wrote the failure description, so I just took the path of resistance. :)  I'll have a quick look at the history.
Use `osFull` instead, `Platform` used to contain the version as well and we want the version here.
A dot is missing here, preventing the tarball from being dowloaded.
yes, it is totally useless now
Please remove the header
the timeout period that should be moved to a constant and ideally to a configuration file for the app
Yes, because in the first one we are referencing the key and in the second one the span child
okay, I think I got what you meant.
This refinement will change tilesView, listView and sublistView for sure, so I would like to do this in another follow up.
`overlay-dialogs`
Just for name-spacing, in tests things are included out of order so I ensure the namespace exists. I could probably just not namespace everything but there is something about adding a bunch of stuff to the global window that still hurts me... Also- Strict mode is always on by default (at least in b2g desktop).
Should be, I guess.
sorry about that, I just copied the old function into the new file without giving it any second thoughts. My fault.
Currently we don't care about text node but in the future? I guess the answer is yes too. What is the advantage using children instead of childnodes? An yes there aren't text nodes between <li> so we could use children in theory
I think you're right. When I started this I think the version of Jingo I had was too old. I'll check again. Would be nice to remove this.
My feelings are that if they are in the url then they should be required fields in the method signature, otherwise we end up trying to mimic GitHub's defaults for those values (if any), which we then have to keep up with in the event that they change on GitHub's end. 

That said, I think the `path` makes sense to be in the signature, but the `ref` does not. That's what my note above on the docs was about.
As the path here and the ref below is part of the url. Do we have to leave them where they are so we can build the url if the options are supplied?
Hi,

how about using : (colon) or ; (semi-colon) for path separator to conform that of OS?

With regards,

Chanwit
`await` and `awaitE` now include the `Monad m` constraint; shouldn't be a problem.
is it just me or do you not close the `<h4>` tag?
you can assume they are zero padded, right?
¿Quedaría mejor comisiones de venta?
Is it possible to have static strings for translation then use another map to hook up the status to the translated strings?
There's no authorization for deleting attachment. Basically anyone can delete attachments from other users.

Always authorise() every action you do!

if ($attachment->authorise('delete') && $attachment->delete()) success() else failure()
`(post)`?
That's right, you have to write it.
161-223 - OK

226+ can you check, if your change will not break other sharers, which use extra oauth parameter?
No doubt. Opened #541 for this very reason.
```php
public function directoryExists($dir)
{
    return is_dir($dir);
}
```
In addition to it, otherwise running simply ``phpunit`` would try to call a PHP function.
btw, the variable name is weird. ``$sourcePath`` would be better
master factory, builds various other components. provides default implementations which can be replaced
Can you check that the indentation matches the original source?  It looks off in the code review tool.
Which of the lines above do you mean?
USing a single message constructor for two distinct events introduces confusion IMHO. How would a third-party service know if an incoming POST concerns a ping event or a CheckEvent event?
Also, it's only a matter of chance that both models have almost the same property names. These propserties don't means exactly the same thing on each size, so I'd prefer if you adapted the message for each event type.
So we're going with `rem`s? Is it really that much of a pain to use `em`s? The accessibility benefit swings me in favour of sticking with `em`s
Do you have any data to back up that claim?

We should use TimeGet, if we can improve TimeGet with time() we should update that function separately.
I've had problems with these changing wildly between releases. Did something in Hackage change such that I won't have to worry?
Hmm.. I don't think having `kwargs` hurts us. Except that `kwargs`,  `dprime()` is already simple to use.  Any advanced/cautious users will look up `kwargs` anyways --- and others will simply ignore `kwargs` and still `dprime()` will work happily.

Just in case if you want to remove `dprime_from_samp()`, I would like to keep `dprime_from_samp()`, cause I often encounter cases where `pos` and `neg` are naturally available first and thus I need to re-package them into `y_true` and `y_pred` if I were to use `dprime()`.   I know this repackaging would be one line code, but --- if we didn't have a separate `dprime_from_samp()` --- the `dprime()` will anyways unpack the things in `y_true` and `y_pred` into `pos` and `neg` internally, and this feels to me unnecessary.

CC'ing others @yamins81, @cadieu --- any thoughts?

PS: and d-prime is used quite often... at least by me ;-]   and there're many different ways to compute so that's why I'm obsessing it.
This seems like a lot to go through (and read) for just `resources = raw_summary['resources']; changes = resources['out_of_sync'] + resources['changed']` Should it maybe be changed to that simpler form?
This information isn't a blocker to merging this change set, but just an FYI.  We (the platform team) are using YARD style method documentation in markdown format now.  As a result, the method documentation usually comes before the definition.

More information at: https://github.com/lsegal/yard/blob/master/README.md
Pushed, good find :-)
Now, all this looks like data-accepting attributes:

```ruby
ImageAndCell.alloc.init.title = "the title"
```

You don't want that. It makes a view to be "a controller" of subviews. What if I want to change text color of a title? (a real and valid use case).

It's not clear what are :required properties are for. Do we need to re-create the whole UIView just to add text to more_info?
Or actually, I misread the code. Ignore the above.
This is kind of a big change -- what was it for?
not a list. a map.
Oh, I didn't know about that. Fixed!
Really is not needed openssl for ZEND Mode
Or both ?
I think it's fine for now -- this is mainly for the representation. We can alter it after RC1 if need be.
If we're not going to use $jColumnKey, why have it?
Align the equal signs.
Should the DB writer convert the DateTime to `YYYY-MM-DD HH:MM:SS`, then? That seems to be the common format for `datetime` and `timestamp` column types. With the old Logger and DB writer class, the date would have been passed in as an ISO 8601 string, so I would have assumed the column for this field was a `varchar`. It's been a while since I worked with SQL servers; would an ISO-formatted string get converted to the appropriate date type?
FormatterInterface's job is creating a single-line string from the event data, which is why the database writers don't support it: they store event data directly into a row or document. When I created `FormatterInterface::setDateTimeFormat()`, it was just a relocation of logic from the Logger class, and IMO is only relevant for formatting DateTime in the context of formatted event data. If other writer backends can store actual dates, I think that's preferable. 

In this case, we aren't even formatting the DateTime object ([DateTime::format()](http://php.net/manual/en/datetime.format.php) is never called). This is analogous to type-casting.
No need for = and ".
Just use string as is.
I think that ``md5`` is enough here
in my copy of the source file it looks like there is another await statement in these lines that don't show up in the diff, is that OK?
There is no setenv in Windows platform, so changing to putenv.
same comment as above here too
I'm using the same CS I've seen in the PreFlushEventArgs class. But now that you mention it, I'm looking at the other classes, like PostFlushEventArgs and it doesn't use the underscore. Which is the right one so I can fix the others too?
Got it -- I saw that but forgot to update this comment.
this can be done in src_prepare() for EAPI>=4
I think using author in url settings would be a misconfiguration if some posts authors are null, don't you?
well, there should be only one. should we implement a sanity checker somewhere to check this?
"""Configure Pasha by setting make options."""
>But fsockopen() will create a new TCP session, so it won't receive any packet that does not belong to response to requests sent through own connection

Afaik, the other end of a tcp connection can send whatever it pleases.

Of course "we are completely sure, that no other request will be sent to this socket before response of previous one will be receiver.", but if the response was never received (e.g. due to timeout), adhering to the spec, if the other end recognizes us (which is possible due to IP addr), it may send some outstanding response not corresponding to our *current* request. Tivoka will throw an error in this case, afaik -- but again: that's ok, because I don't know of any better handling in this case.
.send(caption) twice
result = m.aggregate_for_period(TestModel.objects.all(),
                                    datetime(2012, 4, 1),
                                    datetime(2012, 6, 30))

Might look a bit prettier?
Space out your moustache.
Out of scope, but this is sending 500s?? Filing.
Also a follow-up bug to remove every empty `div.clear` and apply the clearfix CSS.
var decoyCalled = false,
       finishedCount = 0;
I believe this is actually fine now.

The reason a switch was bad is because it would not jit. It does now, correct?
@Sakshiarora a common mistake -- don't worry although do change your password for this account ;-)

Our Jenkins instance has credentials (hidden from the public) for accounts on the wiki -- once the code has past a review and we merge it your tests will begin using our Über Secret credentials.
That's a really weird condition. `if (0)` will always be `false`.
Although this is still an ugly hack...
it would be later on trivial to change the internal class behavior if there would be a better way in the future?
why are those tests commented out?
@vingtetun, would this be something you can add easily?
global variable 'intensity'?
You're missing three temp file names, `manager_irc`, `manager_stream` and `manager_fastcgi`. They are used to start and connect to python managers so hanyuu can connect her various systems.

An example of these are `'/tmp/hanyuu_irc'` which is what we use for the IRC manager.
cut those unnecessary {}
WTF is this doing here? Fine otherwise :P
Always put a `/` before `socket.io/`.
in general most people don't forward agent to unknown boxes, though in this case it is unknown to me whether we shoudl think of the box as trusted
I just copied the methods that used `assert` from the `ExecutingContext` tests. I can change them if you think it would make it more clear
can you change this to `es`, pls?
CS nitpick : Could you please place the arguments of `eZPersistentObject::count()` on separate lines so that it's more readable ?
Why not just using the `-O` flag?
Please ALWAYS use brackets. ALWAYS!
looks like before this to take up one second of time we would nee 3648 repos for a user with 64 repos in their personal account. Though we could still improve the current implementation:

```
@repo_name_array  ||= Repo.all.collect{|r| r.username_repo}
@repo_name_arra.include? name
```

I generally don't like implementing things that I _know_ will have to be fixed eventually, but point taken.  Lets get this in there we can optimize later.
Attributes should be **under\_scored**, not **CamelCased**.
Sorry, I know this will need a migration to change, but it's best to be consistent with a single style.

See the 'Naming' section of bbatsov's Ruby Style Guide for more details: https://github.com/bbatsov/ruby-style-guide#naming
upstart replace "start-stop-daemon" exec.
since 1.5 (ubuntu 12.04), we can use :
```
respawn
respawn limit 5 30

chdir <%= node[:logstash][:basedir] %>/agent
setuid <%= node[:logstash][:user] %>

script
  export LOGSTASH_HOME="<%= node[:logstash][:basedir] %>/agent"
  [...]
  exec java $OPTS
end script
```

this handle any error and do something really nice.
you're not so sure I'm right?  :)

atlantic calls pointdexter, which does shell back to atlantic if given the third arg, atlantic talks with chatham, the job is a chatham ID from the server (something like 50c5798acae33a44b0000001) - which is why jobs show up @ http://debuild.me/job/50c5798acae33a44b0000001 -- if the third arg is missing it won't post jobs back
This hardcodes message field to be `message`.
Because I cannot add a new unique column without setting it per default to NULL. I could add another migration that removes the nullable though
I'm not sure if this is necessary as helenus defaults to a replication of 1.
I'm afraid that these regexes are going to spiral out of control. We have at least 100 API endpoints that we already we will have, and I really want to avoid running them over and over again.

Perhaps, we can do something like this:

1. In generic middleware, put the startTime and URL onto the request
2. In API endpoints with fixed URLs, no additional work is needed, they will be recorded automatically
3. In API endpoints with dynamic URLs (e.g. /api/user/:id), we override req.URL (better name needed) and set it to something that will be the same for all of these dynamic URLs

It would be even more ideal if we could get hold of the matching pattern somewhere in the request chain.

Then, we automatically catch all data, in line with OmniTI's recommendation. Dynamic URLs will by default be recorded per unique URL, unless the endpoint groups them.
If it's an object, we should specify that the keys represent the added members. If it's an array, the type should be changed.
The same applies to this JSDoc. I didn't really learn what this function does.
@td324 : The appropriate way of doing a line break in markdown is apparently 2 or more spaces at the end of the line after which you want to place a line break. http://daringfireball.net/projects/markdown/syntax#p . Can you submit a follow-up PR for this?
Duplicate docs here.
If I have to be pragmatic, I think it's ok for the actor to access the ``ScalaDebugTarget.threads`` field, as nothing bad can happen. Though, from a purity POV, actor's should never access other's threads data. What a dilemma!
Style observation: better specify the return type explicitly and not have surprises when changing the implementation.
This is only for synchronization during tests
no need to default these here since they'll be falsey anyway
heper's >>> helper's
Вы считаете совпадения, а не различия.
Здесь повторов будет меньше, но они тоже могут быть.
Добавлено)
Есть - я знаю. Исправила. Все делалось в экстренном режиме, поэтому был допущен такой "косяк"
из инта в стринги
из стринга в инты
зачем все это?
I think you're right. I had just copied the code from the SDL wiki without much thought.
This needs a note like the one on `+immediateScheduler` noting `+currentScheduler` will never return it.
I'd try using `msg.http` without the header call if possible. If the API is for real json, it shouldn't be too bothered. If it is, leaving a note about why the user agent is set would be good. (I realize this might be copy-pasta from part of another script)
This should really be an if statement
static暂时是不起作用，随手加的。
Where is the love for PLV (and definition for PPC)? I will probably add PLV after you merge unless you feel like adding it now...
Shouldn't it go into the above for statement?
It's almost right, but I bet there are more errors found in this concept. You need to assert that there is one for missing description.
You aren't using this fancy expression anywhere...
If it does not break anything to remove the `+` method here, why not remove it also from its subclasses (`Html`, `Xml`, etc.)?
Indeed. Turns out it's not necessary because the .gitignore shouldn't even be in that excludes list.
Maybe rename host_name to debian_wheezy instead ubuntu ?
Yep.

- tox test summary 
  py26: commands succeeded
  py27: commands succeeded
  pypy: commands succeeded
  congratulations :)
you should remove this ``Symfony`` folder from the default structure as it is not part of it. The name of the folder containing your project does not matter
@cordoval ``--dev`` has no influence on the content of the zipball downloaded from github
I decided to stick to libcurl syntax: http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTSSLVERSION. Because I found it to irritating otherwise.
I completely neglected the error handler. It shouldn't be too hard to
extract at least a little metadata out.

Verbose logging-- I'm not sure what's up.  I thought there was even a test
for it, but it was more than 3 days ago that I looked at it, so memory has
already failed.

Formatting -- will look at it.

I'm not sure what my schedule is.  Hopefully I'll get an hour or two before
next week to look at this.

On Mon, Feb 27, 2012 at 11:05 AM, Andrew Thompson <
reply@reply.github.com
> wrote:

> > +%%    [message] -> The content of the logged message, alone.
> > +%%    [{pid,"Unknown Pid"}] -> "<?.?.?>" if pid is in the metadata,
> "Unknown Pid" if not.
> > +%%    [date, " ", time," [",severity,"] ",pid, " ", message, "\n"] ->
> default formatting if none is provided
> > +%% @end
> > +-spec format(#lager_log_message{},list()) -> any().
> > +format(#lager_log_message{}=Msg,[]) ->
> > +     format(Msg,[date, " ", time," [",severity,"] ",pid, " ", message,
> "\n"]);
> > +format(Message,Config) ->
> > +     [ output(V,Message) || V <- Config ].
> > +
> > +
> > +-spec output(term(),#lager_log_message{}) -> iolist().
> > +output(message,#lager_log_message{message=M}) -> M;
> > +output(date,#lager_log_message{timestamp={D,_T}}) -> D;
> > +output(time,#lager_log_message{timestamp={_D,T}}) -> T;
> > +output(severity,#lager_log_message{severity_as_int=S}) ->
> atom_to_list(lager_util:num_to_level(S));
>
> Please wrap these lines. They are very hard to read ATM.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/basho/lager/pull/36/files#r491475
>



-- 
Jason Wagner
jason@nialscorva.net
yeah, if we want to avoid confusing users toString should be consistent with the class name
I think this is pretty cleaned up now.  What do you think?  Still doing some blocking, but basically to ensure the channel is started.
me likes!
Yii convention is CamelCase, not underscores
И чей это урл?
.content、.cover外再包一層class
Why? :-)
We don't need neither ``"operator": "equal"`` nor ``"operand": true``; they are the defaults. It doesn't really matter, though.
space after other
Done, please review.
`contains?` works also for hash-maps and tells if a key exists.
Whitespace looks a bit weird.
I guess we are talking about the same thing, as if an replay operation would be invoked the tx would be marked asRollback only.
IMO the code would be easier to follow if you don't use the active status, but a flag: https://gist.github.com/3796917
That looks better, but is it set to the right value somewhere?
can this lead to a situation where we have no routes at all or only one single route to "switch" between? could this lead to problems when rendering the language switcher?
i dont know ..
This comment made me laugh.
@klrmn good point --  I didn't realize the other tests for this product followed the same convention. I withdraw my criticism and will put it into a git issue  :-)
This is a pretty hefty precondition, and it is used more than once.  I might use a separate predicate function.  It's a style preference, but it's common -- see the comments in [this post](http://blog.fogus.me/2009/12/21/clojures-pre-and-post/).  Here is an example that probably won't work as written, but can be used in the precondition:

```clojure
(defn critically-bad?
  [bad all-types full]
  (let [total-nil (count (positions nil? full))]
    (if (or (nil? bad) (pos? total-nil))
      (false? all-types))))
```
Can you split this to two lines?
I noticed that we use `jQuery` a lot more than `$` so opted for that one to make it consistent.
`<Import-Package>*</Import-Package>` is the default behavior, so you can remove this line completely.
Please remove that due to ongoing removal of Array2
I already revised that and resubmitted. 



On Jul 20, 2012, at 3:29 AM, Zauberfisch<reply@reply.github.com> wrote:

>>                            ];
>>                        },
>> -                        errorMessages: {
> 
> sweet
> but line 111 should not be removed
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/silverstripe/sapphire/pull/656/files#r1203509
should update to 0.1
A closure would be so much nicer here if we didn't have to deal with PHP 5.2. Will put in a TODO to fix that later on.
Yeah, memory hogging, i'll change that. Thanks!
Are you sure ``$context`` has the correct type as ``*`` is not a sub-type of ``resource``?
I'm missing a test which makes sure that the mass updates nullifies the redis counter.
yeah, that was also my original thinking, but I didn't want to introduce an incompatible change in the API without checking with you first. Of course, I forgot to ask this when I pushed my changes ...

Anyway, since we're OK on this, I'll update this change.
whast $exec for? Dont see it used here
They are the same effect, but `blank? is implemented in Ruby, whereas the nil check stays in C. In general, I'm trying to avoid ActiveSupport candy and go more "to the metal".

    require 'benchmark'
    require 'active_support/core_ext/string'

    times = 10000000

    foo = "asdf"

    Benchmark.bm do |x|
      x.report("nil") { times.times { foo.nil? or foo.length == 0 }}
      x.report("blank?") { times.times { foo.blank? }}
    end

       user     system      total        real
    nil  1.010000   0.000000   1.010000 (  1.008783)
    blank?  8.050000   0.000000   8.050000 (  8.096276)
This won't work with string _id's, will it?
you should typehint the interface instead, and use a use statement
Escapes the text. As to why this needs escaping... well, it made sense when I wrote it. /me double checks
popular_videos is a NormalizedVideoList. If we iterate over it, we get back video instances. By using the ``queryset`` attribute, we get the raw SearchQuerySet, which we need because it has the actual watch count available on the results.
I would use [rage_limit](http://docs.celeryproject.org/en/latest/userguide/tasks.html#Task.rate_limit) support in Celery.

So we could use this task to generate many new tasks. For each latitude&longitude combination one. So define another task which takes latitude and longitude and fetches and stores data and define rate limit on that.

BTW, be careful, there might be duplicate latitude and longitude combinations if multiple nodes are on the same location. You should remove such duplications to make less requests.

From this task return the list of all subtasks you created. (If you cannot return tasks directly, try just their IDs.)

Then, in mange.py you can call eager version of task, so that it is run locally, and then get back all this spawned tasks (or their IDs) and then wait on them, nicely displaying progress. :-)
Quote keys as constant strings. `type` -> `'type'`.
Style this comment like others. Renamed boxes to panels.
doesn't work for me..

time data '16. junij' does not match format '%d. %B'
I would pass size to the template and set it as a CSS class on the image. So `small` would become `image_small` CSS class, `(50, 50)` would become `image_50_50` CSS class.
Wrong class name here?
InvalidArgumentException
Object::ToDynObject()
I'm not sure why the exercises-package css doesn't seem to take effect without adding it here.
Folosește, te rog, numele `personal_title` în loc de `title`, să fie mai clar.
I changes those already :)
we already have a NOTICE file with all this.
You don't need args[:] here, just args
I thought of this, but actually I guess we only want to start it if we are not already using tons of threads, don't we?