labofsahil/github-event-dataset-2012 huggingface dataset:
True. It's a copypaste of the system-ui implementation. No point in promising constness if it's not const.
I missed these before. don't use QBool, it's just something we'd have to get rid of when we port to Qt 5 (as it's gone)

since this is a simple boolean return, it's fine to use QVERIFY here if it complains about not being able to type juggle bool vs QBool
This docstring needs some updating
Pubsub isn't necessarily the same as Redis, even though it uses it. We could theoretically implement Pubsub on something else like RabbitMQ. If we did that, we wouldn't necessarily want to transfer all that code from Redis to a RabbitMQ module, we'd just want to re-implement Pubsub appropriately.
I hate those kinds
yes it is, it has to be a function because it needs to return a managed version of the log, this reserves us the ability to reconfigure logs at runtime.

Explained here: https://github.com/sakaiproject/Hilary/pull/126/files#L4R65
I think this would be slightly more readable:
```
callback(null, 'local:' + uri)
fs.unlink(file.path, function(err) {
     if (err) {
        log().error({'err': err}, 'Unable to remove original file.');
    }
});
Heck yes!
I'm not sure it's a good idea to move this inside `reload`. `askToDoFirst` removes a crashed unit from the *ignore* buffer of the compiler. Suppose you have a compilation unit that causes `StackOverflow` on each keystroke. After the first crash, the presentation compiler will place it in the ignore buffer, and you can go on typing in the editor. If you close and reopen the editor, `askToDoFirst` will put it back in the cycle, so you'll see errors as you type *de nouveaux*.

If `reload` does both, and it gets called from other places, it may cause the file to be type-checked again for each keystroke. Maybe leave `askToDoFirst` here, and have `reload()` do just `askReload`.
This test is too whitebox. What should be tested as a blackbox?
As you are implementing the MatcherInterface, it looks like a bad idea to me. Some people might be expecting to call ``match()``
I assume this was for testing during development. =) I'll go ahead remove this, but I'd really like to port our tests to Mocha, which among other things will let you `grep` which test cases to run!
Fixed in #83; thanks!
Did you change charset or formatting? Strange diffs.
The first option.

Emailing from my iPhone 4S like a BOSS!

On 19 Apr 2012, at 18:55, Timothy Warren<reply@reply.github.com> wrote:

>> +            411    => 'Length Required',
>> +            412    => 'Precondition Failed',
>> +            413    => 'Request Entity Too Large',
>> +            414    => 'Request-URI Too Long',
>> +            415    => 'Unsupported Media Type',
>> +            416    => 'Requested Range Not Satisfiable',
>> +            417    => 'Expectation Failed',
>> +            422    => 'Unprocessable Entity',
>> +
>> +            500    => 'Internal Server Error',
>> +            501    => 'Not Implemented',
>> +            502    => 'Bad Gateway',
>> +            503    => 'Service Unavailable',
>> +            504    => 'Gateway Timeout',
>> +            505    => 'HTTP Version Not Supported'
>> +        );
> 
> So
> 
> ```<?php
> 
> $array = array(
>    'item'
> );
> 
> or 
> 
> $array = array(
>        'item'
>    );
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/1266/files#r708603
I don't think that something needed for a single helper function should affect my whole application.
A space after `if` here as well.
```objective-c
[DNA sddObject: _nucleotides[arc4random() % [_nucleotides count]]];
```

Так быстрее, короче и проще.
А у вас Xcode не ругается на то, что метод отличается от изначально объявленного? Просто переменные не на своих местах.
Да, я сначала так и сделал, но потом почему-то убрал это, непомню уже почему. Учту
все действия после **[super init];** рекомендуется выполнять в блоке 
````
if(self){
...
}
````
you can use `doorkeeper_token.accessible?` that will exclude invalid/expired/revoked tokens
this is really awesome to have this installable, btw.  nice work!
Yeah, subscribers are now guaranteed to serialize that, so no need to do it here.
这个loader应该是一个function吧，建议文档写成loader function。
不过这里用可变参数就比较郁闷，比如我只想传入配置，而不想传入loader function就办不了。我在想是否可以将选项不是作为可变参数，而是一个map，也就是接收两个参数 [loader opts] ，然后对opts做destruction，这样也就可以实现只有opts这个参数的重载方法。
Ah, mono. I was confused; the tests were passing for me with the MS CLR. Fixin' to do a force push.
@cspurk You're right, stupid negligence from my side! ;)
Better than the dict, I added a commit for that...


On Sep 13, 2012, at 08:13 , Martin Luessi wrote:

> In mne/source_estimate.py:
> 
> > +            Function that is applied to summarize the data. Needs to accept a
> > +            numpy.array as first input and an ``axis`` keyword argument.
> > +
> > +        """
> > +        times = np.arange(self.tmin, self.times[-1] + width, width)
> > +        nv, _ = self.data.shape
> > +        data = np.empty((nv, len(times)), dtype=self.data.dtype)
> > +        for i in xrange(len(times) - 1):
> > +            idx = (self.times >= times[i]) & (self.times < times[i + 1])
> > +            data[:, i] = func(self.data[:, idx], axis=1)
> > +
> > +        tmin = times[0] + width / 2.
> > +        stc = SourceEstimate(data, vertices=self.vertno, tmin=tmin, tstep=width)
> > +        return stc
> > +
> > +    def get_surfer_stc(self, hemi='lh'):
> 
> As an alternative to this function, I suggest we add the attributes "lh_vertno", "rh_vertno" and "rh_data", "lh_data", which will make it easy for the user to access the data and, e.g., pass it to PySurfer. WDYT?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
move to the beginning of the file
> Background

fixed
Nope, exactly right.
I think we need to rethink the structure of ConceptSearchResult, when i initially added it about 2 years ago, it made sense to include the word that matched the query and we actually ended up never using it, i think this might be the best time to deprecate of it, same thing for the transientWeight.
If you mean why we allow empty name, it is because when this fields was getting introduced, there would be no value to assign to it for existing concept mappings
i though you were checking that the year is a 2 digit one
Must be in the while loop.
Maybe it is best to use salt's terminology:
 * "slave server" -> "minion"


A minimum configuration is required to get the minion to communicate with master.
Does this belong here? It seems to belong more in theming documentation.
The `setRequired` call is duplicated
超过频率限制的请求会被延迟，知道被延迟的请求数超过了定义的阈值
This is so badass I don't even know where to begin
Use `tuple->Set(0, ...)` here.
I think we must support omission of the desired protocol, mainly because having to manually specify protocol in code means that your application is no longer transparent in the remoting.

I propose to change so that it is configured with transport protocol to use by externalization, then the logic can be:

First, check currentTransport, if there is none, fallback to configuration default extenral protocol.
Лучше тут написать `"<em>" + acc->GetAccountName () + "</em>"`, дабы визуально выделить.
А, ну и пусть вообще без шареда иконка будет.
I agree with you : generally interfaces must be used instead of implementations. But in this case, it make no difference for me as methods (which can be overriden : customParseResponse) are called as Assertion parameter even if using AssertionImpl.

I made this choice for readibility. I could have not add the setAuthenticationDate in AsssertionImpl and use the complete constructor of AssertionImpl to set the authentication date (I would have retrieved the authentication date before creating the assertion object), but I think it's easier to read this way.
If you really think I'm not in the right way for this, I can change it...
Wouldn't `switch` make more sense here?
I'd rephrase to "It is a good practice to do any work in a topic branch to keep your master branch clean. The rest of this document will assume you are using it."

Wdyt?
this is still pretty brittle, i prefer targeting IDs which rarely change.
Here `asset_paths.asset_for` is called twice, but I'll fix it after the merge :)

thanks for the patience ;)
Nope the model throws back the exception.
The previous log already contains the number of keys, segment and node, so I don't think it's worth repeating them here.
I'm not sure why it's not showing up in the same diff fragment, but I did add an explanation in the javadoc :)
The new consistent hash we've built doesn't have a number of virtual nodes per physical node, instead it has a fixed 
number of segments for the entire cluster. We could have kept the "numVirtualNodes" name, but since it means something
completely different we went with "numSegments".
This should be `UsingBlock` for consistency with Cocoa collections.
By PEP8, "same line" comments should be preceded by two spaces.  It's a weird thing in PEP8, but there it is...
Ah, ok.  Good point.
Can you rename/refactor this one to refer to the filter type and pass in the selection, perhaps as a string. eg `select_report_process('Plugins')`
Isn't wifi going to be required for this test?
If these even apply (they're meant to be used with pinch.target), they look wrong:  wouldn't that mean you can't do less than 1x or more than 5x in a single pinch gesture, with no relation to the total scale factor?
Joshua Timberman
<reply@reply.github.com>
writes:

>> @@ -28,6 +28,17 @@ def install_key_from_keyserver(key, keyserver)
>>    end
>>  end
>>  
>> +# run command and extract gpg ids
>> +def extract_gpg_ids_from_cmd(cmd)
>> +  so = Mixlib::ShellOut.new(cmd)
>> +  so.run_command
>> +  so.stdout.split(/\n/).collect do |t|
>> +    if z = z = t.match(/^pub\s+\d+\w\/([0-9A-F]{8})/)
>
> Shouldn't this be 
>
> ```ruby 
> z = t.match(/^pub\s+\d+\w\/([0-9A-F]{8})/)
> ```

Hi Joshua,

oh yes of course it should.
I've updated my branch, thanks a lot !

-- 
Laurent
good point regarding existing PHP constants (which are also integers)
Corrigir identação conforme combinado.
@bp323 Added + switched to single quotes
Can we combine `off` and `on` in the same line?
Please add comments like these through github on the pull request, or do a "git blame" to identify the original commit introducing it, and comment on on the github view of the commit. Otherwise we'll just end up with a lot of out-of-context comments around files, which aren't an actionable TODO.
Yeah my mistake - I shouldn't of done any gridfield bug fixing in this work. Do you want them split out? It's hard not to fix other bugs when you are testing.
Same as before, else should go on this line
Actually two spaces (probably a tab), thanks. :)
use the `||=` pattern here.  also the first line here will never affect the function return value.
Can you remove those. It might be better to hold the last value until there release is done. Otherwise I'm afraid we screw with the versionCode value.
Excellent idea, I never liked this busy loop in the OSTimingCoordinator.
I can't do that, the timezone in the CoreExtension is null by default.
JFactory::getApplication()->input->get('option') even.
btw, you should close the stream you just opened to avoid keeping an eventual lock
I don't understand why

```js
this.empty().setProperty('text', text);
```

would not work too.
add empty line here
Does this actually work here in handle_election? It doesn't seem to check if self.rwdb is None, which should be the case 100% of the time for you since you don't have access to the DB.

(The missing check isn't because of your change, but I'm surprised that your change seems to help any. This should be broken for everybody running a local wormgas.)
This is useless as it is already in the same namespace
Can I talk with you via Skype? I have million of questions right now :S
Aaa. OK, some other name is needed. :-)
Do we need this now? Not anymore?
I think you mixed form names around. This form should be for sending token (as comment says) and lower one for processing.

Also comment could be better: *Form for sending an e-mail address confirmation token.*
One thing to note, I'd be actually adding a comment note in these lines stating that these attributes are automatically calculated, so that in the future we don't de-comment these lines by mistake. or maybe even remove them completely? 

these applies to all commented lines.
очисти нашу совесть
Should we check if the authenticate succeeded before trying to link the user to the provider? Or does that abort happen inside the authenticate() call?
old style was ok
ist jetzt in config
¿Podrías hacer esto aquí?

git rm db/structure.sql
vim .gitignore
# añade una entrada para db/structure.sql

El archivo no necesita estar bajo control de versiones y dependiendo de la versión de postgresql donde se genere rake db:migrate va a regenerar el archivo con pequeñas variaciones.
if you need to invoke any method to create the trace message, like in this case ``key.getId().toString()``, you need to ad a 
``if (log.isTraceEnabled()) {
    log.tracef ...``

The performance loss can be very significant!
ta metoda powinna przyjmowac lat/long (tak jak rozmawialismy)

albo w postaci tablicy albo 2 parametrow
`original` and `modified` should be moved out of this function and turned into "constants" (which they're not in reality, but at least they only get initialized once).
At first I though it would be nice to `filter` here instead, but ì` is used further down, so that won't work.
I think the wrapper should first look in sys._MEIPASS and then just try old find_library() function.
Gosh, I should be more careful, thanks.
Probably...in airport now.   I'll look at this and try creating a module:  l1_common.py that houses common code.
I don't clearly understand how to use it to abstract out. Can you do it for me? Thanks
Ah, right you are.  Extract locale is better.
You may want to test if the salt gets set properly as well
Please remove this check.  It's unneeded and doesn't change the semantics here.
This could use an image map.
Yeah, i have no clue why I switched that 

-- 
lyddonb@gmail.com
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Thursday, May 31, 2012 at 10:56 PM, Robert Kluin wrote:

> > @@ -40,7 +40,7 @@ class Person(ndb.Model):
> > 
> > # Person code, name, key
> > name = ndb.StringProperty('n', indexed=False)
> > - n_ = ndb.ComputedProperty(lambda self: self.name.lower())
> > + name_ = ndb.ComputedProperty(lambda self: self.name.lower(), name='name_')
> > 
> 
> 
> `name_ = ndb.ComputedProperty(lambda self: self.name.lower(), name='n_')`
> 
> or, if you want the long name in the datastore:
> 
> `name_ = ndb.ComputedProperty(lambda self: self.name.lower())`
> 
> 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/EzoxSystems/gae-skeleton/pull/4/files#r912840
> 
>
Either option is fine with me.
My own error again.  autoN is a remnant from an older way I was writing this function.  Should say `(if noise == 0)` and `(if noise > 0)` respectively.
>
> view -> viewed (I have a feeling that Rachel is taking care of all the
> typos, and more, right now...)
> No, Rachel is cooking supper and checking e-mail briefly (AND talking
> about herself in the third person)... fixing typos will have to wait until
> later tonight. Or, you can do it if you wish, I won't be touching the files
> for another ~1.5 hours or so.
>

Sorry... I'm going to sleep now, so that's it from me for today.  (I should
have just fixed them myself, I know... sorry!)
using this name means that any one Chef server / organization is tied to having one License for all their Nexuses.

This is a safe assumption but we can avoid problems by allowing the data bag name to be configurable by an attribute.
Failure will result in a lost batch -- not tragic as long as batches aren't huge.  We'll see the error in the celery log, we should think of some way to watch for errors in util logs (splunk type thing?)
If you were to rebase master then this change would probably not be in your commit.
Ah non justement. Je pense qu'il faut que je separe :
 - l'activite recording, utile bien sur
 - l'activite distribution, inutile.
Thanks @Mithgol!  Fixed here and in documentcloud/backbone#1610.  :)
Why not just use calloc here, instead of the malloc + memset? I would probably also have separated the variable declaration and allocation assignment.
I don't think it is. For example if we have a spec like

```ruby
my_method.should match_array([17,3,2])
``

and `my_method` returns nil then Array(nil) will say [nil] doesn't match [17,3,2], which may confuse the user and make them think the method returned [nil] instead of nil. Imo it should say that the result wasn't an array like object.
Should -Dsbt.log.format=true really be a part of JAVA_OPTS?
Blank lines after assertEqual and set_priority please.
DemoBundle <> has <> them
So you probably miss the word `routes´ here
eval! Is there any reason to eval the string instead of handle click event of buttons one by one?

This is a simple calculator, not a scientific one right?
?1 means first parameter, ?2 second parameter etc.
Has $resolvedHosts been declared before? Otherwise this will generate a notice (at least in PHP 5.3+). Apart from that collecting duplicate IPs seems to be a good idea ...
CS please.
Nu e nevoie de afisari in consola.
I would live Content-Type: text/plain not sure that we can just put it as empty.
It shouldn't need them because they should be clipped by the container div. However, I've just checked and it seems that the CSS from jQuery UI is missing an important overflow: hidden for the progress bar.

Either the single rule could be added in our CSS file, and/or jQuery and UI could be updated to the latest versions (my preference).
Capital *"A"*?
В java приоритет по имени сначала у локальных переменных, а потом у полей уже. Да и у других похожих языков так же. Не надо бояться.
Кстати да, я не до конца разобрался с твоим вариантом. Так, действительно, должно работать быстрее, но ты используешь памяти в два раза больше, а это точно неправильно.
copy-paste из wordCounter
.substring тут не нужен совсем. И + " time".
@ctweney module/interface definition for fake. Will consider the fake param first (if existed in url route), and then look at Settings.canvas_proxy.fake
翻訳漏れ？
I think it's possible to rewrite this as `starred_resources = all_resources.filter(starred_by=request.user)` which might be a bit more readable.
Indeed, also not  a great idea.
@ogrisel Nope. `fit` and `score` are the only methods to take `sample_weight` as extra argument.
I think we could start using the memory view API of cython 0.16.

http://docs.cython.org/src/userguide/memoryviews.html

Unless of course you need to call numpy specific methods that have no memory views syntax equivalent.

Alternatively you can pass array points using the `&` operator as I did here:

https://github.com/scikit-learn/scikit-learn/commit/dbea9d88491fa7e747bcb14f43133cac4ecfc32c
oh my god - a kittler

2012/11/15 Andreas Mueller <notifications@github.com>

> In sklearn/feature_extraction/hashing.py:
>
> > +        y : (ignored)
> > +
> > +        Returns
> > +        -------
> > +        X : scipy.sparse matrix, shape = (n_samples, self.n_features)
> > +            Feature matrix, for use with estimators or further transformers.
> > +
> > +        """
> > +        if self.input_type == "strings":
> > +            raw_X = (((f, 1) for f in x) for x in raw_X)
> > +        indices, indptr, values = \
> > +            _hashing.transform(raw_X, self.n_features, self.dtype)
> > +        n_samples = indptr.shape[0] - 1
> > +
> > +        if n_samples == 0:
> > +            raise ValueError("cannot vectorize empty sequence")
>
> Capitalization, full stop. [image: grammar nazi cat]<https://a248.e.akamai.net/camo.github.com/6ce46d82a951968bce98a60fe90313baed8bfbfe/687474703a2f2f737461746963322e666a63646e2e636f6d2f7468756d626e61696c732f636f6d6d656e74732f796f752b77696c6c2b706c61792b776974682b6d65696e2b6675727265722b5f64653834636362323931636537343232393035366664333130326466313433382e6a7067>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/909/files#r2144125>.
>
>



-- 
Peter Prettenhofer
should use relative imports
I keep getting 
```
warning: cd_fast.pyx:86:33: Buffer unpacking not optimized away.
warning: cd_fast.pyx:86:33: Buffer unpacking not optimized away.
warning: cd_fast.pyx:88:28: Buffer unpacking not optimized away.
warning: cd_fast.pyx:88:28: Buffer unpacking not optimized away.
warning: cd_fast.pyx:89:28: Buffer unpacking not optimized away.
warning: cd_fast.pyx:89:28: Buffer unpacking not optimized away.
```
Something seems to be wrong with my function declarations, could someone give me a hint?
Under "vim" you can wrap this text automatically by putting the cursor inside the paragraph and typing `gqap`.
Don't just use the spawn world, make sure the CommandSource is a player then use the world the player is in <code>player.getEntity().getWorld()</code>
looking again on my code makes me think it's bad ... most likely the logic is broken
this will completely break the localization file
Cause I'm picky: middleware instead of middlewares?
One might prefer moving this to a bin_dir location.
will be NOP if sized already, will only do anything if HT ptr table was flushed (i.e. via critical spill)
The 'dynamicPackage' is used ONLY where late filename resolution is happening, so I'm not sure that passing the topology to it is the right approach (or necessary).
Simpler code, same behaviour
Ah, it's a percentage... perhaps the name could reflect that to avoid confusing poor folk like me. Still a little concerned about overflow.
Worth adding a comment explaining what this code is trying to do, adn why.

//Try and estimate the number of buckets that the hash dedup should use
//   If the number of buckets is too high the hash dedup may write to too many individual disk files - potentially causing many excessive seeks.  It won't use all the memory in the next phase.  I'm not sure either are significant problems (output is buffered, and second point may be a bonus).
//   If the number of buckets is too low then we might need to do another round of spilling - which is painful.
//
//The following estimates how many buckets to create so that each bucket will contain few enough rows to avoid another round of spilling  (if there are no duplicates in the input).
I don't think it's the same - abortSoon is a flag set externally (to this object) indicating that the job is being terminated. abortEarly is telling us we don't need to read all the data.

Though if that's true, I think abortEarly is a poor name, since it's (a) open for confusion with abortSoon and (b) not really an abort, but an early successful exit.
Rename this to "readme.markdown" and I'll rewrite it so it reads well on github :)  But thanks a ton for adding this - really useful
How about the following in the spirit of easier to ask for forgiveness than permission?
```python
                try:
                    blob = data['totals'][product_version_platform]
                except KeyError:
                    pass
                else:
                    append_row_blob(blob, totals_labels)
```
missing T_TRAIT for PHP >=5.4
@ochameau please stop bringing this up over and over again, we talked about coding style at work week and have decide to git rid of patterns that
we all agreed upon and this one was not on that list. It really matter of taste and there is no fight against `prototype` or `this` or whatever. It's unreasonable and error prone to implement `event/core` API so that one will always have to invoke via `.call` form.  Also we do optimize for common case, which is
`emit(target, type, event)` and not for an exceptional ones like stack traces which arguably users should not even have to deal with. Finally we don't pioneer different style of APIs here on of the most popular frameworks on the web http://underscorejs.org/ does the same, but again not because it fights
anything because it makes more sense there.

Let's defer this particular style discussions until we're finished with a decided cleanups, otherwise it's frustrating for both of us.
@ctweney Thanks, actually decided to throw an UnauthorizedException instead.
Ah actually, not yet :-D. Didn't clean up properly from the stash.
it is a useful pattern used later form form type switching within views (see format_param) view
Does iDRAC ever allow login over http?  If so, SSL should be an option, not forced.
Ah yes, me gusta
Lets should have an apostrophe.
line breaks + elsewhere
concatenating an existing enumerable with a new element - if there's an easy way to do this with new Array, I'd be happy to do it.
may want to do a length check as well
Agreed. I've added a section with some examples.. Please review. If you think it's not enough, I can add a link as well.
If I were doing isolate stuff with dart:isolate, I would agree. However, I'm doing HTML stuff with dart:html. In the best case, dart:isolate is just using window.setTimeout, in which case I've used a useless level of indirection. In the worst case, dart:isolate does something with actual isolates. That would be like trying to nail a nail into the wall using a sledgehammer.
Too many magic numbers! Use constants.
Why use the FQN?
А нельзя просто все falsy-значения принимать вместо null? Ну или хотя бы undefined.
You don't align a pointer on an 8-byte boundary on a 32-bit system; you align it on a 4-byte boundary.
Same comments about the assertion and the foreach loop.
... in which case this code should be amended too
:/ must be my botched rebase...

I had actually removed them in the previous commit. Anyways, I removed commas everywhere I could find them.
I had changed the test into a 2, for symmetry, but you make a good point of testing 0 explicitly.
@dansilivestru thought it might be useful. Personally I think its not the most commonly used code so a helper function is useful. However we can remove if that is the consensus.
added. Also git proposal dependency becomes fully optional now
Unused code, can be deleted.
please use IPA header from https://github.com/ipa320/setup/tree/master/templates
Remove the period at the very end.
Fine with me then.
On Aug 3, 2012 9:34 AM, "Christoph Gritschenberger" <
reply@reply.github.com>
wrote:

> > @@ -263,7 +263,7 @@
> >      <dependency>
> >        <groupId>org.openengsb.framework</groupId>
> >        <artifactId>org.openengsb.framework.security</artifactId>
> > -      <scope>provided</scope>
> > +      <scope>test</scope>
>
> The security-impl is actually used in the unit-tests. It would take some
> time to replace it all with mocks
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/730/files#r1299863
>
As my name was invoked and this is an open source project, I figure I'd weigh in on the policy that I had used during code reviews and my perceptions of this topic:

__Re: Best Practice__

When manipulating data within a database, returning the manipulation's success (or failure) _is_ a best practice as it allows the code to react to successes/failures of writing to the database.  While a return may not be used in the current version of the code, it future proofs it for:

* Logging
* Error reporting
* Error messages to the user
* Other unforseen uses of said function/return value

__Returning During MIS' Past__

During my last 4 or so months as lead developer at PSU, I would _strongly encourage_ return values to be used in any code MIS developers produced and urge their usage in functions that manipulated the database.  Flexibility of code was important to MIS and future proofing meant less work later.

I dinged @nrporter , Laurianne, @zbtirrell, and others on that practice when they didn't follow it (and they did it to me when I forgot).  My hope while I was there that all functions/methods going forward would follow that practice.

Whether that is the direction that MIS wants to continue to take is up to them, but that's the recent history of this topic and it's working internal practice.  It is important to note that that practice was not on the MIS wiki when I left, though.
Nice to specify the actual gem name 'rigtht-aws' or whatever
Remove this line, it's unnecessary and can cause issues if anything appears after it.
CS? Concerning the spaces - it's inconsistent but I didn't change the former layout.
lets add this as a second test within another context where `:saml_options` has `idp_sso_target_url_runtime_params`.

that is, we need to have a test which checks that `last_response.location` is exactly (not a regexp match of) the `idp_sso_target_url`, without any additional parameters when no runtime params are specified in `:saml_options`.
On 8 Dec 2012, at 18:32, Kenneth Hoste wrote:

> In easybuild/easyconfigs/o/Oases/Oases-0.2.08-goalf-1.1.0-no-OFED.eb:
> 
> > +
> > +name = 'Oases'
> > +version = '0.2.08'
> > +
> > +homepage = 'http://www.ebi.ac.uk/~zerbino/oases/'
> > +description = """De novo transcriptome assembler for very short reads"""
> > +
> > +toolchain = {'name':'goalf','version':'1.1.0-no-OFED'}
> > +toolchainopts = {'optarch':True, 'pic':True}
> > +
> > +velvet = 'Velvet'
> > +velvetver = '1.2.07'
> > +
> > +sources = [
> > +           '%s_%s.tgz' % (name.lower(),version),
> > +           '%s_%s.tgz' % (velvet.lower(), velvetver)
> 
> It sounds like Oases is borrowing some of the source files that Velvet provides. In that case, it would make sense to add the Velvet tarball to sources.
> 
> However, then it wouldn't make sense to still list Velvet as a build dependency (because then you require that's it also built by itself).
> 

Ok, this may be a misunderstanding from my side. I was using this as a way to access the variables in the corresponding oases easyblock - in the build_step()…
If you can point me to a way how to do that more nicely, I think (ATM) that this could be removed as a build-dependency.

> Is this documented somewhere? Can you point us to it?

It is documented in the README.txt that comes with the oases tarball. Otherwise, the website (http://www.ebi.ac.uk/~zerbino/oases/) states <quote>Oases was designed with a 64bit Linux-compatible environment in mind, with gcc. It requires the installation of the Velvet package.</quote>. What I am wondering is if it is only borrowing the code read-only or doing some modifications. In the latter case, I don't think that one would necessary like to have a different package interfere with an existing installation, even if this packages come from the same developer and both are most likely usually used together.

> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

Cedric Laczny,
PhD Student
 
UNIVERSITÉ DU LUXEMBOURG
 
LUXEMBOURG CENTRE FOR SYSTEMS BIOMEDICINE
Campus Belval | House of Biomedicine
7, avenue des Hauts-Fourneaux
L-4362 Esch-sur-Alzette
T +352 46 66 44 6398
F +352 46 66 44 6949
cedric.laczny@uni.lu     http://lcsb.uni.lu
 

-----
This message is confidential and may contain privileged information. It is intended for the named recipient only. If you receive it in error please notify me and permanently delete the original message and any copies.
-----
should we not check for <?xml while we are at it?
Good spot - this was implemented in my old way because it is part of larger object that can be tweaked in realtime.  Anyway pointless code right now so cheers for that.
Ich würde einen Konstruktor schreiben, um gewisse Werte zu initialisieren:
iteration = 0
state = offered
...
Ну порядок инклюдов же.
И нахрен оно тут ваще появилось?
There's no problem with tabs. I use tabs for all of my projects and we never end up in a mix of both spaces and tabs.
Bert - can you point me to the style  guide? Thanks.
The class contains a lot from BannerPhraseInfoBase\BannerPhraseInfo\BannerPhraseInfoWithStats, maybe there is a reason to inherit?
Oops; you are right
mixed leading tabs and spaces
Hello, Gary!
What is a reason to make copy of `this.adviceChain` and to do double check on it?
Yep, that is exactly what I got.
Okay just ```from musicbrainz import *``` does not work anymore.

**but** I would still rather use ```import musicbrainzngs.musicbrainz```, rather than relative imports.

Note that [PEP 328](http://www.python.org/dev/peps/pep-0328/) was not about using relative imports all the time, just that this option is still available if for some weird reason you can't just use ```import paketname.module```.
You put all these rules inside an .idea block that ends in line 331.
This is enough to get the spec test as-written to pass. If we decide we want to use .fixtures.yml for other purposes I can fill it in (or just fill it in now if you prefer)
I would prefer not changing the defaults in this PR, especially since it's the sole thing that's blocking the merge IMO.
таки да - устоявшийся термин
IndexWriter.sections(examples, configuration) will give you an enumerable that manages this complexity. The way you've written it here is somewhat confusing, and IndexWriter is tested.
Someone can explain what this function used for? example would be great.
the bundle is compatible with 2.1 too AFAIK
@bp323 We should load the application CSS before the lhnavigation.
So there shouldn't be any changes to this file.
I left that in as bait - you passed. 0a111fb2040c94b1d8fcd625cf8fed09ca60d078
Same mutability issue here.
Unless we are going to return all subscription lists in a GetSubscriptionInfo(emailAddress) call, including the lists that the user is not opted in to, I don't think we should add opt in here.  If we do add opt in here, maybe we should get rid of the GetAllSubscriptionLists(publisher) call because you can get all the subscription lists just by getting subscription info for a user.
That makes sense. Thanks for the explanation. I'll drop the import.
The main change that has to be done to spotter/disambiguator classes is that they should have _everything_ they need in the constructor and that they should use InputStream instead of File (so they can be given Gziped input or data from the jar file).
Good point! Refactored some code before committing and overlooked this. Thanks for the note!
You mind if I change the title?
`Indexing interceptors: to index or not based on entity state`
Sure, why not. I'll search for an native alternative way without intl extension.
This isn't helpful to anyone if you don't tell them what a type is where possible values for it can be found.
unittest2 has test discovery; we don't need this...
Jms/active mq doesn't support any objects, it only accepts primitives and the only Objects are primitive wrapper classes and collections
Ugliness noted.  What do you suggest?
I think we should strive for something less intrusive here. I will have a look at what DBUnit has to offer for this case after work. Thanks for great job so far!
Guess we could revert this as well if people prefer the tabbed out spacing.
this should be if (request.readyState === 4 && request.status === 200) 
double if sucks
finish this refactor