labofsahil/github-event-dataset-2012 huggingface dataset:
The thing about the unix PRIMARY clipboard is that it should be populated no matter how something is selected, i.e. with the mouse or keyboard. That's how emacs and other text editors that use it work, and if we're going to support it, that's how we should work too.

The problem of course with that is it would be slow. Copying once on mouse click is no big deal. Copying every time the cursor moves as the user adjusts the selection area with the keyboard would be slowing down the program, 99.99% of the time for no benefit to the user.

Do you have an actual usecase for supporting PRIMARY?

Also, https://github.com/oskusalerma/trelby/wiki/Contributing says this as a guideline:

"Is your patch cross platform? Will it work on both Windows and Linux?"

Guidelines are just that, guidelines, not fixed rules, and obviously platforms differ in how they do things. But we should consider carefully before introducing very different behavior between platforms and only do it if the benefits outweigh the costs. For PRIMARY, I'm not sure they do. In my experience I run across people using unix systems all the time lately who do not even know PRIMARY exists, and do copy/paste in linux just like they do in windows, because that's what they're used to, and that's what all modern linux programs support. So PRIMARY is a bit archaic and not really something that people necessarily expect to be available in all programs nowadays.
Здесь не хватает add_column тех полей которые ты удалил в up.
Ok it seemed to me like it is different for example this code which is only part: https://github.com/mangos/mangos/commit/f86728b540d7d82d8a8df4603b042a58fb3af1bd

Also it is still crashing quite often because of this crash: http://paste2.org/p/1901709
Thanks for finding this, was not sure where it came from.

And yes, files should not end with ?> according to our CS rules.
I'd rather use `isset()`, but that's a great suggestion - thanks.
I also fixed the static files (I hope) and removed the hard-coded URLs so that someone wouldn't have to change settings.py.  I've also added some infrastructure to play around with dynamic updating of the inquiryweb as it develops.  I'll try to merge in your changes when I have time, and then I can send you another changeset or put it up somewhere that you can pull it in yourself.
I think this regex is too restrictive, for example on my phone output from Gecko looks like this:

E/GeckoConsole(27706): info: content script, init
Instead of blacklisting `about:` urls, we might want to *whitelist* `http:` and `https:` URLs, since there's lots of other protocols that likely won't work here (e.g. `chrome:`, `file:`, etc).
Rather than *.prop and *.save, why not just CSISaveGame*

That way you won't need to ignore prefs.prop
The question is, should I return an error, or just print a warning and skip parsing the file again?
What about Melted?
i tried that and in some very very very small amounts of water (orgrimmar) itll still happen
Oh, ugh. Thanks, google.
http://www.cgisecurity.com/csrf-faq.html#referer
Não, vamos manter no /public mesmo. Esse assets é desnecessário.
Why not just use double instead of float?
Strife, can you email adam@wozniakconsulting.com?  I'd like to
exchange some emails with you on a non-lslint related topic.
Heya

Compile on linux all OK, if u wanna start the core, memory error and extrem problems with VMAPS ( u most turn off on the config file ) but the core dont start, u get a memory error
Think I see the problem here -- this should go in the if loop, as we don't want the tab to change if you're not closing out the active tab anyway.

btw, a more concise way to write this sort of thing:

`$nextTab && $nextTab.click()`
+1 for a common version like we do for everything else
I changed it in my fork's code, but now I can't figure out how to add these changes to this pull request :-( Could someone nudge me?
Hah, talk about timing; just stumbled on your document via a search for bobby tables, thought, oh, perhaps I could provide a Spanish translation, and see that you decided to scrap the translation support just yesterday....
Fixed, ty.

On Wed, Feb 8, 2012 at 4:03 AM, jochenberger <
reply@reply.github.com
> wrote:

> This broke the mouse zoom example.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/HumbleSoftware/Flotr2/commit/e645316fb10bbdd5ed06c3be0ab586e7e22d74f6#commitcomment-944473
>
Whoops, my bad!  Thanks for the catch!
Alex,
you're right. What's weird is that I am sure to have cleared my browse cache and tested this case before committing :(
Nice. I was thinking about implementing this by listening for file changes & flushing the cache but this is much simpler.
using `length >>> 0` is also consistent with:
https://github.com/sstephenson/prototype/blob/c4a9149df10abecd80ad695ea91ed3720cad858d/src/prototype/lang/array.js#L193
Yup, we actually had this problem with one of our applications; manifested as a NullPointerException thrown by putTable. The application has a bunch of threads getting HTables out of the pool immediately upon starting, so around the same time.
Ah, thanks, it works now. (I had FreeSerif installed, but needed to copy it to the el folder)
I very well know why the root check was developped since I wipped out most of our development environment because of this "bug" just before living for vacation on december 24th 2008 :)

But I disagree on your argument. If CacheDir is set to an absolute path, it is part of my ezpublish installation but outside of my ez webroot. I do not want to bypass root check which is a very good. I only extended that root check so that it still works if my configured cache is outside of my ez webroot.

Disabling the root check when clearing the template cache (i.e. when using the ezcache script) would be a terrible mistake in my opinion and could potentially lead to the same situation as the issue you gave as example in case something goes wrong.
Are there any issues with including the test conditionally based on the presence of the DontEnum bug?

```javascript
var dontenum = (function(){
  for (var p in {toString: function(){}}) {
    return false;
  }
  return true;
})();

if (!dontenum) {
  test(...);
}
```
naja, private ode rnicht, die core macht nach wie vor ununterbrochen fortschritte, und da sieht man, dass public oder nicht völlig egal ist, da lockne sund ich die einzigen sind, die wirklich drann arebiten, daher seis drum, ob wa public oder private sind
The inheritance from Error is actually just the code playing tricks on you :)  InvalidTransition and InvalidParallelTransition inherit from StateMachine::Error which is the Error class you're seeing referenced there.
I think it would be wise to also include .svn and .git in the list.
Yes, this seems to have done the trick.

Tried the MSVC builds too - and they all compile with no problems. Tried a libsnes Linux library and it ran without problems on SSNES.
As you said, unless you have a reason to enable a RDBMS dialect, this commit should go away. And if we do need a RDBMS dialect, we would rather delegate to the original Hibernate ORM DialectFactoryInitiator instead.
The zoomlevel is missing here. As an example there can be two completly different tiles for x=10 and y=10.
Per naming convention, setters should always have arguments. Is there a different name that would describe what this does? e.g. updateTextContent()?
of course they pass! :)
before this commit, router will never has models passed to it
wut... 88747 is the summon spell it would just summon mushrooms everytime

8777 was right That's the damage spell.
I don't think this really fixes the issue. boss_load:view_module/2 still uses the application under development for its logic (see line 297). I'm also hesitant to use code:lib_dir/2, which is marked as "experimental" in the docs. I'm not sure when it was introduced.

I think the right solution might just be to return "src" from boss_files:root_src_dir() (so that file names returned from boss_files are relative) and fix boss_load:view_module/2 to take a relative path.
I saw in tc that play the movie comes for spell. I don't remember the id :( .
We also need to find a way to reliably generate URLs to issues, since Redmine could be running under url rewriting (e.g. `http://host/redmine/the_rest_of_url`), so we can't start addresses with /.
Alternatively, this function could be moved into unionWith. since the higher order argument will always be `(go (s+bitsPerSubkey))`
Argh, I forgot one "esta", basically all "esta" should be "está"  since it's used in an "to be form" rather than a pointer.
Does this currently feature all possible coordinates with different keys?
Also, it does *not* seem to pay attention to multiworld!
Wondering if this or `read` is better.  Undecided.
I was working on a prototype using Mark's jquery-renewal and implemented a feature like this. It's a great on to have, but due to the way it animates I felt like it wasn't "circular". Later, I think 'infinite' might have been a better name. It's doesn't technically wrap, but it does continue.
shorter yep, but runs counter to the ideology of the module (quick_*, _query, etc)
Change of how to get *simulatorWindow.
Why was the change made from `App`?  We should use `App` since it should, or at least used to, buffer resize events.
OH GOD YES
tpruvot, is your cm9 base on 2.3 still?
Thanks,

I couldn't get the restserver running on one webserver but it was working fine on my localhost. 
I made the change and now it's working on both :)
This is not needed. it should be just:

```
    ...
    @EventHandler
    public void pluginEnable(PluginEnableEvent event) {
    ...
```

You'll also note that I've changed `onPluginEnable` to just `pluginEnable`. The ons made sense when we were overriding, but now, we can read it as "Our `pluginEnable()` method is called when the `PluginEnable` event is fired."
I only committed it. -.-
Some plugins create files like _comments.changes or _linkbacks.changes and media revisions are stored in _media.changes. I think you should skip all files beginning with a "_" as this is not allowed in filenames and thus used for various changelogs.
Can you explain why you need a new command instead of using the existing one?
OK. Just the focus? Can you paste the output of "cat /proc/bus/input/devices"?
`required="required"`
oh, didn't know that:( maybe a workaround will be found...
Forgot to change the name to Tyrel Kelsey :)
Rather than duplicating, can you just add this error on the same line, comma-seperated with the existing ECONNREFUSED rescue?  That way we won't have to worry as much about them drifting apart or anything of that nature.  Thanks!
Do we know why transposition is necessary?
This SVG does not meet the specified format, as seen in all the other widget images.

I also can't tell where this image is sourced from and if there are any licensing or copyright issues.

Please start from an existing widget SVG (jqm_footer.svg for example) and use the existing color scheme and styling to match.  Be sure you do this by hand, not from another tool that will add all the extra SVG XML content.
Shouldn't we rely on a dedicated "time" library like **Joda** ?
Yes, they are in there as an artifact of the move.  There was some minor shared resources (i.e. error pages) that should have been separated.  There's not really a point to skinning the management tool.
I am in favor of `Integer.MINIMUM`. I'll have to cross check and see how the count is accumulated on the caller side.
Sadly, based on maven docs in a multi-module project, everything can be inherited from the parent site automatically, except the menus. You'd need to explicit declare that a child module need to inherit the parent menus through the `inherit=top` setting.

Ref: http://maven.apache.org/plugins/maven-site-plugin/examples/multimodule.html
It should say "Because, __getitem__ returns a new IterationIndex ..."

will fix
I think that it's harder to read with a comment at the beginning of the line. Could we keep the _extra_ `val`?

And the test doesn't test the same thing `(2000 + 399) !< 2000`. Is that intentional?
Why @volatile (docs)
Why are we merging the queues? This behavior is different from a normal cell. And why is the suspend count removed?
yeah, you got it
didn't we say that .empty is badass? :-)

that one was funny, thx
so if someone sends this a buggy message, we don't want it logged in unhandled?
As you can see, i just moved that exception down from the is_null check. Also controller after method makes sure a Response is returned. I was basically following what was said in the docs: http://docs.fuelphp.com/general/controllers/base.html#/returning_results
I'm just aware that the helper functions are not the most well named bunch of functions.

changing the actions feels dangerous unless we deprecate the old names.  But could be a nice plan.  I think this may want wider discussion in the team.  We could do something like

    @deprecated_action_name('recently_changed_packages_activity_list_html')
    def activity_stream_packages_recently_changed(..):
it looks like this has been done - can this comment now be removed?
signed/unsigned warning here
I added GetCommonNav which takes a table/view name and the name of the field in that table/view to be used as the label of the retrieved item. That safes quite some code duplication.
well, this code is executed once every 5 seconds when no device changes are reported by the os, and it's not blocking anything. and even if a device change comes in, I don't think the user will notice the delay of assigning one more int when inserting a new device :)
I don't like this. It means that whenever someone just wants to retrieve the streamdetails we will also query the database for the cast, sets and other information that require extra queries. Either make an extra if-condition-block for the streamdetails or add an "if (additionalInfo)" in front of the videodatabase.GetFooInfo() call (not only here but also for episodes and musicvideos).
I checked source, you are right. The return of GetField is encoded. So it must be decoded once before use to get back to the original value.
No need to do all this here if you can't delete a tvshow anyway (you don't retrieve filePath).
I picked `0.1` because it seemed to have the best speed for watching the patterns.
typo here, should not end with ?
If you could convert these docstrings to the style you've been using, it would help readability. :)
On Thu, Aug 23, 2012 at 12:35 PM, Patrick Mahoney
<notifications@github.com>wrote:

> Do you happen to know if I need to submit a new pull request?


You can update an existing pull request.

-- 
sam th
samth@ccs.neu.edu
If it replaces validRead() then remove it.
validRead() is been tested at TestReadAlgorithm, adapt it to test this new function.
Not sure if this makes it more readable but I copied the patches to the wrong directory on the first try :)
... || return 100
return 0
This is wrong. It is not defined if you don't add a path for it currently
Hey Frank,

I agree.  The trouble is that no existing dir fits the bill as they
are all for temporary stuff.  I didn't want to decide on a new
location so I asked in #fuelphp and FrenkyNet suggested tmp or cache
so I went with cache.  Please do change to something more appropriate
(or I can?)  In our project we just use APPPATH.'smarty'.

Thanks,

T



On Sun, Jul 1, 2012 at 2:09 PM, Frank de Jonge
<reply@reply.github.com>
wrote:
>> @@ -138,6 +138,7 @@
>>                       'compile_dir'       => APPPATH.'tmp'.DS.'Smarty'.DS.'templates_c'.DS,
>>                       'config_dir'        => APPPATH.'tmp'.DS.'Smarty'.DS.'configs'.DS,
>>                       'cache_dir'         => APPPATH.'cache'.DS.'Smarty'.DS,
>> +                     'plugins_dir'       => APPPATH.'cache'.DS.'Smarty'.DS,
>
> I don't think the plugins dir should be in the cache folder. If Smarty uses cache, that can go in there, but plugins should reside elsewhere. I don't have an idea yet of where it should go, maybe under APPPATH.'classes'.DS.'Smarty'.DS
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fuel/parser/pull/48/files#r1081561
As above, `siblings` would probably be clearer here.
This `enum` isn't actually used in the interface. I think it should be moved to TUITableViewCell.m.
Ah, again, debug-like code... I'll get rid of that.
oups sorry, I understand that is a new selector :-)
By the way, you should use uint8_t consistently in this function instead of switching between uint8_t and char all the time.
It is odd. I created a cluster function to get a pretty stack trace, but I have no idea why the name begin with a small `c`. It is not a public or exported constructor so it doesn't really matter, but you are welcome to _fix_ it.
Then at least don't apply the whole initialConfig to the child, but only the editor specific config options.
это стоило бы разбить на несколько переменных, которые поясняли, что здесь происходит.
если передавать его в конструкторе в StartDialog, то этот метод не нужен будет
right, I miss it
Always put new CHANGELOG entries in the top
`EmptyTree` itself represents an error. See the Scaladoc here: https://github.com/scalamacros/kepler/blob/438cecddd2ee33d2611cb1b6c4769699c907746d/src/reflect/scala/reflect/macros/Reifiers.scala#L65
No, I'd have this NonInternal simply match a narrower set of exceptions, that is, leak controlthrowables as u did above.
That sounds good. Then I could move `unwrapApply` here (along with a bunch of other methods - I guess, it'd be okay to pay the small performance price to stay clean). I like the name too - thanks.
Lazy - my first impression is it does not have to be, but a similar thing is lazy in GenTraversableFactory, apparently due to: https://issues.scala-lang.org/browse/SI-4789 (I haven't cast  a detailed look yet).

Public - no probably not.
This line can just be this instead:

```
if params[:callback] && request.get?
```

I will update the commit accordingly when I merge.
I'd vote for `deconstruct` instead, given the object-orientedness of SymPy and the usual associations with the word `destruct` in the object-oriented world.  You may also go for `explode`, which is both shorter and semantically closer to "destruct".
There are no extra spaces here.  There should always be spaces on either side of `=`, except when used to define keyword arguments in a function call (like `f(x=a)`).
Since this is testing the base and not the components of the exp, this should definitely ask if positive rather than not negative (see my previous comment).
Also @raoulb
Isn't  `_eval_trace` handled above?
I'm not exactly sure because these dimensions have a sense only within the MKS system. But you can derive system from other one, for example getting MKSA from MKS by just adding the current and the ampere as base.
Also if for example you want to deal with data quantities, you will need only this dimension and bytes/octets, so other dimensions are useless and should not appeared.
Tests reports are [there](https://github.com/goodok/sympy/pull/2/),
after second comment.

In particular:
http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY-vMQDA

Failures classified as:

in tests:
1. my new tests which tests the order presereved.

2. Hided (I think) bug in the Order class, with logarithms.

3. obviously, tests which are based with testings the `.args` order at
the result expression.

4. written in the form with order dependency. E.g. Mathematically
`solve` function must return the sets, not ordered list.

Note also, I replaced output to sets in some cases previously, for tests
related with `solve`-like functions,

Also: "sift" and "as_coeff_add" but may be they are belong to 3.

5. Unknown:

split_surds -  I don't know about it.
cse - may be related with 4. that is lists in output incorrect, must be set.
I was basing my comment on a coverage report. So unless I mistook this line for another, at the time I wrote the comment, it wasn't covered. This might mean that an expression you thought you were testing auto-evaluated to something else and didn't hit the line of code you thought it would. Perhaps ask(Q.real(Pow(I, 3, evaluate=False))) is necessary, for example.
If the default key parameter unimodular=True/False is used, it is not clear how to work with other default keys in some classes. To remove them?
For example, FreeSpace class. Default key is refractive index n = 1.Then FreeSpace(d, True/False) will be treated not correctly.
On 14.04.2012 21:21, sachin004 wrote:
>> @@ -327,7 +327,7 @@ def eval(cls, arg):
>>               return S.NaN
>>           if arg.is_zero:#equals(0):
>>               return arg
>> -        if arg.is_positive:
>> +        if arg.is_positive or arg.is_nonnegative:
>
> I tried that but its showing failures such as ''Pi' has no is_nonegative
>

Pi has that. I think any failures that are of the form "x.is_positive" 
is True but "x.is_nonnegative" is not are bugs, please report them.
I think it will be a good default. Currenty it doesn't work for namespaced modules anyway.
Inject this in the CTOR
Ok, maybe it's my brain that is forgetting how to use ProviderBundle since it's something I never had to use until now... but the goal is only to write the ginjector, what would usually be in the ginjector when there's a provider bundle in the application?
ditto, `test_wrong_exception_raised`
どやろ
Shouldn't this data set contain > 1 of some values to properly assert distinct and union?
Indeed, and it is likely to be broken as the EarlyKernelRequest runs before the LocaleListener so too early to have the locale
Just `PHP_SAPI` const :wink:
Wouldn't it make more sense to do this in main(), Main() or startGUI()?
I guess we *will* allow the variable to be null, or are you planning to use a placeholder of some kind?
we should doc this base_url thing
yes. :)
Func
On Aug 21, 2012 8:54 AM, "Andrew Leung" <notifications@github.com> wrote:

> In source/administration/sharding.txt:
>
> >
> > -Use :func:`sh.status()` to determine the current chunks ranges across
> > -the cluster.
> > +To determine the current chunk ranges across the cluster, use
> > +:func:`sh.status()` or :dbcommand:`db.printShardingStatus()`.
>
> I find 2 variants used throughout the docs now. Which is better in this
> case?
>
> :func:db.printShardingStatus()
> :dbcommand:printShardingStatus
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mongodb/docs/pull/140/files#r1423850>.
>
>
Also MT_TO_KUMA_LOCALE_MAP at https://github.com/mozilla/kuma/blob/master/settings.py#L197
Please look at the other comments? This is for develop-olympus and thus PHP4 code.
What's with the ===? == will work fine.
What is in this array?
These are different $style and $template variables
@callumacrae Those 4 lines (including the comment) are duplicated within this PR. Thus it makes sense to extract a function, so that when that behaviour changes, it can be changed in one single place. Also, a named function communicates the intent of what that piece of code is supposed to do.

@p Do you have anything to add to that?
Please do not use "void". PHP functions return null if they have no return value so mark them as @return null, same applies to all other places that in which you used void.
This looks like independent breakage. Was a test added for this code?
Should not be required when using the config object.
Uhm why not pass either the object (if you want to use it) or null if you don't? Avoids this whole mess.
Just noticed the use of " here. I can understand not wanting to have to escape the apostrophes, but I think we should reserve " for when we need to parse variables.

At the very least, the "UPDATE " should be changed to 'UPDATE '.
Why put these in the code and not the config file?
I'm not sure about this change. Do we need it?
Doesn't this box value type ?
I do think you should document setValid function because it's unclear what exactly this function is going to do: remove from the scene? re-init? or else
Този сайт ползва Rails 3.1.1 в момента. Силно подозирам, че кодът, за който аз говоря, влиза в сила от Rails 3.2.1 и затова не сработва при теб. Т.е., в Rails 3.2.1 вкарват новия код и deprecate-ват стария, но преди това новият го е нямало и явно няма как да сработи :) Остави го `.html`.
Hmm... OK.  I would say that if `ac.partial.compiler()` is sufficiently useful (as you argue) then we should let it drive a change to the view engine API and require that -all- view engines (including `mu`) support it (via the new `compiler` method).
addParam_ doesn't support Param::FLOAT value. Also other Algorithm's method (get/set) doesn't support float type.
If you don't use extra and extra hash, then leave them out.
I think allowing `manual` as an entry for the first element in the tuple is a bit confusing.  Entropy mgr has the notion of automatic or manual.  That makes sense.  Either mode requires that anti entropy be "on."  To me it makes more sense if the first atom is `on | off` and manual mode is invoked by include the option `manual` or `manual_mode`.  As it stands now the user could invoke manual mode in two ways `{on, [manual]}` or `{manual, []}`.  Why have two different ways of putting the system in the same state?
Ops, my mistake, this should not be so.
Why only a comment?
It's just more compressible if string repeats are close together. `rquickExpr` does best like `(\w+)|#([\w\-]+)|\.([\w\-]+)`, and `Sizzle` does best by clustering the ` if ( (m = match[` pattern. In fact, there's *another* -2 bytes if we reorder ID to the end here.
Thanks. It is very reasonable. I have changed.
`OR REPLACE` is not needed.
This file has a lot of inconsistent indentation.  As always, please make it consistent.  Especially in C++ code, we use 4 spaces for one level.  Make sure your editor visualizes spaces and tabs, leading white spaces.
You are right.. Fixed :)
Do we need to handle browsers without console?
django-mobility also has a mobile check against the user agent. We might want to lift that code. It looks like it covers more possibilities than this. It's possible those possibilities are old and not relevant anymore---I don't know.
It would be better to (a) pick a revision rather than pointing at master and (b) use subformula so that they can be checksummed; see the git formula for an example
Thanks for the feedback.
Done.
Suggest maybe "Add capabilities to your applications through cartridges" here, to give users an idea of what can be done.
Would prefer if we can stick to `lowercase_underscore` in variable names for consistency.
`We` is not clear.

"Remove a vote on the object in the context of the logged in user."
A lot of callback spagetti would have been saved if the session store was promised based (sequence anyone?)
spaces, kwargs
Done (dependency graph -> object graph).

As to the rest, I'm going to leave it to you on this, though as much as I like the idea, be careful about making it too opaque and mathy, as we talked already about avoiding making the whole thing too close in nomenclature to a graph theory library (even though it kinda is)
Never mind - this method is now obsolete.
The intention was to have the functionality of the second case.

If we have `rand() % (highest_value + 1)` the highest value we can get is `highest_value` as `x % y` is at most `y-1`.
In case you want to keep console logging here, I believe, you'd be better of using fluid.log() utility. It will then only be enabled when you run your system in development mode and disabled in production.
There's an extra space at the beginning of the line, which makes it appear odd in github.
None at all, I was just copying a pattern. Though this is a little more semantically obvious for a reader.
Great - left it as Series mostly for simpler testing. Only thing I'm worried about it that this all runs (including the `self` synclet) on the API hosts, feels like bad things could happen if we let it go too parallel.

Good thought on the whitespace.
there's already a 'nav-button-base' mixin in there -- should it be merged with that somehow?
OK.

I didn't translate messages on the 'About' dialog because it seems to contain sensitive meanings, as legal notice.
But I have translated and pushed translated version, please see [that](https://github.com/shumpei/brackets/commit/a1b93e7f8a0c4e3e13f1f064f4a30eda578f2dba).
I recently added a getModeForDocument() method to Editor, so this functionality should be put in a Editor.setModeForDocument() method.
AttrHints and TagHints each get their own copy of the HTMLTags and it's parsed twice. I think it would be better to parse this once in the module and then make these classes share the result.
I'm not worried about any potential performance problems:

* `FileUtils.updateFileEntryPath()` is a no-op (and exits quickly) if the file entry path doesn't contain `oldName`
* We would need to do a basic path check anyway to find the tree items whose path contains `oldName` anyway, so this isn't adding any extra work.
* Renaming is a user-driven operation that is not done frequently. Even if this iteration took hundreds of milliseconds (which it shouldn't....), that would not be a problem.
(Or, if expanding the selection automatically is hard, add an extra param that can specify an extra selection to test before uncommenting.)
I've just pulled a new request, see:
https://github.com/cubing/tnoodle/pull/57
What is the int 4 ? Give it a name through a static constant
> folders

lololol
Where should I put it then if not in the separate file? You probably meant "head" section? OK i will use jQuery to "attach" script files to DOM
`"language_code"` -> `<language code>`
Have you updated the pull request? Here you see that it is still visible in the diff.
Would not know i didn't do the original string, but I can change it if you like.
Could you remove the ++loadedLayouts and change the next line to:

if ( ++loadedLayouts === layoutsToLoad.length ) {
same line as } above it
I think this is indented wrong. Does it go with `<div class="thumbnail preview-thumbnail">`? I think so. Please fix.
you don't need to pass `{}` here, you do `options = options || {}` inside your functions
I've put the snapshot ID back into the if clause.  Well spotted!
Absolutely. Fixed
you should enable dso, if you ...
I think this could be more clear if this method looked something like user.receives_notification_for("new_discussion")
En fait je pense que c'est con d'envoyer le user et la date. Finalement, le mieux c'est d'envoyer le post et le thread.
Type hint avec UserInterface.
Typiquement, comme ça c'est une fonctionnalité métier, tu pourrais ajouter un petit test dans ThreadTest (logiquement le fichier existe déjà), pour vérifier que si tu défini l'auteur, tu as bien count($thread->getFollowers()) === 1
These changes are all wrong - they remove my new code
This line can be reverted - I ended up not using the asset.
-d

On Tue, Sep 11, 2012 at 2:04 PM, Brad Buckingham
<notifications@github.com>wrote:

> In src/app/views/repositories/_edit.html.haml:
>
> > @@ -1,4 +1,11 @@
> > -= javascript :edit_helpers
> > += javascript :edit_helpers, :repository_edit
>
> Are we missing a change to assets.yml for repository_edit and possibly js
> files?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/628/files#r1576071>.
>
>
Assuming KT.content.cancelRepo isn't needed anymore, lets get rid of it!  Its a good chunk of code.
@stof Do you have a better solution for this? 
The current solution seems very dirty :(
Well, I like clean history. But it's OK, I can change it while merging.
It's a fair cop, but society's to blame.
I've open up #1040 for this.
change 'metric after' to 'metric, named after'
Yes, of course, that should be there.
It also made me twitch as I prefer either one line:

    ''''Docstring'''

or three-line:

    '''
    Docstring
    '''

but I'm nit-picky too :-)
@adrn - exactly my point.  And in a straw poll of a few random python users (*not* developers) I've chatted with in the last week or so, they've all assumed the same thing, which implies it will confuse a lot of people.
To link to other modules, classes, functions, etc. you just enclose the name in backticks.  For example, to refer to the `consearch.py` module, you would type:

```
`astropy.vo.conesearch`
```
Does this make `Column` never equal to a `MaskedColumn` -- and is that what we want?  Maybe it should be `isinstance(col, BaseColumn)`?  I could conceive of a case where we would want a `Column` to be equal to a `MaskedColumn` that happens to not have any elements masked out.
话说route方法如果只有index用，切只有接受url作为传参的话，url直接不要传了，里面自己new出来不是可以减少一个参数么？
See my other remark. Please keep it at ="" or ={0} (equivalent), which does the same in ~5% of the characters.
ACK, this gets removed!
Yeah, I think that too, before it was in one separated if after this one, so I'd say that it's possible to remove this check too
closing of this parenthesis goes against the coding guidelines
ah, the naming... in the xml mapping, there are no createphp internal names, only rdf type and classname. widget would still be wrong, as its not about the collection but the things the collection contains. i think something like childnames would make more sense here, to make clear it is not rdf types.
can we call the parameter typeMap instead of typMap? bit weird.
Done.

On Sun, Jun 17, 2012 at 10:01 PM, Thomas Kluyver <
reply@reply.github.com
> wrote:

> > +    result = ip.run_cell_magic('virtualenv', 'pypyEnv', 'import
> sys;print\
> > +     (sys.version)')
> > +    nt.assert_true('PyPy' in result)
> > +
> > +def test_virtualenv_python3():
> > +    if not env_exists('py3'):
> > +        raise SkipTest("Environment py3 not found, skipping test")
> > +    ip = get_ipython()
> > +    result = ip.run_cell_magic('virtualenv', 'py3', 'import sys;print \
> > +    (sys.version_info.major)')
> > +    nt.assert_equals('3\n', result)
> > +
> > +def test_virtualenv_testenv():
> > +    ip = get_ipython()
> > +    result = ip.run_cell_magic('virtualenv', 'testenv',
> 'print("hello")')
> > +    nt.assert_equals('hello\n', result)
>
> Let's make this test do something to demonstrate that it's running in the
> virtualenv - like printing `sys.path`. Then we can get rid of the redundant
> `test_virtualenv_pypy` and `test_virtualenv_python3`.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1891/files#r998914
>



-- 
Flávio Codeço Coelho
================
+55(21) 3799-5567
Professor
Escola de Matemática Aplicada
Fundação Getúlio Vargas
Praia de Botafogo, 190 sala 312
Rio de Janeiro - RJ
22250-900
Brasil
Any chance this would be useful elsewhere? If so, perhaps we can put it in the more generic testing tools directory.  But if you think it's really only specific to this test class, that's OK.
throw Throwables.propagate
No "click here" links, please ;)
any chance of not getting these?



[Velti]<http://www.velti.co.uk> David McNicholl  |  Senior System Administrator
t +44.20.7921.1307   m +44.753.422.2390
e dmcnicholl@velti.com   @VeltiMobile<http://twitter.com/VeltiMobile>
[cid:sep]
The leading global technology provider of
mobile marketing and advertising solutions

Download the Mobile White Book<http://velti.co.uk/whitepapers.html> to discover everything you need to know about mobile, and more…


________________________________
From: David Townsend [notifications@github.com]
Sent: 27 November 2012 22:24
To: mitadmin/midway
Subject: Re: [midway] Maps creation (#2)


In app/models/map.rb:

> @@ -0,0 +1,91 @@
> +class Map < ActiveRecord::Base
> +
> +  attr_accessible :grid, :team_id
> +  validates_presence_of :grid, :team_id
> +
> +  serialize :grid, JSON
> +
> +  validate :validate_fleet_size


Agreed

—
Reply to this email directly or view it on GitHub<https://github.com/mitadmin/midway/pull/2/files#r2243245>.




Velti anti-spam filter: Click here<https://www.mailcontrol.com/sr/ElwJ6Ieu9grGX2PQPOmvUnFKm77zQC2tKv4y10vzFSDZB0XAa6QhbB9n4l+7nHH+BoJrgNtNRqmqE4naC2k80A==> to report this email as spam.
Should this one be a permanent redirect? Won't that redirect be cached even after they upgrade?
webkit specific workaround? or should it be `.transform()`?
Why are the default version's not simply whatever is returned from `/products/Firefox`when no versions are provided? That's the one that still makes the most sense to me. The API is more important than the implementation.
Is there a way to use the existing Signature_Summary_Model object to reduce queries and get this information?
btw this whole "touch /tmp/..." and creates => '/tmp/...'" thing is an optimization so ```vagrant provision``` won't require waiting for a bunch of ```apt-get update``` commands to run (running provision is the way the docs suggest making your changes take effect). It uses /tmp so it'll be cleared on reboot, so updates will get done eventually.
I've seen some spam comments that have IPs. They generally point to referral boxes in order to bypass blacklists and have the form of " Get your free popular gizmo at  10.11.12.13/stealYourInfo.html today!" 

I agree that it's rare, and could cause false positives for equally rare four part version numbers. Since spammers have infinite time and patience and will discover exploitable venues, I figured we should plug it early.
Nifty hack. I'll merge this once I have a sec to try a sdist in the AM. Thanks!
Likewise - I don't think there is anything to do here
Esto no lo veo nada claro
Please use 4 spaces per level for the indentation, not tabs
the comment is wrong. It is an implementation using find
I followed the examples on http://manual.phpdoc.org/ and there is no need to separate the short description from the tags with two newlines, and it is not very clear about the case of types

but this is not really a problem
So should we hardcode the renderer engine in `initRuntime()` of `FormExtension` instead? (which, I suppose, exists to overcome this problem)
same for changelog no ?
Ok. Changed.
do we not use the importer anymore? (i guess not, or the tests would have failed)
We should probably just remove the rvm specific stuff and force an upgrade to rubybuild
While this script may work, other things might break since we removed rvm references from other places like crontab, etc
The command "/roleplay" does not work at the moment. Also, "/rp" causes some internal errors.
Ah! I see, thanks.
Now proposing:
``
            # If the factory doesn't have a crs we'll provide our own.
            if hasattr(factory, "crs"): 
                srs = factory.crs
            else:
                srs = self.projection
``
Not now, see https://github.com/benoitc/gunicorn/pull/419
DOMAIN should still be supported if the 1_0 version of the xsd is used.
Looks like the old <TAB> problem here :-D
attributes should all be explicit **private**
I have applied this change, but slightly refactored this part: instead of creating an object, I pass the original array and then reassign it after event is dispatched.
Why can't we use os.path.isabs(path)?
the `macAddress` l10n entity is already defined.
nit: ValueSelector
ok, but do we care about the localization of the string or it's enough?
Same, `#hangup`
Recents.render.bind(Recents);
Resolved, thx. Had some funky editor settings, fixed now. And the linter helps. :+1:
You touch TitleBar or some object method in changeMode but doesn't confirm that it has been inited.
You have to consider the race condition of two events here.
Intend this under the other this, seriously. I assume you do this consistently though, so how about I just make a note to look around at other code and try to match the style in the future.
The indentation seems broken
remove unused code!
I wonder if this is going to break the code of apps/system/js/applications.js that already use oninstall/onuninstall ?
AFAIK once a message handler is set Gecko will start immediately to execute the function passed as parameter. but I'm not sure. Can we check that?
Oh yeah, sure, I think everything made it into the other files.
How about a method here like:

def apply(fs : cascading.tuple.Fields) : List[Field] = {
  // Go through and get out the comparator, use Ordering.comparatorToOrdering to convert.
  // I've been trying to talk chris Wensel into adding the java Class object into Fields, if he does this, we can almost round-trip.
 // until then, make a Field with the Option[Manifest[T]] set to None.
}
actually this isn't good enough, we'll have to use the identity I guess and maybe error if there is no identity, or use a uuid.
Move magic numbers to a constant
Multi-touch zoom is on android 4 yeah, we added it in 0.4:
https://github.com/CloudMade/Leaflet/blob/master/CHANGELOG.md#notable-new-features
This can indeed be tidied up! :)
The rest are simply cleanups, but I did change the API of ``lower_triangular`` to no longer handle ``b0``.  If the user wants ``np.log(b0)`` it should be ok to simply compute it.
It's not quite clear to me what is happening here. When load or save is called, is it reading/writing to the filesystem? If so, where?
A better message might be: "rabbitmq-c does not support password protected keys"

We'll leave it as a TODO to provide the hooks necessary to support password protected keys.
semi-colons for consistency with the current code :) thanks!
Thank, good catch.  Got it.
These aren't hard requirements so I personally don't think they should be included. One big plus is that this can run just Whoosh and SQLite -- anything bigger is strictly optional.
can you remove the extra empty line here ?
It might need some styling anyway, how about continue and cancel on the same line, kinda like in setup dialogs?
Can we move this file outside root directory, for example in src/main/zanata?
Layout styles can also be divided into major and minor styles based on reuse. Major layout styles such as header and footer are traditionally styled using ID selectors but take the time to think about the elements that are common across all components of the page and use class selectors where appropriate.
Fixed locally. Will push when other issue is solved.
cane -> can
So what is aData here?
This should probably be explicitly asynchronous because right now, this callback can be triggered immediately when submitInterests is called by getCategories. You can make it async by wrapping it with a setTimeout(function() callback..

nit: spaces inside the ()s
This can more neatly be written as:

    super.merge :facts_terminus => 'yaml'
In English, you usually do not insert blanks before punctuation marks.
this can be put in a partial and added to the `:additional_content` block
as far as metadata is concerned, I think it would make sense to be able to set a metadata attribute in the session that is automatically added to any session message.  This would be a patch to IPython, I think.  One of the ways we use metadata is for notifying about the interact_id.  But that metadata should go on display_data messages, stream messages, pyout messages, etc.
umm, maybe resolve this todo?
`a caricare` -> `ad eseguire` ?
Unless you cast like that every day in which case it's indifferent.
replace with Zend\Stdlib\ArrayUtils::isHashTable or isList
Wow, you are talking about big things. You should comment this in the ML justifying the reason because the minimun PHP version should raise up to (What version fix this?)
s/Traits/closures/.
This is only a suggestion for efficiency. Declare the  fields.size() outside the loop as a variable. for all the loops
I haven't looked into this, but is there an equivalent to `git-config` in Mercurial? It would be nice to not to echo out our own `.hgrc` since there's already a more complete one in this repo! All we really need is to fill in `ui.username`... could just remind the user to fill that in at the end or something.
Could be.  I will give it a try ;)
Ok, keep it as is, I don't feel very strongly about this. But can you change it from `incompleted` to `uncompleted` ?
LOCK TABLES lasku ois tässä hyvä
use unknown_exit function
Nope, the try, except needs to stay here.
add docstring: """Support for building/installing MrBayes."""
This is what I love about moving the instructions here. Only one place to make the change. :-)
Good points, I think at one point I had other logic in there.
why did we linkify this? Either way the code should be this:
`{{ profile_url|urlize }}`

http://jinja.pocoo.org/docs/templates/?highlight=url#urlize
Dave has a point here, we should keep both tests in the test class.
Good catch on seeing this in both flavors and instances!
`they will be named` should prolly be `@frei0r@ plugins will be available and named`
we should check for deflate as well here, or simply check that content-encoding is not identity
also, I didn't use string interpolation here, because I wanted to be clear about the fact it's just adding an "s" to the end. :)
I guess not. This method is to allow the Host to remove the token before it's natural expiry (because the install is done). It's easy to add a line to this which destroys _all_ expired tokens as well, but should it do that?
isn't is `request.user.is_authenticated()`?
Oh right, of course it is. I was thinking it was a blank() from prototype.js
why not 
```
elsif @body["response"]["errors"].present?
```
I think you could escape all characters but < and >, call mapHTMLmarkup(), and then escape the < and > characters. I'm not convinced that's a net win, though, since it makes the code above more complicated and thus more fragile.
ERROR? same below
On Fri, Sep 7, 2012 at 5:21 PM, Eric D Helms <notifications@github.com>wrote:

> In stylesheets/partials/_colors.scss:
>
> > @@ -148,7 +149,7 @@ $error_lighter-color: lighten($error-color, 60%);
> >  }
> >
> >  @mixin login_background-color {
> > -  @include background(linear-gradient(top, $login_background_top-color 0%, $login_background_top-color 50%, $login_background_bottom-color 100%));
> > +  @include background($login_background_top-color);
>
> If we are switching this to a solid color, which removes the slight
> gradient that Katello is currently using upstream, then we should remove
> this mixin and the bottom-color variable above all together and instead
> just do background: $login_background-color.
>

I didn't mean to force you to drop the gradient. I was on the fence about
whether to leave it as a gradient, but since we were doing #ffffff to
#ffffff, and the change was to change both colors to the same value of
gray, it seemed silly to keep it as a gradient at all. But honestly I
didn't stop and consider the impact it would have on upstream Katello.

If you want to keep your gradient, what I wonder is -- should we just keep
the default of a "gradient" with the same start and stop, or should we find
a way to enable a solid color option? It feels a little silly to me to have
a "gradient" that's just a solid color.
Я думаю, что нам не стоить давать доступ к "sign_out" по GET запросу. Лучше оставить только DELETE.
s/corrosponding/corresponding
优化选择器性能
I think I need it to write a real one. But now that I added a fake pem file
to the test.

Thanks
On Nov 22, 2012 2:40 PM, "Devan Goodwin" <notifications@github.com> wrote:

> In src/test/java/org/candlepin/sync/ExporterTest.java:
>
> > +        KeyPair cpKeyPair = null;
> > +
> > +        try {
> > +            KeyPairGenerator generator = KeyPairGenerator.getInstance("RSA");
> > +            generator.initialize(2048);
> > +            java.security.KeyPair newPair = generator.generateKeyPair();
> > +            cpKeyPair = new KeyPair(newPair.getPrivate(), newPair.getPublic());
> > +            //create(cpKeyPair);
> > +            //c.setKeyPair(cpKeyPair);
> > +        }
> > +        catch (NoSuchAlgorithmException e) {
> > +            throw new RuntimeException(e);
> > +        }
> > +
> > +        return cpKeyPair;
> > +    }
>
> Is this as slow to run as it looks? Would it be possible to fake the
> keypair data or do we need something legit?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/candlepin/candlepin/pull/116/files#r2208134>.
>
>
Is this a new dependency? Should dimagi-utils have a requirements file? 

(doesn't need to prevent merge, since it'll only error if someone tries to use this module)
the indentation has one extra level here
otherwise, use the dir and filename as baseURL, until we find an new exception.
constы
их можно разнести, так как незаметно
это должно быть в отдельном файле с тестами.
probably we need to implement different scoring algorithm based on node's tps
oops this should have been `build test`.
remove leading empty space
find the first segment at tick == t ?