labofsahil/github-event-dataset-2012 huggingface dataset:
`deadline.timeLeft` can theoretically become negative here, and Thread.sleep boom
Wouldn't it be good enough to always sleep(step)?
I wanted if-else semantics, and that is what Switch.fold does, but I'll change it to the following to avoid confusion:

    val isTerminating = !terminating.whileOff {...}
    if (isTerminating) log.debug...
that's bad, so one must use `immutable.IndexedSeq.empty` to get the "right" `IndexedSeq`
It should of course say call these methods and not override them. Will fix.
I agree on the confusing name. What do you suggest? `DataFilter`? It's used inside `Metric`
It wouldn't be that difficult to make it generic, pluggable, and public. Then one would like to configure it per metric type.
Not sure how important it is. Adds some complexity. Create a ticket.
I don't agree that:

delivery.payloadAsArrayBytes

is better than

delivery.payload.toArray
This is copied from the old code. Should I fix it there as well?
i think this approach makes sense. If there is logic that happens when that value changes, it's a function. externally it's arbitrary but i don't see any other good options.
those things are moved over

RESOLVED
`'action' => 'index',` is default value
Ah yes - it's the latter - typo in two places
This probably isn't the place for this discussion since I'm guessing we use this all over and not just this spec, but is it really Development/Languages? I'd have figured some sort of application-related group.
hey yo!  functional javascript, i love it!  fun fact: the [compact function][compact] could be used here, in which case you don't need the second argument.

[compact]: http://underscorejs.org/#compact
This is c&p of what I had in my PoC branch ( https://github.com/pieh/android/commit/d7347d26fcea584396c744298a5aa549d889dea2 ) which was mostly c&p from other places in GUIFontManager.cpp (as it was just PoC then)

Yeah, iterators are better and cast to CGUIFontTTFBase *  ... I think it was just copied from https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/GUIFontManager.cpp#L270 (which by looking at it now is weird)

I feel bad now - 1,630 additions and 1,773 deletions in this PR and most commented code is my few lines :P
Additionally, we would need to test (for both ventures and roles) a case when there is more than one network attached to ``networks``.
shouldn't this be incremented each time you try (so each time you enter the loop) ?
Pourquoi `.txt` vu que c’est un fichier YAML (donc `.yml`) ?
If we're transitioning to a new zygote, ie current_zygote has passed canary and is ramping up workers. And now the prev_zygote has a worker exiting, will the above caused a new worker to be started even though we're going to kill it soon?

I guess if, that it's ok.
Don't you have the same problem here, that the pinch gesture breaks the ability to pan with two fingers?
I'd actually want both osInfo and hasContentEditable to be declared in a static hash since they don't have anything to do with an individual instance of enyo.RichText but instead are kind-related values/methods.  This reduces the memory overhead of each copy of enyo.RichText.
Whoops, you pushed a commit that added code and therefore GH placed my comment on the wrong piece of code. I'll move my comment.
Shouldn't this be `TUIScrollView`?
My bad. This was already fixed in master but I never back-ported the patch. Fixed (in v0.6) in 3f42612.
Is there a reason not to use RAII here?
Forgot to remove attr("dx") here?
yup, ca met bootstrap
Doesn't follow our code formatting guide lines
Use GeoExt.VectorLegend to create this field instead - it works for both images and point symbols.
added CHANNEL_BRIDGE
Oh no - it's a spare comma!
I do believe they are.
Here you're missing the usecase special treatment. Say you have:
```
trait T { def foo(implicit i: Int): Int }
class C extends T { 
  /** @usecase def foo: Int */
  def foo(implicit i: Int): Int = 3 
}
```
The inDefinitionTemplates for the usecase must be the same as the ones for the member, but this is not true for usecase symbols -- so we have to special case that.
Here are some less value-class-specific ones: https://github.com/paulp/scala/blob/value-class-extractors/src/reflect/scala/reflect/internal/Definitions.scala#L1122
@paulp Could you please comment?
it is comment to leave `XXX` next to warnings like this one. Most editor highlight them (if they are in comments, not in docstrings)
added spaces around ==, removed spaces here.
Ok, I just wanted to avoid clashes with automagic getters.

LastModified may be supplied through an expression. Anway, I'm fine with that. Probably increases coding readability as well.
This could probably use `is` instead of `==`
Affermative :smile:
All links submitted within tweets and direct messages, regardless of length, will eventually be wrapped with t.co
Это тоже посмотреть на тему убрать
Nice. Can you add one more check that is valid if the password and the confirmation match?
Do we need to worry about timezones in these calculations?
optimize your location data with another field? 

optimize the query? 

I think something along the lines of: 

     that allows MongoDB to optimize the query process for location queries, given a coordinate and another field in your documents.
captures data regarding all database operations.
line breaks in between prgram (i.e. `mongod`) and option (i.e. `--journalCommitInterval`)

explain tradeoffs?
- also :setting:`diaglog`
Ah hah, yeah: Submitting this injected form will fail with a 403 Forbidden, because it doesn't have a hidden field with a valid CSRF token. If you view source on just about any form on the site, you'll see this magically added as a hidden field:

        <input id="csrfmiddlewaretoken" name="csrfmiddlewaretoken" value="91d4d05e95018bbe0d4adb2bdabad7d5" type="hidden">

So, our solution in the past has been to generate any forms in need of dynamic injection (eg. BrowserID) as a fragment on the server side and fetch the HTML via AJAX. That way, the site-wide middleware has a chance to inject the hidden field with the token
Why 3.0.x? just makes this a problem again with merging into 3.1.
Probably also want to check whether the cache dir actually exists.
Multiple lines please. Also needs a comment explaining what is checked, since this is non-trivial.
This should be in an external file.
I'm pretty sure we do not support DELETE and LIMIT in the same query. :-/
I'm going with what was explained http://stackoverflow.com/a/6937030/996876 as I said in the comment. 401 is for unauthenticated users attempting to access something that requires authentication. 403 is for authenticated users trying to access something they don't have permission for.
If we don't want this much separation between errors, then I can remove this, but IMO it's better to use the right HTTP status lines in the right scenarios.
This should tell whether or not the current PHP version is compatible with the MOD. In other words, if it is not compatible, say so.
Plurals need to be done via the 3.1 plural system.
MD? you should use EXT as a prefix everywhere, or MOD, but not invent a third shortcut for the same thing.
can resp be nil?
why not use brackets?  request.session[PREFIX+user.username] = datetime.now()?
Its core+arb for current version f opengl, I am not even sure how to use it properly:
 * It is not possible to #include both <GL/glcorearb.h> and either of
 * <GL/gl.h> or <GL/glext.h> in the same source file.
 I guess better to stick to classic gl.h + glext.h headers for now.
updated the PR with camelize, otherwise:

for rchavik/sites, it will try to activate "Site" plugin.

not sure how the best way to do this via composer.json without any inflection.
Shouldn't the "core_action_start" and "core_action_end" marks be a timeline instead?
This will not work with all hosters, because there is no call to .listen(). A lot of hosters expect you to call listen by yourself. Not calling listen() is the main reason why Mojito doesn't deploy out of the box on hosters and why I submitted pull request #267.
Why do we need to attempt the three extensions?  Can't we just use `libpath.extname(filePath)`?
good point, I will generalize that.
Лучше эту инфу вынести в отдельную таблицу. В талице с баннерами информация, которая может редактироваться в веб интерфейсе и общую статистику лучше туда не примешивать.

Да, лучше каждый раз суммировать. Нодой писать в 2 разных места или писать а потом преобразовывать не очень приятное занятие. при этом можно же не все суммировать, а складывать инфу за предыдущие дни(которая как раз и хранится в этой отдельной таблице) с инфой за текущий день, это будет достаточно быстро. Так же делать на просмотре в веб интерфейсе.
state[id] is going to be truthy on every iteration. Hence calling write too many times.
change this location to <location_path environment_variable="steamuserdata" path="115110"/>
This line contains a TODO. Something that should be resolved before pulled in?
Ideally functions like these would be abstracted out to a Util class...would it make sense to include our Util class when we deploy? So you can just call Util.getPatientIdentifier for shared functions?
Hi Leif - to keep our code uniform and clean, can you please run through jsbeautifier.org to ensure correct spacing? 
Also, add the handler function to the Controller (Session.js) instead of here in the view to follow MVC pattern, and make another commit/update this pull request.
Otherwise looks good. Thanks!
Do a search on 'PatientList' and change all relevant comments, so our javadocs will reference the right object
spaces in default args
这行太长。
Get it. Thanks.
Laugh all you like, but propose a way to continue deploying other hosts when one of the plugins (in this case the reboot plugin) fails for one of the hosts.
You had fun, now back to work. If you don't have a solution, put that laughter back into your throats.
A good class-overview comment would go a lot further than method/constructor doc comments here.
I would much rather see this changed to mark agents as "alive" in the new paradigm than see this removed.
I think this should be private.
extra "the" (also in next line)
Feel free to do that, but it's a stronger implementation that I had proposed (or tested).
Is this a regex because of backgroundPositionX and backgroundPositionY? Is that value still work for those? Also, can you move the regex out to it's own variable at the top of the file with the other regex's so it can get cached?
I could see not caching useless results, but supporting `.show` etc. in a hidden body is a bit much, especially for this cost in size and computation.
For now, module stats is deactivated on GP4.0.
I think the event should be triggered after the actual change, and not before. Just move this to after the `if` statement.
Yes it makes sense. I found the django method that parses it and I'm using it now, I think it safer.
Please keep the imports in alphabetical order.  (Unless you've already done that in your cleanup branch.)
This could be a docstring too
if multiple differently-prefixed versions of the same property are used in the same rule, this code will break - whichever one comes last will just overwrite the previous ones. That's a major problem. I think the structure of the return value of this method needs to be rethought.
It's not an objectionable goal. But this is *your* software. Why can't *you* carry this patch?

If you aren't actually interested in supporting OS X properly, then why did you submit the formula in the first place?

Homebrew is not Debian. We have real objections to carrying patches that can easily be incorporated upstream.
Thanks. I'll add a note in the commit message.
esentially yes, but we are also trying to exclude sending through ' data-path="//"' (coming when path == '/') or ' data-path="/"' (when path is '') as this will screw the file creation.
These three options are fairly redundant throughout the command file.  Recommend replacing them with a cart_options protected method on the cartridge class that takes the string description for the namespace and app, and handles the rest automatically.  This will significantly increase readability.
There'S a misconception: the login filter allows to login with one or more defined attributes (e.g. email). The ownCloud user name however is created on the basis of the user display name (e.g. displayname). I.e. the $uid provided by checkPassword() is very much likely to be different to that from username2dn().
Ah ca c'est pas moi :p
This could be outside func.
Can you assert that the data store is empty before the sandboxed code runs? I've been bitten by improper cleanup masking problems in the past.
Можно я продолжу придираться? :)
- по картинке 3-13 ветка, которую мы слили, указывала на коммит C4, и этот коммит не является родителем коммита C2 (является потомком).
- что такое «прямой» родитель (потомок) коммита и какие ещё бывают родители (потомки) у коммитов? Если считать прямым родителем (потомком) непосредственно предшествующий (последующий) коммит (соседняя вершина ориентированного графа), то утверждение может ввести в заблуждение, поскольку совершенно не обязательно быть соседним узлом графа, можно быть пра-пра-родителем (пра-пра-потомком).
- разве можно говорить о слиянии коммитов? В оригинале, справедливости ради, тоже так, но на мой взгляд, это ошибка. Сливать можно только ветки. Ещё хуже фраза о слиянии коммитов звучит оттого, что заканчивается неожиданным перемещением указателя. Я, будучи к этому моменту знакомым с git, конечно, понял, что к чему, и, быть может, преувеличиваю, но новичок может получить здесь порцию противоречивой информации (при слиянии коммитов указатель одного из коммитов может сдвинуться).
- между «достигнуть» и «проследовав» пропущена запятая. Вообще много запятых. Мало того, что мысль сама по себе нетривиальная, так она ещё и выражена громоздкой языковой конструкцией.

Как насчёт такого (добавил названия веток, полагая, что картинка 3-13 будет перед глазами):
> Так как мы слили master с веткой hotfix, указывающей на потомка текущего коммита, Git просто сдвинул указатель ветки master на этого потомка. Иными словами, когда вы сливаете свою ветку с другой такой, что текущий коммит является частью её истории, Git просто перемещает указатель вашей ветки вперёд, так как нет расходящихся изменений, которые нужно было бы сливать воедино.
Тут имелось в виду тестирование исправления. Но в принципе можно оставить только "после тестирования" без "её" или "его".
So you are saying workers and iframes have the same vars?
I think I would prefer two contracts for these:

    @minitems 1
    @minrequests 2
Does the Meetup API let you grab location information for the event? If the `next_event` includes hack nights at Monk or something like January's night at Tiger Tiger, we don't want it to say the location is UCSD.
Here is the exact code that WP uses: https://github.com/WordPress/WordPress/blob/3.5/wp-load.php#L26-36
stutter...
@dsaff 
I can do it now, but then you have two paradigms in one: a factory and typical object creation.
I would actually like to remove any tags that only give information that could be read directly from the code.
I originally had it in options#withPayload(), but it wouldn't have solved the case that we ran into earlier where a PUT with no payload was being rejected by nginx.

As for the unit tests, it looks like there is no easy way to assert that something has been put into the request headers (only the response helpers have an easy way to test). 

Is the right thing to do to add an accessor to help test request headers?
rename destinationNode to containerNode (or somesuch)
Bool is useless here...do a Spout.getPlatform check
I doubt you'll need this, since you shouldn't need to test the dom.
It would be mode JavaScripty to do something like:

suite = getParamMap().suite
           || localStorage.getItem("SpecRunner.suite")
           || "UnitTestSuite";
same as above. remove quotes from attributes
Where is the value of @jstree-sprite-size defined in the jsTree code? I can't find it.

I don't think that LESS variable values cascade, so it would be safest to re-define it in the jsTree code.
Done. Each test has it's own context menu.
This logic can be simplified:

```
        if (_inSession(editor)) {
            _updateHintList();
        } else {
            if (lastChar) {
                _beginSession(editor);
            }
        }
```
This is a serious problem because with this we cannot run cloud9 without the npm-runtime plugin. However e.g. for ftp projects we don't load it.
I added another commit to simplify this
Why does this recieve a PropertyForm? The get has no previous data to fill in. It'd make more sense to create a new one from the property with a special constructor.
Yeah, the suggested impl, and the one I just pushed, is more clear
the multi_typeahead should get bundled with bootstrap js...
If you perform a 
obj instanceof TocTreeNodeLayer
you know that it is not null and that it has the required type. It's faster and easier to understand. And you can perform your cast safely.
Done (just below here).
35 or 50? :P
Yesssss. It's horribly documented. Short version: don't use `mediachanged`. Long version: something about there once being the ability to have multiple `Media` objects inside of butter (hence the persistence of `butter.currentMedia` instead of just something like `butter.media`). This event was going to be fired when the value of `currentMedia` actually changed, which it never does anymore.
I'd just revert all the changes made to this file; it's only used by the test template, which we don't care about anymore.
Why this change?  Functions are better for memory.
definitely wrong
should we use baseDir in the path as we do in the editors?
Again, no Idea if the strings are required here or not.
so, let's use that check and remove the length check.

The reason this all passes when things are invalid is because you use element for two things.  If you make element start undefined, then you only set it from document.getElementById, it'll either be null or a valid element, then you can catch it in the check.
= array();
This error could be misleading. We should be saying something about not having permissions rather than commenting on logins.
Fixed on e0462b2.
Don't we want it to return a set of all interesting, forked, and starred repos?
Will update routes.
@Pajk What was the reason for this change? At least, it would deserver to be in a separate commit with the explanation why because it clearly doesn't relate to the Exceptions problem at all.
I dont like this approach, why you disable orchestration here and creating some magical steps? For candlepin and pulp we trigger orchestration during seed step, and I would expect the same for Foreman. This is NACK from my side at this point. Please explain.

@ehelms it also explains your question I guess
[Sounds like testing is tough](http://en.wikipedia.org/wiki/Weakly_interacting_massive_particles#Experimental_detection), but I'm sure someone will figure it out one of these days.
considering using a class for all colour pickers  


func at line 20 and 25 are just cut n paste. (need indenting too)
A clearer way of saying this would be: "Picard MarkDuplicates file {} only needed for metrics. It has been removed to save space".format(dup_bam)
How long as this been a problem? If this is a regression then something else changed that made it so. Do we know what that is? Maybe this? https://github.com/SignalR/SignalR/commit/48dc5a2cb78881075018c89786ee7674854ea826#L1L375
If the sleep menu is showing, It will pop out sleep menu twice when user click power key.
So, I need to check the flag before set timeout again.
And reset the value null when clear timeout.
Is this a proposed addition to the apps manifest format?

I like it and I always assumed this would be added, but there's no mention of it here https://developer.mozilla.org/en/Apps/Manifest or here https://people.mozilla.com/~anarayanan/webapps.html#app-manifest

Does this need submitting to the webapps mailing list? It's similar to the current "required_features" proposal and I'm personally not convinced we need both, I actually prefer "permissions".
nit: evt -> evt to stay consistent
If `rawdict.txt` is converted or taken from the `PinyinIME` repo, you should delete the file from here.
I'm not clear on why this restriction is needed at all.  Maybe using `ndarray.flat` allows n-dimensional arrays to be transparently treated as 1D arrays, for example.
After closer reading I see now that part of what you're doing here is delaying the import until that dependency is actually used.
That said I still don't think it's a great idea--some startup overhead when first importing a module is expected.  But if you call a function that uses scipy for the first time, the overhead attached to importing scipy might not be expected at that point.
Agreed :). Thanks for your valuable suggestions.
Please use trigger_error() instead of an alias.
We can move this edit_close_date modal html into it's own partial.
I won't have time to review this today (at least not before the evening), so I thought I'd send at least a "message received" message :-)

skimming over the changes, I kind of wondered if there is a reason why we don't initialize the array here, i.e. $rev = array();, but like i said, any serious comments will be tonight or tomorrow.
strings.Fields(sentence)
Maybe this shouldn't search the whole string.
I'll have to look at the context more, but if feels like this class shouldn't know about temp files (and/or when it's safe to close/delete them).
I think you almost had it better without the multiple calls to ```@files_to_pack```. I'm assuming you changed it so you didn't hit ```Dir.entries``` multuiple times? You can just memoize it:
```ruby
def files_to_pack
  @files_to_pack ||= (Dir.entries(@path) - ['.', '..'] - @exclude).map do |file|
    ...
end
```

And reference it with ```files_to_pack``` (like you had before)
I will even do the work if others approve.

On Thu, May 31, 2012 at 8:19 PM, Brian Granger <ellisonbg@gmail.com> wrote:
> OK, I buy that argument, can we change the rest of them to this format then?
>
> On Thu, May 31, 2012 at 8:18 PM, Min RK
> <reply@reply.github.com>
> wrote:
>>> @@ -86,6 +86,15 @@
>>
>> I'd rather not, I think forcing lower-case and no spaces on what are essentially GUI documents is terribly ugly.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/ipython/ipython/pull/1822/files#r912781
>
>
>
> --
> Brian E. Granger
> Cal Poly State University, San Luis Obispo
> bgranger@calpoly.edu and ellisonbg@gmail.com



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
@nicholasruunu and @CoolGoose Changed it :)
I realize this would break the current API, but I'd prefer if the parameters were swapped here. This would also make it more consistent with the `string()` helper. (There are spaces missing after the commas by the way.)

Also, when creating an incrementor column, people probably use the above helper function anyway, so this parameter won't ever be used in an API call.
Yep.

On Oct 23, 2012, at 4:02 PM, nulltoken <notifications@github.com> wrote:

> In src/reset.c:
> 
> > @@ -88,6 +90,11 @@ int git_reset(
> >  		goto cleanup;
> >  	}
> >  
> > +	if (reset_type == GIT_RESET_SOFT && (git_repository_state(repo) == GIT_REPOSITORY_STATE_MERGE)) {
> How about introducing a new GIT_EUNMERGED error code and return it here?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Why the generalization? Can't we retain a declarative type?
I thought the features page was in bedrock?
I know this is not part of this bug but could you take the opportunity to move the `^privacy` part of the regexp in the root `urls.py` file?
Rather than modifying the DOM on every scroll event, I think a cheaper algorithm is to toggle `position: fixed` when appropriate.
`for year, phases in grant.break_down.items()` will be more readable.
Oh, and we keep imports in alphabetical order. Sorry for the OCD :-)
Probably want to change this to:

    # Topics filter
Well that's for the persisted object. What I want to see is how frame looks like. Is it imported correclty when referenced in the global scope?
No need for brackets. Also please don't use a new line but put it right after the opening bracket from `ok`. Adjust the message accordingly.
Can that be `raise ResourceUnavailable(params.uuid)` for better error messages?
版本号只能增加，不能变小啊。
Yes, I am aware of the issue re: #define and preprocessor clashes, and that is explained in the Code Formatting Convention i.e. "As a side remark, we recommend avoiding #define for creating constants, because these can lead to weird and difficult to track down conflicts. Instead use enums or the const keyword."

My question was that we seem to be using enum in some cases, where the values are not part of a real enumerated type i.e. https://en.wikipedia.org/wiki/Enumerated_type.

To be clear, this shouldn't (as you have indicated) result in any difference in the object code, but it does make for some confusion on reading the code.

For an example, I mean say:
enum {
Should the stop method documentation be updated to the same format? I just used what they had.
Just a simple question. Isn't better to move the preg_split to a temp var, instead of use inside the foreach?
It would be more scala idiomatic to use the apply() method
.codec(Http())

Like here:
https://github.com/twitter/finagle/blob/master/finagle-example/src/main/scala/com/twitter/finagle/example/http/HttpServer.scala#L78
I think this would be clearer if it were split into more states. Right now there seems to be a lot of mutually exclusive configurations of `PacketDefragger`. Here's a suggestion based on my very primitive understanding of the protocol: depending on the type of the result set, there may be one or two set of packets that are to be decoded. First simplification: I think the `Option` in the sets are redundant. It's only None whenever there is no data, so use Nil instead to represent this state? Second it seems that you expect a number of packet sets; 0, 1, or 2, and that their order, but not their position is relevant (this understanding may not be accurate). So it seems that what you really want to arrive at is a Seq[Seq[Packet]]

```scala
case class Defragging(
  expected: Int,
  packets: Seq[Seq[Packet]]
)
```

Then your transitions look like

  Defragging(2, Nil)

after EOF for the first set

  Defragging(1, Seq(Seq(first, set, of, packets)))

...

does that make sense? My intuition is that this approach would simplify greatly.
heh, i still get notifications for this pull request. :) This won't cause stack recursion since loop is called again within the lambda passed to future.flatMap.
Since you have a `group` variable, why not use it's attributes? Ex: 12345 -> `group.yammer_group_id`
I might be missing something, but where do you need the value returned? If you have the instance variable, you can use it anywhere in this class.
```css
    fixed : top left right bottom
```
oh oh
kharab shod
too h1 p nazar dige
class slideshow ham ezafiye
az artivle ham mishe estefade kard
masalan
```html
<article style="background-image: url('...')">
	<h1>Title</h1>
	<p>Desc</p>
</article>
```
Is that ```docs/source/mataplotlib/introductory_examples```?
We don't use `&rsquo;` anywhere else; should probably just use a regular quote.
The field label should be moved into the tpl file as that would make overriding/removing it easier in sub-themes.
sure remove the migrations...
Perhaps somewhere around here mention that if the currentState doesn't have a transition named as so it will search up the ancestor tree until it finds one?
I'd have to pass the context to all the chain of methods to resolve at this point.

Would it be possible at runtime stage (in performRuntime), to call once and for all:

    ModelNode model = context.resolveExpressions(fullModel);

and pass the resolved `model`.

This way, all the expressions of the models would be resolved, no?
Fair call. I will remove it.
Any reason to narrow the argument here to embed.Config as opposed to RackConfig? Is there logic in embed.Config that means that only it should be paired with embed.Context?
Why did you remove the 1.8.7 guard? These guards mean this version and up, so they also execute for 1.9. The version guard has this value because this was added in 1.8.7.
Probably is due the dependencies in "deps.js", but if you try to delete this call you will receive some errors in 'phonemetadata.pb.js' and 'asyoutypeformatter.js'
Nit: s/upload/uploads/.  Since busybox is good for more than just the fastpath in install-gaia, maybe change the whole comment to something like:

> This shell script installs busybox on the device.  This lets us take the fast path in install-gaia.py.

Also, please rename this script to otoro-install-busybox.sh, or something.
nit: There is a few places in the codebase that use 'ret' instead of 'out'.
What does this property set do?  It's not obvious.
Thanks for the advice. The querySelectorAll doesn't work with the this._pickerUnites, i use this.element instead.
About "unable", I think it is unavailable as well but the documentation says “Service currently unable” so I followed that.. will  change it than.
yep. Nonetheless I need to have a chat with you just to clarify indentation and line length on HTML files. thanks
yep... at least we have a bug number...
if (evt.target.dataset.frameOrigin == this.currentOrigin)
      return;

save an indent
base_OLD.html? does that mean you can delete it?
how does this work? i understand the key is only added when `maintain_reverse` is set, but why must the existing key be false-ish (`0`, `''`, `False`..)?
@filipewl, removing this style affects the layout.
If there's no alternate method to use, you can pass `nil`:

``` ruby
RSpec.deprecate("RSpec::Core::Formatters::BaseTextFormatter#magenta", nil, "3.0")
```
argh, you're right, that's one of the differences between this version and ours -- i'll fix.
直した :grey_exclamation:
I used this `kill(0, pid)` trick but I'm wondering if there's a better solution. I guess I'm concerned it might be expensive, but it doesn't really look that way.

/cc @rtomayko @scottjg
it's a asynchronous for() loop ;)
For messages, either make a function to have a consistent `"[&nbsp;#{message_here}&nbps;]"` or set the textContent and put braces with pseudo-elements.
Applying Murphy's Law here would turn your question into "Are you sure it won't?"
Should this be "if codebase is not None"? We tend to use '' as a default codebase .. I'm not real familiar with this code but just wanted to ask if this really should be "is not None"...
maybe put this in utils?
Please do, I probably didn't clean up that part yet as my branch wasn't succeeding. Or it's a bad merge (they were changed to RuntimeException some time ago)
These are all defined in `director.Router` which is applied below.
Excellent question eagle-eyed Hamann. It's empty, but it has padding. 

It has `js-visible`, but there is the case when even though the client has js, we don't want to show it, i.e when the `switch` is off. In that instance, we were getting an empty space are due to the padding
There has already been a listener for a couple of weeks now: https://github.com/guardian/frontend/blob/master/common/app/assets/javascripts/bootstraps/common.js#L51
Plz fix :)
Comments missing. What do the return codes mean?
`if (!uri)` sounds good
Search and replace *all* colorized instances
Yes, I just need to learn how to do it in express :)
It's probably not a good idea to put all these assertions into one test. These should be broken up at least into different groups, but preferably each fact should have it's own test.
As above: it adds ability to use an interactive debugger within the method.
broken indentation here, otherwise it looks good ( just why you change log level? internal is obviously wrong, but info could be fine here )
so, what the job of the function : 
 
     public function call($method, $params = array()) 
     {}

if "not needed" ? that function is not effect if we remove ;). sorry for my english.
Remove commented out code if we're not using it.
Maybe reset entirely via `$this->pendingAbstractFactoryRequests = array()`
> I'd argue that the FirePhp log writer shouldn't support a formatter at all, as it simply intends to pass the message verbatim and disregards all other event data fields except priority, which is handled separately in the writer.

It is possible to have a formatter that handles tables or include extra information. "To pass the message verbatim" is only a legacy behavior.

> Much like the DB or Mongo writer, it seems there's nothing to format.

Do you have test some writers like Db and ZendMonitor with your BC? I find it curious that the writer Db is not part of changed files.
I was just keeping with what's already there - the $_defaultViewPartial was above it!
I think this is not ```paragraph_view``` any more, it is ```block_view``` (see configure.zcml)..
no space between brakets
If these directives are encountered in RSRC_CONF, it applies to the "/" location correct?
I do not know exactly what you are asking for, do you mean "oc.tc" should be a variable instead?
This would mean the attached count was never incremented.

Fix that instead?
I am good with the first point about not have the constructor (I think I misinterpreted one of your previous feedbacks) I however don't agree with the opinion that the Resource constructor should use the decoder.  In my mind, that encoder/decoder is specific designed to be used with the backend service use to get and save data.

Lets just say I am using some third party crazy api that returns data like this:

{"response": {"data": {"object": {"id": 123, "username": "test", "password": "user"}}}}

Now with the way the constructor stands, to create a new user in JavaScript, all I have to do it:

var user = new User({"id": 124, "username": "test2", "password": "user2})

If the constructor is assume to use the decoder, then it looks like this:

var user = new User({"response": {"data": {"object": {"id": 124, "username": "test2", "password": "user2}}}})

Now while it is true you could have the decoder account of this but in my opinion you are starting to muck up your standard JavaScript code because of a poorly designed REST API.
@anti t-funkkarit ja $browkielet kuntoon!
@samiluukkonen Huomasitko tän if ($lasrow["vienti"] == 'E') {?
i'm generally not a huge fan of this type of 'magic' in API's and prefer them to be explicit unless totally necessary (in this case don't have enough context to evaluate).
Please read the link I gave to the spec (in another comment on a switch/case): **nothing** talks about empty lines in such places, and the section dedicated to empty lines says you MAY add empty lines for readability. So I don't see why it should be forbidden in this particular place.
If PHPCS gives you an error for it, it is a bug in PHPCS.
Which would suggest that we can just remove Symfony. If i read this correctly
i think you need to add this method to the MappingException class
You don't need these in every environment (for example you don't need them in production) you should limit these to development and maybe test.
Oh, n/m, non-greedy. Told you I'm drug-addled. :)
Hej chcelo. Komentar necham, nemusi byt hned vidno co to robi a hadam nezavadzia;).
V tomto suhlasim s Tomim. Nuti to cloveka, aby daval pribuzne triedy do rovnakeho suboru...
I wonder what you had to do to get an Ñ in your keyboard. ;) 

Fixed. Thanks.
Two spaces before inline comments :-)
change '2' to 'multiple', I don't think this limits it to just too, you can have dozens if you want to.
Nevermind, I thought only about SSE…
This didn't work for you? Crud. Maybe I messed up the syntax? 

I'm pretty sure the "kumascript" branch of my fork of pegjs is needed to make it installable via NPM from github. I don't think the master branch will work.

Kumascript also needs this recent, unreleased commit of pegjs because it provides more context for error messages. Will be interesting to see if tests pass without the "kumascript" branch installed
So if I understand it, this whole function could be simplified to.

```
def compare_permissions(mine, your):
    if mine == 'PB' and yours == 'VO':
        return False
    return True 
````
Well I didn't just duplicate (all) their code, so still there a point into using their library, but I see your point ;) I just didn't think using `super` in the first place and I don't know why. I'll go ahead and rewrite it.

BTW I'm aware of `max_limit`  (https://github.com/mozilla/mozillians/blob/master/apps/api/paginator.py#L14) and I'll wait for tastypie to become stable before using it.
There's no real reason for this to be a `trans` block instead of just `{{ _('Group: {name}')|f(name=group.name) }}`.
This is specific for you account details.
We need to modify this so that no matter what account we use the page and test are valid.
Could you swap argument order here and in `add`? That would be more logical.
these examples should include host/port keys, no?  you'r going to have to configure sfx db wtih host/port, so AR can find it, yes?
@ohadlevy, I fixed this in a commit at the bottom.  How could this commit and diff appear inline in our discussion?
If you want to code this way, this should just be

```javascript
editors.push(creator)
```

but see above.
> Just remembered that `Math` should be in scope here so you can just do `abs(M) !== 1`.

The other tests on this line say Math.x, so I'm happy to keep it like
that.  (I like explicit package names in any case.)

It looks like you committed the fix that I pushed (to use abs()),
which was hopefully intentional! :-)

craig
It can be done with it, but I dont think this would be better. KISS - Keep it short and simple
What about the case where less than 'limit' results are returned? This will throw a KeyError.
I had missed that one. Removed now.
This doesn't cover clearing object's template cache in the subtree. see eZContentCacheManager::expireTemplateBlockCacheIfNeeded( $objectID )....
It's an arbitrary size value to ensure we can handle memory_limit fatal error.
эту функцию точно всем надо видеть?
Обычно unaryFunc содержит ссылку на массив, который хотелось бы менять при просмотре вершин. 
Если передавать по значению, то изменения не сохраняться.
The client works with its own access token, which is created and stored when you run: 
```
mp_client = MercadoPago::Client.new(client_id, client_secret)
```

It shouldn't be necessary to pass the access_token as an argument for any client method.

In latest version, all client methods doesn't receive the access_token as an argument.
The following confusing diffs are just a small refactoring of posFromMouse(), separating out the code that figures out where the clientX/Y coordinates of an event are relative to the lineSpace. I needed this for the gutter click detection code in onMouseDown().
Huge thanks for all you help on this!   Could you consolidate this list of contributions into a line or two?  Now that we're using github, we can probably keep most of these change comments in the commit message.  OR feel free to start a changelog file in the format of your choosing.
can we move this to a region file and maybe make it a little more general :D
Hmm, never heard of this CSS rule. neat!
should probably be named  ```STABILIZATION_ATTITUDE_SP_MAX_DELTA_PSI``` or something like that
We prefer to arrange imports into three blocks. First is stuff from the standard library, second is external libraries, third is stuff from this project:
```python
import re

import yaml
from twisted.internet import defer

from diamondash import mything
```
This just makes it a little clearer where the various things come from.
Maybe mention console output because imo it's not clear where that useful info will appear.
Is the contentObj still returned here? If so, it should be Content.
I think there is an issue with indentation in this method.
maybe this should be renamed to ``scalaPackageStrategy``? (I can't find a better name :( )
memo to myself: to avoid having this modifying actual content, it should at least match the image tag as well. The tag would be HTML encoded for actual content, so it should be safe to preg_replace it.
i want to refactor this anyways, but one thing after the other: the mappers should enhance the parameters in general. that we call something controller is just a convention of symfony, the router should not even check this at all. symfony itself will notice the problem later in the process.
Lolz. Fail.
this stops the click from falling through to the list item, which has a click handler showing the detail page. comment should be more clear yes :D
This it's ok now, it was a mistake on my composer.json... 

I confirm that only `zendframework/zend-http` is required.
Space after `(array)`.

Generally the rule is - put spaces around all keywords.
а еще можно arc4random_uniform([dict count])
Мне так читабельней.
Я к ней не приходил. Жаль что @wwhatisit  уже удалил свой репозиторий с проектом я её взял оттуда. Это часть его решения. Вот мы тут и захоливарили на пустом месте и флуд развели.
Нет, но можете попробовать сами запустить вот такой кусок кода у себя:
```objective-c
NSMutableSet *set = [[NSMutableSet alloc] init];
NSNumber *n1 = [NSNumber numberWithInt:1];
NSNumber *n2 = [NSNumber numberWithInt:1];
[set addObject:n1];
[set addObject:n2];
        
NSLog(@"Size of SET: %ld", [set count]);
NSLog(@"SET: %@", set);
```
Рузультат:
```
2012-11-05 16:34:09.801 Project1-DNA[32686:303] Size of SET: 1
2012-11-05 16:34:09.804 Project1-DNA[32686:303] SET: {(
    1
)}
```
@slebedev опять error
пример не из той области
I prefer `talisman != NULL` over `(talisman)`
It looks like you removed the ERR_NOT_FILE condition. The `unlink()` function needs to return ERR_NOT_FILE if passed a directory. You can run the  LowLevelFileIO unit tests in Brackets to verify this functionality.
Ahh yes, good point!
I think it'd be more conventional to name this `tryToExecute:` (or something similar), like [tryToPerform:with:](https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSResponder_Class/Reference/Reference.html#//apple_ref/occ/instm/NSResponder/tryToPerform:with:) or [tryLock](https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSLock_Class/Reference/Reference.html#//apple_ref/occ/instm/NSLock/tryLock).
I think so, but to fix this I will need to revisit all getNumRows calls and this is out of my possibilities, now.
File.new actually opens the file for reading. Better to use ```Pathname.new``` here to avoid leaking file descriptors.
`.toggleClass()`
What's the point of this edit ?
there was no way to do it with matplotlib? Just to see if we can avoid a new dependency just for this.
2) Would actually be more complicated. Perhaps you'd pass in a list of labels, and a sparse (or dense) matrix of "weights" between nodes, and (optionally) an order.
move this line to the parameter definition section L457, You can then use n_dipoles in L465
hum. People here use this and I understand why after looking at the full length of a  QRS heart beat on the ECG channels. might be worth asking the mne mailing list what people think.
I think this would be written as: 
```
PLV = |E[exp(j∠Sxy)]|
```
And PLV and PPC could both reference:

http://www.ncbi.nlm.nih.gov/pubmed/20114076

Again, I'm happy to add these later if you'd rather get this merged.
I have cleaned up this
I think this line is wrong. startTime is > 1300000000 and Config.TP_DURATION_IN_MILLI <= 20000
Change to `(mk-qualified-path str-or-path (filesystem))`
The messages should be updated (for string / collection)
<literal>ngx_http_referer_module</literal>模块允许您根据请求头里<header>Referer</header>字段的值作出相应行为，
如果该字段里的包含不合法的值，则阻止该请求访问站点。
=>
       <literal>ngx_http_referer_module</literal>模块允许拦截含有非法<header>Referer</header>请求头的请求。
Nil is the empty List, None is the "empty" Option
That's not right, `X509_STORE_add_cert()` takes ownership of the certificate.
Use macro stringification here:

```c
versions->Set(String::NewSymbol("http_parser"),
              String::New(NODE_STRINGIFY(HTTP_PARSER_VERSION_MAJOR) "." NODE_STRINGIFY(HTTP_PARSER_VERSION_MINOR)));
```
I'm not sure what you would google, it's more of a flexibility thing. Often, one can change the representation in a bit of data to something slightly more suited to how the algorithm uses it, and this speeds things up. Another big one is being able lock down choices outside of inner loops (in compilers they call this "code motion", but this applies to the design as well).

A book I read as a teenager, which greatly influenced my perspective on software performance, and which holds up surprisingly well considering it's about 486 and Pentiums, is Michael Abrash's Zen of Code Optiization (http://www.amazon.com/Zen-Code-Optimization-Ultimate-Software/dp/1883577039). This book talks a lot about counting cycles and low level tricks, but the take home message is that switching to the right algorithm will give a much bigger performance boost than micro-tweaking  the wrong algorithm. Micro-tweaking the right algorithm once that is firmly established is how you then proceed to make the code fly, though.
И здесь не забудь обработку.
`:null => false` on these?
please remove remove extralines
Please fix indentation in the whole file
This isn't a bit flag, that should be 3, not 4.
Even the old mapsforge library supported map files...
Of course it is questionable if we want to implement this, as we will phase out mapsforge 0.2.4 sooner or later
Agreed, this can be the heuristic:

No host specified --- pick a random gridcentric host.
A host specified -- boot on that host whether gridcentric or not.

That way it's generally useful as a tool for randomly creating Gridcentric VMs as well as debugging by booting on specific hosts.
Right, it was some carry-over cruft
Don't we have a race condition here? I.e. end up having this code executed by two threads at the same time for the same cache, resulting in newTopoloyId having the same value even thought the list of members might be different
Right, this piece of code originates in the old state transfer code and the "locking not necessary as during rehashing we block all transactions" comment was preserved since then. We can remove the comment now.
Hmmm, I'm not sure the name is very descriptive of what this interceptor really does. 

From what I understand, it's trying to block or allow operations based on the state transfer status and whether the op requires it. 

A better name is needed IMO (Maybe a StateTransferFirewallInterceptor or something similar? More ideas welcome)
Sure. I fixed it in https://github.com/libgit2/libgit2/pull/1118 but that's not really an appropriate place for that fix, plus it will probably be a week before that PR is ready to merge.
There is `pyplot.set_cmap('hot')` for exactly that purpose. Given that nobody thought of this, it should definitely be mentioned in the colormaps docstring as well :) (Note: Its implementation is currently broken, but Issue #896 will fix this.)
Nit: This line should be four more spaces in or alternatively you could put this commented out line before the method definition.
No, because I want the zoom level calculated from the server's resolutions, not from the map's resolutions.
This probably should end up being :kind_if => [ TrueClass, FalseClass ], :equal_to => [true, false]
The method should rather accept compatibility mode as parameter than relying on superglobal.
Maybe test edges here.
The Currency list is imported from moneyed (py-moneyed), and that list is used to provide the drop-down choice list in the Admin as well as being used for validation.
Can we replace all the bg images (gradients) and shadows images, with CSS?
Spacing throughout the block above.
I would prefer `authorizable instanceof User`

`isAssignableFrom` is useful when you don’t know the class at compile time, but that's not the case here, and `instanceof` is more readable.
This method feels strange here. I think it would be more at home in StorageClientUtils, maybe under the name of logoutQuietly(Session session).
please - when there is just a single command - just use 

```
if (...)
    return;
```
@seen: nope, thanks for catching that
All of these changes from the start of the file are changes to correct column-store recno handling for implicit records.
No, that should be a separate pull request.
this is wrong. It will **always** return false because each DI extension is isolated
I like this "stationary wave" description.