labofsahil/github-event-dataset-2012 huggingface dataset:
OH i see..
I'm going to clean it up so you can clearly see what I did. Pycharm indented everything making it difficult to see the changes.
Merged master again since pull request is still pending.

No spec failing.
Basic NO_WRAP mode functionality using a recursive function. It does not return the start point and end point of the word yet.
OK - I created a migration to make an attribute max_items_per_page in ViewStyle to address this. I like that idea because it also makes it easier to test this - I don't need to create 500 items.
Typo here. It should be "UMTRX"
Why are you calling add_setup_hook instead of just defining setup?
Please use RDoc or Yard syntax. Comments go before the function, and are made up of proper sentences (capitalization at the beginning, colon at the end).
"auszugeben" was correct, please re-fix.
Why 100 columns? In other languages it's usually 80 columns. You should explain, why one shouldn't use more than 100.
oh i can /shrug not in the mood to over github convos...atm though. :p
No harm done Anton! :) Made some small adjustments to the main menu and added a background image and background music. Works nicely so far! The merge itself was absolutely no problem.
Tbh I dont understand how this commit would solve it, but Amit86 said it worked so I pushed it. Then this can be re-reverted when the real cause is found.
Nop, it was increased in cata, so your profession doesnt take years
Gives error, remove trailing `,`
You're right. Thanks for the contribution, sir!
I have looked at your other kohana repositories.You use the message class in many places and I have finally found it. But where does Kohana_Message is defined. It's not in the system core. I suspect it has something to do with the benchmark module or the Kohana::message method. Could you please bring some clarity on this? Thanks!
:-) I don't know how to do that either.

//cc @ericbarnes are you able to do this?
@igorspasic - I'm glad you are addressing encoding of international characters! A couple questions ...

1) What is the HTML equivalent of "Супер"? In other words, how do you specify it using HTML representations of the non-ascii characters? This word must be specified in ascii or HTML in order to be converted properly from Markdown.

2) What would the Content-Type header be for the "Супер" example?

Thanks!
Non ti preoccupare, poi rivediamo tutto, ciao!
so, what should the group and artifact ID be for the js-engine? We then can pass the build, the project is already set up.
Test ListBoxControl.setValues & add an 'addItem' & 'removeItem' method, then remove this class and link the model to the list box in the factory.
en effet :)
No problem. A better phrasing would be:

You can use a changeset ID, or set the value as a job parameter defined as "${changeset}". Tags are currently invalid.
So played around with today and its very handy.  Any way to get a steady stream back from the rcon?  Im sort of a noob in this stuff.  

One change I did do was this in the rcon_test.php file.  This is to break up multiple line responses. 
```
               $blah=explode("§e", $Data;);
                foreach ($blah as $value){
                        echo $value."<br>";
                }
```
This commit breaks the subtitles of one test .srt file for me.
Let's see if I can paste its contents below, as it contains non-ascii characters:

    0
    00:00:01,930 --> 00:00:03,800
    <font color="#FF6600">[ سينتل ]</font>
    
    1
    00:00:03,930 --> 00:00:05,300
    النصل له ماضى مظلم
    
    
    2
    00:00:05,710 --> 00:00:07,320
    لقد سفك دم كثير من الابرياء
    
    3
    00:00:07,770 --> 00:00:10,550
    أنت حمقاء لكونك تسافرى وحدك
    وغير مستعدة على الاطلاق
    
    4
    00:00:11,290 --> 00:00:13,040
    أنت محظوظة كون دمك مازال يتدفق
    
    5
    00:00:14,960 --> 00:00:15,570
    أشكرك
    
    6
    00:00:17,220 --> 00:00:18,040
    ...إذن
    
    7
    00:00:19,240 --> 00:00:21,610
    ما الذى أحضرك الى أرض حراس البوابة؟
    
    8
    00:00:25,000 --> 00:00:26,520
    أبحث عن شخص ما
    
    9
    00:00:27,470 --> 00:00:30,830
    شخص عزيز جدا ، روح مقربة
    
    10
    00:00:33,220 --> 00:00:34,160
    تنين
    
    11
    00:02:28,710 --> 00:02:31,110
    بحث خطير لصياد وحيد
    
    12
    00:02:32,820 --> 00:02:35,100
    أنا وحيدة منذ ما باستطاعتى أن أتذكر
    
    13
    00:03:26,920 --> 00:03:29,330
    انتهينا تقريبا
    
    14
    00:03:30,470 --> 00:03:31,880
    لا تتحرك
    
    15
    00:03:47,750 --> 00:03:49,240
    ليلة هانئة ، سكيلز
    
    16
    00:04:10,090 --> 00:04:12,680
    !امسكها ، سكيلز ، هيا
    
    17
    00:04:24,790 --> 00:04:25,590
    سكيلز؟
    
    18
    00:05:04,000 --> 00:05:07,500
    !نعم ، هيا
    
    19
    00:05:38,510 --> 00:05:39,850
    !سكيلز
    
    20
    00:07:25,580 --> 00:07:26,640
    لقد فشلت
    
    21
    00:07:32,560 --> 00:07:34,600
    ..لقد فشلت فقط أن تشاهدى
    
    22
    00:07:37,560 --> 00:07:39,450
    هذه أراضى التنين ، سينتل
    
    23
    00:07:40,310 --> 00:07:41,840
    أنت أقرب مما تتصورين
    
    24
    00:09:17,390 --> 00:09:18,480
    !سكيلز
    
    25
    00:10:21,180 --> 00:10:22,130
    !سكيلز
    
    26
    00:10:25,560 --> 00:10:27,110
    ...سكيلز
    
    26
    00:12:21,560 --> 00:12:27,110
    <font size=24></font>
    {ad(1000,1000)}
    تمت الترجمة بمعامل
    <font color="#FF6600">
    [ SHowTime ]
nevermind, this is CM7, which ignores ABS_PRESSURE or ABS_MT_PRESSURE completely, so it doesn't matter. thought this was CM9.
indent +1 (tabs2spaces& headers). three files still need cleaning... listed in CommitMsg.
Look at what's done in old teambuilder

```

void TB_TrainerBody::setTierList(const QStringList &tiers) {
    QCompleter *completer = new QCompleter(tiers, m_tier);
    completer->setCaseSensitivity(Qt::CaseInsensitive);
    completer->setCompletionMode(QCompleter::PopupCompletion);
    m_tier->setCompleter(completer);
}
```
We're using casbah 2.1.5-1.  I just tried with 3.0.0-M2, but Salat breaks.  I'll try patching that and see what I find.
why did you use double slash to match absolute path?
this is causing my absolute urls to be rewritten, getting prefixed by PIPELINE_URL, to be specific. and in #2 kylemacfarlane suggested to use single slash. it seems you rejected his commit. i'd like to know the reason.
sorry, i should have earlier said (when i suggested "retrieve") that off should be changed to "from"
Fixed line endings in the pull-request.
It's bcm4329.

If this works but gives problems (random disconnects), I also have older version of the source directly from Huawei that works identically to my stock rom's version.
please fix this bug.


		container.setOnClickListener(new OnClickListener() {
			@Override
			public void onClick(View v) {
				if (mItemClickListener != null) {
                    mItemClickListener.onItemClick(QuickAction.this, pos, actionId);
                }
				
                if (!getActionItem(pos).isSticky()) {  
                	mDidAction = true;
        			new Thread(new Runnable() {
        				public void run() {
        					try {
								Thread.sleep(100);
	        					dismiss();
							} catch (InterruptedException e) {
								// TODO Auto-generated catch block
								e.printStackTrace();
							}
        			}
        			}).start();
                }
			}
		});
s/variable/error code
Wow, that is a remarkable number of typos.  Clearly some of this was typed too fast ;-).
Yes ... we have to change the logo in order to make it fit!


2012/2/14 Andrea Spadaccini <
reply@reply.github.com
>

> This does not look good on the github project page: the README viewer
> wraps the longest lines (I think to 80 chars). Please fix. :)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zencoders/zencoders.github.com/commit/b052994f82e419dcaf97d0209ee9d93177a5a051#commitcomment-964155
>
Calma, senhor... tem nenhum teste quebrando. Mas, realmente, a baguna de
gems de form, eu acho, errado. Ou  uma ou outra.

On Wed, Feb 29, 2012 at 9:54 PM, Eduardo Braga Ferreira Junior <
reply@reply.github.com
> wrote:

> por enquanto a coisa t entre aspas mesmo.. tenho feito nada no projeto,
> assim como outros nem deram as caras, ok!
> mas mesmo assim, sinto-me no direito de reclamar sobre isso, embora eu no
> ponha a mo como vocs esto fazendo, estou acompanhando o que est sendo
> feito e leio essa bagaa toda aqui..
>
> acho que as aulas servem pra isso (alguns faltam alguns dias, mas o lugar
> de fazer isso  l), tem nada que sair instalando coisas, mudando coisas
> que talvez faam outros testes quebrarem no..
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/douglascamata/Rick-Rocks-Academics/commit/2051dac6f31a7ab08c1a971e3de99f092a05f7c5#commitcomment-1028914
>



-- 
Douglas Camata
Graduando em Cincia da Computao (UENF)

Blog: http://blog.douglascamata.net
Github: http://github.com/douglascamata
Twitter: @douglascamata <http://twitter.com/douglascamata>
<http://twitter.com/douglascamata>Skype: douglas_camata
-----------------------------------
Linux User #509211
Fixed the wrong message appear in console when a user do: rake import_products:install
BTW, I'm working on this stuff in https://github.com/silverstripe-big-o/sapphire/tree/story/SSF-24 
and https://github.com/silverstripe-big-o/silverstripe-cms/tree/story/SSF-24 - so don't put too much work into fixing up AssetAdmin beyond the necessary (or check for commits to cherrypick first)
Thank you for explanation. It makes sense. I will change my code.
I tinkered with this last night, and what I ended up doing is having the subcommands add/insert groups to a simple list property of the command, and then when command.main() runs, it uses `optparse.add_option_group` to add to the parser from the list in order.   no direct index inserts.    but this could happen later outside the scope of this pull.
I'm curious why 2 instead of 1?
ThumbnailSplitList should inherit from SimpleSplitList rather than the reverse.
I don't think HTML contains js, css concepts, in fact they are different, different in functional, syntax. In a common project, they should be write by different people.
Comment not needed. Just put `/** @override */` or something.
This should already be done by core I think.
fixed here and in other similar tests
Can't grab these from code?
Map(address -> (Deadline.now + JoinTimeout))
What happens if a to-clause points to an Actor that doesn't exist?
Yes, it's testing exactly the same thing.

/Patrik

10 sep 2012 kl. 16:43 skrev Viktor Klang (√) <notifications@github.com>:

> In akka-actor-tests/src/test/scala/akka/routing/RoutingSpec.scala:
> 
> > @@ -241,9 +233,8 @@ class RoutingSpec extends AkkaSpec(RoutingSpec.config) with DefaultTimeout with
> >        routedActor ! "hello"
> >        routedActor ! "end"
> >  
> > -      Await.ready(doneLatch, remaining)
> > -
> > -      counter.get must be(1)
> > +      expectMsg("hello")
> > +      expectMsg("end")
> >      }
> >    }
> Is it still testing the same things, if so, LGTM
> 
> —
> Reply to this email directly or view it on GitHub.
>
Why is MixMetricsSelector both a case class and a case object and the case object neither extends the class nor returns a cached default value. Is MixMetricsSelector case-class mutable? I vote for removing the "case object MixMetricsSelector" since it doesn't do anything AFAICT.
Or have I missed something?
No. Since the node is no longer part of the node ring (or any other part of the gossip state).
I’d rather include that in the Data so that it is available during error handling.
Right, of course.
At first I had the `state.set` after the `deathWatch.publish` and `provider.unregisterTempActor`, which results in a deadlock.
Since it can be moved up the busy state can indeed be skipped, excellent....
makes sense, I'll change
Awesome pic.
I tested setup without the equivalent constant here, and it worked.  Assuming creating the first account is a good enough test.
Alexis, could you take this opportunity to document a bit more the API  of this module?
Should we have a comment in this file saying

# Ckan dependencies
# see docs ..

Also do you think we can use the specific pyutllib versions on pypi which would also remove svn as a dependency I think.
I knew someone was gonna call me out on this if I forgot to go back and add it. I still forgot.
Same as above, you shouldn't have to mess around with making your own bindings, the base test class sets that up for you.
We will probably do a lot more spec work before finalizing this migration.  The only point to these cards is to indirect the group labels with these cardnames.  It could use contents or even a rule if you like.

I think we want a pattern like this to address all the "ENGLISH" fixes.  We want all that in cardnames, rules or card.content.
This is wrong. Nothing else free's this in the base. Any overload need to set it to null if it frees it before.
Right, so IMO those places should be corrected if at all possible - as far as I'm aware, it's only the videodb stuff that resets the path to something else, right?  Is that possible to remove?

Overwriting it here means that in the future we can't have a directory class change the URL for whatever reason.
Do we really need to put this in CApplication?
'name' => 'id',
primary - это вроде делает цвет синим, не вижу его использования в виджете
> Using Zlib requires that. Calling deflate/inflate must be done from
> the same process which created the zlib streams (because of them being
> ports). I was actually stuck for a good while as of that. The shell
> experiments worked OK, while the program itself didn't, though the API
> access was exactly the same. It's quite bad the doc doesn't mention
> it.
OK, I didn't know about that.
Not sure how multiple args are even supposed to be doc'd in TomDoc.
dont we need this?
How so? I haven't come across issues like this.
`tracking` really shouldn't already be `YES` for `mouseDown:`. Seems like that should be an assertion instead.
I guess I was programming too fast.... >_>
Alright, alright. I'll do it for the penguin. And because finals are over and I'm a second semester senior now... much time to spare! :8ball:
nvm, found `setgroups()` call below
I would like it better if this didn't modify `net.Server`'s prototype. I suggest that you include cluster.js in net.js and check if `cluster.isWorker === true`.
This description is not entirely accurate, right?  This class loads dynamic libraries from the local file system or from a jar.
`Y.Array.each()`, not `forEach()`. `forEach()` is an alias, but I don't think its use should be encouraged.
It’s not writting in stone or something, but most of our test cases have spaces after an argument. So "foo(1, 2, 3)" instead of "foo(1,2,3).
Here, I mean you could move the description to a new section, or it will output with the test name, that looks ugly :)

--DESCRIPTION--
......
You can't apply the same logic for everything from 300 to 399.

* For 300, don't bother about the `Location` header, and process the response as though it is a valid response.
* For 301, check for the `Location` header. If this header is missing, treat it as an error. Follow the redirect only if the request method is `GET` (technically `HEAD` too), but not otherwise. When method is not `GET`, treat the response as valid and let the script process it.
* For 302 - same as 301.
*
это можно тоже в список инициализации
хотя не, при isCut = true; все равно break делается, зачем тогда еще проверка в конце функции? она никогда не сработает
Two spaces :scissors:
For generated code, no. Also, we are changing in place where we are touching the code.
I've made this change. Let me know if you want me to do anything with the `html_options.dup` I mentioned above. Thanks.
Just curious, do you know *why* we had the rewinds in here?
bro is to match `SessionKey =` position :D
```ruby
 unless connection.supports_transaction_isolation?
```
shows this NameError. I do not see any `connection` nor `conn` within this test script.
```ruby
NameError: undefined local variable or method `connection' for #<TransactionIsolationTest:0x00000003e588e8>
```
true, cool :)
One could argue that those exceptions should never be seen in user code. However, for library writers, it'd make a lot more sense to throw them (since they're clearly serious implementation-related errors). One could also argue that, if desired, a library writer still has the choice to catch these exceptions and handle them however they'd like. But again, the bottom-line should be that a user, on the other hand, should never have to run into these.

I guess the guiding light principle here is that, in all cases possible, the library writer should do more work to produce correct code than a user.

@retronym made the suggestion-- so if desired, he can also chime in on this :)
Maybe let's move this to `TreeGen`?
is this suppose to be the middle line? Is the input always an even number of lines?
That's right, one has to run it for Python 3.2 and it is already done in the main repository of sympy.
Wasn't there talk of changing `is_Atom` to include things that don't have args so that the second clause would be redundant?
Do you want to add a test ``set(a[True]) = set([x, y])``?

That should work, right? And it would follow the original intent of the doctest I think.
Pertaining to the java.sql.Timestamp questions:
Date.toString returns something like "Tue Oct 30 10:15:59 EDT 2012" while Timestamp.toString returns something like "2012-10-30 10:15:59.812", which Ruby likes better for parsing. What I SHOULD probably be doing is just sending timestamp.
Also when we're storing / reading in timestamps locally. See SessionData lines 33-47
What's the behavior if users are querying these cached tables when the server is first started? Should we block the server when it is creating cached tables?
*another*

*pass* rather than *parse*?
It's not a work around, and this is not a generic binding use-case.

The noDelay() binding *will* get the value, but only immediately after init() has run.  In this situation, the purpose of the noDelay() binding is to immediately (before .set() returns) proxy values from the parent object to the child, and part of doing the proxying properly is having the current values there when init() is called on the child object.

So while noDelay() bindings do apply their values fast at startup, and immediately afterwards, there is still that brief period of time when they are not active. This approach addresses that when it's an issue (as it is, in this case).
This is wrong. www.dev.iron.io doesn't resolve. Instead, use `{{ site.baseurl }}{{ page.url }}`
You don't have to change the function prototype, `handle->loop` is a valid pointer.
Style: spaces between operator (in this whole block).
Why cannot you check this?
ooooh
you were talking about that
mkay
I'll go fix them then
This is a non-issue, I just like my for loops broken into multiple lines so that the insert statement is more prominent.  But this is fine as is.
in these cases I think it's fine/advisable to say "applications" rather than users.
since you're returning nothing, you can just do:

`return;`
I think this is the right behavior for delete_key... We can remove this TODO...
@chrisroberts, barring a strong use case, we're going to drop the node data pipe and move forward with the rest of the code. Thanks for all your work.
Why is this not part of acp_board - it doesn't seem like there is any special functionality here?
I'd just call it `USER_DATA`. No need for hungarian notation.
I'd suggest `@return array Array of strings of available compression methods (.tar, .tar.gz, .zip, etc.)`
New function so pass $user as a paramter and don't use a global?
not undelivered => delivered ?
There's no new line at the end of my file, I don't know why this is being marked as different by git.
2. Yeah... I didn't think of a real use case for that one, I only thought for the other one. If the devs vote for the removal, I'll remove that one and keep the other one.
I think you should be saving the date, too. If they come back a few months later, they won't want the post back and it could be confusing.
fixed here: https://github.com/jeanphix/django-rq/commit/5fa0ebdc4b12fb7a301eb07ca0f0efd8257d0dc1
I guess it makes sense to cache the property. `var forEach = tools.forEach;`

Maybe also:
`var forOwn = tools.forOwn;` and remove all occurrences of `for…in`.
Let's just keep in mind that the number of views is a finite number, and they will be cache after the first read per view. Also, we can easily change all this to async since the "render" method is async by nature (adapter.done or adapter.error are the callbacks). 

Compile and precompile are meant to be used as part of the build process IMHO.
Hmm good point, removed.
Use `var` instead of explicit type declarations. This should be applied to all variable declarations in this file
Why not download the release archive from sourceforge? Fetching the sources from Mercurial adds several dependencies which weren't necessary before. This change adds costs, but where is the benefit?
please remove ext-all.css, too. It's already present here:
https://github.com/Raxa/Raxa-JSS/tree/master/src/lib/extjs/resources/css
make sure you fetch+merge so that you're local enlistment is up-to-date and has the ExtJS libraries
How are you making sure that all concepts have been returned and have correct uuid's?
Does this need to be public? It assumes that the file location is correct i.e. that ```read_header()``` has been called once and only once. You've exposed ```read()``` which I assume is the intended interface.
A tag uniquely identifies any transmission. It is how sends and receives on different compute nodes know to which partner they should connect. There will never be two receives with the same tag in a computation.
Not needed, it will fail later (or else, we could complete with n_steps automatically)
Classes that don't have a toJSONString method don't need a loadFromJSONObject method. 
Back out this change.
This text could be more clear (though you're only updating someone else's text). I think you're trying to says that all joins between partitioned tables (better word) are performed locally in VoltDB, because we reject joins that aren't on partition keys.
Spurious comments.
Why nullable?
CvIsNotDeletedWhenConfirmationIsFalse
I'm not quite sure that `set_height`, `set_x` and `set_y` is the optimal way to divide this method into. It's pretty hard to get a grip of how the program handles `:left => 10` by looking at this method since you have to look into two (potentially four) methods instead of one. It's also pretty hard to change the order/priority of different styles.
The original patch had .encode('UTF-8') so I probably chose the wrong util when getting it to pass py3 tests

I've looked, but so far failed, to find any clear documentation about what Apache uses as far as encoding for conf files, and whether mod_wsgi expects the same.
I don't like this, since its depends on the default fetch value which could be assoc. Can you just use array_change_key_case($row, CASE_LOWER) ?
Slightly odd phrase here. It makes more sense to use the `Returns` syntax:

`Returns a dictionary representation of the given keys. Will not be nil.`
This is wrong here. You have <b><i> "TEXT" so what you want to do is getheadOfCue( 0 )->child( 0 )->toInternalNode()->child( 0 )->toInternalNode()->child( 0 )->toTextNode()

There are errors like that all throughout this code. Each tag within a tag is a child within a node in the node tree and you need to change you're tests to reflect that.
* 変数は（意味的に）重複して定義しない。
'this' is idiomatic
`function` is a language feature such as `if` and `while` so the recommended style is to have a space between `function` and `()`. Not a big deal.
Shouldn't the assigned value be `jQuery.fn.toggle`?
s/visiable/visable/
Should be split_criterion according to the code.
^ copy paste error :)
IMO passing a playlist without the URI set to `save()` is wrong use of the stored playlist API, so I want it to fail hard.
typo there ^?
Yes, they all changed to .org. The last two are fine with that change, but the first one has some redirect funkiness, detailed here: https://bugzil.la/773027
we do 2 spaces for html on sumo. just fyi
I could probably switch it. I just copied it over from Kitsune.

I'll see if that works tomorrow. I bet you're right that it'd work fine.
```rb
system "make"
bin.install 'ren'
man1.install 'ren.1'
```
I'll look into it.

We could actually call the appropriate doctor check directly and print that as part of the exception message.
no s at data
yes, we can !
Can we elaborate a bit here about the importance of the order?
"для каждого из них вычисляется контрольная сумма <...> и эти контрольные суммы добавляются в индекс"
The orphaned_distribution_paths key is used in other modules and should be a constant.
This and anything else that shows up in 1.7 by running the pandas test suite is probably worth bringing up on numpy-discussion.
If you upgrade requests (which I agree is a good idea) many of the other requirements list in this file becomes unnecessary. I don't remember which ones, but should be easy enough to figure out and purge.
Yeah, this is for foolish consistency with `nextProxy()` which also has a 'very next line' problem. But in `nextProxy()` it actually has a behavior side-effect. If the DNS lookup throws, then clearing the socket address is significant.

I'm going to add a comment to explain that.
Fine for root!
Not sure about this bit, doesn't it mean multiple calls to getMatch will return different results? I tend to dislike coupling method calls to changing class variables.
sure, i will update it. thx
I prefer the way `throw err if not handled` reads
Build is probably ok, don't want to be nit picking - I think sometimes the context should allow for some inconsistency since translation is not a translation of words by words - I strongly believe it should reflect the meaning and the spirit as good as possible.

Thanks,

Peter :)
error on line 35, use of setTimeout
Do these spies modify the module itself? If so, would that affect any other unit test that also loads these modules?
This var should be given a different name since it may have nothing to do with the sidebar width (in the editor, for example).
fixed

From: Jason San Jose [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 1:55 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache (#1358)


In src/strings.js:

> @@ -22,145 +22,17 @@

>   */

>

>  /*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50 */

> -/*global define */

> +/*global $, define */

jquery $ is unused

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1358/files#r1377055>.
`;` missing at the end :D
Please note that Giannis' fixed this and his fix is in master.
I've completely removed the method and all references to it. Existing code was refactored to use `makeFilename(self, length=32)` which was enhanced to support `prefix` and `suffix` parameters.
Sorry, I mean in the same Rd file.
Well it seems the original code makes no sense either. `-displayNameAtPath:` will not give any useful result for partial paths that likely don't exist.
(You make context dirty with `search_url` while you need it only once. This is a good approach if you would need the same URL multiple times.
Relict from the past or future, but yes, not now :).
If you are already here, you can also delete those empty lines around this line.
Aa, I was found something else :) Commit...
Can you multiline this string too? Easier to read.
Why does this need to be imported?
no `err` handling here?
I don't see any commits related to these.
Tämä kannattaa ottaa pois
there's a namespace conflict on Set
Is this for some future use? Vs just using the string straight in the QueryRequest
This input shifts in height and width when in focus - can you make it so they stay the same?
I would avoid meta-programing here. I would use:
```ruby
class Api::ForemanProxiesController 
  protected
  def foreman_model_class
    raise NotImplementedError
  end
end

class Api::ArchitecturesController
  protected 
  def foreman_model_class
    Foreman::Architectures
  end
```
`NotImplementedError` is more descriptive than `NoMethodError`
I prefer this condition

    if $katello::params::use_foreman

Let's keep one place to decide whether to use foreman or not.
Oh' you're right, probably should get the alchemy dir dynamically, needs to be resolved, but I don't insist it needs to be this PR
Please move this file into $GAIA/build/ to disambiguate that this file is used only for building
I would bring this in line with your return statements and call it `result_data` instead of `final_data`
Oh, or you could link straight to the cosmology section (http://docs.astropy.org/en/latest/cosmology/index.html)
These "if statements" here are difficult to follow.  Also, return sections need to be formatted in the same way as the parameters above.  So in your case, it should be something like:

```
Returns
-------
convolvedarray : `numpy.ndarray`
    By default, this is `array` convolved with `kernel`.  If `return_fft` is True, it will instead be fft(`array`) * fft(`kernel`).
```

I would also leave out the bit about crop, because the "return" section should generally be as brief as possible for clarity.  You can add a note about this below the return statement, or something like that.

(Also, note that you should use single-backticks to reference other parameters, rather than asterisks)
Maybe ``_EQUINOX_B1950`` should also be made a module-level constant.
I don't really like the fact that the hash in pindexBlock is optional. We have a GetBlockHash()... why doesn't it just calculate the hash if it's not available?
When making my pulls obsolete, which makes sense here to have 1 instead of 2 to fix this, could you please merge the ``WSAGetLastError()`` into the printf :)?
Both evaluate to binary all-ones and are equivalent on all architectures with two's complement notation for signed numbers (ie, at least all that  windows supports.. and certainly that bitcoin supports).
I'm not sure if I understand why, but it's not worth the discussion in the end.
Can we use the same exception message as RC uses: "Popup has not loaded"
Strings made into constants
same is true for maxResult indeed, but it can already be ``null``. For the ordering, it is not an issue IMO as you would probably merge ordering (which is what is done in the PR implementing QueryBuilder::addCriteria for instance) so an empty array would still be fine.
should not this line be tied together with the below foreach?
If we hardcode the `/`, then I'd suggest changing this line to a sprintf().
Hm. We could, or we could save that for the object-level implementation.
The URL should be relative.

Sebastian
This is very minor but could you please add a space after the `~>` for formatting consistency.
Why did this get it's own file instead of going in lib.display with the YouTubeVideo?
Instead of a global `init_notification_widgets` function, why not use a method `NotificationArea.init_widgets` instead to better encapsulate the logic?
CALDAV makes (what I would say is an optimization) and groups all related events (todo, etc..) in the same VCALENDAR body.
ICAL formats itself don't enforce ordering (I think) so RECURRENCE-ID could in theory appear anywhere in a huge document where as we know each sub-component in the CALDAV response is going to be grouped nicely and either by the primary item or an exception for it.
Are you by any chance using Github for Windows or Github for Mac?
It probably makes sense to just return a `git_oid` instead, since the callee really only uses the resulting tree entry to do an object lookup. I'll change it accordingly.

As for the above comment about moving `git_tree_entry_bypath` in with the rest of the tree API, it seems like your version is the more correct and useful of the two, so I'll rename mine so it isn't tempting to move into a public header.
1) I still think this should respect schema-less paths as absolute paths. That is, these should all resolve to true
```js
absolutePathRegex.test("http://example.com");
absolutePathRegex.test("https://example.com");
absolutePathRegex.test("//example.com");
```
The regex would look something like:
```js
absolutePathRegex = /^([A-Za-z]+:)?\/\//
```
If we choose not to support this, that's fine, but we should document it. I don't think there are any CommonJS rules about this.

2) We also have a bug in our relative path regex. The dots `.` aren't escaped and will match any one or two characters:
```js
relativePathRegex.test('w/example.com'); // true
relativePathRegex.test('wt/example.com'); // true
relativePathRegex.test('wtf/example.com'); // false
```
this should probably be:
```js
relativePathRegex = /^(\.\/|\.\.\/).*/
(or possibly more readable)
relativePathRegex = /^(\.{1,2}\/).*/
```

rest of the logic seems fine otherwise
Yeah it was blowing up if password was empty. Good idea.
... and gets a new folder name. To make it better readable I would store the path operation in the same variable. Further asserts in this test could benefit from.
I prefer `implementations_list`
Try not using ``+`` in Python, it is known to be slow. Try using ``%s`` all the time. You can escape a ``%`` with another one, so ``"My %s is %%(name)s" % "name"`` will evaluate to ``"My name is %(name)s"``. Which you can then reprocess with another % operator (or, in this case, pass to the ``execute`` function).
Cool, refresh pull request - I've updated it to map the queue names just once in #initialize.
7 levels of indentation, that's too much, even for rock :) Can you refactor that into something more readable?
removes the "category"-node connection too, is this what we want to show?
The #tabConrol is used to generate the tabs with YUI, but I added the class definition for two cases, default and the explore page which both have their own .tabControl definition.
sure...if i only understand how i can edit the file :S
Do you need to modify this? Instead, could you just use a # for a href in the getInTouch links config section?
Im pretty sure it does for the QEvent::Polish. But I would agree putting if (!w) return; to MakeFontsLargerOnOSX.
you should not tag is as ``@api`` as it is not part of the stable api (it is not even part of the codebase yet)
This should be removed for the same argument as Min.
Well, I think it should really ensure it's unmodifieable or it shouldn't be named as such. Some properties can still be modified via reference. And even the UnmodifiableEventDispatcher doesn't derserve its name as one can still modify the proxied dispatcher and thus also the unmodifiable one. It would require the clone the dispatcher before proxying it. (but that might have some overhead)
it's not that we should but it doesn't harm and it saves a function call
clear also `$lazy` and `$lock` ?
You should add the appropriate ``indent`` calls to make the output clean
``$c[0]`` looks useless here as there is already a single char
Huh? I don't see where this method is used at all (except tests).
Only an ArrayNode here. And please use the short class name (relying on the use statements)
This is a fairly common hack, but yes it's a hack. DIgging around I think setting port to 0 should result in a random port being used, but I haven't been able to get that to work. I think this is ok for now.
Add ()'s around these params
用户不关心你是用什么实现的
更不需要说教，尽量不用其他字体
我是希望模板说明里不出现任何字体相关的东西
font independent
for(var i = 0; i < me.size(); i++ ){
-》不要频繁调用相同返回值的函数
for(var i = 0, l = me.size(); i < l; i++ ){
Add the following methods for completeness

get(Collection<K> ids) : Collection<T>
find(String cqlQuery) : Collection<T>
delete(Collection<K> ids)
Unit square.

OK, I will take out those checks for the clamped computations.  Then will need to rerun all my tests to be super sure nothing breaks.
For the sake of encapsulation, why not go through webmachine router to get the dispatch list?
测试代码错误？
Better yet, drop the `if/else` altogether. And move the assert up to where the `if` was.
I think using a big number is preferable to false as a default. Ideally, we'd use the actual length of the options for the limit as a default, but I think using something like 9999 is probably safe for all practical purposes. Using a default of 999 would eliminate part of the conditional.
That wont be necessary because access is synced already in the underlying ServiceTracker
El debug te va a quedar como el culo porque ahora son 50 objetos...
Maybe a loop here in conjunction with a map from above rather than 4 conditionals?
原因比较简单嘛，就是直接定义成两个价格，我们自己可以做灵活调整。以后再加日元和韩元这个以后再考虑嘛。  

汇率换算模块可以做，而且可以可以不仅仅用于这个地方。这个很好理解嘛。就想iphone5发布，在美国咧网站上定一个价，然后在中国卖的时候直接实时汇率换算过来就是中国的价哦，这样显然不合适嘛。

因为我是觉得这样做就是一刀切，认为我们所有的产品美元和人名币就是直接换算过来就可以了。这个虽然domain不用加。然后用汇率规则来解决，但是这个东西不是通用的。我是觉得很多产品不是汇率换算过来就行哦，而应该根据不同咧标准来定价。

或者说简单一点，可能应该很好理解嘛，就想在中国，可能大家觉得10快钱包月太贵了，宁愿不翻墙忍了。但是美国人和欧洲人觉得来中国不上facebook就要死了。10刀一个月他都觉得无所谓，而且还便宜。

还有你以前说咧日本人修笔记本事情。在中国你说收了300修风扇，可能很多人不能接受。
但是日本人说1000人民币我给你搞好，他马上就付钱了。

所以我觉得这个东西不是靠配置一个参数就能做到扩展型，这个跟扩展性一点关系都不得。现在我就加个字段就是我们可以灵活定义。

或者说现在有个汇率换算模块，还需要更强大一点，你能直接算出日本平均收入，美国收入，然后还有观念系数，然后再加上汇率，综合起来换算出一个合理的价格。这样我觉得可以。

总之我觉得汇率直接算太一刀切哦。  

--  
zhoudi
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)


在 2012年12月16日星期日，下午4:49，longhengyu 写道：

> In data/dev/init-product.xml:
> > @@ -11,6 +11,7 @@ > description="Server Located in California, High Speed, No Access Limit for 1 month. (DO NOT support p2p)" > image_url="http://ww1.sinaimg.cn/mw690/ba2b4929gw1dz8xb9q489j.jpg" > price="26" > + dollar_price = "5"  
> 你总要说你这样做的原因，你把100人民币定成10刀也好20刀也好，有哪样根据，或者说有哪样优点（当然，除去不需要额外开发的优点）。  
> 我认为汇率换算在跨国交易里面是一个比较重要的模块，通过实践，我们都可以从中学到东西。并不是简单粗暴的说我就要两个价格。
> 你只需要加一个参数，定一个换算系数，不管你定成6，还是10，你相把100人民币换成10美元20美元都可以做到，并不需要往domain和数据库里面加任何东西，就可以完全实现你手动写两个价格的同样的效果。带来的好处是，明显扩展性更强。
> 以上是我想这样做的原因。我觉得特别简单，而且顺理成章，你咋个有点喜欢在顺理成章的事情上这么苗。
> 如果你坚持要这样做，你肯定需要说明这样做的好处。而这样做的坏处，我已经给你讲哦，就是程序看起来非常不得扩展性。如果我以后要支持paypal和支付宝以外的支付方式，比如说日本的公司提供的支付方式。是不是又要改程序，加一个日元价格。
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/longhengyu/dream/pull/12/files#r2429593).  
>  
>  
>
case 'mozinterruptbegin':
        // Only ringer/telephony channel audio could trigger 'mozinterruptbegin'
        // event on the 'alarm' channel audio element.
        if (this._isUnderneathCallScreen) {
          // If the incoming call happens before the alarm, we should just
          // put a "silent" alarm screen underneath the oncall screen
          this.stopAlarmNotification();
        } else {
          // If the incoming call happens after the alarm rings,
          // we need to close ourselves.
          window.opener.AlarmManager.cancelHandler();
          window.close();
        }
        break;


This replaces L163-175
I'll let you get away with it _this time_. But drive safe, and don't do drugs.
you're right- changed to shortcut, and the method param changed to shortcutToRemove.
nit: this.sendButton.disabled = !(this.input.value.length > 0)
spaces lines over 4
maybe use ThreadUI instead of self to keep the style?
We should keep the "real" href otherwise the link is gray and not underlined.
The width is for animation originally. But I think using opacity for checkbox and padding transition for other element would be better. Here I use visibility hidden in the checkbox for better performance.
if you move the code segment in `settings.js` to this file, you probably won't dispatch an event but update the switch directly.
hi, vingtetun:
hasConfirmed is defined in IDL,
see dom/icc/interfaces/SimToolKit.idl
Yep, we can use c (well, I'll rename it) instead contact for avoid confusions, but currentContact has to be the saved contact, otherwise it will fail when trying to editing that object again.
Each li has an its own #id. if we add a line using a different height, It will be rewrite using its own css #id height attribute ?
Because that should trigger another view, to select the kind of data that you are going to fill.
We can make that arrow optional. Is that ok for you?
I had to look it up too. A `-` at the start or end tag removes whitespace.

http://jinja.pocoo.org/docs/templates/#whitespace-control
This function should be removed, right?
0e07019
Hmmm, if there are no "children", then it's not a ConfigSection so it doesn't really make sense to put that in there actually; I don't actually need to check if it has children because ConfigSections are only made if they have children.
lazy val toFieldList

perhaps?
s/exclusde/exclude
excellent catch
Here's a case where you could iterate over results from the query returned by GetMeasurementDictList (renamed to GetMeasurementDictQuery) and serialize them one by one. We would eventually change this code to construct the archive zip files on the fly rather than loading everything into memory and writing it out, but at least with that small change that will be easy to do later.
//Otherwise let's be overly verbose with comments, shall we?
Rems aren't supported on any non-modern browsers.

You need to back up with px measurements to, eg:

font-size: 19px;
font-size: 1.9rem;

If the front end toolkit gem is used, then the global typography will be inherited and you won't have to worry about the CSS output so much as the mixins will deal with it for you.
Ahh ha! excellent catch, yes that's exactly what I intended.
Why is most of the file now indented by a leading space?
I do expect it to be a function.  I'll look into adding a check for that.

No, we do not want to go up the prototype chain.  gst_exports must either reference the global setup procedure in the global setup/teardown file, or it doesn't.  There can be no interpolation of intent here, or else things get awfully hard to debug.
typo here: ``mind``
Curly braces I can see in the symfony coding standard, requirement for empty line I can not see.
Maybe add a note saying that only packagist coming from packagist will be notified to packagist, etc. There is no cross-repository leakage.
Backnone → Backbone
(タイポです)
:+1: I like that you gave this a name.
Are you sure that you have to do all of this?  This seems very very strange for a TUN device that has no socket.  Why are we doing socket calls on a non-socket?

I would think you'd only have to make sure that the `/dev/tun` device exists, and if not, `mknod` it, then do the equivalent of what https://github.com/gparmer/Composite/blob/master/src/platform/linux/net/util/cnet_user.c does to create the device and assign it an IP address.
:+1: 

Wonder if it's worth sampling this on the diagnostics server? Send document.cookie.length & a list of all the keys for our inspection.
This is just line separaters
SCLogDebug
move down to the bottom of the list so existing numbers don't change
subobject? Do you mean subclass?
nitifactions -> notifications
Oh I think I had it but forgot to push that :)
very nice restructuring.  that indenting was out of hand.
Much simpler than my solution.
You are not throwing a RangeError but a nameless object, which has a name property set to 'RangeError'. Please throw an instance of the RangeError class instead. Good to know that this already exists.
You dump the wrong LI tags. Can't accept.
You mean push to my master or my branch? Then the pull request, I pull to you, right?
I don't think we should have this line.
grrr...didn't mean to include this NSLog statement. Can you remove it after merge?
Let's change all of these `%{blah}` strings to just be `"blah"`. It makes it much more quickly obvious that this is just a string (for those of us who haven't memorized all of the many ways of quoting strings)
CS, line ending missing
space before `array`
This seems unnecessary but it saves on some processing having to go into either isAbsolute() and isValidRelative(). It will work if removed, but it definitely had intent as a micro-optimization.
This pattern isn't strict enough, HTML patterns shouldn't match non-html text. It needs at least a `<[^>]+` in it to match an HTML tag.
I don't think there is one for this either. However, this one is probably better left alone, in case apple does something crazy with the command line tools and breaks stuff in much later versions.
I had it retrieve from git because then if you re-ran it, you wouldn't have to type everything again. On second thought, it probably makes more sense for them just to type again.
in theory you should have el.parent() to a variable as it is a rather expensive call...
Doesn't look like the 'force' parameter is used anywhere - is it necessary?
Not necessarily as it's not the most important concern of Controller::_init().
It's mainly about instantiating a `response` with a rendering type given a `request`
I think it's safe to write `if (this[k] && this[k].__diff__) {` here. It's stylistic, but I feel it's more to the point, and potentially faster.
Why all these extra spaces?
and this one would become unneeded too
Please remove all code in comments.
Why not
```
try:
    name = subform.first()
except AttributeError:
    name = None
```
and remove the check for `length` later?
For software for which an easyblock is available, the sanityCheckPaths definition should go in the easyblock instead of the easyconfig.
Overriding this default sanityCheckPaths can then still be done in the easyconfig see. See wrf.py easyblock for an example.
We could post this to thecore for a flame war...
What's this supposed to do?
Could we change this to `.nf`? That's the shorthand I've been using so far for nodefront.
Why would it be auto populated in every case? Further more, I think this should go under apps/users/forms.py in the .save() function logic off of the registration form.
<p class="notice">
At the moment I don't see any benefit to changing the direct instance variable access used in save() and delete(), since that would also require adding a (private, or possibly protected?) setter for mTransient. IMO, Since the instance var access is totally encapsulated inside Entity, it can easily be changed in the future with no impact on the public or protected API for the class.

It may be that I'm not seeing the same problem as you - I can't think of any issue where this being private would cause problems in different Android targets?
Technically, this should probably take a `unsigned char **` instead of a `char **`.
You're outside of a function here, so `this` will be the `window` object. If that is intentional, then this line won't actually *do* anything, since `I18n` was already defined in the global scope way up at the top (line 14).
а навіщо цей js на всіх сторінках? можна ж викликати його тільки на сторінках адмінки.
тут з відступами бардак. в js і jQuery є свої стандарти кодування
scOpen(filename)
Right on. Thanks :thumbsup:
>The PMID and PMCID will always be numeric

As of #304 that's actually no longer true. PMCID includes PMC prefix
No strong preference. Perhaps a mild preference for this formatting, actually, since it's slightly more concise. Seems like the probability of changing "li" to something else while not changing anything else would be pretty low.  In any case, no particular style preference at this stage but I guess we could discuss/vote on it on the mailing list and see if anyone else has opinions.
picky picky...
Ok.  I'll change it.
This documentation is no longer correct with the addition of the last few commits. The knife config within the test directory will be used by default if a CHEF_CONFIG value is not supplied.
This needs updating to reflect *this* task, rather than the one it was copied from.
it should be "else", you missed the "e" ^_^
don't need to convert adaccount_id to str, a valid adaccount_id can only be a string (according to the type of the param in the docs)

just use:
if 'act_' in adaccount_id:
I wonder whether this method should be made public.  The fact that it's needed in the tests is a sign that perhaps it should be public.
Why do you have to change the initial locator? is there a test failing because of it?
The initial locator is accurate, and points to the right css element, when instead the locator you gave points to the PayPal image in the top-right corner of the dialog window.
I'll make a pivotal story for this and if, in the future, a region is necessary we can make one.