labofsahil/github-event-dataset-2012 huggingface dataset:
In subversion version 1.7 the ```.svn``` directory is only present in the "root" svn directory. Any subdirectory do not have a ```.svn``` directory.

So I am not sure your test is correct for subversion 1.7
Precondition is `(instance? Period period)`, I think?
I was trying it on live app by dropping in some puts and just refreshing page.
indentation + multi-line
Can we have this a {'code'.. 'msg'..} type thing to make this consistent with the rest of the APIs?
Correct. Done
Why? The reason I put these in the companion object is to make it explicit that the inner fields and methods are only accessed by the ``JUnit4TestClassesTraverser`` class.
в чому прикол?
I don't think it's worth putting any extra effort into it. (See my note on the pull request).
this should be a `for(;;)` loop not for/in
regelt lopen door middel van accel en afstand van de player waar de enemy naar toe moet lopen
Я уже говорил кому-то другому, скажу и вам - init всё же нужен для инициализации по умолчанию. У вас есть конструктор initLength (который я бы назвал initWithLength, или initWithCapacity), - его можно использовать для инициализации с количеством объектов в массиве, отличном от значения по умолчанию.

Так что лучше в init проинициализировать массив со 100 элементами, а в другом конструкторе инициализировать с произвольным количеством (не забыть проверки на отрицательные значения).
... да. только если 100. в другом случае переменную percent нужно будет вычислять исходя из размера массива и процента.
This only allows for one header.
typo: s/thier/their/
Sure.
Though I don't like the installation way of phantomjs on Linux  - copy/paste bin file :)
It is—I want to call Google Map's postCreate, but NOT ChildNodes', and AFAIK this is the only way to do it.

On Monday, October 15, 2012 at 2:05 PM, Chris Barrett wrote:

> In app/toura/components/ChildNodesMap.js:
> > templateString : dojo.cache('toura.components', 'ChildNodesMap/ChildNodesMap.haml'), > handleClicks : false, > > - prepareData : function() { > - this.node.populateChildren(); > + postCreate : function() { > + // this.inherited(arguments); > + toura.components.GoogleMap.prototype.postCreate.apply(this, arguments);  
> Was this still necessary?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/futuraprime/mulberry/pull/3/files#r1845063).  
>  
>  
>
the .T is superfluous right?
``HTTP foundation chapter`` vs ``Templating component is explained``
@phene, while I very much appreciate the time and code you've put into Paperclip lately, this is a development process. Quite frankly, yes, you do have to justify your changes. We're trying to make sure changes are done for the good of the codebase as well as the good of the users.

That said, I like this PR. I really do. But since the idea of breaking changes has come up, there's nothing wrong with jumping down the rabbit hole and exploring what else we can change here as a result.

If you have a problem, issue, or question with the manner in which we carry out our development, please email us outside GitHub. Mike and my emails are in our respective profiles.
Here: https://github.com/travis-ci/travis-support/blob/master/lib/travis/support/logging.rb#L56-61

I.e. it defaults to :debug right now, but it can be set through config/travis.yml
Before I do the merging, do you really want to keep the copyright under my name?
You can drop this method and in your constructor do:

self ! Start
I'd suggest using normal Restart logic (crash yourself, do restart in preRestart and postRestart) reinventing wheels is so 2011 :-)
So make getPutParams and getDeleteParams public as equivalents to $_GET and $_POST and you are good to go, no?
Using "unload" event caused firefox open second connection when f5 is pressed. That's why we decided to use "beforeunload". I agree, that "beforeunload" is a dirty, but using "unload" isn't clear too.
This way of changing behaviour depending options is really neat, some name more informative than `f` would be nice though.
Please add tests to assert the default and behaviour when false.
yes, you are completely right, since I had many failing tests I didn't catch this obvious thing... Of course the test is wrong here.
hah fascinating
My argument regarding LocalStorage is moot, as the methods are part of cgData itself :)
They are re-used in the initialization of the DBHelper  class, but with opposing semantics WRT to the setting, as the move method has the objective to change the system from the state corresponding to the current setting to the opposite, and then change the setting.
I think for such a logic explicit access to both incarnations of the database is better.
That's right! I didn't think about this way of doing. The shared_ptr would lock on assignation/reset. However, am I  correct in thinking that if I test the shared_ptr then dereference it, I have no guarantee that I'm not derefenrencing nullptr? I mean, the only correct thread-safe way I see it working is if I copy the shared_ptr in an other one, which would be almost the same as locking it (and releasing it)? (on the performance side I mean)
What do you think?
why did you have to escape this? Is it because of JSHint or is that some sinister IE limitation?
No, but we have added *Command classes outside org.infinispan.commands that are, in fact, commands :)
True, we only started doing it now, so we could move them all in the same package, but it doesn't feel like they really belong.
Do we still need to support this JMX attribute? Can it be moved to LocalTopologyManager?
store them in an array, so we return it by direct reference?
Done, corrected!
@danberindei +1
Please remove the extra spaces inside the parenthesis (same for next test).
and there is a type in the message: ``fron`` should be ``from``
Apropos of the comment below by @pelson regarding use of _nbins, I think this method needs to start out by checking whether MaxNLocator is being used; if it is not, perhaps the method should exit with a warning rather than raising an exception.

To avoid use of the private _nbins attribute, one can use the public set_params method.
Is there any kind of standard message for this kind of error?
I agree, but should I "fix" this by deleting the method, or should I fix the method ?
Considering it is a deprecated not working method, I'd go the first option, specially since this code hasn't changed since 2008-09-30. It was also deprecated a while back.

How long do you usually wait before removing deprecated function ?
FYI this exception handling code has been completely removed because the exception we are trying to fetch here is already handled in run_tests. So this is obsolete code.
One space short :-(
self. не удастся ее переопределить.
Perhaps it is worth including a link to the manpage (or a guide) for Tar? e.g:

    <p>(The <code>x</code> stands for e<strong>x</strong>tract.) For more information on Tar the various options see <a href="http://linux.about.com/od/commands/l/blcmdl1_tar.htm"> the man[ual] page</a>.</p>
confirmed with tests/manual/google-v3-resize.html that this doesn't seem to be needed anymore.
Didn't know about has-prefix - useful!
Please change this to `encode(options.index)` to ensure it's properly URI-encoded.
Let's kill it.
@nicolaasmatthijs This is going to do a separate DOM manipulation & query for the `body` tag for every widget that needs to be added.

WDYT about the following code:

```javascript

        insertOnLoadWidgets: function() {
            var onloadWidgets = '';
            $.each(sakai.widgets, function(widgetid, widget) {
                if (widget.trigger && widget.trigger.onLoad) {
                    onloadWidgets += '<div id="widget_' + widgetid + '" class="widget_inline"></div>';
                }
            });
            $('body').prepend(onloadWidgets);
        },

```
New private statement for members and all the members to private.
do you have to remove participants too?  what's the difference between destroying and resetting?
Should be camelCased.
I think there are some copy/paste comments here (and below) :)
A comment would be nice there then, looked suspicious
This could you some beter CSS code, this is the bare essential to have a decent look.
I'm not a web designer, so UI is not my thing.
My first choice would be a CASE statement, but Strings are only supported as selectors in Java7+... I originally anticipated there being more than one possible param name so an early out would have made for extraneous checking like: 
```java
if(!params.containsKey("firstKet") && !params.containsKey("secondKet") && !params.containsKey("thirdKet")){
...
}
```
Good catch, I'll fix this. Thanks.
This should use package:unittest/unittest.dart, yes?

We should also add a note here for how to add this to pub:

depedencies:
  unittest:
    sdk: unittest
let's remove implicit here, since a class implements an interface (but that interface happens to be implicitly defined by another class)
"create as" -> "create all"
Certo, mas assim só estou a mover o hardcode para outro sítio que não devia ter hardcode. Não há um ficheiro tipo `config/qualquer_coisa.rb` onde seja normal meter estas coisas globais?
In which cases do splice, slice and clone not return an array of elements? In that case you can skip this check (which could slow things down).
Do we want the image to be a link itself? Also, do we want to localize this text?
Fixed on develop.
You could move this code to `common.js`.
`authi` -> `twitter_auth`? No? To have names consistent.
It just checks if value is one that is listed (in our case male or female) if you leave it empty it would raise an exception, because empty value is not equal to male or female.
`method` is required?
What is this? Where did you get the idea to do it like this? Can you check documentation on class-based views and how context is passed to templates?
Read [here](https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.Field.default).
So the correct way would be to change the view so that if form is invalid, user is redirected back to initiator page (currently hard-coded to home) and through Django messages (error message) she is notified of the form error.
Wrap dict in `attr` call into multiple lines.
Replaced all appropriate .prop() with .addClass().
I did?

> Maybe return it from `get_success_url`?
Perhaps the risk is low... I can't really figure it out, partly because I can't remember whether or not `10D == 10` would evaluate to true or false.

Still, it makes me uneasy to have a test where I *know* that it can fail randomly, so I'd very much appreciate if there was a better way.
This includes a fix for #615.
Delete them from the trinity_strings table
Add:

	//early frost
    SPELL_MAGE_EARLY_FROST_R1_T                    = 83049,
    SPELL_MAGE_EARLY_FROST_R2_T                    = 83050,
    SPELL_MAGE_EARLY_FROST_R1_CD                 = 83162,
    SPELL_MAGE_EARLY_FROST_R2_CD                 = 83239,
I don't understand why the above three files are removed?
Iterating over all the Predicates in the CAS for every token is going to be pretty inefficient. It seems like you should instead just do something like:
{{{
for (Predicate predicate : JCasUtil.selectCovered(jCas, Predicate.class, focusAnnotation)) {
  return new Feature("Predicate")
}
}}}
comment this line of code.
format better?
why is  this check required?
You have to catch the error rather than doing a pass and then you can pass this message as an error using the flash messages. It means that you need to do something like `set_error('your message')`. `set_error` is defined in `circus.web.util` and already imported in the circushttpd module.
what's the value of putting the PROMPT in a constant? Would it be useful to have it passed as an argument to `__init__`?
You can just use something like `<available file="lib/selenium-server-standalone-${selenium.version}.jar" property="selenium.present"/>` to set a property based on a file existing.
I bet this can die in many different ways.
The two great computer science problems - cache invalidation and naming.

The name sucks. If we can have more autopilot "modes" in the future, then lets call it:

```c++
enum Mode { MODE_ECONOMY, MODE_HUNGRY };
```

If we're not having more modes, then maybe:

```c++
enum FuelEconomy { ECONOMICAL, HUNGRY };
```

I haven't quite got into the math yet, so this may not be appropriate, but I wonder if we'd be better to have a `float m_economy`, with 0 being "use more fuel" and 1 being "use more time". I can see a nice UI for that with a slider. Is that something that makes any sense at all? It might be better for a second pass once this has been merged?
Sure. Done. Pushed with force. Thanks!
Were we going to make the DTD location configurable as well? Or were you planning for that to come in a separate PR?
can do, though the variable should stay LOC as it is referred in the RDF file.
For this line, I consider that as long as the working directory version is modified or type changed the file is considered as modified, no matter what the state of the index.

I use a ``?`` because usually I have to take care of some specific values (due to unmerged cases such as AA or DD), but with M and T there won't be any "special case"
Changed to NO since it should "only be testing followInheritance". Stylistic I guess.
We are using four spaces for indentation.
Very minor, but could replace `a` and `b` here with `first` and `second`, due to the use of `a` and `b` in talking about the ellipticities, and indeed `a` also being used for astigmatism below.  Three different meanings for `a` might be a little confusing...!
Thinking about this, the current `PoissonDeviate` is not much earthly use... It might be worth making it simply a `CCDNoise` with fixed `read_noise=0`.
So cacheListOfPolicies etc is only called once (i.e. in the constructor) and never again?
I should have guessed that given it's private...

Perhaps code would be a little clearer if the method was loasdListOfPolicies, returning the Set<String>, and the constructor assigned the returned value to a `private final` field.
But no strong feelings...
Do you need these getters, given the fields are declared as properties?
in effetti io uso Ruby 1.9.2 ma non dovrebbe cambiare. Versione di rake? rake --version
oui c'est juste que la commande rake plantait donc j'ai mis un truc simple pour commencer. effectivement il faut trouver mieux
I don't see corresponding code in this commit that processes this argument.

Is this argument used? If so, where?
> "There are both forward and back slashes in $SPLUNK_HOME. What system are you on?!?"

Windows. High-level IO libraries in Windows will silently convert / to \. I have seen mixed pathnames in production systems before (although not for Splunk).
I wish we can modify the content of dialer.js without rewritting the tests. A way of doing that would be to expose the panels via a Javascript object in dialer.js. Then you will be free to rename them as much as you want.

What do you think?
These are previous commits... I wonder why it shows up here...
Even if homebrew has this in the template: "configure: WARNING: unrecognized options: --disable-dependency-tracking"
Not sure if they're needed or not, so I just put them back
Yes, will fix. Thanks.
No need for the assert... should be able to call without assert and get exception. Same for the rest.
あ、ごめんなさい。Unitテストなら、Functionalテストの方がいいですよね。。。
Use :download: ?
I did, the i variable is no longer defined in the outer loop.
Is it possible to use the weights w if the object is inside a Pipeline or a GridSearch?
The top-level module is getting cluttered. Shouldn't this be in `sklearn.deep`, `sklearn.neural`, ...?
bien ! essaie d'y mettre le reste !
I don't believe ```Braintree:::CreditCard``` has this method, does it? 

https://github.com/braintree/braintree_ruby/blob/master/lib/braintree/credit_card.rb
I suggest making the prefix and suffix opaque. The automatic insertion of slash and dot are convenient but also make assumptions. This would also be consistent with how UrlBasedViewResolver's prefix/suffix properties work.
>> *(index[finger++]) = NULL;
>> In the above code I set the rowsToSort entry for the returned row to NULL (see line 3850).
> You're not setting rowsToSort entry to null, you're setting a copy of the ptr in 'index' to NULL.
> The original rowsToSort members are untouched.

I take it back, index are pointers to the points to rows.

so yes that line is setting rowsToSort member to NULL, indirectly.
Regular expressions are not supported with XSL 1.0 using Xalan.
Do we need to cope with super files within super-files?
This should be called `getAfterBurnerCommand` to make it clear what it's doing (getting the command rather than coordinates
Then maybe we could have `getInputCoordinates` that just returns the list [ input1, input2 , ... inputN ] for a point.

So I think maybe we'd have something like (I haven't tested this :P)
```python
def getInputCoordinates( chain, mfc, n ) :
    return [ chain.chi2vars[input] for input in range(1,mfc.Inputs+1) ]
```
That's a good example of how awesome list comprehensions in python can be :)  They're a really useful tool.

So Below is going to be two examples of a way of doing something, one using *one line* and one using many.  It's possible to write really long and complicated (hard to read) lines in python, so a lot of the time it can be better to choose to use multiple line
```python
AB_binary = "../bin/Afterburner.exe"

def getAfterburnerCommand( chain, mfc, n) : # this is overly complicated for one line
    return "%s 0 %s" % ( AB_binary, " ".join(  [ str(input) for input in getInputCoordinates( chain, mfc, n) ] ) )

def getAfterburnerCommand( chain, mfc, n) : #same function as above but "cleaner"
    input_coords = getInputCoordinates( chain, mfc, n )
    input_strings = [ str(input) for input in input_coords ]
    return "%s 0 %s" % ( AB_binary, " ".join( input_strings ) )

def getAfterburnerCommand( chain, mfc, n) : # same as above but combine the first two line
    intput_strings = [ str(input) for input in getInputCoordinates( chain, mfc, n) ]
    return "%s 0 %s" % ( AB_binary, " ".join( input_strings ) )
```
Which of these you choose to use is really down to you, I would personally avoid the first "one liner" - it's good to know it can be done in one line but it's quite hard to read :P

**Side note**: Above we're using a command called `str.join( list )` which takes a list and joins it into one long string separated by the string `str`, so if we had
```python
my_list  = [1,2,3]
my_list_str = [ str(item) for item in my_list ]
# my_list_str is ['1', '2', '3'] now
my_join = " ".join( my_list_str )
# my_join is "1 2 3"
```

If I'm telling you stuff you already know then I'm sorry :) Just trying to be a little helpful where I can.
Why? we should return an empty string only if  $options['decorate'] is true and there's an empty result.
а не проще было в этой секции просто подгрузить дамп? таблицы создаваться не будут т.к. они уже есть, а данные подгрузятся
Is there any support for %nick%, %id% in advanced regexps?
@christianv Removed comment.
The surrounding `if` is unnecessary, `(> (apply max (vals (frequencies (map (fn [x] (rank x)) hand)))) 1)` already has the wanted boolean value
We should ask him, but I'm sure he won't mind.  Do you know Pietro?  If not, I can make an introduction :)
This might not be obvious from the diff but the matrices here where not aligned and I aligned them (because I was looking at the file any way).
simfs??!? dude i didnt even see this in the docs when i was looking into mounting. it was bind bind bind. wow thats a ridiculously simple fix.
Add a test for `czm_frameNumber`.  For an example automatic uniform test, see `has czm_view` in [AutomaticUniformSpec.js](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/Renderer/AutomaticUniformSpec.js).
Let's make this private at file scope and pass in the `BillboardCollection`.
这个可以考虑和按键设定一起作为输入设定。
Do we need to support formats with the 'Z' suffix (which means UTC - see example at http://en.wikipedia.org/wiki/ISO_8601)? Also, do we know exactly what the server sends? If so it may be possible to cut some of those formats - having 1, 2, 4, 5 or 6 decimal places isn't that common: usually there is either 3 (JavaScript precision), 7 (100ns, or .NET precision) or 0.
wrench.js has been inactive (not just commits, but no visible communication) for months despite pending issues and open PR's.  Unlike the mysql inclusion, this is a simple command that does not require inclusion of a 3rd party module.
It might be better to call out that the child views represent "pages" as further API points below use the term "page".  I would argue that we should maintain consistent naming and stick with "page" throughout the documentation once the definition of what a "page" is defined.
In text, use "Release 2.0" rather than 2.0.0.
If I interpret this correctly then the DocBlock will remain with the node where it was found AND become file-level docblock.
As such you'd get a 'shared' DocBlock in case it contains @package and directly preceded anything other than a class.
https://github.com/justinstoller/puppet-acceptance/blob/f25bcd6305899a0dabbdccba52ee508a44d98d4c/lib/puppet_acceptance/options_parsing.rb#L312
should this be `skip_railties_install_migrations` ?
I guess it all depends on what the usage intentions are for those includes... If some of your javascript depends on external libraries to execute properly, would that cause a problem?
nit: `<code>` tags around the `=`
Sorry, I missed this before... 

`http://twitter.com/@leobetosouza` => `http://twitter.com/leobetosouza`


I'm being lazy, I want to be able to pull this straight in :)
Yes, but these conditional implementations are just too complicated, and are taking their toll on the compiler too. I'm rolling back.
By the way, do we have a policy on when to add one's name to the Authors list? Other open source projects sometimes require adding to the authors list when adding new top level primitives, so I did, but on the other hand, the additions are hardly very original…
Does it work with these:
jms:{destination}?deliveryMode={deliveryMode}&priority={priority}
xmpp:{user}
?
It's used in Panopticon for the rummagable artefact, it returns the parent tag object.
Very good! But can you please add two more '!' symbols to the end of the printed string?
Should we do an empty return, or at least return something? Maybe even Null? You might even consider throwing an exception.
Even if it's commented, this shouldn't be in production code.
Can we be sure that datarow and dict/dataset are the only possibilities?
![SIZe](http://static.desktopnexus.com/thumbnails/450517-bigthumbnail.jpg)
if you don't want to apply an inverse solution I would add an option "abs" or keep_phase that offers the possibility to compute the envelope here. Might be interesting to look at averaged power spectrum in sensor space... but if you're fed up we can keep it for later :)
such a construct needs more and structured white-space to be digestible
You need a DocRaptor acct for this.
ah no, sorry about the BC. I thought it was about allowing ``null`` whereas it is about hiding ``''``
The reason I used triggerHandler is b/c it returns the value of the last handler to run, so you can get the "return false" from an attached handler. I agree that attaching everything to Khan is a little weird, but I haven't tackled that part yet (not sure if I will, might just get the events split up first and then can figure out if we need to refactor the attaching pattern).

Namespacing is definitely not crazy. May pursue.
oops, I don't think it's needed since I have 100% coverage with the other tests.
Do we really want to put Google in? Bing with direct tile access looks good to me, but I'll be in favor of dropping Google of the light build.
I would delegate this to Mark since he requested the initial work for RedisStore outbound adapters, but yes since we supported injecting of the template all along we could avoid all that in favor of injecting a templet.
having said that there may be an argument where for conveniences (i may only want to override one serializer while relying on the defaults for the rest of the template configuration) it makes sense.
Not your code, but lines 510 abd 514 can be refactored into a single line (514 for both branches).
Fixed with 6b69e24
class > file
How about `not_templated`? `no_templated` sună greșit. Sau `without_template`?
can be instead of it's
Effectively, it seems not.
i have rewritten it. should be really easy to change in case of error now:

            $dom = new \DOMDocument('1.0', 'UTF-8');
            $dom->loadXML($string);
            $xpath = new \DOMXPath($dom);
            $list = $xpath->query($expression);

            // @todo: don't know if there are expressions returning more then one row
            if ($list->length > 0) {
                return $list->item(0)->textContent;
            }

            // @todo: don't know if return value is right
            return null;
line 1 va 2 ro delete kon
Please remove the empty line at the beginning of the methods for consistency (in both of them)
Greg wanted this to remain a part of the project, in the interest of ensuring the developer has good problem solving skills, as well as design and abstraction skills - you can't really build an unbeatable tic-tac-toe game without demonstrating those, or a lack thereof.
I was trying to avoid the small bit of overhead in cases where this extra information wasn't needed, but certainly could do, yes.
The EOF/EOR really needs to be the end of a capture group. An or is not sufficient as the EOF could very well be used inside the tag itself breaking syntax highlighting from then on. Separate the definitions if need be.
identifierForAdvertising to -> identifierForVendor ?
This can be shorted to:

this._xhr.setRequestHeader("UserAgent", lang.val(this.userAgent,Ti.userAgent);
this._xhr.withCredentials = (!!this.withCredentials).toString();

You may need to add lang as a dependency on this module, although it's probably already there.
`Disclosure`
What does releasing actually do though? We should probably be a little more explicit, i.e:

* Removes event listeners
* Removes any associated native Views or other content
New `ManagementFilter` minus `IndexPage`
there need to be another definition unit; think about it that it's required to find out if you mean weeks, months, ...
We updated the code and now use "dataDefRefForStep" on line 50 and 55.
This line looks odd. Why Citizens are resource no more after your patch?
Fixed, just use "rim:splash" as the property name
extra underscore for index.js, check markup