labofsahil/github-event-dataset-2012 huggingface dataset:
It's for performance reasons. I think this used to be a bigger deal before (See some older browsers http://jsperf.com/regexp-test-search-vs-indexof/2), but even now (searching in a longer string: http://jsperf.com/regexp-test-search-vs-indexof/8), it's nearly twice as fast.
Well. Since the timeouts are now static, the timeout values are for all ``Trade`` instances, I exposed this here as it makes more sense since this class will create every ``Trade`` instance. 

It makes it more obvious to set them via this instead of calling ``Trade.MaximumTradeTime=x... etc...`` in the ``Bot`` or elsewhere.
No!  blue is pretty! ;-)

seriously, though, easy enough fix.
You can avoid the function by doing `(TARGET_NUMBER === "smallest") ? FIRST_NUM : FIRST_NUM + (SEQ_LENGTH - 1) * DIFFERENCE`
Not sure I understand what's happening here with Biochemistry, Annotation and Mapping.
1. I think you always construct a biochemistry, but if you already have an associated annotation / mapping, how does the new bio get linked? Especially what happens if it doesn't contain the same reactions?

2. What happens if I provide an annotation but not a mapping? A mapping but not an annotation? Both? Niether?
taken care of
These still need validations, but wanted to get feedback before doing so
IE9 return me a error:
====================================================
SCRIPT600: Oggetto di destinazione non valido per l'operazione. 
fullcalendar.js, Riga 4655 Carattere 3
I think the real problem is here. This should be `rescue AbortError`, not `rescue Exception`. It looks like it (accidentally?) got changed in d8d20f7 /cc @strmpnk
I didn't think that i altered the indentation in any way. I thought i just put the comment in, however i must done it on accident. I will check the previous version's indentation.
Why we don't compare response.code with simple 200? Is there any reason? Anyway, I think that here ```response``` can be ```nil```.  Also if we should match all 2xx responses we can do it for example like this:

```ruby

if response && response.code =~ /^2/
```
Crap! Naming is alpha and omega of software development. 
What does this action mean???
FYI, ThinkUp supports assigning custom, per-view CSS in the controller. To do it, you'd take this whole block of inline CSS, put it in its own file, and then in the LoginController add the line:

$this->addHeaderCSS('assets/css/login.css');

Currently this change causes the custom header CSS test to fail (TestOfTestController::testAddCSS2Header) because you moved the {foreach from=$header_scripts item=script} bit into the else area.

I'm fixing now, but wanted you to know 1.) about the custom CSS assignment mechanism, and 2.) that we really have to get you running the whole test suite. :)
Добавлен. В дочерних классах никакой нетривиальщины с удалением нету, потому обошлись одним деструктором здесь.
нужно разделить по строчкам, а то плохо читается

и зачем тут дефолтное значение?
This is supported by 1.8.7 too.

```ruby
module MyModule
  OK = false

  def is_ok?
    puts 'not ok!' unless OK
  end
  module_function :is_ok?
end

MyModule.is_ok?
```
True. 
So you don't need to set it again... since that is done in reset_psi_ref_from_body().
This stanza, to me, has a code smell--it feels like we're choosing brevity over clarity.  I've made this same comment several times on puppet core code where we are chaining a ton of map/collect/etc. calls into one line.  If I were writing this I would either refactor into a few additional methods to improve readability and maintainability, or I'd add some comments explaining what I was doing.

That said, I also recognize that there are different philosophies on this sort of thing and that my background has led me to a particular set of opinions that are not universally shared, so I won't take offense if you disregard this comment... just feel like I should put it out there once or twice since I'm new to this team.

As a clojure noob, I've been trying to parse this for about 20 minutes now and still haven't entirely grokked it yet.  Not sure to what degree clojure noobs are our target audience as far as future maintainers of this code, but... :)
Totally right, good catch. Obviously this is missing a test. :)
According to the docs, exchange.publish takes a callback parameter?
Shouldn't these actually be `undefined` instead of `null` ?
Also, there is some confusion in the docs/function as to whether or not this is for all principals or only users.
This function should have a test. It is currently untested, and only executed when an error occurs in moveFile.
`exit()`?
We have a package called `util`, would it make more sense to place it there?
These are not files, are types. Error message is wrong.
I see whitespace after .desc :P
Extra comma here, are the dev tools not running JSHint correctly?
need space : `if ($this->ip_version($ip) === '4')`
And what about percent being negative?
Тем интереснее будет на него посмотреть.
создаеется 101  элемент, вместо 100
@mvmn Думаю, стоит. Если бы было иначе, то и мутировать нужно было бы не процент, а количество символов.
Нет необходимости импортировать Cell.h, так как он уже был импортирован в заголовочном файле Cell+Mutator.h
Twitching isn't really a synonym for spasming.
@adamabeshouse `'string' << 'other string'` concats
too much copy and paste.
@dahlbyk In fact, I thought about `InvalidOperationException`, but I'm not sure. It is indeed invalid, but I was trying to express the root cause of the invalidness.

I recently introduced the `GIT_EBAREREPO` and `GIT_EORPHANEDHEAD` in libgit2 for this very purpose.

In the end, the real question might be "would the clients of LibGit2Sharp deal differently with a `InvalidOperationException` than a `BareRepoSitoryException`"?
for raw_combo in raw_combos:
Since the spectrum is one at 4 and 8 with a transition bandwidth of 0.5, shouldn't the limits actually be:
Lowpass: 4-0.25
Bandpass: 4+0.25, 8-0.25
Highpass: 8+0.25
?
It seems lke that would make the linear ramp portion in the frequency domain sum to one.
Awesome! I'll have to think on how the above trick works, but I assume you've checked it. Once we have PLV and PPC, I think it'll be a pretty good representation of spectral connectivity options for folks.

One thing occurred to me -- is there an easy way to only test specific frequencies (e.g., using a DFT calculated for only a few specific frequencies, potentially by just using inner products with sines and cosines)  instead of using multitaper analysis? For people who use frequency tagging (e.g., SSVEP or ASSR/AMFR), it can be useful to compute the PLV or PPC at all locations in source space at specific tagging frequencies. It might not fit quite as a "connectivity" measure, but in theory such code could use similar mechanisms, such as the PLV/PPC classes once you implement them here. Just thinking out loud mostly, but I'll probably try implementing that type of functionality soon after you merge this unless it's easy for you to include (which I imagine it's not).
I would add a quick comment here to say why you're clearing out all the tasks
"run the command..." I think the structure of this sentence might be clearer as:

run the command ``copy-to-partition`` in the :file:`/home/jdoe/jobs` directory.
@ColinHebert, I suppose the redundancy is there in case you forget which VCS you are using.
@meh Call `ruby-info` in `preexec` then put `$ruby_info[version]` in the prompt.
isn't it part of PSR-2 ?
one extra `=` here
Use the `:method:` syntax here too.
Hey Kevin!

What do you think about the factories? These all seem to be missing now - possible that it's because of the new way of loading this configuration?

Let me know - and thanks!
It's in 89c8d117e756815333a0e46d387cd64a1f4d37ab
Then could you please fix this and add a test,
or do you prefer a pull request?
Don't use an open `rescue`. This hides too many errors.
the other alternative is to use split(";\n") here, which I kinda like
There's an extra `}` after `sortAttachBy`, can you get that fixed?
not just sugar, but the "overloading" (taking out the current value, replacing it with the new and then restoring the old on exit)
Почему ты так не любишь `const auto& = ...`? const же позволяет убедиться, что в дальнейшем ты это все менять не будешь ненароком.
Потом не лень зато ошибки разгребать будет.

Лучше напиши.
Э, но зачем так жестоко?
Меня больше интересует как сделать так, что бы диалог был сверху, но не
блокировал доступ к личкрафтам
No creo que esta página debiera ser del proyecto público. No debería verse.
why changing the debug mode ?
menu providers don't have an alias
Ah! ok, I thought you were referring to (deftest , I think it's actually about (copy-system-group indent.  I fixed it.
this alignment can stay on previous line
Insert space / CS
I guess that your shell is wrong. So your constructors are all wrong.
nu poți să scrii `form.select.open(field, **{'class': "field-%s" % field.name, 'data-placeholder': 'Alege o optiune"}) `?
work of dzil, i am not so OCD ;)
Is this change really necessary? The marshaller component is volatile, so a new instance is created (and its dependencies injected) on every start() anyway. And even if it wasn't, start() calls rewire(), which calls inject() as well.
What would be the process for getting something other than a snapshot here?
ExecutorService.awaitTermination?
Wouldn't a while loop be simpler here?
Do you think it makes sense to "recharge" the queue by a single element? Just wondering, I didn't get the full picture yet.
s/tread/treat
please use a strict comparison whenever possible (which is the case here)
While your there, would you mind replacing the slashes by using path.join?
Indentation on all of these is now squiffy. Would you mind de-denting the continued lines throughout.
For the icon image?
Isn't this equivalent to str(s)?
Actually this is really an array we send over here. The transformation into a list will happen right before the while loop: `tests = list(tests)`. If we want to change that and directly require a list as parameter I'm happy with but for now I will revert the description to `array` so that this is clear. For the array type see: http://docs.python.org/library/array.html
Игорь, при http auth имя пользователя попадет в PHP_AUTH_USER
Need to add a `null` value for the new `$files` parameter (after the array)
nm I see
I'm happy to see the end of this namespace! All these changes and the tests still pass? Or do we need to add some new ones?
Didn't we make incanter-charts a dev dependency at one time, so we didn't have monster incanter stuff cluttering up the jar file?

I never use incanter so I don't know about what's really necessary, just pointing this out.
@bp323 Please use single quotes here
The above loops through all of the AuthorizableIndexingWorkers allowing them each to decorate the doc as they see fit before the doc is added to Solr. Errors are simply logged such that a failing IndexingWorker will not prevent other workers (or the AuthorizableIndexingHandler itself) to do whatever they can to get the Authorizable's information into the Solr index.
Could you please add comparison with naive quicksort index implementation? This way we can get sure it works properly
ditto for these two
can you maybe move the TODOs to above the method as this just makes for a very long line which is hard to read
I'd prefer to have a helper that iterates over the tags/rules and only collects the data. then iterate over that data within the view and output the required format.
On its way - just discovered the others.
I think the easiest and most direct might be to also just use the body nil check here, so this could just be:
`unless params[:body].nil?`
Aside: Any idea where these spaces keep coming from?
Our coding style is to put a space between `if` and `(`.
Should the return type not be ``string``?
What is wrong (leftover from recent changes) is that raw is no longer an option, thus the line should simply be removed from the documentation. No need to change any code.
`obj[idAttr] != null ? obj[idAttr] : obj` should be `obj[idAttr] != null ? obj[idAttr] : obj.id || obj` in case a model is passed in.
what the f. what a href part? that's how the embed works as provided by rdio ...
encoding参数有用吗？
Can haz em dashes here?
``$app->getRequest()`` in fact. But the point is that the controller does not use the PHP engine at all (and so no ``$app``. But reading the code of the controller again, it appears that it is passed, as this file receives the current context, where the request has been added
This logic is hard to maintain due to duplication.

Recommend that the constructor add each (constant, non user defined) instance to a private static map that this method can use to lookup individual objects.
Do we expect this information to be useful to SDK users? If not, I would recommend changing to package access.
`validates presence` бы
What are those date fields?
(`node_location` comes to my mind.)
Create new variable `foursquare_user` for this data.

Can you also please describe in the comment what all fields are in `foursquare_user` and what they mean? Like for each field in its line. So that later on other developers can know what is provided if it will be needed.
I think it's too permissive, since people might accidentally forget to do the check.  We could pass an empty sequence as the default, which would force them to provide an explicit audience on every call to verify().
a simpler way to do this might be ```::JSON.generate(@attributes, a[0] || {})```
As I am re-reading the docs you might be right. They probably are keeping the default behavior to be the one prior version 51
That default to $1 has been there since 2007 with @codyfauser commit 
ce56e010dffea7331e85958825f3c18795ad22a7 Add currency option to Paypal and Payflow gateways
There might have been a reason for it but I don't know it.

I would love to remove these 2 lines of code but I don't know if somebody is expecting this behavior.
The api documentation has specific info with regard to 0 values that this code prevents to happen.

From: https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=developer/e_howto_api_soap_r_DoReferenceTransaction
    Set this field to 0 if the transaction does not include a one-time purchase such as when you set up a billing agreement for a recurring payment that is not immediately charged. When the field is set to 0, purchase-specific fields are ignored

On a second note:
There are a bunch of different expectations in the code that do not follow the API specs.
There are many calls that expects! more parameters then it's actually required by the api.
I am not sure what's the policy wrt those things, if it's to respect current behavior or adhere to the API docs
This updateError div is crying out for a directive. :-)
Das würde einmal bei onCreate reichen.
Used for debugging?
You can replace it then with:

```php
if (!$this->getDetector()) {
    throw new RuntimeException('To assemble an url, a detector is required');
}
```

(wat mij betreft is zo'n geval exceptie-waardig)
any reason to specify the last argument? It will never be evaluated. If it is evaluated, make a test for it.
I think it makes sense to catch errors in hooks and display them, yes. Having side effects on the watcher's life (killing it, retrying to run the hook, etc) is IMO not useful, and could lead to unintended behaviours.

My reasoning here is that if the logic can be enclosed in the code of the hook, then it will be handled there, rather than adding some extra code in the caller's to handle such cases.
Why not Parallel.ForEach?
Would rather not change this (now), not worth adds more merging horror downwards. Has quite a few references and the APIs are changing.

On dataset, I thought I had seen it being used, but I don't see it now either. But ci 168 is the requirement for the host, not really for the client? We have it since 11.10, I think 3 O Desktop versions back should be okay to rely on.
Macro hygiene: wrap in a `do { ... } while (0)`
I could go either way.  It seems to be common practice in nginx code to include these comments:

  http://lxr.evanmiller.org/http/source/http/modules/ngx_http_fastcgi_module.c#L1965
  http://lxr.evanmiller.org/http/source/http/modules/ngx_http_secure_link_module.c#L303
  http://lxr.evanmiller.org/http/source/http/modules/ngx_http_sub_filter_module.c#L664
`CurBody` dies, and then when `DistanceTo` attempts to retrieve it, `LuaObject::GetFromLua` fires a Lua error (LuaObject.cpp line 546). Unfortunately, this error uses a format specifier which Lua's formatting function doesn't understand. The same problem is latent in `LuaObject::l_isa`. From the Lua manual (for `lua_pushfstring`):

> The conversion specifiers are quite restricted. There are no flags, widths, or precisions. The conversion specifiers can only be '%%' (inserts a '%' in the string), '%s' (inserts a zero-terminated string, with no size restrictions), '%f' (inserts a lua_Number), '%p' (inserts a pointer as a hexadecimal numeral), '%d' (inserts an int), and '%c' (inserts an int as a byte).

And for `luaL_error`:

> The error message format is given by fmt plus any extra arguments, following the same rules of lua_pushfstring.
When I'm reading the code, there are many names that are not understandable without the book. 
For example, a brief summary of the terminology/names in the module docstring would be helpful.  (developer oriented to help understand the code)

missing description line
Hah! This is a good one. Encryption!
On Sep 21, 2012, at 11:15 AM, Mike Jarvis wrote:

> In galsim/lensing.py:
> 
> > @@ -199,39 +201,36 @@ def mypk(k):
> >          return g1, g2
> >  
> >  class PowerSpectrumRealizer(object):
> > -    """@brief Class for generating realizations of power spectra with any area and pixel size.
> > +    """Class for generating realizations of power spectra with any area and pixel size.
> >      
> Weird. Isn't doxygen ignoring our other underscore-prefixed classes? I thought it treated them as private and ignored them. I could be wrong though.
> 
Doesn't look like it's ignoring them to me.
I see -- getByCourse has the nice semantics.
App Secret shouldn't be on github
All of these annotation in brooklyn.entity.basic leads to a lot of stuff/clutter in the package. But that's not exactly the fault of this groovy->java pull request.

I wonder whether we should move it its own sub-package, or whether the annotations are even used (!). If they are not used in the brooklyn code-base or with any existing PoC/Pilot/Customer, we should see about deleting them.
What if apache2 is already running? Would we need to do a restart instead?
gone with existing throw NPE ... to me that is cleaner code, also more efficient now that i've concatenated prefix, suffix into the NPE ... but good idea to do it first
Good point. I don't have an answer - I will check the implementation. The current set of commands are designed to be helpful for testing / demos. I will clarify this aspect in a new pull request.
This assertion error will not cause the test to fail, I believe. Will it be called in a different thread from the test thread?
Delete this commented out code? Or at least include a FIXME for what needs to be done before it can be deleted?
* Pas con je rajoute
* Par contre non par ce qu'ils ont sorti une v2 recemment que j'ai pas testee et si ca se trouve ils ont optimise :)
* Non plus, j'ai hesite mais on s'appelle needforair et ca peut mal le faire. Par contre je vais faire reference a "une application ipad", bonne idee.
For this use case of FilterLogger, perhaps. Who knows what might happen in the future though?

Seems to me that either FilterLogger should be tolerant of any missing method for its "inner" logger, or for none of them -- but being tolerant just in the case of #warn is a bit odd.

Will see if I can fix it without touching right_support (or touching it systematically in any case).
80-columnify
мне как-то валера говорил, что он всегда в тестах привязывается к классам, и что это нормально, если они меняются и падают тесты ) привязыватся по id?
this client looks exactly like it should.. nice and minimal.  good job
@fabpot - Sure, will do.
You can write this as:
```
User other = User.findById(id);
```
I am talking about changing the text of the comment, not the underlying code :P
This is in `Database_MySQL` specifically to work around behavior in ext/mysql. Do you know if this is required for ext/mysqli?

http://dev.kohanaframework.org/issues/2416
Totally ;)
Argh. The problem with jumping between Scala and Java. Will fix.
Здесь возникает NullPointerException. И проверь остальные места на этот предмет.
Пробелы вокруг !=
[] не нужен вокруг одной лексемы. Т.е. \\s* == [\\s]*
They actually can access everything, as spells are passed an instance of HarryPotterSpells.
What happens when the registration id expires?
you can get images_count out of image_viewer after you've closed it?
and image_viewer.image_count doesn't work unless you've paged through all the images? (please explain the workaround in more detail.)
it should be ``>=2.1`` otherwise you forbid 2.1.0
+1 for implementing and benching both and providing a wrapper with a `method="auto"|"reservoir"|"selected_set"` parameter. "auto" should switch to the fastest method according to the `n_samples / n_population` ratio and the threshold can be set according to the benchmark results.
I have the code from stackoverflow (see ref) - I did a quick check vs. itertools.product - here is the result::

     n = 1000

    In [26]: %timeit extmath.cartesian2((np.arange(n), np.arange(n/2)))
    1 loops, best of 3: 3.41 s per loop

    In [27]: %timeit extmath.cartesian((np.arange(n), np.arange(n/2)))
    100 loops, best of 3: 11.5 ms per loop

where cartesian2 is ::

    def cartesian2(arrays, out=None):
        arrays = [np.asarray(x).ravel() for x in arrays]
        dtype = arrays[0].dtype

        n = np.prod([x.size for x in arrays])
        out = np.empty([n, len(arrays)], dtype=dtype)
        gen = itertools.product(*arrays)
        for i, row in enumerate(gen):
            out[i, :] = row
        return out

most of the runtime (85%) stems from the loop to fill the array - maybe there's a more efficient way to do it...
Hm it creates a mask so it is hard to use in the list comprehension. It is not used much, I could change it to directly return the masked array....
shouldn't this be ``random_state``?
err, yes
This is a problem we are likely to have for other parameters / estimators any way. I would rather not make the public more complex by adding not yet implemented options. So +0 for removing it for now.

For forward compat we should probably think of a serialization framework with a language neutral serialization format such as some custom json format or PMML: http://en.wikipedia.org/wiki/Predictive_Model_Markup_Language
The core -> a core
this should be 
  class { 'foreman::install': }~>
  class { 'foreman::config': }~>
to enforce the ordering. Can you add it?
History should be true, not perfect :)
Ah, yeah, there were some changes in cbedtools.pyx, give the `build.py` a shot
this is not a good way to handle dialogs. Activity.onCreateDialog and similar should be used. Alse the dialogs are leaking when Activities are paused/restored - for example when portrait/landscape is changed...
drawTrack
I'm not queit understood why we should follow the behavior on other platforms. Doesn't seem that android follows iphone or vise versa. The NarrowFormat and ShortFormat seems to be the same, which could be a bug also.
Otherwise we have to provide some string format for each format type, which probably not what user should suspect.
Then in the action something like `return new ViewModel(array('bugs' => $this->bugService->getRecent()));`
Uh. Infinite loop?
This is apple-only?
Whether an assert is better (read, easier to diagnose) than an exception depends on how you debug and how your program is structured. I generally find assert easier than assertex in Roxie, Gavin generally finds assertex easier than assert in the codegen. I think it may be down to personal choice...
Fair enough. I'm curious why deliberately not.
This should be clearing all instances of the files in cache...
And since you're always adding the "::", it doesn't have to be inside the IF block, but before.
when is it called? Should be compile time optional, i.e. only in debug? or via a runtime switch?
Roxie's impl. doesn't actually error if invalid at the moment:


        if (!RoxieRowCheckValid(cacheId, row))
        {
            //MORE: Throw an exception?
        }
you could simplify it by writing ``$hasLevelProperty = !empty($config['level']);``
This is overwriting self.url
yup -- nil is falsy
We are adding these settings for auth service, but these settings are quite generic and can be used by other components in the future. Let's rename them into es.transport.host, es.transport.port, and es.cluster.
see http://wiki.netbeans.org/MavenBestPractices#License_Header

Is this this @Wulfspider approved?
That was some old code while testing on files instead of urls. removed.
Ah, "unnamed" being the key ingredient here.. right. What about adding an additional flag for merging all children? 
I think the problem was that when a layout is enabled, but a JsonModel is not explicitly returned, the returned values fall under the 'content' key of the parent model and are therefore named. So, when using the JsonStrategy one would still have to explicitly return a JsonModel or call setTerminal (to avoid winding up with the data under that 'content' key)
Test - this is 2012
Ok done. Sorry for the delay, I was looking around, trying to make sense of some of the more complicated bits in there.
Also, we hsould add a convenience helper method on CloudTable to consturct a query against itself.
s/raring/rating
res can be null, and it isn't checked before accessing res.code and res.message in this else
FWIW, this test won't work because we had to yank OptRegexp.
I would break this line up. Postfix conditionals are difficult to read, especially on long lines.

Also, i think ```array.select{...}.empty?``` is better written as ```array.find{...}``` which returns the first element for which the block is true (instead of all of them), or nil if none.
Yes, I've already addressed that here:  https://github.com/zeknox/metasploit-framework/commit/073565c00182073cef04c730f51012a14eec8de6
Why not have the \n in the previous report good (or add the necessary ones if multiple are wanted)?
Yeah, I originally avoided that just because it was 4 lines instead of 2, but I think those 4 lines are probably just as easy to read as the 2 above. Plus, it's faster and memory efficient. Done.
I haven't dived deep enough into the IPython code to verify but the behavior that seems to occur is that, if available, IPython tries the _repr_png_ and _repr_jpeg_ methods first and if something goes wrong (i.e. errors are raised) there then it falls back to __repr__ automatically. So it wouldn't hurt, but it seems that this sort of  try/except is already built into the display protocol.

I guess we could raise a warning to the effect of "we tried to show an image but no dice" if the display protocol methods fail but only raise it the first time it happens?
I haven't actually tested on windows. The show function is there for the scenario the the cursor is on the bottom line of the screen before  the import is added. When the import is added the cursor is shunted off the screen. show moves it back to the middle. I took if off the html_completions.py in the HTML package. If it doesn't work it doesn't affect the import functionality.
Not exactly 60, but anything 60 <= seconds < 61.  A leap second is one second long.
Why use "false" as the value of the empty interval, versus null or undefined?
Since you already know the length, it's better to do `positions = new Array(length)` here and then use `[]` rather than push below.
In the constructor function, this is no longer used:
```javascript
this._clearState = context.createClearState({
    color : Color.BLACK,
    depth : 1.0
});
```
Why change "person" to "contact record" here, but not in the properties below, such as "address"? 

Since the object is called a "Person", it might be useful to offer a word or two of explanation here, like:

Represents a contact record for a person or organization in the system address book.

Or,

Represents a contact (a person or organization) in the system address book.

Or

Represents a contact in the system address book.

description: |

A `Person` represents a contact -- either a person or an organization.

Or words to that effect...
I would recommend using actual log levels in your logging instead of just prefix the word "error" et al. It's not necessary for this PR, but something to think about.
> I hope that doesn't change :) indexing into String is a nice feature.

It's just that indexing into a string can get you into trouble with unicode
surrogate pairs. For instance, Å can be written as one unicode character,
or as a pair of unicode characters. If it's written as a pair, then you'll
get into trouble when you do naive indexing.

-jj


On Mon, Nov 5, 2012 at 9:23 PM, adam <notifications@github.com> wrote:

> In web/file/terminal/Terminal.dart:
>
> > +    }
> > +  }
> > +
> > +  void updateFilename(String cmd, List<String> args, Function action) {
> > +    if (args.length != 2) {
> > +      writeOutput('usage: $cmd source target<br>'
> > +                  '&nbsp;&nbsp;&nbsp;&nbsp;&
> nbsp;&nbsp;&nbsp;$cmd'
> > +                  ' source directory/');
> > +      return;
> > +    }
> > +
> > +    String src = args[0];
> > +    String dest = args[1];
> > +
> > +    // Moving to a folder? (e.g. second arg ends in '/').
> > +    if (dest[dest.length - 1] == '/') {
>
> I hope that doesn't change :) indexing into String is a nice feature.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-html5-samples/pull/44/files#r2039029>.
>
>
You are correct on this. I will rip out the Name piece.
numerical values!
What's the purpose of the `flag` argument here if it's unused?
Note that the value 'angle' comes from the unit circle javascript file and is always in radians.
Some examples:
---------------------------
angle = - PI / 2
revs = floor( angle / (2 PI))
// revs = -1 is the result

angle = angle + revs*2*PI
// angle = - PI / 2 - (-1)*2*PI = 3 PI / 2
// 3 PI / 2 is same as - PI / 4 but falls in the range 0 to 2 PI

----------------------------------------------------------------------------

angle = 3 PI
revs = floor( angle / (2 PI))
// revs = 1 is the result

angle = angle + revs*2*PI
// angle = 3 PI - (1)*2*PI = PI
// PI is the same as 3 PI, but falls in the range 0 to 2 PI
-------------------------------------------------------------------

I think the logic works for any angle. It gives an equivalent angle in the range 0 to 2 PI. The behavior of 'floor' is the key.
No need to declare on one line if you're only going to use it once, on the next line. Just do:

`$shareContainer.find(providers[key].selector).attr(providers[key][$shareContainer.attr('data-type')]);`

You can newline it up if you feel it's too verbose.
nit: `x` -> `\times`
Again. No comma.
I wasn't entirely sure on this one. Will do.
Maybe CRC of Range? I'm not native speaker but 'to' somehow implies nondestructive conversion to me.
All tricky aspects as `TypeInfo` has lots of them.
I actually moved this sort from _get_inodes() to this function so that it is only done once (in the constructor), instead of each time we check if the file has been modified.  It's required because we're storing a list of inodes and checking them to see if they've changed.

I can add tests.
That doesn't really work, since the EKBCommit is part of the EKB-API 
bundle, which has only the API bundle as dependency, but would need the 
EKB-API bundle so that it knows about the EDBCommit object :-) Except we 
define that the EKB-API bundle gets the EDB-API bundle as dependency, 
but I don't know if that is really worth it. At least the user have then 
another dependency relation he needs to be aware of.

Am 2012-10-19 10:15, schrieb Andreas Pieber:
>>           try {
>> -            edbService.commitEDBObjects(commit.getInserts(), commit.getUpdates(), commit.getDeletes());
>> +            EDBCommit ci = edbService.createEDBCommit(commit.getInserts(), commit.getUpdates(), commit.getDeletes());
>> +            edbService.commit(ci);
>> +            source.setRevisionNumber(ci.getRevisionNumber());
> now that I see it... considering the law of diameter it might be a good idea doing something like source.alignRevision(ci). WDYT?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/784/files#r1887525
>
Finally i think this docs must be for symfony 2.0. there are to many change in 2.1 to have a doc working with this 2 versions.  

And i think 2.0 will use for more than one month, isn't it?

So could we try to make change with this in the idea...
just to clarify .. this filter is for security
i just had a look at the behavior in this part of the code.

$configuration just holds the values from the annotation which seems alright in the annotation only use case.
In case an actual View object gets passed inside the event listener it may hold its own groups, which i suppose should take precedence over anything passed through an annotation as it seems to be the more conscious choice.
The intended behavior in this case seems to be a more philosophically oriented question in this case.

I'd suggest checking for 
 ```php
if (!$view->getSerializerGroups && $configuration->getSerializerGroups())
```
if this is okay with you.
Changed the comment using description for the Dictionary<K, V> as an example (it says "initializes" instead of "creates", which is more correct).
do these values have any relationships to others already in the theme? like 8px for the regular padding, etc.
I'm paranoid about regex, so I usually like to see unit tests associated with a regex if possible.
Please follow the JavaScript style conventions of the project and indent after you open a curly brace.
Я рекомендовал бы обрамить внутренние if/else скобочками, ибо else.
Why "no underscores"? PHP itself uses two underscores to mark "magic methods" and there is also to habit from the old PHP4 days, that `private` and `protected` were marked with a leading underscore.
So does this mean that each htmlblock is independently autosaved? It seems like this type of autosave is different than the existing autosave, where we save it to ensure we don't lose it. This seems like it would create a ton of versions.
These would make nice decorators... :-)
I am actually going to push back on this.
We've talked about it before, MessageGroup is an *internal strategy* only to support many different implementations of MessageStore and MessageGroupStore. That is how we have 5 implementation of MS but all of them are using SimpleMessageGroup. 
We do NOT expect or recommend anyone to implement MessageGroup and that is why we allowed all the breaking changes that went in there in the past 6 month and this particular method was on my list of things to remove, i simply overlooked. 

Also. . .
Personally I consider it to be a bad practice to have any canDo() methods simply because typically they result in duplication since there is no way to check if can* was called which means its going to be called when do() is invoked, but that is a whole other discussion.
Why bother catching exceptions? Just put @Test(expected=BeanDefinitionParsingException.class). You are anyways not interested in the message of the exception, this is convenient and much less noise in the test case.
I agree, payloadExpression check here is redundant, but this code is actually executed and there is a test for it. It just 'payloadExpression' here is always null.

I'll remove it
query is uneccessary. Ldap authenticate will take care of finding and/or adding a user
I think these should probably be different from those in DoctrineORMModule
In GerritReviewersNotifier.Descriptor.newInstance() I make sure that no null will be passed to this constructor from the UI.
This defensive check is only to ensure that no null will be fed to it from unit test and so on.
Just seemed more readable, which can be a bonus in figuring out what tests are doing.
Maybe remove this change? Doesn't add anything to this patch.
memory change between PHP versions and machines
i wold keep legacy instalation metoh via vendors as subsection of step 1
The repeated calls to `count` make this O(n^2). Here's a O(n) version:
~~~clojure
(defn last-element [[h & tail]]
  (if (empty? tail)
    h
    (recur tail)))
~~~
here or in comments? I'm just mocking these methods
you should validate the values to allow ``true``, ``false`` and ``'auto'`` IMO.

and btw, as this bundle requires Symfony 2.1, you can do it very easily:

```php
->enumNode('orm_listener')
    ->values(array(true, false, 'auto'))
    ->defaultValue('auto')
->end()
```
Array, it's my fault .... :p
also needs the url to be in the format of:

https://www.paypal.com/incontext

instead of 

https://www.sandbox.paypal.com/cgi-bin/webscr
does that create go up to 11??????????? Thats awesome. D
Why would you ever use *EmbeddedListField* instead of *EmbeddedSortedList*? (Put this into documentation.)
If there's nothing left in the file that was being required then this line can just go away.
Cette feuille doit toujours être insérée en dernier. Je ne sais pas pourquoi, mais si ce n'est pas le cas, du padding sur le body fait que la navbar collapsed en mode phone n'est pas collée au haut de l'écran.
Je corrigerai ce point dans une autre pull-request.
> should = must?

not sure. @emmanuelbernard wdyt
I suggest renaming the ```PersonalID_list``` variable and ```create_PersonalID_list``` function to not encode the type (i.e. list) in the name. If at some point in the future you decide that the type will change (e.g. it becomes a set or a tuple), then you'd have to go back and change the name of this variable because it wouldn't be a list anymore.

The convention that I've seen is to name a sequence of multiple items the plural of what they are holding. So in this case, I'd rename ```PersonalID_list``` to ```personal_ids``` (since it holds many personal IDs). Likewise, I'd rename ```create_PersonalID_list``` to something like ```get_personal_ids``` (since you're not really creating personal IDs; you're just extracting them from the mapping file).
We could add optional `step` argument which defaults to `1`.
@sebap try this:

Capybara.current_session.driver.delete destroy_user_session_path

the other option is:

click_on 'salir'
rhythmbox crashes for tracknumber, duration, bitrate and rating. those appear not to be handled
seems like this code section could be encapsulated in a function
Avoid as much as possible the use of + to concatenate two strings.

If one of the two is nil, it will raise an error.

Instead use arrays and the join method.
it wouldn't replace the $.ajax call, it would make it look something like this:
$.ajax({ url: ecep.geturl("locationList"), data: options})

The advantage being that if the endpoint '/location/' ever changes, gets moved to a different server, whatever, we only have to change it in one place.  This is a rather trivial example, it starts making more sense when you have a bunch of variables that determine the url (ids, POST payload, query params, etc), and the url structure could potentially change in the future.
what exactly is the todo here?it's already not put into the map
`canceled` - The alternative is the British English spelling.
We really should check to see if frame is valid. On any non-identity rotation, the values we get back would be invalid or not even numbers.
describe the requirement domain generally
`getEntity` can return `null`. Extend `consumeEntity` to accept `null`s quietly?
What do you mean by `factory` here? Creating the SyncClientsEngineStage in the GlobalSession's constructor? :S
Hmmm.....I'm not sure what I'm missing. Unfortunately, I can't verify by running the script, since I don't have a Windows box. Let's sync up and run it together.
It will throw in case of invalid input format. Do we want to be more specific and tell the users that the we got an unexpected response from the authentication service?
`factory.get`
Why is not used `sn_core_hook` when is the name of the file `sn_core_hook.php`?
@croby Will do, I'll also change the color which should make it clearer that they need to change it.
can you please add the config to this so that every extension gets it.
`self._port = int(port)` ?
Ok i fixed it in last commit. It will require an rebase with ``--autosquash`` when the whole PR is OK for a merge.

Le 19 avr. 2012 à 21:44, Christophe Coevoet a écrit :

>> @@ -53,6 +53,30 @@ public function getMetadata($class)
>>         return $this->getEntityManager($class)->getMetadataFactory()->getMetadataFor($class);
>>     }
>> 
>> +
>> +    /**
>> +     * Returns the model's metadata holding the fully qualified property, and the last
>> +     * property name
>> +     *
>> +     * @param $baseClass The base class of the model holding the fully qualified property.
>> +     * @param $propertyFullName The name of the fully qualified property (dot ('.') separated
> 
> types are missing (``string`` for both)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/72/files#r709371
check any MD5 that is not null
tämä tekisi sen mitä alkuperäinen tehtävänanto halusi
Hmm, so it does. Is there any reason for it existing, though? Does it have functionality that isn't in other modules today?
Do we want the dictionary syntax on `RelatedContentManager` as well? It seems a bit unorthodox, and it wouldn't be used in a template anyway.