labofsahil/github-event-dataset-2012 huggingface dataset:
So now I ended with this code:

```ruby
if super
  @@delegation_mutex.synchronize { not @@compiled_delegators.include?(method) } ||
    @klass.respond_to?(method, include_private)
else
  Array.method_defined?(method) ||
    @klass.respond_to?(method, include_private) ||
    arel.respond_to?(method, include_private)
end
```

Thinking of the code, I realise another possible problem. What if:
* thread A: `super` is `false`, `Array#foo` is defined, so we will return `true`,
* thread B: hit `method_missing` and defined `foo` delegation to `@klass`,
* thread A: call `relation.foo`; but `@klass` does not respond to `foo` so we get  `NoMethodError`.

I think we should check `@klass.respond_to?(method)` in delegators like this:

```ruby
module_eval <<-RUBY, __FILE__, __LINE__ + 1
  def #{method}(*args, &block)
    if @klass.respond_to?(#{method.inspect})
      scoping { @klass.#{method}(*args, &block) }
    else
      # try to call another possible delegatiors (Array, arel)
    end
  end
RUBY
```

This problem is probably not related to this PR and caused by the fact that we define `@klass` delegators globally, but sometimes we should hit `Array` or `arel` instead of that compiled delegators. I'll dig into this problem shortly.
Good job on this one. Exactly what I was looking for! :clap:
Will it? I can't seem to induce this behaviour:

    scala> class C {
     |   def apply() = sys.error("!")
     |   override def clone = this
     | }
    defined class C

    scala> val c = new C
    c: C = C@20d10a

    scala> c.clone
    res2: C = C@20d10a

    scala> c.clone()
    res3: C = C@20d10a

Also, we don't have a parameterless `apply()` in these classes.

But, I agree that we should pick one form of `clone` and use it everywhere.
Now sure what the policy is here, but I would find things more readable with `CaseDef#hasGuard`; the `== EmptyTree` checks are very common.
I'd clarify the other throws as well
I believe this is SI-6722, please rename and push -f
Isn't it too specific?
It means there's some mistake in the toString logic of Comment. Yes, please correct it so that it shows all elements in the comment. AFAIK this shouldn't break any previous scaladoc tests, as I used the most specific member I wanted to check. But do run an `ant test.scaladoc` just to be sure.
macroDef.paramss.flatten.lastOption exists (_.isImplicit)
Good call!  Will do.
On Sep 26, 2012 5:08 PM, "Heather Miller" <notifications@github.com> wrote:

> In src/library/scala/StringContext.scala:
>
> > @@ -9,8 +9,44 @@
> >  package scala
> >
> >  /** A class to support string interpolation.
> > - *  This class supports string interpolation as outlined in Scala SIP-11.
> > - *  It needs to be fully documented once the SIP is accepted.
> > + *
> > + * Starting in Scala 2.10.0, Scala offers a new mechanism to create strings
>
> You could just move things around a bit and say:
>
> This class provides the basic mechanics for Stream Interpolation. String
> Interpolation allows users to embed variable references directly in *
> processed* string literals, for example:
>
> val name = "James"
> println(s"Hello, $name")  // Hello, James
>
> Any processed string literal is rewritten as an instantiation ...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scala/scala/pull/1409/files#r1700690>.
>
>
Firstly, I need to change the default to bicubic. (which is the IDL one)

however IDL by default doesn't use bicubic, aiaprep uses it but not IDL rot() actually I am not sure what the IDL default does, but I am not sure it matters here. It matters in aiaprep but not here.
You should be able to skip all uses of datetime in the tutorial because both vso.attrs.Time() and query_legacy() will accept the tuple directly (since they call sunpy.time.parse_time() )
It appears that you are putting a space at the beginning of the string...I would understand a space separating terms, but why is it being added at the start?
Are you saying to wrap the test? Or is it the output that should be wrapped?
`subs` sounds like the imperative "Substitute!" to me.  Maybe it will be better to call this function `make_subs`, to stress the fact that it actually produces another function which does the actual substitution?
would `all(ci in c for ci in _c)` short circuit faster?
This needs to be // to work correctly in Python 3.
s/Attempt/attempt/
The old method left for backward compatibility.
It's applied here: https://github.com/resurtm/yii/blob/aa3a9ab27d1d8ac6fe04611f618ea9f84282702e/framework/db/ar/CActiveFinder.php#L594-595
Missing `:` ;)
As @mikesherov said in the outdated diff, this is incorrect if #431 lands.
Images don't have an end tag.
I'm not sure how the implementation of `runLoggingCallbacks` is relevant. `QUnit.init` and `QUnit.load` themselves are not in the callback queue. Look at the source code.

Calling `start` directly from the `begin` callback will not work as at that point neither `init` nor `load` has complete, but the next tick after the `begin` event both `init` and `load` are finished.
I have corrected it. Before I took the disp command from oc_butcher....

On 19 May 2012 23:33, David Ketcheson <
reply@reply.github.com
> wrote:

> > +  tau(6) = (b'*diag(c)*A*diag(c)^2*c - 1/24)/6;
> > +  tau(7) = (b'*A*diag(c)^3*c - 1/30)/24;
> > +  tau(8) = (b'*diag(c)^2*A^2*c - 1/36)/2;
> > +  tau(9) = (b'*diag(A*c)*A^2*c - 1/72)/1;
> > +  tau(10) = (b'*diag(c)*A*diag(c)*A*c - 1/48)/1;
> > +  tau(11) = (b'*A*diag(c)^2*A*c - 1/60)/2;
> > +  tau(12) = (b'*A*diag(A*c)*A*c - 1/120)/2;
> > +  tau(13) = (b'*diag(c)*A^2*diag(c)*c - 1/72)/2;
> > +  tau(14) = (b'*A*diag(c)*A*diag(c)*c - 1/90)/2;
> > +  tau(15) = (b'*A^2*diag(c)^2*c - 1/120)/6;
> > +  tau(16) = (b'*diag(c)*A^3*c - 1/144)/1;
> > +  tau(17) = (b'*A*diag(c)*A^2*c - 1/180)/1;
> > +  tau(18) = (b'*A^2*diag(c)*A*c - 1/240)/1;
> > +  tau(19) = (b'*A^3*diag(c)*c - 1/360)/2;
> > +  tau(20) = (b'*A^4*c - 1/720)/1;
> > +elseif disp('Order condition for p>5 not implemented')
>
> This line doesn't seem to make sense.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ketch/RK-opt/pull/28/files#r849815
>



-- 
Matteo
yes will do.
listDomainMembers -> listReportsForPair
Thought I'd got rid of all that. Thanks

On 25 Jul 2012, at 08:10, Ben Hood <reply@reply.github.com> wrote:

>> @@ -0,0 +1,396 @@
>> +/* @group Base */
> 
> Is the chosen css still being used?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/196/files#r1232687
I don't think this affects the test, but the name should be "a3" instead of "r3" to avoid confusion.
Attempt to combine these sentences/paragraphs. Maybe this makes sense to turn into a seealso block?
this kind of sentence is incorrect/abstruse: it says "copydb supports authentication" in 17 words (and is missing an article.) It also puts the most important part of the sentence at the end.

Putting the important parts of a sentence at the beginning makes documentation easier to read, and more likely to convey the right message to users who aren't reading carefully (which is a a safe assumption to make of *any" reader.)
Que vaut `isActive`? Si `isActive` est égale à *active*, n'y aura-t-il pas deux `li` de classe *active*? Ceux des lignes 36 et 39?
Let's add a comment here to explain what reference count is and why it exists.
"A" vs "the" IMO articles can be removed from all of the docs.
This was not done.
This PR is now against olympus, public won't work.
Mysql specific sql should be in the mysql dbal. Wouldn't you agree?
No big deal, but the parentheses can be removed and it will still be evaluated as a boolean conditional. Looks a little clearer to me personally.
`str_repeat()` ?
not in the PR.
I think this event should be outside of the </li> and there should be one before the li?
it should never be I don't think. Otherwise we wouldn't have emitted a message event.
fixed... using the virgo.version export now.
Ruby 1.9 has json in the standard library.  The json gem is only needed for 1.8.  I would advocate making qless 1.9+ only.
I don't see any reason about moving the import statement.
Furthermore, using a wildcard is not really a idea.
Also: if ```providerSent === null``` ,  Should you throw an exception or do something more serious here? How bad is the error?
Is this a TODO? I don't see any checking of login credentials going on. On that note: can you re-use existing login (https://github.com/Raxa/Raxa-JSS/blob/master/src/app/controller/Session.js), or do you need a separate login for CHW?
Neither is top-left!
Flip the data here.
Ignore that - it's in summary and makes it easier to find things at glance.
...directory contents of $path
`repr`
Good point, I'll tighten it up.
You cannot have that import here. Only work on frozen models. If somebody runs it in 5 years time the CI model might be totally incompatible.
Сейчас путь зависит от `process.cwd()`. Лучше заменить на: `PATH.resolve(__dirname, '../test/....')`
yes, just silly, fixed below
I'm not sure I like this dependency/coupling.  I would be more comfortable migrating the call to the timer into App.cpp.  The XML file loader shouldn't need to "know" anything about a cyclus core class like the timer.
I checked closer for what other people do, here's what I'm going to copy:

```ruby
if ::RUBY_VERSION < '1.9'
```

If it's good enough for drbrain, it's good enough for me.

https://github.com/tenderlove/mechanize/blob/master/lib/mechanize/monkey_patch.rb#L15
Future note, consider adding an option for splitting up all data sent by a cowboy_client. Would be an excellent way to make sure that this always works for every request we make from the test suite.
No tasks for quantile calculation are spawned. However, I have just changed
both conditions

2012/9/13 Lars Butler <notifications@github.com>

> In openquake/db/models.py:
>
> > +
> > +        realizations_nr = self.ltrealization_set.count()
> > +        imt_nr = len(self.intensity_measure_types_and_levels)
> > +        return realizations_nr * imt_nr
> > +
> > +    def should_compute_mean_curves(
> self):
> > +        """
> > +        Return True if mean curve calculation has been requested
> > +        """
> > +        return self.mean_hazard_curves is not None
> > +
> > +    def should_compute_quantile_curves(self):
> > +        """
> > +        Return True if quantile curve calculation has been requested
> > +        """
> > +        return self.quantile_hazard_curves is not None
>
> Can it also be an empty list? If it is not None but it's an empty list,
> what happens?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gem/oq-engine/pull/874/files#r1598840>.
>
>
You're right, my mistake.  What about `WEBVTT_SUCCEEDED` too match `WEBVTT_FAILED`?
On the first point, I'm saying that the anonymous function passed to `setTimeout` should not have any parameters, but instead close over a `var self = this;` defined in the outer `preDispatch` function.

On the second, my intuition was wrong, but you can still save 27 bytes by replacing `function fixFocus() {…` with `fixFocus = function() {…`, 5 from moving the `fixFocus()` call to the very end, and 6 from rearranging `jQuery.event.dispatch` variables (a total of -38): https://github.com/gibson042/jquery/compare/orkel:12569...gibson042:orkel_12569
A related question -- what is `Meteor.http._encodeString(true)`?
Ultimately they should be as close to this http://www.mono-project.com/Coding_Guidelines as possible. I know not all files meet this criteria, but that is what we are aiming for.
Shouldn't this be `#{prefix}`, so that it is installed into the Cellar?
Should this commented out line be here? It appears to do nothing except set the key separator to the default?
The `BeautifulSoup` import should be made local so that users are not required to install it
Can we also test that the current global is not seen in lib1's or lib2's global ?
This should use `timedelta.total_seconds()` rather than `timedelta.seconds`.
Funky indents. Not a blocker, we should reformat the entire file to two-spaces to match once this gets merged in.
I don't think this is valid to checkstyle
This assert is not needed :) I normally also put many asserts but in this case I would say that it should be fine to leave it out.
Just use a ``std::vector<uint8_t>`` then you don't have to remember to ``delete [] buffer``
target_host is btw. now defined in cdist.TestCase already, so it can be reused from there - fyi - can fix this later as well
Tested, and it didn't work, strangely enough. Just attempted to run the img task and then closed the process altogether without any errors.
这个我表示不能相信……build-dep的意义就在于把烦人的依赖统统装上，而build-essential是r-base-dev的依赖。
https://docs.google.com/a/singly.com/document/d/1PzvbkDRIT8ua7UbAzvMbxfi-8epH1QMG8ZO9OWyRFtc/edit

It doesn't say anything about ' vs. " at present, my pattern is to use ' except for when the string contains a ' because double quotes are way more prevalent than apostrophes when concatenating HTML, for example.
Out of curiosity, what is at [0]?
I wrote this before Joel's plugin code landed. My intent was for quick open to make this "interface" public so a new plugin could call new on this and then register by passing an object rather than the bag of functions. Do you think I should go with this approach or keep the bag approach I have now and fix the documentation?
typo "noe" to "no"
No reason, other than I copied the code from the about dialog. :-)
Is there an open issue to allow file tree to take focus?
`measure` is no longer used I think.
jasmine-html was the standard reporter. We use a custom BootstrapReproter now, so jasmine-html is unused. We never used the jquery utils in our specs, so I removed it.
``{function (*, *)}`` since compareFn could support any type?
it looks like this will fail if the person doesn't have permission to edit commcare users. isn't that a problem?
i'm just trying to follow rapidsms style. i don't think rapidsms lets one handler interrupt the entire processing chain. we can configure the logger to nofity appropriately (email, etc.) while still continuing processing.
You can define development, test, and production groups. We want sqlite3 for dev/test and pg for production.
Won't this loop infinitely if you continue here?

Because you aren't updating the `end` value.
actually, `pulley.oauth` instead of `github.oauth`.
Alright, I think you should ignore me.  It looks like these objects are coming from a cache inside libgit2, so we probably don't need to do anything wrt memory management in this case!  Sorry for the false alarm! :-)
Add libraries to our own libraries so that things work also locally. And if website will run under HTTPS.
Put this as the last context processor so that we can override values if needed.
shouldn't this class be mokeypatched when we require redcarpet instead of every time that the render is needed? I see after `require 'redcarpet'`:

```ruby
require 'redcarpet'
class Redcarpet::Render::HTML
  # monkeypatch here
```
This is a completely separate issue, but I suspect these properties in BIDPOM do not work. I think we actually need `get_attribute('value')`. We should have tests for these properties, and fix them if needed.
True. Just seems like the labels are way less standardized than name,, but I guess it doesn't really matter
Spaces, opening/closing brackets.
Why bother checking if newStart is true? Does this do anything?
Oops. not here.
I don't think you need to set `configurable` for each one of these entries. It's set to `false` by default: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/defineProperty#Description
Oh! Very nice. I caught myself doing that a couple of times.
I should add some normalization for width. For top and left, negative values are ok.
yes I know, it would be right now, but possibly not in the future. that's why I split up the pvr and epg stuff (except for the gui, which still assumes everything has a pvr channel)
interesting!  typeset -f is just about the only 'stable' behavior I've seen across platforms for the typeset command.

might be an interaction with a shell option you have set...

I'm running:
GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin10.0)
Copyright (C) 2007 Free Software Foundation, Inc.

could you do the following for me?

```bash
bash --version
shopt
```
Why do you need `--projects`? Maybe a one-line description would help.
You are absolutely right! And caught a bug :) Base64.URL is base64url encoding and not base64, so I will fix this
Some of these don't seem to be tested, worth adding a few specs
So bootstrap uses the pagination class if you're showing page numbers. Otherwise they suggest using the pager class in the ``<ul>``.

I didn't particularly like the pager class, so that's why it is the way it is now. Regardless, I think if you want to change it, you should change it to the pager class rather than the pagination class since we're not showing links for pages.
Rrr... That's twice that I did this.
You can simplify this with something like:
mkisofs_cmd=`which mkisofs || which genisoimage` || fail "Sorry, The cdrtools is not installed (or in your path)"
Figured.
I think it would be better to
```python
parser.add_option('--name', dest='name', required=1, help=_("architecture name"))
# and concat "(required)" at the end by the method 
```
That was original behavior. I suppose the reason for that is in how exceptions are used. Models are saved/updated with '!'  in controllers which raises InvalidRecord exceptions. There is now way right now how to distinguish between simple invalid data from user or invalid record created by developer mistake. In my opinion the first should not be persisted the second should be. Because it cannot be distinguished I would be for logging all of these notices. What do you think @bbuckingham ? 

IMHO: this is related to two other problems.
Exceptions are not handled properly
``` ruby
def an_action
  @user.save!
   # do ok
rescue => e
   # do ko
end

# should be
def an_action
  if @user.save
    # do ok
  else
    # do ko
  end
  # no rescue here, any other error will be handled by #rescue_from 
end
```

Validations in models are used for validation of data inserted by user which is correct. But validations are also used for ensuring data consistency. I feel the later should be ensured by callbacks raising exceptions because inconsistencies are a developer error and responsibility.
this is just about readability of the html source code, right?
can you new this once and pass it in for all?
you should typehint the Pusher argument
Should it be 'any real'?
Sure, I forgot it.

Oscar

El 05/07/2012, a las 18:12, jao escribió:

>> @@ -107,6 +109,21 @@
>>     RUNNABLE: "RUNNABLE"
>> }
>> 
>> +def _is_valid_remote_url(value):
>> +    """Says if given value is a URL
>> +        with scheme, netloc and path
>> +        or not."""
>> +    #if not isinstance(value, basestring):
>> +    #    # Must be a string
>> +    #    return False
>> +    #url = urlparse(value)
>> +    #if not url.scheme or not url.netloc or not url.path:
>> +    #    # Invalid URL: a host address or path is missed.
>> +    #    return False
>> +    #return True
> 
> can we please remove the commented out implementation?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bigmlcom/python/pull/4/files#r1106180
done
On Aug 20, 2012, at 8:18 AM, jao <notifications@github.com> wrote:

> In CONTRIBUTORS:
> 
> > @@ -0,0 +1,9 @@
> > +Thank you to all who have contributed to this project!
> > +If you contributed and not listed below please let us know.
> typo: and are not listed
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
If we're getting all this from github, we shouldn't need to worry about any of this. Also, email regexes are bad.
My god... is that was is necessary to recover from BDB? Manually parse the hex dump created by a library?

I want to get rid of BDB yesterday.
If I leave this setFocus(), signFrom is NOT focused, but I guess @laanwj should verify my code then.
there shouldnt be any extra spaces
Should this be DING! modules?
You are assuming here that `$namespaceVersion`  is an int, right? Maybe a cast is required.
these tags are deprecated and support for them will be soon removed.
if key.isEmpty
I think `request.path` should be `rstrip()`ed too, otherwise it won't work for everyone using slashes at the end.

Furthermore, many content types do not work without a slash at the end (at least those with `<form action=".">`) and there is no easy way around that -- we cannot rely on request or context available for example in the contact form template. Because of this I'm a bit hesitant to merge this -- these changes aren't sufficient if we want to advertise that FeinCMS works fine with `APPEND_SLASH = False`.
Just do

```
+            Trace.WriteLine(String.Format("[{0}] {1}", DateTime.Now , "Authentication of remote " + Id + " on TFS server..."));
```

How long it took to authenticate is not useful.
Space after and before the `if` statement's `()`.
can \@XmlElementWrapper save us?
Please delete the commented-out code throughout the file.
Would be nice if braces are on it's own line.
Running in multiple threads for faster delta creation.
If we disallow levels below 0, we can use -1 to signal for that, and use that as a signal to use the first entry in the vector (seeing how they're sorted an' all).
Well, it looks like we are pretty inconsistent across the library right now.

**External APIs**

* `git_reference_foreach` returns 0 if the callback returns < 0 with for a packed ref and returns -1 if the callback returns < 0 for a loose ref (which just seems like a bug to me).
* `git_branch_foreach` just calls `git_reference_foreach` so it inherits that behavior
* `git_config_foreach`, `git_status_foreach`, and `git_attr_foreach` return what the callback returns if it is non-zero
* `git_diff_foreach` return what the callback returns, but only if it is < 0
* `git_note_foreach` returns -1 if the callback returns a value < 0
* `git_odb_foreach` is a mess. It always returns 0 regardless of what the callback returns. It always iterates over all backends regardless of what the callback returns. Returning <0 while in the loose backend will stop further callbacks to loose objects. The return value of the callback is ignored completed in the packed backend.
* `git_remote_ls` will return -1 if the user callback returns < 0, but the git and http transports call `giterr_set` and the local transport won't.

**Internal APIs**

* `git_path_direach` returns -1 if the callback returns a value < 0
This doesn't close the modal, it binds the events for closing it. This should be part of the `createModal` function.

You might also consider adding the modal stuff as a hidden element on the page so you don't have to keep binding all these events over and over, and just show the modal instead of re-creating it.
I wondered if these long heading and preamble strings would be better set in variables, and then the variables passed into build_table(), or is that just unnecessary obfuscation?

Also, maybe "title" and "description" would be clearer than "heading" and "preamble"?
This line and the previous lines have an extra space before the last =.
Yay! I never liked that.
i'm a little worried about adding too many arguments to this function.

i think it may be better to have a single 'options' argument:

```javascript
createSimpleToolbar: function(toolbarSel, textareaSel, options) {

var defaults = {
cannedResponses: false,
privateMessaging: false
}

var options = $.extend({}, defaults, options);

...

if (options.cannedResponses) {
    buttons.push(new Marky.Separator(),
        new Marky.CannedResponsesButton());
}
        
if(options.privateMessaging) {
    buttons.push(new Marky.Separator(),
        new Marky.QuoteButton());
}
```
This is a bit off-topic but I thought I'd share...

I once wrote a plugin for django that would symlink static images so that they get unique names. E.g. 'images/foo.jpg --> /tmp/foo.1345691923.jpg` That means you can cache it forever since the URL is tied to the files modify timestamp.
What happened sometimes was that I would get weird OSErrors saying that the symlink didn't exist. This is in regular "thread safe" code with a single process. Granted, it's a single process but apache might have made it "concurrency-complex". Debugging it was hard because the symlink always existed when I looked. Basically, the errors happened when the code, very shortly after the symlink was created, needed it and depended on the symlink having been created. 

Long story short, what I found was that the filesystem probably treats writing files differently from creating symlinks. Almost as if it syncs differently. 

I don't know if that helps AT ALL but it's a valuable piece of experience and I thought I'd share just in case.
these tests make me happy :smile:
Should we also allow integers here?
fixed typo there: changed
`True if valid, false if not` ?
@niklasf Then the `$autoDisposition` name isn't correct (it implies a boolean value, which would lead to an exception).
should be ``public static``
It makes sense to add them to both getStatus() and isTerminated(), but isStarted() should be fine since run() and start() will set status and check is only against != STATUS_READY.
what do you prefer .. that i move the closing parenthesis on a line of its own?
i just think the current one line for everything is unreadable.
the description should be on the same line than the ``@param`` annotation, not on the next one.
fek konam baz be range ghermez tavajoh nakarden :D
ina remove shodan va alan to file styl hame ro dorost neveshtam :)
什么问题？
meshFromOFF.cpp
This breaks the blessed matplotlib alias kwargs (```fc``` vs ```facecolor``` vs ```facecolors``` etc.). I have already broken that elsewhere (natural earth shp I think) but it is worth noting this, so that when we decide to do something about it, it is easy enough to find...
ah, good to know. thanks.


On Wed, Dec 12, 2012 at 2:47 PM, Mark Lavin <notifications@github.com>wrote:

> In aremind/static/css/style.css:
>
> > @@ -570,6 +587,8 @@ body .reports-info-content input[type="submit"].btn,body .reports-info-content b
> >  body .filter-form{display:inline;}
> >  body .sitename{background:rgba(255, 255, 255, 0.7);border-radius:5px;-moz-border-radius:5px;-webkit-border-radius:5px;padding:5px 10px;font-weight:bold;font-style:italic;}
> >  body #reports-table{margin-top:20px;}
> > +body #branding{display:none;}
> > +body #tabs{display:none;}
>
> This CSS file is generated from the corresponding style.less file. If the
> styles should be removed then they should be removed from the LESS.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/WBNigeria/pull/37/files#r2392444>.
>
>
Yup.  First ran into it because the test suite uses a plain `Array`.  Originally I just stubbed it out for the test suite, but then I got to thinking and remembered seeing stuff sprinkled through the code base for non-AR stuff, and figured I should code more defensively.  The point of that `unless` modifier is to ensure that we don't trigger the loading of the collection on an AR collection if it hasn't already been loaded.
Whoops, trailing comma.
I think this should be False :)
Same comment as here https://github.com/jbossas/jboss-as/pull/3199#discussion_r1779100
Minor - This second line just overwrites the value set in the previous line. You could just get rid of the previous line.
Out of interest, why change to `protected` ?
yeah, you are right , guess this test was pointless. I will fix it and let you know.
But then if someone writes a new supervised cost function and forgets to override the constructor, it will still raise an error when the cost is called. Would it be an improvement over raising the exception at instantiation?
Изменил логику на users.id. Заодно перебазировал бранч на последний мастер

Смотри последний коммит в бранче - там только изменения в соответствии с новой логикой. Если всё устраивает, то обязательно скажи - я солью последний коммит с коммитом, который исправляется тем последним и перебазирую опять (для красивой истории коммитов).

Если не устраивает - говори что именно.
Is not better to run this script before we build the profile? So we dont have to unzip, we just go directly to the source dirs and save the time of unziping
I’d rather drop the `dayNames` array and use this kind of localized strings:

```properties
dayOfWeek-0=Monday
dayOfWeek-1=Tuesday
dayOfWeek-2=Wednesday
dayOfWeek-3=Thursday
dayOfWeek-4=Friday
dayOfWeek-5=Saturday
dayOfWeek-6=Sunday
```

…and replace `dayNames[i]` (line 41) by something like `_('dayOfWeek-' + i)`. What do you think?
You know I'm sexy and I know it... :-ppp Thank you!
nit: please remove the two trailing spaces
On 04/07/2012 16:26, Etienne Segonzac wrote:
>> @@ -114,6 +121,15 @@ var Recents = {
>>   
>>       var self = this;
>>       this.history(function showRecents(recents) {
>> +recents = [
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +  { date: Date.now(), number: '+33686834379', type: 'missed' },
>> +];
> Did you left this just to see if I was really reviewing? :)

Oups!
if the array above declares selectors i.e. '#xx'' instead of  ids, we could remove this code and use the same mechanism as above, right? of course we would need to change also getElementById by querySelectorAll but that approach will save us from some lines of code
Yes, it's true.... We need to let it readable for all developers.
remove the leading `#` signs please
Oops! Glad it was not anything embarrassing. I'll remove that.
var hour = d.getHours() % 12;
      if (!hour)
        hour = 12;
OK, Done.
yeah i just copied that from flicks :)
yes, it's possible. I should fix that. Not trivial, but should be fixed.

The one thing though is that it won't be possible in our use of jwcrypto, because we'll call addEntropy. But I'm guessing that doesn't make you sufficiently happy :)
Need to type hint receive-queue to avoid reflection.
We added these lines in early July as part of an effort to correctly set the hostname and domainname for nodes in all OS instances (some of which use simple IP addresses like 127.0.0.1 and 127.0.1.1 for their loopback addresses, others of which were found to use more complicated schemas (including multiple loopback addresses).  This block of code covers all of the possibilities (setting the hostname correctly in all of the appropriate places).  I'm hesitant to go back to a simple one-liner like this...
It is probably a matter of taste. I prefer test names to start with "should", but I can omit that to make all test names consistent.
misspelled should (sholud)
This turn out to be a pretty strange return value. {ok, [{module, M1}, ok, {module, M1}, ...]}

Better to return either just ok, or a list of only the modules that where actually interpreted
So, I'd prefer not to move toList and mkString to FoldOperations because they do make sense in a non-sorted situation, but they are just slightly faster if we don't care about ordering. I'll just pay the cost every time (PS: these methods kind of suck because they don't actually "Reduce" anything, they just rotate a bunch of tuples into a single tuple, which has often caused OOM problems when misused).

So, paying the reversal in every case is probably not going to increase our cluster utilization.
I was skeptical about this initially, but now I think that keeping all the maps/flatMaps/filters in one chained flatMapFn is a cleaner implementation. It's not just the optimization of only doing one Each. This is actually easier to read.
Yeah not entirely sure how to proceed here. Let me think about it some more and I'll get back to you.
Would be nice to know where these numbers came from as well
NOTE: File is not in sync with latest Mirage version.
Where in that case ?
'i' was also being used to generate the text line numbers (up on line 1306).  So I think we need a separate var either way:

* we could keep 'i' and add another var that counts how many inlines we've passed, and then add that count to 'i' when setting 'normalNode(I)' (or later in the childNodes[] expression I suppose)
* or we have separate 'lineNum' and 'childI' type vars as here

I like the latter because the meaning of the two vars feels clearer, but OTOH it does change the existing code a tad more.
See above about ticket.errors[:connection].any?
Yep, I've discussed with them verbally but will open a ticket for them now.
My inclination would be to handle backwards compatability at a higher level (at the public API level). So `BuildMaster.addChange` rather than here. And `Change.fromChdict` rather than `getChange`.
I fixed this separately.
Should this actually be a single test? I'm not sure I like having test dependencies like this.
Casting to array? I see a cast to string here.
`'dist' === $source`
To easy the life of people expecting to have a consistent behavior among all supported browsers?
All static/global vars are initialized with zero by the compiler. Since BUTTON_RELEASE is zero too, the entire loop is  redundant. Please remove.
I definitely should start learning Ruby :) Updated and squashed.
Gabe,

I agree. That's why I didn't add the ck directory to our repo yet. We want to include it as a sub module so that it updates automatically, just like you said. I created an issue of this a while ago and mentioned this in one commit. I'll take care of this after our upcoming deadlines next.

Best,
Qi

On Sep 16, 2012, at 5:09 PM, Gabriel Parmer <notifications@github.com> wrote:

> In src/components/Makefile.comp:
> 
> > @@ -4,7 +4,7 @@ IMPLDIR=$(CDIR)/implementation/
> >  INTERDIR=$(CDIR)/interface/
> >  LIBDIR=$(CDIR)/lib/
> >  MANDITORY_LIB=cos_manditory.o
> > -CINC=-I./ -I$(CDIR)/include/ -I$(SHAREDINC)
> > +CINC=-I./ -I$(CDIR)/include/ -I$(SHAREDINC) -I$(CDIR)/include/ck/
> We need to figure out how to do sub-repositories, so that this actually just checks out the updated ck code. We don't want to have to keep ck up-to-date manually.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Don't use `assert` in unit tests. Use the helper functions like `self.assertEqual(comment.votes.count, -1)`.
Can't we just return a boolean here? Why do we need a model class for this?
is 1000 a timeout?
so will this load rules from both db _and_ files if configured?
I don't think it is, static functions mean they're not 'extern', so can't be called from other source files. "static inline" inlines the code and the function doesn't even have an address. We use inline only for performance critical code, which this clearly isn't.
No `@packaging` is required although naming is pretty bad :( Somethnig like `@configuration` maybe better. As of `@loader` I have explained above why it's a bad idea to dispatch it in a notification, not to say that `@loader` before was exposing loader module not an instance.
Some comment before `p
I don't see any particular issue with long name, especially when it matches an existing ES5 method name.
Just my opinion, but this seems backwards to me. 

If generating warnings when people use deprecated APIs is the best thing to do, that's what we should do. If we get problems because we're using deprecated APIs, we should not use deprecated APIs. If for some reason we have to use deprecated APIs, we should suppress the warnings when they're due to SDK code using deprecated modules.

We should choose a policy based on what's best for our users, not based on what's easiest for us to achieve.

Also, I don't think we should signal deprecation by the modules' position in the tree, a point I've made before: https://bugzilla.mozilla.org/show_bug.cgi?id=793926#c7. If we're using metadata to indicate deprecatedness, it's redundant to use the file location as well. Also, I may be wrong, but if we signal deprecation by file location, then we have to move modules when we deprecate them, and won't we then break anyone who uses them? (unless we hack cfx each time).
@benadida - I agree 100% with what you are saying, but that is not what we are doing here.  If you cannot reach BigTent and Google is not yet its own IdP, we currently have a hard failure mode.

The above digging around does bring up a corner case that I do not believe we are handling (not just for BigTent).

I have not verified this yet with a test, but from a code examination I believe a failing corner case is possible.  If a user creates an account using a primary email, their account has no password.  If their IdP is not available when the call to address_info is made, address info will return with "type: secondary, known: true".  The front end will then show the password field for the user to enter their password.  The account will have no password.  The user will be stuck in limbo without knowing why.
@lloyd - @jedp took care of the rounding on the backend.  We can do it on the front end as well.
Hmm, I don't see enough of the new design to understand, but will take out the TODOs.
Damn. I was really hoping they get off from this gecko branch. :(
Yes, but this is not a bad thing.
We mount explicitly this directory which is not a bad things.
In fact this directories are inside the rootfs, so it already mounted, but if we success to have the rootsfs mounted in readonly, we would need this.
removed useless code (the if block) :D
Instead of matching against the value of `JMXPort == undefined` just directly match against `JMXPort`.
I guess you are disabling all tests that require mysql?
We spoke to Jordi about this one already, and he indicated that "zend" is not necessary, as it's in the "description" field already.
`@copyright` and `@license` are not needed in class docblocks
If `modified + lifetime` is older than the current timestamp, it should be less than, no? The old code looked like it would delete active sessions.
CS: move opening { to next line.

Also, not sure if we need both attribs and classes -- "class" is itself an attribute. That said, I'd make classes the third argument, and fetch it from attribs if none defined. Make attribs and classes optional.
Remove the initial slash
Since the corresponding change the Bukkit (the API) is added in 1.2.5-R2.1-SNAPSHOT, CB also has to update to use that version of the API to work properly. I had assumed this would need to have been done anyway, but maybe I'm missing something?
It doesn't do it in production mode. I don't think we have any duplicates there. It's a development issue I hope.
Wrong title :)
Ok. Lähettäjän tietoja ei kuitenkaan voi hardcoodata lomakepohjaan.

On 19.11.2012, at 9.50, Sami Luukkonen <notifications@github.com> wrote:

> In inc/functions.inc:
> 
> > +					{RC003;{$toim_postino} {$toim_postitp}|}
> > +
> > +				 	{PC004;0070,0380,1,1,A,00,B|}
> > +					{RC004;{$ot_yhteyshenkilo}: |}
> > +
> > +				 	{PC005;0070,0430,1,1,A,00,B|}
> > +					{RC005;{$ot_puhelin}: |}
> > +
> > +				 	*** VAAKAVIIVA ***
> > +				 	{LC;0070,0450,0920,0450,0,2|}
> > +
> > +				 	{PC006;0070,0490,1,1,G,00,B|}
> > +					{RC006;{$ot_lahettaja}|}
> > +
> > +				 	{PC007;0070,0535,1,1,A,00,B|}
> > +					{RC007;Mercantile Group As|}
> Voit miusta jättää ton kommentoimisen kokonaan pois, jos ne ovat luokkaan tuota.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
this should be ``mixed`` as well
Adding: ```OPT_DEFAULT = 0```
Just added this :)
`index is 0` will work as a quirk of the Python implementation (singletons for common values), but is not in the language spec.
why camel case here?
Theirs default implementation send this, thats why I added it here.
I think it's good here to show the different ways to log messages and create exceptions. There should probably be a comment though indicating that this is verbose for the reasons of the example and it's generally no recommended to recreate exceptions or log exceptions that are being thrown. Kind of a disclaimer I guess :-)
Doesn't this line negate the following line, and possibly the preceding lines (unless it's MySQL which doesn't support transactions for schema changes).
Where does this get turned off?

It won't set it to false in the event, as if( time.seconds !== currentTime ) { stops that.
What did you think of my comment on this on the previous pull request (https://github.com/stripe/stripe-ruby/pull/27#r865057)?
ah, forget that :) i see below
can host be nil? below you use host.try(:id), whats the difference in scenario?
I agree that in order to change an instance you need to power it off, but my question was if it make sense for the user to power it off first and only then you could edit it?
hehe. have you been hit by the new pep8 rules?
Thanks for the feedback Greg, I'll take a loot at it again.
Andrew

On Sat, Apr 7, 2012 at 12:50 PM, Greg Weber <
reply@reply.github.com
> wrote:

> > +jobs mx a = do
> > +  sem <- liftIO $ newQSem mx
> > +  sub $ modify (\x -> x { sJobsSem = sem }) >> a
> > +
> > +-- | Run the `ShIO` task asynchronously in the background, returns
> > +-- a Promise immediately, see "getPromise" and
> "Control.Concurrent.Future".
> > +-- The subtask will inherit the current ShIO context, including
> > +-- current task count.  This means that if the asynchronous task
> > +-- also calls background the max jobs limit must be sufficient for
> > +-- the parent and all children.
> > +background :: ShIO a -> ShIO (F.Promise a)
> > +background proc = do
> > +  state <- get
> > +  promise <- liftIO $ F.forkPromise $ do
> > +    waitQSem (sJobsSem state)
> > +    result <- shelly $ put state >> proc
>
> It seems better to avoid `liftIO .. shelly (put state)`, going down to IO
> and back to ShIO and instead figure out how to compose or monads proper or
> alternatively use an MVar as in runFoldLines.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yesodweb/Shelly.hs/pull/3/files#r657927
>
> This is so because xcodeproj is nil as there are no xcodeproj files in the current directory. However if config.integrate_targets is set to false an xcodeproj should not be required. If I'm correct, it only affects the xcconfing files that in this case I would generate as a convenience.
>
> As related note, currently pod install fails ungracefully if there no only an xcodeproj file in the current directory (dirname called on nil). I think that it should raise a pod informative.

Aha, I thought I had tested the code with no xcodeproj in the current directory… Apparently not :)

> I will change the hardcoded path (simply return the path variable) and return it relative to the xcodeproj.dirname if available.

Yes, that sounds better, thanks.
Huh, so it is. *removes offending commits*
Shouldn't have to specify a default value by assigning an instance variable on initialize
When you use a `When` or `Then` you can continue using the same command without saying so using `And`. Use `And` in this case.
shiznits
Not sure that this comment is required, the code is fairly self explanatory.
@pbras : No, the database backend is only used in ezpublish context, not
for serving binary files :smikey:
Le 10 déc. 2012 12:03, "pbras" <notifications@github.com> a écrit :

> In kernel/private/classes/clusterfilehandlers/dfsbackends/mysqli.php:
>
> > @@ -32,6 +32,16 @@
> >
> >  class eZDFSFileHandlerMySQLiBackend implements eZClusterEventNotifier
> >  {
> > +    /**
> > +     * Max number of times a dfs file is tried to be copied.
>
> sorry, didn't explain properly. there is file config.cluster.php that is
> there to duplicate the the file.ini settings, since the cluster stack
> doesn't use .the ezINI() settings(eats too much performance) the best place
> to put them is not an .ini setting, is a declaration in the
> config.cluster.php (the config.php-recommended has the description to
> create the file when setting the cluster).
>
> in versions <4.7, i guess they should land in the index-cluster.php(and
> we're going to need backports all the way to 4.5)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ezsystems/ezpublish/pull/517/files#r2362504>.
>
>
Is this necessary here? It doesn't seem like it's being used.
You should probably assert on the content headers before decoding.
Doh, github markdown renders my markdown comment. :) Anyways, the warning about external code can be in italics or something else that draws attention to it.
Permissions checks should definitely happen in the API method, not the REST endpoint. This ensures that other services calling the internal APIs directly have the appropriate permissions checks as well.
Can you add a TODO here as well ?
This `` collection.$Trait`` looks suspicious. But I may be missing something
These regexes are intended to mirror the ones used by gitolite in order to maintain parsing consistency.
Did you try if this works?
Ruby use the symbol ` to run specific command in a subshell. Converting the ` to ' will probably break all the staff.
Did you test this?
@philsturgeon Managed to figure out a way to test, and I've updated the logic.
Мы же про программирование сейчас не ?
пасиб, исправил...
Завтра уже, я спать. ;)

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
by convention the classname should be TestSupportFile since the filename is test_support_file.rb
sorry, i was messing about trying to add the effect to the liquid supplier.  i don't think i got it to work so thats why its like that.  o well, i will fix it tomorrow probably.

On Dec 13, 2012, at 11:53 PM, Andrew Hill <notifications@github.com> wrote:

> In common/logisticspipes/pipes/PipeItemsLiquidSupplier.java:
> 
> > @@ -66,7 +67,6 @@ public void endReached(PipeTransportItems pipe, EntityData data, TileEntity tile
> >  		while (data.item.getItemStack().stackSize > 0 && container.fill(data.output, liquidId, false) == liquidId.amount && this.useEnergy(5)) {
> >  			container.fill(data.output, liquidId, true);
> >  			data.item.getItemStack().stackSize--;
> > -			
> should there be something here?
> either that, or the import above might not be needed...
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Hardcoded. These keysyms do not have a define somewhere?
TODO: change this to be >= 0.x < 1.0
voce não precisa utilizar URL absoluta se o seu path começar com /assets
And I think we've had this argument as 'subject' elsewhere for consistency.
I'm pretty sure the connectivity code assumes the connectivity matrices are in COO format.
This is a class method, it is not necessary to return self.

An option could be to have a copy parameter, if True a cropped version of Epochs is returned, otherwise it is modified in-place (liked done above).
I think as long as the datatypes are the same, it should be the same as before. In whichever manner "alpha" is represented in double floating point, my understanding of double arithmetic is that alpha / alpha will always yield 1.0. If rows_norm is epsilon smaller than alpha, then it should get set to alpha by the maximum(). If rows_norm is epsilon greater than alpha, then shrink should not be zero anyway. I'll have to double-check on that division, though...
check for err before doing anything.
Can you also document this in the "Local configuration" section of the readme?
Q (https://github.com/kriskowal/q) seems like a better fit for promises in node.js, it also has some nice promise implementation for delay/timeout.
Is there a reason to leave commented English translations?
That's the way it's already written in existing code snippets; my line is even shorter than those ones. Do I really need to deviate from them and break this line over several lines?
I think the security context should be mentionned earlier as it is the common entry point. Your code will generally never use the AccessDecisionManager directly
the above 2 lines should be removed and a file comment can be added
>Step through the Twig...
时间周期
时间段
Параметр-то переименуй. Олсо, @param странный какой-то, возможно, Entry to update?