labofsahil/github-event-dataset-2012 huggingface dataset:
We will need to explain better this paragraph, because it is explaining about the confirm dialog but we are only talking about the `:data` key.

@vijaydev any idea how to improve this?
Ruby 1.9 is required, so this line may be removed.
This is the key change.  "sym.owner.isPackageObjectClass && sym.effectiveOwner == qual.tpe.typeSymbol" limits it to recognizing symbols which are defined in the package object itself, excluding any inherited symbols.
What about annotating annotations?

    // use
    @(deprecated @nonFinal)

    type deprecatedNonFinal = deprecated @nonFinal
    type deprecatedInheritance = deprected @nonFinal
    type deprecatedOverriding = deprecated @nonFinal
Also, this would be a wonderful place not to do this:
```
Option[(Tree, List[Tree], List[List[Tree]])]
```
Instead,
```
case class Applied(sel: Tree, targs: List[Tree], argss: ArgLists) { }
Option[Applied]
```
That would be a big improvement even if you stopped right there; but at least as useful is the bonus of being able to write methods on Applied (or pick a name) which do the more common of the various select/apply/params/args manipulations which we are endlessly reimplementing.
nit: you use both Foo* foo and Foo *foo. I actually prefer the former, but do we want to just allow both and move on with life?
latex the {1, 2}
python -> Python 

(below, too)
So what happens when I ask for a point that isn't defined in this reference frame? Do you have error handling set up for that? Or does it just get handled by the Point class?
You import `sqrt` but do not use it in the example.
890 assertions for PHP 5.2
892 assertions for PHP 5.3+
Well, someone could set distinct to false. (Meaning passing all possible arguments)
I'll make the suggested changes and separate the scale tone functions.

On Wed, Jun 6, 2012 at 6:59 AM, Rob Buskens <rob@buskens.ca> wrote:

> Yeah... it was a previous pull request. I had cancelled it.
> I'll work on it a bit more and resubmit.
>
>
> On Wed, Jun 6, 2012 at 6:54 AM, 0xFE <
> reply@reply.github.com
> > wrote:
>
>> >
>> > -  var c_major = music.getScaleTones(
>> > -      music.getNoteValue("c"), Vex.Flow.Music.scales.major);
>> > -  var values = ["c", "d", "e", "f", "g", "a", "b"];
>> > +  equals(music.getScaleNotes("c","major").join(),["c", "d", "e", "f",
>> "g", "a", "b"].join(),"c major");
>> > +  equals(music.getScaleNotes("d","major").join(),["d", "e", "f#", "g",
>> "a", "b","c#"].join(),"d major");
>>
>> This file does not belong in this pull request.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/0xfe/vexflow/pull/60/files#r935122
>>
>
>
We'll need to show the values in order to avoid the uninitialized variable error we were getting. Not sure how secure that would be.
We assume loaded plugins have no dupes - I guess this is fine because it could only have been loaded by another plugin manager, right?
а почему не превратить в `dict` и просто `json.dumps`?
try change the 2*B to B...does that work?
I don't like this loop. Can you change this to
    if !@question.solutions.where{(is_visible == false) & (creator == my{present_user})}.first.nil?
and then remove the loop? (might need to pull upstream/master if squeel is not installed)

Actually, do this in the controller and pass this as a variable, e.g.

    @unfinished_solutions = !@question.solutions.where{(is_visible == false) & (creator == my{present_user})}.first.nil?

And then in the view:

    <% if @unfinished_solutions %>

etc
It looks like the reason for the visibility of getSQL has gone away during the patch - back to protected?
I think the word local should be literalized `local` rather than in quotes.
the seed list *only* affects the replica set initiation the first time, it's not ideal to recomend that users put a seedlist in their config files since the seedlist will remain in the file forever, but only has any impact if this option is set before the set is initiated.
Checkout `$request->header()`.
The order of arguments should be consistent with _add_permissions as much as possible.
The function returns null, what would be the point of that?
Should probably be wrapped into `if (!empty($styles))`
Not completely random, but padding wrongly applied. IMO, if there's a search for a padding, then  it should be before the `=` and not after.
Based on the merged pr https://github.com/phpbb/phpbb3/pull/881 the above should probably be changed to:
```HTML
<!-- INCLUDEJS {T_SUPER_TEMPLATE_PATH}/template/forum_fn.js -->
```
Why is this variable defined twice exactly the same? You should remove the definition on line 1039, since as far as I can tell it's not being used in the event.
Calculate `time() - self::MAX_FILE_AGE` once and store it in a variable.
Return value isn't documented.
Guys - you need to make your minds up and be consistent - I'm not going to add, remove, add, remove these functions over and over, it's a waste of time :P

My take is this is a version jump and with the inclusion of events/hooks/etc. the entire "mod world" will be tipped upside down regardless. Likewise if this change goes in _all_ existing templates using the {PAGINATION} token will render absolutely nothing unless peeps specifically go into the code and change all the calls to phpbb_generate_template_pagination back to generate_pagination. So why keep the old function around? It's pointless. 

But I'll do whatever you guys want - just make a decision.
you need to destroy the stream and then call ensure_retries. An error doesn't mean the stream ends necessarily
Wait, is this going to do this on every startup? What happens if the eths are reordered on some boot? Will we write out a different uuid?

I think it should just be a flag like monitoring-rackspace --generate-agent-id that an admin runs once.
hmm. looks like this falls through to a reconnect?
I am unsure, I did not change the line but Github seems to have modified it by itself. Can you undo specific linechanges?
Will move, rename, and document.
Not strictly related to this PR, but as above you are relying solely on name again. ```cube.coord_dims()``` explicitly uses metadata comparison, and does not require the coord be on the cube, only that one with the same definition is. ```src_dims = cube.coord_dims(column_coord)``` should do the job here.
Please include the standard comment.
Why this change? I thought the triple quote should be alone on its line.
Similar issue with this ValueError.
It returns the first column of the csv file. Which is the key id column in this example. It is used by the client.
Yes, for now. Paul is creating a ticket to improve this limitation.
Hey Benjamin, sorry - meant to do this but got busy. If you want to submit a pull request with the changes discussed ill gladly pull it, thanks.

Sent from my iPhone

On Jul 18, 2012, at 11:24 AM, "Benjamin A. Petersen"<reply@reply.github.com> wrote:

>>             animate = animate || this.options.animate;
>> 
>> +            // var keyword to avoid global!
>> +            // var tag = $(tag);    
> 
> Alex, would you like me to do anything else to this? I can cut my comments out & clean up the items you mentioned so it is a clean commit.  
> 
> Benjamin A. Petersen
> ben@benjaminapetersen.me (mailto:ben@benjaminapetersen.me)
> linkedin.com/in/benjaminapetersen (http://www.linkedin.com/in/benjaminapetersen)
> facebook.com/benjamin.a.petersen (http://www.facebook.com/benjamin.a.petersen)
> twitter.com/#!/bapetersen (https://twitter.com/#!/bapetersen)
> Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
> 
> 
> On Wednesday, June 27, 2012 at 9:50 AM, Ben Petersen wrote:
> 
>> Good call Alex. You are right.
>> 
>> Benjamin A. Petersen
>> ben@benjaminapetersen.me (mailto:ben@benjaminapetersen.me)
>> linkedin.com/in/benjaminapetersen (http://www.linkedin.com/in/benjaminapetersen)
>> facebook.com/benjamin.a.petersen (http://www.facebook.com/benjamin.a.petersen)
>> twitter.com/#!/bapetersen (https://twitter.com/#!/bapetersen)
>> Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
>> 
>> 
>> On Wednesday, June 27, 2012 at 11:49 AM, Alex Ehlke wrote:
>> 
>>>> animate = animate || this.options.animate;
>>>> 
>>>> + // var keyword to avoid global!
>>>> + // var tag = $(tag); 
>>>> 
>>> 
>>> 
>>> However this should never be undefined unless there is a programmer error, since `tag` is required, and so this will always bind to the `tag` parameter passed to removeTag. So no need for `var` here.
>>> 
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/aehlke/tag-it/pull/82/files#r1061040
>>> 
>>> 
>>> 
>> 
>> 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aehlke/tag-it/pull/82/files#r1188738
I'd used the -1 in there to differentiate that case from the `ok` clause earlier.  I'm ambivalent about which to use, repeating 0 or using a unique -1.  Opinions?
s/view/views/g
Try `:class:datetime.date`
With the comment below, this would be unnecessary..
Actually Mozilla is using the "transitionend" event. I've seen documentation for mozTransitionEnd, but for Firefox 4 that wasn't firing. Probably makes sense to just pull the mozTransitionEnd event from dispatcher… what do you think?

Thanks,
Chris


From: Ben Combee <notifications@github.com<mailto:notifications@github.com>>
Reply-To: enyojs/layout <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tue, 18 Dec 2012 08:36:13 -0800
To: enyojs/layout <layout@noreply.github.com<mailto:layout@noreply.github.com>>
Cc: Chris Patalano <chris.patalano@palm.com<mailto:chris.patalano@palm.com>>
Subject: Re: [layout] Fixed: (#114)


In list/source/List.js:

> @@ -96,7 +96,8 @@ enyo.kind({
>               onRenderRow: "rowRendered",
>               ondragstart: "dragstart",
>               onflick: "flick",
> -             onwebkitTransitionEnd: "swipeTransitionComplete"
> +             onwebkitTransitionEnd: "swipeTransitionComplete",
> +             ontransitionend: "swipeTransitionComplete"


Does this also need the mozTransitionEnd handler? I saw you added it in the enyo diff.

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/layout/pull/114/files#r2450959>.
Woops, good catch.
I have just updated the pull request. Now the region_constraint constraints a geographical region on a sphere and not on the cartesian plane. Now region crossing the international date line are handled correctly
Yes it should.  I'll have that fixed soon.
You can have a single overload  `inline overload infixOperator(forward a, #OP, forward b) = forward ..OP(a,b);` instead of separate ones for no- and single-returns
`posY = curCSS( elem, "backgroundPositionY" ).split( rmultiplebg );`
To be safe, you need to slice this `core_slice.call(arguments);`
It has a bug if we group by svec (see the jira: MPP-18127. Caleb ask me open to you when i show this bug two weeks ago :)).
However, according to the test, the time for this operation is very less, compared to the total time.
Done. use the following code.
```sql
NULLIF(NULLIF(btrim(fval, ' '), '?'), '') as fval
```
On Android it won't be necessary since it doesn't do anything on background
contexts.

Could Android tell the TextureCollection a slot is dirty if it does
anything with a texture due to a background thread?
Since this pattern set is based on 'fjord.base.views' (line 7), you don't need to give a full path to the view. You can just say (the string) `'monitor_view'`, and the import statement on line 4 isn't needed.
Sorry, to bother you again. It's my fault. This line should be:
```ruby
  depends_on 'flex' => :build unless MacOS::CLT.installed?
```
because the Command Line Tools for Xcode ship this. Indeed, I can also locate this inside of Xcode but in a PATH we don't add to the `-I` list. So easiest is to depend_on flex for Xcode-only systems.
alos should be also
Ha. Was writing HTML this morning. Oops.
If we don't add allow_tags=True Django will sanitize anchor tag in admin list display.
it seems these three lines can be merged: `if (length(e) == 0 || inherits(e, "srcref")) return(NULL)`
Rename to CauseMatcher, or HasCauseMatcher?
Could we find a way to not repeat the String.format() everywhere? Perhaps a private version of createTestDescription that takes all of the parameters?
Yeah. Here I would just use `key`.
entity should never be null here. If it is, that points to other problems.
I'm not Atom expert, but my money is on NBC weirdness.
Let's take out the emphasis here now.
There is no way for the browser to get the current working directory of the brackets instance without using the Proxy. Using the proxy, however, requires an asynchronous call, which is not appropriate here. Using "." works on unix systems. Not sure how to fix this for Windows platforms.
Ah, thanks for catching that. It was unecessary.
Note that we can use the hostEditor's lineSpace here now because the new scrolling mechanism in v3 still has the lineSpace always be the full height of the virtual document (instead of just a small window around the viewport as in our original version).
fixed all those cases. Good find!
I'll move the regex test up into `_convertToNormalRGB()`.
Typo. not "a the specified platform"
It looks like setSelectionRange() is pretty well supported (FF, Chrome, IE 9), so to simplify things maybe we should just use that?
That sounds a bit fragile, then. Do you think we can do better, with UI or a TCP connection that waits a bit or something?
you have to keep `*` 
or change several [occurrences of `*`](https://github.com/ajaxorg/cloud9/blob/69d334df3d5c0d07a3f3ef609b5e253ef11b7861/plugins-client/ext.code/code.js#L200) bellow to `^` and handle conversion of user settings
don't think we need to say "(generally) monotonically increasing" again, ie can just say " ... using these identifiers" ?
This also doesn't quite make sense any more since it changes per query instead of per session
Cool, glad that just worked, painlessly?
I chose the *Impl, naming because of my Java background but from a quick google search, I think in Objective-C calling them delegates are more appropriate? However, `XMLRPCDefaultEncoderDelegate` sounds terrible and `XMLRPCDefaultEncoder` sounds great to me.
Can we inline this ie if !(location = ...)
double quotes around style please.
What is this block for? Is there not a callback we can use instead?
By default, the Salt master listens on TCP ports 4505 and 4506 on all interfaces
Just pushed another workaround, what do you think? 96bf85e
Remove this log from here
Any reason for these to not live under the dashboard resource declaration with the others?
And it is already in katello-repos, so this is redundant.
Same thing with overloads.
Sure. Again, I haven’t changed any value: I’ve just extracted the `webapps` array into a separate JSON file.
This should not be a header
I stylistic suggestion you can take or leave: I generally find it easier to do e.g. ``from cosmology import *`` and then in ``cosmology.py`` put ``__all__ = [Cosmology, kpc_comoving_per_arcmin, ...]`` - then you can immediately look at ``cosmology.py`` and see what's in the "public" API instead of having to look at two separate files to figure it out.
This sentence is a bit ambiguous - is this stating that they *should* (e.g. sort of a code guideline), and does it apply to affiliated packages? (I'd say yes to both)?  Moreover, you might want to strength in to say that they should only use this and not other ways of printing (except for command-line scripts, which should of course use print or stderr or whatever they want)
We should use intersphinx references to avoid hardcoding urls in the Numpy documentation.  This one would be

`masked array <numpy:the-numpy-ma-module>`

since the label for that part of the Numpy docs is `the-numpy-ma-module`.

See http://sphinx-doc.org/latest/ext/intersphinx.html
We should probably set at 4 until we have a filter on the fallback preflists to ensure node uniqueness as long as possible.
Is it?

*Before*

```js
var mkdirs = exports.mkdirs = function(dirpath, mode, callback) {
    path.exists(dirpath, function(exists) {
        if (exists) {
            callback(dirpath);
        } 
        else {
            mkdirs(path.dirname(dirpath), mode, function() {
                fs.mkdir(dirpath, mode, callback);
            });
        }
    });
}
```

*After*

```js
var mkdirs = exports.mkdirs = function(dirpath, mode, callback) {
    if (existsSync(dirpath)) {
        return callback(dirpath);
    }
    mkdirs(path.dirname(dirpath), mode, function() {
        fs.mkdir(dirpath, mode, callback);
    });
}
```
is `normalization_factor` always non-zero?
Well this is the same code you took a look at in the last pull? There you did not mention this. Well idea was to avoid char * where possible, as std::string should be more robust.
@sipa RPC "listunspent" already works on the wallet structure, thus "lockunspent" works with the information found in "listunspent"

Making "lockunspent" work globally, even for 'sendrawtransactions' coins not in the wallet is doable, but it creates a disconnect between the dataset manipulated by "listunspent" and the one manipulated by "lockunspent".

Is that disconnect acceptable?
Strangely, i can't add .gitignore to .gitignore. It ignores that line! 

Sent from my Nokia phone
-----Original Message-----
From: Philip Kaufmann
Sent:  17/05/2012 16:38:46
Subject:  Re: [bitcoin] Parallel block download (#1326)

> @@ -20,3 +20,4 @@ qrc_*.cpp
>  *.pro.user
>  #mac specific
>  .DS_Store
> +build/

Sorry, I'm no GIT master :-/. But I never had a pull or commit, where I needed to include .gitignore.

---
Reply to this email directly or view it on GitHub:
https://github.com/bitcoin/bitcoin/pull/1326/files#r839063
I intended it to be disabled by default everywhere, but at least it should be consistent.
Can you set this to plainText? Perhaps this helps? Or can you use another GUI element that does the same?
The messagepage uses an QPlainTextEdit field and I would prefer them to be even in terms of GUI element usage.
I think its a good idea to *add* ellipsis and deprecate ending.  Making ending + ellipsis have the same behavior, with ellipsis taking precedence if both are defined.  Making the methods consistent is important, but we don't want to break any existing applications.
这里并不是操作同步...只是同步一下接收ID而已。
实际的操作还是异步处理的，这个函数只是用来在发送请求的时候取得ID。
the visibility is missing for methods
object is neither a php type :) but you're right! fixed.
Either include the flash test in both of these specs or don't include it in the description.
How about `allow_exponent`, which is perhaps more explanatory while also shorter, since what is actually being banned are values like '1e6' rather than '1*10**6' or something similar.  'Exponent' is what Python's grammar calls that portion of a floating point representation.
I realize you're right.
I'll merge it.
I have taken it from the template: /tests/templates/default/issueXXXX.html

I agree that making it relative is a good idea, but how ? : 
 - we cannot browse from the root, since we do not know where the folder content/ is located
 - we may browse the parent directories (../../[...]/_common/testcase.css) but that would mean that we should adapt the link according to where the test is located.
 - use javascript to write the link to the css file (document.write('&lt;link href="'+basePath+'_common/testcase.css" ... /&gt;') )
 - another idea? 

The last solution seems to me to be the best of the three ones.

What do you think? 

Florent
probably want to skip this test on Windows (I can't seem to get it to build there, at least).
`magic_mode` and `mode` are different.
eg : `magic_ruby` will fail on 
```
....some ruby code
```
and work on 
```
%%ruby
....some ruby code
```

but `ruby` will fail on 
```
%%ruby
....some ruby code
```
and work on 
```
....some ruby code
```
as the same code can bu used to highlight any (future) type of cell. I thing it is worth to do the distinction.
Ya i liked `map` in this context since its working with a list but `each` would work too.
fix indent to 3 spaces.  add comment as to why io timeouts are 10 minutes
I haven't seen that pull request.  I've only seen https://github.com/laravel/laravel/pull/860/files  He just altered `dd()` so that it's wrapped in `<pre>` tags.  The only reason I called the function `d()` is because there is already an `e()` function which simply encodes HTML entities.  `d()` is the opposite and simple decodes entities.  `e()` is a shortcut to `HTML::encode()` and `d()` is a shortcut to `HTML::decode()`.  I named the function `d()` to be consistent with the rest of the project.  Make sense?
Love it. Done.
This is redundant with the assignment to mtime ~20 lines above it. See https://github.com/libgit2/libgit2/blob/development/src/fileops.c#L159 and https://github.com/libgit2/libgit2/blob/development/src/fileops.c#L188. The second assignment is not necessary, so I removed it.
This should be a `<h2>`
I think this element should be moved below the #marketplace > div instead. If you look at the document as it is now you get:

    "kicksend (link)"
    "Opening soon"
    "Mozilla Marketplace — Opening Soon (heading)"

And that does not make much sence imho. If you move it below the #marketplace > div you would get a much better structure

    "kicksend (link)"
    "Mozilla Marketplace — Opening Soon (heading)"
    "Before the public ..."
    "..."
    "... consumers with your app"
    "Opening soon"

And it shouldn't be a problem positioning it visually either :)
For singles like that you can just use `\d+`
I think you should move this inside the big function above so it doesn't create initFolding as a global variable.
``(products):(versions)`` is confusing, it looks like we should pass all the products, then a colon, then all the versions. Call that parameter 'versions' and avoid confusion in developer's minds! :)
Might also || null here?
Yes, Swing's LAF system was holding on to references to the menu items 
in the basic frame - specifically it was to handle the ALT key 
navigation of the menus.   I spent a lot of time poking through the java 
source code trying to find how to force LAF to release these things - it 
so happens that even removing the menu items from the menus did not 
release these references.  The only way I found to force it to release 
them is through reinitialization of the LAF.

Now that I'm thinking about it, I don't think I've tested keyboard 
navigation when having multiple windows open.

Also, there are questions about the impact of this on both apple and 
linux platforms.

Kevin


On 10/6/2012 8:58 AM, plaa wrote:
>
> In core/src/net/sf/openrocket/gui/main/BasicFrame.java:
>
> > @@ -239,6 +241,9 @@ public void componentChanged(ComponentChangeEvent e) {
> >
> >  		GUIUtil.setWindowIcons(this);
> >
> > +		// Reinitialize the LAF in order to free resources pointing to the old frame's window.
> > +		GUIUtil.setBestLAF();
>
> What's this do? The look and feel should be set once at startup. Is 
> this some hack to circumvent memory leaks in Swing or something?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/plaa/openrocket/pull/4/files#r1779393>.
>
Search for `mysql_` and kill off anything left in there.
NB: c'est juste la valeur par défaut, comme ça on l'a sous la main sans devoir aller chercher dans la doc le jour où on voudrait la changer.
I´ve reduced the length of this code so I think there is no need to refactor it anymore.
That's good to know and seems somewhat non-intuitive. So what is the proper solution then to "reset the value" setting to null is the closest it seems.
indeed, this method is never used. I confused with ``remove`` and ``replace``
This line should be removed. It has nothing to do in this method
@zackw I think the original purpose was to be able to set the talkatv_home *once*. Since then the functionality of the document.write-related logic has been extended to `talkatv_shortcut = true` to switch on `/talkatv.js` instead of `/static/js/talkatv.js`, which also has to be [configured on the web server](http://talka.tv/docs/deployment.html#nginx-example-configuration).

However, I think I added an ugly `@app.route('/talkatv.js')` that makes it work even with a vanillla web server or just `app.run()`. *I didn't, I just added a super-hacky sentry/raven-js `/talkatv.js` route*.

I wonder if it would be possible to extract the location of the script from within the script. That would make it almost a no-brainer to switch over to the method you suggested.
deleted forgot i stil had this in there
perhaps venue instead of place in the future.  if only to keep the noun count down.
这个函数名字需要改。当前是p = ele.offset()
I didn't write a test, but I did add some code to guard against the registry changing before the file is fully loaded. Thanks, Dan!
Could improve the docs just a little here to say that the "union" of two regions is the smallest region containing them both.  (The actual set union of two ROIs is not a ROI!)
Does this need to be a function? Consider using a constant instead.
this is a good pt but won't be necessary after I make the changes above.
Why you have not a controller per env ? app_preprod and app_dev.php ? With in your vhost a rewriteCond to force execute the good one ? After you'll only need to remove non prod controller only for the prod server
This would appear to be the correct event to send from _get_change_email_form
Tip: You can do `Rails.root.join('features', 'support', 'house.jpg')` because `Rails.root` is a [Pathname](http://www.ruby-doc.org/stdlib-1.9.3/libdoc/pathname/rdoc/Pathname.html) instance.
I agree - we could have done this a little simpler. Opened a PR #940
I would like this patch a lot better if it introduced a new attribute (say "filter-spec"; better names are welcome) and deprecated the old "filter" attribute, marking it as an alternative to "filter-spec". The "filter" attribute would not actually be stored in the model -- it would be synthetic, read from and written to the filter-spec attribute. This filterToModel method would be the basis of the read-attribute handler for the deprecated "filter" attribute -- pass in the filter-spec value stored in the model and get back the legacy "filter"  complex attribute value. A reverse method would need to be written for the add handler and for write-attribute -- take a complex attribute and store it in "filter-spec" as a string. 

That would be a fully backward compatible solution, and since the old "filter" is properly deprecated we could drop it in AS 8.

I'm not suggesting supporting the old attribute in the xml. If people want that they can just use the old version of the xsd.
LOL when did you change your name? :-D
Doesn't work. I get an error of: Undefined property: Api::$BaseWsRequest
Can we get this OR statement on the previous line or does that break a sniff?

i.e:
    if ($posted_token === false or !$token_found)  {
Can you change these HTML entities to the actual characters? Entities cause problems when using custom date formats in text fields.
You did something on that in your branch. Any need to test this for me any further?
получится, однако не понятно, куда еще его можно засунуть, с этим statless
console.log should be removed
Same as BUTTONS, let's try to avoid speaking too LOUD in those files ;)
This one is tricky. Either `%Y/%m/%d` or `%Y-%m-%d` would work, but it shouldn't the US one Europe one.
Let's ammend the commit then :) 

Thanks guys for the ideas.
good idea to extract this kind of constants
!trans also works :sigh: I need to stop doing that. IE6 damn you!
On further thought, I understand this and like it. And I was wrong about the parens. I'd like (but you don't need) parens around the && expression.

Have you checked that there aren't any other similar lastModifiedDate uses in the code?

Thanks for fixing this. r+
Sorry for not checking this, the ogg parsing library is not written by me, let me check for it then I will commit the corrections.
And in further developing, this library may not be used cause <code>audio</code> tag can have meta-data properties after the bugs are fixed.
Change the prototype of showNotification to receive an object with those 3 properties instead ( title, text, icon)
Moved to its own object from Busytime store....
This test is meaningless. You're creating a mock object, adding it to an object, and then checking that it was added.

What are you trying to test?
It seems like we should be able to simplify the virtual port stuff a lot, at the very least unify the regular and "fake" virtual ports. The only difference between them is what kind of connection they bind to: zeromq or local.
where is tracerfactory being used?
@jessicabarbalho, is there a way to make this link link to the current page? Because `#titulo` doesn't look right.

Now I wonder why these titles are links in the first place if they link to the same page. Oooh @sergiofontes why.
Sure, is it okay to use the same spec in both spots? (ie cuke and spec)

On 30 December 2012 16:26, Myron Marston <notifications@github.com> wrote:

> In features/subject/explicit_subject.feature:
>
> > @@ -80,3 +80,18 @@ Feature: explicit subject
> >        """
> >      When I run `rspec nil_subject_spec.rb`
> >      Then the examples should all pass
> > +
> > +  Scenario: subject bang method
> > +    Given a file named "subject_bang_spec.rb" with:
> > +      """ruby
> > +      describe Array do
> > +        subject! { prepared_array.push(1,2,3) }
> > +        let(:prepared_array) { [] }
> > +        it "evaluates subject first" do
> > +          prepared_array.push(4,5,6)
> > +          prepared_array.should == [1,2,3,4,5,6]
> > +        end
> > +      end
> > +      """
> > +    When I run `rspec subject_bang_spec.rb`
> > +    Then the examples should all pass
>
> Can you add a spec (similar to this) as well? The cukes function mostly as
> documentation, and we rely on the specs to protect against regressions
> during refactoring.
>
> Also, given the use of the cukes as docs on relish, it'd be nice for the
> example here to show a more idiomatic usage of subject!. I think this
> functions well as a test but doesn't really show a case where I'd actually
> recommend subject! be used...it seems odd (and a bit convoluted) to
> create the subject object in a separate let block and just use subject!for a side effect on that object.
>
> So...if you can think of a more idiomatic example to use here, that'd be
> great :).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rspec/rspec-core/pull/760/files#r2520903>.
>
>
Hmm, actually, `around` wraps `before` and `after`: https://www.relishapp.com/rspec/rspec-core/v/2-11/docs/hooks/around-hooks#before/after(:each)-hooks-are-wrapped-by-the-around-hook

I can put everything in the `around` unless you have another idea?
These 2x print could be deletet.
Since you have checked if poll_target is a directory, this line can never be executed.
the successfulRC here should probably be `tuple(0,None)`, right?
:(, but it is enough to leave a todo about this.
why not `_.contains`?
So, really the "Resource" I intended the EC2VMManager to allocate was really money.  Never got around to implementing this, but the EC2VMManager would have a cost cap.  Each instance costs a certain amount and the EC2VMManager makes sure you can't allocate over the budget.  In this way the VMManager makes sure you can't create an instance that you can't afford.

In a plain VMManager (like you have an internal cloud of some sort), the "cost" becomes free VM slots (e.g. you know you can put 10 VMs on each server, you have 100 servers, so you can allocate 1000 VMs).
shouldn't it try to find it in the cache first ?
oops. it was changed in phpunit 3.6. i would revert it.
I don't think it make sense to put those ``@uses`` or ``@see``
I may be wrong here, but wouldn't it be cheaper to call parse_url once without the second argument, and use the resulting array instead?
Applies `verb` or `on`
Definitely not. @lautis could you shed some light on these strange configuration params? Now that the Sources API is going public, we could refactor this.
I think in this case we want to ensure that reqwest isn't called, so we should add explicitly test for that.
Are we adding the appropriate JS to allow these HTML5 els to be styled in IE < 9? If so, are we testing that layouts aren't broken if that JS fails to run for any reason?
1. Don't leave spaces before commas
2. Check if `venue.website` is non-blank
3. Don't leave spaces around text in an `<a>` tag
4. The URL may be long and ugly. Apply the `cleanurl` filter on it like so: `{{ venue.website|cleanurl }}`
Just make it `private` (and `final`). Accessible fields are rarely wise. If a subclass really needs to access `callable` (why?), you can introduce a protected getter, or they can simply not extend this class to begin with since their needs are likely pretty different.
Typo: "somethingFinished"
I don't know if you use it in there, but nodemailer will try to use iconv if it exists (but it works fine without it).
any reason to keep this around in a comment?
We might get to remove all of these, waiting on confirmation.
We should probably just send a quick `{"message: "success"}` at least. Not hard to do and it's easy to process.
It was @Rik's idea. It made sense to me until I realized it could be misinterpreted as "Windows Classic" and I now question my r+.
Poor unwanted fields!
ok. returning it to protected. I think I change it into public just because I want to use jOOQ. 
My first attemp :)
It is probably best to leave this declaration in place, since it is the most canonical way to "document" the instance associated with the constant, and to avoid displeasing various autoloading magic outside our codebase.
We use the following style in other places:

if name =~ /^@[a-z_]\w*$/i
Please remove blank line.
`|| false` is redundant
I like the idea of explore new alternatives but I think we need more discussion about this
Right, what I'm saying is that consuming code that wants to check if a particular object is of a particular type, it should just use instanceof, not is_subclass_of.  is_subclass_of (php4) predates instanceof (php5) and its only usefulness is that it can be used with class name to class name comparisons.

As for the implementation, I'd simply remove the foreach.  I'd create a multi dim array of $classes[$parent][$implements] = true; For the lower case stuff, I'd use array_change_case over ($classes[$parent]).  What this does is remove the loop (expensive), and also keeps the lookup to an isset().
Same comment as for the Float validator -- unnecessary.
"please" spelt incorrectly
The dialog varies, depending on KI level for example. And such a dictionary would take a lot of time to build. Are you sure the effort is worth it?
thx, mixin in head from sf1
missing space after echo, intentional ?
What are you grabbing out of the stack here?
Try not to use single char var names (i,l,e is exceptions of course).
I think many people would prefer tomcat


On Wed, Nov 28, 2012 at 4:59 PM, Justin Walgran <notifications@github.com>wrote:

> In README.md:
>
> > @@ -12,46 +12,56 @@ Default graphics and config files for the OpenTreeMap iOS are available at https
> >
> >  #Installation Instructions#
> >  ###Required programs:###
> > -* Webserver - Apache2 is recommended
> > -* Database - Postgres 8.4 + postgis 1.5 is recommended, Something compatable with Django required
> > -* Map tile renderer - GeoServer(java) on tomcat is recommended (port 8081)
> > +* Webserver - Gunicorn is recommended
> > +* Database - Postgres 8.1 + postgis 1.5 is recommended (postgis 2.0+ is not yet supported)
> > +* Map tile renderer - GeoServer(java) on tomcat is recommended
>
> Should we suggest Tomcat even though we are running Jetty in production?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/azavea/OpenTreeMap/pull/41/files#r2257881>.
>
>



-- 
Adam Hinz
Software Engineer, Azavea
hinz.adam@gmail.com | c: 608-445-8391 | Twitter: @ahinz
Very nice, thanks.  I think this is covered in [21d8b19bf0d5891fa1a5a8b1f1f040f5058bd9a9].
Interesting my IDE did not pickup on those, will fix it.
@harjis $automaaginen ja $laskurow? Ny o muuttujat solmussa.
Both "=" should be aligned since they imply a logical block creation
why using braces around each condition of the AND ?
This is broken. You keep only the last element of the array
PHPDoc doesn't make sense in regard to sorting. Goes for API too and all other LocationService implementations.
spaaaaaaaaaaaaces!
Well, it's not random - it keeps the two lines aligned:

                            <artifactId    >as7-quickstart-wicket-ear-war</artifactId>
                            <bundleFileName>as7-quickstart-wicket-ear.war</bundleFileName>

To make it obvious that the value is the same. Personally, I prefer that. U no? :)
What are your thoughts on this now? Use jar jar?
Cool, thanks for humoring me :)
Hmm, I guess so...

How do we login on local machines, now?
Certainly. Since we don't rely on setuptools. 

More alarmingly, why do we use github for these deps? Why not pypi? And why is there still no version number pinned for django-browserid?
@jsocol should this be _lazy?
I don't see a ready state 4 ever being set. Is this not needed?
We don't need to import Page here since we use the BasePage.
why remove those? these are genearaed by a puppet client, so we might be getting these kind of objects regardless?
Basically if it's anything more than checking one variable and one function call we should probably use an if block. Another one:

    oldView && (delete this.children[oldView.cid]);
    oldView && oldView._shouldDestroyOnNextSetView && oldView.destroy();


(I guess the later one isn't that bad but if you have to do explicit parens to make it work like the first line then it should be a normal block.
Declare the var sw before the "for" statement
Reference whether or not selection is enabled before checking/writing to selection observables.
Well it depends on what we want. In the case `$array['key'] = NULL`, do we want to get `false` (`isset`) or `true` (`array_key_exists`)?
To me, `hasOption` should only check the key, not the value.
Here is the new jQuery plugin for registering image tags to receive `"breakpoint"` events and to set up the event handlers that update the image's `src` attributes.
and with @smoke mark
This sounds quite expensive in processing, better compile the regex and add it as a constant on top of file and then use it with .findall or sth like that.
What does this cli parameter look like?  How would one call it?
This docstring needs updating too
This doesn't work as it needs to be an id (or text) and it is a class. I didn't want to add an id so I used find, which can use any css selector. Maybe I missed something?
There's no need to have a fallback, the `Cassandra.getPagingParameters` utility takes care of this
Isn't this going to be a string rather than a boolean?
This is not a parse error, but a type error. :) Just nitpicking.

But why do you expect to find the test even if there are errors? Since you can't run it, I wonder if it's useful.
Can you please add a comment explaining why you need this special casing? I understand it's because of the `currentOwner` thing, but it's totally non-obvious :)
Would be nice to add the return type (our unwritten style conventions... :-))
+1 for apt-get and Python 2.7
this line attempts to manipulate a private property of the parent
I really don't agree. This hides the registration of the default check in a way that I'm not comfortable with. Also, additional checks will likely be installed by default before long, further mucking about with this. Better to dogfood the registration of any built-in checks by using the public interface, I think.
No, this is unnecessary. I have a inf loop when I try to debug the clang, so I add this to check eod.
Feel free to merge this after fixing this one.
but a var dirty = new Date(); here
Is `resource` a valid type?
`string` should be lowercase
>= 6?
I guess so, as it is a number.
Достаточно неоптимальный метод, так как на процентах близких к 100 — будет требовать много лишних итераций
Сокращается. Но представьте, что вам дали на вход 100 :) Сколько вы будете ждать пока вам arc4random выдаст последний единственный оставшийся случайный индекс? :)

On Wednesday, October 31, 2012 at 11:31 PM, beribas wrote:

> In DNAAssighment/Cell+mutator.m:
> > +// > +// Created by Oleg Langer on 30.10.12. > +// Copyright (c) 2012 Oleg Langer. All rights reserved. > +// > + > +#import "Cell+mutator.h" > + > +@implementation Cell (mutator) > + > +- (void) mutate:(int)X { > + // x percent of 100 = x > + NSMutableArray *replacedPositions = [NSMutableArray arrayWithCapacity:X]; > + while (X--) { > + int randNumber = arc4random() % 100; > + if ([replacedPositions containsObject:@(randNumber)]) { > + X++;  
> проверку встроил, сейчас залью. Я так понимаю, благодаря ей угроза бесконечности сокращается?  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Hexlet/osx-project-1/pull/8/files#r1997051).  
>  
>  
>
аналогично, не спорю, но в таком контексте, пара наносекунд погоды не построит, но учту, спасибо!) как говориться приму к сведению)
Should we just lock the gems here and remove the dependencies in AdminHQ and AgenciesHQ?  I think most of the logic involving these two gems can be moved into toolkit if it hasn't been already.  The versions of devise and devise_cas_authenticatable here conflict with versions in AgenciesHQ.
tabbing appears off.
On second thought, this class is only called from the test suite. It doesn't look like ORM's FilterCollection has it. Do we really need it?
It ensures that the scheduled block will be performed as soon as possible with a valid current scheduler.
`dispatch_get_specific` / `dispatch_queue_set_specific` require a GCD dispatch queue, would `-[NSThread threadDictionary]` work better?
Did you test with no images on a step?
Hmm, let me read through the existing discussion more carefully. In the current proposal, does the Repository.Clone method return immediately? I assume it can't (and must therefore block) until it's complete. Which is not ideal.
the `ThreadAffinity` pattern is only required when one has to call to `Ensure.Success` and potentially retrieve an error message.
I read that page again and I still I tend to think that `DJANGO_BASE` should be included. Otherwise how would a robot know from `Disallow: /login/` that for example `http://some-university.info/metashare/login/` is not allowed (with `DJANGO_BASE = "metashare/"`)? The robot would just assume that `http://some-university.info/login/` was not allowed.

On the other hand I’m wondering how robots would find our `robots.txt` anyway, as it is not in the top-level directory of your web server with `DJANGO_BASE != ""`. Perhaps it makes only sense to create `robots.txt` at all,  if `DJANGO_BASE != ""` …
Yeah, on line 611 you coded it so that it gets turned into a one-element array.
+1 for bandwith everywhere
Hey Josh, The JSON response needs to include the :rating_count method for the mobile front end
How are these two different?
I may look cleaner if you place the link on the next line
如果值以<literal>@</literal>开始，表示缓存响应知道公元后多少秒。
-> 
如果值以<literal>@</literal>开始，它表示自1970年1月1日以来的秒数，响应一直会被缓存到这个绝对时间点。
The purpose of adding it is that in precompilation, there isn't a way to pass data to a partial.  In my scenario I have a partial that references @mytoken.  I want the parent template to pass in the data object to the partial so that @mytoken can be used:

Currently when I precompile: handlebars -f mytemplate.tmpl.js mytemplate.tmpl  I'll get a line like this in the output:
  stack1 = self.invokePartial(partials['mypartial.tmpl'], 'mypartial.tmpl', stack1, helpers, partials);;

This means that if I pass in additional data:
   Handlebars.templates['mytemplate.tmpl'](ctx, {data: strings});
the second param doesn't get passed to the partial

With the lines I added I now get this in the output:
  stack1 = self.invokePartial(partials['mypartial.tmpl'], 'mypartial.tmpl', stack1, helpers, partials, data);;

This is only an issue during precompiliation.  Maybe there is another way to do this to get what I want.  Thoughts?
don't use vars in guards.
It's an immutable collection right? Why would you want to concat it with an empty set?
why toList
Can you change last sentence? It's meaningless now (you're stating same thing as in first sent. )
> Isn't this a regression?

Yeah, I thought about that...but the two roots are just pi apart and
we aren't trying to return all the roots for trigs so I favored
simplicity at this point. The other roots are still accessable if the
user uses rewrite(tan) on the expression.

>>> solve((2*sin(x)-cos(x)).rewrite(tan))
[-2*atan(2 + sqrt(5)), -2*atan(-sqrt(5) + 2)]
>>> solve((2*sin(x)-cos(x)))
[atan(1/2)]
>>>
Опять же, если совместимость с Qt 4.7 и ранее не парит (а апстрим она уже не парит ;3), можно написать
```
Process_->start ("xterm",
        { "-into", QString::number (Embedder_->winId ()) });
```
Там надо возвращать bool, а я не знаю, что возвращать. Поэтому решил отдать
на откуп кутям
extra nl?
¿Jodería mucho si te pido que cambiemos los CS\ por DOMAIN NAME?
"...this creates essential package files and makes the package readily available..."
please refactor this with foreach
You shouldn't call methods in long chains through all instances like doing here. Please use a block local variable for the loop element (mapDatabaseList.get(i)), if it is used more than once inside the loop. Then extract everything inside setChecked(...) as new method "isCurrentMapDatabase(mapDatabase)" or the like. If someone looks at this line in some weeks, he will have to decode the complete method chain otherwise to understand it.
You should probably make the traceback as an error or exception too
getReadConsistentHash()?
Ah, InfinispanCollections.emptyMap is not integrated yet ...
Why do you need to make any changes to this file at all?

AFAIK, this file belongs to the old, pre-5.2 configuration JAXB stuff.
Removed the license?  ;)
I'll fix it. It is 0x20000000 bytes. The libgit2 documentation is both wrong (512Mb) and doesn't mention the units (bytes), so yay for us!
Hrm, alright. Let's leave this as-is.
It's a bytestring '.'
Don't you need a "num" argument here, to match the signature below?
I'm a little confused about this, does that mean I should change it to traverser.err.notice? And what's the difference? I've been mostly going based on previous examples on this file, which were pretty much all notices. I thought the major distinction was compatibility type='error' vs 'warning', where 'error' causes the add-on not to be bumped?
`click()` doesn't take any arguments so can you remove `add a category`
That's old indeed, I'll create a pull request to simplify, if you could review that would be great.
I don't think this will make a difference (getting an md5 collision with hostnames would be very hard), will it? But feel free to change to sha1...
does scalamachine not support multiple header values per header name? You're definitely losing information in this method, as `req.getHeaders(name: String)` is available.
Why `'id' => $v`? That should just be `array($v)` no?
This should use Database::instance() instead..
This test fails here. No such file/directory found.
who is this ?
Allow for "_content" tag to set content of the node.
I am not a big fan of this kind of function, just to use anchor type.
when possible I prefer generic, but I agree this is a solution
Is it possible to add a ``@param`` annotation for parameter ``$url`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? Please also check line 27.
Are you sure ``'/'`` has the correct type as ``string`` is not a sub-type of ``string|null``?
What if there are no spaces in the string at all?
If you do it this way, you will have an error about reading an undefined variable ``$storage``. What is the goal of adding a ternary operator here ?
`application/xml` comes before ` text/xml`
`$package_ensure`-variabelen ser ikke ut til å være i bruk. Den bør brukes eller fjernes.
Yup. You are right. Will change that.
Either way, you're still missing two characters for some of the salts which should be there.
Heh, the CSS started out as extremely temporary but has evolved into "the real thing", so we should probably get rid of this comment, and its corresponding closer at the end of the file...