labofsahil/github-event-dataset-2012 huggingface dataset:
I'm happy with abstracting the request logic and I did it myself with the GET but to bundle the assert in there limits its use.

We in mozwebqa also have a policy of not including asserts in page objects or methods that aren't a test.
we don't actually support the 'unpaid' status anymore actually ... can you change this to (for example) 'approved'?
I expected a punchline at the bottom of this file.
Okay. I'll back out all that code, then.
I actually grabbed this piece from `socket.io-client`:

https://github.com/LearnBoost/socket.io-client/blob/master/lib/socket.js#L385

But yah, that makes sense, something like: a.protocol !== window.location.protocol
What? Noo noo. :-) Don't do another request. You should traverse DOM and `.data()`-attached notification objects and count there. So the idea is: notification comes, we convert it to object and attach it to DOM. Count is synced with how many notifications we have in the list which are not yet read. So everytime we mark a notification as read, we store that and update it in attached object. And update count. We have to read from DOM because store Ajax request is asynchronous. So we should keep state in attached objects.
Yes. Before the change I got this error:
 
```
Exception Type: AttributeError at /
Exception Value: 'BaseDict' object has no attribute 'picture'
```
I would rename this to `is_valid` or even `check_token`, which would receive given token, and do all checks (if it is same, if it has not expired). So code in the form can be simplified. And logic about what is content of the token could be here, not in the form.
*Prosimo, poskusi znova.*
(OK, you could do it sometimes, but not really here. Why would this here be good?)
Oh, you are using UUIDField. Then you should be using uuid value as a default. You can use random uuid for this. (See uuid Python package.)
вот это )
Oh and Android
Let's make it more concrete. Given the current test suite, I can change the implementation of the `Invoke` method to this:

```C#
public object Invoke(IEnumerable<object> parameters)
{
    decoratedMethod.Invoke(new[] { parameters });
    return new object();
}
```

All tests in the `UnknownParametersCountMethodTest` pass even with this change. Is this really what we want? What does it tell us about the value of this particular test suite?

On the other hand, exactly *one* test fails with this change: `Ploeh.AutoFixture.AutoFakeItEasy.UnitTest.FixtureIntegrationTest.FixtureCanPassValuesToAbstractGenericTypeWithNonDefaultConstructor`

This was the original test we would have liked to pass. This is the actual outcome we care about. Do we need any other tests?
Why is it named a List when its a map?
Left over from the previous copy :) I'll re-write it to be more consistent!
Comment and assertion would be fine with me.
the space is aligned with previous comment, I don't see any problem
There's no ASI issue here. `return` is one of the few cases where it's an issue. Just drop them IMO. :)
Why is `flat_list` not just a var?
(Changed that whole map/reduce procedure completely now)
Args not lining up properly.
Or just template.pop()
Newline before this if statement.
In nginx you specify how many arguments you're willing to accept, and above we accept up to 5 in `ngx_http_pagespeed_commands`.  That's what `NGX_CONF_TAKE1|NGX_CONF_TAKE2|NGX_CONF_TAKE3|NGX_CONF_TAKE4|NGX_CONF_TAKE5` is doing above.
Interesting; I'm getting `undefined reference to `DoAssert'` even with adding `libassert_lib.a` to the pagespeed makefile.

Are there debug symbols missing when you run `make all` in `instaweb/automatic` without the `BUILDTYPE=debug`?
Hmm, the comment says "if we have a local configuration". But since we don't have a step 0 (anymore) I guess the if ($RCI->configured) can be removed entirely. Checking for if (empty($_REQUEST['_step'])) should do the job here.
As you will. I chortled when I realized the failure mode you were pointing out.

Given that it is the name configured at snap server startup and not otherwise related to the request, I might suggest `rqConfiguredHostname` or so. Otherwise, perhaps we just leave it along at the existing `rqLocalHostname`.

This does raise a bigger question about whether it even needs to be in the Request object, but that's a topic for IRC perhaps. Same goes for `rqIsSecure`, actually. Does beg, though: can you get to the server Config object from the Snap monad or otherwise?

Anyway, as you wish.
I don't know if it's relevant to have all without contains. I don't really see how it can become handy
What do you mean automatically handled? It messes up code folding for classes and functions in vim for me. Changing the indent is read as no longer part of the same indendentation block / function. I suppose I could try fix the plugin, but I'd rather not...
On 08/01/2012 05:34 PM, Skipper Seabold wrote:
>> +        endog = self.endog
>> +        if endog.shape[1] != 2:
>> +            raise Exception('Correlation matrix not yet implemented')
>> +
>> +        self.corr0 = corr0
>> +
>> +        if nuis0 is not None:
>> +            start_nuisance = nuis0
>> +        else:
>> +            start_nuisance = np.array([endog[:, 0].mean(),
>> +                                       endog[:, 0].var(),
>> +                                       endog[:, 1].mean(),
>> +                                       endog[:, 1].var()])
>> +
>> +        if mu1_min is not None:
>> +            mu1_lb = mu1_min
> The way I read this is that it's part of a nested optimization for ci_corr. Is there anyway to avoid going through all these if statements each time it's called since we don't really need to? Right now just calling ci_corr takes close to 10 seconds and includes 1.6 million (!) function calls. Anything we can do to avoid unnecessary calculations is going to greatly speed things up. Even if ci_corr doesn't call test_corr and repeats some code since the latter might be (?) called just by a user with the outer optimization step.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1288093
I didn't even think of that and I'm sure it can be done.  I just hit a 
major breakthrough with the AFT model but as soon as that is done I will 
address the suggestions from today.
See my comment at line 158.
I do think the actual way random starts are used does not correspond to Rousseeuw and Van Driessen's two-steps algorithm proposal (Fast-LTS).
Although a lot of random starts can be done without sticking to their algorithm, there is no proof (AFAIK) that the number of iterations should be 2 at stage 1 and then "up-to-convergence" at stage 2, and I guess not using subsets at stage 1 reduce the probability to find a good candidate that generalizes well for stage 2.
In docstrings, please use full sentences (dot at the end).
How is this change related to direct?
Are you intentionally not including the message here for a reason?
Instead of a factory, why not a spring bean?
Is it worth linking back in to codemania? or even some reviews of the days... just to give them a little post-publicity?
Even After Work is Over?
You should look at removing some of this white space - it looks messy. No one likes a messy hacker?
So that this works initially, before there's any MOTD, please change this to:
  return systemObjData.motd || "";
Log statement doesn't match the test name (same for second test as well).
Do we really want \@Test on the class and on each test method? I thought that having it on the class meant every public method was viewed as a test.

Would be good to have some content for these tests, but happy for that to be added in next phase if you think that's appropriate.
Why only these primitives? What about char, short, byte, float, double?
i'd prefer to test http as that is closest to real usage.  it's an integration test for which we typically require internet anyway.
This week Fab celebrated their first anniversary
Here you can use `"%s.%s" % (User._meta.app_label, User._meta.module_name)`.
Accessibility is a big work item, but "I can't click focus away from the input box" can be easily fixed without code by adding a tabIndex attribute on the div that should be focusable. Anyway, we can talk about this tomorrow and go ahead with this for now.
Ok, I'm going to change it.
Perhaps max_document_size as name? I am not too fuzzed about this one.
もしかしたら、改行コードの所為かもしれません。
I have many times.
look at #295
Indeed, Symfony must not use the Doctrine way of creating exceptions.
I think it's showing all the changes from when I merged the last time
master changed.  Also, there's one commit in there where I fixed the
indentation in a bunch of files.  It might be more useful to review the
pull request one commit at a time.
-Geoffrey Parker


On Sat, Mar 3, 2012 at 12:18 PM, amshali <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,21 @@
>
> Is that because of the spacing that it shows the whole file has changed?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/19/files#r514887
>
Note that 'Shedules' has been changed to 'Schedules' - if there are any folders by that name, they may be broken... sorry :P

Also, if you're doing translations, stop doing it the way you're currently doing it - I have a cleaner solution! Coming next push
Does make sense to move the method below to HttpProviderFactory for example?
Seems like this check is not necessary here (unlike in ```has_many```)  I'm assuming I should be able to do ```Deal.new(:user_id).user``` without getting nil back.
Как ни странно получается 1.
Кажется, вместо этого всего надо было сделать следующее: ```calendar.setFirstDayOfWeek(Calendar.MONDAY)```
А что за интерфейс bad?
If the new constraint allow empty / null secret like it seems to be, there's no need for this change anymore.

I can update the pull request this evening or feel free to do the modification yourself if you want.
mabiiiiii
Ruby で絶対パスを返すメソッド名は `#expand_path` とか `#absolute_path` という名前になっていることが多いので、同じ名前にしておいたほうがよいかなーと思いました
ops sorry about that
See comment above about doing `return Decimal('0.00')`.
Can you put a comment to explain this?
`eta0` doesn't affect anything when `learning_rate="pa1"`. So, don't define it, this is misleading. Moreover you should set `penalty=None`: the `C` parameter used to compute the step size in passive-aggressive is already a form of regularization, you don't need to add extra regularization like in SGD (not to mention the fact that `alpha` and `C` have opposite meaning). Also `C=1.0` is a more reasonable default value for passive-aggressive.
What is Z?
To the complaint about windows being brain-dead and needing / wanting _isfinite, just use std::isfinite instead (which is "safer" anyway as anyone that includes <cmath> indirectly ends up losing the regular isfinite).
I'm a retard, we had the same discussion wrt the dumb term thing last time.

I'll rebase and push again. I feel like the tput binary not existing should throw an error though rather than silently not colouring anything.. smells of broken system. I'll leave it for now though.
We are not generating code here. It's documentation. As I say in the comment, most of the time a search in the global scope will give the correct match.

Given how DMD is coded right now, it's impossible to do a correct search since the scope where semantic was run is lost. Also types are replaces with their resolved types, and aliases, so it's really hard to make it be "perfectly correct".

But did you check the phobos docs I uploaded? Did you find something wrong there?

My philosophy is "something is better than nothing".

If you have a better way to do the search perfectly precise, let me know. :-)
Why are you deleting the systemd files?
@fomojola I am just testing around with ssl trying to simplify things if possible: 98f4a3c854911aef95a221335e0c339538780378

And i am not sure what the 'handle' is for...? It seems to limit the number of simultaneous connections...

But even when i remove the handle as you see in my code my firefox somehow fails to create more that one ssl connection to the example server at a time.

I am probably missing some basic mechanic...

Do you have an explanation for that behaviour?
This is only set by rows now
Ah, what's that flag?
that would be the semveriffic thing to do
「オーバーロードしているメソッドを呼び出す」方が正確だと思う
Nope, the examples should be as good as possible, even if it takes a bit more time to explain. People will copy these (I hope). I'll try to fix it and ask for a re-review.
I was going to mention that this method is hypothetically slower as `<<` updates the string in place without a copy, but looking forward at the `word` method, I think this might have been mutating the source words. 

```ruby
> foo = ["one", "two", "three"] 
> bar = foo.sample
> bar << "1"
 => ["one1", "two", "three"] 
```
I think the -01 was from an early stage of evolution when Kevin was messing about with some of the cluster, and asked me to hardcode it to -01. I think sakai-dev.berkeley is the right address to use.
It's just a global constant. Shift it nearer the top of the file and change the code later to ```[(state, state) for state in STATES]``` or similar.
Does the vuln require that the object be created like this?  If you create it in javascript, it can be obfuscated whereas this is probably already fingerprinted by AV/IDS.
WORKSTATION refers specifically to the local machine, for ntlm auth i beleive it should be the equivilant of using .\
actually passing . as the domain for ntlm auth does not appear to work however.
This empty line can be deleted
Should be--I changed it to np.float64 for clarity.
right dumb mistake.
nope, and it confuses the point of the test. Removed.
There are a few issues with this code:
```javascript
var modelMatrix = defaultValue(spatialState.modelMatrix, Matrix4.IDENTITY);
var center = new Cartesian4(boundingVolume.center.x, boundingVolume.center.y, boundingVolume.center.z, 1.0);
center = Cartesian3.fromCartesian4(modelMatrix.multiplyByVector(center));
boundingVolume = new BoundingSphere(center, boundingVolume.radius);
```

* There are a ton of allocations.  We should be able to get rid of all them.
* This assumes the bounding volume is a sphere.  We can't do that.  A bounding volume should know how to do everything it needs, and the renderer just uses it polymorphically.  So a bounding volume should have a function to transform it given a 4x4 matrix.  The only issue is allocations.  We can use a result parameter, but then we need a `typeof` check before transforming.
This is a minor knitpick, but would you mind moving this function to be with the other `Color.fromXXX` functions at the top of the file.  Our general rule is that all of the `from` functions should be group together right after the constructor.  If Not, I can just do it after the merge; no big deal.
PolylineCollection.add. I removed that example comment.
It's already called camera position.

I may not be completely understanding the design you're proposing.  I'll bug you about it in person so you don't have to keep typing here.
You can use Quaternion.IDENTITY instead of this variable.
Var statements on separate lines
Change the property `coordinate` in the header file which is currently defined as readonly
Should be 2011-2012 =)
Thank you - this was a typo. Fixed in next update.
OK, yes, I see this now. I did not look hard enough.
у меня не получилось это сделать нормально, из-за всей этой возни про нью
факт в том что этот твой менеджер будет частью нашего АПИ. поэтому либо ты создашь в нем 20 методов и получишь в лоб когда захочешь как-то, например, каждый из них обернуть или чуть поменять, или ты сделаешь один метод-диспетчер, генериковый
Not so easy. It irks me that almost nobody seems to think long enough to see some obvious issues.

Just  look at current example page of docs - **all** of them are going to fail with auto ref:
```d
int[] a = [ 1, 5 ]; 
int[] b = [ 9, 8 ]; 
int[] c = new int[a.length + b.length + 10]; 
auto d = copy(b, copy(a, c)); 
assert(c[0 .. a.length + b.length] == a ~ b); 
assert(d.length == 10);
```
```d
int[] a = [ 1, 5, 8, 9, 10, 1, 2, 0 ];
auto b = new int[a.length];
auto c = copy(filter!("(a & 1) == 1")(a), b);
assert(b[0 .. $ - c.length] == [ 1, 5, 9, 1 ]);
```

Surely it means there is a *lot* of code that relies on copy taking a shallow copy of passed in range.
An explanatory comment would be of good help here.
Well, in my second commit, I actually changed the API of std.crc32 to sanitize it somewhat, so I'm not sure that's really worth the effort. If users switch to std.crc32, they should just use the new API right away. At least that seems like a more sensible approach, if users are switching away from a deprecated module *anyway*.

Fixed the message and rebased.
Same note about default-initialization.
Done. TY.
Mm I hate semicolons in natural text (not programming languages). 
Let's settle on "or failing that", from your link it seems like it's OK.
So what's the semantics of `r` here? As far as I can tell it's 0 or 1. It will be 1 if n has at least one bit set or something.
@arturoc - yes that works. iOS needs depth and stencil in the same buffer.
Better to use File.separator instead of the Windows-only "\\".
Yep.  You saw that right.
Better might be to extend the grouped format to support multiple nulls.  
You could output the number of nulls (up to 254) in the eogPending byte, with 255 used as a continuation flag.
Thank you for your explanation. The new commit has been pushed.
I need to know the action though. This is not easy to do from an observer.
It seems wasteful to create a new DateTime object just to access its type. Perhaps you could use a static resource like Resources::STATIC_DATETIME_INSTANCE?
Normally you copy the .dist file into the file name without .dist and then fill out the parameters. This line is just to protect users from accidently commiting their credentials to somewhere.
`unless model.respond_to? :correct?`
Yes, just in case you don't use the enforced_methods call
Т.к. у нас адрес может быть в разных местах, то надо создавать полиморфную связь вида: `belongs_to :owner, :polymorphic => true, :touch => true`
`signals` идут в конце в самом, после всех прочих методов.
у меня слабость к лямбдам и алгоритмам появилась. функторы было лень писать, а лямбды в кайф.
Extraire cette variable (tout comme celle de la `definitionsList` d'ailleurs) dans une constante `BUFFER_SIZE` ou équivalent.
if the cache is not transactional than the transaction protocol is not used, so switching to NORMAL is not needed. I think the warn can be downgraded to TRACE and "bean.transactionProtocol(TransactionProtocol.NORMAL)" should be removed.
I talked to Brian earlier and he's going to take a look at getting this working with NUnit. I'll let him work his demonry, but it doesn't look like this will be a problem.
maybe call this var `existing_tags`?
The line-break here is wrong - this can probably all fit on one line now, but if not it should be wrapped right after the open-paren
Made the changes.
Here the Success is Http Status code according to HTTP standard. Only if the status is 2xx, no exception would be thrown. 
http://en.wikipedia.org/wiki/List_of_HTTP_status_codes
Adding --destructive doesn't avoid accidentally running the tests, it explicitly allows running the tests. I'm sure this is what you meant, but I don;t think this is particularly clear. I would suggest something like "By default only tests that do not change the state of the website are executed. If you wish to run these 'destructive' tests then you must specify --destructive on the command line."
Is it worth adding --use-mirrors to protect against PyPI being down?
Suggested:

    'choices' => $roles,
What about using a strict equality here?
@bp323 using `:confirm` will make the sure the JavaScript is unobtrusive. This is general best practice.
There are plenty of resources online about this:
https://www.google.com/search?q=unobtrusive+javascript+ruby+on+rails

Instead of saying "it just works" we should be writing good and maintainable code.
Wrong collector name
Why this must be static?
Constant string ...
Uhm, I might be off base here, but these tests check that these representations fail. That's what the "catch(IllegalArgumentException e) { // expected }" implies. :-)
Un retour à la ligne où ça?
l'on s'accorde, Où l'on a toute
Another "magic string"
Please remove this line, as we are going to redirect the output directly to the config file, and this line will confuse the planet software.
che fayedeyi dare in kar vaghti dar halate addi dide nemishe :D
hatta vaghti baz mikoni ham nemiyad
kolan radius image haro hazf kon
Utilise des scope.

Relis la doc sur les scopes dans active model.
I think (though I haven't tested it yet), that if we restrict the number of results from a Sync request, subsequent Sync requests will only tell you about new messages you haven't heard about yet (or changes/deletions). I have *no idea* if the initial Sync response will give us only the N newest messages, or if the ordering is based on something else. I know that the messages aren't necessarily sorted by date in the response...
what if several extensions are registered for the same uri ?
what's a launching code.  The stuff in the briefcase carried by the President? ;)  Seriously, you need to explain what this is.  Look at our own examples of use.
Isn't this a significant problem for parity? I assume this is always top-left on Android, so if the default on iOS is center, users are going to need to check the platform each and every time they refer to a position.
throw exception when the state is other than expected.
``2.*`` is too wide. We cannot ensure the compatibility with 2.2, 2.3 & co yet.

and adding ``@beta`` here is a bad idea. Travis should be able to use the dev versions when testing IMO so you should better set the minimum-stability to dev.
And add some examples here about using env vars.
Empty lines should be empty (no spaces or tabs)
While i do get what you are saying, i don't understand why or how we would be able to move these build scripts from project to project and use them immediately anyways. They are "packager" specific build scripts and can't really be used by other projects.

I can copy the code into the utility class for the build files to maintain code separation, but it would be the exact same code and i usually try and avoid duplicating code as much as possible.

I wonder if we should setup some kind of common module for utility methods and we can make sure everyone is very careful when updating this module as it would be used in multiple places (application code, build code etc).

Let me know what you think. I can copy over the code if that makes most sense for now.
This forEach seems better suited as a filter
Short annotation  of array, just for performance improvements
Weird because I thought @rwmtse  had it working in her extension
Inconsistent checks again
dead code below
Remove non-Entity messages from the queue.
Changed to `toggle_item`.
external js?