labofsahil/github-event-dataset-2012 huggingface dataset:
:class:~cartopy.mpl_integration.geoaxes.GeoAxes is missing a '`' so renders incorrectly.
Extract this outside of the function so that users can extend it (and it is only evaluated once).
This formatting doesn't look right. Either this line or the lines around it should be corrected.
Really 'return' ?!
Use ModelVersion everywhere?
looks like the same bug than https://issues.jboss.org/browse/AS7-5275
It's fine to split up `_create()` if the split makes sense. I don't see how the one-var rule has any impact on chaining method calls.
single var declaration at the top of the function
Descriptions on these two assertions are wrong.
Deleting last blank line... ;-) Thanks!
Don't remove the UI data before getting new data, put this into `fill()`.

Alarm List will flash and blink if you do so.
If it lands, yes. Probably not a bad idea to glance over it in case it doesn't though!
The building of this array is really hard to read, mostly because of indentation issues. Also can't you directly inline the string instead of calling Array.join or do you plan to do a lot of changes to those parameters and you feel it is more maintainable this way?
Yep, you right in both:

function naming
and using toggle, but with a new class for marking the elements that we are hidding that latter should be show when exiting search.
Looks like the indentation is wrong here.
Indeed! ;) All I can say about the timeout regarding the USSD feature is: http://knowyourmeme.com/memes/and-its-gone Thank you guys! ;-)
I know , I know :D just first thing that came to my mind, didn't put much effort on naming :ashamed:
nit: can you group it with the other messages using the same launch path?
hmm, interesting and unexpected. → https://github.com/fabi1cazenave/webL10n/issues/20
`showAwesomeScreen` doesn't seems to be part of the `init` process. 

You would need a `removeEventListener` corresponding to this `addEventListener` if so.
Shorthand syntax please: `transform: scale(0.86);`
the `querySelector` surely works but this is a cleanup to match the implementation already existed in window manager.
OK, you have to admit this is a scary for loop.
Maybe it is worth to highlight that I had to make a change to the original file.
This diff is correct. Should this delta be deleted? I don't understand. Importing org.apache.log4j.Logger should not be done. Are you asking about PropertyConfigurator?
Ok, I can now see this is intentional. Ignore...
This helper is only used in solution files. As in the paths that are delcared within the .sll file itself.
and if they put:

'razor -x policy'

they get an invalid ARG error
Oh! I didn't know you couldn't get Sinatra working locally.. So Sinatra doesn't support Windows? If that's true maybe we should add instructions in the readme for pushing this to heroku as an alternative. 

Sent from my phone

On 2012-08-29, at 10:18 PM, Doug May <notifications@github.com> wrote:

> In CONTRIBUTING.md:
> 
> > +
> > +## Before You Start!
> > +
> > +- If you have an existing fork, please make sure it's up to date.
> > +  It just makes your life easier! If not, make sure you fork *before* cloning,
> > +  otherwise you'll need to spend some time juggling remotes.
> > +
> > +- Create a local topic branch before you start working. This branch is going to
> > +  be named for what you plan to change. `fix-typo-in-slides`, `move-resources`,
> > +  and `mountain-lion-support` are all good names for topic branches. If you've
> > +  never created a local branch before, you can use `git checkout -b
> > +  new-branch-name`
> > +
> > +## Before Submitting
> > +
> > +- Please, please, *please* run `rake` from the terminal before you submit. It
> See comment on Windows -- not an option for these folks
> 
> —
> Reply to this email directly or view it on GitHub.
>
tiny nitpick `meta == null ? 1 : meta`
Kinda obvious, but you can reduce your LoC if you use a for loop here and in the other places where `times` is used.
Move user creation to Migrate.
I'm fine with it being reported all the way up. That's kinda how a stack trace works anyway. Lets me see where it was being called from.
Looks like a few more tabs here.
self.assertEqual(a,b     not    a!=b    right?
I'll fix that in the followup where schedulers are added to the data API.
The composer.json already had `composer/installers` and type as `cakephp-plugin`.

I mistakenly included the `extra.installer-paths`, to be honest I copy-pasted it from my [XHProf plugin](https://github.com/renansaddam/CakePHP-XHProf-Plugin), which needed the extra lines because the name is not standard, checking the plugin into `Plugin/CakephpXhprofPlugin/`.
For DebugKit it is not needed.

Fixed in b774a9d5d4f963794c1c486ed0d578afc003937d.
These function names should match those found on Server objects.  Not sure if they've been changed as well.
Same as below this should be InstalledRepositoryInterface
I added a line to the handler to make the URL optional just now. If it's missing, the current page URL is used. So we should make the link value here optional too and maybe note that in the label as well (e.g., "Link (optional)"). Otherwise, good catch!
I don't like this direction as it makes landing loader to firefox more complicated. As matter of fact in [bug 743359](https://bugzilla.mozilla.org/show_bug.cgi?id=743359) we're working on making loader independent of other modules in order to be able to land it to firefox. This on the other hand introduces new dependency. Unfortunately I do not have any good suggestions yet.
I'm ok with this change, but feel bit worried that some add-on's may get broken by this. Could you write about this on mailing list to increase awareness and users to test this. If `cfx testall` passes all tests I'm r+ on this.
someone should ;-)
Ah, I wasn't aware of these other, related, attempts to control the locale.

I'll have another look at consolidating these efforts.  Thank you very much for pointing this out to me.
Instead of doing this, I would suggest that you just use `File::PATH_SEPARATOR` in the tests.
Same as above, InstanceOf is the nicer choice here.
The `+` isn't necessary here. It passes the test either way.
isnt this the same as `if (this.options.pills)` ?
Is this equivalent to -Xmx4096m ? If so, kind of big to have.
maybe instead we should emit `suite.on('test', function(test){ test.pending = true })`
You can remove all @uses annotations when you find them.
Only issue I see with this is that since the argument for write() doesn't require a ColorInterface for $color and $bgcolor, one might have been using an integer value directly, causing a theoretical BC break.
File needs commenting
spaces inside brackets
i just removed it thanks done
Before the above call, you should really do: account::isNotLoggedIn();
-> `li.find('.edit').val().trim();`
@MathieuLorber
Ah, right. As I mentioned elsewhere, this code wasn't quite ready. Technically, they're different due to case sensitivity, but I've written this new class as a replacement to the existing one. I feel that the new one is a little more flexible and powerful, and also follows the existing html semantics more closely. That's all for a future pull request though.
Can you trim the parens here?
I think this should be an URL of the user, no? `/users/{username}/modules` for example.
I would return FALSE here.
this is wrong. lifecycle callbacks are not meant to receive the event args. The entities should not get access to the unit of work.
yes i know, thats what i mean with "start over" :-(

but the event should rather be "onClassMetadataNotFound" or something.
This method does not return anything
I can to some degree agree when it comes to main location id, the reason why I added it is that I was unsure if these calls also potentially changes main location id, if so then enough info to be able to hint about that needs to be included imho.

As for contentId, this makes signals more consistent by always providing content id on the signal avoiding unneeded retrieval from backend.
Don't limit the query by current playlist. If the video is already in another playlist, just add it from there.

Also, `video_url` can vary for the same URL since Youtube sometimes adds extra characters like `?plcp=1`. Look for unique `video_source` and `video_sourceid` instead.
why sort first?
Please rename rangeMaxdays to rangeMax with same syntax as min/max (via ngxDate.parse)
We can remove this method no?
Just for simplicity I left these out for the time being as there could be problems associated with including them.  I say let's leave this the way it is now and worry about all of the extra stuff later.

But yes, we will be passing all of this along to the user eventually
Do you really have to refresh the pointers on every fetch? Do they change that often?
Just showing you how cool git hub is, that's all.
the rest looks good, dont the other test-cases cover this or am i missing something?
How bout we just remove all the dev deps out of the gemspec into the Gemfile with conditions. Otherwise this is going to have weird results when I build the gem.
I like splitting this out, however when there are two autoload functions what happens? Do both get called? Do we need both to get called?
Yes... along with ``otherItems`` and ``myItems``
Again just for style, we generally use "var toChar = function(num)" instead of "function toChar(num)"
however, you dont even need to collect the data in the parser. the only reason it is collected is because previously you could not index the HTML elements during collection
No need for "in Socket.io", it is in the title.
Revert all changes in this file please
This has to be \InvalidArgumentException 

VObject shouldn't depend on SabreDAV anymore.
import urllib
    help(urllib):

> **FUNCTIONS**
> **splitquery**(url)
>     splitquery('/path?query') --> '/path', 'query'.

Does this not work for you?
Well, the setpoint is being set to the current yaw as well https://github.com/EwoudSmeur/paparazzi/blob/transition/sw/airborne/firmwares/rotorcraft/stabilization/stabilization_attitude_quat_int.c#L89, so it is basically the same
I don't think it's a good idea to puts the request out as it contains the username/password in plain-text.
Use RequestBuilder
On Mon, Jul 30, 2012 at 03:21:55PM -0700, Chris Price <reply@reply.github.com> wrote:
> > +  "Helper method for building up a `ConnectionHook` for our connection pool.
> > +  Currently only defines behavior for "
> > +  [log-statements query-execution-limit]
> > +  { :pre [(instance? java.lang.Boolean log-statements)
> > +          (and (integer? query-execution-limit)
> > +            (pos? query-execution-limit))]}
> > +  (proxy [AbstractConnectionHook] []
> > +    ;; the name of this method is a bit misleading; the way it actually works
> > +    ;; is that *after* a query completes, the connection class will check to
> > +    ;; see how long it took... and if it took longer than the specified limit,
> > +    ;; it will call this method after the fact.
> > +    ;;
> > +    ;; TODO: consider adding a call to EXPLAIN here.
> > +    (onQueryExecuteTimeLimitExceeded
> > +      [conn stmt sql params time-elapsed]
> > +      (log/warn (format (str "Query exceeded specified time limit of %s seconds.  "
> 
> I dunno, I guess I thought it might provide a clue to the user that
> the value was configurable?  I can get rid of it if you like.

If we keep it, I think we should rephrase in terms of a
threshold. Otherwise, I think it sounds like we terminated the query
early due to it hitting a hard limit. "Query slower than %ss
threshold; ", maybe?
I finally added the style inline (9dbeccfbd47bb9b27a958b0e3a561e8b0e02dda8). I could have added a new manifest file in images/app/assets/stylesheets/images.css, but it might be a bit of an overhead for a single style? If you prefer that, just say it and I'll change that in a blast (today I mean! :P). Just let me know what you prefer...
You can probably reduce indentation a bit here.
Shouldn't we be checking for an error on this one? (Same question for the unbind one)
I've just re-used what the tenants api was already using. However, you're right in saying that this shouldn't take very long locally, so I've reduced all of them to 100ms. The tests are still passing on my local machine and we can always increase it again if we start seeing intermittent failures. Making this change has cut the time it takes to run the full suite in half.
Done. As a part of this I refactored the initialization of the UI. It needed some clean up and simplification.
Sorry, you are right. Then why do you remove the damage-repairer?
That's a good point. We probably don't care. I'll change it, certainly to make it simpler.
Can you just PR your work on the tests?

It will be easier to review.

Le 17 oct. 2012 à 14:17, Antoine Corcy <notifications@github.com> a écrit :

> In tests/Geocoder/Tests/Provider/ChainProviderTest.php:
> 
> > @@ -12,10 +12,9 @@ class ChainProviderTest extends TestCase
> >  {
> >      public function testAddProvider()
> >      {
> > -        $mock = $this->getMock('Geocoder\\Provider\\ProviderInterface');
> > +        $mock = $this->getMockProvider();
> Well... I understand but I thought it was a "good" way to test exceptions and to have 100% code coverage. But I agree, it makes code less readable :/
> 
> —
> Reply to this email directly or view it on GitHub.
>
Add more checks here to ensure the salt is the expected length, and to ensure the string contains only the characters you were expecting.
I'm not really sure what this pull request does at all, but as a start ... indentation on this like looks weird. Additionaly - this particular element should not be added on Windows servers as they would ignore the case. Try this, with some comment added above it:

    if (DIRECTORY_SEPARATOR !== '\\')
    {
        $trysubs[] = $dir;
    }
Ну, а вообще, вот:

NSString * arr[] = {@"A", @"T", @"G", @"C"};
int index = random() % 3;
if ([[DNA objectAtIndex: indexToMutate] isEqualTo: arr[index]])
   index = 3;

X        A    T    G     C
P(X|A)   0   1/3  1/3   1/3
P(X|T)  1/3   0   1/3   1/3
P(X|G)  1/3  1/3   0    1/3
P(X|C)  1/3  1/3  1/3    0
И итоговая:
P(X)    1/4  1/4  1/4   1/4
@voleg ок, далеко пойдёте.
Работает.

Если вкратце то логика такова:
В первом for вычисляем позиции, в которых будем заменять гены. Сохраняем индексы в массиве changedPositions и проверяем что бы они там не повторялись.

Во втором for производим замену генов по сформированным ранее индексам, при помощи функции (NSString *) findGenNot:(NSString *)current получаем ген, отличный от гена находящийся на выбранной позиции.
А где порекомендуешь почитать об этом на русском? А то я пробую читать в официальной документации, но мне сложно дается понимание на английском языке.
Почему Вы сначала используете countDNA, и только потом ее инициализируете?
Забыл убрать.
А зачем cellIndex - строковая переменная?
при сравнении объектов лучше использовать isEqual
пока еще не завалил =)
можно поправить и сделать новый коммит
"Appendix A provides a reference guide of common Diamond terminology.  Appendix B lists commonly-used Diamond attributes and attribute types.  Appendix C lists server and filter-specific statistics values."
Do we need an 'else' here, as long as we are returning if index == -1?
Where does 1.3 comes from? Is that conversion between points and pixels or heuristics?
You are right. Why are we passing render_node which isn't used?
I have in mind something like this:

```
import logging

logger = logging.Logger('mne')
logger.setLevel(0)

def verbose(f):
    def dec(*args, **kwargs):
        verbose_level = kwargs['verbose']
        old_level = logger.level
        logger.setLevel(verbose_level)
        ret = f(*args, **kwargs)
        logger.setLevel(old_level)
        return ret

    return dec

@verbose
def my_function(verbose=None):
    print logger.level
    logger.info('foobar')

if __name__ == '__main__':
    my_function(verbose='DEBUG')
```

where the logic of printing or not is in the logger not in the code.
mne.Covariance should not be advertised as a read option. People should use mne.read_cov. I'd remove this line.
why are there changes here?
typo: "purpose-built"
`fromMaybe respond404 res`
如果我设置了2秒，就是至少2秒，这里更加应该是的是加 200ms，而不是减。
I suggest: "...to the database." and "the object knows how to persist itself."
You must go to your fork and repo: http://github.com/fazae/symfony-docs/tree/path-1/ Find this file and edit it. Then you save the file with a commit with a message and you are done.
I thought it might be slightly less brittle to check for createSVGPoint (perhaps something like JSDOM might implement in a strange way?), so I made this change anyway.
Are you sure `map!` won't modify the original array? After the dup two lines above is not a deep dup.
Ох, блядь, мой косяк
@AlphaGit 

Location creo que no necesariamente es la ubicación del archivo original, de hecho creo que por eso elegí CodeBase (igualmente este código ya estaba, solo lo moví).

¿Que recomendás?
Specify formats and target systems.

Formats: PNX, Xerxes normalized XML, OpenURL, RIS, BibTex ...
Systems: Primo, Xerxes, Umlaut, e-Shelf ...
cc.KeypadHandler
yeah. () are optional in ruby
why not a if else w/ the `if not needs_server and if needs_server`?
Same here, no annotation?
You mean remove the flag and just affect the subordinate fields ? Not sure I like that.
Hahaha, yeah sure, it is ok, lets not create more trouble if not necessary!
Ok makes sense. What about methods that have input keys? We have to send task to a node where key resides (node is primary owner) and in such cases do we disregard execution policy or make it best effort (is there is a node that fullfils DistributedTaskExecutionPolicy - fine, it not breach it?). Thanks in advance and let me know your thoughts.
Later this day, i have a meeting starting in 5 minutes, will end at 5´o clock...
I'm not sure if we should deal with this small issue here: bytes is a keyword in python. Changing that would, I guess, break backwards compatibility.
`plt.bar` or `ax.bar`? It probably doesn't matter...
@efiring Hmmm. I thought a numpy version independent way of checking whether something was a number would be neater. I guess we do actually want floating point numbers here. I can't find a cbook.is_floatlike, so this way is probably better, you're right.
Koppelteken (-) hoort hier niet te staan; "...lezen en te becommentariëren is."
add least this method, and probably encode/decode too, should be APIMethods
This file is intended to be used by applications that use the gem so that they can mock out a request without needing to grok the inner workings. It's used by the gem's specs in the same way that an app using the gem might (integration specs).
It is a precondition. I just added the note to point out why there's a precondition. Doesn't seem to do a good job of explaining it.
Deforestation or "clearing activity" :D
We're using the same length of hashes that GitHub uses for their short hash implementation.
why do you change precision here? if you need a lower precision make it an optional parameter!
No, to be honest. How we can make it more understandable?
Exit early:

    if ($response->getStatus() == 200) {
        return $body;
    }
    
    // error handling here
I agree, conn/ is right.
Now they all refer to the abstract class with @see annotation.
Here is a comment
Are you sure the variable ``$fields`` exists, or did you maybe mean ``$field``?
Kikoulol
I'd change "feels custom made" to "matches Art.sy's visual style" or something like that
This is not needed, is it?
Hmmm. I can't get it to work:

    curl -H 'Accept: text/plain+diff' -D-  https://github.com/mojombo/grit/commit/06f63b43050935962f84fe54473a7c5de7977325 | grep Status

gives me:

    Status: 406 Not Acceptable
With `+` interpreter creates several `String` instances in memory and then build one long string. With / interpreter parse several strings to one long string. So, less unnecessary objects are created.
Solid point.  I'll adjust that.
the status is a boolean
for performance reasons, try not to use Item unnecessarily. it usually means your object heirachy can be simplified. I don't have any instant suggestions to mind, ask if you can't figure something out.
Either make private or move to a utility class.
I'm not sure I get this, what if sinatra is distributed as a gem?
@joshk :D

Fixed here: https://github.com/drogus/travis-build/commit/01982f1c08b350c69b17f2616c2fcc24b51ff774#L14R119
these we can maybe move out to the constructor just to keep a bit of bloat out if this method.

```js
this.redirects = [];
this.on('redirect', this.redirects.push.bind(this.redirects));
```

or something
Here was a mistake, it should be `tmp_value` instead of `value`. It is the same logic, but less readable.
But this produces an error:
AttributeError 
Exception Value:	'module' object has no attribute 'ReferenceField'

In test_app this is used:
class CustomerResource(resources.MongoEngineResource):
    person = tastypie_fields.ForeignKey(to='test_app.api.resources.PersonResource', attribute='person', full=True)
Rename to `get_image_url`.
You are still attaching data here again, why?
And you also do not even configure this date to be updated. So only post diff time update overrides both times.
Ok, but this is still not good.
'answer' -> 'response'?

>also names
I do not understand this.

`message` -> `server`?
No, I understand you perfectly. And I would like to guide you to the answer. But you resist. :-)

So, please. Check. Is really `success_url` used in super of `form_valid` or are you writing garbage? Check Django source code.
Don't rename variables. And probably you do not need to store request.user into a variable. Just access it directly.
No unnecessary empty lines at the end.
Even if tasks gets scheduled in between?
Actually, requesting "payload" should be JSON parsed object.
Мы вроде русские, а для стороннего люда  в наших комментах ниче интересного нет, так что давай эту ветку по русски. 

По идее - да, мусорящий код в проекте быть не должен. Но в данном случае я его оставил, т.к. к примеру у меня используется лямбда функция, а не create_function(). 

Я о том что оставил для тех людей которые сами хотят поковыряться, и на тот случай когда наконец настанут те  самые времена и нам не придется заботиться о  < PHP 5.3
this does not follow the coding standards. curly braces should always be used
Is dataset.value.size + 1 a valid stop index?
minor typo -> `Non`e
I noticed that afterwards :$
Adding variable to exists VariableDeclaration is better.
no need for the fully qualified name
new npc_vladof_the_butcher; -> new npc_vladof_the_butcher();
Die Klick-Listener werden so bei jedem neu lade der liste neu gesetzt, muss das so sein?
Reicht das nicht einmal initial? Oder hängt das von der Anzahl Einträge in der Liste ab?
The problem I have is that I call `nginx::proxy` in another class, and it doesn't include the `nginx` class, even if I tell it so, so the dependency on `Exec['nginx-reload']` is not met. Doing this fixes my issue.
Then please remove and fix docblock
Never liked this type of conversion, but we need to handle it for now I guess
My understanding is that this condition is just listening for certain query string parameters in order to tell the security layer to intercept the request -- then inside [...]\Bridge\Consumer\LightOpenIdConsumer we will check whether or not the identity is valid in the complete() method with `if (false == $lightOpenId->validate())`
These'll be purged when I add the s6 supervisor support. Cheers!
I will correct that too.
It´s for disabling the debug package
We should introduce the `$("body").on("click", ".foo", fn)` syntax here as well.
there is already a debug message above.
When I run this on my box, without special casing the STANDALONE, the maven tests fail when run on the hbase-maven cluster.
I like the idea of prompting the user for a yes/no response when they don't specify --confirm, rather than forcing them to run the tool again. A yes/no prompting method is included in BaseTool.  Check out the uninstall tool for an example of its use.
having a comment to tell what this resolution thing is would ease understanding :)
if this exception is only for the tests. why making it a first class citizen in circus.exc ?
If you do not want to improve the example, just remove it.
// The resolution value for this promise. May be either
    // - `undefined` (if the promise is not fulfilled yet)
    // - a promise `v` (if the promise was resolved with a promise `v`)
    // - a pseudo-promise (if the promise was rejected or resolved with something other than a prommise)
    var result;
The same here: is this really a service as we usually use services?
Here it's obviously always an `id`? :)
uh oh, thats the .lock file so its all fine i guess.
These changes feel less readable to me than the previous solution, albeit more compact.
How do you mean streaming? I separated this method from `load_collation_elements_table` to be able to stub the latter with a string in the specs. That's why I chose a neutral `table` name for the argument.
The conditional is there to allow a user to pass openvpn_user => '' (or leave it blank since the class defaults to this) to the openvpn::server class and accept the openvpn default. Otherwise they can specify a user and group to drop privileges to.  The point of the conditional and the default of the openvpn:server module is to use the defaults of the openvpn package on ubuntu (nobody:nogroup) when the user doesn't specify a group or user, and to make it easy to specify which user and group to drop privs to. If the user wants this stanza completely removed(which would make the openvpn server run as root) then they have to provide the rather un-obvious empty string to openvpn_user and openvpn_group, but that is not terribly likely and the user could always specify openvpn_user => root and openvpn_group => root.
Why the extra / before the filename? I don't think any web servers do that.
why not move this into DEFAULT_ATTRS?
Looks good.  I changed the links in demo6 (on #243) to be the wiki page now too.
That's what I meant by "any specified input files".  But it doesn't hurt to be more explicit.  I'll add that clause.
Hi, Gary
Double **to** here
Did you mean to delete the `return`?
Hmm, was this line unnecessary?
These long docstrings in tests make the spec output hard to read.  It's better to have a short meaningful docstring and put these long descriptions into comments. 

I've done this.
@markstory Yes, by moving the check for 'allowedEmpty' out of the helper method, and have the _parseRuleRequired return true|false
ah, but super.isPublished returns the supertype's builder, and we want to return this type's builder... we could cast it,? i.e. 
return (Builder) super.isPublished(isPublished);
Did not know about intptr_t! Sounds good. I don't like this part of the code that much, but I just want an easy way to use a `git_vector` to store an array of integer values instead of pointers.
OK, i think i tried that but ill try again. I initially had a comment here that said where it was copy pasted from but removed it from the final commit.
why the delta?
Unde anume, ca nu vad exact portiunea de cod la care te referi.

Chestia cu if in loc de switch a tinut mai mult de gust in cazul meu. :-)
This code was largely copied from the NatNet example. It could be cleaned up if necessary.
Moved the rspec dev dependency to aeolus_cli.gemspec.
Extension == null четырями строчками выше, и снаружи try{}
Catch NumberFormatException instead, because:
- that new IllegalStateException of 3 lines up will be caught :)
- Catching Exception endangers sweeping exceptions under the rug or report them incorrectly.
Good point - what do you think about me adding a boolean 'async' field to the testInfo?
As this branch of the bundle requires 2.1+, you can simplify it: 

``php
->enumNode('json_declaration_method')
    ->values(array('format_param', 'accept_header'))
    ->defaultValue('format_param')
->end()
```
Done. Function removed
We've been using the django_extension fields CreationDateTimeField and ModificationDateTimeField:

https://github.com/django-extensions/django-extensions/blob/master/django_extensions/db/fields/__init__.py#L154

I'm interested in hearing your opinion if these are better than doing this like you're doing here.
to be compare with 

out.fill(0.)
out += res

or

out[:] = res

which should require only one pass on the data
It leads to a much bigger difference... but in an unexpected way: the new `predict_proba` seems more efficient.

```
In [4]: t = np.random.randint(0, 50, (100000, 1))
# With the previous `mode` implementation:
In [7]: %timeit model.predict(X)
1 loops, best of 3: 3.62 s per loop
# With the call to `predict_proba`:
In [7]: %timeit model.predict(X)
1 loops, best of 3: 3.08 s per loop
```
I guess this should be ``array or sparse matrix`` (also in the line below).
Done with !ifs.
What happens if I call `[myFileManager.cacheSchema setDownloadCacheDirectory:newDownloadDir];`? Wouldn't the `RZFileManager` and the `RZCacheSchema` be out of sync?

We should probably only store this in one place and have both `RZFileManager` and `RZCacheSchema` use it.  If we store it on the `RZFileManager` and give `RZCacheSchema` a weak reference to `RZFileManager`, then the download directory would stay consistent if cache schemas were change.  On the other hand, if we store it on the cache schema, then the download directory would not get littered with files using multiple caching schemes.
Yeah, it doesn't appear to do anything. I'm just going to remove all of it down to something simple

```ruby
def parse_fulfillment_response(op, document)
  { :response_status => SUCCESS, :response_comment => MESSAGES[op][SUCCESS] }
end
```
Exemple de fichier de configuration Nginx (Ok pour Example mais pour l'anglais seulement)
Syntax is rearranged a bit, but it should be functionally the same.
If I'm reading the changes correctly, `init` will be set to true if `LoaderHelper.init(Class<?>)` is called with _any_ class, even if the `org.hibernate.ObjectNotFoundException` and `javax.persistence.EntityNotFoundException` classes could not be found. Thus, is the above assertion failure message really accurate? Perhaps "LoaderHelper not initialized" is more appropriate.
EVENT and CRON aren't really statements, they are parameters to WHEN/NOTIFY to describe what kind of event is used for the communication.
commit and push.

If you do:
```
git checkout create-error-500-template-799522
git diff master...
```

Does it mention the `vendor` part?
`if (!options.partials) return fn();`
Seems like the argument is either `#riak_search_schema{}` or `binary()`. Also, returning `{error, badarg}` rather than raising it (or letting it fail a match) is strange.
Yes, but explaining own mistakes with mistakes other have done is a bad idea. If unsure, consult the WIKI: http://old.ethersex.de/index.php/ECMD#Bekanntmachen
This was glenn and I suggested the same. (set / unset). Glenn, however felt strong about add / clear with add being fatal when it already exists.
I think you are correct. "keystone-manage pki_setup" should be run conditional on there being no external CA in use.  If we  are using an external CA then we should be copying in the signing certificate.
http://docs.openstack.org/developer/keystone/configuration.html#signing-certificate-issued-by-external-ca
No.  It is simply discovering the ip address of the given bind_interface (`node["keystone"]["listen_interface"]`) to have keystone listen on.

Rather than hard coding it to '127.0.0.1' we set it to 'lo' which will in turn become '127.0.0.1'.
We give the operator the option to say what interface keystone should be bound to.  Some ppl may bind to eth0's IP others bond1.2001 (like us).
New dataprovider deal with this one too.. sorry for not updating sooner.. Look for UploadImage tests for an example of joining to of them.
This is broken as there is no Exception class in the current namespace.
Thanks, I couldn't find any documentation on that.
Why the change from `private` to `protected`?
print_status "Retrieved domain #{domain.inspect} from registry."

Would help make output a bit clearer

[*] Checking locally..
[-] Error accessing C:\windows\SYSVOL : stdapi_fs_ls: Operation failed: The system cannot find the path specified.
[*] domain "xxxxx.com"
Users of the TcpServer mixin normally do not call run (this is handled by the mixin). The recommended method is to def setup() for module initialization. If you still want to caller run, you would need to call super() first
esmesho bezar darbare ma va ghable class ha bashe
The exception is probably better since it would have helped us find this problem a bit sooner, and certainty would help an end user.  If we come up with something better later, we'll go with it.
The mass_edit view already defines the form, so the partial doesn't need it. If this partial is used elsewhere, make sure it's being wrapped in a form block the same way the mass_edit view does it.
The stuff from 2011 should have 2011 on it. If you are writing it *now*, it should be 2012.

However, ideally we could avoid using the date at all. I've asked @joostdenijs about this a few times, but haven't gotten a clear answer.
@abstractj Hey Bruno, I've pushed a commit with improvement (hopefully :) ). Let me know what you think.
Not sure inputted is a word. How about entered?
I'm not touching that with a 10 foot pole :) The only way to solve it, AFAIK, is to implement our own tree walker that checks to see if there is anything that will load asynchronously and listen for the load event on each node. Suffice to say, it would be *very* complex and performance would suck.
ok I'll add a null check here
I'm not opposed to adding a configiure(Properties) method to the ConfigurationPersistence, but this was just a more immediate fix.
JSDoc фактически правильно оформлен, но так же не читается.

```
/**
 * Конструктор события
 *
 * @param {Number} start Дата начала события. Если не является типом number, дата не верна, событие не создаётся.
 * @param {Number} end  Дата конца события. Ес...
 */
```
_onCanPlay doesn't take an event parameter. Hence, the function expression is necessary to accept the event argument, but ignore it. I did it this way to make it easier to later add tests for _onCanPlay. By not requiring an event object, I don't require the tester to pass me a fake one when writing a unit test.
i will pass a QString as an argument, containing the URL of the repository that has to be added
The previous language seemed similar to test suite phrasing, where the new language favors full declarative sentences (i.e., for humans). But the difference is minor, and either works for me. I'll revert.
довольно стандартная практика вместо описания своего использовать стандартный так:
assert(2 + 2 == 4 && "strange arithmetic");
Just a quick note, I think in general it is nicer to use #if instead of #ifdef for cases like this, you can then also explicitly disable it by defining it to zero.
I already added that to the last paragraph in http://paparazzi.github.com/docs/master/stylec.html
See http://forum.dlang.org/thread/blrglebkzhrilxkbprgh@forum.dlang.org#post-blrglebkzhrilxkbprgh:40forum.dlang.org for further discussion.
I'm not getting cute, this is specifically what ˋdropOneˋ is made for.

> It doesn't effect the performance.

But it's wrong.

Needle I need saved, then I need to pop the saved version. Ergo, ˋneedle.save.popOneˋ is the perfect call.

haystack, on the other hand, I need first to be popped. I need to keep the popped version, as well as pass a saved version.

If I used ˋhaystack.dropOne().saveˋ, then *my* haystack will actually be left unchanged, which is not what we want. There needs to be a call to popFront on the actual haystack, before calling save.

How did you benchmark this? Did you also unittest it?
This is completely wrong semantically: lines are just glorified function.  
Thus they logically follow convention ( static opCall == function-like entity )
Please remember to remove the ` character from this string when applying this patch. As far as I know, this escape character will only work for MySQL.
> On desktop, this wipes, at least I think it does. Worth checking with rnewman.
> 
When a desktop client detects a disable, it wipes the engine's data on the server (by asking the engine to do so), removes the engine's entry from meta/global, and flags meta/global for upload.
`replace` calls `updateBookkeeping`, which writes into `parentGuidToIDMap`. (So does `insert`, but I imagine this patch changes that.)

If we reconcile a folder and replace it with the remote GUID, the insertion manager won't know about it, right?

Similarly, `retrieveRecord` uses this map to fetch children for a record during store and fetch. It must be kept up to date.

Did you address these points?
maybe using String.format here?
this was what broke windows.
getPixelFormat was not implemented by ofQuickTimePlayer so internalPixelFormat was being set to junk. 

simple fix is to make ofBaseVideoPlayer return OF_PIXELS_RGB unless over ridden.
Since any user in the Admin group can now triggerRefreshAll() the user ID is now important in the event.
you should revert this formatting change. there is not line length limit in the Sf2 CS (which are also used by Doctrine) and method signatures are kept on one line
DRY out $(data) ?

I don't know how expensive jQuery's JSON parsing is, but don't want to let it accumulate.
Han ... it was merged, i open a new pr to this that
This is a generall question. Should we comment all (even I think this isn't really necessary) or nothing?
all updated to use writeElementNS.
`,` at  end of line
Okay, will move that, thanks.
FindAllOrders()
I changed my mind on this.  It's really hard to know if the user would prefer product-specific tags or product non-specific tags.  Really, the safest thing is to just create product specific tags, if they don't already exist for this product, so that's what I'm going to do.
We should break these callbacks out into separate functions, as per my comment above
Added in better documentation
is function is very long. We should break it up into multiple functions.
Default template file now using more semantic markup + thumbnail image support.
s/ZSER/ZSET/
Why did you remove this event?
Some javadoc would be nice
write this so that python can preallocate the list
I'd rather you be more explicit about catching that there were no movies returned. Here you are returning nil if there was any exception.
Lisäksi pitäisi vielä katsoa, että alkiota ovat samat, samassa järjestyksessä. Ei pisteitä tästä, mutta korjata toki saa.
It's on my branch :)
Indeed. Thanks for feedback.
It's a fair question and a good point. Thinking about it though, I'm not sure why someone would store their data in eventsource format instead of just bare czml
I have no idea what you mean.


On Thu, Nov 1, 2012 at 2:37 PM, Walt Askew <notifications@github.com> wrote:

> In providers/app.rb:
>
> > -    Mustache::template_path = ::File::join(version_dir, 'gbtemplate')
> > +
> > +    context = node.to_hash
> > +
> > +    gearbox_data_bag = data_bag_item('gearbox', name)
> > +
> > +    (gearbox_data_bag['searches'] || []).each do |search|
> > +            matching_nodes = search(:node, "roles:#{search['role']} AND chef_environment:#{node.chef_
> environment}")
> > +            results = matching_nodes.map do |result|
> > +                { search['attribute'] => result[search['attribute']] }
> > +            end
> > +            if (search['multiple'] || false)
> > +                context[search['name']] = results
> > +            else
> > +                context[search['name']] = results.first
> > +            end
>
> So, this is probably me not knowing ruby, but this do block is in a map.
> Shouldn't the block return a value for the map?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NarrativeScience/gearbox-cookbook/pull/3/files#r2009137>.
>
>



-- 
Tom Howe
Senior Software Engineer
Distributed Systems Lab
University of Chicago/Argonne National Laboratory
Thanks @badtoyz.
please fix the CS. Curly braces should be on their own line for class and method definitions
It should be in, I'll change that.
>
> [do away with](http://idioms.thefreedictionary.com/do+away+with) is an
> idiom I've learned recently.
>

Nice, thanks for sharing!
Good catch! It's meant to be used in line #25. Fixing
This is a bit overcomlicated, how about:
```python 
if not self.field_type in ['radioselectfield','multiplechoicefield'] :
    self.selectoptions = None
```
ok, I am not the author of a colleague
лучше сделать функцию constructRoot.
The wording makes it sound like it exits via calling launchActivityForResult.  Need to change up the wording.
Can you quick alias constants?

    var v = this.constants.__values__;
    v.size = {
If it's good for them, it's good for me. :)
Note: I discovered after this that there is a PluginWorkspaceProvider with a static method to get the current workspace object.  I was passing the workspace from the plugin to the actions because I wasn't aware of an alternative.  We can switch to the PluginWorkspaceProvider to simplify this code a bit, including the constructor for the SelectionAction classes-- although I don't think that needs to be done before we close out this pull request.
Behövs inga sluttaggar för PHP filer om man inte vill
UserTransaction shouldn't be required to be on client classpath as it's not used on the client side. It's provided by the runtime environment in container.
Am I blind?
I don't think you need to call 'revalidate'.  If there's a session token in the original request, the authentication filter has already validated it and added the user name/id as a request parameter.
why can we remove this? calling documentManager->getRepository(null) will fail.