labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah I think the plan is to have separate url prefixes.  So once the 3.0 goes stable the top level directory will then be 3.0, but the 2.x docs will exist in book.cakephp.org/2.0/ or book.cakephp.org/2.x/ at least that was the plan I last remember talking about.
未授权的状态吗应该是401
Es ist die Methode $grouprequestValidator->apply($form); welche die Werte aus der Form auf die Felder der GroupRequest mappt. Daher müssen auch Felder, welche nicht in der Fom vorkommen (ParentGroup und Requester) von Hand gesetzt werden.

Zudem ist es wichtig, dass die Felder in der Form gleich heissen, wie die Felder auf dem Objekt... Ansonsten funktioniert die Methode "apply" nicht.
Is the last  for loop above necessary?  Seems like it should be dictionary access instead of a loop, something like self.gui_set_param(param_name,defaults[param_name]).  The for loop is able to handle cases where there are multiple parameters with the same name, or no parameter with that name, but it doesn't seem like either of those should be valid conditions.
Sorry, I mean that they're not guaranteed to set errno. The kvm_* functions clobber errno as a side effect of how they're implemented.
Control the Database Profiler to Measure Performance? 

We're not actually analyzing the profiler results.
can you fix this and the previous entry.
I would make the filename 

create-an-auto-incrementing-field

no reason not to, and it mirrors the title.
We should not use the term "records".
might this fit better in the administrative guide? Move if that feels like a better place for this given it's applied nature... it's sort of a shame that there isn't an applications document for sharding. Perhaps ponder the implications of creating one and see if there are other sections that could migrate.
Good catch, updated.
no, that's a good nit. I toyed with a few different names.
this stuff shouldn't be in base.py. it should be in your local.py where is it private.
Please use `ip::ipv6` here instead of `_`.
C'est arrange. Toute page est soit fluide ou non-fluide mais jamais melange.
Two functions please.
`$extention_groups`?
Missing var. Same below.
Tab on this line, please remove it.
eol at eof please.
Space after // and focus the username textbox.
@var missing.
what happens if the check is already in the table?
Please split pull requests, one issue at a time.
We are not supporting windows yet, but msvc is mentioned below :)

Your suggestions?
You should really remove this filter :dancer:
add a test somewhere that checks that multiplies(a, b) with a and b tables of int64 does indeed generate a multiplies_ node. If it generates a map node, then we'll need to change this to have a disable_if with any is expr or something
Replace with `return (extension != null) ? extension.Substring(1) : string.Empty;`
got rid of most of the inline css...
work with astha (designer) to ensure you're showing all needed patient fields (There may be more which aren't yet pictured in the designs)
missing whitespace around binary operators.
I agree with @pelson - this name is confusing. I suggest we make it private as well.
空格缩进 保持一致
Oops. That code is not supposed to be there.  And I'm talking about the whole for loop.  I'll delete that in a further commit, but since it does nopt change functionality, I don't think a version number bump is needed.
This should be a clean kill, not a comment.

OR better yet replace it with tests for the error cases that remain -- self-unions and unions of multiple partitioned tables
Why not include the "m_isConfiguredForHSQL" on this line, rather than twice below? (minor point)
Don't use hard-coded links. Use ``reverse`` with the URL name.
My IDE has no problem coloring it correclty, so I have no problem with it
Ah, this was just a typo, I copied the document...
Is there any reason that this should exists.  I thought this was superseded by the new canonical way for modules to enter the simulation?  The only invocations of this left are in a couple of concrete model tests (RecipeReactor, StubConverter, and SWUeUF6Converter tests).  We should eliminate this from the API before external developers start using it :)
I think `create` should respond only to XML format. Now it responds with XML to HTML format.
are you sure we need this?  You can call something like

```ruby
render :xml => @notice.to_xml(only: false, methods: :id)
```
in controller. BTW, what about url tag?

```xml
<notice>
  <id>9ef134aa-2118-9e28-fc51-cd52ecf75b91</id>
  <url>https://errbit.herokuapp.com/locate/9ef134aa-2118-9e28-fc51-cd52ecf75b91</url>
</notice>
```
The precedence of lambda arrows should be such that you can elide the parens, as in `driver >>= d1 => driver >>= d2 => simulate(...`
Thanks @gibson042 , I like it!  This is my first time working with the jQuery unit test framework; I didn't notice the existing form in index.html.
Could you add the assert statement here, similar to regress/linear.sql_in, to check the coefficients?
Is this With support in the middle?  It seems self.inWith is not used effectively.  I'd like to see drop table here in __exit__
Should this line read

    def timeout(timeout = false)

Otherwise the example in line 194 won't work.

Writing `...find.timeout` for using no timeout might also be a little confusing.
Any reason `include.install 'glm'` won't work?
No need for this chunk of code.
I've included this in the interim until index.rst is fleshed out and properly structured. Not sure where to index it at the moment.
i cannot see where the redis_config values are from when running the tests?

    def __init__(self, dispatcher, config):
        self.r_config = config.get('redis_config', {})     #where is redis_config set?
        self.r_prefix = config['dispatcher_name']
        self.r_server = redis.Redis(**self.r_config)
Can BufferingTracerTests also use this mixin?
not testing for string before splitting?
Yep, we should. I'll have this throw something readable.
Sorry, the comment was in the wrong place. I was not objecting to `( foo )`, but to the realignment of the `Pod::FInd:::pod_where` lines *below* the comment. Sorry, haven't used GH diff comments much.
Removed the help method: https://github.com/linepress/wp-cli/commit/b1d709c024f45b190b8ba5b4e1e28f9712477362
Assign to an intermediate variable. It's possible that another thread could set this to null in between the check and trying to call dispose:

    var repositoryCreationWatcher = _repositoryCreationWatcher;
    if (repositoryCreationWatcher != null) 
    {
        repositoryCreationWatcher.Dispose();
        _repositoryCreationWatcher = null;
    }

Something like that.
Can you write a test to ensure `_makeOrFindRecordFromData` works as intended? Perhaps just asserting that deserializing two identical sets of data doesn't result in two records in the `setsByRecord` index?
This if statement should be split up into two separate plugins or code-files or anything. Makes unit testing also easier because switching environments isn't necessary.
No, because we won't be completing class names anytime soon
Here we provide only textual css-builtins completions
why are we removing quicksearch anyway ?
reports/base_template actually now extends reports/standard/base_template (I forget exactly why, I think it was because having saved reports in the template that all reports extend from broke certain reports or report-related pages that didn't have a domain), so standard/base_template defines reports-js-inline as a sub-block of js-inline which extending templates are free to replace or append to.  https://github.com/dimagi/core-hq/pull/300/files#L7R21

Look for sms-js, you'll see a similar thing there.  Not sure exactly what the alternative would be.
aren't those 2 cases exactly the same ?
Shouldn't be 
@param {GeoExt.data.PrintPage[]/GeoExt.data.PrintPage} pages
?
protected methods deserve javadoc too.
maybe we should use `git config` here to store the value in the git config instead? Thoughts?
Never copy-paste code. ;-)
Can you explain a bit why... Both values are still the same at this point.
It doesn't look like the actual tracks get updated.
should this be renamed to with no id instead?
These event listeners aren't actually doing anything now. Could you remove them and the entire if block around them?
You probably want to remove this unless you want to have a default name for people to save their projects when they remix this one.

i.e. Opening Butter with this saved-project data already gives the project a name. Not incorrect, maybe just strange.
Remove this blank line, so the return is clearly paired with this assignment.
The whole `readFile` method can be simplified:

```php
public function readFile($filename)
{
    $fs   = $this;
    $size = null;

    return $fs
        ->stat($filename)
        ->then(function($stat) use ($fs, &$size) {
            $size = $stat['size'];
            return $fs->open($filename, 'w+', 0644);
        })
        ->then(function ($fd) use ($fs, $size) {
            return $fs->read($fd, $size, 0);
        })
        ->then(function($data) use ($fs, $fd) {
            $fs->close($fd);
            return $data;
        });
}
```
I can see the merits of an exponential backoff (as that kind of algorithm is generally called) but I'm not sure we need that added complexity yet.  The requests from the background job will not all  run at the same time, they're still run sequentially but in a separate process.  So I don't think we need to worry too much about overlapping requests - we won't get 100 simultaneous requests unless we have 100 worker processes.

If this backoff is clearly important later on then we can implement it.  Until then I would prefer to keep this simple.
See commit message of corresponding commit:
44474dc405dceeb661abac26d9c93d517de3c773
Is not just enough to just remove those quotation mark after -qa ? I.e. change it to:
ouput = `rpm -qa >> #{File.join(target_dir, "packages")}`
I think this change broke our nightly build:

http://koji.katello.org/koji/taskinfo?taskID=14694

When doing these complex changes, pls submit SRPM into koji. It is just one command, as Mirek showed on the deep dive.
Because:
+class CustomInfo < ActiveRecord::Base
...
+validates_uniqueness_of :keyname, :scope => [:value, :informable_type, :informable_id], :message => "already exists for this object"
so, it should rather be:
add_index(:custom_info, [:informable_type, :informable_id, :keyname, :value], :unique => true)
Sorry,  you are right, I checked printer.py in wrong branch, which is not up to date
??? we will use
prawn in >= 1.0.0
ruport >= 1.7.0
or am I missing something?
why not make this a `scope` instead of a class method?
if you are fetching children lazily, you should probably more it after the check on the depth
returning nothing is the same than returning ``null`` in PHP.  And anyway, Monolog follwo the Symfony2 CS which say to omit the ``@return`` tag when returning nothing
Just to have a mode to hide the wrong buttons being displayed while loading
Is IndexedDB disabled by default?
Can you remove this function for now?  I understand the wish to have it, but this is a more general conversion utility that belongs either in `astropy.coords` or `astropy.tools` .  Or, if you like, create another PR to put it in `astropy.tools`. Although I am planning on doing that very soon with a range of different transformation functions (2d polar, 3d cylindrical, etc.).
Correct - took me a while to realize that, but I never saw a reason to implement convolve's None approach in FFTs since technically for FFTs a kernel must be the same size as the image.  I think it should be possible (even easy) to implement, but I don't know of any use cases.   Would it make sense to have the zero'd regions in convolve's None behavior (i.e., the pixels that get set to zero because the kernel goes outside the bounds) be set to NaN in some cases?  I don't think it should be the default behavior, at least not for FFTs, though.
Sure I understand. The effect is probably negligible anyways.
Move this into `make_rebalance` and uncomment it. Unlike original sim, we no longer print "After rebalance" after different sets -- just dump rins without any context.
Now we have elementExists() users can check for themselves, like in ticket 398 is shown
Couldn't we listen to `click` on the `ul` element instead of on the individual `li` elements?
Why did you add the maven-specs2-plugin? From what I experienced, surefire launches specs2 perfectly fine (it did not previously because *Spec files were filtered out, see 5c37126d209f2f2edc4ba1020171a9daa2ea2552 and 013dd734bbe236da99c37255b26def298fcf46aa.
should probably be :timestamp in the options hash, a little too terse otherwise.
Since there are only two states to the bonus:
1. Activate 'target'
2. Drop 'teleportation' object

I'd prefer a boolean instead of a number.
I didn't have any luck with this queryhistory call. Modded to be
```
VersionControl.QueryHistory(pathFirstBranch, VersionSpec.Latest, 0,
                                                          RecursionType.Full, null, tfsBranchToCreate.Properties.ParentBranch.Version, VersionSpec.Latest,
			                                              1, false, false)
```
I guess first you want the other way around, set `True` as default, and `False` if the typed text contains `%#\....`.
works better : `ti<tab>` -> `time` but then it fails if you do `%<tab>` where it fastforward to `%%`
my bad .. did not read a line ahead, :(
This should be GIT_WIN32, no.?
Yeah, unless both `.remote` and `.merge` are present, the tracking information is not there. We should probably return `GIT_ENOTFOUND`.
Instead of hard coding the full URL, you should use `{{ url('wiki.document', 'websites-say-cookies-are-blocked-unblock-them') }}
Nit: --screen -> --pbport
The file is using 2 spaces for a tab for most part but, I know we use 4 in general so, I will send a separate commit to fix all the indentation issues.
Passing "None" as an argument to bid.authenticate is not advised.
this file should be ignored also. Its generated by Symfony.
Tu as totalement raison. J'ai du être inattentif avant de faire cette modif, et me suis ensuite laissé convaincre que ce `Environment.url_expire = True` changeait le comportement :-/ Désolé pour la confusion !
and once you change the domain, you can drop the ``security.`` prefix from all keys :)
Silex in a Symfony component ? Really ?
this was a wrong statement.
You can potentially break stuff with this (think of a heredoc with multiple empty lines). That must be removed.
$data['options'] => $data['methods'] ?
True, I don't like it too much either but right now I don't see a simpler yet effective way of doing this. I'll try and come up with something better.
could you fix this line too (``@param`` and the alignment of the description)
Is this a modified or not thing?  If it is, you'd do better to use ok() and notModified()
Looks like its over 80 chars.
(d+1) -> n-cell
If nthreads == 0 we should probably do something sensible - either fail or just use a single thread.  I guess I'd vote for just using a single thread.
Good catch.  Amendment coming, then merge.
No, it's something I forgot to remove.  Plus, if we don't use <tt>include</tt> statements in our iptables templates, then I think the if condition can be removed.
Blank except
Part of the problem is that it isn't clear what the purpose of this test module is. In reality because of where it is you are testing the **non** matplotlib component of wms retrieval. After that you will want to create a test under mpl which tests the matplotlib interface to that functionality. The latter has a simple setup to enable you to do visual tests. The former is much trickier....
Want to add debug log for this property?
```js
VM.runInNewContext(content, {
        MAKE: Make,
        console: console
    }, rooMakefile);
```
On 12/05/2012 03:13 AM, liyangfnst wrote:
> In shared/cfg/subtests.cfg.sample:
>
>>                           remote_prompt ='#'
>>                           remote_ip = 193.168.221.166
>>  -                        remote_uri ="qemu+ssh://193.168.221.194/system"
>>  +                        local_ip = 193.168.221.194
>
> It looks like good...I will do a few changes for this check.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cevich/virt-test/pull/2/files#r2317715>.
>

Thanks!
Linking libSOGo with libcrypto will create a dependency on openssl, is that what you want, when considering your other patches?
we need setters such as `setOut`/`setErr` and an "internal" setter for `compatVersion` that would else need to be exposed elsewhere.
some of the interface methods also make no sense currently for embed, namely those filter related and, as I mentioned, all runtime configuration methods (I think I'll change them to throw `UnupportedOperationException` for now) since there's no runtime booting.

there's some package level shared logic invoked when the `Dispatcher` is constructed to initialize from the application runtime ...
> @timdream If the third param is not given, an error will be fired, see asyncStorage.js:line 88

Oops, that means the code doesn't do what the comments said. Can you help @davidflanagan and patch it?
same issue with the error dialogue, there's no updated code for it. Please be sure of rebasing the latest code before pushing changes.
I am not sure if we should keep this call here or not
nit: indent and | } else { |
add a local variable |var picker = this._pickerUnits;| and use a |var actives = picker.querySelectorAll(".active");| to save some iterations.
Give names to your anonymous functions and expand them instead of inlining them.
this specific line has been removed, but we'll leave all lines-shortening to the later refactor pull request
@sergivila, I was searching the wireframe in Dropbox OWD_Moz_Share which defines the app grid (in pixels) but I cannot find, do you know where it is? thanks Sergi (AFAIR it was in our Jira)
we can keep it as the curtain will still be shown
Should be `from projects.models import DEFAULT_INACTIVE_MESSAGE, Link, Project` as per http://mozweb.readthedocs.org/en/latest/coding.html#import-statements
That's the way it has been (I've never used/looked into oauth stuff). I'm open to patches/pull requests that make it easier for module users to use oauth/oauth2 authentication though.
It's comparing the ImportError message, which only contains the last part of the import path, at least in CPython. So == wouldn't work.
Rename to `handleClick`.
@solnic Try to use the do ```no-deep-freeze-etc``` branch of adamantium, IMHO it should work nicely.
This is pretty ugly, and will break when pids are re-used. There should be a smarter way to do this? Or maybe we don't bother, and use the SIGPIPE or write failure later to retry.
Can you change that to MomentsGroup?
`hljs` extension is no longer exist, use hl instead
You don't need to call the 'ceil' method on the outcome, dividing integers will return an integer i.e.

````
>> 10 / 3
=> 3
````
Replace module name with garmentbox_production
Split to multiple lines the calculation.
I’m also wondering what the cost is to returning the whole searchable content of all the documents, only to use the `link` field. Again, we may have so few documents that we don’t mind, but there’s going to be a non-zero cost to marshalling, transmitting and parsing it all. Then again, that’s a decidedly non-trivial change, so we may want to ignore it until we know we have a need for it.
another semi-colon reminder :)
well, this initialize method is not supposed to be used for wicket-related operations. the problem i'm trying to solve is that NewTileFragment didn't call TileEditorPanel's load method and therefor if you had any fields in your tile editor, you always had to initialize them in constructor, even though these fields will be overriden by load method when you edit the tile. please have a look at my FeedbackTileEditor.
I've included the debugger session (break at del self.source):
```
-> del self.source
(Pdb) hasattr(self, 'source')
True
(Pdb) self.source == None
True
(Pdb) step
AttributeError: BuildStatus instance has no attribute 'source'
> d:\ontwikkel\git\buildbot\master\buildbot\status\build.py(406)upgradeToVersion4()
-> del self.source
(Pdb) 
```
I think
```python
{'poller': { 'allowed': True}}
```
and
```python
{'poller': True}
```
are both reasonable ways of specifying 'allow all'.
Honestly, these pickles are going to die soon, anyway.  The sooner, the better, if you ask me.  You can leave the `.source` attribute.
*mutex_operation* might be more versatile, so you could have:

* mutex_operation-lock
* mutex_operation-unlock
* mutex_operation-miss
Isn't it already set by hmac module?
Methods that shouldn't be overwritten, because they're provided by `Router.prototype`
@randx You are right, need to find another way.
nope - `user area` use it. but it is useless here
preference is to use parentheses here: `def query(sql)`
After further reading, it seems that model is in fact required. Therefore this null-check is unnecessary.
`removeEventListener` ?
It seems fine to use `AddonManager.getInstallForURL` here
Removing all modules and sandboxes in a same turn as unload is problematic. It implies handling unload in the same turn of event loop.
Also it's not `loader.js`'s business to clean up sandboxes and modules, as that would imply this particular behavior for all users of loader.

That being said, you could do this from `cuddlefish.js` or probably better from `bootstrap.js`. Also make sure to do the cleanup after certain delay, otherwise it will force unload handling in the same turn.
(shane caught this) this is a no-no! string extraction cannot handle this type of thing.  the previous version is superior.
how does this work on IE8 & IE9 with CSS transitions?  http://caniuse.com/#feat=css-transitions
This is kind of a vague critique, because I'm running short on time to really dig in and make it specific, but it feels to me like we've got very similar data represented in too many slightly different structures here, and it makes the code hard to read and understand. It seems likely to me that this could be standardized down to one or maybe two standard structured formats (or even objects!), even if that means some code ends up getting more data than it needs, or needing to do slightly more munging itself.

If these formats really are all needed, then I think this method should have a docstring that explains much more clearly _why_ each format is useful and different from the other formats, and when you'd want to use one format or the other.
for now just a nit... please add a blank like "function (name)". It's not a function we are calling here but an anonymous definition.
how about to return `null`? (don't know if it will breaks something... but seems a bit better)
If `-[USCollectionWrapper unwrap]` is not meant to be called anyway, what is the reasoning behind having a common superclass?

`-[USArrayWrapper unwrap]` and `-[USDictionaryWrapper unwrap]` have different return types anyway (NSArray* and NSDictionary*, respectively)
You're probably right.  Especially now that browsers are getting smarter.
Another crazy bit of mine is the 80 character per line rule. I believe this is more than 80.
please add copyright headers to all new source files
The `:class` entry overrides the `.public` on the `:div`, so should probably be added to the class list. Maybe via `:class (str "public " (var-classes var))`
I think it should be without the leading underscore.
Very good idea -- done. :)
Do we want to return a ViewModel ? I can move the routeMatch or conditionally set the status code + return the ViewModel on \Zend\Http\Response. Which one is preferable ?
Indent the body of this block 4 spaces please
Yes, in this case it's better to use the type hinting.
I used step instead of stepInterval in my Number step. We should decide on one terminology for coherency ;-). I agree that stepInterval may be better.
Why is this false by default?
You can ignore this page, it's incomplete.
You have to wrap all client JS with `is_client`?

There isn't a way to use HTML comments to mark it or something?
page_name=cat.url)
Is this valuable output? I can see how it would be useful if there are problems, but it's noisy for normal usage.
Did you check that this mkdir still works? (Previously it was relative, now it is absoute so you change the behavior)
What's the advantage or purpose for adding these attributes?
Humm, maybe yeah. I'll look into it a bit more.
but not similar with the other parts of this XSD. See for instance the cascading: https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L25
missing a space after ``foreach``
out of scope, etc etc (but I think I'll ignore this)
`escape` is not needed  I guess
When I wrote that comment (deleted), I wasn't aware this was a Sentry client. My bad.
`user_nsid` is random number =) where `username` is (at least for me) and screen name.

Check: http://www.flickr.com/services/api/auth.oauth.html#yui_3_5_0_1_1341402993734_260
And example response: http://www.flickr.com/services/api/flickr.test.login.html (`id` = `user_nsid`)
This check is not needed as the `User` class used with FOSUB should implement the `UserInterface` provider by FOSUB?
We don't need this line (kinda the point :-p)
These stars should be backticks
Please use ngxDictionary for texts, see imageupload/lang.
Newline(s) here?
Why put it in test.py? Since it's in local-py.dist and bin/jenkins.sh, everything should be fine.
if you are refactoring this pages can we add the MPL2
Cool beans; no prob.

Matthew Riley MacPherson | http://lonelyvegan.com
(Sent from mobile)

On 2012-09-07, at 17:23, Aakash Desai <notifications@github.com> wrote:

> In apps/users/forms.py:
> 
> > @@ -16,9 +16,8 @@ class RegistrationForm(UserForm):
> >          widget=forms.TextInput(attrs={'placeholder': 'Example: IRC Nickname'}))
> >      groups = forms.ModelMultipleChoiceField(
> >          widget=forms.CheckboxSelectMultiple,
> > -        label=_lazy(u'Do you know which functional areas you would like '
> > -                    'to help or already helping? Choose from the ones '
> > -                    'below to get started.'),
> > +        label=_lazy(u'Please indicate the functional areas you are currently '
> > +                    'contributing to or would like to contribute to:'),
> Dunno, its consistent with the indentation in the rest of the file. I'd like to keep it as is or change the entire file itself. For a nit, probably not worth it.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Leave this out of this PR. I've swung back to my original thing of we should handle this in middleware, otherwise every URL rule will need this.
```yield``` は？
Use a helper function to instead of showing the last_login, turn it into a string like "3 hours ago". 
There is a function somewhere in django which we can use.
Why did you delete this? This was for the dist build to prevent it from outputing some stuff that didn't make sense in the thorax context.
NonFatal, also
Just leave the key be :smile_cat:
this will need to check if the query is a manual iteration or not.


                if (options.lean === true) { 
1023         if (manual) { 
1024           callback(null, doc, next); 
1025         } else { 
1026           callback(null, doc); 
1027           next(); 
1028         } 
1029         return; 
1030       }
What did you think this class would represent?
I wonder if we should throw BinaryStoreException in the base class, so we don't have to wrap the exception in a RuntimeException.
Is this as slow to run as it looks? Would it be possible to fake the keypair data or do we need something legit?
Also the code is already better than before, these 3 lines must go in the create function of HermesService.

This will help adding new services like dropbox, ...
I think display a diagram and an example in the README is useless. Maybe you should 
 * Present fridge in globality (the philosophy, and link to the doc)
 * How to install fridge
 * How to contribute
 * Test coverage

Hope it's helpfull
один алгоритм?
I think value is lost by doing this only by convention. 

Here's my main use case now: My root (/) app is a legacy webforms app. On top of that, I have a single-page javascript application (just html+js) in a sub-directory, and in /restapi I have a MVC (eventually WebAPI) app that is purely my API, called by the single-page javascript app. Using the default forced convention of ~/api means my urls become /restapi/api/ ..  which is a bit redundant.

I could live with the default being /api/swagger but it has to be configurable. I think it also slightly confuses things - the developer's actual application API is /api, swagger is a separate concern and therefore it makes sense -- to me, anyway -- that it lives in a different place.
I think the main thing that struck me is there's no way to validate a key conditional on its presence. If you want to validate a key now, you also are implicitly asserting that it exists. It seems like existence is just another predicate for validation (much to the chagrin of Immanuel Kant). Also, the validation is written as if it's generic validation, but actually it's only appropriately usable for checking the type of a value, given what the error message is. I'd probably break it into 3 or 4 functions, for validating existence, type, and for mapping the desired validations to keys of a map.
instead of deleting everything, I would just replace this with a new comment object that has deleted set to true. This avoids the need of changing this when a comment property is added later on.
`tenantid` should be `tenantId`, right?
I would remove this from now. I don't think we should use the documentation to try to sell. I think we risk loosing credibility if we do.
Pull IWindowManager down on to next line for consistency
I mean line 234
@s1dney Ех.. Завалил домашку )) Когда оптимизировал метод мутации удалил часть кода )
           
 // Удаляем замененынй обьект из массива

 [replaceList removeObjectAtIndex:nIndexForReplace];

Можна ли поправить??
Ок, ваша правда. Но почему ж не вести сравнение, даже если их длина разная? Просто цикл нужно будет организовать по наименьшей длине и разницу заложить в результат.
Это можно соптимизировать: не заполнять массив из значений, а потом из него удалять до needToMutate, а наоборот - *заполнять* массив уникальными значениями до needToMutate, и во время заполнения менять соответствующее значение в последовательности.
Это не ошибка, но лучше использовать BOOL (у него значения YES и NO).
object_id
Any whitespace preference, should we revert this?
Can you add at least one test to ensure that temporarily attached elements are in fact not attached after the call?  In particular, a test with multiple unattached elements in the same tree.
`bb->data` is already of the right type, no casting is needed.
我看源码，似乎只catch InvocationTargetException?
indent w/ spaces please :)
This doesn't work. It will create a 3D array and will fail if either lh_data or rh_data is empty.
fix what? This is just mode-dependent initialization, pass is there so we can use else to catch illegal values for mode.
Looks good to me.

what @mluessi do you think?
We now have additional memory parameters here. Please put "-Duser.language=en -Duser.region=US -Xmx512m -XX:MaxPermSize=512m" in commonArgLineForTesting and use it here and in the default profile. Merge & close when done.
If there are other repositories we can suggest, please add them.
I think @stof means that you use 'cross reference' as a verb maybe. So perhaps to make it clearer you should say something like:

```
TODO: Create a cross reference here pointing to the translator docs where the detailed ....
```
需要理解一点的是，只有在没有向客户端发送任何数据以前，将请求转给下一台后端服务器是可行的。
Maybe you could also change it to use the `Collection#find`method here, since it's easier to understand what you're doing there.
arguement -> argument

You may consider using a formulation like "'i' is not a valid hint."; I think that talking about arguments passed to a function makes the error message a bit too long.
ffnet Sie eine ticket, bitte?
Не дописал, походу
you should keep the signature on a single line. It is short enough
> "What do you mean I'm reaching out to the main VehicleCollector module?"

You're doing the equivalent of "Collection.add_to_collection :the_item" in the above example.
Any reason why you forked to your account rather than the alphagov organisation?
I can't remember to actually have changed formatting, so sure go ahead.

Sergio Bossa
Sent by iPhone

Il giorno 24/mag/2012, alle ore 12:11, Tom McAdam<reply@reply.github.com> ha scritto:

>> 
>> public class GsonQueryClient implements StringQueryClient {
>> 
>> -    private final Gson gson = new GsonBuilder().setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES)
> 
> Can we restore the previous formatting for the construction of gson, as it helps to see what has changed and avoids merge conflicts.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/atlasapi/atlas-client/pull/6/files#r873996
good point. But come to think of it, maybe a simple split() is even cleaner since we're not caring about minor release at all in this case. Will amend.
Thank God you spotted that; I would've been ripping my hair out trying to determine what was wrong when we add reboot back in (same thing happened before and it wasn't fun).
Also there might be an significant difference in time between when the message is sent and when the actual wait happens. I modified the code to track and deduct that time accordingly.
Should subclass object.
can you add an error messages here; it appears <code>unittestzero's</code> <a href="https://github.com/AutomatedTester/unittest-zero/blob/master/unittestzero.py#L178">Assert.contains(needle, haystack, msg)</a> allow us to capture a message if an error state occurs.
Surely the effort is minimal. Less than it would take to add two github comments I should think. ;)
```php
<?php
$this->fail('Unreachable code');
```
капельку наглядней должно быть
Can we use `.hover(showEditCellmenuHoverIn, showEditCellMenuHoverOut)`
hey,sam

         This is done by ant format source,the problem will be figured 
out if we add a comments  showing who the authors are.




于 2012/7/16 18:38, Samuel Kong 写道:
>> @@ -28,7 +35,6 @@
>>   
>>   import javax.portlet.ActionRequest;
>>   import javax.portlet.ActionResponse;
>> -
>>   public class AdminPortlet extends MVCPortlet {
> Why is the line deleted again?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/samuelkong/plugins-cn/pull/6/files#r1167783
>
Quite right, will fix.
Aby se to zkompilovalo a nic nechybělo (třeba CP0_STATUS_IE_MASK).
Macro should say "remove", not "update"
I disagree -- you're checking completion with clang's compiler, so you should use clang's headers. These are standard headers, so there shouldn't be a difference in API (famous last words...), but crucially, clang was failing to compile the gcc headers because of gcc-specific features in those headers. If you really want to compile with gcc (but still use clang for auto-complete), then you can change g:clang_auto_user_options, but I think using clang headers should be the default.
Blah CoffeeScript has ruined me =p I'll `var` that sucker, thanks.
Should logfile name/location be configurable?
what about target?
Oh, my bad.  It looked like everything was deleted after the comma on this line the first time I looked at this.  I really should get more than 4-5 hours of sleep at night...
This file should probably go. Its kinda confusing that the readme that shows up on the project isn't right :)
Needs to be `Brakeman.notify...`
There is some weird indentation here
ok. but then i don't really like the specific model of this checker because it allows this ambigous situation of having the flag saying one thing and the date the other. i would really prefer to have only flag or only start and end date, this avoids ambigouity and is more flexible. the check i wrote above would then go into the checker which is fine for me.
i think that part is the only one that got more complex, but i could make it easier or comment it, if you wish. what do you say?
Furthermore, you removed TODO about checking how does Facebook values for gender map to our values. Somebody hast to check that.
Ok. But just so you know, we have two-level dispatch for updating user list. I thought we should use the same concept. So are you sure about this? I don't like changing things twice :)
No need for new line. You can have both `<div>` and `</div>` on the same line.
Only here race condition could happen, but it does not matter, because even if some timestamp overwrites one later, it is still good enough for us.
Splitting footer into multiple lines is probably a good thing, jut don't break indentation at the same time. :-)
This looks really ugly? From where are those numbers?
I don't know why, but it doesn't work. I tried urllib.urlopen in the same way as with facebook, but i get 405 Error: Method not allowed.
I used postgres.
|| LINUX
This method is not used anywhere in the project. In fact, I even removed the method and all tests passed.
Убрать методы, $request->getPost, getQuery
You're right - I was using the built-in-Github editor, and I must have missed it. Thanks for pointing it out!
Make sure to update your branch with the current master because this folder no longer exists.
Yeah, that wording is awkward.
Sup with these comments?
Thanks. We'll add the missing math function and modify the function. I'll merge this pull request today.
why is this condition needed now?
so that was my own fault :)
I agree we will need to fix all these wrongly formatted files, but you can't do it in a pull request while others are working on it as well.
Shouldn't it rather say 'registerDefaultValues'?
OH! Or, since you're using one picture to reference two things, maybe color code them in bounding boxes?

ie: make "height and width" blue font and then put a blue bounding box in the image around height and width, then red (or whatever) color font for snap x and snap y and then a box around the top of the image where these are at. May help guide eyes more to those locations? Or maybe I'm getting nitpicky
Think I found it. Adding now.
Is there a reason for the double assignment here?  Can't quite figure this out.
this needs whitespace `typeof value === 'function'`
IIUC the artifact feed shows only 'interesting' files from m2-repositories, and the file feed shows only 'interesting' files from all repository types. (With 'interesting' meaning not generated and not a m2 signature or hash.)

Seems fine for me, not need to bomb any feed with 'uninteresting' updates.
I don't know why they were there in the first place, so it was my intention to determine if Sergi meant to output these lines to the IDE's console rather than the inspector
The changes to this file (uncommenting all the tests), while helpful, probably don't belong in the same changeset as the log4j switchover.
Are you a medical doctor or a Ph.D.?  Do you know Dr. Pepper?
you should really use css rather than creating more dom elements for styling
Does this need the special handling of galsim.shear.Shear?
Very very minor, but putting this on a newline from the `"""` directly above, and not using a period at the end of the brief description, breaks the pattern adopted for the vast majority of Python docstrings.
Good idea, thanks (as a rule, I'm cautious to change Gary's original code!)
Did you miss checking in the networking_activity.plot?  Or did you want me to do the gnuplot and chef parts for this?  That'd be OK, just want to understand.
I wonder if number of attempts would be the same calculated these two different ways.
Is this right?
If certificateDestination was null and we auto-generated a path to copy the file across to, then ssl.certificateDestination will still be null.
I rewrite to NSUInteger*.
optinos -> options
It's inherent. The whole sentence needs a rewrite. Perhaps as "This also respects the same origin policy enforced by default by browsers, to prevent cross-site scripting attacks". Point being that this is not a best practice, you just can't break the policy by default.
I'm trying to imagine a csv so wide that izip could matter, but I'm recoiling in horror.
If the replicaset name is part of the connection string won't it  be the literal string "true"?
yeah, sorry. virtual crockford aka JSLint hit me over the head about it too...
This is fine although most of oscar uses ``django.db.models.get_model`` when loading models and the ``get_class*`` functions for general classes.
Is this ordering preserved?
Fix the formatting. and use `===` not `==`
Also can't you just check the first char?
`setUrl` takes only one argument. Should be `setIp()` for the IP.
rename to createMessage()
What is this doing exactly? Shouldn't it show a message to compose a message?
Имя конструктора с большой буквы имя функции с маленькой.
Старайся масимально избавляться от событий в аттрибутах.

```javascript
document.body.addEventListeler('load', addListener, false);
// или
document.querySelector('body').addEventListeler('load', addListener, false);
```
Скрипты, чтобы все работало, можешь закинуть в перед `</body>`
А как гарантируется, что это окончание работы считывания, а не просто не успелось нужное количество считаться?
Я правильно понял, что это должно быть что-то наподобие этого:
IoUtils.close(reader, writer);
?
@klrmn Right on - I didn't realize pytest-mozwebqa provided this safety feature.
we use the same account every time 
the developer agreement is is accepted on the first submission of a app and is not required after that.
@krupa  is this right?
A more appropriate name might be 'test_that_verifies_that_most_popular_section_is_visible'.
but isn't the property the same as in the upper class?
_data_body_class = "settings"
why would we need another property which points to the same settings page?
```ruby
def initialize(name, options={})
  @wrapper_html_options = options.except(:wrap_with)
   super(name, [name], options.fetch(:wrap_with, {}))
end
```
this doesn't seem to be used.
We should allow underscores in email addresses as well.
VirtualCurrency::ValidateParams() will throw exception and will not execute this statement.
remove the links
You have a bunch of these... make sure your editor is configured properly.
replace list by collection
Modifying the `params` hash in this way feels a little… wrong. Would it be better to pull it into a `search_index` variable?
Move this up!
Gavin wrote:

> Is this really right?
> 
> If I read the code correctly, getNextSorted() should probably be renamed queryNextSorted() to indicate it doesn't link the rows.
> 
> before the code took the pointer, linked it, and then called putRow. unusually it then released all the rows (rather than just the ones that haven't been read.)
> 
> Now it is getting an unlinked pointer, calling putRow() - which takes ownership, and then releasing it. I think this should be realeasing it 2 times too > many. If not can you clarify how it works?
To be consistent, should list "-p" as option as well.
yep, will change
You need to define these on MCVariable as well so it's more easy to print.

__str__ should make something nice and quick that is good for user output
__repr__ should be entirely unambiguous (i.e. uniquely identify an instance of the class)
The Platform's actual name and correct capitolization is 'MySQL', that is why that is returned.  Same with 'SQLite', 'Oracle', etc.  Our camel casing rules only apply to classes, for which the class name would be Mysql, or Sqlite, etc.
what happens when the locale's codes aren't in the table? Can we fall back to something better than just a crash?
are these values good for the others language too?
@shacker What was the reason for removing this, did the designers ask for it?
I'm OK with CSS named colors  but surprised you don't prefer hex value over "white" ....
@plamarque : a m is missing at the end of the phrase (Platfor => Platform)
```self.clean()```?
missing license header / copyright info
I don't like a lot the furniture around the comments, but it's something personal :) Anyway, I think no furniture is more "msf style coding compliant"
Do you not need an EOF line after this?
I think that should be `ln_s HOMEBREW_PREFIX+"share/aclocal", share`  because you get
`/usr/local/Cellar/automake/1.11.3/share/aclocal/aclocal`  when you do it your way...
Yes, you wrote it.  As far as I can tell (I looked at it briefly) the credit line is not served as metadata from anywhere.  I'll delete the TODO.
Good point about the hyphen. In order to make the counter work it would have to be static to the `Material` class, otherwise it would be difficult to detect which counter values are used by materials that were created externally. Is having a static counter a good idea?
It looks like all of the setters still have this issue.  I still think we should be checking for `undefined` and throwing rather than silently failing.  Thoughts?
Pretty awesome that we could delete so many GLSL files and use the `components` property instead.
This would be a good place to set PowerShell defaults for executing the script, for example:

$global:ConfirmPreference = "None"
	$global:DebugPreference = "Continue"
	$global:ErrorActionPreference = "Stop"
	$global:FormatEnumerationLimit = 10000
	$global:ProgressPreference = "SilentlyContinue"
    $global:VerbosePreference = "Continue"
	$global:WarningPreference = "Continue"
	$global:WhatIfPreference = 0
s/paramter/parameter
Actually, no. It is the offset into the *buffer* where we start writing the data we read from the stream.

e.g., we read N bytes from the stream, we write them to buffer[offset] through buffer[offset+N-1].
That last bit is, I think, not quite right.  In testing on both iphone sim and android device, i see the scrollEnd will fire even if i just drag a tiny bit and let go and it pops back into place on the _same_ view.
TiProperties.setString() has an if statement checking if the value is null, key is removed.
This code might start to get ugly if we add more flags in the future. It's also a bit hard to parse.
Maybe store the set of valid launch flags as a static final in the class then just test if any of these
bit flags are set on the intent in checkInvalidLaunch(). This way we just need to append later to this static
final flag set if we need to add more flags.

Define this in the class as a static final:
~~~
// Any activity launched with one of these flags will be considered "valid".
VALID_LAUNCH_FLAGS = Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED | Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY);

~~~

Goes into checkInvalidLaunch() for testing the intent flags.
~~~
// Check if one of the valid launch flags is set.
invalidLaunchDetected = (flags & VALID_LAUNCH_FLAGS) == 0
~~~
In the past (and for the CLI spec, which may eventually integrate with anvil as its "official" frontend) we have gotten complaints about loglevel not corresponding to node.js' log level format. The anvil driver should conform to it even if it maps some levels to the same internal value.
AFAIR, charset detection has actually been completely removed in recent releases (UTF-8 is always assumed instead). So this line is somewhat misleading. Other than that: Excellent.
Not to mention, I believe that it used to return `""` (which then isn't even a slice of the string) and that the only reason that it doesn't anymore was that it was easier to return the correct string type when `stripLeft` was templatized if  a slice was returned rather than `""`.
There is no cost to having it, and in general, I'd argue in favor of it, because then it's clear that you meant to initialize it to `false` rather than it looking like you might have forgotten to initialize it. So, I'd argue that it's good practice to explicitly initialize it, but it's not necessary.