[EFL] Unreviewed gardening on the 64bit build bot.

The following test cases don't crash so they should be removed from
WK2 TestExpectations file.
inspector/elements/event-listeners-about-blank.html
inspector/console/console-assert.html
inspector/debugger/debugger-step-out.html
inspector/debugger/debugger-suspend-active-dom-objects.html
fast/forms/fieldset/fieldset-crash.html
fast/events/keyevent-iframe-removed-crash.html

The following test cases pass only in WK2 so marked them as pass.
fast/loader/opaque-base-url.html
canvas/philip/tests/2d.text.draw.fontface.notinpage.html
editing/execCommand/indent-paragraphs.html
fast/animation/request-animation-frame-during-modal.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/frames/seamless/seamless-inherited-document-style.html
fast/js/names.html
http/tests/security/cross-frame-access-call.html
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html

The following test case is marked as known failure.
fast/events/tab-focus-link-in-canvas.html

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302

Reviewed by Chris Fleizach.

Source/WebCore: 

Changes the accessibility logic so that a generic element that's focusable is
not ignored for accessibility, and returns its inner text as its title. That way
if you Tab to the element, a reasonable accessibility notification is generated.

One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.

Also fixes logic that determined if an element was contentEditable by making
sure it catches the case with no attribute value (e.g. <div contentEditable>),
which also implies contentEditable=true according to the spec.

Test: accessibility/focusable-div.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests: 

Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.

Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").

* accessibility/editable-webarea-context-menu-point.html:
* accessibility/focusable-div-expected.txt: Added.
* accessibility/focusable-div.html: Added.
* accessibility/table-detection.html:
* platform/mac/accessibility/listbox-hit-test.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Move several files to remove webkit1 dependency from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=95264

Reviewed by Gyuyoung Kim.

Source/WebCore:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

No behavior change. Just a refactoring.

* PlatformEfl.cmake: Removed files which moved from sources and WebKit/efl/WebCoreSupport from includes.
* WebCore.gypi: Ditto.

Source/WebKit:

* PlatformEfl.cmake: Added files which is moved.

Source/WebKit/efl:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

* WebCoreSupport/ColorChooserEfl.cpp: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.cpp.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
* WebCoreSupport/ColorChooserEfl.h: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.h.
(WebCore):
(ColorChooserEfl):
* WebCoreSupport/PopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.cpp.
(WebCore):
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):
* WebCoreSupport/PopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.h.
(WebCore):
(PopupMenuEfl):
(WebCore::PopupMenuEfl::client):
* WebCoreSupport/SearchPopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.cpp.
(WebCore):
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):
* WebCoreSupport/SearchPopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.h.
(WebCore):
(SearchPopupMenuEfl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: Canvas should have a distinct role
https://bugs.webkit.org/show_bug.cgi?id=95248

Reviewed by Chris Fleizach.

Source/WebCore:

Add new role for a canvas element, and a method to determine if
a canvas has fallback content, so each platform can decide on the
appropriate role mapping to use.

Test: accessibility/canvas-description-and-role.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isCanvas):
(WebCore::AccessibilityObject::canvasHasFallbackContent):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::canHaveChildren):
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper role]):

Source/WebKit/chromium:

Add support for canvas accessibility role.

* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:

Source/WebKit/win:

Map new CanvasRole to the same as ImageRole.

* AccessibleBase.cpp:
(MSAARole):

Tools:

Add support for canvas accessibility role.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(roleToString):

LayoutTests:

Add new tests for canvas role.

* accessibility/canvas.html: Deleted.
* accessibility/canvas-expected.txt: Deleted.
* accessibility/canvas-description-and-role.html: Added.
* platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/mac/accessibility/canvas.html: Added.
* platform/mac/accessibility/canvas-expected.txt: Added.
* platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK1] Unreviewd gardening. Skip failing css3 filter test.
https://bugs.webkit.org/show_bug.cgi?id=95308

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-29

* platform/qt-5.0-wk1/Skipped: skip css3/filters/null-effect-check.html after r126927.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: NMI: Instrument WebCore part of the Image class hierarchy
https://bugs.webkit.org/show_bug.cgi?id=94959

Drive by fix: remove unused GeneratedImage.cpp

Reviewed by Yury Semikhatsky.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
(WebCore):
* html/HTMLImageElement.h:
(HTMLImageElement):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore):
* platform/graphics/BitmapImage.h:
(FrameData):
(BitmapImage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
(WebCore):
* platform/graphics/CrossfadeGeneratedImage.h:
(WebCore):
(CrossfadeGeneratedImage):
* platform/graphics/GeneratedImage.cpp: Removed.
* platform/graphics/GeneratedImage.h:
(GeneratedImage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
(WebCore):
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.h:
(GeneratorGeneratedImage):
* platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
(WebCore):
* platform/graphics/Image.h:
(WebCore):
(Image):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
(WebCore):
* svg/graphics/SVGImage.h:
(SVGImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed: Single line build fix.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Before r125428 run-time methods (wrapped signals, slots or invokable
functions) were subclasses of JSInternalFunction and therefore real
function objects in the JavaScript sense. r125428 changed them to be
just callable objects, but they did not have Function.prototype as
prototype anymore for example nor was their name correct (resulting in
a layout test failure).

This patch changes run-time methods back to being real function objects
that have a correct name and have Function.prototype in their prototype
change

The objects returned by JSObjectMakeFunctionWithCallbackInjected are
light-weight internal function objects that do not support
JSObject{Set/Get}Private. Therefore we inject our own prototype right
before the Function.prototype prototype, which uses private data to
store a pointer to our C++ QtRuntimeMethod object.  This complicates
the retrieval of the pointer to that instance slightly, which is why
this patch introduces the toRuntimeMethod convenience function that
looks up our prototype first and does a check for type-safety.

At the same time the patch removes the length properties from the
run-time method itself as well as connect/disconnect.  The length
property on a function signifies the number of arguments, but in all
three cases that number is actually variable, because of overloading.
That is why we choose not to expose it in the first place.

In QtInstance we cache the JS wrapper objects for QtRuntimeMethod in a
JSWeakObjectMap. JSWeakObjectMap requires the stored objects to be
either the result of JSObjectMake or the global object of a context ref
(AFAICS), which is ensured using an ASSERT. Objects created via
JSObjectMakeFunctionWithCalllback do not fall into the required
category, cause a failing assertion and can therefore not be stored in
the weak object map.

Consequently this patch removes the use of JSWeakObjectMap again and
goes back to the old way of using the internal Weak<> API, for the time
being. In a future patch the storage will be simplified to not require
the use of a weak object map cache for the run-time methods anymore.

* bridge/qt/qt_instance.cpp: Remove unused WeakMap code.
* bridge/qt/qt_instance.h: Remove method cache.
(QtInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
* bridge/qt/qt_runtime.h:
(QtRuntimeMethod): Remove unused member variables.

Source/WebKit/qt:

Fixed some test expectations.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.

LayoutTests:

* platform/qt/Skipped: Unskip test that is now passing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use SVGImage instead of cached image when drawing without a render tree.
https://bugs.webkit.org/show_bug.cgi?id=95002

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously if we tried to use canvas.context2d.drawImage() with an SVG image
that was not in the render tree, we would crash. This patch changes this behavior
so that we use SVGImage::draw() to draw images that are not in the render tree.

Test: svg/as-image/svg-canvas-draw-image-detached.html

* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

LayoutTests:

* svg/as-image/svg-canvas-draw-image-detached-expected.txt: Added.
* svg/as-image/svg-canvas-draw-image-detached.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Extract StylesUISourceCodeProvider to separate file.
https://bugs.webkit.org/show_bug.cgi?id=95319

Reviewed by Alexander Pavlov.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj: Also added WebGLProfiler files forgotten before.
* inspector/compile-front-end.py:
* inspector/front-end/StyleSource.js:
* inspector/front-end/StylesUISourceCodeProvider.js: Copied from Source/WebCore/inspector/front-end/StyleSource.js.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Use floating point literals in expressions that initialize floats
https://bugs.webkit.org/show_bug.cgi?id=95293

Patch by James Robinson <jamesr@chromium.org> on 2012-08-29
Reviewed by Adam Barth.

Visual studio's C4305, which is on for some chromium code, complains about these.

* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphEdges):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Rebaseline after r126864
https://bugs.webkit.org/show_bug.cgi?id=95278

Unreviewed, rebaseline.

Updated range with datalist pixel test expectations because slider theme is changed.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-29

* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Clean up Skipped file
https://bugs.webkit.org/show_bug.cgi?id=95306

Unreviewed EFL gardening.

Remove from Skipped list several test cases that are now passing
consistently on EFL port. Some other tests have been moved to
TestExpectations since we need to get rid of the Skipped list
progressively.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-29

* platform/efl-wk2/TestExpectations:
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/efl/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/efl/editing/selection/extend-selection-bidi-expected.png: Added.
* platform/efl/editing/selection/extend-selection-bidi-expected.txt: Added.
* platform/efl/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
* platform/efl/fast/forms/color/input-color-onchange-event-expected.txt: Added.
* platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
* platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
* platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Added.
* platform/efl/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/efl/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Improve string efficiency using StringBuilder and StringOperations
https://bugs.webkit.org/show_bug.cgi?id=95304

Reviewed by Eric Seidel.

As recommended by http://trac.webkit.org/wiki/EfficientStrings.

* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::customCssText):
* css/CSSPropertySourceData.cpp:
(WebCore::CSSPropertySourceData::toString):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::mediaText):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::customCssText):
* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::undefinedItemType):
* editing/HTMLInterchange.cpp:
(WebCore::convertedSpaceString):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r120113.
http://trac.webkit.org/changeset/120113
https://bugs.webkit.org/show_bug.cgi?id=95320

Wrong fix for the problem, experimentally rolling it out for
bug 95237. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-29

* efl/jhbuildrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r126816): Missing includes when compiling without SVG
https://bugs.webkit.org/show_bug.cgi?id=95312

Reviewed by Eric Seidel.

* rendering/FilterEffectRenderer.h:
* rendering/RenderLayerFilterInfo.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Add *explicit* keyword to constructors in WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=95307

Reviewed by Kentaro Hara.

Added explicit keyword in constructors in order to avoid implicit type conversion.

* WebCoreSupport/ColorChooserEfl.h:
(ColorChooserEfl):
* WebCoreSupport/PopupMenuEfl.h:
(PopupMenuEfl):
* WebCoreSupport/SearchPopupMenuEfl.h:
(SearchPopupMenuEfl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed EFL gardening.

EFL requires a newline at the end of the test expectations here.

* platform/efl/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent
https://bugs.webkit.org/show_bug.cgi?id=95315

Reviewed by Vsevolod Vlasov.

* bindings/v8/RetainedDOMInfo.cpp:
(WebCore::RetainedDOMInfo::IsEquivalent): compare retained object info
labels before casting v8::RetainedObjectInfo to WebCore::RetainedObjectInfo
as the |other| object may not be a descendant of WebCore::RetainedObjectInfo.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126989 268f45cc-cd09-0410-ab3c-d52691b4dbfc