labofsahil/github-event-dataset-2012 huggingface dataset:
Those benchmarks are comparing something different, though still important. What we're talking about isn't whether nulling a property is faster than deleting it; it's whether or not straight deletion makes it slower to reference the value later than if it were nullified, or nullified-then-deleted. These benchmarks show that, for Chrome at least, the reference issue doesn't make a difference, but nullifying-then-deleting the same property has its own costs:

http://jsperf.com/delete-performance/4

I think when we want to delete properties, we should just delete them.
Don't need this whitespace
Evan, you can't use _View.isNotStandalone? If not, then perhaps we should move that flag as it is the exact same logic?
Once orientation is locked in portrait, I think any methods relating to orientation change should have a comment indicating that they will be unused unless orientation is unlocked.
We have these convenience variables in _View for phone and tablet

https://github.com/Toura/mulberry/blob/master/app/mulberry/_View.js#L48

So it would be nicer to put `isBrowser` there -- we're probably going to have to do more conditional template stuff for mobile web, and that'll be easier than remembering `mulberry.app.UI.isInBrowser`. 'phone' and 'tablet' should also probably be renamed `isPhone` and `isTablet` for consistency.
I had tried that initially, but it caused all the other supporting files to 404. I'm not sure why.
Instead of "Heute" I would suggest "Derzeit".
Suggested refactoring. @jbalsas Again, just a suggestion for our team, nothing for you to fix for this pull request.

@GarthDB we might want to differentiate a background progress indicator that runs just in the status bar and a modal one that uses ``busyCursor``. This current implementation with only a ``busyCursor`` does not prevent interactions with the page. I can still open menus, edit files, etc.
@conradz The "another code path" I referred to needs to be written. It would be awesome if you want to take a stab at this.

I took a look at the code, and it doesn't seem too bad. I think we should add a selectFile parameter to doOpen(). All other calls should set it to true, and set it to false here. onOpen would need to be updated accordingly.

After each file is opened, then add each to the working set. Finally, select 1 of the files (not sure if it should be the first of the last in the list, so take your pick).

The code that adds file to working set if outside project in the select code should be moved, but I'm not sure where, so it's OK for now.
This should be followed by a return.
Sounds good -- thanks!
Is commit b5fe2d4 enough?
I will use 80 as a default value
Ow, ok. Looked strange ^_^
this implies that the test is aware of what the original url is. but it isn't. the original url was not the base_url, nor was it specified on the command line. it was determined by BrowserID.persona_server_url() based on the base_url and loaded by the pytest_funcarg__mozwebqa function in conftest.py. i would be happy to have your help designing a different solution, but this is what i could do without help.
"Font Colour"
I think it is. It's saved in history. No need to keep it around.
I'm looking at this again, and I think pushing logic for `butter.project.autosave` back into `project` altogether is a good idea. I don't think `header` code should be telling `butter.project.autosave` whether it's `null`, or otherwise.
A wild console.log appears!
I'd probably take this directory out, unless we can force fragment parsing for these files; they'll never be standalone valid html files.
I consolidated start() and mediaready() functions here
To coincide with chris' note below, the amount of terribly named `url` variables here is bonkers. Mind choosing something a bit better since you're doing this change?
Can you fix all of these? Do you have spaces->tabs setup?
Why do we need a unit test to cover CompositeException? As far as I understand, there are two important aspects of behaviour around CompositeException -- the download all indexes operation must fail if any of the indexes failed to download and the original IOException is logged to allow troubleshooting. As far as I can tell, neither of these two depend on CompositeException.
probably leave it to a master student
This works just fine, but it's kind of a long source line...maybe calculating the url a line above or something...or mabybe it's fine as is...I'm half and half
(And not using `Redis::Namespace` because I might already have a connection to redis object that I want to share between both the GeoIP datasets without having to open a new one, with a different namespace.)
Yes, you can, however! you should be calling getSOA, I'm afraid.
@JeffBezanson Is this style of returning either (D,V) or D likely to cause trouble for type inference?
Based on irc chat with jrist, I'll make updates to address this one with an upcoming pull request on system groups.
When you are adding this link via rpm (without %ghost) then this is redundant and can be removed.
On 26.9.2012 16:33, Lukáš Zapletal wrote:
> Hmm we do have this in all our man pages, I'd stick with this. Why not
> to have it there? Other projects do the same...

man httpd
man rpm

I do not see it there. I'm just questioning what is the benefit? I see 
none. Man page is not is not your ultimate place where you get 
information about version of some command.

Mirek
Why changing the visibility ?
'The operation to perform' ?
it is already different as it is not the last one. So the doc need to be fixed anyway
I have no answer, for that ^^ so you propose to use 0, 1 and 2 instead :)?
Does this really create a toolbar?
"Thrown when a new object is drawn"
Oh yeah, and single ' instead of "
if we want to have python 2.6 compatibility I think we need to have `{0}`. I would also remove the log since it might confuse the behaviour of precision
This can probably just be `return None` if we get to this point.
this changes the name of the field specifying the type of items in a collection to "type" which imo makes more sense than "controller". @flack if you are ok with this, we need to update this in a couple of other places as well.
I have also confirmed that the fonts are not being scaled properly.
I'm not sure if no value is technically valid ics. I think at least the : needs to be appended and I know the C++ parser complained about this.
There, I changed everything that was `git_indexer_*` to `git_transfer_progress_*`, and sane-ified the progress member naming. What do you think?
The error 2 lines down says "is missing or EMPTY" so this line should probably be:

`if not params.uuid:`
Does this affect throw scrolling on Firefox? It's considered "experimental" for non-SVG elements:
https://developer.mozilla.org/en/CSS/pointer-events
You want to cache the file forever, and have it include that cached file. `system/cms/cache/SITE_REF/blog_routes.php` for example.
About this translator function I used pythons string.translate function itself with some easy changes. I think that is more readable. but I will change it again to an independent function in the class and use it even for numbers.
Well spotted, thanks! Seems like a test case is missing for this case.
should also consider `$this->strictRequirements` (see code above)
I guess I should just try it and you'll tell me where to move it, if it's wrong here.
you should not get the value of the parameter here. The definition should use the parameter for its class, not the value of the param. The resolution should be done only later when optimizing the container
IMO, ``null`` would be better for the case where it is not set
why changing clientData here ?
the highlighing should use ``<question>``
What about using the new methods instead of the deprecated one here (where you pass additional arguments to addCollection)?
May using both non exclusive `$absolute` and `$relative` makes it unclear. Should you reuse the terms for the [RFC 3986](http://tools.ietf.org/html/rfc3986#section-4.2) ?
@JosephPeng 哦，我也发现了，你正好test一下issues的使用吧，简单的说就是报bug，上方菜单栏中的issues链接，然后找到new issue链接，会提示输入标题和详细内容，你还可以分配assign即分配给谁以及milestone，我之前一共建了4个，如果有不同意见可以进一步交流。
Cleanup please..
Does the collect still need to be here?
Needs a test (other than for building the documentation)
I've created a generator.
Same question about sorting.
The idea here is to represent "apps" (e.g. a specific page) that hold a set of components (which are in views.coffee). It'll eventually also indicate what channels this page will subscribe to (for real time updates).
De mon côté, la fonction permet de traiter à la fois les ref internes (@ #) et liens web (mail, http, ftp, www.*)

Thomas Escolan ----------------

Le 4 avr. 2012 à 02:08, Julien Dubois <reply@reply.github.com> a écrit :

>> @@ -126,11 +126,35 @@ function listTagTweets(tag) {
>>    });
>> }
>> 
>> -var userrefREG = new RegExp("@(\\w+)", "g");
>> -var userrefURL = '<a href="#" style="text-decoration:none" onclick="listUserTweets(\'$1\')" title="Show $1 tweets"><em>@$1</em></a>';
>> +var userrefREG = new RegExp("(^|[\\s,])@(\\w+)", "g");
>> +var userrefURL = '$1<a href="#" style="text-decoration:none" onclick="listUserTweets(\'$2\')" title="Show $2 tweets"><em>@$2</em></a>';
>> +
>> +var tagrefREG = new RegExp("(^|[\\s,])#(\\w+)", "g");
>> +var tagrefURL = '$1<a href="#" style="text-decoration:none" onclick="listTagTweets(\'$2\')" title="Show $2 related tweets"><em>#$2</em></a>';
>> +
>> +if (!String.linkify) {
> 
> Je ne reprends pas cette partie dans mon merge, je ne comprends pas ce que tu fais avec le linkify là. Et je viens juste de recoder cette partie, je pense qu'on est sur la même chose (le lien ne marchait pas). Si oui, ce que j'ai fait est ultra simple...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ippontech/tatami/pull/44/files#r642608
It does not look like the parser uses the expression for this one. Other cases seem fine.
`alarmID` should be already a number when you pass this into `deleteCurrent`.

Check the caller and make sure it do `parseInt` (instead of here)
Although legit, it can cause problems in the future if someone decides to change the L10n string in the HTML or in the locales files without noticing that it is used in the Javascript code to access the element. I would recommend using the element class instead: loading.querySelector('.loading-header').innerHTML = text;
same here, please avoid allocations, they cause GCs, which cause UI stalls
`Application Permissions` doesn’t fit?
Thanks for this fix!
Are the rest of the method changed to use

this._checkDBReady

instead of

this._checkDBReady.call

Just to have all the methods calling the _checkDBReady in the same way.
Sorry, Etienne, still getting in touch with the GitHub thing :p Yeah, moving this code to the on load event was part of the tests... We can leave it in the on localized event... No problem... Should I? ;-)
`var settings = navigator.mozSettings;`
If it's going to be shared across comms apps, does it make sense if we move out from an specific app?
The answer for this type of questions is to ping @fabi1cazenave :)
Right, they are states, and shouldn't be serialised, will remove from the descriptor.

Thanks.
The callback(bookmarks) should be inside a 

    transaction.oncomplete = function() { 
       callback(bookmarks);
    }

It just helps any code that runs afterwards not get in a confusing state concerning transactions
yeh mostly waiting on visuals for that, its also used a as a new tab buttton, which is terribly confusing to use
"new" {
  filters: "mail"
}
If finally you decide this mechanism I could implement it
empty lines kill puppies
weird that we have BB derive from Github (2 different servers).   I would think there is a base GitParser and GitHub/BB/CodePlex deriving from it.
Ah, thanks @nanliu.  We can disregard this comment for now.
https://github.com/satyr/coco/wiki/additions
>  It gets optimized to a series of assignments if the right operand is an object literal.

Woah, never mind that.
Let's discuss this later :)
Fair enough.  Fixed in 5f770de66087301692c8ed37218be1fd64a95bf7.
dc2c3ce
Rundeck では2種類のジョブをつくることができます。

→

    Rundeck では 2 種類のジョブをつくることができます。

半角スペース
diese imgs auch in den Ember.View (ClockView?) schmeißen
1. Same dtype. This function assumes that the needle is a part of the haystack (otherwise, it simply returns False), so type coercion is not considered.
2. That is true, although this function is not a general purpose one, but only a quick-and-dirty helper function to check the "fan_in" function.
Use self.assertEquals, which is the proper way to use Python unittest.
We should probably have a similar check for the icon here; it would be reasonable to have any of a button with icon and label, a button with icon but no label, or a button with no icon but with a label.
ToDo: I've run into at least two situations where test modules could have used more control over pre/post process.  Rather than unconditionally calling them, what about allowing test classes to override them.  For example,  the test module has already been imported at this point, why not do something like:

    preprocess_func = getattr("preprocess_%s" % t_type, test_module, env_process.preprocess)
    try:
        preprocesss_func(self, params, env)
    finally:
        env.save()
    ...
OK, ok, I updated it to use `fetchone` instead.
My gut reaction is that the time should be an argument to this function.
If we really need to support those users, here's how it should work for them: The first time they run composer, it will check for openssl immediately. If it's not found, it'll throw a nice warning explaining that they are strongly encouraged to enable openssl before using composer and explain the implications of not doing so. The prompt will then ask them if they wish to put composer into an "insecure mode", if they say no, composer quits, and on next run the same prompt will show up. If they say yes, we put an `'insecure_mode': true,` entry into their config.json file in their composer home dir. If that's enabled, a warning will still be thrown on each composer run, "WARNING: Composer is running in insecure mode!", etc, but it will not stop at the openssl check. We'll also make fallback to http:// and git:// dependent on insecure_mode being on. Additionally, we can have an environment variable, COMPOSER_INSECURE_MODE which would do the same thing if it's set.
@SaitoWu @ariejan I validate if MR can be accepted here and store result. I dont think we need ajax for this. At least now. Any thoughts?
I'm sorry. We were trying to use Dir.mkdir(..., 0700). This one doesn't work.
Ok we will test your PR for Gitlab 4.1
`location.href = $(@).attr('url')`
I see. But minor performance gain doesn't worth it, and we have [internal API](https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/projects.md#list-project-team-members).
This is quite coupled to gu.prefs global, whereas our general rule of thumb is to have module broadcast their actions and other modules enact on them.
Maybe change KPMACsvr  to developmentsvr
This require is not necessary as `setTimout` is no longer used.
user.completeTransition does not exist. A test would have found this. ;)
um, I'm indifferent really. It's just another layer. `fingerprint` was there already. I suppose I could add
```
fingerprints: {
  default: "...",
...
}
```
too
That can be better written as:

    if files.any? {|file| file.changed? } then
      Puppet.notice "... changed" # may want to notify from the block to get the filename
      parse
      reuse
    end
It doesn't look like this range matches, but the description implies it should
Hi, 

My mistake. Yes, I based the change on flatten implementation. Do I need to resubmit  the pull request ?
I just noticed that there's a space missing after 'at'.
>  Order them alphabetically via the attribute's names?

Yes, pushed an update.

> Can't you specify multiple attributes in a validates call? If so, what happens then? Do we want to avoid such calls?

We want to avoid such calls.

> Is the idea here to make it harder to accidentally validate the same attribute twice?

Yes, and generally improve the process of debugging validations/associations.
*and returns the value set in the field*
Ah, I see.

1. I that case the `bbox` parameter to `bounds_polygon` should be renamed to `bounds`.
2. Neither `bbox_polygon` nor `bounds_polygon` should be member functions of `IntersectGeometryFilter` because they do not depend on the instance. Instead, they should be top level functions in this module (or, better, some other module...).
see bnc#719881 at the first line.
The second line is a bit "enlarged" consequence of the first one. I need to know which devices are layer2 capable. So I've implemented loading for couple of other attributes too.
CS, no double quotes required
Oh AbstractLogicalFilter.phplter.php
I like the encapsulation of the common code from the current public/index.php -- since we can affect both SM and app configuration already, this makes a ton of sense.
This should read ```$this->translator = self::getDefaultTranslator();``` so it is internally cached.
This should be } else {
removed because already in parent.
This should probably be added to the %w a couple lines above this.
Well, the thing is that I couldn't locate how to escape the curly braces in Mu.
Will write an alternate code... had done it earlier - the template will be served by the server (read: controller).

However, `mojito build html5app` should push it out to the final index.html
You probably want to remove this `console.log` call.
@samiluukkonen Pakotetaan yksi kappale... But why? Mites jos ei haluta osoitelappua ja syötetään tarkoituksella nolla? Mites tää toimi ennen?
Argh!!! ELSEIF!
I think I considered that, but being that here it's only called if `@commentable != nil` I wasn't sure if things would crash when it tried to find `@commentable.comments`
:+1: to get rid the `case`
Hello Eric,
Java mkdir is not recursive by itself asI have shown you in the REPL.

Concerning your code, I think the problem is that if the first example fails, you try to create target/specs2-report/stats before target/specs2-report has been created….

That’s why it fails…

Bes tRegards


Edmondo Porcu
Financial  software architect

[Gottex_logo_complet]

Avenue de Rhodanie 48
1007 Lausanne
Switzerland.

Dir  +41 (0) 21  560 30 82
Fax +41 (0) 21  617 71 55
Email : edmondo.porcu@gottexbrokers.com<mailto:edmondo.porcu@gottexbrokers.com>

The information in this email is confidential and may be legally privileged. If you are not the intended recipient, you must not read, use or disseminate the information. Although this email and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by the Gottex Group of Companies for any loss or damage arising in any way from its use.

From: Eric Torreborre [mailto:notifications@github.com]
Sent: sabato, ottobre 13, 2012 1:12 AM
To: etorreborre/specs2
Cc: Edmondo Porcu
Subject: Re: [specs2] 1.12.3 debug - recursive mkdir + pom with changeable scala version (#112)


In src/main/scala/org/specs2/io/FileWriter.scala:

> @@ -69,9 +69,12 @@ trait FileWriter {

>    /** @return true if the file exists */

>    def exists(path: String) = path != null && new File(path).exists

>    /** creates a new directory */

> -  def mkdirs(path: String) = {

> -    println("trying to create directory "+path)

> -    println("the current dir is "+new File(".").getAbsolutePath)

> +  def mkdirs(path: String):Boolean = {

> +    // Recursive fix

> +    val file = new File(path)

> +    val parentFile = file.getParentFile

> +    if(!parentFile.exists())

> +      mkdirs(parentFile.getAbsolutePath)

>      new File(path).mkdirs

I don't get why this fixes the problem. The call to the mkdirs function in Java is already recursively creating all the parent directories if necessary.

—
Reply to this email directly or view it on GitHub<https://github.com/etorreborre/specs2/pull/112/files#r1834904>.

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________
Nie som dvakrat nadseny z existencie tejto triedy, a uz vobec nie z toho ze je vo vlastnom subore... pride mi to overdesigned. Neviem isto, je to len tusak. Discuss.
Is this going to work with an empty terms? Or do we need to special case it?
Why not passing the option at instanciation time rather than here?
That's a good point. I believe V8 looks ahead to see if the loop will
mutate the property. If there's a function call in there, it will even look
into that function.

I recommend watching the video:
http://blip.tv/jsconf/jsconf2012-vyacheslav-egorov-6141593

On Thu, Nov 29, 2012 at 12:58 PM, Matt Robenolt <notifications@github.com>wrote:

> In src/raven.js:
>
> > +        }
> > +
> > +
> > +        if (traceback) {
> > +            stacktrace = {"frames": traceback};
> > +            fileurl = fileurl || traceback[0].filename;
> > +        } else if (fileurl) {
> > +            stacktrace = {
> > +                "frames": [{
> > +                    "filename": fileurl,
> > +                    "lineno": lineno
> > +                }]
> > +            };
> > +        }
> > +
> > +        for (var i = 0; i < self.options.ignoreUrls.length; i++) {
>
> Actually (digressing a bit), wouldn't the interpreter have to actually
> check .length on every iteration since there's always a chance that the
> array was mutated while being iterated. If it's cached, it definitely
> doesn't have to keep checking. In Chrome for, there's about a 1M ops/s
> difference, but really, this is bikeshedding. It's a ~10% difference on
> something that is called once on an array of a few items. :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/getsentry/raven-js/pull/38/files#r2270783>.
>
>
Hi,

I have done this last week, do you see the new commit or do I have to
enforce another pull request?

On Fri, Sep 7, 2012 at 7:12 AM, Kenneth Hoste <notifications@github.com>wrote:
>
> Can you manually edit the buildstats to prettify the easyconfig? I opened
> an issue to clean up the actual emitting of buildstats, see #233<https://github.com/hpcugent/easybuild/issues/233>
> .
>



>
I think using str(dep) instead of (dep,) is clearer, but you should add a comment line to explain why you're doing (either).
add comment line stating that standard make is OK
Just had the exact same thought reading your comments (moving to vouch()). I was going for a signal too, but then that was triggered on every User and UserProfile model save which can be a lot (e.g. when user logins) and I dropped the idea.
break into if statement
Lots of leftover unused imports, so I cleaned them up.
Yeah, it'll be set automatically but can also be set directly. This will be used to normalize the risk metrics.
これは結局意味ないという話じゃありませんでしたっけ。
why the else here? Dont we do onCreate always? Just curious.
Typo: output something info => output some info
I see two options (literally) that would work:

- `isTopLevel` boolean
- `triggeringView`, then you could check `this.parent === options.triggeringView`

One? The other? Both?
Was using this to add in the batch method/path for batch ingest...  And now it doesn't seem to exist?  Any ideas?
nit: You already have a reference to this button in `checkAnswerButton`, it will still be in scope since JS supports closures.
You can get rid of the "Hexadecimal:" label. Also, we (just by standard) only capitalize the first word in the title.
I swapped this repeated action stuff out for a simple Array.prototype.map call. That won't work in Old IE versions, but it's fine for an example.
Ugh I thought I got rid of that method altogether. I'll fix that.
それぞれの配列を同じ場所にある値を元に結合します。配列のインデックスを通じて強調している分離したデータソースを扱う場合に便利です。入れ子になった配列のマトリックスを使用する場合、*zip.apply* を利用することで同様に結合することができます。
same comment here as for the readme
Please give it more corresponding names.
Like: leftSamplesCount
or something like that
Good catch. I'll do a style guide sweep later.
We should remove the spaces from the URL.
See my previous comment about building the request URL.
Personally, I'd move towards core.cache over ehcache as it's more likely to
gain speed improvements and have a familiar API for Clojure development.
On 17 Sep 2012 22:08, "Chris Price" <notifications@github.com> wrote:

> In src/com/puppetlabs/puppetdb/scf/storage.clj:
>
> > -(def resource-identity-hash* (memo-lru resource-identity-hash* 40000))
> > -
> > -(defn resource-identity-hash
> > -  "Compute a hash for a given resource that will uniquely identify it
> > -  _for storage deduplication only_.
> > -
> > -  See `resource-identity-hash*`. This variant takes a full resource as
> > -  a parameter, whereas `resource-identity-hash*` takes specific
> > -  attribute of the resource as parameters."
> > -  [{:keys [type title parameters] :as resource}]
> > +(defn resource-hash*
> > +  [& things]
> > +  (if-let [result (@hash-cache things)]
> > +    result
> > +    (let [result (apply utils/sha1 things)]
> > +      (swap! hash-cache assoc things result)
>
> I was (am) also interested in using something that might support ehcache,
> but that project says that it is dead; it seems the authors are now
> steering people toward the clojure's core.cache instead (even though I
> don't see any mention of ehcache there).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/puppetdb/pull/277/files#r1621932>.
>
>
No because the thumb method returns a exception if call without a correct argument. But have cleaned it up a bit.
I did some work to have a generic `getMe` function that can be called from various places so I included this PR in https://github.com/sakaiproject/Hilary/pull/156 and incorporated your comment.
цю фішку краще винести в вьюшку, яка вище. тут ми рендеримо список постів, а не список постів+пагінатор (виходить неочевидно).
Document this plugin hook - `swiftriver.river.disable`- here: https://wiki.ushahidi.com/display/WIKI/Plugin+Hooks
A definition shouldn't be in a note. I suggest 2.1.6.1, Open-ended Date Range and 2.1.6.2, Closed Date Range.

As a general comment, paragraph titles should be in Title Case.
В одном из комментариев в обсуждении проекта Рахим отметил, что мутировавший символ должен обязательно замениться на другой. В текущей реализации символ A может замениться опять на А.
Мутируйте обе клетки, так интереснее. Да и по заданию так.
Ошибка: вы сделали переменную, в которой указывается количество генов в последовательности ДНК, но при этом массив индексов у вас создаётся с памятью под 100 элементов. и это при том, что в цикле вы заполняете массив до self.DNAamount
Понадобится когда я разберусь как заменить "int* indexes = malloc(sizeof(int)*percent);" ниже по коду на аналогичный вызов, создающий autoreleased объект.
...конечно, верно. но если я явно не заполню эти эл-ты нулями, то откуда я знаю, что там изначально была не единица...
You can send a new PR for this. I can fix that too if you are busy.
Maybe there should just be one `RAC` macro and one `RACAable` macro, and they can accept one or two arguments?

[metamacros.h](https://github.com/github/libextobjc/blob/master/extobjc/metamacros.h) can totally [do](https://github.com/github/libextobjc/blob/master/extobjc/metamacros.h#L44) [this](https://github.com/github/libextobjc/blob/master/extobjc/metamacros.h#L154). :trollface:
If it's running immediately, shouldn't this be `to` instead of `will`?
if stop is not None:  # equivalent but more explicit
Of course.  Oops.
That makes sense. I've updated the text accordingly. I've also made a distinction between overriding and extending a service
The Argument class is already configurable in the RequestParser and this function uses it. 
Isn't it a little too complex to be configurable ? 
What about a simpler callback design for the parsing needs ?
thanks! I did realize this was a bad way to write the tests, but just couldn't figure out otherwise, and noticed some other tests in other test classes did use internal @reserved_connections. But if you've got a way to do otherwise, great.
On Mon, 27 Feb 2012, Sergey Nartimov wrote:

> > @@ -112,7 +112,7 @@ def javascript_url(source)
> >          # <tt>public/javascripts</tt> it will be included as well at the end.
> >          #
> >          # You can modify the HTML attributes of the script tag by passing a hash as the
> > -        # last argument.
> > +        # last argument.  
> 
> trailing whitespace here

Thanks.  I fixed that and pushed.

Patrick J. Collins
http://collinatorstudios.com
replaced with `*sympfiy(args)`
Why extend Actor at all. There is a self-type to Actor already. Then user could write: 
    class MyActor extends Actor with Stash {}
Which is more clear I think.
i think this can actually be more than 3, so change this to:

```python
traits.List(traits.Int, argstr='-m %d', sep='x', ...)
```

try to use this parameter in the doctest.
Docstring should be removed, otherwise `np.test(verbose=2)` won't show the arguments to `yield` (IIRC). Same for other test methods.
А, убиваешь, все ок.
Me gustó mucho la solución, pero esto me dejó en duda: ¿hay alguna razón por la que quieras mantener un buffer de 255 y no leer todo el contenido en memoria como hacíamos antes?

No creo que los archivos sean TAN grandes como para generar un problema.
```_TTYPE_ENCODING``` is not defined. ```0``` is of course wrong, instead ```_TTYPE_ENCODING``` should be defined, but I don't know how.
sounds nice, would you like to go ahead and work on it or should I ?
Empty method should perhaps raise an NotImplementedException?
Can you please format this line so it is readable? Use some intermediate variables for the values. Also, when a method has a lot of parameters, the standard way of formatting it is to use multiple lines and line up the colons:

```objective-j
    var isSharedController = [CPDocumentController sharedDocumentController] === subclassedCPDocumentController,
        cpAlert = [CPAlert alertWithMessageText:@"Is this the shared instance? " + isSharedController 
                                  defaultButton:@"OK" 
                                alternateButton:nil 
                                    otherButton:nil 
                      informativeTextWithFormat:nil];
```

Also note that you should always use === if you are comparing objects that you know are the same type. == does silent type coercion.
This seems like it would only apply to the nodes that have the arbiter option set.

I planned on having two roles working in conjunction when using a replica set with an arbiter.
1. ReplicaSetMember
2. ReplicaArbiter

They would essentially be the same configuration except that the arbiter would also have the arbiter attribute set.

If you were to utilize the recipe in this way, it seems like it would work just fine as only the arbiter would have the attribute set.
This should not be part of this patch. In fact, there is a second pull request open that tries to achieve this as well, but it's problematic for the REPL:

https://github.com/felixge/node-ar-drone/pull/28
spelling: incoming_migration
Figured I'd try this technique out once, as an alternative to writing the dictionary out manually.
tree() is autovivifying, so there's no need to define `res['root_history']` before mentioning it.
Couldn't this be more efficient? Except in cases of rebalancing, these two calls to isKeyLocalToNode() are doing the same job, aren't they?
It should not fail now. I reverted maxThreads to 4.
I had problems determining what to name it to, hence :misc. :player might also be a bit too generic, how about :media_player or even :portable_media_player?
what is ``$function`` here ?
No, I would say you can leave it out, and we should close #1386.  Note that the d.pop("patchA", None) is inside a block that is executed only if "patchA" is not in d, so it will never pop anything from d; all it does is to set "patchA = None", and patchA is not used from that point onward.
On the other hand, if you use `register_cmap()`, the new colormap shows up in `cmap_d.keys()`, but not in `datad.keys()` or `_cmapnames`, so `cmap_d.keys()` seems like the right answer.  I guess showing the `_r` colormaps too is legitimate, since ones you create with `register_cmap` don't have any `_r` version.
probably not necessary to assert this stuff but i'll let @m8ttyb make the call.
Is this even necessary to have anymore if you are changing this test to be same phone number to same phone number?
Okay, however we don't need the if statement because we're expecting the app to be running still.
Changed to "... commentaires en minusules ..."
can you change the 'x' to 'external' for consistency?   We might also want to call alarm_type 'external_alarm_type' if it is an OMS alarm.
The warning was meant to be displayed ONLY if a ticket is assigned to someone else..  I guess it doesn't hurt but to me warning about an active lock on a ticket (next else) is more important than the team. 

May we actually need to move the lock warning to the top.
Because the other comments were also kept :)
But now that they're all implemented, I can remove the comments, sure.
Spacing ('m', 'e', 's', 'h')
Extra space in the beginning
This line and the next can be consolidated into

```
widgetsToLoad[widgetName].bundles = {
    'default': convertRelativeToAbsolutePath(widget.i18n['default'].bundle, widgetsToLoad[widgetName].prefixPath)
    'locale': widget.i18n[locale] ? convertRelativeToAbsolutePath(widget.i18n[locale].bundle, widgetsToLoad[widgetName].prefixPath) : null
}
```
Do we need the `|| append` here?
Compile error: The logger in this class is called `LOG` not `LOGGER`.
please add yourself as sole copyright holder (instead of TU / max planck)
Re: Cancel - It did have "Uploaded" in there, but was replaced by cancel accidentally when the translation stuff was fixed up. I will add it back.
Minor: Selectors within an entwine definition should almost always be relative, so `this.find('.cms-preview-states')`.
why not \Newscoop\Event\EventDispatcher class?
As I mentioned in the commit message, this is purely a refactoring--I just took the algorithm used to dynamically generate the stylesheets and converted it into actual static CSS. I don't know why this line-height doesn't match the one used for div/pre because I didn't write the original code that generated the CSS dynamically.
@tlubz wups I think this chunk of code is completely wrong, I somehow read 'alternatives' as 'participants' while typing this bit up @_@
The difference between destroying and resetting is that in resetting, we don't want to destroy the experiment, just all the participants associated with it (along with setting completed_at and outcome to nil).
This is more complicated than it needs to be -- just entry = TAILQ_FIRST() will set entry to NULL if there's nothing there.
I think you should add a new paragraph to the WiredTiger Architecture page, noting this information and why it's all cheesy goodness.
Why have braces around a single line?
I like this idea.

I  did this originally because fixing implicit records for column-store made me realize we documented that instantiating record 5 implicitly creates records 1-4, and so applications could reasonably use those records in subsequent session.truncate calls.   I think your approach makes good sense.

Two questions:

First, o we always succeed then, and never return WT_NOTFOUND?   So, if I have records A, B, and C in a table and call:

```
cursor.set_key(H);
session->truncate(NULL, cursor, NULL, 0);
```

it would succeed?

Second, the problem with moving it into the session level is that we need some way to do cursor comparisons and the session level doesn't know how to do that.   We'd have to export some cursor API up to that level?

I'm happy to make & test this change if you want (although we have to talk about the second question, unless you just want to bite the bullet and offer cursor.compare which does a full comparison (as opposed to cursor.equal which does simple equality).
Are you sure ``'You must specify a data...ns array with key "db"'`` has the correct type as ``string`` is not a sub-type of ``string``?
Is it possible to add a ``@param`` annotation for parameter ``$timeout`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
who's -> whose
Well, ``{{ "foo"|title|gettext }}`` gives you the exact same issue than ``{{ gettext("foo"|title) }}``. And using filters would respect the semantic of Twig filters and functions
This could also be done using `my-some`:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
Just need to fix up this return information.
I should stop worrying (and learn to love the bomb) but how come this.framesheet.getUsedColors() didn't return the proper colors ? I don't understand the bug nor the fix :)
please use ``&&`` instead of ``and``
incomplete tag
multi_resize with convert can use one 'convert' operation, rather than many:
http://www.imagemagick.org/discourse-server/viewtopic.php?f=2&t=15438#p54540
Either would work, yes. Using the string here calls `document.querySelectorAll` (plus some Sizzle magic), as opposed to just using an existing variable.

Referring to the document is the same as referring to the body, in this context. `$(document.body)` is possible, but it looks a bit ugly, is longer, and doesn't make a difference to the time taken.
An advantage of making it optional is backward compatibility.
Is this really necessary? Because it is less supported by browsers.
This line you can remove. We are not using that.
So just move above lines here, to update. So instead of:

```
'horoscope_forecast': horoscope_forecast,
```

simply:

```
'horoscope_forecast': horoscope.forecast
```

and so on. (There is no `[0]` if you will use `get()`.)
You already have models imported.
You didn't yet change JavaScript in the way I commented. Will wait for that.
Should be fixed before being pulled, I would think
Please doc this.
Would it make sense to make the argument a collection in case I want to use more than one logger in the block?
last_response
The benefit of a regular expression is that it's shorter to read and less expensive to execute.
Should this be `class NgxFetch : public PoolElement<NgxFetch>`
Here could be used code like

```from PyInstaller.compat import is_cygwin```
See new properties in the pom...
The problem isn't with init.  I realize that doesn't use the group stuff.  (In fact, it took me a while to figure out why you were even setting these groups, until I realized that it was for the config module that is yet to be written.)  

As for what the right implementation is to let config know how to set these values, I don't really have a good suggestion.
 
- You could have "size" and "size2".  Config could check if size2 has any elements, and if it does, it would treat it the same way as size.  In fact, you could extend this to any number of sizes.  Once size2 exists, you could continue on and check for size3.
- Each parameter could have an enumerated sub-group.  `fwhm2 = SimpleParam(... group="size", sub_group=2)`  sub_group=1 should be the default value, so usually you don't need to set it, but DoubleGaussian could set sub_group=2 for the relevant parameters. 
- We can get rid of DoubleGaussian as a specialized thing, and just let the user add two gaussians by hand, which wouldn't be that much more onerous and might even be clearer.  (It would also allow each component to have different ellipticities, be offset from each other, etc.
>I guess I don't find it confusing for config.image.noise.type = Gaussian to mean something different from config.psf.type = Gaussian. Context matters. Obviously we can't have two classes be the same name in python, but it's not confusing to have the same word mean different things in the config files for two different types.

I disagree, as when looking at the config files you don't necessarily see `config.psf.type` but just `type :` (or similar).

>For example, you say that PoissonDeviate doesn't have "much earthly use", but in fact you yourself used it when implementing the CCDNoise.applyTo function. So it is useful.

That was the C++ layer deviate, whereas I do not recall seeing the Python wrapper used once anywhere.  Do you know of an example?

>So it is useful. It's just not what people mean when the say an image has "Poisson noise".  The meaning of config.noise.type = Poisson is to use each pixel value's signal as the mean in a PoissonDeviate. In other words, CCDNoise with read_noise=0, as you say. (It turns out also to be directly applicable after photon shooting, since then the Poisson noise of the object is already on the image, so you only need to add the sky noise, which is a constant, so you can use PoissonDeviate directly on the whole image.)

And this is my problem: we're doubling up not only the documentation requirements (Poisson noise means X, PoissonDeviate Y) in a confusing way, more importantly we're doubling the amount of information that we expect users to carry in their heads / have to hand, when I'm not sure that more than 50% is necessary.

>I don't mind changing some of my names for various concepts in the config structure. However, I don't want to force the naming choices to conform to the limitations of our back-end implementation (e.g. Gaussian can't mean two different things). We should choose whatever names will be clearest for the user. Then if it is convenient to make our back-end stuff match, we can do that.

I think that what would be most convenient for the user would be the ability to mentally index a term and have it mean one thing.  They will then be able to look up that term in whatever documentation we provide (in Python or doxygen or wherever) and have it explained clearly without contextual caveats, or needing to remember that although they specify `Poisson` noise in the config file that actually provides a `CCDNoise` with `read_noise=0`, so they must look up `Poisson` in the config dox first before then trekking over to `CCDNoise`.  For me, it's not a question of conforming to the back-end for the sake of it, it's allowing the user and our documentation to be unambiguously linkable, indexable and ultimately searchable with minimum ambiguity or presumed contextual insight.
I guess this will work; the problem is that there are plenty of other packages with the string 'chef' in them; maybe have a requirement for the line to start with chef in the regex?
.NET coding conventions use Pascal case for methods 
http://msdn.microsoft.com/en-us/library/4df752aw(v=vs.71).aspx

Since this is what the rest of Pandora Keys does, I would like to stick to this. This applies to throughout the rest of the code.

Also isn't it Logging not loging?
Good question. I think we can play around with this to see if we can cut it to 1.5 or even 1 second, but I think this was initially set because it was the minimum time needed to make sure everything was set. I personally hate doing the setTimeout calls, because it seems loosey-goosey; perhaps the popcorn.js will be the way to go.
Agree, any edit to user data is better to be done in users/edit.
Suggest we let `return f.get()` deal with the exception catching.

But the time we do want to log it gracefully is if it timeout out after 60 seconds, causing us to interrupt the task. For that, I think a LOG.info is more appropriate than debug because this is really the root cause of why the test is failing; without this stacktrace, it's hard to tell what was wrong with the connection (e.g. if a test fails on jenkins in this way then our only response will be to either change the log4k.properties to debug and hope it happens again, or to change this code.)
Sorry. I think should replace it to alias.
I would suggest to also add a number of tests to mcon/tests/parse-test.c (or create a parse-test3.c) - this makes it possible to test the behaviour also outside of the PHP extension's context.
What values can create_user have? If it's just True and False, then the if block this if block is in already covers the False case.
мені не подобається назва змінної. вона не "говорить"
I might be wrong, but calling `register(true)` prepend the apcClassLoader
Actually any change from the above can break things. That's why I added 

> This will only work if web server is launched under your group or your user, otherwise it can break your project.
There's a unit test checking for this in the context which is now failing. I assume that removing this is the right behaviour? Could you remove the test ``tests.functional.basket_tests:BasketSummaryViewTests.test_shipping_charge_in_context`` if that is the case?
All the other tests are fine.
А данные из формы разве не всегда передаются уже в формате String?
nit: why do you need to do that?
> By this point the engine redetected the game, since it was initialised, and thus you should have access to ADGameDescription instance which defines all required things, including _gameDescription->gameid.

That is not the case, currently there is no detection phase guaranteed before this function is called and in fact there isn't one before clicking on "Edit game..." for example. So this really can just work with a user target supplied. Furthermore it's correct that for singleId engines, this won't work well right now, since checking the target name is just plain madness, since that could be *anything*. But then again this is really rather a problem with the singleId stuff and not with this interface to access target specific options.
That is weird, since the only place it is ever called has Cleanup() called right before.
You're closing one extra paranthesis after ishuman(occupant)
blank line needed here.
Wouldn't it be clearer to define initWithDetailsController() instead?
Nu e nevoie de afisari.
I'd like to chat a bit about what you're working on here.  I noticed some problems that seem to be cwd-related when issuing snake commands where your vendor, src, test etc directories aren't in the root of the repo (as in the restructured ns_ingestion repo.)

if you do this:
"git snake test (or dep or build or whatever -- same story)"
it will look for a test directory in the root of the repo

if you do this:
"~/.snakegit/bin/python ~/.snakegit/src/snakes/test.py"
it will look for a test directory in your current working directory

The latter is the only way I can issue snake commands when working in the restructured ns_ingestion repo.
Not terribly convenient, and it's also a pain to debug since the problem goes away when executing the source I edit.

I think this has to do with git aliases being executed with a cwd of the git repo's root.
Sort of-- it is analogous to the terminal width (when it comes to code, I am all for <80 lines) that the thor cli is aware of.  Since the output in the tests will vary with the terminal width, we need to set it.  I set it to a terminal width that I thought would be more likely in the real world by an end user.  We can change it to 70-- that implies changing the tests to reflect that.  However, I have my doubts than when all the functionality is complete, though, that all our print_tables would fit within 70 chars (or even 80... or really for that matter maybe even 118).

Also to be clear -- this is for testing only -- we are not going to set or assume THOR_COLUMNS anywhere else.