labofsahil/github-event-dataset-2012 huggingface dataset:
It's not relevant on unix, since I'm creating `socketpair()` for any kind of pipe. And it'll be mandatory for windows if we'll move from `uv_pipe_t` to `uv_stream_t`, since the latter one doesn't contain this information.
should be fixed by defining correct default config file location
it's not redundant cause when running in Linux - the process moved to background and it still recognized all parameters that already were defined. 
there are two runnings - first is to run myself in background (here parameters defined), second - actual running in background - here in Linux, in contrast with Windows, process that run in background recognized already defined parameters and second attempt to define parameters cause to unwanted exception.
it's the reason that this code run in begin/cause block
Going forwards we should be using an appropriate AlertCode and the formatting of the logs should look consisitent - see the PairActor for an example of how to do this.
y synched?
needs literals
there is a C++ lexer for code blocks, just put cpp. 

For future reference see: http://pygments.org/docs/lexers/
I'm totes changing "data" to documents
Please fix this part
Bit picky, but this should either be "Replaces user style", or OVERRIDE_STYLE should be "Override user’s style".
As long as he's not using the value itself for anything, but is only checking that a value is present, this is acceptable. The same is done elsewhere to determine whether a form has been submitted.

That being said, it might be a good idea to use the $request->is_set_post() or $request->is_set() methods.
We don't think this should ever be changed.
Should I use sql_build_query so that we can simple change the SELECT part of the query? We can make similar change in author_search function too.
If this came from plupload either link to their docs where they specify this as correct mime type or open a ticket with them to change to octet-stream.
We should probably also call `$kernel->finish($request, $response);`. Perhaps we can even move exit_handler() to a listener for the kernel.finish event.
I personally dont like inheritDoc, as my editor does not resolve them.
For me personally original, and your suggestion are still not the best; original version was copied from ticket. What about:
"To change your password, your email address, or your username, you must enter your current password."
?
asserting these are numbers or their broad ranges of values would be good?
I don't understand the distinction between _checks and _checkMap.  They both seem to may from check ids to checks.  Why do they both exist?
Discussed before. No :)

http://en.wikipedia.org/wiki/C%2B%2B11#Type_long_long_int
Same argument as before:  the `callback` param is to a function that's internal to commands/compile.js, and it always passes the callback.  Guard still needed?
Looks like we are trusting anyone who implements a factory to put the coord dependencies as the keyword args and nothing else.  This should be explicitly stated (perhaps as a note in the doctstring of ```AuxCoordFactory.__init__()```.
I tried it out but ran into issues (see earlier comment). I propose we tackle this in follow up work for non global data.
TODO: name & docstrings...
On its own I'd agree that `pressure.bounds` is pretty weak. But in conjunction with the following lines that check for the ValueError it makes sense.
what is $do_set?
How hard would it be to implement Mul?
Ok, thanks. Can you just add a comment that explains in which case a ValueError is raised and in which case no error is raised? (I guess it must be some config option?) This way it'll be clearer :)
Add `'ISSUETRACKERS['JIRA']` to settings-test.py if it is required for the tests to pass.
"to download", this is still a part of the sentence above.
Опции из нескольких слов лучше называть через дефис: `--arch-server`

Но это же не только просмотр arch, но и plan? Я бы назвал `--inspect-server`, или как-то так. Или даже просто `--inspector`.
Great info! That was what I wasn't sure about. Will fix it tonight.
this renders inside the "note" box, not sure that's desired?
This test is not such a good idea. I think the order in which signals are executed is not guaranteed but rather an implementation detail and the test does not check if a_signal and c_signal trigger the receiver at all.
What is a version vector?
Sure. Let's do that.
It's a bit funny that we still have this win32 stuff around :P
I think we should move these out to a dynamicModels.py file, which we import in models.py.
I learned something.
Belongs in commands/base.rb (because it can implicitly use options).  Moved there
Do MediaFone actually want JSON back from us?
I don't like the comment that it clears any previous vote. It makes it sound like it does two things. If it's not clear by just "Downvote the object" then we can expand on it by saying:

"If the object has not already been voted on by the logged in user, it adds a downvote, otherwise it changes her existing vote to a downvote."
actually it's pretty minor (only about a 10% penalty in a 1mm-length Series that's 50% NA)
Please change this to something like:

```
from x.y import (
    z,
    a,
)
```
ace7f1b5d4c1fa312ce04fdaf46852e28c73714d
nit: `size() > 0` --> `!...isEmpty()`

Prefer isEmpty() wherever you can; in some collections it's way faster (for example, ConcurrentHashMap)
Why add to a set when you can just keep a reference to `getInjectedClasses` ?
I believe that one was an accidental change. I'll revert it.
The change to add the `IllegalStateException` was added after the 4.11 release, so we can fix it now without breaking anyone.
This should never happen if validation passes, right?  In this case, I think we should just let the IOOBE propogate.
this block of code probably belongs in didFinishLaunchingWithOptions.  this addSkipBackupAttributeToItemAtURL method purports to be a general method for setting the attribute on any resource and shouldn't be concerned about creating this particular resource, or any resource really.
I wonder if we should call this `checked` rather than `selected` (which sounds like I might have just chosen the menu item).

Also, when the user checks/unchecks an item, I wonder if we should pass that to the command.
Hmm... I thought the result will be empty as the cursor is after the begin tag. ie. after ``>``
Move to first line of function.
Hopefully the menu "header" can simply be hidden so we don't need to compute its height at all.
If we keep this change as is, then ``autoAddRemove`` should be renamed to ``autoRemove``.
I think these should just be top-level constants inside the Menus module, so from outside you can just refer to `Menus.BEFORE` instead of `Menus.insert.BEFORE`.
i updated it to do it with apf

there is an issue with apf databining rules, specifically when you add two checkes in a disable attribute 
but i will review and merge ruben offiline branch, which removes the first check 
so should be fine afterwards
Add comment to explain acquiring locks in the same order.
Agreed.

Though I do have a mind to, in a another pull, change these references of
scaling_bloom_t.  To me, a scaling bloom filter is something different,
i.e. the traditional scaling bloom filter that scales minus the counting
aspect for removals. But that may come later.

On Wed, Sep 12, 2012 at 4:31 PM, Pierce Lopez <notifications@github.com>wrote:

> In src/test_dablooms.c:
>
> > +        if (positive) {
> > +            stats->true_positives++;
> > +        } else {
> > +            stats->false_negatives++;
> > +            fprintf(stderr, "ERROR: False negative: '%s'\n", key);
> > +        }
> > +    } else {
> > +        if (positive) {
> > +            stats->false_positives++;
> > +        } else {
> > +            stats->true_negatives++;
> > +        }
> > +    }
> > +}
> > +
> > +static void dablooms_bloom_check_and_score(scaling_bloom_t *bloom, const char *key,
>
> this is just a nitpick, but I think it's more consistent to call this
> scaling_bloom_check_and_score()
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitly/dablooms/pull/51/files#r1591605>.
>
>



-- 
Justin Hines
Columbia College '13
Computer Science and Math Concentration
I use your old function and then add the log to it.
This way I did not double code or destroy interfaces.
This tag should match the class name
form_perks needs bleach.linkify as well. Use:

```python
form_perks = bleach.linkify(bleach.clean(form.job_perks_description.data, tags=ALLOWED_TAGS)) if form.job_perks.data else ''
```

Same with form_description. Reduce to a single line.
If a ParseException can be thrown somewhere else, the second call to invalidateUserInput is meaningful. The throw-catch pattern is dodgy, indeed.
This does not exist for mongoengine fields.
Well when restmail is invoked from the context of the test then we've (usually) already instantiated browserid so we can get the Regex from there. You could count emails from the test too.
The event everything else listens to is `projectchanged` (e.g. https://github.com/mozilla/butter/pull/1011/files#L5R763).
All of this indentation, actually.
Dead code here, 2 lines below as well
lets yank this out until Opera 12 is officially out and csslint supports its new features
might be faster to stick with the if/else: http://jsperf.com/ifelsevsmax
There is additional logic in our save/restore, but it doesn't look like you modify anything that would warrant us calling it.
needs to be deleted
The master calls this function when it freed the old cycles.
Our code style is to have this on the above line. I know that's slightly different from what IntelliJ reformats to but let's try to stick to our version.
Как я понял, здесь всё таки смысл «не фризить картинки»
By all means, if you could sort this out that would be ideal from my point of view.  Frankly, your going to be able to give this a lot more careful thought than me in the near future.
Oh, I see now, I missed the new at the end. np then
http://msdn.microsoft.com/en-us/library/bah54t54.aspx :smile:
My point is that "slowly", it will take a lot to have all of them fixed, and if we do some massive automated fix of them, there will be no benefit in having them fixed now because it will cost the same to fix 5000 files or 5100, so you can save your time :)
do an early return instead of if/else. Also see my comment about this.goIsRefresh above.
Also if you add 'mozChromeEvent' to the events  array you will be able to use |this| instead of LockScreen
I wouldn't say it's an 'excuse'. Just my reasoning.
I was copying from possibly the most established and tested code in all of premake...
I prefer your solution too, but I figured it was safer to follow the precedent set by the stable+tested code.
I'll change it.
IRC, the correct Pythonic way is doing `except Exception:`
那叫validNumber吧~
@icedfish 确实，这个不应该跟SearchResult有关。
我曾经试过listing直接拼接搜索结果的List，各个方法都是返回一个array，而不是对象，但是这样也就失去了totalCount等信息。

或者能不能考虑把SearchResult extend出来，在外面做这件事情。你觉得呢？
@TheBlueMatt it was originally above the if version block, but then it would miss an opportunity to fire off right after that version message, which would be an ideal time. It can't go into the disconnect handler, as then for which node would it be sending the getblocks?
You don't `@requires` here. `@include` suffices.
Is het niet logischer dat die isAllowed deel uitmaakt van FrontendProfilesAuthentication?
There should be no attributes that are not always defined.  Make sure this is defined in the class at the top level (`_jpg_supported = Bool(False)`)
blobstore stuff isn't needed for quantum.. also, change dep from jclouds-blobstore to jclouds-core
add endpointName
javadoc this class
What is `[=!?]?` for?
Needs an `@return`.
Looks like the nbsp is a visual formatting hack to prevent "Design" from appearing on its own line at mobile sizes. Without it we get "Different by<br>Design" and would prefer "Different<br>by Design". 

Forcing a line break with <br> won't work because it's all one line at larger windows sizes. I'm not sure of any other way to control where the text wraps, short of enclosing each chunk in some other element with whitespace:no-wrap (or maybe display:inline-block). So it's certainly presentational and shouldn't be necessary, but I think we need that nbsp.
Easy enough (and sensible) change to make. I'll wait until I see the ok in the bug.
@AdrianGaudebert does this not import base? 

from socorro.external.postgresql.base import PostgreSQLBase

If so, can I just call self.add_param_to_dict
`form[name]` should now be `value` instead, no?
Why do you move that out of the function? For a small class like Bugs that has only one method it works, but other classes like Crashes can't do that. Is it not better to keep it consistent?
If users want to keep a perfect profile by pulling the card after a failed song, that's their business.  The dynamic memory cards feature is hidden behind a config options and is initially disabled; unless the user knowingly enables it, the game behaves as it always has.  If an arcade owner loads OpenITG on their machine and knowingly enables the option, I'd say it's the owner's responsibility to inform other players of the difference.

The feature is mainly aimed at the event mode, which otherwise does not save the profiles at all while playing.  Besides allowing swapping players in and out at will without the delays associated with backing out of song selection and entering it again (useful when more than two players are present), it also offers some insurance against the game crashing and throwing away an hour's worth of scores (I once had that happen after playing VerTex hard 5 times in a row to get a pass; then I had to play it 15 more times to get another pass).
Thrift uses $GLOBALS to store the path to the thrift folder
This is copied code but we should fix in a followup.
this constraint doesnt support the exact number?
The `salt` can't be generated in this function as it returns only the encoded password.
@stof It was unknown to me. Thanks
why DT instead of Type ?
see #5879
Why not `func.apply(this, args);` to maintain the call scope?
暂时写成这样也可行
Does this work on older Pythons? Seems the None arg was added in 2.6.

http://docs.python.org/library/stdtypes.html#str.translate
Minor note: The outer `float()` shouldn't be needed in this case, as multiplying a float by an integer yields a float in Python. If you wanted to be explicit for readability, you could also change the `100` to `100.0`, such that all three numbers involved are floats, and likewise remove the outer `float()`.
what if people override this method and forget to call super.propertyChanged(). Then the derived value will no longer be available. 

You might want to look at DynamicSetProperty and see if you can use the same trick to avoid that from happening.
On second thoughts, I have no idea why this appears different. I checked my files and they seem correct. I think its an issue of tabs vs. spaces.
print it to log4j
spaces before and after operators please
don't we need ``from django.utils import simplejson`` for compatibility?
looks so to me too, changing the paths
Ahh, nm, understand, this is to keep it from recalling simpledb.  Disregard
I think it should be. It's rare, in tests only ATM, this method will ever be used. Most appenders don't have a default format, but handlers generally do.
This makes sure the parser barfs if there is a crap element :-)
Please have a look at #2148 on why it is ok to change these as part of 7.1.2. In short 7.1.2 will be the first release with meaningful ids for the osgi subsystem
Would you also be able to add a test to make sure that this change does  not make other contents of war available to the class loader? (e.g. make sure you can't use getResource on stuff in the root of the war).
需要加入接口说明和参数说明，最好加上版本号
@longhengyu
This looks like it works, but I think it would be better to just put that zero-argument case directly in the event handler for the repeat button and make this function always use one argument.
This file makes me so happy :D
Update comment here.
Any reasons for moving this line?
Why can't you simply nest them so the callback will be called only once?
For the comment, the paired device list are the newest already when we show the selector.
We could check the function getPairedDevice().
It's a callback function to run it and show the selector in the end.
Thanks crack :)
Remember `'use strict';` and the vim header!
`<a>` becomes block level on html5 http://dev.w3.org/html5/spec/single-page.html#the-a-element
a popup will appear periodically reminding you to sync up your FB contacts. that's not currently implemented.
NOHAX
Since it's a command that's being run, the expectation is that it returns some form of helpful error code, which is what I'd recommend returning. I try to only return True/False in cases where I specifically name the method things like is_something_blah() where by the name of the method you'd expect it to return True/False.
Seems safe to add these around all read operations, since they should be less likely to fail. But sure if we want to fix each problem as it arises that's fine by me.
Want to make that change or should I?

Other than that, this looks great and I'll be happy to merge it.
Nah - that makes sense.
Changed in this commit:-

https://github.com/skyluc/scalatest/commit/8726e7dc26d96c94d3f41d3f157d0309cb56f363
WebKit landed support for toggle (token, force)

this.viewport.classList.toggle('horiz', this.horiz);
Yup, fixing.
We should be using python2.6 in the meantime.
dont need a px for 0
Are we now getting all github and zendesk closed tickets? or is it still only github closed tickets? curious as to why the change in the comment.
Is there a minitest that should be run in this block like:

    found_pycql.must_equal true

?
Cool! I didn't know setter/getter syntax was actually supported! I guess I shouldn't be all that surprised since it's definitely available in ActionScript.
in your example `$groups = null` trigger 2 tests
I don't need to? Does that mean XMPPClient.setServiceParent(self, parent) in the setServiceParent override will be enough?
I'm not too familar with that code, so any help is greatly appreciated.
This should link to #1992 so users know what's solved and what's not.
These tests are great, but this is testing code in `buildbot.process.buildstep`, so it should be in `test_process_buildstep.py`
corresponding is still right, notification isn't since it acts on multiple ones ;)
The commits I took from your branch caught Exception so I just kept it. Do you want me to change it to RuntimeException?
dummy text?
It is done in TmThreadCreateMgmtThread which is used to create the thread:
ThreadVars *TmThreadCreateMgmtThread(char *name, void *(fn_p)(void *),
                                     int mucond)
{
    ThreadVars *tv = NULL;

    tv = TmThreadCreate(name, NULL, NULL, NULL, NULL, "custom", fn_p, mucond);

    if (tv != NULL) {
        tv->type = TVT_MGMT;
        TmThreadSetCPU(tv, MANAGEMENT_CPU_SET);
    }

    return tv;
}
KIll benchmarking code
Shouldn't this be + instead of * as * will match zero spaces and thus split by character?
Missing endind ";"
I'm not sure I understand that comment, but only use case where one would want to provide custom resolve is to imply more security concerns or define completely different `id` resolution logic. For example SDK does that now it does lot's of different searches and than writes results to manifest which is used by passed in `resolve` to look up what it actually maps to.
Whoops! I just pushed another patch that passes requiredEmail through (unchecked), and shuffles the try/catch section a little bit to anticipate some sort of validator being added to the requiredEmail assignment.

One question though: why didn't my tests fail when I regressed requiredEmail? Does that imply that we're missing test coverage for that feature? (I have phantomjs installed, but not mysql, so it's possible that requiredEmail is covered by a test that I didn't run)

In general, the "copy only what you expect to use" pattern might protect us from other surprises, especially since it looks like internal code adds properties to 'params' that *didn't* come from the RP, in which case the RP might sneakily supply them itself.
File name is "mappnig.py"
Oh, I see, it gets locking for free via `ProjectBatchCommand`. So these imports should be removed.
As discussed on IRC, I have attempted to move this out of global scope, but this causes the test to fail.
There will be CriterionEqual, CriterionNotEqual, CriterionLike, ... You will want to have them all grouped together in your IDE, so Criterion must come first IMHO.
We should try the "confine" approach here (see acceptance/tests/windows/eventlog.rb)
ok, just remove it
make this long?
@cgmartin, I think we should ideally have a Zend\I18n\Translator\TranslatorAwareInterface that defines setTranslator(\Zend\I18n\Translator $translator); Then ere we can check if $helper instanceof TranslatorAwareInterface before attempting to call $helper->setTranslator();
s/Traits/closures/
@ralphschindler Can you help me with this?
if tall is the man, if blue is the sky

Best regards
Antoine Hedgecock
Senior developer / Server technician 
PMG Media Group AB
Tel: +46707972145

On Jun 28, 2012, at 6:45 AM, Gabriel Baker wrote:

>> @@ -79,14 +79,18 @@ public function getDocBlock()
>>      */
>>     public function getAnnotations(Annotation\AnnotationManager $annotationManager)
>>     {
>> -        if (($docComment = $this->getDocComment()) == '') {
>> -            return false;
>> +        if (null !== $this->annotations) {
>> +            return $this->annotations;
> 
> Yoda conditioning is the best kind of conditioning
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1581/files#r1065640
and not used
I would write it ``{% if bundle.license is not empty -%}``. It reads better
You don't need to wrap these in reset, they're set to default style already
Are there any header files to go with this static library?
Understand, thanks :) Leave it, please.
I tried your branch, I think you need to drop `:reload`. The tests then work fine for me.
Identifiers are always arrays as of class metadata. We shouldn't introduce more inconsistencies on that one (already a mess in the various ODMs, where that interface is currently ignored).
Shouldn't we, for all of those, use `{@inheritdoc}` instead ?
i'm not going to mention this anymore ;)
Should not be there ...
its code to reset an internal variable so cli.parse. can work multiple times without being additive.

i should submit a patch to cli though. i think setArgv or a new function should do it. shouldnt mess arround with the internals
Should the `error_message` attribute not go on the model field? Then you could leave the widget definition in the Meta class.
Should this, and perhaps the filename itself, be called test_performance_page.py?  At the least, your Mission page test's class is named TestMissionPage, so we should be internally consistent
if is_vouched is in kwargs, the User.objects.create method won't work.
You can't log into this website without js.
Given that this will be part of the tinderbox pull request, can you move this over?
Yeah, I don't understand why this is failing. My knowledge of vows is still limited, so I could use some help debugging.
in otwarchive / config / deploy / production.rb

# otw3 and otw4 are the main web/app combos
server "otw3.ao3.org", :web, :app
server "otw4.ao3.org", :web, :app 

I think should be 

server "otw3.ao3.org", :web, :app
server "otw4.ao3.org", :app 

As otw4 doesn't have a nginx or a squid instance.
replace with requre
I have a feeling this can be improved
"used each snaplet" is missing a preposition here :)
ありゃ、確かにそうですね。直しておきます。
Can't please both you and Bakksjø :(
A lot of "unnecessary" scoping is not something I like either, but this I find useful if your IDE does not have attached sources with javadoc (but maybe not exactly here where the call is internal).

However. Will not fix ;)
Does it make sense to color opposite sides the same color so that it makes more sense why their lengths are the same?
alternatively, if this is an array, run all the functions within?
Really minor, but I'd suggest not making this a final hint, but make the final hint something like...
"Person(1) still owes the bank - formatDollars(Z), making person(1)'s balance formatDollars(Z) (note the negative sign)."

Just a rough idea ...
version的判断没有用吧
I guess raising an exception is probably best. It's not too much of an annoyance to do this:

    quantity1 + quantity2.to(quantity1.units)

At the same time, it is really killer to be able to do `q1 + q2` and have the objects just figure it out, but it is ambiguous and that's bad.

btw I need to get consistent about whether it's `units` or `unit`. . .
No on both counts, so I've updated to ```prefix + '_ct105_rightCol'```, etc.
Shouldn't we change the delving fields from format to schema in the constants, so that this becomes more in line with the API naming and functionality
Anyway, instead of updating this code line, I will check if I can find the mocked class which introduce this bug (IMO, foo is too much generic fo a class mock, I will use an other name).
Can you declare `count=5` here. Even though it is in the method itself for a fresh set of eyes looking at the test it would be great to know exactly how many addons in the xml are being analysed for test clarity :)
Could we add a suitable explicit wait in the click method?
It seems excessive to me, but I'm not going to fight it if you want it in there.
better use getent passwd ( ldap/nis friendly )
I was doubting to call this `path` as it's not really a "path" but rather part of the URL that the UI is requesting.
That said, "URL" isn't correct either so I'll change it to path in order to be consistent.
You probably don't want to specify loginId here, as the columns will probably be the loginIds instead of a column named loginId.
Changing to util is fine, the changes to package.json ensure that the new version are not run by older versions of node.
waiting is bad, waiting is bad :) 

It looks like what you need here is CPS (or some way to simulate that behavior), no?
I see. Maybe the parameteres could be renamed to ``unusedPort`` and ``unusedConfiguration`` to convey this information directly in the code (just a suggestion, up to you).
These are just suggestions, you can keep implicits if you want, I just don't know if `apply` would work well through implicits, and that's kind of fun ;-)
Потенциально бесконечный цикл, хоть и с бесконечно уменьшающейся вероятностью.
В данном конкретном случае метод рабочий, но вы должны понимать, что так будет не всегда. Операторы сравнения в случае с объектами будут сравнивать их ссылки, а не значения.
пропустил, да должно быть dna size, причем его мы должны передавать при создании уж если так. Ок поправил в новом комите.
Спасибо, буду знать на будущее этот тонкий момент
retry the reexecute RPC.
"contain the URLs of scope lists, which enumerate the objects to be searched."  I think we can leave dataretrievers out of this, since the diamondd doesn't care who produces the scope list.  We don't want to stray too far out of scope here (no pun intended); for example, we won't be defining the format of the scope list.
Clojure里面常量是不是也用大写(`BYTE-BYTES`)好一点?
If no customStorage object provided use localStorage as normal
I'd prefer *not* decorating this with a `[CLSCompliant(false)]`

What's the maximum object numbers that could be reached? Wouldn't `int` be enough? If we could deal with more than 2,147,483,647 objects, we could still return a `long`
This is not a pthreads bug. It is a python one.
```return response.end(JSON.stringify(error));``` and no need for the else statement
Did you forget to check in `tests/assets/sample.jpg`? I tried to run the tests and it couldn't find this.
You can't use log4j here because it can't be fully configured until after the bundles have loaded because the properties come from the bundles.  So we could configure it in a default way, or just use System.out.println.  That being the case I don't know if this would be useful to expose more broadly - it depends how much is going on before the bundles are loaded.  Thoughts?
You could refactor the `wants_email_notifications_for_private_messages?` check into `message.should_send?` or something.
Don't prefix stuff with `_zsh`. You're not modifying core zsh functions. Rename it to `prompt_borra_set_zstyle_if_not_set`.
The context should be `:presto:module:prompt:theme:borra`.
`groupName`
It is used indirectly in existsAndUpToDate() method.
Please omit the line continuations '\'
when passing keywords, don't use space around the equals.
Y u no capitalize sentence? I'd personally bang a fullstop on the end, too.
Если кинул в мусорку — то мусорка. Если кинул вообще на инвалидный
индекс — то корень.
This should be the only situation in which we can successfully start a headless server.
Este constructor no era necesario, no?
Same here: Invalid fields are removed by the array_intersect. no need to list 'failed' fields.
I guess `sid` is short for "sample id"? Some extra verbosity is always nice to understand code.
Why disabling feedback ?
It was trying to require the `json` gem which couldn't be found in my environment when I tried to run `rake develop:using_bundler`
What about `posts = [Post.new] * 81`?
`cond` näyttäisi hiukan siistimmältä.
I'm not sure about the exception, but we should indeed i18n the error log.
Or wait to release that before handling this master change...
No need to create the request object. This makes your class untestable.

Use `$app['request']`instead.
I suggest you just go ahead and do it.
Rather than using the module level namespace, it might be worth considering constructing a class which has "test_" methods.
@NelleV This is another important suggestion by @dmcdougall.
Please use the strict comparison as we can do it :)
`if(0 === data["last_timestamp"]) {`
Cool-beans -- good thought -- we don't have these mocked or pickled so you can remove it.
Sure, I'll add this: `freq` is the number of occurrences of a repeating event per unit time [wikipedia].    But I accidentally fetched develop, so overwrote shit on my feature branch.  I've got to run to class, but I'll do this soon.
@dooremont Could you make sure that you use 4 spaces for indentation?
permute sounds like the order of labels is permuted....
if you don't emit the doc definition anymore, you'll need to change the name of the view and its description.
There's a chunk of search code in common between __wt_txn_get_snapshot and __wt_txn_begin, it could be an inline function if it might be used in other places in the future.
I'd rather throw an exception here, because this can happen on invalid input. Asserts won't throw exception in production environments.
Are you sure ``$host`` has the correct type as ``string`` is not a sub-type of ``string``?
So I have this ability shimmed in to optionally call a specified bundle based on the plugin return code. It works fine, but when I tested passing in a parameter to the bundle like this.
"check[check_dummy_CRIT][_usebundle_if_critical]" string => "bundleifcritical(\"context.params\")";

It didn't work. I don't think I was escaping the parameter correctly, just wanted to show it in the examples.
А если такой категории не существует или ввели новую "Супер-пупер блюда от Марины Петровны".
Система должна это предусматривать и создавать новую категорию.
I don't believe that either of those need to be tested.  What the template needs is something with the name `popular_videos` which is iterable and contains popular videos in the correct order for the frontpage.  Testing the length could be one way to do that, or going back to the older code which tests against the Video queryset.
This is much better, but this checks for if self.rwdb twice.

Maybe bust this logic out into a utility function?

def get_current_channel(self, nick):
    if not self.rwdb:
        return None
    luid = self.config.get_id_for_nick(nick)
    if not luid:
        luid = self.rwdb.get_id_for_nick(nick)
    cur_cid = self.rwdb.get_current_channel(luid)
    return self.channel_codes.get(cur_cid)
Also, add index on `station_id` and `timestamp`.
This file is probably unnecessary in this pull request?
*Izbriši sporočilo*?
I've removed the debug line.

On 6/11/2012 9:55 AM, Sergiu Dumitriu wrote:
>>  
>> +        /** DEBUG URI System.out.println("attachmentUri: "+attachmentUri); */
> This line should be removed.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xwiki/xwiki-enterprise/pull/25/files#r960955
You check for IN_CALL in the above if, but not the else block.  Seems like it should be consistent in both places or neither?
Ah yah, should be openssl.
That seems fine
What is this line saying?
you should depend on ``1.0.*``, not on ``dev-master`` which is an unbound constraint (``dev-master`` will change forever, even if a BC rbeak is introduced)
``require-dev`` is only considered when the repo is the root repo, as [documented](http://getcomposer.org/doc/04-schema.md#require-dev)
this means it will never be read for your projects (btw, you should have seen it in your own demo project, by forcing you to depend on ``jdorn/sql-formatter`` in your project)
Nope, I mean calling `$this->userIdentity()` in the view :)
> To add the dependencies via some Maven-definitions-using tool

Add  the following Maven dependency:
I don't seem to have the ppl package. I think that pxfonts is similar but my version looks a bit diffrent
Why remove the map type params here?
Currently, no one of these scenarios is internally cached.
Here is my point of view:
- the first kind of scenario (MyModel.collection()...) should not be cached, per design: we are making the request the whole way, so it may start from scratch and it the db
- the second kind could accept an internal cache: once you have instantiated the CollectionManager and evaluated it, you expect that the further call will not hit again the database ; the problem, here, is that we are using the redis pagination, so, for example, once you've done ```my_collection = MyModel.collection(some_filter=some_value)[:10]```, only the first ten elements have been returned by redis, and so you will not able to do ```my_collection[10:20]``` later on. Thus, I think that the caching could be done manually, doing something ```like my_collection = list(MyModel.collection...)``` and then to slice it like a normal list.
I don't see a reason either, think I just didn't change it. Fixing now.
Hm, I see, so we need to add these options because they are not in RewriteOptions? Only in ApacheConfig? Can you add a TODO to share these?
`"~> 3.1"` should work
Are we okay with adding args like this? I don't much mind, but it breaks backwards compatibility.
here we could add additional asserts,
for example t_test and f_test, which would also check that df_model agrees.

I didn't see any other tests that check that the nan_dot in t_test, f_test and cov_params works.
E.g., my general log_star function that I think I sent you

```python
def log_star(z, eps):
    log_idx = z > eps
    loggedarr = np.zeros_like(z)
    z_ok = z[log_idx]
    z_star = z[~log_idx]
    loggedarr[log_idx] = np.log(z_ok)
    loggedarr[~log_idx] = np.log(eps) - 1.5 + 2*z_star/eps - \
            z_star**2/(2*eps**2)
    return loggedarr
```
Ok. I will make the examples I uploaded a bit more formal. I think that 
should do the trick.
On 07/25/2012 06:02 PM, Skipper Seabold wrote:
>> +
>> +        Difference between log-likelihood of corr0 and a pre-specified
>> +        value.
>> +
>> +        Not intended for end user.
>> +
>> +        """
>> +        return self.hy_test_corr(corr0, nuis0=None, mu1_min=self.mu1_lb,
>> +                       mu1_max=self.mu1_ub, mu2_min=self.mu2_lb,
>> +                       mu2_max=self.mu2_ub,
>> +                       var1_min=self.var1_lb, var1_max=self.var1_ub,
>> +                       var2_min=self.var2_lb, var2_max=self.var2_ub,
>> +                       print_weights=0)[1] - self.r0
>> +
>> +
>> +class DescStat(OptFuncts):
> Just like our other examples. Something to kind of explain what's going on and show how (and why) you'd use it. Doesn't have to be anything crazy. Something like the cancer example in Owen (1991) would work.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1239668
It's just the way it falls out. I didn't fight it much, but yes it's used for multi-equation.
There seem to be other elisp files in that github repo. Are they important?
Comment probably not necessary/useful.
我擦。。。。还有这一说。。。
This template text should be cleaned up.
Yes. The system properties aren't used anymore.

We can create a separate pull request for it if you don't mind.

On Tue, Oct 9, 2012 at 12:08 PM, ahgittin <notifications@github.com> wrote:

> In
> core/src/main/java/brooklyn/util/internal/BasicDelegatingSystemProperty.java:
>
> > @@ -0,0 +1,18 @@
> > +package brooklyn.util.internal;
> > +
> > +public class BasicDelegatingSystemProperty {
>
> Wouldn't this be better as an AbstractSystemProperty
> with abstract T getValue() ?
>
> Having subclasses inherit from something which delegates to string-based
> is weird.
>
> Alternatively we could get rid of this hierarchy altogether and use
> ConfigKeys that are used against BrooklynSystemProperties ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/brooklyncentral/brooklyn/pull/343/files#r1793080>.
>
>
1. Fair enough - I tried it both ways and don't feel particularly strongly that one was cleaner than the other.
2. This could just as easily translate to `_ref = x.y; _ref()`, but of course I understand why it doesn't. Given the additional semantic meaning of "do for side-effects" that you gave the `do` keyword above, I'm fine with this. Without that extra meaning it just seemed unnecessarily ambiguous.
That doesn't make a whole lot of sense.. a fixed length string, but not defined text?
Generally, imports like this are best done module level. E.g.

```
import urllib
import datetime
...
urllib.urlquote(...)
datetime.date.today()
```

https://mozweb.readthedocs.org/en/latest/coding.html#python
What I mean is what if the user provides options['yes'] but does not provide an options['no']?

You will pass the if statement because you have a 'yes', but when you eventually run options['no'], it will fail, right?
really useful module, but this should be moved and submitted to npm
do you need the 'g' flag here?
my rather incompletely expressed proposal was to maintain two lists within db_connection_context: 'operational_exceptions' and 'conditional_exceptions'.  'ProgrammingError' would not be in the 'operational_exceptions' list.  The handler for 'operational_exceptions' remains the same.  The handler for 'conditional_exceptions' just calls back to the special handler, 'act_on_exception', within the 'db_connection_context' as the body of the handler.  

'act_on_exception' naming alternatives:  'handle_conditional_exception', 'special_exception_processing', ...  naming things is hard.
@jjbohn: was it https://bugs.php.net/bug.php?id=55739?
`$user->uuid` should just be `$uuid`.
https://github.com/caelaislinn/Baystation12/commit/6c98b2048c815b35bd130394bdd4f1e4d752bdf8#diff-9
`dotwrp` is used to solve problems that specifically affect 64 bit builds on Snow Leopard that involve the Accelerate framework when vector dot products are calculated. I believe the issues were solved in the Lion release.
This file used to be called defer-sequence-create.js. I changes the name to reflect that it tests both the creation and resolution time of the sequence
Yup, good question. The issue is that all the variable are declared and assigned on one line. As a result, you can't drop a breakpoint midway through the variable declarations to see what the code's state is. Your case just defines static values, so it's not likely a problem in this particular instance, but there are lots of cases where you might be assigning a variable based on something more dynamic, and you'd want to be able to see the state at each step in the process. For example:


As a result, we typically avoid this idiom in general.
Why the use of `installed_prefix`?
The test passes the login successfully, but fails at this step:


settings_page = home_page.header.click_settings()
GEO_CODING_HOME should be the only mechanism left for development and production. Test should use the config files in test. (src/test/resources). For running a server locally we can use -DGEO_CODING_HOME=something. So don't remove GEO_CODING_HOME
Oops, that was bad copy/paste, hold on
try/finally?
This should look in **both** h_students and h_students_peoplesoft
shouldn't label not be provided instead? Or the comment should be updated to says that only the first 2 labels are considered.
again, at terms like these it'd be good to either their sklearn documentation or a wikipedia link for example :v:
There are really 2 conventions for how to name the "main" class of a module

`Module extends Module_Core` or `Module extends Module_Module`

It would be nice to allow `Module_Core` to be catered for, rather than hard-coding this one exception..
Read-only properties will be implemented in future patches.
The problem with that (which I had) is that in this case we didn't reuse the rows we alread created which is wrong I think. We need to find way to reuse them.
The only problem I have with us validating the IP is that this won't allow hostnames, but the bbndk does. Then again if we're calling the parameter _ip_address_  then we're being fairly specific. This would be something to discuss with Appcelerator in case they would like us to support hostnames. Shouldn't hold back this patch though.
Ok, now I had another look. Reflection is needed! I am not doing to avoid including Tika classes. but to instantiate the user specified type for these internfaces (_TikaParseContextProvider_, _TikaMetadataProcessor_). These are interfaces the user can specify on the _@TikaBridge_ annotation.
Yes, you can't make it completely common.

But you should use getLogs not getDebugValue ..
It did cross my mind that a little odd, I would usually (often) put main in the class that contains the CThreaded object.
It made the code minimalistic to have IThreaded (and the virtual main()) in the owning class though...
I tend to agree really though, it would be better to pass in owner separately, contain main() and call out to a properly named method..

Let me change it before pulling.
Aren't the above append* type function of general use in building up a uri path and so shouldn't they be in juri.hpp ?
The creator of the IDirectoryIterator can decide whether it is recursive or not, I think.
Hmmm...if I'm re-reviewing this code right, the possibility exists that this could break for big numbers, since it's trying to do math on a string.  This should be:

    return accurate_return( Math::BigFloat->new( $self->from_base($str) )->bneg() )
      if $nc && $str =~ s/^\Q$nc\E//; # Handle negative numbers

Where `accurate_return()` is that code piece on the bottom of from_base.  I'll add a commit with that and a test for large negatives.  Also, it looks like to_base negatives needs a quick big number check to make sure it can do `-1*$num`.
`django_browserid` is part of playdoh-lib and thanks to funfactory it gets automatically added to `INSTALLED_APPS`. 

Have you perhaps forgotten to `git submodule update --init --recursive` ?
`import this` :)
I used the names that you suggested in commit 000f327.
Ок ингэж засъя.
@weierophinney logic was clear to me :) I am just for -1 line :)
Have you confirmed with Service Bus guys on that? I've asked them to add this setting and they refused because it's not consistent with their connection string format and what is found in .NET SDK
You should add an entry to the clobbers list below to be consistent with how other modules are exported.
Always use a snapshot version when developing.
maybe you could have an array of commands to grep and then foreach over that array in your health check?
@cboylan It is possible, but I was hoping to get this base module merged and then everyone can submit pull requests against it to make it even better.
Imho the logic is correct but your version reads definitely better.
LNICS, p. 676
To match style elsewhere in the code, the trailing parens should actually be on the following line, aligned with the start of the declaration.
Same here, data('group')
Do not add NLS here; we need to be sure to internationalise this beast
Unsure about the necessity of this one. Up to you whether to do this or just `os_write(postData.toByteArray());`
Looks like an indentation issue here.
This info needs to go into LICENSE.md too.
Same doc comments as `computeVertices`.
Is `addSubRegions` still the best name for this function?
This comment refers to all of the new tests, but I'll use the above for reference:

When comparing two values, we prefer the use of `toEqual` instead of `toBe(true)`.  This way if an error occurs, the message is much more informative.  Some of our old code hasn't been converted yet, but we change it as we find it.  So your first line would change to. 

`expect(Color.fromCSSColor('#FFF)).toEqual(Color.WHITE)`

You'll also noticed that I swapped the order.  That's because the first parameter should always be the computed result and `toEqual` should always contain the expected result.  I see you also use a mix of lower and upper case values, I'm guessing in order to test them.  You should actually not mix tests like this (unit tests should test exactly one aspect of the code).  So I would create two versions of the test, one that tests with capital letters and one with lower-case.  You test RED and BLUE, but not GREEN; you should test all three.

Finally, technically your WHITE and last tests are not needed, but because testing Red/Green/Blue individual should be everything you need.  As a general rule, we try and keep unit tests down to the minimum set of tests needed to hit every possible case.
Any reason we don't have an answer to this question?  If we know the answer, we should update the TODO with more information rather than a question.
line breaks + elsewhere in the file
add
default: true
Can we simplify this?

if (event.getAction() == MotionEvent.ACTION_MOVE && !mEnabled) {
    return false;
}
return super.onTouchEvent(event);
Of course, *why* I decided to generate them at module time is an entirely different question.  The original thinking was that I wanted a hash where i could store class instances without the impact (big strings) of AssetCryptImpl.  So this class was an intermediary.  But I now realize thanks to your comment that I could have made this intermediary in the app itself. :(  Maybe I should change the approach, and then just ignore this class if it exists in older modules.  Thoughts?
So, the definition we currently have of hybrid (in our docs) is satellite imagery with roads and names overlaid on it. That is NOT what we're doing on Android--we're showing a normal road map, with street view indicators turned on.

Here's a summary of the current observed behavior:

<table>
<tr><th>constant</th><th>iOS/MW</th><th>Android</th></tr>
<tr><td>STANDARD_TYPE</td><td>Road map with names</td><td>Road map with names</td></tr>
<tr><td>HYBRID_TYPE</td><td>Satellite image with roads and names</td><td>Road map with names</td></tr>
<tr><td>SATELLITE_TYPE</td><td>Satellite image with NO roads and names</td><td>Satellite image with roads and names</td></tr>
</table>
We don't seem to actually be doing this.  Where do you see this happening?
You don't need this override since openOptionsMenu() is already a public method.
Property still not renamed to horizontalWrap is docs
This does not appear to be used anywhere in the code base.  Should remove it.
Found it, just do another pull request and it gets updated :)
Should have while/whilst in the name
О, спасибо!
if it's the last one why is it [-2] ?
It's not a big enough deal that I'd insist on it, but I don't see any problem with putting the specialization first, especially when we're talking about string types, because there are very few types involved as opposed to something like find which is truly generic and just happens to work with strings.
> We've used $(D true) elsewhere btw.

So are you saying I should change ˋ$(D true)ˋ to ˋ$(D _PARAM true)ˋ? Or the other way around?

I assumed using ˋ$(D_PARAMˋ was better than ˋ$(Dˋ, but we usually just use ˋ$(Dˋ because of lazyness/forgetness.