[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
https://bugs.webkit.org/show_bug.cgi?id=92366

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.

Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.

* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Qt/Mac build fix: Use libWebKitSystemInterfaceMountainLion.a
on Mountain Lion.

* WebKit1.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477

Reviewed by Chris Fleizach.

Source/WebCore:

Consider title and accessibilityDescription together with helpText to
decide whether an object should be exposed in the accessibility tree.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

Remove passing test from TestExpectations.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

* chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
* src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Removed.
* src/ColorChooserProxy.h: Removed.
* src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
* src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
* src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: workers inspector is broken in the remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=92540

Reviewed by Yury Semikhatsky.

The problem was that worker manager re-used complete url with query parameters
for spin-off worker front-ends. As a result, in case of remote debugging, newly
created front-ends were connecting to the same web socket (because of the ws parameter).

* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.isDedicatedWorkerFrontend):
* inspector/front-end/inspector.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359

Reviewed by Pavel Feldman.

Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();

Source/WebCore:

* inspector/InspectorMemoryAgent.cpp:
(WebCore):

Source/WTF:

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::sizeInBytes):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: element tag disappears after editing
https://bugs.webkit.org/show_bug.cgi?id=92385

Reviewed by Vsevolod Vlasov.

This has regressed when we started hiding elements panel upon
batch updates. Narrowing hiding cases, updating selection
in on-screen mode only.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.updateSelection):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r124004.
http://trac.webkit.org/changeset/124004
https://bugs.webkit.org/show_bug.cgi?id=92622

Broke Android build (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/Platform:

* chromium/public/WebLocalizedString.h:

Source/WebCore:

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

Source/WebKit/chromium:

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):
* src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(ColorChooserProxy):
* src/ColorChooserUIController.cpp: Removed.
* src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):
* src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebCore):
(WebKit):
(WebColorChooserClientImpl):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unnecessary code which set event's target from EventDispatcher::dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=92613

Reviewed by Hajime Morita.

EventContext::handleLocalEvents does all required jobs so we don't
need to set target in EventDispacher::dispatchEvent() for TARGET phase.

No new tests, no behavior change.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Replace UnicodeWinCE with UnicodeWchar https://bugs.webkit.org/show_bug.cgi?id=92539

Reviewed by Ryosuke Niwa.

UnicodeWinCE never contained WinCE specific code. UnicodeWchar
is a replacement for it, which is mainly based on the functions
from <wchar.h>. It is ment as a minimal Unicode backend, which
can be used very easy and has no external dependencies.

.:

* Source/cmake/OptionsWinCE.cmake:

Source/WebCore:

* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

* WTF.gyp/WTF.gyp:
* WTF.gypi:
* wtf/Platform.h:
* wtf/PlatformWinCE.cmake:
* wtf/unicode/Unicode.h:
* wtf/unicode/wchar/UnicodeWchar.cpp: Added.
(Unicode):
(WTF::Unicode::category):
(WTF::Unicode::combiningClass):
(WTF::Unicode::direction):
(WTF::Unicode::decompositionType):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::convertWithFunction):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
* wtf/unicode/wchar/UnicodeWchar.h: Added.
(Unicode):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::isDigit):
(WTF::Unicode::isLetter):
(WTF::Unicode::isLower):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isPunct):
(WTF::Unicode::isSpace):
(WTF::Unicode::isUpper):
(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::umemcasecmp):
* wtf/unicode/wince/UnicodeWinCE.cpp: Removed.
* wtf/unicode/wince/UnicodeWinCE.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Hajime Morita.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fix issues remaining with fixed positioned layers
https://bugs.webkit.org/show_bug.cgi?id=92528

Reviewed by Noam Rosenthal.

Source/WebCore:

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
Make sure that the delta is used when syncCompositingStateSelf is called afterward.
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
* platform/graphics/texmap/TextureMapperLayer.h:
Use a FloatSize instead of an IntPoint for the delta.
(TextureMapperLayer):
(WebCore::TextureMapperLayer::adjustedPosition):

Source/WebKit2:

This partially fixes jittering of fixed layers when zoomed in and the
blurriness of rendered tiles of the non-composited contents layer.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
Remove the adjustment on the root layer. This cancels setPixelAligned and causes the blurriness.
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
Use m_accurateVisibleContentsPosition to calculate the delta.
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Remove accurateVisibleContentsPosition and use a FloatRect for visibleContentsRect instead
https://bugs.webkit.org/show_bug.cgi?id=92536

Reviewed by Noam Rosenthal.

AccurateVisibleContentsPosition carries the same information as visibleContentsRect.location() and
is needed for fixed layer position updates.
This patch instead uses a FloatRect for the visible contents rect from the web view down to the
LayerCoordinatorProxy, and converts it to an IntRect at this moment, before sending it to the
web process.
This also moves the check to prevent sending the same rect to the moment of the conversion
in LayerTreeCoordinatorProxy to fix a bug where the fixed layer deltas wouldn't be updated
unless the integer part of position components changed.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
* UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::visibleContentsRect):
(WebKit::QtViewportHandler::informVisibleContentChange):
* UIProcess/qt/QtViewportHandler.h:
(QtViewportHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove an unused member variable, m_originalTarget, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92614

Reviewed by Andreas Kling.

No one uses EventDispatcher::m_originalTarget.

No new tests, no behavior change.

* dom/EventDispatcher.h:
(EventDispatcher):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r124000.
http://trac.webkit.org/changeset/124000
https://bugs.webkit.org/show_bug.cgi?id=92632

seems to have broken chromium Range_InstanceSizeUnknown unit
test across many platforms (Requested by tomhudson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::clearPreloads):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: [Styles] No color swatch for the SVG "fill" and "stroke" property values
https://bugs.webkit.org/show_bug.cgi?id=92638

Reviewed by Vsevolod Vlasov.

Added the "fill" and "stroke" properties to the list of color-aware properties.

* inspector/front-end/CSSKeywordCompletions.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: make MemoryInstrumentation methods private
https://bugs.webkit.org/show_bug.cgi?id=92379

Reviewed by Vsevolod Vlasov.

MemoryInstrumentation was refactored.
- All reporting methods on MemoryInstrumentation except add*Object are
  private to enforce MemoryClassInfo usage.
- MemoryInstrumentation::Add*Member methods renamed to Add*Object
- String reporting is implemented directly in the MemoryInstrumentation,
  not in its descendants.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* dom/MemoryInstrumentation.cpp: Added.
(WebCore):
(WebCore::MemoryInstrumentation::addString):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addObject):
(MemoryInstrumentation):
(InstrumentedPointerBase):
(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::calculateContainerSize):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
https://bugs.webkit.org/show_bug.cgi?id=92636

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk1/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92625

Reviewed by Hajime Morita.

EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.

No new tests, no behavior change.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
(EventDispatcher):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92627

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-30
Reviewed by Noam Rosenthal.

Remove the default behavior I added in r123729 so that we run all tests as pixel
test with -p. It was intentional but it seems like we don't have consensus on
that we want it.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._supports_switching_pixel_tests_per_test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124020 268f45cc-cd09-0410-ab3c-d52691b4dbfc