More puppet-lint formatting fixes

Yet another bunch of puppet-lint fixes.

Change-Id: I9574cf1c5e35620b12e4d5e2bd6b2eb4d320c935
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/13988
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Jenkins Jobify API Documentation.

Add these jobs to jenkins_job_builder's api-jobs.yaml and projects.yaml,
as well as to the openstack/*-api projects in zuul's layout.yaml:

  - network-api-v10 (replaces openstack-netconn-api-doc)
  - openstack-object-api-doc
  - openstack-compute-api-doc
  - identity-api-v20 (replaces openstack-identity-api-doc)
  - image-api-v11 (openstack-image-api-doc)

Please note that the 3 replaced jobs listed above will need to be
manually removed from jenkins.openstack.org once this change is merged.

Change-Id: I07611b518b647b35cf8fb46e937f79e3f25ca745
Reviewed-on: https://review.openstack.org/13997
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Convert 3 of the OS guide jobs to yaml configs.

Convert openstack-ha-guide, openstack-install-deploy-guide-apt-fedora,
and openstack-install-deploy-guide-ubuntu jobs to Jenkins Job Builder
yaml configs. Each has been converted to run in the zuul post queue as
well.

Change-Id: Icce086f0a4531b8f91330ab5a4aa15128f429d64
Reviewed-on: https://review.openstack.org/14000
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Pass jenkins.o.o cert contents in from hiera.

Use hiera to store the jenkins.o.o cert contents and populate the cert
files from the values in hiera.

Change-Id: Iffd724b7fabf9403506f08f76fa927c3b461ba19
Reviewed-on: https://review.openstack.org/13933
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Fix dependency cycle in cert file ordering.

The new cert file resources in jenkins::master introduced a dependency
cycle. Break that cycle by putting the files in place before the apache
vhost is created.

Change-Id: I0f029dd2d4fa1f5c6e168bbb479b359acb21489e
Reviewed-on: https://review.openstack.org/14115
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Pass review.o.o SSL certs in from Hiera.

Use Hiera to store the review.o.o SSL certs and pass them down to the
gerrit module.

While modifying these files fix indentation and rocket ship alignment
according to puppet lint in the sections touched.

Change-Id: I914b0dea72c77dedb44a4e6f51417985e673b315
Reviewed-on: https://review.openstack.org/13975
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Remove unused module

According to mordred in #openstack-infra the orchestra puppet module has not been
used in about a year. So, we are removing it.

Change-Id: I6ba1bc96ea321e151944e156a822f2e1843a9ebe
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14105
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Set ssl keys group to ssl-cert.

Recent ssl cert management changed the group on the ssl keys to root
from ssl-cert. Change it back.

Change-Id: I6dcbeca364fa9c435aee520248a59f0917cd02a8
Reviewed-on: https://review.openstack.org/14116
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Kill trailing whitespace.

Killed trailing whitespace in the puppet repo files using
`sed -r 's/\s+$//'`. Skip binary files and html templates for lodgeit
and mailman.

Change-Id: Ib43493161d8f0e8fae1426b22fb1737832ca14cd
Reviewed-on: https://review.openstack.org/12969
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Add nightly tempest job for HEAD.

Change-Id: I6a05b6efd8c99d6bfc8b0590da7f4d0e914b0e62
Reviewed-on: https://review.openstack.org/14101
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
Puppet-lint / Refactor meetbot module

This started as a puppet-lint clean up and ended up more a refactoring
of some of the logic.

Change-Id: I5315571fbef8ff4ebe2ae77d2d2b19a6fcd5798d
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/14113
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
style changes to tmpreaper module init.pp

Change-Id: I957e2d4a70048f2eae6e7bffd75ee0796a32d508
Reviewed-on: https://review.openstack.org/14169
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Use puppetlabs apt repo and pin puppet version.

In openstack_project::base use the Apt module to configure the upstream
puppet labs apt repository and pin puppet to version 2.7.*.

Change-Id: I0a09e02e3d26eb9452215e5bccef143487e9e58d
Reviewed-on: https://review.openstack.org/14194
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Bump dashboard module to 0.0.5.

Change-Id: I8a828f4e412950610c3ff9772255b620a1c39a16
Reviewed-on: https://review.openstack.org/14222
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Use dashboard module v0.0.6

Change-Id: I3e928f24b356b69109d33da3cbd751d351aee55a
Reviewed-on: https://review.openstack.org/14232
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Improve module regex.

The pattern was too generous and matching multiple module lines.

Change-Id: I8ba95aeb913783139f544f85586dbae73a6bfb8f
Reviewed-on: https://review.openstack.org/14234
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Fix jenkins ssh key dependency in slave template.

The jenkins slave template manifest depends on having the jenkins ssh
key variable in scope. To make this happen have
openstack_project::slave_template inherit openstack_project which
includes the ssh key variable.

Change-Id: I231f030e42e7bb2cf780f04f2a3ca1e668cf61f9
Reviewed-on: https://review.openstack.org/14186
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Fix restart logic in zuul init script

Change-Id: I4ddd69916db4d9df036d3d674fb58847981d2758
Reviewed-on: https://review.openstack.org/13810
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Antoine Musso <hashar@free.fr>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Fix rubygems dependencies in jenkins::slave

The rubygems package is only installed on non bare slaves but the slave
manifest attempts to install the puppet-lint gem on all slaves which
requires the rubygems package. Only attempt to install gems when the
slave is a not a bare slave.

Change-Id: Ifc09d15340eed97b35a865a1475a52172f7c9b25
Reviewed-on: https://review.openstack.org/14260
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Cleanup gerrit init.pp manifest lint errors.

Change-Id: I68c6cd9b24c93f9f1cc2ba92eceae49b3c38ed36
Reviewed-on: https://review.openstack.org/14176
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins