labofsahil/github-event-dataset-2012 huggingface dataset:
this could be done in a better way, by using the JsonFormatter instead of the NormalizerFormatter as you expect json
Namespaces inside the file.
Like I wrote above - this is the reason for using `Distinct()` - each descriptor is appearing multiple times in the dictionary.
Why not just "unless ($string) {" ? it's simpler and does the same...
Can you assign some reasonable default for TEST_AGENT_SERVER based on B2G_HOME?
这个不懂，能不解析一层不是更好么？ 为啥要用raw？
Right, fixed it.
Well IMO it doesn't make sense to see an "ThreadIRCSeed exited" message in the log, when there was no "ThreadIRCSeed started" message, because of the pre-checks. I think that message should tell us "hey the thread IS running!", nothing more.
Have 2 empty lines a special meaning in the code?
I need to hunt that one down yet since I think it's used outside of rpc*.cpp. I'll post a new commit working on that soon.
If you're going to rename pszModule, you need to do it here too...
Why not have the _setupFilesystem() method return a list of variables that you can unpack with list().  That solves the duplication and variable scoping issues.
That's quite the selection in behaviour. This is all to handle the case where the referring URL & loginRedirect are inaccessible to the user who is logged in?
Nitpick, extra blank line :smile:
@eleu Can you review this file?
Never ever abbreviate variables, methods, etc. Use `$reflection`.
As discussed before with stof, it's just `callable`
comment was swallowed by github: we do need this i think as this is a mixed collection and we can't know the type of the child here.
Thanks, I was looking for that ;)
+1, but the above will also do that :P
Lots of macros here. Can you move the macros inside the function body to avoid duplicating the function header?
And that should be an `unsigned int *` I guess rather than an `int *`...
Keep this view, remove the rest.
I'm trying to figure out if there is supposed to be a gettext call here and that's why it was imported and not used.
One thing this just reminded me of is that we're about to break everyone's bookmarked queries that used "tags"

We should either:

1. provide a backwards-compatible something or other (a redirect?)
2. mention it on the forums in big bold letters when we land this
This would be even slicker if you added caching. Basically, make a ``var cache = {};`` object, and then store url: response key-value pairs whenever you make an ajax-request. Then before making a new request, look for cache.url for whatever url you're about to request, and if you've already requested it just use the response data you've already received.

The downside of this, of course, is that if another user made changes to the cases (or suites) you're fetching, you won't receive the updated data until you do a page-reload. I don't know whether that's a problem or not; your call on whether the trade-offs would make caching worth it.
For people who don't dare to mess with their `PYTHONPATH` just for socorro, I would instead recommend:

```
PYTHONPATH="." nosetests socorro/unittests
```

If you do it as a prefix it doesn't stick. I'm not entirely sure what else can go wrong with other projects but this feels safer.
We have more room in the UI with the vertical table so I think you can bump this up to 1000.
You are correct, there may be more cases. Please note that I somewhat already acknowledged that by saying that "I see" those two cases. This wasn't an absolute statement and indeed I could be missing other cases here.    
However, this extension method has been added for convenience reasons for a common use case. It was a conscious decision to not add this method to the `ResourceLinkVerifier` class for the very reasons you bring forward.  
This extension method doesn't make the existing API less open, you are free to use the existing methods `TryParse` (which doesn't throw an exception at all), `Parse` (which throws a "normal" exception) and `Verify` (which also doesn't throw an exception). The extension methods also doesn't make the existing API less discoverable, as you will see the existing methods alongside the extension method.    
The extension method is intended to be used on the first case I mentioned. It is well documented to throw a status code 400 exception, so everyone using it knows the outcome if the URI can't be parsed and verified.
In MathGeoLib float3 d = cpos - epos;
When these addDocuments are commented out and the index with these docs already exists the test works fine. Only problem is querying directly after adding the docs.
Please add the expected outcome, then merge ;)
`assertNull`
Class is not the same as filename, this will give problems with the autoloader.
The variable should probably be named `$profileIndexed`.
checking ``isset($this->instances[$driver][$instanceId])`` is enough
Looks like an unrelated change??
fromNow variable was placed inside next if statement. Unfortunately I could not run `make test`: jshintc complained ("One var is to much"). So "fromNow" is now placed here.
did you fix this?
fixed ... I'll clean this up in other places too in a commit for the synthesize stuff this weekend.
I'd just taken it from [this post](http://stackoverflow.com/questions/145154/what-does-your-objective-c-singleton-look-like).
in order to chain the methods we need the method to return the instance of the object itself. To do this my_group_messenger.remind.deliver the remind method needs to return the instance of the object you sent the message to.
如果用户 阻止了某元素的 mousemove事件冒泡，此时该如何能够支持drag?
Call it DefaultEntityManager
Please use four spaces rather than tabs for consistent indentation.
s/processed/published/
could you rename this variable to `webserver_user`?
this is one of the rare times taht we need the propagation to get the dropdonw menu to dissapear
I think that paths in ZooKeeper are much like regular file system paths and Python programmers are used to the `os.path` interface. 

Using `os.path` directly would be unsafe because of platform differences. `os.path.abspath(path) == path.startswith("/")` is true in Unix but not on Windows. Further, the path separator on Windows is not `"/"` but `"\"`.

Some packages that deal with Unix-like paths just use `posixpath` that comes with Python, but ZooKeeper does not allow relative paths. That's why `zkpath.normpath()` forbid `"."` and `".."`.
`function gotMessage(message) {`
nit: makesure → make sure

And +1 for the proposed fix… at least until we come up with a better solution on the Gecko side.
mmm I don't know if I can find a better name without losing the semantics ...
Add a `XXX` here to remind everyone you are expose a CSS color name to the UI.
You need to create it after calling `createNewHeader `. Every time you have a `header` you need a new `<ul>`, and before creating a `header` you should check if previous element has `li` tagname, and if it has, adding `</ul>`.
why don't we wait for the Callback to succeed? if it is not needed a comment is necessary to explain why
umm good point, I did'nt think this use case before :) @rafaelrebolleda , can you help us? thanks
tricky good or tricky bad :) ?
It looks like you need to change the name here because you will store the message id in the list, right?
I read you code And I get your point.
I will update my code right now.
Good call on scoping what can be removed in the description.
文档中的 PutFile() 全部换成 rscli.UploadFile
If not argument is given it still defaults to 10.  Should the description just be updated to have "(default: 10)" in it or do you want to remove the default?
I just need it here and it is a one-liner ... I see no need to split it.
so, what i do with that ?
Why are we filtering this part twice? I definitely want to see Zendesk problem tickets that don't have github tickets. I don't want to see github tickets that aren't associated to a problem, though.
Why is the ampersand encoded as a HTML entity? I noticed that the individual browse pages are broken (in development, when slimmer processes it) because they don't do this.
oh, it's existed in python 2.4, here is the doc of py2.4.3 which is used in rhel5:
http://docs.python.org/release/2.4.3/ref/Booleans.html

And we have similar code in autotest:
reboot() in kvm_vm module:
```
2433         if method == "shell":
2434             session = session or self.login()
2435             session.sendline(self.params.get("reboot_command"))
```
I'll put this in a `.. note:` for now.  In Buildbot-1.0, the APIs will move to the "customization" section of the manual, and all that will remain here is the implementation information.  For the moment, though, all of this is for developers, with different sections of more or less interest to different developers.
The patch_level is also mentioned twice instead of patch_body. Patch comment and author are also accepted so will add these to the doc.
What is the rational for having this as a separate table, rather than just a column in the schedulers table? That should be documented here. Also, is there any reason that schedulerid isn't the primary key, since there will be at most one row per scheduler?
Doing a scan through `buildbot/util`, I see two side-effects that we want to avoid:

```python
log.msg("unable to import dnotify, so Maildir will use polling instead")
```

and 

```python
warnings.warn("Use simplejson, not the old json module.")
```
To expand on that, the fact that this kind of ad-hoc factoring is useful, suggests to me that the abstractions we have here aren't quite right (but I don't have any useful suggestions on what abstractions we should have). :/
Nope, `false === strpos($output, 'authorization failed:')` - it's just the convention to put your expected stuff on the left side.
ok.. but i'm a native german speaker.. :-)
Awesomes.  I'll get right on that.
so page != window.location.pathname. Should it? and should we include query/host/domain (full window.location.href)
nit: `target` is used by the first part of this module. It would be easier to read if we define `target` before it start being used.
You may just move this pice https://github.com/Gozala/addon-sdk/blob/2ae4e3ca551d14a2dce11bf902b181991a23f54d/packages/addon-kit/lib/simple-prefs.js#L25-43 right after the current line.
hehe darn.. got it!
got it 971f4cd.
right, it's an *internal* api for browserid to trigger a database write on dbwriter.  We do this in several cases:

1) when we need to both write the database AND contact the keysigner (like `cert_key`)
2) when we have a large api handler that only infrequently must write the db (like `authenticate_user`)
3) when browserid detects information in it's normal processing (fetching .well-known) that should be persisted (this case)
Ah, here's the comment I was looking for above! It'd be nice to have this somewhere close to where the valid values are actually defined.
Nit: As mentioned please separate in blocks and let a comment start a block. So move the declaration of iStream right before the asyncCopy line and leave a blank line behind after foStream.init.
Yes, it works that way. I initially thought about Proxy class as a proxy that allows the DSL communicating with Puppet, but Actions is a good name too.
One is used when we want to import types from Ruby file and the other one when we apply a ruby manifest.
I'm going to work on a logging structure so we don't have to mess with each other's code
Orphaned code, not used any more.
I'd mark this protected, and name it "getDefaultValidators".
Should this also be done for SMTP and/or File transports? or is it an issue only for the Sendmail transport?
This should be // CraftBukkit
While I'm at it... move this one line up.
you should depend on ``2.1.*`` instead of forcing to use the branch. this way, composer will be also allowed to choose stable tags when they will be available
Gotcha. No, I guess they weren't. I'll minimize the unnecessary code.
"Password" mit einem "s"
Please do document this one. We generate documentation from the library. Maybe the description can say something to the fact that it will return the default property if ...
@alex88 try with `phpunit -c phpunit.xml.dist Doctrine/Tests/ORM/Functional/Ticket/DCC2161Test.php` (without the `require_once`)
Just one small note, we don't need to start each line with `>`.
And there is a small typo, it should be `global:` instead of `globa:`.

Thanks a lot!
yeah, that was beause the buffer-copy patch was not merged when I did this, and the patch context overlaps. I did'nt know how to supply a patch that would merge cleanly otherwise. I'll try to rebase, then this should go away.
Oh, yeah, I think that's a bug that I know about.  I need to talk to our WebGL folks to see what's the right thing to do here...
I omitted it intentionally.  It'll be of use in so few cases that adding it to this example really only clutters it.
`#fff` is shorter (and you use the short syntax above, so it's consistent).
Though I agree that code debt can be paid back incrementally, I don't think the code should be left in a state of confusion. For an external person coming in, it doesn't make sense why the css files would be split. IMO, it would put the code in a worse state than it is now. It seems out of the scope of this bug to start fixing this.

That being said, not a hill I'll die on.
Might be cool to organize the bootstrap stuff into a separate bucket, which I think the assets/jingo stuff makes it crazy easy to do (just for organizational purposes). Maybe even just do that with all the libs?
Overline comments, please (no end of line comments)

:)
Wish it could be a static class instead of passing mozwebqa around all over the place but I can't make it work.
up until what is issued?

You deleted EXEC?

PS thanks for updating docs :)
Would be great if you could wrap that in json so it can be used server-side. Something like:
{"ipport":"123.32.12.32:1234"}
We try to do that for all plugins we update these days.
So basically, the text is not in title case if there is an all-lower-case word that is not a skip word?

A few questions:
Does title-casing allow lower case words that are compound words joined by dash? E.g. would it be "Pre-existing or Pre-Existing"?
Why do we not lowercase the last word?

I think we can pretty much accomplish this check by doing the following (with some tweaks depending on your answer to above):
```
const skipWords = ["but", "or", "yet", "so", "for", "and", "nor",
  "a", "an", "the", "at", "by", "from", "in", "into", "of", "on",
  "to", "with", "up", "down", "as", "while", "aboard", "about",
  "above", "across", "after", "against", "along", "amid", "among",
  "anti", "around", "as", "before", "behind", "below", "beneath",
  "beside", "besides", "between", "beyond", "but", "despite",
  "down", "during", "except", "for", "inside", "like", "near",
  "off", "onto", "over", "past", "per", "plus", "round", "save",
  "since", "than", "through", "toward", "towards", "under",
  "underneath", "unlike", "until", "upon", "versus", "via",
  "within", "without"];

const wordRE = /\s([^\s,\.:?!]+)/g;

function isTitleCase(string) {
  var word;
  while(word = wordRE.exec(string)) {
    word = word[1];
    if(skipWords.indexOf(word.toLowerCase()) != -1) continue;

    if(word.toLowerCase() == word) return false;
  }
  return true;
}
```
You can mess around with the wordRE to redefine what constitutes start of word. I think the words we case about are pretty much always preceded by a space. I.e. we don't look at the first word anyway, and I don't know what the answer to my question above is, but we can totally compensate for it.

We can also add more characters to what is not supposed to be inside a word. Probably all the delimiter characters that you put in your regex. I haven't tested it extensively and I may be overlooking some cases. Let me know what you think.
Can this be `final`? And how did you not have to specify the `<String,JcrRepository>` types after the `new HashMap`? (Are you using JDK 7?)
I'd suggest changing the type of this field to a `List<ConnectionEventListener>` and then using a CopyOnWriteArrayList for the implementation. Then there'd be no need for synchronization, as that impl is a concurrent list that is thread-safe.
Delete commented javascript
We could require that instead of the `u` param, you just use `less` or `coffee` and then you don't need to deal with getting the filename from the URL.

You can also kind of ignore the filename and just send back `compiled.js` or `compiled.css`
then please send a PR on DBAL to make them accessible in 2.3
please use properties notation: `pad.userlist.approve`
I was going to do a thing here where I added a Page to the sitemap when somebody ignored a specific path, then use an `after_configuration` handler to run through the sitemap and validate that all the pages people ignored or proxied actually existed. How would I do that validation with this new scheme?
There was a lot of coupling here between the CPU code and the Apple-II related code. I decided to let you add callbacks for memory reading and writing. This way, the soft switch code and all of the memory mapping stuff can be placed somewhere outside of appletoo.js
Sorry, now is removed on the last commit =)
This would only work for a fact query, right?  So maybe it should be named `restrict-fact-query-to-value`, like your `restrict-resource-query-*` functions below it?
In engine seeds template you're using `if Refinery::Core.user_class`.
I'm not exactly sure what you mean. Are you asking if it checks whether a group with that name already exists?
If so, that logic sits in the canCreateGroup and it'll respond with a 400 saying this groupname is already taken.
Each test should have some documentation above it as well.
I would prefer `rolesAPI` and `principalsAPI` here, just like in our other files.
Oh, I see.
Then, maybe, what about just doing the following:

```scala

def disconnectReleaseRunningVM() {
  ...
  eventListener = toIDebugEventSetListener { e =>  e.getSource() match {
    case CurrentProcess if (e.getKind() == DebugEvent.TERMINATE) => latch.countDown()
    cae _ => ()
  }}
  DebugPlugin.getDefault().addDebugEventListener(eventListener)
  ...
}

def toIDebugEventSetListener(f: DebugEvent => Unit): IDebugEventSetListener = new IDebugEventSetListener() {
  def handleDebugEvents(eventSet: Array[DebugEvent]) {
    eventSet foreach f
  }
}
```
Harsh, man. Harsh.
А можно вопрос? Почему ты сделал DNA readonly ? В коде же он изменяется. И что значит nonatomic ?
You shouldn't subtract 1, because by doing that after calling removeObjectIdenticalTo: on newMarkersArray you exclude the possibility of choosing the last element from newMarkersArray.
Let T be the marker to exclude, so the possible outcome would be either A or G and never C.
I updated the test so that it shouldn't run if `.git/` and `.gitmodules` don't exist (though I can still separate it out if you'd like)
Global data is always initialized to 0/NULL.
[Log at minor](https://github.com/Thynix/fred-staging/commit/c595187cda2b4ff8127a149abb083b6c79fd2d77).
PCA is unique up to an unknown sign. To have a consistent sign across epochs you should use the same trick used with the flip. Basically I would get U from the PCA and align the sign of waited normal of U[:, 0] with the label normal. Maybe this should be called pca_flip...
The reason for doing things outside of SourceEstimate is that it is more efficient, e.g. we only have to compute "label_vertidx" and "label_flip" once, instead of for every stc. So I think we should leave it like this..
if not isinstance(raw, list):
use strict equality here (!== instead of !=).
"ip" vs "IP address"
I totally understand.
This has nothing to do in the doc of the standalone component
I set 'www' to be consistent with the documentation which refer to localhost/Symfony.
But my question about the Cook Books was about this kind of delicacies (Write more details about the command options).

I didn't knew about that in version 2.1, did you think I must wait?
%domain% is not defined anywhere, nor explained that it would be replaced by a container param
Oh, probably because Middleware already extends it :)
Does this need quotes?
Well, actually, we can easily get the type from the path of the file.
Why do you need that? Also, why are you creating multiple top-level actors instead of just one, that is responsible for the clustering, and that one can have children?
Чо за пробел? :3
Serían 100 story points, no 50.
Just curious, are we caching the rendered templates, or are we re-parsing them each time. My point is, if possible, we should render this once, and set the rendered template as the ```self._template``` variable instead of just the name of the template file.

I'd concede that for testing and developmental purposes, this makes sense since edits to *.html files would be computed on a per-request basis, but it is horrible for performance and responsiveness.
Rather than adding a new method I'd like to see AddClass changed to support

    tag.AddClass("foo bar baz")

    tag.AddClasses("foo bar", "baz")
Alex, 

SVP tu peut corrig pour le mettre de la bonne faon! (sorry j'ai fait a rapidement) sauf SVP s'assurer que a reste comme prsentement dployer sur le site , i.e. Installations en vert et plus petit font....(trs important)

Si tu pouvait ce soir crer le lien qui permettra de voir le site en anglais ou franais et de plus changer le context localiser des Twitter et Facebook button

Si tu as une chance appelle-moi plus tard ce soir pour que nous puissions discuter

Merci,
sf

Stphane Frchette
mobile: +1 (819) 319-2935
email: stephanefrechette@me.com
.tel: http://stephanefrechette.tel
GatineauOuverte.org - Initiative citoyenne, donnes ouvertes

On 2012-04-04, at 4:19 PM, Alexandre Potvin Latreille wrote:

>> @@ -185,7 +185,7 @@ App = (function () {
>>             '<div class="info-window-content">',
>>                 '<b>', data.name, '</b><br>',
>>                 data.address, '<br>',
>> -                '<b>', localeData.labels.installations, '</b>',
>> +                '<b1>', localeData.labels.installations, '</b1>',
> 
>  moins de faire erreur ```<b1>``` n'est pas un tag HTML valide? Pouquoi ne pas juste utiliser une classe css ```<b class="green-label">``` ou un truc du genre...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GatineauOuverte/parcs/pull/18/files#r647231
Yup, absolutely. Missed those in refactoring. Thanks.
I see what you mean, but we should really never add a <script> or <link> tag if the file it's pointing to definitely doesn't exist. 404 requests are never a good thing for page loading, from what I've learned.
you must add a blank line after this
please move the comment above the structure control, please use braces
I agree completely. Maybe the original author would be kind enough to make it more readable.
You can refactor this this way :
```
specName = {a: 'assassination', Z: 'combat', b: 'subtelty'}[data.activeSpec]
data.options.rotation['opener_name'] = data.options.rotation["opener_name_#{specName}"]
data.options.rotation['opener_use'] = data.options.rotation["opener_use_#{specName}"]
```
```python
names = sorted([name for name in resource])
```
Tätä piti vähän puukottaa että kääntyi.
Copied from https://github.com/infinispan/infinispan/pull/1389, as that PR is closed now:

@mmarkus I think we missed something here: the prepare command may be forwarded to other nodes, but the rollback command won't be forwarded (because the StateTransferInterceptor is the one doing the forwarding). We may be able to fix this without injecting the TransactionTable in the StateTransferInterceptor, by checking the txComplete flag on the transaction itself.
It took some time, but I did realize that this class isn't a test after all...
It's just a test Sanne :)
It produces a full-blown error, but the new non-baseline images are produced.  I consider "known errors" to be things we expect to fail in a certain environmental situation (i.e. missing an optional dependency).  Missing the baseline images means that matplotlib didn't get installed correctly (or it's a new test).
Another PEP8 issue: Add an extra space before and after the `#`.
IIRC, it is correct.  What the rotate_axes does is switches up which X/Y/Z data is assigned to which jX,jY,jZ variables, but only for the purpose of the contouring process.  We want the limits to be determined from the original data.  Note, I have never really thought about this question, and I could be completely wrong.
I'll fix this small typo when I merge it in.
Checks if the user is an admin. The call to isAdmin() is protected by checks to ensure the authorizable is a User object before casting it.
array_merge is more readable.
This doesn't match the coding standards.. should be 
}
else
{
However, that would be a separate RFC, I think. This RFC is only for removing permissions, not adding settings.
The assignment to ``$options`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere? Please also check line 112.
Are you sure ``$class`` has the correct type as ``*`` is not a sub-type of ``string``?
Are you sure the method ``getRequest`` can be called on ``$client`` (of type "object<Zend\Http\Client>|null")?
How come this big block is commented out?
I agree, but I couldn't think of any better way to word it, thoughts?
No, no such thing exists. We use spans of the source code to do refactorings, not the tree.
Nice, thanks for hinting this ;)
all the comments are gone....
This allows you to click through an element.  As the pseudo element has transparent boarders it blocks clicks through it.  However, it has been [pushed to CSS4](https://developer.mozilla.org/en/CSS/pointer-events).
I think this should "throw" and UnexpectedValueException (there is an error in the XML - do not pass Go or collect $200).
I believe json encode quotes array keys which doesn't seem to suit my use case. I could be wrong though.
I'm actually pretty sure that latest currently doesn't work as a fallback. So this one's still left.
The '$' is simply not needed, is it?
I believe the vector highlighter has moved to the contrib-highlighter package (which is available in 3.6.0). I would require we use the one that matches the other lucene dependencies.
Ahh I must have missed this notification. :( I've had to study for another subject. So have you finished already? If you haven't than I would like to try but if I don't make it untill tomorrow afternoon then your help would be welcome.
Indentation. Use four spaces.
This line you can remove, it was not here before.
No, this is not really a correct template tag library. It is not really connected with accounts, no?

We have a better one [here](https://github.com/wlanslovenija/PiplMesh/blob/master/piplmesh/frontend/templatetags/frontend.py).
`user/email_confirmation_process_token.html`
Go into new line.
It is very good what you did, only the value you put into the string is wrong. `LANGUAGE_CODE` in the template context is not the same as `settings.LANGUAGE_CODE`, but depends on the current user language. `settings.LANGUAGE_CODE` is only fallback value for that value in template context.
So you are saying that buttons [here](https://nodes.wlan-si.net/account/login/) also border?

I think those general guidelines for IE could be helpful:
* Any element with this hack needs to have position, so unless it already has a position, attach position: relative.
* It can act funny on some elements that are natively inline, even if you attach display: block, although not all the time (fun!).
* It also has issues with elements that don’t ‘have layout’. Attach zoom: 1; to get around this.

Zoom is for IE6, `position: relative` seems a [known hack](http://compass-style.org/reference/blueprint/ie/), check the source of *blueprint-ie-defaults* for *button*. :-)

This could also be solved with use of some `reset.css` file the professor was talking about (I think you were missing at that time). You could find some good one. :-)
Why removing it? Just display some other content in the template.
This is really strange iteration?
```
GEOIP_PATH = os.path.abspath(os.path.join(os.path.dirname(frontend.__file__), '..', 'geoip'))
```
And this whitespace. ;)
Not really a fan of this approach. Can't we just either write it pure PHP or make it bash/bat? (not important now, but I'm not a fan of Symfony2's vendor approach, which hides too much what people should actually know...
Please make lines length 100 characters or shorter.
эту логику в assertion
Since this is a `.tar.xz`, this needs a dependency on xz:

`depends_on 'xz' => :build`
I didnt delete it. new PR for a squashed commit.

Anyway my response was that executing this query with the exception of only the quest that will be converted wont work when there is more than 1 quest.

>and should we really delete all other quests?
I will leave it as it is for now but according @Aokromes quests should remain for when the character changes faction again.
I didnt do that in case more ajax functionality will be implemented in the future. That way ^ajax/ exists as the namespace for any ajax functionality that will be added to timepiece.
Is there a way we can pass this URL in dynamically?
s/Enforcement/enforcement
May also want <relativePath> element in here and in other submodule pom.xmls:

http://maven.apache.org/pom.html#Inheritance
I didn't notice that you made your own asScala for this.
The SQL event bus does not make this guarantee.
TODO: Bug, missing "--with-alias-name" argument.
It's unclear to me why you're storing references to persistent objects here, surely only filesystem paths that get loaded need to be watched. Adding a timestamp to the transform `_Cache` would allow you simply compare the cache timestamp to the last observed file update.
We already have an invalidation mechanism for in-zodb content - the cache is stored on a _v_ attribute on the registry, and we simply dirty the registry object to propagate changes to other zeo clients with a subscriber. Other zodb changes should hook in the same way.
Not needed. We don't need to expose this outside qBtSession.
I took care of this on another branch, so there might be a merge conflict, but it'll be an easy one to resolve. :-)
even functions and classes that are no intended for the end user should get full docstrings, at least Parameters and Returns
Maybe it should have been made ​​a `generateOriginAccessIdentityConfig` method so that we can make a `setOriginAccessIdentityConfig` method as well.
Right, I guess the `stage || :default` is a bit superflous. How about this?

``` ruby
config.timeouts[stage] || config.timeouts[:default]
```
Yep. Just pushed a change. That's what I get for copying and pasting that bit.
I vote we don't use 'trigger' as the method name here, that is typically used to fire events "manually" on an object.  Like:

```js
  thing = new App.Ui.Smartbox.View.Box()
  thing.trigger('somethinghappened', 'whathappened')
```
Hmmmm.  I think my preference would be `x` over `r`, indeed because of the use in the relevant Bartelmann paper.  But we could always use `xx`, or even what about `u`? It's commonly used as a substiution variable, and we don't use it anywhere else (in Fourier space we use `k`s almost exclusively, except some places buried very deep in the C++ I believe).  But if not some alternative, I think `x`.


--
Barnaby Rowe
Postdoctoral Research Associate

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom

On 3 Oct 2012, at 18:26, Mike Jarvis wrote:

> In galsim/lensing.py:
> 
> >          self.cosmo = cosmo
> >  
> >          # calculate scale radius
> > -        a = self.cosmo.a(z)
> > +        a = self.cosmo.a(self.z)
> >          # First we get the virial radius, which is defined for some spherical overdensity as
> >          # 3 M / (4 pi r_vir)^3 = overdensity
> >          # Here we have overdensity = 200 * rhocrit, to determine R200. The factor of 1.63e-5 comes
> On Oct 3, 2012, at 1:11 PM, rmandelb wrote: Hmmm. I see your point about x, but it is pretty standard in papers defining equations for NFW (for example http://adsabs.harvard.edu/abs/2000ApJ...534...34W which is the standard I tend to refer to), and r IS also confusing. Perhaps we can bring in a 3rd person for another opinion? @barnabytprowe ?
> I guess we already have a third opinion, being Peter, who wrote the code in the first place. He apparently preferred x.
> —
> Reply to this email directly or view it on GitHub.
> 
>
That's much better, will push an update in both locations.
I added logging of the prepared statement 'params'.
For rekelvinate I was thinking of three commands
1. list videos missing thumbnails (can filter by handle or something)
2. queue up one job
3. queue up everything missing (filtered by handle or something)

So yes, you run the command on one machine, your laptop or app or util, and it queue's up jobs for all the util machines
:+1: on generic numbers.
I fix these when I get this test working, this whole file is basically a no-op right now
Should this go in the \@AfterMethod instead of a finally block? No strong feelings, until we add a second test case...
If we care about efficiency here, we should use StringBuilder and append() rather than lots of `+=`, each of which creates a new string object. But if this isn't called a lot, then not particularly important.
Same as Predicates.alwaysTrue()
oops, well spotted!
I would tend to check when it's set, rather than when it's used.
Fail early, and also if we end up using it somewhere else we don't repeat the check.
It is my mistake, will recover it.
%s/filename doesn't work on windows...
It should be %smongo-selectdb_error.php
Should not need a separate flag for this .. if we have to guard the "prefresh" call we should be able to detect it by the absence of the `state` argument.
there are indentation mistakes.

you can fix your styles running gjslint and fixjsstyle. they are tools under tartJS that help you fix your coding style.
this code is hard for me to read, and these variables being named "y" and "z" is partly why.
I meant line 16965, not the table :)
Added success/error messages to calls to executeQueryAsync.
I think I missed this: there's a little bug `if !game.canedit` then there needs to be an empty `<td></td>` (as in a blank column for non-access users. See: http://twig.sensiolabs.org/doc/tags/if.html
IA32 is not the only 32-bit out there.
Pas besoin de ça : protect_from_forgery

Le contrôleur hérite de ApplicationController ou c'est déjà défini.
remove format.json then?
Это делается автоматически.
We should use markdown lists (numbers followed by periods).
@krupa, @cvan, are we always guaranteed to have this in dev?  Wondering if we need to make this test more dynamic...
It's the test that should fail if something is wrong, not the page object, so if anything this should just return the result of `self._current_step == self.current_step`. Also, those variables should be renamed so they indicate what you're actually comparing. For example actual vs expected.
Yeah, I could see wanting one over another.  Maybe treat it with priorities similar to `EventDispatcher`?

So, something like:

```
public function addParser(ParserInterface $parser, $priority = 0) { ... }
```

Then I suppose you could just custom configure the priorities?
It's merged now, sorry for the delay. I'll close this and fix things up and re-submit to Hilary branch.
作成しません。

は

    作成しません！
I'm way ahead of you :-) ... I just wrote a clean() method on the AbstractPhase model that checks for this. By default this only checks clean() in the Admin and when clean_full() is called. I will also override save() to run the clean method so that this constraint will be  checked when we're using the phases in code. What do you think.
use `to_sym` here
That doesn't ensure it's not checked, right? Perhaps it could have another line with `assert_no_select 'input[checked]` or something like that? And may need to check if the hidden field is being generated with the correct `unchecked_value` (same in the other test)?

What do you guys think?
On Wed, Sep 19, 2012 at 08:22:48AM -0700, Wei LI wrote:
>  > +    return -np.sum((pi / pi_sum) * (np.log(pi) - log(pi_sum)))

>    This line causes some exactly 0/1 case to fail, make nmi gives
>    values a little bit larger than 1 or very smal negative values.

OK. I am a bit surprised that the '0' case works better:
<pre>
In [1]: 0*np.log(0)
Warning: divide by zero encountered in log
Out[1]: nan
</pre>

I would have suspected that it was necessary to remove the occurences of
pi==0 manually.

I guess that this is all covered by the tests, right?

Could you please add a comment line above that line explaining the
reasons. Thanks!
There is an explicit switch that is off by default.
+1 as I said below.
I'm confused by this line.  Unless I'm mistaken, `self.class_prior_` is equivalent to `np.bincount(self._y)` divided by a normalization constant, so the multiplication and division cancel out.  Let me know if I'm missing something.
Could you please explain / point me to an explanation?
typo "and and", also try to fit "mutual information" instead of "mi" if you can.
Could you add a 'topic' here giving a link to the example.
I mimicked that behavior from URLTest::addExistingParamsDoesNotPartiallyModify().
Actually I was looking for a function like setExpectedException like in PHPUnit.
I better should have taken a look in the documentation :)

I'll change that.
Good point -- this is actually a URL being written.  The thing I was talking about before was for a case where we weren't writing a proper URL, just an address:port.
it seems like maybe the spacing got confused here somehow from 4->2 spaces, this also happens somewhere further down. unless this is a specific style i haven't seen before
Hmmm.  Are you saying that's how I should implement this feature, or are you saying that that should already work in the current jade.js?  Because currently, if you access a property which is nonexistant, this exception occurs: "Uncaught ReferenceError: hello is not defined" and the template fails to render.

So, this doesn't work:

h2 this is #{hello || ""}
je crois que dans ce cas, le internal field devrait toujours être non null.  les autres fonctions ne traitent pas celui-ci, alors pourquoi le toString devrait-il être différent.
Then I guess I should use variable names with a single character, because that is soooo much clearer. Oh, and I must not forget to have code on the same line as an opening brace.
Should handle the case when message is empty.
If provided blackberry with android (positional and optional), android related stuff not generated.
Thank you for catching that. Submitted commit to fix.
Align your name. Remove Kyle, this is your stuff. Add your email address.
Change to `setServiceLocator` and according to that in the entire class.
See various comments about this function from the previous commit.
you can just do:

```python
def clean_range_value(self):
    return self.cleaned_data['range_value'] or 1
```
ouch, bien vu, elle fait mal aux yeux celle là :)
This comment applies to all the new classes:

So while I'm not an "please attribute me freak", I can say that adding this note to every class makes it look like you are the author of the whole bundle basically, when what you did was to refactor it into using the compiler passes. Yes, creating these consumers/producers/ etc. is not rocket science but I think this requires the proper attribution. 

So we either attribute everybody that has contributed so far or none. 

Another option is to add an AUTHORS file. If you want also a CHANGELOG saying like 'Configuration changed to use compiler passes by "Timothée Barray"'.

What do you think?
the password should probably use ``askAndHideAnswer``
I think you can most likely reuse same validator so maybe you could fix that while you're there.
Oh I fixed this bug without landing it ... I'll land it right after I end up this review, so that you should be able to remove this, right?
Are you able to display a title to source code sections?
If yes, it would be really cool to put files path+name!
You wouldn't even have to read stuff between code in order to guess how the whole think works, especially, what is the file layout.
Please revert this. Within ZF2, our guideline is that each component defines an Exception *interface*, and then concrete exceptions that implement it and extend one of the various SPL exception classes; these, in turn, are what are thrown.
Please setup your text editor so that it replaces tabs with spaces and make sure the indentation is correct.  Now, with the tabs, the formatting of the code is not that nice...
Why not leave these as-is, and use the FSM for other exceptions types? That would simplify the tree.
@yuhunglin we can probably remove this for now
What do you think about moving this logic down into the model? Something like 

```ruby
class Discussion

  def self.for_category(category)
    case category
    when "conversation"
      Discussion.conversations
    when "review"
      Discussion.reviews
    when "evaluation"
      Discussion.evaluations
    else
      Discussion.conversations
    end
  end
end
```

Then in the controller we can do:

```ruby
class DiscussionsController < ApplicationController
  def index
    @discussions = @course.discussions.for_category(params[:category])
  end
end
 ```
i'd suggest one additional test here (and for emails) - set the type of an out of bounds number (to make sure it doesn't crash). but you can do that later, this looks ok
I think pyflakes does that, although I just checked manually.
Bonus points for including a readme about the implementation :smiley:
I know it seems silly for such a trivial example, but you might want to use a Resources class like:

    public class Resources {

        @Produces
        @Resource (mappedName="java:jboss/mail/Default")
        private Session mySession;

   }

As then you can just @Inject the Session wherever you want.
I believe requests has other dependencies.
Rather than sending the process an anonymous function, you can just let it run with `$proc->run();`, and after it's done do `$output = $proc->getOutput()` and `$errorOutput = $proc->getErrorOutput()`.  It means you can't get it while it happens, but... may be easier to deal with, up to you
Let's use `Math.max(this.width, this.outlineWidth)`.
See my comment above, we should still provide an optional 5th parameter [images].
Why move this?  Why not keep it consistently ordered (assuming it was in the first place)?
Good catch.  At one point it was initialized automatically in fromAxisAngle by passing it to axis.normalize() and re-assigning itself, but that introduced a bug in the case of axis.maginitude() === 1.0.  Initializing it should actually give a decent performance speed up for fromAxisAngle.
Now that I look at the code, I didn't even port AddMerging data, so we may not even need this capability at all.  I saw your overall comment about what capabilities we actually need, so I'll go respond to that rather than elaborate further here.
I assume this is taken care of in the terrain branch?  Perhaps we can just remove this comment.
Can we add a README totest project that describes any necessary ancillary files (for example, publishsettings or other required credentials), and instructions for running the functional tests?
I don't think this will make a different is the easiness of the test code readability, the variable name explains what it is and also its defined in the same class so pretty much easy to refer to it.
On Android, 'close' event is not fired when the tab group is closed.
Yeah, we're actually stripping the '#'  for user values, but not for the values from the webcolor map.

If we did the stripping in colorForHex (or whatever it's called) instead, we wouldn't have to worry about which code paths strip the # before passing it in, and logic would be simpler. Sez me.
I think textContent is part of DOM3, and text was some experimental property that we implemented previously. It does seem to be on iOS (not swearing it works right, but it's there...). 

I don't see text in DOM3, only textContent.
`expanduser`
Can this just be:

    self._layoutTimer = setTimeout(startLayout, 10);
On Fri, Sep 28, 2012 at 6:39 PM, adam <notifications@github.com> wrote:

> In appcache/beginner/appcache.dart:
>
> >      window.alert('Oh no! A cache error occurred. See console for details.');
> > -    print('Cache error: ${e}');
> > +    window.console.log('Cache error: ${e}');
>
> We should be using window.console.log over print in dart:html applications?
>

In general, no. print is fine, because it's for the developer. I'm doing it
this way because it's an alert box that says "See console for details."
Hence, I was thinking of it as user facing, not developer facing, if that
makes any sense.

Most of the other examples use print statements for showing stuff about
what's going on.

-jj
Ah, I didn't realize how the i18n was done. How about making the i18n files call $.extend so that it's a little more extendable (of course we still need i18n updates for the long-term, ideally before release).
i will add a QString parameter to the function, which will be the URL of the repo to be added
i is not a good parameter. i is usually only used for short-lived counters in a loop.

It's also not needed in this class. You don't need the index within the Details widget, as it already knows, what the details for itself are, and there is only one set of data to show here.
@kelseyhightower 
We changed the defaults for `--puppet`, `--facter`, and `--hiera` to be nil because the logic in the Git Install Step will install anything of those with a non-nil value. Defaulting to nil means you must always specify the option from the command line if you want it installed (and you probably will want that going forward), but when testing, say 2.7.x, we do not necessarily want hiera or hiera-puppet installed.

If you want an easier way to specify the repo then you could add logic to the install step that will set the appropriate uri if something like 'master' or 'kelsey/1.0rc' is specified....
This is really cool. Didn't know you could do this.
Shouldn't this be `ret == stopSym`?
is permutation part of the sorting category?
btw, what you posted just ignores everything. i still want my own code to be flagged as warnings.
This deploys to git repo
`finally`. Also, closing the `PrintStream` will close the underlying `FileOutputStream` for you.
This is nice. We should provide this as ring middleware eventually.
Please include @since tags on new public methods
For specialty, should we use a model for specialty, like we did for department?
This is a syntax error. Should be:

    default_value_for :attribute_name, :value => { :value => 123, :other_value => 1234 }
It is still used for the "santized" key to inject in the RouteCollection.
Technically, what @xrstf proposes makes the most sense. However there are other things to consider when developing coding standards for a project (and believe me, I have done this a few times now).

If technically it makes sense to use tabs for indent and spaces to align, this is by far much more difficult to:
1. support across different editors/IDE (they are not all good!)
2. make people stick to this somewhat more complex scheme
3. verify with style checking software and/or VCS hooks.

Basically, grepping for the TAB character is the most effective way to ensure consistency. It should simply never appear in files if CS specifies spaces as indentation scheme.

We should also try to not reinvent too much thing here and use what is really popular and consistent. Using spaces is by far the most common indenting scheme in the PHP ecosystem.
Does this render correctly? It is certainly safer to do :class:`~matplotlib.axes.Axes`. (the tilde shortens the link to Axes)