labofsahil/github-event-dataset-2012 huggingface dataset:
This doesn't need a return false;  no return, `return '';`, or throw an exception.
this is weird, doc says this function returns an array
put it in a constant, make it a regexp literal -- sez mike
export=True should be default
This seems to call Backend:capabilities/2 with the symbolic state, and thus break the test.
Same function, different module: https://github.com/basho/riak_kv/pull/416/files#L4R202
I'm using cowboy as a smart layer 7 proxy to rate-limit and manage incoming requests, I want to pass these through unmolested.
I 100% agree that the more granular a progress reporting is, the better for the user...but I fear that having lots of small tasks could lead to a performance degradation in the risk side. We'll probably have to change the progress reporting strategy to achieve both (for example, report inside a task and not just when a task is completed like we do right now -- and I think it's the only possible way at the moment, am I correct?).

I also see your point about being consistent with the hazard configuration, but since hazard and risk calculations are so different I'm not sure if it is the best solution (honestly, I think we'll have a clear idea only when we'll test risk calculators with big exposures, like millions of assets).
> If you don't call srand, the random number sequence is the same for each call. right?

The random number sequence is same.  The generated random numbers are random. Why do you need different sequence for each call?
Sure, mStorage[8] would be out of bounds if the array is on 8 elements long.
Please let me know if you're planning to address Florian's comments so that I wait before merging.
Dependent on whether one uses cmd or bash, we just try both. One will pass and no errors are output to the console.
I don't understand this. platform is a string. If it's 'Ubuntu', then we set the platform_version to 'Ubuntu' (but that doesn't look like a version according to the docstring) and then the platform and platform_version might be 'Ubuntu'?
This is a kind of a roundabout way to check for the existence of something. Clearer would be to just do a `.filter(...).count()` and assert the count == 1.
I'm taking these responses one at a time.  Thanks for taking a look at these and thinking about them, btw!

> Can you describe the thought behind this test?

Sure.  The purpose of this first test is basically to test the same thing as the following existing test--

    - name: Section - Expansion
      desc: Lambdas used for sections should have their results parsed.
      ...
      template: "<{{#lambda}}-{{/lambda}}>"

but for a list of lambdas rather than a single lambda.

I'm interpreting the expected behavior from this part of `sections.yml`:

    If the data is not of a list type, it is coerced into a list as follows: if
    the data is truthy (e.g. `!!data == true`), use a single-element list
    containing the data, otherwise use an empty list.

    For each element in the data list, the element MUST be pushed onto the
    context stack, the section MUST be rendered, and the element MUST be popped
    off the context stack.

combined with this part of `~lambdas.yml`:

    When used as the data value for a Section tag, the lambda MUST be treatable
    as an arity 1 function, and invoked as such (passing a String containing the
    unprocessed section contents).  The returned value MUST be rendered against
    the current delimiters, then interpolated in place of the section.

The key observation (from the first excerpt above) is that a data element that is not a list is the same as a single-element list containing that data (because a non-list data type is first coerced into a list anyways).

In particular, the following existing test case:

    - name: Section - Expansion
      desc: Lambdas used for sections should have their results parsed.
      data:
        planet: "Earth"
        lambda: !code
          python:  'lambda text: "%s{{planet}}%s" % (text, text)'
      template: "<{{#lambda}}-{{/lambda}}>"
      expected: "<-Earth->"

should be equivalent to the following, slightly-modified test case:

    - name: Section - Expansion of Contents of Single-Element List
      desc: Lambdas used for sections should have their results parsed.
      data:
        planet: "Earth"
        lambdas:
          - !code
            python:  'lambda text: "%s{{planet}}%s" % (text, text)'
      template: "<{{#lambdas}}-{{/lambdas}}>"
      expected: "<-Earth->"

In other words, the lambda logic in the second excerpt above should be applied individually to each lambda in the list.

The test case I provided above was simply a two-element list instead of a one-element list.
roger, tweaked, looks pretty nice :D
Don't need to use a separate args array.
Still not matching:

```
MD5:  baa5ff5002f1c988dd3ccccc92934ace
SHA1: 2039bbc0c25c7ff6bd6e27a0844f10ec8a88dfec
SHA256: 7259afaaef9d4e1ecc87c8c3f898c0666be96615a88ec3b139a1b85b60837ab3
Warning: Formula reports different SHA1: d7f32eac8651734ecc72204c9ad42603008ae04d
```

You're seeing another sha1? The md5 on the copy I downloaded matches the author's published md5.
Unfortunately it's not identical. In 2.3 the samples configuration files have been moved under a new `sample` directory, which didn't exist under 2.2. Also a sample initialisation file was deleted. Tried to DRY this up but it complicated the code unnecessarily. If you have a good idea on how to DRY this up I'd be happy to implement it and update the MR.
This should also work with this change here.
Oui, malheureusement, il faut que je discute de cela avec lui, je ne suis pas tout à fait ok. Il ne gère pas assez ca de façon générale.
Pas très jolie comme message (même si c'est plus explicite pour le débugage. On enléve dans la version trunk?
Debug???
It's not really clear why this is intentional here.
Assuming it still works, can you add a trailing slash here for consistency?
Could you use more descriptive variable names here, please.
I think printing a message for every single post is too verbose, especially since `$action` is loop-invariant.

Could print a single message: `{action} {count} posts.`
I know but it's potentially insecure if it comes to rewriting the code or if someone else does some changes.
如果自己安装包的话，貌似是需要的。gcc/g++/gfortran(或类似)以及libtool都是必要的。
It is used in a comment. Reason is that we declare here that the Javadoc works.
Unfortunately we are not allowed to print strings within test round. Or are we? If we are, then i would uncomment the usage.
oh damn! i'll change
It's on the interface, right?
Nitpick: Even though the style of all the existing specs is to use short, cryptic variable names like c, C, and t, I'd rather that we moved away from it. It makes it harder to search within the file to find references to the variables.
Oops... need to update the comment
We need to remove the listener to avoid memory leaks.
You're very thorough in your review. Actually, I intentionally leave out small swatches since I intend to add them into tab loop and each of them should get focus on click. Since you mention it already, I just add my code for handling those swatches in tab loop :)
No, I think this is as intended. Note that the next line is a return statement.
Can we show an error dialog instead of ``console.error``? There's still no message to the user when this fails.
Should these methods all be underscore-prefixed?
Why 200ms? If my browser loads stuff slowly, will this break?
what is the use of this whole file?
We should discuss this lock with Jon.  It is redundant to what already exists within leveldb and does not guarantee the order of two submissions on the work_queue.  So either we have a work queue problem, or a redundant lock.
i think you want 
from corehq.elastic import get_es
es = get_es()
Minor nit, but do you think you could clean up the spacing and formatting for this file please?
Should these attributes go to the beginning of the file ?
This was just unused, I'm assuming.
The only thing I'm worried about is that this editing hook won't work on the original image plugin (which doesn't store position data), and if someone tries to apply to more than one template, it will fail. 

Anyone who looks at this code who isn't me/us might be confused by two different plugins having the same name. Could this possible be an issue?
Is it worth checking whether the notification was cancelled by one of the subscribers?  If so, do you want to bail and not bother with the rest?
I kept these separated on purpose just to group them.
instead of using click events with prevent default, let's go with onclick returns false.

Using preventdefault does more than just stop the click. It does other, unexpected things.

If we return false inside the onclick, it'll return and cancel the click.

I think you have to use onclick, and not addeventlistener, like so:

elem.onclick = function() { return false; };
Can you document this a little? It's not immediately obvious why you have these wrapped in `if` blocks.
This is a pretty dangerous class name as far as class names go (in terms of conflicts)
Curious: what's the `\` do?
should this be an 'else' when checking between oldPreviousModel and oldNextModel? also the same for newPreviousModel and newOldModel respectively. I'm wondering since you use that logic above and this logic assumes it could be in all 4 states?
should this be indented two more in?
If we are only using this in one place, why not just directly use PDFJS.combineUrl to avoid another level of redirection?
Should we have a flag when paintInlineImageXObject is encountered and only optimize if the flag is set?
Yep, exactly. These are all just page enhancements, so if the API calls fail, nothing breaks. We already accidentally tested this, in fact :) (The GitHub api only works over HTTPS, and wasn't available in one of the testing environments we were using.)
Much cleaner to use CoInternetParseUrl. This code doesn't seem right to me since it will match even if the hostname appears in e.g. the path.
"non-Scribe"

also maybe change the comma to a semicolon
Good catch. Fixing in the next commit.
Do we also need to clean up the roles/permissions that may have been created for filters?
Well, at least you would like to disable it. If you delete an ordinary file, its back on update. You can comment it out as a normal config file.
do another commit in the same branch and push it to github. It will update the PR.
One could impose a memory limit for caching if needed.  In your example allowing a cache of the last transformation would only use 160 Mb of memory, which isn't that much these days.
Do we want to say that for long-term code, we recommend users choose the OO-way of doing it? (as it makes it more explicit which cosmology is being used, and 10 years form now people might not know what default they had set). That is, maybe we should have a kind of guideline for when to use the guidelines, and when to use the convenience functions.
ah ok, its overkill then. removing....
This is actually the max # of objects that can be 'in flight' before we refuse to send any more.
This looks like we can get sequences of version 1 blocks following version 2 blocks. Doesn't seem good.

How were those magical numbers picked? Comments or constant names would be nice for illustrating them.
After looking at how the code works, I guess I can just remove this. Even if the IPC thread doesn't run or something happened we don't rely on this to ensure a working Bitcoin-Qt. It was a left-over from my former pull.
I have no idea at all! I don't know how this got in here! I'll remove it.
Because the name of the function it is in, is being renamed.
I agree with sipa, dbenv seemed to get very confused when I renamed database files behind its back for my corrupt wallet.dat handling code.
I removed that one, because we set the text below, so that was not needed. The same was true for the progressBar tooltip a few lines below.
Carful > Warning
IIRC, Sf2 uses a space after ``use`` for closures. Not sure about Doctrine.
This cancan ability stuff is all looking pretty good. Just be aware that if we use blocks in these cancan statements like this, then we can't use it to filter collections and a few other little things. Sometimes it's good to try and figure out if the cancan statements can just be done in terms of active record conditions. In this case, I think it probably can, but it may not matter too much.
Whichever name conveys the intent better wins - regardless of length ;^)
No - we don't want it to call super, since the QtObject() super does a bunch of stuff which is not appropriate for images.
hmm not sure about this. I think the image should be a app-level or session-level resource. Then, the client side image view can grab the client side image and deal with it directly.
queue_ts
'copy' if ... else 'original'
This construct seems a little odd to me. Why do we not just loop through all of the content types and `hasattr` on them?
I'm concerned that this will be slow for large (multi-thousand-line) selections. Can you try selecting a big buffer (with cmd-A) and see if it's noticeably slower?
I agree with @takluyver here.
These should be declared as Set (interface) rather than HashSet (implementation).
"it should" .. but it was doing odd things with the centered image css ... I will re-test and see if we can avoid this before I merge, if unavoidable I will make a more clear comment about why we need the computed size.
Hmm, well, based on @yorah's comment, I was thinking we should just emulate core git and put the strcmp in front of the fnmatch call here, but then if you look at the whole function, you'll see that the exact same strcmp (actually strncmp) is made immediately after a failed fnmatch already (with a bunch of additional contraints) which is pretty odd.

Then on top of that, diving into core git's dir.c code, there are actually several different match functions besides the `match_one` function that @yorah mentions. The `match_pathspec_item` function is probably more like what we want to emulate for this code, I suspect (which is still doing a strncmp then an fnmatch). That code actually makes is clearly how to consolidate the two different strncmp match cases into a single call that can result in either a `MATCHED_EXACTLY` or a `MATCHED_RECURSIVELY` result (the distinction of which doesn't matter for diff and status, I believe).

Regarding flags, I'm open to adding a `GIT_DIFF_PATHSPEC_EXACT_MATCH` that turns off the fnmatch part (and a corresponding `GIT_STATUS_OPT_DISABLE_PATHSPEC_MATCH` or something like that), if we think that it will be useful to callers, but I think the behavior that matches core git should be the default.
I love it -- in this case we could probably turn the various `git_packbuilder_*_lock/unlock` functions into #define's too! I'll try it out in a little bit.
This causes one of the test failures on Jenkins because IIRC Jenkins runs Python 2.6 (which should be fixed), but assertDictEqual was introduced in Python 2.7.
As discussed in IRC, here the results are sorted correctly in the ES call but not the DB call (I should add a comment). I am almost convinced about dropping the ES calls in topics_for and products_for though.
Oh, whoops--I forgot you were running a Fedora VM. So, this might be just Fedora, then. Sorry about that.
docstring wrong
Why are they global?

I like it when constants like that are inside classes. Makes for a nice grouping. Modules are quite useless and classes are not.
Why? For garbage collection? Won't be needed for a wsgi app since it closes and collects automatically once the request is done.
Perhaps instead of this statements function, we just want a shared helper function that takes DbType and Suffix and returns the file name (complete with path). Then each X_statements function calls that and then does file:consult to get statement.
Why not throw a 'normal' exception instead?
I'd change the last line to: "You should not only test for the valid use cases...." instead of the "It may be..."
@adamfairholm Damnit.. No but it is required in 2.2 lol.

It stops redirect type domains from infinitely redirecting. This is part of the feature/domains branch.. not sure why it's here though. Noooob
Why is this removed here?
:+1: great idea!
supersede -> superseed?
It won't be escaped? It won't be replaced because it is escaped with `%%`.
oh U NO LOG because that one moved here and the "starting health monitor" log msg was removed. why?

I like having the `log.info('worker forked')` right there in the same function as the `os.fork()`, generally I'm trying to keep log messages as close to the thing they log as possible.

I do want to know about the health monitor starting too, the only reason that isn't in the `health_monitor` function is that function also gets called when *re*-starting the health monitor each time.
Did you change the reference to this method everywhere?
ой, не то
There's an extra space in "proper"
I personally would expect the state to be shared, but okay, I can change that.
Do you have any suggestions how I could choose the wording to make the distinction clearer?
In the case where only `rings` is True, why make the call to attach lines?
Breaks it in what way?
So here's something that can bite you. The `riak` and `riak-admin` scripts change directories, and execute both `riak` and `riaknostic` from `$RUNNER_BASE_DIR`. In a devrel setup, for example, this is `riak/dev/dev1`. 

Right now, there doesn't appear to be a good way to get which directory someone executed `riak-admin` from.

One thought was to use the environment variable OLDPWD, however it turns out bash eats that when invoking a new shell: https://gist.github.com/2986216

It might be worth looking into storing our own in the `riak` and `riak-admin` scripts.
do we really want to retry in double the time since 1970?
ARGH!  I knew I'd seen something like that, and I even looked through `http://apidock.com/rails/Hash/` looking for that exact method and didn't see it.
@everbird 一般这种控件习惯怎么命名？Android这边都是加个mXXX，我就习惯性这么用了
Remove the check and correct the task.
the context for the callback should probably be changed to something more useful than ``this.options``
Hmm, it looks like at some point my IDE stopped automaticallly adding license headers, and I did not notice.
The point here is that is wrong to support expression for those values, since they are rewritten in case of multiple activation. Before submit a fix (it's 2 secs fix) I'll ping you today on IRC
A further explanation what was the problem in the first place: The #toolbar is a **span** (for whatever reason) and therefore top and bottom paddings won't behave properly. By making it have a display of either "block" or "inline-block", it can properly contain its elements and can/should take the same top and bottom padding as the left and right padding.
I have no idea why the padding of the #toolbar was changed for IE7. In all browsers there is a bit more space on the right than on the left, because every button has a right margin. In all IE versions it seems to be a bit more, but IE7 is not different to other IEs. Maybe it was before my fix, though.

If you'd like I can make screenshots before and after the fixes.
> Do you know if there is a better way to do that, and if not, should the browser API expose something?

This is probably the right way to do it with the current API.

We could add something to the browser API, but it would have to do basically the same thing.  If you want a synchronous "is-loading" variable, we'd have to cache the value from the child -- otherwise the query would have to be async, because we can't make sync calls from parent to child.

Unless this is a big pain, I think we should keep it how it is, for now.  The alternative is to add a lot of caches to the parent -- it's just more code we have to test, and more code we can break.
We assign the dom variable to currentDom or document if we don't have any other.

Should we add the event listeners to the specific target? (dom)
If you change the code here, you need to update it on all files.
Nevermind about the reasons. I see it use in postMessage. But having it hardcoded won't work with DEBUG=1 / GAIA_DOMAIN build.
yep, you are right. I'm gonna removed unneeded stuff
You mean "Toolbars" ?
apparently shouldn't be needed anymore
This algorithm has to be implemented in 'contacts.js'. @gtorodelvalle is working on it! ;)
Please don't save screen state here... you can always ask `ScreenManager`.
The reason we were "querySelecting" all the time was that you can dynamically  add more fields to the form (phones, emails, comments...).
This change could lead to the "Done" button being disabled because all the initial fields are empty, but you added a new one.
What about reseting textFields var when a new field is added/removed? 

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/contacts_form.js#L224

That will avoid 99% of cases where we were doing querySelectorAll.
Thanks guys for the effort!
Are you sure you can see all the contact details when the contact has a picture without this? Try to create a contact with photo and start adding fields. I'm sure you won't be able to see the last fields when detailsInner height is > than the remaining space between the photo and the bottom but < than clientHeight. Not easy to explain, so say hello on IRC and we can talk about it.
The conditions here are already handle by the case 2. Why is it not working?
nit: remove one leading space please.
Also since you're using them in the init methods there is no good reason for making them lazy. Just call getElementById here.
Due to the conflict that I mentioned above.
Here might result in: the overlay will not disappear cause currentOverlay will never equal to "cardinuse".
It should be <code>currentOverlay === 'pluggedin'</code>.
It's entirely subjective. This is just a suggestion again here. I mostly try to minimize the number of LOG.info statements that I have so the user can actually what is going by on the screen and understand it. Turning on debug may result in a ton of stuff going by, but should give the user lots of info to go back and look through if they're running into issues.
A better solution would be to observe the actual precision of the `Real` and display that many digits.
Wow, that was quick :)

I shall go through and make some modifications as you have noted.  The null
ref - yeah, stupid mistake on my behalf, the rest are good comments.

Regarding HTTPS - that takes a lot of extra setup for IIS, you can't simply
throw a port number and expect it to work, so no we don't care about that
at the moment.  That is something I expect to sort as part of "multiple
hostnames" later on, but perhaps not right away - https support is a self
contained extra.

Regarding whether its random or not - random is only set if the default
hostname config is not set, so you get either "localhost:randomport" or "
app-name.suffix.com:80".

Does that make sense?

Cheers
Richard

On 1 October 2012 20:18, David Fowler <notifications@github.com> wrote:

> In Kudu.SiteManagement/SiteManager.cs:
>
> >          {
> >              var pool = EnsureAppPool(iis, applicationName);
> >
> > -            int sitePort = GetRandomPort(iis);
> > -            var site = iis.Sites.Add(siteName, siteRoot, sitePort);
> > +            IIS.Site site;
> > +
> > +            int sitePort = randomPort ? GetRandomPort(iis) : 80;
>
> So it's either random of port 80? What about https? Or do we not care
> about that as yet?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/projectkudu/kudu/pull/168/files#r1731801>.
>
>



-- 
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not 'Eureka!' but 'That's funny...' - Isaac Asimov
rs.uploadWithToken(opts = {...}, callbackFunc) 形式比较灵活，参考 ruby sdk http://docs.qiniutek.com/v3/sdk/ruby/#upload-server-side
This is provided by the rails-i18n gem. We shouldn't add these translations ehre.
Yes, or is there a reason to keep it here?
How should I call it to post to the channel instead?
Above code doesn't say that profile was saved if avatar wasn't changed -- which is wrong. Function should always give result, which is either success or fail.
Aren't these supposed to be secret? If we put them in source control, won't thisl allow anyone who can see this (public) project to mess with our auth?
You should be calling performAction on this queue here, I think. Otherwise performActionParallel has an unexpected one-frame delay. I would expect performActionParallel to have the same timing as calling it not in parallel.
The above three functions are in fact the same function but with different regex being applied based on assumptions you are making as the result of your browser sniffing. What happens if they standardize and all use the same format? What happens if we meet a browser in the future which looks like none of the three above but happens to act like webkit?

Instead of browser sniffing, why don't you examine the format of the stack trace and use the most appropriate set of regexes? You could pass this set of regexes to a single function which could do the work required. One approach would be to have an array of objects, each with a test regex and  well known properties for the other regexes. You could work through these objects until you get a match and then pass the successful one to the parsing function?

c
since we're using bootstrap-sass, we can remove lines 7&8 here.  i did this as a manual override to the vanilla bootstrap css, which i believe the gem now takes care of, as its asset-pipeline aware.
`id` is `nil` here ;)
Near from should be translatable. See [this commit](https://github.com/movilla/diaspora/commit/85a6f59903baa34e04e23d53806d61ee92ca70c0) for example : 
$('#fileInfo').text(fileName + ' completed');
=>
$('#fileInfo').text(Diaspora.I18n.t("photo_uploader.completed", file=fileName)).fadeTo(2000, 0);
no need to add many line breaks here
We tried it that way, but it didn't seem to persist the variable inside of the shell bundle exec creates, especially when using RVM.
Couple of questions:
- how will this deal with the case where reloads are disabled in yaml?
- will this report when reload is fully complete?
- what happens if reload is already in progress?
formatting looks odd still
Same comment here as for value_split and prefix.
Somehow a tab snuck in.
Sorry if there is some misunderstanding, but I'm not picky. I just think that put that link "as is" in the comment is wrong.

As you said, the code I wrote and C++ code doing the same. The difference is that in the C++ code there is no explanation about what's happening – why that process is *needed* – where in my code I explicitly said that.
The C++ code use a `nsISupportsInterfacePointer` but it doesn't explain why. So, to me, is totally useless: it's basically the same code, as you said, but looking at it you can't figure out why these steps are needed.

So, to me it's wrong put this link in this comment as is because if I read that comment I would expect that the link will bring to a code that explain what is described above, but it doesn't.

Notice that I'm not against to put that link, I just think that put the link in that context is misleading. As I suggested the link could be added in a different context – same comment, but with a sentence that define the link contents better, something like "To understand the copy action on platform side, see: http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsCopySupport.cpp?rev=7857c5bff017#530"
Nice way to do it without evaluating the template and keeping the code DRY.
Could `info` be the results of an addressInfo call? Or is it always a combination of data from storage and variables set from code?
not sure about the `_ova` part, it could be made more generic if one provide the binary output codes used to compute the confusion matrix -- what do you think?
OK, I understand it now... 
Thanks
No technical reason we couldn't do that, just not sure if changing the default behaviour is a good idea.

In my own usage patterns I rarely use the AWS name tag, more often it's Chef node name and other AWS tags (eg. aws:autoscaling:groupName).

It would be easy enough to define default behaviour from a setting in the knife.rb config file.
I think constructing this temp name can be replaced with using `create_test_file` and `get_test_file_path` from `Puppet::Acceptance::TempFileUtils`
Yes it seems to. What action should we be taking on this comment though?
Curious, what's the reason here for the different naming, trigger_kill instead of register_kill?
Based on [matz's response](https://bugs.ruby-lang.org/issues/6239#note-2), `ruby_bug` is not the appropriate guard here. Instead we need two specs: one for `ruby_version_is ""..."1.9"` and one for `ruby_version_is "1.9"`.
why change this from regex
when it happens, the bottom space is many more
Only one blank line between each group of imports is required.
Add class header with a class description
Ok. Anyway, we should agree on a naming too for traits. I like the "Provides" something naming.
http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.var.pkg.html
I'd do:
```
if (!in_array($strict, $checkTypes)) {
   /* throw new ... */
}
$this->strict = $strict;
return $this;
```
Easier to read and understand the flow.
You can use multiple var statements here
If we only update the stats every 2 minutes on the server I'd bump this time out to something like a minute.
why don't you simply leave this method unimplemented (abstract)?
yeah  copy paste error... will fix that if this is the way we go further, thanks for catching it...
Why do you disable the input? it's only visible when in editing mode anyway.
Could you put this in a `<script>` block template and pull it in instead?
I haven't tried your patch, but looking at this line, it seems Angular will reuse any existing `window.angular` and extend it. This goes directly against the principle of returning the old value unchanged, and in fact turns `noConflict()` into a no-op.
should really be backwards compatible for at least one release with warnings instead of exceptions.
Should I throw an exception when an error in the regexp occurs?
i think here cascade all makes sense.
There is no underscore. :(
two empty lines
add an extra var for verbose output and check it here.
I think we should just drop the two step war deploy. It seems to only add confusion to me.
Non-idiomatic code, use `return parser->state == s_message_done;`
indentation here looks wrong, will probably break python
missing whitespace after + operator
This should probably just be an array:
```js
admins: [
  'sup@example.com'
]
```
Yeah, sorry about this. I end up with the same problem if I tell my editor to strip out trailing whitespaces too :/
Let's not kill this, let's just move it:

// Existing youtube references can break us.
// move it and use the one we can trust.
window.cachedYT = window.YT;
window.YT = null;

This way the object can still work, access it's "this" (i.e., global), but won't break us.
Please use double quotes
This is dangerous. `Exception` is not rescued by default — only descendants of `StandardError` are. Idiomatic here is simply

```ruby
raise "Couldn't decode SAMLResponse"
```

which raises a `RuntimeError` (which is a decendent of `StandardError`, which itself descends from `Exception`). `Exception` and its other descendants are used for critical errors in the interpreter like `NoMemoryError`, `SecurityError`, `SystemExit`, and friends.
`manage_required` isn't a good name. Too generic. I would simply call it `staff_required`.
What I meant is that you want a boolean `true` rather than a string `"true"` (notice the quotes). Although both of them evaluate to true and would work, I want to make sure we're on the same page.
I'll put that in.
nit: indentation of the above comment is off by a char or two
I have changed that :) see below - should be much better now
You should use ``assertArrayHasKey($key, $array)`` instead.
где ты был, когда мы говорили, про smart pointers?
This turns off middle-mouse-button "pan" scrolling, which doesn't work with the new scrolling implementation. (It just occurred to me that we might want to only do this if options.flickerFix is false.)
Good catch, I meant to send you an email yesterday, it was actually a
mistake, I enabled own repos for myself locally when testing, this
shouldn't have been committed.


On 26 December 2012 13:24, Oscar Rendón <notifications@github.com> wrote:

> In app/controllers/wannahelp_controller.rb:
>
> > @@ -27,7 +27,7 @@ def toggle
> >    def default_search_opts
> >      {
> >        :need_help_true => true,
> > -      :user_id_not_eq => current_user.id
> > +      # :user_id_not_eq => current_user.id
>
> without this filter all repos are gonna be listed on search results even
> your own repos.
> Do you find this better from user perspective?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/orendon/contrib-hub/pull/108/files#r2503052>.
>
>
That's the case I was trying to fix. They'll get redirected back to `/refinery/images` by https://github.com/resolve/refinerycms/pull/1904/files#L0R54
Right now there is no private user data that is returned in searches. The displayName will be private once id-management is merged along with the publicAlias, in which case we have a use-case for private info in search to test against.
Should do a permission check to see if the user has access to the content.
Unfortunately that doesn't work as the redirection happens differently among the auth providers. We'll probably need to know whether the tenant is running on https or http. I'm assuming you'd only run on http as a dev really.
I can't immediately see why only ``ScalaCompilationUnit``, could you add a comment?
True. But, given we have no stable API, I can't see how this would be worse than any other change we do (plugins will still need to be re-compiled as they are not going to be binary compatible...)
Fixed! I hope ;)
It does now! ;)
Could be just:

    echo now('Australia/Victoria');

Not that it really matters, but I like giving better examples. :)
Indentation looks weird here, use tabs instead of spaces.
В данном коде не идет речь о замене X процентов. Здесь реализована перестановка элементов массива случайным образом.
Мне сложно судить можно ли было сделать проще. Если предложите конкретный способ реализации, ответить на ваш вопрос будет проще.
Этот метод ничего не делает с состоянием класса - его можно сделать методом класса (class method)
Я имею в виду int indexes[percent], конечно же, простите за опечатку.
Good point. Objection dropped :-)
By the way, isn't it better to switch to nose and remove custom ./setup.py test ? This way proper return values & code coverage will be given for free.
Can you set an expectation for the prompt you will see here?
and you need to escape the ``\`` too
This comma is not necessary.
> I'm not really sure, but I think that doing an stop there is odd.
It feels less odd to me without the comma, so if you're not sure, I propose we let @weaverryan decide, I believe he's a native english speaker.
是的，这个确实不好直译，很难读。
但丢掉少量信息量低的信息即柳暗花明，另外善用括号，比如
为访问日志设置路径，格式和缓冲区大小(nginx访问日志支持缓存)
This `else` block is unnecessary after the `if` and `return`.
Just to clarify 

* `.to.be.true` is syntactic sugar for `to.equal true` 
* `to.eql` is `===``
* `deep.equal` is `===` recursive through the object (not `==`)

The reason why I used `.to.be.true` is just that I thought it looks nicer :) but I'll change it to `to.equal true`.
Also, it should be "exception", and there must be a space after //.
The void type is a bit strange also, as the only place it is used is rk_fill, where it is cast to unsigned char, but it is harmless.
OK, I see what you're getting at.  This is exactly why we need Piecewise(evaluate=False).
Ты кликаешь по файлу - СopyUrl. Оно передается в плагин. Плагин высылает
сигнал с уролом. Если это GDrive, то сначала шарит файл, а потом высылает
сигнал. В других плагинах можешь реализовать как хочешь

>
For performance reasons, this should be much higher. An interval of 1 means that the debug hook would run at every instruction, which would cause an unacceptable performance loss.
We talked about this code in office hours... just an alternative way:

```
class Automobile
  def ==(other)
    color == other.color && make == other.make && model == other.model
  end
end

####
blue_honda_accord = Automobille.new( make: "Honda", model: "Accord", color: "blue" )
@@vehicles.select { |vehicle| vehicle.class == Automobile }.select {|a| a == blue_honda_accord }
```
good point again, thanks!
Please open a pull request when you have finished your work, not before. "<!-- NEW: is just the place-holder and reminder. Will be removed within next commits." = not finished. Closed.
yes, this is picky but, can you add a space before '#closeModal, .modal-backdrop' and function() {
lolxcode… it isn't rendering a space… or letting me delete it O_O.
Same question as before, shouldn't this return statement use patch_cattr instead of the empty dictionary?  Otherwise, what is the point of saving patch_cattr?
Good catch--I removed the enumeration (commit de1f1f4).  The second for loop can be merged without any problems.  I think that the separation was from a previous hack.
As I wrote in a comment earlier, `collection._offsets` is a numpy array, not a list. This means that `bool(np.array([0]) == True`, and `bool(np.array([0, 0])` raises an error.
It's more of the fact that I saw that code existed before for this code path, so I didn't understand why he got rid of it
Хоть оно в coding style и не вынесено, но по остальному коду перенос в цепочке вызовов оформляется по другому
Won't this clobber `$this->members` and `$this->groups`?
@thdox: I agree it's much more readable.
I'll change it
Maaaaaaybe want to be specific about what the relevant spatial information is here.
Maybe an even more general point -- function docstrings should talk about data structures. "timeseries" is really vague here, since the timeseries we use elsewhere is actually a map like this:

```clojure
{:start-idx 0
 :end-idx 3
 :series [0 1 2 3]}
```

This is fine with the example -- but remember, we're going to be releasing this for other programmers who might not be as into the research, and might not know what "idiosyncratic disturbance" is. I'm not really sure why a deseasonalized signal would be a disturbance -- it seems like the seasonal affects are the disturbance.
Why are you putting XXX on comments?
Is this the preferred way of "remembering" metadata for a form?
James, could you add a more detailed example of how this would look? I noticed the `defaultOptions` key in a previous commit, should this still be used? You can probably use the embed content widget as an example.
thats really cool!
Variable should be $em not $orm.
Bundler takes platforms as a parameter, so you can additionally restrict
this gem to only linux machines

https://github.com/carlhuda/bundler/wiki/Platform-as-a-parameter

On Mon, Sep 24, 2012 at 1:24 PM, Dan Croak <notifications@github.com> wrote:

> In templates/Gemfile_additions:
>
> > @@ -5,6 +5,7 @@ gem 'formtastic'
> >  gem 'flutie'
> >  gem 'bourbon'
> >  gem 'airbrake'
> > +gem 'therubyracer'
>
> Is this only needed in development, assets, and maybe test environments?
> Would be nice to avoid putting it in staging and production environments
> if possible.
>
> Alternatively, if this is a development-machine-specific library that
> doesn't require Gemfile changes, can Debian users just install a Javascript
> runtime as part of getting their machines ready for Rails? It seems like we
> don't necessarily need to make this an application-level concern if it
> works for some operating systems with libraries installed external to the
> Gemfile.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thoughtbot/suspenders/pull/104/files#r1677405>.
>
>



-- 
@adarshp <http://twitter.com/adarshp>
developer at thoughtbot, inc <http://www.thoughtbot.com>.
313.454.1515 (m)
Can we either change the element name to "form" or actually return a form id?
Currently I'm seeing
```
<report id="686" approved="0" verified="0" form_id="Default Form" mode="1">
```
which makes no sense since "Default Form" is clearly NOT an ID.

Also seeing a lot of reports with blank form_id .. is that expected?
This is the bad change: we won't schedule eviction on any page that has a modification structure -- see #419 for the discussion.
Rolf, just FYI: there are fundamentally 6 types of objects at the moment, files and tables, and there are row-store, column-store and fixed-size store versions of files and tables, so 2 x 3 types of objects.   Generally, it's good to test all of them because it's hard to predict where they share code paths and where they don't.   One of the things I've been noticing in the test suite recently is that we don't test tables with lots of underlying files in some places, and there are problems.  I've added a couple of functions in the file helper.py: simplePopulate, simplePopulateCheck, complexPopulate and complexPopulateCheck, that create simple or complex file/table objects (complexPopulate only operates on tables because only tables can be "complex").   Anyway, those functions might be useful to you.
You probably don't need to do anything more than calls self.session.create(), we don't need error checking in any additional detail except in maybe one test (and now that the system is running pretty well, not even there).
I'm having a devil of a time with it. Let's leave it as is, then remove later.

One reason I think it keeps showing up is that Netbeans doesn't use .gitignore-global.
Are you sure the variable ``$resource`` exists, or did you maybe forget to declare it? Please also check line 93.
Is it possible to add a ``@param`` annotation for parameter ``$title`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
Probably typo... will check.
Injected whitespaces break the formatting pattern and add unnecessary line changes
AFAIK, dynamic codegen works in Silverlight, though you might be restricted to the Expression Tree compiler (System.Linq.Expressions, in particular see LambaExpression compile). IronPython and IronRuby run in Silverlight using runtime codegen, and they have no special permissions (they're "security transparent" in Silverlight parlance, essentially untrusted user code).
We no longer need to reference those CodePlex items actually, but thanks :) Lets move off that thing.
(enhancement idea) make NUM_RECENT_MESSAGES configurable
As lame as it sounds, I would add some kind of method comments that explains what the function does and what each argument is and what its' properties are for. I would require this for pull requests as well. This codebase will only grow and become more confusing to grok:)
hmm try to break this up into a few lines if needed? goes beyond the limit of 80 chars or whatever the max is
All these functions are about transforming the input, and so should be Twig filters instead
Are there threading concerns with this method? (is it reentrant?)
Just a friendly follow up on how this is going. No pressure :)
Sure, go on, `iOS Simulator.app` makes even more sense.
I don't see the motivation behind this method. Why wouldn't client code just use `attach` directly?

And why provide special support for a `PrintStream`?
If you can, replace the magic number with an expression or a symbolic constant.
The diff confused me as to what the intent was here, but after reading the code everything was crystal clear.
You can test for type of input arguments. :-)

If it is already sting, you use that, otherwise you call `get_full_name()` on it. :-)

Anyway, you will also not read from session, but will use `request.node`. :-) And then do `request.node.get_full_node_id()` even. :-)
Again, why full import of the function? And please, just try what is the output of your call and see if it is right.
So this fail at run-time or you listened to PyCharm? Because PyCharm was quite confused with relative imports?
It is ugly but good way to solve it. I don't have any better suggestion.
What is difference between user data and profile data?
Why is this method in the form?
There is nothing better for username?
Да, на все 100% уверен, что парсер не скушает `smarty`. Про вложенность не уверен.
Idem (not introduced by you, I know, but while we're at it...)
`else` you might get angry.
I was just thinking if I could make changes to the commits directly in github, but apparently I need to check out the code and make the changes.
are there tests for the country code being included as well?
checking float == 0 is not so good

i think the formula is also bad:
dist = 0: 500 dmg
dist = 0.1: 25000 dmg
dist = 0.5: 5000 dmg
dist = 1: 2500 dmg
dist = 2: 1250 dmg
dist = 5: 500 dmg
dist = 10: 250 dmg
dist = 25: 100 dmg

or i'm wrong?
The build needs to come before the lint so that we can check the generated template js files.
Wie ich das sehe wird das Rating noch nicht zurückgespeichert.
take out the hgroup. not necessary if it is only na h1
the service id does not follow the naming used in the bundle
I think there's a mismatch between the `@throws` type and the actual thrown exception type.
In common with the convention used in other files, this should start:

``` ruby
module Capybara::Poltergeist
  class NetworkTraffic
```
That's good to know. So where the click command actually clicks depends on the scroll position of the window? I should run some tests to confirm this.
"official" not "office"
This newline at end-of-file change was unintentional -- my editor was overzealous apparently.
We can use re.compile(r"[^\w_]") as a shortcut, nope?
This should stay `None` if `None` is passed in
+1 for the deprecation warning. We maybe should update the docs accordingly.
I'm not sure it's worth adding another level of indirection here. Doing self.streamer.publisher / self.streamer.get_pids sounds acceptable and probably easier to read/understand for newcomers.
Having one way to specify what we want instead of tweaking three 
options sounds far better to me.

And if "explicit is better than implicit", then I prefer much more 
"http = host:port" than having to set three settings to do something.

When you say "mich more complicated", you mean for the user, right? If 
that's true I strongly disagree. Having to know three settings is more 
complicated than having to know only one from my POV.
This is too inflexible. A change in the version of Java or Selenium, or command line options would cause this to fail.
I would keep this comment, as we are not guaranteeing delivery.
`notNullOrEmpty` uses `empty` function which returns true if the object is null
Is there any particular reason why you use `if len(data)` instead of `if data`?
Looks more like an API function, we can probably remove the ```_ ``` prefix
The "*" is unnecessary.
Number(), also on the next line.
We'd like to handle moving the definition to LWRP in a separate commit/branch/ticket.
What if n == NGX_ERROR?
typo: Override