labofsahil/github-event-dataset-2012 huggingface dataset:
Да проблем при накатывании и так не будет. Проблемы будут при чистке после предыдущего накатывания, и я не знаю как их решать. Вы забываете, что R2 это не что-то готовое, а процесс, и SQL-и тут могут меняться в любой момент :)
По хорошему тут нужны либо спец. механизмы в ядре (например формирование гуида с использованием карты - но это неоффлайк), либо деление областей статиков в некотором центре - ядерщиками (мейнлайн) или базмейкерами, ибо это стандарт. Но раз они не сделали - придется изобретать локальный велосипед.
no, this only allow has one config for mmaps and standalone cores (with different DataDir).
Since python dicts have a `get()` method with a default parameter, you could shorten this conditional to something like:

    brush = MT_SYNTAX_BRUSH_MAP.get(language, language)
    el['class'] = "brush: %s" % brush
Some classes are missing in this commit, source will not compile. Do not use it and wait for a following complete commit.
If you are going to make the name longer, it should EventManger. Although perhaps eventManager would be better. Poke people on IRC about picking a naming convention.
This is worthy effort ;) 

I keep cleaning this anti-pattern when I see it, always keeps sneaking in somewhere.
Yes, that what I thought. I didn't remove every print statement. I will keep them if we need it for next files.
(I realize that harping on C vs C++ is mostly pointless since the code's written.)
Please take look at this. When do the user need a quote -> " <- for paths? Can we remove this line? Refs http://redmine.froxlor.org/issues/1009#note-5 "Oh and again: One customer just entered "". Apache doesn't like that too ;)"
This breaks unoconv for me. Ubuntu 11.04, LibreOffice 3.3.4 as pre-packaged by ubuntu.

Works all right with short options (after changing conditions to "if True:").

Thanks for your awesome work, btw.
Shouldn't this be
&programname[strlen(programname-4], ...)?
Rebased to latest version of JBoss AS 7.1.0-Final

$ git pull upstream
$ git rebase -i 2e3f3e9645bcd8da66dcf0190111c512825a44a4
$ git pull
$ git push
Here I would rather like us to stick to lively.ide as a module in itself. I like the idea of being able to include a main module of a subsystem that that allows easy inclusion. Also don't like the uppercase name :-/
for this i have already prepared a similiar solution like you have done this with the gpt stuff in the installer. the installer will ask if ssh ishould be enabled by default and if its "yes" then "ssh" will be added to the kernel commandline. the ssh_enable solution is more a temporary solution to enable ss if you have disabled ssh per default. hmmm i can push this commit for testing, but it needs some good words in the textbox, maybe you can help me there?
Nice :-) I'll do this as other PR; this one can be closed.

Sincerely, Pavel.
24.02.2012 3:57 пользователь "Matt Wynne" <
reply@reply.github.com>
написал:

> :D
>
> The latter idea - using with_file_content. I think that's much simpler,
> isn't it?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/argent-smith/aruba/commit/a440a3537153a23ad95215d443de72c3168629a5#commitcomment-1005018
>
Social Stream is pretty good , if there is Q&A(like Quora) component will be better ：）
haha...git commit message is just as advanced as the message function on Facebook. I will work on others tonight. Let me finish my lesson first. :-)
Thanks, i'll try to replicate the issue later, will let you know.
don't try to remove it, eclipse need it to work.

I thought that I putted that file in the gitignore file ...
I just put those values there as default values! Is there a draw back or you just kept the code clean?
That'd be like suggesting to use the arrow keys instead of hjkl in VIM! *lol*
Just a remark about integration tests is that we need polyglot released with changes on maven
I haven't found anything specific about this issue in the documentation, but the array example in
http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/operators.html#delete
indicates that the items should only be deleted from the array without changing the array length
Water velocity is in fine units now? (thus this change to display water velocity correctly?) Interesting.
i only hack til script finished then figure out correct way .. first goal is always blizzlike then correct
To conform to the other specs we should only send POST body data here (not GET params, since they're already included as query_string)
that's alright.

shall we proceed as it is?
… which only exists in my repo since it seems I haven't sent the pull request yet :/
perhaps this would be better...
#[^\p{Z}\p{C}\/] matches not "separator","other" or forward-slash
[^\p{Z}\p{C}\/]{1,}(?:\.[^\p{Z}\p{C}\/]{2,6})+

http://en.wikipedia.org/wiki/Mapping_of_Unicode_characters#Character_properties
oh thanks for this. Were did you get the ö from? ;)
This change looks to add back the problematic $all (start-up/shut-down last) function. Is there a reason for this?

-# Required-Start:    $local_fs $network $remote_fs
 6 	   	-# Required-Stop:     $local_fs $network $remote_fs
 7 	   	-# Should-Start:      $NetworkManager
 8 	   	-# Should-Stop:       $NetworkManager
Oh, that's why.
He likes spoiled things.
Ok. now just a crazy idea, would it be possible to make the endpoint registration even more dynamic? Let's say you have an actorsystem, you run it, you find out that you get stuff in your dead letter queue (if that is even there listening in akka), you reconfigure the endpoint correctly while the system is running, and feed the deadletterqueue back into the system, problem solved (and no messages lost)?
First we must understand why adding "distinct" breaks xwql queries like the ones used in App Within Minutes. I don't have time right now to investigate, but I've seen that the "order by" clause is broken. For instance this fails:

    from doc.object(AppWithinMinutes.FormFieldCategoryClass) as category order by category.priority

while this works

    from doc.object(AppWithinMinutes.FormFieldCategoryClass) as category

I'm not against adding "distinct", but it should not break existing applications.
Не помню зачем это было сделано... >_<
Enige reden waarom hier een specifieke revisie sta
What is the idea behind this? Do I understand it correctly if I interpret it as first it gets the last part of the URL (A file name in your case I guess), and then it tries to get a "name=" key. What is the behaviour in the second step if it can't find a "name=" to split the string into? I understand it so that it will automatically use len(s) instead, I guess that's ok =)
Btw, how does your urls look like? It would be interesting to know!
why this change?

Git (if used with the recommended settings - see wiki) is not fond of blank lines at the end of files...
Looking into this...
If there's a bug where expand-region keeps marking the same region over and over, I'd like to fix it in expand-region. Do you have some steps to reproduce it consistently, @gvol?
It does crash it for me. Feel free to re-test :)
![kid](http://g.static.memegenerator.net/cache/instances/400x/12/13259/13577396.jpg)
If you look at graph of branches, it makes more sense :)
Because morons, and even rub their posts LOL
"Are they beings of light?"  

"Not quite."
I don't know - possibly the nubmer of results  I'll check.  Especially since that number won't be correct if it is.
Unless you rely on the apis for some sort of group support why do you use them at all?
Pex is too old and just keeps getting quirkier.
there are much compile errors: in icecrown.cpp dalaran.cpp and yogg-saron.cpp "class Player has no member named <b>HasAchieved</b>
Mainly as a proof of concept - thor uses both and I'm not sure which one Jake would prefer to use.
Not really :) I've just collected the changes between pms-mlx a couple of month ago, and I try to keep up-to-date. I thought it is necessary for mlx, but if you don't know it, then who knows ? :)
This is slightly cleaner as a switch statement
I understand but I think there is a lost understanding here with site templates based on one of your descriptions from an email thread I saw yesterday and that is that the pages can be deleted when "allow changes" is activated?

Didn't we explicitly prevent that from being the case, that site template pages can never be deleted?
that should simplify to a single line: ``as(<directory-locator>, path)``
esc_attr_e is a translation function so it was being used incorrectly in this context.

This still needs an echo, though.
Good call. I meant to ask but forgot to. Thanks.
This logic should be in the form.  You shouldn't ever really need to pass an 'error' variable - that's an indicator that you're not using the form properly.
Reapply this. (?)
Defaults to* false* to prevent missbehaviour with existing configurations
Indeed, sorry for this.
We need to be *100%* sure no exception is raised in the compiler except `DatabaseError`, because all other exceptions are "swallowed" by the `list(...)` call in `django.db.models.query.QuerySet.__len__:80` and then this happens

```pycon
>>> Foo.objects.filter(...) # throws some exception
[]
```
since Derby doesn't support locks we'll get '0' after DELETE_MESSAGE if we try to poll message in two transactions at the same time
The cluster URL fetching would use `.getBlocking`.  As would meta/global?  IIRC, the actual `.get` method is /fake/ asynchronous.
Thanks for the fix ;)
Why are these not indented?
The test assumes the availability of the MediaInfo library, see 9106c238b0bafd5bade1b9a20b2a827611e55b23.
It will therefore fail if the library is not available in the directory where the mvn command is being executed.
The big ZIP button on top could be useful, but the color is an eyesore.
http://glqgamemaster.github.com/Gentle-Love-Quest/
If a process is interrupted it usually has an >0 exit code,
e.g. tail -f xxx + Cltr-c == 1
messed up commit message - the change add JTA support under Tomcat+Bitronix TM
Yup, I caught the typo after committing.
Makes sense to me! Wanna patch/request pull?

Cheers!
```$this->getConf('useqrcodes')``` would be the correct way to access the plugin config ;-)
This is a static Archive, so it could extend CachedAuxiliaryArchiveAppender
why forcing the locale to the default one ? It means that they will not be translated in the right language as soon as the user changed the language used to browse your site
Hi, Flinny

I sync the whole project today, including this commit of course. But the compiler complains lots of errors/warnings about mm-video project. Did you build it without problems?

By the way, the Android.mk of stagefright library should also be changed to build libstagefright.so successfully because mm-core location has been changed: $(TOP)/hardware/qcom/media/mm-core/omxcore/inc -> LOCAL_C_INCLUDES += $(TOP)/vendor/qcom/opensource/omx/mm-core/omxcore/inc.
I looked at the ways to not compute the fingerprint more than once, but I could not figure out how, without breaking the brittle specs.

Computing the fingerprint shouldn't be too expensive, so I am not too concerned about it here.
You can still issue an update command in the rest module, just not on the rhc command.  Telling the user you are deleting a key without asking them is scary.  Just do the update and tell them you are updating the key.
`this._unitSetter` doesn't work.. `this` will point to the global object. Instead you can use the string `'_unitSetter'`.
The DOM barrier is being crossed in later calls, so I chose not to make it browser conditional in case of future fragmentation in the browser spectrum. `disabled` is already a weird, and seemingly underspec'd thing. I'd rather guarantee consistent behavior.
This should be in a separated commit
How did you get the name prerequisite? I think its meaning is the reverse of what it's being used for.
That's fair, i'll update this
This implementation detail should most definitely not leak into user API.
What are valid values for the parameters?
Might want to link to the JDK docs for the settings
I don't see this request in the EC2 documentation.
Note that this is updated.  I did manage to update the commit range, and it shows the new diffs.  Maybe I should target the pull request to agil, though, not develop.
I brought up the improved inspect and to_s because the old ones were breaking again.
I can bring that change forward too (caching trashed cards as new?)  It's pretty self-contained in fetch.
again don't we need to specify the config file explicitly?
'Consumers' should be passed through gettext.
thanks.  (and, btw, I agree that it may be a good idea.  just feels underpondered, and I'm not sure I've got the space to do the needed pondering right now :) )
Do we really need stop and kill method? Seems only kill is called from outside
What is it doing? ;)
no it doesn't, they're still urlencoded after GetField().

FYI the url part of the imageurl is still urlencoded after CURL::Decode(filepath)

eg:
path = image://http%3a%2f%2ffanart.tv%2ffanart%2fmusic%2f66c662b6-6e2f-4930-8610-912e24c63ed1%2falbumcover%2f14010%2fhigh-voltage-4ec1a0bb2a96e.jpg

without this, then the image:// part is urlencoded, and we can't open the file.
will add a parameter to handle subtitle only on OpenDefaultStreams
those tests should apply to SchemaTuple by passing the right schema
it's not immediately clear that this is for X_ flags. also, bCustom is null for X_ flags. it's not used yet, but i imagine it should be set to false when defined, and set to true only if needed.
Кстати, почему ты сама так не сделала? Ведь выше по коду ты так умеешь.
Why handling only Admin or nothing? I think we could have it more generic so we could set roles with other names.
```py
__services__.items()
```
the reason it does not find them is the minimum stability. Libraries should not depend on a so strict version of their deps as it forces their user to use exactly the same version.
fix spacing here and below. if, for, and while constructs and the like should be given plenty of spacing , for example:
```
for ( i = 0; i < RTEMS_MM_ALUT_SIZE; i++ ) {
   ...
}
other layer have `pointer-events:none`, you can add add `pointer-events:auto` to this
Can you indicate that this concerns the server part?  Perhaps also with changed parameters, e.g. CVMFS_TEST_SRVDEBUG or so.  This comment should rather go to test_functions as this is aso very the variabled are defined and used.
Could we use parentheses instead of a back slash?  :-)
$('form') - верне тобі всі форми сторінки
треба указувать ID форми або її клас, щоб точно указать на потрібну форму
A bit more Pythonic perhaps:

    if e.errno in (errno.ENOTEMPTY, errno.ENOENT):
        return
Yes, works for me: https://gist.github.com/3977987


Also `man gcc` has this:

```
       These switches are supported in addition to the above on Solaris 2:

       -pthreads
           Add support for multithreading using the POSIX threads library.
           This option sets flags for both the preprocessor and linker.  This
           option does not affect the thread safety of object code produced
           by the compiler or that of libraries supplied with it.

       -pthread
           This is a synonym for -pthreads.
```
Why not `container_of()`? Also removes the need to `assert(wrap != NULL)`
jaurais pu, mais bon yaurais fallu lajouter apres. meh
"not known to be True"
Fixed with the next push.
Лучше написать полноценный if
why ree? It's considered end of life and is compatible with 1.8.7
I think this should be inside the `if`
I'll add an encoding commit to this PR, and I'll close #7572.
Yeah, suboptimal simplification from more complicated interim state.
What if we figure out if a default is provided?   We can control the default typeclass, so let's give it a real class name and throw an isInstanceOf before mangling?   Either that or we can wrap the typeclass on the way *in* to the hash map if it's an instance of default....

I agree, keeping the mangling is good for the default.
You accidentally scooped up ArrayClass in this case.
It's criterion number 5 from SIP:
```
C may not define equals or hashCode methods.
```

Good question about `##` and `==`. I thought that those are treated specially only for case classes, no?
For better maintainability, this should probably just call the `expm` routine defined above, unless there's a difference that I'm missing.
This indexing notation is a little hard to decipher, could use a comment.
A Dummy() is a dummy variable with a complex value, which has basically nothing to do with the name of an abstract object. The semantic mismatch will cause problems and require hacks. It has actually already done so, see below.
The input formally, is a list of lists.
I removed it -- let GIGO rule.
You should implement rewriting to position space (you'll need sympy.functions.special.polynomials.hermite).
If they aren't xpassing, it's because they are testing a different output than what we get now. Either that or you didn't fix this correctly.
What do you mean here by a oneform?  I suppose it's a differential 1-form. (so the basic 1-forms should indeed be dx, dy) Is there some way to make this more reminiscent of '1-form' (for example, one_form, since one-form and 1_form are not going to work)? This is a very minor issue, though, so if changing it will present a problem you should probably keep it that way.
@qiangxue Yes, it's much better looks here.
No need for changelog line since this fixed change that wasn't in release.
Please follow https://github.com/yiisoft/yii/wiki/Core-framework-code-style
krall wrote a test which verifies all the phases are exercised. Please add your new phase to that test.
c89: variable declarations must be at the top of a scope.
Как этот мусор сюда попал? перед коммитом смотри, что изменилось. Грохни это дело.
Center Map doesn`t exactly describes what this button do. Restore Map State is much closer because this button not just only center the map but also restore zoom and hide opened popUp window
s/then/than/ (my fault.)
I've put everything into a separate async.py file for now. This makes it
easy to import or not import this code.

I intend to restructure files after it works.

Is it necessary that the optimization be in opt.py in the development phase?

On Wed, Sep 12, 2012 at 11:56 AM, nouiz <notifications@github.com> wrote:

> In theano/sandbox/cuda/basic_ops.py:
>
> > +        fail = sub['fail']
> > +        # eventName = "GpuFromHost_%s_event"%inp
> > +
> > +        return """
> > +        cudaEventSynchronize(*PyCObject_AsVoidPtr(%(event)s));
> > +        %(out)s = %(inp)s;
> > +        if(err){
> > +            %(fail)s;
> > +        }
> > +        """ % locals()
> > +
> > +    def c_code_cache_version(self):
> > +        return (1,)
> > +
> > +# TODO Register
> > +@theano.gof.local_optimizer([host_from_gpu, gpu_from_host])
>
> The optimization should be in the cuda/opt.py file.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nouiz/Theano/pull/17/files#r1589204>.
>
>
You should use the second parameter of the `.on` method here:

```
$('#phpbb').on('click', ':not(#notifications_list) #notifications_list:not(#notifications_list_button)', function () {
    $('#notifications_list').hide();
});
```
extension_allowed is only really suitable if you're checking one extension as it calls $cache->obtain_attach_extensions(). It would be quite inefficient to call this function multiple times.
You are keeping e-mail in the first line and using email in the second line. This hunk conflicts with develop which changes to email.

For consistency I would suggest using email in both places.
I'd suggest YES here.
i agree, this approach leads to much cleaner routes.
oops, this was a testing screwup
Let's declare this as `var listTabs` otherwise it'll be in global scope.
I meant the `BeginProcessRequest` method. It's nearly 200 lines of code that could be split into more manageable method chunks with descriptive names
Is this Vishnu's code?
for readability:
```
// Or whatever var names are appropriate...
var isAvailable = record.get('status')===STOCKSTATUS.AVAILABLE;
var isSelected = record.get('drugName')===selectedDrug;
var isNewDrug = Ext.getStore('newIssue').find("batch",record.get('batch'))===-1;

return isAvailable && isSelected && isNewDrug;
```
Inconsistency across the codebase whether we use single or double quotes in messages like this.
I think it'd be better to replace the `str(cube.data)` stuff with:
```python
self.assertEqual(cube.data.data.shape, cube.data.mask.shape)
```
Should just return true -- there's only one order for a single row.
Would this be clearer as "rk -= (xl + 1);"?
As mentioned above got rid of the NOP policy and the associated dead code for validation against it. Thanks.
What is CSVLoader.getFirstIds()? Is it a method specific to this app?
Why '|'?
smart pointers again?
Might be a good idea to include the date of the spec you are referring to. Check my tests for an example.
Testing for stateString saves 1 byte ;)
=> `if (`
As above, the error message could be improved.
After more testing I'll make a new commit
Yes, the camelCasing is done in JavaScript.
I'm actually not really happy about how this works, since it adds an extra value to the query string. It would be neat to figure out what the selected date range was just by looking at it server side, but I thought that would be harder.
>Wouldn't it be most logical to have xcode_version return nil when Xcode is not installed?

The point is to minimize the number of conditions that need to be checked elsewhere. I don't like the idea of having to do this:

```
if MacOS.xcode_version >= "4.3" or MacOS.clt_version >= "4.3"
```

when the compiler builds and other provided software are going to be the same given corresponding releases.
Todo lo relacionado con funciones hash tiene una traducción *literal* complicada. Un ejemplo lo tienes en la [wikipedia] (http://es.wikipedia.org/wiki/Funci%C3%B3n_Hash) donde dicen al principio :
>A las funciones hash (adopción más o menos directa del término inglés hash function) también se les llama funciones picadillo, funciones resumen o funciones de digest (adopción más o menos directa del término inglés equivalente digest function)

Pero en esto caso estoy convencido que no da lugar a equivocaciones. De todas formas, si es un problema, podemos poner otra cosa.
Oops. Tests and code fixed.
We do. This is just from my fast-turnaround testing where the 5 second timeout was just too painful. I've removed all the timeouts that already inherit defaults and bumped the rest up to 5 seconds.
Will modify this to

Return submissions whose title contains the query phrase

Based on discussions of search_reddit_names
hmm ich dachte an

```
$props = array();
foreach($mixed as $name => $val)
{
  $props[$name] = self::callableAsString($val);
}
return get_class($mixed) . '('. implode(',', $props) .')';
```
This is pretty ugly, but having a separate routine here seemed pretty consistent with the other ugly bits of starcheck.  The "if" statement to identify these cases does seem big enough to warrant some of its own code real estate and commenting.
Oh, I forgot about that too! That wasn't even the motivation; I added this so we could let the original exception fly if it was the last step of the loop.
I'm really not happy with having `@Provides` have more attributes.  Aside from the fact that it doesn't read in any way like english, it also starts to really overload Provides with quite dissimilar attributes.  `@Element` is structurally different from `@MapEntry` or `@KeyedElement` or whatever we decide mapbinder will look like.  

As to "accompanies `@Provider`" - I'll fix it, though it's implied.  I agree, it should be explicitly stated.
You should use `ln -sf` instead of `cp -fs`
!annotatedFieldsByParameter.isEmpty() is better. You don't need curly brackets here.
Yeah, it was mostly so i could override it in the polymorphic association and not have to re-write all the setforkey/record logic.  This is because the arguments change
OK - given how unprotected things are in general, I hadn't considered defending the events against hostile or ill-behaved mods as a priority....
Same critique here about the list of arguments: can we pass in an options object?
I agree. Looks like stuff got pushed all over through several iterations of design. I pushed all the functions to the top and grouped the prototype functions below their contractor function.

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 4:55 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +        if (!menuItem.isDivider()) {
> +            menuItem.setCommand(command);
> +        }
> +
> +        return menuItem;
> +    };
> +
> +    /**
> +     * Removes MenuItem
> +     * 
> +     * TODO Question: for convenience should API provide a way to remove related
> +     * keybindings and Command object?
> +     */
> +    function removeMenuItem(id) {
> +        // TODO
> +    }

It feels really weird to have the Menu & MenuItem constructor be up at the top of the file but have their prototype methods assigned down here, with a bunch of other code in between.  It looks like this code only depends on a handful of utility methods like _getHTMLMenuItem().  Could we move just the simple utils up to the top of the file, then have the Menu/MenuItem full declarations (constructor & methods contiguous), followed by the standalone public functions after that?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r879082
Ditto about case-sensitivity
changes in this file can be factored out into a separate pull request to merge to master.
Oops. Restored.
OK, I'll fix this and your other commenting suggestions.
you could move this one on a separate file
check the guided tour to see how is done there with the demo file
IMHO this should be "Newline Mode"
Yeah this whole thing's a little awkward since no matter what at the end of the thing we load the entire file into memory at once to send it over, but I figure it's best to write to a file for the part that takes a long time (creating the file), and then load it quickly at once into memory, which has the same peak memory usage but only for a short amount of time. Also the amount of memory we're talking about could be negligible at this point, and we might eventually need a way to stream files from the server's disk or redis directly to the client without loading it all into memory once it becomes a bigger deal.
The line beginning with :scope => should be 6 spaces indented
Useless comment. (For me IDE tells me this.)
Changed to settings.
Let's remove the model validation from these two fields
change this to `popcornOptions` vs. corn.
Does this mean 'clear'?
pro tip, gitignore files can handle glob syntax (and regexes, too). so ``*.sw[nop]`` should work, if you like.
Any reason why you think this is better? I've actually always seen it written as either `variable++` or `++variable`. I've also been using `variable++` in other commits, so perhaps it's better to keep it consistent.
Let's register this with the same identifier as the resource url which is RESOURCE_NAME in bootstrap.js
Firebug Aufruf..
Does this mean that depending on my API setting, some tests will be skipped?

I'd prefer to have all tests run, independent on the settings. How about using `override_settings` to change the settings environment for a test class / single test, like I did with opensearch? https://github.com/willkg/richard/blob/master/richard/videos/tests/test_views.py#L277

```
@override_settings(API=False)
def test_api_disabled(self):
    """Test that disabled api kicks up 404"""
    ...

@override_settings(API=True)
    """Test that a video can be retrieved."""
    ...
```

Hm, we might have a problem with the URL configuration then, but I'd really would prefer it this way.
Why does this take a Maybe Int if it's going to call fromJust on it?
Disagree this is a bug, at most it's a missing feature.
but shouldn't the API call still return the system object as JSON which I would imagine the should is for?
The difference between these two was slightly confusing to me.  History returns all and history_tasks only one job?  Maybe follow the info/list paradigm and do 'history_list' and 'history_info' to denote the plural versus singular case?
why do we no longer need the label here?
I think so... especially given no other comments/javadocs in this file do that.
The url bar stays until the page has loaded and the title is updated then, without that there is barely any time at all to see what url is loaded and its a bit busy visually with stuff changing all over the place, I would prefer to keep this behaviour
4 can be a property of the object, so it will live next to the other customization bits.
This can probably be removed, since astropy only supports >= Python 2.6 anyway.
Use `io_lib:format/2` here, it'll be less confusing.
just remove that sentence i guess
This part is not in the master anymore:
https://github.com/bitcoin/bitcoin/blob/master/src/qt/forms/overviewpage.ui
um, it's a deferred comment?
`os.path.join` ;-)
you could actually move this to an inner private static class (or anonymous) in the config module that uses it.  this is very small and not worth calling out.
do you happen to have json with this in it?  sorry if i missed it.
If you want full documentation too, missing @param.
Thanks for noting it down :+1: , I have added the amendments now.
Please undo this. The CMake artifacts only add noise.
Let's move the comments next to the values then. I think it's the right thing to do, I'll fix the parser if it breaks.
If you want to code this defensively and also slightly more efficiently (since you don't care about the actual string length, just that it is greater than zero), you could write:

```c
if (!remote_name || !*remote_name || !merge_name || !*merge_name) {
```
Actually, this is really an accident. I'm sure I fixed this because it was wrapping in my editor and saved it without thinking, but I would generally never include a change just to alter indentation. Sorry!
Something like assertFalse(task.getTrace().getRelated().isEmpty()) might be slightly more expressive of the intent.
I've asked to change the URL to `firefox/facebookmessengertab`, may have to change.
Hm, what is that for?
docstring seems out of date
`except OSError`
inadvertent - I'll roll in the deletion with other changes from comments on this PR
This is output from MDN, so it's strange they allow the <span/> tags.  I guess I'll remove them though.  

I have tests that substitute in scripts tags.  Is it better practice to put things like that in fixtures?
?  Isn't this always true?
I think it is about the expansion of the values and the data-type size ? so if I pass a short to the "long" method, will it return the same results regardless (negative, zero, large-positive).
I extract the last namespace e.g   "Company\Project\Bundle"  gives  "Bundle"
I agree with the use of 'entry_points'.
May be better choice will be used 'entry_points' param for automate generating script for any system?
See as a https://github.com/perone/stallion/pull/26/files#diff-2
Also, a HashSet basically randomizes the order your blocks are going to be set in, which *might* slow things down.
Need `@since` (also on other new constructor).
You are asserting twice the same in line 783 and 784...
are you sure you don't have to do a `$this->updateStatus();` here ?
Cache slow process cmds, think it's worth it.
@stof i think it's a good point, cuz we anyway have lead maintainers for components (me for this component and @Dattaya for `inotify` part), that should be contacted in case of anything. I think it'll be quite easier to state active contributor on packagist/composer.json instead of throwing everyone to @fabpot, IMO :)
I agree, hence my comment, but you beat me to it ;)
`Ask` should be `Asks` and there is a missing dot at the end of the line.
Here you use `array_map` + merge of additional array, few lines above you don't check that. IMO you could add small `private` method which could cover both cases.
typo: expected to be
Maybe use `sprintf` here.
DRY じゃない
というかこの describe 節の前提 'with invalid params' を表現するコードが事実上このコードなんだから describe 節の中で共通なものとして書かれるのが自然ではないでしょうか。
I made a new fork and new commit to start things clean, so by mistake I copied that. Got it fixed.
I added this because when I set foldmethod=syntax, I only want the SIG to be folded. But looking at examples like perl.vim, there's very little "nofold" but I didn't want to break compat, unless we don't consider that a major issue for ps1.vim (it could easily be fixed in anyone's .vimrc).
srs is not a keyword then?
I don't like the overloading of the meaning of `_cached_path`. It'd be much more obvious if split into the two logical components: `_allow_path_caching` and `_cached_path`.
no way bad idea
The problem is that it needs to be in JS so the dimensions can be corrected
once the video has loaded on the client machine...

Sent from my Swiss Army Phone
On Dec 29, 2012 7:32 PM, "Bharat Mediratta" <notifications@github.com>
wrote:

> In modules/gallery/views/movieplayer.html.php:
>
> > -    {
> > -      src: "<?= url::abs_file("lib/flowplayer.swf") ?>",
> > -      wmode: "transparent",
> > -      provider: "pseudostreaming"
> > -    },
> > -    {
> > -      clip: {
> > -        scaling: 'fit'
> > -      },
> > -      plugins: {
> > -        pseudostreaming: {
> > -          url: "<?= url::abs_file("lib/flowplayer.pseudostreaming-byterange.swf") ?>"
> > +  var id = "<?= $attrs["id"] ?>";
> > +  var max_size = <?= $max_size ?>;
> > +  // set the size of the movie html anchor, taking into account max_size and height of control bar
> > +  function set_movie_size(width, height) {
>
> This is very similar to Item_Model::scale_dimensions in that it's
> preserving the aspect ratio - can we combine the two? I hate having
> functions like this in a template, we should pull it out into a common
> helper.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gallery/gallery3/pull/82/files#r2520327>.
>
>
How much data does the free cache store?  What happens when it fills up?  10 minutes is not very long...but we don't want to run out of storage.
This a published API that other projects may have subclassed. We cannot change the method signature.
It looks like this should be volatile?
Can't, as `$(window).offset()` returns `null`. Any thoughts? Otherwise I think I've addressed everything from this latest review.
I'd remove the testHelper for these tests and just call the code inline.
Remove this unused function.

Also this function is useless dont you think?
The comment seems to represent an old state of the API.
Nice comment since it made me think and check the behavior in those cases :-) In fact, I just check that in both cases (no navigator.mozSettings or onerror) nothing should be done and the dark gray background color would be shown. Are you fine with my explanation? :-)
The same applies here. Please use `/shared/style/`
use this._telephony
On 04/07/2012 17:47, Cristian Rodriguez wrote:
>> -  drop: function(origin, target, dir) {
>> -    var icons = this.icons;
>> -    var onode = icons[origin].container;
>> -    var tnode = icons[target].container;
>> -    if (dir > 0) {
>> -      // upwards
>> -      tnode = tnode.nextSibling;
>> +  drop: function(origin, target) {
>> +    if (origin !== target) {
>> +      this.setReady(false);
>> +
>> +      var icons = this.icons;
>> +      var onode = icons[origin].container;
>> +      var tnode = icons[target].container;
>> +
>> +      var childNodes = this.olist.childNodes;
> Currently we don't care about text node but in the future? I guess the answer is yes too. What is the advantage using children instead of childnodes? An yes there aren't text nodes between <li> so we could use children in theory

I don't think we will care about textnode in the future for this method 
but there is not much value of switching from childNodes to children. I 
have just found that useful by the past to avoid beeing broke by a 
comment inserted into the dom hierarchy for example. But I don't really 
care for this case :)
`AlarmEditView.load();`

and in the `load` function check for passed alarm object and `if (!alarm) alarm = this.getDefaultAlarm();`
the comment is a bit old, may we can say that invokes when an import or update is launched
This doesn't need to be called, FileSystemStorage._save should take care of actually saving the file.
I like the first approach better.  There are lots of cukes out there already that start with a previously recorded cassette, and using that here is fine.
toned down cycleway, which Victor said was too high compared to other tracks/paths. And it was really routing me on weird ways to keep me on a cycleway before.
Cool. I didn't know that! :)
I think it'd be more intention revealing to use the symbols (e.g. `:green`) here rather than the numbers.
最後の ": " は消した方がいい？
Use error_logger:info_msg
no need to specialize on Byte. Java keeps maps of these, so the cost to go to/from primitive is low. It's the larger space ones that are issues (Int/Long/Float/Double).

Specialization bloats the generated code, so I would remove the Byte specialization (in this and the rest).
If the type of T is not (K,V), then at compile time, this will fail.  It uses implicits to do a compile time check that one type is equivalent to another.  If T is not (K,V), we can't automatically group.  We cast because it is safe to do so, and we need to convert to K,V, but the ev is not needed for the cast.  In fact, you can do the cast with ev(t) and it will return it as (K,V), but the problem is, (as I comment) ev is not serializable.  So we do the cast, which due to ev being present, will always pass.

I'll add this comment, but it is really more documentation on the scala =:= object (used in the collections API).
Hmmmmm crazy, mine pass every time lol Did the test get merged and not the fix? Cause that sounds like the error that would happen in that scenario.
not all systems use `lib` that's why there was  `\find "${path}" -name "libyaml.${extension}" | GREP_OPTIONS="" \grep '.*' >/dev/null`
Why say that when we do it for them anyway?
I think this should be moved to `_initElements` (inherited by `Path.VML`) or copied in `Path.VML.js` `_initPath` too to make it work in IE (VML also supports CSS styling as far as I remember).
You mean that the fix must be done inside function "pi_util_set_node_title", right?
This should be a configuration constant pulled from settings.
This is the only test of the copy behavior, so we don't want to get rid of this test.
+1 for Coffeescript's [existential operator](http://coffeescript.org/#operators) `?` for checking `undefined` or `null`.  Quote:
>It's a little difficult to check for the existence of a variable in JavaScript. `if (variable)` ... comes close, but fails for zero, the empty string, and false. CoffeeScript's existential operator `?` returns true unless a variable is **null** or **undefined**, which makes it analogous to Ruby's `nil?`

>It can also be used for safer conditional assignment than `||=` provides, for cases where you may be handling numbers or strings.
Ah, I was thinking a base64 string would be neater to transit messy error message strings, stack traces etc.

I'll just stick with encodeURI
`resolution`/`rejection` are similar to `resolve`/`reject` except that first one return low level promises wheres the second one returns high level ones. All of them return promises. A promise is something that has a `then` method that expects two functions as arguments.

I consider all these names as being misleading and unhelpfull. I dislike overusage of single word names everywhere.
So I'm saying that current names are okish, so that you can feel free to ignore this and keep them as-is. It is close to a nit as it is just to improve code readability/reviewability. But in case you find it relevant I'm suggesting to rename all of them with two words pattern, similar to this:

`resolve`/`reject` => `resolvedPromise`/`rejectedPromise`
`resolution`/`rejection` = > `resolvedFakePromise`/`rejectedFakePromise`
No matter what we do, it means that component won't be able to have attributes with such name. It won't change much to avoid copying them. 
If the nsISomething interface you want to implement use such name you will have to use and pass a `Component` attribute and that's ok.
But in Protocol case, if you decide in a sub class of Protocol to use such attribute name, you are going to have unexpected behavior. A user of Protocol API should not have to know that something internal to XPCOM module prevent their protocol class to use `id` as attribute.

At the end I have a mixed feeling. In any case you can use a `Component` attribute and have a determinist behavior,
but if we allow omitting it and merge with Service/Factory options, it may lead to unexpected / hard to undertstand issues.

Can't we delay this discussion to protocol implementation?
Could you just use `function preferenceChange(...` instead.
We should integrate i18n-abide with browserid.

Now that I"m looking, this was already a feature of that module
https://github.com/mozilla/i18n-abide/blob/master/bin/extract_po.sh#L11

Moving away from node-gettext is new and we should do it systematically in i18n-abide so all Node based projects get that update.
Hawt.
no need to nest this, you can just do ``else if``.
I personally find it cleaner to increment things on a separate line, but at least wrap this in parenthesis so it's clear what's up.

Also, why not `foo++`?
Pretty much all JS, including some of the Mozilla JS I've worked on and _most_ node.js and CoffeeScript, is 2 spaces for indentation. Tabs are pretty much hated by everyone who isn't working on the Linux kernel nowadays.
Please use better names for those constants so it's easier later in the code what we are referring to.
Do we need to bother to make this accept some... other config object? If they want to use this object, they should have a `Muddle.configure` block somewhere, no? Then we can just hard-code `Muddle.config` some place in this object.
Actually, I think we should just delete the entire else: condition. If there are any files other than .sql or .py just ignore them.

Can you just delete lines 138-140 and undo the whitespace changes?  Much appreciated!
Is this line meant to be commented out...?
@cloudhead: Was not aware of that. How much effort would it be to go over the codebase and handle those? I see a lot of potencial for failure modes on these premises, furthermore with the increased network complexity between bazooka components once we're running on more than one datacenter.
there's a grammatical mistake ..as **and** "inline"..
The `!!` is unnecessary here because `this.options.pills` is already a Boolean. And even if it wasn't, you only need to check truthy or falsey here anyway.
You are right, it should be an internal "dirty" flag, but the UI treats the data as if it owned everything - for another example see below Host::Clear(); (formerly Host::hosts=$[];). That will be a topic of some future refactoring step.
I don't know if @weierophinney could refresh us which is the correct namespace for place the classes
You need to test all possible types here -- array(), '', 0, 0.0, false, and null would all have passed before. Test those values as well, and if it still passes, you're good. :)
These should be skipped until zen-26 is complete (Paddy's Feed spring cleaning)
Does PtDebugPrint ever throw a UnicodeEncodeError? If so, that sounds broken...
mode should be event.getMode()
This has been renamed to Zend\Stdlib\AbstractOptions
No space between the ( )
Delete all these lines, and replace with just @unknown_value
Who not `$form->isValid()` ?
Please keep the empty lines added for readability
Why? It's just an extra function call.
raiseException
get rid of this empty line, it might screw up the generated documentation
Removed also duplicated (now) check from generic resource owners.
Do these functions need to be attached to `self`? You're already in a private function scope.
Sorry, I'm missing where you do a JNDI lookup?
bon, je suis sympa, je fais en sorte que gardien vous envoie des valeurs par défaut. Parce-que oui, il aurait pu vous envoyer des "null" et là, ça aurait fait boom!
Why is this needed? Are localhost urls considered invalid by the validator?
Have you manually verified that the Persona login dialog links to these property? The [navigator.id.request](https://developer.mozilla.org/en-US/docs/DOM/navigator.id.request) docs seem a bit unclear on this, since their examples use URLs relative to the site root (e.g. `/tou.html`) but the docs say they need to be Absolute URLs, which i usually think of as containing the whole shebang (protocol, domain name, etc).
Move this into the test definition
yeah. will update that.
finis?
omniauth ってこういうののテストを簡単に書く類のものないんだっけ。
とりあえず spec 要追加
when params[:host_id] is an invalid value (but not blank) this will generate the wrong query where.
```
SELECT MAX("reports"."id") AS max_id FROM "reports" WHERE "reports"."host_id" IS NULL
@ohadlevy yep, shall I submit them there too?
@lzap should we wait for them? (just to avoid the issue with packages etc)
This seems fine as a first version. Later we should also add support for changing files when a new Slot is started. New Slots can be started when the old one reaches a certain file size, or the clock turns a full hour.

But for now this seems ok.
Later on, we'll want to limit this and order it, but this will work for now.
What do we want to use the `json` for in this action and those below?
I'm thinking maybe these should either go directly into the .module file or into maybe a utilities file that we can just include. I also like keeping the module file clean, although the occasional function that gets called everywhere makes sense to be in the module file as well I think. 

How often are the functions in the globals.inc file used? Could we pull a couple into the module file and put the rest into a util function?
are there plans yet for an add_psf function for completeness studies?

new_image = add_psf(data,  psf, [list of coordinates] or "random" with a number specification, mag="random" - or maybe min,max,delta)
Don't use a hardcoded label, please use a code:

_('ID_ACTIVE')
This method signature is likely to change in the future, accepting a connection, connectionId or a ShutdownConnectionParameters. However, it's not the goal of this pull request to fix that, but only to provide current functionality from a java Interface.
длинновато и копируется. нужно сохранять ссылки.
Yes I see it's an action chain thing. I can replicate it locally. It depends on the position of the mouse  cursor over the page.
Then again, multiple return points from a function don't really enhance things either, but could be considered here.
I wanted to do this, but wasn't sure *where* to direct people. Do either of you have a recommendation?
Ah okay - in the screenshot the spacing looks a bit out :s
Should be principalIds
That would mean we wouldn't be able to use the createColumnFamily/dropColumnFamily anywhere else.
If we stick a note in the jsdoc it might suffice?
Is the plan, for structured content like sakaidocs to have a uri that refers to internally managed functionality such as a sakaidoc API?
I'd probably make the function 'isGlobalServer', should be easier to read.
Doesn't '' evaluate to false, and so the result would never be an empty string? Should have explicitly validated at node terminal. Will double check and change if necessary.
I see. I'm removing the call to the logger.
This flag is pushed through a lot of code just to indicate that the auto-detected charset should be overridden. Why not include the charset in the conf/encoding file and simply use it here as value of ev.default_charset? Currently your solution works only for polish services (note: hardcoded iso8859-2 in dvb_support.c). If you move the charset value to config file it would be way more flexible.
I have just fix that
I am fixing this here. https://github.com/vinothchandar/voldemort/compare/client-conn-cleanup . There was a subtle time out race.
Nope because I switched to using dictionaries so we could have keyed campaign objects. You can't sort dictionaries in python.
Just country? Can also be the result of search, nearby, whatever :)