labofsahil/github-event-dataset-2012 huggingface dataset:
Die 3 Hooks verstehe ich nicht. Sollten das nicht die Zeilen weiter oben außerhalb der Klasse erledigen?

```php
<?php
if ( function_exists( 'add_filter' ) ) {
	// Activation and Deactivation is needed for Version checks
	register_activation_hook( __FILE__,   array( 'Inpsyde_User_Level_Management', 'plugin_activation' ) );
	register_deactivation_hook( __FILE__, array( 'Inpsyde_User_Level_Management', 'plugin_deactivation' ) );
	register_uninstall_hook( __FILE__,    array( 'Inpsyde_User_Level_Management', 'plugin_uninstall' ) );
	/* ... */
}
```
I like it, except it's going to search the load path for files every time the filter runs for every file. It would probably be better to cache the `additional_file_paths` and override `generate_rake_tasks` to recalculate them, so it only happens once per run. @wycats thoughts?
This should be 2.11.2 because you use gui_message
nice, I also found this bug earlier
Note: this was different to the other default (on the config-editing form) so one can tell where the default came from. I suppose it was useful for debugging but not essential otherwise.
What is this comment for? Isn't it quite obvious by the code? Can't we use docstrings?
wops.. I don't know why I put 0x885B4, I'm in front of the dump and it's really 0x885B1 :P

Thanks @Chameleo
Content negotiation is useful for requests made from the Javascript in your pages (and the headers can be trusted since you control them), I've added a README with this explanation - see 4802b6e35f339bf0eb890bc1c4d0638b7eecade9
I'd probably use  !name_specified.nil? && !group_id_specified.nil?  as your check here. Above you went to the trouble to make sure that at least one is set, but this conditional allows for a potential nil value to to passed as GroupId if GroupName is set and GroupId is a key but is nil.
Right makes sense. I have moved internet services and node services into separate entities to meet the fog patterns
Can we simplify this loop such that:

- `OAuthProvider overrides equals()`. Does this make sense? 
- `listProviders.contains()` will effectively loop through and invoke equals
Should we validate that size is an int here?
We should have titles for interlang links in footer and those titles are removed here
Use `textwrap.dedent()` for this.
The same question as below. I don't have enough context, so I assume it is the right thing, but please confirm :)
ouch, indeed. You’re right of course.
noooooo. NonFatal
Get rid of the curly braces and the unnecessary type annotation:

```
this(context => None)
```
I think you can replace it with:

    registerRoutees(paths.view.map(context.actorFor))
so decay = -1 == boom?
that was also changed for failed remote sends
Realized it was in a test. Would be nice if things in /test/ were sort of colored differently from /main/
Why the tick? Rate limiting?
if you lock before setting exitFlag, you then exitFlag doesn't need to be atomic, and the correctness of the use of exitFlag is easier to see
Fixed when  build some tests for ObjectContent
This one not so easy.  The function is needed.  Should it maybe be in another place?  In model/permission.rb maybe?
I did checkout your branch and make the change myself. I just made the change on a new branch and alerted you of the change with PR. This extra permissioning system prevents merge conflicts pretty well.

I would be fine switching if it accelerates development. I remember when I first started with git it took a lot of time to learn. I believe that to switch from your method to my method you need to learn how to use remotes and pull requests effectively. Once you do I believe that it's much safer/simpler. I think this falls into the hard but simple category.
I"m not actually sure that this is the case. I remember MTurk was returning the content of Question as escape XML(I have no idea why). Can you confirm that this is still the case?
Doesn't hugely matter, take what .NET does
I think we need to distinguish between var(noise-sample) and var(noise-distribution). These two will be very close for a large noise-sample, but at the end of the day, var(noise-sample) is only an estimate of var(noise-distribution) and when noise-sample is small, it's a pretty bad estimate. I believe is usually defined as `SNR = mean(signal) / sqrt(var(noise-distribution))`. We can either hard code the analytical form for var(rice-distribution) for use scipy.stats either should work.

Bago
you can use `refute` here instead of `assert !`. Would also prefer doing that all on one line `refute grant.expired?`.
I just wanted to make sure we went into the else case in the code, which is why it returns None. Which I'm assuming you figured out ;)
This and the above are not run through gettext.
[missing semi-colon](http://siq.github.com/front-end-development-guidelines/#requirement-21)
aren't we leaking now?
This one changes behaviour ( < has higher precedence than = )

@Memphiz ?
docstring я имею ввиду для модуля. """asfasdfasdf""""
If some AMD engine is running it will enter there
This test might fail if a weight got initialized to zero. Please rather set the weights to a value outside the initialization range before the reaction strategy is performed. Then test that they fall within the correct range here.
And that's why I stopped using loose comparison... forget I said anything :)
strong instead of retain, please
This method should return the `TUIViewController` that was popped. (According to iOS API parity, as well as being a good idea...)
Similar to the above comment: these lines should be aligned with something from the previous line - ideally the open bracket but failing that you could use the equals.
What, why this madness? Why not just unset?
Maybe I'm just being slow this morning, but I don't understand what this last assert is checking for. A comment might be useful.
I guess? It wouldn't make me wail and gnash my teeth, but I have a general preference for not hanging extra bells and doohickeys on what's fundamentally a pretty simple and low-level interface.
Of course, it couldn't *hurt* to use abspath in the logging files.  I can make that change if we'd like.
просто add() не покатит. переименовать во что-нибудь типа loadProject()
Вообще мне тут ещё перевод для mainWindow надо бы добавить
if am quite used to short-circuiting (like if-return without else) but it does seem more readable
@fxn could you take a look at this?
If primary_key is not integer, start.to_i changes itself into 0.
I think the test could be `test_counter_cache_with_inverse_of`, wdyt?
Yeah. This whole commit is pretty lazy. There are a ton of edge-case issues including slugifier ones. Other places where we generate slugs, we don't pass through a slugifier, so ... probably best to fix them all.
And I guess it should be there, just put it before you match on tree.
we probably don't have a choice at this point, so I'll add a TODO to update the spec
Another option: don't integrate `Hash` into the type class hierarchy, but just add the `areEqual` method to it directly.
The problem that I see with putting "internal" in the name is that some of the `Throwable`s that are ruled out are not necessarily internal, for example, `InterruptedException` or `OutOfMemoryError` (like other `VirtualMachineError`s). I don't have an idea for a better name, though. Maybe just keep `NonFatal`?
You got me. That works and is trivially more wasteful.
``from _spectral import lombscargle``.
Should be "and aspect (and thermal)"
what if one of the conditions contained a non-commutative elemenet?
I think (but would have to double check the docstring) that None means there is no solution. But NotImplemented is possible:

```

>>> solve(exp(x)-cos(x))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "sympy/solvers/solvers.py", line 780, in solve
    solution = _solve(f[0], *symbols, **flags)
  File "sympy/solvers/solvers.py", line 1206, in _solve
    result = _tsolve(f_num, symbol, **flags)
  File "sympy/solvers/solvers.py", line 1957, in _tsolve
    return _solve(rewrite - rhs, sym)
  File "sympy/solvers/solvers.py", line 1212, in _solve
    "\nNo algorithms are implemented to solve equation %s" % f)
NotImplementedError: multiple generators [exp(I*x), exp(x)]
No algorithms are implemented to solve equation exp(I*x)
```
Ah. Well "monomial order" and "product order" are very standard terminology.
This definitely is a PEP8 violation. I'll be pretty reticent to change it. 

I proudly align `=` signs in my code. I think it makes the code substantially easier to read in places. It clarifies structure and reduces reader work.

Getting me to change would probably start a lengthy e-mail discussion :) I've been considering an anti-PEP8 blogpost actually.
Why delete statement then and not `SELECT LIMIT 1` for example?
Are you using TABs?
Would an enum be an improvement here?
why this ? there is no reason to have ``.htaccess`` and ``index.php`` in the Silex repo
Would you like to receive all mails?
Is the indentation correct here?
I see that now. I thought you were removing it completely. Making it
internal only is fine.

On 25/05/2012, at 18:20, Ben Hood
<reply@reply.github.com>
wrote:

>> @@ -102,11 +96,6 @@ trait DomainDifferenceStore {
>>   def lastRecordedVersion(pair:DiffaPairRef) : Option[Long]
>>
>>   /**
>> -   * Removes the entry for the latest correlation store that was recorded with the diffs store.
>> -   */
>> -  def removeLatestRecordedVersion(pair:DiffaPairRef)
>> -
>> -  /**
>
> I was under the impression that the only callers to this method would be internal, i.e. it gets called within the scope of `removeDomain` and `removePair`. The intention of this is cleanup is to prevent any dangling checkpoints arising.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/166/files#r880243
I don't know. But I was confused about what cursors were when I first learned of them in August, and the minute I saw the phrase "cursor object" in the wiki I understood perfectly, so I want to continue to use it in this tutorial.
change to look for ul.errorlist li a[href="#id_slug"] instead of the (English) error message
Yea, fo sho. Just wanted to get it working locally first.
there should be two empty lines between two classes.
All properties should have access control specifiers (private/public).
@nickvergessen It would make more sense to use an index.php event as it doesn't need to be loaded on every page. I think we added one to index.php?
Maybe use array_keys once to get another array and then use isset in the loop and for $config['newest_user_id'] below.
Docblock? I have no idea what this function does.
No. I get one with the basename = 'ucp_pm' and then I update it's parent's basename to 'ucp_pm', if the one I got is not a category.
why would we want to make it more complicated?
Great idea. Fixed in 287e8a7
Why not `Activity.objects.filter(action='seen', user_from=player).aggregate(date=Min('timestamp'))`, or something alike. Use database.
imho gets should be changed to returns. also rotatable object I suggest.
Also I tend to avoid echos, they're longer than doing ```?><th>Bonds</th><?php``` and you lose the advantage of html syntax highlighting/checking in echos (if you have an editor capable of such)
Is there a reason this function isn't in the common utils.js file?
Отступы, пробел после  ),
I think it would be much better to use a library to deal with JSON. For example:

http://code.google.com/p/google-gson/
No but I use `browserify-server --bundle` which makes requiring html files work
Umm, there's plenty in there that don't :P
This works fine for an url like src/screener/ but eventually we will have src/screener/#somepageinscreener

Instead of splitting by /, check to see whether the url contains the topbar field value as a substring.
Not sure, but it's wrong. The config stuff is unused until we have a discussion over exposing sticky data for commands. Then it will either be tested or dropped. I did fix this one thing. Thanks.
put this in clean_serial_numbers on the form
What happens if an insert comes in between flush_buffer/1 and snapshot/1?
`node = (this['create-' + tech + '-optimizer-node'] || this.createDefaultOptimizerNode)(ctx, sourceNode, tech);`
What is job adds ?
I think you wanted :trollface: but I might be wrong :wink:
There's possibly some missing subtlety here. If an invalid POST is made to this view, `object` will not be in the context. We need to actually implement this little test app somewhere in order to ensure all of our example code behaves as predicted.
note that we are using spaces
In the pull request I have done, I have a module (core.py) that imports the post-processing logic (post_process.py) and the data layer module (models.py). I preferred to not have the post-processing and the data-access coupled.

Maybe, I am getting you wrong, but the tone of the questions suggest me that you want a flame. If it is not the case, please continue this discussion on the devops mailing list. The contribution of other member of the staff could be useful.
Agreed. I think the default lengths are low but acceptable for Locale. While moving these methods, I'll stop using the default in calls from this class.
Giving credit is great, but I am unsure if linking to Jeff's django branch makes a lot of sense in this context.
How is it worth than "jQuery.getScriptSync is not defined"?
This line code is used to get the support count for an itemset.
In any case, I think madpack needs to be rewritten. We should reword [MADLIB-264](http://jira.madlib.net/browse/MADLIB-264) accordingly.
That comment is not immediately clear to me.
Is this the only error that can be thrown? How should other errors be handled, caught, sent to the client and re-thrown or something else? What about the danger of information leakage via error messages / tracebacks?
Bare excepts are really bad in almost all cases. Amongst other things, they catch KeyboardInterrupt, SystemExit, runtime errors (like memroy) and other exceptions that you really don't want to be catching here.

You should catch the specific exceptions that you need to catch. Namely anything that datetime.strptime is throwing for bad input.
Where did you get these icons?  (Are we legally allowed to use them?)
Yes, I just meant that this part of the if statement is now calling the `xcrun` binary directly, rather than the `locate` method as it did in the past.
ok cleaned up and resent https://github.com/mxcl/homebrew/pull/14332
Looks like there is some old code lying here.
Debug donc a supprimer
Needs some thought.

### Option 1: Java just passes extra parameter

I guess the default situation is that it's the same as the existing calls in Akka 2.0 that need a dispatcher, like:

    Futures.successful(4, system.dispatcher());

So the solution space should be the same as it is for that. With this patch you wouldn't have to provide `system.dispatcher()` creating a Promise anymore but you would for `onComplete()`, etc. Typing `, system.dispatcher()` isn't _that_ horrible given all the crap you already have to type to write an anonymous callback class in Java, but maybe we can do better.

### Option 2: Differently-named version of each method using a default EC

From the Java perspective, there's no reason you couldn't have an overload with and without the executor, using a default executor for the one without. But of course that breaks Scala since the overloads would be distinguishable in bytecode but not in Scala source.

Simple if not 100% pretty solution: name the overloads different things,

    onFailure(callback, executor)
    onFailureDefaultExecutor(callback) // brainstorm better name

On the crazier side, maybe there's some language extension that would let us add an overload to the class file that Java would see and Scala would ignore; it looks like right now the generated class file from `onFailure(callback)(executor)` has an `onFailure(callback, executor)` with one combined parameter list. From Java we'd like to add plain `onFailure(callback)`, but hide that from Scala. I can imagine some language feature to allow that, like `@javaOnly` or something. But clearly not a short-term solution.

### Option 3: withDefaultExecutor()

Another possible option, just to expand the possibilities, might be to add:

    // Future with an ExecutionContext associated with callbacks you add to it,
    // intended for use from Java; not needed in Scala
    trait FutureWithExecutor[T] {
        def future: Future[T]
        def onComplete(callback: Either[Throwable, T] => U): this.type
    }

    // existing Future trait gets new methods
    trait Future[T] {
       def withExecutor(executor: ExecutionContext): FutureWithExecutor[T]
       def withDefaultExecutor: FutureWithExecutor[T]
    }

So the idea would be that your Java code is like:

    future.withDefaultExecutor().map(...).onComplete(...).future()
   
Where `...` expands to the Java anonymous callback class.

I kind of like this solution since it avoids adding a lot of methods to Future itself that don't make sense in Scala, and it's more DRY in Java. 

It does allow Java programmers to shoot themselves in the foot in the way this patch is intended to fix, if they start passing `FutureWithExecutor` across module boundaries instead of passing `Future` around, but they'll hopefully not do that. Anyway anytime they go through scala.concurrent or Akka APIs they'd have to convert back to regular `Future`.

Maybe we can think of more options, these are what I thought of so far.
Sent is still being updated https://github.com/praekelt/vumi/pull/393/files#L1R121
RedirectAgent is imported but not used.  Perhaps the examples directory should also be linted?
@daniel-uzunu: *by calling* **a** *web service*
Shouldn't it be called `set_crumb_levels` or `crumb_levels=` ?
I actually implemented this with a finally, but then I realized it wasn't the case in the rest of Dagger code so I kept it this way for consistency.
Hey guys, just a heads up - a puush isn't guaranteed to always be an image.

In cases where it's not an image, this results in webkit rendering a dead image... after downloading the (potentially large) file.
What should happen if a class has both annotated fields, and a multi-parameter constructor?
Why is this option called internal? Because it's only for use by the framework? In that case, name it something descriptive and just prefix it with an _. Otherwise I have no idea what the option does...
Grr. Visual studio likes to do that sometimes when files are removed from a project. It's in the last commit, I'll fix it real quick.
isEnabledFn is a guard for asynchronous cases where SetEnabled() may be called by some function but may have not executed before the commandFn and the logic expects it to. isEnabledFn calls during command execution to allow clients to verify at the time of execution that the command is indeed enabled. 

It does make me think isEnabledFn should return a deferred where the command executes when the promise resolved. Consecutive commands could then execute out of order though. What are you thoughts?

-----Original Message-----
From: Jason San Jose [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 1:34 PM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> +                return (new $.Deferred()).reject().promise();
> +            }
> +
> +            var result = this._commandFn.apply(this, arguments);
> +            if (!result) {
> +                return (new $.Deferred()).resolve().promise();
> +            } else {
> +                return result;
> +            }
> +        } else {
> +            return (new $.Deferred()).reject().promise();
> +        }
> +    };
> +
> +    /** @return {bollean} */
> +    Command.prototype.getEnabled = function () {

You have get/setEnabled as well as _isEnabledFn. Is that intentional? How would they be used together?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r870943
Should use double quotes here.
Fixed everywhere I used the underscores.
Can we rename this module? Proxy seems a bit generic and doesn't tell me a whole lot. :) What about BracketsShellProxy? A short comment here to explain how ``app`` and ``fs`` are used and proxied here would also help.
What's the case that should use line comments instead of a block comment? I couldn't find any way to do this.
The call to fix_scroll() is disabled for hovering, and this code seemed to break fix_scroll() for selection, so I backed out this change.
Nit: we can move this line down to the bottom of the function, since 'result' is not used before then
see my note above. Theres probably a more elegant way to do defaults. I was trying to keep the pattern similar to what you had started.
long name...
Is an optimization to find out which of these functions applies? Why check if mozRequestAnimationFrame is right every time?
Ideally I'd think there'd be a separate helper per concern, you know, kind of like Rails? *wink wink nudge nudge*
something about doing %s on a dict and using it for a key makes me feel icky
```coffee
for key, direction in {d: 'right'}
  if @keyboard.keys[key]
Why moving into cc.common?
Shouldn't everything be under the mrlda.cc package hierarchy?
We don't own common.cc, so it's bad practice to put there...
This method is used get the value of the password field and it is used twice(as i've seen in the tests)
Once for the filed when you create your password and once for when you log in.
If I remove the logic from this method i will have more methods which basically do the same thing, and for which only the locator differs.
can we change this to be type as well?
I'm wrong, nameSuffix is also shared.  I'll do this for namePrefix and nameSuffix, yes.
It's good form to filter out unwanted bits of the prototype.

As for the coercion, I don't think it's necessary, but when checking for object existence, it can't hurt.
Again! An unnecessary & wrong change.
Tengine can fork the number of processes the same as the your total CPU cores, don't specify the hard code here.
Module -> module
`aria-labelled-by`?
I figured since app_config was setting this at init time that this was a good place for it. It seems to be the same kind of logic thats in ".katello?"
@Baachi thx.
Go ahead and clean up the to-do's in here first
Sadly we can not really rely on this input for now...

I don't know how we can make this more usable easily, maybe @pivanov has some ideas :)
That's what I was thinking originally, but then makeRecord isn't a private method, so if it is called directly, the number of levels to go back to find the module calling the logger has to be different. However, if we agree that we should not call makeRecord directly, then I can indeed change it.
Where is `bool fRestartWarningDisplayed_Proxy`?
Indeed, I forgot to remove it while reverting the getTransactionFee() change, thanks for noticing!
I think 1.5.0 is not the same thing as 1.50.0.
dont pass objects at all, no matter if its CakeResponse or something else, it will blow up when calling send()
the api clearly states $content should be string.

This only "fixes" wrong usage, and just partially
just saying :)
Extra space before `),`
Can you please rename it to addToWhitelist ? First time I read this I thought it was ment to add fields to a query
a number of indentation woes in this file.
No we want Closure here explicitly, because that makes all the code var_dumpable without problems.
This function appears to return a Toolkit instance, not a str.
The font size increase is also not proportional.  Comments?
i am renaming the existing file as filename.SavedAt.TimeStamp and writing the other one now.
true, also fixed.
Which is a good thing :-) I'll do so!
sure :) thanks for your help.

I was hinting at the dynamic partials, and the context itself been a function. I have not personally used this ( but the code supports it )
minor, both the tests are names the same
Yeah, I think it's better to require authentication to view the list of users. 

I'm reconsidering the authorization question though. In fact on the live site we don't even allow anyone logged in to see the full list of users, only someone with manage_users permission. So I'm wondering if we shouldn't do the same here, and require "core.manage_users" permission in order to even see the list of users.
Not to drop, but to use ``/products/`` instead of ``/products_list/``.
Yeah, this really isn't what I meant.
Do we want to keep YaST++?
Since we don't share checksums across orgs, I think this query needs to take an org_id as well. Same for the delete_checksums_by_id query, needs to limit to a specific org_id.
update() should trigger physics
you can remove the ``else`` as the ``if`` breaks the loop
should be on previous line, right after `}`
'type' should be renamed to 'input'.
I know, but FormFactory relies on that method.
If the method signature is the same as the parent there's no need to redefine it.  I'm not sure why you're even trying to do so. :-)
Yes, it reads the config.

I'd add the log message rather to YastService.Call so it's logged always, not just in this Samba case.
Is `session` the right word? It's a bit overloaded in web terms. I think of it as a browser session. How does the access token work? Is the half-life of the access token conceptually the Yammer session?
其他有些地方必须改的，不然编译都无法通过，可以考虑顺便一起加上
摘录：《本科生毕业设计（论文）手册》的《本科生毕业设计（论文）撰写规范及要求》
2 书写规范与打印要求
2.3 字体与字号
论文题目： 2号黑体
章标题：3号黑体
节标题：小4号黑体
条标题：小4号黑体
正文：小4号宋体
页码：5号宋体
数字和字母：Times New Roman 体
-------------------
这个已经写的再清楚不过了吧，根本没有留下什么类似于强调之类的灵活性，
再强调也是正文，是正文就应该用小4号宋体，不是小4号宋体就不符合要求，
这个很明确，没有任何商量的余地，而且中文字体里也没有加粗的说法，
我实在没有搞明白，一篇论文里面如果各种字体来回换再加个颜色什么的那还算什么东西
I use it basically for retrieving the flat list of tag classes/values. Then, I save that list into Solr, and also use it in JavaScript to match the tags (keeping that list in select/option values). Added comments and specs 8340401
If the code got here it is a bug so it shouldn't estimate the hashes done based on some unexpected problem
The abort time is the only valid estimation of the hashes done since any extra done are not valid and not checked unless:
If EPOLL resolves this - then that is just as bad since EPOLL isn't always available when the code is compiled.
Using ``false`` as a default complicates the logic when we test for it later. Using a number would allow one check: ``if @limit_choices >= @choices``
Comments always go above the line.
nit: missing `</p>`
I've tried without it and its recognisable, there is a short flash unfortunately..
New line at the end?
JavaScript is better than that :)

See http://jsbin.com/ocefur/4/edit
How I magically re-activate the last button.

Great idea to use jsbin for this BTW.
mmm I like the fact that we can launch the activity, create the contact and return to the original app with a reference to the contact just created.

Also understand the behaviour you propose, should we have both? And there is an elegant way of having both (don't want to add more parameters).
Cool! definitely worth mentioning in a comment.
Loos ok for me, but I'm pretty sure that there's an easier way to create the overflow for a span depending on another span on it's right with css.

Maybe @basiclines can guide us through it, and if possible, I'd love the css option more.
if (callback && callback instanceof Function) would fix it, right?
Function names are clear enough, no need for the comment
this rule is ignored with the current state of the HTML markup, right?
Do you need the `input` selector here?
Not sure why it was removed.  Maybe auto-format.  I'll put it back.
No, sorry for the confusion; it works under both versions. I have 5.3.2 running on one of my machines and I wanted to test Mimeparse there.
It was added by @filipewl , he can answer
Oops! thanks
no, that's a refactoring artifact
I'll add that as a "future" task
Log what type the user gave you in the TypeError.
Move this import down with the one for helperfunctions.
I think this flag could be really interesting to experiment with. I opened an issue on GitHub (https://github.com/AppScale/appscale/issues/114) to investigate if we can get better performance on our Java AppServer apps by messing around here.
Why? It seems like you should only put this on nodes that are `appengine`.
>`true`

lolno
scope :date_event, lambda {|dt| where(date:  dt.beginning_of_day..dt.end_of_day)}
thought from README, user can specify both mins and at times... but this if / else seems contradictory ?
if you look at:

TileEditorPanel ed = tile.newEditor(newTileEditor.getId(), nodeModel);
 ed.initialize();

it allways happens when a new one is created right after - so, what exactly do you want to achive with this?
`controllerPath` would be better here if we'll stick to camelcase in hash keys
"counts" as a *type instance* does not carry any information. See my above suggestions for following *collectd's* naming schema more closely.
what is this ``/inDir`` ?
sorry, haven't configured my IDE at home properly
you should be able to use the `get` helper function for this, I think, see: https://github.com/elabs/serenade.js/blob/master/src/helpers.coffee#L5-11
I think we can omit the variable definition if we don't use it later:

```php
<?php
$this->fumocker
  ->getMock('BadaBoom\ChainNode\Sender', 'extension_loaded')
  ->expects($this->once())
  ->method('extension_loaded')
  ->with('newrelic')
  ->will($this->returnValue(false))

```
@Carreau, very nice suggestion. Have adopted it and will push it with some other changes once they are ready.
Has platform agreed to adding bootstrap class names?  I'm assuming this is bootstrap.  Otherwise it might need to pass it in as a parameter.
We don't use DS anymore (it's deprecated and removed in the current platform). You should either use / or if you absolutely have to DIRECTORY_SEPARATOR.
Generally for long indented blocks, I like to have comments after the 'end' detailing what block is being ended. See examples at the end of the sample here: https://github.com/logstash/logstash/blob/master/STYLE.md

Real-world example: https://github.com/logstash/logstash/blob/master/lib/logstash/filters/date.rb#L120-122
I've used select and unselect.
I think it's probably better to use [util/list](https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/util/list.js) instead.
These two code example aren't really helpfull. Both are identical whereas we try to explain different behaviors. I'm not sure examples are really important. These two sentences are quite clear.
Defining a function called "attempt" inside a function called "attempt" hurts my brain
Good catch @shane-tomlinson I kept reading 0.8.12 in this ticket but swearing I'd seen 0.8.11 somewhere.
It would be nice, and I prefer a [`providers.js`][1]-like resolution about this. 
But strictly in a follow-up issue! :)



[1]: https://github.com/mozilla/nightlytt/blob/753c6ec07f109dc78120230d8808708c37440227/extension/chrome/content/screenshot/providers.js
We don't use the word `should` in descriptions.

```ruby
it "equals LITTLE_ENDIAN" do
   # ...
end
```
@dbussink we can do something like that:

```ruby
value = 0 if value == true
if value
  value = Rubinius::Type.coerce_to value, Integer, :to_int 
  raise ArgumentError, "negative process group ID : #{value}" if value < 0
end
```
This is from a bug fix that Erik F did around case insensitive matches on username and name.  IMHO, this *should* be included in 1.2.  We have been running this in production for about two months now with no issues.  Thanks, L
noErrors -> no_errors
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Naming#Naming
no that's incorrect. isActive means the element is open. you don't want to focus the element on when closing the element. that makes no sense
What is the reason for this functions?
Missing `AdapterInterface` type here
No, because we have the shutdown() function that unset the $this->db.
>  isset() will return FALSE if testing a variable that has been set to NULL. Also note that a NULL byte ("\0") is not equivalent to the PHP NULL constant.
this param don't exists in method signature
Same as above, this will return true instead of the intended vaue.
Attualmente
Now that I think about this, this is the correct thing to do.
I'm not sure, I think @jconniff had a reason to make it a GIF.
What? Can you maybe say this rather???

// The field needs to be re-added to the main panel because the added 
// field needs to be at the top and cannot be added on a panel at index 0.
// The index of the field in the array can be re-added to the main panel 
// in the correct order but it first needs to be cleared from the main panel.
This should be the opposite, see `event_FOO.py`
Should not be necessary as sqlite databases should end with " *.sqlite3".
why changing it ? It makes the feature fail
this is useless as it is already the default
Could you write a unit test for this? Yank this out into an LDAPProvider type and then mock it out in the test
This is an awful lot of requests. Is this really the framework best practice?
Any updates? :)
Ok, but you can just preventDefault() in the event handler and keep the links.
The open curly braces should be at the same line.
Generally speaking, this condition should be:

```php
if (($entity = $this->getEntityFromIdentityMap($className, $data)) && ( ! ($entity instanceof Proxy) || $entity->__isInitialized__)) {
```
you also might want to add doc and or examples if the package has them.
see http://sisyphus.ru/en/srpm/Sisyphus/ThePEG/spec
Nice idea, thanks
No, afaik.
line to long.
Just copy the copyright header from another file in the repo?
the `##` on the end of the line
http://hpc.ugent.be
GPL header?
Use backticks around the method.
I know this style differs to Addon-tests and our other projects but I'd prefer to keep test suites in either all 'return' style or all this style for consistency.  We can convert this over to 'return' style all in one pull one day.
こうなるよね
All functions should call get_any_ip()
def get_any_ip():
  if has_front_ip()
     return get_front_ip()
  elif (has_back_ip()
      return get_back_ip
  else:
    raise Exception('host {0} doesn't have any ip")
I think homes_file should is in world folder.
So what are you going to do if the test isn't cleaned up properly?
final and space after :
Confirmed that removal of .summary-header makes the feedback form squished. I've undone this merge, can you fix the css and resubmit please Jo?
These aren't flattened right?
@joker-x hey, clever solution ;)
что именно этот метод изменяет в этом классе?
Yes, please.
If you bump the version one, and add a note to the CHANGELOG with your name will be perfect :-P
Yeah, Python 3 makes "print" a function so the parentheses are required.
Nice, I like this pattern.
the value of the install class changes only when the install button is pressed.
Click_and_hold is the desired action for this particular test.
If you have any idea on how to get the class value when the button is pressed please do share...
the user has the "search" button on the keyboard and off course the button at the end of the search bar
What happens if it doesn't exist -- does it still tweet via `@firefox`?
2 space indent?
what i mean is, since this file (test/test.authenticate.js) is in the test file, does `nconf.file()` use a relative path from this file, or somehow from the root?

If it's relative, then leaving it as 'local-test.json' would be fine, as long as that file is in this folder.
Are you commenting on methodString()?  I like it because it makes it easier for debugging of course a user could directly call MethodToString...
ha ha. thanks. fixing.
Did we remove the other middleware?
``getDebugTarget`` is defined in ``DebugElement``, and we can't modify it. While ``debugTarget`` it's defined by us, and it has a different signature. My intention was to simply make sure that subclasses of  ``ScalaDebugElement`` only override our own definition.
Yeah, I agree, ``OpenDeclaration`` and ``OpenImplicit`` provide no real added value, since there are already factory methods ``toDeclaration`` and ``toImplicit``. Will remove the classes.
I've discussed this further with Philipp, and he agreed that pop/push are more readable names. Hence, using a mutable stack is a better fit.
I believe there is an issue with indentation inside this method.
Same for this one, there's a method in Static that converts from CArray to ItemStack.
yeah .. maybe add a link to this PR
Hmmm. Interesant idee deze class.

Hoe ik het zou doen is ietsjes anders. 

Ipv een spawener die de enemies op een random plek spawned zou ik juist een paar fixed spawners hebben op de map. Ik zou dan een andere class hebben, een `SpawnManager` ofzo, en iedere keer dat de `SpawnManager` besluit dat een enemy gespawned moet worden dan kiest hij een `EnemySpawner` en die spawnt de `Enemy` dan op die locatie. 

Op die manier heb je 1 class die er voor zorgt dat je niet te veel enemies hebt, en de spawners zorgen voor de locatie. Je kan een klein beetje variatie toevoegen links en rechts van een spawn point zelfs.

Idee?
Yes. Uncertain of fix at this point (may have just missed a flag, may be
LF\CRLF issue)

On Tue, May 29, 2012 at 11:23 PM, Ben Scott <
reply@reply.github.com
> wrote:

> > +{
> > +    Log-Message "Running unit tests"
> > +    CMD /C "$build Testing x86"
> > +    CMD /C "$xunit $test_assembly"
> > +}
> > +
> > +function Set-Version
> > +{
> > +    Param([Parameter(Mandatory=$true)][string]$version)
> > +
> > +    Log-Message "Updating version to $version"
> > +    $infile=get-content $assembly_info
> > +    $regex = New-Object System.Text.RegularExpressions.Regex
> "\b\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\b"
> > +    $replace = $regex.Replace($infile,$version)
> > +    set-content -Value $replace $assembly_info
> > +}
>
> Is this stripping the line feeds from GlobalAssemblyInfo.cs somehow?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Code52/DownmarkerWPF/pull/290/files#r892029
>
Simple - it is way better to leave to job to PHP instead of trying to track it yourself.
вынес, не знал об этом, сам удивлялся зачем категории в основном коде
о да! это, безусловно, фол. )
спасибо за подсказку.
Я изначально тоже делал как Вы :)
На данный момент мне больше всех понравился вот такой:
1) Формируем массив индексов длиной равной длине ДНК, значения которого NSNumber
2) Рендом выбираем из него значение от 0 до длины массива индексов
3) Меняем элемент ДНК с индексом полученным на пред. шаге
4) Удаляем запись с массива индексов и повторяем все начиная с шага 2

Вы будите исправлять/пере заливать свой проект? Или можно выставлять оценку.
В задании говорится: "в классе создайте переменную DNA типа NSMutableArray...".

Возможно я ошибаюсь, но мне кажется, что свойство в данном случае не является правильным решением.

Вы говорите, что в свойстве тоже создается переменная. Это так, но, во-первых, это неявная переменная, и во-вторых, с именем отличным от DNA.
good call, changed it
```games``` вернёт все игры этого пользователя. ```where``` выберет из них те, у которых статус "не закрыта", такая игра должна быть только одна, но метод возвращает массив в любом случае, так что выковыриваем из него ```first```. Единственное, что может пойти нет так, если у пользователя каким-то образом окажется одновременно 2 не закрытых игры, но при создании новой игры вроде уже стоит проверка ```if current_user.current_game.nil?```
Nothing needs to happen in the `onSuccess` case? Seems weird how `onFailure` is handled here but `onSuccess` is not.
Do you have a test that validate this algorithm?
Yes sounds reasonable. More than having a private ._copy with index arg...
Or what do you / the others think?


On Thu, Dec 6, 2012 at 5:40 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
> Maybe temporarily remove self._data in *getitem* before calling
> self.copy()?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337336>.
>
>
see for example:

http://stackoverflow.com/questions/889088/function-decorators

that can be a start.
Please change the structure of the code to be as follows:
 - Remove the folders "logic" and "routes".
 - Rename the folder task1-express to news or news-feed.
 - Include only two files under that folder. The first file is 'news.js' and the second file 'app.js'. There's no need for any other files.
 - Please make the needed changes for the new structure to work properly.
please remove  this added line.
Since we use the precompiled approach (typescript is compiled before being packaged) we check in the resulted (after running build) kuduSync.js file.
You can use `%F{blue}(%f`
好像还是原来的通顺一点啊
@kellyredding - It looks like there is some inconsistency in how you initialize an action. Further up, you are initializing actions with a `runner`, but it doesn't look like that's what's being done here. 

Everything else looks good and makes sense. I like all the changes.
I am using it to dump to NFS mount. The hdfs copy command is too slow.
Use akka.util.NonFatal. New decree
why this catch block?
Just clean up this bit (commented imports) and we are ready to merge?
Well, if it works then let's keep it.
Коннекты по стилю пишутся с каждым аргументом на отдельной строке, типа

    connect (Action_,
            SIGNAL (triggered ()),
            this,
            SLOT (showHideMain ()));
I'm not happy about the amount of logic here but at the moment it uses a combination of both the `vim_path` and the `gui` to determine how to spawn a user-specified Vim.
I suggest to also override onPrepareOptionsMenu(), as some of the buttons should be enabled/disabled depending of the overall state of the queue (e.g. disable flush if the queue is empty).
http://twitter.github.com/bootstrap/components.html#pagination
this is bootstrap demo style.
I also think to look at some of the better than before.
We made this change for the presentation, and then forgot to flip it back because Manzer probably will test in Firefox. We need to find a better way to position across browsers.
assuming everything after should_authenticate are params?
Before this you also need to checks if a-seq or b-seq is empty:
~~~clojure
;...
(or (empty? a-seq) (empty? b-seq)) false
;...
~~~
Sounds good.  I'll can probably get to that today.  Also, should I change the project directory from validation-ext to something else?
役を判定するクラスなのであれば、そのような名前に変更してください。
Judgementクラスはショーダウン時に各プレイヤの勝敗判定を行うクラスと考えていました。
Use ```canvas.manager``` as per #919.
How about rewriting the code (including the array_filter from a few lines above) to something like this:

```php

$identifier = array();
foreach ($classMetadata->getIdentifierFieldNames() as $name) {
    if ( ! isset($data[$name])) {
        return $this->fallbackConstructor->construct($visitor, $metadata, $data, $type);
    }
}

return $objectManager->find($metadata->name, $identifier);
```

otherwise we are traversing this array multiple times.
please break line after ~80 chars
The reason this code saved the btree handle from the primary cursor is that we need to clear the "no eviction" flag on that btree handle.  Now that you're using the implicit `session->btree`, I don't see how we can be sure that the flag is cleared on that btree.
This is the bug fix to skip internal checkpoints that aren't necessary.
Should all these tests be commented out? Do these commits reduce the overall level of test coverage for this flow?
May I just throw in here that it is far more easier to write a code sniff that ensures that every comment is terminated with a full stop than to examine if the comment is indeed a complete sentence containing a verb ?
Thats probably where we need a javadoc
Why is the DAO serializable ?
Да, в тестовом задание не сказано про это. Поэтому я решил сделать так.
Yes, I have explained latter how I would do it. (Instead of `if` in the Python code, an atomic query checking for all those conditions.)
Be verbose, write variables in full, `latitude` not `lat`.
Added comment in docstring above this line.
Split into multiple lines.
Unnecessary space before `>`.
In init of a changepassword and account form.
`checked` -> `enabled`.
`panel_checked` -> `panel_enabled`, use better semantic meaning for variable names.
Needs doc string
ye thanks ;]
and for the XSD, it will be similar to the ``option`` type
The intention of this PR is to prevent a find lookup on the identifier field when values are parsed  to the hydrator like this;

```php
Array
               (
                            [categories] =>
                            [body] => sdfsdf
                            [contact] => Array
                                (
                                    [contactid] => 64
                                )

                        )

                )
```

Note the `categories` key is an empty string and does not === null.

What do you propose based on this?
What about add_conversion_formula as method's name?
"when text" not "when a text"
Actually scratch that. You were right. Fixed.
This implies that visiting filenames is always done. Should be explicit that that's the case. Do you think it would be a valid use case to only visit directories, in which case we'd want to add vistiFiles boolean?
Upps. Let me fix that.
```And I should see the following <links>:```
It's still within the network_service. Okay, but I'll change that.
Height of the badge was increased with one pixel - it's to compensate for that by making it a tiny bit lither, in order to keep the same weight of the badge.
Call this: `create_etext_folder`
@ColinHebert How am I supposed to check the result of that expression?

And doesn't this line cause an search of all directories in `$path`?  This would be somewhat slower than just accessing the `$commands` array, without any considerable gain, because as said, `virtualenvwrapper.sh` can expected to be executable.
FigTree seems to be the best available implementation, but its LGPL.
It is a good idea to get rid of unnecessary nested blocks.
For example:

```js
function(...) {
    if (wasHere[id]) return;
    // ...
    if (!children.length) {
        leaves[id] = 1;
        return;
    }
    for (...) {
    }
}
```
nope - I need to remove that.

On Tue, Oct 23, 2012 at 12:10 PM, Brian Humphrey
<notifications@github.com>wrote:

> In
> Product/Production/Gateway/DocumentSubmission_11/src/main/java/gov/hhs/fha/nhinc/docsubmission/_11/entity/MailServer.hbm.xml:
>
> > @@ -0,0 +1,14 @@
>
> Is this still needed?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CONNECT-Solution/CONNECT/pull/110/files#r1917996>.
>
>



-- 
Michael Landis
Software Engineer
www.5amsolutions.com | Software for Life(TM)
phone: 866.526.6042 x774
email: mlandis@5amsolutions.com
skype: mlandis5am
There's a couple of redundant span elements here, when you get time, you could optimise this
A valiant effort, Rachel.  :)

I [posted](http://old.nabble.com/Putting-%40mainpage-in-a-markdown-comment--tt34464466.html) a message to the doxygen users' forum, so maybe some doxy-guru will have a suggestion for us.
doxygen is treating this weirdly.  I see everything from "As in SBProfile..." to "... in real space" (below) in a code block, so for example the ```@param``` is written literally rather than interpreted as it should be in doxygen.
Actually, you can remove the lines with empty contents (ie. only keep the `bin` field)
Unclear if this is still strictly required, setting the servername outside the virtual host.  If you don't though, you get warnings on restart that are annoying, and this seemed innocuous.
Instead of:
`log.info "{} deploying {} to {}:"+dest, entity, f, hostname`
can do:
`log.info "{} deploying {} to {}: {}", entity, f, hostname, dest`
If you make this `append` it should append to a list, so the argument can be repeated.
You could have just replaced the `":("` in the stub with `(* x x)`. Most of the time `defn` should be used to define functions.
Oh, without it the tests for 304 were failing. But I see the point, will remove it.