Unreviewed.

Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
some code that is conditionally compiled and therefore fails in some
configurations.

* tests/WebFrameTest.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix margin box ascent computation in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98540

Reviewed by Ojan Vafai.

Source/WebCore:

The margin box ascent doesn't depend on the margin below the box.

Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.
       css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::marginBoxAscentForChild):

LayoutTests:

Remove a FIXME and update the results.

* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Don't assume that TileCache layers are opaque
https://bugs.webkit.org/show_bug.cgi?id=98555

Reviewed by Dean Jackson.

TileCache previously set all its tile CALayers as opaque.
However, we will need non-opaque tile caches when we use this
tile cache for tiled layers, so add a member function to
control tile opacity.

RenderLayerBacking already calls m_graphicsLayer->setContentsOpaque()
using the FrameView's notion of opaqueness, so this change will
cause the main tile cache to be non-opaque if external forces have
set the FrameView to be non-opaque.

Also tweak the layer border widths on tiled layers.

* platform/graphics/ca/mac/TileCache.h:
(TileCache):
(WebCore::TileCache::tilesAreOpaque):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
(WebCore::TileCache::setTilesOpaque):
(WebCore::TileCache::createTileLayer):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setOpaque:]):
(-[WebTileCacheLayer isOpaque]):
(-[WebTileCacheLayer setBorderWidth:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Inline continuations create :after generated content on style recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
Reviewed by Abhishek Arya.

Source/WebCore:

The bug is caused by RenderInline::styleDidChange's setContinuation(0).
RenderObjectChildList uses continuation to know whether the given
renderer should have AFTER render object or not.
However, setContinuation(0) makes RenderObjectChildList to
misunderstand that all continuations are last continuation.
To avoid the misunderstanding, added a new flag to class
RenderObejctChildList to enable/disable updating :after content (and
also :before content).

Tests: fast/css-generated-content/after-with-inline-continuation.html
       fast/css-generated-content/dynamic-apply-after-for-inline.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
Disable upating :after content for continuations which are not
the last one during setStyle just after setContinuation(0).
The setStyle invokes RenderInline::styleDidChange and also invokes
updateBeforeAfterContent via the styleDidChange. This means,
the last continuation's updateBeforeAfterContent is also invoked
after setContinuation(0). We have to update :after for the last
continuation.
* rendering/RenderObjectChildList.cpp:
(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
If s_updateBeforeAfterContent is false, quickly exit
updateBeforeAfterContent.
* rendering/RenderObjectChildList.h:
(RenderObjectChildList):
Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
updating :before or :after content.

LayoutTests:

* fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
* fast/css-generated-content/after-with-inline-continuation.html: Added.
* fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
* fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
* http/tests/misc/acid3-expected.txt:
The acid3-expected.txt has the duplicate RenderBlock (positioned).
Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
exist. So did reset-results for acid3-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
Reviewed by Silvia Pfeiffer.

Source/WebCore:

* WebCore.exp.in: Export new WebkitSystemInterface functions.
* WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.

* css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,
    background, and text independently.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as
    un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.
(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from
    setClosedCaptionsVisible
* html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme
    has a captions style sheet override, inject it into the current page group, otherwise
    remove injected sheet.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member
    variable. Get caption font scale from theme instead of hard coding.
* html/shadow/MediaControlElements.h:

* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
(WebCore::MediaControlRootElement::updateTextTrackDisplay):
* html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.

* html/shadow/MediaControls.h:
(WebCore::MediaControls::userCaptionPreferencesChanged): New.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the
    shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the
    shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):
* html/track/TextTrackCue.h:

* platform/mac/WebCoreSystemInterface.h: Updated.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

* rendering/CaptionPreferencesChangedListener.h: Added.

* rendering/RenderTheme.h:
(WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
(WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
(WebCore::RenderTheme::captionFontSizeScale): Ditto.
(WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
(WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.

* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
(WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
(WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
(WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
(WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption
    background color preference.
(WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow
    or webkit-text-stroke property.
(WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property
    with a color value.
(WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption
    text with the user's preferred text edge stye.
(WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption
    text with the user's preferred font.
(WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions
    with the user's preferred style.
(WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences
    changes listener.
(WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences
    changes listener.

Source/WebKit/mac:

Add WCSI support for new WKSI caption functions.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

* WebKitSystemInterface.h:

LayoutTests:

* media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
* media/track/track-cue-rendering.html:
* platform/chromium/TestExpectations: Skip tests that need to be rebaselined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Exclusions] Add shape-inside tests for rounded rectangles
https://bugs.webkit.org/show_bug.cgi?id=96669

Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
Reviewed by Levi Weintraub.

Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
to simulate the shape-inside area in the test expectations.
(See http://www.alistapart.com/articles/sandbags/)
In general, each line has its own pair of left and right floats (both lineHeight tall),
to position the text and appropriately limit its width. In the simple, 0 corner radius
cases, these floats can be merged because they all have the same width on the left and
right.

* fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating
a shape-inside, simulating one, and generating content that should roughly fill the
shape-inside.
(xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
distance from center.
(xInset): The inset of a rounded rectangle from its bounding box.
(generateString): Generate a string that roughly fills a shape-inside's content area.
(simulateShape): Create floats to simulate a shape-inside area.
(simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
(generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
with content.
(generateShapeElement): Create a shape-inside and fill it with content.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:
Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:
Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
https://bugs.webkit.org/show_bug.cgi?id=98526

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-05
Reviewed by Stephen White.

This is causing some problems with picture serialization between chrome
and the mainline skia tools. (Once this change lands and is gardened in,
I will make the corresponding change in chromium/skia/skia.gyp)

* features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tests in webkitpy involving child processes are flaky. 
Skipping run_webkit_tests_integrationtest.py.
https://bugs.webkit.org/show_bug.cgi?id=98559

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose_in_child_processes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
https://bugs.webkit.org/show_bug.cgi?id=98550

Reviewed by Andreas Kling.

This shaved another 5% (100ms) off of the runtime of resizecol.html microbenchmark:
http://www.robohornet.org/tests/resizecol.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Chromium gardening.

* platform/chromium/TestExpectations:
Updated a wrong bug info and rebaselined 2 tests:
fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html

* fast/backgrounds/solid-color-context-restore-expected.txt: Added.
* fast/reflections/inline-crash-expected.txt: Added.
* platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
* platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
* platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
* platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
* platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
* platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
TestResultsServer does not display sync_integration_tests results
https://bugs.webkit.org/show_bug.cgi?id=98551

Patch by Richard Larocque <rlarocque@chromium.org> on 2012-10-05
Reviewed by Ojan Vafai.

Allow builders whose name contains "Sync" to pass through the
isChromiumWebkitDepsTestRunner filter.

The test expectations in flakiness_dashboard_unittests.js have been
updated to match the new behaviour.

* TestResultServer/static-dashboards/builders.js:
(isChromiumDepsGTestRunner):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update WebKitSystemInterface libraries and header.

Reviewed by Simon Fraser.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130563 268f45cc-cd09-0410-ab3c-d52691b4dbfc