labofsahil/github-event-dataset-2012 huggingface dataset:
So, if for some reason we gave '-p greenplum', but were pointing at a postgres instance it would fail the regex and conclude that it was the most recent version of Greenplum?
Yes. I do not see the requirements. We already have the functions for sparse vector. I think it is better for us to optimize the sparse vector implementation rather than providing another set of functions.
The first pre in this line is extraneous.
And what if the first arg is null?
Please see comments above.
Pretty sure this is wrong. If you don't call GIT_SUBMODULE, then it'll never update vendor* things.
Because it looks bad and we don't advertise anyone in the UI part. There is Authors.txt for this job.
One could use `#{version.to_f}`:

```
[irb(main)]$ "2.7.3".to_f
 ====> 2.7
```
This file is copied automatically by the installer, so you can just remove this line.
We prefer not to break URLs up like this, or substitute the version into the URL; i.e. we keep them cut-and-paste-able.
wow that was bad lol
If possible I'd prefer not using a dot notation here as that could possibly break things in Django templates, but it's -0 because I could read those values in the view and then update the context before rendering the template.
Various workers create their own managers from the configs without using `get_riak_manager()`, and we want to throw exceptions there instead of unknowingly having a bunch of potentially dangerous database access. `RiakDisabledForTest` was the easiest way I could think of to raise an explanatory exception without adding a bunch of test-only code to the managers.
also hinsichtlich errors wärs noch ne Erwägung, ob man die grundsätzlich als eigene warnings außerhalb der jeweiligen tables ausgibt.. leider hat man bei tables keine optionen hinsichtlich farbe, font oder ausklappen wie man es z.b. bei groups machen kann.. d.h. man kann fehler nur einfach in den title schreiben, aber nicht sonderlich hervorheben..
I meant where exactly in all of the statements in the `try`. That's basically what I said :P
Fixed. Thx. Takes time to rearrange my brain globally.
Look like this is integration test not a unit test
See my comment above with benches, I think we should just be doing straight deletions.
I don't see how this could possibly be secure.  there's dozens of ways to craft script tags to avoid this gsub.

the better practice is just to escape tags for the whole string, eg, gsub '<', '&lt;'

We might want to check to see what rails does internally as an example.
this could be deleted too
A minor nit picking. Why one-character indentation here and the next line?
Should test that the key binding is added to KeyBindingManager
You have weekends too ;-)
```fullPaths``` does sound like a better name if we stick with this approach of changing the API.  I think we have a loose convention: variables named "file" are usually of type FileEntry, and variables named "path" are usually a string.
Looks like this is doing a case-sensitive compare... is that intentional?
You're right again. I can safely remove this and the test still passes.
It's ok to use single-quotes to avoid escaping double-quotes. Also, I don't think it's necessary to set the local endQuote variable, so this block could be:

completion = '"' + completion + '"';
This thing needs to be recursive.
According to function "run_command" $COUCHDB_USER can be empty.
Code should be:
```
if test -n "$COUCHDB_USER"; then
    chown $COUCHDB_USER "$RUN_DIR"
fi
```
This check was here before commit 3c1504c05aa817731d76124a13ef06c06abd6aa7.
could this be made part of the database.yml so is easy to change them? (again not a :ship:  stopper)
This is bellow #main, no?
space right bracket
True! Looks like Scott's approach is better.
Spacing at the end for `{`.
I actually like this idea alot
Ah, I guess I forgot to update the others. My whole `scaffold.js` says callback, but I didn't update `crud.js` with a similar standard. I think it's important to mention all the parameters, even if one is a callback. This will reduce any ambiguity and the "Returns: `callback(...)`" section will also be clarified.

If you're OK with this, I'll go ahead and add callback to the documentation for the other functions.
"wheter" should be "whether".

Also: that second arg explanation is strange. I'd say "Requires: web request, new request boolean (true if project is being created; false if updating)".

*That* said: you don't use the second argument.
Is this method needed for this example? If not then it is arguably a distraction.
mod_concat
Why is this hard-coded in here?
txt => description
I've rewriten this. The old code is commented so you can review at the next pull request :)
Add this change as different commit
Well, hopefully they're both getting inlined anyways, but I still don't think there's a good way to know that for sure.
While we're at it, could we explain a bit better what's going on in the docstring? (Before, the default values were kind of self-documenting, but now...).  And we probably can also eliminate references to httplib here...
changed to out=sys.stdout as in model.py methods
On Aug 20, 2012, at 8:40 AM, jao <notifications@github.com> wrote:

> In bigml/api.py:
> 
> > +                content = exception.read()
> > +                error = json.loads(content, 'utf-8')
> > +            else:
> > +                LOGGER.error("Unexpected error (%s)" % code)
> > +                code = HTTP_INTERNAL_SERVER_ERROR
> > +
> > +        except urllib2.URLError, exception:
> > +            LOGGER.error("Error establishing connection")
> > +            error = exception.args
> > +        source['code'] = code
> > +        source['resource'] = resource_id
> > +        source['location'] = location
> > +        source['object'] = resource
> > +        source['error'] = error
> > +
> > +    def _stream_source(self, file_name, args=None, async=False):
> I would add here a boolean parameter to be able to desactivate printing the progress bar... users of the API might not want their standard output written to. Another possibility would be to take the output stream instead of a boolean toggle. I would then consider making silence the default.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
This would induce the need to change all functions using ``std::vector<unsigned char>&`` into ``std::vector<unsigned char, zero_after_free_allocator<unsigned char> >``.
It is nicer this way, especially if you are stepping through with a debugger.
Right... Is there a list of the namespace-polluting crap macros that windows dumps into programs somewhere? 

And yes, ERROR and REQ_ERROR are different, the first category is meant for general critical errors the other is simply a failed RPC command.
If you can give me a hand in the correct syntax - `preg_match('#(^[javascript|mailto|tel|sms]\:)|(\://)#i', $url)` is not quite correct
well, in fact, you should probably keep the name, but change the case where you use ``true`` and ``false``
`.textContent` doesn't take HTML, so this is wrong.
shouldn't there be a break; here?
Thanks for the catch.  Should be fixed by setting `force=True` below.
absent() for now, as this gets complicated :P
maybe pull out runlist into its own class w/builder? then make a runlist arg?  ex. RunList can be rendered as a list of strings like recipe[], etc. later
Leaks As Fuck (TM)
Warning, not everyone runs in a 64bits environment ;-)

How about changing the fist part to 

```
>"Path\to\cmake.exe"
```
Nope, I actually do it manually as I find it. If it's particularly bad, I end up doing a replace function and double checking it. (I always format manually)
Was there a reason this has it's own file? Couldn't we just add it to config.js? Mobify.config is an accessible key that can be used as needed. Also why is it a .konf file living in the konf folder? I would say it should be a .js file living inside of the api folder.
If /legal is specified here. I would then add the /eula into apps/legal/urls.py

That seems OK, would this cause any problems for the /legal content that is going to remain on legacy for now?
weird indentation here. Also you can probably just do `$container.html($response_preview);` right?
This test probably fails now that we require a key argument.
This check should be replaced with a check that the desktop product was added to the document. But that depends on willkg's code.
proc is called ``update_signatures``.
Perhaps I didn't spot it but I couldn't find a case where the execute method is called with something set for the `allowable_errors` parameter. 
Maybe you're just thinking ahead for some future date when this might be needed and used.
haha, 'wich' - might as well fix that in that pull request ^^.
name='users.user_recover'
Indentation to fix in this block
While I agree, it's an open source project and they're already everywhere.
Eep, Guava also handles this nastiness:
  text/plain; charset="utf-8"
  text/plain; charset="\u\tf-\8"
Well, I think using ``data-prototype`` as name would be better as it would keep the BC.
Why is there no specific `testRead` case or at least assertion reading an non-existing id.
Yes, that's the problem, I didn't knew which interface to take and add to this PR.
The PSR one seems dead and a bit different from the pov of the people in the above tickets so.. depending on which direction we take, I'll change this.
I forgot to mention that this refactoring was also done to simplify code in Drupal.
Yes. Global state is now stored in the visitor. Note that we have `GlobalExecutionContextInterface` now.
How better disable rendering of error screens but enable it logging? I can add `debug` argument to the `ErrorHandler::register()`.
simply use ``if`` here as the previous ``if`` breaks the loop.

And it should be ``if (0 === $n) {``
This suggests that the decoder is not separable from the encoder. Perhaps you should just conflate them in the code? It would avoid this extra decoding step and make the code clearer, I think.
Yes, makes sense, I'll fix that.
please wrap this (and `.x` few lines above) with `round` function (sometimes you can get `x = 0.5` out of those equations when you are dividing and view looks blurry)

also try to split long lines on many lines, so it fits on screen
Search and replace typo :)
if part['type'] in ['descriptive', 'narration', 'action', 'comment']:

(Though why are we printing out comments?)
i know this was not introduced in this changeset but what is the purpose of this code:

```js
(v || {}).isInstanceOf && v.isInstanceOf(Stateful)
```

 1. it will cause a TypeError if `v` is `null`
 2. it shouldn't matter if `v` is an instance of `Stateful` or not - it will still be an object

i think you can completely remove those conditions unless i'm missing something
The good thing with doing this is that it makes it possible to override the setting in siteaccess settings.
This makes a matrix to old the data, each row in the matrix will be a datum, and each row has a an unlimited number of cells, which correspond to the first \firstword in the toolbox file.  below they are refered to as columhead
thought so too at the beginning, but then it means that wherever we create an HTML element using JS we need to both give it the proper attributes, and  get the actual translation. it makes maintaining the code a lot more confusing.

this way all we need to do is create an element with the l10n data attribute, add it to the DOM, and voila!
I am pretty sure it is the same.
See also http://hsivonen.iki.fi/aria-html5/ — which clearly states that `<header>` elements don’t support `aria-level` attributes.
Imagine that the App is already opened, we are initializing twice PhoneNumberManager. Could you add the code needed for calling it only once?
nit: I think the code speaks for itself :)
you don't need the check for pin === '' since it will be less than 4 characters :)
nit: comment referring calendar
ellipsized sounds a real world as long as we both understand it ;)
(I'm not against it, just trying to understand)
``
} else {
```
I don't think you need the g flag here, do you? And doesn't the presence of g change the return value of match() or is that just for exec()?
You could just be using regExp.test() here to get a simple true/false return value.
We should keep this hide till localized finished, we could have some text in the markup.
I don't know whether cloneNode() would be any faster.  I was just imagining a createListItem() function.  You'd pass in the result object, and also a string like "search" or "album" or whatever to identify the type of the list.  Then you'd use that string to create the CSS class names you need on the elements.
nit: ' use strict'; without the -
not part of your PR, but we should remove dead code.
// When user clicks cancel button on confirm/prompt or
    // when the user try to escape the dialog with the escape key
I have tested again and found, Bug 812098 is resolved, but the file which passed by web activity still become a blob, cause I tried to see if file.name exists of not, still no name for the file. And the file caused an error for metadata parser so I have to use this workaround first until I found what's wrong with the passed file.
Please do log.error(...) here or something printing exception.
Also, what's not clear from the comment is what exactly does this add to the log. Obviously, you wouldn't do it if it had no effect :)
According to the specs, "inline" would refer to the name of a frame or
iframe and should be ignored by turbolinks. "_self" is valid and should not
be ignored (but it's not generally used). I'd be glad to add support for
"_self" if a commiter requests it.

On Tuesday, November 6, 2012, Ayrton De Craene wrote:

> In lib/assets/javascripts/turbolinks.js.coffee:
>
> > @@ -183,11 +183,14 @@ noTurbolink = (link) ->
> >      link = link.parentNode
> >    ignore
> >
> > +targetLink = (link) ->
> > +  link.target.length isnt 0
>
> Perhaps this should take link.target == 'inline' into account as well.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rails/turbolinks/pull/107/files#r2046088>.
>
>


-- 


Cheers,
Steven Bristol
steve@lesseverything.com
--------------------------------------------------
http://lesseverything.com
http://lessaccounting.com
So if the `$!.status` is `126` and the rspec run fails (producing a status of `1`), you want the exit status to be `127` even though neither thing had that as the status?

It seems like that a status of 126 is specific and meaningful, and the invoker may care to look for that exact status code.
I haven't done enough YARD documentation to recognize this syntax...will this render well with YARD?
Тут вообще немного по другому нужно записать, ведь в зависимости от кол-ва будет меняться склонение.
Nice .. I´ll change it!
Add an args section.
Split this into separate functions.
Thanks for that :+1:  Is there anyway for me to change that?
This line seems to confuse me. What about this situation:
```
<args body='foo' />
```

Would that not result in this line resulting in info=""?
Move that to the base class. You are repeating it in all subclasses which is wrong.
OK. Just use the old way of the pre implement and will change this part. Maybe something like this:
floppy_readonly = floppy_params.get("floppy_readonly", "no")
floppy_readonly = floppy_readonly == "yes"

Thanks for point out the security problem of eval().
I really don't like ''.split(). It makes the reader figure out that the author wanted a list, but was just didn't want to put commas in, rather than actually doing something.

Also, If you are going to build up the list incrementally, you should be explicit about what each version is building on.
this should be indented one level more
这个现在来看比较困难，我们的流程不同，我是从Excel文件中来读取这些，而任远是直接从request中读取
生成representation的方法比较简单，没有抽成方法的必要
Anyway，以后任远写完代码之后重构时可以考虑有公共的方法
For all this we can probably just use classList https://developer.mozilla.org/en/DOM/element.classList.  For the browsers that don't support classList yet ( cough ie9 cough ), we can shim it.  We use this in Butter if you wanna steal it https://github.com/mozilla/butter/blob/master/src/util/shims.js#L122
What was the reason for replacing # by @@HASH@@ and later substitute back again?
What happens if the value is a nested array?
Each action you add in additional access sections in an access.xml file should be available in the component access section. So the core.edit.own action is available in the menu section, and should be added to the component section as well. Otherwise you can't set an action component wide.
esse Paste aqui é alguma dependencia do amberjack ou debugtoolbar?
@dgoforth typo ````factnumer````
save before rendering view
Yup, its skipped.
It would be better to use if/else if/else and put comments for each cases.
Yea, it looks like it sucks. What we have is 2 beginning scenarions: already authed with the dialog, or not. This module is only shown if the user isn't authed. `upgrade_to_primary_user` handles the case that the user was authed before, but now must upgrade.
@jedp - there is no danger of siteInfo being undefined, line #218 checks `if (siteInfo)` before branching into here.
Ah wait. So it really only return the relative preference string based on the extension name?
So you might want to use config.preferences[aData] instead when reading the pref. That limits the number of places we would have to update if the preference name changes.
For better readability I would prefer a temporary variable.
huh. does richard have the 'registration' app installed? I haven't used it w/ scrumbugz, but this could be some strange edge case. I'll take a look.
I will just try to write:

u = v * gamma => gamma = Sqrt[1 / (1 - (v / c)^2)] =  Sqrt[1 + (u / c)^2].

With a little transformations between the two steps one gets this result.

2012/5/19 Ognen Kapetanoski <kapetan.ok@gmail.com>:
> Actually no, it is with minus when you want to calculate gamma from
> the velocity, in this case (as Andreas wrote, thanks again) it is the
> relativistic momentum, so when one does the calculation, it gets exact
> with + sign. I will try to find the calculation and post it.
>
> 2012/5/19 Kirill Streltsov
> <reply@reply.github.com>:
>>> @@ -0,0 +1,19 @@
>>> +package org.openpixi.pixi.physics.solver.relativistic;
>>> +
>>> +import org.openpixi.pixi.physics.ConstantsSI;
>>> +
>>> +public class SolverRelativistic {
>>> +
>>> +     protected double c;
>>> +
>>> +     public SolverRelativistic(double c) {
>>> +             this.c = c;
>>> +     }
>>> +
>>> +     /**gamma = sqrt[1 + (u / c)^2]*/
>>
>> This is not gamma!
>>
>> Gamma is Sqrt[1 / (1 - (v / c)^2]
>>
>> I understand that you do not do the division but rather divide by gamma in the solvers, maybe that increases accuracy so its fine but you are definitely missing a minus sign there!
>> https://en.wikipedia.org/wiki/Lorentz_factor
>>
>> If this is intended pelease add an explanatory comment.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/openpixi/openpixi/pull/19/files#r849620
You forgot the end ">"
Okay - I've corrected this now.
Use `executeCliCommand()` instead of directly sending console commands to the MI interpreter.
I don't have an iphone.

Should we give each of these a more semantic class and then turn them off in the css?
I don't think that achieves the same ordering, as protocol vars do not have :protocol metadata.
Usually if this doesn't work, there's something else that's wrong with the layout. It's a pretty sturdy hack.
The ucwords() call is not necessary, as methods are case insensitive.
I know you only fixed tabs as you said, but please add the @param tag
(Actually, exercises people don't need the website repo…)
What do you think ? For the moment, we try to guess from the code as much as possible. But it's still possible it fails.
Then, user has to change the getName method.
This is really nice, @jpobst! I think you should also update this comment. ;)
`if ( !item.content().trim() ) {` -> `if ( !item.title().trim() ) {`
@stas But by doing this the selected state is coupled with the click even, which is wrong. `Active` should be selected on reload too.
I think the best solution is probably to change the order back to the way it was before.
HTMLReader uses the HTMLParser to pick apart the the incoming content. I actually considered making the HTMLParser a inner class of HTMLReader as it's very specific to what the Reader is doing.
Regrettably, this test does not pass on IE7.  I expect that the testing harness doesn't share the same `document` as jqLite, seeing as the polyfill for the `article` tag is not properly understood by the browser.

IE7 fails so many tests already due to harness issues that I don't feel bad adding another, though I will remove it if you request for me to do so.
You can maybe try to log the error?
So it turns out that Django validates max_length on a ModelForm twice; once in the form field, and once in the model. The issue is that the form field validation happens first, which means that any error message on the model doesn't get used in the form. So this will have to stay for now. :(

Will file a Django bug later when I have time to write a test case.
Hmmm. Trunk? Shouldn't we pull in a release instead?
Definitely better. Thanks.
nit: `query` isn't a good var name for this since It's a boolean and not a `QuerySet` instance. I'd go with something more like `app_exists` just for readability. It's not used much so it's not a big deal, but I initially worried that using `query` in a boolean context was triggering an unnecessary query.
Because both the m and s portions are optional, I'd suggest you normalize first so you don't get NaN values because of multiplying by 0:

// Make sure we have real zeros
minutes = minutes|0; // bit-wise OR
seconds = seconds|0; // bit-wise OR

return "&start=" + ( +seconds + ( minutes * 60 ) );
declare text up at top of function.
This only checks length, not that all the keys are the exactly the same.

We could leverage union and do something like this instead.
Since if any had different values in the unioned set would grow.
```
assert sid_keys[0] == set.union(*sid_keys)
```
Great documentation of the byte data :D
Also, what happens if someone used the form for attributes, but also set the same thing in free form JIT field? Does it matter if they are using subject or attribute for user id? See comment below about testing.
but surely we dont need the login method in the api?
well, fog for ec2 might not, for others it will.. (and I'm not 100% sure you are right that it wont)
Ok, I'll look into that, thanks
Remove the filter please. Bourbon doesn't support IE filters.
Being "too defensive" doesn't hurt so I'll keep it this way. YCP is harder to test than, for instance, Ruby, so I rather check for possible issues in future.
final spinal
noticed that looks funny
I tried stubbing it, but that doesn't work since we shell out for the CLI steps
After seeing a sample of the data, I think this can be done less verbosely / better. You can use each_line on the output data and use a pattern to match the delimiters of the key and values.
The formatting on this file is pretty bad.

The `class_option` stuff should be indented two spaces. Same thing for `method_option`.
We prefer the `desc` to be on the line above the method definition.
No need for this comment, it is fairly obvious
can -> could
Because this is being pulled into the crop function, $crop will always be true, so this was removed.
Why is this dependency both here and in the pom.xml file?

Being a general purpose helper library, isn't it safe to put it on the foremost pom.xml and be able to use everywhere?
Are we going with British spelling? ;) Unless we'll be using "colour" or "behaviour", let's stay consistent.
Do we need to take care of escaping here or does Twisted's template stuff handle that for us?
This code freaks me out, though maybe I just need to think about it more. But I'm weirded out by post-facto addition of LIMIT clauses to queries. This seems like something that the code doing the assembling of the queries should be handling. String manipulation like this seems inherently fragile to me.

Or if we're intent on doing it generically for all queries, then I'd rather us look at using something like `setFetchSize` on a JDBC Statement to ensure that the data from the result set can be lazy-loaded, and just use `(take ...)` or other standard means to ensure we don't iterate past the limit.
Not just for error logging, for trace logging as well so we can see all data interchanged through the RestAPI. I set up the logging in `beforeTests.js` so you can get a better picture.
If this method is called once for each tenant, then these results keep overwriting eachother. Again, I think your throughput results will be by a factor of C (concurrent tenants) low in this scenario.

This issue was in my data-loading code at one point I think, and I think I moved the throughput result calculation up into the `dataload` function.
I didn't know it was possible to have an `abstract private` method. Maybe it's better to make it protected, or even `public`. Could this be generally useful functionality?
renaming this to ``postStart``
Could this be useful elsewhere? I'm wondering wether it could be a good thing to have an Extractor for it.
Remove the code below.
Не помню, как в задании. Если сказано, что метод init должен вызывать метод родительского класса, то придется переделать. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Круто, я этого не знал, спасибо за науку :)

Вы меня убедили, я не настаиваю больше на том, что нужно объявлять DNA переменной.

Мне интересно, что такое сильные и слабые ссылки? потоки? И что еще может быть объявлено в @synthesize? И поскольку это полезные сведения, то было бы хорошо создать для этого отдельную тему в дискуссиях.

Спасибо!
нужно сравнивать не ссылки на объекты, а сами объекты типа NSString с помощью метода isEqualToString
В примере https://github.com/Hexlet/osx-project-1/pull/17 очень интересный алгоритм выбора элемента из массива с исключением повтора за один раз (метод +(NSString *)getRandomGene:(id)replacingGene в Cell.m)
Число, передаваемое методу mutate - процентный показатель, и вы об этом забыли.
зачем фигурные скобки?
очень хитро )))))
Indices can be duplicate, breaking rule "exactly p percent of gens should mutate"
760 is good for span8, I'll update the height to 350.

The re-sizing is done automatically when they upload pictures via creating new images of the desired width/height, and centering on the photo before cropping extra.
CakeDC Category plugin uses UUID.
Nice; I like all of this.
I debated about this for a while. The semantics for a command based on a can execute block vs. subscribable are just different. I don't think we want to conflate them into one method. So we have this property for when it's subscribable-based and the method for when it's block-based.
As above regarding the use of `NSValue` here.
Ah true, I'll set them all to nil/0 to start.
What's up with the indentation?
Similarly, the maximum value a `long` can hold is 9,223,372,036,854,775,807.

Would it be safe to consider that being able to report 9 **[exabytes](http://en.wikipedia.org/wiki/Exabyte)** transfered bytes is enough?
This can be "if not dir" which covers both cases. Good catch.
I don't have the folder anymore. I cleaned it out after dealing with it.

There wasn't anything that seemed out of the ordinary, it just looked like a typical SAB download that had failed to repair and extract. Mostly .par and .rar.part01 and such. There was a single episode that repaired correctly, but the rest were broken.

I do still have the original e-mail from SAB saying a download failed, that includes a link to the NZB if you would like me to forward it on.
ok fair enough. I was just asking at when you build the doc many sphinx errors appear because of imporper parsing of the docstring
... interesting what happens to the font size when writing a comment using an iPhone..
originally clusters could be anything that would be used for accessing. In 1 dimensions clusters are proper python slices returned by ndimage. I think it could be explained this way.
Needs an @since
I think it is somewhat odd that we want to have less provenance info on our release builds for the sake of a pretty name. That said, isn't the logic just no prerelease_version and commits since tag of 0?
I think you have to return after this line so you won't reach the:
deferred.resolve();
line.
"dosomething" was just an example I used in my pseudo code. We should use something sensible here like "dispatch".
如果后端服务器出现错误，nginx可以使用过期的响应缓存。这条指令就是定义何种条件下允许开启此机制。这条指令的参数与<link id="proxy_next_upstream"/>指令的参数是一样的。
You have 2 options:

1) Store it somewhere safe and then read it back in on postRestart, think EventSourcing or similar
2) Delegate all risky operations to children
It won't. It will just be bypassed.
thats not exact. We need simple layer between in ylib-ycp ( simple symlink ).
Эмм, а `id` чуть выше у тебя зачем?
Ты на себя бы посмотрел вначале :-P
reply утек.
that's just an example of what a location array should look like. memcache can split data across multiple servers, so I didn't want it to look like I was setting the same one twice.
Since this is ActiveRecord, you could probably simplify to `@page.conclusion?`
Please keep this line
This would fail if the translation include a double quote.
BTW, you should better use the p4.Dialog object for such use as it natively add dimensions, and properties such as "modal" "not-resizable" and a correct CSS z-index.
you don't need this route. index, show, edit, new, create, update and destroy are all created automatically by `resources :books`
What about `find("table.index")`?
will this hold up the PR?
It seems Vladimir already created it: https://issues.jboss.org/browse/ISPN-2641
Never directly instantiate ConcurrentHashMaps... see https://issues.jboss.org/browse/ISPN-1889 and https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/util/concurrent/ConcurrentMapFactory.java
yes, this is picky but, can you add a space before  :data, :toggle, =>, "modal", :vimeovideoid, =>, and video["id"]
Actually, I was wrong, in PEP8, docstrings are recommended to be at most 72 characters.
TestLaunchApp
interaction with whom, where, how?
Done in f15f723.
trailing ,
`Else` on previous line.
I changed it around so only `renderMenu(templates)` is waiting in the callback function.
i don't know.... i guess we should ask vojtech
without {}
I didn't manage to get to work correctly the time functions in shogun so I have 
used these ones taken from the standard instead
Please use 
for (...) 
{
    ...
}
Jo eště by mě zajímalo, co je tohle ..
Are you sure the method ``unserialize`` can be called on ``$this->adapter`` (of type ``object<Zend\Serializer\Adapter\MsgPack>|null``)? I found this a couple of more times on lines: 105, 114, 123, 132, 141, 152.
Having given it a bit of thought, I can kinda see the filter syntax working...

    {{ "Foo"|_ }}
    {{ "Foo"|_p('verb') }}

I only have a problem with the plural functions, and especially the ones with lots of parameters:

    {{ "Foo"|_dcnp("Foos", num, "verb", "errors", "LC_TIME") }}

That does seem a little awkward to me.

I think I'll certainly generalize all the `_*f` function out into a `...|sprintf` filter (if there isn't already one?), that makes a lot more sense.
so do we reuse hacks?  Is this a valid usage:

    my_crazy_hack = Hack("foo")
    def zing():
        with my_crazy_hack as hack:
            if hack:
                pass

Because we're only keeping the last time an event fired.
It has only been fixed one year ago. Are we sure all browser instances have been updated in the world?
I read that ifndef is portable where pragma is not: http://www.cplusplus.com/forum/beginner/7877/

However I have no strong opinions, whatever is in line with the community.

(Nb you have used ifndef in the existing testApp.h in this repo, I can change that too)
extract first_arg into a local, maybe more?
spaces around = here and above pls
Yes, so we do authorization only first time. And then do authentication. No? Yes?
You would get error, if you would do reference to the Comment document. :-) With string you do not get it, because you do not have to import Comment document. :-)

Yes, I think it would be better to move notifications to separate document.
Not really... The way I see it is, that we have only users which all have their profile page (user description) and account page (user settings).
Ok. I just assumes that there is no need because block content already has indent in plain.html. Will fix it.
omg, I did mix them.
Ehm, and here? You should do a better find&replace.
Ah, yes, need to fix not only that docblock. But anyway, we don't use it and we're providing a (pretty useless) additional feature to guarantee then.
`x`
I think there's a misunderstanding again. For the same reason, I don't agree with duplicate keys in a regular destructuring assignment `{a: a, a: b} = c` either. In the way that constructing an object like `{a: a, a: b}` would be possible by assigning to the `a` property twice, destructuring is happening by (terminally) accessing the `a` property in two assignments. And it should be unacceptable. The rationale for its unacceptability was given in the original strict mode issue: the only reason a key would be duplicated would be out of human error.
Should not remove the Infrastructure.Tests project from the solution.
Because the order in `StorageService` is not same the of `HostedService`
I have done such thing previously too, but i think it's cleaner to have a proper if statement and then just push to the template what you have to push.
Just a `CHECK(async_fetch_ != NULL)` with a descriptive comment?
Please add a space after //
So far I don't set df_model anywhere.  You're right that it would work for aic/bic calculations.  Will setting df_model = nnz_params work everywhere?  Is there a clear definition for what df_model should be?
Fair point, will inform when a revision is pushed.
I'm confused, the python Angle dox say -pi, pi but the C++ dox say 0, 2pi.  I think that the code is actually doing the former so this comment should be fixed, but can someone please confirm?
The texttt stuff goes off the right side of the page.  You could probably remove the spaces around the = for `add_to_image` to make it stay in the margin though.  This would also be consistent with the other parameters.  (Change the corresponding item in draw too.)
alpha please.
Here you are removing something that was fixed in an earlier commit. 

The following quote is taken from this page: http://stackoverflow.com/questions/12445392/pull-requests-overriding-earlier-commits
"A correct pull request should be applied in a fast-forward manner, which means a contributor should first rebase his/her work on top of the latest commit of the destination repo (ie git pull --rebase), before making the pull request."

Please make a new pull request in the way described.
http://stackoverflow.com/a/548337/577988 explains it pretty good
I would prefer NO_DIFF over SUCCESS, it is more neutral - what if we add an assertion expecting a diff ;-)
sorry , i know it's messy ><
Why not just include brooklyn/logback-file.xml, instead of declaring appender here?
Something like 'path for browser extension to install (webdriver).'
to prevent many launch files for just small configuration issues, there are launch file arguments (see http://www.ros.org/wiki/roslaunch/XML/arg) which can be used to configure included launch files from parent launch files or the console.

suggestion: introduce arg "base_topic" which is by default pointing to "/base_controller/command_safe" but can be overwritten by setting the argument outside of the launch file.

Using this approach we would on ly need one launch file for the interactive teleop.
This should probably be moved to the email.js tests since it has nothing to do with the actual `#send` method
bit curious why this context_manager is defined here?
Well, so one option would be to requre the bandit to provide idx and vals;  so then the question becomes "how does the bandit get them"?  Well ... I think it could GENERATE new idx, vals pairs first ... as a way to generate the other configs, avoiding the reverse problem.
there you go.
-Geoffrey Parker


On Mon, Feb 27, 2012 at 5:17 PM, amshali <
reply@reply.github.com
> wrote:

> > +  }
> > +
> > +  public static void getPhoto(Long photoId) {
> > +    Photo photo = Photo.findById(photoId);
> > +    if (photo == null) {
> > +      response.status = Http.StatusCode.NOT_FOUND;
> > +      renderText("");
> > +    }
> > +    else {
> > +      response.setContentTypeIfNotSet(photo.image.type());
> > +      renderBinary(photo.image.get());
> > +    }
> > +  }
> > +
> > +  public static void addPhoto(Photo photo) {
> > +    if (photo.image == null);{
>
> Could you please send a revision?
>
> -- Amin
>
>
>
> On Mon, Feb 27, 2012 at 5:12 PM, Geoffrey Parker <
> reply@reply.github.com
> > wrote:
>
> > > +  }
> > > +
> > > +  public static void getPhoto(Long photoId) {
> > > +    Photo photo = Photo.findById(photoId);
> > > +    if (photo == null) {
> > > +      response.status = Http.StatusCode.NOT_FOUND;
> > > +      renderText("");
> > > +    }
> > > +    else {
> > > +      response.setContentTypeIfNotSet(photo.image.type());
> > > +      renderBinary(photo.image.get());
> > > +    }
> > > +  }
> > > +
> > > +  public static void addPhoto(Photo photo) {
> > > +    if (photo.image == null);{
> >
> > BUG!  ; after if statement on this line.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/w7cook/OpenBook/pull/10/files#r493596
> >
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/10/files#r493628
>
Revert this line.
/obj/machinery/atmospherics/binary/dp_vent_pump/high_volume in code/ATMOSPHERICS/Binary/dp_vent_pump.dm
/obj/machinery/atmospherics/unary/vent_pump/high_volume in code/ATMOSPHERICS/Unary/vent_pump.dm
Actually I want to get rid of `Class` altogether.
Why would we not want to use a ConcurrentMap/ConcurrentHashMap and skip the synchronization below?
Do we have any usage to the method below? Looks like it's never used.
you got it

On Thu, Sep 27, 2012 at 5:27 PM, Cory Zue <notifications@github.com> wrote:

> In logistics/models.py:
>
> > @@ -477,8 +568,8 @@ def deactivate_auto_consumption(self, product):
> >          if ps.use_auto_consumption:
> >              ps.use_auto_consumption = False
> >              ps.save()
> > -
> > -    def notify_suppliees_of_stockouts_resolved(self, stockouts_resolved, exclude=None):
>
> I assume that whenever you deleted/renamed a method you verified it wasn't
> being called elsewhere (pretty sure is true for this one on malawi/tz end)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/rapidsms-logistics/pull/3/files#r1712335>.
>
>
Вроде у меня всё компилируется
```@Test(expected = RuntimeException.class)```
Should probably remove the 'sqlite' gem and update the active record version with a version. gem "activerecord-jdbcsqlite3-adapter", "~> 1.2.2.1"
What do you mean by HTML5 navigation events? `navigate` should get fired only on top-window `unload`. When the document changes, not the URL/location (think History API & `location.hash`). It's then up to the user of the target to check `document.readyState` and listen to `readystatechange`
strictly speaking, copyright only applies when reasonably substantial contributions to something have been made (a few fixes, a feature or two), but that doesn't matter so much.

This does need to be properly formatted, though:

Copyright (C) 2012 your-name-here <your-mail-here>
will do... though after entering Java world from C/C++ universe, this construction seems sooooo hot :)
Ok, I tested the alternative using a function like:

    cdef inline np.uint8_t is_in_mask(Py_ssize_t rows, Py_ssize_t cols,Py_ssize_t r, Py_ssize_t c,np.uint8_t* mask):
        if r < 0 or r > rows - 1 or c < 0 or c > cols - 1:
            return 0
        else:
            if mask[r*cols+c]:
                return 1
            else:
                return 0

The memory footprint is lower and the speed is untouched
This is the first occurrence of the word "boosting" and it doesn't explain it. Maybe so-called boosting iteration? Or "At each iteration of modifying the data, called boosting" or something
Sorry, I have some trouble parsing your statement. My point is that ''False is not None'' is a false statement while ''not False is None'' is a true statement. Afaik.
Sorry, on mobile right now.
-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.



Gael Varoquaux <notifications@github.com> schrieb:

In sklearn/linear_model/stochastic_gradient.py:

> @@ -449,7 +449,7 @@ def partial_fit(self, X, y, classes=None, > ------- > self : returns an instance of self. > """ > - if class_weight != None: > + if class_weight is not None: 

I am not sure what you mean by your remark, @amueller . 'foo is not None' is the right way to ensure that the test is not triggered only by the 'None' value.

—
Reply to this email directly or view it on GitHub.
Yeah, sorry that was not a practical example. :-) 

I think arrays work fine for instances like `(a,b,c,d,e)`, but I was kinda thinking the ability to do multiple packs() would be easier than arrays for situations where you may or may not have a multipart message, and if you do, it will probably have two codecs (technically).

So for something like a PubSocket, with *optional* topics. It might look something like:

```javascript
.send = function(topic, data){
  if (!data) data = topic, topic = null;
  var encoder = this.encoder.multi();

  // optional topic (defaults to "none" codec or something, its just text)
  if (topic) encoder.pack(topic);

  // body part w/ our socket's default codec set via .format()
  encoder.pack(this.codec.encode(data), this.codec.id);

  // fan out... whatever.....
  this.sendToPeers(encoder.end());
};
```
I think this should be a deb-specific target flag, since I don't think any other pacjage requires it. Thoughts?
__ZTC__ is obsolete.
remove has_traitsui and move the traitsui imports into the create_view function
always prefer a `static const` to a `#define`.  It makes for better type safety with the compiler.
missing space between the cast and the variable.

Btw, I'm not sure you need to cast it: if the property is not a boolean, the annotation reader will already complain when validating the annotation
Бүлгэмийн хэлэлцүүлэг дээр хийвэл илүү олон хүнд хүрнэ шүү дээ
A comment block like this should be placed above the function definition and as best wrap it into /* ... */. Also I don't think it's necessary to reference the browser code and why you have named the function that way. Re: bug 502389 can you make it a single line?
Don't want to sound pedantic here, but personally I don't find this naming very clear to what it actually means. What is "named" here that apparently this is a symbol for? Even when calling it symbol_for_name, it's still not clear what kind of symbol it is and what it is actually for.

Maybe something like "required_status" is better? What do you think would be a better name?
example app.  I don't really care about making it not use it.
Yep, good call. It has no effect. Turns out the incorrect error I was seeing on that line was due to the git diff being interpreted as the body, prior to my fixing that issue.

I've removed/reverted this redundant check.
I couldn't remember if it was something I had to write a migration for...

On 18 May 2012 23:04, Carl Suster <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,7 @@
> > +migration 9, :add_primary_to_image do
> > +  up do
> > +  end
> > +
> > +  down do
> > +  end
> > +end
>
> Why is there an empty migration? Either this doesn't need to be here or it
> needs to be filled in...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/contraflows/leacock-gallery/pull/22/files#r844824
>



-- 
jack moon  //   m 0417 393 638  /  e jack@contraflo.ws  /  w
http://contraflo.ws
@rsantander we can not add this css locator to @FindBy because the driver does not work with static webelements
You should use StringBuilder instead since it's unsynchronized and therefore faster.
Could this line either be switched to the cluster address (as in production) or to a dummy host?
ok.
>  I wonder what is the best practice for maintaining different coding styles in one project
in my company's team we are lucky that currently everyone on the .NET projects agrees to the default Resharper standards for formatting and naming. But I know that such an agreement is not always the case - especially if number of people gets higher.

> I prefer to avoid refactorings that don't increase code quality especially if refactored code wasn't written by me.
That sounds like a sensible practice. I'll try to comply. :)
I see. `DELETE` might be a little weird in that case. I don't really like those rpc style actions, though. I prefer the following

==>
    PUT /notifications/summaries/:id
    content-type: app/v3
 
    {unread: false}

<===
    200 OK
This was fixed, thanks!
sounds good! fixing
Would be nice to use send_request_cgi if it can be used.
I'm having a difficult time following the shape manipulations. The following are possible comments to add (if I'm understanding correctly) right before each line:

    # reshape image coordinates into xy-coordinates..
This commented-out line will be removed in the next commit.
Alright, will adjust all `if`s to be with `{}`
Given all the `SceneMode` checks in this function, I think we should make it delegate to separate 2D, 3D, and Columbus view functions.
I probably won't spend much time on this till Monday, so if you have spare time and want to change it, go ahead.
It is a big problem, right?  Because people will write texture coordinates into a vertex buffer, and they will need to update the vertex buffer if the texture atlas resizes.  Of course, the billboard and label collection handle this, but new code will also need to know to handle this.
For your scenario, the outline width needs to be 4 since that is how the width is defined.  Look at the draw calls in the code.

I should mention that this won't matter for long since the outline will be replaced with a material that implements outlines in a shader.
Let's also return `modelMatrix` in the object literal returned by `update` - it will be optional and default to the identity.  We can still have the public `modelMatrix` properties, but the rendering engine only accesses the one returned by `update`.  Again, this cleans up the interface and reduces coupling, depending on how we argue what coupling is.

This is a baby step.  When we return the list of draw calls (or even a tree) instead of having a `render` function, each will optionally have a `modelMatrix`.
Not necessary for the initial rev, but it would be good to autogenerate this (or dynamically determine at runtime) in the future.
Some minor formatting rules that we are using in Java.  { should be on a separate line for methods, and classes.   Otherwise,  { should be on the same line for everything else (try, catch,if,else,for etc...)
Same comment as CoverFlowView.
How do we the localizations to support these two new properties?
You have some null_false columns in this table, as a general rule you should add validations for those fields, and specs for those validations.

Also, any other fields that are required for the app to function should be validated & spec'd
So many uses of clazz[1] deserve an assignement :p