labofsahil/github-event-dataset-2012 huggingface dataset:
in addition to the above noted bugs that have been introduced in this patch, I'm also not a fan of blindly adding extra = here and there just because the linter says to. `typeof`, `toString`, etc ALWAYS return a string. There is no case where they don't, and there's no case where they return a falsy string like "0". So the extra = is unnecessary and clutters the code and increases the size (albeit slightly).

also, who is the linter to tell me i can't put my semi-colon on a separate line if i have a comma-separated list. I do that style of line separation so that, during debugging, i can comment out any line in the list without creating a syntax error. the linter complaining about this is obviously confused about ASI and thinks that semi-colon on next line is dangerous. It plainly is not, and I think it provides a value and avoids the syntax bug of accidentally commenting out the ending semi-colon in a list.

i'm not a fan of forcing third-party libs to undergo linting, or to have to adhere to a certain style. take the code as-is. And moreover, don't use the LAB.js source code in your project. Use the pre-compiled, pre-minified version which has passed all necessary checks and tests. Lint your own code, and let third-party authors worry about linting theirs. If your linter can't be relaxed on LAB.js file, then just add it as an ingored file for the linter.
@emmanuel @solnic I just made these changes due to some code that was merged, but wasn't checked with rake ci.

I just wanted to make sure that everyone was running "bundle exec rake ci" before pushing code up. It's ok if you're not using it between every commit, we just want to make sure that the code that is up passes the thresholds we've set, or those thresholds are adjusted.

In general, I have no problem with adjusting thresholds. The main thing is that it's done explicitly and with full knowledge of the programmer. If you add another method to a class and have to adjust max_methods, things aren't happening by accident. There's supposed to be a little bit of tension between code writing and this process, you should be asking yourself "is making this class bigger really the best way to do this?", etc. I find that happens all the time with other things.

Sometimes I'm so deep into coding it's only when reek/roodi blows up on me that I realize classes have too many ivars (thus too many Responsibilities), or knows too much about it's collaborators (Feature Envy), and that maybe it's a sign I need to refactor. Sometimes not, but I think it's a good idea to always think about it.
I think that there are some problems with this implementation of escaping.  I am wondering why we are setting the .innerHTML AND the .value of a textarea -- shouldn't we just set the value? 

To demonstrate the problem, look at this [fiddle](http://jsfiddle.net/johnthethird/e529e/12/) which is using the shopify master branch. Try typing into the text area.

This [fiddle](http://jsfiddle.net/johnthethird/e529e/10/) has the same code but with my mods from [here](https://github.com/johnthethird/batman/commit/ba53a471f10ccb244de7e1184190885615f4f3e9) and this seems to be the expected behavior to me. If I am on the right track let me know and Ill try and create a patch with better tests.
Should probably be: darray->length - 1
Oh, I see. The || is because you're clobbering a previous aret value.
piekrītu
see `IJAXBReportData` , IOException / InputStream
![meme](http://i.qkme.me/361qtx.jpg)
@Th0ar 什么时候回复。。。
@richarddong
@KiriX 
`cat mangos.log|grep VMSS >/home/mangos/source/bin/server.log`

короче, это до server.log , а не для крэш дампа.
@KiriX 
I think you mean this one
https://github.com/mangosR2/mangos/commit/81c678127601f2c834505010ba634b2c0055c957
much better with this patch :D
![shipit](http://shipitsquirrel.github.com/images/ship%20it%20squirrel.png)
likely not :)
It should do something... not sure what, when and why.
The `\t`, `\r`, and `\n` characters are all “ invisible” so if e.g. testing a function to harmonize line endings or indentation, the test output without using the escaped form will not be helpful.

By doing this, escaping backslash naturally follows to keep it from being ambiguous.

Escaping of the double-quote was added for aesthetic reasons (now that escapes were introduced). The entire string is double-quoted in the error output so it seemed wrong to have non-escaped double-quotes inside the string.

As for breaking tests, I assume it is breaking tests about how `asString` should format a string? I.e. the patch should have updated the test as well for the new output.
Yeah, ok, that's about the slowdown I saw too. I used random numbers to avoid LLVM's cleverness.
This should actually be a char-based substr, per the FIXME several lines prior
I have every Day at instance reset time a server freeze because the dungeonresetschueduler fire millions of sql-query. Mabye someone has a solution
for  me spellwork shows:
ID - 69065 Прокалывание
AttributesEx3: 0x00130000 (SPELL_ATTR_EX3_UNK16, SPELL_ATTR_EX3_UNK17, SPELL_ATTR_EX3_DEATH_PERSISTENT)
This is just a test comment.
Yes but i'am developing those scripts for "my" Repack not for yours.
I hope you understand that it costed me weeks to write the scripts.

You can copy the scripts in 2 months or so but not yet!

If you want to develop with those scripts i can add you as a contributor.
Hi, how do you apply this patch ? I can't find the file in my install of TinyMCE :/ Thanks a lot !
from now, because the others are already in... i will test this approach soon...

Fabian Gander

Am 05.02.2012 um 19:31 schrieb Yannick Charton<reply@reply.github.com>:

> Hi Fabian,
> 
> In fact, I didn't do a pull request for that """"feature"""", as I didn't think it could be useful somehow (and especially after you fix for old IE).
> Generally, when I think something (feature, bugfix,...) could interest you, and if it is finished, I create a pull request.
> 
> 
>> Did not merged it directly, but over the other branch 
> "contrib-integration" and then merged with the master (for test them 
> first).
>> Hmm the graphs looks not nice now looks like you have to make
> pull requests to the contrib-integration branch, then it will 
> 
>> perhaps 
> look better in the graphs. Is this possible ? I thought that it will 
> recognize the flow Angelo and me defined, but it looks not...
> Concerning you problem with the graphs, I had a look at the pull requests, and it seems that I cannot change the destination directly. The only solution is to close and recreate the pull requests. Note also that in github the destination of a pull request is by default the "master" branch. It's also a bit strange to do the requests on a branch which is not the master one, but why not.
> 
> Do you want me to recreate the 4 last pull requests? Or do you want me to use from now the "contrib-integration" branch?
> 
> 
> Cheers,
> Yannick
> 
> 
> 
> 
>> ________________________________
>> De: Fabian Gander <reply@reply.github.com>
>> : Yannick Charton <tontonitch-pro@yahoo.fr> 
>> Envoy le : Dimanche 5 fvrier 2012 19h04
>> Objet: Re: [NConf] added a warning if the client browser is not supported by NConf (16704d5)
>> 
>> Good, I will ignore that. Thanks anyway for the contrib ;)
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/Tontonitch/NConf/commit/16704d540150f30d5a44f235874537e9447dc051#commitcomment-934505
>> 
>> 
>> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Tontonitch/NConf/commit/16704d540150f30d5a44f235874537e9447dc051#commitcomment-934551
Good to see Motor is being worked on again.
We can added some new attributes for VM class,  vm.vcpu_threads   vm.vhost_threads ....  they can be assigned after creating VM.
An utility function is also needed.
nope, this means, rename this class, and/or rename the other class currently called wave index. there is a complementary comment in that file too.
Keep it up, the test cases are one of the aspects that distingues the project and makes it possible to have a small dev team. ;-)
у тестов есть свои фикстуры, поэтому было бы правильней разместить файл для тестов там. А так получается действие с файлом (не с кодом), который не относится к тестам уронит эти самые тесты
500% seems a little off to me... is there another way you can do this?
The patch is correct, I will merge it soon.
Will the Hibernate 3 adaptor also need to start the classloader service?  And need to atomically create it?  If so, might be better off synchronizing on a common class or object.
Move this code to `view-portlet.html` instead of including it.
Daniel, was this on purpose?
I tracked the problem to the `delete-trailing-whitespace' which changes the position.  A tiny fix for the above is to replace `(setq p (point))` with `(setq p (point-marker))`.  Do you want me to resubmit a modified patch?
This conflicts with commit c825594ebe34fefc52980654e8684d1869935d94 which removed pc from the global namespace.
This works for me, or at least displays a piano roll. Doesn't look like there's any code to play it yet. The Seesaw dep in project.clj was wrong. I fixed that so maybe that will get it working for you?
you could just `del role_choices[-1]` if the `allow-refuned` switch is active, but this works too. this is all temporary anyway.
You may want to use the WEB macro which does not need http://
すんませんです。修正してpushしました
https://github.com/mumurik/xyzzy/pull/25
Yep, that's right. It should be ok now. Thanks.
Check s.empty first is better.
john...
What `:dummy` is for?
Is this should be tested?
assertArrayHasKey, assertEquals? :)
Works fine for me. If someone wants to ```import *``` from this module they'll just have to rename these symbols, no reason why we should have to do that for them.
Having
Device(1): {name: 'xxx 100%'}
Device(2): {name: 'yyy 90%'}
tag  #{select 'device', items: devices, labelProperty:'name' /} cause Exception.

So should I create property that return escaped name or what?
i have this link...i used the patch for 2.3.4 but the same error...what change between the patch in the kernel and this on github?
That should have been `inst_material`, right?

I've renamed all the `inst_materials` to `instance_material` on this commit:
https://github.com/mrdoob/three.js/commit/b716ed40408aeb5d16788a70c1abcca56453347f

Let me know if that's how it's meant to be.
ok, awesome but how to turn it off when click a different pjax link?

thanks,
tim
Not sure what you mean...

```
1.9.3p0 :001 > def f(*args) ; p args ; end
 => nil 
1.9.3p0 :002 > f <<A, <<B, "line three"
1.9.3p0 :003"> line one
1.9.3p0 :004"> A
1.9.3p0 :005"> line two
1.9.3p0 :006"> B
["line one\n", "line two\n", "line three"]
 => ["line one\n", "line two\n", "line three"]
```
Didn't knew this when I wrote the last peace of code there regarding the "gzip" encoding... thank you for clearing this out!! :)
These are empty, I didn't commit them since they don't bring any value.
So do we merge this in or not?
escape $index in sel\_other\_detail\_$index
Please do not use inline styling.
This deserves commenting.  This is good that this stuff is getting refactored a bit, and we should take advantage of this to better document what the code does.
Well, you're right, BOOL/bool is not a problem. Commit that breaks action is actually this
fixes issue #1305 - https://github.com/cocos2d/cocos2d-iphone/commit/3d4895a4208c0893e89dc793ecdebb59772de499

So latest commit in which actions work is:
CCSprite: displayedFrame -> displayFrame - https://github.com/cocos2d/cocos2d-iphone/commit/149d3bb7cdfbf35862f4c701c898a32f687e157e

Sorry for mislead, I really thought the problem was with bools
I'm really worried about SEO and color : transparent; maybe i shouln't ?
Yeah your right, i tought it might be a good example how to use it but maybe it's better to leave it out
Well like I said, up to now it was c.l.Character, but with Stef's new stuff I don't know, so you should listen to him :)
Should be this.INITIAL
hell no... this was based off solinorons work, 
just alot of what i was seeing had looked exactly the same as what we had done at Skyfire and trillium, 
since none of that was his work and no mentions to the others that had worked on it i got pissed off...

enough for everyone not to say in the least, but i got over it, cuz the fact is:
 doesn't matter who designed what and where ... 
(and the point i should have been looking at) the fact is that it is now working...
can you fix this warning too ?  

warning C4351: new behavior: elements of array 'PlayerTaxi::m_taximask' will be default initialized

player.cpp

PlayerTaxi::PlayerTaxi()
    : m_taximask()
{ }                        <<<<<<<<<<  Here
What the fuck are you talking about, Bootz?
I'm not sure what the best solution is, but I like modules to be self-contained so I can run, for example:

````
puppet apply  --modulepath ./modules -e 'class { "newrelic": license => "123abc" }'
````

I think the `command` should definitely contain the full path to nrsysmond-config since that program is being installed by the module.
Git version builds. "0.13" version does not build, because JPA.getJPAConfig(unitName) wasn't added in Play! 1.2.4. I'm mavenizing different Play! modules for use with my Maven Plugin for Play! Framework (http://code.google.com/p/maven-play-plugin/). I download a released version, create "pom.xml" file, and build with Maven.
:+1: nice use of json to guarantee unicode in & out
52060, 52061 spell is fail.
Maybe it's time to remove these arenas from the disables table?
actualizado el código y el wiki para poner localmente la app
That is so cool, thank you! Have to play with this as soon as I'm home!

The parser spec in krypt should work with krypt-core-jruby right away. I first had the specs duplicated for both krypt-core-jruby and krypt-core, but then I figured this would be harder to synchronize. I also felt krypt was the best place to put them because I see the specs as a way to test and specify the behavior of krypt as a whole on the Ruby level, regardless of the implementation being done in native code or in Ruby... From your comments I would take it that you feel the same?

I run the specs locally by running them with -I<path to krypt-core-jruby>/lib -I<path to krypt>/lib, but I understand that's not an option for automated tests :)

So, regarding your points:

1. If you think it would be better to have the specs also in krypt and krypt-core, too, I would suggest we develop them on krypt, making krypt the master repository for specs and tests and then we simply copy them to krypt-core and krypt-core-jruby as needed for now? It would be nice, of course to have something automated for this process :) Maybe a commit hook could do it?

2. I added a test/unit test for Krypt::Asn1 yesterday, to see whether the basic principle of lazy parsing is working. Right now, some of them fail, because the values are not decoded to Ruby values yet. We could certainly expand these, for example we could merge in the Asn.1 tests from ext/openssl. I wanted to start a spec for Asn.1 today, and I guess it would become rather large. But if you want to, please feel free to start one yourself, or expand the stuff that's present today. I'd appreciate it a lot!

3. That would be awesome, because I have no experience with code coverage for C code! I also thought of maybe using something like Valgrind for krypt-core and maybe Findbugz or something equivalent for krypt-core-jruby. Continuous integration would be another nice to have...

I'm not sure how to prioritize, so please feel free to do the things you like best and that are most interesting to you. I will appreciate anything :)

To give you a short overview of what's missing functionality-wise:
In krypt-core the only thing still missing in is the encoding/decoding of the raw byte values into the appropriate Ruby types. Once I've committed the Asn.1 class for krypt-core-jruby, it will also be missing there. Another thing still missing, but I'll probably add this today, currently "Asn.1 headers" cannot be created from scratch without having parsed them first. 

My plan was: 

- Add "create headers from scratch" today
- Complete Asn1 class for krypt-core-jruby on Wednesday
- Complete Value en-/decoding by the end of the week

Next week:
- Finish docs, complete tests and specs (as far as is reasonable)
- Benchmarks comparing to OpenSSL::Asn.1, but also to other existing Java and C implementations
- Final report
I dont get teh new plugin visible at all. After a reinstall of the module etc. Did you do anything special?
could still be static?
EXC_BAD_ACCESS on using 3d view 

    glGenLists + 15
    run_view() + 229 (3d_view.cpp:137)
    main + 1906 (terrain_generator.cpp:293)
    start + 52
The same : I will use Element el_wrapper = writer.element("div", "class", "t-banner", "id", "banner_clerrors_"+formId);
will it require changes in the bundle for the integration ?
Thanks! I've shaved off 20 lines of code :-) - will push update.
This looks good. Thanks :). I will test it today evening after my classes are done with.
Yep - both this and the bukkit interface updates (the methods are in both Block and World) are now in Bukkit and CraftBukkit, as well, as of last night.
Seems a bit hacky to me as well. Isn't this what we are after ? 

http://stackoverflow.com/questions/792035/how-do-i-cancel-a-text-field-edit-in-a-uiwebview
maybe revert this.
I posted my last message before I read your response.   What did you try in psql?
Угнич - хуй!
All of the files in /public/admin/ should be GPL'd still.
What about an immutable`Set<ClientRecord>`? I don't think there's a need for the String in `Map<String, ClientRecord>` but Iterator doesn't have a size() method which I'm using in the tests.
It'll break if you have a computed observable that triggers re-evaluation of itself during its initial evaluation. I thought I had fixed it, but it got lost somehow.
Since we're no longer doing an `rm -rf` each time, shouldn't we do `git clean -xfd` to ensure there aren't any untracked files/directories, left over from someone trying things out on the box?
Ok, thx!
To me method validation *APIs* are not for users or very rarely for users. Framework and other interceptors will make use of them. That's why, I was hoping not to pollute `Validator`'s space
change all this into

# mount fstype  device                  [device2]   [fstype2]   [fsoptions]         [fsoptions2]

/boot       bml     boot	  	
/cache      ext4    /dev/block/stl14        NULL        rfs         NULL                llw,check=no,nosuid,nodev	  	
/data       ext4    /dev/block/stl13        NULL        rfs         NULL                llw,check=no,nosuid,nodev	  	
/recovery   bml     recovery	  	
/sdcard     vfat    /dev/block/mmcblk0p1    /dev/block/mmcblk0	  	
/system     ext4    /dev/block/stl12        NULL        rfs         NULL                llw,check=no	  	
/sd-ext     ext4    /dev/block/mmcblk0p2

for work with new CWM ;)
It might be related to this ticket:  TRUNK-2682
Modify Concept getNameInLocale(Locale), getPreferredName(Locale), getFullSpecifiedName(Locale) to find names that have compatible Locale matches if no exact Locale match

I'm thinking the answer might be to remove preferred name as an option since this functionality is a little wonky.
@Mook, @GeekShadow, @rsjtdrjgfuzkfg ...all this branding I've done and despite the edits the appname is still "Songbird" within the application itself...any idea where $(SB_APPNAME) is defined?
`INHERIT` — это модуль (и по совместительству функция). Модули мы сохраняем в переменные в верхнем регистре.
`U` — это модуль, но есть ещё системный `util`. Чтобы не пересекаться по именам предлагаю util проекта подключать как `U`, а системный как `UTIL`.
`Plan` — это модуль и по совместительству класс. Классы мы сохраняем в CamelCase. Вот здесь есть расхождение с `inherit`, да. Не знаю, что с этим делать.
Может стоит уметь принимать объекты нод в качестве parents, children?
Yes, this would be possible. But I do not understand why do you want to do this? The variables n_rows, row_ptr, col_idx and data "belongs" together. In my opinion the convert function is responsible to initialize n_rows, row_ptr, col_idx and data. I would not split the initialization to different places.
I believe this message displays after any installation where the requirement is currently satisfied, not just upgrades. So if you performed

```bash
pip install Django==1.2.3
```

and you had Django 1.2.3 installed, you would see:

```
Requirement already satisfied (use --upgrade to upgrade): Django==1.2.3 in [...]
```

whereas if Django was a dependency in install_requires that was satisfied but would be force-upgraded with `--upgrade-recursive`, it would instead display:

```
Requirement already satisfied (use --upgrade-recursive to upgrade): Django>1.2 in [...]
```
I mean you can just do `var args = arguments`.
This should check for `Y.config.win` first before checking if `"msPointerEnabled" is in it.

Probably work `var win = Y.config.win` given that it's used frequently.
Chrome versions below 6 reported touch support when it didn't support
it. Satyen should have the proper details for it.
Thanks, that looks like a better way to do it, I'll try it.
It might be better to have a small button whose caption is "..." on the right side of the input.
Remove this, and just make doc a prerequisite for update_docs?
We might want to brainstorm about a new name :-)
Don't put code in the .rt docs, it's a maintenance nightmare.
Please use the same approach used by the other docs, where compiled and tested code is automatically hoisted into the docs.
ah, but what if the gossip fails, e.g. picks a node that happens to just become unavailable?
is that still ok?
StateNames?
that's what I get for copying and pasting!
do we need a barrier after starting first?
most tests have that, but I'm not sure if it's needed, what happens if second tries to join before Cluster extension of first is started?
Yep :)

Sent from my iPhone

On Jul 12, 2012, at 2:05 PM, Viktor Klang (√)<reply@reply.github.com> wrote:

>> +
>> +.. includecode:: code/docs/camel/Introduction.scala#CamelActivation
>> +
>> +The above code shows that you can get a ``Future`` to the activation of the route from the endpoint to the actor, or you can wait in a blocking fashion on the activation of the route.
>> +An ``ActivationTimeoutException`` is thrown if the endpoint could not be activated within the specified timeout. Deactivation works in a similar fashion:
>> +
>> +.. includecode:: code/docs/camel/Introduction.scala#CamelDeactivation
>> +
>> +Deactivation of a Consumer or a Producer actor happens when the actor is terminated. For a Consumer, the route to the actor is stopped. For a Producer, the `SendProcessor`_ is stopped.
>> +A ``DeActivationTimeoutException`` is thrown if the associated camel objects could not be deactivated within the specified timeout.
>> +
>> +.. _Camel: http://github.com/akka/akka/blob/master/akka-camel/src/main/scala/akka/camel/Camel.scala
>> +.. _CamelContext: https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/CamelContext.java
>> +.. _ProducerTemplate: https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/ProducerTemplate.java
>> +.. _SendProcessor: https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/processor/SendProcessor.java
>> +.. _Endpoint: https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/Endpoint.java
> 
> Alright. Tackling Java documentation now?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/562/files#r1148983
I think you know this better than me.  That sounds correct.  I'm not even sure how/when this came it here.
Switched out `defn` for `fn`

I started explaining what this does. Decided it was better to do it in the code. Documentation added.
The upper bound (limit) for the number of selected items seems useful. For example, an opinion poll question, could say "Pick your three favorites." If the user tries to pick more than three, there would be no selection action. If the question were, "Pick at least three items", then the user would pick some items, and if at the end of their selection session, perhaps ended with a push of a "Submit" button, the program would check the number selected and handle the case of < three items. But the selection machinery itself doesn't have to react to a minimum selection limit, only a maximum.

In both cases, the program could observe selection changes. In the case of a maximum (limit) of three, on an attempt at a fourth, a pop-up could show. Or, the program could just set the limit, and leave the user to realize that they have hit the limit. In the case of a minimum, the UI would need a "Submit" button or some equivalent, and then it would check the sel count and show a pop-up perhaps. 

Does that make sense?
BLOCKER: Still has the progress report accepted in the StatusMixin constructor. I'm almost positive this was the only use of it.
This can be restored if/when it is implemented.
I want to rename this function at least. It should be named similar to:

````
bool URIUtils::ProtocolHasEncodedHostname(const CStdString& prot)
````

so a function like:

````
bool URIUtils::ProtocolHasEncodedFilename(const CStdString& prot)
````
yeah this gets kind of messy when new types are added to CFileItem. but it's not related to this PR indeed, so we can pick that up later
Haha nee, maar we zijn ook nog niet in productie toch ?
No; Removed.
I'm not sure this is the right way to go for accomplishing what you want. Can't the backend / string type its parameterizing just be a member variable passed to a constructor? This seems overly complex.
It can fail in multiple ways. In type setter, after library call it should check if there are any exceptions by calling self.raise_exception().
If you commit this I will try to fix that and write basic tests (Image.alpha_channel property affects Image.type).
Added full list of JavaScript preserved keywords so developer can avoid using them in object property.
Duplicated code here. Have you considered setting the duration of the animation to zero if it shouldn't be animated?
This conditional doesn't make sense to me. It's either wrong or needs documentation.
This duration should be in a constant.
As above, `contentMode` should be cast to the type used in the format string.
Hah, wat?
How about we move them into a `TUIView` private header? This way, any `TUIView` that needs to know can just import the header and automatically know.
Never though one could use cut this way...
How does the needview defined two lines above fit in here?
Ah, I didn't know that! Thanks, I'll update this text.
это уже решенная проблема - уберу
предлагаю заменить dissectable на dividable. ну и все остальное везде тоже по аналогии
Please, use 1.9 hash syntax here. Thanks.
`Rails` is uninitialized on that step(i just treid)
This line break looks a little bit weird :)
Ah, the other pull request hasn't been merged yet, but they will conflict right?
Not sure why I did that, fixed
Also even if the paragraphs are empty we need to pass the `html_options`
Why did it change here? :)
This is better as one line IMO.
consider avoiding the var using

```
val loader = ScalaClassLoader.fromURLs(classpath, self.getClass.getClassLoader) match {
  case loader if  global.settings.exposeEmptyPackage.value =>
    ... 
    new AbstractFileClassLoader(virtualDirectory, loader) {}
  case loader =>
    loader
```
Wow, I didn't know that either. Thanks for the alert.
Not worth the effort to write a test-case.  You've almost certainly already generated a stack trace.  One more object allocation is not going to break the bank if it manages to slip back into the library code.  (May be worth test cases for Success(value) vs. this, however.)
Is it possible to not comment the tests out, but making so that we test that it fails with -optimize, so the guy who fixes SI-6188 also can fix the test?
This is the second run on body stats. Isn't it possible to move this inside the first flatmap?
line too long and trailing whitespaces.
We try to keep the lines under 80 characters. Could you write it as 


```
    assert simplify(cosAsExp*tanAsExp).expand() == (
        sin(x))._eval_rewrite_as_exp(x).expand()  # issue 1242
```
Why isn't the if-condition needed? (I can't tell from the code changes.)
It seems unnecessary to have this class. Why would somebody use it instead of just writing the expression.
I think you are right that `subs` should be simultaneous, so let it stay as it is now.  I did have doubts when I was writing the comment, but decided to post it nevertheless.

"Big Elephants" is a cool example :-D
Could you please add the same "warning" as in the `Inverse` and `Transpose` docstrings i.e. that this is unevaluated.
I still suspect this will work if you do the depth-first followed by the application of the hint as suggested at line 1607.

OK, that's it for tonight.
`r2` is an expression, so it is not callable. I tried `r2.evalf()` but `evalf` does not work when the answer is an mpmath matrix. `r2._imp_` returns the `_imp_` of `r2.func` so there may be a deeper problem here:

```
f(x).func == f # this is ok
f(x)._imp_ == f._imp_ # this does not make sense as you already remarked
```

Anyway, this seems to be a bug in something around the `Function` classes, not the behavior of `nsolve`. I should update the test so it uses the stricter semantics.
No I haven't checked the commit log of round and int. Could you provide me the link or any command in git so that I could take a look at it.
I don't see a reason to use a ternary operator here.
Be my guest....
Before I do a build - let's restore this file on your branch. I'll come by and we can figure it out. LMK when you are free.
Nevermind; my mistake. I thought the second line was installing something else (a pip bundle or something).

I guess we want to install a Kotti release here, not master.  What about you point pip to the requirements.txt from the 0.8a1 tag, and then `pip install Kotti==0.8a1`?

For the future, maybe we can move to a one-line installation.  Let's discuss, should we release a requirements.txt file along with every release?  One that includes the right Kotti version as well.  This would save us from having to install Kotti separately.
You should have this in your global .gitignore.
Fixed in 616efdf
@lyrixx not really. If the user is already fully logged (remember_me token), he is simply given a chance to authenticate fully. If the user is already fully logged, he should simply receive a 403 response
You should leave `composer.json` and `composer.lock` in state.
I don't think we should set a default method, the user should be explicit (somehow).  Also, if somebody does explicitly pass something we definitely shouldn't be changing it.
another empty constructor here ;-)
Should include the exception message and backtrace.
Move back to fieldset.
No, there wasn't. Please take a look again.

Old code:

		<li id="display-panel-tab"<!-- IF not S_MERGE_VIEW --> class="activetab"<!-- ENDIF -->>
			<span class="corners-top"><span></span></span>
			<a href="#minitabs" onclick="subPanels('display-panel'); return false;"><span>{L_DISPLAY_OPTIONS}</span></a>
		</li>

Your code:

		<li id="display-panel-tab"<!-- IF not S_MERGE_VIEW --> class="activetab"<!-- ENDIF -->>
			
			<a href="#minitabs" onclick="subPanels('display-panel'); return false;"><span>{L_DISPLAY_OPTIONS}</span></a>
		</li>
My objection is to using display name as style identifier.
Empty, can be removed completely.
Yes! Great catch. Fixed.
lock 和 unlock 的也不用了。
Wouldn't you want to make this a String (so this becomes properly immutable).
Yup. That does make sense. I didn’t even think of the example of passing an array in. Update coming.
temporary?
@drewfish "mojito compile views" is pretty dummy today (it doesn't select specific views per context, etc). Shaker does a better job in this area, but still I feel that, sometimes, having the ability to serialize a partial and sending it over to the client side to execute a particular process without all the hazard of compiling all of them during build time is a nice to have feature, specially if you have some sort of logic to pick the right view programmatically rather than a fixed value.
Ещё раз про обновление количества показов. Такое решение в корне неверное. Во-первых, оно ограничивает тебя возмодностью запуска только одного сервера node.js, что сразу же убивает горизонтальное масштабирование. Во-вторых, ты на каждый запрос баннера лезешь в базу. Это лишняя огромная нагрузка.

Думаю правильным решением этой проблемы было бы делать следующим образом.
В базе завести отдельную таблицу вида:
id(первичный ключ) | дата (с точностью до дня) | n(номер интервала за день) | banner(название баннера) | value (количество показов в этот интервал)

Интервал за день - внутренний конфиг сервиса, например пусть он будет равен 5 минутам.
Тогда каждая нода будет в переменной считать количество показов каждого баннера и, например, раз в 10 минут, записывать эти данные в базу, удаляя у себя.

Плюс нужно будет добавить в каком-то виде крон, который обновляет информацию о баннерах(что показы закончились), либо попытаться каким-то образом обойтись без крона(что мне больше нарвится)
Ouai mais regarde
SurfaceDisk you can loadFromFiles() or equip() with the data structures directly. I wasn't sure which was preferable, so I left both. surface_searchlight takes the data structures or an already-equipped SurfaceDisk.

I thought surface_searchlight would be helpful, but I haven't found the need to use it, myself, so I would be fine with dropping it entirely.
you're doing a repated check here. 

```
if(selectedPatient.item)
{
  document.getElementById("item").value = selectedPatient.item;
}
```

rather than writing each check 1-by-1, suggest you may an associative array of items (Name, Id, Age, .., etc) and use a for .. in loop to iterated through them. Should save some lines of code and also makes it simpler to understand that you're repeatedly doing the same thing.

Only issue is where elementName != the way you've stored it in localStorage... for example patientName != Name here
```getElementById("PatientName") vs ```selectedPatient.Name```
opening brace
The the memory is not aligned to the elemsize, we could cross a bondary, but with the current code and driver this won't happen. This is extra safety that don't loose anything. I'll add a comment.
If we don't do that here, we won't be able to get the full precision if that is what we want.

What can be done is in Eigh.grad() do the cast. Is that good with you?
This is not my understanding of INTERSECT ALL behavior. I believe that duplicates should only be output to the extent that they are DUPLICATED in all tables. So, if my first table has 3 duplicates "A" rows and 2 duplicate "B" rows and a unique "C" row and my second table has a unique "A" row and 2 "B"s and 3 "C"s, I get the "low water" overlap a output: 1 "A", 2 "B"s, and 1 "C".
You can drop m_stmtsBase. It is not really used.
Changing globals that may affect other tests in your test is frowned upon.
enum typedefs are moved to after their definition, as g++ has a problem with typedefing or forward declaring enums, apparently.
noooooooo.

no space before `:`
Switch to ghost_unconnected_pads=False or s/parse_bin_from_description/parse_launch/ so we create a bin?
I'd prefer: 

```ruby
puts_columns modified_outdated, :star => installed, :green => installed
```
Use a list:

```rb
system "make", "PREFIX=#{prefix}"
```
Best approach here is probably to skip `make install` and just do it like this, for example:

```rb
system "make"
bin.install 'ndiff'
man1.install 'ndiff.1'
```
I would rename this check_niimg
(that is, in your other pull request)
Seems like the comment here is deprecated :-)
Would it be a good idea to have this check happen for everything by default with the option of turning it off / providing a list of known Models?
Does oauth actually _require_ https? I'm wondering if I will be able to update my reddit install to handle oauth without https since I don't believe the reddit install script configures that at all.
But the error here is that prev_public_description_id does get updated and therefore the assert doesn't work. If it's a bug on Reddit's end, I think we should straight up raise an Exception so it becomes clear to anyone that this is an upstream bug that will get fixed shortly, rather than make it appear as though PRAW has a bug.
These aren't really 'widths'. I think it would be easy to accept an actual list of widths, e.g. `[4, 8, 5]`, assuming each field begins where the last one starts. It wouldn't be able to read overlapping sections, but I can't imagine that's a common use case.

Also, is there a particular reason to use inclusive intervals, rather than half-open intervals like Python normally uses? If your fields are back-to-back, it's easier to see with half open intervals `[(1,4), (4, 7)]` than inclusive intervals `[(1,3), (4, 7)]`.
This file should be named by it's use, not a generic "helperModule.rb", also camel case shouldn't be used for file names (anti ruby convention). This module is scoped for auth methods, so call it something descriptive, like

    authentication.rb
Maybe add a --ssh-directory-group parameter?
This loop is performance killer, can we improve?
important for deployment to Maven central and sourceforge
the maven uses maven-deploy-plugin in deploy phase where distributioManagement section is necessary and must be specified
that section must use url
if you deploy with a protocol e.g. http or webdav or ftp, you should use the extension
it is telling the maven that the plugin's ClassLoader will extend the classpath by the library of wagon - it's the implementation of wagon API

did i answer your question?
wrongfullyTyped is now an odd name for this field, no?
Please no commented code. Is this required or not?
Randy, I've pushed my changes so you can update test in the pull request?

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Wednesday, July 18, 2012 1:07 PM
To: Ty Voliter
Subject: Re: [brackets] fixes issues #1270 #1271 #1272, ESC key handling with popups (#1276)

> @@ -689,7 +690,12 @@ define(function (require, exports, module) {
>          // insert into DOM
>          $("#context-menu-bar > ul").append($newMenu);
>          
> -        PopUpManager.configurePopUp($popUp, closeAll);
> +        var self = this;
> +        PopUpManager.addPopUp($popUp,
> +            function () {
> +                self.close();

REMINDER: need to update new context menu unit test I added in pull request https://github.com/adobe/brackets/pull/1273 to uncomment line that checks for contextMenuClose event.


---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1276/files#r1191389
I have thought a while about this and asked my wife who studied German and Linguistics. It is not a "bescheidener Anfang" nor would I say we are "demütig" (abject). The meaning as I get it is that this is just still early in the process of building a product and that this should be taken into account, in other words a passionate start but not a complete version close to 1.0.

I will merge as it is but I feel this is not an appropriate translation, its one of those things where you can get lost in translation.

THX,

Peter :)
Didn't thought about the other extensions... should we refactor this in a `utils/Resizer` module with a simple API to make an element or extension resizable and initialize its behavior?
This API change might break extensions that use it. Jochen's Spell Checker (https://github.com/couzteau/SpellCheck) is the only one I am aware of that uses it, but this change should be announced on the brackets-dev forum in case there are others.
Should there be a unit test that selects all text and then calls getModeForSelection()? With the current implementation, this should return "html".
Yeah, I agree.  I tried commenting those lines out and everything seems to still work fine.
issue #1069 is already fixed, so please remove this comment.
These three lines are copied from Garth's original colorSetter() function. So Garth might be able to answer your questions. In my testing without these two lines seems to be ok. We call _correctColorString to convert user typed color string to the string that tinycolor will convert to for a valid color string. Another reason that  we call _correctColorString is to filter out incomplete color strings since tinycolor will automatically correct the input string as in the example I listed in the comment. And we explicitly use correctedColor in commitColor call so that we always correct the missing spaces between a comma and next color value in RGB or HSL formats.
boldName and rPath also need to be escaped (although not as URIs -- just ```<``` and ```&``` need to be escaped).  Do we have a regexp utility for this somewhere already?
I understand why you've chosen to pass dataglob alongside kurt_files, but I don't like the asymmetry between the kurtosis and data files.  

Your code will work fine *so long as the filename structure of the data files does not change*, and has the advantage of ensuring we read the datafile corresponding to each kurtosis file.

Something similar may be obtained by passing a dictionary of filenames / waveforms indexed by station name, as we do for the migration. 

As this code does not break any tests, I'll pull it as it is, and add an issue to work on the dictionary.
The `riak_kv_test_util` module is still trying to use this function: https://github.com/basho/riak_kv/blob/master/src/riak_kv_test_util.erl#L247

What should it be doing instead?
```el-get-update``` is not meant to be only sync.
May be just a little message "There is no script to execute" or something like that ?
try:
        http_if_none_match = int(request.META['HTTP_IF_NONE_MATCH'])
    except ValueError:
        #return debug.technical_500_response(request, *sys.exc_info())
        #what goes here?
You'll probably want to make a const for these, right?
why 97? maybe add a comment here as to why were using the magic number 97
Do we need all the comments?
Spacing for `rgba`.
`Media` objects should already have an up-to-date `ready` property.
Adding googlemap as well?
Please add them back in
Nope, `SYSCONFDIR=/etc` is without `$(PREFIX)` and `$(DESTDIR)` will usually be empty, if not packaging (the intended user-tweak is `$(PREFIX)`)
Feel free to help make it shorter and clearer if you can.
Note: it seems like Python 2.6's `httplib.HTTPConnection` *does* have a `_set_tunnel` method, and its implementation appears identical to Python 2.7's.

Python 2.5 does not have any such method.

Personally, I would be +0 on using something like:

```python
  if scheme == self.scheme == 'https' and self.over_http:
    set_tunnel = getattr(conn, 'set_tunnel', None) or getattr(conn, '_set_tunnel', None)
    if set_tunnel is not None:
        ...
        set_tunnel(host, port)
```
s/id/Id/
It's basically copied from another place in the existing code ;-). I don't know the code well enough to say what can be left out.
can't we use the types enum to avoid this loop?
I'm thinking about pulling this out and using the inherited subclasses in islandora to implement class autoloading.
true, false, nil doesn't seem the best way to handle this, because nil and false are almost the same. what about returning symbols :yes, :no, :skip instead. It's also more flexible in case we wanted to add some new option (like yes for all, just an example)
I'm not talking about checking that in the promotion phase. And that should also be the time, when checking the package specified in the template, can be found in the environment. What I'm suggesting is, in this place, use only
```
self.packages.create!(:package_name => package_name)
````
without any conditions, and do the checking when promoting (or alternatively when adding the template into a changeset)
I'd say that changing the case for the word "Back" makes sense, but not adding the %s will make things less confusing for transtalators:

notice _("Welcome back") + ", " + current_user.username

gettext does allow for a comment to be added to the po file to provide context for the translators, so if you figure out how to do that, then applying either format (the one you suggested or the one I suggested now, plus a comment such as "This is a welcome message followed by the logged user name...."  would make things clear.
Would you mind adding >/dev/null here? I noticed last week RPM installation is verbose in this case.
I would probably indent these 2 lines to make it more readable, no?
Halo pipeline? Some refs please, all my google searches lead to the Xbox shoot'em up game :-!

I guess @percyfal is right then, I would merge it all, the rest looks awesome, thanks @vals !
We don't want these either.
Each line is 80 characters long. Because we use the `ContinuationLinesInputter` different lines will be merged together and each line needs to have the same lengths. We cannot crop the whitespace at the end of a line, because then different lines will have different lengths and after merging continued lines later parts will not be at the position the FixedwidthSplitter expects. On the other hand, the DAOPhot format specification may not always use up the entire 80 characters width. One line might be 73 characters long, the other 79. The remaining space in the data lines is just filled with whitespace. In essence DAOPhot adds an extra column of white spaces to make the width 80 characters. 
So, there are several ways to proceed:
- Calculate the number of characters used up by the columns explicitly given and then add in a dummy column of the missing lengths. Later this column needs to be discarded, because no user wants random columns of white space.
- Calculate the number of characters used and remove the remaining white spaced form each data line. In this case the ContinuationLinesInputter needs to know about the column specification and crop columns before merging. (Possible, but a bookkeeping nightmare. If this is the second continuation sign, crop 4 white spaces, then merge, if this is the 5th continuation sign crop 2 white spaces).
- The approach taken here: Add those extra white spaces to the last column in the table. It will be wider then specified, but in the current scheme asciitable strips white space before any ingestion of the values anyway.

I can imagine situations where the last approach might fail (e.g. for very complex format parsing, which relies on the number of white spaces to the right of a string), but in the context of the DAOPhot format is seems to work well, because DAOPHOT does not have have output that complicated.
BTW if we ever drop 2.6 support we can use importlib instead.  But for now that's not an option :)
minor typo `exectute`
Clearly note that this is in kilo *bits* per second, not bytes.
s/VERISON/VERSION
Investigating...

Am 25.03.2012 03:23, schrieb Luke-Jr:
>>   {
>> -    message_queue* mq = (message_queue*)parg;
>> +    std::string strIpcDir;
>> +    // get path to stale ipc message queue file
>> +    interprocess::ipcdetail::tmp_filename(pszFilename, strIpcDir);
>
> There is no interprocess::ipcdetail on Linux.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bitcoin/bitcoin/pull/980/files#r600665
>
hSocketMax is 0 or set by some magic, happening in the FD_SET macro if I read correctly.
We have actual base layers in our c2cgeoporal applications. So isn't the problem related to ```allOverlays``` being ```true``` in our maps?
You had been using `X >= ((Y div 2) + 1)` for the majority check elsewhere, but I guess they're equivalent, right?
It concerns me that if someone sets the whitelist as nil (instead of '') the default whitelist will be used.
hmm should you need a space from the !?
edit the discussion "title" not "description"
This assignment doesn't work how you expect. You are creating a local variable here, not assigning to `self.validator`.
let's stick with lowercase `gm`
Ah, well spotted: Vim defaulted to the wrong correction for this one. Amending.