labofsahil/github-event-dataset-2012 huggingface dataset:
Not that it matters much, but I'm not sure I like this change. `include("test", 1)` doesn't as much have a "wrong name" as much as it doesn't have one at all (it has an integer). So I like the original better (maybe with "expected non-empty string" if it matters, and I'm not sure it does). Also, s/wrong/invalid; "wrong" makes me think in the direction of "you guessed the wrong password".
Remove this (Dieter has a small penis)
Build clean uses `unlink(c(Sys.glob(c("*.o", "*.sl", "*.so", , "*.dylib")), paste0(pkgname, c(".a", ".dll", ,".def")), "symbols.rds"))`
cython has optimized version for foo-loop:

```python
cdef int i

for i in range(nwatchers):
```

see http://docs.cython.org/src/userguide/language_basics.html#integer-for-loops
We should probably wait for #2204 to be merged first, and then update this to use that API, right?
Don't you want to directly loop over `_imagemime.keys()` ?
it seems like those 2 status variable are unused....
I don't think you need the `iter()` call here - `reversed()` returns an iterable. See the implementation of `get_tail`

Also, a spot of bikeshedding: assigning to `cur` is semantically wrong, because cur is short for cursor. So I would make this line `return reversed(list(cur))`.
Below,  another error is catch and log a message to the console as well as showing the traceback. 
Maybe we could conform to that and do the same, it would allow for better debugging guide the user when they have an error like that. 
What do you think ?

Same for other file.
Move this comment into the module docstring.
one more q:
would not the following need the same check?

Context.prototype.getBlock = function(key, chk, ctx) {
  if (typeof key === "function") {
    key = key(chk, ctx).data;
    chk.data = "";
  }


dynamic partials

 if (typeof elem === "function") {
    return this.capture(elem, context, function(name, chunk) {
      dust.load(name, chunk, context).end();
    });
Ah yes, the joys of overloading "=" to be a comparison and assignment operator :)
Since this block of code is identical in both files, it makes sense to create a macro.
So, category_tags was a list of tags. Assuming you didn't change the call point, this should be product_slugs plural and the docs should say "list of product slugs".
In this file there is a mix of declaring all variables with the `var ` in front and the comma separated declaration. I think in general we have done comma separated in our js in SUMO, so it would be better to stick to that convention.
You could just do `self.databaseName = self.config['databaseName']` that'll catch key errors and take care of raising the error automatically.
Thanks for volunteering @andymckay !
i got into it a bit more in worldguard.  One could certainly roll the functionality into the existing commands; it would be a bit more work though.  The current commands cannot be run from the console.  In the absence of a local player, one would need to check for a parameter specifying the world.

Figured a second command for console users was a bit easier than editing the current commands to say "they cannot be run from the console, unless X"  Running from the console is sorely missed though, would love to see it in there however it's done
Same here, additional (empty) line required
You mean it could be used in a block called from within form_widget_primitive? Because at the moment its not used anywhere inside.
I simply mean `<input type="{{ type|default('text') }}"`
You need to add a blank line above `@return`
`\` is not allowed anyway (see above). so no need to replace it.
doh sorry again .. shouldnt rush stuff like this .. even it seems trivial .. i amazingly found lots of ways to screw it up
you're right, it's not in the composer file, forgot to check. I removed the dependency and set the response code in another way
That should be named `getBuilder()` as it returns a builder instance.
Well, the logic should be fixed. The logger is optional everywhere in Symfony.
Ok, i understand, but why it was in guessMin if a null was return ?
you should keep this method before ``splitHttpAcceptHeader`` to avoid unnecessary diff in the PR. This will avoid breaking the git history for this method once the commits are squashed.
duplicated ``with``
Does it really flatten a tree to a single collection? From what I see, the resulting DumperCollection can have sub-collections?!
better: "The field '...' is not ..."
Once you set `@invitation`, you can move this extract this into a private method like `def save_and_construct_errors`.
\clearemptydoublepage    
使用这个命令是保证偶数页结束章节，若该章节在奇数页结束，则添加一张空白页。
```
2012-12-12 09:58:00 | root | ERROR | util.py:38 | ValueError: invalid literal for int() with base 10: 'abc'
```

With one log file per component I know exactly where to look and what to test. With only a single log file, I have an extra debugging step to figure out which process is passing the bad data. If it's an infrequent error, I'm SOL.
It's inconsistent/confusing to use "Downloader" in the subclasses but "Downloadable" in the superclass. How about just renaming "DownloadableItem" to "Downloader".
(where n is the # of segments in the path)
probably "/usr/bin/env python" at least for the time being.
since I set a language to public: False
The property definitions below expect these attributes to have _ prefixes.
@twinturbo I'm sorry for an ambiguous comment. It was fixed by https://github.com/twinturbo/ember.js/commit/ebe0337d12dcd41541e0c511ac0504714c19c91b. Great works!
Emanuel, I don't think any of these should be registered on an HC; they are purely server resources.
Ah, I see now. Looks like a wrong synchronisation between the sample file and the one I used in the local test. I accidentally committed an earlier version (where I  just needed the `error_log`).

I had already fixed this on the server (swarm.jquery.org is running file and it is running on the latest code).  Committed in 474494b.
Там @hizel нашел какое-то правильное сочетание опции этой аннотации, без параметров чем-то плохо получается. Посмотри как в других контроллерах сделано
You still hold a reference to `item`, you have to release it before returning.
I'm talking about `sendUserCancel` not `handleLoginAbort`. I see the eventListener you mentioned in L53 only calls `handleLoginAbort`?
Please still add function name here, which will make the debug log more clear.
You probably want to exclude sms/ext instead.
why not have a `isFullyVisible` property encapsulating both conditions and then just have:
```
if (!this.isFullyVisible)
  return;
```
See my next comment about your hack in the window manager and add the same issue number next to this code.
Yes :P
So I did a little rewrite on formatTime().
Here we are making the call as the result of the activity, and I'm not sure if we should do that. 

I prefer the android approach, is just launching the dialer with the phone number and the user has to press the dial button, but this is just a personal preference ;)

@etiennesegonzac what do you think?
better if we tab this content as

myFunction({
   param1: value1
   param2: value2
})
Start of the week should always be zero (unless I am misunderstanding your intent completely and you want Monday but getDay in theory is localized so it will vary). https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/getDay
nit: please give this if-else some curly braces
OK, perfect, sounds good!
No, @alivedise is talking about logic of flight mode. You should keep the `this.reservedSettings.bluetooth` check.
get eltsbyclassname is not supported in ie8, need to think about replacement.
Pro moji informaci, co tohle znamena? Dik
GetSiteUrls can return a null here.
I think this needs to return a full URL, like the reference implementation. e.g. I use the JsonView Chrome extension (https://chrome.google.com/webstore/detail/jsonview/chklaanhfefbnpoihckbnefhakgolnmc), and with your implementation, I can't click to move around the file system. So my guess is that the accepted 'standard' for REST APIs is to return fully qualifies URLs.
These methods were [recently added to sexp_processor](https://github.com/seattlerb/sexp_processor/commit/fc7eb683bb0dbc1fd657dc1ab59b9fda710f7be8) so hopefully they won't exist here much longer.
This just changes the MySQL table format from a VARCHAR to a BLOB which is basically a byte array as far as Java is concerned.
Can you give descriptive names to each of these cases?
The main reason of the classloader is to load the finder class, which contains the code to resolve the selected test.

For example, FunSpec in ScalaTest is annotated with @Style like this:-

@Style("org.scalatest.finders.FunSpecFinder")
trait FunSpec extends Suite { thisSuite =>
  ...
}

FunSpecFinder is a class that is contained in the finder jar file included in the plugin, it contains code to resolve selected test based on the selected AST nodes.  The classloader will load the FunSpecFinder class, create an instance of it and call its find method.

For more details explanation of the approach, you may read our earlier discussion in scala-ide-dev mailing list:- 

https://groups.google.com/forum/?fromgroups#!topic/scala-ide-dev/A-jWSJaotfQ
I wanted the type of the partitionFn to be inferred, but I had to still specify it with (_:Int). Is there a way to add the type inference?
remove the spurious space before "n"
must be! hahaha, I was probably running an older SHA or something, no clue
Should also test header content.
Then erase it.
You actually want to put your unobtrusive javascript stuff as the last thing before the body closing tag. In this specific case, it actually doesn't matter that much because everything is a `$(document).ready`, which is very fast, but it does slow page rendering down by a little bit. The browser will stop rendering the HTML while it executes that javascript, resulting in a slightly slower "page load" from the user's perspective. If the JS is at the very end of the page, the page is rendered first, so appears to load more quickly for the user.
It's saving to the map config that's being wrapped by the annotated object config. This config itself doesn't save, so no read/write to the filesystem is done.
I thought about that but "shut down" was used for the pause behavior so I followed that example in referring to start/stop rather than resume/pause. Perhaps both should be updated.
Good call, /templates added.

Why not have the app specific BaseView live in /views?

If we're talking sharing between apps (like a modal component, or a tabs component etc.) maybe we add a /assets/components/ directory that would then house the files necessary to make that component work on its own (views, models, templates, css)? Does that make sense?
Fixed. Thanks.
https://github.com/cocos2d/cocos2d-iphone/commit/a7273477b298b116f76a2e93ac
c8a24660b94867

On 6/12/12 12:49 AM, "Nicolas Gramlich" <nicolasgramlich@gmail.com> wrote:

>Let me ask Ricardo tomorrow (or this week, since he is busy on WWDC and
>getting owned in basketball *cough* =P )
>
>--------
>Letters were harmed in this message!
>
>On Jun 12, 2012, at 12:37 AM,
>minggo<reply+p-965357-bbc6aeda493f88771200336de5f09e51942fb82d-287060@repl
>y.github.com> wrote:
>
>>> 
>>>                 dataSize = widthBlocks * heightBlocks * ((blockSize  *
>>>bpp) / 8);
>>> -                unsigned int packetLength = (dataLength-dataOffset);
>>> +                float packetLength = (dataLength - dataOffset);
>> 
>> Yeap, it is stranger.
>> It should use "unsigned int" instead.
>> But cocos2d-iphone use "float" here.
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/cocos2d/cocos2d-x/pull/1000/files#r965357
this method should be moved to the VcsDownloader as it is now the same for the difference child classes (the different logic is in ``hasLocalChanges``
Since the variable isn't used anywhere else you could just put the .save call directly here ;)
You can style a link to look like a button (button and new-btn classes should get you along I think), lets focus on one thing per PR, the flash notifications are a different issue ;)
I have asked @etirelli on irc and you are right, thanks for your comments!
すべての継承可能なメソッドをモデルのプロトタイプにアタッチする。
Where has my foldLeft gone?
Why are you inserting Ticket Type here?
can sig_cnt be bigger than 255? I think it can, in that case how do you handle idx > 255?
так пашет, проверял?

для 2 рельс тоже надо
Also, concat'ing yaml streams like this probably isn't as useful; If the file starts with a yaml document header ("---") then your YAML.load will load multiple documents and probably get some awkward behaviors..

Thoughts?
Adding some comments to explain intent of this code would improve readability.
In fact that's a case, but this is cuttlefish so it's for add-on code. So `panel` will need to be normilized to `sdk/panel`. If I misunderstood and you meant to normalize in loader.js I don't think it's worth it. No reason to make sdk modules special on platform side.
Most of the functions here implement **underscore** APIs, would be nice if `flatten` did to:
http://underscorejs.org/#flatten
I'll add a comment here
A simple comment about the necessity to start with `;` would be welcomed.
@lloyd - the reason for the transition is jQuery has a bug with its animate function if you try to animate an element's width that has it's box sizing set to border-box and a padding.  jQuery does not include the padding in the element's width, so it makes the arrow jump all over the place.  Instead, I went for a simpler solution to let browsers that support CSS transitions do the work themselves, and those that don't just sit there for a second and a half and close.  IE8/IE9 falls into this category.
nice explicit comment re embedded js.
If you don't want to switch to the `handle_project` approach here, I'd at least remove the leading underscore.
Does this function need a name?
AlinT: QMO actually remains on the same page if you click the search button without data, so it is not a false positive. The rest of your suggestions I will happily use in the next test- which verifies searching with data!
Please keep previous logs intact. I know them by heart :), it helps to debug.
Map and collect are aliases.  I find `collect` a bit more readable so this is fine.
Yeah there are probably about 50 places where I have "TODO cprice:".  They will all be cleaned up before the final pull request.
Can you fix up the formatting
I think we might want to use `deleteInstanceDir` so that everything is killed.  I'm not sure, I haven't tested yet.
maybe "top-level `Features` module"
True, removed both of them.
So all this template stuff is for js-side? You need to document it somewhere...
Authorize before doing something...
This is fine for now. I think I'd like to re-visit how configuration is stored at some point as I'm not keen on anything that uses the `ConfigurationManager` directly (which is also how I've done it in the only other place that uses config) as it's not easily testable. Some sort of abstraction over loading the configuration options from appsettings or something might be preferable, and would give us a nice configuration API to use (YAGNI for now, of course).

Designing our own "configuration API" (even if it used appsettings as the store, though that would mean it's readonly) would enable us to support charity-specific values as well as global ones. It'd be nice to have some sort of authz-controlled configuration UI to modify these settings once they grow in number.
`<?=` itself is incomplete, indeed `<?= ?> `is not a valid syntax.
`<?=$variable;` <- is in a way the whole "opening tag"
`?>` <- is the closing tag
maybe should you put this logg.debug in the else statement of the try/except, so it's displayed only when the dir is actually deleted?
@harjis Pupe-styleguiden mukaan näin {$yhtiorow['yhtio']}
I want a user to be able to update their 'email' or 'about' section quickly and without needing password and confirmation. I'm thinking about redoing the auth in the near future though, I took a quick look at simplest_auth.
changed this back on a different branch -> this entered an infinite redirect loop on some pages
This was split so there would be a cancel button if you were editing info on the edit page, but given that you can edit your info in the show page there's no need for an edit page anyway. Problem solved.
Later I want to open up password changing but I'll cross that bridge when I get to it.
extra space after %s  here would be safer.
Why not reuse the easyconfigs available in easybuild/easyconfigs/... ?
OK, I tought this was clear, 
this will only set LM_LICENSE_FILE if it's not set yet (in the users environment)
Since the user will provide the file somewhere...
I'll add it as a comment.
2 empty lines before class definitions
use `self.moduleGenerator.setEnvironment`
Should this docstring change since the function name has changed?
s/_xul_runner_image/_xulrunner_image (it's one word)
Yay for directly comparing objects!
Its been javascripted by infinite scroll.
Nit, but looks like we can ditch the parentheses around `'Location data should appear as submitted.'`. (I think I put them there, but if so I was wrong.)
Do this for all instances below here plz
If you can, you'd now be passing mozwebqa into every method rather than the class constructor. I don't see how this is any better (but then I don't see an issue with the latter)
Yeah, I stuck it that way on purpose. Um...the thing is, I don't want to have the option presented for "complete" works where chapters = expected number. Hmm. I guess I could stick in a "nil" condition in there as well, so that if there's no status set, the box appears.
I may be guilty of throwing in non-standard names as well.

I'd say let's standardize on Test* prefixed names, using this as a guide, http://docs.python.org/2/library/unittest.html#basic-example
you could change this to `volume['status'] in ['available', 'error']`. NGTHUTPR (Not Going To Hold Up The Pull Request)... +1. good work on the tests
`mp4` is already supported by faad right? I think we should only add formats not natively decoded elsewhere..
Em qual situação eu instanciaria um Schema sem passar um XSD?
I'm wondering what's the reason for this?
I am not an expert in this.  So we would need a "powerup" and an "updating database" step?
since you override the console method, I am not sure if this logic is required?
@ohadlevy, I just copied from the UI audits_controller to the API audits_controller
There is probably a better way to do this. An array of `invoices`  is returned when sending a GET request to `/invoices`. A single `invoice` is returned for every other method. I'll work on cleaning this up.
Just make another commit and push.
Do you need the `true` to do a deep copy? If not, it's best to omit it.
This is already imported.
You can check for this via e.pointerType != PointerTypes.MOUSE
I think it is fine like that, it is part of the server variable.
Probably okay for this test, but it would probably useful to use some test uuid id strings that are more like real uuid's (just
to try to catch any size or string boxing issues or other madness).
Yea.  Sorry.  First pull request.  Virgin.
All fridge DBAL keys are lowercase. Can you update accordingly please? :)
graph_->cur_node в переменную
деструктор?
@jcredding - fixed thanks.
Bah, I knew that had to exist. Guess my eyes were avoiding it on the docs.
can who also be '' or 0 and be considered valid? if not, then should it be a truthy check?
Not really, but I can make up at least two. :-)

1. A habit from Python, where private variables start with an underscore by convention. As this variable isn't supposed to be exported, it is private in a sense, so...

2. I guess it isn't unthinkable that some other process might rely on some variable called msvc2008, so it avoids a possible naming conflict as well.

Neither is really compelling. You want to get rid of it?
So, if we're getting rid of this... there are still something like 15 occurrences of it in the code:

doc/query.md
test/com/puppetlabs/puppetdb/test/http/v2/facts.clj
test/com/puppetlabs/puppetdb/test/http/v1/resources.clj
test/com/puppetlabs/puppetdb/test/http/v1/node.clj
spec/curl.md
src/com/puppetlabs/puppetdb/query/node.clj
src/com/puppetlabs/puppetdb/http/v1/resources.clj
src/com/puppetlabs/puppetdb/http/v1/node.clj
src/com/puppetlabs/puppetdb/http/query.clj
src/com/puppetlabs/puppetdb/query.clj

Some of those *may* be still relevant for internal implementation detail stuff and v1 support, but the v2/facts test and the 2 documentation files seem like they shouldn't reference it... right?

In fact, I would expect for those v2/fact tests to actually be failing due to invalid syntax.
Did you decide that `sequential?` was sufficient?  As opposed to something like `list-or-vec`?
No character classes in any of the tests... seems like it would be worth at least knowing what we can expect, as my guess would be that the whitespace one (\s) and the alphanumeric one (\w?) would be fairly commonly used?
This test uses the same cron expression in the documentation. It fails with the current condition, but passes if the condition is reversed in IsIncluded.
I've changed all comparisons to be more sane and removed some other whitespace stuff.
I've honestly never see `>>>` before, and google is currently failing my ability to look it up, edumacation is required please
CQL should be in line with styleguide.
The second parameter of the User object is the user `id`, not the username, that only exists on the loginid of the user.

Either way, this conflicts with the tenant separation branch and should be merged after, as the `Config.getValue` method was switched back to taking just `tenantAlias`, not a context, so constructing that would not be necessary here.
What's the difference between `disabled` and `inactive` ? Should we consolidate them into 'enabled/disabled', and get rid of the notion of starting/stopping? Not in scope of this PR.
This should probably be `tenant !== OAE.serverTenant.alias`
It's not great that we have to repeat all of this code here, as it's already in oae-authentication/lib/rest.js. We should try and find a way in which we can share that code.
missing var statement?
The doc points to the doc of `scalaVersion` where the possible values are described. I can duplicate it if it makes it easier to find.
Is this a TAB? :)
parts of this method look like a duplicate of `Table#attributes_for_row` can't you make use of `super`?
damn you're right :)
Cool. I see the issue here. But, if you notice, this is the selector manager thread. The client code (blocking or non blocking) will finally checkin the clientrequestexecutor, at which point the socket will be closed. . But seems good to have anyway. will pull this in.
Only so few mechs supported? No SHA-1, no GSSAPI? Drop this junk, use qca *trollface* =)
Needs null reference checking, since it hard crashes if not setup correctly.
Я бы на вашем месте переписал этот метод на более "Objective-C"-подобный. Как вы уже заметили, практически любой объект можно инициализировать по умолчанию, инициализировать с помощью чего-то. В частности, у NSArray есть метод initWithArray: который позволит создать массив, используя другой массив. 

Я вижу следующий метод:

`-(id)initWithCell:(Cell *)cell`

Который, при необходимости, можете реализовать.
DNA должна быть скрыта от постороннего вмешательства - в условиях задачи сказано про переменную, а не свойство
В задании говорится "Создайте метод hammingDistance, который...". У вас в интерфейсе этот метод отсутствует.
Грубо говоря, тип id - это обёртка для любого класса. Например:

```
    id tmp;  // переменная-"контейнер" типа id
    Cell *myCell = [[Cell alloc] init];
    tmp = myCell; // ок, tmp - это наш объект, можно сделать следующее:
    [tmp mutate:60]; // если выведете на экран после этого myCell, то увидите, что она изменилась
    tmp = [tmp DNA]; // а теперь tmp - типа NSMutableArray!
    [tmp objectAtIndex:10]; // выведет 10 элемент последовательности
```

То, что массив может принимать значения типа id означает, что его можно заполнить различными данными!
Вот, пример:

```
    NSNumber *number = [NSNumber numberWithInt:20];
    NSString *string = [NSString stringWithFormat:@"Тестовая строка"];
    NSArray *array = [NSArray arrayWithObjects:@"А это",@"тестовый",@"Массив", nil];
    NSMutableArray *newArray = [NSMutableArray array];
    [newArray addObject:number]; // добавляем в массив объект класса NSNumber
    [newArray addObject:string]; // и NSString
    [newArray addObject:newArray]; // и даже NSArray
```

Вполне спокойно, и всё отлично, у нас в массиве три объекта: число, строка, и ещё один массив из трёх строк.
Мне не нравится такой метод, поясню почему - при изменении DNAElements тут придется так же менять значение. Нужно всё же более гибкий способ написать, который подошёл бы к заранее неизвестному количеству генов.
Хорошим тоном является помещение всего последующего кода в условие if (self).
Can you sort the methods for this file?  Thanks.
Missing command and description docs.
Are you sure  you have these line breaks right?
MySQL version hasn't default value, [see here](https://github.com/gpongelli/joomla-cms/blob/master/installation/sql/mysql/joomla.sql#L1243), why have you added this ?
PySurfer

also I would call the method as_pysurfer_overlay
Please rename this file to news.js
:heart: that you wrote docs on how to run the tests.
Oh, ok... do you think I should always do `self.client.logout()` in tests that login a user or something?
good call, changing it.
since this file isn't really in the change set, would be nice to squash this out.
Maybe "The system administrator is sometimes writing code"?
I'd write this a little differently,

``` ruby
class CommentObserver < Mongoid::Observer
  def after_create(comment)
    increment_comments_count(comment.item)
  end

  def increment_comments_count(item)
    item.inc(:comments_count, 1)
  end
end
```

And maybe even pull `item.inc(:comments_count, 1)` back into the Item class itself. That method makes sense in there I think...
Good catch! It was used but then I switched to a `:doc:` link. I will remove it.
There should be no space after `{` and before `}` in the hash.
We typically like to put all of the URL references at the bottom. So, it'll look like this (I've also changed the title to match the article):

    `Working With Symfony2`_

Then all the way at the bottom of the article:

    .. _`Working With Symfony2`: http://www.propelorm.org/cookbook/symfony2/working-with-symfony2.html
How about the name `#has_enabled_but_unset_created_at?`.
I don't think this section (307-317) should be here, it generates an error rendering the template. if params exist they will be output in 293-303.
changed to:

context.parent ? ChannelRequest map (_.asInstanceOf[Channel]) map setupChannelInternal

That's pretty slick!
Don't catch anything, the test will fail if there's an excpetion thrown
The NULL checks are not necessary.
@vijaydev added docs to both `protect_from_forgery` and `handle_unverified_request` methods
you might want to copy and paste the output from `pprint(Sum(f,(i,a,b)))` to make sure it looks right; what you have below is not right. Notice that the tic on the upper bar is not at the end of the bar.
no space around equals
well, then every other durable mailbox has the same problem. "everybody else does it" is not a good defense ;-)
Эм, а там разве не QStringList по договоренности?
Actually several participants can be added in one call
global? srsly? why?
Just to clarify, this bug has to do with *computed* values in Webkit. The values output by Sass were always correct (and seem to be to-spec), which is why tests didn't pick them up. What happens is that if `html { font-size: 112.5%; line-height: 1.4rem }` the computed value of `line-height` in Webkit is 1.4 * **16px** = 22px when it should be 25px.
Yes, I miss this. I will check CMake scripts in order to understand what is needed to be installed. However, could you please provide a real example of list of libraries which are needed to be provided for the end-user? For example, is it interesting to have cppnetlib-utils-thread_pool library to be installed?
can you delete the commented code?
please rename to self.outgoing_migration for consistency with the variable below
But if it's confusing I can revert that, not that big of a performance issue anyway.
Octals ? This is because the string is then fed to Integer.valueOf(String) which interprets leading zeros as an octal number.
Actually not even that, as if we don't support concurrent updates then we don't even try to acquire a lock, so this interceptor does what's needed.
Borrowed from forge? :)
Right. I'll rename it: "havingParameterWithoutValue" -> "havingParameterWithGivenName"
Actually, this is for when a file changes it's file type between normal blob (which includes both text and binary), symlink, directory, or submodule.

Under normal usage, if in a particular diff you replace a normal file with a directory (or any other fundamental change of type), you will get a `DELETED` record the for normal file and an `ADDED` record for the directory. That is probably what you will generally want. But for status related commands, it is preferable to have a `TYPECHANGE` record with the data for the normal file as the `old_file` and the data for the replacement tree as the `new_file`.
If your happy for me to do that in this PR, then I will.
We may as well do the width & height in the CSS... or does that break the resizing code?
Thanks for pointing that out. Since this is a PEP8 PR, I think it's better to leave this in and remove it in another pull request.
Or, one could use tempfile.NamedTemporaryFile instead (get the filename from the "name" attribute of the file object).
The destinition is the url of the openEngSB. This has be be provided. The domainType is the domainName like Example and PLC. These are required too.
@bartvde I'm open to removing the fallback and renaming 1.1 to 1.1.1. You are more experienced with OGC services and versions, so it is your call to decide. Just let me know :-).
There is a wrong href here.
As per http://www.w3.org/TR/CSS2/syndata.html#charset char encodings are resolved as:
1. An HTTP "charset" parameter in a "Content-Type" field (or similar parameters in other protocols)
2. BOM and/or @charset (see below)
3. <link charset=""> or other metadata from the linking mechanism (if any)
4. charset of referring style sheet or document (if any)
5. Assume UTF-8

Since cloudfront doesn't set a Content-Type and since we don't use any method from 2->4, it would be safe to just:
    fp = ContentFile(new_content.encode('utf-8'), filer_file.file.name)
I believe it's spaces. It's actually in the real data so I wanted to be sure it's in the tests. I'll add a note in the docstring for the test. 

On Nov 13, 2012, at 10:40 AM, Sam Ritchie <notifications@github.com> wrote:

> In test/clj/forma/source/fire_test.clj:
> 
> > +    (valid-fire?
> > +     (str "latitude,longitude,brightness,scan,track,acq_date"
> > +          ",acq_time,satellite,confidence,version,bright_t31,frp"))
> > +    => false
> > +    (valid-fire? "-16.701,137.752,338.2,1.7,1.3,2012-11-04, 01:25,T,89,5.0       ,298.1,63" expected-length) => true
> > +    (valid-fire? "0.585,100.415,331.3,1.2,1.1,2012-09-18, 06:40,A,84,5.0A,75,5.0       ,302.4,26.3" expected-length) => false))
> > +
> > +(future-fact
> > + "Test `fire-source`. Source mimics formatting of an input file.
> > +
> > +  Test should pass, currently fails despite output seeming to be
> > +  identical to the test result."
> > +  (let [src
> > +        [[(str "latitude,longitude,brightness,scan,track,acq_date"
> > +               ",acq_time,satellite,confidence,version,bright_t31,frp")]
> > +         ["-16.701,137.752,338.2,1.7,1.3,2012-11-04, 01:25,T,89,5.0       ,298.1,63"]
> Is it a gap or a tab character?
> 
> —
> Reply to this email directly or view it on GitHub.
>
If the left hand nav event is caught the generateNav function will be executed twice. We should try to avoid that.
Details for search templates was being accessed piecemeal through the search process. By creating a single interface and obtaining the template details up front there is less need to pass either the SlingHttpServletRequest, the Session, or the Resource to the search methods.
DIE!
why redefine this method? looks same as parent to me
unicode ftl
yeah, but by the time the bundle is loaded a particular version of rake is loaded too

On 21/03/2012, at 12:01 AM, Sven Fuchs wrote:

>> before_script:
>> -  - 'RAILS_ENV=test bundle exec rake db:create db:schema:load --trace'
> 
> rake always loads the bundle anyway
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/travis-ci/travis-core/pull/24/files#r583030
I don't see any reason to add more checks for WT_CONN_TRANSACTIONAL -- the existing code will generate the error message "No transaction is active", which is what I would expect.

Ack on the error messages in begin_transaction.

The usual argument for non-transactional sources is that transactions are heavyweight, and we don't have that problem.  Regardless, if we want to add that feature at some point, I would do it with a "transactional=false" flag in WT_SESSION::create (which matches what BDB did), not in the transaction API.

Updates outside a transaction are exactly equivalent to auto-committed updates running at read-uncommitted isolation, so yes, that will work.
Why did you choose not to have __rec_dictionary_lookup return an int? There seems to be a fair bit of state held in the returned structure that might be made clearer by using explicit return values (found, add, dictionary full).
We no longer need to clear the page from the eviction list, because we waited for it to drain before we got here.
Not used uses.
the code that decides whether or not to _run_ a check will be in a different place.  This code is only concerned with scheduling a check.
You don't need combine() if you only have one conditon
Sure but it's already a smaller header (h4).
minimal -> Minimum
needed -> required
I was going with that the priest thought he came there looking for a sword to save his people, but he ended up getting a dragon. lol
Framfor å gjøre dette manuelt, se på `apache::vhost`-regelen (f.eks. i `hdo/manifests/apache.pp`).
This won't work if the `pred` returns `true` for falsey values, like `nil?` does:
~~~clojure
(boolean (first (filter nil? [1 nil 2])))
;=> (boolean (first [nil]))
;=> (boolean nil)
;=> false
~~~
To fix this, you should use `pred` instead of `boolean` and check wheather the filtered sequence is empty:
~~~clojure
(let [f-seq (filter pred a-seq)]
  (and (not-empty f-seq)
       (pred (first f-seq))))
~~~
not really, the idea here is to test if the property is backgroundPositionX or Y *only* if the browser supports those extensions.
What goes behind this is that if you try to retrieve `backgroundPositionX` in say Firefox, you will "correctly" get `undefined` instead of a wrongly normalized `0px` (which we don't need to normalize, as it's non-standard)
Nit: Double blank line.
`{@inheritdoc}` ?
What is this file for? Just include it above in `home.html`, no?
This is probably not needed in this list?
Why you changed indentation? It was OK before. We indent on any Django template tag or XHTML block.
I suggest that you add:

```
self._key = self.username.toLowerCase();
```

And then use `user._key` for keys.
We write space after `{%`.
are you sure this will work with https://github.com/nzzdev/www-sql/pull/412/files#L1R3  ?
formatDisqusDate is defined inside of $(document).ready but not in global scope
I don't see a good reason to make this a variable.  I am not a fan of creating variables that don't do any extra work before passing them to the view (template).  It's a node attribute, so just reference it.
entfernen.
This is so my local .rbenv-gemsets file does not get into the repo
Please add a dot at the end.
> copy all distribution dependencies from the directories: ...

that's not in this patch!

anyway,it's not about dependencies of this distribution but things which are part of the distribution archive so I'd prefer the existing expression
you can go directly to handler without going through a redirection.
            $r->set_handlers( PerlResponseHandler => \&handler );
            return Apache2::Const::OK;
Again - `console.log( x )`
"accomplish this," instead of "accomplish that."
This change hunk looks unnecessary.
prop is not a great variable name, how about let's call it rawProperties.
This is wrong

id can never be none.

This domain applies only in cases where category is in a remote model
Why not just use regexp for this?

```ruby
keys.select do |key|
  key.match /"#{filter}\(\d+i\)/
end
```
should these not be default values?
I used a [Java script](https://gist.github.com/8139eefcd58abe9ff6d5) to generate these strings.
Move bracket.
We have a linkify method in core/util. So if we're sending pre-anchored text to the client, let's just not do that and let linkify take care of it.

FWIW it's the most advanced, capable linkify method I tested out of a number. It even has a list of all the possible domains.
This may fail depending on the filesystem timestamp resolution (ext3 uses 1s IIRC)
I think we have a thread safety problem with these fields.  The endpoint can be reused across calls.
This probably ought to be listed as:
```
galsim.BoundsI(xmin, xmax, ymin, ymax)
```
While there are other ways to construct a Bounds object (e.g. with no arguments or with a Position), this version will by far be the most common usage.
It is done, I'll remove the comment!
First mention of Great08 - give citations / links? (likewise in demo5.yaml, json/demo5.json)
P.S. Comment is reinstated in most recent push.
I prefer to use try parse in cases like this.

http://msdn.microsoft.com/en-us/library/f02979c7.aspx
select score, count(*) from c2g_examrecord group by 1 order by 1;
+-------+----------+
| score | count(*) |
+-------+----------+
|  NULL |     4010 |
+-------+----------+
It would be better to use { } here.
I feel like these should be `TypeError` or `ValueError`.
Could getVersion ever return null?
je confirme :D
A replacing of class to struct is a difficult problem.
I will rewrite so for the present.
can you explain more what "high resolution" means?
this white belongs to twitter bootstrap variable, it's a specific white not  #FFFFFF
Nit: Blank lines would be useful to delimit sections here. Example:

```
+        self.index.refresh()

+        originalCount = int(self.index['totalEventCount'])
self.index.submit("Hello again!", sourcetype="Boris", host="meep")
+        testlib.retry(self.index, 'totalEventCount', str(originalCount+1), step=1)
+        self.assertEqual(self.index['totalEventCount'], str(originalCount+1))

+        # clean always times out under Splunk 4.x if run in an enabled index, but
...
```
i cant remember - do we call `.version()` somewhere in here to default it? this looks fine as far as fetching the version goes but at a glance it looks like we wouldn't be registering `--version` unless you did `program.version(program.version())`
O no no no. This soooo introduces race-conditions. This is bad API.
I was going to say "please don't prefix variables with underscores unless they're members of a class", but I see that this file seems to be violating that rule everywhere else, so .. at least this is consistent.
nvm. This is actually needed in checking friendship and in news.
I stand corrected, actually any value other than the accepted values will result in no headers being sent at all.  So `0`, `false` or even `''` have the desired effect.
oops - I can read... it is...
Trebuie sa adaugi in doc block ul functiei si parametrii pe care aceasta ii primeste folosind tagul @param. Ex: @param nume_parametru descriere_parametru. Toate tagurile trebuie sa se alinieze. Ex:
@param ceva &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Descriu ceva.
@param altceva Descriu altceva
Ты либо ставь пробел перед и после = либо не ставь.
С условием все ок, вроде.
On 15 November 2012 23:37, Dmitriy Komanov <notifications@github.com> wrote:

> In src/ru/fizteh/fivt/students/kashinYana/parallelSort/ParallelSort.java:
>
> > @@ -27,7 +27,7 @@ public String toString() {
> >          }
> >      }
> >
> > -    static final int size = 1024 * 2 * 2;
> > +    static final int size = 1024 * 1024;
>
> ðÏÑÓÎÉ, ÞÔÏ ÚÎÁÞÉÔ ÜÔÏ ÉÓÐÒÁ×ÌÅÎÉÅ.
>
åÓÌÉ ÏÎ ÂÕÄÅÔ ÓÏÒÔÉÒÏ×ÁÔØ ÂÏÌØÛÉÅ ËÕÓËÉ, ÔÏ ÂÕÄÅÔ ÂÙÓÔÒÅÅ.
îÕÖÎÏ ÚÄÅÓØ ÓÔÁ×ÉÔØ ÒÁÚÕÍÎÏ ÌÀÂÏÅ ÞÉÓÌÏ, ÎÅ ÐÒÅ×ÙÛÁÀÝÅÅ ÒÁÚÍÅÒ ËÜÛÁ ×
ËÏÍÐØÀÔÅÒÅ.

>  --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/185/files#r2143329>.
>
>
The change should take place in SoOSiM, so the above code would subsequently change to:

> S.ReadyToRun -> return Active
> S.WaitingForMsg _ _ -> return Waiting
> S.ReadyToIdle -> if (null mb')

Doing the 'small step' by default would not change this issue. The point is that 'ReadyToIdle' only indicates that the component wants to go idle, but if the message queue is not empty, it will still be activated in the next tick.
I forgot to fix that. It's now the more logical allRemotes()
Ah, I definitely misread that. You're right. My apologies.
I will remove it to a single engine
Or may just need the Weaknesses name moving a few lines down.
Why not write this like:
```
  if ! $macaddress {
    $macaddress = getvar("macaddress_$title")
  }
```
And drop the use of $mac?
The complete initialization here in lines 90-140 is imho reused in all _core* files. We should add a function for this.
> I think I was going by Luxburg but I can check again.

Check it empirically :)
We no longer need the requirements as they are installed using apt, do we?
This doesn't sent a mail to the main mailing list.
зайві опції можна прибрати
Effectivement, je lisais le commit a l'envers...


On Fri, Feb 24, 2012 at 9:02 AM, Cyril Lacte <
reply@reply.github.com
> wrote:

> > @@ -15,7 +16,7 @@
> >   * Asynchronous fetch to check if member is registered at the ticketing
> partner
> >   * @author Agnes <agnes.crepet@gmail.com>
> >   */
> > -@Every("10800s")
> > +@Every("3h")
>
> Ben, la lisibilit : 10800s=3h
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cexbrayat/linkit/pull/112/files#r484147
>
s/pathes/paths/
There's not a real policy.  My rule of thumb is that debug code can stay, but anything that looks like logic that's dead and has been for 'a long time' that it should probably go away.  There's a few places in the code that have #if 0'ed out code that's left around as a warning that you can't do it like this, because... <foo>.  Those are useful to prevent accidental new attempts to transform the code.  Unfortunately those really _ought_ to be encoded as tests, but I bet aren't.
fix the warning about obj not being used. Same for the rest of the times too.
change to
if (width_ != NULL)
> Use QString functions for these manipulations, it will make the code easier to read and easier to maintain in the future.

Hasn't been addressed.  Use QString methods rather than char* manipulations
That is mainly because `getReference` is an ORM specific method
Should I use spaces instead of tabs to fix this?
At some point I'm pretty sure I `free(path)`. This probably leaks or has undefined behavior on some systems. Valgrind broke in OS X 10.8, so I'll have check this on a Linux system.
AFAIKS the majority of files in the code base does not have an empty line there.
Sorry, I assumed that was the last line in the function.
Shouldn't be in the interface (see note above)
You shouldn't really have a static object.

I'm not sure it is really worth protecting either of the calls with a critical section either - they are almost certainly going to only be called in the init/closedown code.
And this the current file...
Does this fix any existing code that should be noted in the commit summary?
Oh it's not that they can't - it's that they are allowed to not exist ...

Odd functionality - though perhaps need to keep for now..
jargv?
Among other reasons to prefer a plain `hg pull` for cache updates, using `--rev` or the like can require more CPU on remote server and/or client.
Please use a form to handle this instead?
We don't need much business logic validation but if we do (later) it's much easier to add that to forms.
At least if we start using a form we'll get automatic validation for the dates/dateimes.
Sorry @stevage, I should have been clearer. I don't think `USE_MIDDLEWARE_FILTERS = False` is good default behaviour. I think it would be surprising to most MyTardis admins, as all other ingestions methods use those filters. 

Without the filters, the pre-save and post-save hooks won't run, so I'm not sure why you're actually including the switch in the first place. Are there circumstances where those hooks would cause problems?
really I never had problems with parallel builds. It builds blazing fast (on 4-core i7 here), so it makes a difference.
If you insist on it, why not adding `if build.debug?` (not tested if it is called that way, may be named similar)
Couldn't this be `if not self.options.channel`
When I ran tests, this one failed. It looks like the assertion is incorrect -- shouldn't it be "array('foo' => 'bar')"?
Why the 3rd column? Are you sure this is robust against input file changes?
last comment is that you should parameterize the test so that the test is more data driven. Also, focus on making the test more readable. The comments are less important than the names of your methods which can give you all the description you need.
@shacker Can we also put the anchor tags on a new line and fix the indentation?
why should it be public?
This is a significant change btw.

Before, when `res.nil?`, it would just print the error and then move on and try to update anyway. I'm certain this wasn't intended.
The Version field isn't needed anymore, can be deleted.
I flipped it over to unless anyway
I believe I have taken care of this in the latest pull, please take a look.
Thanks, it was about the name. Everything else is clear from the code :) thanks!
In the long term we should really get rid of this legacy scaling, especially now that we impose that arrays are scaled between 0 and 1. I'll do it (and change accordingly the default values of beta) in a future PR.
-1 on this, as it breaks style with what people typically see in a Django app. The idea is to reinforce that it's "business as usual" by looking like Django's URLconfs.
You can use the common.instance_exists for this, which is basically the exact same try catch
While this would be nice, you can't use Object.keys() because we still have to support Firefox 3.6 :(
How often is this code called?  It looks like every time we need to recreate the verext array, which I'm guessing is often.  This will be really slow, creating an object literal and new instance of Polyline each time.  We need to be good about recycling data when we can.  If this code is rarely called, then might not be an issue.
is the double '_' intended here and below ?
Rather than creating two new `Cartesian3` instances here, can we get away with using scratch values?
Why not use `Cartesian2` or at least an object literal with `x` and `y`?
var statements should be grouped together to save space, i.e.
```JavaScript
var selectedValue = [],
    numColumns = this._columns.length,
    i,
```
There is a issue with this code: it works as expected (described in the doc above) only when _hitRect_ is bigger or same_ than scroll view bounds.
In case _hitRect_ is smaller the code does not limit the hit area. Basically, if hitTest is specified, it should be tested first.
Seems weird that we are keeping so many boolean values stored in the class and how we need getters for all of them.  I'd like to see this simplified... maybe stored all these values in a 'modified' hashmap?
Arthur Evans ;-).
We should move the i declaration up to the top of the function
We don't use any map APIs in this module so it can compile fine with the standard API version.
+ These could be processed within this worker or other workers could be used to processed these components. 
+  In this way, the workers stay task specific.
+
+ To orchestrate this, you could fire up workers from the page processor or even better use multiple message queues (in IronMQ)
+ and have the workers run off of those queues. The lists can be passed as message data (along with the page itme information in
+ IronCache in the event the worker needs to get the page source.
+
Any reason for moving this up here?
Typo "fufilled"