nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

This should fix things properly; FileUploader() was setting the
socket default timeout value, and apparently that doesn't work
properly with urllib. Also, the class had a bad try/finally
block that was causing the exceptions to be swallowed :(.

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.__init__):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
* Scripts/webkitpy/common/net/networktransaction.py:
(NetworkTimeout.__str__):
(NetworkTransaction.run):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.upload_json_files):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

Changed the CSS Parser to accept a conventional comma separated argument list for the
polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
polygon(10px,20px 30px,40px).  Now commas separate points: polygon(10px 20px, 30px 40px).
This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
Additional relevant information about CSS argument list syntax can be found
here: http://dev.w3.org/csswg/css3-values/#component-whitespace.

Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.

The existing tests have been updated.

* css/CSSParser.cpp:
(WebCore::isComma)
(WebCore::CSSParser::parseFillPosition)
(WebCore::CSSParser::parseFillRepeat)
(WebCore::CSSParser::parseFillProperty)
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
(WebCore::CSSParser::parseAnimationTimingFunction)
(WebCore::CSSParser::parseAnimationProperty)
(WebCore::CSSParser::parseExclusionShapePolygon)
(WebCore::CSSParser::parseDeprecatedGradient)
(WebCore::CSSParser::parseRadialGradient)
(WebCore::CSSParser::parseGradientColorStops)
(WebCore::CSSParser::parseImageSet)
(WebCore::filterInfoForName)
(WebCore::CSSParser::parseCustomFilter)
(WebCore::CSSParser::parseFontFeatureSettings)

* css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapePolygon::cssText):

LayoutTests:

Updated the tests to match the polygon syntax defined by the draft exclusions
spec - http://dev.w3.org/csswg/css3-exclusions.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unskip some tests on GTK+ that should now be passing.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unskip a test that should now be passing after r113004

* platform/gtk/Skipped: Unskip a test that should now be passing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
.: Compile the vibration module for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit: Add the vibration client for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry: Add a vibration client for BlackBerry and enable it.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): enable the client
* WebCoreSupport/VibrationClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::vibrate):
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):
* WebCoreSupport/VibrationClientBlackBerry.h: Added.
(WebCore):
(VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] moving a cursor on a misspelled word should not remove a misspelled underline
https://bugs.webkit.org/show_bug.cgi?id=83214

Reviewed by Ryosuke Niwa.

When Chrome enables asynchronous spellchecking, it adds Spelling markers in the
background. For this case, moving a cursor should not remove these markers
because it requires Chrome to spellcheck text again. This change prevents
removing Spelling markers added by spellcheckers asynchronously.

Source/WebCore:

Test: platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html

* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):

Source/WebKit/chromium:

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): use marker descriptions instead of spellchecking text when Chrome enables asynchronous spellchecking.

LayoutTests:

* platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt: Added.
* platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
https://bugs.webkit.org/show_bug.cgi?id=83252

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-05
Reviewed by George Staikos.

Test: http/tests/misc/resources/referrer-main-resource.php

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove intrinsic padding from contentBoxRect(), etc.
https://bugs.webkit.org/show_bug.cgi?id=83092

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-05
Reviewed by Julien Chaffraix.

"Intrinsic padding" does not count as CSS padding, but is treated as padding by basic
layout and rendering code, e.g. RenderBlock::layout(). A lot of code relies on the
equation border-box = content-box + padding + border (+ scrollbars). To keep this valid,
change 5 functions in RenderBox.h to not include intrinsic padding in the content box,
thus reverting to their behavior before the patch for bug 33593. Instead, have
sizingBox(renderer) in CSSComputedStyleDeclaration.cpp explicitly put the intrinsic
padding in computed CSS content-box values [for javascript getComputedStyle()], so the
above equation still also holds for CSS computed values. This seems more consistent with
how the padding...() functions behave since the patch for bug 23487, and will work
better for MathML. For instance, a block's contentLogicalWidth() will be the
availableLogicalWidth() for use by child elements.

No new tests. The only real observable changes are illustrated in the bug 83092 attached
test case and discussion. These are minor and hard to automate.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* rendering/RenderBox.h:
(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
    - Change these 5 functions to omit intrinsic padding from the content box.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::cellBaselinePosition):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening. Update baselines and expectations in fast/backgrounds, fast/block, fast/box-shadow and fast/box-sizing.

* platform/efl/fast/backgrounds/001-expected.png:
* platform/efl/fast/backgrounds/001-expected.txt:
* platform/efl/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
* platform/efl/fast/backgrounds/background-clip-text-expected.png:
* platform/efl/fast/backgrounds/background-clip-text-expected.txt:
* platform/efl/fast/backgrounds/background-inherit-color-bug-expected.png:
* platform/efl/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/efl/fast/backgrounds/background-leakage-expected.png:
* platform/efl/fast/backgrounds/background-leakage-expected.txt:
* platform/efl/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
* platform/efl/fast/backgrounds/background-origin-root-element-expected.png:
* platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
* platform/efl/fast/backgrounds/background-position-parsing-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
* platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
* platform/efl/fast/backgrounds/opacity-on-document-element-expected.png:
* platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
* platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
* platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
* platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
* platform/efl/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
* platform/efl/fast/backgrounds/size/backgroundSize16-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
* platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/efl/fast/backgrounds/size/zero-expected.png:
* platform/efl/fast/backgrounds/size/zero-expected.txt:
* platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
* platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
* platform/efl/fast/backgrounds/svg-as-mask-expected.png: Added.
* platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Copied from LayoutTests/platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt.
* platform/efl/fast/block/float/015-expected.png:
* platform/efl/fast/block/float/015-expected.txt:
* platform/efl/fast/box-shadow/basic-shadows-expected.png:
* platform/efl/fast/box-shadow/basic-shadows-expected.txt:
* platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/efl/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/efl/fast/box-shadow/inset-box-shadows-expected.png:
* platform/efl/fast/box-shadow/inset-expected.png:
* platform/efl/fast/box-shadow/no-blur-multiple-offsets-expected.png:
* platform/efl/fast/box-shadow/transform-fringing-expected.png:
* platform/efl/fast/box-sizing/box-sizing-expected.png:
* platform/efl/fast/box-sizing/box-sizing-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening after r112112.

* platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening after r110072.

* platform/efl/fast/clip/008-expected.png:
* platform/efl/fast/clip/008-expected.txt:
* platform/efl/fast/clip/011-expected.png:
* platform/efl/fast/clip/011-expected.txt:
* platform/efl/fast/clip/012-expected.png:
* platform/efl/fast/clip/012-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening; update expctations in fast/css-generated-content.

Mostly adapt to the size changes after the jhbuild and font
commits.

* platform/efl/fast/css-generated-content/003-expected.txt:
* platform/efl/fast/css-generated-content/009-expected.png:
* platform/efl/fast/css-generated-content/009-expected.txt:
* platform/efl/fast/css-generated-content/013-expected.png:
* platform/efl/fast/css-generated-content/013-expected.txt:
* platform/efl/fast/css-generated-content/014-expected.png:
* platform/efl/fast/css-generated-content/014-expected.txt:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
* platform/efl/fast/css-generated-content/inline-display-types-expected.png:
* platform/efl/fast/css-generated-content/inline-display-types-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline a couple tests for GTK+.

* platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
https://bugs.webkit.org/show_bug.cgi?id=83141

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-05
Reviewed by Adam Barth.

No new tests required.

* dom/DOMCoreException.cpp:
(CoreException):
(WebCore):
(WebCore::DOMCoreException::initializeDescription):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Leak in WebSocketChannel with workers/worker-reload.html
https://bugs.webkit.org/show_bug.cgi?id=83345

Reviewed by David Levin.

A speculative fix of memory leaks caused by worker-reload.html.

No new tests, as this change imposes no functional change.

* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
Receive the peer as PassOwnPtr<> so the destructor of the task object can
delete the peer even if the task didn't run before main thread's cleanup period.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129
REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken

Patch by Dan Bernstein, Reviewed by Beth Dakin.

This code assumed that the current CTM wouldn't have extraneous operations built into it, 
but this bug is evidence that that assumption was wrong. We should just get the base CTM instead 
and apply the device scale factor to it.

No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h: (GraphicsContext):
* platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Calendar Picker: Add code to open/close the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=83258

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This code is not used because of no ENABLE_INPUT_TYPE_DATE.

* WebCore.gypi: Add existing header files.

* html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
Moved from DateInputType.h because the constructor depends on
CalendarPickerElement.
(WebCore::DateInputType::createShadowSubtree):
Store a CalendarPickerElement object.
(WebCore::DateInputType::destroyShadowSubtree):
Release the CalendarPickerElement object.
(WebCore::DateInputType::handleBlurEvent):
Close the calendar picker when the input loses focus.
* html/DateInputType.h:
(DateInputType):
- Move the constructor definition to DateInputType.cpp
- Add function declarations
- Add m_pickerElement data member.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::hostInput): A helper to get the host <input>.
(WebCore::CalendarPickerElement::defaultEventHandler):
If the element is clicked, open a calendar picker.
(WebCore::CalendarPickerElement::openPopup):
Opens a calendar picker by ChromeClient::openPagePopup().
(WebCore::CalendarPickerElement::closePopup):
Closes a calendar picker by ChromeClient::closePagePopup().
(WebCore::CalendarPickerElement::detach):
Closes a calendar picker when the element loses a renderer.

(WebCore::CalendarPickerElement::contentSize):
Provides the initial size of a popup.
(WebCore::addString): A helper for writeDocument().
(WebCore::addJavaScriptString): ditto.
(WebCore::addProperty): ditto.
(WebCore::CalendarPickerElement::writeDocument):
Provides the source of a popup. The function creates a complete HTML with:
- WebCore/Resources/calendarPicker.css
- WebCore/Resources/calendarPicker.js
- An object to pass localization strings and <input> state
(WebCore::CalendarPickerElement::setValueAndClosePopup):
Sets the value from a calendar picker to the <input>.
(WebCore::CalendarPickerElement::didClosePopup):
Clear the popup object.
* html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Add declarations.

* platform/text/LocalizedCalendarICU.cpp:
(WebCore::getFirstDayOfWeek): Make sure this is 0-base. UCAL_SUNDAY is 1.

Source/WebKit/chromium:

* features.gypi: Enable ENABLE_PAGE_POPUP for non-Android
platforms. This is needed because ENABLE_CALENDAR_PICKER now depends on
ENABLE_PAGE_POPUP.
* src/ChroemClientImpl.cpp: Add stubs.
(WebKit::ChromeClientImpl::openPagePopup):
(WebKit::ChromeClientImpl::closePagePopup):
* src/ChromeClientImpl.h: Add declarations of openPagePopup() and closePagePopup().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so
fast/mutation/clear-transient-without-delivery.html and
fast/mutation/transient-gc-crash.html have been skipped.

Patch by JÃ¡nos Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
Reviewed by Zoltan Herczeg.

* platform/qt/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[REGRESSION] Refreshed autofill popup renders garbage
https://bugs.webkit.org/show_bug.cgi?id=83255
http://code.google.com/p/chromium/issues/detail?id=118374

The code used to update only the PopupContainer coordinates as if they were the coordinates relative
to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
location should be (0, 0) (and their sizes should always be equal).

Reviewed by Kent Tamura.

No new tests, as the popup appearance is not testable in WebKit.

* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
(WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
for passing into chromeClient.
(WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
(WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.
* platform/chromium/PopupContainer.h:
(PopupContainer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Unskip tests after r113323.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113419 268f45cc-cd09-0410-ab3c-d52691b4dbfc