labofsahil/github-event-dataset-2012 huggingface dataset:
It turns out that some of those old slides have some X coordinates which are negative.  (I know this is correct because their distance from the next position is consistent with other inter-position distances.)  The negative X coordinate coincides with a Y low-order byte equal to 255.

Fixed-point interpretation:

    .x  x  x  x .y  y  y  y z3
    00 e0 ff ff ff 64 36 00 00

Padding-byte interpretation:

    z1  x  x  x z2  y  y  y z3
    00 e0 ff ff ff 64 36 00 00

Eureka!

    z1  x  x  x  x  y  y  y  y
    00 e0 ff ff ff 64 36 00 00

I have seen {0, 1} in z1, {0} in z3 and now {0, 255} in z2.  In f1412ba5, Marco reported seeing z3 == 255, so that also fits.
payment now posts correct transactions, although the logic from payment confirmation to payment posted is hard coded. Probably a better "RoR" way to do this, but for now it works.
Isn't there some way to do the namespacing in a branch.  This line blows up when editing a blog post and still isn't generating the path you are looking for since it will generate 'refinery_blog_post_admin_blog_post_path'.  Since the routes are not being changed at the same time it seems like these commits really should be isolated until the process is finished.
I didn't know. Thanks for the tip. Btw, do you have an example of implementation?
Could we depend on underscore.js instead? I'd like to stick to dependencies that are peer-reviewed to death by the community :-)
Дальше идут два графических файла... А это прикол.. или прокол :) Они случайно попали в коммит, спешил... и не заметил, что они попали в коммит. Это файлы, которые я тестировал при создании спонсоров, что первое попалось на рабочем столе, то и закинул в логотип. Теперь моя тетя Тоня попала на github, ппц :)
It's probably not necessary to log success here, and I imagine it could produce excessive output in many installations.
Mmm... I don't understand what you mean...
Probably a good idea. It should only increment when `style.css` changes though...
I looked a little further. It looks like there is a problem with your "up_table_map". Had it been defined properly with a key for "upload_id", then, this line would have added the ID to the hash:

  $copy{$map->{upload_id} } = $id;

Your patch does the same thing. Search for "up_table_map" in your code and see what your find. Compare that to the primary key of the related database table. If the primary key is not named "upload_id", I think you've found your problem. If it has a different name, you need to use "up_table_map" to tell CGI::Uploader what it is. 

Perhaps CGI::Uploader could better detect a problem like this and issue a warning or exception.
I'm wondering, why fseek()+ftell()+fseek() when there exists fstat()? revealed while reading code that supposed to be Victor's :)
that´s right!
c? WTF? :p
irony* ;P
Can you send me the report? Also, I've never used Chrome, but does it have
the APIs Chickenfoot needs?
On Feb 6, 2012 10:45 PM, "bolinfest" <
reply@reply.github.com>
wrote:

> Ugh, so I submitted Chickenfoot for approval. It was rejected for tons of
> reasons: it contains obfuscated code, it calls eval(), the list goes on and
> on.
>
> The report was so overwhelming that I'm not sure I will ever have enough
> time to get it through the approval process.
>
> I'd be more eager to start from scratch in Chrome, in many ways.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/bolinfest/chickenfoot/commit/97fcf004a2cc9fc7ef24a39462badb338122fc1d#commitcomment-939652
>
The pattern we use in XAP is to explicitly name a "joker" template as a "template" variable.
It makes the code a little more readable.
In this case it means any TokenCounter() object
Can we add `@since Symphony 2.3` to the documentation.
I don't get what Java unboxing has to do with ours?
Off-by-one error, again.

These were easy to debug once I added the detailed exceptions in `ks_primitives` -- it told me that you were passing `nil` to `*`, which usually means an out-of-bounds array access.
Tracking messages that are 'in flight' = they have been sent but the send(... callback) hasn't fired yet.
I think it should be added as doc on defmojo.
assert(numRows >= commitRows) ?
Yeah you are right. The class has to be added in if branch and removed in else branch.
```SQL
(@Bag,3,4,1,0,-@RefB,1), -- one from Sigil of Beckoning
```
No need to duplicate the model to a view model, since that this is very simple model that is used just in one way.
Else than that, what is the bug? Please push again, without the new view model, as there is not really need for it.
do oyu have the base sql file for the malygos ? i cant find the sql anymore :O
дело в том что неправильно строится новая картинка.
у тебя есть новый @album, соответственно надо билдить картинку от него
(сейчас точно не могу сказать как, что то типа) @album.images.build
http://guides.rubyonrails.org/association_basics.html
там дан такой пример @order = @customer.orders.create(:order_date => Time.now)
com'mon guys, lol the point was made... ;) ... just if the ppl using this db that has customs have to take it upon themselves
 to make there own custom imports, not to hard to do...
 
plus this also keep the re-packers at ac-web chasing to keep up...since they have to always re-import everything lol...
 just to keep current. /shrugs... 
i'm sure update packs will come b4 long, just so much changes go in, it only (to me) makes sense
to re-issue the updates as a whole.
Hello, I am looking for library functionality in android-plugin. Could you please explain why this branch not merged with jberkel source? Is it ready for use?

PS right now my pool request to android-plugin hang. So i try to understand - do I need manually merge you code to plugin or wait a little ;-) and you push it to jberkel code. Or maybe is it incomplete?

Thank you,
Alexey
Maybe i am alone with this opinion: But i really liked the way how they faded out while raising.
Well this should not prevent you from pushing, as i said: maybe it is just my personal taste.

(lifetime change of course looks fine to me)
Does it evaluate incorrectly?
this is from this commit?
I feel bad if i mess the same hierarchy.  It will be cleaner, i think that separated from object code.
There *must* be some way to reload the current file instead of opening a new window?
일단 임시로 json 페이지로 링크 -_-;
Hi Baylore,
it's a very nice tutorial on MVC you have uploaded to youtube. and am not sure it's a right way to put's my comments on here or not. Am new in php MVC framework. And i like ur way of putting/coding, which you have shown so far in those part1,2,3,4,5 and 6. However, i was wondering if you could have done another part which would connect to a DB and have some functions on DDL,DML. or  could direct me somewhere i could find something similar to your mvc framework style. Many thnx for your effort and time.
I will use Element el_wrapper = writer.element("div", "class", wrapperClassName, "id", "wrap_clerrors_"+formId);
Why did you use the forceAttribute method ?
I don't like forcing contributors to ignore this file themselves, nor do I like enforcing that they a) use gemsets  or b) use a particular gemset.

However, I'd accept a patch that adds .rvmrc to the .gitignore and provides a .rvmrc.example file, if you want to send one along.
I also did some cleaning up, and fixed package reference. Messed up the message! :)
This comes from FXP sources and overwrites previous commit (b9da64839eb184511e5a56b7a90099a98a5320c0).
You probably want to use the size you get on 412 to decide the size of the byte buffer. Reference handleWrite to see what I mean.
Note that I also had to change the /var/apps/hannahsmithson.org directory to allow group write access :-

    chmod g+w /var/apps/hannahsmithson.org

I'm going to look at updating the provisioning recipes to ensure this gets setup automatically in future.
but ofTween is still included though elsewhere, and therefore oF doesn't build
Yes, this looks right.
wow, just in time for us as well, thanks !
.. bleah.
me pregunto si deberia ser ".local", "share", font_dir_name
I this this approach is superior as people can more easily find and reach you,
Problem with SurfaceFlinger & spontanious rebooting...
That is the plan.  http://forums.gradle.org/gradle/topics/plugins_and_classloader_isolation

Up to Gradle team atm.  If someone (ahem) we to be able to create a pull request to integrate this work into the Maven plugin, I am sure it would get integrated much quicker ;)
"$#array" returns the zero-based index of the last item in an array. The scalar function is used to force a scalar context, which is unnecessary here because the assignment is already scalar context. So all you need is:

$count = @ids;
Added future support for ignoring an array
Hum, this seems to introduce a regression :

```
$ make clean test
... during native code compilation...
+ ocamlfind ocamlc -c -warn-error +26 -g -annot -thread -warn-error A -package bigarray,num,str -package oUnit -I qtest -I build -I src -I benchsuite -I libs -I testsuite -I src/syntax/pa_comprehension -I src/syntax/pa_strings -I libs/estring -o qtest/all_tests.cmo qtest/all_tests.ml
File "src/batArray.ml", line 490, characters 2-27:
Error: Unbound value BatIO.string_of_t_printer
```
I'm using this -> http://code.google.com/p/msysgit/downloads/list
Oh.....really?
HEERROOOOOOOO
Cool, Now you can re-enable the header changing, since the headers weren't the issue :)
This would be better:

(int)result < 0 ? ClrInteger.One : ClrInteger.MinusOne;
should we remove CUTROOT from resulting link???
Re-instated the expected behaviour - see my change. But we need to let an empty experimental condition through if a gene condition was specified - this is so that we don't loose the user's expression type selection
tells pkg-config where is the local installation of libffi
I don't like the idea of this being exposed via an API. Can we just make it "username"?
I don't believe it is assuming `==` means `is`, though it is the case that `==` for sets is `is`.
30 maj 2012 kl. 01:20 skrev scullxbones<reply@reply.github.com>:

>> +      breakers.multiFailureCb.withCircuitBreaker(Future(sayHi))
>> +      awaitCond(breakers.multiFailureCb.currentFailureCount == 0, awaitTimeout)
>> +    }
>> +
>> +    "increment failure count on callTimeout" in {
>> +      breakers.shortCallTimeoutCb.withCircuitBreaker {
>> +        Future {
>> +          100.millis.dilated.sleep()
>> +          sayHi
>> +        }
>> +      }
>> +
>> +      checkLatch(breakers.openLatch)
>> +      breakers.shortCallTimeoutCb.currentFailureCount must be(1)
>> +    }
>> +  }
> 
> No there isn't currently.  Should I look to put something into akka.performance.microbench?

No, I don't think that is necessary.

>  Need some pointers here.

I think what Viktor is looking for is some test that verifies functionality with concurrent usage. Share same circuit breaker between several threads, eg futures. Simulate failure and verify that it behaves as expected.

> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/493/files#r896796
yeah, that would be super awesome
You can refer/link to classes [[akka.actor.Actor]], but I don't think you can for members, which is poor.
This is nice.

What happens if you do both startCluster and awaitClusterUp won't the cluster move the node to JOINING again?
This should be encoded in the Open state and not in the breaker itself.
Don't copy unless you have to
Good point, I'll document it.
epix
Feel free to remove it – I frankly didn't understand why the $ sign was there. If it is the distinguisher between trait and companion, then it makes sense.
Before pulling, can you remove (or include in the module docstring as an example) this part?
Yes, should be good
This check should go to public method or value.ToString () will throw
I suppose 'ijk' was refering to the input space, and 'scanner' is now refering the output space - is that correct ? (not really a comment  - just a question :)
this is bad you got the config passed to you in update_config() you could have cached it there and then you don't need to import pylons.  IConfigurable would have been an even better option.
Something about this is incorrect reST, at least in github's rendering of it. If the sphinx produces docs are fine, then ignore this, but figured I'd let you know.
I like 'Preferably' :)
je pense que pour ce pattern le seal trait avec des case class c'est mieux... https://github.com/wajam/nrv/blob/master/nrv-core/src/main/scala/com/wajam/nrv/tracing/Tracer.scala
let's talk about this line, not sur I get it
Is there a reason why it's not just replacing @ with the device name instead of just the first char being that?
I should have deleted this line. m_decode is set by render manager. It calls CRenderer::SetBuffer(int idx)
Please use strncmp for this.
I don't like this at all. I did the whole conversion from CStdString to more suiting types like std::vector<std::string> for the very reason to get rid of such things. With these changes m_strArtist and m_artist basically contain the same information, just in a different form and m_artist is IMO the better representation because it's a list of artists. Sure the m_strArtist may be easier to use in a GUI context but not in the database context.
Sorry, one last thing: `if mode_has('ALL', 'JOB_FLOW')`. We want `ALL` to take down the job flow.
It's actually the only way to ensure any custom "delete" logic is ran for each item.. 

But, still, it feels wrong :(
缩进有问题？
Remove the commented code please.
Wait, was there such a requirement? I, personally, detest spaces after the `if`… I'd find it slightly absurd if an open source project had such requirements (I also prefer same-like bracketing, like `if(condition) {`…)
Heh, I'm so smart at 11pm in the night! :panda_face:
Indentation is still screwy on these lines. I'm pretty sure just enabling tabs on the file won't update the existing indentation.
Стас, вот так будет верно, твой код неверен!
/MSIE\s*[5-7]\./.test(typeof navigator != 'undefined' && navigator && navigator.userAgent)
@charris - you did the work for sortlib, perhaps you have a suggestion?
это не его дубликат, тут идёт поиск свойства по значению и замена его, а у propertiesiteratora не хватает для средств, а то, что там было закомментировано - так это просто стереть забыл :)
I think it'd be better to just kill the `.`, as it really doesn't matter for the cache key, right? Something like `timestamp.to_f.to_s.delete('.')`. Also, please update the docs :).
There isn't reuse- yet, but after this PR goes through i'm planning on using the layout again in the routing exception page. That way we are consistent every time we show routes in the browser. Thats also why I re-factored the JS to not rely on jQuery.
I'm surprised, this is passing in Rails master? Probably the last version of sprockets-rails isn't being used
Susceptible to overflow; see http://googleresearch.blogspot.ch/2006/06/extra-extra-read-all-about-it-nearly.html
I know. I left as it needs to be changed in multiple places. I will make a separate pull request for that.
What do you mean recognized?
docstring is not up to date right?
OK, makes sense then.
Why are you setting a constant here?
This will copy either one chunk of data COPY_BUFFER_SIZE long, or if there is less left to copy, the remainder. It's all wrapped in a loop, so it copies all data in blocks of COPY_BUFFER_SIZE or less. 'length' is modified, maybe that is confusing?
This needs to be implemented in `Matrix`. As `Matrix` does not play well with `Basic` I am unsure when this will start working without stating it explicitly.
convert comments to docstring
`in`?
I was searching for something like `repeated_evaluation(func, arg,
times)` in `functools`, however I did not find anything more idiomatic
than this.
There are (IMO) an amazingly few number of modifications to have made this work. Since the person who wrote this inline comment thought non-sorting would be better and you've done that, it doesn't seem like there's any reason to not do this. (If there was I would hope that someone with insight to this would have said so by now.)
On the other hand, your `_mat` is not the same thing as `_mat` of Matrix. Matrix's `_mat` is the flat list of matrix data. Perhaps it *is* better to make this public. matrix, perhaps? mat doesn't look that bad, now, considering that you are actually storing the matrix.
Just have it return `self._to_mpmath(prec)`.
There's no `is_number` function in PHP. Have you tested your code?
same as for #1049:
"Added model validation rules blacklisting"
Wenn du den User aus dem Context verwendest, dann musst du diesen nicht wieder Persistieren.
Persistiert werden nur neue Entitäten, welche der ORM noch nicht bekannt sind.
assert(r == 1)?
line 62: config file treatment
line 77: command line parameters treatment
it will be better to unite two similar treatments
oh I know why, it's the Int.TryParse thing, the method call is guaranteed and the int is a out parameter so the method initializes it :) regardless of the if condition... so nvm :-)
``files``
this needs a conjunction
This is to sanitize the HTML in the EJS templates?
I've been using $rv for years, what would you suggest?
So $plupload can be a boolean and an object, right?
I'm just basing this on the existing precedent in the code. In all cases the include is wrapped in an isset() check and not instead set to an empty string. I assumed this was the desired behaviour.
This string should probably contain information about relative vs. absolute URL?
printf? debug?
Ok, I think its safe to remove since only non-external tables prob encode binary as base64
All these returns are very un-idiomatic, but I understand the appeal to a python programmer.
Should the line below reference Y.Env rather than YUI.Env?
I did not do it like that because if there is NO timezone it also has to work, and there might be only a negative ticks count.  So it would again find that minus sign at the beginning of the string.  Like this it won't find anything, and that's what we want :-)
What does just running 'make' do? Build the modules, or is something else build too?
added as subtask of code architecture, more major cleanup, ticket:
https://raxaemr.atlassian.net/browse/RAXAJSS-372
Where is orders coming from? You are also missing alerttype, defaulttask, etc. Make sure to go through the required fields and only include what you want.
You are redefining the builtin ```str``` and ```file``` here and in all your ```read_*``` functions.
вместо `(\+|\-)` можно писать `[+-]`

вместо `\d\d\d\d` можно писать `\d{4}`
Do we follow the convention of uppercase for class constants?
And for me as well.
@bfrog That's actually a good idea. I believe the reasoning here is that we already done the work to set up a set of expected request-response values in the test suite. No need to duplicate anything if all we want to do is to mess with the arrival rate of the data. I think it's much better if we do this in a separate issue though.
ohhh this is neat :)
`function ()` => `function()`
Yes, I did. We need to use such function (rank or row_number) to generate the UNIQUE CONTINUOUS NUMBERs. And the time for this operation (generating KV tables) is less than 10% of the total encoding time. Please see the testing results from connect and internet_ads. Therefore, i think it's acceptable here. If you have better solution, please let me know. Thanks.
```sql
dataset	          breakup table     generating KV tables	 generating vertical table	 
connect	         00:00:05.532092	 00:00:01.463905	      00:00:04.470939	
internet_ads	 00:00:08.114627	 00:00:02.594773	      00:00:05.439457	 
```
I tested on a 40 segments configuration running on gpdb[1-5].delta.sm.greenplum.com
Can you put a comment to explain why we need a function?
Please see line 2637
The values of all these variables will be the same for all data points.  What is the rationale for running this check on all the points?
Mark this as a build-time dep: `depends_on 'asciidoc' => :build if ...`
yes that is even better
Weren't we supposed to use the mongo store as the default store?
I think a clearer version would look like this:

``` ruby
def set_level(default)
  return default unless @crumb_levels
  action = self.action_name.to_sym
  @crumb_levels[action] || default
end
```

What do you think ?
命名“为”
I appreciate the work that's gone into coding and documenting this so far.  Unfortunately, the more I look at the javadoc, the more I feel that there's substantial writing left to be done to really explain the feature.  I can think of two ways to open this up to more users:

1. Ask on junit@yahoogroups if anyone would like to be a collaborator on the documentation.
2. Pull the new feature out into your own custom ConfigurableCategories runner, in your own library, and release it for usage and feedback.

Let me know how you'd like to move forward.
No extra spaces inside if(), please
Oh, did they actually name their page-size parameter `page`? If so, gross, and ignore my first comment :)
Spacing looks inconsistent here
There is a 
```java 
Bukkit.getScheduler()
```
No need to go over the Server instance.
I think something like
`get "/:os/:type/?"`
on the original route will match with or without the trailing slash. Shouldn't have to redirect.
Should clarify that it's up to clients to do timestamp checking to figure out which documents that they care about have changed in that case.

(In the future, we should figure out if we can centralize that logic as well. It seems a little weird to have this class track in-memory changes, but have the clients be responsible for tracking filesystem changes. I guess that will all get better with filesystem watchers in any case.)
"?boolean" indicates that the boolean parameter may be null. You should use "boolean=" to indicate an optional parameter.

https://developers.google.com/closure/compiler/docs/js-for-compiler
Does this event need to triggered *before* "open" class is added above?
Why is this language "root" instead of "en-US"? I don't think I've ever seen it done that way, and it makes it harder to distinguish from other English languages such as en-GB.
FYI, it looks like the success callback is not nullable/optional according to the W3C spec, so we currently have the "correct" behavior in NativeFileSystem. Seems a little annoying from an API design point of view, but we want to stick with the spec.
Should probably also test the related case where we've never notified before, but Brackets _is_ already up-to-date: _buildNumber: 93 but _lastNotifiedBuildNumber: 0.  (E.g. first launch on the day the build was released).
I believe the still are equal
I just tried on c9.io
maxsize should definitely be a configurable setting as well as the queue sizes for the clients below. I'm also not sure if they need to be different. Though I guess I could see a slow client might want to have a larger queue size.
I think the parens and other punctuation count as part of the translation, the most trivial example being that in e.g. Chinese,'（', and '）' are different unicode characters from '(' and ')', etc.
`custom-theme-load-path` was added in Emacs 24, perhaps add `(when (boundp 'custom-theme-load-path)...)`
It shouldn't be needed to parse the files, and then re-generate them again. Instead; just concatenate the strings
You are assigning the input gathered from your `showInputDialog` here to `First_Name`. If you look above (line 36 - line numbers are on the left hand side), you initialize a variable called `First_Name` and set it equal to an array of 100 Strings. The compiler will throw an error here because you are attempting to assign a String (the return of `showInputDialog`) to a variable that's been declared as an array of strings.
In Java arrays have a fixed-length and are not resizable. To resize arrays you either have to create a new array of a different size and copy all of the data from the old array to the new one, or use a variable-size container like an [ArrayList](http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html), which has the convenient methods `add` and `remove`.
Awesome !!! When can we test it on staging ?
Hm. What if we would just extend Facebook backend from the default one above? Then we would just have to change `authenticate` and we get everything else for free (like permissions)?
But you cannot hardcode `next` - you should use the value from `django.contrib.auth.REDIRECT_FIELD_NAME`.
Same reasoning as below, Safari 5.1 supports linear-gradient
why wrap the fn call in an anon fn?
Could you make this comment and the one for join more descriptive? They don't really make sense as is.
No, I think you're right in pointing this out, but I'm not sure it's bad/wrong. My intent was for you to be able to call `spawn()` and just have the dialog appear without waiting for it to initialize. Think that's too confusing?
Spaces between `if` and `(` are needed. Also near the `!=` operator
There should be a time out after some time in case AWS or Agifog isn't working properly otherwise we could end up in a scenario where many processes are hitting AWS. Also, the retry time should be increase every time 10, 20, 40 so it's less likely that that the requests are run at the same time with can decrease the responsiveness a little.
Yes. I'll take it out
I've moved the method to misc.hh (i've no clue if that's good). Now using that.
yes, i believe rfc1982lessthan would be correct here
This definitely looks like an oversight on my end…
While having a convention about the way to provide exception in the context to allow a special handling is fine, I'm concerned with this implementation: it will log only the exception and drop the log message (which could be better to understand the issue as the dev could have explained why he catched the exception in this case and logged it).
I can't remember why the setTimeout was here but I'm pretty sure there was a reason :)
Can you add a class docstring here?  one sentence will do, but it would be good to have that, because the first sentence is used in the API/Reference table.
It wasn't checked in the basho_expect test either. Perhaps we should make it do something else?
Why convert to try_receive instead of timed_receive? With timed_receive we can handle URIs instantly without any messy Sleeps and without eating CPU?
Please make this (arbitary?) limit of 64 a constant instead of a magic number.
Well we could always add a random() method to String class if that is something people will frequently need.  I don't think it should belong on Security unless we're going to get crpyto strength random data which is harder to come by on most hosts.
Removed and used existing exception
right, seems odd to calcaluate with MB in the strings, pow() converts all to numeric, but i think its clearer if i take it out.
Also will make it strtoupper
Shmanks.
what about ``isFoo`` ?
These things are constants defined here, but in practice they're pretty much hardcoded: the amount of hand-coded logic and regexps everywhere that assumes these values is so big that we might as well call them 'the ipython language' once and for all and drop any pretense that they will ever be user-tunable.
Should this be this.deleted.addAll(keys)?
Super Duper Leaker (C)2012
Agreed! An unfortunate evil. We've still cleaned out 99% of the inline js from the old site!
Really? I thought it was cleaner to pull out of the try block everything that cannot raise an error. And that's what Python's doc recommends to do.
On 5/23/12 6:14 AM, Adrian Gaudebert wrote:
>> @@ -15,7 +15,7 @@ SELECT create_table_if_not_exists('release_repositories',
>>              ( 'mozilla-aurora' ), ('mozilla-aurora-android'),
>>              ( 'mozilla-esr10' ), ( 'mozilla-esr10-android' ),
>>              ( 'release' );
>> -    $x$,'breakpad_rw');
>> +    $x$,'breakpad_rw');well,l
> 
> Is that wanted? It doesn't look like SQL or PL/SQL to me, so I just want to make sure it's not some typo. 

Hmmm.  That looks like the commit got mangled.  Let me check.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
Is that wanted? It doesn't look like SQL or PL/SQL to me, so I just want to make sure it's not some typo.
I'd prefer it didn't, and that the caller explicitly specify the value to set.
Actually this change aligns the method signature with the 1.7 version, only adding 'final' and a tweak to the implementation. So this change makes this class backwards compatible again.
The modules module does not actually exist anymore, modules and themes have been merged into a new "Addons" module. 

Take a look at this commit to see what has changed: f4033fd09318342187e2dd01981407a431e9cb7d
не перевіряє значення value,  воно підходить для label, textarea але не для input-a
The brace should be on a new line.
matching `.*` makes no sense because it could simply be removed without any impact.
well, you can inject it in the DIC, but you cannot inject a pre-configured builder (well, you can, but it will be lost when resetting). So this is quite limited.
The ProcessBuilder (as all other builders in Symfony) is a single-use object. If you want to use DI for classes using a process, you should probably create a dedicated object wrapping the process logic (a bit like (Composer's ``PocessExecutor`` class](https://github.com/composer/composer/blob/master/src/Composer/Util/ProcessExecutor.php))
It seems like it's broken when a route has the same regex but a different method requirement for example.
All of these options seem to have been available from the config file. For instance this is from the bot's help page:

```
  -R REPOSITORY, --repository=REPOSITORY
                        Change the default 'sympy/sympy' repository to
                        something else. This allows to use sympy-bot with
                        other projects.

```
A quick check shows that changing `(.*?)` to `\d+` and `[.]` to `\.` does not parse the regexp at all.

    > var ua = 'Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.34 (KHTML, like Gecko) rekonq/1.0 Safari/534.34'
    > var regex = '(rekonq)/(.*?)[.](.*?) Safari';
    > var m = ua.match(new RegExp(regex))
    > m
    [ 'rekonq/1.0 Safari',
      'rekonq',
      '1',
      '0',
      index: 69,
      input: 'Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.34 (KHTML, like Gecko) rekonq/1.0 Safari/534.34' ]
    > var regex2 = '(rekonq)/(\d+)\.(\d+) Safari';
    > var m2 = ua.match(new RegExp(regex2))
    > m2
    null
TJ, I guess you can just merge this line and make 99% of  display usage work properly. Only `display: box !important` will fail.
I commented on this, but I'm not seeing it now.

Part of the problem is this script is also run locally, where someone might very well be using RVM.  Maybe it doesn't matter there, but I figured I'd play it safe.  If you know that it doesn't I'll gladly remove it.

I'm reticent to force a full upgrade on people too.  Since this one file would be used across all nodes, I thought I'd make it work in both cases.  I should probably fix crontab to do the same.  Passenger I don't care about because the config is generated and stored just for that one role.
These days you can simply do:

```ruby
render 'title', title: 'my title'
```

So yes, the outer locals can be left off.
Hmm, i missed it somehow. Why you've deleted this code, is it failed to work?
> Changing to is not would do an object identity check

Yes. Of a singleton (it is either ```True``` or ```False``` right?). Its so trivial, but I cannot see *any* benefit to using the caret - please enlighten :-)
I think you may be correct on this but so long as SugarCane is initialized after the bases it should be fine (and thus this method is un-needed).

Order is important in VanillaMaterials.
One option that @jystewart  and I discussed last week was to use a Redis or Memcached-backed Rails cache store (presumably shared across the nodes). Would that work, @jamiecobbett ?
This if statement looks unnecessary.
is undefined behaviour, since you haven't defined the behaviour in that case
I'd perhaps eliminate all mentions of Ember.State to avoid confusing people.
One difference between this and the previous code is that the Ember.assert will get stripped in production but the `!mixin` check won't be. Do you think it matters for us to have a check in production?
How I can do it better?
two User_Profile in the messages.json
Do prefix this with "swarm". The url we are adding parameters to here may already contain several parameters (we're pointing to the test suite, possibly executed in-app, basically intruding here).

(also, add a space after `//`)
?? free newlines?
this should be `C:\\some\\path`, right?
Can you clarify what this does? (lazy reviewer)
So people would know the keyword `ready` without looking for WebIDL again.
if (evt.detail.type !== 'geolocation-status')
       return;

and save indent below
Perhaps instead of showing the overlay in line L208, we could call:

contacts.List.load(true);

that shows the overlay by it self, the result (success or error) from the logout request isn't that important? (Or maybe I'm missing something else)
we are missing  |></script>|
Why is there those labels and buttons that are invisible in the example?
dom.min_timeout_value:4 <- yep
This should be `assert_finished!` rather than `assert_finished?`, right?
not sure but can you use script.cloneNode() here ?
What about:  

    for(x <- xs; if !seen(x)) {
      buf += x
      seen += x
    }

?
I don't remember why this tests are disabled
saved ジョブ :smiley:
** 強調もれ（原文と差異）
Это по желанию :) Перед тем, как вливать правки, нужно протестить. Сейчас нету возможности, думаю попозже. 

3 дек. 2012, в 11:49, Maxim Kulkin <notifications@github.com> написал(а):

> In config/locales/ru.yml:
> 
> >        no_shipping_methods_available: "Для указанного местоположения отсутствуют способы доставки, пожалуйста, смените адрес и попробуйте снова."
> >    errors_prohibited_this_record_from_being_saved:
> >      one: "1 ошибка не позволяет сохранить запись в базе"
> > -    other: "%{count} errors prohibited this record from being saved"
> > +    other: "%{count} ошибок не позволяет сохранить запись в базе"
> Спасибо. Поставьте "+1" тогда в общих комментариях. Ну или как тут у вас принято? =)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Close this file once you're done with it.
But it won't get to that point because of the isVariable check right?
You could perform the replacement on `value` before calling `.html` and by-pass `.text` altogether, but is this really the behavior we want for the `text` binder? I suppose if the programmer doesn't want newlines replaced they could use the `html` binder.
@l3l0 would be good if you extend the full words from CF as they are not clear
Generally, we try to avoid using onClick events directly on a button. Instead, using 

    $(document).ready(function() {
        $('#specificId').click(function() {
            window.location.href=foo;
        });
    });

onClick (and onHover, onMouseOut, etc) clutter up your HTML quite a bit and mix presentation with behavior, which you generally want to avoid. The practice is called [unobtrusive javascript](http://en.wikipedia.org/wiki/Unobtrusive_JavaScript) and it really helps with readability and maintainability of your javascript code. 

Also, I haven't actually seen this UI, but I would question the use of buttons as navigation elements in general, though. Users general have the expectation that links take you somewhere, while buttons "do" something. This "actions" div seems to be a part of a navigation menu, so I would consider using one of the [Bootstrap Navs](http://twitter.github.com/bootstrap/components.html#navs)
Formatting here. (No before method params)
It would work without it. But it removes the usefulness of bundler, which is to limit the available gems to the ones specified in the Gemfile.
See http://gembundler.com/bundler_setup.html

And as you've used rails, you have actually used it. See `config/application.rb` : https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/config/application.rb#L16
isSequential=true means repairing the column families sequentially for each keyspace

From: Matthew Bogner <notifications@github.com<mailto:notifications@github.com>>
Reply-To: bazaarvoice/Priam <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, October 23, 2012 10:57 AM
To: bazaarvoice/Priam <Priam@noreply.github.com<mailto:Priam@noreply.github.com>>
Cc: Ahaduzzaman Munna <ahaduzzaman.munna@bazaarvoice.com<mailto:ahaduzzaman.munna@bazaarvoice.com>>
Subject: Re: [Priam] [EMO-237] Implemented scheduled repair of Cassandra nodes. (#3)


In core/src/main/java/com/netflix/priam/noderepair/NodeRepair.java:

> +    private AmazonConfiguration amazonConfiguration;
> +
> +    public NodeRepair(CassandraConfiguration cassandraConfig, Optional<ZooKeeperConnection> zooKeeperConnection, AmazonConfiguration amazonConfiguration){
> +        this.cassandraConfig = cassandraConfig;
> +        this.zooKeeperConnection = zooKeeperConnection;
> +        this.amazonConfiguration = amazonConfiguration;
> +        this.lockAcquireTimeOut = Duration.standardMinutes(cassandraConfig.getLockAcquireTimeOut());
> +    }
> +
> +    public void execute()  {
> +        try {
> +            if (!zooKeeperConnection.isPresent()) {
> +                return;
> +            }
> +            JMXNodeTool jmxNodeTool = getJMXNodeTool();
> +            jmxNodeTool.repair(true);


what does isSequential=true mean?

—
Reply to this email directly or view it on GitHub<https://github.com/bazaarvoice/Priam/pull/3/files#r1917833>.
I'm not entirely clear on the point of confusion. Could you suggest an alternative phrasing that would be more appropriate?
Adding a dependency on underscore just to find if a intersection exists seems a little excessive, @Kami thougths?

Also I think we should call it `var underscore`, rather than using `_`
why skipping hidden files if they were part of the original package ? it means you are only caching a partial package
Same here, catching doesn't add to the functionality in my opinion.
has anyone an idea how we could realize something like:
```
PIN_CLEAR(usart(TXD));
```
Around left part of expression by bracets
Minor. 'make init' was creating the device node, but 'make clean' was not removing it, so a 'make clean' followed by 'make init' would fail due to the file already existing. I added the rm line to the clean target, but since I'm not testing cnet I've commented them both out.
Here we need to set *buffer_len to 0 as this is the test used in https://github.com/inliniac/suricata/pull/142/files#L7R212 If not a failure will cause suricata to try to work on a NULL buffer.
Ok, I've changed that.
Thanks, it is nice to have it in code, so you can quickly recognize it and then you can decide if you can switch to _POSIX_SOURCE for example.
I don't think you want to end with `,` here.
I addressed the rest of the comments, but I'm not sure I'm following you here. What do you mean? `bar` is not in the DOM already.
Cool, this will capture the most critical places to message the user.
@benadida - I really like this simplification of the previously janktastic code.
Is there a bug in the latest PyPI release of python-oauth2 that forces us to use an unreleased github version?
I now see the "Windows Classic" issue and can't unsee it. I'll reopen the bug and see what further discussion happens and deal with it on Monday.
See also http://doc.opensuse.org/projects/YaST/SLES11/onefile/yast-onefile.html#id_ycp_listmap
This config  is for css concatenation, it's needed even when using raw css.

I've retested without the empty `compiled` config and it worked, so removed it.
If *iconv* function can have notice or warning, we have a *internal mechanism* for that, look [Zend\Stdlib\ErrorHandler](https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/ErrorHandler.php). Ask more at Matthew.
Message::getSubject() was used only in sendmail.
I will check if getters for other properties proxied to Headers  are used in transports and replace them with direct access too.
You must use `||` instead of `or`
$row is being set by 2 while loops within one another, this can cause an unexpected $row and an overflow since $result is also being changed within the while loops aswell -- Though I yet have found the reason for these while loops... you should only be working with one realm ($realm_id) and 1 character ($guid)

Also connect::selectDB($char_db); should be connect::connectToRealmDB($realm_id);


Easier way to do the above would be on line 90 change it to
```PHP
connect::connectToRealmDB($realm_id);
$result = mysql_query("SELECT name,guid,gender,class,race,level,online FROM characters WHERE guid = '{$guid}' AND account = '{$acct_id}'");
if (!$result || mysql_num_rows($result) != 1)
 die('Possible sql injection detected');

$row = mysql_fetch_assoc($result);
```
Use templating for the footer (#footer).
I'd suggest turning "TodoElement.dart" into a library.  You can now use the
export command if you want to reexport TodoElement.dart from app.dart
e.g.
export 'TodoElement.dart'


On Wed, Oct 24, 2012 at 3:16 PM, Mathieu Lorber <notifications@github.com>wrote:

> In labs/architecture-examples/dart/dart/app.dart:
>
> > @@ -0,0 +1,39 @@
> > +library todomvc;
> > +
> > +import 'dart:html';
> > +import 'dart:math';
> > +import 'dart:json';
> > +
> > +part 'TodoElement.dart';
>
> What should i do ? I shouldn't use import (? - and I did not manage to
> resolve internal errors with it).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/addyosmani/todomvc/pull/295/files#r1935116>.
>
>
Nothing, I just grabbed a pretty complete Gemfile from a previous project, not very minimilast of me
Why not protected ?
CS: missing space between ```foreach``` and ```(```
It is obvious now that I know your reasoning, but it sure was not obvious when I saw this file on it's own.
But if you add better class doc all over the place on the changed files here, that should do it as well :)
Anwsering also last comment:

I think that we should keep this as `uuid` or at least `uniquename` / `identifier` because `username` in that case is really confusing, more that this IMO.

Additionally I'm +1 about changing `getDisplayName()` to `getNickname()` and this `username` to `nickname`. So this would make clear picture of what is what:
* `identifier` → `id`
* `nickname` → `login`
* `realname` → `name`
The only part that stands out to me is the URL scheme. Generally speaking CRUD url schemes use a single root for all CRUD operations (so no "/task" and "/tasks" simultaneously).
I think you want to include _header, to be consistent with both the locator and the other header tests that have it appended
This should be `slug` because it's not a url, it's a slug.
Yay for the default port.
Nope. self.mozillian_client isn't defined.
These options are only relevant when manually triggering a build. When this is done we typically don't want the report to go to mozmill-ci but to mozmill-crowd. When pulse triggers jobs it will still use the appropriate report URL.
are we sure the twitter plugin applies "px" values to this and the width attribute?
Technically I spelt chache correctly though :P

Kidding, good catch.
Can you define a plugin that has no function definitions and still have it work? Just to make the test smaller.
ripper is not used any more
should we merge without this part?
should be fixed - I hope if conditions evaluate sequentially? Couldn't test
this, the xpath returns the highlighted section in the menu which is/should
always be there.


On Mon, Dec 10, 2012 at 9:03 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In OECD.js:
>
> > +	but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +	GNU Affero General Public License for more details.
> > +	
> > +	You should have received a copy of the GNU Affero General Public License
> > +	along with Zotero.  If not, see <http://www.gnu.org/licenses/>.
> > +	
> > +	***** END LICENSE BLOCK *****
> > +*/
> > +
> > +function detectWeb(doc, url) {
> > +	if (ZU.xpathText(doc, '//ul[@class="sidebar-list"]//a[contains(@title, "Cite this")]')){		
> > +		if (ZU.xpathText(doc, '//li[@class="editorial-board"]')){
> > +			return "journalArticle";
> > +		}
> > +		else if (ZU.xpathText(doc, '//li[@class="menuitem"]/a[@class="on"]').indexOf("BOOKS")!=-1) {
>
> This may cause some unnecessary exceptions being thrown. xpathText could
> return null.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/467/files#r2373928>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
Is there a reason the markAsFInished line was commented out previously?
...and something similar for the other problem types
can you move these to the top of the file and add a space after the `//` ?
@igorw, you're not right. That's by design.
Not used here, but is one potential storage location for authentication credentials
Perfecto.

Sent from my iPhone

On May 6, 2012, at 11:31 AM, Eric Ferraiuolo
<reply@reply.github.com>
wrote:

>> @@ -14,6 +14,9 @@ Photo = Y.Base.create('photo', Y.Model, [Y.ModelSync.YQL], {
>>     pageUrl: 'http://www.flickr.com/photos/{user}/{id}/',
>>
>>     buildQuery: function () {
>> +        // one time initialization for FLICKR_API_KEY in lazy mode
>> +        FLICKR_API_KEY = FLICKR_API_KEY || YUI.namespace('Env.Flickr').API_KEY || '';
>
> I think it would be cleaner to stick this in a utility function at the top of this file, then anytime it is needed, `getFlickrAPIKey()` can be called.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ericf/photosnear.me/pull/1/files#r779218
You will want to put these strings into `src/locales/en.ini` and remove the text content.
8e023e9
Seems weird that you make absolute paths here and then make them relative again inside the callback functions.
Ok i will try to convert this to become one of the regions module then
The reason I had it as `function request` and then assigned it to `this.request` later is because this function can be recursive, in the case of a 301 redirect. I think this change breaks that. You haven't noticed because `api.js` is good enough to not need it right now.
I vote for `com.puppetlabs.http`
I find the file easier to read when all public methods are at the top and all private methods are at the bottom. This file deviates from that somewhat to separate roles, groups and permissions, which is mostly due to the sheer size of this file. I don't really have a strategy to reduce the size of the file yet, though. I'm open to suggestions :)
I wonder if we should rename action to role. 'viewer' or 'member' isn't really an action, it's a role.
I believe the missingMembers were introduced when groups could still be completely private. I think this can be removed now and we can just throw an error when members don't exist.
modules doesn't seem to be a param. If defaultConfig is returned it should be prefixed with callback.
Should it be `_.threadRef eq thread`, like in `removeThread` a few lines below? (I know you didn't write this line, just noticing it because it's highlighted :smile: )
GlobalEnv.class is implied, (literally every function uses it, even if not directly) so that's the only case where you can skip it.
good spot. fixed in #98918
weghalen als je dit niet meer gebruikt
А вот эту проверку надо внести в сам метод mutate — сами методы должны проверять входящие данные
DNA_CAPACITY это константа, размер массива DNA. А hammingDistance возвращает distance - метрику между клетками.
Менять каждый элемент нужно только один раз. Такой подход этого не гарантирует.
а почему именно в этом отрезке? почему не просто 100, ведь эта конструкция все равно раскроется как arc4random()%100
Не уверен полностью, но кажется, здесь каждый раз создается новый массив [NSArray arrayWithObjects: @"A", @"T", @"G", @"C", nil].
Теоретически бесконечным я назвал цикл рандомизации гена
            while (variant == currentVariant) {
                variant = [NSString stringWithFormat:@"%c", [Cell returnRandomGene]];
            }
Согласитесь, что random (пусть и с очень малой вероятностью) может долго возвращать одно и тоже число (к тому же на выборке из 4х элементов)
тут что-то странное с названием файлика :)
I wrote ``setimagecolorspace`` as ``setColorspace`` does not exist for gmagick.
I don't get the point between ``setimagecolorspace`` and ``setColorspace``