labofsahil/github-event-dataset-2012 huggingface dataset:
Very smart! I like the use of the partial here.
I meant factor out the MessageFilter.create() < -- > .setTimeout() into it's own method since it's duplicated 3 times.
```objc
[[[signal1 deliverOn:RACScheduler.backgroundScheduler] sequenceNext:^{
	// blah
	return signal2;
}] subscribeNext:^{
	// blah
}];
```

Any two execution points needing to be synchronized will need to know about each other in some way anyways. Requiring that those two signals are both known in one scope seems reasonable.
These two `robot.hear` should probably be `robot.respond`` and you'll be able to remove the `^(?:hubot )?` bit of the regex.
I believe you can drop the `to_i` in both instances here
Not enough exclaimation points.  need 2 more
Hehe, once or twice :P
This should be a lockable hook required by lockable. recoverable is just one of the ways to expose the failure. :)
I thought we had received permission to open-source this client as BSD, @morgs can confirm.
Gr8. I was not sure about stock so i agreed with @radar. So deleting order will not be good idea.  if Stock isn't assigned to order than deleting line_items is also not needed...rite @radar ?
а мне не жалко
This is one of the side effects of ours having a deeply nested structure. I came up with an alternative solution, but I'm not sure if it's easier to read:

if obj['samples'].get(scilife_name, {}).get('library_prep', {}).get(prep, {}) != None:
This always evaluates to true?
A module is not made up of many classes. A module could be included (Mixed-Into) in many classes.
missing "return" keyword
Now it's awesome!  Err...  I mean Epic!
I meant if the caller included extras in general but no extra for the map mode
with alwaysRun=true so that it gets executed regardless
I think this method is safe without the synchronized keyword because the map is initialized during the GCR constructor, and the GCR reference is then written to a final field in the DCM constructor.

On the other hand, the result Map is modifiable, and anyone can change it without any synchronization, so there is a potential for concurrency problems here.
No because TxCompletionNotificationCommands is not visitable.
838b9713ece51ecd01b7304378b99eb3596be18e
You realize that by moving examples around, we will need to go back over the doc strings and the ReST files and change plot directives that refer to these examples, right?
With these "enable" and "disable" functions, you have very similar functional logic, with the exception of the string and the boolean in the function. Can you squash this down from 4 to 2 functions possibly?
It looks like there are some indentation inconsistencies here. This should match up indentation-wise with the `return` statements above and below.
No. But I wonder if anybody at all uses 1.1.0.
Isn't this going to clear the value of hiddenInput every time the user changes the main input, rather than just when the main input's value is empty like the existing conditional?
Right. Am having a terrible time building hybrid - but will change when I do.
@bp323 Can we add `$rootel` in here?
@dooremont can you translate this?
please put lambda on new line
There might also be vectors/matrices of SGObjects, you need to iterate over all of them
TSGDataType contains a field length_x length_y, (these are pointers so carefull, might be NULL)
@chillu Good point, I guess it depends on how much PHP 5.4 testing we get done before the SS 3.x release. We could probably be conservative and just say 5.3 for now.
I really prefer not to bring "TODO"'s into the framework, what else needs to be done to fix this?
To je ze zadání? Podle mě tím OK mysleli EOK, ne?
not a fan of $ in "user" scripts varnames, but we can rename it to something more informative...
On Wed, Aug 1, 2012 at 7:48 AM, Michael Cahill <
reply@reply.github.com
> wrote:

> I had this explicitly because it was the only case where we might or might
> not be holding the schema lock.  Now I'm concerned that I have to look at
> every `WT_WITH_SCHEMA_LOCK` and try to work out whether it could be leaving
> the schema locked.


I backed out this change, so it will be back to the way you had it.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
Still needs changing back properly.
Please revert to '===' as these are on purpose here!
Just as a future note.
instead of 
```ruby 
unless overrides.nil?
```
you can do
```ruby
if block_given?
```
Is it possible to add a ``@param`` annotation for parameter ``$dbconnection`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
ok guet voila!
Ev. besser `getCurrentRating()`?
use one-line function syntax here
[Done](http://code.google.com/p/dart/issues/detail?id=5173).
This was gone while trying to setup how the testing procedure run, my bad. Next commit will be about testing and will reinstate a rewrite of this without the Mockery dependency using PHPUnit mock objects mechanism.
Why would you like to rename this ? I use the same syntax of the first filters "localized date".

In Twig, we are "number_format" on [Twig Core Extension](https://github.com/fabpot/Twig/blob/master/lib/Twig/Extension/Core.php). It's not a good idea.
typo "available"
add `backend` as an optional kwarg here for easy override?
Also, Jabber::Simple is not the most idiomatic piece of Ruby out there :)
Just to confirm, should_not?
i agree - would be nice to make use of ddmslib for executing commands. there is already some code to initialise the debug bridge / device in `AndroidDdm.scala`.
it is a requirement for pytest-mozwebqa
A note though : it doesn't work with debian default install since debian has either python or python2.6 but no python2... But creating a simple symlink solves this.
it is the same as in core ..
Minor naming quibble: I'd rather see `#needs_js_copied?` invoked outside this method (on #L11), or this method renamed to reflect the conditional behavior.
Don't create fragments like this.
Default should be ''.
Moves. http://api.jquery.com/appendTo/
Add `channel_id` field.
I wasn't paying attention to this, because you assumed timestamp works as we thought it does, and I just thought you're probably right. I don't know what is its purpose then.
Ternary party!
We still support 32-bit when possible, if we can get 32-bit binaries also then something like

```ruby
if MacOS.prefer_64_bit?
  url ...
  md5 ...
else
  url ...
  md5 ...
end
```

should suffice.
I agree, and I think the title text should be the same (they are all tasks
anyway). As for the css, I just wanted to standardize the color :)

On Mon, Feb 20, 2012 at 5:14 PM, Zuzel Vera <
reply@reply.github.com
> wrote:

> >    <div id="task-discussion" class="content_page">
> >      {% if can_comment %}
> >        <a class="button post-task-comment" href="{{ new_comment_url
> }}">{{ _('Post Comment') }}</a>
> >      {% endif %}
> > -    <h1 class="tasks-title">{{_('Task Discussion')}}</h1>
>
> We should keep the tasks-title class (since it has some css associated to
> it) and probably just the 'Task Discussion' text for the header (it
> probably does not matter to much if it is called Task Discussion or Comment
> so I am choosing the newest name. The UI for challenges was designed more
> recently).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/p2pu/lernanta/pull/95/files#r467990
>



-- 
Cumprimentos,
Ricardo Soares
What is the difference between start/stop and begin/end?
A few doxygen comments doesn't hurt, please take these 5 minutes ;)
I agree. I was close to posting the same thing as well, but then refrained for the sake of just getting it out. Let's change it if @wisq feels as well that the wording is a bit unclear.
Why is this blank? Seems like it should either be stripped out or implemented.
You are not calling this from the ScriptLoader.
This will throw a warning (resulting in a thread crash) if $result is undef. 

See an example of SNMP error handling here: https://github.com/inverse-inc/packetfence/blob/stable/lib/pf/SNMP/H3C.pm#L116
I think this is a discussion that should be continued in its proper issue. Can you post your concerns there instead?
should be stub
This is the number of loop begins, because labels have to declared up front, so needed to figure out how many were needed.
It will stop which process? The arbiter? Circusd? I think we can be more explicit.
On the other hand, I am pretty sure that a reader who ventures in the source code of promises knows what a FIFO is (or at least knows enough to look for the definition). I don't think that the link to Wikipedia adds anything.
bash_profile actually grabs a template based on `drupalcs-alias`, so can we rename that file as well?
https://github.com/myplanetdigital/ariadne/tree/4f883ac64affceb4ad2923e164a0b8a00e7162b3/cookbooks-override/phpcs/templates/default
what does checkstyle think about the identation of the paramenter comments?
I think it would be nice if these became visible on `:hover`, so they would overlay border-left or border-right of `.zoomer-overlay`. Or maybe style border-left and -right of `.zoomer-overlay` different by default too, since those are interactive?
It leads to an annoying behavior where it jumps back and forth on mousewheeling.
Or just sub_template.shift()
do you think it's worth to be more specific on the regexp?
are this and the following functions also the same as in the slsqp version.

import and avoid code duplication, if yes.
Should this be mod2?
Notes section comes before Examples section.
The idea of ​​`listBodyToInfo` is to abstract out all that is done in all list methods. The function may not be named so good but I could not think of any better when I made ​​it.

How do it complicates thing for you?
I'm not too sure if the `sort_by` is required here.
@KL-7 @camertron Since Ruby 1.8 doesn't maintain the hash keys in the insertion order, is it better to leave it in?
Good catch.  This one is wrong -- it does wrap to [-pi,pi).
Yes.  That sounds good.  You can even mention the functions by name if you want.  Or what you wrote is fine too.
Worth putting these lines in the try-catch as well.

If an exception is thrown by the runnable in executor.submit, the exception will never be reported unless someone calls future.get().
For scheduled executors, it's a particularly bad problem because there is not future to call get on.
So to aid diagnosis of potential future bugs, it's well worth wrapping the entire run-method body in try-catch when submitting to an executor (unless definitely calling get).
locations cannot be null due to the way git-like-cli operates, as I understand it
agree it's ambiuous.  i've added a ListModification object so you say  setConfig(SOME_LIST, ListModification.addAll([1,2,3]))  ... not ideal but best i can see...
Superfluous space before question mark.
Manter o boolean pra saber se Tem ou nao Tem mapa cadastrado. olhe o diagrama de classe
Missing method docs
Please remove commented code blocks (since version control will still have them).

Or document under what circumstances they should be restored.
Perhaps clearer as:

```
# Verify expected fields exist
[user[f] for f in ['email', 'password', 'realname', 'roles']]
```
I like this way of handling the migration of alerts to a newly signed up user.
the icon is never null, i set a default one on init
Are these used? I don't see them defined?
Remove this file. git rm app/views/Messages/create_message.html
when you say there is a form that posts the data.can i only post strings or ints to the controller? how would i get these strings and ints from the checkboxes, textfields, etc. and instantiate the date object. im not sure how to set the date object within the event that gets created by the controller. for example when getting the dates from drop down menus in my code. how do i get the values of each option and set the date object within the event class without storing them in their own instance variables in the event class. i feel like i don't know how to temporarily get the data in order to create the date object without storing it first
Since it's in a static location (e.g. you don't need require() to look through the search path), you could just read() and eval() it and call it whatever you want.
It is orthographically wrong to capitalise nounds, just because they are used in a bullet list. In other words, this is orthographically correct (and has nothing to do with grammar). Stickler ass-hat response for sure ;-).
You could dry up these tests a lot by leveraging `let` and the tests would begin to be more poignant.
Это хак. На самом деле иероглифы так просто поддержать не получится, поэтому лучше просто выпилить этот код.
shouldn't we change the log to use jboss-logging ?
s/argree/agree
why don't we use self.selenium.find_element(*locator).text where we need it ?
it should be ``addParser`` to follow the conventions used in Sf2
デフォルトの動作を変更する場合は、BuildConfigで@grails.war.dependencies@プロパティにAntでインクルードするパターンのリストを設定するか、またはAntBuilder構文で記述したクロージャを設定することで、明示的にWARファイルに含めるライブラリを指定することができます。

というような意味ですね。
change method name to authorize
Looks like apt-key is in the apt package which should be there by default.  Without python-software-properties installed, apt-key is able to fetch the 10gen key...

```
vagrant@box:~$ dpkg -S /usr/bin/apt-key
apt: /usr/bin/apt-key

vagrant@box:~$ dpkg --get-selections | fgrep python-software-properties
vagrant@box:~$

vagrant@box:~$ sudo apt-key adv --keyserver keyserver.ubuntu.com --recv 7F0CEB10
Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --secret-keyring /tmp/tmp.H0TBLE6BQ8 --trustdb-name /etc/apt/trustdb.gpg --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver keyserver.ubuntu.com --recv 7F0CEB10
gpg: requesting key 7F0CEB10 from hkp server keyserver.ubuntu.com
gpg: key 7F0CEB10: public key "Richard Kreuter <richard@10gen.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
```
The first line only contains the type, the description starts in the second line (scipy convention afaik).
2012/10/26 Olivier Grisel <notifications@github.com>

> In doc/modules/preprocessing.rst:
>
> > @@ -257,6 +257,44 @@ to be used when the transformer API is not necessary.
> >    To avoid unnecessary memory copies, it is recommended to choose the CSR
> >    representation upstream.
> >
> > +
> > +Encoding Categorial Features
> > +============================
> > +Often features are not given as continuous values but categorical.
> > +For example a person could have features ``["male", "female"]``, ``["from Europe", "from US", "from Asia"]``,
> > +``["uses Firefox", "uses Chrome", "uses Safari", "uses Internet Explorer"]``.
> > +Such features can be efficiently coded as integers, i.e.
> > +``["male", "from US", "uses Internet Explorer"]`` could be expressed as ``[0, 1, 3]``.
> > +
> > +Such integer representation can not be used directly with scikit-learn estimators, as these
> > +expect continuous input, and would interpret the categories as being ordered, which is often
> > +not desired (i.e. the set of browsers was ordered arbitrily).
>
> "i.e." => "e.g." or "for instance".
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1279/files#r1950633>.
>
>

And "arbitrily" => "arbitrarily"
i wrote it for this PR .. not sure if we did .. in the sandbox we only had the multilang admin
Could you point out an example who does that different?
I suppose a better way to phrase it is should this be serial or parallel.
leftover debug code. good eye!
Call this method `contains` for readability (`include` makes it seem vaguely like the method adds the item to the array).
We are going to iterate over the list of properties anyways, so might as well pick them from a list, if one is specified.
Shouldn't throw an exception if length is too big since it's a maximum. Just use the smaller number.
Would it make any sense to put this stuff in TiObject instead or am I overgeneralizing?
Used now
These currently are read from this config file but in a future commit will have the ability to read an environment.xml file to get the correct paths for an environment. 

I do not want to have it read environment.conf as the regression suite does not have to be run from a system where the platform is installed.
PS: There isn't a single ```return 0```, so I think void would be a much better fit for this method.
I've seen very similar code to this before.  Can it be commoned up?
d'oh, just missed that. Sent a patch to do it.
Maybe call `commonjs_module?`
Do we even need this any more? Which version of Firefox does NOT support `box-shadow`?
Maybe a new 1-1-stable branch?
Yes, we have. But this refers to the sample code created by cfx init, which uses "const". Probably it should also use "var", except that there's a bug saying the cfx init should not create any sample code at all: https://bugzilla.mozilla.org/show_bug.cgi?id=616640, which I think would be better.
Since use of `browser` element is an implementation detail that can change in a future we have decided that we can keep the name as is, but have to update comment so that it does not lies about the fact that it uses iframe.
Use $path here instead of $phpSelf.
please check the redirect url too:

```
self.assertEqual('/schedule/proposal/1/how-to-learn-python', response['Location'])
```

Also, `assertEquals` is deprecated in favor of `assertEqual`.
I was thinking we might need to expand this in the future, and the FSM was the easiest way I could wrap my head around the exact logic.
This is exactly what `map` does: `(map rank ["1D" "2D" "3D" "4D" "5D"]) ;=> [1 2 3 4 5]`
Could this return self?
Also need an else to handle unexpected format request or you'll get an odd exception from line 90.
Unnecessary, ```sysinfo``` is already a method that caches the results of ```session.sys.config.sysinfo```
no () needed for no args
Yes, I think this would be useful, since 99% seems rather arbitrary.
This should be ok.  All the extra logic in convertTaiToUtc is to detect when you're inside a leap second and to fail the transformation.  But in this case, because we're actually supposed to be using UT1 and we're only using UTC as an approximation, we explicitly do not want to fail when inside the leap second.  When using UTC as an approximation of UT1, a leap second is kind of like time travel.  You do second 59-60, then you travel back in time and do that second again (the leap second) before proceeding to second 0 on the next day.  So yes, the Earth rotation snaps backwards when the leap second begins.  This is consistent with Components and (as far as I know) the best you can do without having an actual UT1, which requires EOP data.  The rest of the code (diffDays, etc.) is computing Julian centuries and doesn't really have anything to do with UTC<->TAI.
This conversation probably belongs outside of a comment on a line of code in a pull request, but here it goes anyway... 
I am often torn between fully-commenting every single function in code I produce (e.g. full php doc for each function) and on the other extreme, following @nb's philosophy that comments should only exist when they are necessary and tell you something useful. In this case, I "sided" with Nikolay and didn't think the majority of the comments in the plugin were particularly useful, so I removed them and/or clarified the code (e.g. function and/or variable names) where needed.
Has anything changed here?
It's not. As with [Line 53 of dmd/src/posix.mak](https://github.com/D-Programming-Language/dmd/blob/master/src/posix.mak#L53) it allows to call `make -f posix.mak MODEL=` to set it to empty value.
We can't enable accessors, because they do not exist on Android. Thus, I explicitly added the getLandscape and getPortrait methods (lines 10 to 20).
Inappropriate cast. The text widget type could theoretically support any kind of text widget, which is not necessarily a `UITextField` and may not even respond to `selectAll:`. Instead of performing a cast should check the view's `respondToSelector:` and dispatch appropriately.
For table rows, it is also very important that on ios, `touchcancel` is called to interrupt an ongoing touch when it causes the table to scroll.
Probando this shait! :shipit:.
Why are you repeating this instead of just calling it off the service?
Fixed, thanks for mentioning it.
It should say something like "We recommend using the Facebook C# SDK at this location" as these two projects are not the same.
The problem was, that $item->getValue() on a property with references tries to dereference that property automatically, which ended up in a unnecessary lookup of UUID-to-Path on jackrabbit. This lead to the 100% CPU issue problem, which is actually a bug in Jackrabbit

But even without that bug in jackrabbit, I think this (the dereferencing) is unnecessary and should be avoided.

I can't look into that further, so you're welcome to have a closer look.
should be http://www.dokuwiki.org/template:dokuwiki
and there should be a real repo entry to support the new extension manager (screenshot included)
lowercase (throughout)
Instead of a conditional statement, skip this iteration with next.
```
next if ignore_group?  Array(group['committers_to_ignore']), commit.grit.commiter.email
```
I don't think we need to make copies of v.
わかりにくいと思ったので一応補足しておきます：
WebWorkersとGeolocationは英語のままで、CSS3 Animationは訳してCSS3アニメーションでもよいかな、と思います。
行数重なるのを嫌いましたが、見通しが悪いのでネストするように変更します。
`static`.
I still think that ProjectChoice component seems like it is the same in two classes SendEventPage and TestClient. The only difference is the response page in onModelChanged, right? This value could be passed as parameter to an own component which is used on two different places?
Should the results from this be what is returned in this method?
Patch file is not used? So get rid of it.
This is totally inconsistent with the way Symfony names its methods. You should have ``addExposedClass($className)`` accepting a class name and adding it, and eventually ``setExposedClasses(array $classNames)`` replacing the whole array
actually at the moment this isn't saved at all, so it has no effect
with a selector ~~per~~ for each sent message
Within backticks, you don't need to escape backslashes.
regarding using  the ".eql?" method call over the "=="...I am not sure why I did that. is there a rule of when we should use one over the other one?

thanks for your feedback.
-j
@jburel, do you also want to update omero_database in this patch?
Yeah, but you are essentially checking if the start character and end character is @ for the given word, right? So, I thought that would be a simpler way to do it.
@christianv Can you re-word this sentence?
The matter is, the `getClass` function is use for other purposes (like menu generation if I remember well). Changing the behavior of this function will lead to too much refactoring IMO.
But I think it is not possible to check with instanceof :) Because method setPropertyPath() just was removed at https://github.com/symfony/symfony/commit/a30a6791356099513fbda27ecd8a0c6ec5fc984f#diff-6 without any another changes related to interfaces.
Dave: change to "It is recommended that you upload a file or link to an external location as this object is intended to reference a file."
@comfortablynumb this seems unused
Accept :-)
Can't you just write it as "return [[self loginView] toolbarPosition];"? If loginView is nil, then nil will propagate itself
No… it should not be.

The appendix should be left alone so that downstream people “know how to apply it”. It’s kind of weak… but it’s a best practice.

The copyright should just be in the notice, and the source files. ( Which looked fine imho )

RW

From: Jason Scott [mailto:notifications@github.com]
Sent: Wednesday, October 10, 2012 3:03 PM
To: blackberry/jQueryMobile-BB10-Theme
Cc: Richard Wallace
Subject: Re: [jQueryMobile-BB10-Theme] Update to the license file (#13)


In LICENSE:

> +      of your accepting any such warranty or additional liability.

> +

> +   END OF TERMS AND CONDITIONS

> +

> +   APPENDIX: How to apply the Apache License to your work.

> +

> +      To apply the Apache License to your work, attach the following

> +      boilerplate notice, with the fields enclosed by brackets "[]"

> +      replaced with your own identifying information. (Don't include

> +      the brackets!)  The text should be enclosed in the appropriate

> +      comment syntax for the file format. We also recommend that a

> +      file or class name and description of purpose be included on the

> +      same "printed page" as the copyright notice for easier

> +      identification within third-party archives.

> +

> +   Copyright [yyyy] [name of copyright owner]

Should this be Copyright 2012 Research In Motion Limited.?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry/jQueryMobile-BB10-Theme/pull/13/files#r1810508>.


---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Yeah, we can probably stick with how things are for now.
"cleints" should be "clients"
> its children only if there were any layout changes
Could be written as `elif command == 'install' or command == 'adhoc'` with target/deploytype settings set on a per-command basis to reduce C&P code
NOT a fan of this. ``cmp`` is deprecated in Python to my knowledge.
т. е. вынести в свойство функции Event
function Event (start, end, location, id)  {
    .............
    Event.dateValidator(..);
    .............
}
Event.dateValidator = new function (...) {....};
This line should be the last line of the initialize function
I'm worried people may try and use this when they don't know what they're doing. Can we add some more detail to the description to at least show it's optional and for pre-generated bar descriptor files only. Maybe something like `Optionally specifies the path to a pre-generated bar descriptor file (bar-descriptor.xml).`
I removed it because an easier approach is now used for the two instances to run on one node - port-offset. How to se port offset is described in indinidual examples' readme files.
Why not pass the ext in here as opposed to a global incremental tracker. Seems more logical.
Is all that has been changed was "overflow"auto"? I can take a look to see if it's needed, I don't recall the specifics.
If the method is only in the header, it should be commented in the header.
Isn't "changelog" consecrated enough to deserve its own word?
What are you thoughts about switching back to the current OBA version numbers?  Does that conflict with any of your existing releases?  Have any of those release artifacts been put in any public repos?

In the same vein, do you think you're going to need to continue to make versioned releases independent of the main codebase?  We can definitely talk about giving you release privileges on the main codebase, especially once we've got things in sync, if that will help.  If you do need to make versioned releases independent of the main codebase, I'd probably talk about how we can do that without causing release conflicts.