labofsahil/github-event-dataset-2012 huggingface dataset:
I didn't realize that... that's really annoying and possibly a deal-breaker (e.g. may imply a different solution to this problem is preferable)...
I know there was already some discussion elsewhere on documentation, but I didn't get fully caught up with it.  So should these contextmanagers maybe have docstrings?  I know they're more just for developers, and their use is fairly obvious, but just a short description would probably be good.  Same goes I guess for a few other methods in here.
It's function should propagate the isUpdate value to all internal rules
The var `$parentField` contains the parent field name so using the string 'parent_id' was redundant / incorrect.
I don't understand the comment for `floor_validation_pattern`. What does `floor_validation_pattern` have to do with security?
`Default is 100.`
Because it makes it clearer which of the parts had an error in it. The diffing algorithm that nosetests uses gets overloaded with big dictionaries, and you have to change settings or add print statements to figure out what the problem is.
I think this should be `self()` instead of `unicode(self)`, so that the format specification can be applied to the returned object, not its string form.
Probably not necessary to make this a function just to call it once.

```python
for fname in filenames:
    open(os.path.join(td, fname), 'w').close()
```
return the image behind the template, wdyt?
Why added newlines at the end?
If the old branch name contains regular expression characters, this could cause a problem, I think, when you use the pattern in `git_config_foreach_match` below.  You may need something like:

```c
    git_buf_sets(&pattern, "branch\\.");
    git_buf_puts_escape_regex(&pattern,  old_branch_name);
    git_buf_puts(&pattern, "\\.*");
    if (git_buf_oom(&pattern))
        goto cleanup;
```

The regex escaping was added to deal with just this type of situation.
another URL that shouldn't be hardcoded. If this is not in bedrock yet, use ``php_url()``.
This one's up to you, but I prefer to use the attrs dict to add things like maxlength, required, and placeholder and then output the form with:

```jinja
{{ sms_form.number.label_tag(_('Enter your 10-digit phone number')) }}
{{ sms_form.number }}
```
We should pass something like `active='forums'` and make the "Contributor Forums" link active.
Note that, if you wanted that to be a tuple, you'd have to say use (ALL,). Otherwise the parentheses are essentially just stripped out and it's a single value.
This is not up-to-date! :)
That's what I mean: the queue name can be mapped in advance.
Empty line to be removed
s/helper/filter/ ?
I don't know the logic behind this code, but shouldn't we just write the sound samples to the output file, when we actually called callbackHandler(...)? This looks like it will duplicate the current sample buffer multiple times. So it would be nice if you could explain the logic behind this.
So, is it ready to be merged? or do you need more time to investigate the above questions?
This should be removed. We reuse the same kernel for all requests.
typo here: ``a``
That's why I changed it to buildViewBottomUp, where the children are already there.
you should use ``defined('PHP_WINDOWS_VERSION_BUILD')`` to detect windows
I'm wondering what to do for this. I can't find a way to determine if a sub pattern matched or not. Assigning the parameter's value here would break default values (non matched params would be assigned an empty string). Any idea ?
did you mean to pass in the $name argument to this method as well?

and would there be a problem if we make getAttributes explicitly expect exactly two arrays?
Why the isSilent here ?
Faux => not real. MockFile will be better? Maybe MockSplFileInfo?
> I fully agreed with you, but GitHub doesn't leave me a choice(I'll try to add OAuth auth later) but for now it's only one way to use sympy-bot without annoying asking of password :-(

It is a pain right now. Do not dedicate too much time to this. What
you have done is already of great value; we can think about security
later (after all this is just a build-bot).
There indeed was a mix of different quoting styles without much motivation, like in lines 272 and 273, where first single quotes and the double quotes are used, and it's never bad to fix such problems.  However, you absolutely right in that such changes do not belong to this pull request.
you no longer need the `ua_family` and `os_family` arguments.
Yeah, thought about subclassing UIButton and doing this in drawRect but I'm guessing this is the only place we really need to use this so I think it's okay for now.
Curious what's private and public in this file, and whether we want to audit it in a separate commit.
@JosephPeng 恩，说实话，我还没想好怎么处理
不过暂时我想应该先把这个pull request搞定，然后再解决 #77 那个问题
这个pull request 目前阻碍了其他进程
而且我不确定这中注释风格好不好，要是你觉得需要大改，也尽管说
Start/stop/restart should all have consistent names (that is to say, use `start` instead of `init`). Also use symmetric privacy levels .. why is init private, but everything else is public?
Ok, I will add static constructors.
Should throw javax.persistence.PersistenceException
Yeah, unfortunately, I found this issue in the real world when somebody accidentally saved an OpenEXR with the .tif extension (or maybe it was the other way around), and I wasted a lot of time trying to figure out why none of the oiio tools would open the file.
`} catch ( err ) {`
yea helps for opening files etc
right, it's easier. I had 'blackout', forgotten about that : )
You'd probably use hash - providers ids {'facebook' => 'facebook_uid', 'github' => 'github_uid'}. Currently it's not a big deal :)
spurious comma
Hey garry,

I would not merge that one. 
I am not sure why there is a diff with that file but I didnt touch windows.cpp anyways
Also, I think the changes in texture class may be discarded too.

- Mario..
Yeah that's cool! I'll add a patch to the pull request adding that.
This is wrong for several reasons.

* We cannot use `.on()` since we support older versions of jQuery.
* This would need to support all uses of helpers, not just clones.
* We shouldn't bind to remove, we should handle this in `_destroy`.
* This happens on every drag start and is never cleaned up.
Seems to work without problems. Changed.
я не понимаю, чем тебе не нравится. получается внутри Topic-а хранится заранее правильный Section, а ни какой-то не виртуальный sectionId, который может вообще не существовать.
просьба этот второй индекс убрать
can you remove the space behind the `!` and put each statement within the if block on its own line? Closing curlies also belong on their own line.
Should get the newest paired device list here.
Do not add extra whitespaces before the rule and add a line break between the 2 rules.
It is an order: "to map the type".
Why is this done whenever the homescreen starts?
Resolved - this is now removed.
Sounds like a crash.  File a bug?
Move this line on top of this function since you reference it above.
@gtorodelvalle Here should be your code taking into account https://wiki.mozilla.org/images/2/29/HTML5_Dialer_Contacts_20120810_R2S1_V6.0.pdf  ;)
The timeout tests wait until the spout receives the appropriate number of acks or fails, so it's not actually time-dependent.

Yes, with semaphore implementation, if the test is wrong or there's a bug it should hang, which is fine.

Your second proposal is a lot tricker than it seems. It's doable in theory, and in fact tracked topologies implements a bunch of this. We would have to add inter-task queue checking in order to accomplish this. I think the first approach will be much easier for you than trying to iron out every last detail of the second proposal.
For the quick start page I mention possibly showing the URL after the sync section. Seeing it here makes me like that idea more, this looks good.
Rename module to `SetXHRCurrentLocation`.
Yes it should. I'll correct.
when saved as a webclip on an iPhone 5, width=device-width leads to a letterboxing effect
This scans through the module abstract code twice. Once for get_source and once for get_line. better to just get the info once and get both source and line from it.
I like yajl, and it provides a fast symbolize_keys option.
I would recommend adding:

https://github.com/echen/algebird/blob/b50b08b1aaeeb4252794038af545e3b390eab6c2/src/main/scala/com/twitter/algebird/CountMinSketch.scala#L58

something like:
```scala
object CMS {
  def monoid(eps: Double, delta: Double, seed:Int): Monoid[CMS]
  def monoid(depth: Int, width: Int, seed: Int): Monoid[CMS]
}
```
Then you can use CMS.monoid(eps = 0.01, delta = 0.1, seed=1) or the other one.
No leaving crap behind!
Skipping documenting this
As far as I understand, the event propagation stops only when the map is focused, and user shouldn't expect the keyboard input to influence other controls other than map when so (in special cases, you can disable/enable the keyboard handler manually). So I think it doesn't have any harmful side effects.
Remove as field-hierarchy will re-calcualte the values.
What does r_op and r_cl stand for? Needs a comment.
:)

```
do {
    $groups = $form->getConfig()->getOption('validation_groups');

    if (null !== $groups) {
        if (is_callable($groups)) {
            $groups = call_user_func($groups, $form);
        }

        return (array) $groups;
    }

    $form = $form->getParent();
} while (null !== $form)

return array(Constraint::DEFAULT_GROUP);
```
I don't like this being condensed that much. Less easier to read IMO. What about

```
while (null !== $form) {
    $groups = $form->getConfig()->getOption('validation_groups');

    if (is_callable($groups)) {
        $groups = call_user_func($groups, $form);
    }

    if (null !== $groups) {
        return (array) $groups;
    }

    $form = $form->getParent();
}

return array(Constraint::DEFAULT_GROUP);
```
Chai doesn’t work in IE8 at all, it’s made for IE9+: http://chaijs.com/guide/installation/#browser
Only parts of it are supported by IE9 (okay, we’re not using the `should` syntax).
I don’t like that. I don’t want to drop IE8 support just to be able to write `to.not.have.been.called` instead of `not.toHaveBeenCalled()`. Also we just need the compat in our apps, IE8 is the most important IE version, so I’d like to continue writing tests for IE8. I recently spend much time on IE8 compat.
this line not needed any more
Is there any circumstance where this list could be empty? I suppose not, but it's worth checking.
It seems like the version number on the master branch has been messed up. It should currently be 0.4.2
Also we should stick to following export pattern:

```js
function foo() {
  // ...
}
exports.foo = foo;
```
again, this function is not yet in use, in prep for issue #730
Should a default background be set here for IE?
I'm wondering if `PROJECT` should be an instance attribute instead of a class attribute, it seems like it should belong to the object instance.  We will likely have different pushlog projects, especially in the case of b2g.  Making it a class variable will result in every object instance's PROJECT value being the same, this will be a problem when working with more than one project.
Ok, so we can revise that code later. Leave it as it is. Thanks for the clarification.
Do we really need all that code? Isn't the reverted value immediately visible in the addon settings? I don't think that we should come up with a modal dialog here. Simply resetting the pref to the last value if changes happen in about:config sounds totally fine for me, and there you can see that we revert the path directlly.

Also how do we react on startup if the dir is invalid? Currently we should fail because that's not handled.
That mirrors my observed behaviour on Win2K3r2, which is annoying.  I would love your opinion on the best way to address that.  I don't hate the idea of temporarily taking control of the target file to allow writes, if we can turn that back to what it was later.

Alternately, we can just fall through to `MoveFileEx` which is more robust, but preserves less state.
looks more general than an edge shard reader? should the package change?
Not sure if you are asking about the destination or the bare: true.

Do you want the destination be app/scripts? 

I have bare: true because that is what matches the old coffee task's output.
This not need to be imported
Should be `// CraftBukkit end`
btw, you should probably switch the Zend packages to their official composer repository (but it should be a separate PR)
It also doesn't make sense to move it outside the if statement, because that would introduce a race condition where the indexing service could do its update BEFORE changes have been committed. :-(
Use braces.

`if (!title) return;` ->

```
if ( !title ) {
    return;
}
```
> based on this assumption, i suggest to remove ie.js...

Still, it can't hurt to include it. This will make sure developers don't need to think about oldIE.

From app spec:

> There's a ie.js file in the assets folder which contains html5shim, es5-shim, classList.js, outerHTML to let you to develop without having to think about legacy browsers.
I think it would be better to keep this in your local .git/info/exclude
Also, with this approach, configuration (for debugkit panel):
'clear_cache' => array(
'engines' => array(),
'groups' => ('comment')
)
disallows clear engines (both all of them and one by another separately) from DebugKit, and allows to clear cache group 'comment'
Nice catch @nvt! The RTL8019 driver isn't used anyway, so I submitted a pull request that removes it completely. https://github.com/contiki-os/contiki/pull/11
Since validation has been moved to tools, this shouldn't be needed anymore here, plus it is a check that only worked on XML/YAML/PHP drivers.
@beberlei yeah, but then we're adding this call everywhere (instead of just where the API states `@param mixed $id`). Nvm, guess it's an acceptable overhead.
But, what you actually want to do here is to call String.split_words inside the quote.
Also, in testVisit method, $trashItem needs to RestTrashItem now.
getting TypeError since current_task is None sometimes
Just a question. Should we add this to all our docstrings? Jens once commented that this information already resides in the header.
No, there always were two files, where ldap_utils provided lower level functionality. Do you want them merged? I do not have any qualms with that, I just never did it, as I assumed it was designed that way :)
this one should be defined before the protected methods
Wieso schickt ihr hier die userEmail mit? Macht es nicht eher Sinn das der Server die abfragt? Es muß ja sowieso sicher gestellt werden das sie korrekt ist.
I've been thinking that as well as I investigate. There's essentially no observable difference between `Object.create(Object.create(null))` and `Object.create(null)` if you keep the main one safe from taint.
Maybe there's a way to do those changes in a batch?
I didn't add this, i just moved the file.
No - when you run the `collectstatic` command django collects it all and puts it in your `STATIC_ROOT``. This includes admin stuff. Django then looks for your admin media at `<STATIC_URL>/admin`. So as long as our other static files are served fine, we're good to go.
this is superfluous now.
negative one should be one that returns no results.
`var keys = ...`
This will crash the entire service and container ... use `validate_true` or `validate_false`
deveria ser ``return self.xmlschema.validate(parsed_xml)``
shouldn't this example require a list of unless clauses? Or recursive application of the function itself? (this kind of uses are why I wrote mine)
all of the attr_* params are required if onthefly_register is true (which suppose to be boolean afair)
ouch: why allocate an object in a default argument?
you are right, obviously. I removed the variable `width` and the unnecessary assignment. thx!
it could be a problem when not defined
cs issue (indent/align)
We need to add a check to make sure we're not updating a computed column.
you know, i don't really have an explanation for it, i just copied it out of @zacc 's WebDriverWait tutorial and changed the criteria.
I think that the new lines 108-111 should be removed... 
</widget>
</item>
</widget>
</item>

I guess I copy-pasted them again by mistake.
Depends. Can you guarantee that, during creation from QML, path will always be set before any other getter is called? If it's explicitly specified during construction, that *MAY* work (though I'd still worry about other bindings), and if you set it at any other time it won't work at all.

For that matter, are there any setters that would require path to be set first? I don't think you can guarantee order.
Also refactor this into `Gandalf.Collections.Events`
Given that now people can specify times more granularly, does it make sense to still report the threshold in days? Can we pretty-print the time interval somehow, or maybe just show them hours? Would be weird to see something like "0.0342 day threshold"
Done in 365dc33
can you make this addDownloadLink? It's a bit confusing given that we already have links as a content type.
This is not in line with what we agreed during the Cambridge meeting. I think it would be really confusing if widget developers would have to code all of their widget URLs to /widget/, whilst their widget would be living elsewhere on the filesystem. During the meeting, we said that having people use node_modules in their paths would be an acceptable trade-off for the ease of installing widgets.
As an aside, when introducing the DAO, all gets / updates would be going through that DAO (including the calls to save URIs onto the principals), in which case the caching updates and invalidation should be able to be stuffed in there.
I think so. I left these console logs and the ones inside the performance tests, because they provide status information for when running the performance tests from the console. It is helpful to not have this info mixed in with the app logs.
This shouldn't work now that we're using Helenus..
I checked and since the `astRoot` we pass is always null, the super call doesn't do anything anyway.
已经有一个 `validateReturn`, 不再需要这个
or we could forget about that and just say we have one method finalMatch(RouteCollection , Request)

i don't really like the setCollection and then matchRequest process. too much state.
Changed to `<Leader>` in follow-up commit, thanks.
Please add Interbase/ Firebird. I would have, had I noticed this file existed at the time :-/
No idea if this is accurate. ;)
Какое число мы получим в changesCount?
Гарантии на рандом никто не может дать, на то он и рандом. Но если провести тест и указать size =100 и upperBound 100, то массив заполниться за доли милисекнуд.
да - ARC выключен
It would be good to do error checking here.
This method can be rewritten as:

```
private static function getFieldTree($field) 
{
    return array_reduce(
        array_reverse(explode('/', $field)),
        function ($result, $value) { return array($value => $result); },
        true
    );
}
```
... but did you bundle install?
These flags don't look quite right.  The docs say OFN_FILEMUSTEXIST cannot be used with a Save As dialog.  Not sure if OFN_PATHMUSTEXIST is right either -- does it simply prevent entering files whose containing folder(s) don't exist, or does it block any nonexistent filename too?

It also seems like OFN_OVERWRITEPROMPT should be set (unless it's on by default for Save As, but the docs don't say that).
I don't really know anything about that... I just removed the proxy part since identifier fields are not lazy loaded ;)
Don't we use the phpDoc2 syntax? It should be `\ReflectionProperty<object>`, no?
Favourite -> Favorite for consistency
I'm extremely surprised that this doesn't crash on `nil`. I don't think we should depend upon it.
Hadde det vært mer logisk følge om if-meldingen lå rundt `render partial:` i `_form.html.erb` i stedet?
Is there something crazy going on with indentation here?
?


On Thu, Dec 6, 2012 at 4:24 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> def copy(self):
>
>      raw = self.raw.copy()
>      del self.raw
>      new = deepcopy(self)
>      new.raw = raw
>
>
>
>
>
> On Thu, Dec 6, 2012 at 4:22 PM, Alexandre Gramfort <
> notifications@github.com> wrote:
>
>> In mne/epochs.py:
>>
>> > @@ -463,19 +493,30 @@ def __repr__(self):
>> >      def __getitem__(self, key):
>> >          """Return an Epochs object with a subset of epochs
>> >          """
>> > -        if not self._bad_dropped:
>> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
>> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
>> > -
>> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
>> > -        epochs.events = np.atleast_2d(self.events[key])
>> > +        epochs = self.copy()
>>
>> I am always afraid that copy does not do the job. I would hack it with a
>> deepcopy after removing the raw attribute...
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335953>.
>>
>>
>
>
Should probably beef up the disclaimer, something like "Note: data are not filtered here, thus you must ensure that they are sufficiently low-passed to avoid aliasing artifacts". I think the extra lines are worth it.
In my tests, it sped up the compute_proj_raw function by a factor of 2, which is worthwhile IMO. Once we implement computing projectors across multiple raw files (as opposed to individually), it should yield at least some performance gains in those, as well. There are probably other places to also speed it up---I think a big one has to do with the epoching currently---but I figured every little bit (or 2x speedup) helps!

1/ I have no problem with not branching---will the code still work on Windows if we don't?

2/ Right, I think splitting the epochs could get hairy.
I know that's why asked :)

I'll do it tomorrow if nobody does it before.

thanks heaps for this new cool feature !
aldo?
Actually we don't loose history, because we preserve it on new DataExportTest. Maybe, it's ok.
As far as I know, even if pipe is done before the onEnd call, the onEnd will get called.
Looks like AR [defaults to 64](http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/DatabaseLimits.html#method-i-index_name_length) and [63 for postgres](http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/PostgreSQLAdapter.html#method-i-index_name_length).
Like my previous comment, I don't understand the problem with this.. I have take this part of code inside a Sensio or a FOS Bundle I don't remember.
Is it an option to at this rule to the Coding Standards @fabpot ? I can't find this rule.
@richardmiller it isn't correct now, you forget the opening bracket (or am I missing someting?)
Exponentiating (spelling)
getPriceDisplayMethod() doesn't return a boolean. It can't be used like this in a test.
from line 122 to 128 it's duplicate condition. on line 106 you have exactly the same condition and the same code in the if.
for me you can replace from line 106 to 128 bu this :
```php
if (!$curProduct->active || !$curProduct->isAssociatedToShop() || !Validate::isLoadedObject($curProduct))
{
	unset($ids[$k]);
	if (isset($this->context->cookie->id_compare))
		CompareProduct::removeCompareProduct($this->context->cookie->id_compare, $id);
		continue;
	}
```
```with-client``` calls ```setup-client``` for you.  You should remove this line.
You will miss the case when the filename end with e.g. "1.Q25.fastq.gz". I would do something like:
s = read.split(".")
if len(s) >= 2 and "fastq" in s[-2:]:
  if s[0] == "1": 
    read1forsample[tag]=fname
  elif s[0] == "2":
    read2forsample[tag]=fname
That too was copied pasted from the ViColonInput command
Why is it commented ?
Can you please change this back to string interpolation?
Its from time travel camp next weekend.
Misspelled "defined".
Should we remove the "target" key from params since it's treated differently?
Ask Carlo Wolf, lead of the project, to do a release :)
The version is defined in plugin management section of parent so no need to repeat it here.
The `null` special case was needed before because we needed to start the cache outside of this method. It's not needed any more, now that wireCache also starts the cache.
Agreed, I'll change that
graterd is actually defunct now, it's just a config file against hekad. We should probably include a sample config file for folks to use to get started. Also, after the install, you can run the code using "$GOPATH/bin/graterd" (or, now, "$GOPATH/bin/hekad") instead of needing to use "go run".
Same here, two `yield`s
Should there be a path / separate test for if no networks are found?
this now doesn't match the teardown so the app is not killed in the teardown.
The writer is now set the same way in two different test harnesses. Can we push it up into the base class?
Если хочется их вынести, то тут оставить
```php
<?php5
const WRONG = BasePrimitive::WRONG;
const MISSING = BasePrimitive::MISSING;
I was wondering about that, too. I'm not that much into Chef yet, to know, what is an established practice in this regard, but I wondered why anyone would use the yum cookbook without also managing the yum.conf (and thus potentially running a configuration, that's not working well with the LWRPs shipped with the cookbook). The yum.conf as generated with the template using default attributes also is identical to the distro default (I only verified that with Scientific Linux 6.2).
Thanks for clarifications -- I'll remove the empty lines you referred to.
"set -eu" is Bash-specific, it does not work with Dash - the default shell on my Ubuntu 12.04
Probably a stylistic thing, but you don't need the ``then`` here.
@gsilver can we use single quotes on this line + spread it across multiple lines.
These exact same checks are performed above at lines 338-360. We shouldn't need them twice. Is it possible to reach this code if any of these strings is null or blank?

As an aside, these checks should use `org.apache.commons.lang.StringUtils.isEmpty` It performs the exact same test, but it's cleaner.
No arquivo anterior a estrutura do feed estava estática, o que deixava a sua criação mais engessada além de ter sido implementado com apenas alguns campos.

O Design OO foi utilizado apenas para separar o que era especifico do render mesmo.

Talvez seja mais interessante fazer dois renders um para aquisition e outro para navigation assim ja eliminaria o caso do content type e ficaria mais enxuto, o que acha?
Todo: add german translations
Yeah your right (so damn good) I'm not sure why I was seeing these lines, might have been effected by something else. Removed it.
Note that these items have been removed because they're no longer relevant - they're doing an incomplete job of something that is now covered by `DataList::filter()`.  SQLQuery is now All SQL Fragments, All The Time. ;-)
I reworked this a bit to use the asset pipeline and not include the js inline here
It looks like this can fail silently, should we have a call to __wt_err() here so we know what happened?
This assignment to "ret" is potentially overwriting the value saved to ret by the call to WT_TRET at line 199 -- not sure it matters, or what the solution is, but this pattern doesn't make sense.
It's easier to understand if you insert the content of your _getCategorizedProductIds() method directly and don't name your variable $startProducts because it's the start number of the categories, not products.
reverted the empty line back
It must exist at least in the IDE, no? How else do they do refactorings? @gavinking?
but it may be useful for the support of other backends, no ? Failing with Windows Azure Table is a reason to implement the new one, but it is enough to remove the old one ?
`BaseCheck#has_immediate_model?` will return model attributes, too. I think line 66 already checks for what you want (could be wrong).

On a different note, why is it checking all the args? The only arg to `redirect_to` that matters is the first one, right? Maybe this can be simplified...
Why is foo returning x *x? I think it should return (x *x) - x.
would that not be simply `function isPublished();`?

and afaik coding convention is to have interface methods without access qualifier as they are inherently public.
Unnecessary space near the end.
*Tvoje*
I know how are we getting settings variable in:
`{{ foo }}`

I know it's now `{{ piplmesh.views.frontend.HOME_CHANNEL_ID }}`. Help! This is only making me look stupid :/
Change to not user dict.
Use jQuery everywhere.
Put `else` and `else if` on its own line.
David, I wanted to make bounds an optional variable. So in the case that bounds is not provided, num_entries is going to be None and so we cannot have an if statement checking whether num_entries is going to be too large and so on. Therefore, to work around this, I have check to see if num_entries_to_read is not None, and then if it is indeed there (which means a bound has been provided), using only one line, I slice the ArrayIterator with the stop_index as the minimum operator applied on the size of the dataset and the num_entries_to_read. So whichever is smaller gets taken as the stop_index of the slice. 

This way, I can write everything in just two lines and there arent too many extra if statements. I think it is useful to keep the option of not providing a bound size because maybe the user wont know what the bound size of interest would be apriori, and so would like to have all the data for the particular variable.
Is this the correct behavior? What would happen if instead of throwing the algorithm would clear its state and start all over again?
Makes sense.

I have but it seems I forgot to include it in this request. Good thing I didn't anyway because I changed the fields slightly since time was a bit superfluous.
2012/11/28 csware <notifications@github.com>

> In src/Resources/TortoiseProcENG.rc:
>
> > @@ -747,11 +747,13 @@ BEGIN
> >      PUSHBUTTON      "Clear",IDC_RESIZABLEHISTCLEAR,243,93,50,14
> >      LTEXT           "Authentication data",IDC_AUTHHISTORY,7,120,226,8
> >      PUSHBUTTON      "Clear",IDC_AUTHHISTCLEAR,243,118,50,14
> > -    GROUPBOX        "Action log",IDC_STATIC,7,148,286,62
>
> The user actively clicks the button. We should ask the user if he wants to
> continue and warn him that this action should only be used if no other TGit
> application is running.
>
User may use other tools, like beyond compare.

> For deletion of files on startup: Files are only deleted if those are
> older than one day - if we cannot delete a file (or another tool just
> deleted a file), ignore it.
>
Older file may acceptable.
Actually, I think it leave it finial user to choose it.

>
>
 —
> Reply to this email directly or view it on GitHub<https://github.com/TortoiseGit/TortoiseGit/pull/2/files#r2246976>.
>
>
To make it funnier, he added that spell to an enum.
Ohnais!
Muss man da kein .notifyDataSetChanged() aufrufen?
Same thoughts as above about the `query` concept.
from config.pm
I don't see anything useful in the changes to this file.
Raghu's making a change so this is no longer necessary. We can update after that patch goes in and use the regular mavenized version.
s/wibi/kiji/
I don't think it is entirely true. The class DefaultPrettyPrinter has the notion of indentation. You should check it out
Is the whitespace before `js-script-select` intended?
Do we need to do this?  Right now we signal that we're done with the request by sending 'F' (finished) instead of 'D' (data) but could we just close the pipe to indicate that we're done?
Good point. Given that, I prefer calling them request options. Maybe we should file a TODO somewhere to rename ```GetQueryOptions```.
Comments should be removed
Probably some more points:
- Could you please add license header to these files with your name?
- We probably do not have any coding conventions yet but I started doing comments with First letter uppercase and ending them with a dot. Would you be so kind do it also this way? Thanks

```# This is my comment convention.```
does summary work here or not yet.
Does this extend() do anything? Rename "scope" to "callbackScope" and be done with it.
example.com pls.
Thank you.  Fixed.
Much better (I had making the draw the correct size for the test on a mental to-do myself), thank you!
Just put braces around the contents of the case:
```
case HALF_LIGHT_RADIUS: {
        MoffatFlux mf(beta);
        double fluxFactor = mf(maxRrD);
        Solve<MoffatFlux> s(mf, 0.1, 2.);
        mf.setTarget(0.5*fluxFactor);
        double rerD = s.root();
        rD = size / rerD;
    } 
    break;
```
Ah yes, my apologies you're right. 

On 19 Jun 2012, at 16:24, Mike Jarvis wrote:

>>          */
>>         bool _useRejectionMethod;
>> -        double _maxAbsDensity; ///< Maximum absolute flux density in the interval (assumed to be at an endpoint)
>> +
>> +        /// Maximum absolute flux density in the interval (assumed to be at an endpoint)
>> +        double _maxAbsDensity; 
> 
> It shouldn't.  The triple / should still mark it as a doxygen comment.  It was just too long for 100 chars when put to the right of the variable, so I moved it above.  I think that's equivalent markup though.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/194/files#r1014405

--
Barnaby Rowe

Jet Propulsion Laboratory
California Institute of Technology
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom
Perhaps use:
    return ImmutableList.builder()
            .addAll(header.lines)
            .addAll(body.lines)
            .addAll(footer.lines)
            .build();
does this filter have to be added _before_ the rest api is added ?  (rest is also implemented as a filter.  i worry if it is first security might apply only to the gui.)

also being anal, we should add the filter before we start the web server.
Fair enough - next time I have a reasonably standalone project I'll try out `yes`/`no` and see how it feels in use.
The input to updateParam (name) will always be an Array, actually.  I duplicated some of your code in the validate function so that all fields are represented as arrays.

This code could be further generalized, but I figured it would sacrifice readability.
honnetement le "I believe that the best" est moyen venant de quelqu'un comme nous. On n'y connait pas grand chose a la distribution du contenu. J'aime pas du tout cette phrase
Good idea. Will do so.
Este metodo nao pode e nao consegue rs retornar um ```List<Voo>``` pq a busca é por ID e ID's sao unicos correto, logo o retorno é um Voo
That was definitely not on purpose. Sorry for that, I reverted it.
Will this be backwards compatible or does it mean that views using this have to be updated when upgrading to 0.5? Wouldn't it be better to get the basket from ``self.request`` to keep the signature unchanged? Or at list provide ``basket=None`` and look it up from the request if not provided?
Out of curiosity, why are they sorted by the names of the listeners?
Readd the spawn(0)
It's better to just remove code outright, than to leave in commented out code.
It says so in the comment at top of the file and i didn't get it to work when doing the discoveryf4 ports so i assumed it to be broken. So is DMA broken or is the comment broken?
Space before the brace!!!!!
Пробел до (
readLine() может вернуть null (когда в консоли жмёшь Ctrl + D). Это корректное завершение приложение.
Looks like it.  I'll clean it up.
It's not actually software, until there is a Makefile :)
i can't imagine how it could have the file at the expected location if i py.test is running on a mac and the browser is on windows.
this smells like a false pass to me (probably the submit_app you've quoted too), but i have no idea how to prove it.
We already have the screenshot data in our mock object when call submit, so can we not also add screenshots at the same time?
no article for MDS I would guess.
I still don't understand.  Here we have
```
class_count = np.bincount(self._y)
```
and in `base.py` we have
```
self.class_prior_ = np.float(np.bincount(self._y)) / len(self._y)
```
The subsequent normalization means that this operation will never have any effect as the code is currently written.  If we add an option which allows the user to set an arbitrary class prior, though, I think this is the correct form.
It depends on your use case.

When n_samples <<< n_population, then the python core version is faster.
However (time) performance drop considerably when  n_samples  ~  n_population.
Memory can reach O(n_population) on bad tries.

The reservoir sampling algorithm is more constant in  term of time and space complexity.

I would say that the reservoir sampling version is safer in term of performance.
I will make a benchmark to state the difference between both.
should be `source-ip`
Since you repeat the code, you should probably refactor this part
could we just use pydicom here instead?
What are the changes to this file for?
Extending `ArrayAdapter` will save you from implementing a few of these methods.
Fixed in commit 0d5f85499511773f51
Most of the time, the type is redundant. Consistency in this case is irrelevant, since the tree output will never be parsed.

The idea of dumping a tree is to quickly and easily examine the contents of the expression, even if that means that some of the information will be missing or simplified, if that means an easier visualization of the data.

I'm aiming for ease of use, not completeness of the information. This comment works out for most other comments you made before, too.
Should this be ,stopping instead of ,true?
deliberately not, released in deconstructor.
wouldn't it make sense to maintain a list of passed standards separately of this FAQ and then link to it from here?
It would be great to have such generic class, but I think that the goal of my task is not implementing it. I guess we need this class for rackspace only, because OpenStack right now uses RightCloudAPI and it's possible that the problem of extra auth requests is already solved for open stack. So, I don't think that we need to extract it somewhere or make it generic.
s/put set/set up/ ?
gimme_minute() has no reason to be in the FUNCS array, moreover it would cause problems when a 4th language is implemented.
Ah, because I changed it somewhere else. Silly me.
This method makes me a little bit nervous since it can return a User instance that's not actually backed by the database and therefore doesn't "really" exist. Is such a phantom User ever created and used?
I'll change it anyways for future sake. Do you think this solution is acceptable for the meantime?
please fix spelling
This breaks for older release since it is actually a version String like 20.0.1. I will fix it and push a fix out.
files moved to assets pipeline
Maybe use

``` Objective-C
#if __has_feature(objc_arc)
  ...
#endif
```

I'll have to look up the syntax for reversing the logic there.
Has this anything to do with the powershell stuff or is it a fix for a seperate issue? :)
If you want a warning, it's no longer print_status, there's print_warning
Agreed, have added the above lines at the top of the file.
Oh, dear, my brain is more tired after this conference than I imagined.  My thought was that we simply pass this function through to warp as the coord_map... Hrm, we don't.  Why not... I guess I should go back and read the entire file.
I don't quite follow: can this be combined with the previous check as an `if ... or ...` block?

Also, could the check be replaced with `hasattr`? I guess it's less specific (since `fname` could have a `write` attribute instead of write method, but I don't know if that's common.
This should say "array" instead of "range".
I see, yes, that is better.  Updated.
If this is because of the color space issue, see #350 and we could potentially add pixel tests here.  If it has more to do with WebGL implementation inconsistency, then obviously there's nothing we can do.  It's up to you.
`maxActiveTasks` should be `maximumActiveTasks`, right?
No sense setting this._modalDimmer if it's not used.
Agreed. If you want we can always use this until I can get a PR merged for the change in upstream AS 7. Then just make the change then.
Замени все `document.*` на функции jQuery
Just one blank line.
Maybe call `getattr(default_value, 'id', None)` to be safe.
I don't think we should throw an exception because the user inputted an odd number of args.  I do think it is a problem that the user does not know that the increments failed.  Perhaps I should change the spec of the function so that true is returned when the increment succeeds, false otherwise?
This should probably be `arguments.length != 1` since calling `incr()` with no params should also throw.
This page allows Jasmine to run the test suite referenced in the head section.
Ignore this, I didn't change / touch this code, I just decreased the indentation because I've used return.
Сейчас можно очень просто «обернуть» любой метод. Потому что он делегирует загрузку тому, кто это умеет. Название метода только сигнализирует о типе данных. Почитай код, правда.
I'm not sure I'm happy with the assumption that a contribute button would have a .button class.

I would prefer a looser check that an element is not present like this: `//a[contains(.,'Contribute')]`
Can you provide a check script for mercurial?
Why compute and add this info for any other user than $_SERVER['REMOTE_USER'] == $user ?
but if is it supposed to be there for the caller then it could have unexpected side-effects by not being there. This is an issue that we may need to see how people use it. I would rather pass to much through than too little
Thining more of it... it's incapsulated sooo it will take a great deal of evil genius to signal this handle. 
So basically scratch this.
As above I see no practical need to mix *static* and *dynamic* arrays. Again, our opinions are opposite.
You reused the variable name. I assume that this should be `i7973`? As it stands, this does not compile. It gives this error on the pull tester:

> std/bigint.d(584): Error: declaration std.bigint.__unittest2.c7973 is already defined
std/bigint.d(590): Error: undefined identifier i7973, did you mean variable a7973?
Why are you declaring `s` on one line and then assigning to it on another? This is just a waste of a line. Personally, I'd use a different variable for each call to findSkip too, but that's personal preference. I'm not a fan of reusing variables in general, since it increases the odds of reusing them when you don't mean to.
since `if (` is everywhere else in this module, please preserve it
Would it make sense to put these into the »dummy range« mixin, so that they can e.g. also be used for `std.range` unit tests?
my bad, apologies
That *is* a problem I though about. It would be great if appender could be made safe/pure, but I'm unsure that will happen anytime soon.

we could just forgo using appender for now, and re-insert it later. For now, appender needs to be made at least trusted. Given that it is currently casting all over the place though, I'm not even sure it can be made trusted. I tried to look into it, but Appender is very complicated, and it had *other* bugs that also needed fixing. I did the strict minimum I could in appender, but tried to not take it past what I couldn't do.

For split, I'd say that being safe and pure outweighs performance...
Well If you insist..
This doesn't make much sense to me.

If you're updating a record, you want to be able to transition it deleted => live. If you don't need to transition it, then you have nothing to do for deleted items, right? (It's just a guid and a time deleted.)

Can you explain?
what happens if its not a valid version string?
We recently added some logic to behave differently  based on which environment you're running in (dev, prod). This should probably follow same patter, and.. should this be in core instead? What's the difference between this and current behavior in master?
I'd like to see some test cases for these guys.
> This seems to do the trick, ya ?

It does - but it matters only to us humans - "1.4.12" is true, and so is 'true' :-). I think its completely unnecessary, but interesting none-the-less.
That's probably ideal but not required to function.
Huh ? `!$v instanceof \Traversable`
didnt seem like a sensible use case so i disallowed it for now
ah sorry, other repo
We're not sending uuid in POST request, also (state, crreated_at, cancellable, etc.)
As far as I know, the JGroupsTransport is shared between different (named) caches and each one of them can have a different configuration; this can result in a cache using 2PC and another one TOB. This boolean helps me in distinguishing between a 2PC-based PrepareCommand and a TO-based one.
TOB, in fact, enforces a total order on transactions and, to do that, PrepareCommands are sent with a total-order primitive (which is different from the plain 2PC one)
yeah, fair enough.  I should have removed all the talk about mapping outside the actual classes.
As I said I think ImgPath should not be an APIProperty in SingleFile.js. This is to accomodate the case where we want to add SingleFile.js to the API docs to explain its role.
No, success is passed through in the callback below.
В этом случае разницы особой между `GetRawValue` и `Property` нет, лучше использовать второе.
Use `override @property` to fit with others.
Spring standard is else on new line.
@olegz Sounds good to to me then. I wanted to provide the least code-changing implementation and thus minimize any deprecations. Let me go ahead and make the changes.
Considering a literal value is probably the more common case, I don't think we want to *require* adding single quotes every time. Should we add a mutually exclusive 'key' attribute as well?
@Dentxinho: Yes you're right, in the same thought as my temporary fix...
But again, the same question pops in my mind: "Do I support such openness?"
Since this is working much for this idea of "allowing people to use anything else than email or username" to authenticate along with a password.
In my opition, we should reasonnably remove the "$this->identity_column . ' identity_column, " par of this query, and give the users the power of modifying it when required... I understand the point to make this parameter generic but I don't approve deploying, at this time, such efforts for such a singularity...

@benedmunds: Want me to apply this on that file of my branch, then you'll be able to choose if you want to integrate that or not in your project...
Good throughout! Thanks for upgrading. Same for FSharpX.
CSS is magic. Black magic.
@bp323 Can we split this so we can have it on different lines?
@ntalbott yeah, I guess I just wanted whoever was calling the method to be as explicit as possible, but either way is fine.
oh neato
don't use table, try div
'name' and 'items' could probably be indented to the same depth each since they're both keys of this dict
I will admit, this approach has a benefit that changing a config setting does not: it forces the runtime state to be in sync with the management database.
This is the wrong signature, there should be a success and fail as well.
I don't really know how that happened... but now it's fixed

cheers,

Javi



On Thu, Nov 15, 2012 at 1:26 PM, Romain Deltour <notifications@github.com>wrote:

> In src/main/resources/etc/system.properties:
>
> > @@ -1,5 +1,5 @@
> >  #fwk version
> > -org.daisy.pipeline.version=${pipeline.version}
> > +org.daisy.pipeline.version=1.4-beta
>
> Are you hardcoding the pipeline version intentionally ? If not, please
> revert before I merge the PR. Thanks!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/daisy-consortium/pipeline-assembly/pull/7/files#r2138473>.
>
>