labofsahil/github-event-dataset-2012 huggingface dataset:
for branches, it has to be ``version=origin/2.0`` as it is not a local branch but a remote one so the name include the remote name
Oh look a spelling mistake that causes a compile error
Bah, you're "right"
How is this entire method different from `db.store`? If the records are equal, the store is redundant. If the record doesn't exist, we'll insert.

(Also, when you extend clients to include commands, you'll see why I broadened the definitions of equality in `Record`. Are two records the same if they're identical but for their command list? Or their modified time?)
Hoping this will prevent the 1+ inquiries we get each day about our code showing up in slider plugins.
This does not look good on the github project page: the README viewer wraps the longest lines (I think to 80 chars). Please fix. :)
@neoascetic ;)
à la ligne clairement ce `}`
hmm that's exactly what I have ...
ken korsilam vule gesi..:p
I think I have managed to update the pull request with a change to the
ipProtocol test.
No, it's completely unrelated - I had stuck it in there when I was first tracing through the code, and while I deleted most - I left that one in there for some unknown reason - I must not have seen the logger statement two lines below when diff highlighted, I'll strip that now.
Should this be "The `tap` Event" instead of "Events" ?
After this change of ui-dialog sytles, the "Add Device" dialog in Preview seems not good. Please check and fix the problem.
HashTable might work. However I'm thinking ClearPass actually does store null values to indicate that a user's password is not available. The EncryptedMapDecorator unit test seem in the clearpass module seems to suggest this.
Good point. I switched over.
The idea with a factor of something else is that there is less knobs to learn how to turn. But I'm fine with either.
not case object?
I’d call it `moving-average-half-life` and document as (replacing last sentence): The relevance of each data sample is halved for every passing half-life duration, i.e. after 4 times the half-life, a data sample’s relevance is reduced to 6% of its original relevance. The initial relevance of a data sample is given by `1 – 0.5 ^ (collect-interval / half-life)`.
you have to do that commit yourself man :-)
no, eq/ne needs parens, and I don't want to make it look like the RHS has priority over the LHS, thereof the balanced parens
"corresponding nodes" or "the corresponding node"?
I've played with the proxy class loader idea but it doesn't quite work (I suspect ObjectInputStream).

The main difference is that with the Java Hack the code operates directly with the targeted class loader i.e. Remote or Original. But with the Proxy it operates with Proxy instance. In theory they should be equivalent but...

I get the classic RCL deadlock, CL waits for Bytecode, Bytecode comes over the wire but waits until the CL request timeouts before being deserialized.

Because of this RCL communication has it's own thread group and uses the original actor system class loader. While RCL is done with RCL Class Loader and on the primary thread group.

But with the Proxy CL it deadlocks anyway. I suspect Java Serialization does some strange things under the hood. I looked at the Java sources but they look ok. I started looking at jvm.cpp if Class#forName0 is doing some strange things. I surely missed something.

I'd prefer to just keep the Java Hack.
I don't get the performance optimization comment. How I would rewrite the `getChild` method so it returns null for both `None` and `Some(ChildNameReserved)` in a nice way without basically doing the same thing that I do right now in `child`?
Big Thanks!! It's just plain B.A.D.
"Showing 130 changed files with 1,405 additions and 1,241 deletions".

Let's set a max of 500 for additions + deletions (except for massive file reorganizations).  that will be a good metric
For debugging, should remove when finalizing the branch.
should card.codename return a Symbol?

Good insite on the API, it would act as if it really is an AR field in the table.  That would argue for it returning a String, but I like using Symbol
I did. Fixed formatting until it passed, before i could commit. it's not
passing?

Sent from my iPhone

On Aug 11, 2012, at 4:58 AM, Mathieu Virbel <notifications@github.com>
wrote:

In kivy/uix/carousel.py:

> +            if self.index == 1:
> +                return None
> +        if self.loop and self.index == len(self.slides)-1:
> +            return self.slides[0]
> +        if self.index < len(self.slides)-1:
> +            return self.slides[self.index + 1]
> +    next_slide = AliasProperty(_next_slide, None, bind=('slides', 'index'))
> +    '''The next slide in the Carousel, is None if the current slide is
> +    the last slide in the carousel.  If :data:`orientation` is 'horizontal',
> +    the next slide is to the right. If :data:`orientation` is 'vertical',
> +    the previous slide is towards teh top.
> +
> +    :data:`previous_slide` is a :class:`~kivy.properties.AliasProperty`.
> +    '''
> +
> +    #### private properties, for internal use only ###

I don't think it's pep8 compliant no? :) ("make hook" !)

—
Reply to this email directly or view it on
GitHub<https://github.com/kivy/kivy/pull/626/files#r1357148>.
the biggest problem with this is that `-x` is an O(n) operation so you loose the benefit of doing a O(log(n)) search. It's all moot anyways for two reasons: 1, x tends to be small so this pretty fast no matter how you do it and 2, I like my little function and you're not going to take it away from me ;).
These name changes are really important - just because you don't see them as such.  It actually harms readability in this case because data_dict has a specific meaning in ckan.
@seanh Done.
:( why am I sad
This caused me to look up lgettext. It's probably the direction we want to move, but I'd rather do it across the board rather than one-offs. It's likely not to cause an issue, but I'd rather not have variations in approaches in the same codebase.
I added a comment to move this into that config section when it comes into existence.
Wait 'till you see how much of account is already like a card attribute.  This should be trivial now (tip branch account_card)
session_user is supposed to be a card now.   I think it is still nil in the 'session' (session[:user])
I'll do that in an other pull request.
Sorry to be a PITA, but I think this block can be replaced by
```
CFileItem item(itemDir, false);
if (item.IsVideo())
  itemDir = URIUtils::GetParentPath(itemDir);
```
thus avoiding the inclusion of StackDirectory.h
now we grab all properties, regardless of server
Deze mag je altijd weglaten.
How is it possible for  `access_token` to be `None` if it was just checked for?
And I've just seen that it's used on a float below. If you need to handle bytes as well, I guess this would work:

```
if isinstance(s, bytes):
    return s
return bytes(str(s), 'ascii')
```
Shouldn't we keep it simple and require the right suffix in tests=?
```sh
$ rebar eunit tests=foo_test,foo_test_ suites=bar,baz
```
would try to run the test foo_test and generator foo_test_ in bar(_tests).beam and baz(_tests).beam
This does not seem to be used anywhere
This should be pulled out into a named constant.
Yes; can't believe I missed that.  Incidentally pull request #327 fixes this.
mezirka! :) plus tyto ify na 3 radky :) http://doc.nette.org/cs/coding-standard#toc-control-statements
Actually, one of those is inside Unsafe, and the other is directly on ByteBuf.  Hope that helps.
os.path.join() for future cross platform compatibility sake
Umm, I didn't mean only here. The comment applies to the following two exceptions also.
Why de we need to inspect here?
I don't think `Exact` is necessary here. Also, I think you can use the `rescue` method syntax instead of `begin..rescue..end` in this case.
Just some notes: In theory it should fail if returning `nil` because [it's being concatenated with another string in form tag helper](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/form_tag_helper.rb#L656), but this does not fail there because the tag helper actually returns a SafeBuffer, that does not explode when concatenated with a String (weird huh?).

But, it'd be a problem in `button_to`, [where it uses `safe_concat`](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/url_helper.rb#L355), and will give errors if `token_tag` returns `nil`.
I like this since with this PR the rewrite_extension now looks so complex
I just try to make it as much flexible
But i think you are right, i will remove that case to make it work faster
Harder to do the path-dependent type without an explicit path name....

I wanted to avoid implicits with explicit return types.  Especially in documented, very copy-pasted, code.
Ah, right. Yeah, I think it might be a bit better.
I really don't like that typedRefinement returns Unit (unlike other typedXYZ) .
I agree that it's not necessary to be so specific. OK, so then let's just make it generic.

    def prepare[T, U](f: T => U): ExecutionContext = this

I'm not sure about renaming it. `bind` makes sense, but it's one of those very, very general names. In the meeting we always used `prepare` and intuitively it makes sense to me.

Anyway, Heather can add this change to the commit with the fixes.
i thought this was gone? I would just get rid of it completely.
This works! Hurrah. I'll make this change once I can finish up changes in another branch.

```
In [1]: def foo(): pass

In [2]: q = foo()

In [3]: not q
Out[3]: True

In [4]: def foo(): yield 1

In [5]: q = foo()

In [6]: not q
Out[6]: False
```
oh sorry yes
On Fri, Mar 16, 2012 at 8:30 PM, Julien Rioux <
reply@reply.github.com
> wrote:

> > @@ -2670,9 +2670,6 @@ def _eval_derivative(self, s):
> >              return S.One
> >          return S.Zero
> >
> > -    def as_numer_denom(self):
> > -        return self, S.One
>
> what happens to as_numer_denom? is it now defined elsewhere for everything
> that subclasses this?
>
>
Apparently I keep it only in Expr because a general Basic object doesn't
have a numerator and denominator; that's a property of an Expr.

commit 7611d52b150c7f5ac932b32abcddd596db7b55ff
Author: Chris Smith <smichr@gmail.com>
Date:   Sat Nov 5 23:28:37 2011 +0545

    keep only Expr.as_numer_denom() stub

        It doesn't make sense for Basic to have a numerator and denominator.

        AtomicExpr derives from Expr, so it inherits Expr's as_numer_denom
stub.
What is the PEP rule here?  I always use just one space between functions.
> That means that Add and Mul's sort_key should use _sorted_args, too, I believe.

Absolutely.  And your pull request #1462 has done that :-) `Basic.sort_key` uses `_sorted_args`, so by overriding `_sorted_args` in `Mul` and `Add` you have assured that their sort keys are hash independent.
These inherit from Expr - does this make sense?
That's for changes already in master, right?
Note that changing it from '=' to '==' also changes what is removed from the RemoveTarget call below...  I would be very hesitant to merge this without some testing >.>
much nicer.
ditto, `test_callable_arguments`
Yeah, I always forget that Python lets you do this.  Changed.
Looks like this is a special-purpose duplicate of the "tags" plugin.
+1 we should adopt the convention from the unit package.
It doesn't really matter since it's only used during loading and the save function itself sets the domainChanged to false
concider use $0 for executable name with proper comment (cryptic ruby magic..)
Oh, ok.  class is deprecated anyway
omit.
:D ahem..
Indeed that should really be stored as data and be done when viewing logs. Although I don't think we currently have list handling for log data
What's the reason for using call magic? It makes the code really difficult to read.
Why have you created a second global statement?
In the event that the following $template->assign_vars() call is used for other template variables, this comment will no longer apply to the whole method call. As such, it should be moved to the line directly above `'S_UNREAD_TOPICS'` (with the same indentation).

Also, I'm not sure such a long comment is needed. We can probably just shorten it to something like:
`// Determine whether or not at least one topic in the forum is unread`
The unit tests capture these events for testing.
No, I don't think we should retry.
> I wanted to avoid the situation where you're sitting down to run the test, but have forgotten you have stuff in your Redis db.

I tend to use a separate redis db number for my test environment so this isn't an issue...
Actually, I could be confusing the Mojito framework index.js with the Mojito _application_ index.js file here. In which case we could potentially remove the index.js file from the framework. Individual applications still need a Manhattan-compatible index.js if they're going to deploy to Manhattan.
Зачем разделять? Получилось 4 куска ппактически идентичного кода
Зачем эти комментарии?
use `var`
so what will we do if that is not only None's but mix with str etc?
Add the view of your grid here as well.
Per my comment on line 133 of src/screener/app/controller/Application.js... you should abstract the definition of a drugOrder into another view file and reference it by xtype here
Please use http://jsbeautifier.org/ to cleanup formatting
(Code style conventions: https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Code+Style+Conventions+for+JavaScript)
currently all the variables are global... so there is no restriction/motivation for anyone to only use the Util.getUpdateUITime function.
You should be doing it as privileged function - http://www.crockford.com/javascript/private.html
or make them capitalized (to give them a constants feel) inside the Util class. So someone would say Util.UPDATEUITIME. Also it is bad naming style to use verb ('update' here) for variable names. Verbs should be for method names.
Please remove this file from the Pull request, since it's not involved in the Bmi Calculator
> It'd be nice to avoid the explicit (and therefore fragile) list of attributes. Can't you just use the existing copy() method and supply new points/bounds?

The intent is still desirable - but forget my stupid proposal! :blush:
This line is still too long - perhaps just ditch the unnecessary `_PP_little_endian_spec` intermediate (in which case, we'd need to do the same for the other format specs).
This can an also be an ```iris.cube.Cube``` as they have ```shape``` and ```ndim``` attributes.
Strike line: msg1 always assigned before use, msg2 not used. Suggest rename/replace msg1 -> msg.
constants should be UPPERCASE
You don't use ``default`` anywhere.
get_export_response
again explicit comparison is nice for non-bool types.
I'll make sure he notices. :-)
no need for else after a return
Indent issue here and next line.
A few bytes, I think. If the list grows, we should either unconditionally define an object to do key lookups on (i.e., at top of file) or switch to regex, but this is such simple logic anyway that I'd rather have the savings now than use a suboptimal scheme in anticipation of potential changes.
`function(jqXHR, settings)` => `function( jqXHR, settings )`
`jQuery.extend` is probably overkill, why not just define as function expressions:

`jQuery.Animation = function( elem, properties, options ) { ...`
What do you think of making .timedelta a property of the instance instead? That way we could just say self.timedelta instead of passing in self.repeat_*

http://docs.python.org/library/functions.html#property
This line can currently crash on Android. If you hold a touch down and the device orientation changes, it calls ReleaseAllTouches(). Then a release event can come in with the same ID so _touchIds[id] throws a key not found exception. The unfortunate thing is that Android sometimes gives you released events and sometimes doesn't. That was why my EndTouch() implementation didn't Assert that the touch already existed.
Wait, _why_ aren't we using timezone-aware datetimes?
annotation.endpoint?
Die Funktion um ein strtolower() erweitern, dann passt auch das mit der Groß-/Kleinschreibung:

  function getSortType($default = null)
  {
    if(rex_request('list', 'string') == $this->getName())
    {
      $sortType = strtolower(rex_request('sorttype','string'));

      if(in_array($sortType, array('asc', 'desc')))
        return $sortType;
    }
    return $default;
  }
GitHub shows a complicated diff here. Was this just a closure wrap or are there other changes here?
Linux就是折腾~~make确实不适合新手。可以删掉这个部分。

On 2012-3-31, at 上午12:35, Yihui Xie wrote:

>> @@ -200,6 +200,13 @@ $ which R
>> $ echo $PATH
>> /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>> ```
>> +当然,奇葩的make -j8可以不用安装(sudo make install)就能使用R,你只要在`~/.bashrc`后面加上PATH就可以了. 更改`YOU_R_PATH_Directory`为你的R目录,复制如下内容到你的Terminal中:
>> +
>> +```bash
>> +cat >>~/.bashrc<<EOF
>> +export PATH='YOU_R_PATH_Directory':$PATH
>> +EOF
>> +```
> 
> 我还是希望多数*nix用户能以标准轻便的方式安装，不要轻易动用make以及改PATH
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629487
Please put a space after each comma
Urls*
Are you sure `:not` works in Android 2.2? I seem to remember that I ran in to problems because it didn't, but I can't recall whether that was really 2.1.
For JavaScript only right now if all the lines in the selection are line comment, it will uncomment it instead of adding a block-comment inside of it that would do nothing, unless all the line comments are inside a valid block-comment.

For example: (using `|` as the cursor)
```
    // One lin|e comment
```
Using toggle block comment like that, should become
```
    One lin|e comment
```

```
    /* Block comment start
    // One lin|e comment
    */
```
But in this case it should become
```
     Block comment start
    // One lin|e comment
    
```
Should add a note here that the purpose of this is to make extensions backward-compatible and brackets core code should always have keybindings explicitly defined.

Is there a way to verify this in the code and write something in the console log?
It also looks like `_convertToNormalRGB()` currently bails if *any* of the components is not a percentage, but it seems like it should be fine to convert just the components that are percentages. I'll make that fix as well.
名前付きテンプレートを使った場合は if body がtrueに
there is a better fix on the ui/navbar
I think that a recent pull request in APF also fixes this, but better: https://github.com/ajaxorg/apf/pull/42
I think this is fixed by a PR I closed a couple hours ago.
ok, addressed
We've got some pretty unintuitive naming going on here. Like the url name "app_summary" => "summary.html", and "exchange_summary" => "app_summary.html"?
You can get rid of this check. When you call getNodeForPath (and the item doesn't exist), the 404 exception will already be triggered.
I wonder if going to INT2 is really a good idea. Users might have to do explicit type casts more often. Thoughts?
oh, the **stack trace**! Ok, close enough ;-)
You do not have guards here even if you call some of YUI methods. We should try really hard to prevent any uncatched exceptions.
Obviously a personal choice thing, but it seems like the @params here aren't really adding anything to the main API doc, right?
I will fix this as soon i will implement feature for language setting from user object, because right now I don't yet know what other things will I have to add. Is that OK?
Yes, it is. Do I have to use different name?
Just wondering, what's the advantage to splitting this up? i.e. why wouldn't you just do like `!butter.cornfield.authenticated() || !butter.project.name || !butter.project.id`
Not a bad idea. Callback should always be something here though. If it's not, it's most likely a mistake we'd want to hear about.
Don't need to close the first tag here: `<script /></script>` probably confuses some browser somewhere.
This one was mine, and not Brian's, and this was intended to check for numeric values. 0 will be true in this case.
And some spacing here.
Unless there's somewhere you're overriding this... but I don't think you are
I'll sort this when I have time to tidy up the CSS task
we need to limit loop somehow to protect from invalid data.
How is 127.0.0.2 the left most resolvable ip?

fwiw, The current test added on 22nd is failing locally for me with:

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec <<< FAILURE!
testResolveIP(org.sonatype.nexus.rest.RemoteIPFinderTest)  Time elapsed: 0.114 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:<[127.0.0.1]> but was:<[{unknown}]>
	at junit.framework.Assert.assertEquals(Assert.java:85)
	at junit.framework.Assert.assertEquals(Assert.java:91)
	at org.sonatype.nexus.rest.RemoteIPFinderTest.testResolveIP(RemoteIPFinderTest.java:32)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
'handle' is enough.
Same, as if we add SWC dependency which depends airglobal to project that ain't air.
Do we need cassandra.jar?
this should probably be static
because it is dependency of ZenTest, which is devel only dependency
Ok by me for now, will merge
What would be base URI be for `visit` to use?
You can use display: inline-block to assign widths to inline elements without having to use float.
The docstring should be used to describe what the function does.  This information is helpful, but should probably be in a comment following the docstring.

The docstring could be something like:

```
Resets all of the vo warning state so that warnings that have already been emitted will be emitted again.  This is used, for example, by `validate` which must emit all warnings each time it is called.
```
(there are other lines like this that are commented out, but since it's not critical I won't comment on all of them)
Does it make sense to change ``from_table`` to:

```
def from_table(cls, votable, table, id=None, name=None, ref=None, ucd=None, utype=None, description=None)
```

and then read the values from ``meta`` if available and not specified in the above call? Or would it make sense to just do it for ``ID``?
类似的，你提醒我可以用array_reverse解决！
Why are the numbers different here than in the population script?
As I have no clue what FIRST_CLASS_MESSAGING is or does for me you are free to assist me in fixing this ;). You could start by posting a screenshot how that dialog looks with it ^^.
ok, good. Sucks that github shows so little context around diffs
I *think* it's been "use absolute namespaces in new code, but don't bother changing old code".
recursivly -> recursively
ah true, so I don't think the complete ternary condition in this case comparing using the null displaid will help, I think it's more readable as it was before. I'll move it back. thank you
This happens when I'm too lazy to browse :)
I disagree. Testing something which makes no guarantees about thread safety
by using threads is a recipe for disaster IMHO.

I'd rather solve the problem once.
On Oct 31, 2012 5:59 PM, "Didrik Pinte" <notifications@github.com> wrote:

> In enaml/tests/widgets/mock_application.py:
>
> >
> >      """
> > -    def __init__(self):
> > -        self._root = None
> > +    #: A signal emitted when an item has been sent down the pipe.
> > +    actionPosted = Signal()
>
> Thinking about it, I think we should go forward with the current
> implementation. If they are broken behaviour, let's implement some test
> case and fix the issues. We are in a much better shape than before with
> this code. I will add some notes in the mock_application.py file to make
> sure the potential issues are captured.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/enthought/enaml/pull/202/files#r1998742>.
>
>
>This will work if you stick on only delivering an x86 version of Git-Tfs.

Well - looks like @kgybels is already bumping up against that limitation on his repo. So I guess we'll be changing over to amd64.
I think you can just use `suppressWarnings` here?
I think that, if we're to deprecate this argument, we should either ignore it and log, or just take it out of the parameter list. This would likewise raise an exception, but keep the code cleaner.
In [IPython.testing.nose_assert_methods](https://github.com/ipython/ipython/blob/master/IPython/testing/nose_assert_methods.py), we only add `nt.assert_in` and `nt.assert_not_in`.

I don't believe that we monkey patch `unittest.TestCase` to add `assertIn`, etc.
I still think that this option is not needed. For me it does not make sens to rename the already present file.
If it is for backup purposes, then it is to the backend to do so.
you can expose mappings without needing a user to supply them :)

ex. look at BlockUntilInitScriptStatusIsZeroThenReturnOutput and BlockUntilInitScriptStatusIsZeroThenReturnOutputTest

You'll notice that the function classes are isolated and also unit tested.  However, the \@Inject ctor doesn't require bindings.
rangeEnd = Changeset.numToString @snapshot.pool.putAttrib ["range.end",1], true
This is going to collide, it's been defined before. Maybe this belongs in a common header with an `ifndef`.
This `goto done;` is the same as a `break`. The `done` label is probably not needed.
OK, this is fixed now and we no longer need to allocate this string.
I know this is not part of the pull request but could you remove the second argument. `"foundation/annualreport/2011faq"` will be automatically added by the system.
Brilliant! This is coming together nicely!
I believe this expression would be easier to understand:

```lambda stack: any('CreatePairedMinidumps' in signature for signature in stack)```

it reduces to one level of parens and drops the confusing `find` and `-1`
My bad! I didn't spot the raise. Ignore me.
Instead of making this configurable, we could just do one like this:

```python
def _indentify(self):
    msg = "This is a %s" % self.__class__.__name__
    if self.config.get('ip_address'):
        msg += ' running on %s' %self.config.ip_address
        if self.config.get('port'):
            msg += ':%d' %self.config.port
    self.config.logger.info(msg)
```

or something like that.
if (xxx) {
需要保留一个空格
Okay, sounds like it will still work then :) Thanks for the explanation
Need this section.
Stupid copy-paste mistake. I've updated the pull request. Thanks for
catching this.


On Sat, Dec 29, 2012 at 4:28 PM, Jason Grout <notifications@github.com>wrote:

> In sagenb/notebook/interact.py:
>
> > @@ -2639,6 +2639,8 @@ def interact(f, layout=None, width='800px'):
> >          ...         html('There is no solution to $$%s x=%s$$'%(latex(A), latex(v)))
> >          <html>...
> >      """
> > +    if not isinstance(f, types.FunctionType) and callable(f):
> > +        (args, varargs, varkw, defaults) = inspect.getargspec(f)
> >      (args, varargs, varkw, defaults) = inspect.getargspec(f)
>
> Ah, I notice that this pull request and the patch on the relevant sage
> ticket are different. Did you perhaps mean that inside of the if-test, it
> should be f = f.__call__?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sagemath/sagenb/pull/125/files#r2520681>.
>
>
а це ти даремно видалив
this should be a ``BadMethodCallException``
I don't understand why this PR would be needed? Can you give an example how an attacker can modify the host of a site?
If there is a way, wouldn't it be an error on the web server side. I don't see how an invalid host could reach the web app.
The example given here cannot be a host because everything after the `?` is per defintion the query string and that's what the web server must take care of (and not the script).
@jfsimon should the handlers really be registered on the RequestContext ? It seems wrong to me as they are able to change the way the route are compiled, which means that the cached router would need to depend of what is set in the RequestContext you set into it.
IMO, you should register the handlers in the matcher and generator themselves.
This can be merged with the above if () statement.
Please leave the options array unchanged and set this value after line 148 instead:
```
$dateOptions['input'] = $timeOptions['input'] = 'array';
$dateOptions['error_bubbling'] = $timeOptions['error_bubbling'] = true;
```
it should be ``if (!file_exists($file)) {``
I noticed that, but I have a private method named countDeprecations(), which goes through the logs and does the actual counting. Any good suggestions on how to name that?
Please remove the ``\`` on the function call. Symfony does not use it.
fix the weird indentation: prefer

    .. val defaultSSLContext: SSLContext = {
      val ctx = ...
      ctx.init(..)
      ctx
    }
what is this file? remove it make a correct merge and recommit.
(weak, nonatomic) for these two IBOutlets
I know this was my idea originally, but style guide suggests not using the construct name in the method name (e.g. array, hash).
For two examples, I might just make two Scenarios rather than use the table. Feels like a tool for 3+ examples

Also the "<profile_image>" syntax doesn't read as a user story. Meaning, I can't imagine a user saying line 13, which is the test for a user story.
Does this not work if you pass in a relative path to the file (rather than the `.join` and `.to_s`)?
would it perhaps make sense to move this workaround into a code path that is available for all Ajax requests, e.g. the $.ajax wrapper at the top of this file, or even into cms.base.js?
Is this where it is doing the "relax the filters" part? Maybe highlight that with a comment?
d23ea3a just came in, so you'll probably have to globally replace `stateManager` with `router`.
I guess this one line by itself isn't really valid JS anyway.
The reason for the static use is that this object needs to be shared between a BoottimeAddStepHandler, an OperationStepHandler, and a DeploymentUnitProcessor. I made a cosmetic change that moves the flag to the static instance.
We should discuss this with the core team and determine coding standards. This is a defensive conditional to avoid typos.
style changes made as requested
This is obviously specific to the “drawer” use case (note: this could be called “sidebar” instead, if you think of bigger screens…), but what about the rest of this file? Which of these 500+ lines of CSS do we need for the drawer/sidebar itself?
Shouldn't we move it to "style" if we are landing 1 app using this style? What's the reason of having a "unstable"  folder landed? @fabi1cazenave @vingtetun @etiennesegonzac ?
Could we do it with a for, instead if/else? Just in case we need to add more fields, would make it easier.
@fabi1cazenave should we change the identifier here?  It appears to me that "App" is distinct enough from "Application" that we should.
and why are we using href="#" here? I tend to consider that bogus links should be buttons…
I think we need to make it /pulp/puppet. It's a fuzzy area. Technically speaking, there's no overarching pulp namespace that plugins have to put their stuff in. It could have been just /puppet. It might make sense to put in the whole path after the server so that the user can copy/paste that portion after typing out the server name and be done with it. That way there's no implied knowledge of a pulp namespace.
browser doesn't use plugins, no need folder
I like where this is going.
missing localization here. we need:

    raise Exception(_('File is not valid package: {0}').format(path))
with block?
Presumably one of these arguments should be called `entities`, yes?
LGTM tho we can just do `if (query) media.val = new nodes.Literal(query.nodes[0].string)` to avoid the lookup / .call
Allow me to ask why that is?
Isn't this potentially breaking for current code?
Should there be a description of the type returned?  It should be obvious from the name that we're not returning a new Renderable object, but you never know.
Fair enough. 

Long term, I'd argue it this app should be moved to doing things with the asset pipeline, rather than fighting against it (I did this successfully with Panopticon and Publisher).
Could we not just serve a 302 then?
perhaps append to the this line "Returns array of directories in the stack" ?
Does the Feature object use this factory? Looks like it might be an unused val.
Versions should be only defined in the parent pom of a multi-module maven project.
? 
```coffeescript
      # First filter the route handlers to those that are of the same
      # name
      for handler in Backbone.history.handlers when handler.route.name is name
        url = handler.route.reverse params
        if url isnt false
          return url

      # We didn't get anything
      false
```
As a rule for *version 5.0* and later, all *types* with one data source must use the *data source name* **value**. Also, the use of `COUNTER` is strongly discouraged in favor of `DERIVE`. I.e. this line should read:

```
deleted value: value:DERIVE:0:U
```
```
#!/bin/sh
# Composer Git Checkout Hook

# Process composer.json if one exists.
if [ -f composer.json ]
then
    # Check to see if Composer is installed.
    echo "Processing Composer"

    # Check to see if Composer is installed.
    [ ! -f composer.phar ] && [ ! `which composer.phar` ] && curl -s http://getcomposer.org/installer | php >/dev/null

    # Run the composer install
    [ -f composer.phar ] && php composer.phar install || composer.phar install
fi
```
Leveraged the state variable which github oauth will return when it calls the authenticated callback (in this case the github-authenticated routine.
Use QDateTime::setMSecsSinceEpoch
why have you made chain of find?
Comment why this function exists.
Still the dev account?
grr. I was going to remove the replace_all function so it was like a microsecond faster at doing this but I guess it works, I didn't get around to it yesterday because I did an all-nighter (we all know how we love those).. I guess I can stick it in with a future pull request.
Do not specify ````:adapter```` after incorporating changes recommended in other comments.
oh sorry ... my emacs does that for me :)
Does it mean that we run the sdk target all the time, also when we are creating the xpi but not for 'run'? It would be great to only have the xpi available if all tests are passing.
s/hydratea/hydrate
> The identifier of the most recent post that was seen
If I remove the silence operator, all tests in there will fail:

"Only variables should be passed by reference"

I don't know why this happens. There's just a string passed to the new AccountFeed Object. The same usage with the DataFeed in some other tests works fine. Also if I make a sample Skript using the same Code and run it with E_ALL active.
Changing interfaces is a BC break.

The way to get around this is to introduce a new interface -- let's say, "SharedListenerAggregateAwareInterface" -- with the new methods. The default implementation can then implement that as well as the SharedEventManagerInterface.

(If I merge today, I'll do that work; if not, I'll let you know.)
$output already had a value assigned on line 309. Not sure if overwriting that is the way to go.

If correct I would suggest:
if (!$head) {
   $output = $tableText->render();
} else {
  //  ... this code block;
Faute de frappe: explique
Have you checked that API still works? What is the reason to remove this line?

In any case it's better to comment it, as it was here in original auto-generated file.
Thought so, though a quick look through nms didn't yield any occurrences of this. I know they're there though!
nit: spaces after commas for arguments
Please use the ``Twig_Extension_Debug`` available as of Twig 1.5 instead of the old extension
fixed in my latest commit
Oh the irony. It was everything else which was showing up in the wrong review.
This has nothing to do with the exception, it's just a formatting issue. When download/packages count is 0, the Json contains an empty string, which slightly messes up the layout on the home page. I changed it to "n0" to be consistent with [_ListPackage.cshtml#L30](https://github.com/NuGet/NuGetGallery/blob/master/Website/Views/Packages/_ListPackage.cshtml#L30) which shows "0" when the download count is 0 :-)
I'll send another PR for this as the main purpose was fixed in 513f257e6818391345edd2a7301ce6a018d585d0.
I know that
Are you requiring this change? I don't see the need to produce a new string just to know if the string is whitespace or not. I simply want to know if the string is blank or not.
NEWEST_FIRST? ANTECHRONOLOGICAL is just a pain to read.
@harjis Tässä vois kenties mieluummin käyttää PHP:n omaa date() ja mktime() funkkareita. Just in case. Ei voida nimitääin olla 100% varmija, että kaikilla pupe-palvelimilla on toi DateTime extensio asennettuna.
pep8? this is a little over 80 characters....
Ah, saw @asm89's comment now :P
Fine, will do it later today
For use in eZ Publish 5, the original idea was to implement a SlotFactory that uses the Symfony Location container for resolving slots by their identifier, so that it is not necessary to have all slots instantiated at configuration time. Just as a remark.
It is possible to have a URLWrapper object that has a name equal to empty string. if the meta data does not have any value. Thought this could be useful to blank out a default if required
@itkovian, @nudded: We could agree on something, but will we try to enforce as well?

I'm not going to spend my time replacing 's with "s (or even scripting it, which might be a lot harder than you think if you don't want to break things).

Sometimes you want to use 's because you need "s inside the strings, e.g. ' with-gcc="$MPICC" ' (you want the $MPICC to be expanded by bash, so you need "s).
But, in other cases, you'd want to use "s so you can use 's inside the string, e.g. to avoid that bash expands things: " --with-cmd='ls *.a' " .

Maybe one of both should be the default and preferred, but I don't care for it much, it would be very hard to enforce imho. And if you don't enforce it, you'll fix it once and then start diverging again.
Ditch the extraneous empty line
use `pass` and a decent docstring
Oh, thx. I remove this code in next commit.
I think at the time I misread the banner hash generation code and thought it would be the same on every machine. That was wrong.

I'll put it in test.py instead so it doesn't throw errors about not existing.
Bob, can you make it easy to tell which link failed?
I'd rather share a subdirectory of `views/` to make it clear what's a client-side template and what isn't. I've been using `views/templates/` shared as 

    app.use('/templates', express.static(path.join(__dirname, "views/templates")));

though maybe we could choose something more descriptive than "templates".
there are some spaces in this?
Done and done, I'll have that cake now pls. :-D
Yep! I'd do it but I don't really know how to test...
@ohadlevy, I added the pagination, since an admin can alway change the setting entries_per_page to something large.
Never mind, you do that below. Nice!
`ZU.xpathText` returns `null` if xpath is not found. So this may occasionally throw exceptions.

Also, a nit regarding url.match (and it's really just something I want to point out that I recently found out) if you don't intend on using the matches returned by string.match, string.search (but it returns index, i.e. -1 for false) is a more efficient function.
Agreed. Better wording is better :)
Is this not always true?
I'm getting rid of all the node references. I wanted to see what was on the get rid of list when I was in other classes.
Ha, my bad then!  I mis-interpreted the breadth.  You could do something more like:

- if content_for(:interstitial)
  .card_container
     .card
       = yield :interstitial
oops.  forgot i did that
I've seen this pattern in other places in django templates we use - e.g. on the Aptivate website but i think in other templates for econsensus too- where you're deciding whether to wrap something in a link tag or not (you have to close the tag which means two ifs). I don't know what a better pattern would be. One thought though - whether this is a good idea or not may depend on the efficiency of the particular test. Django templates are not particularly quick so you wouldn't want to do this all over the place on something that was heavy to evaluate.
What about using standard phpDoc:
```php
/** ...
* @param string $arHandle Area handle. If specified, returns just the blocks in an area
*/
```
See http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.param.pkg.html
Wrong encoding?
Why is this completely removed ? Am I missing something ?
деструкторы вызываются всегда у всех предков.
If you're leaving the `exists?` method on `Store`, you might as well use it here.
Why not just use underscore's uniqueId function? We can still use the hash to make sure it hasn't been generated, but I feel like that's an unlikely scenario given its uniqueness.
what is this line for??
Do the same test but with it failing too!
Worst case scenario is if given a power of two, we need to fill all the other slots with ones. i.e.

    01000000000000000000000000000000
    01100000000000000000000000000000
    01111000000000000000000000000000
    01111111100000000000000000000000
    01111111111111111000000000000000
    01111111111111111111111111111111

After shifting 1, we are guaranteed to have 2 ones on the left, so we can bitshift 2 next time. After that, we will have at least 4 on the left, so we can bitshift 4, etc. bitshifting in this way will work for any 31 bit number (all positive numbers).
You don't think it's worth mentioning that we only accept GET?  If they accidentally leave off the -G it's not entirely clear what went wrong.
do these have to be float64?
Nope, there is no notion of visibility or privacy in this API. Authz a library that is used by functional components like PrincipalsAPI, Content etc..., who worry about that kind of thing.
So are you saying you need to do both getContent and canManage? Given the requirements for deleting comments, that's probably be the case. Unless canManage returns the content object even if you can't manage it, but I'm not sure if that's the case.
Yea, that's what it means right now. I agree it's not ideal. I'll see how I can make it more extensible.
Might actually be in either my Search PR or ID Management PR where that logging sits.
We are already using Array.isArray in other places. It's the recommended approach for Node.js.
i must admit i dont know the code after the refactoring sufficiently, but what is the purpose of ``FinalMatcherInterface``? it seems like its job is to receive a collection and a request and to return attributes.

but why dont we simply have a factory for a matcher instead?

btw IIRC the core Routing has some places as well were class names are injected and @tobion was hoping to remove those.
no 500 status for connection failures?
use more convenient dot notation here ( camp.name ) - only use bracketed quotes when  you need to (e.g. variable/reserved keyword/has a - or other keyword character)
I think it's better to use OIOREST (http://oiorest.dk/) ... But I know It look better if it is OIORest. It's up to you I guess :)
Hmm, there is no issue open on the force_clear_output_dir. Let me open one. I only see an email exchange. Of course, its confusing if there is no background issue!
Nog een incorrect indentation
А зачем в данном случае привязываться к DNALength если хотите сделать рандомную мутацию то
[cell2 mutate:arc4random() % 100];
Ок, сделаю. А как добавить еще один пул-реквест, чтобы не удалять старый? А то у меня при попытке добавить выскакивает такое: http://d.pr/i/PJDA
As I mentioned globally on this pull request, these tests are environment agnostic- `jsdom` only exists in the nodejs runner.
@jmikola I moved it to try and put the methods in a logical order, but I can move it back to make the PR easier to read.
Can you remove this package import ?
+1 for this and next three.
Do you need to require this?
https://github.com/jelmersnoeck/forkcms/blob/release-3.5/library/parameters.base.yml is niet goed genoeg? :D
ahh sure.
we should factorize this with the `_preload_data` method
maybe `_alloc_data_buffer(self, preload)`
Just wondering whether we should have function for wrtiting source estimates from connectivity measures on the long run, just for convenience.
I'd go for a --proj option in which case the projection are taken from this file. Is there a usecase where proj should not be included?
Although I commited this crime -- could you change boolean to bool while you are at it?
as of here the CSS indentation goes completely bonkers =)
I want it to be different on Windows
This should be TShift.  In general, classes should be in StudlyCaps case.
let's send the authenticity token so we're testing the right thing.
Off-by-one error, `pass[passlen]` is outside the buffer.
Well, that's strange.  I don't get it even when run in a script from the command line:

```
$ cat try_radon.py 
import numpy as np
import scipy
from scipy.misc import radon

print np.__version__
print scipy.__version__

a = np.random.randn(100, 100)
r = radon(a)
$ python try_radon.py 
1.6.1
0.11.0.dev-148c3b0
```
.__________.
Ну и нахрена? Почему сразу не работать с avatarUrl?
1. 相關景點很多區塊都會出現, 所以也可以 partial
2. 相關景點連同 `.caption` 和 `.content` 是一包的, 所以再用一個 dom 包起來
you could simplify it as travis now supports composer in their VM:

```yaml
before_script:
    - composer install --dev
```
¿Por qué estamos quitando el favicon?
Nope, the anonymous function takes A Request object as first argument
I suggest to extract a named constant for the map file extension. Chances are high that this will be reused at some point of time.
tried to implement this helper with content_tags, but the result was even worse