labofsahil/github-event-dataset-2012 huggingface dataset:
I think just returning BaseForm[x] is fine. As I said, this case isn't so important.
Actually I meant supporting both : and ;

> It's a property in a properties file - using commas to denote multiple property values in the same property is more conventional.

I see. Probably using , would be better fit for a properties file.
scratch that, look at this one instead bf82eb2
can you un-autoformat that?
直した。
not a big deal until we measure but it might be worth adding an offset to `this.pack` so we dont have to dup the arrays
Add a colon after ValueError.
Reworded. Said its the cassandra implementation of the AppDBInterface interface.
Typo -- collapseable
I mean line 922 for the map options not for the marker option :

	var myOptions = {
zoom: 10,
center: latlng,
mapTypeId: google.maps.MapTypeId.ROADMAP
};
Shouldn't this be `default=True`?

The tests still pass because you're testing the generator object and the bug is in the option parsing step.

Otherwise this patch looks great.

Thanks
I'm not sure what's going on here -- is `gpoCommandArgsMatch` a pattern function like `gpoSubcommandPattern`?  In any case, commenting out code or using `print` in tests is good for debugging, but not in committed code, and I think that in this case your test isn't actually asserting anything..
kind of personal here. remove that line or make it more generic.
Interesting idea.
Could you verify that from a consumer's point of view, drools-compiler is still just a jar and nothing has changed?
Should I start with just the ones I need?
so what is the purpose of this??   to avoid fame and lost of money from busy visitors? ;-)
I basically think it's pointless - if you want to make it hard to scrape email addresses do it properly (which is very hard).  Otherwise you just make it harder for the user of your site and no harder for the spammer.
I think only one thing is needed to make it thread safe: lock the hash row. It's not strictly required, but I think it's a good idea anyway.
Cannot depend on a snapshot here; you must get 2.3 released _first_.

IIRC @imod was talking about factoring this dependency out of `maven-plugin` to begin with, using an `@ExtensionPoint`.
I agree; I'll update
what does the filter do?
error doesn't seem to be defined anywhere here
the code doesn't differentiate between the pop-up that doesn't close itself on sign-up from the pop-up that does close itself on successful sign-in. the code attempts to close both types, when it's done with them.
お手数お掛けします。
$uid = $this->d3dConf->uid; は、このあと $uid を参照しているので必要です。
$array() は array() の typo ですね。
s/freePoint/firstFreeSlot
instead of this, you could use http://docs.oracle.com/javase/1.4.2/docs/api/java/io/File.html#createTempFile%28java.lang.String,%20java.lang.String%29 also look at deleteOnExit.
Please re-write this as a multi-line `if` statement, the `x if y else z` broken over two lines is confusing.
Please "as" instead of "AS".
Above should read:
```
if ($result
    && is_array($result)
    && $this->_secureStringCompare($result, $creds[1])
) {
```
in order to follow our coding standards.
Typo `ErrorMessage`
Then I'd use `$flags['name'] !== ''`
please use Zend\Mvc\Exception\ExceptionInterface implements.
Fair enough. I'll make the change and go with jrtc27's first suggestion of catching the IllegalArgumentException from the Packet250CustomPayload constructor (so the length check doesn't depend on the exact packet format)
Let's please leave this as 144 for right now. Turning down the strip size makes this test much less stressful on desktop machines. We can figure out what we want to do with this after the initial code integration.
I prefer to use filter too, but as default we use _trans_ tag, it's will bring inconsistency don't it?
is this meant to be packageRegistrationRepository.Verify(); ?
Verstehe nicht was der Sinn hinter dieser Zeile ist?!?
same here it need an extra space imo.
You didn't touch hqstyle-core...why did this update?
hmm sorry, in ``bin/doctrine.php``, it is not really needed. but the TestInit.php file should handle it
In ConvertDoctrine1Schema.php we have the following code:

```php
if (preg_match("/(\w+)\sas\s(\w+)/i", $column['name'], $matches)) {
            $name = $matches[1];
            $column['name'] = $name;
            $column['alias'] = $matches[2];
        }
```
No check of 0 vs FALSE for preg_match' result and escape. Can you show me some example.

I think is good ideea to remove $m. It polutes with no benefits. Otherwise I should have named it $matches.
myconf="${myconf} is equal to myconf+=" if you like to save chars.
Remove also this line, thanks :-)
No that looks worse and is even more obscure. 

```
from phonebook.helpers import VOUCHED, PUBLIC

self.privacy_dict = dict(
                basic_info_privacy=VOUCHED,
                contact_info_privacy=VOUCHED,
                tags_privacy=VOUCHED)
```
ia -> is
this should probably be moved up to the line above
I don't see how that would be possible. We currently pass it to every new page object, so we're not doing anything more than before.
навіщо окремі пакети, якщо нижче весь zf2 тягнеться?
Should be you
I prefer props on top, for easier linear reading of the pom.
This seems to not work properly in the case of removal of build files from a build phase.
It looks like these calls to animate() aren't working. Perhaps somewhere with our earlier upgrade and downgrade of Raphael, it worked at some point, but not now it seems. :(
Yep, everything is in the plane, but I wanted to vary the relative angles between the lines so it looks like the problem changes each time. I basically just copied and pasted code from the points_lines_planes exercise and modified it. ... but then I wanted to add in a third tilt since we have three lines.
What does `$gprHash` look like?
What should `$proteins` look like? Especially that triple-deep array ref...
At each if statement, what do we find out about the gprHash?
I think this ASCII Font looks a little better and more bacon-y than the last
You should use #collect here. http://www.ruby-doc.org/core-1.9.3/Array.html#method-i-collect

http://matthewcarriere.com/2008/06/23/using-select-reject-collect-inject-and-detect/
What's with the underscore?
Please note that the `$("a#...")` always returns an object. To test if there's some jquery element in it's enough to do a `if(mObj.length)`.
Furthermore, the bug is still there using
```javascript
if(mObj instanceof Object && Object.getPrototypeOf(mObj) === Object.prototype){
```

When using this instead:
```javascript
if(mOb.length){
```
it seems to work...
It'd be better to use `+(...)` here rather than `parseInt(...)` for consistency with how coercion is effected elsewhere.
@gnugat Awesome! You just point a WTF I could not understand! This test was only covered when I execute this specific TestCase but not when I execute the full Test suite. And you're definitively right, it sould have a mocked class called foo in an other test case.
можно в среднем уменьшить количество сравнений?
This function is called during initialization and on `$(window).resize(...)` to read the current breakpoint from the CSS hack. If the breakpoint has changed, it fires an event named `"breakpoint"` on `$("body")` to notify all of the listeners of the new breakpoint. A property named `breakpoint` is added to each event to communicate the name of the new breakpoint to all of the listeners.
This is used to simplify `partial(...)` so it doesn't have to manipulate the `arguments` object in a messy way.
This was the only way I could think of to get the cursor to update properly over the gutter. I was worried about setting the style on every mousemove, but it doesn't seem to be sluggish in my testing.
You are importing subprocess here, but you are not using it.
(enable lint checker on ninja)
Yeah, I might be able to get rid of that.
This should be in alphabetical order.
In hindsight, it might be an edge case.
Can be ``private``
This needs to be moved to the end of the columns list as we discussed, but check with Vivek where he wants it anyway.
Не все компиляторы поддерживают такой синтаксис. По крайней мере десять лет назад не все поддерживали :-)
Поскольку код написан под linux, а проверяться должен был в MacOS, решил не экономить строчку, с тем чтобы обеспечить гарантированную переносимость.
а если <0?
Да, этим трудно не согласиться.
it's provided by Formtastic
We need to use the `$mapping['targetDocument']` identifier type to convert the $value to the database value. It is not always a MongoId.
For completeness, you could mention that you first have to click in the little box next to Console in order to enable it. Then the little arrow menu actually does something.
Yeah, just verified it, and changing the protocol's declaration to the above causes the following type:

```objc
- (instancetype)bind:(RACSequence *(^)(id value))block
```

to fail with this error:

> error: conflicting parameter types in implementation of 'bind:': 'id<RACStream> (^__strong)(__strong id)' vs 'RACSequence *(^__strong)(__strong id)'
This is only used as part of `_RACAbleWithStartValue` above, which already has a conditional for the argument count. Is there any reason to not combine this with that macro?
Which part of the interface is that guaranteeing?
I'm wondering if we should auto-detect the `+mainThreadScheduler` too, since that's a simple thread check.
This should be renamed `Notes` and moved to after `Commands`.
@dengemann I didn't implement the windowed-sinc because this would require its own special code, even though I think it's just an FIR filter (I'll have to look more carefully), and I haven't had time yet...
Either way is fine by me, I just took that name because it mimicked the C version (mne_mark_bad_channels). I'll change the name to load_bad_channels---would a note saying it's replacing the functionality of mne_mark_bad_channels be good?
Or couldn't we use a tuple with is non-mutable?

Sent from a Miniature Mobile Computing Unit

On 16 Jun 2012, at 14:40, Alfredo Aguirre
<reply@reply.github.com>
wrote:

>> @@ -0,0 +1,23 @@
>> +from django.core.cache import cache
>> +from django.http import HttpResponseBadRequest, HttpResponseForbidden
>> +import hashlib
>> +
>> +def throttle_view(func, methods=None, duration=15):
>> +    """If I was a better programmer, I would get this to work with passed arguments,
>> +    however - it's just not in the cards tonight. hence ...
>> +    TODO: make this thing actually take arguments
>> +    """
>> +    def inner(request, *args, **kwargs):
>> +        throttled_methods = methods if methods else ['POST', 'GET']
>
> In python mutable parameters are modified in place. It is saner to set them after, more about this: http://effbot.org/zone/default-values.htm
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/webpagemaker/pull/434/files#r997836
Very basic remark : can you prefix non-private functions (used in other .c files than this one) with a "_9p_" string. For example this function will become "_9p_AddFlushHook". This "layered naming" policy usually helps debugging a lot.
The refactoring in #2076 means that the guide could just be changed to reference `require_refinery_users!`.  Overriding that to return false results in clearly intention-revealing code without the need for a configuration that won't be used in the majority of cases.
单位为秒，精度毫秒

没有“完成日志写入”的意思，只是提到了写日志。
I ardently agree with you and disagree (for the nth time) with how the thoughtbot team went about this.
Why does this have vars?
Passing a instance variable to a method?
blank lines before and after

```
.. note::
    This can ...
```
Lets break this into a few lines like:

DATA = [
            {..},
            {..},
    ]
please add extra line
typo : s/origine/origin/
Oh, I see. Shouldn't the wrapped controller object be created when the map view is built and then simply returned in `getMapController()`? We would have the best of both worlds then.
Remove printf or make it a Logger message
the QUERY_STRING is always a string, so doing "".split('&') will just return an empty array
Why remove version? Makes the build predictable :)
for sure it's hilarious code :)
I's more light. You said that in your talk at Symfony Live Paris ;)
It is better not to use the `var_dump` in the controller. In this example `var_dump` function will show the contents of the $blob->output() if $blob is an object, otherwise you see Fatal error.
This is sucky. The hunks should retain the delta until they're disposed.
Interesting note: we actually don't have all the information here. a `GTDiffFile` has absolutely no idea to which repository it belongs.
A for loop would be fine too.  We were just trying to keep with the original style.
why delete? Leave this as information for someone who might need to understand why this is the way it is in the future :)
Because the launch now takes care of switching to the app frame.
Хотел написать что в диалектах у нас подобных вещей нету... Но вообще у нас там сборная солянка :)
Как именно вынесети? Создать три метода типа quoteSavepointBegin, quoteSavepointRelease и quoteSavepointRollback ?
Can't you use a foreach loop here?
integer? and float? don't respect the differences between long, short and int, or double and float. If in our code we take the trouble to create values of specific types, shouldn't that be respected?

Seems like here everything would be cast either to ints or doubles. If anything I might guess casting to longs and doubles, but I'd still rather have specific type choices respected.
Ah, gotcha. Maybe just put the "note" section in its own paragraph. It's easier to parse quickly if the main focus on the doc is isolated.
Why can't we roll some ec2 instances to compute the sizes of all of the gems on s3 and create a file of sizes and then use that to import on the main gemcutter instances?  This way, i/o to AWS is free for all of the EC2 operations and we can leave it running somewhere without worrying about site performance?
@bp323: The templates are not brought in here.
Hi,

That h2 is there because you are looking at other people's library, etc.  - in those cases the name of the other user is an h1.
@dooremont These properties should be removed as well, since they are the same in the default.properties
Why is there no column headers?
when doing casts, please have a space after the bracket )
From what I can tell, this does a call to the Oembed provider (through Oembed_Result->loadData()) whenever the page is accessed. That's really not a good default, for one because it couples execution to a potentially unreliable external service, but also adds significant loading delays.
Its even worse when you've got autodiscovery enabled, which is another HTTP call. 

So if you list four of your favourite youtube clips in a blog entry, that'd be up to EIGHT external HTTP requests.
Assuming they're fast and each of them only takes half a second, that's still a significant delay.

We need some form of caching here, ideally on a HTTP level respecting the cache headers.
http://stackoverflow.com/questions/3314635/what-are-best-practices-in-dealing-with-oembed-regarding-storing-and-caching-res
Sure, you can partially or statically cache the page content, but I don't think thats a feasible scenario
given how broadly we expect OEmbed to be used.
No problem. That was the easy part. ;)
Yeah that makes total sense.

Sent from my iPhone

On Sep 17, 2012, at 2:01 PM, Jordan West <notifications@github.com> wrote:

In servlet/src/main/scala/scalamachine/servlet/ServletWebmachine.scala:

> +    val uri = new URI(req.getRequestURL.toString)
> +    ReqRespData(
> +      method = HTTPMethod.fromString(req.getMethod),
> +      pathParts = path(uri),
> +      rawPath = req.getRequestURI,
> +      hostParts = host(uri.getHost),
> +      baseUri = "%s://%s".format(req.getScheme, uri.getHost),
> +      query = queryString(uri),
> +      requestBody = requestBody(req.getInputStream),
> +      requestHeaders = requestHeaders(req)
> +    )
> +  }
> +
> +  override def fromData(data: ReqRespData): ReqRespData = data
> +
> +  private def requestHeaders(req: HttpServletRequest): Map[HTTPHeader, String] = {

yea its a known deficiency. My hesitation to add it is I don't like the
type Map[HTTPHeader, List[String]] because the common case is "SomeValue"
:: Nil which usually adds more verbosity to implementing code. Long term
this will be something like Map[HTTPHeader, QueryParam] where query param
abstracts that ugliness away.

—
Reply to this email directly or view it on
GitHub<https://github.com/stackmob/scalamachine/pull/10/files#r1623117>.
Having a CSS selector in the module itself feels fragile. I'd prefer to see this passed in as an argument, but I'm probably being paranoid.
On Thu, May 17, 2012 at 8:27 AM, Michael Cahill <
reply@reply.github.com
> wrote:

> > +     WT_HAZARD *hp;
> > +     WT_SESSION_IMPL *t;
> > +     uint32_t i, session_cnt;
> > +
> > +     conn = S2C(session);
> > +
> > +     /*
> > +      * No lock is required because the session array is fixed in size,
> but
> > +      * it may contain NULL entries.  We must review any active session
> that
> > +      * might contain a hazard reference so insert a barrier before
> reading
> > +      * the session count.  That way, no matter what sessions come or
> go,
> > +      * we'll check the slots for all of the sessions that could have
> been
> > +      * active when we started our check.
> > +      */
> > +     WT_ORDERED_READ(session_cnt, conn->session_cnt);
> > +     for (i = 0; i < session_cnt; ++i) {
>
> I am concerned about how this loop interacts with the session close code.
>
> Let's say we have 10 sessions open and session 3 is closed.  At the same
> time, some other thread doing a hazard check has read session_cnt == 10,
> and i == 5.
>
> To close session 3, we swap session slot 9 into position 3, then NULL out
> slot 9.  By the time i == 9 in the hazard check code, we see a NULL there.
>  We never checked session 9's hazard pointers.
>
> Is there some reason why this can't happen?
>

No, good catch, I think it can happen.

I forget, why are we packing sessions to the bottom of the array as we
create them?   Is that really useful anymore?   We run through the list of
sessions during session open, close, eviction sync requests, and hazard
reference checks.

What if we quit packing sessions at the bottom of the array?  That is, we
use the first NULL slot we find for each session we create rather than copy
the last session reference down, which should give us reasonable packing.
Session close would decrement session_cnt to the last active slot.

Eviction and hazard ref tests for whether or not a session is active is
pretty cheap now (NULL or !NULL), so I don't think this will matter.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
Hum... Does it really make sense to use a <br> here?
Are you sure ``$cat2`` has the correct type as "object<Symfony\Component\Translation\MessageCatalogue>" is not a sub-type of "object<Symfony\Component\Translation\MessageCatalogueInterface>"?
Are you sure ``new \stdClass()`` has the correct type as ``object<stdClass>`` is not a sub-type of ``object<Zend\Uri\Uri>``?
Are you sure the method ``getConfig`` can be called on ``$this->getParent()`` (of type ``null|object<Symfony\Component\Form\FormInterface>``)?
这里只替换了一次空格。多个空格没有完全替换。replace(/\s+/g, '')
It's been a while since I correct this and I think I've tried your solution first but it didn't work. I'm not sure through...
"will" -> "would"
We should use top-level query here, yes?
Thanks, I'll update this in a bit. I'm not as familiar with defer and async as I should be. If jQuery gets loaded with async, will my jQuery.noConflict() snippet afterwards wait until jQuery is loaded before executing?
no empty lines afters ifs and defs everywhere in this file pls
Why not use `pop` instead? Again, name variable the same.
So `attr` here.
I don't know what's up with object, but it's always None ;)
Please order field similar to how they are in Facebook backend.
OK, you ask user what to do.
> That was main reason why i asked if we really wanted to use mongoengine signal.

And I wanted that you argument why they might not be good. :-)

> So should i use django signals instead

Both MongoEngine and ours are Django signals. :-)

> because there were located in frontend/views.py

This is completely your decision where you decide to connect onto them. There is no reason why you did it in models.py! See, MongoEngine signals are nothing different to signals we do, they are just defined in MongoEngine and called there. Where you connect to them, this is your decision.

> most important part we had all the object needed

This is the most important part. It allows us to same serialization as we are using for REST protocol.
Maybe some Windows trick?
Python standard modules go to the top.
yes needs to be cleaned up
I've checked a few pages (challenges, courses and study groups) and they
were looking good. But if that style has a wider use, I agree, we should
keep it.

On Mon, Feb 20, 2012 at 5:20 PM, Zuzel Vera <
reply@reply.github.com
> wrote:

> > @@ -1510,7 +1510,7 @@ header {}
> >    width: 652px;
> >    float: left;
> >    background-color: white;
> > -  padding: 15px;
> > +  padding: 16px;
>
> #main is used all over the site so I will avoid to change its css if
> possible (unless you check that it looks good on the other pages.)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/p2pu/lernanta/pull/95/files#r468000
>



-- 
Cumprimentos,
Ricardo Soares
This is exactly why everything is done on its own page now. We haven't figured out the logistics of making it do stuff on the same page. Personally, I think it is better to give it its own page for this release and work on same-page implementations when we have more time in the next release.

My guess is what we'll have to do is add logic to dashboard to see if there's a form and then pop up the window with the form. Either that or manually put the form into an Ajax request and send it off.
ya, that all makes sense...
these lines aren't needed at all, as you never do any changes to the size of the rect in-between this and line 105
why would it be a dev requirement ? This would mean the profiler is broken for everyone (with a Fatal error).

``require-dev`` lists packages needed to develop DoctrineBundle, i.e. to run the testsuite.
@superdweebie yes, I understand :) But heh, I'm not here to approve everything :P Anyway, if you really WANT that feature, do it in your own module. If it turns out that community wants it and it has correct use cases, we could think of adding it later. For now my personal vote is -1. Maybe the rest of the team thinks differently. You may ask on #zftalk.2 as I said ;)
Instead of regex shenanigans, what about patching out uuid.uuid4() and returning a predictable value?
I don't really see the distinction in terms of determining the namespace. 

All of the identifiers come from Wikipedia's, and we typically given namespaces based on the original source, not the republisher. DBpedia has been a special case here, although I don't see why. I refer to Wikipedia and not "DBpedia" in discussions about wikipedia content in the semantic web, even if the URIs currently go through the DBpedia third-party. 

In terms of longevity of namespace identifiers, I would prefer that we used "wikipedia" to avoid having to change our mind later on if there is either another rdfisation of wikipedia that we also want to use, or dbpedia drops away after wikipedia starts publishing RDF itself.
same as `$prop`
Or get rid of the `.concat( /* ... */ )` and shove the test and its `:[]`fallback directly in the array
Checked, there is background-position and background-size set inline, that's why this needs to be a background-image and therefor a gradient. Maybe the name is a bit too generic, but this is correct. I have nox fixed the degree value, but that's just for consistency, it of course doesn't make a difference.
cool, makes sense
"Dissipar" is also a good choice in portuguese but it gives the idea destruing the object.

I think "Desvanecer"  is the right choice, thank you. I will look in the ES locale for inspiration for now on =)

By the way, how do I change it know? Just edit it on my fork and make another pull request? Can I wait for when I have more lines reviewed?
Yes Joerg, you're totally right!  I've fixed that and will push...
Just a comment.  As I've been scanning these (and other recent) changes, I want to say that this style of parameter listing is very nice.  Much easier to read than when the variable name is embedded in the paragraph.
name and transform seem to be missing from the [last set of docs](https://github.com/SciTools/scitools.org.uk/blob/8926aa43e6a0281cba82950f8155c5ad92baed83/iris/docs/v1.0/iris/iris/fileformats/rules.html#L231)
He Aled,

I have auto imports on. So the field was imported, but not used. 

I have cleaned up the empty imports.
agree, fixed
This step definition is making assumptions about what items are in the database at the time the step is called.  

How do we know whether or not there are any activities matching the term "lines"?  Why is "lines" hard-coded into the step definition?

I would suggest that this 'step definition' is actually a feature test...
Harder to read? If I ask you, in conversation, "has `inner` changed?", would you respond with `false` or `no`? Almost everywhere we use `true`/`false` in other languages, `yes`/`no` is more appropriate. There were one or two instances where I did not make the change in your code base, and that's because `true`/`false` was the better response. I don't care about precedent, this makes the code read more naturally.
you are missing `this.query` here. Also I would prefer checking

```js
if (this.params.hasOwnProperty(name[0])) {
...
```
Feels weird to be explicitly checking the types rather then cast it to boolean.. Now for example we explicitly disallow the string "1".. Although technically incorrect there isn't any reason why we shouldn't allow it and follow the general PHP type juggling
So it seems :) my bad.
Fixed. You're not confused.
в тебе phpcs матюкався на файли тестів? їх можна скіпнути і не морочити голову. глянь хелп по команді
This passes tests and is more clear.
I mentioned this in the spec doc and I still don't have a good alternative but I don't think we can get away with hardcoding deployment details such as the path in versioned code. As an example I serve montage out of /montage on my machine so this example does not work.
You removed the osops-utils depends from metadata.rb, which has the get_settings_by_role routine. You need to change the above to:

```ruby
rabbit_info = config_by_role rabbit_server_role, "queue"
```
Links to `error_reporting()` and `display_errors = off`?
This is the standard Objective-C initializer style:

```objective-c
if (self = [super init]) {
    ...
}

return self;
```

But for gfxCardStatus I actually prefer WebKit-style initializers. e.g. early returns so that there's minimal nesting. Like so:

```objective-c
if (!(self = [super init]))
    return nil;

// initialization stuff ...

return self;
```
А, finnaly выполняется даже если в catch System.exit(1)? Если, да то видимо по незнанию.
Arrays.sort допускает null в качестве компаратора.
что значит экранировать? Разве просто вывод строки не является её экранированием?
В catch ты перезаворачиваешь это в исключение в другое FormatterException
Is this line OK?
I think it should be "to JBoss Enterprise Application Platform or JBoss AS 7."
might want to name this something like max_songs_spin_box
We should have triple double quotes here (" " ")
http://www.python.org/dev/peps/pep-0008/#documentation-strings
拝承。
i'm pretty sure i've said it before, but if you're using an ifdef, then you don't need to check in commented out code.
These changes are a hang up from last change. They're already in the existing plugin.
Do you remember on IRC - when I asked you to make an event for '10pm on Friday -- do the shopping' and it made it at something like 3am for you, since it was GMT.

The only commit that is different here is 40ae47b030023b1685eaed03e7d4fc8110868e01

Sorry for the confusion
I agree, the possibility of speed improvements with my implementation is a bit unlikely. My main rationale was readability, but that's a bit subjective.

Do you have a strategy for dealing with equal-valued  (but unconnected) maxima in the same neighborhood? Maybe you could use the center-of-mass calculation, and then iterate over coordinates based on the size of the labeled region (thus, choosing broader peaks). If there are two peaks of equal size and equal value in the same neighborhood, I have no idea what to do.
nothing - that's a copy-paste error - i've removed it.

A previous version used ``apply_tree`` and ``np.take`` to implement ``Tree.predict``, however, I noticed that ``np.take`` added some overhead that was significant when you perform predictions on single data points. 

PS: I've recently deployed a gradient boosting classifier in an application that needs to make predictions on single data points - it turns out that prediction times for some sklearn models (e.g. random forest, gradient boosting) are basically the same for predicting single data points or mini-batches (say 100 data points).
I think that I would prefer this variable to be named 'regularization'. What do people think?
aaaahhh ! why computing the same computationally demanding dot(X.T, y) twice ?
Also would it be possible to warm restart an AdaBoost model with a new (larger) value of `n_estimators`?
On Wed, Oct 3, 2012 at 6:31 AM, Andreas Mueller <notifications@github.com>wrote:

> This is not really what you want. You want the probability to increase and
> you can't compute the partition function usually.
> We could do an example with ~5 hidden units and test that. That would
> actually a good test.
>
> But: (P)CD learning doesn't guarantee increasing the probability of the
> data set and may diverge.
>
Well, PCD does, at least asymptotically, as long as you use an
appropriately decaying learning rate.  But asymptotic behaviour is kind of
hard to test.
sorry, I forgot to remove that when I refactored my code.
The exception should be fully qualified - eq. `lang.IllegalArgumentException`.
That's correct, if you look at the 2.0 docs, `textAlign: 'center'` is not in the example anymore and the param desc for textAlign is: 
```
LabeltextAlign : String/Number
Text alignment. One of Titanium.UI text alignment constants, TEXT_ALIGNMENT_LEFT, TEXT_ALIGNMENT_CENTER, or TEXT_ALIGNMENT_RIGHT.
```
No problem at all! it's much easier to read a series of clean and concise concepts than a big blob of unstructured text. Just pointing out in some cases it goes a bit too far. But by all means, keep your style brief and to the point that's generally a good thing in technical docs.
Thanks!
If you are adding unsigned/size information about some types then you should add it to add types that it is applicable to.  If this is a work in  progress then it is fine not to output all the information about a type, but you should output a consistent set of information for each type.
I assume this is just for testing.
Would be clearer as a for loop

    for (i=0; i < maxRows; i++)
Using the existing IMultiException::errorMessage - would have been the safest and easiest option then.
another example that does occur in the diff.
<b>Duplicate names</b>
Most implementations only support having one property with a given name in a section. The second occurrence of a property name may cause an abort; the second occurrence may be ignored (and the value discarded); the second occurrence may override the first occurrence (discard the first value). Some programs use duplicate property names to implement multi-valued properties.
Interpretation of multiple section declarations with the same name also varies. In some implementations, duplicate sections simply merge their properties together, as if they occurred contiguously. Others may abort, or ignore some aspect of the INI file.

From <a href="http://en.wikipedia.org/wiki/INI_file">wikipedia</a>

В таких случаях я считаю привязываться к конкретной реализации читалки конфигов неудачной идеей. В любой момент реализация может изменится. И будет потрачено куча времени на выявление проблемы, которую можно было бы предотвратить.
No need for brackets here
Hi Rafael,

I'sorry, i just realized that my fix has a border effect on contents that
are not files or images : we don't see title + description anymore

I have to change of strategy : title + description has to be removed from
version_file_view and version_image_view, not from main history view

sorry for the mess and thanks you see my mistake immediately. i shouldn't
have merged so quickly

On Wed, Aug 8, 2012 at 9:48 PM, Rafael Oliveira <notifications@github.com>wrote:

> In Products/CMFEditions/skins/CMFEditions/versions_history_form.pt:
>
> >          <div class="documentDescription" tal:content="vdata/object/Description"></div>
> > +        -->
>
> Well, this change is still in effect in the master branch. Could you
> please revert it ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/plone/Products.CMFEditions/pull/6/files#r1336075>.
>
>



-- 
Thomas Desvenain

Téléphone : 09 51 37 35 18
typo sent -> send
I also think that a nicer solution would be to provide your own class that returns the custom AMQP message, but I'm not sure if that doesn't just over complicate things
I did with `not` because it was hard to read with the lines break, use the constant on top will make it more readable in the "positive" way, I agree.
FYI, looks like a whitespace glitch here. No need to block the merge.
Can you give an example of what this funny formatting is, and what you fix it to? Hard to tell without context.
Should this be in a separate JS file for clarity?
there is no other usage of this interface so far. I will check this.
ugh not even sure if I'm using module.value() correctly
Hmm, so this line actually doesn't work for me.  Instead of "\u0001", my data uses "\a":

	["testuser@10.0.1.6\a\a\a\a\a\a\amypassword"]

I propose the following fix (please test):

	user, pass = credentials.scan(/[[:print:]]+/)
Can MSF_LICENSE be used? If you agree, could change it please :)
Same question as above for this line.
Syntax error: Missing a ")"
I had wondered about that.  Will do.
great docs!
This was most likely the eclipse formatter.
Awesome, I had no idea.  Thanks.
Aren't these in the feed? It is used for scoring.
Can this wording be re-worked?  For a cross platform mechanism, I don't care for the strong association with between the Titanium API's and iOS API's as any future changes we make will cause them to be compared specifically to how native iOS works rather than their value or role within Titanium.  I think avoiding this kind of association will make life easier in the future as this mechanism evolves.
Can we just put the implementation of addArray() here instead of calling another local function?
No, I was thinking of something like:

```
typedef ImageData ApplyFilter(List<num> mask);

void toggleFilter(String id, ApplyFilter applyFilter, List<num> mask) {
  if (query('#$id').classes.contains('filtered')) {
    restoreContent(id);
  } else {
    ImageData pixels = applyFilter(mask);
    filterImage(id, pixels);
  }
}

query('[name = "brightness"]').on.click.add(
    (e) => toggleFilter('brightness', new Filters(img).brightness, brightAdj));
query('[name = "sharpen"]').on.click.add(
    (e) => toggleFilter('sharpen', new Filters(img).convolve, sharpenMask));
...
```

But in writing that out I see that it would instantiate a new Filters object on every click, even though it's only necessary in the "else" case, so this may not be the best solution. Or at least would take a bit more refactoring to get this right.
I'm going to just leave this.
Needed to use Sass 3.2 because the responsive stuff blew up otherwise.
`$( "form" ).find( "input, select, .texturePicker" )` ?
Which files exactly are you looking at? Comparing ui/jquery-ui.js and ui/minified/jquery-ui.min.js, the banner is same.
Can this just use the cmxform.css?
you have removed the line number but that is explicitly added for correct generation; if this included in the 'getAttributes' call that you added?
set to None
Ah, sorry, forgot that you added a constraint on it.
`drop` works on an input range, so if you want to avoid it having to call `save` on the original when passing it in, we'd have to make it take a forward range. And making `dropBack` `save` without changing `drop` would make them inconsistent. It's true that in many cases, you'd want to call `save` when passing a range to `drop` or `dropBack`, but it's also useful with plain input ranges, because the primary benefit of `drop` over `popFrontN` is that you can use it in function chaining. That being said, the lack of an automatic `save` call in `drop` and `dropBack` combined with the fact that most ranges aren't reference types means that they're likely to be misused with reference types quite a bit, but that's also frequently what happens with them as so few ranges are reference types and are so and often forgotten.
does it actually fail when built in parallel? have you seen if fail?
docstring should be something like (more or less standard)

```
 EasyBuild support for building and installing Java, implemented as an easyblock
```
Don't capitalize Send Tabs.
Careful. You can also throw a `ClassCastException` in `getString`, and a `NullPointerException` by calling `intValue` on the result of `getIntegerSafely`.

I'd be inclined to wrap this whole thing:

```
try {
  …
} catch (Exception e) {
  throw new IllegalArgumentException(…);  // Rethrow with cause.
}
```

or a suitable "bad JSON" input. Sure beats having a random NPE if you get a missing version!
ops! thanks, fixed!
It could be good to add a comment here (or maybe in INSTALL document) about ghostscript dependency.
And removing ImageMagick requirements if not needed anymore.
OK, I'll edit it.
We can replace these two lines by: `users.any?`
why do we throw NotImplemented exception at the end of a method?
Extra `'`
You're still passing in $childList :smile:
Variable-ized copyright font-size.
Nope. Adding a new variable.
That method  (test_init) can go away, just my starter point for a test case, it's pretty much redundant with the other tests.
Doesn't seem like this will do what you except, while `this.extractMetaInfo` might
Actually - shouldn't this happen in LLVM itself as part of the patching? This way any llvm application can work without changes (to the source).
Ah, I see, all must be fully populated for use below.
@croby: Yes, each htmlblock widget saves independently, but only when it has changes. These saves don't generate versions, they just store data in the temporary page object. The only save that generates a version is a full page save.
move the invocation of this function inside the parens
Sorry, it was meant to be: "Overriding strategy to be..." - I'll reword it
Nope this breaks it. Check and see for yourself.
please document your hard earned knowledge! :^)
This will never be executed - impossible to have messageOrPayload instanceof Map with null expression here.
We won't want the @Transactional annotation  here (and in this class for all the methods) as the we have the transactional sub element to take care of the transactions. In fact i am not sure what the behavior would be if annotations are configured to use a different transaction manager
what is this stdlib class? what is it for?
Figured this part out after I spoke with you, and it was for something else I was thinking of. Has nothing to do with what this commit should have been. Should not be in there for this pull request.
Uh. Yes exactly.
Nice one, thanks. I'll merge this in now.

I'm still on 10.7 (can't bring myself to upgrade). Does it still work on 10.8?
Technically this violates XPCOM semantics, but that's OK.  This style is better.
another note.
Yes thats right, the reason i have array.array.length / stride is to get the real count of the data based from reading the float_array and dividing by the xml parameter stride rather than from using the xml parameter "count" as it can be incorrect in some blender exports.

If you look at my xml in the first post the count data for both the accessor and float_array in that export is incorrect, so this attempts to calculate what it should be.

Does that make sense?

Perhaps this is a bad approach? or shouldn't be considered because its the blender export at fault?

Either way this workaround worked for me. Here try this http://davidejones.com/labs/mar_1b.dae and try parse it, it fails because of the data at 2368 doesn't match up.
the only really important thing about a pull request is the ability to comment line-by-line on the "code".
Small indentation issue.
这种调试代码能让你很爽，但别留下来
Should we not dictate length? I imagine -- `length = 1` could be unhelpful... Perhaps a `min_length` on the integer field?
I suggest renaming this namespace to `clj-oauth2.ring`, what do you think?
If something is a "buzz word", does it lose its meaning?

Responsive web design (often abbreviated to RWD) is an approach to web design in which a site is crafted to provide an optimal viewing experience—easy reading and navigation with a minimum of resizing, panning, and scrolling—across a wide range of devices (from desktop computer monitors to mobile phones).

Specific enough?
for formatting in this method is making ti really hard to understand what is going on.
test for < 0 won't work very well with an unsigned variable
A Start/Stop sequence could be called multiple times during the DeployableContainer instances lifecycle. 

Start -> Stop - > Start -> Stop is legal. (no setup inbetween)
In irb, ENV['foo'] returns nil and does not raise a NameError. Wouldn't the same happen here?
this line looks like it's indented wrong
Currently we don't actually support a list value for a property, but we do support strings and you could easily just separate entries by comma in the property value, and call `split` in the python script
instead of "eventListener on the JS side", we might say "a javascript event listener"
Setting the value in the constructor will not work.
use real fields pls
please use `wp_redirect()`
this should point to ``liip/monitor``
I think It is ok if you want to give the copyright completely to us. But you could go ahead and add yours, I think the layers would be happier with that.

In any case the year should be changed to whenever the file was created.
Should also check that the file exists before using session.barxml
Should this be a static function within the BBM class?
Its the flag to treat this item like a "delete" action. Ie it is absolute positioned in the bottom
What is this ready?
(clean up)
Not sure if this last line fits here. I agree but it feels out of place.
Way too many asserts in one test case.  Let's break these up more