labofsahil/github-event-dataset-2012 huggingface dataset:
The descriptions don't indicate either units or why there are two values separated by a colon. Need to tell people what they are looking at here.
My bad, I didn't know about autolink.c being language-agnostic. Also: Are the `ctype.h` versions of `isalpha` etc sufficient for UTF-8 input?
I don't really like this.  that's not what bang means to me.
Note that the logic here is that setting_cards_by_group returns all the groups, even the ones that are specific to a type (i.e. :pointer_group), and they are filtered again at render time.
test current behavior :)
cosmetic: no need for the { and }
This stuff seems really hacky, though I don't have a better suggestion atm, given that the paths are changing all the time.
Are these deletions needed? It shouldn't have negative impact on test.
逗号后面要有空格，其他地方也一样
As above, no alias.
At this point in time, that was the least invasive solution.

The other options were:
1. Make all creation strategies have an ''accepted'' method: That is silly
as it is only relevant to this creation strategy.
2. Make a new DEIterationStrategy which has that extra line: That is silly
as it is a lot of code duplication.

It will however change when the next part of the paper is added as a new
DEIterationStrategy that updates the required parameters needs to be
created.


On Wed, Aug 29, 2012 at 7:27 AM, Gary Pamparà <notifications@github.com>wrote:

> In
> library/src/main/java/net/sourceforge/cilib/ec/iterationstrategies/DifferentialEvolutionIterationStrategy.java:
>
> >              if (offspringEntity.getFitness().compareTo(current.getFitness()) > 0) { // the trial vector is better than the parent
> >                  topology.set(i, offspringEntity); // Replace the parent with the offspring individual
> > +                acceptedOffspring = true;
> > +            }
> > +
> > +            //If an SaDECreationStrategy is being used it must be informed of whether the offspring was accepted or not.
> > +            if(trialVectorCreationStrategy instanceof SaDECreationStrategy) {
> > +                SaDECreationStrategy creationStrategy = (SaDECreationStrategy) trialVectorCreationStrategy;
> > +                creationStrategy.accepted(acceptedOffspring);
> >              }
>
> There has to be a better way of doing this. I'm really not a fan of
> instanceof checks as they cause the code to be worse. The same goes for
> boolean flags.
>
> There must be a better way of doing this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cilib/cilib/pull/67/files#r1482413>.
>
>



-- 
Regards,
Kristina Georgieva
MSc Computer Science
CILib Research Assistant
It took me a while to grok the flow of this function because of these multiple return points. There's nothing at all wrong with what you've done here, I just struggle to read functions with more than one return statement, so I thought I'd point it out. Some folks (opinionated folks on the interweb) have argued that the more readable way to do this is with a single return statement at the end of a broader if else loop. Here's one of those people : http://www.fredosaurus.com/notes-cpp/functions/return.html , for reference.
It should be documented.  You can define an empty attribute at class-level e.g.:

```python
#: (:class:`Metadata`) The metadata mapping of the image.  Read only.
metadata = None
```

Anyway how does it works well, even though there is no `'metadata'` in the `__slots__` list?
shouldn't this be `for (key in timer_data)` and `if (timer_data[key].length > 0)`?
Moving this into a separate function doesn't appear to be part of making the backends configurable. Can this be its own PR?
The call duplication here don't seem sensible
This should depend on whether the image can be saved. Otherwise, it shouldn't prevent things like window dragging.
Alright, I'll move them then.
Why #TODO?
Looks like the dummy function trick doesn't help with the indents, they are still there. The help function must do some formatting.
I think you meant to comment down below around line 721. Here "n" is always a string literal.

BTW - there are some duplicates and unused declarations in the peg. After this round of changes, I will go over them and clean them up.
http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions

Indent after private/protected.

Is this statement wrong?
Francis, the symbol vs string thing is not consistently applied in the Rails framework or code base. There are many cases where symbols are accepted in place of strings. In fact, the docs for the #column method include both symbols and strings for the name in the examples. As I mentioned, the schema.rb file is generated to use strings. But this line here was not an attempt by me to infiltrate or influence the Rails code conventions - I was just making things more readable. And I do think it's more readable to have the name as a string while the types and option names are symbols - it's much easier to scan and see what it is that makes that line special. I've never understood the allure of using a symbol in place of a string just to save a single character, when there is absolutely no use of the symbol as a symbol inside the code. If you look at the implementation of the #column method in schema_definitions.rb, literally the first thing it does is coerce the name (1st arg, which you say should be a symbol) to a string, then the type (2nd arg) to a symbol. That's about as close to type hinting as we get in Ruby, and I am following what that code explicitly says. I have no idea how you get from `name.to_s to` symbols being idiomatic. Symbols are names of objects in code, not as data. If you are never comparing the symbol to another symbol, it should generally be a string. </rant> If someother time you want help making string vs symbol consistent in the framework, I'm happy to take part in that.
I think the mutex is fine. We did some changes like this recently. See 0d7b0f01
@rafaelfranca fixed
I think we don't need this `rescue` here.
Well, we always mean to return `nil` when nothing else is returned :). It's fine in any case.
In <code>setup</code> there is new in-memory sqlite3 database created before each test so created tables are not visible to other tests:
https://github.com/rails/rails/blob/master/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb#L14

I followed the convention in <code>sqlite3_adapter_test.rb</code>. There are many other tables created in similar fashion there and not dropped afterwards. For example, that is the other test for default value:
https://github.com/rails/rails/blob/master/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb#L263
I understand why you're torn about this, but this makes it feel complete. One gets a better understanding of what DDL changes are possible with migrations. At the very least, please retain a link to the relevant API documentation.
It would be great to not only have a macro like that, but for pure self-contained tree transformations like that one, a nice reusable library (for which the macro is a thin wrapper around one method.)
Oh wait, we're trying to prohibit these: "A class or trait C is ephemeral if the following holds: ... C may not have initialization statements". 

I blame it on the hour...
getTypeMember seem like a small change but it's a huge improvement.
This is for @phaller -- hoping he'll chime in. (Will ping him).
Do you remeber why this change was made?
There's a typo in this comment (I can't tell what it's supposed to say).
Sure, but why not submit it as a PR?
`opts_template$set(myfigures = list(fig.height = 4, fig. width = 4))` is enough; the first `list()` is unnecessary
Should not be required to include the class.
`can now` → `now can`
OK, I see that ````self```` doesn't work inside that block (from ernie's docs), but I think the ````my{}```` would be nicer.

    Person.where{name == my{some_method_to_return_a_name}}

like

    .where{question_id == my{question_id}}
It looks like you are overriding the method and then doing the same thing the base method does.  In that case, there's no reason to override it, just have the default instance and use that.
I'll try to reword.
Il faudrait renommer cette classe. C'est pas bon de changer tout d'un coup le style de Bootstrap comme ca. Ca va te jouer des tours et ca complique pour rien tout le reste de ton css.
At what point does the data in $FILES get htmlspecialchars applied to it?

Also, please add a test where the input to e.g. file name has e.g. < in it, and test that it is correctly html-escaped on the phpbb side.
There are various other instances in this diff for which the same applies.
Do not use multiple return doc tags. You should instead use @return array|null and then explain in the description which is returned in which case.
I believe that the correct grammar, probably in all cases used in phpBB, would be to have the punctuation inside of the quotes.
I'm pretty sure there is an Array#push in javascript.
Is this duplicating the core.display_forums_row_inject just above in any way?
Not sure what's happening here, but there should only be three additions.
bantu, I think, asked for an explicit list of files to be removed. He may have meant it for some other issue that no longer exists now. A subdirectory sounds reasonable though.
Use $this->config->set()
I haven't actually reviewed in detail, but my feeling tells me this is almost a 1:1 copy if the variable() method.  If that is the case, please apply some "do not repeat yourself". Otherwise please explain why this method is so big.
This is not going to match tab-space-tab I don't think.
I wanted to use :split to flip / to \ but using path builtins is probably better.
Can you have an absolute path in windows that doesn't have a drive?
less ugly?
Discussed verbally. Please don't mix classes an structures, they have different purpose.
Alternative:  

> "Basic" \`S8.isPrefixOf\` authStr
It's a habit that will die hard, but when in Rome... I'll change it up!
yap, right on the money. :P

Cumps
--
*Fábio Silva*

*http://www.shipsoncamera.com <http://goog_1728611982/>*




No dia 12 de Novembro de 2012 19:00, João Vieira
<notifications@github.com>escreveu:

> In single.php:
>
> > @@ -15,7 +15,8 @@
> >  <hr />
> >  <section id="comments">
> >  <h3>Comments</h3>
> > -<?php foreach (get_comments('post_id=' . get_the_ID()) as $comment): ?>
> > +<?php foreach (get_comments('post_id=' . get_the_ID()) as $comment):
> > +	if($comment->comment_approved == 1): ?>
>
> Tu aqui estás a verificar que o comentário foi aprovado antes de o
> mostrar. Pelo que entendi, o comentário estava a ser mostrado sem ter sido
> aprovado mas na contagem de comentários no index só estava a contar os
> aprovados daí a diferença?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/vieira/booty/pull/2/files#r2100975>.
>
>
ok, I'll change the method name to getYUIInstance()
don't give a unnecessary  blank line in between...
ok, I change it to servint again..
also, is this UUID server specific? I'm not yet familiar with how this is handled on back-end and if it's ok to hard-core a UUID like this, but on front-end it's a problem because UUID's are different depending on the OpenMRS server.
You should get the lock on the compilation directory. Otherwise you may have some failures due to competing jobs.
Typos: raises / contains
access_term_cache is the function that actually calls Op.grad. This pull request upgrades it to do a lot of type checking to make sure that all of the ops have a sensible interpretation of what their gradient is.
like -Dfunky.quotes="hello \\\"my back slash \\*\\* quoted \\\" darling?"
Not imported in this module. This is a convention in the entirety of this plugin.
get() returns None by default. You don't need to pass the ``None`` parameter. Same goes for the other lines above.
<pre>
for x in [a, b]:
   if x == a:
     ...
   if x ==  b:
     ...
</pre>

This pattern makes no sense. Why use a for loop?
This should be a `ThirdParty` path, not an absolute path to `C:/Users/Jeremy Landis/...`.
Yes, I agree. Will fix.
Put `JavaScript` after the triple quotes and it will syntax highlight it for you.
Since the test is a bit weird, should the issue been mentioned in a comment / test message?
To be honest, there is no any good reason. I do for this because I generated most of the code by script from configuration file with the input list below:
chi_squared 			;	chi_squared_distribution			 ;    c#0                 ;	df>@<df > 0	

Renaming to chi_squared_CDF makes it more simple to process by script. 

So if this is not a serious problem, I want to keep this name convention. 

Almost 95 percent of the codes are the same for different distributions.
This code doesn't work in case the facebook package was added before accounts-ui. Don't worry about fixing this -- I'm redo'ing the login service listing to iterate over the Meteor.loginWith{ServiceName} methods instead, which I believe won't have the problem because all javascript must have been loaded before any template helpers are called.

I think the next step (outside this PR) would be to eliminate all of the boilerplate code in files like facebook_client.js. It could be pretty easy to create a function in accounts-base/accounts_client.js named, say, `Accounts.registerLoginService` that does this...
This is probably done in many places in this project, but I'm gonna point out this one as it is the one I'm looking at right now.

> - Comparisons to singletons like None should always be done with 'is' or 'is not', never the equality operators.
http://www.python.org/dev/peps/pep-0008/

I've been digging for a few style guides and even though [this guy](http://stackoverflow.com/a/3965129) suggests:

    if not (label_form is None):

... I actually think that this is more readable:

    if label_form is not None:
Were you able to test this with the current version of clang? Does it work now?
It looks like the code that actually uses the `duration` in this call is all in https://github.com/pculture/miro/blob/master/tv/lib/frontends/widgets/videobox.py, in the `handle_play()` methods.  At least one of these, `ProgressSlider.handle_play`, will break if given 0: https://github.com/pculture/miro/blob/master/tv/lib/frontends/widgets/videobox.py#L343
No need for parentheses unless you're splitting the imports across multiple lines. Also, I'd prefer `from vumi import log` and then using `log.debug()` and `log.error()` so it's clearer that these are logging functions and not something else.
Might want to add "and errata" into the upload line. There are still more things to upload, but I think those are the two primary use cases.
should this be `self.mock_tracer.record.call_count`?
After talking to Daniel, I think something like this is more accurate::

    {
        "": {
            "lang": "en",
            "plural_forms": "nplurals=2; plural=(n != 1);",
            "domain": "messages"
        },
        "Sincerely,": [ null, "Cu stimă,"],
        "Send email": [ null, "Send email"],
        "msgid": [pl, sg, pl, pl2, pl3]
    }
nit: lowercase 's' for 'set' the word, or {@link Set}/{@code Set} for 'Set' the class.
Or, rather, should the ProductGroup validate all of its children as well? Or just itself?
There's also a problem if there's more parameters than fields, right?
another style nitpick: `if` isn't a function, so it should have a space after it. At least this is how the rest of our codebase is formatted, so we should continue with that style.
This is now used in `QuickOpen` and `FindInFiles` (sort of) other than here. Maybe it would be worth refactoring at some point...
Typo: "de" -> "the."  Also might be clearer to say "viewport" instead of "code."
Do you mean waiting for the following calls? I did try that and I still got error in getting the node. Besides, I want to make the following calls only after I save the changes in html document so that I can verify the unsaved css changes are applied on top of html changes.

liveDoc = LiveDevelopment.getLiveDocForPath(testPath + "/simple1.css");
liveDoc.getSourceFromBrowser().done(function (text)
I thought we used $.each here?
Yeah I'm going to undo this. I am not mixing more revisions stuff into this pr
Also good as in line1
Not sure if we'll group all calculator arguments together, in that case `**kwargs` is better.
Useless cast as well, ```Math.pow``` returns double.
No problem, we should also fix it in rugged_raw_read.
Shouldn't this technically then be named symToSAAssoc?
Besides, `children` only returns direct descendants (a.k.a. children) while `getElementsByTagName '*'` returns all descendants.
This is going to keep breaking.  We need a way to ask the server for the embed URL for a given project ID.  I had to change our URL structure in the S3 ticket.
One more space after `for`.
It's not. It gets placed in the code above when popcornOptions is created: https://github.com/mozilla/butter/pull/129/files#L3R221
Same comment as the one above, really.
Consider moving this outside of the route into it's own function so it can be re-used and isolated in the future.
I'm not sure that this trick is optimal but I thought something was better than nothing...
Whoa - that's a crazy trick - I'd love to see a patch for that...
see org.sonatype.nexus.proxy.utils.RepositoryStringUtils.getHumanizedNameString(Repository)
test *what* about redirect index page - try to describe behavior
you should be incrementing a different counter
Jako předchozí.
add_index(:custom_info, [:informable_type, :informable_id, :keyname, :value], :unique => true)

does not work. the db yells and says the name is too long. the limit is 63 characters.
I think there was a badly resolved merge conflict here.   Should be:

reposition_left: reposition_left
This is the old loop on each XDoc creation re-resetting the XmlResolver for every node
Yes, `format` used to be settable but that breaks immutability.  I should have just turned this into a decorator at the time, but I will now.
Can you change this link to http://docs.astropy.org ? That should be a more stable/easy to remember url (or devdocs.astropy.org if you want the latest *development* version).  You might also make it a hyperlink - e.g. ``See the `Astropy documentation <http://docs.astropy.org>`_  for ...``
I fixed this particular case.  In general this particular file was copied-and-pasted from astropysics, and I wrote it before I became wise to the virtues of PEP8 :) It will also probably be replaced by cython wrappers around SOFA functions in 0.3 (such is my plan anyway), but you're still right we may as well make it PEP8 complient at the end along with everything else.
That sounds reasonable, I guess. Together with @astrofrog's comments we then need to say goodbye to the notion if they broadcast or not. Because these beasts can be anything (not necessarily arrays).
This is really just XML unescaping -- should probably use the stdlib's `xml.sax.saxutils.unescape`.
plugin都关掉？
@laanwj I was asking myself, if this should be changed into
<pre>
        case ProxyUse: {
            proxyType proxy;
            return QVariant(GetProxy(NET_IPV4, proxy));
        }
</pre>
Not blaming you for this, but why on earth do we have a guiconstants.h file? That just seems broken - shouldn't constants go in the header for the file in which they are used?
The results of this are not going to change, is there a good reason to call this for each rule? Or am I misreading the diff.
You can check this also with: 
```
-               if ($current) {
+               if ($current && self::$_requests) {
```

Just wondering how you did get the error?
I think we might need to have a sideline discussion about nailing down just precisely what we can assume about the capabilities of an abstract message object.

The need for this method is *really* stemming from what JSON is capable of and filling a gap there.  I *think* efficient binary blobs are the only real hole in JSON, so this is the only method I forsee needing, since you can *always* serialize in some generic binary format and then binary encode for the channel, and then decode and deserialize on the other side.

So to push this a little further, I think messages need to be able to handle:

  * numeric types (ints, floats, bools, etc.)
  * strings
  * None
  * binary blobs
  * list/tuple sequences of any of these
  * mappings with numeric or string keys and any of these as values

I think that we have to assume that JSON may be used as the serialization format, but I'd be willing to put a wrapper around it which recognises standard Python binary data types (arrays, buffers) or which allows a string to be marked for binary treatment.

A different approach would be to have some sort of flag on the pipe which gives hints at the capabilities of the pipe (eg. arbitrary Python objects are OK, pickled Python objects are OK, binary objects OK, or text only.
While we're iterating, may as well provide a summed SP number and add to the char object..
i was not aware of that, but i only call encode where previously there was the <> added directly. i updated the doc comment on the method to explain its only meant for links.
At some point, we might move this block and the one from lines 85 to 92 into a separate function, because they are basically the same
You need to add a string as a default value or it will crash here when DESKTOP_SESSION does not exist.
You have accidentally changed the logic here so that it'll print warning messages almost always:

```
WARNING: The notebook server is listening on all IP addresses. This is highly insecure and not recommended.
```

I don't think that is intentional.
We care about the remote name because the fetch specs are not enough to disambiguate.  My above argument isn't terribly convincing.  Let me try again.  Take the following configuration:

    [remote "one"]
        url = whatever
        fetch = +refs/heads/*:refs/remotes/broken/*
    [remote "two"]
        url=different
        fetch = +refs/heads/*:refs/remotes/broken/*
    [branch "master"]
        remote = one
        merge = refs/heads/master

Consider that remote `one` contains a `master` branch as does remote `two`.

Although fairly ridiculous, `git` handles this by matching the current remote name, not by looking at the target fetch spec.  Thus, if you were to `git fetch one`, then `master` would be marked for-merge.  If you were to `git fetch two`, then it would not.  This replicates that behavior.
Can you include a dash?

    SOURCE_IMG=$(ls -v1 $BASE_IMAGE_DIR/${SOURCE_NAME}-*.img | tail -n1)

Nice thanks. ACK
Because I wasn't really thinking. I wonder if jinja2 supports `set h1_text = title = _('')`
yeah i know this block is gross!
need a test for this case to get back to 100% coverage
`int(11) not null default 0`
A dica básica é: se uma classe só tem um construtor e um método, ou você ta fazendo algo errado onde você usa ela, ou ela não deveria ser uma classe, e sim um método. 

No seu caso, você começou certo, o problema era que o seu Collider que estava fazendo a função de checar se os dois "CollisionLimit" (renomeado pra Rectangle) intersectavam-se. Ao mover essa função para a classe correta, ela passou a fazer mais sentido =]
Good point. It's probably ok to wait and fix that, or?
Initialization code can no longer see the State and Events as soon as I add TSub
Why did you change the id into search?
You should able to close the request by the "Close pull request" at the bottom of this page.
`p` should be `package`
What about checking for `is_a?(Enumerable)` and flip this around instead?
please remove these extra space
I dont see a variable `foo` defined in any pattern.
What is an `investigation` here? Assume typo?
This is out of scope for this refactoring. Open question for the team: should we do these kinda of modifications anyway? They run the risk of leading to irrelevant merge conflicts.
Why can't you use Service,ycp API?
Can we compare against nil explicitly here?
A minor gripe but commas should be followed by space; it's more readable.
Tests should go in oiio-images, we don' t call it oiio-testimages any more.  And, can you explain what the test images are, where they came from, and how much of the XPM spec this covers?
Much appreciated Larry :)

Ok, let's do this: To avoid changing the specifications out from under
Stefan (yet again!), we'll go with the current method for this review
which I think is perfect for the common cases.

After it's committed, I'll have a look in more detail to see whether the
"no alpha is opaque" rule can generalise to nchans!=3 without a
maintenance or performance burden.  (I'm pretty confident it can be.)

"Fixing" this would only generalise what we already have in this pull
request, it doesn't change the behaviour in the common case.
In https://github.com/ding2tal/ddbasic/pull/4 I have made a different version of this. In that version I have erased the ",&nbsp;" part.
I don't know if there's a performance difference, I was going to do `!== undefined` but `key in cache` seemed more descriptive of what's being checked. Equivalent of `has_key?` vs `obj[key].nil?` in Ruby.
Change this to to `(Event && contextOrEvent instanceof Event)`.
this changes the use-case of the fullscreen user view, to a new use case: that of showing the user's public page. This is handy if we have teams working otgether and multiple peoples activity's in the activity feed, when the user clicks on one of those gravatars, it calls the dashboard fullscreen user view, which will load the public user mask of that user (from that corpus) and display it in the public user page. if the user hasnt clicked, by default it shows the users own public page.
It doesn't. I thought it fixed the tests. Amending now.
Should I add a handy getJSON method to WebRequest class, or local validation is enough? 

Talking about contents validation, is it ok to add a method directly to SaverunAction, or what would be a good place for it?
La riga 11 non server. Serviva per vedere se funzionava la funzione ma per il resto.... non serve
+2 @pld (+1 for suggestion, +1 for education).
It seems very similar to the activity menu. I bet those 2 can be merged at some point to use the action_menu.css building block. (not in this PR).
Would you like me to namespace these paths? We could do something like:

// Dependency Injection
Calendar.App.DI = {
  paths: {
    js: "/js/",
    css: "/styles/"
  },
  files: { ... }
}
Declare them closer to where they are used. Actually it seems like you can even declare them in the if () {}.
Im not sure I need to show this error msg to the user..
I do prefer begin/end than left/right, but I even prefer no arbitrary class at all. :-)

I think it’s too specific. Can’t we have a consistent rule instead, and let developers modify the icon placement by app-specific rules?
@jmcanterafonseca the system is designed to have a FTU that can be replaced by any other app.

But we fallback to the one that we know in case that setting is not available.
I think is safer to place this new properties below a more secure selector `form[role="dialog"][data-type="edit"] header menu button`
If not we may change the appearance of the bottom menu actions!

Thx @pivanov  for your quickly work!
can we encapsulate this code for lazily loading within a function getTextFields(). I think it would make the code cleaner
Actually I don't know what is the correct UI for opening a bluetooth-transferred audio file, let's keep the current UI which normal Music player is using, and I will ask UX or visual designers to define this.
This will be handle by the system. This is per spec so you can remove this code.
Many times you're very defensive about |callback|. Not in requestSettings though. Why?
Btw since you control the code completely I'm not 100% convinced tou want to be so defensive about it :)
Actually we have both file `Open-Sans-Bold.woff` and `opensans-bold-webfont.woff` in this pull request.
Should only keep one :)

We should camel case all the fonts or none of them.
indentation changed to 2 spaces here? and below... shouldn't it be 4?
Python has a specific NotImplementedError you can raise: http://docs.python.org/2/library/exceptions.html
I needed those because I used from_python(expr) and for instance for `BaseForm[x, 2]` in the web environment it gave an exception for these two functions missing.
Yes, that's right. 

One thing I don't understand. Why would this rise and error?

    #> BaseForm[x, 2]   (* Should this raise an error? *)
     = x

I also have a problem with the first one. It should be fixed by some rule probably.
Should print the error. Not with color. But should also print the
optparse help like the previous version did.

Nicholas Weaver
817.914.6166

On Jun 15, 2012, at 13:28, Nan Liu
<reply@reply.github.com>
wrote:

>> +    def puts(*val)
>> +      @output.puts val
>> +    end
>> +
>> +    def available_slices
>> +      slices = Hash[ ProjectRazor::Slice.class_children.map{|s| [s.to_s.gsub(SLICE_PREFIX,'').downcase, s] } ]
>> +      slices.delete_if { |k, v| v.new([]).hidden }
>> +    end
>> +
>> +    def run
>> +      trap('TERM') { print "\nTerminated\n"; exit(1) }
>> +
>> +      parse_options!
>> +
>> +      # TODO: this does not suppress color for parse_options exceptions
>> +      require 'project_razor/cli/colored' unless @options[:colorize]
>
> It's not printing color with -nc, but it's still printing the error.
>
> Should it not print the error at all?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/Razor/pull/72/files#r994822
DriveShaft has been deprecated as of 2012.
ok now there is a method for updating environment https://github.com/wayneeseguin/rvm/blob/b0e25f2ea26b343583a5ea73bbd6a186cb25b179/scripts/functions/build#L145 :

    __rvm_update_configure_env CCFLAGS="-I/opt/local/include"

it looks better and will update `CCFLAGS` if it was already set
I'll add these in.
1 single call.
i don't think you can do multiple deletes at once
more than 79 cols.. and the rest of this template where it applies
Should these puts statements (unit test and convergence test) be uncommented or should this be changed to raise a not implemented exception?
getFormat is probably better
Any reason you don't make this an AnnotatedConfiguration? Would save some code.
We do braceless conditionals, should I go fix all of them too? And in my defense, the loop was already braceless :(
OK, so, it looks like the caching concerns around 302s are not an issue. Also, not passing PageRank on to targets is not going to be an issue either, so we can use 302.
size and block_size would be undefined if the above `if` sentence is false..
good catch on the unsigned type
Why order by?
This part of the patch isnt really necessary since you guard this in __init__ right?
shouldn't you apply ``preg_quote`` to be safe ?
window.Flow内部で
(大文字です。)
What about a utf character or icon? http://csswizardry.com/type-tips/#tip-11 ;)
I left this bad code in place to illustrate what I'd like to accomplish. How can I get a handle/ptr on the rule struct from the engine instance?
Why the change of indentation?
Should be localizable: `${%Expand all}`
I'm going to remove the 'ipaddress'  dependency and replace this with:

```return IPAddr.new(ip_string).mask(@key.to_i).to_s```

Example:

```
>> a = IPAddr.new("1.2.3.4")
=> #<IPAddr: IPv4:1.2.3.4/255.255.255.255>
>> a.mask(24).to_s
=> "1.2.3.0"
```
You should put some comment about "TmpD" string it's far from obvious.
the caller is getting something that's not what they expect, and have no way of telling that. are you sure we shouldn't just have exception here?
This variable should still be on the reporter object and not stay in the global scope.
nit: please add.
also, what if `images` array is empty?
I thing you have a tyop in there: "you may to ensure"
Any reason you changed this spec? The original one was much more clear to me as to what it means
yeah i understood what it was doing, but it's too "magical"… better to fail if the intended container is missing
baahaha... sorry "clobber", `className = 'suite'`
Sure. I wrote it that way as I had in mind to add a class for deprecated vars, so they could be visually distinguished.
I added the type hinting for $db
Please, no ServiceManagerAware traits - do SeviceLocatorAware instead, as
that's what we standardized on.
On Nov 9, 2012 9:19 AM, "Evan Coury" <notifications@github.com> wrote:

> In library/Zend/ServiceManager/ServiceManagerAwareTrait.php:
>
> > + */
> > +
> > +namespace Zend\ServiceManager;
> > +
> > +use Zend\ServiceManager\ServiceManager;
> > +
> > +/**
> > + * @category  Zend
> > + * @package   Zend_ServiceManager
> > + */
> > +trait ServiceManagerAwareTrait
> > +{
> > +    /**
> > +     * @var \Zend\ServiceManager\ServiceManager
> > +     */
> > +    protected $service_manager = null;
>
> Camel case please. Also, the var docblock can just be ServiceManager since
> there's a use statement.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/2927/files#r2084108>.
>
>
Ah, you're right. Will fix these tests/
Missing assertion?
You're duplicating core httpd functionality now. Using `ap_some_auth_required()` here is the right thing.
Yeah, Stats.js sounds better to me.  Then if we have more stats-related stuff, it could all go in there.
thank for the tip !
No, we don't want a global field, we want to instantiate an entirely new CraftingTableInventory every CraftingTable#onInteract
It is required by `Flask-Login`. If we have no plans to use this extension, I'll remove it.
Either way sounds great.  :)
Can't we externalize the execution of this somehow?
I'd recommend a strategy for this.
http://jsperf.com/caching-array-length/123

It's all basically the same.

/me shrugs

I just do it this way out of habit now. Maybe I can stop it.
use "OSError, err" and add err into exception message
`hwi_oauth` ?
Not really. The session context is indeed injected, but you never use the principal field as a field. Furthermore, the bean is a stateless bean, so it's very bad practice to assign values to fields.

I've no problem if you want to make the Principal a method local variable, to enable commenting it better (you would need more comments than you have now thought to justify this).
Ah, but that kinda fails if the system python is Python 3.x. You need to use `python2` instead. Or just modify `./pesterchum` as in #11, which is a bit better imho.
I can change the class names to SMS  and keep sms_page in lower case so it looks cleaner. What do you think about that?
please remove the underscore before get
Actually... I'm not that good at this, I'm going to punt on this for now, because I don't know how to make a pseudoelement around the `<dt>`/`<dd>` pair to make them float like this.
You could do

return redirect(reverse('profile.edit') + '#services')

to return the user to the 'services' tab to get his new key. Right now you are redirected to a "different" page and feels wrong.
We need to make sure values like this correctly become check boxes
Yes. Not merging this. Will fix this.
Transforms contain a [class variable](http://www.python.org/doc/essays/ppt/acm-ws/sld051.htm) for the output bindings.
same here, this way we could start using my_facts and my_hosts regardless and ensure they are always scoped.
if you setup has_one, than you can put all of this limitation in the has_one definitions
Ok, i'll update. I can do the same in :my_facts too
It seems like this fits in the view more so than the controller. Also, isn't the variable `@environments`, not `@environments`?
Cucumber? :see_no_evil:
It can be added. Can you open a bug on bugzilla and CC me (:vingtetun) and yurenju@gmail.com on it? Also I guess :lblakk would like to be CC'ed on it.
These are not valid test cases. Use Scaffold to generate test cases: go to the page that needs to be tested, open scaffold, go to the Testing tab and click New Web then Save.
Same thoughts as the other PR :P
I didn't see a video that pertains to this formula, so I guess we need to include the derivation here. It would be nice down the road to just be able to show:

`<code>a_{n} = a_{1} + (n-1)*d</code>`

and continue from that point. The hints look thorough and comprehensive though, nice work.
Do we capture the sequencer name, sequenced path, and the output path in the failure event? This is all useful information, especially when a sequencer generally works but fails on particular inputs.
As far as I can remember, there currently isn't any functional difference between leader and admin. It's mostly in visual things, such as quote and photo caption notifications. Any leader can make themselves an admin from the account panel. Admin will eventually be phased out in favour of preferences of some sort.

tl;dr: sticking with leader is fine
две строки можно объединить
мы хотим, за O(E)
Non-zero for error is more of a convention than a rule, and not all commands stick to it. More than 126 are definite errors, such as the process not existing.

Still, I'm not sure, since this plugin is going more for the usual use case and leaving the less general stuff for custom plugins maybe it would be a good idea to treat all non-zero exits as errors.
I had separately submitted this specific fix as another pull request (https://github.com/marijnh/CodeMirror2/pull/482), though in master it doesn't seem to affect anything. It's actually necessary for this pull request, though, because if maxLine isn't kept up to date, the scrollerInner's width won't be set properly.
This is initially going into RHEL6.  Handling systemd is on the plan, but not for the current work.
There are a number of places where the code will have to be adapted when it's applied to systemd based distros.
Helper functions must be declared static.
Sounds good with me! 6117e9d9a682da96bbd79457b8e222f7a9024bbc
This should be a DELETE request, not a POST
Do we still need the schema.js files? It feels like a bit of a pointless abstraction now, although does make it clear where to find the schema declaration. I'd be inclined to move ensureSchema into this file and remove the schema.js file altogether (including dropSchema).
I think the `()` should be removed
The following is what I had in mind:

```scala
object MethodClassifier extends Enumeration {
  // This is defined in Enumeration but it cannot be accessed!?!
  private def nextNameOrNull = if (nextName != null && nextName.hasNext) nextName.next else null
  
  protected abstract class Classifier extends super.Val(nextId, nextNameOrNull) {
    def is(method: Method): Boolean
  }
  case object Synthetic extends Classifier {
    def is(method: Method): Boolean = method.isSynthetic()
  }
  case object Getter extends Classifier {
    def is(method: Method): Boolean = method.declaringType().fieldByName(method.name()) ne null
  }
  ...

  def allKindsOf(method: Method): Set[MethodClassifier.Value] = values.filter(_.is(method))
}
```
I know it's more verbose, but I like that it keeps data and behavior close, particularly for the ``Forwarder`` and ``DefaultGetter`` case.
``Scala/Java Junit 4``? (just pointing out for consideration)
Like the approach of triggering an event
I think bellow analog will be more "consistent" :

    $json_result = is_callable(array($result, 'result_array')) ? $result->result_array() : (array) $result;

Since there was (and still on going) alot changes within codebase, to convert similar control structure (if/else statement) into ternary statement style.
И в коде есть проверка - проверяется длина набора индексов цикл while ниже в коде
Да, именно это.)
somente coloque como público na controller métodos que serão actions. o que faz este checkFormData? ele está gravando um model? Não entendi... Se você quiser usar validações, o que eu acho que não precisa neste momento, veja: http://framework.zend.com/manual/en/zend.form.elements.html
That's a very hardcoded way to make Vengeance spin faster when it has more stacks. I've removed vengeance, so this code is obsolete and can be removed.
Can you move else { up to the same line as the }
Remove line break before this line and add it after this line.
This will make a logical group of assignments and method call
Okay, merged. Are there tools I can use to check such low-level performance things, and if so are they ridiculously expensive? Will I just have to develop an understanding of such things? Are there any books or articles you can recommend?
Cool thanks.   I'm new to coffeescript.   I'll make that change along with a bit more error checking.
InvocationTargetException应该是Method调用的时候把所有异常包了一层，在找它处理异常的地方，一层套一层，再找找。
The note about makecert should go in a file comment at the top.
If I do it like you propose the resulting raw gets oblivious to the ICA compononents and thinks it just has the reappended channels:

```Python 

/Library/Python/2.7/site-packages/mne/fiff/raw.pyc in __getitem__(self, item)
    283         sel, start, stop = self._parse_get_set_params(item)
    284         if self._preloaded:
--> 285             data, times = self._data[sel, start:stop], self._times[start:stop]
    286         else:
    287             data, times = read_raw_segment(self, start=start, stop=stop,

IndexError: index (19) out of range (0<=index<18) in dimension 0

```
If I go back to my notation it is fine again. Wdyt?
if you want the example to be rendered with a plot in the doc its name should start with ```plot_```

I would fix the seed of ICA and try to find a component that looks like heart beat to plot it. If ICA works it should be present.
Ok, forget the first part, wrong scope. The Decomposed object could nevertheless be considered.
Don't forget to actually say what it was:
```
            raise ValueError('%s is not a valid connectivity method' % m)
```
What's <!-- HERE --> :) ? Remove if not needed.
Maybe it is worth adding a note that salt keys are SSH keys, but SSH is not used for transport.

A note about SSH keys security... but maybe this is already covered in another chapter.

* salt master only stores "public keys"
* if a key on salt master can be read by a third party there is no security issue. Is not like reading a password
* if a key on salt master has write permissions by a third party there is a big security issue.
Good catch! Man we need tests for this.
Yep, this is a little trick we have built into our render :). So, I'm closing this ticket - the markup looks ok to me. BUT, if you're seeing some sort or rendering issue, let us know!

Thanks!
@stof @weaverryan ...fixed...
Is the idea that the Ruby-based JSON validator will catch errors and then you need to use JSON Lint to find out more information?
needs to reflect new location
Кстати, почему оно называется Event?
Сотри и оставь пустую строку. А то переводчикам зазря нужно будет «Form» переводить, некруто.
joya

On Saturday, August 11, 2012, Alpha <notifications@github.com> wrote:
> In source/CommonJobs/CommonJobs.Mvc.UI/CommonJobs.MVC.UI.csproj:
>
>> @@ -499,10 +314,6 @@
>>      <Content Include="Content\twitter-bootstrap\less\utilities.less" />
>>      <Content Include="Content\twitter-bootstrap\less\variables.less" />
>>      <Content Include="Content\twitter-bootstrap\less\wells.less" />
>> -    <Content Include="Content\twitter-bootstrap\LICENSE" />
>
> Sí, en la carpeta Libs mantenemos la copia, y el proyecto se distribuye
con todo. No creo que en la versión que se está ejecutando necesite ser
visible.
>
> —
> Reply to this email directly or view it on GitHub.
Se renderiza bien sin la separación de líneas acá?
Here you added a "stub" parameter to your should_receive.. but stub actually creates a new object that you can use later on. So this would have worked:

```
it "should calculate a route via the CalculatesRoute" do
  starting_point = stub
  cities = [stub, stub, stub]
  subject.stub(:cities) { cities } 
  CalculatesRoute.should_receive(:calculate).with(cities, starting_point)
  subject.route(starting_point)
end
```
Virtual Memory Streaming?
nit: sp after ,
Why would we be passing req in here instead of init?
global isn't necessary unless your modifying VERSIONS, which I do not believe you are.
This is the kind of whitespace change that I like. pending WS is very annoying. Still, it's better if such changes are kept in a separate commit.
I don't think this is helping.  It appears that a problem with the whole docstring is that it never says anything about what determines the default color, when it is not specified as part of a syle/color string.  Early in the docstring, it should say that the default comes from the color_cycle, which can be set with an rcParam or with the set_default_color_cycle function.
For later cleanup, at leisure: use parentheses instead of backslash; I'm pretty sure this is supported for 2.6 and later.
Put the triple quote on its own line.
Oh dear. I don't think this is better either.
We can use the same `test_music`, `test_camera` lamda approach right to wait for the condition/duration text over sleeping, right?
Yeah I agree it's probably not safe to assume that suites should be deselected if they're not in the included list.
I am fine either way.
Eric


Sent from my iPad

On Jun 11, 2012, at 11:11 PM, "Wils Dawson" <reply@reply.github.com> wrote:

>> @@ -14,6 +15,8 @@
>> using namespace man::corpus;
>> using namespace man::memory;
>> 
>> +#define BOX 5
> 
> I don't know how strict we want to be on this, but my understanding is that we wanted to move away from <#define>s and instead use <static const>s i.e.:
> 
> <static const int BOX = 5;>
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/northern-bites/nbites/pull/322/files#r964776
Just a note that the Windows service currently runs rad without any arguments, is something like this needed there (it's written in C#).
Agreed, and it makes template compilation slightly slower.
Could you add an assertion which tests that grandchildren are removed as well? Given how onBeforeDelete() is implemented, this is very likely already the case, but testing it doesn't hurt :)
typo? :-)
Opening brace must go to a new line
hmm, okay, I see. so you send something like ?token=XXX, that makes sense. A comment would help to understand :)
Another thought: do we really need this object `db` of type `Connection`? It doesn't really do anything except encapsulating the sequel database object. If `target_database` would be the sequel object, this would also simplify the code of the mapping, validation and after row blocks. I always found it tedious to write `target_database.db[:my_table]` instead of just `target_database[:my_table]`.
Should this go through anything on the old_chunks list as well?
It seems to be pushing the responsibilities of DialectExtension in my opinion, but since I can't think of a better place to put it and agree that this could be cleaner, I'll go with that.
The isset is not required.
What's the difference between this and without '###' at the end?
I was thinking to replace this with a Module listener similar like getViewHelperConfig(), i've looked at https://github.com/zendframework/zf2/blob/master/library/Zend/Mvc/Service/ModuleManagerFactory.php#L52 which can be added at https://github.com/zendframework/zf2/blob/master/library/Zend/Mvc/Service/ServiceListenerFactory.php#L108 but that could only be changed at the application.config.php level, i have to dive deeper to be able to configure this at the module.config.php level