labofsahil/github-event-dataset-2012 huggingface dataset:
Shouldn't that be `href="?page={{ users.number }}"`?
Are we doing the same for event_new.html too?
Sorry you can leave out this line.
This does not look like an English sentence. you have 2 verbs
just wondering, why did you switch the parameters?
can you add some docs around this, possible values, what they mean etc.
Second person and a few errors:

> In this article, I will introduce you to the core features of phpBB and guide you through the installation.

Applies to females, too :-D
Any reason why we're serializing both the identity certificate and the keypair here? It seems like we should just need the id cert which simplifies a lot of the patch. (potentially)
Delete this alert
Or delegate it to the block's codestring trait, depending on which you see as primary, the code or the block.
hmm, indeed. But as this fixer throws exception everywhere and is not really fixing the codebase either (see my comment), it should be possible to run psr1 without it (so that you can actually fix the CS in your project)
default is only necessary for non `None` values. You can omit it in both cases.
Happy to remove this method completely. Most of this stuff is copied directly from `jmbo-analytics`. I wasn't sure what is relevant and what is redundant so I just moved over everything and make sure it works. Any cleanup we can make is a huge improvement!
Also, is an array of objects not supposed to be `Object[]`, String array would be `String[]`, etc...
I'd prefer [ComparisonError](http://junit.sourceforge.net/javadoc/org/junit/ComparisonFailure.html), as Eclipse has a nice UI Diff tool that it uses to display strings that differ in that way.
got it. Multiple test descriptions were wrong :P
Категорию лучше вынести в отдельный файл (File -> New -> File... -> Objective C Category).
Если задать 2 одинаковые ДНК и сделать для одной 100% мутации, то результат измерения различия не даст 100%.
Ошибка в этой строке.
Если не сможешь найти - напиши покажу.
for example transmission addon use /var/log. It's not standard of course but trying to make standard good idea If you ask me. Lets ask @sraue he is the boss :)
erm...... no idea how that got there :D
You should assert an exception here.
Maybe we'll open an issue and revert the file, I'd rather the commit didn't touch files unnecessarily
`valueWithNonretainedObject:` would be marginally better here. Even better would be using the `CFDictionary` API directly, since you can set non-copyable keys with it.
Looks like this can be removed, yah?
Can you use `mail` instead of mutt? More likely to be installed. Also, you could include notes like `apt-get install mutt` on debian-like systems, etc.
Why not name this self.gather
is ecg_proj.fif included?
They are required; we insert default values prior to validating, so there will always be something there.
"lets" vs "allows"
"system identify" vs "system to identify"
Could you add a space between `#` and `config`... Thanks :)
``its``
Should return, but I was unsure of the return type of the response.end calls everywhere else. Changed
auto_ptr delete pointer in tts destructor. So, you can avoid memory leak.
If you call release method, you can get pointer which auto_pointer own and auto_ptr release ownersip of pointer.
Просто `const auto&` сойдет.
Мне лень писать << и >> для shared_ptr
wrong slug
Hey Colin,

Thanks for the comments! I was taking a little break. Will fix these up and
get back to you soon. Happy holidays!

Cheers
Mayank


On Sun, Dec 23, 2012 at 2:23 PM, Colin Clark <notifications@github.com>wrote:

> In flocking/flocking-ugens.js:
>
> > +         out[i]=0;
> > +         // now fill with grains
> > +         for (j=0;j<m.numGrains;j++) {
> > +             out[i]+=that.delayLine[m.currentGrainPosition[j]]*m.windowFunction[m.currentGrainWindowPosition[j]];
> > +             m.currentGrainPosition[j] = (m.currentGrainPosition[j] + 1) % m.delayLength;
> > +             m.currentGrainWindowPosition[j] = (m.currentGrainWindowPosition[j] + 1) % m.grainLength;
> > +             //randomize reset position of grains
> > +             if (m.currentGrainWindowPosition[j] === 0) {
> > +                 m.currentGrainPosition[j] = Math.floor(Math.random()*m.delayLength);
> > +             }
> > +         }
> > +         out[i]/=m.numGrains;
> > +     }
> > +     };
> > +     that.init();
> > +     return that;
>
> I'm really excited to see this shaping up so nicely!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/colinbdclark/Flocking/pull/31/files#r2496582>.
>
>
Then remove them -o-
It would be a bug to return a marker when you're out of data. Passing a null marker is intended when there's no more data.
More tests can't hurt, though.
Base on what I see, I can understand why you added the synchronized sections around the hash map, but you should document the design choice to avoid confusion in the future.
Oh. Ok.
Anyway I've checked the original class name It's "JSMin" so I'll keep that consistency.
ah, nevermind, I see what you mean.
Is a histogram function a helpful thing outside of this testing framework? Could/Should it be factored into the main code?
These should be separate test files.
>  А вот тесты предлагаю вперед этого пульнуть.

да ну что ты такое говоришь!? я в первую очередь задумался о том как будут смотреть, проверять. без тестов можно чокнуться даже пытаясь помочь добить этот пулл =) 
Про ссылка "здесь" -- там весь diff состоит из выпиливания использования отдельных $this->errors и $this->violated, а также $this->primitives[$name] и $this->rules[$name]. Все методы будут перепилены дважды. Если один пулл создаст много проблем, можно распилить его.
phpunit позиционирует в таких ассертах первый аргумент как ожидаемый (тот который должен быть), второй аргумент как тот, который получился в результате выполнения теста.
В onPHP по какой-то причине часть тестов (большая, пожалуй) написана с перепутанным порядко аргументов, часть с верным.
Думаю стоит все же двигаться в направлении использования правильного порядка аргументов. Впрочем если происходит какая-то ошибка, то все равно нужно залазить и смотреть что случилось.
You don't have to escape the `.` inside brackets, and PHP allows number chars in the function names as well. I would suggest `[A-Za-z_][\w._]+`
I've followed PEAR coding standards. ("Split function definitions onto several lines" section): http://pear.php.net/manual/en/standards.funcdef.php
You are right; it should be the MIT license.
I like the page that you created for this, but maybe it'll be slightly too high in maintenance for now (given the anticipated changes). I think for now just the warning box would be sufficient, and would reduce some of the repeated stuff from the widgets.
Having a `role="main"` here means that this will be on the page twice. It should be removed from the welcome widget.
I bet this can also be shared code across all the ContentQueryHandler classes. The original ContentSearchQueryHandler has:

ImmutableMap.<String, Object> of(
      CommonParams.FL, "path",
      GroupParams.GROUP, Boolean.TRUE,
      GroupParams.GROUP_FIELD, "returnpath",
      GroupParams.GROUP_TOTAL_COUNT, Boolean.TRUE
  );

"path" is the only thing that Solr needs to return because the servlet builds the output by going out to SparseMapContent. The GROUP_TOTAL_COUNT is needed to provide correct totals when a search matches both the basic pooled content item and one of its widgets. (Preventing bugs like that is one reason to centralize query logic as much as possible.)
Mention what `displayln` does.
Can we use `.cms-edit-form` as a selector instead? We're not using `#Form_EditForm` for much in the SCSS
set field data maybe but now it's same as for setData method
No worries. I may just put this guy in Pro blocks anyways so it makes more sense
Yes but is not consistent with the rest of the file. What I was saying is to change the code to:

```php
if (true === $gzip) {
```
I've changed it to roll back if closing cursors fails.  The common code between commit and rollback is already in `__wt_txn_release`.
Fixed in 85ce4ce045346bfbfb975b638b29474267cb61a8.
Colin and others, I pushed to my "jocelyn" git repository a solution to address HEAD request in a smart way
I think this solution is fine, and without negative comments, I will push to the main official repository soon.

Check https://github.com/jocelyn/EWF/commit/125d44ff67623b83f1f246f9d367787885b9a695
Are you sure that the method "getExtension()" exists?
Should the type for parameter ``$helpHtml`` not be ``string|null``? Please also check line 101.
I don't think we can guarantee the order that the keys will be iterated over so the resulting array may not be in the expected order. Otherwise, yeah, I agree, it's a bit of spaghetti code.
Keep the sprintf
We could reduce this by adding more logic to the `getGetter`, `getMap`, and `getStyle`, but I'm also trying to encourage a simple hook mechanism. See the following comment.
Shouldn't these methods be on the ResourceCollection?
`, auth`
No, in CSS file define CSS class. And then just add or remove those class from from the element.
Have you read that page with django-missing documentation I gave to you? There is written which template tag library you have to load and how. Read the page a bit. ;-)
I am not sure if you want to wrap everything at once, because what happens with long URLs? Does it split them? Or does it leave them? Because if it splits them, then you have to use this around every paragraph.

I would wordwrap at 72.
Well yeah, it makes no sense marking it for translation if we should and won't translate it :)
Change by overriding `api_field_options` I added for you to `MongoEngineResource`.
Does this task really work for you?
`piplmesh.frontend.views.ForbiddenView`
Anyway, why would you need some special treatment?
I don't know, but apparently the way to access elements is then also changed, in a line 
> for node in stations_tree.markers.marker
I get 'lxml.etree._ElementTree' object has no attribute 'markers'. Can it sty like it is? :P
But caller already know this? Why it is again returned?
Django models? This cannot be right.
Yup, I don't agree with it. It's ok though, I'll release a gem to handle it within the next few weeks. I might use the term `idempotent` or `pure` (as in "pure function") instead of `memoize` though.
Hah, sorry - my bad.
Please use jsdoc-style comments:
/**
 *
 *
 */
I guess you can remove this comment
Duplicate??
Again with the `any` / `any()` problem.  Return type should probably be `dict()` and argument type `tuple()`. This will be passed other types of records too.
Each GOA species file has a different version (see http://www.ebi.ac.uk/GOA/archive.html), so how should I proceed?
Looking back on this test, I'm not happy with it. I was never planning on including every template. This was just an example to say "if these files are there, they should get spat out in the template list.

Not sure I like this explicit version either, though. I'd prefer to just remove the test entirely and add one or two more "Then"s to the list_templates.feature as a sanity check and call it a day.
you are forgetting the steps that would merge your feature_branch_name with master
git checkout master
git merge feature_branch_name
git add .
git commit -m 'details here'
Very good point, correcting this test class and updating the pull request
You should use [this setting](https://docs.djangoproject.com/en/dev/ref/settings/#internal-ips).
let's put 0.3 as an option we can configure
That could be useful to have a docstring here, explaining how to use this Plugin, briefly, why not with a reference to the docs if it makes sense
I think I'll wait for the future way, I don't want to hold this pull up further.
Previously on line 179 (https://github.com/tauberer/ckanext-datastorer/blob/02217d8760f30b252a3c2c038c4653b83ff00c43/ckanext/datastorer/tasks.py#L179) there was "check_response_and_retry(response, datastore_request_url + '_mapping')". I see now _mapping was just for the log message. It was confusing.

So, IMO, delete/create/insert is painfully clear. Overloading 'insert' with different underlying operations (violating an expectation that it would be similar to SQL INSERT) makes the code much harder to follow.
Move up after `else`.
Without it we get a compile error:

    net/instaweb/http/public/headers.h:110: error: ‘net_instaweb::protobuf::RepeatedPtrField’ has not been declared
I think this introduces a race if you change the same key two times without invalidating the timer first.

Example, you call that on the `blorp` key with a 12 seconds timeout, then 11 seconds later, you call that again with a new value. 1 second later, `-expireMeta:` would get called (for the first timeout) and would erase the second value set.

Sadly, I can't see an easy way to fix : either you have to manage a dictionary of timers (one for each different key used) so that you can `-invalidate` them before scheduling them back. Or switch to `-performSelector:withObject:afterDelay:`/`+cancelPreviousPerformRequestsWithTarget:selector:object:` and make `-expireMeta:` take a key argument instead.
No worries - done, and some whitespace cleanups in the rest of this file too which was a bit confused.
Please order imports alphabetically.
Please externalize the actual command management in a separate method
Perhaps a ``<blink></blink>`` would be appropriate here?
Probably doesn't matter at all, but I think using `std::copy(rhs._array, rhs._array + _nn, _array)` instead of the loop gives the compiler/standard library the best opportunity to optimize this, and I consider it slightly more idiomatic.
That's reasonable.  I just pushed a fixed version.
要让它执行你的测试脚本。
Wait, since when do you care about the quality?
Are some of these required?  If so, you probably want to add ```:required => true```
Perhaps use e rather than e.getMessage().
For example, NullPointerException often has an empty message. Will sometimes be very useful to include the type of exception as well as the message.
A note about what data type 'onsets' is might be helpful.
My deepest condolences. I assume this is the primary motivation behind the kickstarter compiler?
you must make sure that the exiting collection of transport is closed first, before cleaning it.
It's a warning, because you're not supposed to use "true", but instead the name of the replicaset. Should we change that in the message?
Why shouldn't these be docstrings? The test runner uses the more descriptive name in test output, which is nice (but still has the function name so you can find it quickly).
Does it make sense to use `::Object` here instead of `Object`? It'd be pretty crazy for there to be an `RSpec::Object` or `RSpec::Expectations::Object`, but 1) Ruby's constant resolution rules have changed and I don't always remember them and 2) We were originally defensive about this.

/cc: @myronmarston
Any reason for removing the sourcetype check?
See https://github.com/symfony/symfony/blob/master/src/Symfony/Component/ClassLoader/ApcClassLoader.php#L74
@bksunday the SE repo has a 2.1 branch whihc will be used to release the next 2.1.x releases. The master rbanch of the SE is not about 2.1 anymore.
is this still true in 5.4 ?
This is a bad patter to include `?` and `&` into params. Wouldn't it be better to do this:

```
params  = {
 :format => :xml,
 : addr => address_url,
 : lat => latitude, 
 ....
}

params_string = params.map {|k,v| "#{k}=#{v}"}.join('&')
```

This way it is 
  * order independent
  * less typing
  * less error prone
  * easier to see what is going on
@jaberg, is this something (e.g. sonify of 2d (or larger) arrays) that would be hard to implement?
I haven't removed it completely, just moved this text inside of activate(), it still would write to logs about clumsy-priming, but would not say it was clumsy or normal. I can add a switch to show clumsyness of priming if you wish.
This bit doesn't seem to be particularly related to caching.
I couldn't think of a case where it would fail proper other than not being set. Localhost is probably fine.
this should be node["cinder"]["db"]["name"]...
I'd name the variable same as the "old" one, importing_tasks
well, http://c9s.github.com/Onion/ is not ready, the http://github.com/c9s/Onion provides more informations. :)
Надо избавиться от copy-paste в этом методе.
Используй BufferedReader :) Эта штука не будет на каких-то архитектурах работать, где перенос строки - это \r.
На случай если название файла начинается на -
Без учёта регистра не значит, что можно выводить модифицированный результат.
Good point. Looks like we don't actually hit that user/pass combo anywhere in code, so this should be safe.
This changes the formatting of the commit output...
[Zurb Foundation forms](http://foundation.zurb.com/docs/forms.php) don't have hints. So you are right, `hint_class` should not be required.
Perhaps something like this makes better sense:

Spectral embedding is most useful when the graph has one connected component. If there graph has many components, the eigenvectors will simply uncover the connected components of the graph.
line is too long :)
thanks - changed that
Initially I thought it wasn't too bad but some of the other examples are strange. If it all gets to verbose perhaps pull it out to an ant task or something?
You lost a change here. I added a config override for some of these variables.
These notification name constants should be more specific to avoid colliding with other notification names.  Something like `NSString * const RZFileManagerFileDownloadStartedNotification = @"RZFileManagerFileDownloadStartedNotification";`

Notification constant variable names and their values usually match and are very verbose. (i.e. `UIKeyboardWillChangeFrameNotification`)

The Notification keys should also get the same treatment.
bad spacing, but you can safely ignore
the curly brace should be on the same line than the ``if`` (as done previously)
This is overly verbose. It's enough with:

```python
def get_timedelta_from_value_and_unit(value, unit):
    if unit == 'weeks':
        return datetime.timedelta(weeks=value)
    if unit == 'days':
        return datetime.timedelta(days=value)
    if unit == 'hours':
        return datetime.timedelta(hours=value)
    return datetime.timedelta(weeks=1)
```

Doesn't that look shorter and easier to read?
makes more sense,thx
Also, I don't know what I was smoking to allow this to be a tuple. Use``list`` instead as it that is the correct data structure for choices.
Ok to move `TEST_CONNECTION_SETTINGS` in `tests/base.py`, and for `DEFAULT_CONNECTION_SETTINGS`, it can stays in `database.py`.
Indentation goes off here.
I don't think that a let would work here, since this is a "before :all"... I would like for all of the tests to share one temp dir, and I believe that subsequent calls to the let for each test would generate in separate temp dirs.
I added your fix and a test in 142b677
These don't need to be fully qualified -- as noted, annotations in docblocks resolve according to the namespace and/or imports.
@shacker Can we also add a label for this checkbox?
Although it's allowed in html5, I would suggest to still close the `<input` tags
`(not (== 1 (count (:authors book))))` would be a better way.
Maybe manual bootstrap for angular is the solution?
true is not the same as 'true'.
If you must rescue ::Exception, please log the backtrace.
The code in setup seems a good example of code to put into scanner_prescan in the new UDPScanner mixin:

```ruby
		if datastore['RANDOMIZE_PORTS']
			@probes = @probes.sort_by { rand }
		end
```
I mean you don't seem to be using anything from Concern in this module, so I'm not sure why it's there.
Did you test it with obfuscation?
It is incorrect as author field
this does not work in the gray-level case (when data is an ndarray and not a list): 


```
>>> data = np.zeros((70, 100, 1))
>>> for spectrum in data:
...     spectrum = spectrum.squeeze
...     
>>> data.shape
(70, 100, 1)
```

Therefore, in the gray-level case, the arrays are not squeezed for 2-D images.
This means that we miss a test on the shape of output, I guess!
Note: this is repeated in other docstrings below.
I think it's much preferred to only have one call, but you're right--the API is awkward.

How about we modify warp(...) to check the type of the reverse mapping, and to automatically apply the class if it is a transform?
I'll do a comparison but I originally implemented this in pure Python and the reason I "translated" it to Cython is the speed. Don't worry, I do not implement things in Cython for fun - I prefer Python as well ;-)
I'd use 1.8.7 style hashes in the documentation.
I'm don't. Not because I like HTML better, but because the web would be completely broken. HTML is created for mistakes, XHTML throws on the smallest mistake.

Still wrong though, since then it would be `<input class='edit' value='{0}' type='text' />` with XHTML :P
Right.  I fixed this by changing the `cst"` to `dst`.  This simplifies the step and avoids the subsequent vanishing quotes problem.  :-)
Updated and re-based thanks for the pointer!
How screwed are we when we want to support both kinds?
Why is czmlInterval coerced to a number but result isn't?
As I commented elsewhere, we shouldn't have functions within functions without a very good reason.  All of these functions should be moved out to the local private scope.  This will also make the code a lot more readable.
Another great principle - for both code and doc - _make every word tell_ (I said that 500 times when editing OpenGL Insights).  Every additional word gives the reader a chance to get bored and move on.
I agree.  We should be able to delay this until `update` like we do elsewhere in primitives.
Regular createGuid returns a roughly 36 character string which is too long if I'm using guids to differentiate uniforms and agi_getMaterial calls inside glsl. I can make a comment in the code about this.
I was not trying to follow the mixin example. As I was telling u yesterday, I had found a couple of posts where it was suggested that args in the main function should be in upper case. I asked you about whether this was a good practice, and u did not know. Therefore, I left it there. If u prefer the bus = bus || EventBus(), then it is ok with me.
Typo - givin
Why does this sentence end with ";" instead of "."? Perhaps habit? :)
"writeOutput('usage: ${cmd} filename');" is duplicated twice here. Can you refactor so that it isn't?
it returns a 4 tuple:

(widget, mode_field_instance, model_field_type, field_key)
Goes here because `as` has an unhelpful parent return type! Not that anybody is going to feel sorry for me when I'm doing what I'm doing here.
Im not sure that the error is referring to ranges in the sense of say, `lrange`, but rather the input bit-width perhaps.
I double checked the incr documentation.  It doesn't show it the message there, but it does on the CLI.  Also, I did find the same error for decr, which is similar here: http://redis.io/commands/decr

Here is redis-cli run-through:
```bash
redis 127.0.0.1:6379> incrby x "2"
(integer) 7
redis 127.0.0.1:6379> incrby x "2b"
(error) ERR value is not an integer or out of range
redis 127.0.0.1:6379> 
```

I guess the question is do we want to be exact in the error return messages or not.  I think we should.  Let me know what you think.
Same for the name here
No problem!

I am grateful that you took the time to write it and that you want to contribute :)

+1
Small API breaking change here: new version will not allow using module level `moveFront` if `compute` doesn't return by `ref` and `ElementType` has postblit.
The whole appender!X vs Appender!X starts looking like a mess. Are they equivalent, are they different? Plenty of places like that.
The trick is ... it doesn't compile with:
           T1 e=void; 
           T2 v=void;
            fn(v,e);
            fn(e,v);  

I believe it has something to do with string predicates. 
Like compiler checking "value used before initialized", it works ok for => predicates.

Problem happens with code like this:
import std.range;

void main(){
	int[] abc = [1, 2, 3];
	auto srange = assumeSorted!"<="(abc);
	srange.lowerBound(2);
}
nit: `completeFlush` is ambiguous.  Does that mean "complete a flush that is progress" or "do a complete flush"?
Why not test against the latest versions of Rails (e.g. `~> 3.2.8`)?
subscriptions is used on Topics, each topic can have multiple subscriptions, each subscription can have multiple rules. As a result, it might be more appropriate to separate " create, list and delete subscription " from Queues. In addition, message operation work both on Queues and Subscription, as a result, it might make sense to either list message related description independent from queues or repeat it for subscription.
This change clearly requires a newfile at file's end. It is the One True Way as any one with Common Sense knows.
2 spaces between `"pagetitle"` and `&&`
Does this need to be random?
typically no spaces on either side of the `=` for function keyword arguments (as opposed to regular variable assignments)
less parameters needed
the else was added, you may be looking at the wrong commit
```
else {
	throw new MessagingException("Ambiguous method parameters; found more than one " +
				"method parameter and neither one contains a @Payload annotation");
}
```
pushed
```
if (size < 2) {
		return handlers.iterator();
}
```
s/~~have a look at~~/see/
Gary, although I still prefer 'obtain' or some equivalent i would rather live with 'get' then 'getOr*'. So if you can't find a better name I'd change it back to 'get'.
What about: 
provide*, retrieve*, attain*, acquire*. . .?
There are these facter facts:

operatingsystem => CentOS
operatingsystemrelease => 6.0
osfamily => RedHat
Clarified because there are now 2 iPhone display sizes
sure https://github.com/SimonCropp/Fody/issues
This is optional, so it need to be injected through setter
@kaelima already helps me to find another solution (store targets guids or use ApplicationMap)
Raghu,

Yes, It don't need to be a set, it is here just because I thought the code is from the base but actually from Harry Chen.
Perhaps clean up this doc a little bit ... doesn't need all of this info, or at least not the last line about the template!
More mutability.
This should be data, not date, right?
<pre>UH - OH!
THE FDSIZE HAVE
STARTED TO MOVE!</pre>
This also works:

```
if isinstance(f, (fields.ComplexDateTimeField, fields.DateTimeField)):
```

And we are importing only modules so there are not so many additional imports required. :-)

But OK, leave it like this is they are doing it. I just wanted to know the reason. Because I do not see one. :-)
Yes, the handler reads two unint32: 'num' is 'the length of response' of the request, and the following unint32 is the actual value that I support. So I think it's no problem that I only apply a fail cause. 

Per my understanding, it's not a bug. 'num' is the 'length of the response of the fail cause request. If 'num' is zero, that means no response, then the handler just returns.
simpler way: ``$config = $this->->processConfiguration($configuration, $configs)``
tested logging in through the new auth server, seems to be working well.
please remove the c++ exceptions, we do not use c++ exceptions
"Driver" can be lowercase.
I think that makes more sense.
yeah, i think this is old - the new diff shows only `forms.py` as being changed.
"Versioning"
He is doing it the other way round, i.e. loop through all active plugins and check if there are in the black list, is_plugin_active() would require knowing the plugin path
s/environemnt/environment/
Because include_once, like include, require, and echo, is a language construct, not a function. While the PHP parser tolerates this use, it is not correct. You can see examples of this syntax in use in the documentation on include: http://php.net/manual/en/function.include.php and an exploration of the differences between language constructs and functions in this Stack Overflow thread: http://stackoverflow.com/questions/1180184/what-is-the-difference-between-a-language-construct-and-a-built-in-function-in

From PHP documentation:
"Because include is a special language construct, parentheses are not needed around its argument. Take care when comparing return value."

From StackOverflow:
"A language builtin is faster to call than a function. This is true, if only marginally, because the PHP interpreter doesn't need to map that function to its language-builtin equivalents before parsing. On a modern machine, though, the difference is fairly negligible.
On 09/26/2012 07:16 PM, jguiditta wrote:
>
> In app/models/image_management/provider_image.rb:
>
> >
> > +    attr_accessible :target_image_attributes
> > +    attr_accessible :status, :status_detail, :progress #, :as => :image_factory
>
> Is the comment above something we expect to need/use later, or a 
> leftover that can be trimmed?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/aeolus-incubator/image-management-engine/pull/20/files#r1698592>. 
>
>
This is a reminder that we may have to add in permissions on 
image_factory attributes.
I don't have a better idea off the top of my head, but I think you can still find a solution. All I am saying is that we should not use FactoryBean this way. So, back to the drawing board. I'll think about the problem in more detail as well, but this is your issue, and I'm sure you can handle it alone if needed. I'm simply saying we can't abuse the FactoryBean contract. That's a line I have to draw. Sorry.
Why? I think if we want to keep consistancy, we should display similar messages in each action...
`if (callbackConfirm == null || !$.isFunction(callbackConfirm)) {`
or
`if ( callbackConfirm == null || !$.isFunction(callbackConfirm) ) {`
choose one, but do not mix spacing.
Why is this being commented out?
@nukulb Are you ok with the addition of the jake clean task? 

Additionally, should we also clean native
Nice use of reduce
Ympäröivä `if` on tarpeeton. `(== (mod n divisor) 0)` tuottaa jo itsessään halutun tuloksen.
What are _functional_ tests (not sure)? Thanks!