labofsahil/github-event-dataset-2012 huggingface dataset:
Would prefer only to call the `.where(options[:conditions])` if conditions are present - but didn't want to move too much around in this first take. Suggestions?
Would that make the condition $this->_modelName === false true?

On Thu, Mar 8, 2012 at 12:43 PM, Qiang Xue <
reply@reply.github.com
> wrote:

> > @@ -32,6 +32,7 @@
> >       private $_errors=array();       // attribute name => array of
> errors
> >       private $_validators;           // validators
> >       private $_scenario='';          // scenario
> > +     private $_modelName=false; // model name
>
> No need to initialize. The default would be null.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yiisoft/yii/pull/471/files#r535168
>
В connect'ах вместо const T& можно спокойно писать T — для connect'а это один хрен, и на производительность не повлияет никак.
Readability nit: please use consistent quotes (double or single.) Since this file seems to have more doubles in it, I'd say go with that throughout. (Unless there's a functional reason, like convenient escaping, to use single quotes)
Noted. I try to keep comments as full sentences. (Though of old habit where I used headline style of sectioning code I still stray a lot.) Will make sure to proof read before pushing.
This part of code is common databox_abstract, please refactor in parent
Remove this doc blocks
Can we move this to a method on User and change it to use `where(...).first!`. I believe `find(:first, ...)`, `find(:all, ...)`, etc, is being deprecated or removed in rails 4.
If there is, it serves people right for calling `arcT` with those arguments.  I doubt such an arc would be visible anyway.
I think this patch goes to far / does the wrong thing here. All I want is an exception to be triggered when somebody tries to use the client library to take off and the battery level is below 20%. This patch will constantly emits errors when the battery is low, and will also never trigger an exception (because of the way `_maybeEmitError` works).

Let me know if this makes sense.
Okay, I will tweak the targets to support that workflow after this pull request.  Will go into master though, and be dead simple so I can merge it directly.
if the instance is fresh would you ever be able to get a guest and delete the queue?
So at what stage does this actually get cleaned up from the transaction table?  When the transaction manager calls rollback()?  If so, that makes sense if using an XA transaction but does this also work with Synchronizations?  Or have we now got a mem leak?

Test for this?
getCacheName() includes the cache mode as part of the name. Is that the only way to make the name unique?
Yes totally, sorry, my above comment was agreeing with you.
This doesn't need to be on a separate line.  Apart from that, I think this PR is ready.
Map lookups are relatively expensive vs. other types of access (struct values, sequential arrays, etc) so we want to avoid doing them multiple times if possible. It's possible that the compiler will optimize this away in some cases, but I don't really know if that's the case, it'd probably be best to assume that it will not. If you want to avoid having to allocate and GC a new variable for every message (which is A Good Idea™) you could put another variable in the StatsdOutput struct and reuse it for each message. This is safe b/c we're now creating a separate instance of each output struct for each individual pipeline pack, i.e. each output struct instance will only be used for one message at a time.
we could transform to str in the method
Added a bunch of test strings for this and also a couple strings that *shouldn't* match, and they seem to work as expected.
With the same approach in `test_music`, can we check for enumerated videos before assuming there is one to click on?
I'm not sure I understand why you had to match all urls  and then exclude the ones which weren't commented. Wasn't possible to match only the uncommented urls?
Yeah maybe but we shouldn't rely on external libraries to clean up our code.
@arnodeclercq missing space after `,` and could you also define all the selectors on the top of this file?
This could implement just `AllResourceTypeIndexingHandler` since it extends `IndexingHandler`. Might be a little confusing to future readers to implement both.
What is a "selected"?
formatting is still strange should be

{
*tab*for (int32_t i=0; i<size; i++)
...

and any indention level is one tab not a space or so
Please use braces here instead of just a newline and tab to represent code within the if block. http://doc.silverstripe.org/sapphire/en/trunk/misc/coding-conventions
pls add some spaces - after if and between ){
We're actually only asking them to reinstall if they came from alpha.

"To upgrade from the alpha versions (<= 4.4.2) of LunaCE to the beta version (>= 4.5.0) ...."
We are not interested in the actual english message of the exception. It is irrelevant.
Could you add a ``@return`` annotation? I also found this on lines 173, and 183.
Should the return type not be ``*``? Maybe you can also make the array more specific, something like ``array<String>``, or ``String[]``?
newline is one word so it should be `_insertNewline`.
Delete benötigt evlt. auch noch ein Parameter, bin aber noch nicht sicher...
Would +[ NSData dataWithBytes:length:] work better here?
Our general style is to use can.
hot!
No, just come to see the great detail
I guess there could be a possibility of checking if the setting is set prior to call parseTests. This could be cleaned up but a major refactoring on the device management would be better imo (using IDevice from ddms rather then executing ADB calls). I did not have time to fully look into it yet but playing with the idea. There would be a possibility to have something along the lines of:

executeSQL <= (devices in Android) map { d:IDevice => d.executeCommand(...) }

As such, instrumentation could be used as above and so would logging.
``` js
var border = '1px solid #123abc'; // allows js compressors to do their job
el.style.border = border;
var returnsBorderInWrongOrder = (el.style.border != border);
```
Oh I did not know about  `__autoreleasing`
This is not "internal error". ;-)
*confirm this e-mail address.* -> confirm for what? An user could forgotten what is this about. Or some other recipient could not know. Maybe better something like `confirm this e-mail address as yours for your account on {{ site_name }} with username {{ user.username }}`
```(new Date().getTime() - Date.parse(post_date)) / (60 * 1000);``` is better.
Nope, get an error
Why to flags? You have three possibilities:
 * show station and current data
 * show station and old data
 * show just station (so that we know, that there is a station)

So what exactly do you get by 12 minutes and 10 minutes limit? What means if something is between 10 and 12 minutes? If you think of trying to  get locations with this approach, it will not work, because if last update was older than 12 minutes, you will not get anything. So why 12 minutes?

You can have a cut at 10 minutes for old 1.) and 2.) above. If you want to support 3.), you have to do it through aggregation in database.
No need for `name=` parameter, by default it is the same as name of the function.
`wrapDivide` should probably be renamed `wrapQuotient`. The primitive could be renamed to `integerQuotient` too.
Get the path names from the stream def
I didn't mean `SpecificationIsNotNullWhenInitializedWithConstructorWithoutSpecificationParameter` - I meant `CreateWithAbstractionRequest_DelegatesObjectCreationToDecoratedBuilder`
to be honest, I'm not really sure. I'm mostly following crawl's instructions on compiling from the source (http://gitorious.org/crawl/crawl/blobs/master/crawl-ref/INSTALL.txt, line 214 ). it seems, however, that the only officially supported compiler is gcc (same doc, line 49).
Yeah, I saw that on other places, will fix :)
klass in this case will always be a descendent of ClassyEnum::Base, so this will never be true. Since it's a hack until Rails 4.0 comes out, I wouldn't be opposed to just rescuing NameError for cases when it's not using active record. Or maybe there's a more elegant way to handle that.
99.99% of the time, if you see "printStackTrace" in your code, that's wrong. In this case, loadHashTable should be declared to throw a FileNotFoundException, and initialize should catch this and re-throw it, wrapped in a ResourceInitializationException.
Prefix with `\`
I remember @fabpot putting ☃ some place in the code. I guess it was an test. I'll fix it.
I don't like this switch. What is fundamentally different about the integration environment that we have to essentially put if statements in front of a whole bunch of functionality?
10:13:53-~/github/BrowserID-Tests$ git submodule init && git submodule update
fatal: reference is not a tree: 529faac40f23bd061dbc14d136fa3c6bb4eb6100
Unable to checkout '529faac40f23bd061dbc14d136fa3c6bb4eb6100' in submodule path '123done/browserid'
> Tell me if I am wrong, but it is my understanding that one of the main reasons to introduce promises in Jetpack is to encourage/enforce asynchronous > programming. If you start building code that relies on order of evaluation, you are effectively introducing hypotheses that will all fall down and crumble > once your code is effectively asynchronous/multi-threaded/multi-process.

Let me try to put it other way, if you deal with async computations using promises order of handler calls will be FIFO,
now if you don't guarantee the same order in a non-async computations it easy to catch someone by a surprise.

Now even if you disagree with above statement I think it's important to be complaint with behavior of Q which happens to be FIFO.
It applies to the request headers and body, and response headers. So this is a simplification. Maybe `Show requests and responses in parsed mode`, to reflect that this is modifies how _and_ what is shown?
Isn't this generated? How come the 1.0 file has this now?
CentOS, in my case. I neglected to check other distro's naming schemes for packages. Thanks!
pool_ = NULL ?
Could you please add license header to the top of this file?

The one like in the file buildtests/basic/test_site.py.

Could you please also add a comment what the test is supposed to test?
``if not igls``
Does this really need to be a decimal?  We can assume some standard number of days or weeks in a month, like 30 or 4.
shoudln't it be ``Solarium\Core\Client\Client`` according to the check in the adapter ?
You don't really need this, right?  Anything you pass in is automatically put on @options isn't it?
Note: I'm including json versions of the config files, so people can use that format if they prefer.  (I don't, but with David's idea for how to include comments, they aren't as bad as I had thought.)
I just tried it, but doxygen doesn't find the mainpage text if we do that.  I also tried
```
<!---
@mainpage 
--->
```
(i.e. on 3 lines) but it still didn't work.
I think this is the line that is causing the test failure for me.  If scipy isn't present, it returns Da(z) = z.  So that screws everything up and the test fails.  I think this should not just throw a warning -- it should throw an error.  And for now, our tests should catch that error and issue a warning that scipy is required for anything that uses Da.  Then we should open a new issue to get this integration pushed down into c++ so we don't need to depend on scipy for this functionality.
Could this "Note that the referenced `Interpolant` is not copied, it must stay in existence" be a problem in practice for realistic code usage?
Shouldn't this be a require on the zendserver::package class?
Perhaps worth overloading with a version that takes a Function<List<String>,?>.
Otherwise, it can't be easily used from Java code.
Need `ConfigSensorAdapter.apply` to publish attribute sensors from config keys.
And/or autodetection of protocol based on presence of SSL_CONFIG ?

And something smarter around SERVICE_UP so that UP=true iff >= 1 child is UP ?  (if not too tricky)
seems like this should be a uint32array, since it's counts.
it have argument name by default

On Wed, Nov 21, 2012 at 5:17 PM, ddurnev <notifications@github.com> wrote:

> In
> frontend/src/main/scala/com/griddynamics/genesis/rest/ProjectsController.scala:
>
> > @@ -51,14 +51,14 @@ class ProjectsController extends RestApiExceptionsHandler {
> >
> >    @RequestMapping(method = Array(RequestMethod.GET))
> >    @ResponseBody
> > -  def listProjects(request: HttpServletRequest): Iterable[Project] = {
> > +  def listProjects(@RequestParam(required = false, defaultValue = "name") sorting: String, request: HttpServletRequest): Iterable[Project] = {
>
> Request parameter name is not set?(value annotation parameter)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/griddynamics/OpenGenesis/pull/620/files#r2193490>.
>
>
I'm using it with a slash for my own project. Seems to work just fine "/path"
Why does this exist as well as the one for `body_content_title` and why do they differ?
I think the html code will be more semantic with headers:

    <div class="block-documentation">
        <h1>Documentation</h1>
         <ul>
             <li><a href="http://symfony.com/doc/current/book/index.html">The Book</a></li>
missing webinos header
You don't need these methods if you extends OBController
If you have it like this, you can remove the text() part.
user.visible_message("\red \The [target] has been smothered with \the [src] by \the [user]!", "\red You smother \the [target] with \the [src]!", "You hear some struggling and muffled cries of surprise")
s/beofre/before
I think this should be:

```ruby
if web_srv == "apache"
```

AFAIK, one should not compare symbols to strings. web_srv is a string, no?
Комментарии принято писать перед тем, что они комментируют.
Это некорректное условие.
Строка 167 этого файла это не то, что Вы ищете?
Этот тест не будет работать, если запускать не из IDEA.
Do we really  want printlns in here?
indent this, and on the line before, mention that this is the output of the comment.
Also should this be in a specific class not the Base class?
Thanks, I've updated these to str.format().
I think we should keep it like in xbmc configure :

  powerpc-*-linux-gnu*)
     ARCH="powerpc-linux"

That would be consistent and avoids confusions.
> Also, can you comment on the drastic difference in values of sigma_color and sigma_range?

`sigma_range is in respect to the x, y position
`sigma_color` is in respect to range of color values, here [0, 1] as we use `img_as_float`. If we pass an ubyte image, we'd need to change the sigma_color accordingly.
Thanks for giving that a shot. Good to know.
I'm sorry I should have been more explicit about which code I'm talking. 
The int/int wasn't the problem in this case, but thanks for the reminder I still fall into 
this trap from time to time.
I was referring to the out commented code in  your gist:
https://gist.github.com/2979853
Maybe the compiler is smart enough to move the checks outside of the loops and write the 4 variants already by itself.
з блоками я бачу проблему. назви блок sidebar і виводь туди потрібний контент.
разве так в фикстурах обмен данными происходит?
http://symfony.com/doc/current/bundles/DoctrineFixturesBundle/index.html#sharing-objects-between-fixtures
there is an issue here: if you pass ``false``, it won't disable it as ``false or true`` will give you ``true``
This also seems like odd formatting.
La version stable de l’API Phraseanet est la 1.2 sur les versions 3.7 de Phraseanet.
s/collection/array/
no need to comment out code, just delete it (thats what source control is for)
Actually, you're right. It's not an issue.

Although, I'm not sure how this compiles without warnings since path is const and it's being changed. I'll clone and compile your code, but I might be interrupted by work. It could be a few hours.
Looks like this is setting CRC32 crc = 0 , but it has no operator= ?
I decided not, partly because the timings have moved to stderr rather than stdout (so that eclccserver can process them), which confuses ecl run (which for some reason is setting verbose on the eclcc instance it uses to crete the local archive), but also because it's more flexible to specify them separately rather than have one imply the other.
Minor point, but I like to see such 'free' constructs, are guaranteed to call, e.g. if populateFields threw an exception it would not and leak.
So I'd prop wrap with all with a try catch and ensure iruFreeUriMembersA happened.
Agreed, I'll change.
'meta' leaked, shouldn't have passed ownershipt to getRowAllocator...
ultimately RoxieEngineRowAllocatorBase and it's member, CachedOutputMetaData, links the meta.

So this sould just have passed in meta (without the .getClear()), i.e.:

> keyLookupAllocator.setown(queryJob().getRowAllocator(meta, queryActivityId()));
I thought about that, but there was no reason, so far, to keep them there.

I don't intend to build strings on the URI class, maybe another, maybe later. But for now, this can stay here...
btw, it should probably be better to check with ``assertSame`` here
We discussed this and I don't think we agreed to switch from this well known pattern on the web. In a way it may be a misuse but so is double negation expressions instead of type casting `!!foo => Boolean(foo)`. It's not about size constraints it's about convenience. Also note that we use this form in many other places in the code, if we decide to switch we will have to change code in all these places and in any case it will be a separate task.
In that case channel based approach is probably better.

I would not put `read` in url module though, ideally our url module would match the one [from node](http://nodejs.org/api/url.html) so I would prefer not to increase difference even further. Also I think function / module name should be explicit about the fact that it reads only content from the local fs and not just an arbitrary `url's`. Also I think function should verify that given `url` is local one regardless of the fact that we do validate `pageMode` options since it may be misused in other contexts.
You mean the line that was removed..?

On 20 Feb 2012, at 07:27, Marc Bennewitz wrote:

>> @@ -73,7 +75,12 @@
>>     public static function factory($options = null)
>>     {
>>         if (null === $options) {
>> -            $options = array('Zend\Loader\StandardAutoloader' => array());
>> +            if (!isset(static::$loaders[static::STANDARD_AUTOLOADER])) {
>> +                static::$loaders[STANDARD_AUTOLOADER] = static::getStandardAutoloader();
> 
> should be static::STANDARD_AUTOLOADER
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/802/files#r466144
Formatting question: Why indentation?
Nice addition here.
Is there a specific advisory for this vulnerability? Please would be nice to avoid general url's
Would look better as:

```ruby
while packet_len > 0 
```
Yeah. Actually users can easily convert an image to binary by simply use ```binaryimage = image > threshold``` that satisifies their need.
Maybe "threshold" should be changed to "offset". Alternatively, both `offset` and `image` could be converted using `image_as_float` (I think), but this isn't really necessary since the image is used internally an then gets binarized. Although---at some point---we may think about calculating the local threshold using a function (instead of a fixed offset from the mean), in which case using `img_as_float` may be necessary.
Does this work reliably for you? From my experience back on Windows, it was not uncommon for `show` to do nothing, when it was called in the middle of some other command.
While I'm OK for this particular test, we have to be careful about taking white-box testing too far in general.  For example, we agree that a benefit of tests is that they allow us to change the implementation, rerun the tests, and be reasonably confident that our changes were good.  If I rewrote the other `equals` function to not delegate (unlikely I know), we would no longer have a test for this function, so if I also rewrote this function I could have broke it without knowing unless I ran code coverage.
Good eye.  Let's fix this now.  See 759c24f9d4c2d51c53ee70a75682c62d7e5c7358 and da5ce39ace033e8696dea9807b3b7fd1f7114c6.
why not call self.bind(....) if u are only binding one event?
Mmmm, we will see all normal build errors if there is a failure during packaging.  We should also see failures when the template resource are copied into the build location.  If we are thinking in terms of some kind of checksum almost to guarantee that all the tests made it into the harness then something more robust than this is really needed IMO.  Once the files have been copied into the normal app Resources directory any packaging sanity checks fall to the build script I would think since it is no longer a Driver mechanism.

All that said, I may just go ahead and make the test stricter and finish the test pass if the specified test is not found (same as suite).
Ah, it can be removed. It's a copy paste from my other script. It can be useful if package is installed via composer. But I doubt someon will do that with Silex-Kitchen-Edition.

BTW, I just notice that you have wron package name in https://github.com/lyrixx/Silex-Kitchen-Edition/blob/master/composer.lock#L5, copy-paste as well :)
Oh, fine. I somehow thought it was well over 80. Will do.
equal alignment !
do we even need them anywhere still?
It looks like this returns data, not a query string.
No need to send the JS files for every single page on every page. (i.e., no need for registration JS on the pharmacy page).
Need to apply this change to `receiveSubscriptionMessage` too.
These lines solve the Serialization issues (#23, #24 & #25)
`add_suite_names` or `add_names`
I reviewed the codebases of ZF, Symfony, CI, and others. Even in the same projects, I see mixes of "else if" and "elseif" (which I didn't really expect). I don't think `else if` with the space is *more* readable; I think it's *as* readable. I'd also argue that saving a space might be important because of line line length, but it's probably not *that* important.  Maybe the guide could read "whichever you use, use it consistently throughout the project."
I modified the bit in the UsersController so that it's two separate code paths now. Right now I've removed the message when switching companies but we can make that whatever in the future.
fair enough. Better to just remove it entirely.
What about that comment about purity? Wasn't it supposed to be legal to call unpure functions in debug statements?
Yes, I agree. 
However I like your solution with third table :-)
Allows you to obtain the path to any defined local storage resources for your service.  For example, the 'DiagnosticStore' resource, where Azure logs are collected is a local resource that is defined for every Azure service.
The two foreign keys are missing a translatable ``verbose_name`` keyword. Would you mind adding those?
Actually, instead of a double slash, the class name should be surrounded by "``" marks. ( @Freeaqingme -- double-slash was necessary as it's always interpreted as a control character in rst -- UNLESS it's part of a literal)
Since game_done is a "destructive" method, you probably want to signify that with `game_done!` .. the bang at the end of a method indicates (by convention) that this is unsafe.
`count` kutsuminen tekee tästä tarpeettomasti O(n^2) aikaisen.
`modles` &rarr; `models`
Isn't this redundant with the test :
if scheduler_url is not None and prefix is not None:
    raise Exception('You may not provide both a prefix and a scheduler_url.')
in the Link class
I think I was having in mind, whether the original code mentions that it is
thread safe or not and whether you checked the code itself. Banging on it
is a brute force which may never detect a potential thread safety issue :)

On Fri, Mar 9, 2012 at 9:52 AM, Zoran Simic <
reply@reply.github.com
> wrote:

> >   * @author ypujante@linkedin.com
> >   */
> >  class JsonUtils
> >  {
> > +  private static final jacksonMapper = newSortingMapper()
>
> Yes, the mapper is thread safe. I have tested the console under heavy load
> with a big JSON object to (de)serialize.
>
> I'm rewriting the little program I wrote for this so that it doesn't use
> anything linkedin specific, and will send it to you for review. The program
> will do this:
> - be able to generate a huge JSON model and upload it to one's dev console
> - be able to perform N waves of M simultaneous 'status' requests to the
> console and show how much time it took to perform each wave
>
> I've tested this by hammering the console with waves of up to 200
> simultaneous requests.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/linkedin-utils/pull/6/files#r538147
>
the cachedConcepts property and methods should be moved to PatientSnapshot
You can copy the lines from one of the other projects' AssemblyInfo files.
We're only testing against 2.1 with composer. Is there an easy way to bring back 2.0? I'm not that fussed about testing against 2.0.
There is no object to xml serialization capabilities in the Python standard library.  

The order of the elements is significant when generating the xml, and sometimes data needs to be converted.  

We could refactor to reduce the amount of code, especially the duplication of the start and end elements.  We could also use the DOM to create the nodes, but that doesn't seem much better (although that's what node.js does).

As far as maintenance goes, we haven't had problems so far.  We like having the element names fixed (instead of dependent on the parameter or member names, which does seem like a maintenance nightmare) and the serialization easily readable.

I'll start on some refactoring to see how it looks.
怎么能这么做呢？太糊弄了。太影响程序的灵活性了。

把link字段改为diff，内存diff表的id。
What is `fields` module here?
Can we keep the existing style please.

self.object.save(**kwargs)
"parameters validation" = "parameter validation"?
Does it depend on how you create it? As I remember you created this code: 
https://github.com/Islandora/islandora/blob/6.x/api/fedora_item.inc#L1494-L1498

Which I think will set the owner to anonymous.
yes. You are right (like always). I'm creating a new commit.
... "and taking screen/view density into consideration."  (I think it does that anyway.)
We should also mention tabBarHidden, a property on windows themselves, that can also cause the tab bar to be hidden. In that case, however, the back button is still visible in the nav bar.
link to ekb-manual-chapter
Same feedback here.
It just loops through the properties, and if one exists, it returns that the obj being tested is either non-empty, or empty..
these two lines can be combined into a single line since value is not being used anywhere else
Could the pre-process module return the data in memory and we could avoiding making temp files?
Try to enable if this test comes first
chris submitted the pull request
must be HIS problem!!!
consider adding a visual feedback for errors