(#16376) Fix rails compatibility layer for activerecord < 3.0

Previously an alias was attempted between scope and named_scope to allow older
activerecord versions (< 3.0) to work with the inventory service while also
supporting modern activerecord. The scope alias failed because
Puppet::Rails::InventoryNode inherits from ActiveRecord::Base, which has a
scope method already. So activerecord's scope method is found instead of the
intended alias target. This commit removes the alias and simply switches on
activerecord version to use the correct scope (AR >= 3.0) or named_scope (AR <
3.0) method.
fail better in package repo rake tasks

This commit modifies the top level Rakefile to only
load the packaging repo yaml file if it exists, as
well as provide some error handling for other unwanted
conditions that may arise as a result of trying to
set up the packaging repo.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Merge pull request #1171 from MosesMendoza/maint/2.7.x/cleanup_package_repo_rake_tasks

fail better in package repo rake tasks
(#16585) Remove dead ldapnodes setting

This setting has been dead code since 0.24.0, and its value is never read.
This commit removes it.
(maint) Add .yardopts file

This patch makes it easy to generate documentation, including private
methods.  The assumption is that code will be marked up in markdown
style yard comments.  YARD tags are documented at: [YARD Tags
Overview](http://rubydoc.info/docs/yard/file/docs/Tags.md)

The YARD documentation is currently intended for Puppet developers and
community contributors.  While useful for end users, YARD documentation
is not intended for new users or end users who are not developing on
Puppet.
(maint) Add yard generated documentation to git ignore

This patch simply adds the yard generated documentation to the gitignore
list.
(#16637) Add spec test for non-root puppet master confdir and vardir

This patch simply adds test coverage to catch regressions in
[16637](http://projects.puppetlabs.com/issues/16637)
(#16637) Fix default confdir and vardir with puppet master as normal user

Without this patch `puppet master` will select the wrong default confdir
and vardir values when running as a non root user.  This is a problem
because permission denied errors result trying to create the system
directories when running as a non-system user.

This patch fixes the problem by removing the explicit check for the
master run mode in Puppet::Util::RunMode#which_dir
Merge pull request #1136 from haus/ticket/2.7.x/16376_update_rails_compatibility_layer

(#16376) Fix rails compatibility layer for activerecord < 3.0
Merge pull request #1194 from jeffmccune/fix/3.0.x/16637_default_confdir_and_vardir

(#16637) Fix default confdir and vardir with puppet master as normal user
(#15717) Require puppet/run in the agent

Commit 81c73fd0d0d0a9ad4a7f2cb5386d5956739a89aa had accidentally removed
any requires of the `puppet/run` file and so the code needed for kick
was not being loaded. This adds loading of that file back into the agent
application.
(#15717) Allow pluginsync as an option to Puppet::Run

Commit 62420c6ff02133e7bf6254cff83ddb3511a1ea41 changed the way that
agents decided to perform a pluginsync to have a flag passed in. The
initialize method of Puppet::Run tries to validate the options passed in
and failed when it recieved the new option. This makes the new option
validate and restores the ability to use puppet kick.
(#16757) Only load rubygems in bin/puppet

Under some setups it is necessary that we don't load rubygems ourselves (such
as running bundler in stand-alone mode). This change gives the user control
over loading rubygems, at the cost that they are now required to load rubygems
if loading puppet with rack.
(#16757) Don't load rubygems if bundler is running

If bundler is handling gems we don't want to load rubygems ourselves, as it
can conflict and cause loading of system gems beyond what bundler has set up.
Fix up dependencies for Hiera and Facter in RubyGems.

Since Puppet 3.0 promises to follow semver, the dependencies should take
this into account. This means now that only patch releases of Facter and
Hiera will be pulled in for patch releases of 3.0, and the version
dependency must be bumped for any minor or major release appropriately.

This also fixes a bug in the Hiera dependency due to the segment
comparisons in the RubyGems version resolver. Because there was no `.`
before the `rc` in the current dependency (`1.0.0rc`) this resulted in
the comparator looking at `1.0` and selecting the first version `>=`
than it, in this case `1.1.0.rc`. I assume this is unintended and that
the target was meant to resolve to Hiera `1.0.0`.
(#15717) Acceptance tests for puppet kick

Previously, the acceptance test for #3172 only verified that `puppet
kick` could be given a target host to connect to, and would verify that
exit code 3 was returned. This exit code can mean connect failed, which
is what the test was attempting to verify.

However, exit code 3 can also mean `puppet kick` failed to verify the
SSL server's certificate, or auth.conf doesn't allow access to /run, or
something bad happened on the remote agent end -- in our case #15717.

This commit updates the acceptance test for #3172 so it's clear what
it's actually testing.

It also adds an acceptance test to verify that the master can kick an
agent, and that the agent reports the kick was successful. It also
verifies that running `puppet kick` generates a deprecation warning.

While researching these issues, I've discovered that `--ignoreschedules`
doesn't work and hasn't for sometime, see #5975. The option is also not
documented in the puppet kick documentation.

Also, the `--pluginsync` option doesn't do anything, since in Puppet 3,
pluginsync is enabled by default, and the ability to specify
`--no-pluginsync` doesn't make much sense in an agent/master
environment.
Merge branch 'ticket/3.0.x/15717-puppet-kick' into 3.0.x

* ticket/3.0.x/15717-puppet-kick:
  (#15717) Acceptance tests for puppet kick
  (#15717) Allow pluginsync as an option to Puppet::Run
  (#15717) Require puppet/run in the agent
Merge branch 'ldapnodes_setting' into 3.0.x

* ldapnodes_setting:
  (#16585) Remove dead ldapnodes setting
(#16768) Clarify documentation about the purpose of --no-client

Per user comments on the mailing list and in #16768, they thought
a SIGUSR1 would trigger an agent running with --no-client, which
it doesn't.

This commit clarifies the documentation to match reality: only
a puppet kick will trigger an agent running with --no-client.
(#15717) Kick agent using its fqdn

Previously, the acceptance test would fail if `puppet kick` verified the
SSL certificate of the target, and the hostname it connected to didn't
match what was in the certificate.

The `agent` string contains the agent hostname as specified in the
configuration file, not the fqdn. Also, the agent and master may be in
different domains.

This commit modifies the test to query the agent for its fqdn, and then
puppet kick's that.