labofsahil/github-event-dataset-2012 huggingface dataset:
@resurtm this isn't a changelog about what changed in the docs, it should tell people important changes in yii framework.
It's just not maintained very well.

"git and hg support when generating blank application" - would be a better name for that link
Bouh!
Not sure why this is commented out? I would have thought that you would want to store what geometric field as associated with a data projection?
Implemented in newest commit
`SymfonyBridgesServiceProvider` should link to the symfony_bridges service provicer docs.
We should pass in `self` as the sender here.
этот `in` - баг, он расплодился в common
most likely.....
totally forgot about that....
I believe so - I've used that in some other places, and it seems to work ok.
The `is_localizable` check to show/hide the "Add translation" button is covered by a previously-skipped test. It fails if the button is there when the doc is non-localizable. Need to update that test, too. Probably worth a follow-up bug to rework.
I think that it would be better if these get methods themselves would assure type safety, so type cast it before returning.
1. We don't follow the js convention? (Oh yeah...  I read a little about that in a comment above)

2. Hum... I thought had deleted that if... I'll take care of it.

For a language that has a convention I don't understand why we shouldn't follow its convention.
or in_array as you dont need the key value
$proper is always true. this can be removed.
Different British and English rules I see. I will try to get around to fixing this during the weekend
space after metric?
It feels like this should be a module level constant like REEMIT_NAMES
Would `&& 'ontouchstart' in audioElement` make sense to avoid adding handlers that will never be removed again?
In general I prefer "builders" so we avoid the assumption about whether there's a / needed or not. But +1 :).
We wouldn't do anything with privileges, yet?
The indentation in this file looks a bit off
https://github.com/alexanderbeletsky/Nancy/blob/7f53e86ea3ef5c813fb9ffe37d2032cbc6ea65c5/src/Nancy.Tests/Unit/StaticContentConventionBuilderFixture.cs
remove? needed later?
This is not your code, but I'm aching for bracing here.
This change does NOT make replicated table writes single-partition compatible (as it shouldn't) -- they continue to fail that test by virtue of having a collector fragment.
Yes, yes it is , for shame.
Does the call actually throw an exception or do you just get different hostnames every time?
I personally like this, but @fahad19 expressed some dislike about having this/similar method in croogo before.

But with php 5.4, we can use json_encode with JSON_PRETTY_PRINT flag.
explicit comparison.
Replaced with attributes created during Option.contribute_to_class()
please use `let` instead of before and instance variable.
And that's perfectly fine that Django and Celery use factories. But we're not discussing those codebases. I don't see the necessity for this abstraction. You either create a mean curve writer, or you don't. You either create a quantile curve writer, or you don't. That's 4 lines of code.
We can do those changes in later fixes.  Assuming bash for now is reasonable.
where'd this go?
As a general rule, since this is duplicated, it should be in a variable. Whether or not it is smaller to do so, it is easier to maintain.
This lost a change that was added recently. See 44011450d56fec8fb29e2c10e2cd894c51127a94
We have as convention that italics indicate placeholders. Still, it might be helpful to add that <em>distribution</em> stands for beta, binomial, ...

As fpr parameter1,...,3: That's a somewhat informal usage description. The distribution functions have different numbers of parameters, ranging from 0 to 3. But then, I don't want to list all distributions here, because that kind of prevents seeing the forest for the trees.
Then, the weight for stateRight would be 0. So no need to make this a special case.
`json` can throw `OverflowError`, but only if you ask it to *not* check for cycles in the data structure. By default, it checks for this.

IMHO it's more important for the developer/user to get useful tracebacks from Python made available in JS to help debugging than to hide the file paths to the Mopidy source on the server.
There's definitely a race condition here where if there are concurrent pipelines processing items, both could simultaneously get a no-match on the sitescan and then both create it. I wonder if we should have a unique constraint on `(batch, site_url)` to prevent that, and then use Django's `get_or_create` for a non-racy alternative (this would require switching MySQL from `REPEATABLE READ` isolation level to `READ COMMITTED`).

Ideally there would be way to pre-mark requests/items with the appropriate sitescan and not have to do this whole get-or-create business at all.
Denne lina er litt mistenksom. Er KGB på ferde?
We don't depend on gfortran directly, but rather call `ENV.fortran` inside `def install`.
>Is fails_with really the "right" way?

No, the right way is to force the Makefile to use the compiler we set in the environment; then there won't be flag mismatches like this..

>It also needs libz as a dependency, how do I add this? 

libz is part of OS X by default, you don't need to specify it as a dep.
Better tools for operating on arbitrary numbers of objects. I'm going to try out a mechanism for that now.
Ok. Will remove the word comment.
I like it.

Just a quick note: You need the possessive `'` (user's). Please try to pay a little attention to this as it seems I'm correcting you on each of them.
In the Introduction section above (can't link directly to the line, or at least can't figure out how), if you are going for total completeness there's also package groups and categories. I think it reads fine as is (could even delete DRPMs), but throwing it out there in case you wanted to add an "etc." or something.
ok, verstehe..
Same note as above re: `abort`.
@shingara just remove it from gemspec. We'll rely on gemfile from devtools for *all* develeopment dependencies
whoa, is that an old-school xdoclet annotation? Haven't seen one of those since 2005
Can you also create assumeThat(String message, T actual, Matcher<T> matcher), and use that here?

Sorry, I should have caught this in earlier review.
4 spaces in the source, not sure if you're seeing something different?
The following code (to the end of the function) feels like it knows too much about the guts of editors and inline editors. Could we add a new method on Editor with this code in it, called something like `refreshAll()`, and just call that from here?
The high ascii version was the original filename, but github.com couldn't handle it. I renamed the file to low ascii, but forgot to change the comment. :(
We might want to put this chunk of new tests into a separate describe() block -- we already have tag names & attr names separated out.  (I know it's the same provider object, but semantically attr names & values are pretty separate sets of tests).
This is basically the same as my earlier question with endQuote but: when does this happen?  I can't seem to get code hints to appear when the attr value is unquoted or when there's nothing written to the right of the '='...
don't know how i missed that, thanks!
Agree, makes sense. It's in need of a refactor.
Any reason not to use a minified version of this?
FYI, raising a class instead of an instance is deprecated: http://www.python.org/dev/peps/pep-0352/#transition-plan
This is a random place to point this out, but it might be nice if index was named SelectedClipIndex or something along those lines to make it very clear what it is.
No java logger, we are using Log4j.
Something like:
```java
Logger.getLogger(ChoroplethDataModel.class).warn(...);
```
(this is not the same Logger class, it is the one from log4j, which is already in our dependencies)

Question: if the error is so severe, why is it swallowed here? Shoudn't you propagate it?
Remove TODO?
No space before `:` please.
i guess nobody is ever going to write a test where they click next without filling in the email field.
Are you just sneaking this in here? Doesn't look like it has anything to do with z-index.
We don't want to leave Lorem ipsum in here.  What's your thought about having this area?  If we're not putting anything in it, let's dump it.
Space right bracket
I still think we may need to throw or handle this some other way, what about IE9? https://developer.mozilla.org/en-US/docs/DOM/window.URL.createObjectURL
I know this is nit-picky, but I'm *trying* to reserve camel-case tokens with first capital letters (like `UnloadDialog`) for classes and namespaces. Something like `UnloadDialog.init` fits better. I realize that it's a bit longer/messier/etc, but in trying to make staring at Butter's code as painless as possible, I'd rather enforce this small formatting requirement.

To clarify, `EventManagerWrapper` makes a bit of sense since it's actually extending this class here, but UnloadDialog does something completely orthogonal to the scope of `this`, and it's not really a class we're going to hold on to -- it's just a function that runs once, right?
Can we make tight loops out of these?
Based on the commented code doesn't look like we need any of these buttons or the title var.
yeah usually it's just for readability .. like for (var i = 0; i < whatever.length; i ++) {

but if it's already like that everywhere else I guess you can leave it.
The idea is that maybe the epg info is totally f***d up and we want to update it from scratch. That's why I'm clearing it first
The encoding option here is interesting.  Is this the same as Medistrano?  Can we be sure that the PDF will never contain any characters that are only supported in Unicode?
Will update Javadoc. "Designator" is a dropped idea that was present initially (ability to "target" some parameter per proxy repository, not available anymore as pool is shared).
mutax -> mutex
这个文档里面没有写，加上吧。
`function(alpha='one', beta='two')` というコードがあって、カーソルが `alpha` にある場合は `index=0` ですが `'one'` にあるときは `index=1` になるみたいですね。これが `(1- index)` の理由でしょうか? これはあとで本家に報告しておこうと思います。
I would write this in Bash :-) ACK
??? so there should actually be:
validator.require('name')
instead that one_of?
So I assume its not needed for RHEL6 anymore. But how about RHEL5? I am not sure if we support this for CLI.
@xsuchy, with the changes introduced, the product will not be None.  If the user were to enter a product name, label or id that is invalid (i.e. doesn't exist on the server), the products structure will be returned; however, it will have len of 0.
mach das bitte anders
If this portion of code is not needed, please remove it: no reason for commenting out code that is not used, given that we have a version control system.
If somebody passed in a 1-tuple this will not work the way you want it to.

I would have written this code by building up a format string more like this:

```
if pad:
    pad = 2
else:
    pad = 0

if not isinstance(sep, tuple):
    sep = tuple(sep)  # Note: This will convert 'hms' to ('h', 'm', 's'); a potentially nice shortcut

if len(sep) == 1:
    sep = sep + (sep[0], '')
elif len(sep) == 2:
    sep = sep + ('',)
elif len != 3:
    raise ValueError(...)

literal = '{0:0{pad}}{sep[0]}{1:02d}{sep[1]}{2:0{width}.{precision}f}{sep[2]}'
(h,m,s) = hours_to_hms(h)
h = "-{0}".format(int(h)) if math.copysign(1,h) == -1 else int(h)
return literal.format(h, m, s, sep=sep, pad=pad, width=precision + 3, precision=precision)
```

Something similar in `degrees_to_string()`.
Is it possible to make the `.galactic` attribute (and corresponding attributes for other coordinate systems) show up in IPython tab completion? At the moment it's "hidden", which makes interactive work for people like me that tend to forget exact names harder:
```
In [10]: c = FK5Coordinates(266.404994802194, -28.9361739597975, unit='deg')

In [11]: c.  
c.cartesian            c.epoch                c.longangle            c.separation           c.x                    
c.dec                  c.is_transformable_to  c.precess_to           c.separation3d         c.y                    
c.distance             c.latangle             c.ra                   c.transform_to         c.z                    

In [11]: c.galactic
Out[11]: <GalacticCoordinates l=0.00007 deg, b=-0.00003 deg>
```
Right, that sounds good to me.
Candidate implementation in 63d90c957fb05e407132ee7931cc9348c874178a.  The only place it gets a little ugly is that `np.asarray` will actually accept almost anything (`None`, `dict()`) and then just make an object array which fails as an item.  So I check for the result of `np.asarray` being an object type with `item.dtype.char == 'O'`.  I am not sure that is universally the right thing.
This now fails with:

```
UnitsError: The unit parameter should be an object from the astropy.unit module (e.g. 'from astropy import units as u',then use 'u.degree').
```
Ah, I was wrong. This case *is* needed, because the `catch Type:Reason` below needs to catch problems that happen in the body of the `{ok, #fitting_details{}}` clause, like failures of `riak_pipe_vnode_worker_sup:start_worker`.
Agree, wll change.
You may want to check for the timer already active here with `isActive` "If the timer is already running, it will be stopped and restarted." so the start() postpone it. This is not needed in pollBalangeChanged as you already know that the timer triggered there.
Guess italic false is default, so this can dissappear.
I can try recheck that I was using the unit tests as the tool to cover those changes as it passed on tests I thought that this change was okay.
I guess what mark says is that you can cache the value of  checkEmpty, so it is not called per rule.
Strange, in my app code I already get phpcs errors for assignment inside conditional.
Yes, I forgot to remove the grouping, it was needed to make ```'10.'``` valid (but with ```*``` instead of ```+``` at the end).
```$dnum = "(?:[0-9]*[\.]{$lnum}|{$lnum}[\.][0-9]+)";```
should have been:
```$dnum = "[0-9]*[\.]{$lnum}";```
I'll amend it.
I'm not sure I agree with this change, shared_ptr *never* stores `nullptr` because you cannot have `shared_ptr<nullptr_t>` so it doesn't really make sense to say this constructor allows an instance to not store nullptr. I would suggest "non-null" (in lowercase) or "empty `shared_ptr` instance with a stored pointer that is not equal to `nullptr`"
Well, it is not an imported class but an ignored annotation
Missing spaces around `.`.
migrate down and delete this migration.
Good point. Nice to be learning about some of these different code smells.
Is not have **kwargs causing you problems?
To be consistent with the other examples, let's just use character ID 1.
The request is done on the LibGit2Sharp project ;) But it will not be possible immediatly https://github.com/libgit2/libgit2sharp/issues/143
In fact, using the command was, in my mind, just temporary...
OK I would prefer if we scaled the image proportions and font sizes in the same was.

But, have we asked the mpl devs about the SVG resolution question?
Why not use existing utils.path.get_home_dir, where you fixed this the first time?
no wildcard inputs; please revert this stuff
Let's not cast away the `const`.
>If you tell it it's both a local and a remote-tracking branch, you've failed so you get no love from the code :p

I'll add an assert detecting this

>I have to wonder what your plans are for remote-tracking branches. You (as the user) don't create them or are able to do much with them. It's fetch and push that modify them and trying to do so anywhere else is probably a bug.

Makes sense, indeed. I'll remove the `branch_type` parameter from the `git_branch_create()` signature. Would `fetch()` need a non externed version with the `branch_type` or do you think they'll be handled as plain references?

Regarding remote-tracking branches and local ones, I was thinking about adding (later) a `git_branch_lookup()` which would return a concrete branch struct. I don't know yet what the struct would expose, though.
Comments & examples.
I'll just nix the contraction. :)
Good point, I should clarify it as "last approved translation"
`for name in form:` will automatically use `iterkeys()` on it.
NIT: these don't need to be private variable names. You're using them in tests later.
Refactor the name to "$defaults" for more consistency with the "link" method
勘違いでした。
Should be `${project.version}`
I still don't feel that constants are warranted here, since these values are all only used within the class. Just to clarify, the getters I mentioned above are all along the lines of `countErrors()` or `countDeprecations()`. They don't have parameters, so you're never passing in the string values in question.

That said, if a few more people feel that these should be constants, I'd be happy to make a pull request.
you should reset the default vars too
I've moved the test for PHP 5.4 to avoid iterating when not needed. Good catch, thanks.
this is wrong as it will allow only closures instead of allowing any callable
this should use the short class name, relying on use statements (and it is wrong anyway currently as the leading ``\`` is missing to make it a FQCN)
You are right. I fixed my commit.
I don't think that the above suggestion would produce the same results.
Yep, you're correct. BTW, with this patch, there's no BC break with 2.1, PR updated
In some cases, they are not separable. I don't think it would be a problem to conflate them especially since the encoder is so simple.
There is no logout to import.
This was for functional review purpose only, fixed now
Personal preference would be to temporarily replace the cache dictionary. You solution is fine though (and I do not propose you change it).
*"...not correct"*
They're always the same.
We can't currently request maps from a different projection to the axes.
Does that remove this concern?
No normal user would come across it either? But it's a useful signpost & sanity check for a developer. And I suspect the interface between the Axes and the Feature will get more complicated in the future, so this will become more useful.
Понятно. Array - by reference. Спасибо.
Why are you moving this to every single view, repeating the code?
That maybe reflects how old this pull request is. ^_^

I'm pretty sure that originally the issue I ran in to was the tests passing locally and failing on travis, the difference being the jquery version.

Let me check to confirm that everything is fine without also watching 'selection', but I believe this is the case.
Can we remove this file? Unit tests must be enough to cover correctness of events.
Still need to merge the two `if` statements. If it works, also replace `!== undefined` with `!= null`.
It should be easy if you make your operations and at the end you divide by 10, and you add 'rm' instead of 'px'! ;)
`if (!telephony) {
  return;
}`

;)
this comment does not match the code (merge issue)
can we call it wifi-refresh-button for consistency?
That the modification we already discussed in bug 821334. We need to avoid calling setAppSize on foreground sms app when we receive the open-app event that is dispatched when receiving an sms.
it seems we need [one] definition to make this l10n work, although [one] is not a special case here.
@fabi1cazenave  this add the pressed state for the buttons in the header, also it provides disabled states for them.
And the important is needed because that pressed style is the same in all the skins.

I will take care with the `!important`:D
is there a change that any of the selected sms is a pending message (not a delivered one)?
Simpler to use .Compare with InvariantCultureIgnoreCase instead of lowering both sides.
This doesn't appear to support anything along the line:

    --option1 value --option2 command

OptionParser.order! seems to do exactly this, does the custom solution work around an issue?

http://stackoverflow.com/questions/2732894/using-rubys-optionparser-to-parse-sub-commands
#if !GLIB_CHECK_VERSION(2,36,0)
   g_type_init ();
#endif
In coffeescript you can interpolate: `$("#messages tbody tr[data-message-id=#{id}]")`
Also why is there a period following Max?
As a general rule, each use case should be in its own test method. To avoid the case when an early failure hides additional problems, and to have more control to disable tests using ``@disable``.
Sean posted a go fmt which didn't break `git add -p` - would be nice to have that incorporated!
s/ノードを識別するために利用する一方/ノードを識別するために利用される一方/
s/SSH コネクションに用います/SSH コネクションに用いられます/
Aww, snap! Shame upon me, I really was carried away with the idea of finding a concise solution to the problem, and overlooked this detail!
ok, this one is new for me, I did not know you can use spaces with quotes and alternatives here, looks more readable!
Alphabetical order, please.
Wrap property names and similar things (`src`, `dest`) with `code` tag.
Did you change this to avoid calling `splitWords` every time?
Depends which config file you're referring to. They're in `$HOME/.freeseer/logging.conf`.
We need to null `threadID` because 4chan doesn't like 'new' as a `resto`.
If i read things correctly is just the final  value returned by libmysql when the streaming of the query is done.
why not just

<pre>
d.addCallback(lambda _: self._fullClone(shallowClone=self.shallow))
</pre>

here?
Really, anything accepted by a ChangeFilter might make sense here -- repository, project, category, and codebase, at least.  But that still wouldn't cover per-file matching, or regular expressions.

I don't think we *can* version message key formats -- at least, not without sending duplicate messages with different keys.

So, all in all, I think it's best to keep the keyFields minimal.
neither `master` nor `buildername` is defined here..
ありがとうございます！修正します。
False? ;)
next 被修改了？！
{ at end of line, and } after the body.
Sorry. Too much whitespace!
With the extra indentation caused by the new logic this block of code looked silly. So, I refactored it out into the method above (_ensure_indexes_exist)
you should close the socket explicitly rather than wait for garbage collection to do it for you (if it ever will)
it's probably just 'spec/event.rb' not lib/spec/event.rb' right?
Example is also out of date see test for example
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/tests/test-xpcom.js#L75-79
helpful to have this example
IE8 unfortunately doesn't support Array.prototype.indexOf.
maybe we should do that sanitation *inside* our code running in the dialog, because we have to do that anyway?  (all of include.js runs in an untrusted environment, and we have to harden the postMessage API from the dialog side.)
should we be stricter here, just to prevent weird code paths? If there's an authority field and it's not a string, maybe that's a malformed well-known?
Agreed, so I'll write a quick + dirty format method for `String`.
__whimboo__ commented on commit:
> Has this already been moved over?

Yes! I did take care about this in ba06511 and 66c0392
@vrthra did you intentionally not `combine` the stdout and stderr streams here?
Thanks for the pointing out!

I do simplify this spec to `[].index.should be_kind_of(enumerator_class)`.
Because "what" is [already described](https://github.com/rubinius/rubinius/blob/04616454bfef4b5c1f230bffbc60597debcc649f/spec/ruby/core/array/shared/index.rb#L23).
This is not doing the right thing when there are no free variables.  Try entering just `pi`.
I think these need to be clarified. Order them alphabetically via the attribute's names? Can't you specify multiple attributes in a `validates` call? If so, what happens then? Do we want to avoid such calls?

Is the idea here to make it harder to accidentally validate the same attribute twice?
could you explain, why changing to this non-functional style?
maximum size
Class is named incorrectly (EscapeCss instead of EscapeUrl)
Isn't this violates `HeaderInterface` rules?
@Maks3w there's no such dir... wouldn't create it then...
Use `||` instead of `or`
Can you fix Zend_Zext_Table_Row for Zend\Text\Table\Row?
break the array values in multiple lines.

You can see the coding style here http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards
Well it's faster, so why not use it.
I am using implementsInterface, because I can be sure, that $type is an interface. Otherwise the method would return earlier.
This exception class has not been imported.
Are you sure this is a CS fix ? I think the is the opposite =)...
During canonicalization of a name, spaces, underscores, slashes, etc. are stripped -- which means that lines 228 and 229 are not necessary. (I'll likely  make that change during merge.)
Why are we using a closure for do a simple cast?
I didn't even realize I did that... Maybe a nap is required :P
This is environment-sensitive information. You should give developers ability to redefine it. Rename `behat.yml` to `behat.yml.dist`
Probably. Keep in mind that Zend\Session has its own lifetime mechanism that sits on top of PHP's session gc, IIRC.
Why are you calling exit explicitly?
Okay, works for me then.
@infininight should this be html encoded?
These checks should be 

    if ('_id' in doc) 

Just safer and cleaner
This is a BC break too (and for more people)
missing space after ``if`` and missing curly braces
Please remove trailing whitespaces
@FabioBatSilva you forgot this one ;)
replace with: (options.skipTransition)
We need to pass exact url in facebook, else facebook will show all thumbnails in `hasgeek.tv`
@param then
I kept the same structure that the previous ResourceOwner had. I'll update it for both ResourceOwners
Spacing around `=`
Yeah, I forgot those were carefully chosen. Fixed.
Not as simple as that - I just get the outer node stack in the stacktrace, and it stringifies the error object into "[Object]".

Thinking of creating an Error on function call, and then setting the message property before err-cb, but that feels wrong.
shall we change this condition to instance variable? ex:) ```@is_own_page?```
Wrong way. Need use interrupt flag
isn't it pointless to wrap this whole thing in a function and pass it $ then use $ as well? I've used this to pass in `jQuery` and use it as `$`. Is that what you meant to do here?
pytest is a third party
pages..desktop is application specific,
unittestzero is application specific

Also having them sorted  alphabetically is cleaner
Two spaces before popcorn please.
```js
if (condition) {
    ...
}
```
I addressed your TODO; when there are syntax errors in the local config, it printed ugly multi-line exceptions. Now, only the actual error message and the context (i.e. sourced file) are printed.

`fnameescape()` was introduced for exactly this; unfortunately, it has a bug on Windows; I have already reported this: http://groups.google.com/group/vim_dev/msg/0b616f0cfe00c909
I think this could be improved by being more suggestive, instead of declaring... Something more like "Let's say 'x' is the first number in the sequence"
Why no newline?
nah that wouldn't change anything unless the `__dirname` is in your PATH
values引数で指定した値を配列から除いた配列のコピーを返します。
If ARES is hosted for mutliple users, there will be many ports required & as users will be unuaware of each others, starting file-server may become a challenge. The file server reports the dynamically assigned port of stdout parseable JSON format, which is later used by the IDE to communicate with the file sever.
либо в начале заинклудь либо в конце. но в середине странно.
I need to have the build script be able to push non-interactive - aka not be prompted for user/pw.

I think this means simply setting dev03 up with a ssh key and assigning to the repo...more reading to do.
I'd rather keep calling this something meaningful rather than call it `Base`.
s/shoould/should
s/tests/tests,
We don't need to repeat this check in this test.
But I will test without the /\s+/, that sounds good
@cprice-puppet : great idea. updated to just use plibdir.
Sorry I wrote that on my phone.. I meant [rmtree](http://ruby-doc.org/stdlib-1.9.3/libdoc/pathname/rdoc/Pathname.html#method-i-rmtree)
long line is long
`filename` and `mimetype` can probably be wrapped up into an optional params object.
I removed this endpoint and the full config is sent back now.
I'm tempted to say that the tenant module should not have a config file, and its handling is special. Thinking about it, I don't think the tenant admin should be able to change the main tenant name. Later on, there would be a tenantTitle used by the UI that they could configure, but the main data should probably be superadmin only.
Change to...... :)
The method could probably execute the query as well.
It could do some validation prior to performing the query and return execute the callback with an appropriate error
this can just be `fs.readFile(path, 'utf-8', callback)`
You probably want to check existence of and access to group_id and principalsToAdd.
Right, you use the timeout to get a change of seeing a possible change in ``running``. It is just a shame that you need to pool, but not your fault :)
I'll make this change. Is there a particular reason for the other form, or is this just personal preference?
I think I found it here: https://github.com/EllisLab/CodeIgniter/blob/develop/user_guide_src/source/changelog.rst

What version should I add my updates to? 2.1.1 ?
Revert those, I think we already discussed them on another PR.
`||` must be  changed to `OR`, as per the style guide.
Throw in a `@static` in here.
Здесь у вас ошибка небольшая, вы проинициализировали массив, выделили память под 99 объектов, а затем добавляете в массив 100 элементов. Большой ошибки в этом, может, и нет, но лучше всего инициализировать с заранее известным количеством, если оно, конечно же, известно. 

Я кому-то уже приводил аналогию с покупкой билетов на киносеанс для группы: вы можете заранее позвонить в кинотеатр и забронировать 25 билетов, а можете прийти перед сеансом и каждый купит себе билет. В первом случае вы в любом случае будете знать, что у вас будет 25 билетов (в противном случае вы выберете другой кинотеатр, в котором билеты будут), а во втором случае билетов на всех может и не хватить!
Для увиеличенной вероятности, в данном случае 100

Sun, 04 Nov 2012 11:00:56 -0800 от s1dney <notifications@github.com>:
>	
>
>
	
	
>
		
		
			
>
>In DNAProject/DNAProject/DNAProject/Cell.m:
>> +//
> +
> +#import "Cell.h"
> +#include <stdlib.h>
> +
> +const int ARRAY_COUNT = 100;
> +
> +@implementation Cell
> +
> +-(id) init {
> +    self = [super init];
> +    if (self) {
> +        _array = [[NSMutableArray alloc] init];
> +        for (int i=0; i<ARRAY_COUNT; i++) {
> +            int r = arc4random() % 100;
> +            if (r>=0 && r<25) {
>
>забавно, а почему именно arc4random() %100 ? почему бы не сделать просто %4 и выбирать символ из 0 1 2 3?
>
if (r == 0) {
>
_array addObject:@"A"];
>
}....
>
              —
>
              Reply to this email directly or view it on GitHub.
Согласен, можно было.
случайной буквой может оказаться та же самая буква, что не является заменой
у нас в массиве 100 элементов, соответственно количество измененных ячеек будет равно количеству процентов, заданному в mutationRange.
In the new implementation, we are not building a JSON string. Instead, each selected file should be added to the selectedFiles list. Please see the mac implementation for details.

This really simplifies the implementation since we don't need to build up JSON strings, and we no longer need to include the EscapeJSONString function.
`getReturnValue:` always returns an `__unsafe_unretained` pointer.
Style: `s.toArray`
use basestring not str (otherwise it breaks with unicode strings)
Is this the sampling frequency of the data?  If so, the parameter name is not consistent with other parts of python-mne (e.g. mne.time_frequency.tfr.morlet) which uses "Fs" rather than "sfreq".  Would it be better to keep the parameter name consistent throughout python-mne?
This comparison won't work with localized field labels.
arguments is instance of Arguments class, Arguments is object "like array", but it is not Array...

function my() {
  return JSON.parse(JSON.stringify(arguments)).length
}

my(1, 2, 3, 4, 5);
chrome console return: undefined
You should put a space between `(boolean)` and `$termsAccepted` and `boolean` should be `Boolean`.
Why get rid of the interpolation?

Same for line 707
I guess I'm a little confused here.

- why would you pass `in_region` or `in_postal_code` instead of passing `region` or `postal_code`?\
- why can't we just use kwargs for postal code, region, lata, etc?
Since this class requires an Activation, and Activation already has a "def system: ActorSystem" etc, is this really needed?
It just changes the error reported from 'error' to 'fail' (AssertionError). But you are right, just the one line is needed, maybe with a note

    # should not raise error
Я не смогу тогда передвинуть встроенный чекбокс на нужную позицию
Делай же более осмысленные хедеры диалогам.
It does not expire the token.
`h3` to replace
Si el employee no está guardado en la base de datos, no se le pueden adjuntar archivos.
the best way to make a perfecte pull request is to create a branch on your fork. One branch for each fix or feature.
The when you make initial commit like this one https://github.com/doekia/PrestaShop/commit/fdcaf1fc70ffd274d8e9c4bf21b26fd7d33606a8 and then you push and make pull request on github interface. If you want to change some thing juste make another commit and push and the commit will automatically added to the pull request
Copy and paste error... yup, must fix!
Again, it would be good if these information can be easily shared between multiple axes.
Why is this code here if it's in the abstract base class as well?
Ignore this one, too! It's not even here, it's already gone.
You're creating 2 lists before synchronizing it, surely you can just wrap Arrays.asList around synchronizedList() ?

You should document the implications of this i in the modifications instance variable javadoc, to avoid iterations being done outside of a synchronized section
Re using a colormap, my intention was that the plot should have some colour; I don't care what colours.

You can safely assume that all mpl devs read the mailing list!
Could just default to 1 here (simplifies the documentation).
unilinéraire ? sur une seul ligne ...
" sentence case" is a form of tile where the first letter of the first word of the title is capitalized, and then only capitals for proper name, i doubt there is a french equivalent, but in the end the meaning is "do not use all caps for title".
ouch, critical one here, thanks for spotting! fixed
So why do you have both files?
it has bool return type so return false maybe :)
@sonney2k Hi, updated!
Escaping text for the DB is not the same as escaping for output. You always
have to do both.

Escaping for the db just avoids text breaking the SQL statement.. the extra
slashes are not actually stored in the DB.
You still need to escape on output - this is why you use htmlentities for
html/xml output. For csv you need to escape sensibly for csv..

Going to have a quick look at fixing this myself.

On Wed, Dec 5, 2012 at 7:56 PM, Angela Oduor <notifications@github.com>wrote:

> I would think that they are escaped when the report was being added.
> Seeing as we're pulling directly from the DB, stripslashes() would be more
> appropriate
>



-- 
Robbie Mackay

Software Developer, External Projects
Ushahidi Inc
m: +64 27 576 2243
e: robbie@ushahidi.com
skype: robbie.mackay
This looks right -- clearing discard makes sense.
Please always use braces to surround the code block of IF statements. Please also check line 148.
Should the return type not be "StaticEventManager" instead of "EventManager"?
add `the` following items
For this particular case on the view square should be seen. If setting scaleX and scaleY. That's why set them equal. there could be some other approach also to have at the end square.
I like the way your beginning and end flow together, they walked in one end of the city and logically back out the other.
Good call. I just did camel case by habit.
No, I mean alpha chars [A-Za-z]. In my testing, N.n didn't cause any issues.
This sets `$foo` to boolean true every time. I'm running PHP 5.3.15. To get it to set to 'The default' if `$object->foo` is not set, you need to use the shorthand ternary `?:`

```
$object->foo = null;

$foo = $object->foo || 'The default';
var_dump($foo);
bool(true)

$foo = $object->foo ?: 'The default';
var_dump($foo);
string(11) "The default"
```
This turns on the speakerphone immediately, doesn't it? But the preference should only be used during a call.
pushed a fix, https://github.com/deepak/knife-solo/commit/c2da04c5de6f9ea9acb7b9dedbf784099106684a
this should be Message(msg).GetChannel() 
(message is not defined)
no empty line after fund decl.
`columnId` is what? Index? Or id?
Yes, you could have also same view. But should be made in a cleaner way then. (Finding out which form was used.)
Please write variables camel case.
Yes i understand. I noticed that when using mongoengine signals we are missing objects i just didn't mention it in the comment. That was main reason why i asked if we really wanted to use mongoengine signal.

So should i use django signals instead as i did before because there were located in frontend/views.py and for most important part we had all the object needed?
I fixed the form and refactored that variable. Mixin is for another pull request I guess?
Hm, you probably want to sort/order the dict here? There are easier ways to do it. Read [here](http://wiki.python.org/moin/HowTo/Sorting/) and in general Django has a ordered dict structure available (so it keeps the order). Or simply just convert it to a list and sort.
Привычка уже :)

Разницы для конечного пользователя нет никакой. Не вижу смысла заменять тут на анонимку. А вот тащить закомментированный код — это явно плохо.
Can i add one tag per entity manager?
just want to make sure that vclose is not a typo ;) i guess it means violation close but since v and c are close on the keyboard... ;)
Since we assign a new timestamp as part of the backup restore process, we can skip recording the original timestamp as part of the backup.
ah secrets in code.  Fired.
Seems like this would require at least as much math in the getLocations function as there currently is.  To get the start and stop points of the array so we can slice it, we would have to start at `percent * offset` and end at `percent * offset + percent`, right?  And we would have to define the new variables percent and offset.  It may be worth it for the sake of intuitive code, but I haven't implemented this change yet.
Why not checking agains Guid.Empty?
Might as well just copy more of the comment from the docs:
> Service Name: ... name for the hosted service that is unique within Windows Azure. This name is the DNS prefix name and can be used to access the hosted service.
> Label: ... The name can be up to 100 characters in length. The name can be used identify the storage account for your tracking purposes.
`if ! tmux has-session -t "$tmux_session" 2> /dev/null; then`
> How is it different than OLS without a constant?
>
>
Because when estimating en EL linear regression model without a 
constant, you still have an exogenous matrix with a column of 1s. 
However the maximum EL estimate restricts the coefficient on the 
constant to be 0.  3 implications are (1) different parameters, (2) 
narrower confidence intervals, (3) the residuals still sum to 0.
Add space after `,` in tuples.
Couldn't you exclude the `%` directly in the RegEx? This way you wouldn't have to do the replace here.
As a rule, after we've released GalSim in some official way then I would say to keep such things for backwards compatibility, but given that we're still developing it, it makes sense to me to say that we want everyone (including developers and eventual users) to use our new and improved descriptors directly, and remove getFlux and setFlux.
I'm not sure that `group="optional"` is going to work here.  We need to set one size for each component.  Don't we need to tell the config framework that somehow?  So isn't "optional" saying the wrong thing?
If that functionality gets requested often enough, we could even make a python routine that does it for people.  But let's wait until it's clear that there's demand for it.  For now, could mention this option for users in the documentation here.

On May 22, 2012, at 1:34 AM, Barnaby Rowe wrote:

>> @@ -207,9 +202,111 @@
>>          */
>>         virtual SBProfile* shift(double dx, double dy) const;
>> 
>> -#ifdef USE_IMAGES
>> -        // **** Drawing routines ****
>> +        /**
>> +         * @brief Shoot photons through this SBProfile.
>> +         *
>> +         * Returns an array of photon coordinates and fluxes that are drawn from the light
>> +         * distribution of this SBProfile.  Absolute value of each photons' flux should be
>> +         * approximately equal, but some photons can be negative as needed to represent negative
>> +         * regions.  Note that the ray-shooting method is not intended to produce a randomized value
>> +         * of the total object flux, so do not assume that there will be sqrt(N) error on the flux.
>> +         * In fact most implementations will return a PhotonArray with exactly correct flux, with
>> +         * only the *distribution* of flux on the sky that will definitely have sampling noise.
>> +         *
> 
> Hmmm, added a comment which vanished, so apologies if this appears twice.  I think this makes sense.  Am I right in thinking that the sorts of SBProfiles for which the flux is *not* exact are those with negative regions (either due to noise or the choice of interpolant), as discussed below?
> 
> For all-positive SBProfiles, it seems to me perfectly reasonable to ask the user any user who wants Poisson shot noise in the total flux to set N = flux and draw N from a Poisson distribution itself, before calling a shootDraw() method.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/156/files#r858232


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
As Reiko noticed, this doesn't work for CCDNoise.
I like the kwarg option better too, so I'll do that.
def attr_query(name, val)
      (val.nil? || val.empty?) ? "not(@#{name})" : "@#{name}='#{val}'"
    end

    matcher = [
      attr_query('type', options[:type]),
      attr_query('profiles', options[:profile]),
    ].join(' and ')

    arch = attr_query('arch', ['x86_64', 'i686'].grep(options[:arch]))
what is template? What is trailing?
fine with me.

On Sun, Dec 23, 2012 at 11:32 AM, john krauss <notifications@github.com>wrote:

> In vocab/6.exercise.txt:
>
> > @@ -47,7 +47,7 @@ die Betriebsleitung	company/plant management	n
> >  nicht sprechen will	 doesn't want to speak
> >  wenn die	if they
> >  die Staatsicherheit	(GDR) state police
> > -der/die	Delegierte	delegate (the one delegated)	n	-n
> > +der die Delegierte	delegate (the one delegated)	n	-n
>
> hmm, agreed it's redundant since "Delegierte" doesn't change across
> genders (unlike "Schauspieler/in", etc.). what about just marking it as
> "female" and leaving it as one line with "die", or the other way around?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/talos/germanforgreatgood/pull/5/files#r2496161>.
>
>
always returns false
So, please transfer also timezone information. Here you are losing information. If input timestamp has timezone, you read information from timestamp without timezone adjustment, and then you convert this to datetime without that. The other way would be to adjust for timezone. See how objectid has this:

```
        if generation_time.utcoffset() is not None:
            generation_time = generation_time - generation_time.utcoffset()
        ts = calendar.timegm(generation_time.timetuple())
```

Similar you should do it here. But when creating output datetime you should then set timezone to UTC.

So the point is that it could happen that somewhere else, because timezone is not set, code assumes that datetime object is in local timezone and not UTC and adjusts it. So we should make sure that if user specifies timezone that we keep that. And only if user does not specify timezone, we do not do anything with that, leaving to possible local timezone adjustments whenever (this is user's problem if she is omitting timezone information).
I disagree with this. The QPushButton does not have the required properties of a QtToggleControl, and is therefore not ready to be initialized, until 'setCheckable(True)' is called. 'QtToggleControl.initialize' calls 'set_checked', which is meaningless if 'setCheckable' has not been called. The 'setCheckable' call must come before 'QtToggleControl.initialize', which effectively what happens inside 'create'.
OK, looks good, then.
/bin/sh and set -eu
This comment is unclear: does it solve the issue? (I assume so, since you're committing it!)
remove extra break;
this fails gracefully

On Thu, Sep 27, 2012 at 5:18 PM, Cory Zue <notifications@github.com> wrote:

> In logistics/models.py:
>
> >
> >      def __unicode__(self):
> >          return self.name
> > -
> > +
> > +    def display_location(self):
> > +        """
> > +        It's pretty confusing for the location of Ada Health Clinic to be Ada Health Clinic
> > +        This function returns what you would expect: that Ada HC is in Dangme East district
> > +        """
> > +        if self.location.tree_parent:
>
> i forget - does this break if you aren't using mptt or does it fail
> gracefully?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/rapidsms-logistics/pull/3/files#r1712187>.
>
>
"null"?
I think we should consider the prospect of eliding the button entirely using IoC, rather than instantiating it and then hiding it with CSS. Looking at the implementation, the code is already factored for this--the fullscreen button is  a subcomponent of the Controllers component and our feature detection code is already IoC-aware. We should be able to issue a demands block for the "fluid.browser.hasFullScreenMode" context and replace fullscreen button with an fluid.emptySubcomponent instead.
Yes you are correct, I think that `MediaService::create` will take the auth inputs from the user and do the work.
looks good but dont grok why mysql connector needs to be added for every run - shouldnt it just be in the mysql profile ?
I think it would make more sense to derive from AbstractWarningsParser, what do you think?
while i should be able to figure out precedence in my sleep, i don't, and it took me a bit to figure out what was going to end up in root in either case. is it pythonic to add some parenthesis to make the precedence more explicit?
s/freame/frame
Did you mean to change this? Wondering whether it should not be in a different pull.
1.
ドメインクラスとして振る舞い
↓
ドメインクラスとしての振る舞い

typo的な？
「ドメインクラスの振る舞い」でも良いような気がします。

2.
データベースの接続なしに
↓
データベースと接続せずに
のほうが自然な気がします。完全に個人的な好みですが・・・。
WARファイル配置
WARファイルの配置
ok, scaffolding removed
Remove--this pauses exection.
the tool has changed. Some line continuation stuff was added. See #1484.
``easy_install --upgrade flake8`` ;)
I'll look into the multi-class init tomorrow and I have to double check with Scott.
btw: Thanks for your throught review - I really appreciate that!
J'y ai pensé mais ça ajoute un python_to_pythran pour chaque type dans ce cas alors qu'ils ne sont pas utile pour les float ou int par exemple. Après, le python_to_pythran<float> ne fait rien du tout donc on peut en effet les appellé, c'est juste qu'ils ne servent à rien et le code est un peu plus beau.
+1 for the PSR-2. I believe we decided to standardize on PSR-2 for libraries once it was finally approved. We've already switched over allplayers.php and I feel this should be as well.
forgot to merge code here
Try to keep the same format as for the other platforms.  This section should start with "On BlackBerry, ..."
For code blackberry is fine, but for user facing doc it should be "BlackBerry" with the 2 capital B's like in the official logo.  Same for the section title.
Removed. We'll use default usage()
yes, but because it is implemented for BB as well, we have nothing to add here
A la création d'une étude, crée-t-on automatiquement tous les documents qui vont avec ?
Sinon au lieu de renvoyer une erreur, ce serait bien de créer la facture ;-)
Is this the new change?
Let's also add `orm:info` to check that all entities are there