labofsahil/github-event-dataset-2012 huggingface dataset:
Well, this is wrong. Leading \ should not be used.
I'd prefer to remove this, but I'd like others to weigh in as well.
можно не инициализировать в общем-то. оно по умполчанию путое создается
I found better solution and only with one iteration:

```ruby
def deep_stringify_keys!
  keys.each do |key|
    val = delete(key)
    self[key.to_s] = val.is_a?(Hash) ? val.deep_stringify_keys! : val
  end
  self
end
```

It faster then separate iteration
I think we don't need the `present?` check here.. `options && options[:lock]` should be enough.
Could avoid shadowing the `#length` method with the `length` arg by changing the arg name to something clearer, like `truncate_at`
You can indent this with four spaces to highlight correctly.
maybe `valid? && save` would be better? That way if it's not valid it won't even try to save it?
Do you have a soul?
One should expect invalid literals to halt compilation before arriving at any more meaningful error messages, given that the program can't even be parsed. I don't think this is a problem.
Hmm, sorry, on re-reading maybe my mental model has made the wrong boxes. Let me take another look.
Here... I think this incremental building of a sparse result will be relatively expensive.  Building a dense matrix would be quicker, but there's one thing I'm not clear on: do we necessarily expect sparse output in `spsolve`?
how about peek()?
If these are supposed to be internal, then they shouldn't be in `__all__`. If they're not, then they shouldn't start with underscores.
So if these are defined in MatrixExpr then do we not need them here? Will this happen automatically?

regarding def vs = I probably just copied some style from elsewhere in SymPy. Do we have a a standard for this?
In doc comments fields "offset" and "limit" are declared to be integer, not string, so they should not contain any query params.
Although I can append them too, but I need a confirmation for this.
In lines 266-268,282 please use `integer` and `boolean` for `@param`, as this is what the rest of Yii's PHPdoc uses for these types.
Can you just remove the spaces at the beginning of the line?
reduce, reuse, recycle
self.thread_names = [thread.name for thread in self.threads]
@djencks @bnd 

argh, what is this doing here?!
you probably want to work on your rebase skills ;-)
you're lucky it's in a comment..

please fix it (originates from 361d129804f400183b89dcce77193033ea48626a)
I don't think it matters enough. We call it once per minute, usually.
Here I would use
(d_quantiles.getQuantile(2) - d_quantiles.getQuantile(0)) / (2 * 1.960);
because it is more robust. As another note, you should probably determine which indices are the .5, .025, and .975 quantiles instead of assuming they are at 1, 0, and 2. You can do this in the constructor.

But preferably, getDistribution() should not be called...
This is a problem on all the queuey calls so I filed #2 to take care of it everywhere.
I'm not sure about `jmp` and `ret`. `SET pc, …` is an idiom that any DCPU-16 programmer will recognize; I don't see much gain in "hiding" it behind a macro.
use Params module.
Need to remove this line (artifect from development)
Hmmm, could this not be detected by either using an Interval or throwing an exception at this point? (In addition to the validation you're putting into the follow up branch)
`else { ... }` whilst we're at it
If this is a title/slug change that's going to leave a redirect behind it, this seems like it'll be checking for a cached timestamp based on the new (i.e., uncached) slug rather than old. Or am I misreading?
Do you mean the "if len(parts) == 0:" section ? 
I will delete this check for the request.
I added an explanation of the use of $error in the interface.
I would really prefer separate fixtures for all of these.
1. Which is why I asked you to document what is allowed to be in the array in a preceding comment.

2. I assume it is fairly straightforward to write a regexp to check whether a string is a valid xml tag name, therefore you should simply do this instead of continuing to argue.
Basically, as I understand it, $error can be either a string or an array. If a string, it is the language key for the associated error message. If an array, the first element is the language key, and any further elements are mixed values to be placed into the string (for use in sprintf).
But yes, documenting this somewhere would be helpful.
INCLUDEJS always seems to prepend the path with the style directory (e.g. styles/prosilver/) so I cannot use INCLUDEJS for files in the assets directory.
fixed in b040f1b
delay can end up larger than consts.DATACENTER_MAX_DELAY at this point (which is a bit unexpected given the name)
hrm, should we use this to setUnavailable?  thoughts?
I agree, I prefer to be explicit but for now I just want to get this merged so endpoint changes can also be deployed.
Defined names are defined at  18.2.6 definedNames (Defined Names) in the spec (part 1)
This particular one is what lets you print the column headers on each page.

That particular bit is just to make sure we dont hit any parsing errors when it is there. Still, shitty test, I admit - I'll add something that does break without that line. Nice catch mate.
Actually, this could be in config.h,  which already exists
It was specific to the homepage, but none of the other pages (the gradient didn't look any good for the other pages).
I'm sure there's a better way of doing it with stylesheets in nanoc but wasn't very familiar with it
Please put `radians` at the beginning. Variables that are not explicitly assigned should be listed first. I know there aren't any coding-styles available yet for bonsai.. but soon :)
Maybe we'll find a better solution. I added it to a list of open issues. See: https://github.com/uxebu/bonsai/issues/92
т.е. суммарные просмотры/клики просто каждый раз вычислять?
remove this constructor, it shouldn't work
@Vikas, you check that how to use enum by having a look at /src/resources/scripts/page_enums.js
I'm using that for Lab Module
Yes you are right, the order of the dimensions in the weights must correspond to the order of those dimensions in the array. I will note this in the docstring, and perhaps add an example or two to the docstirng...
> When will model_level_number ever be picked over level_height?

What I meant was: When will ```model_level_number``` ever be picked if ```level_height``` isn't the dimensioned coordinate? I'm not sure its possible.
I added a comment warning people that implement new cases that they should keep this in mind.
I also fixed a wrong result in Clip.grad, that has been there for a very long time. It treated the gradient with respect to the clipping boundary as always 0. I fixed this at the same time I fixed the Clip.grad crash that was introduced in the rc.
`.save` без проверки кода возвращаемого значения — это всегда скрытый баг.

заменить на `.save!`
It's a mistake. The original design was to read the first line only.
It should be removed in the current design.
UNINLINEABLE_OBJECT_LENGTH is 64. If the value is 65 or longer, will this cause problems?
Don't make unnecessary mixin, if used only in one place.
Do we need a more explicit guide on how to replace the permalink decorator? The answer might very well be no...

Maybe the permalink documentation should mention why it is deprecated. You can just use reverse inside the get_absolute_url, so you can always replace permalink by get_absolute_url which uses reverse.
I added it to South not too long ago, and it allowed me to factor out things for Oracle and SQL Server (and I might have included MySql, had I been aware that there's a similar issue there).
https://bitbucket.org/andrewgodwin/south/changeset/9425a7823355e1907c2bd9f9e2e0c7e1845c6dcf
@ramiro 

I can not think of any use of a custom null translation backend. Even, I also don't need it here https://github.com/rtnpro/django-pontoon-hook/blob/i18n_backend/pontoon_hook/i18n_backend.py.

I kept it in case some one wants to use it (very unlikely). If it is not needed, then it can be removed.

Please let me know so that I can update the patch.
think this file is current currentmodule annotation
should be "... %(type)s  NOT NULL", I think.
wrond indentation (it should use spaces, not tabs)
Why not simply 
```php
<?php
if (false !== strpos($value, ':')) {
    // ...
}
```

Base64 encoded strings should not contain a `:`, right?
Yeah, that's cleaner.  Just in case some plugin takes forever or similar.
(contains? m elem)
`// Support: Firefox >16`
How about the part where I'm deleting that line because it's not true. Firefox is the browser with issues.
I thought we were just talking about the multiline style. *shrugs* sorry!
Can we javadoc under what circumstances it throws exception?
Ah, now I think I understand.  I thought it is for the length of the child nodes.
yes, I also prefer merge these although it may lose some readability. Done. Thanks.
On Apr 5, 2012, at 9:43 PM, Hitoshi Harada wrote:

>> +        SET_VARSIZE(result, sizeof(int)*(doclen+2) + ARR_OVERHEAD_NONULLS(1));
>> +        result->ndim = 1;
>> +        result->dataoffset = 0;
>> +        result->elemtype = element_type;
>> +        ARR_DIMS(result)[0] = doclen+2; 
>> +        ARR_LBOUND(result)[0] = 1;
>> +        for(start_pos=0;start_pos<doclen;start_pos++){
>> +            memset(curr_top1_array, 0, nlabel*sizeof(int));
>> +            memset(curr_norm_array, 0, nlabel*sizeof(int));
>> +            if (start_pos == 0){// the first token in a sentence, the start feature to be fired.
>> +               for(int label=0; label<nlabel; label++){
>> +                  curr_norm_array[label] = rArray[start_pos*nlabel+label] + mArray[label]; 
>> +                  curr_top1_array[label] = rArray[start_pos*nlabel+label] + mArray[label]; 
>> +               }
>> +
>> +            } else if(start_pos == doclen-1){// the last token in a sentence, the end feature should be fired.
> 
> The code here and below looks so similar.  Avoid as many duplicate lines as possible.  The only difference looks like the addition of mArray, but I'm not sure.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/madlib/madlib/pull/103/files#r653665
>
Can you doc these?  (I know the others lack docs, sorry about that!)
Use `///` for doc comments.
There's no indication in the ui that this is the format to use. So I think either we need to support other possible formats (mm/dd/yyyy, dd/mm/yyyy, etc (which is problematic)) or we need to explicitly state what format to use or we should have one of those calendar widgets that pops up when you click on the field. I think the latter is probably the best.
It does that. The real magic, though, is that MappingTypes can _do_ things. Right now Kitsune search gets back a bunch of dicts. It'd be so much more useful to get back instances of a class that can _do_ things. It'd probably reduce some of the code in the templates and other places.
Can't assume /usr/local, and you don't have to hardcode paths into the cellar, there are methods for this. Take a look at https://github.com/mxcl/homebrew/wiki/Formula-Cookbook
i think this was in here for protection against redirect attacks
Hi Vanessa. This message doesn't get sent to the original user posting the content, only the site admin :)
Shouldn't need this file here. It belongs in the tests/input folder
Indeed. I forgot to add the summary of the changes made to the output. Done and test updated.
Cool, I made that change and also removed the quote characters.
addressed in 0242d1c
I completely agree with your assessment... and I mis-remembered when you get an IllegalAccessException vs. SecurityException.  Carry on.
My concern with that was with messages that were already in the pipe - if we terminate, we'd have to drop those, which would be a confusing situation. This way no further messages get added, though any already en route when the disconnection occurred are in limbo. Not sure there's much we can do about that, unless I'm understanding it wrong. 

I did initially try and repurpose the hiccup command to do it, but that didn't seem to work out right. I'd much prefer to do the whole thing without introducing a new command though, as it is a bit messy.
I'd rather do !!@options[:path] to force it to be a boolean.  Can make debugging issues unintuitive if you get a string out of something you expect to return a boolean.
Got it. I think I like the ternary operator too much :)
Watch indentation here. (Really, though this whole file.)
Now that all the functionality that the menus depend on is wrapped up in Commands, will clients ever really need to access Menu or MenuItem objects directly after creation (or even do things like listen for open/close events)? They can't really use open/close in order to decide when to update their enabled/checked state since those are going to be asynchronous. So I wonder if we just should consider Menu/MenuItem to be private implementation details--client code should do all their work in Commands and not try to work directly with Menu and MenuItem objects.
Line 199 for the ``focusedEditorChange`` event handler. Line 214 should have been updated though. Fixed.
A little nitpicky, but: this var name makes it sound like it holds an event object itself.  Maybe something like didToggleChangeSelection or toggleSelectionPending?
The idea is that that case should never happen, if the ctx starts inside a block-comment. But for commentEnd it can since a block comment could be valid without the `*/` in the case of starting it and ending at the end of the document.

But I will change it.
I tried it and it doesn't work for me. You may be thinking about changes Peter F made to get Quick Edit (not Live Preview) working in <style> blocks.
The onerror handler is missing here.
Yes, but on infra they're not, which sucks.
Docs say you can only call this from a non-NIF called thread on the SMP emulator.  We need to add similar protection in the NIF init code that we have in innostore https://github.com/basho/innostore/blob/master/c_src/innostore_drv.c#L188
fixed. i would argue that 'json_format_datetime' and 'string_to_datetime' are not the most convenient or discoverable function names for dealing with iso dates.
Well, is that really an issue with the CalDAV Plugin as this is specifically designed to work for *files* ? Anyway, I got your point. An idea could be to make a temp copy of the existing stream, patch it, return the patched stream then overwrite the original one. A more complex and time consuming version would be to patch "on the fly". It would require to make our own stream class to add such ability but at list it would spare a file copy on the disk wich might be very slow.
I am sure I messed up this condition here, but you get the idea :)
*I created new field language to be saved to user profile* < New? But we already added one? So you mean to have two fields for languages or one?
Looks like :D As Debian GNU/Linux user I would like to propose to have a logic of platform-dependent starters. something like this:

``` ruby
case RUBY_PLATFORM.downcase
when /darwin/ then sh "open http://localhost:4000"
when /linux/ then sh "xdg-open http://localhost:4000 > /dev/null &"
else puts "Don't know how to open browser. DIY & GOTO http://localhost:4000"
end
```
Can you move this lookup into a method inside db.py:AUSDatabase? It seems likely that other code may want to make use of it.
yeah that's better
Personally I don't think there is any harm. Is there anyway you can test to see if it does cause harm with an unescaped url with said characters?
In the off chance that the XHR above hasn't responded yet, what happens?
If you could comment this too, it would be great. I have no idea what this css does.
I know, gross.  It evaluates to something like https://github.com/mozilla/butter/pull/801/files#L1R9

the `important` is to ensure that it overrides any inline styles from drag and drop, etc.
New line above this.
class NoValidProjectException in file TooManyFilesException ?
Thanks Filippo, I guess we might need a conditional for older Python versions then? I assume you guys are still wanting to support 2.7?
Rather than run a 'USE' query, you can also specify that database in the call to ```connect```
If we end up going down the `WorkerStreamer`-per-connection route, *probably* still want to make sure that this code gets invoked at most once per tick.
I'd stick with a longer more descriptive column title: Like `notification_level`.
Yeah Tom, That looks like it! Thanks.
I would find it useful to keep the tuque library independent of the islandora code. As a stand-alone module, it has broader appeal.

:-1:
These changes are  wrong - they remove my new code
It should already be an error object.  Not a string.
Just occurred to me that two `Pool`s are created.  Instead you could have one `if multiproce: pool = Pool()` and reuse that same pool every time. Much less overhead that way.
Can you give the complete reference here (journal number and page number)?
es有个很蛋疼的地方NotQuery不能单独使用，必须跟其它Query组合在一起。如果一个Query只是NotQuery就挂了。
I added it back in, but the code path doesn't get hit.  I think it's because all of the claim sim deals with directly with calling riak_core_claim:claim/3 rather than calling riak_core_ring:rebalance_ring() which calls riak_core_claim/1 and grabs the wants/claims function from the environment.
here's the correction
This feels old-fashioned. Just do `Video.all`.
Updated to be a single function.
I think it would be rather cool to display the changelog in the update Window :). Should be possible.
But that's perhaps an idea for another commit.
This and the following ``if`` could be ``else if``, or?
I am fine with this. It would make it clear that (the content of) $foo is not being used afterwards.
Little nitpick, you should only have 1 newline here.
@elemoine The cgxp tests are not very easy for me than you want to look at it it's great :-)
It might be worth pointing out that the cycle_timer_ variable is set equal 1. That is, it's not reset to zero, as might be guessed by a naiive individual.
People are freaky about hashbang. You might want to note or footnote that this is using the default HashLocation class but others are available and there is an API to write your own.
1a.  I think this document has grown beyond the scope of being a "primer."  c/d
1b.  Dare i be so bold as to assert that this is really "How to build Big Ember Applications" or "Building Applications with Ember.js" ?

The point of the Ember-Router-Application-Guide-Code / Halbert discussion is that you can `git clone` that project and have working code that moves lockstep with this guide at every step.  A major losing point in most frameworks is that the examples are either trivial (Todos v99.0!) or non-extensible for novices.  With these peer commits, the reader is no longer bound to having to re-type or cut-and-paste these snippets in.  She can simply `git checkout` to examine an interesting point in the commit history, edit it, and then move on.

I'm with @wagenet, I think anyone who would substantively (trolls notwithstanding) complain about the Ruby bias here, @trek, should have the ability to read the code that's references in the `Diff View` links, see that it's *nothing but javascript* and then cut-and-paste into Node or whatever mechanism is appropriate.  I could add a few *more* caveats to line `196`, but is that really necessary?
after a closer look at the code, for consistency this is definitively and improvement => merging
I just copied the previous test (TestSimpleRecord) and changed casing.
If you want a test for different character sets, that should be created separately to this test.
Can you describe why it is needed to move the config from here into a `<srcript>` tag in the html?
I'd like to keep the old description.
I get that show is the normal convention in cli commands for openstack.  however, I think get is much more commonly used in our code.  let's make this follow convention, then we can bubble up whether to change the convention for all openstack stuff.  Now is a good time to agree on conventions.
No `char **` out please. This keeps biting us in the ass.
This code should be pulled into a template macro and used in both this and base-resp.
Perhaps copy and paste that explanation into the code as a code comment.
``$.trim($(this).val())`` should go into a variable, you're calling it twice (here and previous line).
Why?! We have other perfectly happy crontabber apps. Like the bugzilla one and reports_clean and stuff.
This line must be indented more to be aligned with the other ones
2 separate functiions would be clearer and faster instead of boolean flags (reverse) and partial functions
I think someone's IDE autocompletion messed something up here.. hope it wasn't mine :)
I think tis class is not needed. You could mock the interface itself and achieve the same result as this class is not adding anything compared to the interface
This flag is written but never accessed, meaning it is useless
missing types, description and new line above
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tests/Fixtures/FooCommand.php ?

what do you mean @stof
please remove debug commented line
ok, fair enough, I've changed `path()` calls to `urls()` calls.
ok let me do that.
Yes, but I think Request should replace RequestContext anyway at some point like for Symfony version 3.
Unti then, what do you think about my alternative implementation mentioned above?
you should not iterate over a JS array with a ``for in`` loop. This can give you more stuff than the array elements themselves (as JS arrays are objects and so can have additional properties). You should use a ``for`` loop instead.
I just ment explain why sometimes it might not always line up perfectly. I would think that they would and the fact that they don't would make me think that I am doing something wrong with my code.
%s/tag/footer/g
I like the name as is. It's returning a collection of invitations not a collection reminders, so the proposed new name doesn't work. 

It's difficult to come up with a name that ends with plural invitations that still explains what this is a collection of. `pending_automatic_reminder_invitations` is the best I can come up with, but it's a Invitations model, so the invitations part seems repetitive. If it has to be changed something like `invitations_pending_reminder` could work, but seems unnecessarily wordy.
Yeah, but I think it'll be a while before everybody is C++11 compliant enough to assume that this will be available.
Should be:
       n_states = len( np.unique( assignments ) )
Tu peux aussi faire un  ```--no-rdoc --no-ri``` pour cet gem là.
oops. nice catch. this diff is getting a bit long eh
если force=False - то берет из индекса (так уже было).
В таком случае я возвращаю None и в таком случае нет необходимости сувать энтри в индекс
Why the rewrite - CRLF vs. LF maybe?
I don't think we are supposed to be changing message ID's.
Comment out this will break layout on SGS2 phones. Please fix the layout rather than comment it out
If container would be absolute you dont need to set 'bottom' and 'right' properties in 'send-message' ;)
Sure, previously the image was added always, and now only when it is needed, but we are keeping the text-overflow for long names, photo & no photo ones.
So the behavior is as expected and we are not over-truncating names.
nit: `} catch (e) {` (space + same line)
Can you please add the following comment here?

    ## LOCALIZATION NOTE 'call' is an action verb

(Or something to this effect.)  Without the comment it's not clear whether we mean a verb or a noun.
heh, good catch.
The code in shell.js that does that will be moved to Gaia once the Idle API lands.
In fact, all are the same, the only thing you are changing is the data-type ... could you refactor please?
Please prefix with `_` only the functions that should not be called outside the singleton and group them
"in bucketed into" -- should it be "is bucketed into" instead?
any pointers on a better way to do this?
hmm, and what if two words in the document map to the same id?
Using tabs instead of spaces perhaps?
handle-debugger-reply would be more appropriate
is this necessary on beginning? any `/opt` paths should be on the end as they are optional, if it is required then maybe other check should be done.
was ist das? :) how about moving it to a `json` array with 5 elements ?
Have it here for consistency with the other function that generates environment vars.
The reconnect time is arbitrary, and since its a power of two should not over step.
needs a better name for r_cl
It's because we can ensure consistency using inserts, which we can't do with updates.  This is similar to buildrequest claiming, which is unreliable using UPDATE because two masters can update the same row without a peep from the database engine.  However, one of two duplicate inserts will result in an error.  (Note, this isn't quite true, if you're replicating between database servers asynchronously with MySQL.  Rather than the application getting the error, the database servers just get upset, stop replicating, and page oncall.. I love MySQL!)
"unsalted" here, for example, worries me.
How is this different from the other `addBuildsetFor..` methods?  It's hard to tell if it's a wrapper around one of those, or more generally useful.
I'm not sure that this is going to do what people expect, if they don't specify a codebase on the `Triggerable` scheduler, but do use codebases elsewhere.
It seems like I have to configure the `DownloadManager` anyway. At least I can't figure out if I can pull an instance from somewhere else.

When I do the following:

    $manager = new DownloadManager(true);
    $manager->download($package);

I get an exception that there is no downloader for type 'git'. I don't see the point configuring another object first?

Do you know what I mean?
you should use the interface for the hint, not the implementation
Thanks! Fixed in the new commit.
makes your testing harder
Test options should not be selectable if TEENSY_SUPPORT is active.
Working on this presently.
this seems to all be whitespace changes? shouldn't be in feature branch.
Heh - no.  My regex-fu ain't that great.. Maybe there is a simpler way to
get at an expansion that may or may not have a default?

On Fri, Nov 2, 2012 at 2:42 AM, Victor Julien <notifications@github.com>wrote:

> In src/conf.c:
>
> > + *
> > + * This compiles the regular expression used in variable expansion and
> > + * caches it for re-user.
> > + *
> > + * \retval The compiled pcre
> > + */
> > +static pcre *
> > +ConfGetEnvVarPcre(void)
> > +{
> > +    static pcre *envvar_pcre = NULL;
> > +    const char *error;
> > +    int erroroffset;
> > +
> > +    static const char pattern[] = "\\$\\{"
> > +        "("    "[^\\$\\{\\}:-]*" ")"
> > +        "(:-(" "[^\\$\\{\\}:-]*" "))?"
>
> easter egg? ;)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/167/files#r2014121>.
>
>
do all the chains have to be configured in a "global" canopenmaster.yaml file? or can there be a tray.yaml and a torso.yaml and be uploaded to the chains namespace?
You could do:

```C
ssl-> ssl_head = to_insert;
```
at this point instead of in each block.
maybe "code-generation"?
I'm confused. My understanding is that nothing will happen on fennec at all ?
If so is that a expected behavior ? If it is we should note this in docs.
Also comment about this in `addon-page` module would be useful IMO.
Yeah I used it for debugging and forgot to remove.
don't need "DEPRECATED: " here
Ok so I have investigated into this more and it looks like we need `normalize(id)` mainly due to built-in modules`s whos's URIs are resolved during loader instantiation to be cached accordingly. Now if in that scenario there is no requirer in manifest so resolution happens on in the else branch. Without normalization there chrome is not normilized to sdk/chrome and then require from manifest won't be able to find it in the cache.
How about: "that defined when and how stable SDK APIs can be changed or removed from future versions of the SDK while giving developers enough time to update their code."
@jedp - was the port meant to be checked in?
I don't think `mark_complete` can itself be included in the same transaction because it's on a different database (the objectstore) and thus a different connection. It's just a matter of making sure that `load_test_data` either fully completes or else gets rolled back, and that we only do the `mark_complete` if it completes.

I don't really like the idea of having `DatazillaModel` methods that modify the database but never commit, relying on the caller to commit or rollback for them. This situation makes me wonder if the current `nocommit=True` API is really the best one for datasource transaction handling, as opposed to a stateful API where you explicitly call `.begin()` on a datahub, and datasource records an "in transaction" state for that connection, which automatically prevents autocommit on all subsequent executes until you explicitly call either `.commit()` or `.rollback()`. (Calling `.begin()` again without having committed or rolled back would be an error). If we had that API in datasource, then the individual private methods used by `load_test_data` could remain totally agnostic about transactions, so they would still work fine and autocommit if called individually, but `load_test_data` itself could call `.begin()` to start a transaction and then either roll it back if anything fails or commit it at the end. Curious if @jeads has thoughts here as well.

In any case, these kinds of complexities are why I thought it might be best left to a separate story / pull request, as its not really inherent to this one.
I might be exaggerating the difficulty so I'll make this change in the next commit, and then we can compare the two solutions. What I was trying to argue was for an elegant script over a neat markup.
Yep, E_WARNING is what core does as well.
Instead of `@facts.length == 0` you can just say `@facts.empty?`. 

Two points of style:
1) The comment isn't needed (it is exactly what the code says)
2) I find suffix ifs like this obscure because they hide the very important conditional.
You might want to check "puppetlabs_spec_helper" and see if this line needs to be added there too.

If Puppet tests are relying on this behavior, then it is likely that module tests (stdlib et al) will fail without it as well.
This could be moved to the `renderPipeline` method a few lines lower and `renderResponseBody` 

```scala
case result: ActionResult => 
  status = actionResult.status
  // add headers
  actionResult.body
```
`string | false`
@weierophinney True but since there where no other else statements in this case, the suggestion should work.
Bah! Can't believe I missed that regex. Good catch :)
Maybe could be possible write `$majorRevision > 1` and save one comparision
There aren't cases for IPv4
It's not. I just thought that adding the strictness would be a nice thing to do.
Some were `bool`, some `boolean`, so I decided to go with `boolean`. Reverted the change :)
please reduce number of empty strings
I think I merged this already, didn't I?
The fileinput and sys modules aren't used anywhere.
Reference the jQuery in the assets folder
Does this not break Lyricli::Util#sanitize_param?
@anti No index?
MIssing line break between param and return
Don't think we need Validations
well, if you pass a valid index, it will always work. The question is whether they tested their invalid cases
Fix package as above.
That's left over from debugging. I'll remove it.
I missed that! Yeah, use `rgb[a]` or hex values. Words are weird science.
Removing the "Which" here seems easier to read (and possibly translate?), but I'm no wordsmith, _per se_.
Remove this example, it's silly
why not use the reported ip ?
I think this code should be in a seperate class

how about adding a class called /lib/puppet_setting.rb ?
Change date to say 2012 as that is when the file was created
the alignment here feels really strange to me but I guess it is okay.
It'd be useful to document how this relates to a JCR Session. IIUC, there can be multiple handles for a single JCR Session. Perhaps this (along with a summary of how the other JCA interfaces are mapped to JCR concepts) is best documented in a `package-info.java` file.
Neither will `spec/knife.rb`, but there is a `knife.rb.sample` there
Found a typo here, one . to much.
Erorr*
By default, pch files are ignored, but XCode seems to choke on this. Should not affect Windows development.
wouldn't just $accessIdentifier=strtr( ... ) be sufficient in this situation, and simpler?
Yeah, I thought about it afterwards and wanted to fix that. :ok:
и за сколько это работает?
конструкцию можно один раз написать.
``array_shift`` also requires a reference. I switched it to ``current``.

But anyway, does PeytzMail supports setting multiple recipients (either as an array or as a ``Foo Bar <foo@bar.net>,foo@example.net`` string) ? It would be better than using only the first recipient. but there is no doc for it (is it an internal software ?)
This fixes a bug that I think is reproducible in the original CodeMirror scrolling code as well: on Safari, if you do a touchpad throw scroll, it decelerates for a little bit but then stops abruptly. This seems to fix the problem. The "cursor: text" above is necessary to make it so that you get the standard I-beam cursor while over the code (since the code div itself no longer handles the mousemoves).
Yup, you're right. The method in the API is returning all the activities,
not only the future ones (like I am querying the db).
And even if it were, we have to proceed the way you described because we
can't guarantee that all the activities being returned by the API are
missing from the database (even if the API returned activities in the
future like the local query is doing), picture remote updates to the
entries since they were last fetched by the client.
Thanks for reviewing the code.
On Jul 14, 2012 8:08 PM, "Ricardo Martins" <
reply@reply.github.com>
wrote:

> > +        // and add them to the list.
> > +        reqwest({
> > +            url: globals.server + '/locations/' + venueId +
> '/activities.json',
> > +            type: 'json',
> > +            success: function(resp) {
> > +                Ti.API.debug(this.responseText);
> > +                var activities = JSON.parse(this.responseText);
> > +
> > +                Activity.beginTransaction();
> > +                _.each(activities, function(activity) {
> > +                    if (Activity.get(activity.id) === null) {
> > +                        Activity.add(activity);
> > +                    }
> > +                });
> > +                items = Activity.getNextInLocation(venueId,
> activityListLimit);
> > +                Activity.endTransaction();
>
> I think that an approach like the one in scheduleList.js:350 is less
> taxing on the DB: doing all the reads (`SELECT`,
> `Activity.getUpdatedOrNew(activities);`) at once and then doing all the
> writes in a single transaction, instead of having reads mixed with writes.
> I haven't measured this, so I can't say for sure.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/meqif/cec2012pt-app/pull/75/files#r1164357
>
Definitely. I want to allow something like DocumentMapper, which is a ORM-like interface to YAML front matter.
great catch +1
Does Ruby have a method for merging hashes? Seems like this would be simpler if we just merged main_section with, say, default_opts (a hash representing our defaults using keys of :server, :port, and :max_queued_commands). Then the part of the code that ensures all things are cast to the right types or stripped or whatevs could just focus on that, and the `||` logic disappears.
Should be `choiceArr`
I'm assuming that there will be lots of places that actually use the principal_id property that need to be converted to use .id ?
Please add comments on this.
Some sort of form serialization plugin would still make sense.
This is a very interesting discussion, but I don't think there is a problem. The visibility is solved if `start` creates a *happens-before* relationship between the assignment and the first action of the new thread. According to the Java Memory Model, this is guaranteed when you create the thread. Also, a `synchronized` block would do the same. I believe that `start` does create a new `Thread`, so we should be safe. I sent an email to @phaller still waiting for an answer.
Okay, I'll update it. By the way, should I fire a new "pull-request" for the updated one?
But it doesn't work on ree :(  

- Neil


On Monday, September 10, 2012 at 2:11 PM, Mani Tadayon wrote:

> In Gemfile:
> > \ No newline at end of file > +gem 'debugger', :platforms => 'ruby_19' > +gem 'ruby-debug', :platforms => 'ruby_18'  
>  
> The debugger gem works on ruby 1.8 as well!
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/thegauntlet/gauntlt/pull/40/files#r1570734).
dit moet op 2 regels?
Okay, `$file` above might not be needed (+1). But we don't need to rename this one as well. :)
Should rather be:

     - Added dsn (delivery status notification) option to the :doc:`Email Library <libraries/email>`.

... config setting would mean a variable that is set in a config file.
@devipad то, что сделали вы - этого тоже нет в задании. ;)
Можно использовать NSUInteger – будет unsigned, т.е. не отрицательное число.
Да профайлером. 146.0ms при 78% и 94% мутаций на 10000 элементной ДНК 1,5 с было при 100000 элементов сейчас я на хакинтоше. Идеологически правильным методом на мой взгляд было бы заполнение массива последовательными числами о 0 до 99 и перемешивание этого массива методом который обеспечивает доказанную случайность тасовки(хотя в данном случае эта самая случайность нафик не нужна). Твой метод быстрый, но мне нравиться свой метод как простой и понятный.
Оно, конечно, хорошо, но не совсем правильно. Всё-таки основную инициализацию нужно использовать для того, чтобы можно было хоть как-то пользоваться объектом. То есть, в конкретном случае нужно вызвать [super init] здесь, проинициализировать все необходимые массивы и переменные, а в другом конструкторе вызывать именно этот init.

В любом случае, не вижу надобности в дополнительном конструкторе.
Is there any way to make this lazy instead of eager? This code basically means that the full sequence will be generated right off the bat.
Ok, good to hear you like this approach.
why return self?
2 spaces before grouped
Use default None for verbose, same docstring as in other functions.
yes, i use NewsJSON.js (new.js) instead , it have the same code except that it has no http server
Seems like you might have done this before.  :)
i think its a few weeks behind, but it still should not be changing them back when looking at diff...
This should be `// ... do some work`
the component is named EventDispatcher
I feel that the comment clearly explains why it's multiplied by 5.

(Also, yeah, remove it. Joke's over now.)
You shouldn't do this here. CNumberValidator would be a better place
ок. Уболтал, чертяка языкастый
Looking at the entire (defgroup  , it looks like indent is correct.
Why did you remove this string?
This is used.
please revert copyright year
to move in middleware
By the time this constraint description bubbles up to the UI, it looks like:

<pre>
[testStructureAllergy] RDF structure check failed

Invalid results (first 3 shown):
   http://purl.bioontology.org/ontology/snomedct/160244002 http://smartplatforms.org/terms/codes/allergyexclusion 160244002 ffno known allergies http://purl.bioontology.org/ontology/snomedct/
</pre>

Some formatting down the line would make this easier to interpret.
commented out? just remove if not needed?
We could but we'd just get a very small performance on an non-critical path: no lock acquisition for l1 writes in the case of non-concurrent caches (non-default). So I'm happy with this for the time being.
I agree it would be nicer, especially for the fetchSize as it's easy to assume that parameter is optional.
Also more options could be added in future in case of a fluent API.

I'm not sure about the main switch: Eager vs. Lazy fetching are a fundamental choice.
We have two options:
- make it mandatory in the constructor
- if we make it a fluent method we need to choose a default value. In this case I'd think Lazy as a default is safer, but I'm open to hear more reasons
Please don't instantiate DCM directly (see https://github.com/infinispan/infinispan/pull/1025#r595707)

And where's the call to stop()? (see https://github.com/infinispan/infinispan/pull/1025#r595709)
not yet, but in the api
I don't see how very long lines are cleaner, but I guess that's jeremy's call ;-)
I think returning hist is a good idea though incase people wanna do something like drawing a number over the color patches.
When would one want to use ```tri.triangle_nodes``` and ```tri.edge_db``` without using ```to_client_point_indices()```? If the answer is never, then I suggest that the attribute itself takes care of this.
I know its been merged already, but its worth mentioning that the lines:

```
if offset_position=='data':
    offset_position = True
else:
   offset_position = False
```

Is exactly equivalent to:

```
offset_position = (offset_position=='data')
```

(un-necessary parentheses added for readability)
I am not sure, but might this lead to a leak?
as u like, just make clear of your intents!

On Tue, Aug 7, 2012 at 11:17 AM, François Thillen
<notifications@github.com>wrote:

> In testproject/ETMTCP/ETMList.cs:
>
> > +        public object this[int index]
> > +        {
> > +               get
> > +            {
> > +                return listelements[index];
> > +            }
> > +            set
> > +            {
> > +                AddProtocolType((InteractionMessage)value);
> > +                listelements[index] = (InteractionMessage) value;
> > +            }
> > +        }
> > +
> > +        public void CopyTo(Array array, int index)
> > +        {
> > +            throw new NotImplementedException();
>
> Is inherited. It is not needed for the list but I could add it too
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1319275>.
>
>
Fair enough. Closing issue.
Should only be shown for logged in users.
When methods return a new (SG_REF'ed SGObject), you need to remember to add that in the modular interfaces once you integrate them. Just a reminder (I always keep forgetting this and wonder about memory leaks) See the existing .i files to see what I mean
the encrypted stream is hooked up to a pipe stream. I have a feeling it takes care of this, but I haven't verified this yet.
The assignment to ``$value`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
could use a comment
Well, they're documented in the FAQ (http://backbonejs.org/#FAQ-events).
 Did you see that list?  If not, where do you think they should be instead?

-brad


On Wed, Dec 5, 2012 at 10:26 AM, Ore Landau <notifications@github.com>wrote:

> In index.html:
>
> > @@ -1408,7 +1408,7 @@ <h2 id="Collection">Backbone.Collection</h2>
> >        triggered on the collection directly, for convenience.
> >        This allows you to listen for changes to specific attributes in any
> >        model in a collection, for example:
> > -      <tt>Documents.on("change:selected", ...)</tt>
> > +      <tt>Documents.on("change:selected", function(model, collection, options) {...})</tt>
>
> Good to know! Anyway, my point was that the arguments passed for event
> callbacks are not at all documented. How do we fix this? Should I open an
> 'issue'?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/documentcloud/backbone/pull/1871/files#r2321540>.
>
>
Probably because this is written in the doc block: <code>@return  mixed  Associative array or false if badly formed URL.</code>
You are right, it needs to go.
√, but I opted to not do the ternary.
Thanks for the explanation.

Update the PR with the changes, and I'll have a second pass at it.
Why lazy? These strings are inside a function, ergo will not be executed until the app knows what language it is operating in.
Seems like this file kinda snuck into this change?
odom is the only word that is shortened. publishing, occupancy .... and so on are used fully in parameters/topics. Why shortened that one specifically ?
`check_online_users`?
You should remove this whitespace.
Yeah the window of history is used for another feature we don't support yet ("healthz" and "varz" reporting).
It's not returning his own object
use as MapperException
Note: before this is merged, change to make sure `this` is set to the provider instance.
What?
Use a DELETE statement, then an INSERT statement with all the data in its body, not an INSERT IGNORE + UPDATE, thats not the codestyle.
Need to test this more, but my thought was that since RtpSocket is
connectionless any IOErrors are unexpected network interruptions and not
normal disconnects - normal disconnect should come only through
the signaling.


On Fri, Nov 9, 2012 at 3:17 AM, Moxie Marlinspike
<notifications@github.com>wrote:

> In src/org/thoughtcrime/redphone/call/CallManager.java:
>
> > @@ -116,6 +117,9 @@ public void run() {
> >      } catch (AudioException e) {
> >        Log.w("CallManager", e);
> >        callStateListener.notifyClientError(e.getClientMessage());
> > +    } catch (IOException e) {
> > +      Log.w("CallManager", e);
> > +      callStateListener.notifyClientFailure();
>
> It looks like, down in the old RtpSocket-land, this used to be
> notifyCallDisconnected(). Now it's notifyClientFailure(). Was that an
> intentional change?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/58/files#r2080476>.
>
>
removing imvirt package from build deps
s/radius/RADIUS
missing the switch portion
~~~
a(1,...)(2)
~~~

is imaginable, though not entirely likely. Any idea how to detect that case?
the only thing is the naming here.
the pattern for distinguishing internal from external (with/without LOOO) should be more consistent so users can interpret names more easily.
dffits_int dffits_ext ?
student_resid_int ?
or names without postfix should be consistent

(it's not completely clean on attributes of class either)
jshint を通してください。
> $ npm install jshint
> $ make jshint
  
`make jshint` で bin/capturejs.js の lint を通すようにしてください。
```
jshint: capture.js lib/capturejs.js
```
    
> % make jshint 
> jshint capture.js
> capture.js: line 13, col 16, Missing semicolon.
> capture.js: line 14, col 27, Missing space after 'function'.
> capture.js: line 14, col 30, Missing space after ')'.
> capture.js: line 15, col 5, Missing space after 'if'.
> 
> 4 errors
> make: *** [jshint] Error 1
s/forwardaddress_invaild/forwardaddress_invalid
The first line in the Additional scripts section is still incorrect.  Otherwise good.
I wonder, might it be better to put this in a module scope variable at the top of the file, to make it slightly more visible?  It might be important enough to warrant it...
I like the Wiki idea.  Would you like me to do the page?
This is a good place to leave the ellipsis, and just point out (as you do) that there are lots of ways to specify Shear.
Add and Convolve both require arguments, so the ellipsis is not really accurate here.  In both cases, recommend writing `( [ list of objects ] )`
is this relevant to this commit?
This should be a more rigorous test
name attribute should just be a string and not an array. Make the plugin list an attribute on this resource
Could you back out this whitespace change?
I presume this comes copy-paste from Monterey, so no need to review code?
Mozilla Developpers Network, une super base pour apprendre internet. Si t'as une question siouze sur JS par exemple, tu tapes "question MDN" sur google et si MDN a fait un article t'es sur que tu trouveras pas mieux autre part.
@$el?
Alterado para utilizar urllib.
This should also be internal-TomahawkSqlQuery  cannot be used outside of databasecommands that already live in libtomahawk
It was the very idea to load (not register) every module, so that modules can run some code on their own and decide on their own if they want to register.