labofsahil/github-event-dataset-2012 huggingface dataset:
`subjects` is already defined. See pseudo-scope vars ;)
For what it's worth both Bill and I wrote JS for over ten years following your preferred format -- it's ours too. But we lost that battle to the community and tooling behind jsdoc.
I'm going to punt on this.  This class is internal to this file.
For me, I couldn't get it to work for any of your tests.



-----Original Message-----
From: Harlan Harris [mailto:reply@reply.github.com] 
Sent: Wednesday, June 27, 2012 11:01 AM
To: Short, Tom
Subject: Re: [julia] Add with, within!, and transform! (#2)

>  
> +srand(1)
> +N = 20
> +d1 = PooledDataVec(randi(2,N))
> +d2 = PooledDataVec(["A", "B", "C"][randi(3,N)])
> +d3 = DataVec(randn(N))
> +d4 = DataVec(randn(N))
> +df7 = DataFrame({d1,d2,d3}, ["d1","d2","d3"])
> +
> +
> +@assert with(df7, :(d3 + d3)) == df7["d3"] + df7["d3"]

argh, looks like the `@test` macro breaks when the expression includes quoted parts...

---
Reply to this email directly or view it on GitHub:
https://github.com/HarlanH/julia/pull/2/files#r1060579
Is llvm a runtime dependency? I'm not ecstatic about adding another 150 MB to the closure of X applications...
> would you do that or should I?

you do, also because I am not sure you are right that this is a bug in numpy. I mean, you are going to need sort one way or another if you want to have an efficient unique. If you are fine with an inefficient implementation, that you can just go ndarray->list->set and that's it. Don't you think so?
The name doesn't quite highlight that its saving to the localStorage
- removing most "cancels" because it doesnt make sense to navigate back with new UI layout.
- moving this on to line 259, with other goodsIssue fns
Why was this removed? Can it be added back please.
fixed in a local commit. PR later.
On Thu, Aug 2, 2012 at 5:15 PM, Łukasz Langa
<reply@reply.github.com>
wrote:
>> +    if not settings.ZABBIX_URL:
>> +        return
>> +    zabbix = Zabbix(settings.ZABBIX_URL, settings.ZABBIX_USER,
>> +                    settings.ZABBIX_PASSWORD)
>> +    zabbix.set_host_templates(hostname, ip, templates,
>> +            group_name=settings.ZABBIX_DEFAULT_GROUP)
>> +
>> +
>> +def update_zabbix_templates(device, templates=None, remote=False):
>> +    hostname = device.name
>> +    role = device.venture_role
>> +    try:
>> +        ip = device.ipaddress_set.get(hostname=hostname)
>> +    except IPAddress.DoesNotExist:
>> +        return
>> +    if templates is None:
>
> I'd rather use `if not templates` so an empty list also forces calculation of Zabbix templates.

Then you wouldn't have any way to set an empty template list, which I do need.


-- 
Radomir Dopieralski, http://sheep.art.pl
`console.log()`
Did you mean to remove the ending newline?
A fotm elem neve olyan legyen amit nem fog más modul is használni, mert a system_settings_form változót készít ezen a néven.
Ez mire jó?
Can you please uncomment this line of code, or delete it (if it's no longer used)?
Unfortunately, this isn't addressing the issue that was being addressed previously, take a look:

<img src="http://gyazo.com/b0d62d3ed41f4b17542effa349112d47.png">
Replying to https://github.com/jquery/jquery/pull/785#r850556 :
Until we have something like [`shared`](http://irc.jquery.com/%23jquery-dev/%23jquery-dev_20120420.log.html), I don't see any other way to achieve the necessary results for code like this that is accessed from multiple modules.
append to ("#qunit-fixture") instead.
B65-ZK-978.zul has been removed due to recently discovered side-effect.
ninja also parallelizes by default, with no command line.  Maybe reword this to just say the "default parallelism" or something.
Can the image URLs be relative here? STATIC_URL might change (i.e. somebody may want to alias monlog to /monlog/)
Then the next issue pops up: Using `.values()` of the later dicts (or `OrderedDict`) will return the same backend multiple times if it supports multiple URI schemes. Pushing it through `set()` to get rid of duplicates potentially destroys order again. The current solution is simpler, but I felt it wasn't obvious from the code that rearranging it would break introduce subtle errors.

(For the record, Python 2.7+ got collections.OrderedDict.)
This kinda works. Problem is now that I get a No credentials stored error, like #65. I do not get this with the older versions of my fork. Strange. If I know why, I'll let you know.I'll commit the non-working version;.
;) This should be changed to an actual test, or removed if there isn't something noninteractive that's testable. For instance, many programs just do `foo --help`, which typically returns true.
var logout = new Image(); logout.src="https://cas.utc.fr/cas/logout";

Comme ca pas besoin de rajouter l'élément casimg.

Cool trick sinon :)
C'est le Load des ressources du serveur, et non pas du client. Ce n'est donc pas une fonction de gestion de message client mais juste une classe de loading de ressources.
The always sync or always async rule? I guess I'd say it is always sync in the lexical scope of Future and always async in the lexical scope of the app. (Again, app just means "not Future internals".)

Or more precisely, from the perspective of the app it's "always use the EC the app provided to run the app's callback", I'm assuming the app's EC is async, but anyway it's always whatever the app wanted. Modulo bugs there's no way an app's code ends up running in the internal executor AFAIK.

So I think everyone here has strong guarantees; Future knows that it will run its own code sync, and run the app's code how the app wanted (normally async, e.g. with the defaultExecutionContext).
This won't be true unless the access_token was set when the Config was created.
This is used for adding an array of routes so having a name option doesn't really make sense - just use `add_route` in the test
These final names are semi-redundant.  You're adding square-foo, but when this is pushed to the maven repository, the square- is removed - it's only going to show up as square-dagger-1.0.jar in your target/ directory.  

To wit: run `mvn deploy -DaltDeploymentRepository=alt::default::file:///tmp/alt-repo`

and run `find /tmp/alt-repo`

You will have no files prefixed with `square-`

I would just remove these in a subsequent change.
These can be inlined now, I think.
I believe this documentation is outdated (does not fit the code ;-)
I wonder what the performance implications of this change are. For example, if you have a large observer chain somewhere containing a model attribute, this now contains its own internal key path.
That's what I originally tried, but couldn't get it to work for some reason. I'll give it another shot. It would be nicer that way.
nitpick: Do you need to store a reference to the connection? May as well not assign it to a variable if it's not needed.
Yes, we do have additional code further down this block (outside of testing with testPos block) to cover the cases where no whitespace token to the left. If you see any issue in your testing, then I will be happy to take a look.
Same as above. You can use replace with regex.
Missing `var` keyword, so this will crash when you run it (due to strict mode)
Why do you need decodeURI here if you're going to show encoded urls in the list?
no, just laziness. i'll replace
I left it so that the script can be tested when Boric is run locally, but if you want, I'll remove it.
I am not sure if this goes into model. I think it goes into [queryset manager](http://mongoengine.org/docs/v0.5/guide/querying.html#custom-querysets)?
Why? What happens if it is not? We do not want to use any Django application which requires relational database.
space after the comma: `($(child)[0], $(ref)[0])`.
Add some spacing here.
For brevity's sake, you can probably just use `fallbackCB = fallbackCB || function() {};`.
this for loop and the one above look to be the same. Accidental duplicate?
scott++ for awesome comments
Change the extension to .html instead of .xml
These are wrong :(.
Commented out line left here.
It looks like you're removing the multi-line text feature here
this is wrong, function shall return array not a string.

In case of 'qBT' it will return: "qB", which is wrong.

Also, make `} else {` as one line.
I'd use BufferedInputStream here
Doctype-määritys voisi olla myös tässä.
Hack... is this some sort of Etsy practice?
I've changed this to use an enum.
make backup files to be 5
Oh, the problem here is that the delegate has a `void[]` parameter instead of `const(void)[]`, then the implicit conversion should work.
Architecture or architecture?
Will keep it in mind for future commits; not fixing here. FYI, in my browser the cut-off is 106 chars. I will wrap lines at 100 chars when encountered in future.
Thanks!
``$record['formatted']`` is meant to be created by the formatter. if you need some custom stuff, write another formatter for this
Channel ?
You might include an example here, e.g.

```
For example::

    t = Table.read('photometry.dat', format='ascii', data_start=2, delimiter='|')
```
`riak_core_ring:my_indices(Ring)` is simpler if you're on the node you want to repair.
In principle, yes, Qt supports IPv6. However that doesn't matter now -- bitcoin.org isn't on IPv6.
I don't think this should sneak into the makefile :)
This should also probably be using a "shared_context" as I mentioned above...
following the same test format, this should probably say "does not allow". i'll change this in the merge.
Please explicitly specify types for columns
This fixes a bug where the summary from an acknowledgement was not being stored in redis (but was being shown in acknowledgement notifications)
Yea, agreed.  Was being lazy and avoiding changing the usages to be remoteComandLine().  Now updated though it still seems a bit fudged.  Any further suggestions gratefully received.
I haven't looked much, but I suspect the author intended for it to compensate for the `from __future__ import unicode_literals`.
No, definitely not. I believe we actually do the checkout into the in-memory index, then show progress information while actually checking files out to the working tree. So the progress you see in git only starts after we are done looking at the trees entirely.
I would change this to:
```js
absolutePathRegex = /^([A-Za-z]+:)?\/\//
```

this will match against any fully qualified path, including protocol relative ones:
```
http://example.com/...
https://example.com/...
ftp://example.com/...
//example.com/...
```
Can't it be left as active code, by dowgrading it to DEBUG mode? It may be usefull to have it available in production.
Incidentally, if `return` and `else` are combined with an identifier, so should `typeof`. However, this is not the case in UglifyJS 1.3.1.

```bash
echo 'typeof[],function(){return[]};' | uglifyjs
```

yields

```javascript
typeof [],function(){return[]};
```
You want to line-break on occasion; there's no reason not to.
Remove this file entirely, unless you write any tests for this.
ahh, yeah.  cool, I hadn't thought to do that at the module level.  neat!  :)  removed.
that is a mystery artifact that I do not understand.  It was a test that has nothing to do with what was working on that was failing.  I meant to investigate to see why it appears to work in master, but I can't see how could ever have worked.  I'll do my neglected investigation.
This is actually the direct opposite of how things should be done. Space before and after `!` and no random spaces between parenthesis. How it was was exactly right.
maybe use the "else" here as **else** as well?
These instance variables live in the same space as the instance variables in an end-user's Sinatra application.  I used the underscore prefix to minimize the likelihood of a naming collision.
... and coming full circle, if you recall that was link that I forgot to axe in said demand.
This should say the same than the full changelog. Here, you don't mention the fact that ``ContainerAwareTraceableEventDispatcher`` is gone
Good point. I got carried away on this.
but it's the context of the matcher. if the generator needs an updated context it should be updated on the generator.
otherwise this listener simply assumes that the generator and matcher use the same instance which is flawed imo.
Extra semicolon here... Otherwise looks good!
@dlsniper you should declare the instance in the container instead of declaring a config array. The instantiation of the driver would be done by the container.

People not using the DIC would build the instance themselves to add it in the registry (which is far more flexible than trying to build a big array and handling keys in many different ways to configure the dependency)
No, not really. Just part of my IDE's template for classes ;-)
@Fran6co each firewall uses its own set of listeners (but each one its own instance) so they should not share the handler
it's not equivalent, would it work ?
This addition is not needed as it was the old behavior anyway.
wrong. The ORM returns an array when doing a findAll (which is why the current code works for the ORM btw). Collections are only used for relations.
Please do it...
`Topic#owner?(user)` に +1 です〜
```ruby
def something
  var = a
end
```
have you tested it for screen with "LI" & "Later" buttons and for screen with "LI login web view"?
pass chera ghableshoon fasele zadi ?
why the trailing _? (as opposed to a leading _)
If one of the 400 error cases are hit below, result_array will never be freed, which is a memory leak. You can move these two initialization lines below the 400 error cases, and use NULL for jsobj in finalize_request() for the error cases.
0 is Go's sane default for an integer, so if it's 0 chances are they haven't set it.

Rather than setting the pool size to 1 and limiting their possible throughput without them even being aware seems like a bad choice, better for someone to be notified of this when building the client, so that they can set a value that's appropriate for them.
We've released `gherkin-ruby 0.2.0` with your addition so this won't be needed.

Let's see what does the rest of the people think of your PR and then we can merge it
Was there any particular reason for using while instead of for?
the the => the
I meant it a little bit differently ;)

Why not define the namespace right here as with the WKR?
registerExternalType("usingnfc.com:geo", GeoRecord.class, new GeoRecordEncoder(), new GeoRecordDecoder());

A developer who works with the GeoRecord class does not need to care about the namespace so there is no need to define it within the class. The same goes for AAR.
生产环境需要换成我们收款的email帐户
I think |if (!menu || !menu.title)| is enough
I have the feeling this wont pass linting :)
Pointing again to https://wiki.mozilla.org/Gaia#Coding_Style

We have more than 55K lines of javascript in this project following those guidelines, let's continue! :)
What do you mean by "screen estate limitation" ? I changed it after playing with the mail app on my Nexus S.
As soon as i could test it.
once this is approved (along with the other smaller changes), we'll open a PR on our l10n branch, and there it will all be in the .properties files correctly.
can we have this initialization as part of the constructor of the Progress Object?
dialer-view. really? :)
@ochameau Why dont, instead of creating a lock, we remove the listener? `this.sendButton.removeEventListener('click', this.sendMessage.bind(this));` We will activate it again once `send` was success/error.
I will add an util function to get the actual html font-size and we can use it for rem <-> px convertion.
Less dependencies are better for a testing library imo.
It is already there by default in /etc/httpd/conf.d/ssl.conf, so no necessary to be added in our conf files. It results in warnings when added again to pulp conf files.
my version of mpl doesnt have the key 'savefig.extension' in plt.rcParams.
This works because of the new multipart stuff, best to pass arguments around rather than arrays now...
I think I'd just name this `sort-by-following`. And please add a comment explaining why this thing that "looks" like a constant needs to be a nullary function - it depends on the mutable state to for `if-user`.
This isn't intuitive. Shouldn't the variable be called something like `col_family_name`?
Add an issue for this on GitHub.
I'm not a unicode expert, but I think I took away in a couple of blog posts that ::is_utf8 is not a reliable way to determine whether the underlying string is actually utf8 encoded.
@mourner 
> I don't like setting filters by default for common elements because IE is known to get slower because of this.

You mean in the CSS? I totally agree - which is why put it inside a conditional comment or perhaps modernizr adds a class that could be used. Either way I don't think it should be this javascript's concern. Not a big one, though.

Thanks for your code changes, so much nicer :)
I basically like agree. Call it a build system, that's what it is.
This schema is a bit incomplete, please not only the main attributes but all of them, except `checksum` and `announced`.
Typo: You intend to submit `hash_collisions` but actually pass `deleted`.
yeah, and I would vote for removing it as well...
Please don't add trailing whitespaces in the empty lines
i wonder if we are always going to be doing multiple queries, if we should not just start with fetching a post by guid or id, then check the permissions in userspace?  Since I feel like we now have like 3 paths for finding said post, maybe that is easier now?  Thoughts?
What I'm asking if this is even necessary when using `useJQuery`, doesn't jQuery make these events consistent anyway?
You are right ;)  (see 69c18903e7)
Same permissions comment
Currently page mods using "*" would be applied to addon's pages shipped in data folder with your changes they no longer will be applied to them, so there is a risk of someone relying on this.
I see, a comment would be nice, or maybe you could export the code to a function in the `api-utils/array` module?
I used camel case in order to be able to use destructuring and/or regular attribute access like `option.xpiPath`/`let { xpiPath } = options;`, instead of only `options["xpi-path"]`. Having said that I'm fine about dash-delimited too.
None, removed.
You could use Z_TYPE_PP() here.
Yeah, this is to ensure the module is still a module.

I'm anticipating the situation where someone comes in and changed `module Modules` to `class Modules` and I want the specs to fail in that situation.
function that is supplied with contents of file and filename and this data is put in Editor tab contents.
I dont think we use any of these in this file
Never mind, got it.
Reading the [docs](http://guides.rubyonrails.org/active_record_querying.html#passing-in-arguments), IMHO  its better this way.
Need a space between `if` and `(` (and below as well)
Why sha1?
Again, given the name of the test, shouldn't this be packageRegistrationRepository.Verify?
This feels backwards. Don't know how Meteor works, but the intended way is to let the filter links just be ordinary links, and then listen to the hashchange event and read the current route. See the App Spec.
Props uses the prefix now for maximum convenience
Generally we put things that need to be loaded on `documentReady` into `admin/on_ready.js`.
ADmad: for example, configuring ClearCache panel for DebugKit with
'clear_cache' => array(
    'engines' => array('', 'default'),
    'groups' => ('comment')
)
would allow to clear:
- all cache engines at once, and 'default' one separately
- jus group 'comment', but not all groups at once
Hi Rick, Just started reviewing your pull request. I noticed you have csc-... selectors which are used as selectors in javascript. If you want to add just styling selectors I would suggest using cs-... Also I would change then from being record type specific, e.g. cs-record or something (maybe cs-authority-record). We are trying to move away from having record specific code/css in master so this should really be record-type agnostic.
oh, so you're changing the location of drafts!
Should this be a docstring? If not, please use normal comment format with a single hash sign :-)
```python
from vsc.fancylogger import getLogger
log =getLogger(__name__)
```
doesn't matter I think. should indent using spaces then
Yes, looking better. I'll do a full format when I merge as well :-)
Nit: Alphabetize imports.
I do this ALL THE TIME in tests.
Going to stop requesting this.

Just assume I want it when possible.
Same as above re: magic (hard-coded) numbers ;-)
i think we can drop pagination as well, at least until we make a decision if we want to include it or not
@releod @jlee42 can you guys help me with this? Is #49 flawed since it uses ["invoice"](https://github.com/zmoazeni/harvested/blob/master/lib/harvest/invoice.rb#L42)?
This is not unused. It's used to populate the RSS feed. We may not have proper tests for the RSS feed though -- I think we got stuck on how to test the RSS stuff at the time, and punted on it.
also:
Warning: XSLTProcessor::transformToDoc() [xsltprocessor.transformtodoc]: No stylesheet associated to this object in fedora_repository_object_details_XSLT() (line 73 of /mnt/share/drupal6/sites/default/modules/islandora/ObjectDetails.inc).
Je précise, là c’était un problème de ^M sur les deux lignes.
Spaces D:
Iirc, we always start with a timing point now - the script start time, so no need to check if it is set
Yes, yes... one thousand times yes!
It feels a bit weird to have rest endpoints in the util module, but as I can't think of a better place either, it's probably fine.
Note: There is a circular dependency between oae-util/lib/oae.js and oae-tenants/lib/api.js
We should probably still add a check though, otherwise we'll end up with 

```
{
  'deleted': true,
  'createdBy': null
}
```
in the response
What about the benefit I mentioned of consolidating logic? This tends to improve maintainability of code and reduces the risks of bugs when changes are made to, for example, validation logic. It's generally good coding practice.
Ch. 6 vi
(I need help here. Whatever text goes here I think should move into Ch. 5 vi Site memberships.)
old debug stuff
@flisky It doesn't work.
Ik zou dit niet in de init doen.
приват проперти
```objective-c
[DNA componentsJoinedByString: @","];
```
а попробуйте создать NSMutableArray *arr=[NSMutableArray arrayWithCapacity:-100] :)  

best regards,
Evgeny Trefilov


On Tuesday, 6 November 2012 г. at 0:45, Alexander wrote:

> In osx-project-1/osx-project-1/Cell.m:
> > +// Created by Alexander Kazanskiy on 30.10.12. > +// Copyright (c) 2012 haxlet. All rights reserved. > +// > + > +#import "Cell.h" > + > +@implementation Cell > + > +-(id) init{ > + self = [super init]; > + if(self) { > + > + //Размер масива DNA > + capacity = 100; > + > + if (capacity < 0){  
>  
> capacity можно изменить но массив не может иметь отрицательную размерность
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Hexlet/osx-project-1/pull/55/files#r2034916).
This change also doesn't have anything to do with commas.
It should be moved to RPI video driver in that case.
Instead of having one long function consisting of blocks with comment headers, this would probably read better if it were factored out into a few smaller functions so that the high-level logic can be seen quickly. Something like

```javascript
_bubble: function(target) {
  var bubblingChannel = $(target);
  var bubbleDestination = bubblingChannel.position().top + this.$('.scrollHolder').scrollTop();
  if (this._needsBubbling(bubblingChannel, bubbleDestination)) {
    this._shrinkStartArea(bubblingChannel);
    this._growDestinationArea(bubblingChannel);
    this._startBubbleAnimation(bubblingChannel, bubbleDestination);
  }
}
…
```
I think we should do `{"tilemill":"0.10.0"}`. While overly conservative perhaps for some plugins, doing this across the board is safer in the face of MM/wax  upgrades that may happen between point release versions of TileMill. What do you think?
I don't understand what this method is doing! could you please illustrate why it's necessary with a simple example?
The other thing this needs to mention explicitly is that because it's using pyes 0.19 and they made that change, you have to make sure to comb your codebase for any instance of ``indexes`` as an argument to any ``pyes.ES`` method. While you added code to handle that nicely here, it's not the case that it's handled elsewhere.
I don't think you should be ignoring this test.
This stuff gets run after validation of the run list items happens.
lowercase u utils.ts
The version seems superfluous because this will break when it becomes 2.1.0
I changed the name of this template tag to be more explicit.
Why not `record.id` instead of `record.send(:id)` ?

Also this line is pretty long, I'd consider breaking it up by making it a proper if ... end block instead of the trailing conditional at least.
"Clean!" as of you like it or "clean this mess up you moron!!!" :) ?
底下 `%ul.nav.nav-tabs`  的命名才是合理的
裡面的每一個 dom 就都是一個 tab
Yo creo que podríamos sacar directamente ese texto.
Wasn't it National Geographic HD the one to blame? ;)
General note:  there are several ways to write a 'literal' list:

```clj
(list 1 2 3)
'(1 2 3)
[1 2 3]
```

None are necessary "more correct" than the other, just a matter of preference really.  Just wanted to make sure you knew the options.

I think the first two are exactly the same in terms of what they produce.  The last one is actually a vector.  Vectors have different performance properties than lists, but since you don't normally write a literal list of 50,000 items, it doesn't usually matter.
ok. agree.
We should add a comment about why we use don't the filter for "/*" . (which path is excluded, and why)
and we have if vol_enabled here. So not sure that this commit changes anything.
Oh wow, what a blunder! Thanks Manik
Do you think to add public getters into HttpMockRule?
Also, the proper PHP version to test against is 5.3.3.
is it really the right link ?
`git_diff_index_to_tree()` and the like which construct a `git_diff_list` all make an internal copy of the options structure that you pass in. Once you have passed it in, it is fine to release the memory, be it from the heap or the stack. In almost all of our code, we just put the `git_diff_options` on the stack.
Using the getter here seems inconsistent with the ivar access on the line above.
Nice spot… why the hell isn't the compiler shouting at me I wonder… `typdef`d to the same thing?
OK folks. I usually just assume when something is asking for a pointer it wants it on the heap… perhaps mainly as I come from objective-c first?

I'll move this bad boy to the stack.
I've changed all of those in np.deg2rad.
Didn't intend to push a modified cfg file. Will be careful to avoid that in the future. 

On Aug 23, 2012, at 2:28 AM, Trif Andrei-Alin <notifications@github.com> wrote:

> In mozwebqa.cfg:
> 
> > @@ -1,3 +1,3 @@
> >  [DEFAULT]
> >  api = webdriver
> > -baseurl = https://crash-stats.allizom.org
> > +baseurl = https://crash-stats.mozilla.org
> why did you change the baseurl here? crash-stats.mozilla.org just make a redirect to crash-stats.mozilla.com
> crash-stats.allizom.org is tha staging site & crash-stats.mozilla.com is the production site
> 
> —
> Reply to this email directly or view it on GitHub.
>
i think you need to be testing for all 5 cases here
I thought I'd better point it out since other people could be looking for the reason is behaves differently in the future...
(and also not to forget we should find a way to have a coherent behaviour)

do you want me to remove the comment?
Well, because of two reasons actually:
1. the 'option_text', that follows 'options', at line 25, which would have gone to low to have a clear view of the whole $plugin_list['csv'] array after the lines were broken
2. the if-else below and the end group after that, which will remain separate anyway
Ummmm … I sort of follow, but mostly not. Where would this even go? Does it work?


On Apr 19, 2012, at 11:48 PM, Sam Ritchie wrote:

>> @@ -243,3 +243,9 @@
>>   (<= good-min (float
>>                 (/ (count (filter good-set reli-ts))
>>                    (count reli-ts)))))
>> +
>> +(defn shorten-ts
> 
> Yeah, the way to do it is to create an adjust protocol with different implementations for different things:
> 
> ```clojure
> (defprotocol Trimmable
>    (adjust [& series]))
> 
> (extend-protocol Trimmable
>   ISeq
>   (adjust [& series] (reduce min (map count series)))
> 
>   TimeseriesStruct
>   (adjust [& series] (apply adjust-timeseries series)))
> ```
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/14/files#r711608
Minor nit, just curious about the use of `;;` for comments instead of a docstring via `"`. Do you just like the `;;` better?
Seria melhor utilizar os arquivos .ini para abrigar as configurações ao invés de misturá-las com código Python.
Could you point me to where #save is being called now? I couldn't find it in Experiment::Base, except for in `define`, which doesn't seem to get called.
actually technically this is equivalent to `record && record['enabled'] == true`, since `!!record['enabled']` would evaluate to `true` for some `else` cases, e.g. `'imastring'`
A comma required in previous line.
I have split the call into two. The configuration parsing remains here. The cache pool creation now happens at the same time as cache create.

I've documented that the cache pool cannot be reconfigured in the new cache configuration documentation page.
On third or fourth thought, I went with:

```
'total LSM, table or file object key/value pairs'
```

we don't need to call out btree, I don't think.
а здесь не надо было ничего менять, верни назад
Are you sure ``$contentType`` has the correct type as "Boolean|string" is not a sub-type of "string"?
Are you sure ``$engine`` has the correct type as "object<stdClass>" is not a sub-type of "array"?
Could you use a straight `if` here? The negative logic is a bit confusing.
Derp. Code review on a tiny phone screen is hard.
Sorry, that's what I meant. Should maybe be "add the path of the \bin dir..."?
ah, gotcha. That seems good then.
Love it.  I think I want this to be an optional per-service setting.  For instance, a service may support only pull/issues/issue_comment, but define just `#receive_event` for whatever reason.  

Also some tests would be nice.  You don't have to bother, I'll just do it when I get around to merging this though :)
The `count` can be costly. But fortunately `every?` returns true for a empty string and `nil`.
Yes, but $key is by default null. I can't see any case when $key is not defined in this context.
in fact, it is used by the file included as template. But this needs a comment to explain it and avoid breakage later. (and btw, the phpdoc is outdated)
This switched from `-approved` to `approved`; is that right?
`account.models`?
It's just javascript, we will figure it out anyhow :)
Are you sure you have to repeat those values used in `objects` query? I think they are added automatically? No?
Still, this is not the right way to do translations.
There's nothing to fix. But note taken, I have to fix this in another issue.
No, bad instructions. Don't write anything else on the same line as token. Because people will paste everything in.

Better would be:

```
Or, open the following URL:

...

and copy-paste the following confirmation token into the input box there:

...
```
Lower-case CSS class names.
In general, new empty object can be done with `{}`. Much nicer code.
It is useful for setting two backgrounds and we need two because of the sprite image that we are using. Well we could use just one image and wouldn't have problems with aligning them. But I just accidentally found out that if I put position:relative on span, the button in IE starts to behave like in all other browsers  - wow - I'm not sure if this is a bug or a feature but it works so I would keep this span.  :)
No, don't change that.
(Or register handler in jQuery document ready, which is probably even better.) So include together at top, but register in document ready.
This line has invalid syntax.

You can see that by tests which have also failed because of this (GitHub is showing them just bellow the pull request description).
heh oops.. fixed.
Я думаю нам это не нужно
It's because it is a PUT not a POST, the CSRF only comes into play on POST.
use enum instead of a number
SET @GO_GUID             := 9650;
Okay, with the lining of the other options it makes sense. I generally don't do that...
Extract method (oder utility): `if (updateNecessary()) { ...`
The itertools recipes section, python 2.7.3 documentation. I kept things in the same relative order, you should be able to find it: http://docs.python.org/library/itertools.html?highlight=itertools#recipes
What happened to this file, to be this different?

can you please make sure the patch is not that big?

It looks like all lines are different. Maybe you have some issue with line-ending.. is it set to checking as Windows -style line ending?
If the goal here is to never let the user see a stacktrace unless they've requested it with --debug, should we catch Throwable and not just Exception? Or is an Error always severe enough that it should blow the jvm?
Так — неправильно. Если создать 2 экземпляра Server, то они свалят с одно место все свои потоки. Нужно инициализировать в конструкторе. Кстати, do_stop тоже лучше сделать атрибутом у Server
maybe should check more closely here for the keys inside the dict?
Do you have suggestion how to rephrase this ? I'm sorry it's just no matter how much I try to make best comments I'm still non native English speaker.
Actually no, there were two empty lines.
if this is the "magic sauce" that resolves the mail session connectivity issues, we should rename these "mail.smtp..." properties since they aren't actually javamail properties anymore.
Quite right, will fix
Move this to an extension method if you need it, otherwise remove it.
We are keeping these alphabetical.
fixed in 9f90a4e
This link works for me as-is. Should it be changed?
Why do you default to "false" here, and to "" in other definitions?
Remove this method due to the above reason.
If I'm not mistaken DataStore is required but never used? Is that on purpose? If not we should get rid of it.
instead of this.. what you can do, is pull *all* this logic into a Runnable

then, once the change is in, where you have ListeningExecutorService exector as a field, you can simply tack this on.

ex. at around line 72, you'd do

ListenableFuture\<NodeMetadata> future = executor.submit(new ProvisionNode(...));

now, you can use either future.addListener() or any of the goodies in the future class to perform the post processing.  and regardless of whether this code block takes the form of a Runnable or FutureCallback, etc. it is much more testable, as it would be isolated to a class with this purpose alone.

When this is in, basically this loop ends up just a barrier for completion or failure of all futures.
Should be named `Feed` rather than `Feeds`
Why not just check for null and throw instead of throwing twice?
I submitted this to my fork after submitting the pull request.  I had no idea that it would be added to the pull request.  It's something I was playing around with and does not belong in this pull request.
oh right sorry, nevermind me I'm in limbo
Nu e OK sa verifici dupa " - ar trebui verificat dupa primul = . Calea e ce e scris dupa primul =, doar ca trimmed pentru spatii.
If there are no twitter accounts the twitter option is not shown so
they'll never get to that method. For simplicity at this moment we
only take the first configured account. One option I'm considering is
detecting multiple accounts and expanding the single "Twitter" item
into one for each account.

On Jun 2, 2012, at 12:18, Jorge Bernal
<reply@reply.github.com>
wrote:

>> +
>> +    ACAccountStore *store = [[ACAccountStore alloc] init];
>> +    ACAccountType *twitterAccountType =
>> +    [store accountTypeWithAccountTypeIdentifier:ACAccountTypeIdentifierTwitter];
>> +
>> +    [store requestAccessToAccountsWithType:twitterAccountType withCompletionHandler:^(BOOL granted, NSError *error) {
>> +
>> +        if (granted) {
>> +            NSDictionary *params = [NSDictionary dictionaryWithObjectsAndKeys:
>> +                                    @"true", @"stringify_ids",
>> +                                    @"-1", @"cursor",
>> +                                    nil];
>> +
>> +            NSURL *followersURL = [NSURL URLWithString:@"http://api.twitter.com/1/followers/ids.json"];
>> +            NSArray *twitterAccounts = [store accountsWithAccountType:twitterAccountType];
>> +            ACAccount *account = (ACAccount *)[twitterAccounts objectAtIndex:0];
>
> What if they have multiple accounts set up?
> If they have no accounts, is granted false?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/beaucollins/WordPress-iOS/pull/1/files#r919215
That sounds fine. There's just no guarantee 3, 4, 5, etc would build upon preceding PSRs beyond 0-2.
Слеивать строки надо через StringBuilder
```
    @Rule
    public ExpectedException expected = ExpectedException.none();

    @Test
    public void test() {
        expected.expect(RuntimeException.class);
        expected.expectMessage("Hello");
    }

```

RuntimeException - это базовый класс для всех непроверяемых исключений. Там может прилететь и NullPointerException, и IllegalStateException.
this should not be used....
 You can find a app by searching for it...
constructing the link proved in AMO that is not a desirable approach 
This works ok for apps with common names but if we try to open a more advanced app it will fail
If we're going to capitalize it, we should spell is as PayPal
could this just expect a collection called `locator`?
well, no.
that is, member vars -only access.
Remove the TODO from above since we're now using this. Also add a comment about why we're using this because it's not obvious to me why we can't use the built-in serializer.
K. I will replace this by ``convert``.
pep 257

docstring should be a first short sentence on one line
then the main text block
try to stickt to pep8 when you code?
don't like name requestFullPage
No, I'm not suggesting removing it. Sorry, I was just hoping you had magic powers to get it released as a Final! :-) I've pinged the relevant people about that.
Make explicit. Also add disbaled copy ctor & = operator
".cmd" probably should be changed ".exe" in above lines, since it failed to run SConstruct.
reverted back.
Though from the other native class (e.g. button, label, etc.) it seems we decided to return container_ from NCO for each native object.
I find this data = that.get(); manipulate(data); that.source(data) to be weird. Usually get is paired with set, but here you have source as a combined getter/setter, as well as get, unmatched with set.
Needs to be an LinkedHqlExpr
So, every loop you register inotify handles, check for changes and re-register? I could be wrong, but it seems wasteful, and might not get some events (in between the checks)...

I think you should init the inotify on constructor and clean on destructor, possibly with a specific macro (```USE_INOTIFY```, set by default on Linux) to allow Linux installations to use the backup method.
Since boundCount is used twice the following comment is less applicable:  Generally it is better to avoid addFilter which is lower level and use the higher level buildFilter.  

So if you were *just* converting the contents of this if you should say

````
OwnedHqlExpr ifTest = createValue(no_gt, makeBoolType(), LINK(count), LINK(zero));
buildFilter(ifctx, ifText);
````

and avoid the calls to buildSimpleExpr etc..  In this case countCount should be already evaluated, so using addFilter would be as simple.  You could still use buildFilter, but instead of LINK(count) you would use boundCount.getTranslated()
Yeah, it looks that way. The function is well commented, so no worries here
Ah, no! You're right!

There's a return I missed...
This should not be needed, it was just there because the transaction was not active (hacks, hacks...)

Try first without it, and if the super locks, add it back and put a comment to fix it.
True. Although the default, in options.py, is not to use this feature - and there's a comment pointing out you need MicroTardis right next to it.
It would be usefull to mention events/core and how you can emit event to these registered listeners.
ok 應該刪
here, checking that ! password_failed_$(usergroup_user_index) would be great
```
{% if forloop.last %}.{% else %},{% endif %}
```
5 is the length of the "args." at the begging of each of the arg entries in the defstep.
oh right, thanks
Make this inline (as in `action unless condition` all on one line and no `end` keyword)
Also fixed a small layout issue
@yuhunglin It's not bad - just one line to gather external data. Such an improvement over the ajax hoops we were jumping through!
Why 8.2?
Rather than doing a filename comparison, I would give NemoImageMetadata a 'const QString &format' parameter, and check if that is "jpeg" (and call exifOrientationFromJpeg there - no need for this little wrapper). You can use QImageReader::format() to provide that parameter.

Qt will detect things that are not *.jpe?g and decode them, so it'd be confusing if they didn't rotate too.
Should we be removing the report_auth_info completely? Still seems useful to report the users to metasploit while writing them to alist for the user.
still apply if the output is intended to copy/paste elsewhere?
not really, dbg :$
It's  bit strange that a function named `something_to_some_map` sometimes returns a map, not a list. But you most likely had good reasons to introduce this change. Could you please elaborate?
This isn't the Hibernate 3 example ;-)
Well i decided we didn't need to remove these because we will need to wait for some time but i noticed sometimes the call was not finished yet. So i added `self.wait_for_instances()` after the call in the `main()` method below. This will make sure the asynchronous call is complete before continuing.
Maybe `Satellites` instead of `Orbits`?  On a larger note, we should probably get rid of the three example we have now and come up with 3 very different examples that showcase Cesium and CZML.
Should these use defaultValue?
Unless I'm mistaken, it seems like this practice for private methods only works if they are declared and called from within the constructor. In some cases it might still be necessary to use the underscore notation when the private function is supposed to be accessible by public methods.

Anyway, I'll make sure to move most of the private methods to the bottom of the constructor. Hopefully it doesn't clutter the constructor too much.
Yes, it's mocked out.  See the `josnp.loadAndExecuteScript = ...` stuff below.  I could use a nonsense server name to make that more obvious.
Should these be public properties?  If not, why not make them closed-over locals instead of properties, since they're never modified anyway?
Use TiC.PROPERTY_USERNAME instead of hard coded string.
Misspelled; should be `observer`
Should show example usage here.  Make it more clear on what to do. Maybe even override init so this can be used like a regular Django form.
It's not a question of ruby, it's a question of whether the harness is used as a gem or not. The top is the way it should work if the harness is installed as a gem and the setup steps are sourced in a separate project. The bottom for used as a script when the PWD is the harness' project root.
if possible 2.1 would be great .. but maybe some features will not work .. and i dont think we should carry too much BC baggage just for 2.1 compatibility. i am assuming here that all our current contributors are more of the type that will be ok with adopting 2.2 quickly, leaving the main question if potential new users might be hesitant because we dont support 2.1. then again the real target should maybe be 2.3 as its the LTS.
Any Controller, Model, View, Javascript, or Stylesheet (apply casing as you see fit)
I think we should cross that bridge when we get to it. Until then, let's stick with the simplest solution. Thanks!
Shouldn't this create a new Not Found Exception in stead of an access denied HTTP Exception ... because when this is used in the frontend the users will know the page exists but they don't have access to it. While for them the page actually doesn't exist. If they know it exists maybe they will try to hack it.
Must be some tabs in here. :)
Makes you long for Clojure's concurrency primitives, doesn't it?
use RemoteTools[] directly here
change this keyword to something more descriptive like collect_exported
don't use virtual resources, just do nothing.
This likely needs to be a `catch` with a logging error so that each submodule is attempted.
I had find the problem.

When changing the commit range, the list isn't the complete list of possibles range, but just an autocomplete list.

So the commit is now in the 2.0 branch.
why did you change the syntax here?
Spaces after : and ,
I agree and will refactor after @schmittjoh reviews it.
@uwej711 ok for you like this?
good point.  ok.  fixed.
Can this be a `button` instead of an `a`?
Needs a ;
Does not allow process id or name to be specified manually.
IMHO it can be like this:
````java
String objectName = element.getAttribute("object-name");
		String objectNamesRef = element.getAttribute("object-names-ref");

		boolean hasObjectName = StringUtils.hasText(objectName);
		boolean hasObjectNamesRef = StringUtils.hasText(objectNamesRef);
		if (!(hasObjectName ^ hasObjectNamesRef)) {
			parserContext.getReaderContext().error("Exactly one of 'object-name' or 'object-names-ref' is required", element);
		}

		if (hasObjectName) {
			builder.addPropertyValue("objectNames", objectName);
		}
		else {
			builder.addPropertyReference("objectNames", objectNamesRef);
		}
````
And that is why I propose simplify `NotificationListeningMessageProducer#setObjectName` & `setObjectNames`: all smart work is done by `ConversionService` :-)
Also there is no any parser's test about new attribute 'object-names-ref' and about exclusivity both names attributes.
Oleg, sorry for worry.
It's me again.
I've found another solution about this issue - @DirtiesContext
I've indicated it when I was implementing ```<jpa:outbound-channel-adapter>``` inside ```<chain>```
Some Gunnar's test-methods are markered with @DirtiesContext, but last one isn't. And I'catch problem with my own test.
So, this Spring Test ability resolves my problem.
Also I've checked it on the StoredProcOutboundChannelAdapterWithinChainTests and everythis pass again.
WDYT?
Maybe @DirtiesContext increases test execution time...
Maybe you can point out that it defaults to *DefaultSearchTermStrategy* if not specified.
More efficient to pass in size...

    return this.buildHandlerIterator(size, handlers.toArray(new MessageHandler[size]{}));

I have to say, this all still seems pretty crazy to me.

For 99.999999% of the cases, there will be one subscriber; but we get an unmodifiable set, convert it to an array, then copy it to another array (in 2 chunks), and finally wrap that array in an iterator.

It seems to me that, even for a few subscribers, it would be more efficient to just use the iterator on handlers to set up the new array. Perhaps we should add some optimization for when size is, say, < 5 ???

There is an optimization above for size = 0; it should probably appy to size = 1 as well.

Given that's the majority of the cases, I could live with all this copying for the rest of the cases. That said, it's not that hard; something like...

````
if (size < 5) {
    while (iterator.hasNext()) {
       pos = startPoint + 1;
       reordered[pos++] = iterator.next();
       pos = pos < size ? pos : 0;
    }
}
else /// array copies
````
Don't we still want to honor deleteSourceFiles, even when appending?
Just for info sake can you explain why this is necessary?
Oddly, this was not in your commit -- must have been part of a previous merge. Move along...
This forum link could also be standardised like the other links, e.g.

    :forum:`What are your LDAP  requirements? <viewtopic.php?f=5&t=14>`
              Forum discussion if you have LDAP requirements that are not covered by the above  configuration
these 3 lines are just for testing, right? Should these be excluded from merge?
sorry about the auto-indent making it all diff'ed. the notable change is here.