labofsahil/github-event-dataset-2012 huggingface dataset:
Anyway, I do not like that we are duplicating code here. No copy-paste please. Can you create a top-level function in models:

```
def limit_date(value, lower_limit, upper_limit, error):
```

which does everything you do bellow. On error, it calls `error` argument like `error()`. And then you can define `clean` like:

```
def clean(self, value):
    value = super(LimitedDateTimeField, self).clean(value)
    
    def error():
        raise ValidationError(self.error_messages['bounds'])

     limit_date(value, self.lower_limit, self.upper_limit, error):

     return value
```
Let's at least pretend like the code style in this file is uniform and adhere to the agreed-upon spacing we have in Butter as well.
**Typo** - `hasen't` should be `hasn't`.
**Typo** - `openned` should be `opened`.

(Fortunately caught myself before falling foul of Skitt's Law!)
「ブックマーク」じゃないですか
woops, a debug statement, cleaning...
You are absolutely right in creating connect as a payload, but it shouldn't have a message.  The act of connecting is not inherently linked to a connect message.  The server may ALSO send a message, but it should be sent as a messagePayload separately from a connect payload.
`PATH.join('test', dir, 'test')`
a proper name something like createLocalCommitPaths() might be more meaningful here
Above code should be replaced with createValidData()
I don;t like hard coding the :id=>2  but I like the fact that you have a comment there.
So going to ack this.
Is this the best way to do it? You are using a list comprehension in order to work on a numpy array. There must be a better, more direct way to do this.
Moreover, by using `None` you are creating `object` arrays. A much nicer solution will be to use masked arrays but I do not know how it is done.
I'm not sure I understand how we risk duplicate object creation though I understand your concern for performance issues.

More about this in a more generic comment.
you should removes these empty lines
Please use 0.2.* or >=0.2.0,<1.0.0 or something more restrictive because this is not good since they could break BC in a future release. We shouldn't assume they won't.
parseInt永远用两个参数
There is not "build" directory in the source tree.
Ok, this is now effectively done in the end! (see below)
Should have been removed when it was refactored.
Frankly there isn't any such need for the other thread-functions either.
This should be just a more general comment, I have this in the mentioned pull.
boost itself uses socket_base::reuse_address internally, but that's fine with me too
This list of strpos() calls is getting too long, would be better to change it to a single preg_match() call.
Couldn't this just be `!$cType` ?
Indentation is still incorrect, better use the code sniffer.
We don't use malloc directly. Look at Allocator.h
missing space before param section and return statement on docblock
nope. ``callable`` is a type, not a class. So there is no leading ``\``
@AaronThornton00 is there a reason this code has been commented out instead of deleted?
TODO: remove `command` structure as unused
When I try to use this code I get an error that i is not defined.  We need a `var i` somewhere.
May as well use `openpy` here as well.
I'd say logger.error()
Didn't know the tryFind method, and it can be very useful in other parts of the Abiquo provider. I'm going to refactor this to use it, and open another pull request with this change where it makes sense.
Adrian Cole <reply
+p-901011-5c234b13bece191df25cdb9666f143971ab6089f-1453210@reply.github.com>
 wrote on 30/05/2012 06:57:08 PM:

> From: Adrian Cole <reply
>
+p-901011-5c234b13bece191df25cdb9666f143971ab6089f-1453210@reply.github.com>
> To: Kenneth Nagin/Haifa/IBM@IBMIL,
> Date: 30/05/2012 06:57 PM
> Subject: Re: [jclouds] Added container handling methods and tests (#654)
>
> > @@ -103,9 +103,12 @@ protected CDMIObject(Builder<?> builder) {
> >      * identifier (ID) assigned at creation time. The CDMI object
> ID is a string with requirements
> >      * for how it is generated and how it obtains its uniqueness.
> Each offering that implements CDMI
> >      * is able to produce these identifiers without conflicting
> with other offerings.
> > +    *
> > +    * note: CDMI Servers do not always support ObjectID tags,
> however downstream jclouds code
> > +    * does not handle null so we return a empty String instead.
> >      */
> >     public String getObjectID() {
>
> is there an either/or here?  ex. objectID or name?  if objectID is
> not set, how does someone retrieve a blob?
There is definitely not an either/or relationship between objectID and
objectName,
however the spec. is sort of ambiguous in other parts of the definition.
According to the specification objects could exist with only objectID and
no objectNames,
but in practice I think this will be very rare.
There is talk about removing the objectID mandatory requirement from from
the spec,
since there is not requirement to support access by objectID and there
exists implementations
that do not include objectID in the response message.
-K


>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jclouds/jclouds/pull/654/files#r901011
>
Yes, i was thinking of maybe adding them as a data attibute on the button, good idea?
Why `tabindex="-1"` ? AFAICT, this is used to make an element non-focusable but it's already the case for `<div>`
everything in this file looks shweet!
As the function is called ``get`` (as opposed to ``exists``, for example), and to stay consistent with the rest of the API, I want to keep returning a result instead of True/False.
I know this is from the original code, but should we use the "requests" module instead? I've been switching to it for new code, the urllib2 API is so obtuse.

I'm not sure how much harder this would make unit tests though.
ohhh now I see what's going on here. The exception doesn't exist till *after* the connection has been made. Bizarre but I guess you know what you're doing. 

Still, the `.close()` still feels like it should in a finally block.
you can remove most of these imports
I think a comment or two in this sizeOf method would clarify things a whole lot.
the kind field needs to be split up into more fields, in order to represent the information :
* t.boolean :theoroidal
* t.string :exactness  (with values none, weak, exact, model_bijective)
* t.string :sublogic (with values none, embedding, sublogic)
* t.boolean :projection
* t.boolean :faithful
What would you think about moving the malformed_request_message stuff into its own module? Feels like a lot of code.
Instead of the defaults being global, simply make them belong to a configuration object.

This is in relation to the GENERATOR_OPTS let value, which should use the argv array given to the command line, not sys.argv.
probably missing docblock `@throws` tag here.
I have to say I don't quite see the advantage of this weird case `evaluate me this` vs the if/elseif that was there before. More lines and awkwardness for no benefit (that I can see).
better to write :

``` 
'cli' !== PHP_SAPI
I miss a space here, do I ?
A request-centric matcher can easily turn a path string into a request by creating a new Request object, which would then behave identically for the rest of the method. I think it's fine to require supporting both.
Can you link to the specific tests it breaks please?  I tried to look for them but didnt see anything.
Instead of changing the style for many elements (and thus duplicating it between the CSS file and the template), couldn't you toggle a class on some root element and handle the style in the CSS ?
没有或者，只有一个
Vorbește cu Alex și folosiți stilul de la bootstrap: xxlarge pentru input. și eliminați din css aceste stiluri.
The common case can have one less conditional here if this is written as:

```C
if (c >= min && c < max)
    histogram[(int) ((c-min) * ratio) ]++;
else if(c == max)
    histogram[bins-1]++;
else {
    ...
}
```
Maybe a better format would be:

```
app1:
  Load average: 1m: 0.04, 5m: 0.15, 15m: 0.13
  CPU: 0.8%, MEM: 74.1%, SWAP: 2.8%
```
Instead of using if/else, could you just throw a `return` at the end of the `if` block so the rest of the file doesn't need to change?
Unfortunately doing this means that the `print_scrolls` method is only being called the first time through...

```
Available Scrolls: active_admin, capybara, cucumber, delayed_job, env_yaml, eycloud, eycloud_recipes_on_deploy, git, github, guard, jquery, mysql, passenger, postgresql, prototype, rails_admin, rails_basics, redis, resque, rspec, simple_form, split, sqlite3, test_unit, thin, twitter_bootstrap, unicorn

Which scroll would you like to add? (blank to finish) thin

> Added 'thin' to template.
Which scroll would you like to add? (blank to finish) thin

> Removed 'thin' from tempate.
```

vs.

```
Available Scrolls: active_admin, capybara, cucumber, delayed_job, env_yaml, eycloud, eycloud_recipes_on_deploy, git, github, guard, jquery, mysql, passenger, postgresql, prototype, rails_basics, redis, resque, rspec, simple_form, split, sqlite3, test_unit, twitter_bootstrap, unicorn

Which scroll would you like to add? (blank to finish) cucumber

> Added 'cucumber' to template.



Your Scrolls: cucumber

Available Scrolls: active_admin, capybara, cucumber, delayed_job, env_yaml, eycloud, eycloud_recipes_on_deploy, git, github, guard, jquery, mysql, passenger, postgresql, prototype, rails_basics, redis, resque, rspec, simple_form, split, sqlite3, test_unit, twitter_bootstrap, unicorn

Which scroll would you like to add? (blank to finish)
```
Same here, we should encode the url variable before it's used anywhere.
This alert is where #412  goes
Такая конструкция избыточна, там помоему можно просто писать ", msgid, tagid" - работает varargs + auto boxing
You got it! :-) Including it right now ;-)
I think it’s a pity to use a div+class here.
You really don't want to use indexOf as a way to validate the application. Otherwise people will create application with such a name in the origin and weird things may happened.
same here, can’t you toggle the proper class name on the parent element instead?
Can you add some line breaks into this function. It's a big unified block very hard to read. Code needs to breeze :)
only semantic.... IMHO it's better to say if (Applications.isDownloading(origin)) and it isolates the logic
I remember FxCop doesn't like this static ctor for reference class.

(1) http://msdn.microsoft.com/en-us/library/ms182275(v=vs.110).aspx
(2) http://blogs.msdn.com/b/brada/archive/2004/04/17/115300.aspx 

Perhaps a static EnsureDefaults() would do.   No need to have locking, simply use local var to init and set back to a new effective static variable.
delta.total_seconds()
This I thought added clarity.
The idea of using a settings type is that the smart constructors can remain unchanged, so this parameter should be dropped. Instead, you'd set the parameter via `serverNeedLocalAddr.`
Don't fetch the main page - as many of your apps have shown, the main page can perform side effects. Instead, fetch one of the `_ah` pages.
To be consistent with other changes in this diff, use the exclamation point instead of `not`.
Did it was for Github issue. Changing Note to TODO.
Good point.  I considered the attribute name for compatibility but didn't think at all about fallback on the value itself.
what about the board?
why uppercase #CCC?
@chuanchang I guess @kongove meas you should not touch (close) the session if the session is passed into this function.
some example code:
```
sess = session
if not sess:
    sess = self.vm.wait_for_login(nic_index, timeout)
    created_session = True # set a flag here.
... balabala ...

if created_session:
    sess.close()
```
even better (for consistency):

```
logging.warning('target: <%s> must be a directory', pool_target)
````
only close session if it's created inside this function ?
there's a constant defined above to be used instead of 5.
Postfix `if` can fit better here, if the line is less than 80 symbols.
sorry, my mistake: it was a merge conflict and I picked the wrong version :)
Love what you did here, nice job.
**delegateEvents** を使用することは[render](http://backbonejs.org/#View-render)中に、jQueryを使って手動で子要素にイベントを結びつけることよりも、多くのアドバンテージを提供します。すべてのアタッチされているコールバックは、コールバックが呼び出されたとき、Viewオブジェクトを参照し続けるために、jQueryに引き渡される前にViewに結びつけられています。異なった`events`ハッシュを伴って **delegateEvents** がもう一度実行されるようなときには、すべてのコールバックを削除し、新しく委譲を行います ー 別のモードで異なった動作を必要とする時があるViewにとって有用です。
Have you tested these to see if they give expected results?  You really have to run them to see if they give the expected values.

In this case, there is very little chance they will.  I think that you're still confused as to what you're measuring.  We want the following:

1. a thread is continuously doing an rdtsc to record the time stamp counter, and recording it into a global variable.  You have that plus the addition of saving the tsc into an array which is unnecessary here.
2. When an interrupt occurs, it happens "at the highest priority", so it preempts the previous thread.  Thus the last rdtsc done in the previous thread represents our closest approximation of the time of the interrupt.
3. When the interrupt wakes the highest priority thread that is blocked on a read, the first thing that highest priority thread should do is take *another* tsc.  Then it can store into the array of measurements the difference between these values to get an elapsed time.
4. At the end of computation, you can compute the stddev and average of the values and output them to terminal.

Only step 1 is being done currently, as far as I can tell.  My question is what you thought you were actually measuring in this code.  I don't see any meaningful measurements being done.
Might be nice to have a comment here, explicitly saying: Yes, this is an exception. But we know we're doing it, and why it's the probably the best approach.
Please put the comment above the code it refer to. Also make it a bit more descriptive.
how about putting the contents of this 'else' block in a separate file? Perhaps lib/logstash/inputs/drupal_dblog/jdbc.rb or something?

Then you can just ahve:

```
if RUBY_PLATFORM != "java"
  require "mysql2"
else
  require "your-jdbc-hackery"
end
```
The view has to be updated when the model is updated, but model update is more generic than the view update. So updateModel calls updateView.
This is confusing could you please stick to `module.exports = ...` pattern.


```js
module.exports = require("api-utils/xul-app").is("Firefox") ? require("./tabs/test-firefox-tabs") :
                             require("api-utils/xul-app").is("Fennec") ? require("./tabs/test-fennec-tabs") :
                             {}
```

And export `./tabs/test-tabs` as a separate test file.
I really can't understand nor see the value of this example?
We should expose an example with only one promise, and it would be valuable to use a real life example, similar to this:

    // Make a promise of Http request
    function query(id) {
      let { promise, resolve, reject } = defer();
      
      let xhr = new XMLHttpRequest();
      xhr.open("GET", "http://example.com/api?id=" + id, true);
      xhr.onload = function () {
        resolve(xhr.responseText);
      }
      xhr.onerror = function (event) {
        reject(xhr.status);
      }
      xhr.send();

      return promise;
    }

    // use it
    let promise = query(10);
    promise.then(function gotIt(text) {
      console.log("succeed : "+text);
    },
    function failed(status) {
      console.log("failed with status: "+status);
    });
Is there a danger in always enabling this?
Does this rpm install /service/browserid-*?

Will this restart any unrelated services that aren't part of this RPM?

Are there already %requires entries for whatever rpm installs /usr/local/bin/svc?

Is the order of restarts important, such as static and browserid before router?
This is pulled from down below, I reordered the message processing to be handled in the same order as they are printed in stdout.
Haha copy paste ;)

I can kill that line
i don't fully understand what we are doing. but i guess the point of this thing was to prevent typos or undefined things.  i think strictly speaking with a query buildder you do not want to use SQL syntax so the constants should be used. but returning '' is certainly wrong. do we validate at some place? i can live with allowing to write the join method explicitly.
I can move all documentation to before the class definition - I'll work up a commit for that
I think creating a method on `Puppet::Indirector::Request` called something like `remote?` would make this clearer about what the logic is.
What is the point of a feature, supposedly for querying if you have some feature installed, that itself causes a hard failure when the answer is no?
What's the deal with Solaris tar? Does it not have gzip embedded or something larger? Are there flags we can pass to ol' crusty Solaris tar to make it work?  
I'm not opposed to gnutar (and it's probably more sane), I'd just prefer to limit external dependencies, if possible...
For this guard we usually use

```ruby
Rubinius::Type.coerce_to(ndigits, Integer, :to_int)
```

but I guess this is ok too.
You can set RBXOPT. Our default is still 1.8 mode, so normally that just  runs. You can then specify 1.9 mode with -tx19 passed to mspec. We should probably also add -tx18. 

In this case you also need to not run the spec in 1.8 mode, so you need a version guard like  ruby_version_is ""..."1.9" do which means run up to 1.9 exclusive.
This should be done above when fixing the selector (line 113) instead of doing it here IMO
and optionally, to get descriptive report with mocha reporters, about what filepaths have been tested. eaa19f9abe5833c80218282a0b142cbcf466d7a2 all tests regenerated.
Please break lines and wrap the statement around brackets (this won't pass PSR-2).
+1 on the casing.

I'd also argue that the exception caught should be added to the new exception.

E.g. `new Exception("Something happened.", code, $oldException);`

I am also wondering why the names are all lower-case?
Answered my own question by looking at the test failures -- you get a fatal error now instead of an exception. I'm okay with that, but it will require updating some tests.
getRequest have a special sense here because create a new Request if request is null
camelFail?
this is an informal spec :)
This test should then change to `if self.settings['LESS_GENERATOR'] == True`
This should not be in `Repo` since it doesn't require you to be logged in. It should be in `LoggedInRepo` I think.
check if language is "french" because there is need to add a special particle
@harjis Tästä funkkarista puuttuu kokonaan tuki käteinen/pankkikortti/luottokortti-konseptille. Tästä puuttu myös errorhändläys, eli mitä jos kassalippaan taakse ei olla tallennettu pikkeavaa tilinumeroa? Tsekkaa esimerkki teelaskuntiliointi.inc:stä riviltä noin 394 alkaen.
Taking my previous comment about `kernel.root_dir`, you won't need it here any more then.
AS comes after EAP :-)
Can't you just do `if current_user == contact`? I'm assuming a contact is an instance of `User` (if it's not, it probably should be)
@arr-ee good idea.
super minor, but i generally like to put the interface on the LHS instead of the concrete impl...

Map<String, Logger> loggers = new ...
you can also you 'unauthenticated' in principal` which is faster IIRC
Why pass in `MonthYearPicker` if it's not going to change names?
Interestingly enough the only way the display name is populated is because of this else statement. The UserProfile.objects.create(user=instance, display_name=dn) part actually doesn't deal with any arguments other than the user one. So the Display Name is actually being populated in the "else" of the if statement.
When I try to add the ircname directly after the creation of the userprofile (and by using the .get to get its object) it seems to store a hashed value (looks like it's related to the instance)
`deepEqual( newOptions, updateOptions, ...`
no space between '(' and '{'
make it `_teardown: function( options ) {`
if user
if user.new_record?
で迷いました。
×　userのvalidationによって、適切でないuserオブジェクトをcreateしようとするとfalseがかえってくる
○　適切でないuserオブジェクトの場合はsaveせずにインスタンス生成、適切な場合はsaveもする　結果インスタンス生成は両方ともtrue
☝この挙動が判らず苦労しました・・・
I need to actually try this out, there might be an accidental assignment issue with `action == "start"`. I will take a look a bit later.
timeoutMs?
You're defining `boxes` twice. I think you can remove the definition that's outside this function.
Any reason for the switch from div to paragraph?
lowercase for both, actually. `getGamepads`.  prefixed() will uppercase both while it checks for prefixes versions. but the standard unprefixed is targetting lower.
All code should be signed with the author or current maintainer for a few reasons:
* Responsibility. You are responsible for the code and somebody knows who to go to if they have questions.
* Pride. You wouldn't put your name on a pile of garbage, would you?

The conversation I had with you was about accepting contributions and understanding that you are not the sole author of a project. A successful project is influenced by many people.
Yes you are probably right. I think I am going to come back to this though -> I'd like to refactor / reevaluate a lot of the logic for handling responses. Some failure cases are probably not handled well atm.
@Afforess can you confirm this is right? It looks fine to me, but you implemented the run stuff :P
This also needs to be `@runs_once` annotated.
Ah, got it. Makes sense.
Do we really need ssl here? Just curious.
Figured it out, not sure how I added tabs here but they need to be gone, thanks.
You probably want isinstance(n, (int, long)). Python 2.x has two integer types. Try, e.g. isinstance(1L, int).
It was there in the earlier commits, but has been refactored out based on Nick's feedback and general code hygiene.  This line is commented out, but should have just been deleted.
Not sure if the conversion should be happening here. It feels like an idiosyncrasy from REST.js
Why do we need the tenant for anonymous users?
Might be better to do validator.check().notNull(), similar to updateFileBody
Optimist was already a devDependency. I don't think it needs to be added here.
Oh, nice, you can have a timeout on a test? Did not know that :-)
They check that there are no crashes. Yeap, I can remove the pool value.
I feel like you shouldn't have to register the default check if we are going to force it as a check anyway.
I know why this is here and it still feels icky. 

Is "Services" the right project name for this still?
`rand = arc4random() % [dict length];` - думаю, именно это вы и хотели написать.
Рассказывали. С помощью @synthesize. :) 

Поясню. Если мы объявили свойство 

@property NSMutableArray *DNA;

То, если вы пользуетесь последней версией Xcode, вам писать @synthesize не обязательно, он подразумевается автоматически. Но раньше нужно было синтезировать свойство вручную. Так вот, возвращаемся к свойству. По умолчанию, пусть нам и не видно, в имплементации после задания свойства как бы присутствует строчка: 

@synthesize DNA = _DNA;

Эта запись означает, что наше свойство теперь имеет сеттеры и геттеры, а состояние переменной доступно по _DNA. Можно правую часть вообще убрать: 

@synthesize DNA;

Эта запись означает следующее:

@synthesize DNA = DNA;

Теперь внутри класса упоминание DNA означает внутреннее состояние класса - переменную NSMutableArray *DNA;

Относитесь к свойству, как к макросу, который скрывает за собой что-то определенное, что раньше делалось вручную (сеттеры, геттеры, слабые и сильные ссылки, потоки и так далее) к переменным класса. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
В задание указано что должна быть отдельная категория. А это расширение
Тут не обязательно сравнивать с NO.

if ждет внутри скобок логического выражения. В данном случае isEqualToString возвращает YES или NO, после чего мы сравниваем с NO. Можно сразу использовать значение, которое вернет этот метод.

Примеры:
if (! [withCell.DNA[i] isEqualToString: self.DNA[i]]) {

или

if ([withCell.DNA[i] isNotEqualToString: self.DNA[i]]) {
неизвестно через сколько времени закончится цикл. При совпадении хромосом можно удалить ее из массива и брать остаток от деления на 3
Вернее при попытке передачи отрицательного числа выйдет исключение... Надо бы тоже исправить
Why did you remove these content_for :head ? 
Stylesheets inclusions should be in headers of an html page, shouldn't they ?
если нужно js: true во всех тестах, то можно написать его прямо в дескрайбе

`describe 'My Profile page', js: true do`

но я не вижу зачем в этих тестах джиес?
"Lehter" or "Punker" are better equivalents.
No need for `before_script` and `script`. Just add `connect` as devDep to package.json and the test execution to `scripts.test`.
filters and blob arguments
Does this make that one lint error get ignored? if so then, sweet, thanks :-)
The creation of the gherkin formatter should be handled by the JsonFormatter constructor. This logic is part of its internal "wrapping deal" that should not surface. The instantiation of the JsonFormatter would become as painless as it is for the other formatters.

When running Cucumber in a browser environment, the formatter has to be instantiated, there is no configuration management for that matter. The simplest their constructors, the better!
very clean approach, had it in mind too but wasn't sure whether you would like it. appreciate the public attributes!
The default params you've explicitly made false - not sure what they all do, and would rather trust default behaviour for now, unless you've thoroughly tested this in a few scenarios and on a few devices
I think `completedOrErrorsBySignal` and `valuesBySignal` are still appropriate names for these variables. We're just using a different "key" now.
It's useful if you need to generically serialize actions without keep a dedicated scheduler around.
> It could behave that way if it detected a `+currentScheduler`, and fall back if it didn't, but that would complicate both the implementation and the semantics.

I disagree. That's basically what we're talking about here – we're just debating which scheduler method it should check.
Here the description will suffice, commands imply something you type to trigger it, where as this just detects URLs.
ok.
but I'm not too passionate about this idea, if prefer the copying alternative, that's fine too.

On 08.10.2012, at 23:37, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -903,6 +904,63 @@ def _update_projector(self):
> >              return False
> >  
> >  
> > +class RawFromMerge(Raw):
> let's take care of this in the ICA PR then. if you're ok close this one for now
> —
> Reply to this email directly or view it on GitHub.
>
Per the ticket description you should be testing that a username with 2 chars only is valid and with one char is invalid.
Looks like `user_spec/0` is unused. Removing it will remove a dialyzer warning.
In the event of this BAD_REQUEST result, you will still log a success event in the monitor. Is that really what you want?
careful with case-sensitivity of header names
drop this code.
@cordoval sure, but this is **only** influenced by ``--prefer-source``. The ``--dev`` option will not change anything about the fact that you get a zipball without the tests
Sure, it's gone. 

I have a noob question though: I tried to stick closely to the contribution docs but couldn't find the described to link to change the base branch back to @2.0. I somehow managed to change the branch after some fiddling around but that left a PR for the master branch which I closed directly. I guess that's not how it's meant to be done so maybe the contribution docs are outdated or a little fuzzy? Chances are of course that I am simply blind… ;-)

Thanks in advance.

Cheers

Am 03.11.2012 um 23:02 schrieb Wouter J <notifications@github.com>:

> In cookbook/validation/custom_constraint.rst:
> 
> > @@ -217,7 +217,7 @@ With this, the validator ``isValid()`` method gets an object as its first argume
> >          {
> >              if ($protocol->getFoo() != $protocol->getBar()) {
> >  
> > -                $propertyPath = $this->context->getPropertyPath() . 'foo';
> > +                $propertyPath = $this->context->getPropertyPath() . '.foo';
> It's not your foult, but can you please remove the space around the dot operator?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
You should put this on the first line of the code:

    .. configuration-block::

        .. code-block:: yaml

            // app/config/config.yml

        .. code-block:: xml

            // app/config/config.xml

        .. code-block:: php

            // app/config/config.php
you need to double the ``\`` to escape them otherwise the link to the api doc will not work
why using a capital letter for ``extensions`` ?
这条指令的默认值近似于下面字符串
->
这条指令的默认值接近于下面字符串
Maybe I should use String#chop here?
private def closeChannel(): Unit = channel = channel.flatMap( c =>
  if (c.isOpen) c.close()
  notifyCallback(Stopped)
  log.info("{} channel closed", self)
  None
)
Created a ticket.
Minor beans, but I think the "left" should be removed (sounds a little better IMO), as well as "not a string containing a number" (you're not sure that this is the case, what if it's an Object of some sort?)
Только всякие @brief'ы лучше с большой буквы начинать (и в предыдущей функции тоже).
class name?
Yup;  also reported in #3
Status is an object, but its also the name of that column. Its been a bit awkard like that for a while, this code just shows it in fake mode.
Again, how come my name is here?  :)
I think you should return false if the future was already cancelled, at least FutureTask does it.
you should add the class docBlock with the ``@author`` annotation (you) and the ``@link`` annotation with the link to the CssEmbed library
I don't think there should be a semi column here.
based on the travis results, I am assuming ```viewvalues``` is not python2.6 compatible?
No, this is a framework unit test
We may want to cache this per client as well if we're potentially looking to do per-client slaves.
maybe take it out until it is tested/used, and keep this as a "TODO" until then?
`class="table table-bordered table-striped"`
GOD_DAMN_AWESOME_DENSEFEATURES may be
that line here is to long - 80 chars max is the limit!
Just a general comment: Try to keep the Markdown lines at 100-120 chars as well (same as PHP code),
because otherwise it becomes hard to review on github.
`GridFieldComponent`s, or `GridFieldComponent` objects (if we don't want to have the s directly after the class name)
can we activate feature per slug? eg. rails/rails ?
OK, I'll make those modifications and let you know when it's ready to integrate. Thanks for the code review!
This code is the guts of address-deleted reads: if the address is gone, magic up a clean page, otherwise, read the backing page and optionally instantiate all of the deletes ine page.
aha yeah... forgot about that.
這邊的每個區塊都可以 partial 一下
The assignment to ``$options`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere? Please also check line 92.
I suggest switching the operands. *The class is orange* reads better than *orange is the class* (unless you're [Yoda][1]).

[1]: http://united-coders.com/christian-harms/what-are-yoda-conditions/
public string GameExe = "DevPro.dll";
Test name says "should delete". Code says "create and read".
For anyone wondering, `change:x` should definitely be fired before `change:y` as `set(y)` isn't called until `change:x` is triggered!
I would probably match all of these with something like ':) ' so there is a space after, in case they are validly trying to say something something:Pblahblha
I just pulled this in, but would still be really interested to know whether or not string interpolation works within pattern matching statements. When you get a chance, @adriaanm could you just confirm/deny here?
Hm, I miss some `<tr>` tags here, I think.
Set fields to `required=True`.
And contains probably is not good choice here either.
Why we have this in account form? You want to allow changes to account only with password?
No line.
This would be better to move to `limit_date` function! Because it is the same for form field!
Be precise with spaces around `=`. This is function call, no spaces. And comma at the end.
Replace `val` with something meaningful. What is meaning of `val`? Value of what? What does it contain?
openhours_info?
Patch is small enough that it can just be inlined, i.e. placed after `__END__`
Why do we require everyone to have a secret key? what is it used for?
i don't undestand how do it better. i think that it would be better to create function in vehicles for find first passenger,
but this do GetPassenger(0).
Or u ask why i not use difine?
All of the above could be replaced with

    yum_repository "10gen" do
      description "10gen RPM Repository"
      url "http://downloads-distro.mongodb.org/repo/redhat/os/$basearch"
      action :add
    end

The `$basearch` isn't Chef magic; that's literally in the file, and yum resolves it when it reads the URL.

Also the cookbook will have to depend on the "yum" cookbook which has this LWRP.
Aunque se pase de 80 líneas en estos casos es mejor dejas atributo html junto a su valor (href="http:...).
Remove the NID hardcoding.
_based_ on that element?
Relative time from the start, i.e. if the event start time is at 150 ms and your zoom area starts at 100 ms, the relative start time is 50 ms.
And yea, it kinda sucks (I wanted something shorter than "relative" because it was usually too long for the tooltip min-width). It also didn't make it to the string review.
There are NULLs lying about in the code (or there used to be), I assumed it was because it was clearer you are setting a pointer (and there must be a way to deal with this in the code which must not be interfered with). All the minor formatting stuff was fixed anyway:)
Why do you define these in the parent scope? I would prefer if you uncomment these lines if possible. If impossible, please remove those 2 lines.
Why are you dropping those two lines ? They're responsible of redrawing the search view in case the object whose icon was just loaded is currently selected.
fixed in 40ad459
"Syntax on" is not necessary IMHO. At least I don't have it in my file and everything works :)
Your VM guest agent must use IQ to communicate with other bots, not msg.
This will help check the coherence of the commands, and avoid certain command.

Create a protocol like

```xml
<iq to="UUID@HOST/RESOURCE" type="get">
    <query xmlns="archipel:guestagent:command">
        <archipel action="execute" command="ls">
            <argument name="-l"/>
            <argument name="-a"/>
       </archipel>
</iq>
```
The configuration above is glassfish only.  I felt that it was beyond the scope of this effort (i.e. trying to find all the configuration that may affect large payloads for all servers).  I am updating the wiki to provide a guide to configure glassfish which they can use as an aid for configuring websphere/weblogic.  With that said, I believe we are doing performance testing with webpshere/weblogic and large payloads.  We can update then the instructions/config files if we see anything that will alleviate whatever bottlenecks that may pop up.
#111111 is much better in terms of design. pure black is a large attention whore
I don't know that we have any mechanism for passing warnings from C++ up to python users.  That would be quite difficult to implement, apart from printing something to stderr.  An alternative is that the `drawShoot()` method currently has a void return.  You could change the code to have it return the fraction of photons that missed fell outside the box, and the python code could use that information as seen fit.

On May 21, 2012, at 5:54 PM, Rachel Mandelbaum wrote:

>>      * @brief Draw this SBProfile into Image by shooting photons.
>> +         *
>> +         * The input image must have defined boundaries and pixel scale.  The photons generated
>> +         * by shoot() method will be binned into the target Image.  See caveats in `shoot()` docstring.
>> +         * Input `Image` will be cleared before drawing in the photons.  Scale and location of the `Image` pixels 
>> +         * will not be altered.  Photons falling outside the `Image` range will be ignored.
> 
> This might be a more general issue for later (and connects to a comment I made elsewhere a few minutes ago): it would be useful to have some kind of warning if too many photons are falling outside the range of the input Image.  I understand that it's probably too much for a first iteration of photon-shooting and isn't necessary for this pull request, but shall I open a new issue for this for later?  Or is there some reason why this might be a bad idea?
Next iteration?
I believe it's `O(n * m)` either way since `_.difference` uses `_.include`.  It might be better to use a lookup hash instead, but there are time/space tradeoffs to consider in that case.
do you still need this commented out code? if not remove it.
hmmm I've generally been making two separate lines, one per gender, for stuff like this...
for consistency purpose it will be good to move this file to webinos/test
I would create "import" API call which imports datapoints and makes sure there is no overlap with existing datapoints.
+1 newline
this seems wrong. This will be broken when using several firewalls as they will all use the config of the first firewall configured to use a max session. So all other firewalls won't be using their config
This is the drastically simplified version. It does almost nothing except parse the CSV into a string[][].
Spelling mistake there.
This should support #ifdef MODULE_VTOLPATHFOLLOWER_BUILTIN.  See Modules/GPS/GPS.c for an example.
s/implemention/implementation
Actually national calls .model_for inside it so it's safe
added assertion in case there is no exception.
Is the colon at the end a typo?
It is necessary because C99 style struct initializer is not be used in msvc.
Nit: spacing here with the return statement
Updated the code, and thanks
If it is once in a year, that's no problem. Translators can handle that. It us just that if you change one word in the srting, it has to  be re-translated to all languages. But if it is not so often, it is no problem.

I'll update this PR with your new version number in the string.
Thanks,
Cheers
this is a mass assignment problem.  see error on Comment model below.
how? overwrite the init paramter?
shouldn't this conversion be done in the code that's doing the eigen decomposition? it seems out of place in a set_diag function.
I did that at first, but wasn't sure if it was more readable. Thoughts? I can change it.
Might want to fix the error message too.
you're right. remove e then, since it is not used.
I think this needs to happen for "FAILED", "DELETED" and "DELETEFAILED" as well.
>>The first line is leftover from debug. The second line is too short to be warrant its own helper function.<<

If this is the only place this is used then fine.  If used more than once place then I would disagree.
I did check that the regression suite runs to completion leak-free. But there may not be a test i the regression suite that covers these lines....

Do you know what ecl construct is needed to provoke this case?
ECL_CLUSTER_S ("-cl") wasn't checked before ? and now is (ECLOPT_CLUSTER_DEPRECATED_S) 

Or am I misreading?
extreme nit picking - double space after !foundInterfaceHash
I ran this through jshint and it had 0 suggestions :)
This is repeating the point above.
```unless user```, наверное, тоже подошло бы
Why do you grab the currentStatus again?
This should have a opening quote not just a closing.
Since it is also an Android phonegap plugin, it shares much of the same
boiler-plate code as Schaul's plugin. Also, you're right to say it is based
off of his plugin.

I'm completely out of my depth with license law, and agree that we should
err on the side of caution. Let's include the licensing blurb as you
suggest.

On Mon, Mar 26, 2012 at 9:48 AM, Patrick Hayes <
reply@reply.github.com
> wrote:

> > -of this software and associated documentation files (the "Software"),
> to deal
> > -in the Software without restriction, including without limitation the
> rights
> > -to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> > -copies of the Software, and to permit persons to whom the Software is
> > -furnished to do so, subject to the following conditions:
> > -
> > -The above copyright notice and this permission notice shall be included
> in
> > -all copies or substantial portions of the Software.
> > -
> > -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> > -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> THE
> > -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> FROM,
> > -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> > -THE SOFTWARE.
>
> The code you wrote still looks based off of the Schaul plugin. I think we
> should still keep the license around. Read the relevant part of the license:
>
> > Permission is hereby granted, free of charge, to any person obtaining a
> copy
> > of this software and associated documentation files (the "Software"), to
> deal
> > in the Software without restriction, including without limitation the
> rights
> > to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> > copies of the Software, and to permit persons to whom the Software is
> > furnished to do so, subject to the following conditions:
>
> > The above copyright notice and this permission notice shall be included
> in
> > all copies or substantial portions of the Software.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wikimedia/WiktionaryMobile/pull/19/files#r604102
>
Null does appear to be a valid return however I have now added Routematch with capture against $_GET... however my original intention for the query route was to act as convenience for building URIs with a query string and I cant see a suitable use case for matching against the query
Buzz is required to use this bundle.
Yes this would be possible, it would be a pretty simple change:
public static bool MatchesAny<T>(this T element,  IEnumerable<Predicate<T>> predicates)

Only real issue I have with this is this turns it from a lazy function to a strict function....though that may not be a bad thing.
@christianv Yes and no. Using ng-include to eliminate bulk  of the duplication, though some still remains. Duplicating as little as possible, but was thinking the "no tasks available" bit could be made into a directive. Another day.
Yes, you can.  It'd be neat if you implemented it with session.fs.file.stat.  =)
BSD_LICENSE or MSF_LICENSE?
Just to clarify: I meant the call `plt.plot()` (no arguments) can be removed, not the call with the `filtered_coords` as an argument.

Also, that call with `filtered_coords` can be changed to:

```python
y, x = np.transpose(filtered_coords)
plt.plot(x, y, 'b.')
```

which is slightly more readable. (I know these lines aren't part of your PR, but while you're at it .... :)
Should be "with the same id"
if `description.context` is optional, it should be in brackets and there's no need to call it out as optional in the description.
I thought about doing it this way, (your first example).  I'm not against it, I just made a preference call.  I can change them all to do it this way if we agree that's how we want it.  I'll then keep that pattern with other core types as well.  @shunter thoughts?
Good catch.  Yeah, that is accidental as the configs dir really shouldn't be a item in the cfg file since that is part of the checked in test content.  This might change in the future but for now...
That bit about opening as modal only applies to iOS actually. I updated the docs to be more clear on this point.
I really think we should be using the update operation since android provides this.  When you delete/ re-insert, the action is not guaranteed to be atomic, so something can happen in between (maybe another app queries for the same contact and finds that property missing).
DOM3 spec. IOS and android have DOM2
In the doc http://docs.appcelerator.com/titanium/2.0/#!/api/Titanium.UI.WebView, "The native web view handles scrolling and other related touch events internally. If you add event listeners for any of the standard touch events (touchstart, click, and so on), these events do not reach the native web view, and the user will not be able to scroll, zoom, click on links, and so on."
I also tested on iOS. If we add click event listeners to the webview, it will not call the native click.
```
if ()
  ^ пробел
```
@jjinux not exactly sure what happen here, looks like eb6962a got sucked into my pull request.  The only ones coming from me is f02920b and bdfcc0f . Should I try and remove eb6962a from my comment log?
gotcha. agreed.
I think this is the problem, @daniel-pittman...it's resetting the ISO_VERSION to $1 for every call, not just the calls where the version number was not included when this script was run...
same pw and encoding
I'd just like to give a reminder that when you switch this to enforce you have to switch the expression around so it becomes:
`enforce(fmt[0] == '%', new Exception(...)).` It's very easy to make the mistake of keeping the test the same when switching to enforce.
`R r;` fails if `R` is a struct with disabled default construction.

Are you asking whether or not such structs should be valid ranges?
If I wanted to pick nits, I might say that this should read `b < a`, but I guess due to `opCmp` it's okay either way.
Yes, you're right. I couldn't remember why I added that comment in here and  didn't add base type.
Will fix.
Good catch. It's a pretty simple fix using the new Appender: 

array = app.dup; 

to

    static if(!is(T == immutable) && !is(T == const) ) {
        app.dupTo(array);
    } else {
        array = app.dup;
    }
Copy/pasted code is a terrible thing. I just copied the ServerConnectEvent as a template for this. Didn't even notice that line :)
It has only one parameter, and `this` can not be null as that would give an NPE when trying to call `.equals`.
Does this need to be in the Users namespace? Can it be moved to the module namespace?
the name BodyComponent is a bit strange to me. Not sure what else to suggest, though. MainComponent or TodoAppComponent perhaps
I haven't tested this on dart2js yet :)
This change needs submitting to richfaces quickstarts.

BTW we should consider renaming this to helloworld-richfaces.
Doh! This shouldn't even be here. Sorry.
This cast can be removed (we already cast in the setter).
`LeechCraft::` излишне.
why all this special stuff, requiring extra logic for each locale ? You should use the ``transChoice`` method of the translator instead which already handles this for you (including stuff that are not handled in your implementation)
Also - for forward portability, I'm trying to use the new s`.format()` string-formatting rather than %-formatting, which is deprecated in Python 3. Short version: `"some string about {0} and {1}".format(replaces_zero, replaces_one)` in place of `"some string about %s and %s" % (replaces_zero, replaces_one)`. Full reference in the PEP: http://www.python.org/dev/peps/pep-3101/
Isn't the FPU supposed to be saved by the callee ? If not, indeed, I have to add that.
As Gary said before we should document this `jdbcTemplate` limitation.
By the way there are another solution: `JdbcOperations#execute(StatementCallback<T> action)`. And further we may use logic of `applyStatementSettings` manualy. In this case `jdbcTemplate` will free for shared usage as before. Similar solution is in `org.springframework.batch.item.database.JdbcCursorItemReader`
WDYT?
Of course, it may be changed in the 3.0, as you said in the JavaDocs, Gunnar
I'll fix the typo.
As far as migration notes we actually are having a wiki page that we update once something like this happen. For example: https://github.com/SpringSource/spring-integration/wiki/Spring-Integration-2.1-to-2.2-Migration-Guide
This should probably be alphabetically sorted.
Better to use the first Jenkins version, maybe, and then use the correct group id
Align with `help`.
No need for pre-increment since you aren't making use of the value directly