Fixup update.py after argparse breakage

Commit 5b9cb4148 changed the way cfg support's positional arguments and
broke update.py. Use the new positional argument infrastructure.

Change-Id: I0dc8b5ec445daaf3b437eb524c6eb4b684e5a695
Fix broken --help with CommonConfigOpts

Since we switched to argparse, the way help strings are interpolated
have changed and broken --help with the options registered by
CommonConfigOpts.

Fix and add a new test case which would catch the issue.

Change-Id: I10e42efe4721e22ff41d0efbf390c805ccb9a6a0
Hide the GroupAttr conf and group attributes

There's no reason why an option group shouldn't have options called
'group' or 'conf'.

Add a test case which would have failed because the 'conf' attribute
would have been a ConfigOpts instance and fix it by making those
attributes private.

Change-Id: Ic3e41a546c0d1b7b6aae04e1dbac2933ac661f57
Add another duplicate opt test case

This gets the code coverage of the tests back up to 100%.

Change-Id: I737c1cfa52d10b3813237a9cb88b15211e0872c1
Fix common rpc to use common logging instead of python logging

Looks like we just need to fix imports

Fixes Bug #1072633

Change-Id: Iac84ae3aadbe440f9b19e184f080320e4c6cca5f
Fix regression with cfg CLI arguments

Fixes bug #1082279

Only options registered using register_cli_opt() should be available via
the CLI, but since e42276a all options are added to the CLI.

Also modify one of the existing unit tests to catch this problem.

Change-Id: I742a4ae4e0fc17cd9ae5e4424c2edd38e2bc50a2
Merge "Fixup update.py after argparse breakage"
Fixes import order

Rearranged import order of openstack.common.rpc.matchmaker

Change-Id: I034a96e459763910adf51dc8f6642d6485208732
Replace try: import with extras.try_import

The block form:

try:
    import foo
except:
    foo = None

is confusing to code analysis tools looking for redefinition. It's also a
common enough pattern that someone else has encoded it into a library. Let's
use that instead.

Change-Id: I35a5c7a7e3595a51ba1ef1886c3965f463dba04a
Make project pyflakes clean.

Added both a tox test-env for pyflakes and fixed the current pyflakes errors.
This did actually fix a couple of bugs.

The CI team has started using pyflakes on its projects and also has started
using oslo for things, so ignoring pyflakes warnings on the oslo code was
starting to get old. However, additionally, pyflakes is pretty solid, so we
should maybe consider gating on it across the board. (% locals() is the
biggest thing that we do that it doesn't like)

Change-Id: Iac1ca62db301892b7863711162fcbc74807eb24f
Provide i18n to those messages without _()

bug 1081498

There are a few log messages without _(), but a lot messages with _().
Wrap these log messages with _() in order to make the code consistent.

fix missing imports for _

Pass the log message and interpolation argument(s) to the logger separately

remove extra parens

rework the patch against latest trunk

Change-Id: Ib0a7b0f9c57aadfbc2cfc477c6123b885c9c6060
Qpid H/A cluster support

Implements blueprint qpid-roundrobin-reconnect

Change-Id: I01b65e6c33a238663667e9b6023b90172f1b77dd
Merge "Fix broken --help with CommonConfigOpts"
Merge "Add another duplicate opt test case"
Merge "Fixes import order"
Use Service thread group for WSGI request handling

- Reuse the pool from thread group in service.Service
  instead of creating a new green pool
- Add ability to control the size of the pool in service.Service
- Add a couple of tests for wsgi.Service() to test the size
  of pool a start/stop as well
- Get rid of the wait method by using tg.add_thread
- Get rid of pool in wsgi.Service
- Added explicit property for host and port

Fixes LP #1050379

Change-Id: I40507dc7887fb036ec594bb167cdaa42c278607e
Merge "Fix regression with cfg CLI arguments"
Merge "Hide the GroupAttr conf and group attributes"
Merge "Qpid H/A cluster support"
Merge "Use Service thread group for WSGI request handling"