labofsahil/github-event-dataset-2012 huggingface dataset:
I believe the only difference between Assert and AssertJunit is the order
of the parameters.


On Thu, Dec 13, 2012 at 5:18 PM, tristantarrant <notifications@github.com>wrote:

> In
> core/src/test/java/org/infinispan/distexec/BasicDistributedExecutorTest.java:
>
> > @@ -527,7 +537,14 @@ public int maxFailoverAttempts() {
> >
> >           Future<Integer> val = des.submit(task, new String[] {"key1"});
> >           val.get();
> > -      } finally {
> > +         throw new IllegalStateException("Should have thrown exception");
> > +      } catch (Exception e) {
> > +         assert e instanceof ExecutionException;
> > +         ExecutionException ee = (ExecutionException) e;
> > +         boolean duplicateEEInChain = ee.getCause() instanceof ExecutionException;
> > +         AssertJUnit.assertEquals(false, duplicateEEInChain);
>
> AssertJUnit is miles better than using plain assert or other assertion
> tools, because it prints out proper error messages (Expecting x found y)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1509/files#r2408220>.
>
>
Heads up, this is important but necessary change. Without it get on the Future with Timeout does not and can not work. The reason is that line setNetworkFuture((Future<V>) localExecutorService.submit(call)); in the change below cannot execute on a calling thread. If it executes on a calling thread proper network future does not get installed and timeout on get does not get triggered. The only downside that I can see from this change is that users must call DistributedExecutorService#shutdown - but they should do that anyway.
This block needs to be copied, because it may get invoked after this method returns (because Specta b cray). I'd also move the initialization into the `beforeEach` block, but I don't remember what problem I ran into that made me start doing that…
No need for this comment now.
I am not entirely sure if that would make sense and did not look at the internals of this method so far. Let's for now suppose that input with a higher dimensionality than 1 does not make sense here. If so, I would add a dimensionality check and document that x, y, z are required to be 1D. This would have to be done for all the other plotting methods in the Axes3D module as well.
Nope, but always happy to learn.  
help(assert_array_almost_equal) referred me to np.testing.assert_allclose, which in turn referenced np.allclose(). A useful np shortcut I was not aware of. Thanks :+1: 
(p.s. It seems that generalizations added by assert_allclose, like handling inf/nan values, are redundant in this case, and probably not worth the complication of extra import and runtime, so I use plain allclose() ).
We don't usually name such variables with the `_element` suffix.
>> +        # follow redirects for up to 5 hops
> 
> Are you sure we need to duplicate these lines? It has been a while since I wrote this code, but I think the `$curl` here comes from our `Request` class, which means it passes trough the `_build_easy` there?

I think you're right, don't need to. I haven't tried to fully grok all the code. I've just been looking at a number of Curl modules, and the first change was a quick hack :-)
Have removed from WWW::Curl::Simple, and just left the code in ::Request
How about this:

```
var e = {filter: this.createFilter()};
this.layer.events.triggerEvent("loadstart", e);
this.response = this.layer.protocol.read(
    OpenLayers.Util.applyDefaults({
        filter: e.filter
```

This allows loadstart listeners to change the filter entirely.
Always use shell paths instead of hardcoded windows paths because Windows likes to virtualize these directories (and virtualization IS used for program files in the cloud). In this case, use File.join(ENV['ProgramW6432'], 'RightScale', 'Mount', 'Softlayer').gsub('/', "\\") instead of "C:\\Program Files\\...".
I have to use this matrix in various computations of cblas_dgemm,etc so i dont know how to do that in any other way.
But i'll work on it and will inform you if i find any other problem.
why the extra newlines here?
Yeah im not sure either :)
Please check if this is what you expect it to be (I think you want `stdClass`, but it could be `null`).
Is there a reason we don't just do `$(lastToggle).remove()` here?
Can you do the BIO_FREE stuff in a error: block and use goto to remove this duplication?
Is it possible to define a more specific type for parameter ``$subject``; maybe using a union like ``null|Object``, or ``string|array``?
This is using the wrong versioning system..
No space between method and and args list when using parens.
Muss keiner sein, kann aber. Es ist nicht nötig für jede Representation einen neuen ObjectMapper zu erstellen. Man kann aber. Was ist besser?
Would it make sense to throw a new exception with this as the message?
What if you just add this line to the `clean` function.
Dans ce genre de cas tu peux utiliser une syntaxe plus compacte du type :
$max_view = !$max_view ? 1 : $max->f('max_view');

C'est en gros le "if" "then" "else" compact
Heu oui, t'as raison, au temps pour moi !! Je me suis trompé ... mais c'est sur le principe de gagner une ligne ;-)
I removed it because it doesn't exist in ruby1.9 at all - not even as a gem. You can find some third-party ports, but that all feels a bit hacky. Since it didn't seem to affect 1.8 either, I didn't worry. I have no windows machines to test on, though, so I'm unsure how to fix the problem.

We are still including 'net/ping' - is there overlap?
Sorry I didn't know we were doing it that way, thought it was a mistake.
I don't know. What they are using in their API? Use the same.
No. This is wrong.
So you have three levels. `panels_dependencies` -> `panel_dependencies` -> `panel_dependency`. Ugly. Find something better. :-)
Of course you should import this in a way to have a shorted function call!
I would simply have a functions which redraws the list. And then I would add or remove from internal JavaScript store (dict). And call that redrawing function.
What is stored in `value`? Name the variable after that.
One empty line above.
Also - could we get a link to the upstream issue? Thanks!
Right, but I'd rather have less flexibility and keep the code simple; the goal of ActiveMerchant is to abstract away gateway details, and if someone actually needs to pass the string through, AM probably isn't the right solution for them.
thank u. i'll add it.
Yes, you are correct. It wasn't the best naming on my part, but I couldn't think of anything better. It is the *ACL* for an object that is *shared* with you.
```ruby
@coupons.reject(&:applied?)
```
you should do it before the str_replace call
don't confuse the `hibernate.dialect` property with other properties as:
`hibernate.ogm.datastore.provider`
`hibernate.ogm.datastore.grid_dialect`

`hibernate.dialect` is ignored by OGM.
I like the way that you have scoped this down. I was modifying a tool that already existed and didn't feel comfortable removing functionality, even though I had a hard time imagining a world where you only restore one table. 

In order to avoid the delete masking problem, we have to start with a clean slate. Otherwise, we can not guarantee that users haven't performed a delete. There are two options that I see:
-Kiji keeps a map from table name to rowkey in the meta table. When we need to a clean slate to restore metadata to, we reassign the row name to point to rows that have not been used yet.
-Kiji tracks the hbase table being used as the meta table. When we need a clean slate, the create a new table kiji.<instanceId>.metav1 -> kiji.<instanceId>.metav2

I think the second option makes the most sense in the "world is on fire" scenario that we expect users to be in when they restore their data. Does this make sense to you? Should I implement this now as part of this change?
Still reviewing but I also changed this in my copy - and suggested the same in #14
This etag header is existed after Nginx-0.1.25. But the macro of clear_etag and etag module appear after Nginx-1.3.3.
This hunk (the ternary expression changed to an if statement) seems unnecessary, though I'll defer to you if you think it's clearer as an if statement.
Prefer `_urd` for private data member instead of `urd`, as elsewhere?
Ohhh.... sorry. I undestand now. I delete this line by error.
Cannot approve commented out code. Please either comment why this line is so important that it must be left in or remove it! Tanks :-)
I think requires n+1 database queries.

You should build the list of friends and then append them all to the campaign

I.e.

friends = []
emails.each do
  friends.push(Friend.new())
end
campaign.campaign_friends = friends,

(I might be wrong)
How about using something like `Iterables.getOnlyElement(apps)` instead of copying the collection just to call `get(0)`?
This one, with an array of 300000 and chunks of 13 took 16ms.
I suppose password should be hidden
So there's no expected action for **B** when the subscriber adds it? Or you test that **B** gets added in a separate test?  It is difficult to understand what the test intent is here.

Perhaps if you changed the **action** column name to **first action**, that might clarify it a bit.  For non-technical people, the underlying assumption of "one assertion at a time" is a foreign concept.
No warnings or anything if the option is double or non-scalar? Just silently ignore it? :(
Since you're checking the parameter below before calling update, you should make this `None`.
Why not just use `javax.tools.Diagnostic.Kind` to begin with? You introduce a Java 6 dependency in `plexus-compiler-api` but since you are doing so already in `plexus-compiler-javac` this seems harmless.
Shouldn't we use getitem here, to do a single fetch of just that entity?
We get a factor of 4x in speed due to the skim filters for some of the MC samples, so I think it is good to only run the tuplization if necessary.

I don't think you can get away with not putting the tuplization in a path after a filter, if you only want it to run if it passes any filter.
It will, but your suggestion is much more bullet proof
Another few tabulations and line-ending white spaces around here.
Correct, fixed now.
Is this really usefull ?
Yeah, I tried that, but apparently is casues a huge amount of runtimes. This one doesn't. I have no idea why.
Yesterday I merged the changes to use JdbcOperations/JdbcTemplate instead of the deprecated SimpleJdbcTemplate.  If you need the JdbcTemplate, can you please update this.  Otherwise, this actually doesn't seem to be used here so please remove.
GrowlJob und ProwlJob (beide in Shared)
LinkedList/ArrayDeque
My understanding is that -h has been deprecated.

-Randall

On Apr 4, 2012, at 6:47 PM, Stuart Eichert wrote:

>> @@ -1,5 +1,11 @@
>> #!/bin/bash
>> 
>> +SOURCE="${BASH_SOURCE[0]}"
>> +while [ -h "$SOURCE" ] ; do SOURCE="$(readlink "$SOURCE")"; done
> 
> test  -h and test -L are the same thing.
> 
> I would normally use $0 as well, but the suggested solution for this problem that I found on stack overflow used BASH_SOURCE[0].  I don't know that it really matters.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/isis-project/isis-project/pull/5/files#r648597
複数の closure とか pattern が指定された場合は最後につかされたほうが有効になるという話ではないでしょうか。
Indentation looks a bit weird to me here. Also, I prefer the arg of ``sum`` to be explicit ``sum(axis=1)``. Don't know why. Guess it is an idiom?
I think you know it already but you're missing other kernel parameter. Have a look at KernelPCA, for example. And (to be checked), the default value of `gamma` seems different from other estimators.
Could you please include both test cases? I think the old test with the tie should still pass, doesn't it?
Should be `net.xp-framework`.
I thought this trait was meant to be used only with a struct because it's the only D type which may or may not be a POD based on its definition, hence why a trait is necessary. For other types the POD check isn't necessary. 

But how are all non-struct types PODs? Classes aren't PODs?

Are we implementing an `isPOD` trait for structs, or some kind of `isPassedViaRegisters` trait? I'm confused at what your definition of a POD is if all non-structs are PODs..
Also would expect to see show at the same level.  Also of note is that some elements already have there implementation of hide and show.
Seems reasonable that the opacity should be applied to the container for the background as well.  On the other hand since the alpha of the container can also be set we could end up with double the transparency in some cases.

Checking the other platforms is the best way to figure what needs to be done here.
QHash should not be defined in this base class. The intension is this is an abstract class that can be used by all platforms. If this is required by all Titanium objects, a class that inheirits NativeObject should be created.
Changed it to setget to be consistent.
Remplacer par un exemple d'installation sous windows
Attention, bien separer les `code-block`

```
example:

 .. code-block:: none

    phraseanet_indexer.exe --install
    ....
```
I thought that, but then I decided that (given that fact) the overhead of the cs was also insignificant...

What's the objection to the static object? We have a lot of static critsecs...
You should only be evaluating boundCount once.  Therefore the code below to unconditionally evaluated it should be before this.
Yes, it would be great to have these match our current terminology, but that would require a lot of thought.  These interfaces represent our web service interfaces and are used all over the place, including eclwatch, client apps and tools, and possibly external applications.  Definitely not this pull request... maybe 4.0 (or 5.0 <g> )
Should spillPriority be set to disabled instead of the additional checks for rc_allMem?
I think it's ok for this to be ignored here, for now.
I have half a mind to namespace it to `Library`, so that you could (in theory) be like "What are all the libraries loaded at this moment?" and avoid common namespace problems. Of course, all the library objects will be protos of the `Library Specification` object so...

I may yet have an `Io` namespace. Bleh.
Yes, I know. But having a common interface / class at least to be able to know that we're receiving a Query / QueryBuilder object would be nice. Regarding this case.. the only thing we can do here is to move these methods to the AbstractRepository classes.
Thanks.  0ddd1c783f1f466f26df5bfec79f7a8d0b072fcf
This line is great!
The indentation is wrong for `onClick` and `attach`.
Can you please update the links to point to the mozilla account on github? With that fixed we can get it merged.
I have checked this about count, and it works good, can you give an example?
OK, this may result in something a bit ugly in the file, but it makes sense. Thanks for the explanation.
This seems to be duplicated code, now we have two places where we handle `resIndex` and `apply`.
Why don't we just modify this line with
`this.$callback(cb, res)`
add mmg in the aserrtt
add  if($this->_Db){mysqli->close($this->_Db);}
Why not call it: InfinispanExample? `IIinfinispanExample` looks odd.
Also looks completely unused except in the specs
Since we're authenticating anyway, can't this be determined from the target?
taking note :P
I'm guessing the `c3` was *not* a mistake, but maybe `c3 -> c2`, or `(c0, c1, c3) -> (c1, c2, c3)`? (I'm not sure about this.)
5d?
This should have some kind of information that bourne is required.
If we return the view source page object then we could change this to `view_source_pg = home_pg.click_view_source()`, so we'd save importing the page class and the following line too. :)
It's probably cleaner to just explicitly check against `undefined` and let short circuit evaluation (JavaScript has that, right?) avoid the allocation.
You can probably predict my thoughts on this function:  this is an ad-hoc, special-case implementation of a promise system :)  Compare to `Core/loadImage` on branch `imagery_layers`.

This is a good incremental improvement over the status quo, though, to start centralizing image loading.
`type` is OK with me.  @IanLilleyT?
The default alpha, 1.0.
So when can @IanLilleyT and I get a hold of the "right solution" for use in the material system where users specify image urls in JSON and we want to load the image and create a texture.
Var dec at top
extra semi colon
Yeah, I think a method taking Properties should be there.
Debug and test code needs cleaning up at some point.
I believe the "checked" attribute is used in the TPL_INPUT variable, which occurs in the Template for loop. It just wasn't very obvious, and will be moved into it's position per your first comment on this file.

var TPL_INPUT = '<label title="{name}"><input type="checkbox" value="{name}" {checked} />{name}</label>';
Thanks for the tickets @walterheck 

Looks like you still need to sign the CLA. Go ahead and comment here or on the ticket when you have signed it.

https://projects.puppetlabs.com/contributor_licenses/sign
я б с удовольствием это сделал, но сначала всякие остальные важные штуки :(
Please use `sprintf` here.
Or should it just prevent seeding as well?
s/Internal/Impl/g
@alexrp, can you post you opinion here too, please?
It's for objects that are declared as `inout(int)[]`. EG: static `assert(!hasSwappableElements!(inout(int)[]));`

TBH, I don't know *what* a `inout(int)[]` really is.

The original code was written by @denis-sh , in his implementation of `lvalueOf` in #954.

While I can only observe that it is needed, he actually took the initiative to put it in, so he may have a better idea about this.
just use `return typeof(this)(_data, i + _a, j + _a)`
why change from good style to bad style?
Do we need to escape quotes in the name here? e.g. this appears to work in JS:

    var d = document.createElement('div')
    d.innerHTML = "<foo data-x\"bar=\"baz\">"
    d.childNodes[0].dataset["x\"bar"]  // returns "baz"

Perhaps add a TODO so we don't forget about it. I opened: https://github.com/dart-lang/dart-web-components/issues/88
I think the confusion in these comments might be due to naming. The encrypted username is not encrypted with the sync key. (I believe the encryption refers to encryption by the Master Password, which does not exist ATM.)

Since the username/password is not encrypted, and we have no way of encrypting it, the only way to find a matching record is to filter through the unencrypted records returned by the query.
People were missing it and going straight to the cms, where the warning appears again anyway. I think I'll put it back though, because it's only when you view a page within the cms that it warns you again.
This will duplicate the "Recompiled." puts statement from the recompile_coffee method.
gquery-plugins shouldn't be better as artifactid ? At first glance, it makes think that we develop our own version of gquery
Should test all supported types here: float (`3.5`), boolean (`true`, `false`) and date (`new \DateTime('06/21/2012')`)
Makes the timestamp be the name of a datatree node. Could run into issues if multiple interviews, or multiple teacher trainings, are scheduled at the same time. Can you integer index the names, like we had been doing when we manually set them up?
Falsche check-Reihenfolge....
PHP muss für einen > Vergleich $price bereits zu einem numerischen Wert konvertieren... Wenn das möglich ist, ist der zweite Check hinfällig!
Wenn's nicht möglich ist, wird bereits der erste Vergleich fehl schlagen.
Das funktioniert so nicht.... denn discussions ist ein array... publicComment wird "array /Deadline: dd.mm.yyyy"  sein.

Um die Diskussion zu serialisieren wirst du darüber loopen müssen.

for($discuessions as $discussion){
  $comment .= $discussion->createdAt() . $discussion->getComment();
} 


Da diese Diskussion ja anschliessend veröffentlicht wird, wäre es cool, wenn sie anonymisiert ist. Das heisst... Kommentare vom Kunde mit "Kunde", Kommentare vom Proofreader mit "Proofreader" und Kommentare vom Admnt mit "Admin" als Author anschreiben.
($user mit $order->getUser(), $order->getProofreader und $user->isAdmin() ) vergleichen....)
Hmmm... how come this didn't cause last night's Pseudo TX merge to fail on the CI build?

Sounds like Redis is not running on the build server.
there are more chars allowed in JMS property names; refer to the JMS spec
I don't think we can deprecate this for the reasons stated above.
That seems to be copied from something JDBC related, isn't it?
Updgrade  to 1.4.1.
I think you missed a JText here ;)
Will fix all of this (this file was actually a move + addition of 2 functions but git didn't see that).

About CS in general, the bundle already had some places where it wasn't entirely proper. I can send a different PR fixing all CS after checking with phpcs.
Thanks, that is a left over artifact from before I implemented the Search_History class.
please do not mention this one, we only included it to work if people do guessing. or put it as alternative for Long - it is just an alias
These seem redundant. I think we can trust Python's `=`.
Does it work for application URLs with and without the trailing '/'? E.g. `https://myapp.azure-mobile.net` and `https://myapp.azure-mobile.net/`?
In places we use regex, can we please be clear about what exactly the regex string is supposed to do?  It would be nice if it was a more descriptive variable than 'r' and maybe a comment explaining the regex?
There are mulitple KML namespaces. 
http://earth.google.com/kml/2.2
http://www.opengis.net/kml/2.2
just to name a couple as well as versioning of kml .
Thanks Javier, I'm getting: Notice: Undefined property: stdClass::$created_by on line 183, going to check into it
So, this is probably me not knowing ruby, but this do block is in a map.  Shouldn't the block return a value for the map?
Exactly the service version should not be customizable it's something that the SDK states. For example imagine if we have a new version `2013-1-1` and user passed that while this version exists, the code will not parse the new elements provided in this version and the user will be wondering why that is happening.
filter returns a new array, it doesn't modify the original one in-place... so I don't understand what your code is doing here.
If the subtotal is updated when you tell it to not reprice, we need to investigate why.
moved to the ExposedRoutesExtractor to reduce the amount of logic in the controller and make things reusable.
Thanks for your pointing out. I'll remove changes for 7542 and 7543.
I mentioned this earlier, but I really prefer the previous behavior of these tags.
#done - good advice, it is much cleaner b356f0e9d8673b97018c11ba673d578b57344982
Also since these are scattered through multiple files...maybe we should do them in a compat.py or bbb.py and then import from there, to avoid needing the conditionals in multiple places.
Background service management is done by us only; methods relating to it should be private.
Confusion: "Editing" translated to Swedish could be both a verb and a noun. I have used the verb form here, e.g. "editing this post".
now i don't get it ;) what service do you want to remove here?
This is a major problem since Celery is a hell to configure (think to developers).
Btw, have you documented how to setup Celery for askbot in the doc?
Ja tämä on sama kuin:
~~~clojure
(apply f (my-map first sequences))
~~~
I am using tabs
I don't know, I guess we need this flag for windows for some reason, it doesn't make sense though because it force compiles as C++. It should be doing it anyway based on the extension. Maybe because it's a .cc file it doesn't like it on Windows. Leave it in, but can we open another pull request to fix it for everything else that will have this same problem?
need a space between comments and #include
Not sure we need this here.
`(* x -1)` = `(- x)`
Wyrzucisz to "this."?