labofsahil/github-event-dataset-2012 huggingface dataset:
I'm using the version 1.2.71 because the newer version is or was unstable after introducing a support of long long. Since Version 1.2.108, they have recently changed some of matrix storage names. LIS_MATRIX_CRS became LIS_MATRIX_CSR. I have used the macro name for storage type because unique ID was not given in the tutorial, unlike solver type. But I saw now that the latest document provides a list of storage type ID. so probably I can remove macros from LisOption.
Thanks for the pull request.

I'd say we definitely should have tests around this, and this should be part of your pull request.  If you need a hand with that just ask and I'll try help.

So shell parsing and escaping is tricky. For `--install-options="--libjpeg=/home/conrado/library\ builds/"` does `--install-options="--libjpeg=/home/conrado/library\\ builds/"` work? 

Also have you looked at `shlex` in the stdlib as this may help with splitting 

Also we'd definitely want to support this both in requirements.txt and on the command line, so this is probably the wrong place for the support to be added.
I can't resist a good naming discussion. "inprogress"?
I understand what you're asking me to do, but I don't see which pull request you're talking about. #154 (CAS-1210) does not have this change ?!

Am I missing something ?
scala._ is always imported by default, and here scala.Some is imported explicitly, twice
Fatals are not caught and thus do not fail actors.
I didn't think this was user-facing?
I don't like the wrong usage of the name `frequency`. Should we change while we are touching this? It should be `interval`.
I think it just needs to be documented in those traits which modify the defaults, so that everyone deriving from Stash will know that they need to call super. Should be bold italic and really visible.
I'll continue review later
isn't it good practice to change it back to original value when done, or is the Constructor object a throw away instance?
I'll take it out, it's not necessary
This line means I get co-author status, right?
REST routes to Cards at '/'.  Note that the standard mapping of the GET action on an :id is to :show, so the :except and the get are so that we remap that action to card#read which is much more RESTful.  I really think they should fix it in the core, but maybe #show is to entrenched.

This does not break any current tests, so if it breaks things in real life, we need more/better routing tests.
I'm running tests like so: `nosetests --with-doctest --with-coverage --cover-package=nhlib`

`get_dip` appears to be missing test coverage.
Okay, I can try to explain better.  Every point in the DSI_ODF is calculated by sampling radially from "the center" of the PDF. However some times we don't want to start from 0 but from sampl_start.
should we check that the user is the same as the requesting user or else can I read anyone's dashboard via the api?

should we do something like

`if not (c.userobj and (c.userobj.username == user or c.userobj.id == user)):`
The exact same code appears in the Group controller as well (from which this controller originated)

I've created a ticket so that the group.py instance doesn't get lost at http://trac.ckan.org/ticket/2902
Sure, on problem :-)
No comma before is.
Would be nice to keep the same sphinx syntax as above, using ":return:" instead of "@return:"
Is there a reason you took this approach over setdefault?
We will need them when we will have the synchronisation. We don't want to garbage collect while we are sending records to a remote node.
Nice description ;) I tend to not put any description on tests BTW, as they test a class that should already be tested
Wouldn't you be able to only update a specific container if you did a comparison on the type of the item passed in the announcement? So if the type of the item is "movie" only update "videodb://1/2" etc.
strArtist should be the Artist string 'as it was intended'. For example:
'Chet Atkins & Mark Knopfler feat. Emmy Lou Harris'. 
We can't hope to encode all types of split with a std::vector<artist> so otherwise we lose data or can't split artists fully.

std::vector<artist> will go away later and be replaced with an artist credits processor that creates the right entities in the DB.
In that case at least make it into: bool result = directory.substr(0,17).Equals("pvr://recordings/"); return result;
Под каждый проект индивидуально, и имхо - не нужно
You want me to push this change into my pull request? Any other changes?
If these are dollar amounts, lets format them as dollar amounts

something like this:


In [10]: "$%.2f" % 11231232.1773123
Out[10]: '$11231232.18'

In [11]: "$%.2f" % 100
Out[11]: '$100.00'

In [12]: "$%.2f" % .0123
Out[12]: '$0.01'
This was required to handle code where the with block has an if else. I am not sure if there are cases when a if .. else block ends with a POP_BLOCK. I tested with a if .. else and a if .. elif .. else .. code and it worked correctly.
I know … but since `firstElement` and `lastElement` are just helper variables to reduce the template code, I didn't want to write like 20 lines of code to determine their value.
adding 0 has no effect so just check if numOnes != b and only have the else part
Shouldn't this be: 'There are no registered paths for path name "%s"' ?
Correct me if I'm wrong, but isn't it now possible that the the following check is not handled correctly if the `$name` is the instance of the Filter.

```php
if ($this->extensionInitialized) {
    throw new LogicException(sprintf('Unable to add filter "%s" as extensions have already been initialized.', $name));
}
```

This is what I would have proposed as a fix:

```php
public function addFilter($name, $filter = null)
{
    if ($filter === null) {
        $filter = $name;
        $name = $filter->getName();
    }

    if (!($filter instanceof Twig_SimpleFilter || $filter instanceof Twig_FilterInterface)) {
        throw new LogicException('A filter must be an instance of Twig_FilterInterface or Twig_SimpleFilter');
    }

    if ($this->extensionInitialized) {
        throw new LogicException(sprintf('Unable to add filter "%s" as extensions have already been initialized.', $name));
    }

    $this->staging->addFilter($name, $filter);
}
```
Can this be drawn out into a constant? Should this be `TUIScrollerFadeSpeed`?
You have prompted me to wonder why I’m sending nested when messages at all. All the tests pass with a single layer.

Rather than factor out the common rejection, I think I will factor out the nested "when".

Good eye.
lolll wtf
Why a json file instead of the values themselves? It would make debugging easier (meaningful values in report files) and allow to save the values to a database without an intermediate json reader node.
сейчас это сделано, чтоб не линк не превращался в точку. а вообще это надо изменять код delCloseLinPoints, но только тогда, когда будет пофикшен #602. Сейчас просто сделана отмена на этот метод в таком случае. Могу конечно сейчас его подстроить под этот случай. Надо?
is not `connection` accessible in the test context?
In this particular case, isn't `Array.wrap` a defensive thing? What will the difference be over:

```ruby
value.permit(*Array.wrap(filter[key]))
# vs
value.permit(filter[key])
```

Do we expect it to be nil or something else?
```
UNSAFE_STRING_METHODS = %w(
  capitalize chomp chop delete downcase gsub lstrip next reverse rstrip slice
  squeeze strip sub succ swapcase tr tr_s upcase prepend )
```

prefer a shallower indent, too
Darn `%s/JavaScript/CoffeeScript/g;` :wink:
@blakesmith sorry about that, when glancing at the code really quickly I thought you were testing the initializer (which called `warn`), but it has nothing to do with it. Thanks.
Space before the if.
the //todo is actually a bit misleading. we are missing test only for bests.isEmpty.
It should be case _: TypeError =>. Should I do another pull request with this?
No test to verify when it's not completed yet?
>
> space after comma would be another refreshing change,
>> I never did a pep-8 check
>>
> Do you know whether there is software for this, or it is easier to use
> sed?
>
>

I found pep8.py, but this appears to result in a considerable amount of
work if we follow this approach.


>  —
>> Reply to this email directly or view it on GitHub<https://github.com/scipy/scipy/pull/310/files#r1603621>.
>>
>>
>
>
"Die letztere fügt automatisch die Symbole in den Namespace ein, und beide Funktionen akzeptieren eine Reihennotation:"
Maybe I am just biased, however I think that this work is totally
cool. I will try to review it soon.
Using symbols is the best way to go, and we should definitely encourage its use through doctest examples. It does the right thing for multicharacter symbols, works with commas, supports indexing magic, and is much easier to read and understand.
Added S(1) here.
Get rid of double quotes around n and m, here and other locations.  See http://www.unnecessaryquotes.com/ for further examples.
I left this out because Matrix works on iterables. However if you think it is better with a more explicit example I will add it.
Please add a newline between if() and the following statement.
This routine is a bit too problem specific. The nodal assembly should loop over the nodes and call the assemble routines for that node. If for your specific problem you only want to do something at the end nodes then that should be decided in the particular equations set routines.
ditto, `test_right_exception_raised`
This isn't getting generated from anything. We just got this from somewhere else. Our .css files are being generated by us, but not this one. It needs to be restored.
I don't think this is quite fixing the issue. The problem isn't just duplicate tag names, it's duplicate names with a case-insensitive comparison. That is, "Javascript", "javascript", and "JAVASCRIPT" are all duplicates and cause the exception when any one of them is looked up. 

This code looks like it is case-sensitive and will miss the case-insensitive dupes.
No, because it's not looking for templates: It's looking for pages that *use* templates.
It's none for jinja
Ce `div` ne sert qu'à créer un espace. Pourquoi ne pas avoir une marge sur la navbar plutôt? Il suffit d'utiliser `margin-bottom`. Le code serait plus simple et plus clair.
Looks like you removed goutte with this somehow. Can you check why / add it back?
On Windows, you must also uncomment the following line: <url to explanation of why this is needed>
Found it. It wasn't. It was the merge.
The rebase -i I made with itself removed these from the merge I had made.
Fixing it.
@igorw All controllers always return a response object. See the example in the above comment.
Does mysql choke on enabled? If no, take out is_ prefix.
If it is used globally then it is better to create it here than everywhere else.
Should probably be escaped here too.
Yup, I've got an open PR changing them somewhere.
Rather use a variable name that describes the variable rather than some acronym.
is it supposed to be rackspace-monit?
yeah. it's lame... fixed in 10b1dc9
To avoid creating pseudo-scoped variables like `var property` that leaks into the parent-scope I would suggest to use tools.forEach here. `tools.forEach(propertyNames, function(property) { …  })`.
I don't think that we need that check. What about `"", null, [], {}, …`? I see your point but I don't think that we should expect `undefined` and `number` of all types. The cast in L357 takes care of invalid values.
Not a big fan of "no space after //". I thin we should standardize on "real sentences" for comments. So:

// Log a warning if server mojit has a dom dependency.
За день у одного баннера будет одна запись. Нода в течении всего дня будет её апдейтить, на следующий день она автоматически переключиться на новую запись.

Мне не хочется чтобы крон занимался таким пересчетом. Ему придется тогда где-то хранить ещё и сумму показов за все предыдущие дни. Да и в твоем варианте у крона появляется лувая работа. То есть ему кроме проверки показывать ли ещё баннер, нужно будет заниматься формированием статистики.
I added HealUnitsCrateAction specifically for the single player campaign but it also happens to carry over to MP because it's awesome.
```5.5```  should be saved as a named var CONSTANT_NAME. Right now it is a magic # without explanation.
Use an enum from Util on each setActiveItem
Can you please resize Message box index to make sure that all text area fits in the box.
use setSize( width, height )
Yes, you should always use the ```var``` keyword, else the variable is automatically in the global scope. See: http://stackoverflow.com/questions/1470488/difference-between-using-var-and-not-using-var-in-javascript
You need a way to easily set this value in the program (like our gear does in login at demo.raxa.org -- perhaps adding a popup on the toolbar on top) you can see the example of the overlay in src/app/view/Login.js
这里暂时不用断行吧，断行之后的缩进有点问题。
I think a similar fix (=links) should go into .../tensor/signal/conv.txt, while you're at it.
Is it easier just to turn column names into column value expressions and then treat all index columns as expressions? Is that too much work, or slower in the fast path or something?
Returning the not-ready-for-primetime extractedParams doesn't add anything. The Parameterizer could just hold onto them and provide them later via an accessor that accepts the plan.parameters and returns the finalized extractedParams for better encapsulation of the whole valueForStringWithType process.
.format unnecessary
Reuse one IP address query instead of doing two.
Test bulkedit for generic actions
damn, pushed achievement rewards change necessary
Code style:

```js
U.readJsonJs(path)
    .then(function(json) {
        // ...
    });
```
Tritto (uhm, isn't this code duplicated?)
Actually why not create a generic slowloris transport that buffers and randomly delays on bytes to test that sort of thing.

Then just run your test suite over with a different config?
I agree we need specific tests for this, I don't agree that this has to be in the client. For unusual behaviors, raw is what should be used, you already know I'm not a fan of adding dozens of nonsensical options to my code.
Sorry it's taken me so long to followup on this pull request.

I've been trying to restructure this function (move it outside of `Source` class and restructure the code) and I can't wrap my mind around how this works.

I don't understand why `root_` changes when it does nor why `dict_['titles']` is assigned based on `root_` like it is.  Also it seems like this function always returns a single-element list (unless I'm missing something) and I don't understand why.
I must be dumb, but it doesn't seem to work neither.
Is the intention here to generate _geographical_ locations? If so, these ranges are not valid for lon/lat values.
This line is causing travis.ci to fail. I ran a clean build on Windows (mingw) and the tests passed. Could someone on Linux and Mac test this out? (My VM is broken for Linux).
* _today = [_calendar components:unitFlags fromDate:_now].day;
Wouldn't it be more performant to test for hasCallback first, then chain the conditions, rather than having the tests made upfront in the variable declarations?

    if ( hasCallback ) {
        if ( rjsonp.test( url ) ) {
            s.url = url.replace( rjsonp, "$1" + callbackName );
        } else if ( typeof data === "string" && !( s.contentType || "" ).indexOf("application/x-www-form-urlencoded") && rjsonp.test( data ) ) {
            s.data = data.replace( rjsonp, "$1" + callbackName );
        } else {
            s.url += ( rquestion.test( url ) ? "&" : "?" ) + s.jsonp + "=" + callbackName;
        }
    }

I suppose it wouldn't hurt gzip, would it?
I really do not understand why `standard` is preferred. Can I add constant into it using jshint comments in my code?
The problem is issuing ERROR cannot catch the C++'s try block and if the ERROR passed the C++'s try block, the process hangs.  As far as we live within the backend C world, those functions are safe.
After discussion I think I'm okay here.  My understanding was that DEFAULT_COLLATION_OID was going to be a *specific* collation, not the collation defined for the database.  So long as the collation matches the default collation for the database I don't see an issue here so long as we document that this is the behavior.  

Which I guess means that we need to add a doxygen comment to this affect.
Wouldn't one for speaker A and one for speaker B make sense?
We probably want sanity checking that we only write to files in the right folder and not symlinks etc. I.e. get the absolute and de-referenced path and make sure it is in the playlist folder. Being a bit overly paranoid when we let user data dictate where we write stuff feels like the right thing to do :-)
nit: "its", not "it's"  (Also on line 28.)
(Like setting some classes on the tds, and using $(this).sibling("td.whatever"), or something.)
Here, too, I think we should put the language after the description…
`#{bin}/trash`
Yup, the tools are validated against 1.3 which is this sprints release.

On Nov 12, 2012, at 4:24 PM, Brenton Leanhardt <notifications@github.com> wrote:

> In lib/rhc/rest/client.rb:
> 
> > @@ -14,7 +14,7 @@ class Client < Base
> >        # The list may not necessarily be sorted; we will select the last
> >        # matching one supported by the server.
> >        # See #api_version_negotiated
> > -      CLIENT_API_VERSIONS = [1.0, 1.1, 1.2]
> > +      CLIENT_API_VERSIONS = [1.0, 1.1, 1.2, 1.3]
> >        
> Just checking, was this change expected?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Should it also say something like "Use --[no-]git instead"?
My problem with the thing here is that we don't know *when* this script is called, so that downloads *may* fail because the file has already been deleted. Or am I missing something?
Add the "use strict" statement and check that everything works after the change.
# and ! don't have special meaning in regular expressions
Add requirements=dict(act="del|add") to 404 on invalid actions.
You should make `fatal` a keyword arg to `__init__` and pass it through, so it can be overridden
Group this with other stdlib imports
I think you should use ``resize(size)`` instead of ``reserve(size)``, the size of the vector is not actually changed by a reserve. Check the http://www.gotw.ca/gotw/074.htm
`wp-config.php` can also be placed one directory higher than WP_ROOT.
The correct name is 'textdomain', not 'context'. Same for taxonomy subcommand.
Like I said, I did all of the org.junit. I can back out the other changes, but why not have a blanket rule?
Oops, one more issue actually: Cmd+L on Mac is already used for "Go to Line."  Is there a different shortcut we could use there?

We could use Ctrl on Mac too (instead of Cmd), if you think that's reasonable -- just use the syntax `[ {key:"Ctrl-L", platform:"win"}, {key:"Ctrl-L", platform:"mac"} ]`.

The only app I know of for comparison here is Sublime.  They actually use Cmd+G for "Go to Line" on Mac (which I think is nonstandard), so they're able to avoid this problem and use Cmd+L on Mac.  I don't think we want to use that solution, though.
We should document that this is ignored if keyBindings is an array instead of a single object.
Thanks for your suggestion.
Done!

2012$BG/(B10$B7n(B25$BF|(B 11:33 Raymond Lim <notifications@github.com>:

> In src/nls/ja/strings.js:
>
> > +    "ERROR_OPENING_FILE"                : "$B%U%!%$%k$r3+$/:]$K%(%i!<$,H/@8$7$^$7$?!#(B<span class='dialog-filename'>{0}</span>. {1}",
> > +    "ERROR_RELOADING_FILE_TITLE"        : "$B%U%!%$%k$r:FFI9~$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B",
> > +    "ERROR_RELOADING_FILE"              : "$B%U%!%$%k$r:FFI9~$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B<span class='dialog-filename'>{0}</span>. {1}",
> > +    "ERROR_SAVING_FILE_TITLE"           : "$B%U%!%$%k$rJ]B8$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B",
> > +    "ERROR_SAVING_FILE"                 : "$B%U%!%$%k$rJ]B8$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B<span class='dialog-filename'>{0}</span>. {1}",
> > +    "ERROR_RENAMING_FILE_TITLE"         : "$B%U%!%$%k$NL>A0$rJQ99$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B",
> > +    "ERROR_RENAMING_FILE"               : "$B%U%!%$%k$NL>A0$rJQ99$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B<span class='dialog-filename'>{0}</span>. {1}",
> > +    "INVALID_FILENAME_TITLE"            : "$B%U%!%$%kL>$,IT@5$G$9!#(B",
> > +    "INVALID_FILENAME_MESSAGE"          : "$B%U%!%$%kL>$K$O!"<!$NJ8;z$r4^$a$k$3$H$O$G$-$^$;$s(B: /?*:;{}<>\\|",
> > +    "FILE_ALREADY_EXISTS"               : "$B%U%!%$%k(B <span class='dialog-filename'>{0}</span> $B$O4{$KB8:_$7$F$$$^$9!#(B",
> > +    "ERROR_CREATING_FILE_TITLE"         : "$B%U%!%$%k$r:n@.$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B",
> > +    "ERROR_CREATING_FILE"               : "$B%U%!%$%k$r:n@.$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#(B<span class='dialog-filename'>{0}</span>. {1}",
> > +
> > +    // Application error strings
> > +    "ERROR_IN_BROWSER_TITLE"            : "{APP_NAME} $B$O!"$^$@%V%i%&%6>e$G<B9T$5$l$F$$$^$;$s!*(B",
> > +    "ERROR_IN_BROWSER"                  : "{APP_NAME}$B$O(BHTML$B$G9=C[$5$l$F$$$^$9$,!"%G%9%/%H%C%W%"%W%j$H$7$F<B9T$9$k$3$H$G!"%m!<%+%k%U%!%$%k$rJT=8$9$k$3$H$,$G$-$^$9!#(B{APP_NAME}$B$r<B9T$9$k$?$a$K!"(B<b>github.com/adobe/brackets-shell</b> $B%j%]%8%H%j$r;HMQ$7$F$/$@$5$$!#(B",
>
> Can you add a space after {APP_NAME} just like you have in the above line?
> Not only this instance, but you have others with {APP_NAME} or {APP_TITLE}
> without a space. Can you fix all these instances for consistency?
>
> $B!=(B
> Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1929/files#r1936766>.
>
>
Typo: finalaize -> finalize
Looks like this doesn't actually support passing a Command object -- only an id string.  So these docs should change.
If the user edits a file, it becomes dirty, and DirtyDocumentTracker notices and marks it dirty.  Once Quick Edit has been run once, we'll have its function list cached and so DirtyDocumentTracker now considers it clean.  If the user edits the file some more, it's already dirty so DirtyDocumentTracker doesn't get any notification.  If Quick Edit is invoked now, it'll use stale cached data.

I think this is the same bug that Ty's early caching prototype from a few sprints ago had.  It sounds like we either need to only care about saved changes (a la JSLint) or need to listen for individual Document change events.  (Or do some hybrid like seeing unsaved changes within the current file but only seeing saved changes in other files... I think FB followed that rule in many places and it proved to be less confusing than it sounds).

If we wind up listening for individual Document changes, I wonder if it's worth having a generation counter or something like that to simplify the code and improve performance...
I did set tab expansion and did a "retab" with vim.
I'm confused why you're changing the config file to be a requirement. I'm not seeing any good reason to do such a thing. I'd quite like to avoid it if at all possible as well. Basic Bucky configuration for a quick "let me shoot stats at it and have it forward" should be a trivial command line. Things that require more advanced configuration may require the use of a config file though.
Push these guys 2 spaces over plz
It's a good habit to delete any commented code from the repo, unless it's a very temporary change. Anything else can be found in the history easily enough.
I18N missing here
I thought so. :-) So you cannot use this like you are doing. :-)
Instead of this, we can probably just have on `onMouseUp` occur globally now, which calls something like `_draggable.onMouseUp` on each trackevent.
Yeah, inside trackEvent.update, check _isGhost.
I don't think you need to explicitly pass in `false` as an argument, should work fine if you pass in nothing
Move `&&` on previous line
The HTML block needs proper indentation, depending on the nesting level - why is it completely flat?
ok. no problem
Deploying log4j twice is a recipe for confusion later on when versions change.
An enum is always increments automatically by 1, but the code looks better if we use constant values
Could you move this to the notification_post_save function? Notification is not needed anywhere else right now and it will be better in case we need to refactor our already bloated layers/models.py
If you bind to document instead of body, there is no DOM lookup required.
Want to strip all trailing semis?
I wonder if there's an accepted standard way of representing dates in JSON.  Surely ISO 8601 is as close to standard as we're likely to get?  Personally, my server runs on a Java JAX-RS stack and it was not very happy to see RestKit's date format.
phpdoc also allows to omit it: http://www.phpdoc.org/docs/latest/for-users/tags/return.html#description
looking at the description of the function in the NR doc, this is a wrong use. the context associated to the record is not about giving more data about the current web request but about the current record. If you have several logging calls in the same web request, they will simply be mixed together here without any way to understand their respective meaning (and potentially overwriting them if the same key is used in both)
Why not just do it as part of the HubPipeline itself?
Per offline discussion, move pending deletion handling to a better place.
`convnentions` -> `conventions`
Is this a Numpy bug, and if so does it have an issue number?  Might want to add that to the comment and then in the future add a numpy version check and only do this for "old" versions of Numpy.
都改成配置也行。
You can extract the call to session_write_close(); into a protected function and mock that one, no need to mock the destructor.
Completed it and pushed it.
Couldn't this whole if/else be written as `$options['before'] = isset($options['before']) ? $options['before'] . $sign : $sign;` ?
Is there any reason why you change this text?
I think that the technical meaning is false and I'm wondering if it's more understandable to end users.
the endpoint example should not begin with https//api.change.org
Is there a reason that the two branches use different ways of marking the class as active or not?
look at other recent poms in labs.  this should be removed and there should be a corresponding property
extra we know this works...
POS tagger is dummy at this stage!!
This can probably get moved up to the `post "/activites/new" do` block since we won't be calling it from any other method or route.
IT will want to set Django's default email settings in their local.py -- You might want to add those to local.py-dist to make sure they know what to fill in. Also, need to bring that up for the push.
You should just use `if sms_form.errors` here, as unbound forms return an empty dict for the errors attribute.
maybe give this an id and then add a `margin-bottom: 20px;` to make sure there's space between this and the for contributor sidebar.
Should we not default to using bcrypt?
FYI - IIRC we also need to add this file to the list of ignored paths from tools/hashfiles
This should be 'adu-matview' (was confusion on my part)
cause => caused
You should use a variable to compile the node form only once IMO as it can be a bit heavy (you can use any valid expression to access the form, not only a simple variable)
Missing extra line before `return`
the first letter of the variable name should be lowercased
your ``from`` variable is not safe (at least when going through the ``call.file is defined`` branch to define it)
Agreed! I'll rebase it.
Sure it matches more than only the URL, like the HTTP method (POST, GET, ...) and possibly the domain ($pathinfo has only the path, not the full URl).
this should be moved to a ``2.2.0`` section
will change from wid to worker_id
does `dagLevel` encode this notion of runtime equivalency of jobs we discussed Thursday?
I read the spec wrong. This of course managed to work because I haven't dealt with string lengths that don't fit into a unsigned byte. I'll fix it to use the length coded binary.
It will not be then consistent across the application. All table views uses `SVProgressHUD` for error.

Time is long enough for me to read "The Internet connection appears to be offline" using `SVProgressHUD`, so I think it will be enough for "Error getting data from foursquare".


(Also less experienced users always have option to "Cancel" and reopen this dialog, not speaking about that in iOS 6 Mail.app Apple has switched from refresh button to native pull to refresh.)
Can we construct this string beforehand, then reference it? It reads like a long hash, but really has only one element.
已修改，drag增加了dispose方法，会清理drag对象。
use static instance (see above)
should be `htmlContent = htmlContent.replace(/\x1b\[0?m/g, '</span>');`
Please, remove this method
Я обычно для private методов дополнительных отступов не делаю. За другими тоже пока не замечал
I think this is related to the new base theme that ding2tal builds and very much wants to contribute back to core.
Would a user/dev ever want to change these default options passed to  FB.init() , if so maybe passing in an options hash to the Authorizer constructor which then extend this default object may be more useful... Just food for thought
Probably not, just wanted to understand why this wasn't changed.Tthx again!
Does this still run when the selectmenu gets disabled? If it should, pass the supressDisabledCheck flag (see ui.widget, was added recently).

Either way, let's move this handler into a `documentClick` method or something like that. Should remove the need for the comment above.
Please keep these args around (even if commented)
Probably don't need this anymore, right?
It seems you mean `enumerate(book.chapter_lengths, 1)`.
Why did you remove this semicolon?
Only call the callback if there is data.
I've just wanted to fit the markup with the latest design spec on that view:
https://www.dropbox.com/sh/tr2cnlzbupg79yu/XeCHsBd6g_/_Production/Visual%20Design/Apps/Browser#f:Firefox_Settings_120808.jpg

If you prefer i can use a `menu`, i didn't want to have conflicts with other css rules about `menu`

Thx!
Use iccMenuItem directly.
Same comment that screenEnabled. Use a getter that returns an internal value if you don't want the external world to change that.
alright, you need get 12-hours
heh, OK.
What about using the asyncStorage helper provided by shared/js/asyncStorage.js ?
nit, add a space before the `{`
Same reason ;) 
I think that using the click is better for not repeating the code, but if you see any performance reason, I'm all ears
non-blocking review:

this is bad API design. An method return time should return a date object.
(lastChild) I assume its impossible to get a text node here (or thats what your expecting).
all fixed up and updated the documentation here as well.
any special meaning for the 6?
Why dont we use a white list instead of a black list. Only initialize if requestMethod is 'GET' or empty/null
```scala
override def equals(that: Any): Boolean = that match {
   case o: Date => day == o.day && month = o.month && year == o.year
   case _ => false
}
```

I find that way more clear than what's there.
The Metrix is all around us. That's why.
How much would you object to calling this class TypedPipe instead?
I meant, which input works with `quote` but not `String ::Quote`? It is likely that similar input will break through S::Q escaping in other yast modules.
This shouldn't be here, but should be in the build script.
There is no point to this, if you don't return at all, its the same as returning None.
Moved to AppilcationController with 1cb3836
Remember "graceful" is for slaves, while "clean" is for masters -- so you want "clean" here
Pass by ref arguments are  not a great idea in my opinion.  Why not have this function return an array of ($out, $errors)?
you should declare the BaseDumper class abstract and implement the DumperInterface on it to avoid doing it everywhere
in my experience, having to use instance eval in your tests means your missing an object collaborator that could be stubed out or mocked in a cleaner way.  just a thought.
This one is unneeded I think ;)

Also what about

```
expect {
  get :show, :id => @message.id
}.to change(Notification.where(:unread => true), :count).by(-1)
```

as expectation? Might be more reliable ;)
AFAIK the compiler protects the 16 bit operation
Both `uid` and `email` are required, right? If so, this conditional is bad. It will only raise the exception if *both* are nil. If UID is present but not email, no exception gets raised.
Looks like You missed =
judging by the code, I don't think the 'timestamp' here will be valid in RFC3164; logstash uses ISO8601 times, and RFC3164 uses 'month day time' format. Right?
I imagine that first case are all but relative and second is only relative case?
Can you add comments about different cases?
Why don't you make it part of prepareFile()? I don't see a reason to have _firstLog then.
I used redis_client, but changed after seeing what others did
do we use camelCase for variable names?
It would be better to remove tgz references in apiserver.
I was following the standard set by the other selinux facts, but nil makes more sense to me.
Just a few notes: Prefetching have apperently gone wrong in the past causing lost records (like a timeout when querying or something): https://groups.google.com/forum/?fromgroups=#!msg/puppet-users/BaUxo4FMdk4/9aCdhteKkbQJ

On the other hand there are situations where prefetching does not work because the file is not yet present or you want to manage a user's crontab on the same run the user is created.
After sleeping on it I don't feel comfortable with this just swallowing all SettingsErrors. I'm going to change it to pass in an option for that.
The semantics of that code, in base, and in `Puppet::Util.execute`, were crazy.  It turns out that the POSIX side did the "right thing" with the string, but Windows got it about as wrong as possible - it turned the entire string into one double-quoted thing.  (...or, conversely, my input was pathological, but POSIX wrongly accepted that.)

I agree, though, that using an array is the right thing™ here, which is why the change.  I spend ages digging into that code to try and figure it out and concluded that was the right-est version, and probably the POSIX behaviour is vaguely buggy - but is exposed to users, so I didn't want to fiddle with it.
perhaps specify here that this is unoptimized, and runs in a single thread for now.
タイプミスあり。修正して下さい。
That's fine.  I just didn't want to assume too much given there's a dedicated Interface.

On Dec 19, 2012, at 6:02 PM, Michaël Gallego <notifications@github.com> wrote:

> In library/Zend/InputFilter/Input.php:
> 
> > @@ -18,7 +20,7 @@
> >   * @category   Zend
> >   * @package    Zend_InputFilter
> >   */
> > -class Input implements InputInterface
> > +class Input implements InputInterface, ConfigurableInputInterface
> So you won't need to define the getOptions. I agree this may not be the best way but this is how it works in Form elements, basically the base setOptions copy the array to $options property.
> 
> In your classes that extend Input, you only need to define setOptions.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Additional feature enhancement to translate the label. Similar to FormSubmit PR #2124.
Same notes as above.
I mean, should we end up with this script changing files in here with user-specific changes? The problem I see is that then, when someone who's working on it runs the script, then this file is marked as modified and might be pushed. Would a non-in-place sed work well too?
this should be updated as the path changed
Message mit Status 304? Hattet Ihr da was besprochen das ich verpasst habe?
I'de rather you use `\u00A7` instead of `§`
Just make it:

TodoWidget(this.todoApp, this.todo);
Hmm, I'm a bit torn on both of those requests.  Do you think we want to continue to track the symas data if/when they publish more?  The reason I'm torn is that these two files are exactly what I pulled from the link on their page.  If they make slight changes to their underlying benchmark I'd rather just pull their new links as-is rather than having to figure it out and merge into db/db_bench.cc or remember, every time, to add the comment at the top.  Can I add a message to the git commit log for that file instead somehow?  Would that be sufficient?
@cmeiklejohn Sure, but he's still right. You're not doing anything special with the `undefined` clause. Why not simplify this case clause to:

```erlang
BodyToken /= undefined andalso BodyToken == CookieToken.
```
For safety, this should `@maid.stub(:cmd)`
We should stick to using === rather than == in the function below.
Can't we use "===" here?
`$this->_rightExpr = $rightExpr === false ? 0 : $rightExpr;`
Use `kernel.root_dir`:

```
%kernel.root_dir%/../vendor/ezsystems/ezpublish/eZ/Publish/Core/Persistence/Legacy/Tests/Content/SearchHandler/_fixtures/transformations/ascii.tr.result
```
what's the difference between them?
Keyword argument "errors" breaks compatibility with Python 2.6
Actually (digressing a bit), wouldn't the interpreter have to actually check .length on every iteration since there's always a chance that the array was mutated while being iterated. If it's cached, it definitely doesn't have to keep checking. In Chrome for, there's about a 1M ops/s difference, but really, this is bikeshedding. It's a ~10% difference on something that is called once on an array of a few items. :)
>>> p = ['AMD', 'include', 'amd.h']
>>> import os
>>> os.path.join('installdir', p)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/posixpath.py", line 66, in join
    if b.startswith('/'):
AttributeError: 'list' object has no attribute 'startswith'


I can use os.path.join though, instead of hardcoding the '/'
Koncha doesn't have an application.css, so there's a 404 in the console when running its own specs. Can you set `stylesheets` to an empty array in the spec_helper?
Some day it'd be nice to unify the switch statement/logic from here and in `http_parser_parse_url()`, both of which do basically the same thing.
Semantics have changed here. arg is passed in, where it is used as a *minimum*, not as the actual value (in createFileHandle, we optionally add nulls to keep it dense, then return the length, which could differ from arg if it is smaller).

(Or is this ok to change per the C spec?)
I think proposition 3 is the best one. I agree with the `$stream` vs. `$resource` thing, using `$resource` makes it more clear.
Not wrapped around a route handler like this, no. The `connect` package has a caching middleware, but only as [an addon to static file serving](https://github.com/lmorchard/kumascript/blob/master/node_modules/express/node_modules/connect/lib/middleware/staticCache.js).
Backbone is supposed to handle this case on its own; if it doesn't, that's a bit worrying.
So? I don't see a commit for 1367.
No, this is not deadcode, this is a second run through the same check that's used for binding event hooks (eg. canplayall, which must bind to canplaythrough)
This bug took me all day to find `-_-`
If you supply a url here, Zotero will perform another HTTP request to fetch the page for snapshot. You already have the entire document loaded in the doc variable. You can supply it here as `document: doc`. See Attachment section here: http://www.zotero.org/support/dev/translators/coding#saving_single_items
It could be stored in g_langInfo instead of the value read from langinfo.xml (if we want to drop those) so that it can be retrieved using g_langInfo.GetDVDAudioLanguage() (or rename it to GetAudioLanguage).
Just a thought for you Paul:

new Xacml() will throw a XacmlException if it can't read the policy. Since we may come across policies that can't be read by us, maybe we should fall back to the old system, or we could fall back to printing a message (or logging) and denying access, that would force people to use the new policies.
Just instead of `IsGood`, because if it's not good, there's an error. Private backpacks are fine though.
Newline before curly brace please. :)
Use function pathinfo to get file info (path, filename, extension, etc.)
2 less lines of code? I've simply used it as a short hand of an html element that I need one for each of something. Turns out it also adds the `id` of the active record object in the elements `id` and `class` ( http://api.rubyonrails.org/classes/ActionView/Helpers/RecordTagHelper.html#method-i-content_tag_for ). I don't know that we benefit from that here :smile:
blank line contains whispace
Also, it should mention what each of the fields actually means, semantically.
This was actually copied from scripts/nightly-test/full_test_driver.py:301.  I believe what it's doing is setting the environment for the python script at that location, which will only include built-in functions and generate_test.  I believe Tim wrote this line, originally.
We will do necessary changes.
Yes, you are correct.
I'll change this. The UI will need to specifiy:
 * a group alias (unique within the tenant, no colons (`:`) permitted.)
 * a group title (no constraints)
 * a group description
 * ...

That alias will then be prefixed with `g:tenantId:` to determine the group ID.
It still doesn't feel like we need it in the me feed. When we're at /admin, we post to /api/tenant, when we're at /admin/tenantId, we post to /api/tenant/tenantId.
There are a couple of places in this patch where we should probably stick the _.keys(..) results in a variable so we can re-use it.
If we still need this, this would probably be better:

if (_.keys(modules[m]).length === 0) {
  delete modules[m];
}
Ah, here is the parse error! Mystery solved.
This is not being updated because it is not necessary. If someone report any bug it will be updated.

Mergulhão's fork is pretty awesome but changes completely the mindset and should be analysed. Maybe it could be merged or linked here as alternative but not saying that it isn't active anymore.
That was what I was thinking I'd want, but I wasn't 100% sure that did what I wanted, so I opted for explicitness. I'll try that out.
Ook confirmed
rename naar `initSpawner`?
Okay, line separation works for me. But I'm not sure I could add any useful comments - those expressions look pretty much self-explanatory.

P.S.: I assume the same goes for MSSQL, SQLSRV and ODBC (other pending pull requests that do the same).
x - это значение процентов. То что длина ДНК равна 100 это случайное совпадение. Программа должна быть написана таким образом, чтобы могла вычислять проценты от ДНК любой длинны.
Данный метод работает, но при большой ДНК и высоком проценте мутации, количество "пустых" проходов будет огромно. Iphone не потянет ;-)

ПС: В целом мне очень понравился Ваш код, получил удовольствие от его просмотра. Ничего лишнего, все по делу...
Здесь тоже лучше бы поменять id на NSString.
Будет, почему же. Просто будет работать не так, как задумано. Более того, нужно по-любому изменить значение, а в текущей реализации A может поменяться на A, что неверно.
Defaults to 'true'. Set to 'false' to only cache, but not execute the file.
Style: `NSProcessInfo.processInfo.globallyUniqueString` (maybe excepting the last bit)
What about something like `rac_bindSelector:toObjects:`, `rac_subscribeSelector:`, etc.? I don't like how this seems like a simple extension to `-[NSObject performSelector:withObject:]`.
This can use `-[NSArray makeObjectsPerformSelector:]`.
Any reason why `mImageid` is a `String` and not an `int` or maybe an `Integer` if you need `null` values?
Definitely. Let me add them in comments. 

In general, here is how the algorithm works.

1) calculates the partition Ids (S) for the input set of partitioned ids.
2) take the first element from the partition ids, get the nodes serving this partition, and intersect set S with each node, and find the largest match. When both capability and canServiceRequest eval to true, the node with the largest match will be put into result set. S = S - ( last intersection result)
3) Repeat 2) until S is reduced to empty.
4) The counter is for load balancing across all nodes serving the same partition. It instructs where the greedy intersection check to start, thus favoring nodes closer to where the counter points to when there is a tie.
spell out FISTA and give a reference if possible (non-optimization people will not know what FISTA is)
I do not approve this  change... this could have all sorts of effects on other code, if saving a patient clears the session.

We need to find some other way of addressing this problem.
@djazayeri is package visibility good enough? I must call it from ModuleUtil.
It would make more sense to provide the real arguments for the addCallFake closure so we don't have to muck around with "arguments" in the body of the function.
I'm not a fan of commenting the closing braces. It makes the code look denser and harder to read. Any decent editor will show how the braces match up.
Hah... yeah. I stole this code from dm, but then took away two cases I think. doesn't really make sense anymore... will change
Add the word `method` after ``prepend()``:

Inside the ``prepend()`` method, developers ...
变换文本 -> 替换内容
Why the extra whitespace? Remove it.
please look at #line 139-143

attach)
        # Make sure a node IS running
        RES=`$NODETOOL ping`
        ES=$?
        if [ "$ES" -ne 0 ]; then
...
someone had already use return value($?) instead of text output when pinging before attach.
It's bettter to be the same.
if [ "$ES" -eq 0 ]; then ...
I've made a mistake when use -ne, not -eq.
Wouldn't it be better to leave out this license statement, then it's automatically covered by the SciPy license.
Да, геттер убрать.
Можно не указывать `IBloggingPlatform::` же.
Dejame probar. Si funciona prefiero usar CSS solo, sin duda.
si es lo mismo. Lo saco. Gracias
¿La configuración de la app (Windows Authentication) no se encarga automáticamente de esto?
If I remove it, GCC uses ebx  as `%1` in some cases. With this code that isn't a problem, because `xchg %%ebx, %%ebx` simply does nothing (and I assume that GCC knows it shouldn't put `%1` in `ebx` when compiling with `-fPIC`). I do remember having bugs because GCC used ebx as input or output register, though (and that's why I put it in the clobber list) - I must have modified the code since.   I guess things like that are the reason to have a separate non-PIC code path.

Anyway, ebx doesn't need to be in the clobber list here, so I'm removing it . Maybe it would be better to have a separate code path for non-PIC after all? Should I add it?
will create duplicates.
No, but it can't hurt can it?
Oh crap, how'd that get there? Whatever, I'll get that back.
you shouldn't cast ` $request->request->get('ssel')` as it will return 0 instead of `null`
The .ogm line certainly could be killed.  As I had mentioned above, an argument can be made for keeping it to support legacy formats, but in the strictest since of the spec, it is not supported.
We still raise on time out, so thats something.
We need to figure out why this is coming back as a list, it shouldnt be.
Ah yeah, sorry had forgotten about it.
This isn't quite true - we do allow transactions to proceed while we're applying state.
stop() call should be in a finally statement. In fact, even better if you call;

    TestingUtil.withCacheManager(TestCacheManagerFactory.fromStream(is));

That will make sure that stop is called in a finally statement and we avoid leaking cache managers if there's any errors.