labofsahil/github-event-dataset-2012 huggingface dataset:
My first pass at refactoring this (which includes removing the logic that is in the controller) would be something like


```ruby

class NotificationMailer < ActionMailer::Base
  def mail_notification(notification)
    @notification       = notification
    notifier            = notification.user
    cohabitants         = notification.cohabitants
    departments         = @notification.cohabitants.map { |cohabitant| cohabitant.department }
    @departments_string = SnellMail::NotificationConfirmer.new(departments).departments_string

    notify_cohabitants cohabitants, notifier
    notify_admins admins_wanting_update, notifier
    notify_notifier notifier if notifier.want_update?
  end

  def notify_cohabitants(cohabitants, notifier)
    emails  = cohabitants.map { |cohabitant| cohabitant.contact_email }
    subject = "You've got mail downstairs!"

    mail(to: cohabitants, from: notifier.email, subject: subject)
  end

  def notify_admins(admins_wanting_update, notifier)
    emails  = admins_wanting_update.map { |user| user.email }
    subject = "#{notifier.user_name} has notified cohabitants"

    mail(to: admins_wanting_update_emails, from: notifier.email, subject: subject)
  end

  def notify_notifier(notifier)
    @notifier = true
    subject   = "You just notified cohabitants"

    mail(to: notifier.email, from: notifier.email, subject: subject)
  end

  def update_admins(notification, options={})
    want_update_addrs = set_to

    departments = @notification.cohabitants.map { |cohabitant| cohabitant.department }
    @departments_string = SnellMail::NotificationConfirmer.new(departments).departments_string

    send_update(want_update_addrs, options)
  end
end
```
Save experimentVariationSids as an instance variable. Removes the need for synchronization.
It's a tab, not an additional space. Do we tab or space separate for class properties?
Those filetypes don't even exist in the repo, theres only .yml and .java
Сам перечитал требования к проекту. Там не сказано что-бы заменять ячейки на другие, так что думаю засчитать проект.
Эта строка у вас встречается в двух местах. Может логично вынести ее в метод.
Honestly not really, never looked into Spoutcraft code before this.
Weird. When I first looked at the diffs, this line said '[savePanel setCanCreateDirectories: canChooseDirectories];`. Yes, this is fine. Please ignore my comment.
Hmm? Is triple equals a C++ operator?
This needs some thorough testing
I think you should use an `object` here.  It will make the code below
that details with these values less error prone.

``` javascript
    infomaniac._listeners.push(
        {target: target, event: event, callback: callback});
```
also no actual test here. please make it verify something :)
lowercase the "o" in or
Why this comment here?
"middle ware" vs "middleware"
I think this isn't necessary. I removed it and the tests still pass.
Do this in `after` and use `name` as per above.
`get` will return None if it's not there
Correct, this should be changed. The test failed because a field was added.
fixed.  not sending back options any more.  either you get the connection or you get a timeout when you try to get it.
aha, `yield connection`, right-o, I see it now, thanks!

(It would be a quite fine design if it did what I originally thought it did though, I think! But good enough how it is, thanks).
Есть же Qt::BackgroundRole и Qt::ForegroundRole.
Да я не помню. Но кажется оно не работало по констрефу.
These specific trace statements make a lot of noise.  My thought was you only want to see the result from the changes when you filter by rsc id.  If you want to see everything, you can add this function the the PCMK_trace_functions  list.

I ran a few scenarios and tried to see which log statements were helpful and which were just noisy after I finished the initial patch.  I went back through and made a few tweaks here and there based on what I saw.  This was one of those tweaks.
En la rama sobre la que estoy trabajando ahora (`index-attachments`) se empieza a utilizar, representa un hash de la configuración de los Extractores de contenido, de manera que si cambia (ya sea porque agregamos uno o porque cambia la versión) sabemos que attachments deben ser reindexados.
Nice use of regex! :)
Sorry what do I miss ? You can easy log into a mysql table or whatever you want using a specific handler and SearchEngineLogger class does exactly that ?
Graph Title Support Added
I've created a JIRA[1] to track this. For now though, this approach is better as I (and other people using the same system as I do) can run the test suite in reasonable time till this is fixed.

[1] https://issues.jboss.org/browse/ISPN-2399
Shouldn't this delete be in a finally of the remove and close? That way we guarantee that under abnormal situations, files are closed and then deleted.
I guess the point in sleeping here is in order to wait for the task.executeAsynchronously to execute.
This is not going to behave nice in an multithreaded test env such as ours, may I suggest a different approach:
- make LatchMapper.interrupted an AtomicBoolean in LatchMapper.
add a condition:
eventually(new Condition() {
  boolean isSatisfied() {
   return latchMapper.interrupted.get(); 
 }
}
Will this work if one less file imports another which imports another?
we should eventually create subnodes for search providers and put provider specific config into them to make things more explicit. restrict_to_site is also coming from the google configuration.
I'm sorry.  I'm pushing a change to undo this.
Here this list was broken after the `|` binary operator. On line 70 it was broken before.
The other methods, as far as I can tell, are named `print_[filetype]`. Since 'surface' is not a filetype, perhaps this function should be called something else? Perhaps this is really nit-picky, though. I have also just realised it doesn't actually __save__ a file, it merely renders it to a canvas. The other `print_[filetype]` methods write a physical file to disk. Perhaps `render_to_canvas` would be more appropriate?

Maybe some of the other devs could chime in here.
OK I'll fix. I was reasoning that `=false` means not compatible.
I have tried to do setup and teardown in py.test as we have a similar problem in flightdeck-tests. It's the one thing I really miss from junit/testng.

I managed to get a setup/teardown but couldn't get the mozwebqa/selenium session into it.

At the moment we just have to deal with it I think
>То есть в процессе работы мы можем менять параметры подключения - хост, порт, таймаут?

Не, не. Смысл в том, что подключение производится только при необходимости.

>мы еще раз устанавливаем таймаут?

Это ошибка. На самом деле там два вида таймаута - таймаут на подключение и таймаут на запрос. Можно задать оба.
should we create an array with the event names, so we don't have to duplicate them?
It seems awfully restrictive and a bit un-Ruby like to restrict parameters based on type, especially since the type you're expecting is a simple struct. E.g. what if I have another class (or AR model) with the same fields that I wanted to pass in? It might be better to just duck-type it.
Definitely trouble! It's just so strange that the original pull request was somehow reverted. This was fixed at one time. In any case, this is our strongest candidate for finding the cause of the error we saw last week. I expect to have an answer this afternoon.



On Tue, Jun 19, 2012, at 01:53 PM, Sam Ritchie wrote:
> >    (let [countries (map read-string countries)]
> > -    (rain-chunker "1000"
> 
> Looks like trouble!
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/53/files#r1013399
Shouldn't the above 2 lines be the prefixed versions of `box-shadow`?

Now we have these properties twice.
It doesn't because the response is not an array, it's a JSON object.
Let's make this an if statement since it's a bit too long to be readable.
@bp323 it doesn't seem like we're still using this anywhere, can we remove it?
If CKernel has a clone() method, I can do this. Because I have to create multiple Kernel instances. 

Yes, the built-in KernelFactory can only use default parameters. If the users want to customize parameters, he has to write a subclass of the KernelFactory himself. This is not an elegant solution, but I think this is currently the most straightforward solution. I have written an email to the list to explain my struggling for this. Hope I clarified the problem clearly. And I'd be very glad to see anyone come up with a better solution for the whole thing.
This should be `extraStatics`, not `extraStatistics`.
Ah okay, that's what I figured but I wanted to make sure. Maybe a comment in the code would be good so someone doesn't revert this?
param missing for $status
"stale buns which were not wiped yet" lol nice.
Missing parenthesis. Not required in Lua, but for consistency, I think we should have them.
Remove whitespaces before and behind the function brackets.
Do we exclude the cache and the packages directory using "repository.GetLocalOnlyAggregateRepository"?  Probably doesn't matter overly, but worst case you will need to scan up to 100 packages on disk for the cache, and up to N on the packages directory.
Drat, this should probably only show up when there actually are solutions in the back of the book. In physics there aren't any so there would be an extra empty "Solutions" page and entry in the TOC
Are you sure ``$this->context`` has the correct type as "object<PHPUnit_Framework_MockObject_MockObject>" is not a sub-type of "object<Symfony\Component\Validator\ExecutionContext>"?
Please always use braces to surround the code block of FOREACH statements.
Are you sure the method ``unlock`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)?
I changed this as an empty attribute would fail this test
without this included gcc somehow manages to compile but when running with 'FLASH_FULLSCREEN_DISPLAY' set to anything a segfault happens
That's exactly the reason why I use the .dist suffix. You distribute that
file, then if devastating want to have any custom settings, they copy it to
phpunit.xml.
On Nov 10, 2012 6:50 PM, "George Petsagourakis" <notifications@github.com>
wrote:

> In phpunit.xml.dist:
>
> > @@ -1,26 +0,0 @@
> > -<?xml version="1.0" encoding="UTF-8"?>
>
> Just a rename happened on this to phpunit.xml (bypassing git for renaming
> is bad, and I feel bad) nothing new has happened. Do you have a specific
> setup that requires the .dist ? PHPUnit first looks for phpunit.xml and
> then for phpunit.xml.dist thats why I changed it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/davedevelopment/phpmig/pull/23/files#r2091524>.
>
>
Throw in this test

```js
var clone = model.clone();
equal(col2.get(clone), model);
```

This will fail without the alteration mentioned above.
Remove unused line?
Can probably collapse these two cases?
We don't want to change the default behavior for people using django-flag that may update their copy, so by default, NEEDS_TRUST should be False
Does -W take an argument in chef-solo? Looks like it doesn't on line 40 of our options.
Ah, estou a ver. Então como é que os testes passavam antes?
Seems this is identical to `skip?`, we can reuse the method.
It is necessary since i get this on a type that is constructed ttw:
>>> IPrimaryFieldInfo(obj, None)
*** TypeError: ('Could not adapt', <Item at /Plone/copy_of_elefant.jpg>, <InterfaceClass plone.rfc822.interfaces.IPrimaryFieldInfo>)
For every template, there is one or more "versions". The first version is always the raw, "unrendered" version, with no data flow analysis. The rest are copies of this version, but with data flow and variables from either a controller or another template.

So, in this case, there will always be a warning for

```erb
<%= params[:whatever] %>
```

because Brakeman will see that in the "unrendered" form and warn on it, even if the template is never used.

I think this is desired behavior?

Possible scenarios:

* Template is never used - okay, but it is a risk in the future. I want to warn in this case
* Template is used, but only when `params[:whatever]` has been replaced with an escaped value
* Template is used both safely and dangerously

The current behavior will warn for all of these scenarios and gives me some peace of mind in case of Brakeman bugs that might hide the third scenario.

Note, however, that this patch WILL change the warnings produced, because it will not warn on the rendered version.

If this doesn't make sense, I blame it on being sick.
`notifications` -> `notification`.
Yes, but connections which are recorded in Connection document could be from different channels and there is very small but existent chance that you would unsubscribe too much (also Connection documents from other channel).
I meant in general. :-)
How do I query with id? models.BicikeljStation.objects(id=station['id'],..)  keeps returning ValidationError?
Yes, then bundle is not reasonable to have here, if it is not notification bundle. Remove it.
Caller should convert to string when necessary. ID object should provide a way to convert it to string.
ID should be probably changed to CSS class.
But, this is because [Mozilla Parser API AST spec](https://developer.mozilla.org/en-US/docs/SpiderMonkey/Parser_API#Functions)...
I think we should only display "edit" on announcements created by the user that is logged in
What I was trying to achieve is: If I don't have weakness: reapply. Gonna make it a bit more explicit in next commit :)
really? damn
True fact :( on phone, so can't do until tomorrow. Sorry
these are the properties I meant in the previous comments
@rmurphey do you mean to remove the entire jQuery IIFE example, or just reword the line that starts "Secondly..." to mention IIFEs, then show the jQuery example, and then move onto the next example (which starts on line 59) ?
Suggestion: ordered from newest to oldest.
Подписку на сигнал лучше сделать сдесь же, в finally — восстановление прежнего обработчика
stub? if not, you don't need to specify ```.exactly(1)```; that's implied with ```.should_receive```
`_requestID` -> `_request_id`?
use the enum variable to define the command?
It's worth noting though that previously, plone.namedfile wasn't a hard dependency of p.a.i. So we'd be introducing it just to be able to specify its version. I don't think that's bad, just saying.
mainly a general aversion to using magic methods if we don't have to. ``del data._tmp_dict`` looks better then the pops
编译PCRE库时增加“实时编译（jit）”支持
pushed a typo fix for `funtion`
this line seems messed up, the comment should probably end with "aberration" rather than a #?
I think we could see this exception get raised at the top of the method, rather than do all the processing then give up since the normalization kwarg is not as expected.  I've made some changes on a local branch that implement this for `draw` and `drawShoot` (with a slightly beefed up ValueError message saying what string values are expected), OK if I push?
Pushed a small fix for this, please edit/revert as desired.
Ah right, I'm sure greg cleaned this up.
这个可以用path.extname()来判断扩展名。不然.json文件也会被扫描到的。
tested, it does, in the super of course
Best to call stop even if !serviceUp, in case the process is running but just hadn't started up its mbeans properly or whatever.
You can do: `if (app != null) Entities.destroy(app);`
0. I omit curly braces on single-line object literals that are alone (not in argument lists, or members of arrays), and have a single key. So I would omit them here.

0. It should be read as `(x.y)()`. I see why you may feel that the context of that method should be the global object, but we're just emulating the behaviour of that line of JavaScript. It's just how things are.
I think you should use auto here (and in all other instances) since we don't really care about the type in this case.
It's being used on line 65 `$this->last(explode('/', ...` because `end(explode('/'` was giving an "only variables should be passed by reference" error because end() uses a reference, and the result from the explode call can't be used directly. 

I could just set a variable as the result of the explode in the get_user_info function if that would be preferable.
Double import of SafeOperation?
I suppose the better option would be a mouse-over and mouse-out event to the elements we are interested in and keep track of things using jQuery's data() method?
manter o ```rs.getBoolean("MAPA");```
Also, without it you cannot run Guard in a `bundle exec`.
will do...
travis now has composer installed. you could also just do ``composer install`` instead of the lines above and below.
.ui file :)
Should this remove friend requests as well? 
Also, you are using a binary & rather than a &&
var classes = document.body.classList; and use that
It is licensed under the same license as Android. So it should be compatible. Do we need license closures here?
fallo mio, iba a meter algo ahí pero ya no recuerdo el que, como es normal si está vacío, no vale para nada, lo borro :)
Is this constructor used anywhere?  It seems like a bad idea and this change would need ot make sure the calling method represents the data differently...
I did intend to include them, simply for maximum humor and "HTML-1.0-look-and-feel-ness" but if you think it's clutter then I'll remove.
А в задании было же указано работать с toString().
Косяк.
Но [0] не пуст при этом будет
Check `testDeleteBlobSnapshot` at [`BlobRestProxyTest.php`](https://github.com/WindowsAzure/azure-sdk-for-php/blob/master/tests/unit/WindowsAzure/Blob/BlobRestProxyTest.php)
Corrected on 53712624d81015 commit
This needs  to say why we are adding these definitions.
This should state that it is library mode. No instructions for client-server mode?
I know this is a dupe check.
I can't see what you are sugesting here but if you have e example maybe we can put something together :D
This and the other similar code lines will make sure that the images in bottom bar change according to theme. My app has been rejected by Marketplace for not sticking to their clause "5.5.2" (http://msdn.microsoft.com/en-us/library/hh184840(v=vs.92).aspx). It should also be noted that ChildBrowser doesn't follow  requirement 5.2.4 (usage of Back Button) also.
`histogram_increment` and `histogram_decrement` added
will give it a try.
Which classifiers have ``n_outputs_``? I didn't know we had something that needs multiple ``classes``.
`decision_function` should not change the state of the object.
``%mprun`` and ``%memit`` magics.
Le 02/11/2012 10:36, serge-sans-paille a écrit :
>
> In scripts/pythran:
>
> > @@ -30,7 +30,8 @@ parser.add_argument('-m', dest='extra_mflags', metavar='machine', action='append
> >  parser.add_argument('-I', dest='extra_Iflags', metavar='include_dir', action='append', help='any include dir relevant to the underlying C++ compiler', default=list())
> >  parser.add_argument('-D', dest='extra_Dflags', metavar='macro_definition', action='append', help='any macro definition relevant to the underlying C++ compiler', default=list())
> >  parser.add_argument('-O', dest='extra_Oflags', metavar='level', action='append', help='any optimization level relevant to the underlying C++ compiler', default=list())
> > -parser.add_argument('-g', dest='debug_flag', action='store_true', help='any debug level relevant to the underlying C++ compiler', default=list())
> > +parser.add_argument('-g', dest='debug_flag', action='store_true', help='any debug level relevant to the underlying C++ compiler')
> > +parser.add_argument('--no-gpl', dest='no_gpl', action='store_true', help='Keep the same license before and after pythran')
>
> --gpl plutôt qu'une double négation ?, à propager un peu partout...
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/serge-sans-paille/pythran/pull/21/files#r2014365>.
>
Updated :-)
sumcn should never be zero, because there is always an element with value
zero, and when exponenitiated will be 1.

On Wed, Dec 19, 2012 at 9:52 PM, Jonathan Chang <notifications@github.com>wrote:

> In src/gibbs.c:
>
> > -	      } else if (method == prodLDA) {
> > -		double x_d = REAL(annotations)[dd];
> > -		int n_k = INTEGER(topic_sums)[kk + K * topic_index] + 1 + lambda;
> > -		p[kk] *= sqrt(n_k) *
> > -		  exp(-(wx2[kk] - wx2[0] - (wx[kk] + x_d)*(wx[kk] + x_d)/n_k + (wx[0] + x_d) * (wx[0] + x_d) / n_k) / (2 * var));
> > +				p[kk] *= dv_update(annotations, dd, REAL(beta)[kk],var, nw, method, logistic) - dv[dd];
> > +		  } else if (method == sLDA) {
> > +				double change=0;
> > +				if (logistic) {
> > +					int cn;
> > +					sumcn=1.0;
> > +					for (cn=0; cn<classN; cn++){
> > +						change=REAL(beta)[kk + cn*K]/nws;
> > +						sumcn += exp(change - dv[dd+cn*nd]);
> > +					}
> > +					if (!R_finite(sumcn)){
>
> The other bad thing that can happen is when sumcn = 0 because all the
> values are really small and you might wanna go down the same block.
>
> It might be worth simplifying things and always doing the check.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/slycoder/R-lda-deprecated/pull/1/files#r2473599>.
>
>
Please add a use statement for the class
If ``apid_data['active']`` can only be ``True`` or ``False`` feel free to be lazy and shorten this to:

```python
if apid_data['active']:
    ...
```
please wrap if statement in curly braces to adhere to styling guidelines
I'll fix this when I push, but for future reference this should be:

remote.connection.default.host=${node0:localhost}
Moved into blackberry.py.
Changed properties to 'not specified'
Retourne la liste des databox disponibles
Validate :email, email: true
Pode deixar. Quando integrar arrumamos... A contribuição já foi válida. Valeu!
better to use "unless" instead of "if not"
Absolutely, oops! Good catch. Perhaps easiest fix is to move this block before the initialization of the matches* variables.
A bit dubious - assumes the payload is the first attribute.  Would have problems if it was also ,PACKED.
Not sure, if there isn't a workunit method already to retreive a process's groupname or group, there should be.
>I'm not convinced by the logic of this function.

No nor was I, at best it was a poor guess.
So yes, maybe just default to prime # to start with regardless of how many input records..


>Also, the number of buckets shouldn't be a factor of the number of nodes in the system, otherwise a local hash dedup which spills, followed by a global hash dedup would end up being serial since all rows from a single bucket would only go to a subset of the target nodes.

Hm, yes, I thought I had already changed the first 'div' to handle this (via calcBucket), i.e. to pass in # nodes.
The PROJECT_DEFAULT_RECIPIENTS constant was discarded in the last check-in on 2/23/12. The commit message was "More default recipient fixes". In that check-in, the use of the recipientList local variable was also removed.
We can tidy this up with a format statement with named fields.
Please reconsider the tone of your request.
Please consider moving this definition to a common file, see also

0 dc3840.c         153 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
1 i2c_slave.c       40 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
2 rfm12_raw_net.c   31 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
3 ecmd_net.c        36 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
4 uecmd_net.c       32 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
5 mdns_sd.c         35 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
6 snmp.c            37 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
7 udpio_net.c       43 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
8 udpcurtain_net.c  30 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
9 udpstella_net.c   30 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
a zbus_raw_net.c    31 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
b udp_echo_net.c    28 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
c ntpd_net.c        33 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
d tftp-vfs.c        37 #define BUF ((struct uip_udpip_hdr *) (uip_appdata - UIP_IPUDPH_LEN))
Import all the various Dom* classes used, so they don't need to be qualified.
@ozten - great point, I hadn't thought of that.  Will update.
Don't you really think that saving a small structure is faster and cheaper than reading the whole file twice? Besides, this would allow us to swap discrete/integrated cards if they were listed in the wrong order by the kernel.
Shouldn't "none" be "None" ? I thought this was case sensitive.

Also, please clarify the human readable error message: "There is nothing to do on module" is really not an acceptable sentence to explain to users what is going on here. Something like "No Apache modules configured to be enabled, no changes made." would be better.
Nämähän on tietty joustavuuden kannalta hyvä olla näin, mutta vähän huolestuttaa ylimääräiset funktiokutsut.
accidental comment-out?
IDEA is complaining about unchecked conversion here. Can you use instanceof to make sure it's a List<EnumMap<LDAPFields, String>>?
Let's talk about this file in the office. If we have to start playing games like this, it doesn't feel like we gain anything from rails_config.
`(not (empty? (living-authors (:authors book))))` would be a cleaner choice.
Can't get to this if ```__enter__()``` doesn't give me the object.
You could consider using ```socket.create_connection()```
remove, then?
*credentials
Use the Rex one, please
That does make sense - but if you change this, you should also change `default_error_message` in `lib/shoulda/matchers/active_model/helpers.rb`.
For this one, I guess

    urlpatterns = patterns(
        '', 
        *urls
    )

would work for you?
Ah, I misunderstood.  There are a lot of nearby variables with names that sound similar to `distance`, so I wanted to make it clear that this wasn't a reference to any of those.
`EPSILON4` is a big epsilon.  You have a reason for it I assume.
Only the constructor needs the @private tag. I just tried it out to be sure.
As I mentioned above, all of these pseudo-private prototype functions should just be actually private local functions that take the Material instance as their first parameter.
Updates have to be one-to-one with the dynamicObjectCollection, you're right on this. The first iteration, I had a property member called updater in the DynamicObjectCollection and this was set in the documentmanager but this was deemed incorrect and limiting. If you have a better solution, I'm game.

The EventSourceUpdater I might have over engineered. The one thing I was thinking was that the eventsource updater's eventname could change over time. one time it could be listening to 'access' events, another interval 'coverage'. If you think this is unreasonable, then I'm fine with making it simpler.
If I were to see an `id` property in some JSON, I would assume it is the ID of an instance.  But here you're using `id` to refer to a type ID.  Why not call it `type` or `typeID`?
Any reason to delete tests for chassis and wheels?
makes sense. I've added only those that I decided is very useful (i.e. `ddemangle` as `c++filt` and `rdmd` for scripting).
As alternative to `detab` I'd like to consider [`expand`](http://pubs.opengroup.org/onlinepubs/007904975/utilities/expand.html) utility which is part of POSIX standart IEEE Std 1003.1, 2004.
According to [win32.mak](https://github.com/D-Programming-Language/tools/blob/master/win32.mak) `dman` requires `*.tag` files which is built from documentation with help of `findtags`. As I understand docs is from [d-programming-language.org](https://github.com/D-Programming-Language/d-programming-language.org) project according to last commit message I saw on that file. What I'd like to suggest for this utility is to move most of thing to external files to load in run-time.
I believe that it is enough to have the @Inject on the constructor.
Talked with Vishal. We don't use property accessors here since we want to return String for getUsername/password/domain.
Change lists to *list*
Why check for disabled image? The code does not set the background image for normal state if no background image is specified.
Hmm actually I won't change username b/c if user enters an empty string for 'username', that would be an invalid user name.
Aren't these both needed?
Ok, so you want the deleted lines back, but only applying to Jackalope-Jackrabbit?

i.e.

.. note::
    
        Make sure you also configure the main ``doctrine:`` section for your chosen RDBMS.
        See `Databases and Doctrine <http://symfony.com/doc/2.1/book/doctrine.html>`_.
1. грузить жкуери если он уже есть – хамство
2. то и отлично, наверное его патчили для особой ситуации проекта, и те же патчи нужны и для виджета?
3. давай у требования про версию будут ограничения с обоих сторон. можно даже довольно жесткие (все равно все продолжит работать, если человек обновит jquery, так что не страшно если они будут жесткими)
Может лучше `settings.multiple = !!settings.multiple`?
If you're only going to use the variable once, don't bother declaring it. It might be optimized out, but it's useless overhead if it isn't, and it makes the code more verbose. I don't know at what point it becomes cheaper to declare the variable than to access the array again. I expect that it's well worth it with `c3` in the `c2 == 0x80` block but don't know whether it's worth it or not when only using the variable twice. When it's only once though, there's definitely no point.
space after semicolon
> And in many cases, even if a type were backwards enough to return int, it would still work anyway.

I agree with everything you've said but we still have to fix the compiler. Look at this nonsense:

```d
import std.stdio;

struct S
{
    int x;
    string opEquals(ref const S s) { return "foobar"; }
}

void main()
{
    S s1 = S(1);
    S s2 = S(2);
    writeln(s1 == s2);  // writes "foobar"
}
```
Those are the right equivalents, but "." makes me very sad, because
    it means there's no good way to distinguish PERIOD from VK_DELETE. 
    So I actually left these in as an unsightly mnemonic to figure out a
    better way to distinguish these keys later. ;-)  Surely there is
    some way to do this...On 12/25/2012 6:57 AM, Jonathan
      Protzenko wrote:
    
      In modules/keycustomization.js:
      > +  list.setAttribute("sizetopopup", "always");
> +  let popup = doc.createElementNS(XUL_NS, "menupopup");
> +  list.appendChild(popup);
> +  function createItem(itemKey) {
> +    let item = doc.createElementNS(XUL_NS, "menuitem");
> +    popup.appendChild(item);
> +    item.setAttribute("value", itemKey);
> +    item.setAttribute("label", describeKey(itemKey));
> +    if (itemKey === key)
> +      item.setAttribute("selected", "true");
> +  }
> +  for (let i = "A".charCodeAt(0); i <= "Z".charCodeAt(0); i++)
> +    createItem(String.fromCharCode(i));
> +  for (let i = "0".charCodeAt(0); i <= "9".charCodeAt(0); i++)
> +    createItem(String.fromCharCode(i));
> +  createItem("\x0D");

      Unless there's a strong reason for obfuscating using hex codes,
        please use (I believe) "\r" and ".".
      
        —
        Reply to this email directly or view
          it on GitHub.
:sunny: :sunflower:
This will lead to fatal error as this event expects `UserResponseEvent`.
That's done to have an actual database to persist data to (sqlite::memory: by default).
not used ;)
Don't think its guaranteed.
seems like it, but it's not. maybe a clearer inner classname would be a good idea.
What do conversions need to do with derivatives? Or is this handled by calling this function 3 times in the deriv case?


Is there more to this patch? It doesn't look like convert_value is called from anywhere yet.
Yeah I think you are right. It might be possible to skip some steps for certain types (for example when requesting a color on the OSL side, you know it can't come from anything bigger on the renderer side so no extra memory is needed). But its still probably more complicated in the end.

Your solution is probably the cleanest way to do it overall.

LGTM for this side of the review
this will fail for a proxy IIRC. you need to give the entity class for ``find``
Ah ok, die Eingaben des Nutzers inkl. dem Dokument etc. würden wir also nicht schon im Order hinterlegen, solange er nicht "Submit" klickt!? Sondern erst dann um ihm nochmals die Zusammenfassung anzuzeigen? Dann könnte man natürlich mehr Felder bereits im Konstruktor initialisieren, richtig?
Die Rolle ist Typischerweise ein Enum (abzählbare Menge)

Ich setze diese in der Regel so um, dass ich Konstanten für die möglichen Werte definiere
(Siehe Core\Acl\Acl.php)

Im Moment sind das wohl etwa Member und Boss
Only the specific controller will be shown in this field. If it's empty, it will use the default controller.
Any reason why? If someone types in bad regex, should they see warnings? If one redirect at the top of the list has a problem and a warning is thrown, couldn't that prevent a redirect from occurring since headers have been sent?
Фиг тебе, `%1` тут тоже должно быть, исправь обратно.
Дублирование ника — баг в адиумодвижке, а не на твоей стороне.
the function name "map_dict_list" doesn't explain very much. maybe I'll have a better idea what to call it when I see what it does, just noting that in reading the code here I have no idea what that means.
Do you think the GFI control is used more than the GF control? If the GF control is added we'll also need to add Protocol/WFS.js. This is hard to tell.
Yep, copy-paste error. Cleaning it up
An enum with a an EnumSet would make this look nicer :-)
Oh, I see. Yeah, that's not what I meant. :)
I agree with Artem; I will polish with something like "Currenty...".
Copyright 2012
Liks I said I first wanted to make sure I have something that works. Now let me explain a few more details that were missed during our call last night.

The call that creates an inconvenience for us is session.createConsumer().

To get to session we first need to get connection from the CF, then getSession from the connection and that returns us a Proxy, so what we really need to do is wrap that proxy and intercept the call to createConsumers(), but also rely on the current CCF logic for caching consumers instead of our own and that logic is exactly what you see (that is the bare minimum that i've extracted from our CCF). You can see that I've overridden one method only getCachedSession(). So let me wrap it and I'll change tests back to CCF
@celibec dont forget to check my comment on the commit
How can u access the username without user object?
I guess u should use request.POST['username'] instead of user.username
so the line should look like :-
    user = authenticate(username=request.POST['username'], password=request.POST['password1'])
Without it I get the following


    warning: Scope(Apache::Vhost[spectre): Could not look up qualified variable 'apache::params::options'; class     apache::params has not been evaluated at /etc/puppet/modules/apache/manifests/vhost.pp:42
I would bring this back in and instead pull `runModule` into here.

```coffee
{runModule} = require './run'

require.extensions['.coffee'] = (module, filename) ->
  input = fs.readFileSync filename, 'utf8'
  csAst = CoffeeScript.parse input,
    raw: yes
  jsAst = CoffeeScript.compile csAst
  js = CoffeeScript.js jsAst
  runModule module, js, jsAst, filename
```
@apex13 Should be fixed now
We shouldn't be using the `<i>` tag here.

Could we use a class on the `<h4>` instead and use an _italic_ font-style?

[1] http://dev.w3.org/html5/spec-author-view/the-i-element.html#the-i-element
I was thinking about that as well. I believe the answer is yes.
else放到上一行的}之后，如下：
```} else if (....) {```
This is a non breaking change. This is also adding a new feature. Given a Major.Minor.bug_fix version format, the minor number increments for new features. You incremented the bug_fix part. The perl convention is that `0.0123` corresponds to `0.1.23`
This will not work. A dev requirement cannot overwrite the version selected by the requirement
I *guess* using a `<table>` element could be correct here, ’cause it’s sort of tabular data (each column is a weekday, each line is a week).

My main concern would be, how do we do if we need a right-to-left layout? I’m pinging a few Arabic-speaking contributors to see if we want/need RTL calendars. If table columns can be reordered right-to-left with a CSS snippet, I guess I’m okay with using tables for calendars.
We can try in another way to store metadata for each BB, but i think this is not a blocker issue, right?
not required yet, remove
Nice job Vineet. I'll review the revised draft later tonight.

Based on our experience w/ this pull request, I think it's clear we need to document the authoring workflow better. We're in the process of moving the website guides over to individual wiki pages rather than in the README so that they can be updated more easily. Once I migrate the instructions for writing a guide, we can add in advice for how to handle the workflow.
(and the previous mode may be turned off). ... Enabling the manual mode is done by ...
I can't see all the context, but prefer early returns from these clauses than requiring the reader to follow another 15 lines of control flow.
`finally`.
please use full package name here
The reason why I don't want to mess up in existing controller. Your suggestion with Submission#rating looks good. If we create Submission#rating already, so could call `render "puzzle_rating", :rating => @submission.rating`, then we don't have to check both in controller and view for correct submission.
What happens if the user sets a piece of invalid data (say changing folder to a string) and they attempt to save. It seems like it will just be ignored entirely. Is this expected behaviour?

Should we instead make it a property that will throw an error if you attempt to set it to something invalid?
nicely done, very nice setup for future proofing

ofcourse future is tomorrow but still :)
success function is never invoked
requireLocal() no longer required after Jeff wrote our own require loader
This has some whacky spacing. Can you sort it out and please stick to the CodeIgniter Style Guide?
Missing some doxygen
Since the `og:site_name` is going to be the same, no matter what type of page this is, let's also break it out of the conditional block.
Now that you've added the setBlockLocationService(...) with @Autowired you can probably remove this null check, since it shouldn't ever be null.
Never mind.  This was moved to line 195 in the new document.