labofsahil/github-event-dataset-2012 huggingface dataset:
Put as many parameters as fit on a line together (so the first two on one line, and then mkey on the second line).
This is a worthy commit, cheers.
Umm well, this is the result of me nesting the resource list in <clone_resources> .  I do something similar with the group resources.


--- How it is right now.
<clone>
    <clone_resources>
        <resource name="blah" />
        <resource name="blah2" />
    </clone_resources>
</clone>

--- maybe how it should be ?

<clone>
    <resource name="blah" />
    <resource  name="blah" />
</clone>
1. maybe "functional requirements"?!
2. should it be in present tense: "... are defined" OR maybe it's better to say "were defined" ?
missing public keyword
here the paths are wrong , the test fails
People. You have become tired with the changes in functions. What are they? They do not improve rabotspobnost!!!! To fuck ...
\ No newline at end of file :P
This might prove problematic for those who want to build the docs but don't have ffmpeg.  Maybe there is some way to tell sphinx to not run this file?
https://github.com/NServiceBus/NServiceBus/issues/192

On Mon, Feb 6, 2012 at 8:07 AM, Andreas hlund
<andreas_ohlund@hotmail.com>wrote:

> Yes I sort of agree but this is also due to the way castle is generating
> ids (not using assembly qualified names). The other containers works just
> fine.
>
> I don't want to change all our persistence implementations this close to
> release. But we should definitely do it for a 3.1 or 3.2
>
> /Andreas
>
>
> On Sun, Feb 5, 2012 at 10:47 PM, Johannes Gustafsson <
> reply@reply.github.com
> > wrote:
>
>> Well, yes, it does work in this particular case. But it could show up
>> again
>> if an internalized component was registered as, for example, a transient.
>> It does not seem to be in the saga persister though so maybe it's not
>> really an issue, but I don't know about other places.
>>
>> I'm in the nitpick corner, I know, but I still think that internalized
>> components should be hidden from the container as much as possible to
>> avoid
>> "leaks". Best way to do that would be to wrap them into another class.
>> Then, components would not have to be named at all but could use the
>> container default.
>>
>> 2012/2/5 Andreas hlund <
>> reply@reply.github.com
>> >
>>
>> > I tested and it seems to work without naming the instances. Tried
>> running a
>> > external raven from the pubsub sample and it worked. Can you do some
>> > testing and see if there is still an issue?
>> >
>> > On Sun, Feb 5, 2012 at 10:20 PM, Johannes Gustafsson <
>> > reply@reply.github.com
>> > > wrote:
>> >
>> > > Components registered using IContainer.Configure() should also be
>> named,
>> > > right?
>> > >
>> > > ---
>> > > Reply to this email directly or view it on GitHub:
>> > >
>> > >
>> >
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934750
>> > >
>> >
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> >
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934751
>> >
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934778
>>
>
>
src\server\scripts\EasternKingdoms\AlteracValley\boss_vanndar.cpp(96) : error C2065: YELL_RANDOM:
@gnugat The composer.json file already does it. The only stuff registered in this file are non-standard stuff (i.e. Swiftmailer and the annotations) and the intl fallback which is registered conditionally
ja

-----Ursprüngliche Nachricht-----
Von: Frank Wienberg [mailto:reply@reply.github.com] 
Gesendet: Montag, 16. Januar 2012 11:03
An: Kleine, Moritz
Betreff: Re: [jangaroo-tools] somehow I created a bad combination of slf4j, selenium and jetty. Well... (accff3f)

Consequence was that we could not run tests with Selenium, but only with phantomjs, right?

--- 
Reply to this email directly or view it on GitHub:
https://github.com/CoreMedia/jangaroo-tools/commit/accff3f632124ee30676a5d51d431c34c0a7619f#commitcomment-870221
Ok, just don’t use it now. They can be deleted then in future.
"rear" should say "repair". Typing fail
Fetch, help, accessible/inaccessible
This branch is not supported. Forget it even exists.
That would be sweet! It's only got 6 outputs right now, but later this year it'll have 36 and be sweet for a really nice V8 setup. Chrysler or ozzy valiant?
[fixes #4]
in linear models y is centered when fit_intercept=True
I generally avoid initializing return values...
@FernFerret It can't be that easy. It....it just can't be, ok?
My changes should handle this - It'll attempt to "bucket" rows into "screens" based on the heights of the widgets they contain.  Haven't actually tested it with widgets that aren't 32px high, though!
Hmmm. I'm not so sure we should be touching Grunt core files.  I'd rather we break out the task completely if you absolutely must modify it.  I will be frequently upgrading Grunt and I don't want to have to deal with merging in your changes each time.
c5.c random led blinking with linear feedback shift register
(FIBONACCI) ,c6.c- - - -c9.c different forms with TACCR0 REGISTER.

C10.C &C11.C --GALOISE LFSR
What does the "html:false" vs "html:true" change? All I know is that as of now (14:00 Jan 30 2012), the popovers up on heroku are displaying `<br />` as part of the description text...which is annoying if you're trying to actually read the description :)
This string is from Issue #2 (it should be excluded before export this lacalization)
Redundant I think, close already does this
Lose the underscores. Space is fine.
there are numerous other reasons for that import to fail than just running the code with python 3.x here :s
see 7c63675
Gedit plugin is still not done for this.
> I don't like commit wars. I'd rather have discussion on a commit that seems flawed until consensus is reached before reverting rather than revert and then discuss. I think it's friendlier that way.
My apologies for that, I really shouldn't have reacted in a hurry.
> If I understand correctly what you're doing, you can use a \* pseudo-action in the configuration file to achieve the same thing in a much cleaner way.
Actually, that's should work but it doesn't. I'd almost suggest moving the \* arguments to Build_PL. I really hate Module::Build's argument handling. Also, PERL_MB_OPT has exactly the same issue (it always overrides the Build.PL arguments), and no way out.
Daar is de Accept-header niet voor bedoeld, en je hebt daarover lang niet altijd controle.
Add that a provider implementation must wrap calls to `ParameterNameProvider` and wrap it into a `ValidationException`. By the way does the spec mark other contracts like that as supposed to return a `ValidationException`? `At least `TraversableResolver`, `ConstraintValidator` etc do not in their JavaDoc (not sure about the spec)
Have you tested whether this works?
@MichaelCastelbuono  According to the spec, it should be `<County>` not `<Country>`. I think part of this needs to be reverted.
I just thought about what you meant--we should use a partial?
Hi freeformz,

Thanks for looking at my pull request.  I added a link and replaced the context-specific words (ie 'rawstat') with more generic words (ie 'table_name'). 

Thanks, 
Alex
Yeah, according to http://stackoverflow.com/questions/5595512/what-is-the-difference-between-require-and-library:
'require is used inside functions, as it outputs a warning and continues if the package is not found, whereas library will throw an error'
But I don't quite see the point of continuing if these libraries are not present, as we're bound to get an error eventually. Give the above, I'd change all require() statements to library()
Now I see, I somehow tried to be in line with the below test and jQuery setup, but that makes no sence ofcourse. WIll stick with the proposed setup:

      bean.add(el1, 'click.fat', function () {ok(true, 'target multiple namespaced event handlers with fire')})
      bean.add(el1, 'click.ded', function () {ok(true, 'targets multiple namespaced event handlers with fire')})
      bean.add(el1, 'click', function () {ok(true, 'targets multiple namespaced event handlers with fire')})
      bean.fire(el1, 'click.fat.ded')
Please don't return false unless you have a good reason for it.
I think add options when creating the select is better.
these should return a value that would indicate the value is useless.  Possibly -1 or Integer.MINIMUM
perhaps write the above 3 asserts something like this:

    mergedGossip.nodes.map(_.address) must be (Set(m1, m2, m3).map(_.address))
I don't know, I just used the existing code. I suspect that there can't be such a case.
the docs are also in the distributions
final override val?
What happens if you send this message to another kind of router? Nothing? Error?
this answers my question: the test is not overly cautious, maybe there should be a comment explaining this (because it might somehow pass by chance anyway if making the follow-up tests strict)
This seems like straightforward DRY, not sure why it is controversial.

Also, I've got some mock based email tests and we can make those more complete.
This line is also missing coverage.

If there is a condition that could cause `azimuth` to be < 0, is it possible for `azimuth` to be >= 360?
Please note here
I'm not sure what Freesurfer means by the 'output orientation' - I
suppose it changes the affine mapping with appropriate flips?

But in any case, nifti only allows one output mapping - that is RAS+
or more specifically: 'x=L->R', 'y=P->A', 'z=I->S'.   Formally a nipy
file can have any orientation, because the orientations are just axes
names, and these are unconstrained, but the way I've set this up,
nifti load constructs RAS+ output names, and saving to nifti requires
that the output names are RAS+.

See nipy.core.reference.spaces for more detail if you are interested.

On 5/30/12, Satrajit Ghosh
<reply@reply.github.com>
wrote:
>>
>>  In the NIFTI specification, the order of the output coordinates (at least
>> the
>> -first 3) are fixed to be LPS:('x+LR','y+PA','z+SI') and their order is
>> not
>> -allowed to change. If the output coordinates are
>> RAS:('x+RL','y+AP','z+SI'),
>> -then the function ni_affine_pixdim_from_affine flips them to maintain
>> NIFTI's
>> -standard of LPS:('x+LR','y+PA','z+SI') coordinates.
>> +first 3) are fixed to be what might be called RAS+, that is ('x=L->R',
>> 'y=P->A',
>> +'z=I->S'). This RAS+ output order is not allowed to change and there is
>> no way of
>> +specifying such a change in the nifti header.
>> +
>
> in mri_convert from freesurfer, we can set the output orientation of a file
> to be any of the following:
>
> https://github.com/nipy/nipype/blob/master/nipype/interfaces/freesurfer/preprocess.py#L162
>
> just trying to make sure i understand you correctly - this mapping that can
> be set with mri_convert is not the output coordinates of nifti, but simply a
> reordering of the data blob.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nipy/nipy/pull/177/files#r903009
>
I agree, don't want people wanting to work with organizations via the API to have to figure out that they need to use the group functions.
I'm not sure. Currently if the request fails then just nothing happens (and button does not change from follow to unfollow). The follow button is such a little thing, is it worth having a big error notice for it? On the other hand I can imagine if they click the button and nothing happens people might think they've followed someone when they haven't.
Only two blank lines between top level classes and functions, not 3.
I can see that. This whole section is simply to head off the inevitable "Why the hell do I have to type true?" that even people on our team have asked. I might have gone overboard with the rationale.
This should be wrapped at 80 chars
Смотри, желательно добавить 
так как в image array('file', 'file', 'maxSize' => $module->maxSize, 'types' => $module->allowedExtensions, 'allowEmpty' => true), но для этого надо в модуль добавить: allowedExtensions и maxSize
Deleted all my useless comments and just fixed the problem.
That "thing with the `types` module" didn't do what I think it did. **Instance methods must be individually bound to their instances.** You can't just patch a class to get a new bound method on all instances.

My solution instead is to just subclass `EMRJobRunner` in `test_emr`. It'll work just as well and affect nothing else.
можно, но геморно будет вытащить все действия для кейса и отфильтровать только нужное
it's not really for X_flags only, it's just used when the internal_name and external one are the same. It does set bCustom since it calls the private 2 argument constructor and that one sets it
Slice the groups for this class out of the full array and pass it to the chunk's new method.
Ok that makes sense. Add a comment here in __getitem__ for why it can return None. It's kinda what I guessed.
yeah, that actually doesn't even work at the moment ! one of the other layers (marker or cursor) is blocking my pointer.
yes, it's on purpose.
Yeah I didn't really know how best to handle this in terms of clarity. I was actually wondering whether declaring the struct type closer to it's use would make sense.
Wow, that's impressive.... but how will people on Xcode 4.1/4.2 compile it?
ついでにA をAnにしといて。
Is `null` used as a hack?
Yeah.  The odds of that happening are probably close to zero, so unlikely to be too risky.  But I've definitely been burned by similar comparison is the past.  I guess it was sort of an open question of whether there's a standard way in Ruby to compare versions of Ruby itself.
I'm just trying to say, if getPersistentParams returns only [ 'lang' ], it will end up with parameter $lang with default value 'lang' instead of 'cs'
Although there is some advantage to keeping the indentation down. I tend to see this sort of thing as a check for a special case and I think those look better as a series of 'if's.
Will *(p -1) always be valid? - I didn't check all the code paths, on first sight it looks dangerous.
This example makes it look like the config is specific to the User class. It should communicate that it's a global setting.
I tried to follow the conventions in the file,I didn't see a newline :)

About indentation,how should it be exactly? I indented all the lines to start at the same place
Don't need `self.` qualifier
@axel22, I'm up for suggestions if you'd like a different name :)
I confused myself here, but I think it was correct.

`caseImplies(x)(y)` computes the implication 'if y matches then x matches' 

thus, if x comes before y, y is unreachable:

`unreachable = cases.tail.find(caseImplies(currCase))`
The line just above attempts to answer the question (though there might be a better solution to the problem than sorting by length). Since the outer classes have shorter names (because of how names are flattened), sorting by length puts outer classes before inner classes.
Staying consistent with firstTypeArgs declared a few lines above. For my personal use case it doesn't matter though.
Yeah, that would nicely encapsulate the trigger, but it would (potentially) blow up more often that it does now. Because we don't have tests for all the variations, I erred on the side of "crash rather than fail with a nice error" rather than "fail with a nice error rather than soldier on."

While I could be persuaded to the other side, I just wanted to point out we can't encapsulate without changing behaviour.

For sure we should revisit this. But right now, the most valuable input for the PR would be additional test cases (even ideas for them, I'm happy to implement them.)
fixed earlier.
cent->cient
So this function was created but never used in SymPy?
Oh, I guess I have a TODO on the next one, so I did notice it, but was too lazy to fix apparently.  You'll notice the numerous TODOs scattered throughout the code.  Unless they are trivial like this one, I'd like to not fix them until after this is merged, so we don't have to wait on this any longer (with the exceptions of the ones that block the merge like the non-determinism stuff in DifferentialExtension).
I still don't like this code block. While it may be technically correct, you should enumerate the new cases in the imaginary handler here, rather than doing an ask on expr.
Apparently, you have accidentally added some trailing whitespace.  You should just remove it from this line, and the tests should pass.

Generally, when you see that code quality tests fail, find the relevant bit in the error message and just fix the problem.  In your case it's:

```
AssertionError: File contains trailing whitespace: /home/travis/virtualenv/python2.5/lib/python2.5/site-packages/sympy/logic/boolalg.py, line 517.
```
In this version, this **kwargs are ignore by _eval_trace() methods. This is fixed in the next PR.

I believe doit() does not need **kwargs here.  So, in the next PR, the function looks like this:


def doit(self):
    if hasattr(self.args[0], '_eval_trace'):
            return self.args[0]._eval_trace(indices=self.args[1])     #where args[1], will be a empty list for full trace, or have ints for partial trace.

        return self
Thanks for other comments, I will clear them tomorrow.
Once more, I don't think these operator overloads increase clarity.
or 

```
num, den = [dict_from_basic(_, gens=self.gens)[0] for _ in a.as_numer_denom()]
```
lowlevel -> low level or low-level (?)
L130, L133, L138
codebase of CDbTransaction is lower case, I think we should leave it lower case and adjust all documentation.
These **must** be below the stdint.h include!
This change seems wrong. Two examples using cubic hermite interpolation are failing after your changes, I'm guessing this is why.
same here, fix identation
why is this cache key a constant?
To better match `undefined_function`, make this `undefined_module` instead.
Style: same as above, avoid this multi-line style.
The room as integer is very campfire/hipchat specific. It doesn't work with irc adapter. Rooms name are . Just forgot about the migration.
Don't need if you do what I said above.
T__T
torture
that's what this is
Can pass a map to ````attr````:

    $("#radio_button_rid<%= prev %>").attr({value: '<%= temp %>', checked: 'true'});

Just a hair more efficient and shorter.
same for these urls
Corrige a part l'exception mentionne plus haut.
The sql cache should be tested separately.
Consider using multiple lines.
Controller, disappear.
Because I don't have to? I have it measured based on the 79 character limit here, and I don't feel like having to back through by changing the commit type. It's not a big deal, really, imo. :P
One per line. Docs?
Looks good to me, I can make the changes for the plupload_salt in this PR. Shall I submit a ticket for the avatar_salt changes?
This actually returns the filename of the avatar's template file, i.e. ucp_avatar_options_gravatar.html.
Ahh yes, you're right. It is still used like an array so I had forgotten.
Was this header name suggested by Plupload? If not, it should start with `X-phpBB-`
Hmm. Leaking `user_password` to style authors here.
Delete "various"?
This is a behavior change.

For guests (is this permissions on Anonymous user?), f_nocaptcha should be set to yes if anonymous posting is allowed without captcha on the board being updated, and no otherwise. I don't see a technical reason why a never would be needed but I could be overlooking something.

For all user groups including newly registered, the permission should be set to yes. Practically speaking I expect only registered and newly registered roles should be changed. I think even registered only should be sufficient.
So, in the upper 3 lines, should it stay like that or there's a need for the newline that was deleted?
Great question...
Variables in templates are meant to be CamelCase style - to act as a sort of separation between the templates and general application logic (since we have no enforced logic-less templating engine, which are great.. until you need presentation logic and have to stick it in the application instead :( )
Can we just make ``get_worker()`` return worker to the default queue if
called without any argument? This will make it more consistent with how
``get_connection`` and ``get_queue`` behave and more importantly, it
follows django's convention of returning the ``default`` backend (in the
case of multiple Cache and Database backends) when no backend name is
specified.

Win~


On Thu, Aug 23, 2012 at 11:50 PM, jean-philippe serafin <
notifications@github.com> wrote:

> In django_rq/workers.py:
>
> > @@ -0,0 +1,11 @@
> > +from rq import Worker
> > +
> > +from .queues import get_queues
> > +
> > +
> > +def get_worker(*queue_names):
>
> fixed here:
> https://github.com/jeanphix/django-rq/commit/5fa0ebdc4b12fb7a301eb07ca0f0efd8257d0dc1
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ui/django-rq/pull/5/files#r1446846>.
>
>
appConfig is reused a few times in that function (vs invoking getAppConfig())
Fixed my stupid mistake in Brew(End)Event
I always give links an unique ID as well. Might be superfluous but well... I always start with an ID column :)
This should be reverted because it's already targeting 2012 https://github.com/NancyFx/Nancy/blob/master/src/Nancy.sln#L3 the change was all on your end.
ok i do that..
Time for you to fix it!
Please add these as a function in startup.js -- then, call that function when the app is launched.

In addition, make a function that is called whenever the server is changed (add to the Login.js view in app) -- to clear the localstorage.
Please flip your array inside out. Right now, your outer loop goes through the fields [0],[1], ....[6] but should be [i],[i+1],....[noofdrugs]

This way, drug.length is actually how many drugs there are, rather than being always '6'

NOTE: you will have to flip your [k][j] variables in the view for this to work.
Should start on a new line.
注释有问题吧？
```
@return {Object} {key:  "dimension name(column name)", value: "dimenType("ordinal" or "quantitativ")"}
```
return this.getLoc(name, 'province');
OK, it turns out it looks like the CAR thing was wrong anyway. I'll be pushing a new commit with info from Olivier Breuleux (does he have a github account?) in a few minutes.
I'm really not familiar with the code, so I don't know what makes sense to downcast, and what does not, so I can't really answer that. Maybe @abalkin has some insight?
the controller does a *sem = 0 after the fork
Sheepish comment about indentation. Apologies.
StatsSource synchronizes the access to updateStatsRow() and getStatsRowKeyIterator().
Is it intended to start searching for end even before start is found? -- and to reset status and msg in that case?
In normal operation, you are going to need tmptup to store a result, but you don't need it declared separately as three different local variables.
Declare and initialize it once near the top of the function.
No. Non-inlined memory doesn't have anything to do with the actual tuple location, but that case is handled by the function just below.
missing __unicode__ method.
Why isn't the serial number used in `concurrent_get_or_create`?
PEP-8 short lines are not mandatory by Django Coding style guide. I personally found more readable long lines than splitted statements. But you have a point. Here on GitHub are better to splitted lines.
Did you leave this in intentionally?
Good use of pattern matching. Making our error messages better one function at a time :P
Lines 61-79 are missing coverage, at least in the coverage report. Are there any tests which exercise this logic? I don't see any.
this really sounds great to me, although will it be possible to share the config between the EclEmma plugin and the ant task easily?  So that devs have confidence that if their changes are "good" locally they can run an ant automated build with confidence.
This assumption here is meant as a precondition for the correct outcome (in a mathematical sense). If this precondition is not satisfied, e.g., because the function is called directly, the result will not be correct. The C++ AL will raise an exception when an out-of-bounds array access occurs.

That said, your concern raises a valid point in that there are cases where the code takes the address of an array element (with bounds checking), but then accesses memory relative to that pointer (no bounds checking any more). This is the case when Eigen objects are mapped to different locations in a single array. I'll check those cases and fix if necessary.
I am new at this, but shouldn't there be a {MADlibSchema} before the function call?
I am not sure what is going on with these 4 lines. What is the stamp for?
because we can't have group names with - char . We could change the AUTHENTICATION_CHOICES to use _ , but we would have to change all the code.
I'm doing these tests on test_sanity_view_no_erros. It calls do_config_checks and do_domain_checks. I'm not testing each error/warning message because the test would get too long, or we would have to create too many tests.
Let's add a comment here explaining why this hash is needed rather than just using site url.
ここのあたりの削除が衝突していると思われる。
I get a different sha1 for XSLT: `4df177de629b2653db322bfb891afa3c0d1fa221`
Prend en compte ;)
Using grep + perl is pretty excessive. I think that it could be done with perl or sed only. Following should be equivalent:
$ svn log --xml | sed -ne 's|<author>\(.*\)</author>|\1 = |p' | sort -u
No need to be so verbose in variable naming. This could be called `_sessions` since we know that mongodb deals with collections. Also it's a good pattern to have a 1-1 name mapping between collection (/table) names and the code variables.
I believe the "&&" in the spec specifies that the two related clauses must be present together; not in the syntax literally. Similar to above, can you remove some of the outer groups?
I can has docs?
Just curious . . . any idea if this works for lookups in the processing env?
here's no check for existence of sha256, which is done in gencode-local.

I'd advise to use "cksum" instead of sha256 - it's included in posix.
Thanks. I'll wait for you to setup the Travis and the tests bootstrap. Once it's done I'll write tests for this part (we need good test coverage as I plan to use this for a next project :p).
I guess you thought you should remove it as soon as possible, ie. when the job is "complete" or "failed"
This will prevent futher events from being emitted tho, for example if a job failes and attempts() are specified.
oops. you're right. fixed.
Why the return?
Yes, separate script is the plan. I haven't looked into consolidating both to run in git bash. I'll investigate.
I cleaned this up some more and added code cleanup issue #1397.
Also, see note below on inconsistencies with other places where we're specifying menu/item positions.
Nit: previously view -> previously viewed
I'm getting a jslint error for this html template fragment. I'm not sure what the solution is though.
This comment is no longer true: instead we should document that it's matching against the full relative path even though that's not the main label
I updated the padding factor a few commits back and didn't bother to update the specs. Good call on the test name. Changing.
it's not activated yet in prod anywhere, just a placeholder for getting to work once ready - can remove entirely since we're likely not using this class at all anyway.
Why do you need the `aaply`? Passing in a character matrix should be fine.  And I don't think you need the ifelse either?
why is this method static ?
用 `$('[data-type=modal]')`

haml: `.xxxx{ :data => { :type => :modal } }`
Removed hoover and focus, looks better without.
Those code segments are leftovers which I forgot to remove.
Yeap, sounds good.
haha what is the span there for?
`_handle`
Same as above. Does the popcorn variable change?
is there a difference between `mediachanged` and `mediacontentchanged` (we use both in various places).
would

`for ( ; i >= 0; i-- ) {`

look better? (whitespace added)
Do we even need the `../../..`?
I dunno - these are just copied from the Remix URL...
instead of putting the entire test in a callback, add a new test block above the rest that calls t.end() in the callback fn
This case ends up filling the log with noise. An underscore prefixed on the name of the module or function ought to be obvious enough not to need logging.
odd to have groupId with dash
dso find postion (%i)
Původní popis neodpovídá skutečnosti, v daném dialogu nikde nejsou žádné cesty, natož pak adresáře.
good ,better for add 。
No need for full namespace as this is added in `use`
An item uri can only be generated by one route, so you can simply do 'routeParameters' => $params.
+Trainers from the Pokémon Gym\xfffehave come to the Dreamyard and\xf000븀\x0000\xfffetrain extensively.
I don't have access to my PC (for about 9 hours). I may be able to do it on my phone though.
ref? No thanks
I discarded this approach.

We have already a circular dependency between EBox::UsersAndGroup::User and EBox::UsersAndGroups::Group and I don't want to made it stronger.

The alternative would be t o create an userExists and groupExists methods in EBox::UsersAndGroups but I think we have already many methods there (around 60).  

So if you find the exception ugly we must implemente the *Exists methods
remove underscore or lodash?... i thought both of them are dependencies (whichever user prefers)
You moved the discussion of the idea of "current" cosmology down here, and I'm afraid this means it will get lost.  Perhaps have it in it's own sub-section or something, at least?  Based on the discussion in the mailing list, this isn't an immediately obvious concept, so new users will probably be rather confused if they don't see this explanation... particularly when it starts finding its way into other subpackages.
I think you should use the `setattr` builtin here instead of `object.__setattr__`
You're right, that needs to return a fun.
A mistake rebasing. Fixed.
Can I see the code in that case?
I like this suggestion, as it's a nice coding style. Perhaps someone should look all over the code and check if we can optimize control-flow statements!?
Ah, true. I forgot about that. Browsers... :(
His stuff :P I just copied over
no, we have bindObject on the type. reusing the entity for different objects would sound really weird. setObject is just an implementation specific helper.
Each call of the rendered shouldn't cause the template to be reloaded.  Let's load these once in the application, save them as attributes and then just call their `render` method in the handlers.  Let's use a name like `foo_template` for those attributes.
very clear, thanks!
these map between the oauth spec's algo names to the JCE algo names, so yes.
Hi @leshill,

Thanks for the comment and the code. I hadn't used this approach yet, but it's a nice one!

The pull request is updated automatically, that's nice.
`.download-list a` would be even better.
/me learns something new.

ok, i think there are probably a bunch of places where we do it wrong then...
Just a best practices thing.
Yeah, apparently the last 7 days is a little volatile so they asked to change to last 30 days for this and default.
typo: ``it WOULD remove``
If the choice is mutually exclusive, the API result should side with machine readability (preserve the status code over the message). However, I'm pretty sure that's not the case. You can probably subclass the status you want (https://github.com/webpy/webpy/blob/master/web/webapi.py#L122), change the message, and raise it.
@AdrianGaudebert well, there is another place this function is called, inside the products function, and I did not want to change the way that works so, when that function calls this it passes null for $versions hence, if $versions is not null use versions else just pass null as it used to be.
the only column in the table is UUID.  If I use *, then I completely avoid the question of uuid/ooid/crash_id/report_id/crash_key problem...  ;-)
The same could probably go for `_create_featured_app()`: if we're not using the code where we're writing it, it becomes difficult to determine where or whether it's used in the future.
Make the exception message more helpful by including the failing path.
repr of a string will add the single quotes already
I need to clean up this line
Not a _huge_ deal, but I think `isinstance(klass, basestring)` is preferred. Otherwise, looks good to me!
https://github.com/square/retrofit/pull/94
does the function really need to be static ?
my bad, sorry!
This is more of a consistency issue. Every other message uses this form. Plus it's a closer translation.
you should use a strict comparison according to the coding standards
caution there is a trailing `'`
Is 'bbb' typo?
`return (self.leftStyle != CPUserActionCellSwipeStyleNone)`
same goes for self.rightStyle
SelfNote™: Consider using a function which returns the hash.
what's the point of the tag? why don't we just tag with host and port? is there any reason to have other ad-hoc tags?
Minor speedup/improvment (by avoiding multiple dict lookups):

```python
server_port_tcp = options.get("server_port_tcp", [])
if not isinstance(server_port_tcp, collections.Sequence):
    server_port_tcp = [server_port_tcp]
for port in server_port_tcp:
    try:
        reactor.listenTCP(int(port), ircd)
    except ValueError:
        pass # Wasn't a number
```

Same goes for ``server_port_ssl``
No, the default options should be looked over, but that isn't in the scope of this pull request. We'll have to do that later.
Copy paste got the better of me.
Yay! Death to meta x- fields!
There's an "if" missing here, methinks :)
Ironically based on our conversation yesterday, this is one case where I would use dict() so you could use a generator expression to initialize the dictionary. dict((name,AddressBookEntry(name,cidrs)) for name, cidrs in config_dict.get('address_book', {}).iteritems()) (check the number of parens there)
"Tell Ember..."
Probably should have .. in front of the first /
I agree, I though of using ```Joiner``` to make the code a little more concise but didn't want to introduce this change without any approval  :smile:  :
```java
final Joiner pathJoiner = Joiner.on(File.separatorChar).skipNulls();
final String loggingConfigurationDefaultValue = "file:" + pathJoiner.join(jbossHome, serverBaseDir, CONFIG_DIR, "logging.properties");
```
Or I can just replace front slash with File.separatorChar : 
```java
final String loggingConfigurationDefaultValue = "file:" + jbossHome + File.separatorChar + serverBaseDir + File.separatorChar + CONFIG_DIR + File.separatorChar + "logging.properties";
```
What do you think ?
Just added a commit to the branch which makes the update operation private.
I was wondering what happens when FRAMEWORK_SYSTEMPACKAGES, FRAMEWORK_BOOTDELEGATION are given in the props to the FrameworkFactory. They need to be considered for modules package delegation too, no?
The EntityManager reference count should only be referenced by one thread.
We could make the reference count atomic in case it does end up being
referenced by multiple threads for an unexpected case.
On Jul 18, 2012 2:48 PM, "Jason T. Greene" <
reply@reply.github.com>
wrote:

> > @@ -151,15 +158,47 @@ public void close() {
> >
> >      }
> >
> > -    public void containerClose() {
> > -        if (underlyingEntityManager.isOpen()) {
> > -            underlyingEntityManager.close();
> > -            if (isTraceEnabled) {
> > -                ROOT_LOGGER.tracef("closed extended persistence context
> for pu = %s", puScopedName);
> > +    /**
> > +     * Start of reference count handling
> > +     */
> > +
> > +    public void increaseReferenceCount() {
> > +        referenceCount++;
>
> not atomic
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/jboss-as/pull/2546/files#r1190652
>
Done, in 10732ed9523e939987bf1e1f74ce9ed54ae19716
Also, `ui-progressbar-animated` is a bad name as it's visually descriptive, not semantically descriptive; `ui-progressbar-indeterminate` would be much better.
This map construction seems very non-idiomatic.
Why not just use a literal?

```clojure
(reset! clock-atom
  {"hours" ...
   "minutes" ...})
```
Why can't we use os.path.basename?
but the problem according to UX guys is that fallbacks are wrong, well, could I change they?
May be storing in a var the result of the querySelector and then add/remove classes to that var
don't need the ( )
classes.remove?
it was for symmetry ;)
No worries, I know you added this trailing space just to see if I was really reviewing :)
Do you mean sometimes I check if callback exists and other not? I should check it always.
// The frame is just being append and app content is just being loaded,
      // let's get the screenshot from the database instead.
generic `openDialog()`
My bad, but after looking at it more closely, this call indeed makes more sense in the exitCallScreen function.
sorry!
nit: add a line break;
I totally agree with @basiclines , so (unless @etiennesegonzac tell us otherwise), I will create a "custom_dialog.js" for the Communication apps to make the dialog messages configurable, even regarding the "document" on top of which they may show and hide, injecting the corresponding HTML code :-) This way we'll be able to delete all the forms from the dialer's index.html file ;-) If anyone if not fine with this, please comment ;-)
Do we need this iconEdit here? It seems belong to ThreadUI page.
FB? for the same reasons as suggested above
Rebased today. Settings seems to be running fine OOP.
You could use 'disabled' HTML param to achieve the same
Is your test case for embedded images, or external images?  (Is it one of the e-mails you forwarded to me?)

One possibility is that the width/height directives don't have any effect when the "src" attribute on an image is removed, and so when we put it back, those sizes take effect?
I’d still *much* prefer using submit/reset instead of an arbitrary class name for a functional thing like OK/Cancel.
why not just `action1Node.className = ''`?
No. These URLs are meant to be protocol-relative. If you force HTTP here, this will lead to errors when serving a site on HTTPS. More info: http://paulirish.com/2010/the-protocol-relative-url/
Nejak moc prazdneho mista
Not much of a 'writer' interface :)
Yep, that's going to be the next feature. I'm looking to replace our existing IMAP processor with Mailman, which currently moves processed emails to a new folder.
Take this port and make it into a constant.
Save asserts for your tests - use AppScaleExceptions instead.
This should use HttpProvider (oversight in the original implementation), which should pass in a Network Credential instead of a custom model. Makes ConnectionInfoModel irrelevant.
In fact, this should perhaps just append the branch, in case the URLs are `/path/to/repo-branch1` and `/path/to/repo-branch2`.
looks like you got some merge conflicts.  I think you wanted a rebase, not a merge.
Just not yet implemented. Maybe not needed, indeed.
Symbian RIP. Or you want to add Symbian support for qbs ;)?
Input field was removed, see 65abd8b20ab047016e2fc30e5cd1edf5bf4554ea
we write history and then trigger ajax call? Trying to understand how it works now :)
Thanks, added a fix to #1392
The whole `unname(...)` probably should be its own function
so that we can test in our unit tests that auth_with_assertion works for proxy_idp issued certs.  if you look in this file, test/lib/primary.js is written right now assuming all primary users will come from our sample primary.
For compatiblity reasons.
In 1.9 release, we are going to use a new Sandbox's which will allow us to remove Components from sandboxes global scope.
But in the meantime other firefox releases will still have it. And the compatibility issue is that it will throw exception if you code try to overload existing `Components` global.
Having said that, we may export in future releases Components and components from require(chrome) in order to allow that, but only when all firefox releases will support this new Sandbox flag.
Hu? Why is accuracy changing here?
no need for an extra space
+1 to relying on $PATH instead of hard coding it
I think that probably adds more cost than value, but if you wanted to experiment with, say, a feature to detect this, I would be cool with that.
The later. :)
`self.path` references the current directory (`./...`), i.e. the working directory. This will therefore fail if ricodebug is not started from the directory where the folder `third_party` is located:

    IOError: [Errno 2] No such file or directory: './third_party/load_pretty_printer'
Shouldn't the v1 API still be present in the API doc if it's still supported?  What happens if the eureka service dies and we lose the registered APIs, and then we need to get Agi back up and running using AgiFog again?  How do we re-register the v1 API?
Ok then, removed
can be :+1: but, the default should be true, instead of false.
In this case we can't delete data via export. 
I have only one suggestion to solve timestamp-based delete -- user should provide data actuality timestamp via web interface on import form.
In this case we can remove all records, which  not  updated from this time and do not listed in CSV file.
Nice anecdote - I would have answered the same :cat:
The same thing here
`strada` e' un concetto precedentemente presente nelle docs di ZF1? Perche' userei sempre `route` se possibile... Rende le cose piu' semplici all'utente finale avere un collegamento diretto tra nomi delle opzioni e delle classi :)
Here it's strange
it is turned on and off, from the admin.js
Just a little bit =)
Check this post from Antoine http://stackoverflow.com/a/8527531
just trying to save myself some coding for when you have a filter applied and add/remove items. I'll take a look at if it can be done without CSS.
well, you indeed need to change the route name as you removed this one, but you should keep using the router
done. you should really get some sleep before you hurt yourself :)
I don't think so, but it's true that a bit of escaping wouldn't hurt
I wasn't sure why Selection was being exposed externally from the model; it
seemed like Selection was something the model was using internally to help
manage its state. It seemed more natural for external users to operate
directly against the List rather than also have to know about Selections.

Also, it looked like the squill Lists and Cells had some of the
functionality I needed (or at least some thought had been given to
providing that functionality, whether or not it was all implemented), so I
just copied some of it over to the ui.widget versions.



On Tue, Oct 23, 2012 at 3:42 PM, Martin Hunt <notifications@github.com>wrote:

> In models/List.js:
>
> > @@ -271,5 +278,49 @@ var List = exports = Class(Widget, function(supr) {
> >  		}
> >  		
> >  		this._cells = newCells;
> > +	};
> > +
> > +	this._onSelect = function(dataItem, id) {
>
> What's the reason for republishing the events and adding all of the
> Selection accessor methods to the List class?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gameclosure/squill/pull/7/files#r1922804>.
>
>
So, if I get this right, you simply block until a packet arrives, and assume it's the immediate response corresponding to the request we just sent?

So, it's fairly similar to the http implementation, where we also assume the http response will contain the immediate JSON-RPC response to the very request we sent along with the request. I'm generally very unhappy with this solution, because it's not very flexible and doesn't adhere to spec, which dictates async communication.

But, since php is blocking up from the ground that'd be <del>very hard</del> impossible to implement. So, meanwhile this is the best solution I can think of. (for non-blocking php react would probably be the best solution... but we're not moving this repo to react for now, if at all we'll port it)
The list comprehension that uses locale as a name caused issues with the import, and since some methods here use locale as an argument name, I figured renaming the import would be better (I guess we could change them to locale_code but locale is used everywhere else in the site)
IE9 will lock up on console.log instructions, as it doesn't actually have window.console unless you open the debugging tools (brilliant decision). This may need an if(console && console.log)
Who = What
I don't think this does what you think it does.
Try using brackets.
I've choosen such a name to align with the ```PasswordMissing``` type
I might need some help with this. I really suck as CSS. I played with it last night some, but my classes weren't getting applied. I guess specificity issues... Not really sure at all. I was able to get the width portion to work but not the border-top.
See above notes re: the educational nature of what's generated by rails. I've found it helpful to have these stub files around to give me hints as to the possibilities, at least while I'm working towards being a Sparkly Rails Princess (c.f. twitter.com/betthearm/status/266916129291763713)
changed to orange sector fill and unfilled circle recently
Yes, that's the reason why I've removed explicit log4j dependencies. 

The only one left is within the AS kit, of which I'm not sure.
I don't particularly like this being in all of the ChildReference instances. I'd rather have a subclass that adds it, so that we don't have all the extra overhead (of an empty list and the federated ChildReferences object) in all the internal nodes.
Isn't `new` always a GET? Considering that, it is a very RESTful way since it renders the page for a 'new' session; right?
Or comparing the type ;)
Please don't commit commented out code ;)
Isn't it used outside the pjax function scope:

function extractContainer(data, xhr, options) {
  var obj = {}

  // Prefer X-PJAX-URL header if it was set, otherwise fallback to
  // using the original requested url.
  obj.url = stripPjaxParam(xhr.getResponseHeader('X-PJAX-URL') || pjax.requestUrl)
...
While not strictly part of our CS, I surely admit it is kind of ugly to have them for the else part and not for the former one!
что это за бредовый класс? зачем такой нужен?
первое число можно вычислить. не стоит заставлять пользователя передавать такую информацию
Technically no, because the size of `limited-result-set` is `limit + 1`.  This is how we can distinguish a query that returned *more* than the maximum number of results from a query that returned *exactly* the maximum number of results.
I've rearranged this, but this might be in error. My rationale was that users should be given the opportunity to insert any stylesheets before Refinery's (albeit minimal) stylesheets are loaded, but I'm concerned that this might result in errors if the user is on IE6 and loads some library with PNGs. @parndt WDYT?
Also check that none of the actual metadata of the deleted comment comes back.
This now uses `/api/configuration` and I removed the functions that get the individual module config.
Not quite sure what the user is intended to do with this function. There is no result, should there be a reference to a local temp file or something maybe?
We might still want to keep this around, otherwise production deployments will have to manually drop the keyspace after (successfully)running the tests.
Will fix. I didn't know about av_inv_q.
If your concern is accessing the selector even after its closed due to ClosedSelectorException, we should just call close, log the exception and return from the method.. Much cleaner