labofsahil/github-event-dataset-2012 huggingface dataset:
> def copy(self):
     raw = self.raw.copy()
     del self.raw
     new = deepcopy(self)
     new.raw = raw

don't forget to re-assign self.raw
Yes, exactly.

2012/10/28 Alexandre Gramfort <notifications@github.com>

> In examples/preprocessing/plot_ica_from_epochs.py:
>
> >  # A distinct cardiac component should be visible at index 24
> > -epochs_ica = ica.pick_sources_epochs(epochs, include=None, exclude=[24],
> > +ica.plot_sources_epochs(
> epochs, idx=13, n_components=25)
> > +
> > +###############################################################################
> > +# Find the ecg component automatically using correlating with ecg signal
> > +
> > +from scipy.stats import pearsonr
> > +#  First, we create a helper function that iteratively applies the pearson
> > +#  correlation funciton to sources the sources and returns an array of r values
> > +corr = lambda x, y: np.array([pearsonr(a, y.ravel()) for a in x])[:, 0]
>
> leave it but add a note that 'corr' can be used instead?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1960941>.
>
>
use tempfile see #247
Looks like there's a few other instances of ``ES_INDICES['default']``, too.

I'm not really sure what to do about this. On the one hand, if it doesn't exist then maybe that's indicative that someone hasn't configured it. On the other, maybe we should have a "sensible" default? On the other other hand, if the user is sharing a cluster with someone else and everyone's using the "sensible" defaults, then everyone is hosed.
Fixed. Nitpicky much though? :-P
again, should be "might". The Symfony console always behaves correctly. PHPUnit does, but we don't care about that; I mean, someone should probably report that to PHPUnit, but it has nothing to do with Symfony. I would even say that this sentence should be removed altogether.
You should put a space between `="PUT"` and `/>`
If ANSICON is not installed, they will be shown for sure. E.g. if you have phpunit.xml.dist set to emit colours from the console, you will get raw ANSI sequences under Windows from a Console command.
当开启此功能时，对于相同<link id="proxy_cache_key"/>的请求，同时只允许一个请求发往后端，并在缓存中植入一个新条目。
this one-line function is a code smell, probably not your fault though.
Double free. You're freeing it here and on function exit.
http://blog.xdite.net/posts/2012/02/06/extend-bootstrap-in-compass/
ModifyMembergroupIcons()
[/pedantry] :)
I think you should restart the repaint interval only, if a repaint actually occurs.
s/tp/to/
We can probably move the contents of this function back into initialize now, as I moved it into its own function so we could repeatedly call it.
Yeah, I'm gonna leave it here.
I see, thanks for the pointer.
hum I don't recall `grunt.log.writeln` accepting multiple arguments. where did you see it done this way? also, if i could just get you to squash your commits then I'll accept this and give it a once over locally.
Yeah, it is in the config. I am setting the default there, which is just a sample interface.
Er, this time it really is necessary: it's used in an anonymous inner class, so it must be final - at least until we upgrade to JDK8...

Besides, it's not just this parameter, it's all of them except asyncMarshalling.
All this implementation is wrong when the asset is not a FileAsset
Ok, thanks! Added.
Ah.  It looks like the new values are better anyway.  We may want to keep them.  @jdh2358, @efiring... and others who understand the boilerplate generation: what do you think?
this should be removed?
Excuse me. But could you let me know why these mails were sent to me while I have no projects in github and follow no projects?


--




At 2012-07-20 00:46:37,becw <reply@reply.github.com> wrote:
>> @@ -147,7 +147,7 @@
>>  						rule += p1 + value + p2 + value; 
>>  					}
>>  					rule += '100% { -webkit-transform:rotate(100deg); }\n}';
>> -					document.styleSheets[0].insertRule(rule);
>> +					document.styleSheets[0].insertRule(rule, document.styleSheets[0].cssRules.length-1);
>
>This doesn't work for me as written; adding the rule to the end of the CSSRuleList does work, though:
>
>```document.styleSheets[0].insertRule(rule, document.styleSheets[0].cssRules.length);```
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/neteye/jquery-plugins/pull/47/files#r1198655
Yes, I use Eclipse for editing and durring implementation I changed the
editor's rule, so after first/second checkin I have the 2 space instead of
tabs.

On Tue, Sep 4, 2012 at 8:54 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> >
> >
> >  var childrule = function( pass, noneok, rulename ) {
> >    return function(ctxt,cb) {
> > -    var pn = ctxt.util.proplist(ctxt)
> > +	var pn = ctxt.util.proplist(ctxt)
>
> please maintain consistent indentation
> 2 spaces per indent, no tabs
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/8/files#r1525610>.
>
>



-- 

*malex*
err - train and apply should have exactly *one* SG_PROGRESS - no more. otherwise it is becoming meaningless.
I would prefer if you would add a wrapper in the CHash class, so that you dont have to iterate over the call IncrementalMurmurHash2, but just pass number of bytes to it. Makes reading a lot easier
Because multiclass_type is no longer a variable of CMulticlassSVM, but one variable of his base class CMulticlassMachine. I think it might be his base class's responsibility to write and load this variable. However, I'm not sure about this, so I commented out instead of deleting it. If you think it should still be read/write here, I can uncomment this and change "multiclass_type" to "m_multiclass_strategy". :)
for what you need here $p_count?
I tried `(default)` as a prefix but the name gets cut off since the column isn't large enough. But I do agree that there should be a better indicator; just don't know what.
Why are patching an already released DB patch?
Not sure what you mean - that the function could be made more generic, and not only for network interface configuration?
You don't need to pass `context` to `Backbone.history.route` just to get it back in the callback.  You can just use the value from the closure above.
Note that here, Delegate actually has a delegate.  My thought here was for each delegate to BE a delegate ... in other words, the Delegate should be a parent class of both stores.
How *do I
Kalliin `count` kutsun välttämiseksi voit käyttää hyväksi `my-some`:a:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
Compile warning: dereferencing type-punned pointer will break strict-aliasing rules

Can we use reinterpret_cast here to make this super explicit?
Yes, I can agree to that, -- but `code` was what was originally in the code. I can change it. Or do you mean to do `code = newstyle_name;`?
did you mean

$viewName = $input->getCmd('view', $this->default_view);
We have to use extra for the watch count (since using annotations is heavy and automatically excludes unwatched videos). Unfortunately, because of how extra works, we can't filter or exclude on the watch_count field if it was added via extra - feels like a bug in django, but I can't seem to find a ticket offhand. I can add this note in a comment.
what if klist is not in path? I guess we need to do which(klist..).

--> I added which klist

also, if we move this code into its own line, we could parse it without reverting to grep :)

hmm can you give me a small hint, how to do this. Basically all I did was copy & paste for most of the code. :)
Now, here you have a problem. :-) Notifications is processed in the background, in Celery. So when you get here, you are too fast, notifications has not yet been processed. The idea is that client gets response as quickly as possible, so that we do not necessary block web Django process, and keep connection open. And then when notification is ready, we push.

But there is even one larger problem here, testing with background tasks is not really easy, you should not be required to run some background process to test things, and then wait.

So the solution would be, that just for the time of testing, we force all background tasks to be executed in response generation itself.
But that upper `if` will not get triggered again because `is_online` is already `False`.
<code>Prosimo bodi previden/a, da odpreš celotno povezavo. Tvoj e-poštni odjemalec jo je morda razdelil v več vrstic.</code>
Ok?
This is quite tight loop. Are there any limits on how many requests per second/minute can we do to them?
Create HTML eleemnts through jQuery.
Ok icon needs title/alt anyway. :)
It seems that executing all 3 writes altogether is very unlikely (upgrade, USB source, some added sources (???)), moreover saving sources is just writing the respective *.repo files. The files are really small (few lines) and there are usually few of them to the time cost is negligible if any (so no problem IMHO).
Usually, for encoding/decoding code like this, you would implement the method that handles a string using a stream and not vice versa. Streams are used to enable your application to handle large strings (potentially larger than your available memory) efficiently - so by reading the content of the stream into a string for further processing,  you are defeating its main purpose...
We might want to make this consistent and set the default value to false as well.
you can cast obj to gameobject and get gameobjecttemplate from this pointer directly
just to be consistent, should this not also s/$!/e?
@davidwhogg, note my comment below.
I don't think doing it in ``setApplication`` is a good idea. It would instantiate the registry even when running other commands than Doctrine ones, as ``setApplication`` is called when adding the command in the application. Couldn't you modify the help in another place running only when needed ?
We should make the link text configurable – either globally as a configuration option or individually as a tag argument. Or both? What would you prefer?
While having this in the header allowed inlining, because it was static then anything that included `ngx_pagespeed.h` but didn't use `ngx_http_pagespeed_str_to_string_piece` got a compilation error.
Could you please add license header at the top of this file?

The one like in the file buildtests/basic/test_site.py.
+* `Installation <install.html>`_
I see most of the formatters use [`Formatters::Base#extract_locale`](https://github.com/twitter/twitter-cldr-rb/blob/master/lib/formatters/base.rb#L33-35) and `TwitterCldr.get_locale` (that also takes `FastGettext` locale into consideration) is mostly used in `localize` methods. Is that on purpose? Would it be more consistent to use `extract_locale` here as in other formatters?
hm. must be.
Argrhgrmm... don't love the "selected" parameter. Are you sure "point" needs to be there? It could just be highlightPointCallback, I guess. What about drawHighlightPointCallback?

Also what if I dumped "Callback"? "drawHighlightPoint"? It's not standard. /me blathering.
this method should be named iq_exec

Plus, this methods *MUST* be safe. Please use a try catch block, declare and error code. You can have a look at other modules
do you really want to call this even after the catch case?  why not just push this up into the try block?
This one is: ahmedhack14@yahoo.com
Should this be `isAnalyticX() const { return false; }`?
This removes the variable from the dox, is this intentional?
the part "case current_project..." should be refactored into a method. since it si duplicated in the 2 actions.
That is perfectly reasonable. Go ahead.
Could you pull the unless out, so it reads:

```ruby
if metadata[:options] && !metadata[:options][:layout].nil?
  opts[:layout] = metadata[:options][:layout]
end
```
These subclasses should only inherit Page, otherwise they inherit MozilliansBasePage twice.
Also, it could be good addition to time and args tracking also add number of retries.
Erros de ingrêis:

Corrigido:
Your password has been reseted! You may now log-in using the login box

Sugestão:
Your password has been reseted! You may now log-in using your new credentials.
o primeiro nível do path desta URL poderia ser: journal_actions, ao invés de bulk_actions, por este ser especializado
no, but is untranslatable, using global call to the bootstrap's `.button('loading')` seem to be nicer solution, and is DRY
You can pass in a tuple of types:

    if isinstance(start, (date, datetime)):

It'll return True if the obj is an instance of one of the given types.
why block comment this rather than just removing it?
I think you two agree, I don't think @jamesiarmes wants you to remove them.
looks like a typo: "IBRARY"
No they don't.  Don't mess with code you don't understand. :|
(This would make any largeish burn, bruise, or cut bleed.  if a brute force wound is of a certain size, it can become a cut instead of a bruise.)
This would probably be better of being a proc under each type of gun, so that you don't have to edit anything outside of the code specifically for that gun to add a new one, if it is not intended to be able to be in a holster, instead of having to edit this. Also makes it (very) slightly faster, since it's not doing a bunch of ifs every time a gun is holstered.
Thanks a lot for spotting this.
Incorrect input на каждую возможную ошибочную ситуацию... Надо более чётче пользователя информировать.
Это совершенно нормальная ситуация, когда пользователь в консоли нажимает Ctrl + D
Вынеси эти две строчки в отдельный метод.
Thanks Chris, I knew I would have missed something. Will hopefully fix
tomorrow.
On May 28, 2012 8:38 PM, "Chris Northwood" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,10 @@
> > +include setup.py README.creole MANIFEST.in LICENSE
> > +recursive-include molly/apps/*/tests/data *
> > +recursive-include molly/apps/*/templates *
> > +recursive-include molly/apps/*/static *
> > +recursive-include molly/apps/*/data *
> > +recursive-include molly/*/templates *
> > +recursive-include molly/*/static *
> > +recursive-include molly/*/data *
> > +recursive-include molly/media *
> > +recursive-include molly/templates *
>
> We need molly/maps/management/commands/markers too it seems:
> http://buildmaster.mollyproject.org/builders/molly_demo/builds/560/steps/shell_1/logs/stdio
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mollyproject/mollyproject/pull/94/files#r889527
>
I added some notes above about the whole .type_blah(app[blah]) syntax that's going on here.
Since joe is not here.. gonna go ahead and merge..
What is the purpose of ``py_random_state``? Not to change the estimator during fit? I would do
``random_state = check_random_state(self.random_state)`` and then use ``random_state`` later. Or doesn't check_random_state make a ``copy``? Maybe it should.
``n_iter`` seems not to be documented.
Returning `ErrorExp` will display `(__error)` in the error message. Instead, setting error type to the returned expression, as like `e->type = Type::terror`, would be better.
It's a redundant code. I'll remove this.
Fixed the logic as suggested. There is no need to test container_ because it will always be valid. All controls have parent containers. It's set in the function "setControl", which tests the container_ member.
Close, these are XML nodes, so there'll have to be some mapping in there.

```ruby
response[:tracking_numbers][order_id] = tracking_numbers.map{ |t| t.text.strip }.join(',')
```
Which PR?

For this line I rely on https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/AbstractOptions.php#L126-129
This comment is no longer relevant - the implementation has changed significantly.
> Any failure during commit, that alters the store, e.g. cAddSubFileAction will not rollback, if subsequent failure..

That's not true. Most actions have a proper roll back, this one is rather an exception than the rule.
these could be const I think
This might end up cleaner if you have a
ExpressionName * queryName(IHqlExpression * expr)
which checks queryTransformExtra, returns it if non null, otherwise allocates, associates it, and then returns it.

then you can say
if (queryName()->id)
or
queryName()->id = ...;

(See various uses of queryExtra() and queryBodyExtra() in the transforms for an equivalent).

Later if you start expanding annotations on the same line, or expanding constants in line you can use flags in the class to indicate whether it is expanded.
You could even move the logic for generating the text into there, but that might be a step too far.
should be a memsize_t cast
Since it's reading back a bucket (phase 2+) here from a prev. spill, it should be a small factor of the memory footprint it had when it spilt.
For this reason, I had deliberately coded so that it couldn't spill whilst the new buckets were being populate by 1 of the old bucket keys, it couldn't spill (i.e. other consumers would have to make way).

I probably could spill at this initialization point too, it complicates things a bit, I'll have a think.
We talked about not using ``get_or_create`` because we check for ``created`` in ``kwargs``.
Change to the DB to ensure that it is enforced not NULL. - Needs to be changed.
Uh, they're already there by default:
https://github.com/mytardis/mytardis/blob/master/tardis/settings_changeme.py#L173
Changed in $reader.
I'm analyzing your first question.. 
"I think my last question is: when I imported your changes locally and removed the cast (StatefulKnowledgeSessionImpl) -- just left line 50/64 as it was, then the test did not fail."

I don't understand how do you want me to modify the tests to fail if I use the StatefulKnowledgeSessionImpl where?
``*`` is bad for a requirement as it will forbid tagging a release. You should use bound constraints (btw, the same is true for other constraints as they are all unbound)
It seems it does render ".:", so I put "::" on a separate line.
I guess most importantly, this should state which ones are and which ones are not.
I don't think so... the field in the db is post_status, setting postStatus appears to be working:

![see](http://cl.ly/image/3N1g0h2I0741)
What does the final pom look like in a repo?

Using deep management + properties for versions is great for maven, but terrible for resolution times and understandability of a deployed repository.

I consider it an anti pattern.  If maven rewtites to an effective pom before publishing => cool.   If not, I'm on the fence about this.
Instead of function, this piece of code should work:
```javascript
for(var i in spanTag.getElementsByTagName('script')){
  eval(x[i].text);
}
```
This is already covered by ```Opt::RPORT(3299)``` above, please remove this line.
Ah! That makes sense. I'll ensure that the register part only happens once.
We could create a new class ``Injectable`` or something like that which both ``Inject`` and ``InjectValue`` could extend.
Does this logic beyond in the `BillboardCollection`?  Conceptually, does it make sense for the abstraction of a billboard collection to have to do this?  Should it be a function - or precomputed property - on the frustum instead?
I won't even try to hide my bias, I hate object literal parameters more than any other standard practice I've seen in Javascript.  That being said, this might be one of the few cases I could possibly see a use for them.  These parameters are ordered from most-common to least common, so chances are users won't need to pass 'undefined' half-way through the call chain, but since new instances aren't created very often, I have no problem with an object literal if that's what users prefer.
I think launchOptions should be released to nil here since none of UIApplicationLaunchOptions*Key option are relevant when an app will resume from background.
@sptramer, your opinion ?
Again, if you're referring to the param, see previous note.
No null checking for geomagneticFieldLocation
Why removing quotes ?
Nah, but it seems like something the base class should delegate to. I'm OK with leaving it.
this should be removed. It is not needed
Just nitpicking: this sounds like it misses a word. forwardEclipseLogEventsTo... Whom? :) The previous name sounds clearer to me.
"...original price <b>of the of the</b> item..."

(Too many "of the"s)
> Con: adds clutter and makes people who do know that particular detail worry they don't have it right.

Honestly, I wouldn't worry about that, since the spec and TDPL are very clear on what happens with default initialization, and I think the gain of making it clear that the programmer didn't forget to initialize the variable is definitely greater. I generally consider default initialization to be for cases where you forgot to initialize a variable or where there's no point in doing so (e.g. it's declared right before an if-else statement which initializes the variable as part of what it does) and that it shouldn't be used in lieu of explicit initialization. But it's definitely true that the decision is subjective.
`$(D argv)`
I forgot about this one tbh. Need to have another look
s/Install/Build and install/

s/packages/libraries/
This is not cool.  Abstract SendTabActivity.getAccountGUID and do this right.  You don't need all these hi-jinks with invalidation, etc, anymore.  This needs to be rewritten and then we'll re-review.
if I don't define them here, they weren't added to the generated agent jar. Maybe I've done something wrong here. This counts also for the next comment.
If it is not a test class, please name it different then My---. Name it Default--- or something like that.
got it.  thnx.
Maybe it's better to override the form_errors block?
Why commenting ? Should we just remove ?
Use input[type=submit] instead of standalone button
`Open subtitles`
Why does this method accept the full case data rather than just the email? It seems to violate the abstraction a bit, this object shouldn't need to know anything about case data, it just fetches users based on email addresses.
idiomatic Python favors "ask forgiveness, not permission" over "look before you leap". In this case, I'd just try constructing the `CaseStep` inside a `try` block, and then catch `KeyError` for the no-instruction warning.
s/Rather/Whether/
Can you align the value ? 

sorry about this detail, it is more about readability
Need to close the ```bash
Э, нее. С `protected` больше не работает.
Doesn't this need to be `{% if app.security.token %}`

I'm getting the following error message with an unauthenticated user:

> An exception has been thrown during the rendering of a template ("The security context contains no authentication token. One possible reason may be that there is no firewall configured for this URL.") in SonataAdminBundle::standard_layout.html.twig at line 91.
I prefer having this in the GitNotesPublisher class since the code that manipulates the git notes shouldn't need to have any understanding of what's in the note itself.
Per our conversation, I'll remove the deprecated annotation. At some point in the future when a multi-loader figures out the correct loader for you this could be removed.
Yah, Andrew got me on the right track.  Hoping it helps others doing similar tests.
Afraid not. For fake mode the config file path is $PATH_REDDWARF/etc/reddwarf/reddwarf.conf.test, while the rd_manager command uses the conf at $USERHOME/reddwarf.conf.
i think probably we have to distinguish between moving the actual node and updating its children. the moved node can indeed be renamed, and changes its parent. the children never need renaming and stay with their moved parent, they just need their path updated.
You can combine all those into one line.
is this really needed? Should always be true anyway and if it is empty the following for loop will not execute anything.
when  a user clicks on a corpus link it will now take them to the user page which knows how to load the corpus dashboard. if the user clicks on the corpus that they are currently on, this will result in a page load, unlike before.
I compared seq_type of 9,000 requests from an old dump to whats currently
there and they were translated over correctly.

On 19 September 2012 12:58, Sendu Bala <notifications@github.com> wrote:

> In sql/VRTrack_schema_20_21_22_23_24.sql:
>
> > @@ -0,0 +1,28 @@
> > +ALTER TABLE seq_request MODIFY seq_type ENUM(
>
> On 19 Sep 2012, at 12:00, andrewjpage <notifications@github.com> wrote:
> In sql/VRTrack_schema_20_21_22_23_24.sql: > @@ -0,0 +1,28 @@ > +ALTER TABLE
> seq_request MODIFY seq_type ENUM( I'm afraid I dont know enough about this,
> but eyeballing our databases the values look okay. I presume you havent
> noticed any issues with your databases either since updates 20-23 (written
> by vertres) also reordered the enum?
> I did a little test and it seems like MySQL automagically handles the
> change of order. At least, I hope my test was sufficient. I'm not aware of
> any issues that arose, but am also not sure if having the wrong seq_type
> would raise an error anywhere.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VertebrateResequencing/vr-codebase/pull/44/files#r1638772>.
>
>
For objects your keys do not require string syntax.
ie.
"customSpinner" should be written without double quotes.

Again, Javascript will still parse, _and_ work, but good practice and so that you know at an early stage the right way to program is to drop the double quotes.
Maybe a little bit conciser: "The API furthermore allows declaring and evaluating constraints on the parameters and return values of methods respectively constructors. We will discuss ..."
I've experienced problems with phantomjs if the response is not written immediately. Can you confirm you tested this and it works?
I think you can just use ```abort```
Why, this is a non breaking change?

-W

On Nov 6, 2012, at 17:32, Naveed Massjouni <notifications@github.com> wrote:

> In dist.ini:
> 
> > @@ -5,7 +5,7 @@ license = Perl_5
> >  copyright_holder = Crowdtilt, Inc.
> >  copyright_year   = 2012
> >  
> > -version = 0.0300
> > +version = 0.0301
> This should be 0.0400.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Si une phrase has_many translations
@translation = @coressponding_phrase.phrases.build()
This will leak, because you never release it.  Since you're going to add this to the view below, you don't need to retain this object.
This should be calling ``within``.
oh :| I stand corrected then
поставь ссылку на википедию
I think everything above this line was copied from the original fact and probably isn't meant to be in this file right?
I got it now, sry for the confusion
I'm somehow missing the situation where the link is executed within a program
The above set of lines are duplicated as in <i>JpaMessageHandlerParser</i>. These too can be moved to <i>JpaParserUtils</i>
Spaces after comma:
```javascript
$(this.dialogID).attr('style', $(this.dialogID).attr('style').replace(/max-height:[^;]+;/, ''));
```

but I am sure this is quivalent, but faster and easier-to-understand solution:
```javascript
$(this.dialogID).css('maxHeight', 'none');
```
It is irrelevant, It is our dev code.
No problem I will remove.
> el.appendChild(el);

Это вообще ПУШКА!
Use short variables, not single letter variables.  "auth" is fine.
Changed to for loop.
We could add one but here would not be the place.  I'll add a check to index.js
Good idea, I will change to lazy load

Sent from my BlackBerry device on the ROGERS network.

From: Jeffrey Heifetz
Sent: Saturday, 1 December, 2012 2:09 PM
To: blackberry-webworks/BB10-WebWorks-Framework; Rosa Tse
Reply To: blackberry-webworks/BB10-WebWorks-Framework
Subject: Re: [BB10-WebWorks-Framework] Implements blackberry.pim.contacts.invokeContactPicker() (#306)



In ext/pim.contacts/contactConsts.js:

> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingIcq] = "Icq";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingJabber] = "Jabber";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingMsLcs] = "MsLcs";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingSkype] = "Skype";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingYahooMessenger] = "YahooMessenger";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.InstantMessagingYahooMessengerJapan] = "YahooMessegerJapan";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.VideoChatBbPlaybook] = "BbPlaybook";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.SoundRingtone] = "ringtone";
> +subKindAttributeMap[ATTRIBUTE_SUBKIND.Personal] = "personal";
> +
> +module.exports = {
> +    ATTRIBUTE_KIND: ATTRIBUTE_KIND,
> +    ATTRIBUTE_SUBKIND: ATTRIBUTE_SUBKIND,
> +    kindAttributeMap: kindAttributeMap,
> +    subKindAttributeMap: subKindAttributeMap
> +};


If this file isn't exposed to developers, should we lazy load this map to improve intial load time?

\u2014
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/306/files#r2286163>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Ternary opportunity if you care for it.
is there any way you can assign them from the native values rather than hard coding them, my worry is that they will change and we will be out of sync with the values
nitpick - "should invoke the tasks.."
work = [(SendColor, (row, column, user_id)) for i, j in RandomRowColumnOrdering(ROWS, COLUMNS)]