labofsahil/github-event-dataset-2012 huggingface dataset:
four functions to complete the _underscore.js library:
sum: sum of numerical object elements
mean: aritmethic mean of numerical object elements
median: median (center element) of a sorted object
nrange: enhanced range function returning an array of the specified range

usage:
node.js 
require "underscore"
require "underscoreAddon"

in a html file:
<script src=".../underscore.js"></script>
<script src=".../underscoreAddon.js"></script>   

Note: make sure underscore is loaded before underscoreAddon.
Any plans to make this less hard-coded?
still - just keep it all, and then choose what you wanna use in default.prop

also, it wont work with the current kernel - as ours if full of samsung shit - and backporting just the android gadget driver doesnt work(me n angel both tried it) 

So restore this - we're going to need it anyway
I removed this helper entirely a while ago, please take a look on my fork for the updated code.
I'll merge this, for the WhenTestingTheClass class through :)
Why not just use asset_path('ckeditor')?
About haml: I think, it can be used only if every developer will agree to move to haml. If not, it better to stay with erb.

But maybe erb2haml can be useful as erb checking tool, because, actually, it breaks ror-e tests and site :) And it should not break anything in ideal situation.
# 成功!!! 

[解决方法参考位置](http://civilnet.cn/bbs/browse.php?topicno=75481&trackpoint=end)

    编辑D:\Git\etc\inputrc：
    改为：
    set output-meta on
    set convert-meta off

    在Bash提示符下输入：
    git config --global i18n.commitencoding utf-8
    git config --global i18n.logoutputencoding gbk
    注：设置commit提交时使用utf-8编码，可避免Linux服务器上乱码；同时设置在执行git log时将utf-8编码转换成gbk编码，以解决乱码问题。
    编辑D:\Git\etc\profile文件，添加如下一行：
    export LESSCHARSET=utf-8
    注：以使git log可以正常显示中文（需要配合：i18n.logoutputencoding gbk）。
no, not like that either. it should be half of the cpu speed (second column) for each frequency.
Added note!
Thanks @michaelklishin =)
pushed it in by mistake. my bad. got a the manifest almost tracked down with its resources
this is warren btw
I tried using this - It seems to show me a completely blank screen - I modified the old code to add your changes and the screen just goes blank. What am I missing
OK, ovo trebamo sa Rovom dogovoriti kako ćemo riješiti, jer očito mora biti negdje taj gid u configu.
PyCharm appears to have derped with the line endings...
@idciconsulting :  please read this http://sonata-project.org/bundles/admin/master/doc/reference/installation.html#id1
FM noise fixed by:

https://github.com/CyanogenMod/android_device_lge_p500/commit/e112a1094996ab8a00dbb70838a0e21a382b229c
https://github.com/CyanogenMod/android_device_lge_p500/commit/a67d22c2dd9b98c2f29f6da46e06f8074b87616c
https://github.com/CyanogenMod/android_device_lge_p500/commit/e831dddc70729c84f6ee935d48f20819cb0eae9d
> I wonder if that should be '\r?' to not break it for existing/older versions.

Yes, absolutely.  I forgot to check how recent that feature was.  I'll fix up the patch and resubmit.

Cheers,
Fitz
You would need to spell out the string inside the exception for that.
i am still getting errors building msm8660
http://pastebin.com/pf8cKV0s
just letting you know.
Я не понял. Що енто за херь.
Откуда у тредов возьмется свойство Num?
Вы хоть тестили ея?
Быстрый ответ сломан, tNum = undefined
<input id="thr_id" type="hidden" name="parent" value="0">
Am 01.01.2012 15:27, schrieb zachariasmaladroit:
> bei Ton=on stand wie geschrieben der genannte Wert (~ 6 Stunden),
>
> Idle war leer und nur Deep Idle belegt;
>
>
> jetzt hat "Idle" am meisten (486389 ms), Avg 2 ms
>
> Deep Idle (TOP=ON) 13375 ms
>
>
> bei Deep Idle (TOP=OFF) war bis jetzt noch nichts
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zachariasmaladroit/android_kernel_samsung_aries/commit/04f33dfc725d8ab999d0569c0428a97f71920cc4#commitcomment-830297
>    
ja, hab grad nochmal geschaut, das ändern der variablen hat tatsächlich 
zu falschem zählen geführt.

werde heut abend dann nochmal testen. muss jetzt erstmal wieder lernen
If the tree paths are optional, do we need to indicate if the loss map was produced from statistical (mean, quantile) hazard data? (I'm assuming that's what these tree paths indicate: hazard results.)
I'd rather see the code import the names it needs from optparse, or just use `optparse.make_option`.
well, even when "virtualenv_no_global" was only checking for the existence of a "no-global-site-packages.txt" in the right place, that's still pretty conclusive.   not sure really why I ever had both checks in there  :  )
The initializer seems like a better place for this logic. Is there a reason it's in the bind phase?
You didn't provide a replacement implementation, so I assume that means that the default object search covers these ok?
SYNHRONIZED!!!
Sorry for not reading the front matter (must have still slept this morning). Even so it is not immediately clear to me why this is a good idea. The rationale behind the previous implementation was that the conductor should better know when players are on their way out; if they leave without permission better notify everyone ASAP that the test is failing/failed.
As a compromise, I will remove the braces around ```ByteOrder```. ;-)
What does this test compared to NodeStartupSpec? Do we need both?
We'll have to carry this one forward as something we still want to fix.
`Caused by: java.lang.RuntimeException: Unable to find static field: parseInt in class java.lang.Integer`
You just need to call `_check_access()`, e.g. `_check_access('user_subscription_list', context, data_dict)`. Then you need to implement a `user_subscription_list()` auth function in `ckan/logic/auth/get.py` that returns either `return {'success': True}` or `return {'success': False, 'msg': _("...")}` depending on whether the user is allowed to update this subscription or not. Who should be allowed to update a subscription? I'm guessing just the user who the subscription belongs to.
Perhaps...
The reason I didn't was that I've seen these control flows change, sometimes drastically, overtime, which always trips up abstraction.
BLOCKER: Please pull this out into the config. Even if it's unlikely to change, we should have all of the config for the tasking in a single place so we can easily see in a single area how it's driven.
Fixed a ton of references. I originally did this because PyCharm flagged "== 0" as being able to be simplified. I've since changed PyCharm to accomodate my own preferences in this area.
Is this target binary-compatible with the other targets that generate linux-XXX binaries?  It's not strictly an issue with this patch, since this patch enables builds but does not bundle the resulting binaries, but it could lead to some confusion.
Actually I had more of a look. I think I'd need to add the right compilation flags in native/Makefile too, but should be able to mostly copy the linux ones. I'll have a go with that tomorrow.
sorry you're right, Id thought these were already wrapped for some reason
I'm running Linux with ALSA so I could perform some tests... But what's not entirely clear is: what's the issue then with ALSA? And does it only occur with this PR or also with mainline? Only thing I've seen with mainline is that XBMC sometimes hangs when restarting within the same X session of which I suspect it's caused by AE.
Thou art spaced correctly hence forth.
except VentureRole.DoesNotExist:
This test will never work.
commit的时候会记住是谁修改的，不要在代码里写这种注释
Lots of necessary cleanup, we had the logged_id? api, but weren't using it here.
That's true. Wouldn't 2 logical operations have been more reasonable before this pull request? I can to a pull request with code cleanups after we have finished this pull request.
Well, wouldn't that basically be saying "prefix every method possible"? The `CG` types have been available since Mac OS X 10.0, but Apple chose not to provide `NSValue` wrapper support for them.
So it doesn't overstep the scroller boundaries. If I've merged it right....
Style: two newlines between functions/methods.
The file itself is fine, just GitHub website has header `<meta charset='utf-8'>`, that's why it looks garbled. This applies to all other non-Unicode resources.
This method needs to be synchronized.
Why did you change this? I reverted it to fix the tests previously. I think I understand what you're doing here, but it seems more complicated and prone to false negatives.
enclose these imports in a try except, in case these underlying libraries are not available on the system. 

```
have_dcmstack = True
try:
    import dicom
    import dcmstack
    from dcmstack.dcmmeta import NiftiWrapper
except ImportError:
    have_dcmstack = False
```

this would also allow tests to be skipped if it requires the underlying library which is not available
Ahh!  Yes it is a documentation mistake.  I'll have a new patch set in a few minutes.

PS:  I'm struggling with the "make check-before-commit".  It seems that it hangs dues to matlab (I'll need to figure out again how to prevent this), and it is really noisy, such that I don't know what warnings I should pay attention to.  After running it, I don't know if it shows that I am good to go, or if there are issues that need addressing.

Hans


From: Chris Filo Gorgolewski <notifications@github.com<mailto:notifications@github.com>>
Reply-To: nipy/nipype <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Sunday, November 18, 2012 9:22 AM
To: nipy/nipype <nipype@noreply.github.com<mailto:nipype@noreply.github.com>>
Cc: Hans Johnson <hans.j.johnson@gmail.com<mailto:hans.j.johnson@gmail.com>>
Subject: Re: [nipype] Enh/update ants registration capabilities (#484)


In nipype/interfaces/ants/utils.py:

> +                            desc='image dimension (2 or 3)', position=1)
> +    out_postfix = traits.Str('_cmt', argstr='%s', usedefault=True, position=2,
> +                             desc=('Postfix that is prepended to all output '
> +                                   'files (default = _cmt)'))
> +    reference_image = File(argstr='-R %s', xor=['tightest_box'], position=3,
> +                                desc='reference image space that you wish to warp INTO')
> +    transformation_series = InputMultiPath(File(exists=True, copyfile=False), argstr='%s',
> +                             desc='transformation file(s) to be applied',
> +                             mandatory=True, copyfile=False)
> +    invert_affine = traits.List(traits.Int,
> +                    desc=('List of Affine transformations to invert. '
> +                          'E.g.: [1,4,5] inverts the 1st, 4th, and 5th Affines '
> +                          'found in transformation_series'))
> +
> +class ComposeMultiTransformOutputSpec(TraitedSpec):
> +    output_image = File(exists=True, desc='Warped image')


I'm just saying that the description of the output (and the name of it) suggest that it is a warped volume where as far as I understand it is a transformation (either a warp image or affine matrix). I guess this is just a copy/paste mistake.

—
Reply to this email directly or view it on GitHub<https://github.com/nipy/nipype/pull/484/files#r2161333>.



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________
Could we instead test this using a request spec inside of core?
But this will check the <code> Rails.logger.info "\n\n" </code>

But we can remove this.
Yeah, i see that now. Thanks for the clarification.
`object_id` potentially can be negative?
space after the `all?` after the `{`
And here goes another dependency for @drogus to take a look :smile:
This is part of the tests that I was a bit uncomfortable about..

In my first version I was only check that when loading values from cache no exception about missing class was raised.

and then @fxn pointed (rightfully) that it will be better to check that what I am reading from the cache is what I wrote.

so instead of:
```ruby
assert_nothing_raised { @cache.read('foo') }
```

I thought about doing:
```ruby
loaded = nil
assert_nothing_raised { loaded = @cache.read('foo')}
assert_kind_of E, loaded
```

And the it incarnated to this,but I guess that just check for values is better and letting exception to be thrown is more elegant.
It looks like there are tabs in here (instead of spaces). Please convert to use spaces.
No idea.  None of those xxx0 methods should be public; so let's not create needless future difficulties in the name of an unimportant consistency.
i think there's a negation missing somewhere
being new to the SciPy contribution process, I wouldn't be sure how to determine `X.Y.Z`. Should it just be the next version number? How can I know if it's maybe already too late for the next release?
should limit lines to 80 chars (pep8)
I may not have phrased that clearly. What I meant was have this line be an elif len(args) == 1, then have a new else block raise an error (in the case there are 0 or >2 args)
Particle and RigidBody are in their own modules and not a part of 'essential'
ahh, so step could be negative
Cool. If possible I'd really like to limit the scope of this PR. It has grown far beyond where I wanted it. I'd really like to be done with this soon.
I remember hearing something about that too but it doesn't make perfect sense to me. This example also gives some evidence against.

```
In [1]: [1,2,3] == [1,2,3]
Out[1]: True

In [2]: hash([1,2,3])
TypeError: unhashable type: 'list'
```

I suspect that if you define an eq then the default hash goes away so if you want one then you'll need to define it? maybe? not sure. My inclination would be to handle this issue separately and maybe ask on the mailing list.
I think in either case ```e``` should end up as a FiniteSet object. I don't think the  ordering of elements within a FiniteSet depend on how you construct it. You probably shouldn't depend on this ordering in any case.
Will do some searching.  Reduce may be the right way to handle sequences when we just want the raw gcd.  But in other situations, we want to know the coefficient vector that makes  a x + b y + c z == gcd([x,y,z]).   We can do this one recursively, but it's not a one-liner, as far as I can see.

There is also an approach using Gaussian elimination, but it works best with array operations.  It comes out clearer,  but I don't know if it's more efficient in terms of operation count.
Separate non-related issue, isn't it?
Ok will do and wil delete the .gitignore file from my repo
Shouldn't matter. The current requested URL comes from a `$_SERVER` key, so redirecting to that will always work.
Splitting a header out would definitely be more keeping with the usual C/C++ conventions. I'd still guard the `#include` of it with `#ifdef _WIN32`, though: Even though `[v]asprintf` isn't POSIX, it's available on every modern POSIX environment I've come across in practice, with its declaration made available (unsurprisingly) in "stdio.h". Including a duplicate declaration *should* be innocuous as long as it is truly identical, so I won't quibble too hard on the point.
Hier müsste der Text noch übersetzt werden. Ich habe mir gedacht, das wenn ich die .po und .mo files im Ordner languages/deutsch update und neu speichere würde es reichen für die Übersetzung. Dies ist leider nicht so.
Was muss man alles machen, damit die Übersetzung funktioniert?
Something like 5 times slower, but 10,000 calls takes 13 ms on my laptop, so this is no relevant.
I tend to prefer using the block as it keeps everything in context… however, if we are using this pattern elsewhere in Rebel then we may as well stick to it.
`free(buf.base)`? Maybe make the buffer static (if possible)?
There's a typo here. Are you sure this runs?
Since question doesn't have the project association, I guess I'll just call it "project"
Indeed - well spotted. This is cruft that should have got deleted in b74d21c4e. So I think we should remove it now.
They actually do run at the end of a scan - the event based wiring still exists for pair events. You'll only end up in this scenario if you schedule a report to trigger on an entity event.
This should *not* have a default.  It is a required configuration parameter.
I'd call that standard logging?
This spacing is inconsistent with that of the other doc blocks on this class' properties. Also, all others have periods but this one doesn't. In other words, this doc block is inconsistent with the others.
Why was this space added?
Is this line supposed to have a # at the start?
Should have fixed all now
Is this return olympus inheritance or something added in the refactored api?
Please refactor this code into a separate class, we should not be introducing large amounts of new global code. Even if we absolutely have to have a new top level file for this (I would much prefer it would be handled through index.php) the file should not do anything more than the necessary setup and call code stored in a class that can actually be tested.
Have you tried putting this in the markup and making the javascript generic?
I am going for just non-zero. Any reason for 3 vs 1?
spații după virgule și după :, probabil va fi nevoie să spargi linia.
Maybe you should change comment-style here.
Можно в одну строчку написать
return ($shows_limit === null) ||  (filter_var($shows_limit, FILTER_VALIDATE_INT) !== false && $shows_limit > 0);
indentation is still problematic in this file
Should be marked as steam only, since this config only works with the steam copy (for now)
nit: should be named "controller.dispense" to match other pharmacy names?
this is not code..
it just shows that what are the parameters(options, success ,response) used in callback function below..
I will add a note of it there
it's -> its

A lot of native English speakers mess this up too. [This might help.](http://garyes.stormloader.com/its.html)
Shouldn't ``NullType(..)()`` return an instance of ``NullVariable``?
Yes, this comment should be removed as the bug is fixed already.
without a venture
Then save it when it is created.
This was actually done, though the format is a bit different.  The ?COUNTER macro takes the type and data point and expands it to a tuple of {riak_kv, node(), Type :: 'get' | 'put', DataPoint :: 'in_progess' | 'errors'}.  I've missed the fsm bit obviously, so I can add that in if you think it's needed.
I feel like we shouldn't be quiet about invalid exchanges in
`trigger_exchange`.  I assume that this can only happen when a user is
triggering exchange manually.  In that case it would be helpful to log
something to let the user know it's invalid.  Also, it would be a good
safeguard just in case the situation ever arises where invalid
exchanges are trigger during automatic mode.
Since the only way to get here is if `self.skip_token is True`, this whole `elif` seems unnecessary.
The order of the `then( next, next )` and the `done( deferred.resolve )` shouldn't make any difference... `then` is not `pipe`, unless you've replaced jQuery.Deferred...
I guess we could also fetch min and max volume in _setup_mixer instead of in each get and set volume call?
Don't need to `mktemp`, this is taken care of by the installer.
Also, if you can always set a `data-path` attribute (even for `/`) you don’t need to check for undefined or `’’` in the javascript.
We might want to log these somewhere.
hier ist das file .xy
Please be explicit with the imports (i.e., `from r2.controllers.validator import Validator`)
I tried removing the call to `_nons()` and still passed all tests.
What about removing it completely of figuring out a test case that justifies its use?
Nvm, `should_receive`
I wasn't sure if a case like a maneuver-only recovery load would be one 
where having the warning about the file and a warning on the ERs about < 3 
bright stars would help (thinking about such a case as time critical and 
likely to have wrong history...).
But it's not a getter.  getFoo() is a known pattern of instance accessor methods.  Hrm.  Must find better name.
newline after `*/` :D
I don't have evidence one way or the other, but it seems like there would be no to few cases where a property exists with an unused change event. The only thing I can think of is when you generated an accessor and then never use it. But that's not something that happens on a regular basis.

All that to say, I think the tradeoff of the extra objects vs. the performance benefit of fewer function calls, we should prefer the latter; generate everything in the constructor.
it's not a rails project. :(
This sentence sounds wired to me. How about: "Um die Live-Vorschau zu verwenden, muss Chrome [...]."
REMINDER: need to clean up these default context menu definitions.
Calling FILE_RENAME synchronously works fine here since the item is already visible in the tree. However, if the selected item was _not_ already visible in the tree, this command would complete asynchronously, and you would need to wait before continuing on with the tests. It would be nice to add a comment explaining this just in case this test gets copied/pasted into a new test.
This may be misleading since we only care about the current platform. So it should be removed.
is identify[1] supposed to be a dict? cuz it's a string.
same as above. Compute the condtion that is true.
Good idea this about SEO. But will our portal be accessible from search engines? How Facebook managed to get user profiles into the Google, but when you visit the page not logged in you have just one empty login page?
It feels weird to say, "If you for some reason have a commandline but not node".... but maybe that's just me
Looks like a double space here.
I don't understand this, what about time===0, which will trigger this?  Also, why are you sometimes returning a number, sometimes false?  You should only return one type, always number.  Use 0 instead of false.
get rid of this whitespace
I'm guessing this doesn't pluralize octopus, assuming I'm reading this code right.
测试过了么？为什么 demo 还是 php5.3+ 风格的呢？
Ok, than it is fine. I wasn't 100% sure about that.
shouldn't you check config is not undefined?
清理shcyc->pool?
remove the comment!
Ditto for this test: it should be broken up into two tests and it's clearer to create the speaker and work on that specific speaker rather than do a for loop which suggests there are other speakers around which there shouldn't be.
May "Galaxy Tab 10.1 (3G)" will be enough...
Gotcha, makes sense.  Wanted to make sure :)

Thanks!

On Tue, Aug 21, 2012 at 11:33 AM, Miroslav Suchý
<notifications@github.com>wrote:

> In src/app/controllers/api/role_ldap_groups_controller.rb:
>
> > @@ -28,7 +28,7 @@ def rules
> >    end
> >
> >    api :POST, "/roles/:role_id/ldap_groups", "Add group to list of LDAP groups associated with the role"
> > -  param :name, String, "name of the LDAP group"
> > +  param :name, String, :desc => "name of the LDAP group"
>
> As stated in commit description - it does not build on Fedora 17 as ruby
> 1.9.1 has problems with this syntax.
> And in build time,this is executed to generate API documentation.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/496/files#r1425579>.
>
>
@xsuchy, For each of the commands that include product 'name', the user may now use product name, label or id.  The options are defined as mutually exclusive, so if the user provides more than one of them, they will get an error.  As a result, the ordering here, will not really matter since only one can be provided.  For each command impacted, the help has also been updated, where appropriate, to declare that product name, label or id is required.
Good call, on it.
@ariya wrote a great article some time ago about Boolean Traps: http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html

I do think that having the second boolean variable makes the meaning of the first "empty".

What about `bytesToRead = -1` as default value of the method, where `-1` will be treated as `READ ALL THE THINGS`? This way you don't need any special `QVariant` handling neither.
And that is, why I vote for removing it :).
@gavinandresen Would you remove that line from your patch then?
Maybe just
```#define AI_ADDRCONFIG 0```
?
I tried to use the exact same code that was used above in the file to get data for the Options Dialog.
Note for future: Argument check should reside in bin/genejs and actual integrity of required files of the language have be controlled geneJS.cli.process.
can you move keyCode 191 to a named key in the `Keys` literal on line #26
ui.watchMessageScroll([id], room)
Why not just delete this line?
Missing line break and also `\`.
Don't all annotations using Doctrine engine need to extend this class at some point? Is there a common interface? The previous comment leads to making that mistake "The Annotation".
and btw, the phpdoc and the code are not in sync as you renamed it.
all these link_to items should probably be turned into a template at some point to reduce duplication.
open can be removed...
'corp': {
        'id': ...
        'name': ...
    }
This binds a concrete value, so shouldn't it be in the concrete interface?
fair enough - I will leave it as the cleaner one-liner, and hope nobody tries to debug prompts by printing things.
For Python 3 compatibility, this should be `from io import BytesIO`. `io` is available in all the Python versions IPython supports.
Good eye.  I had to change this later after finding out StatisticSet and Value were exclusive, something not marked in AWS docs.
same as above, its preferred to just override than to have internal conditionals and null returns.
Just makin' sure that you verified this number against Core Git and not your own implementation. :)
Magic numbers make me sad :(, even though I know they are used elsewhere.
nit: add a blank before the opening bracket.
Same as above. Please remove the screenshot file.
Ordering dependency again.
Why doesn't this have a 'T'?
This one and the test above it are exactly the same?
Maybe call it 'recovery_token' instead of 'token_obj'
в чому логіка? при апдейті сутності час апдейту і так зміниться
As I was saying above, `preg_replace` does such check internally and returns `null` if passed argument is an invalid UTF-8 string. So probably this check `null !== $result = @preg_replace(` is enough. What do you think about it?
typo (Splitts)
This code should be removed.
@Tobion I don't get why we need to do this, could you briefly explain (/ add tests) ?
added if-windows check
i dunno. was super easy to do in javascript. not a big deal. if you want to submit a jquery version go ahead. i don't see any reason to change working code though
囧，这儿前面五行还是保留吧，后面的字号设置和间隔控制删掉。
Good point. Edit pending.
Yeah, I'm mystified as to why the try-catch doesn't pick it up. It almost
seems like it's a bug in Safari -- maybe there's some subtle difference in
error handling between Safari's Nitro engine and Node.JS / Chrome's V8
engine. (Also, the try-catch catches the error as expected in Firefox).

On Sat, Sep 1, 2012 at 7:15 AM, Robert Kieffer <notifications@github.com>wrote:

> In uuid.js:
>
> > @@ -41,12 +41,17 @@
> >
> >    // Node.js crypto-based RNG - http://nodejs.org/docs/v0.6.2/api/crypto.html
> >    // Node.js only, moderately fast, high quality
> > -  try {
> > -    var _rb = require('crypto').randomBytes;
> > -    nodeRNG = _rb && function() {
> > -      return _rb(16);
> > -    };
> > -  } catch (e) {}
> > +  //
> > +  // This block crashes when loaded as an AMD in Safari, so wrap it in a
>
> Really? The try-catch doesn't prevent the crash?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/broofa/node-uuid/pull/48/files#r1512287>.
>
>
Error on Eclipse :/

Add SuppressWarnings or change "ArrayList<String> langFiles = new ArrayList();" to "ArrayList<String> langFiles = new ArrayList<String>;
why not ``if self.can_change``?
`value !== void 0 || value !== null` can be changed to simply `value != null`
I guess my point is that if you just keep drop_handlers, you can do both: keep the defaults or not from the plugin. It seems less redundant and cleaner to me, but I understand that the tab drop is something that you always need in there (what would happen if you remove it)?
Why do you need to add the deployment root to the resource roots list? (I know it is not part of this PR, but I should have questioned this before). 

This may cause problems as I think we have a fair bit of code that assumes the deployment root is not in this list (e.g. the change you made above to the index processor).

If at all possible I would rather change the code that consumes the RESOURCE_ROOTS list to also check the deployment root.
While not actually the point of the PR, the comment is wrong :)  A better comment would be:

    Generates a CSRF token and adds it to the list in the session. Only the most recent five tokens are stored.
On Mon, 19 Nov 2012, Rob Allen wrote:

> > @@ -0,0 +1,65 @@
> > +var map;
> > +var marker;
> > +
> > +function load_map() {
> > +	var lat = $('#map_latitude').val();
> > +	var lon = $('#map_longitude').val();
> > +	var zoomLevel = parseInt($('#map_zoom').val());
> > +
> > +    map = new L.Map('map_canvas', {zoomControl: true});
> > +    
> > +    var osmUrl = 'http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png',
> > +        osmAttribution = 'Map data &copy; 2012 <a href="http://openstreetmap.org">OpenStreetMap</a> contributors',
> 
> Do we need to remember to change this to the correct year every January 1st ?

I've fixed that now in my PR.

cheers,
Derick
`if ( this.open ) {`
Could we just have a `role` option and infer the item roles from that? There have been requests for a `role` option on dialog as well, so that the type of dialog can be defined.
вроде разобрался с логикой.
уже почти работает, с топиком всё ок, коммент что-то не фурычит думаю завтра добью.

кстати патч удаляющий Template скоро войдёт в основную ветку?
What happened here? Line ending issues?
This one is not anonynous ;)
used the .response to mimic an API response, so it'll be easier to work with both endpoints (local and API). but you're right- it's a but confusing. changed the object name to 'data', so now it's data.response.
Ups! Actually that's a leftover that I should have deleted. Will fix it
if (l10nArgs) {
       try {
       } catch(e) {
       }
      }

Also this console.warn make me crazy, there is tons of untranslated strings that pollute the console. Anything we an do about that?
can you add the use of strick mode, so the linter can check propertly.

Thanks!
Sorry, I've included some "comments" out of date. Next Pull will move 'mozvisibilitychange' to MessageManager handler
Fair point :)
Can you just add a comment? Thanks!
What about a icc_utils.js to not duplicate this code?
how stupid i can be!
`enabled`.
Comment doesn't make sense and is probably missing a word or two :)
Why is that line needed ? Does the default value specified in line #11 not work ?
I'd rather see this as:

isNumber(arg)

and:

def isNumber(arg : String) : Boolean = {
  try {
    arg.toDouble
    true
  }
  catch {
    case e : Throwable => false
  }
}

Or another more elegant function if one exists.  The advantage of the above is that it will accept many different ways of writing numbers, and it is easier to explain: if the string has no dashes, or is a number, it is an argument, else it is a new key.
Remove the extra space before "path".
kcheckkbox-all needs to be kcheckbox-all
This doesn't assert what it claims to.
Might be worth commenting this to explain that this only needs to cover formats that are wired up in the frontend.
Keep in mind that .gitignore just keeps stuff from getting picked up by `git status` or your gui tool.  You can still explicitly add anything ignored here into git by using `git add`.
According to this diff file, a extra "_" here? (do you mean "_close_mac_pool"?)
Why it calls CCFileUtilsWin32 on win32? Then can not use CCFileUtils in the codes, should use different class names on different platforms?
delete-file-recursively doesn't exist beyond the old monolithic clojure.contrib (as far as I can tell).  As you stated, this is a copy/paste from that old lib.  I'll do further research to see if I can find its new home.
hmm...maxlength seems like the type of thing that should be "actively" validated, even before a field is marked invalid, using the activeClassSelector seemed like the natural solution for doing this.   Thoughts?

Assuming that it should be validated even before marked invalid another option could be to create a new selector type, similar to kbSelector or mSelector, or yet another way could be to just switch the keyup eventFlag to true when validating the maxlength attribute on textareas
this has to return a github status code, so either pending/building/failure/success
actually it's a sortof generic filesize function that i copied from the interwebs because the filesize widget in jinja2 appears to be busted.  it can handle negative file sizes, which is maybe handy in some circumstances, maybe when you're talking about size diffs?
I think, rather than adding a comment, it might pay to make this more obvious...

bool isAllowed = true;

if (!IS_LOCAL(user) && !IS_OPER(user))
    isAllowed = false;

... etc

do you mind doing that, please?
why do you depend on the database directly, not on the API (messages)?
Sure. I struggle with this, actually, and think we lack a good term for these parts of your add-on. "Your add-on's modules" is technically correct, but I think will be confusing to a lot of developers who only have a main.js, and aren't thinking of their add-on as being composed of modules.
I think it would be a lot easier to read if it was just:

```js
return !!tab.linkedBrowser || !!getWindowHoldingTab(tab)
```
@lloyd - is the reverification email supposed to be the same as the "add email to account" email?  If it is, I should take out the "confirm" page.
Consider documenting the shape of this callback, where it is originally declared, since it has an optional parameter.

Great stuff!
these lines can be deleted.
This is same as line 103?
Okay dude - made some changes to both messages, can you take another look @pvande ?
Sorry, my spec was not DRY :<
I use `@method` in `shared/index.rb`.
you can replace this guard with `encoding.isBlank`
Here where we determine the test runner (whether to use `rspec`, etc. we are setting the `--no-color` flag as necessary.
I believe this lock is needed because the qutex could be created in one thread and then locked in another, without the lock barrier the second thread might see the uninitialized value of owner. helgrind backs me up on this and issues a warning without the lock.
use this.options.minLength
Because you're calling return from inside a conditional, you can omit the else statement:
```
if (null === $name) {
    return $this->queryParams;
}
return $this->queryParams->get($name, $default);
```

This is true in the other implementations following as well.
This will be filled in by a later commit by beta4, its a placeholder
add a space between foreach and openening parenthesis
I'd say this should be "integer", as we use full type names everywhere.
The race condition is a non issue because in any case, we make sure we commit changes to DB first before calling NotifyIndexingService()
Ha! Wow it must have been late when I did that one...
Entities should be able to have the hunger concept.
$security should be $rbac or $rbacService.
You should avoid doing this and instead pass the arguments required directly to your services. Creating a hard-dependency on the service manager makes your modules less extendable.
->

```js
'setActiveRoute': function(route) {
    $('#filters a').removeClass('selected').filter('[href="#/' + route + '"]').addClass('selected');
},
```
This is prone to race conditions if 2 people are creating schemes at the same time.  It would be better to set this in a before_validation callback on the model.
This isn't a *different* command, so let's just make a note about the '-v' flag rather than a whole new block.
why blank? blank year?
Thanks! I will do it this way.
I thought I had documented that one, maybe didn't make it into the last commit. I'll wait and push this with the updated HISTORY.MD, and the unit tests for this.

        /// <summary>
        /// Return the value of a single property.
        /// </summary>
        /// <param name="propertyName">property name</param>
        /// <param name="defaultValue">Default value returned if property does not exist</param>
        /// <typeparam name="R">property value type</typeparam>
        /// <returns>The value of a single property of type R.</returns>

-----Original Message-----
From: Daniel Doubrovkine (dB.) [mailto:reply@reply.github.com] 
Sent: Saturday, June 30, 2012 5:19 AM
To: mikewalker
Subject: Re: [vmwaretasks] Added some code to deal with deprecated constants in VixCom 1.11 (#3)

> @@ -84,6 +85,27 @@ public R GetProperty<R>(int propertyId)
>              object[] properties = { propertyId };
>              return (R)GetProperties(properties)[0];
>          }
> +              
> +        /// <summary>
> +        /// Return the value of a single property.
> +        /// </summary>
> +        /// <param name="propertyName">property name</param>
> +        /// <param name="defaultValue"></param>

Please do document this one. We generate documentation from the library. Maybe the description can say something to the fact that it will return the default property if ...

---
Reply to this email directly or view it on GitHub:
https://github.com/dblock/vmwaretasks/pull/3/files#r1080555
@harjis Miksi tää haara on siirretty omaan iffiin? Ei pitäis. Kuuluis olla just niin kuin se oli.
Should we give access to the prototype like this or the chidren object ?
Yeah, please ignore me. Just do:

    Code.eval(File.read!(user_config), file: user_config)

So we get nice stacktraces.
Hahaha. Just in time for the only liquor bottled sized to make it through the holidays: http://www.zazzle.com/disfunctional_family_humor_greeting_card-137875698306693845
Settings:
`TAG_URL = "tags/{slug}"`

`value[:value.find('{slug}') + 6]`  = `tags/{slug}`

`value.find('{slug}')` = `5` so without the `+ 6` it would yield:

`value[:value.find('{slug}')]`  = `tags/` and the slug would forever be left off

Since `{slug}` is and always will be 6 characters, `+ 6` includes it.


```
t a g s / { s l u g }
1 2 3 4 5 6 7 8 9 1011
```

The only other way I know to do it is:

`return unicode(''.join(value.rpartition('{slug}')[:-1]).format(**self.as_dict())`

So that removes the `+ 6` if that is the confusing part
and set CPLEX_HOME
Then it should be something like "EasyBuild support for Pasha, implemented as an easyblock" or something like that.
"""Custom sanity check for Pasha"""
what is this file for ?
What is this pattern? Can we use `parse_url()` instead?
You could drop the "the" and the sentence would still make sense and fit in under 80 chars.

Otherwise, it looks better to do

    """
    Add a click to this instance and the associated ClickStats object.
    """

Even though I imagine some lamer docstring parser things won't like it.
I don't think `null=True` even makes sense here. `OneToOneField`s should always exist. It can RETURN `None`, but you need to run a (data) migration that creates an `Address` for each user to stop getting errors regarding this. No `UserProfile` should lack an `Address`.
When you change to camelCase, make sure to change this guy.
This is the new preferred way to determine a time-series based grid domain set.
What's the reason for pulling out `xmlschema`?
>There is, however, a slightly more elegant solution than what you have in the translator right now. The href property (but not attribute) on an a tag is always a fully qualified URI

Fixed

>We could do this, but neither of those functions exist in the connector. This would need to happen in _itemDone.

I was considering this further, and I'm not sure how well this would work out if we start doing cross-domain scraping (i.e. search results), but I suppose in those cases the URLs could still be resolved manually. Either way, the anchor href property I think might be sufficient for most cases.
Changed to AnyRef
I'd probably get rid of the purple at this step.
Can you test null here, looking above I think this can get called with null for old clients not reporting a fact, can't immediately see where it would be handled in the code.
You could use a triple-quoted string here to obviate the need for backslashes. :)
While we clearly prefer PHP 5 constructors: *__construct* over the old PHP 4 one, we have to take care about a possible BC break:

    class myAudit extends eZAudit {
        public function myAudit() {
            // personal stuff here
            // [...]
            // Calling the parent would break:
            parent::eZAudit();
        }
    }

Not that it should be corrected, but just a reminder for the person going to merge this PR that it should be taken into account (doc?).

I am personally for a global change with a single "upgrade" doc entry about this rather than just having some classes changed that way and not the others.
I'm not sure, you're sure there needs to be a line change on 6?
do you need to run the replace() here too? Looks like you're already doing that on lines 27 and 16.
0 можно не указывать
Does this have any effect, or should we just do nothing here for Django 1.5?
Lol
On Jun 11, 2012 8:13 PM, "Jean-Philippe Boily" <
reply@reply.github.com>
wrote:

> > @@ -17,7 +17,7 @@
> >        <%= yield %>
> >      </div>
> >
> > -    <aside class="sidebar three columns">
> > +    <aside class="sidebar four columns">
>
> oh, nevermind.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jipiboily/monologue/pull/83/files#r964140
>
We can't unmixin extensions, so we need a clean class for each `config.rb` change.
This is a string, so it should have double quotes.
having the name CollectionSearchResultList.SearchResultItem instead of CollectionSearchResultList.CollectionsSearchResultItem did not mean there was any less access to the unique _name_locator
Please use `self.timeout` rather than a hard coded wait timeout.
Please also add a global docstring for this module.
One more comment!
actually, using @ didn't work because `_.each' was messing up the scope (remember i asked you about that earlier and we couldn't find a good work around). i think this works; this is what i usually do in jquery and i've seen it used a lot actually.
No need to output anything if sending was successful. Raise exceptions otherwise.
`(pos? limit)`
That's not too important though. Mostly just for future reference.
If you have your logging set to TRACE it would. IIRC the settings are:
 * local development: DEBUG
 * app servers/production: INFO
There is now a TempFile utility on which you can call .remove() to remove it and .update() to refresh the filesize (in case you changed it)
This should not have been changed -- `RAH.map_center` is set to the requesting user's location if it's known; the map's center and zoom level are then set accordingly.  That behavior should remain as-is.
Ik snap niet helemaal wat deze methode doet. Het verandert de acceleratie?
Ik denk dat de naam een beetje verkeerd is. `player` is de speler. De speler controlled een caracter, waar dit de space commander is ofzo.
Я же вас не ругаю! Вы учитесь, набираетесь опыта. И я счел полезным вам это объяснить. Чем раньше вы начнете применять накопленные знания как бы для "практики" (не могу подобрать слово, но, в общем-то, имею в виду, что с самого начала стараюсь вывести на понимание своего кода, чтобы и дальше писать профессионально в силу своих знаний). 

Вы получаете знания как из лекций, так и из комментариев, и это для вас весьма полезно. 

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Смотрите какая фишка - вы объявили свойство @property NSMutableArray *dna. Это эквивалентно записи @property (assign, readwrite) *dna. То есть, ваше свойство позволяет менять массив извне, а значит, нужно быть готовым, что массивы могут быть разной длины. Следовательно, при данном подходе, мало того, что нужно делать цикл по наименьшему количеству (в противном случае будет ошибка доступа), но и не забывать о разнице в количестве - она должна быть заложена в результат.
Так не будет работать, x в нашем случае это не количество элементов, которые должны мутировать, а процент от количества этих элементов.
Also, for OS projects I really like having a fileoverview that says what the class does, what it should be used for, and maybe a brief example.  That might be too much work though.
что-то меня смущает. Почему не has_and_belongs_to_many? все равно users_roles не сможет стать полноценной моделью

и второе, у вашего пользователя может быть сразу несколько ролей? а зачем?
Take care. Fieldset should be within <form>
Have moved the creation of the gherkin formatter back into the wrapper constructor.  I think I was taking dependency injection a step too far...

https://github.com/worldofchris/cucumber-js/commit/243bce8727edb760a43bc47b1bb1293544b3a9ec

On 24 Jul 2012, at 23:00, Julien Biezemans wrote:

>> @@ -15,6 +15,11 @@ var Configuration = function(argv) {
>>       case Configuration.PRETTY_FORMAT_NAME:
>>         formatter = Cucumber.Listener.PrettyFormatter();
>>         break;
>> +      case Configuration.JSON_FORMAT_NAME:
>> +        var JSONFormatter = require('gherkin/lib/gherkin/formatter/json_formatter');
>> +        var jsonFormatter = new JSONFormatter(process.stdout);
>> +        formatter = Cucumber.Listener.JsonFormatterWrapper(jsonFormatter);
> 
> The creation of the gherkin formatter should be handled by the JsonFormatter constructor. This logic is part of its internal "wrapping deal" that should not surface. The instantiation of the JsonFormatter would become as painless as it is for the other formatters.
> 
> When running Cucumber in a browser environment, the formatter has to be instantiated, there is no configuration management for that matter. The simplest their constructors, the better!
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cucumber/cucumber-js/pull/79/files#r1230267
Ooh, nice catch. :)
Yes, absolutely.  You want zero code duplication not only for readability
but for easier maintenance.  JIT will sometimes inline the method call and
when it doesn't you will get better L1  instruction cache utilization.
On Jun 27, 2012 3:53 PM, "Steve Dougherty" <
reply@reply.github.com>
wrote:

> > +                             }
> > +                     }
> > +             }
> > +             return false;
> > +     }
> > +
> > +     /**
> > +      * @param type probe result type requested.
> > +      * @param candidate node to filter for response from.
> > +      * @param uid probe request uid, also to be used in any result.
> > +      * @param htl current probe HTL; used to calculate timeout.
> > +      * @return filter for the requested result type, probe error, and
> probe refusal.
> > +      */
> > +     private MessageFilter createResponseFilter(Type type, PeerNode
> candidate, long uid, byte htl) {
> > +             final int timeout = (htl - 1) * TIMEOUT_PER_HTL +
> TIMEOUT_HTL1;
> > +             final MessageFilter filter =
> MessageFilter.create().setSource(candidate).setField(DMT.UID,
> uid).setTimeout(timeout);
>
> I made [this](
> https://github.com/Thynix/fred-staging/commit/a76e79fa060a9e69a7fd6623d2391d489eed375a)
> but I'm not so sure it's worthwhile. Do you think it's worth the extra
> method calls for better readability?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/freenet/fred-staging/pull/94/files#r1063140
>
It's probably a bad idea to schedule this on the current queue. I think we should pick a global concurrent queue, since the scheduler of the resulting signal isn't defined anyways.
I've addressed those issues. The code now checks whether SB-EXT:EXIT exists, and if not, it will fall back to the older SB-EXT:QUIT.
I think there is a good opportunity here to break out this action into smaller pieces.
@cspurk Thanks, I think it is solved in the next version.