labofsahil/github-event-dataset-2012 huggingface dataset:
What exactly is left to do? You did implement the method so why didn't you remove the TODO comment? 

The same comment applies in other places.
This should use `trigger('start')` and `trigger('stop')` instead of calling `start_func()` and `stop_func()` directly so listeners can intercept.
I'll install magldr on my phone and see if it works on my kernel.
There's another place where the "Multiple X are not allowed" exception is raised - this one should be changed as well.
* Set the affinity of the calling thread.                               

You wrote this function...
That's just old stuff showing up in a nasty rebase
Ich hatte gehofft du würdest das machen :-D
Ah that makes more sense. 

Will change that.
Наконец - то от мусора избавился!
typo: detech -> detect
crash if arr is 0

why not doing this->LabelArray->DeepCopy(arr); ?

Mention in function doc that the array is deep copied.

should call this->Modified();

Why not creating the LabelArray once in the multivolumenode constructor instead ? (this would simplify the setlabelarray code)
btw, it's not a "bug," it's a feature of JavaScript and many other languages and it works just as well for different situations. See  http://en.wikipedia.org/wiki/Modulo_operation#Remainder_calculation_for_the_modulo_operation
The only reason this was possible is because of the ending html comments after the closing div tags. How else do you find the right closing tag to replace?
This is a comment on a commit
Since you are expecting the "status" to be passed as argument, it means that this function doesn't always return "UP" vds. So the function name should be something like *GetVdsByStatus*
Thing is, in French "navigate" is "naviguer", but on the other hand "language" is "langage" (there are hundreds of other examples) ... this is soooo confusing !!! Now even in French sometimes I don't know how to write words ...
![where did you guys learn to make memes the toilet store](http://i.qkme.me/363mqv.jpg)

You failed with „The Most Interesting Man In The World“
Is it reasonable to have lots of tabs sets, or is this expected to be unique per client?  Does Fennec have UI for managing tab sets?
As long as a device's vendor has stabilized and you're only building for
one target, incremental builds should be fine (besides the obvious
build.prop issue)
On Feb 18, 2012 4:57 PM, "Justin White" <
reply@reply.github.com>
wrote:

> Good to know. I do incremental builds for myself because my little VM takes
> quite a while to do a fresh build.
> On Feb 18, 2012 5:55 PM, "Keyan Mobli" <
> reply@reply.github.com>
> wrote:
>
> > All nightlies are clobber builds meaning there is no build.prop there to
> > begin with.
> > On Feb 18, 2012 4:52 PM, "Justin White" <
> > reply@reply.github.com>
> > wrote:
> >
> > > This is very much what I had in mind with my Build Date addition to the
> > > Device Info screen. Will be good to keep the time info out of
> cm.version,
> > > though.
> > > Will this change cause the datestamp to be updated on every build, or
> > only
> > > when build.prop is first created? One issue with my mod is that if
> you're
> > > not doing a fresh build, you must remove
> > > out/target/product/*/system/build.prop by hand so it will be recreated
> > and
> > > have a current datestamp.
> > >
> > > ---
> > > Reply to this email directly or view it on GitHub:
> > >
> > >
> >
> https://github.com/CyanogenMod/android_vendor_cm/commit/bc1f988afaea186c5ad508fff550189d98698bbb#commitcomment-981759
> > >
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/CyanogenMod/android_vendor_cm/commit/bc1f988afaea186c5ad508fff550189d98698bbb#commitcomment-981762
> >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/CyanogenMod/android_vendor_cm/commit/bc1f988afaea186c5ad508fff550189d98698bbb#commitcomment-981764
>
its 433 and no its still in development.
Block was duplicated a few lines down
давайте не использовать однобуквенных переменных, numRows, numColumns
Yeah, I’ll add some as I go through all the functionality one last time. First I want to get the design stuff finished.
`ObjectManager::getClassMetadata()` chains to `ClassMetadataFactory::getMetadataFor()`, which internally caches the metadata instance by class name. I think the code you have above is fine.
The assert should be:
assertThat(response, containsString("[ 1, 2, 3 ]"));

this produces much nicer error messages
Who should be able to use this view? A regular user will need to have view permission on Session in order for this not to throw a KeyError exception below.
If it's only the number of values in the parcel (5 instead of 4), build libril with BOARD_USE_NEW_LIBRIL_HTC instead of using the prop. That'll solve it.
IIRC, I made that change because it seemed that other places were using
the TII date formatting, and as a result this triggered an unnecessary
call to TII.  Bit hazy I'm afraid.


On Tue, 2012-02-28 at 04:17 -0800, Matt Gibson wrote:
> Hi Peter
> 
> What was the logic behind this change? The dtstart thing gets used on line 931 of lib.php like this:
> if (!empty($dtstart) && $dtstart->value > time()) {
> which I think won't work with a value like 2012-01-13%2011%3A13%3A14
> 
> It seems like the stored value for dtstart is not used for anything else, but does it get resent to turnitin any time?
> 
> I'm asking because I found an error caused by a mixture of timestamps and url_encoded dates in the config table and I need to decide on one or the other for a fix.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mattgibson/moodle-plagiarism_turnitin/commit/fe1fdfec113815820bc174ae6b8867efc9a73c2f#commitcomment-1020443
81KB is way too big. The last few themes I've downloaded from ThemeRoller (with 3 swatches) has 19KB minified CSS files. 

3 swatches is enough to satisfy jQuery Mobile default data-theme behaviors.

To clarify, this commit restored the comments that had already been in jQuery Mobile's CSS (they were accidentally left out). The comments are crucial for ThemeRoller's parsing. The size of the CSS has essentially remained the same as far as I have seen.
Ignore the first 3 commits
Sorry , but what do these changes do ?
the strings and preference_headers are mostly just converting tabs to whitespace
Also just add the key loading code to the ssh_helper.rb
They are actually internal (numeric) Atlas gene ids; perhaps rename this variable to geneIds ?
Ditto.

As far as I can see, you have some changes only in the `setUp` method.
it would be nice to see the tests confirm the exptected notifications
3.3 fails on this line as well, it doesn't have non_hierarchical either.
Your indenting is messed up here.  Make sure you are not using tabs as well.  Please fix this up so each sub-block is indented 4 spaces from it's parent block.
Certainly. Will do.
we don't have properties for the versions in the parent pom?
Turns out you can, see  	c6e84ff
yes, that's good point, even though graceful shutdown should trigger normal Terminated message it should not hurt to publish `AddressTerminated` when `MemberRemoved`
Do you mean `MemberExited`, and in that case why that, and not `MemberRemoved`?
(or what was the conclusion from the convention of `private[this] val` vs. leading underscore again?)
I see, but I don't think there is a good reason for it. The other properties are not BeanProperty. Can't be very important to have `getCause` for this API.
It's one of those horribly undocumented things :/

I think "isStateTimerActive" is a good name for a Yes/No question :-)
this `if-else` has somewhat misleading formatting
I think it is important that we reiterate that the EventBus is not clustered, so that deadLetters will be the ones that are known to be dead locally.
I created a ticket to do that automatically
Why is the register sent in preStart?
Can't it just do this in the constructor: camel.supervisor ! Register(self, endpointUri) ?
Wasn't there a todo to make this ocnfigurable?
Session will be problematic unless it will play well with the existing Session model class that is more or less implicit.  And I agree with # 4 and that it needs a better home.
As we discussed, this is the controller impact, but this could be moved upstream if necessary.  Really, all you need to tell this phase is what attribute you want it to provide the pre-rendered data on: :text => currently, :json as above, and :xml could be arranged to serialize from the same objects as json.  So could Html, but it isn't clear why you would want to.
```sigma : float```, and elsewhere
This needs to be re-worked. It looks like some stuff (peaks and qa and gfa, ...) are being cached when odf is called. I don't believe this is the right place for that because it means that the peaks of the odf are computed every time an odf is evaluated. It also means the cache is updated every time odf is called, and the values in the cache depend on the sphere used in the most recent call to `fit.odf`. For example if I use a sphere with 1 point, to do non-linear peak finding for example, the cache values will be set to garbage afterwards. Also there is a lot of code duplication here, we should figure out a way to do this (maybe in a parent class somewhere) so that all the models can benefit from it and we can avoid duplicating code.
No need to copy `bvals[1:]`
yeah, in this case it may not be so bad but once you let one through the door ...

what does the extra info give us?  

I could probably live with the except if there is a 
# raw except is bad and i feel dirty comment
Yeah, had some code here before moving it to the extension.
Thinking out loud, I wonder if this makes sense to be built in okaara functionality. Taking "required" a step further to be "one of X, Y, Z is required". Not something that needs to be in place for this fix, more that this fix inspired that idea.
This is used by 'as' and by 'session=' to find the +*account card.

Note this needs to work when WagnBot+*account has not yet been saved, or the migrations won't work unless you do something like manually adding that card.
Yeah, IMO that is better.
Should be named ``networks``.
There is a reference to Session, now Account in namelogic.  That needs fixing as part of making the namelogic config better.
This should cause an error that the class `wcf\action\wcf\data\IStorableObject` wasn't found.
Yes, should return True. If the process is already dead. Thanks, good catch.
Typo in comment. Also, please put the `*` next to the variable name rather than with the type (just a style consistency thing).
A preferred notation would be `background: url('../images/oae-bg-pattern.png') repeat-x top left #eceae5;` which combines all background styles.
this is a more general problem, as timer resolution across browser varies greatly. Theoretically, 0ms should work, since all we need to do is wait for a browser repaint but in practice it just doesnt. setImmediate was supposed to fix this, but it's a mere workaround to the problem because what we really need is a way to either force a repaint, or get notified of repaints
I think the "support" word in there messes up the intention. Wdyt?
and the 500, of course
If we're going to add this as a feature, it should match the built-in wording.
This line was removed :)
Looks mis-indented.. is there a tab by any chance?
Should be "these task *utilities*"
should be a list of numbers
Well, that optionally uses the Python allocation. My own preference would probably be malloc/free if we don't want to track memory usage in these things.
should be in your ~/.gitignore
I think the implementation of this method should be only `super(self.class.new_from_hash_copying_default(other_hash))`
This test passes with the current implementation in master.
With JSON - yes. If we serialize hash with symbol keys with JSON and parse result - symbols became strings
    1.9.3p194 :027 > JSON::parse({ :foo => 'bar' }.to_json)
    => {"foo"=>"bar"} 
    1.9.3p194 :028 >
We can make something like this:

```ruby
content = self[0...stop] + options[:omission]

if options[:hmtl]
  content + options[:html]
else
  content
end
```
I'm just trying to understand here, why do you use a MiniTest exception class?
You probably don't need begin/end here
Can use `.tap { @built = true }`  here
This one seems weird to me. I think it should be `invalid?`.

In your expectation this case returns `false`:

```ruby
Code.new(:letters => [ "z", "c" ]).valid? #=> false
```
types() is not implemented correctly right now. The current implementation initializes ros.message() objects and passes them in the callback.

I am looking into a [pull request on rosnodejs](https://github.com/baalexander/rosnodejs/pull/23) for ideas on implementing types in ros.js.
This was handy to have a little autocompletion in test cases. It shouldn't actually ever compile anything as it doesn't have the Scala facet.
Similarly OK.
Should be ``num[z == 0] = 1``, but yes that's better than ``where``.
Ralf Gommers wrote:
> One test for ``method="golden"`` would be good here.

Done in f2f5f4616b6b9951a2c2a5e1b4367c79759faea3.
Would it be simpler to just say renamed here, instead of adding one, removing the other?
better use latex
Do the standard `Basic` methods work on these classes? Do they have a `.args` field?

For example can I subs a different Manifold into this patch? I'm not sure why you would ever want to but, in principle this should be an option.
PEP8, I believe, would suggest removing spaces around `*`
Actually this parameter is different for distinct prisms. I would like further improvement on this direction
Because bottom imports are evil. They make a complete mess of the import graph, making it very painful to resolve import loops and they go against all pythonic conventions.
Also when we're storing / reading in timestamps locally. See SessionData line 33-47
ここは *あのあれ* だね。
That would be nicer to declare a class for this `WireFormat`:

```scala
implicit def AvroFmt[T <: GenericContainer : Manifest : AvroSchema]: AvroWireFormat[T] = new AvroWireFormat[T]
class AvroWireFormat[T <: GenericContainer : Manifest : AvroSchema] extends WireFormat[T] {
 ...
}
```
This helps with the debugging because you get proper names instead of anonymous classes names.
Surely there is a better way to do this than having to pass in the bot to get to the config each time?
why super()?
If the record's state is "inflight", then we can't do anything useful with it, like `rollback()` or `commit()`.

Shouldn't a record with a 422 response from the server transition to "uncommitted"?
This is an oversight. Not sure about the best solution as `None` is now used to mean "no bounds checking". Will ponder.
Wrong use of Params.read_yml_params_file. You should put all the parameters of the executable in one yml file and let Params.init handle it. If the file location is not the default location:~/.bbfs/conf/#{Params.executable_name}.conf  (as in your case) you should override it like this:
Params['conf_file'] =  Params['backup_server_config']
And then call init (line 44)
24.09.2012 10:24, Vitaliy Kotov пишет:
>
> In protected/runtime/application.log:
>
> > @@ -0,0 +1,91 @@
> > +2012/09/17 16:03:23 [error] [exception.CException] exception 'CException' with message 'CAssetManager.basePath "/home/slon/eclipsews/calc/assets" is invalid. Please make sure the directory exists and is writable by the Web server process.' in /var/www/yii/framework/web/CAssetManager.php:128
>
> Как этот мусор сюда попал? перед коммитом смотри, что изменилось. 
> Грохни это дело.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/kotslon/calc/pull/13/files#r1670169>.
>
application.log - грохнуть, или его содержимое, может ваще его в 
гитигнор забанить
indentation isn't correct given the context.
Mention the need for quotes around paths and filenames that includes spaces.

e.g.
C:\mongodb\bin\mongod.exe --dbpath "d:\test data \mongodb version 2\data"
> MongoDB supports location-based queries and geospatial data with a special index for coordinate data. The index stores :ref:`geohashes <geospatial-geohash>` data, and makes it possible to return documents using special proximity and bounded queries against flat or spherical coordinate systems. Geospatial haystack indexes provide additional support for certain classes of region-based queries.
dirname is imported but unused.
Yep you are right - Done.
Forgot this is PHP4 compatible and we would have to pass it as a reference, I guess you can leave it as is.
Why is array a hash?
You can probably remove the `@`. `php -r "error_reporting(-1); \$a = array(); ksort(\$a);"` doesn't throw an error for me.
Per its implementation this function should be external to the driver.

Looking at this issue differently, it should be possible to determine whether a driver is enabled without instantiating it.
I was always taught that if you refer directly to an undefined
variable, an error will be thrown. It certainly does in older
browsers, the behaviour might have changed recently.


On 20 Apr 2012, at 11:18, Marc Alexander
<reply@reply.github.com>
wrote:

>> @@ -129,7 +129,8 @@ $('[data-ajax]').each(function() {
>>        phpbb.ajaxify({
>>            selector: this,
>>            refresh: $this.attr('data-refresh') !== undefined,
>
> There is no need for typeof as .attr() already returns undefined if it's not defined. Take a look at the jQuery documentation for that.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/744/files#r712494
`__construct()`
Oops, that was a typo. s/extensions manager/events dispatcher.
@param requires object type as well (same with all other param docs in this method) like so:
```php
* @param phpbb_request $request The request object
```
Acest mesaj ar trebui trimis în așa fel încât să nu îl salveze în db.  Cumva, trimis un parametru și modificat funcția[1] ca să îl ignore.

[1] https://github.com/rosedu/wouso/blob/master/wouso/interface/activity/models.py#L108
Is it ok to do such comparisons? Is this semantics declared in standard?
Doc the arguments, not immediately clear what the role of `r` and `[T.Text]` is.
At some point we need to overhaul this class properly with a nice literate Java source builder or some such.
This was not added, but commented out from the original tests. But can be safely removed.
removed the app.js
Also, to make it more flexible, propose that you pass an argument for the keyName, too:
``` 
KeyMapButton: function (componentName, keyName)
{
   key: keyName,
   ...
   var element  = Ext.getCmp(componentName);
   ...
}
```
Vertical alignement required if there are arguments on the first line.
Do these helper functions need to be public?
Obviously we still want to keep this docstring.
I saw this too, wrote a comment and then retracted it having checked the PEP. However, it differs from the rest of the codebase so for the sake of consistency I say '\n'.
Should the "gpu/cuda version" line be above?
I removed it completely from unionnode.*. <string> is included through
other includes.

On Fri, Oct 19, 2012 at 10:04 AM, Paul A Martel <notifications@github.com>wrote:

> In src/ee/plannodes/unionnode.cpp:
>
> > @@ -44,17 +44,56 @@
> >   */
> >
> >  #include <sstream>
> > +#include <string>
> > +
>
> I'm guessing that the include is NOT required by the .h, so please
> demote/defer it at least to after unionnode.h, preferably as the LAST
> include in the .cpp .
>
> There's not a total team consensus here on the (extreme?) practice of
> listing system includes last, but, FWIW, it is my own personal preference.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/230/files#r1890117>.
>
>
Should you not write unit test for private methods?
fixed ... !
Hmm -- not sure how I missed that. I'll double check. Thanks!
I think I misunderstood what override(None) really does. Apparently it switched gettext to NullTranslation, but for some reason `get_language()` returns `settings.LANGUAGE_CODE`, which is a bit misleading. I thought it just switched translation to `settings.LANGUAGE_CODE`, my bad.

Restored the original behavior in updated diff, although I'm not 100% convinced that returning untranslated string is the best thing to do here.
Ohai,

After some investigations, I managed to reproduce some kind of lockup using "ifdown eth0" on my VM (I have no wire, did I tell you that ?). However : 

- simple_demo.py (from ssh) exhibits the same issue (hangs and never ever breaks)
- vanilla fab exhibits the same issue too
- branch fab has the issue (obviously)

All these where run along with a simple ssh user@host which has some kind of protection against that and end up aborting ```Write failed: Broken pipe```.

So now, I'm left with very few things:

- can you check the issue does exists in simple_demo.py and vanilla fab when you actually unplug the wire ?
- if yes, then:
  - we likely have a more serious issue in ssh (I suspect something wrong happens *but* the ssh code does not detect clearly the network is cut)
  - we can however implement a solution in fab by adding someking of "idle" timeout what will decide that when a client hasn't say anything for 'n' seconds, then something's wrong (I know the whirr - hadoop like framework - has some kind of hardcoded idle timeout of 30s which did posed us problems because we has something that was idle for > 30s). This is *dirty* but it might be acceptable.
- If no, I need to find a way to reproduce the issue in some way.

Argl.
As it is written, `value` is guaranteed to be a String or `nil` after this block. Passing `false` to `uloc_setKeywordValue` raises an `ArgumentError: Invalid String value`.
I love hot pants
Right, the problem is that SVG children will have incorrect getComputedStyle values. :-\ Perhaps this IS a wontfix until SVG becomes a bit more stable. Good catch gentlemen. @dmethvin, thoughts? This really only works for certain situations, and I guess we don't want to be advertising that we can be accurate about this sort of thing.
The featureset table is already created before crf_feature_gen is called.  It is either created by the user, or by the crf_data_loader code.  Either way, the f_index column of featureset is already of type integer before this line of code, and the only way that I know of to convert an integer column to a serial column is essentially creating this sequence.  

However, we could convert other parts of the CRF code and documentation so that f_index is initially created as a serial column, if you think that is necessary.
Node.js on Windows is in another folder, so cd correctly.
The reason is that we plan on a DirectX implementation for Win32 in the future which means it will be DirectX with SharpDX, but it won't use the WinRT API.
The docs now got more examples.
Nice idea. What do you think about doing that in query strings, so we don't have to make a whole bunch of entries in `urls.py`.
I had this as `required=True` originally. I was very confused why all the "unhappy" forms were failing.
Should the "config.domains.all|length|pluralize" also be changed to "config.domainrequests.all|length|pluralize"?
I would rather this be less clever, and more explicit:

```rb
args = %W[--disable-debug
          --disable-dependency-tracking
          --prefix=#{prefix}]

args << "--without-mysql" unless mysql?
args << "--without-postgresql" unless postgresql?
args << "--without-sqlite" unless sqlite?

system "./configure", *args
```
Don't install directly to `HOMEBREW_PREFIX/'share/couchdb'`, install to `share/'couchdb'`. The Homebrew installer will create symlinks in `HOMEBREW_PREFIX/share` and will also be able to clean them up during uninstallation.
I don't understand: this fails on my computer because "FastICA has no attribute 'inverse_transform'". Does it work on your computer @AlexandreAbraham ? We need to fix this.
OK, I wasn't aware of that, and maybe I overdid it a bit with indices (what's the plural form fro index?). I can just remove it.
^Replace instances of MoreComments objects with the actual comments.
Same two comments from above on i18n and the inclusion of the distributor ID.
This class description could be a tad more descriptive (doesn't really explain what the purpose of this class is)
Why convert it into strings? It would be nice to have real bools etc, wouldn't it???
Your call
nit: use `if all_var is None:`
Didn't know you were paying attention. :)

Thanks, that makes sense... and in this case I feel comfortable saying we probably don't need it.
Lets use a config option that allows people to disable SSL checks. I want to default to verify, it's the right thing to do.
I think lint will fail the build with this
What about a group being different named then the user?
you mean findSubscriberByCustomerNo ?? because it is called 2 times from the above, so i split it out
if this method just return thing from findByCustomerNo, why it needed to exist?
Guice be gone!
this should be deleted
I think these styles should go in `app/toura/components/Checklist/_checklist.scss` since they would presumably be used in any page that uses this component.
Should align the "=" signs, like in our other modules
Heh -- exactly.  Could have phrased that a little better I suppose :-)
Yes, those loops are identical, and I wanted to create a _parseRuleList() function to encapsulate taht code. But, _parseRuleList() would have to call _parseAtRule(), which would have to call _parseRuleList(), so there's a cyclical dependency and I couldn't think of how to do that in JS functions. It doesn't seem like it's worth creating modules. Please let me know if you know a simple way to do it.
I assume you meant I needed to do $("body").toggleClass, so I updated it to that.
Fixed. I also updated the comment now that I am using an event to signal the dom is ready.


From: Randy Edmunds [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 8:21 AM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache (#1358)


In src/index.html:

> -                <p class="dialog-message">Notices, terms and conditions pertaining to third party software are located at <span class="non-clickble-link">http://www.adobe.com/go/thirdparty/</span<http://www.adobe.com/go/thirdparty/%3c/span>> and incorporated by reference herein.</p>

> -                <p class="dialog-message">Documentation and source at <span class="non-clickble-link">https://github.com/adobe/brackets/</span></p<https://github.com/adobe/brackets/%3c/span%3e%3c/p>>

> -            </div>

> -        </div>

> -        <div class="modal-footer">

> -            <a href="#" class="dialog-button btn primary" data-button-id="ok">Close</a>

> -        </div>

> -    </div>

> -    <div id="context-menu-bar">

> -        <ul data-dropdown="dropdown"></ul>

> -    </div>

> -    <div id="codehint-menu-bar">

> -        <ul data-dropdown="dropdown"></ul>

> -    </div>

> +    <!-- HTML content is dynamically loaded and rendered by the htmlContentLoad

> +         module. Any modules that depend on or modify HTML during load should require the htmlContentLoad module so that it is loaded first. -->

This comment line should be split so that it fits in 80 columns.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1358/files#r1373256>.
I notice on Mac in the appshell/Resources folder there are subfolders for en and en_GB, so that makes sense.
Remove extra ``/``
Is this faster than a regexp replace? .replace(/\n\n/g, "\n");
Can you just indent by 2 spaces here please?
*COMMENT_MESSAGE_MAX_LENGTH* you mean? OK, could be.
That wasn't me? https://github.com/mitar/PiplMesh/blob/master/piplmesh/settings.py
This docstring doesn't explain what the method does.
It didn't complain about l?
Move this up to the line above
Are these changes needed? It looks like the code from Brian's quiz, but we don't need that, right?
Better to do this as a fraction of `@HEADER_SPACING`
Looks like your indentation is wrong here.
`header("location:../");` should work just fine.
makeStyle 接口已经废弃了, 图像处理的接口就只有 imageView 和 imageMogr
Bei viewREXMedia müssten die params auch hinzugefügt werden, oder?
Done, check out the new docs.
And do we really want to rescue? What about this:

```ruby
  def watch(*keys)
    synchronize do |client|
      client.call [:watch, *keys]

      if block_given?
        begin
          yield
        ensure
          unwatch if $! && $!.is_a?(RuntimeError)
        end
      end
    end
  end
```
fffff, okay.  weren't we on a path to updating nexus to use updated junit @peterlynch ?
Tests should strive to avoid use of time based mechanism to validate functionality.
什么样的情况下会出错？最后一个模块？
-21 should be better ;)

More seriously can we have a visibility: hidden on this those frames?
should probably not be in here ;)
System templates allow to group content (products, repositories, packages) and handle them in change sets as a unit. They also provide an export consumable by different systems (such as Aeolus Conductor to generate system images)
Just for the curiousity - mongodb and postgresql are not there intentionally?
is :presence => true really required? Is is possible to create system without hardware information?
The ugly comment to remind me where I put my changes.
I think this only needs to be done once for the top/final plan.
Or, this can be as simple as `ConversationList.view`
I think starkos does not remove old cruft because he uses this branch in production and wants to have fallback in case something is suddenly broken.
Variable hoisting here too.
The ``unit`` argument needs to be set to a tuple for two of the examples above.
为何方法叫validInt，里面用is_numeric呢？
Then again, we could probably replace this `finish_transfers` function with `future_ring` provided by the staged clustering code after merging and integrating both branches. That does something similar:
https://github.com/basho/riak_core/blob/gh177-staged-clustering/src/riak_core_ring.erl#L758
Sorry, I'm no GIT master :-/. But I never had a pull or commit, where I needed to include .gitignore.
I re-added this ;).
Why not set $_systemTimezoneIdentifier to current system timezone in setUp() method and simply remove this "if" check and in _restoreSystemTimezone() too.
I understand but disagree on your semantic correctness point. But this change makes this version of cake.php inconsistent with the other 2 which also use local variables.
I added ```strpos($col, 'tinyint') !== false``` because of ```tinyint (1)``` validation, notice the space in between.

https://github.com/cakephp/cakephp/pull/1011/files#L6L502
Should the quote be a colon here?
If you indent this and put the "-" first it will be nicely formatted in the docs
Doesn't matter if the link itself is https or not, it's more about the embedded content
Mostly because I thought when we care about them, we'd want to get both. Especially once we add the derived total field. Not feeling strongly about it.
static_url was tornado defined macro that was adding a `?v=file_sha` for caching. With is doable in Jinja2 but not worth it if i remember correctly.
Predicates.in ?
is this runtime subtype helping us?
I'm noticing this class wasn't using all the wrapper types before and now is changed to do so.  Any way we can avoid this, as this data type is now horrendous to use.
odd I wonder why It did not throw a syntax error

```` js
[";" + k + "=" + this.parts[k]
````
I don't think there is a code path where we would get to this point and have error be non-zero. Can this line be removed?
By the way, I also think when the callback terminates the loop (either with non-zero or <0 depending on what we decide), that it should definitely terminate the entire loop - no crazy shit like the the ODB iterator does now where it only terminates part of the iteration.
nitpick: put the else on a separate line
Don't need the string literal here. Sorry i know I said no `,` in mixins but the exception is ones inside of parens.
Oh, scratch that--I see what's going on.

Might want to mention in the docstring that this view covers all the steps.
I was wondering if anyone was going to take exception to this :-)

The if/else version is actually 6 lines instead of 4, because I raise en error if it falls through, which this does implicitly. Though raising ValueError is probably better than the KeyError that would be raised before.
We depend on memcache for CSRF now. But we could might be able to fix that with a local settings change.
I guess it's better to be safe than sorry. 
A concern could be that right after this all caches are flushed and every single request thereafter will cause a cache miss. That could be overly heavy load. 

...but with the amount of traffic we have, it won't be problem for many years.
This should be:
```socorro.cron.jobs.duplicates.DuplicatesCronApp|1h```
"nottest"??
I don't know how useful single characters are. they're confusing, and it's just general practice elsewhere to use numeric constants.
I don't really get your point here. My concern is not with .ini or sf2 but with the xsd only.
wrong order for the keywords (running the PHP-CS-Fixer will fix it for you)
Tell me if i'm wrong but you are not doing N iterations (where N equals to `$this->iterations`) but N-1. Isn't it?
True, I'll change it if I can figure out how to update a pull request
Fixed and added test for this case, thanks
Yep, there is not CS rule against `!`, but there is convention (not sure about rule) to not use Doctrine approach `if ( ! $something)` but to use `if (!$something)`...
this class is not used
I don't see the use case for replace multiple (length > 1) elements with a single element, and override this element as an array index.
I would rather say we don't need a length param for that as such strange use cases can be achieved with a simple `remove`.
Instead the name should be optional and stay the same for the replaced element when not given.
I.e. signature: `function replaceByIndex($offset, $name = null)`.
This method should be defined in the TestCase class to be able to use it in other intl tests if needed IMO
Does this code change have any benefit? I think it is more complicated to read than the previous version and does not really add anything.
the code when using the shell should not be changed. Events should be dispatched by the commands launched inside the shell, not before and after running the shell itself
lone `raise`
I was wondering where all the set* methods went for Dates. I'll change these methods to use Calendar instead.
What is 0?
```ruby Rails.logger.error``` would match the conditions here better.
these will all be handled generally by upcoming changeover to CPApiClient
Just saw the quotes. Will change.
unnecessary ?
Why isn't this a method of the class?
Ahh, you are using previous_index. That's dangerous because the buffer might be released before it is actually swapped to the front buffer. See CXBMCRenderManager::NotifyDisplayFlip
I see two options:
1)
Keep the render buffers longer-> increase by one cycly of glxswapbuffers

2)
Shift render buffers after having rendered second field in second frame. Call CXBMCRenderManager::PrepareNextRender();

I would go for 2) because 1) does not work without buffering in renderer. In current mainline version you can observe slight stuttering caused by early release of render buffers (buffer overwrite). Current LinusRendererGL does only have 2 buffers which can't be in use at the same time.
I totally agree. Just pushed a less complex ```Freezer.parse``` implementation.
I don't understand the need for this field. It seems like the ChannelAssociation could be passed through the stack the same way the Channel was before the patch.

I suspect this field is the cause of the problem, as looking at the stack trace I posted, it seems like more than 1 Channel would have to be involved, with the VersionOneProtocolChannelReceiver getting added to the wrong one. That could certainly happen if this ChannelAssociation field got swapped before the separate thread that runs a task to call ClientVersionMessageReceiver actually gets that task run.

I'm experimenting now with just passing this ChannelAssociation through the stack.
This method is a non-sync read
Please add a reference to AS7-5882
we do not have any font-size declaration!
Although users might put some video 3gp in other folders, this can at least ignore those generated by Camera.
Maybe you can use querySelector here:
this.vew.querySelector('a[data-num="' + number + '"] div.name');
I'm not sure the code is correct or not, but you can use querySelector to reduce the step.
I know you need the real message id for message deletion, but it seems a weird place to record the id. messageDom element actually use the id property, but it store the timestamp for id, not the real message id. You can store the message id to messageDom.id, and I will also add id property for pending message. You can get the messageDom.id and push into delIDLsit for executing deletion.
please use real ellipsis (…) here
no as addToList is a callback invoked by getContactsById and there are two params for the same reasons as explained above. nonetheless I will add a comment as suggested by Vivien
Please don't write z-index in separate stylesheets. It's hard to manage the z-index if everyone set their z-index in their files.
Find out a position in `apps/system/style/zindex.css` and try to give some comments about why you set this layer to 2 would be very good.

And, since you have a new class name `ftu` for `div#screen`, you could also use
```css
#screen.ftu > #initlogo[data-z-index-level="initlogo"] {
  z-index: 2;
}
```

BTW I think @timdream set z-index of initlogo at top of  `apps/system/index.html` for loading timing issue, if it's so you could set `initlogo`'s z-index there.
I didn't translated that, next commit to fix it, also Yes, sounds better Código than Clave
why do we need this? AFAIK this code already lives on the settings app
I don't think you will need this string.
browser doesn't have any other lib dependencies, no need for this nonstandard OSX app dir
You could probably simplify this to `mappers.each(&finalize_attributes)`.
Looks like a debug statement was left behind.
Lines 19-25 can be refactored significantly:

```ruby
 @processor = options[:processor]
 @username  = options[:username]
 @password  = options[:password]
 @filter    = options[:filter] || ['NEW']
 @port      = options[:port] || 143
```
Means we don't know the arity, so it cannot be checked at flow build time.
So it can compile?...
I don't see what you mean. In Bukkit, all enchantments return 1 for this method at the moment.
Probably a bad merge. Is this flag portable?
Difficult to review the regex here as there are no examples of the expected format present.
Not necessarily - in many cases the "canonical" link is not the endpoint generating the link - be that for endpoints returning lists, or for endpoints at "extended" paths like `/builder/:builderid/build/:buildnumber/step/:stepnumber/log/:logid`, where the canonical path is `/log/:logid`.
It may be good to leave mention of these in the manual, since they still exist and are visible on the web, but specifically deprecate them and call out their unreliability, and indicate that source stamp attributes are preferred.
@stof true (you're fast like @fabpot said : _Yes, seconds!_)
looks like some words are missing here (also before though, but it may need to be fixed).
It should be 
```python
order.status = Order.CONFIRMED
%d expects an int value
Could be move to the beginning of the file where the high/low check and macro definitions are located.
Also needs to be 0xFFFFFFFF.
Yep, still dev account, this is just short term, we need some more info from it then will delete
Venue may not have a website. Use the `wtf.Optional()` validator or `URLField` will complain about blank fields.
should we free something about jdata here?
I agree that a `mkdir -p` behavior would be ideal.  If we can't *write* to that dir, we error out, but simply printing the directory to the user and not creating it is the kind of annoyance that setuptools is famous for  and we should avloid.
Okay, i understand that this will be next method, which be called by some of the code you will write. I'm just giving you some constructive criticism - don't write code which is not currently in use. Same goes with commented out code - rather than commenting out something, just delete the code. I'm saying this because the code which is not used is equivalent to code which is commented out (and there is commented out code in ms_uia and its specs - i don't think that it was you who did that, but i had to say that out loud, hehe).

Anyway, no hard feelings and let this method be for now, but just for the future reference, what kind of coding style (and most coding style books) really recommend.
`harnessOptions` was pretty unfortunate name, that we always wanted to change. Maybe we can fix this now ?
My first thought was add `btoa` and `atob` as globals, it was @Golaza that suggested to add them in "chrome" module instead.

I'm open to any of the options you have listed.
I forget that so often...

I'm inclined to switch it to `if (state === 'loaded' || state === 'complete' || state === 'interactive')`
We don't. But by default the ubuntu tempalte came with.  I'm not sure about the tty0 to be working. After my test, I believe that the first tty is 1.
Should be ``AMQPQueue::bind($exchange_name, $routing_key = null)``
Let's try and TravisBot will tell us :)
I'm actually wary of adding anything at all in this patch. This patch is a gateway patch, that removes our reliance on 'which' or letting the environment do its own resolution. It gives us more power which is awesome, but what we choose to do with it is still a very debatable thing.
Nope, updated :)
Consider using Joda-Time's date-time parsing, it is thread-safe and immutable.
Maybe show how to actually take the integral of multiple variables at once, like `integrate(2*x + y, (x, 1, 3), (y, 2, 4))`.
My suggestion is based in the code above sets the requirements for the bucket and this part of the code evaluate that requirements.
It is not the same. If you pass an empty array the old check will ignore it; isset() will accept an empty array.
I can do that. But why a new key ? If you use formRow you likely do not render them manually, so I don't see where it should conflict :p.
add space between foreach and (
With "showTitle" dropped we can drop this too.
Add doctags for author and since on all created methods
This should probably not use `isalnum()`, its behavior is dependent on the current locale.
It looks like the line endings in this file were changed from Unix to DOS style. If this is happening because you're on Windows, could you please post-process the file to minimize differences? See for example http://stackoverflow.com/questions/2613800/how-to-convert-dos-windows-newline-to-unix-newline-in-bash-script .
This looks broken :)
$user_manager => $userManager
Use the jQuery in the `assets` folder instead
I think I'd like to either do this, or remove the comment; if there's a need for the method to change, we'll feel it anyway.
you could have used the mock lib to do this. I'll change the code so it uses it (will be simpler)
Indeed! And this could even be in the nominal package, but perhaps, it is generally useful?
I wouldn't rely on the URL. Instead we should be able to introspect the user object and determine this:

```ruby
if f.object.persisted?
```
This is due to `load_and_authorize_resource` in cancan, right?
I'm aware of it :)

What do you want me to do? Add a comment describing the temporary nature of implementation, with link to the first commit?
To avoid confusion (because your comment might be formatted differently than you meant). You mean to place "iomp5.a" under "%s%s" or under "ifcore.a"?
I believe the "id" argument is required?
No need to declare deps in the parent - as you've declared them in the modules
can we remove this @InheritDoc crap, it's not standard.
Backticks around JaxWS...
We use quickstart, rather than example, to describe what "this" is. Just keeps the language consistent.
This should go somewhere around line 70 instead (`safe_visit()`). This will replace anything that the traverser encounters; you want it to only apply to accesses to the JSON.
It's probably an out-of-date version, but I think it does. At least use protocol-relative URLs `//ajax.[...]`.
"There were errors with **your** input in the search form:"
https://docs.djangoproject.com/en/dev/glossary/#term-slug
The naming the field `url` implies that it contains the url. But it doesn't, it contains a slug.
This can't be specified with <defaultValue>? I would take ci as default given that our ESX cluster will start reporting to release and ci gets a playground and we do not massively interfer with user executed testruns.
Mustang updated last time 6 month ago (it needs new maintainer). If we drop this hack, tests will fail. I'm trying to keep only working tests
add `raw: true` here for suggested typical RingBuffer usage
Lets to `this.emptyTemplate = this.emptyTemplate || getTemplate` or put this in a conditional if block rather than putting the side effects on the right. This should be a common pattern.
I agree that exposing NodeKeys would simplify this code, but they would complicate a lot of other places in the existing code. 

Performance wise (considering the all tests run & pass) based on the overall build time, there is absolutely no change with this code in place.
5000 is what's common in devstack, might want to keep that port #
This is useless. You will not prevent caching of authorized pages like this. 
This better.
Если внутри класса A есть вложенный класс B, мы наследуемся классом С из класса A, то правда, что A::B и C::B - один и тот же тип?
нет не нужно
We should also add the 'native' mark to this test since it uses hover.
Why do we use <code>s.find_elements</code> here?
Shouldn't we use <code>self.selenium.find_elements</code> >?
Should it really be an OR here?
This would mean that no programs or videos will be shown if the setting is set to TRUE.

Proposing an AND instead:
Ff the setting is set AND a program/video ends with "teckentolkad" then do not create directory item.
ANGLE_FLOAT_OF_BFP is superfluous here...
We tend to go with triple double quotes and no spaces around text for docstrings.
Neat, why do we need NULL at all though? Those things __always__ require to be set otherwise we can't query them.
On second thought, it might get tricky storing performance tests in individual module directories. The tests will likely need access to downstream APIs in order to set up data and perform other related operations. They almost feel like integration tests, and as such it may force us to eventually aggregate them into a top-level performance/ directory
why does `lib` get passed back in the callback. Also, should the `err` not get passed into the callback instead of just `true`?
Agree. "ветка" is better than "бранч".
I still don't understand but ok :-)
Проверить, удовлетворяет ли метод mutate требованию **заменить строго Х% символов** довольно просто: выводим ДНК до мутации, мутируем определенный процент, выводим измененную ДНК и на основе результата делаем вывод, выполняет метод свои обязанности, или нет. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
assert или exception или С-style проверять возвращаемое значение
"это не оптимизация, это костыль"
Нет, я с вами не согласен - это именно оптимизация. 

"заточив свой проект под конкретную задачу"
Это и есть оптимизация.

Скажите, если бы в задании было указано, что нужно разделить процент на 2, а в имплементации вместо деления был бы побитовый сдвиг, вы бы тоже сказали что это ошибка, ибо в ТЗ чётко сказано "разделить", и в будущем могут попросить делить не на 2 а на 3?
Согласен, я в отдельном бранче делаю метод Фишера-Йейтса но вроде задача не на оптимизацию поэтому сильно оптимизировать ее не стоит. Насчет arc4random_uniform() - тоже согласен но это не критично.
Вы отправляете сообщения экземпляру класса (self.DNA или [self DNA]) до завершения метода init. Это плохая идея.
init должен позаботиться о правильной инициализации состояния класса, без использования деталей реализации.
Более детально http://stackoverflow.com/questions/5932677/initializing-a-property-dot-notation
I guess we'll need this in production too. Also, we have to remember to change the Apache config to add the variables.
Again, I'm sure there's a reason for this but if we can remain as vanilla as possible that would be great. If not, please explain with comments.
we use em-mongoid