labofsahil/github-event-dataset-2012 huggingface dataset:
I don't think we want to use libpath.join() for URLs.  If we did, if the server is windows we'd generated URLs like `/foo\bar\baz` which is really weird.
Can't understand the purpose of this code line.
recommend that the license this is updated across all of the Raxa files in one pull request (separately). It's confusing to see many edited files with just the license, which is irrelevant to this pull's main content (i18n files).
https://raxaemr.atlassian.net/browse/RAXAJSS-368
Wait, might be an issue on some devices, SIII selects do not work, I'll check on my version.
You want `connections[db]` here, otherwise it won't work when `multi_db = False`.
I believe it's comparing the wchars of the strings and gtest say's it supports wchars. It probably works.
Instead of this, a comment about how (and more, when) to use it would be more helpful.  For those that understand it, this will be obvious; for all others they will trip on it.
I don't think that this needs to be performed after acquiring the lock.
It should already have been normalized by this point, although I just realized that the qSA fork leaves an out that should probably be closed.
Prinzipiell ja, allerdings gefällt mir "Lernen Sie einige Tipps ..." im Moment nicht mehr so richtig ...
Wie wäre es mit "Erfahren Sie einige Tipps ..." oder "Lernen Sie einige Tipps kennen ..." ?

Ich bin noch recht frisch im Umgang mit git(hub), besteht jetzt aktuell Handlungsbedarf auf meiner Seite? 
Kann/Soll ich diese Mergeanfrage jetzt zurückziehen, die Fehler verbessern und erneut stellen oder wie wäre das passende Procedere?
Add the test for c45_classify.
The name "BinaryStream" (ambiguous "binary"):
  Looking at the interfaces of this class, it looks like something similar to std::iostream, in which context, "binary" probably means "ios_base::binary" (no memory alignment) and it is not why you name this class with the word "Binary". Something like "ByteStream", "WordStream", or "CharStream" may or may not work, but it does at least avoid this ambiguous...
Sorry, I don't see any difference for the two suggestions from you.

If we use the solution from you, the random number does not uniformly distribute between [low, high]. The probability of minimum number and maximum number is significantly lower. You can make an experiment.

I can explain to you theoretically tomorrow.
Are you aware this gets into master and is not scalable.
How about just a sentence with a link? like:
For detailed function signatures, see [here].

This can at least tell readers that there are placeholders in these signature-like descriptions.
s/populate_playlist/populate_tracklist/ :P
Действительно, повествование от первого лица («мы») звучит лучше — словно автор вместе с читателем, а не напротив него. Да и постоянное «выкание» зачастую избыточно («вы решили, что вы будете работать»). Чтобы быть последовательным, переделывать надо не одно предложение и не пару абзацев, выделю это в отдельный коммит.
Wow. I think this takes the "declarative" style a bit far, don't you think?

What's the business case for an end-user feature being "smoke test"?

I don't think this works...

Given I'm a tester
And I smoke test
Then the tests should pass

...but that seems to be what this step definition would fit into.  Something is wrong on Saturn 3.
Looks like "messages" doesn't  exist anymore.
As far as TravisCI knows this was ```rubinius 2.0.0dev (1.9.3 e0e5d5ab yyyy-mm-dd JI) [i686-pc-linux-gnu]```. So it seems to be pulled directly from the repo... I'm going to add something like:

```
# Remove after Rubinius 2.0 released or if pulling from master after 2012-12-6
```
... this is the calling code
Make this a protected class variable so you can clean it up after the test ran.
Can we use `published` for this value as per the Jekyll docs?

https://github.com/mojombo/jekyll/wiki/YAML-Front-Matter

`published` - Set to false if you don’t want a post to show up when the site is generated
Could this function be renamed to make it more clear what the distinction is from `op_fetch_data_char`?
:-1: from me on this I find it less clear to be honest... More characters too. What prompted you to make it into constants?
This allows the profile manager to update any auth changes that happened during the run, such as refreshing an access token.
Man, the notion that we have to think about this stuff now -- reentrant requests for the same Document -- really scares me.  We're approaching the super bug prone zone of multi-threaded apps now.  DocumentManager is especially prone to this stuff because it has to ensure singleton-ness of Documents, but I would bet that half the functions in our codebase that chain promises have _some_ sort of "threading" issue (with reentrancy, with other APIs in the same module being called concurrently, etc.).

We were plenty aware that lots of our code will have bugs once async operations become truly slow (e.g. going over the network), because then the user could manually invoke several commands while the first one is still executing.  But I don't know that we've thought enough about these other cases of _programmatic_ parallelism -- usages of `Async.doInParallel()` or other cases of kicking off multiple async ops at once.  It seems like we badly need a thorough scrub of all our async code before we can safely transition to brackets-shell.

I wonder if, in the meantime, we should be super-explicit about documenting which methods are safe to call in parallel with _anything_ else going on. So far only `getDocumentForPath()` can be flagged as such...

Out of curiosity, did one of the unit tests actually hit this case of two concurrent requests for the same file?  Or is it just a case you decided to guard against preemptively?
Very minor nit: space before brace
Brilliant! Fixed.
I can't hit this code path. Is this change necessary? How do I get here?
Von der Festplatte neu laden
It looks like both document and window are no longer used and can be removed
JSDocument & HTMLDocument are only returned if the experimental flag is set.
Do you think it's worth the churn of adding underscores to all the "$" members in this patch?

I'll add the getter either way though.
Solved now.
Why not use outer joins?
Why have you removed the defaults for all of the command line options?
is_staff is a little odd here (it essentially means they can access the django admin, and I don't think we use it for anything other than superusers currently). is there a reason that's also included?
Setting the default `expand` values needs to be done twice: once before stats are calculated, and once after. `train_position()` seemed like a good fit, so I moved it into `train_position()`, and everything still works. 

I had to modify `train_position()` to take a coord object as an argument, since the `coord_expand_defaults` operation needs access to the coord object.
Once again, please explain briefly what this class is used for.
I am not sure if this doesn't cause some strange error if user doesn't write correctly callback ( I often forgot to set response code ). So maybe we should explicitly check if it is true,false, symbol, nil or something strange

otherwise user write
```ruby
widget.activated { |event,dialog| dialog.find(:a)[:Value] = "dump" }
```

and then get unexpected behavior ( it pass event )
This looks out-of-place here now, since it never gets called anywhere else with another value. Does it even need to be here anymore?
Remove this and line 186, we don't need fallbacks for opacity.
Should probably just cache trackEvent.manifest.options here.
Why is there an empty rule here?
Consistency on the quotes.
This entire file is commented out, why include it?
I think this is still liable to break.  From MDN:

```
The toLocaleTimeString method relies on the underlying operating system in formatting dates. It converts the date to a string using the formatting convention of the operating system where the script is running. For example, in the United States, the month appears before the date (04/15/98), whereas in Germany the date appears before the month (15.04.98).

Methods such as getHours, getMinutes, and getSeconds give more consistent results than toLocaleTimeString. Use toLocaleTimeString when the intent is to display to the user a string formatted using the regional format chosen by the user. Be aware that this method, due to its nature, behaves differently depending on the operating system and on the user's settings.
```

I wonder if we should getHours, getMinutes, getSeconds and then concat with ':' ourselves.
Change the focus method to highlight
We don't really `throw` anywhere else in this shell script - we `exit(1)` instead. Any particular reason why we should start throwing?
well, it seems like the intent here is to check if the app_instance was saved or not. if it was, then #persisted? should be true (and #new?, its antonym, should be false). that seems like what you are doing with #uuid here, since a uuid was generated only if it was saved. it is odd that that breaks, though - what's the error?
Yea I agree.
We should also catch all exceptions and maybe map fail to return some stat. It would be nice to do `failWith respo404` and avoid all case blocks.
This statement can be broke into 2 statements if 'continue' is used.
The if statement below would need if(!isNull(arguments.orderItem.getSku().getSubscriptionTerm().getForceBillingOnDay()), it really doesn't need the isNumeric check because that will be done with validation when the data is entered, but you can leave it in if you like.
Переименовать, т.к. пересекается имя переменной с функцией.
Why is preserving the example needed?
The : at the end is not supported in Ruby 1.9. Fixed in #515. The preferred way to iterate through a collection is:

```
ids.each do |group_id|
  # ...
end
```
Curious, why do you "attach a system to a subscription" but "remove a subscription from a system" ? If I attached the system to a subscription, wouldn't I remove the system from the subscription?  

This question is based on  line 617 below.
This is taken care of too.
Is the order correct here?

Shouldn't it be the following:
repo = get_repo(org_name, repo_name, None, prodLabel=product)
the visibility is still missing
If you want to be consistent with the rest of Gaia you should not inline this condition.
So I guess you want to use `Ui` instead of `UI`?
Please, use translations. {{ trans "Member" }} instead of Jäsen.
Yeah sure. Will add few more methods
```ex_list_multipart_uploads```
```ex_abort_multipart_upload```
```ex_cleanup_all_multipart_uploads```

Also, need to check how to expose these in the CLI commands. Have some ideas. Will work on a future ticket for this.
Once I implement this, will upload patch to JIRA
Yeah -- `'file://' + pathname2url(join(absdir, 'index.html'))`, since `pathname2url` (despite its name) just gives the `path` part of the URL.
Is it okay to have no return when the condition is false?
Shouldn't this be `!IsLimited(NET_IPV4)` ?
Does _findThreaded() itself work as expected if the results don't contain parent field? I think not. In that case the fix shouldn't be done in the TreeBehavior.
The double call to `class_exists` is intentional. The first call triggers the autoloader to load the file and the second one ensures the file existed and was loaded.
Shouldn't use `oneshot` for anything that keeps running. `forking` would be better
Can we make this array declaration during the setPlaceholders method?
Also, align the `=>` signs.
Can we also choose a better name for `<lazyLoadedPublicPropertiesDefaultValues>`?
typo: ``are skipped``
You should not include `msp430.h` directly. Include `Energia.h` instead.
Some indenting weirdness here. I think there are tabs and spaces comingled. Please change any tabs to spaces and use 4-space indents.
According to #1644 this should now be 2008 only... :-)
I think that `TraitError` is appropriate in this case.
OK, that's fine, I just wanted to make sure we'd thought about what API
we'd expect, as this creates the possibility that a trait can be changed
without the notifications being fired.
for *your* sessions
Good point, i copied that from somewhere else so I wonder if there is more than once instance, I'll have to look at it.
all valid. I'll update and resubmit.
"profiling"
do you mean ``if not kwargs.get('newsletter', True)``?
Oo--nice. I think this solves my problem with products and parents.
Does `checked` really work? It should be `selected`. See [MDN](https://developer.mozilla.org/en/HTML/Element/option)
this comment is still misleading. An env id is always specified in the URL - it must be, or the URL pattern wouldn't even match to get to this view. The only thing we're doing here is making sure that it's a _valid_ env id for this run, and if not, redirect them to pick a different one.
"the function" instead of "our function"?
Someone pointed out that this information wasn't here, so I added it while I was in the codebase.
"cons" means "conservative. By the way, could you please also add tables basic_proofs, structured_proofs, structured_proof_parts and used_axioms, as depicted in the white board notes?
Don't we need this to do on all output format changes? Or did I miss something here?
Yep @link could be better
shouldn't the parameter names be placed after ``Some mandatory parameters`` instead of after ``are missing`` ?
yeah, thx
if we introduce an interface, it means that we accept other implementations of the interface which don't extend FormBuilder.
Also I don't think we inherit `@api` statements by default.
> Why this file path is hardcoded here? Can't just return array('en', 'root')?
the locales index it's always `res_index.res`, and it can contains all registers the locales (fr, es, fr_FR, en ...)

>To make this really usefull, we could generate the res_index files in the update-data script.
Great, but it's only per bundle, and the stub data it's one bundle, I been if I have my own translation bundle, it's not the same `res_index`
The DI container only instantiate a service the first time you request it, which is why I said you should have a special LazyCacheRegistry with a reference to the container to lazy-load the services.
For a first implementation, I think the simple CacheRegistry (requiring to initialize all instances but without any other dependencies) and the LazyCacheRegistry are enough. People wanting another implementation (based on Pimple for instance) can also implement the interface.
I would not break BC here but add a `foreach` in the caller
I"m fine with multiple check per `isset` call.
it does not seem to be made sure that `$this->template` is set when calling renderBlock directly.
Wouldn't it be simpler to direct people to write

    <script>
        var talkatv_shortcut = true;
        var talkatv_ordered = true;
    </script>
    <script src="http://talka.tv/talkatv.js"></script>

?  Even better would be to figure out a way to annotate the script element itself so the inline is unnecessary (this would also be necessary for compatibility with sites that use Content-Security-Policy, but I realize that may be a way off).
It's not needed. Those variables are global, and the script calls config before taking any action.
If you pass ```userId``` and ```long```, then you wouldn't have to do this parsing.
isn't there a way this functionality could be left to the CPUserActionCell superclass? It's basically identical except that the VenueUserCell content is in visibleView instead of the UITableViewCell contentView
Consider moving to top of phony class for readability
a method `allocate` could be created to return instances of T*
"Average" is generally abbreviated "Avg" ("Ave" is "Avenue")
Ports in Quantum have device owners.  If the owner starts with network: then Quantum owns and manages the lifecycle of the resource.
please change to:

`get(this, 'multiple')`
Why do you need this? Can't you simply use a regular select, and listen the onchange event? That would make this PR much smaller :)
white space before window?
Extra line-break!
this is a very helpful comment!
I think this is the only line of the pull request that I understand :-)

If I understand correctly, this is what makes the activity visible, right?
reuse the lock
NOTE: you can only call registerMetric during prepare or open, should we add a check for this? That's in clojure atom open-or-prepare-was-called a little cumbersome to access from this function.
maybe make case insensitive? and return a normalized version like "ASAP" or so? Or is it always normalized as input?
It's our app secret.  I just make a 50 character hash and put it in
Don't have it installed, apparently.
Returning -1 on all failure scenarios is a bad idea. This makes is hard for the AppController (or a user reading the AppController logs) to determine why failures occur, and thus makes debugging harder. Just return a JSON'ed hash that has the PID and the reason why a failure occurred.
```
$form['foo'] = array(
  '#type' => 'textfield',
  '#element_validate' => 'integer',
);

drupal_render($form);
```
To really be anal and correct, all the error message should really be printed to stderr, not stdout. 
This applies to all your error message, I'll only comment on this one.
But if `g.BOARD in ['vg', 'q'] and !reply.sub` only happens should threadID be 'new'. I don't get it.
ditch the blank line
same answers, too :)
How come this uses decode instead of ascii2unicode (or vice-versa for the other translations)?
Maybe we should just accept both at this point, with no error messages?  The whole `master.addChange` interface will be deprecated soon enough..
tree.shorthand hasn't been removed
You're right, better to append it as a last parameter
No, I have not tried it, and we might only see these bugs randomly,
otherwise they would already be fixed :)

We can try it with this version, but it will take some time to tell whether
it actually works, or not.

On Tue, Jul 31, 2012 at 9:55 PM, Victor Berchet <
reply@reply.github.com
> wrote:

> > @@ -5,38 +5,49 @@
> >      require __DIR__ . '/composer' . '/ClassLoader.php';
> >  }
> >
> > -return call_user_func(function() {
> > -    $loader = new \Composer\Autoload\ClassLoader();
> > -    $composerDir = __DIR__ . '/composer';
> > +if (!class_exists('ComposerAutoloaderInitTargetDir', false)) {
>
> Just to make it clear, have you already experienced some real life issues
> with `class_exists()` and APC (or you _think_ there could be some issues) ?
>
> I have used `class_exists` because:
> - the changes were simpler and I had to work fast,
> - `class_exists()` is [already used](
> https://github.com/vicb/composer/blob/963fedc9a5b30bbc5c08e1ad8dc2c7b64f02ec48/tests/Composer/Test/Autoload/Fixtures/autoload_target_dir.php#L4)
> in the same file
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/composer/composer/pull/961/files#r1277110
>
I don't think anyone needs to know about deprecated internals stuff. I
would remove this note completely.
Please provide the .config and the hardware configuration for that!
dont rescue all exceptions but only charlock holmes
sorry. I've understood.
had to make swipe tests separate as it requires tricking the browser into initialising galleries with swipe support.
I have a hard time making sense of this documentation. Can you please try reword it a bit / fix the english?
This entire block (until line 237) can be more clearly written as:

```
        for fmt in display_data_priority:
            if fmt in output:
                break
        else:
            for fmt in output:
                if fmt != 'output_type':
                    break
            else:
                raise RuntimeError('no display data')
```

This avoids creating extraneous data structures and unnecessary calls to `keys()`.
Thank you! That's basically the solution I was looking for but couldn't think of. ;-)

I'm a little unsure if an ordered dict makes sense or not, because it might be nice to list the supported formats in a specific order. But I don't have any strong feelings about it, so I'll change it back to a regular dict as you suggested.
After looking at the code again, I now remember why I did it this way.  I _did_ actually add the ability to filter by both text and by RegEx, but I did now know how to get this to work unless I retrieved *all* of the rows from the `UiaDll.dll` first.  The way the `ElementCollection` code works is to [break out of the loop in the `#each` method](https://github.com/jarmo/RAutomation/blob/master/lib/rautomation/element_collections.rb#L35) if `exists?` fails.  Having seen that, I did not know of a way to filter the rows out without retrieving all of them first.  I _could_ have it filter by the exact text in such a manner, but the RegEx one would be tricky.  Let me know how you'd like for me to proceed.
This deletion is not actual deletion but move below prefix_suffix_match()
I think we're trying to promote `port.emit` so maybe it's better to mention it first.
This is not enough as it breaks `tabs[index]` supported by a desktop version.
`resolve` doesn't seem to be used.
Most likely if you implement such `race` function you want to make sure that returned promise will be rejected if all the given promises are rejected (As you can see we don't use any reject handlers, which in complete implementation should happen). That would have complicated example so I decided to leave at as exercise to the user.
Maybe in `utils`?
Maybe issue a warning if something is not a string?
the thing is. We can get this working for ```Module``` as well. Thus we can evolve to:

```ruby
Imitate.mock_class('Foo::Bar') # Foo::Bar.class = Class
Imitate.mock_module('Foo') # Foo.class = Module
```

Thus the last one in chain is not necessarily ```Class```.
In context of ```process_name``` method names ```tokens``` and ```last``` looks reasonable to me.
well, it would make more sense yes
@MosesMendoza I think you want to wrap this in:

<pre>
class String
  unless method_defined? lines
    def lines(separator = $/)
      ...
    end
  end
end
</pre>

May need to do the same for `class IO` depending on whether facter is splitting a string or io.
This could also be done with at `when nil` case, which is a little cleaner.  Personally, though, I would say:
<pre>
result_candidates = when request.options[:kind]
  when "foo" ...
  when nil # all three
  else # fail
end
</pre>
Why not `!=`?
this condition should be combined with the one above it…
Just before this line, I've forgot this:

$nameOrAlias = $this->canonicalizeName($nameOrAlias);
Since this is a form element that inherently deals with strings, my preference would be to stick with strings by default and leave it up to the hydrator to decide on the ultimate value/object. I'd rather not force it upon a user to work with DateTime, when, intuitively, with Forms you're just working with string values.
A constructor always return a class instance
Remove empty docblock.
Hmm, with strict mode Off no exception thrown and this line will raise fatal error
*sigh*

I'll just make a list :P
@jtdaugherty Please see notes from @pames
this is wrong. a ``tgz`` archive cannot be handled by the zip downloader
Sorry for the delay... `Model::config` seems to take only metas as param. Imo it should be something like that :
`@param array $meta Meta-information for this model, such as the connection.` instead of `@param array $options Possible options are...`
Might be interesting to replace `$options` by `$meta` in the function ?
Parent is passed in as the user logged in and passed in when creating each Contact object
Oops, I did that change in the github.com, their web editor mustn't like 
unicode :P

-----Original Message----- 
From: Daniel Doubrovkine (dB.)
Sent: Monday, July 16, 2012 4:21 AM
To: Simon
Subject: Re: [resourcelib] General solution updates (vs2010, nuget, build 
script) (#5)

> @@ -2,7 +2,13 @@
>
>  **New Features**
>
> -  * [#2](https://github.com/dblock/resourcelib/pull/2): Added 
> `VersionResource.FileFlags` - [Andreas 
> Ländle](https://github.com/alaendle).
> +  * [#2](https://github.com/dblock/resourcelib/pull/2): Added 
> `VersionResource.FileFlags` - [Andreas 
> Lï¿½ndle](https://github.com/alaendle).

Something went wrong with encoding of Andreas' name here :)

---
Reply to this email directly or view it on GitHub:
https://github.com/dblock/resourcelib/pull/5/files#r1165602
I will, but FYI: all other slots also don't have use statements.
you don't need to do that. if the method isn't present it won't be called, IIRC.
Single hash
group `sourceURLs` with `sources`
What happen if you run this on your laptop, where there is no PBS server to connect to? 

You should provide some extra code that checks and warns for a situation like this.
`scope` is not handled by OAuth1
The `signRequest` should also support multiple methods in that case.

From a quick look LinkedIn, Twitter and Flickr support `HMAC-SHA`, so maybe those alone will be a good start? If someone needs different signing methods we can add those later.
I need to use this script to understand it fully.

I am tired, i did not get everything it does.
Would all contributors not have an IRC name? And seen as we're not longer showing their username on their profile and instead are choosing to show their IRC name surely it would be better to have something there? But i suppose i'll make an exception for you and allow you to have none :)
@sammybahamas - is this the copy you asked for?
So, the above two could look something like this:

var playerTypeLoading = {},
       playerTypesLoaded = {
         "vimeo": false,
         "youtube": false, etc
       };

for each through each playerTypesLoaded

Object.defineProperty( playerTypeLoading, forEachPlayer, {
  get: function() {
    return playerTypesLoaded[ forEachPlayer ];
  },
  set: function( val ) {
    playerTypesLoaded[ foreachPlayer ] = val;
  }
});

end for each

Something like that is what I had in mind.
All of our tests should pass in a number for the expected tests instead of using `expect( 5 )` for example
этого пока нет, я бы убрал
Just a thought, if the user selects "Attribute" radio button, what if we disable Username or Federated ID text field and basically force the user to add the attribute in the Additional Attributes text area.  If we go that route, we can remove the Attribute Name and Format fields from the UI.   In essence we would have all attributes defined in the additional attributes area and have one method to construct the attributes.
`@referrers.count` is 0 when the object is initialized (an object doesn't belong to the project until another object starts to reference it), then if you remove all the referrers it goes back to 0, yet the object is still functional (this is why I removed the `destroy` method) and can still be referenced by another object, bumping the count back to 1.
Guessing this should not be hard-coded to your OpenShift instance.
I thought I had posted a line note about that... what about a simple if ( $executable == eZINI::instance( 'image.ini' )->variable( 'ImageMagick', 'Executable' ) ) ? it might require an extra test with the path, but that would work, wouldn't it ?
ping @clemherreman
yes! i wrote a test: https://github.com/fwenzel/django-sha2/pull/13/files#L16R21
параметров сколько минимум?
`@sitemap.pages += proxy_pages`
Links don't always link to another page, maybe I shall point it to #share-options then it would make more sense. It's a link because I wanted to take advantage of the native keyboard support.
Well the goal is to have different command laws for each mode, so you have to call it in each mode. As long as you only set the RC_MODE command there is no problem, but I understand your concern if you have the SetCommandsFromRC node with the regular commands as well. So I guess I'll make the command laws accept the mode as input, that will solve all problems.
I can relate to the functions idea, but I don't think anything is wrong here. 

"Why apply the roll/pich to the setpoint instead of the current yaw?"
As I explained on skype, that will cause the a/c to roll (around the earth axis) when pitched 90 degrees and trying to yaw. For quadcopters this might be desired, for a transitioning vehicle it is definitely not. I do not think it is possible to unite applying pitch and roll to current yaw on the one hand and earth bound setpoint on the other hand.

"And now you actually apply the yaw command when you are not in_flight as well... at least for quads this is not desired."
I in fact do not, I only apply the pitch and roll to the actual yaw. No yaw is applied when not in flight.
The spelling rules on this are [unclear][1] , I've changed it to _verder gaan_.

[1]: http://www.onzetaal.nl/taaladvies/advies/verdergaan-verder-gaan "Verdergaan / verder gaan, language advisory, Society for our Language / Genootschap Onze Taal"
Hmm, I'm not sure about this. Node runs on V8, I don't think we'll ever run in to a case where isArray will ever not be present on the Array prototype
These have been switched to javascript events. The locations where events are fired were revised, can't remember off the top of my head if that involved moving this to `_setGroupMembers`.. I think it did.
Do you want me to make any changes as part of this PR ?
The index worker is now responsible for gather this data, so if configured as a slave it should not impact the latency of actual app nodes.
The exact same remark applies for ``ScalaStepOver`` and ``ScalaStepReturn``
Don't we get into a licensing conflict here? In principle we could license the `debug.tests` bundle with EPL, and keep the other bundles under the Scala license?
Is this catch block necessary inside of the test? It seems like it would hide errors that should fail the test.
Shouldn't this pointer be checked when it is first set instead?
@adamsutton is there any style guideline for user contributed code? what about opening braces?
Create an entry in the log file that the plugin doesn't exist in the filesystem and it's being deleted from the DB
Until it's confirmed how ZAT is going to manage development values, let's keep these out of here for now.
make sure any errors we get from the reflect package get trapped and returned.
make sure competing goroutines on an Execute dont do silly things compiling
No it's fine, do you think I should test for a string where the wrap is exactly at 76 chars ?
Вынесите категорию из main.m в отдельные файлы.
I think these changes need to be made to the .gyp file, otherwise they will be clobbered the next time the project file is generate. Can you try running scripts/make_appshell_project.sh and see if it works?
what's the point of this? If I'm not mistaken, it makes the following lines, and the whole method unnecessary.
I don't think you want to select ALL 'ul' in the document, maybe just the ones inside of your x-tag?
spaces before and after ===
Why did you change all these to read the ivar directly instead of call the reader? If `@path` and `#path` are different, you probably need a new method name for `#path`
The cookie should be the string `'True'`, not the actual boolean.
hemi : str
Let me see what I can do.


On Thu, Dec 6, 2012 at 7:23 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> >
> >          if self.preload:
> > -            if isinstance(key, slice):
> > -                epochs._data = self._data[key]
> > -            else:
> > -                key = np.atleast_1d(key)
> > -                epochs._data = self._data[key]
> > +            self._data = data
> > +
> > +        if not isinstance(key, str):
>
> What I had in mind:
>
>     if isinstance(key, str):
>         name = (key if epochs.name == 'Unknown' else 'epochs_%s' % key)
>         key = (self.events[0:, 2] == self.event_id[key])
>     else:
>         name = self.name
>
>     epochs.events = np.atleast_2d(self.events[key])
>     epochs.name = name
>     if self.preload:
>         select = key if isinstance(key, slice) else np.atleast_1d(key)
>         epochs._data = epochs._data[select]
>
>     return epochs
>
> you can get rid of ._get_events()
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2338818>.
>
>
this is wrong as you neglect first_samp which is an offset used for example to concatenate 2 raw files acquired sequentially
fft based filters are fine with long signals like raw. For short like in most stc we need a short IIR filter that is zero-phase. Something like this http://www.scipy.org/Cookbook/SavitzkyGolay for example. Then decimate.
Otherwise we could just drop this helper function and do the standardization on the entire data matrix from within the main function...
I would say if not None it has to be above 0. I think it's a C programmer behavior to use 0 as a default behavior :)
this script file is the same as task1.js in the pure node.js script, but without http server
I still need http module to get XML data from BBC website using request and response in http module
If you set these to null, does the ConceptSaveHandler insert the right values for you?
ok, will shorten
Yeah, that's right.

I'll try to think about a way to do that.
There should be no space after `{` or before `}` in the hash.
Like everywhere else, use the double-colon to setup the php code block:

    to set your own mode::
现在感觉
“设定变量 XXXX 的值”
更流畅
Isn't CamelContext mutable?
OK, try it now.
The way that this prints, "The feature each_char option to symbols() and var()...," seems grammatically incorrect, or at least grammatically sloppy.  I think it would be similar in most cases to say, "The feature such and such is deprecated."  I'm not sure what a good way to change it would be, though.
`if s[0] in '+-':`
Ну и здесь аналогично.
Лучше такие магические числа в енум запихивать, типа, `enum Columns { Name, IsValidated };` и т. д.
Ну и здесь та же херь с удалением.
` + ""` не нужно, зачем прибавлять к строке пустую строку?
to accept this pull request please make a new commit on this pull request to keep this line :
```html
<meta http-equiv="Content-Type" content="application/xhtml+xml; charset=utf-8" />
```
I tried to get those tokens to work, but they won't validate and gives me the error: Your session timed out while posting. Please go back and try again.

I have no idea how they work (except it's a sequrity fix) and how to fix it.
You must not write a return annotation when the method does not return
please use curly braces
Please declare all used namespace in the file header, and remove extra comments
I've added notes about simultaneous vs sequential PSF fitting, and about the residuals and the position tuning.
also you can use `re.match(ur"%s\s+...` and avoid escaping the back slash
Yeah, you'd think we would have had that on hand already. I can do that.
Renaming to OwnershipStatistics.
Yeah, after fixing the FQN it all works fine. False alarm :)
Yeah because we have CancellableCommand to denote commands that are 
cancellable... and then CancelCommandCommand....well I can see your 
point. Matter of taste I'd say but I'll change it.
On 12-10-23 10:49 AM, Manik Surtani wrote:
>
> In core/src/main/java/org/infinispan/commands/CancelCommandCommand.java:
>
> > +
> > +import java.util.UUID;
> > +
> > +import org.infinispan.commands.remote.BaseRpcCommand;
> > +import org.infinispan.context.InvocationContext;
> > +import org.infinispan.util.logging.Log;
> > +import org.infinispan.util.logging.LogFactory;
> > +
> > +/**
> > + * Command to cancel commands executing in remote VM
> > + *
> > + * @author Vladimir Blagojevic
> > + * @author Manik Surtani
> > + * @since 5.2
> > + */
> > +public class CancelCommandCommand extends BaseRpcCommand {
>
> |CancelCommandCommand|? :) Why not just call it a |CancelCommand|?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/infinispan/infinispan/pull/1369/files#r1916859>.
>
1 day wait timeout??
Hmmm, this doesn't look right to me. The isPre=true even should be fired before the entry has been updated. See PutKeyValueCommand.
What's different in e.g. testSingleCacheWithKeysExecution to make a shutdownNow call necessary there? 

If you don't need to shut down the executor service I'd rather see it declared inside the block, as it is it makes me thing that you intended to add a shutdown call but then you changed your mind and you didn't revert all the way.
Opened github/objective-c-conventions#28 to discuss using `copy` in places like this.
Forgive my naivety but the options parameter takes a pointer as an argument so I just assumed that it was best practice to put it on the heap. 

Stack preferable?
BUG: I intended to use the edgecolor & facecolor and then reset them at the savefig level so that the backends don't have to do this. Unfortunately this is half baked at the moment (writing a test for this might be interesting).
Good point. Though, another option would be to return a `PolyCollection` instance instead of wrapping around imshow, just like `hexbin` does.
cheeeeeeeesssyyyyyyy
I'd clean this up before merging
A problem I see in this test is that all of the values being relied on here are generated within the test. What would probably be a cleaner way to do this is to either:

1. We assume the sdcard comes prepopulated in automation with a certain set of videos, so this test should follow the expected behaviors when X videos are included
2. We generate the test case variables (such as the name here) by getting from the sdcard directly through the device storage api.

(2) probably is going to be easier and cleaner to pull off right now, so I'd suggest going that route.
I did. Then I ran 'git grep image'. I still don't see anything that could be using it.
This is good to get started - need to replace this with something more dynamic. StreamParser will help here.
try to document all those classes properly. They look very generated
somehow :-)

On Tue, Aug 7, 2012 at 4:10 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/Soap/FaultElements/FaultActor.cs:
>
> > @@ -0,0 +1,10 @@
> > +﻿using System;
> > +using Org.Openengsb.Loom.CSharp.Bridge.Protocol.Soap.Parents;
> > +
> > +namespace Org.Openengsb.Loom.CSharp.Bridge.Protocol.Soap.
> FaultElements
> > +{
> > +    class FaultActor : EndnoteElement
> > +    {
> > +        public FaultActor(String message) : base(message) { }
> > +    }
> > +}
> > \ No newline at end of file
>
> It is not generated. It cames from my architecture of a SOAP envelope
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321506>.
>
>
When you add the reference over VS then NPanday add the path to the dll. When you add it over a maven reference, then NPANDAY add a .reference in every project, which is used for VS to locate the dll.
We don't. The COMPASS compiler adds it automatically. It's stilly, and it just never got stripped out... That said, the CSS is a bit of a mess in several places, so I'll finish switching SCP CSS over to LESS (we don't need all of the features of COMPASS and LESS is a little easier to deal with) and including the uncompiled source soon. I'll try and do it this weekend. I've been meaning to forever.
Fixed in https://github.com/Seldaek/fig-standards/commit/a4e533108e361475604cab7c91c60910cc68b7b1
Sounds good. Let's keep it uncommented in the repo though, and then comment locally as a workaround until we fix this thing. Maybe?
Oh, cool, thanks @sritchie. I'll merge this in.
That fastcgi_split_path_info and the NOTE comment are in the files that the package installs. It is to prevent arbitrary PHP code execution in nginx. See, for example, https://nealpoole.com/blog/2011/04/setting-up-php-fastcgi-and-nginx-dont-trust-the-tutorials-check-your-configuration/
i agree, it should be new PR.
1) Create failing unit test.
2) Get annoyed with trying to pass it; comment it out.
3) Later, fix code.
4) Forget to uncomment the unit test, which now passes.

New commit coming shortly...
Do we need to also `chmod` the copied file so that it's executable?
Yes, we have a `pusher` method that uses `Pusher`. this file wasn't cherrypickable before which I noticed when I cleaned up tests
"else if" -> "elseif" .. assuming that still works in JS?
also - new line before the <
>= 4.5.0 ?
`NDData` would need to get **kwargs as you might want to set the error=None, but want to set a mask. 
In this case I would just pass exactley what is required to `NDData`. so `from_array(disp, flux, error=None, mask=None, flags=None, wcs=None,
                 meta=None, units=None, copy=True)` and then pass this to `NDData`
The benefits of doing it have already been stated. If you know of any downsides, we can maybe change it.
I don't think this should be done in the extended resolver. A ``kernel.controller`` listener may be better.

and you can simplify this:

```php
<?php
foreach ($request->attributes->get('_before', array()) as $callback) {
    call_user_func($callback, $request);
}
```

Btw, I added the request as argument to make it easier to use it in the callback
Are you sure ``$asset->getSourcePath()`` has the correct type as ``string|null`` is not a sub-type of ``string``?
Are you sure the method ``setTitle`` can be called on ``$contentPage`` (of type ``string``)?
Денис, у Вас какая-то проблема с кодировками.
I dunno about "see through". Myles suggests "transparent"
this is needed for 'getenv'
yeah, it's tricky to find the right balance. Perhaps keep similar feel, but accomplishing the task the way you would in C#? I think the audience is C# programmers so whatever seems most natural to them.
Doesn't look like it:

    $ cmake --help-variable WIN32
    cmake version 2.8.6
      WIN32
           True on windows systems, including win64.

           Set to true when the target system is Windows.

    $ cmake --help-variable WIN64
    cmake version 2.8.6
    Argument "WIN64" to --help-variable is not a defined variable.  Use --help-variable-list to see all defined variables.
Sorry, I meant "returning".  See how this line is ``return JError:: ...``.  So, just leave those as ``return JError::raiseWarning( ... )`` etc.

Can't change my username sorry ;)
speaking about readability... please a space after the # :p
Doesn't really make sense to me. Granted it's an unlikely case, but we probably wouldn't want an OutOfKitchen check to also catch a WrongPrepareError which is what would happen with the current subclassing.
TODO: Fazer GET com request body não está no (RFC)[http://tools.ietf.org/html/rfc2616] e não é cacheable. Temos que repensar isto.
Sure? The recent update to the ntp cookbook doesn't have a .chef/knife.rb, and it is passing in travis.

https://github.com/opscode-cookbooks/ntp
It seems like this section of code could be simplified if we just always return a thumbnail from our servers instead of sometimes linking somewhere else. The main benefit (not hitting the database if there's an external url?) is lost since we're now getting the image anyway to generate the resized versions.
Use two argument version instead of dict if you have only one value to set. (`.css('margin-left', max);`)
Why are you doing list? Why not simply iterator and use `yield` for each of that records?
But probably you will have to do a server-side query. Have you tried asking the question on StackOverflow?
I suggest you use string field. You never know what we will get as ID. ;-)
`scomments`?
Set `null=True` to allow empty list for comments.
Move this bellow, just before `after` line so that there is smallest delay between removal and adding. (You can construct `message_info` before.)
True–however once taglib supports free-form keys I'll stop using Ex Falso. :-) Anyway, I agree that the issue is not worth breaking read/write symmetry, so I'll remove the prefix detection.
Maybe log a warning for the else case too?
Please change to return false for better readbility.
You are right - sorry, I just noticed they are different fields.
Fixed, though github hasn't flagged your comment as outdated.
`fun erlang:is_integer/1` ?
```php
if (null !== $credentialCallable) {
    $this->setCredentialCallable($credentialCallable);
}
```

Ternary would probably fit an assignment :)
It´s not realy SNMP constant too ...
I realy don´t know where to put them.
Parce deja un espacio antes de `:vcr`
use `os.chmod` instead.
Why you've extracted the setup of `restProxy` in it's own method?
Also title can here obviously be null or undefined. That will get stringified later, it seems?
The test and the define here don't match up. Just noting it so it doesn't get completely forgotten.
Why have two separate tests here? Why is this not just `if i <= 10 then ...`?
This is already on line 25 of this file
Yeah, see my comment in the PR. Working on predict doc templates, so I can make my life easier on this. Will post to ML.
you should remove this. It is quite useless
This return type doesn't have leading slash
This should be ```e.data.start >= e.data.end```, since a track event can't start when a video ends
Empty comment blocks in this class.  Also, out of curiosity, why is checkstyle turned off above?
We can go back to all caps for the magic numbers if people prefer that convention.  I prefer reserving all caps for preprocessor macros and constants (to highlight their even more special status).  

The way I did it, all the magic numbers in the code are preceded by `sbp::`, so that tells you right away where it is set.
Yes, will push.
Pushed, and noticed a few missing group definitions that were, to put it bluntly, shameful!  All fixed and pushed.
It's pretty easy to do, but there are two options, and they'd both involve some changes to the C++ API:

 - You can return the actual object held by the `InterpolantXY`.  You'd probably want to change the return type of `get1d` to return a non-const `shared_ptr` in that case:
```
// In Interpolant.h
boost::shared_ptr<Interpolant> get1d() const { return _i1d; }
```
Then you'd just need to register shared_ptr conversions for `Interpolant`, and it'd all work fine:
```
// In pysrc/SBInterpolatedImage.cpp
bp::register_ptr_to_python< boost::shared_ptr<Interpolant> >();
```
The only problem with this approach is that it gives the user non-const access to the innards of `InterpolantXY`, and if we have any mutable `Interpolants` they could modify it and mess up the `InterpolantXY`.  If we don't have any, and especially if we've declared `Interpolants` to always be immutable, this is fine.

 - The other option would be to add an interface to return a copy of the `Interpolant` from the `InterpolantXY`.  That would require adding a `clone()` method to `Interpolant`, and, well, at that point you might as well add a `clone()` to `Interpolant2d` and `InterpolantXY`, and then you could just call that.

Hmm...all that said, if `Interpolants` are in fact always immutable, there's actually no reason to copy them - there's nothing wrong with sharing them if you know neither owner can modify them.
Good then we all should be set then.  It's a little curious why it shows up in the diff for this change, since it should be a no-op.  We should just take care after pulling in to inspect the model again to make sure this class doesn't show up twice or anything annoying like that.
does `action :restart` also start things if they are stopped?
I started off with it being inferred. In an early version I inferred it from parent==null, but that's not good enough (because could be creating memento as other modifications are being made, like unmanaging the entity). 

It can only be easily/reliably inferred once you have deserialized so have the entity instance and can do `instanceof Application` (or the class to do isAssignableFrom). I think it's useful to have it explicitly in the memento. And also it much easier to implement BrooklynMemento.getApplicationIds when deserializing (because at that point you don't have entity instances).
This is most likely due to a database misconfiguration, it shouldn't be fixed in the code like this.
Signature of regionToRects is incorrect. I will fixes it.
Yeah, you can add the newline in a new commit on your master branch, and this PR will pick it up.
Do you think we can have some sort of documentation there as a comment documenting the function (I know it wasn't there before but it would be nice if we can have it now).
These buttons weren't working for me - I get an error message saying I have to select some lines.  Shouldn't they just be links rather than submitting buttons?
Who cares just add it.