labofsahil/github-event-dataset-2012 huggingface dataset:
Do we need to validate (or maybe we already do?) that clients only provided handles >= 0 ?
def clean_deprecation_date(self):
menufacturer -> manufacturer
self.device has data from db
rfind always scares me a bit, is there a better way?  What's going on here?
What's our reason for making this virtual?
Yes -- this is expected to throw an error when the name you pass in is not found.  There is even a test that makes sure it throws (and catches) an exception when you lookup an unknown name
Alright let me know if I can help with the merge.

On Dec 18, 2012, at 10:09 PM, "Ben Combee" <notifications@github.com<mailto:notifications@github.com>> wrote:


In list/samples/ListContactsSample.js:

>                               {name: "divider", classes: "list-sample-contacts-divider"},
>                               {name: "item", kind: "ContactItem", classes: "list-sample-contacts-item enyo-border-box", onRemove: "removeTap"},
> -                     ], reorderComponents: [
> +                     ]/*, reorderComponents: [


oh, maybe not... I want to pull in your new samples too. I'll just merge and then fix.

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/layout/pull/115/files#r2459821>.
Right. That piece of code ought to be refactored. I would only keep the option to cache metadata, ie make it possible for the client code to cache it if it desires so.

For now I am nervous about potential of hidden bugs. RETS servers have so many quirks. It would be good to make it easy to swich back and forth between two versions of this gems. Once we feel confident with the new code, I'll do more refactoring and code deletion.
This needs to have a dash. `utf-8`
Don't worry about it - I've got some more work to do on JaCoCo before I get to EclEmma :)
If that's your only quarm, I'm going to merge it in...
This is weird.  Whats wrong with uncheckedInstantiate only having the class variant...are the others used? Screams premature optimization.
I think we should be aiming to cull API rather than expand so much for v1.0, less public API...less to maintain...less likely to make breaking changes.
A problem with this is that, since `delete` is not dynamically dispatched and all `Object` subtypes are `delete`d by `ObjectPtr`, it will try to delete `ANode`s using `Object::operator delete`, which will try to `free` memory managed by the `BumpPtrAllocator` and crash. Luckily AST nodes don't ever reach zero refcount currently, but if they did, stuff would break.

To make subclass-specific deallocation work in C++ you need to do something like this to make deallocation happen as part of destruction (and then never stack-allocate):

```c++

struct Base {
    // overload operator delete to do nothing so that `delete base;` just invokes the dtor
    void operator delete(void*) {}

    // invoke the real virtual deallocator as part of the dtor
    virtual void dealloc() { ::operator delete(this); }
    virtual ~Base() { dealloc(); }
};

struct Derived : Base {
    void *operator new(size_t sz) { return CustomAllocator::allocate(sz); }
    virtual void dealloc() { CustomAllocator::deallocate(this); }
};
```
This is a problem with the BigIntArray implementation as well. I wouldn't suggest this without extremely careful performance testing as it's the core bobo class.
We have svac_sum().  In Excel, the multiplication version of SUM() is called PRODUCT(). It seems that's the de-fact name when googling around.
From my current test, the result is stable. I don't know if the text has bug or not. That's what i can figure out for now. Any suggestions are greatly appreciated.
What is the encoded_table?? Isn't it result_table?
The API doc already includes this as a footnote. However, I agree that we could put as comments.
i don't think `translateY` is hardware accelerated so you'll probably want to use `translate3d`
Shouldn't this be $i < $rgb?
Yes, I e-mailed the maintainer Tomas Styblo with my patch, but not hearing back, I researched how it was being used on Linux. That's how I cross-referenced with what Debian was doing.
Let's just wrap these all in a single `if build.head?` instead of three postfix conditionals. Also, they should probably be the symbol versions (`:automake`, `:autoconf`, `:libtool`) instead.
pango, potrace and libspiro not even optional?
You guys didn't want me to break out the Perl stuff!!! :-/

Ok, i'll go with that one, but I think the original is more clear of the intent:

* if the `@path` is not nil, an empty string or '/', put in a `data-path` attribute for the js to deal with.
* else, don't put anything in - there is no path

Whereas now we're just doing string manipulation regardless...
this gives an error when $_REQUEST['redirect_url']) is not set
imagine your http root is '/var/www'
→ requesting /index.html serves /var/www/index.html
imagine you have an alias named 'alias'
→ requesting /alias/index.html serves /var/www/index.html
imagine you put owncloud on a subdir named 'owncloud'
→ requesting /alias/owncloud/index.html serves /var/www/owncloud/index.html
The call to the function is done before checking if background jobs are disabled and therefore should be executed either way. 

If cron.php is never called though temp files will be deleted only if placed in a directory cleaned by the OS itself on exit (I'm thinking about /tmp)
@rmocanu because the session middleware tries to override it, and this way it gets it's writable property set to false so it can't be overriden
@rmocanu: no acknowledgement, would come in handy for signaling errors and handling them on the client
Do we need to update these to ```k.to_s =~ /^@/``` considering we're dealing with keys rather than strings?
Nice catch! this one is totally legit!
HA HA HA! Of course! Good call. :)
Either clean out debug lines or use `logger` so they end up in the right place
https://github.com/SpoutDev/Spout/blob/master/src/main/java/org/spout/engine/world/SpoutChunk.java#L874

So, something like

((SpoutChunk) chunk).getFutureSnapshot(..., ..., ..., true);

You can only have one pending per per chunk.  So, make sure you wait until all current futures are free before calling any more.

The method returns null if there has been no changes since the last call.
OOps. How do you feel about a one-liner { /*todo* }; instead ?
The first arg here is the value of `_loadedAgents[i]`, not `i` itself.  As-is I think this code will never try to unload anything.
Sublime's behavior is strange. Instead of rotating, it closes the list and then allows the editor handle the key event, which results in surprises, like the cursor moving or, in the case of page up/down, the whole page jumping away. Xcode doesn't handle page up/down at all; it also scrolls the page and closing the hint window.

I think the user should have to explicitly request that the hint window be dismissed instead of having it disappear when the navigating off the end of the list. The other option is to have the selection stick at the bottom or the top but, after playing around with it for a few minutes, rotation feels better and more useful to me. I'm going to commit rotation to this pull, but I'm happy to be overruled if you think it should stick instead!
Also, this block and the segmentCounter check below it seem to be duplicating a lot of the logic above in the curChar special-case block.  Is there a clean way of consolidating those so there's less code duplication?
Should be double quotes.
Please add a line break (or 2) to make this code easier to read.
typo: "to: Number" should be "top: Number"
Were you planning to resolve this TODO before committing?
What is `e.delta` doing here ?
used this
no need for "final int"
Convention dictates that function names be written in either camelCase or snake_case. In Java it's common to see people writing method names in camelCase. Either way, casing can be pretty important so that you can tell off-the-cuff whether something is a variable or a method or something else. I would recommend renaming this method to `modifyMember` or something like that for clarity.
The `action` here assumes hosting on the root path. Use `url_for` to generate the whole URL.
I'm following by example... only certain methods in jekyll are actually TomDoc'd, not everything.
Why the case change here?
Doing it this way, the container will still accept pointer events :(
Same here. Just including it would be best.
Nice hack :).
See this ticket https://webmademovies.lighthouseapp.com/projects/65733/tickets/1886-add-labels-option-to-manifest-with-options

Would be better to set labels/options instead of doing the conversion here.
Just return after the if is done, and drop the else
If you're doing `-moz-transition`, do:
```
-webkit-transition
-moz-transition
-o-transition
-ms-transition
transition
```
@k88hudson Should I remove videojs?
pass an Error instance, not a String.
I thought we weren't using throw?
hmm... controversial..
log.err(e, "Failed to insert a trace: trace_id=%r,span_id=%r" % (trace_id,span_id))
-h, --help                             display this help and exit
-p, --prefix=PATH              set module installation prefix
-a, --add-module=PATH  external module which will be compiled
-s, --with-nginx-source=SOURCE set nginx source root
Also expensive. If you frequently need to find vector components based on some key, I would really recommend using maps or the awesome multi_index_container.
Could this be AppConfig.use_foreman? since this is very foreman specific?
I removed the restriction because there already is a Validation that checkes if given username is longer then 64 characters. If it is the user isn't created, so I thought from the description of the bug that it isn't necessary to haverestriction for 255 chars. if there already is for 64 chars.
The number of arguments to all these methods are getting to the point where they should be refactored to take (*args, **kwargs), and then 'unpack' those inside the functions.
Check for dups.
I believe there is a css3 mixin to extract the vendor prefixes for this: `@include box-sizing(content)`. But that shouldn't block this pull request.
This is not a huge deal, but for consistency's sake, perhaps change this to ``import *`` and add  ``__all__ = ['logger']`` to ``logging_helper.py``?
The signature change to `tigger_ownership_handoff` breaks `handle_cast(ring_changed)` code. Please fix the `ring_changed` code.
I think yes, as in OptionsModel::Init() we take care of this, as command-line options override the GUI settings.
Shouldn't this be <= 104900 ?
Please add this to the enum, instead of defining a macro (same for BTN_MASK below).
Typo "pepend"
@lorenzo It's for adding fields to query. From what I understand the patch is to address the issue that when specifying 'fieldList' for saves many forget to include foreign keys in the list and thus associations are not saved properly.
Yup remove both
I think the line here should be indented to match the "If" in the statement above otherwise rst renders this as a separate line apart from the bullet.
4 spaces, no tabs.
the constructor should not be responsible of the logic as it would make instantiating the object very consuming even if you don't really use it later
Same comment here as before. =)
I think this should be getType, or am I missing something?
you don't need the maint_data variable there, you could just have the hash and that will be the implicit return value from the method.
as MBS says
wondering if we can unwrap these CimWhatever types
I have added some code to check the input data. This however is relatively expensive (computationally). A user who demands performance probably wants some means to disable this input check. However, according to the Java docs you should not use assertions to check input data of public methods: http://docs.oracle.com/javase/1.4.2/docs/guide/lang/assert.html (Section preconditions). Any recommendations?
I think this method should call `current_user` and `current_user` should be modified to do the couch lookup lazily and cache the result in a controller instance variable. (It already stores it in `@user`, but it does the lookup every time it's called.)
Sir, fixed. Sir!
I'd line-break after the parenthesis to save the ugliness of three really short lines afterwards
Am I sure?

Shouldn't be `var endTime = Date.now() + timeout + interval;` instead?
And what about negative values? (e.g. `var endTime = Date.now() + Math.max(0, timeout) + Math.max(0, interval);`)
And what about the lack of parameter checking?
* ".../" won't really work I don't think :)
* collector_app.py should be executable in the repo
You could probably even just put this in `setUp` and not write it once for every test.
and yes - in worst case we have 2 saves as opposed to doing 4 saves regardless
requirejs is already included in packages.json - I think the issue was actually that the path to r.js in the Makefile was not local, this was fixed by 4bf11321b200bdae919d96760fa9d9c58dca46df . requirejs shouldn't need to be installed globally.
Oh, indeed. I confused myself. Was thinking of the wm malformed_request callback. Carry on :)
you should not sue ``else`` here as the ``if`` returns
You should note that you throw `\InvalidArgumentException` in case of unknown driver.
The name is really weird. A class implementing this interface does not represent multiple cache operations. It is a *driver* supporting batch operations
the property should be private (we use private by default and switch stuff to protected when we have a valid use case for it, as protected stuff are potential extension point and so are concerned by the BC)
please #define constants for 15 and 17, because they are used on more then one place
I think the name could be more specific.

Maybe `def set_token_and_endpoint`.

Or keep name and have two private methods, `set_token` and `set_api_endpoint` separately to avoid the gross "and".
if options.closeButton is a string set it as button tip
in case your environment is not set as en_US.UTF-8. In some other countries a comma (',') is used as a decimal point which crashes the agent.
I moved it on another commit (the second, referencing #2974)
Use the ```add_image``` method - we need to make ```self.img_factories``` private... (separate PR if you want to do it)
OK oublie mon premier commentaire :p
why do we need to consider exceptions at all?
If there's no functionality just remove code or comment it. I prefer removing.
The `app` in the middle is redundant.
The file has inconsistent tabbing. I'll fix this in a future commit.
for the records, we'll deal with this in https://issues.jboss.org/browse/AS7-5793
I'd really like to discuss this with the rest of the team. I can't help but feel this is very wrong. grunt-cli should be installed globally before trying to grunt any project; it should be treated as a system-level dependency, like make or java.
Even with #72 implemented, this list might still be useful for the homepage, that's a good usecase for me.
we should extract `doc`, `screen`, `titleNode`, `messageNode`, `action1Node`, `action2Node` in variables on `ConfirmDialog` and have an `init()` function
I would like to remove those and use window.confirm instead. That would make those dialogs consistent with the rest of the UI and that would remove the need to code that inside this application (also I can see quickly the text of those dialogs when transitioning from the main view to the 'new' view).

For the moment window.confirm is not implemented but it will be in https://github.com/mozilla-b2g/gaia/pull/1758 which I would like to land asap.
onode and tnode are not very good names (i have no ideas what they are)
`ssids` -> `networkKeys`
this.onUpdateProgress.bind(this, 'start')

Wouldn't that work?  And the same for the other two cases below.
Remove this UA string probing check. File or reference a bug on this with a comment.

If desktop B2G or Nightly failed, let it fail. Phone is the only thing that worthy of a workaround.
Okay, it wasn't transparent for me, now I understand. Thanks.
We don't need this line :)
The way you've written metadata.js, I don't think this else clause will ever be triggered.  If there is cover art, it is always resized and saved, right?  So I'd just delete this old code.
OMFG! :-s
Hmm, I am not too comfortable with all app sharing the vars, I suspect most apps will not modify them but putting it on the prototype is not expected.

My suggestion is to put it on the constructor...

```js
function AppIntegration() {
  // ... old code
  this.testVars = getTestVars()
}
```
hmm i guess it's a matter of style, but maybe break it up so it's not all in one line? for readability?
Won't this crash? d_ptr is uninitialized, fromString uses it.
I don't get this one.

I can't put the close commands in a finally block, as the error gets thrown outside, and I don't have a reference to the streams there.

Or do you mean I should do Algorithms.closeStream(is) ? What does it make for a difference? The error doesn't get thrown outside anymore, so it's hiding the error?
Do we need all this imports? #6
@mbj I had to add this method. It is available in veritas-do-adapter. Do you know why it's missing in the mongo adapter?
see above comment :hamster:
デフォルトでは saved job は "Single Execution" で1度に1回実行できます。

→

    デフォルトでは saved ジョブ は "Single Execution" で 1 度に 1 回実行できます。

ジョブ、半角スペース
Why is here a reference to the Impl?
cool trick.
Actually just do
```coffeescript
o = board: board
o.herp = derp if condition
etc...
```
looks like it's more than 79 columns wide? same with line 96 i think
Very true. Should make more sense to have them right after the action statement and then remove the finally blocks.
You should confirm this is a graphic.
All right, let me add it.
`window.onload` will be much more clear
This should go on the InstalledRepositoryInterface not the RepositoryInterface.
Use size_t instead of unsigned short int here. There's no difference in performance, and trading a few bytes for clarity is ok.
The ruby gem doesn't raise such an exception.
You're right. I had it there when you could pass a flag to set YAML.
Please remove if unnecessary.
I think it would be way simpler if you would leveraged Array methods instead:

```js
function isIgnoredFile(name) {
  return IGNORED_FILE_PREFIXES.some(function(prefix) {
    return name.indexOf(prefix) === 0
  }) ||  IGNORED_FILE_SUFFIXES.some(function(suffix) {
    return name.substr(-1 * suffix.length) === suffix
  })
}
```
Easy -- the browser we'll be running it in and care about most -- Firefox :-)
I guess I need to change that to `self` or to a string.
Well, you'd have to handle a special case for behavior parameters nor being actual rules... I think it's enough to mention the ability to write a simple preSave() in the doc, don't you?
This has a handful of problems - mostly Unix oddities:
1. Putting it in /tmp with a static name means anyone else can, as R.I. points out, create a [Symbolic Link race](https://en.wikipedia.org/wiki/Symlink_race)
2. In order to have atomic rename on Unix we can't have cross a file-system boundary; that means you need the temporary file in the same directory as the target file.

To generate the temporary file you should use the [mktemp(1)](http://stackoverflow.com/questions/2792675/how-portable-is-mktemp1) tool to generate the name.
Chris is right:  This is the crux of the fix for `$libdir` not being in `$LOAD_PATH`.  When #7749 commented out `$libdir`'s :call_on_define => true, the problem of this ticket, #13948, was inadvertently created.  The previous change allowed more reasonable usage of `require 'puppet'`, but unfortunately, `$libdir` was *not* being added to `$LOAD_PATH`.  We can't call it on setting definition, because that messes up `require 'puppet'`, so we created the ability for the hooks to be deferred to application initialization (i.e. immediately after `$libdir` has a reasonable value).
I changed this code logic when I merged with updates I had done offline on the way home (which required resolving conflicts).  I think that the above would always set `col_class = Column` and `self.masked = False` since the `break` applies to the inner loop, not the outer if statement.  See diffs in
https://github.com/taldcroft/astropy/commit/e59915d669a2354a47f14a8cd32576a8e885d2cd and let me know if you agree.
You can catch both using a single except statement:

```python
except (ConfigParser.NoSectionError, ConfigParser.NoOptionError):
    pass
```
@H3DAZ -- will it cause confusion if we have the offset-by-one present? If so, we should fix; if not, document and move forward.
Use different files for different namespaces
These lines should be removed.
I think that is best test it with all versions.
This should not be called "EventsAware". "Aware" interfaces are for hinting to the DIC that a setter needing auto-injection is present. I'd rename it to something like "EventsCapableInterface" instead.
This method is not necessary, and may confuse people a bit, as form elements are not really supposed to compose validators or filters directly.
Tabbing here is AAALL messed up
this is @@lesson_part_arrival
Also why ignore case, given that Lucene field names are case sensitive?
Talk to Ebbo. :P
There is no special reason to use this magic numbers, except that it would help understand the code.. I will remove this static numbers and set set them directly.
This was reported in mxcl/homebrew#10424 and fixed in mxcl/homebrew@161951a. I just did a quick test and `ENV.fortran` appears to be correctly stripping flags like `-march=native` from `FCFLAGS` and `FFLAGS`.

If `-march=native` is still being passed to `gfortran`, the most likely explanation is that `CFLAGS` is being used instead of `FCFLAGS` when invoking `gfortran`---which would be a buildsystem bug.
This class is just a convenience wrapper around ConfigurationService for type conversion -- doesn't it make more sense to just pass through and have the property naming semantics defined by ConfigurationService?
I'm not sure, but couldn't you have used operators.attrgetter?
the best way to get 'protected' => ask the developer do use it correctly :)
The line length exceeds 120 characters.
You are right. It's not an PSR2 error, just a warning. But anyway i'm fixing them, too.
why not reusing the ``$oc`` variable in this line ?
```php
case ($e instanceof AST\NewObjectExpression):
```
Are you sure this works with PHP 5.2.x ?
I'm wondering if css doesn't allow us to specify these two lines into only one, using a comma.
LdapFilter instance
Actually this might later be added to suite.py, which would require the ability to import them.
pgks? you mean pkgs?
delete this unused variable, and the one below it too
You can put 4 in as the second parameter, which will do the expects
spacing around e
You should use ID, instead of CSS:
(By.ID, 'quck-seach-btn')
Same question about the rescue and reraise here. Is there something I'm missing?
Add req # for debug
Since you're the only one touching this element, you can probably just set className to ''.

Also, you already have the keydisplay element cached - why are you getting it again?
@kellyredding - couple typo kinda things.

* "Suite provides access to the contexts, test, and test results", I'm assuming you want "tests" instead of "test".
* "runnner_seed" extra n in there
I don't have an opinion about whether it should be configurable or not.  Fog provides the dns_name, and if fog is not getting the correct dns name, I don't think foreman should correct for that.

I would say, though, that if the foreman machine cannot use the Resolv library to get the IP address using the hostname provided via Fog, the DNS setup is probably wrong, or at the very least, not what they intended.  I am finishing out a puppet type for managing Route53, and trying to manage DNS in the cloud is tricky, indeed.
"raw" support is in now, let's reduce this to just `this.entries.push(str)`. Also perhaps change the "str" var name to "rec" to not be specific about whether it is a string or an object.
This will have really strange effects when the resample sync method is used, changing the video timestamps is the best way to do it.
If you want to change something on this line, make the arguments final...
I'd recommend putting this "hint" in the question.
`Angle` will definitely not become a subclass of `Quantity`.  `Angle` does not have an intrinsic unit, and it will also support arrays (which `Quantity` should not, because then it's `NDData`)
http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Type_selectors#Type_selectors
对于js的选择器已然有效吧
Wouldn't you prefer to store the path in an attribute?
I like the Python convention of importing modules in a well-defined order: standard library modules, then third-party modules, then application modules. I'd like to see this import moved to line 3.
柔軟に番号付けされた整数のリストを生成する関数です。eachとmapのループ内で便利に利用できます。start引数が省略された場合は0がデフォルト値、stepのデフォルト値は1となります。startからstopまでの、stepずつインクリメント（またはデクリメント）された数字の配列を返します。排他処理。
а вот подумай, если хранит ссылку, то что будет происходить?
s/incompatibily/incompatibility
is this not the same as the locator on line 132?
Looking at what would be in `context.tenant.tenantId === 'global'` and `!context.tenant.isMainTenantServer` you'd get:

- global/admin: true & false
- global/admin/cam: false & true
- tenantserver/admin: false & false

as the value for `isGlobalAdmin`

So further down when checking if on global tenant it will only show all enabled login fields (and not just local) when you're on a server tenant.

I'll have a look to see what can be consolidated.
What's the rationale between sending out requests upon request, error and response? I think events are a great way of queueing things up and processing them asynchronously, but experience from the UI has shown that we don't want to over-use them, otherwise it becomes a large bowl of spaghetti.
Oh, I see now. Would it make sense to move both ``scalaClasspath`` and ``classpath`` in a separate class? (maybe it's not possible, but it was worth asking :))
Yes, that should be possible. I'll implement it.
That's very good doumentation. Thumbs up! (and blame on me for not doing it in the first place :))
Do these changes actually work? You're removing the `.` infront of `field-` and you have no indication of what `field-name-` is. Originally the `.` is meant to designate that it is a class name on the field, which I believe you still need.
What is the purpose of this attribute when <tt>filename</tt> exists?
je kan dit schrijven als:

```js
if (res.collision.x) this.flip = !this.flip;
```
There is no need for that check, because that foreach shouldn't ever be entered. The results array will only ever be two dimensions deep.
ну это-то понятно. просто как-то уже я так понял принято в таком формате записывать. есть предположение, что компилятор обе версии переварит в одинаковый код.
DNA.count будет корректней заменить на 100.
Нам нужно менять случайный элемент последовательности!
А по-моему очень даже неплохо. Человек уложтлся в минимальное число строк кода, при этом не забыл что можно случайно выбрать одну и ту же ячейку, а так же что при замене необходимо проверить на текущее значение элемента. По поводу оптимальности тоже претензий нет. Исходя из постановки задачи оптимальней не сделаешь.
лучше бы размер задавать аргументом в инит
@AlexKlim https://github.com/Hexlet/osx-project-1 пункт 7
I follow PEP8 style guide for the python code. http://www.python.org/dev/peps/pep-0008/.
It says:
"Avoid extraneous whitespace in the following situations:
Immediately inside parentheses, brackets or braces.

Yes: spam(ham[1], {eggs: 2})
No:  spam( ham[ 1 ], { eggs: 2 } )"
I'm doing a talk today and was hoping to show it off, I think it's ok to merge in as long as we have that techdebt in to address the bigger picture issue. Thoughts?
This guy didn't show up after cloning repo.
nomeclatura fora do padrão. deveria ser: getBusinessId
See the dependency: #142
what is this for, Brad? why hard-coded host: what if one day it becomes down (or runs out of r.h. network?)
I will split this out so FetchProgress no longer derives from IndexerStats.
why add_geom False? does it break if True?
can you add a deprecation warning?

```
import warnings
warnings.warn('Constructing a SourceEstimate object with no attribute will be deprecated in v0.6. Use proper constructor.')
```
leave it but add a note that 'corr' can be used instead?
the more i see the stc.label_stc I am wondering if the naming "stc.in_label(label)" would not be more natural? any opinion?
and also add the getAll(boolean, Integer, Integer) and getAllCount(boolean) per Rafal's comment on OpenmrsDataDAO.
Is it John or Matt?
@weaverryan I just tested it and all ordered lists are rendered the way it needs to be rendered..
How about:

    Suppose you have a form for editing a blog post:
For performance reasons, it is recommended to use single quotes for simple strings that don't contain variables. This should be `$msg.get('platform.faq.about')`.

Strings in single quotes aren't parsed by the velocity engine, while strings in double quotes are. This means that:

    #set ($x = "Hello $user")

will interpret `$user` and output the value of that variable, while:

    #set ($x = 'Hello $user')

will just leave `Hello $user` as the value of the string. It is not a mistake to use double quotes all the time, but it's better for performance to let Velocity know that it shouldn't look inside that string, since you don't want any variables to be evaluated.
Nooo, why context.system.actorOf? That creates top-levle actors all over the place.
I prefer the previous way. I would also use safe_concat, since it is faster and more correct conceptually (better than calling html_safe at the end).
Yes, you're right. Using createUrl and createAbsoluteUrl is the right way. I will fix it.
В смысле, если «да, не блокирует».
Я бы еще `Release()` из деструктора дергал. Как правило хорошего тона.
這個檔案的規劃用意?
Esta parte me gustó.
the facility method must return a string, not echo
Yes, it would be a 2-d array, and it would be equivalent to the example you showed.
I think rspec takes care of the LOAD_PATH by default, so no need to those 2 lines
Do you think this would be any easier to read/maintain?
```
cmd = "/bin/ps -C mysqld h"
cmd = cmd.split(' ')
out, err = utils.execute_with_timeout(*cmd)
```

No holdup, just a suggestion to keep you from having to wrap these lines every time you call it
`revisit`
Should all of the component registry changes be a separate commit?
This looks like a different fix.

If you could separate it, so that we'll be able to easily backport your nice cache-starting fix to 5.1.x
@RishiRamraj: Thank you :-) Hope that explains the trick. ;-)
This must be in the `AuthorizationServiceProvider::boot()` method.
I'm comfortable that your code is doing what you intended, but I am not so sure that it is the *correct* behaviour. As I understand it, this would mean that:

```
PathPatch(path, transform=None)
```

and 

```
PathPatch(path)
```

have different behaviour.
Minor question of style: I think the most common style in the codebase would be
<pre>
import matplotlib.cm as cm
....
} else {, not } else
{
Does this belong in the spec directory and called spec_helper.rb?
This might explain a few things. :)
Please excuse me if I find it very disappointing if the first comment I get after a month is about syntactical irrelevant newline characters. There is not a single word in any of the wiki documents about that. All the files in the tests directory are using a chaotic mixture of both styles, most brackets are on their own line but a few are on the end of the previous line. You are free to change the code to whatever you want. I don't care.
I've only changed the URL in api util to use the config URL since I wanted to avoid an extra dependency in this file.
@bp323 Can we remove this hover image as well?
@gsilver 

* Instead of using a background image, can we use the background color / gradient instead?
* Can you make sure that (e.g. for border-radius and box-shadow) we include the right prefixes? `-moz`, `-webkit` and the standard version
* While you're at it, can you also reformat this to the new style guide?
can you indent the js within the condition? and then put the endfor in a newline. then you can merge it - thx!
x-column-count() also adds webkit CSS rules (making for easier previews)
These are now committed.
Are you sure the method ``lockExists`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)? Please also check line 206.
add spaces around `*`.  Same for all other occurences
This file was generated automatically by compiling the template files
`and` palauttaa booleanin, ei tarvetta `if`:lle.
Explanation: http://php.net/manual/en/language.operators.increment.php
maybe also move the feature detections here, closer where it's actually used.
Fixed, see https://github.com/propelorm/PropelBundle/pull/130/files#L1R338 what do you think ?
This configuration should go in the the main doctrine configuration
missed a spot ^
Use a more standard code convention. (`HelpModel()`)
sounds good, tried it out and it's fine. We could add a `-h, --hard` flag or similar to retain the old functionality, ideally with a dry-run and confirmation
`NotImplementedError`!
Do I see a hard-coded URL?
Yes, it will not go so easy. You will have to loop over dict manually. ;-)
We are putting spaces around `()` in anonymous functions. We always list all arguments, even if we do not use them, so that later developers know that they exist. Does this anonymous function gets any arguments on load?
WHAT! How do you define Python classes???
Aha, plugins are only places in the tree ...
Poly uses gens as a property,
There never was http://doc.quickpay.dk/paymentwindow/technicalspecification.html#index2h2
I'm confused why the method definition already existed but you had add the invocation to it here? It was just not used before?
Wouldn't it be better then to use AfterCast?
Delegate last to @collection ?
this doesn't work because the test cases are MiniTest not RSpec. I did try it.
This won't result in `undefined` being logged; rather, it will result in a Reference Error, *assuming* `x` is not also defined outside of the function.
These comments don't seem correct for this new class.
Do you need to check that server_context != NULL first?
That's not fair =))
You also can't match named arguments with positional arguments, because the named arguments aren't necessarily in the arguments scope in the order they are listed for $args.
and in line 396, Atmospheric --> AtmosphericPSF
Pixel in particular has a non-intuitive parameter name.  `xw=pixel_scale`  So I personally prefer the syntax without the kwarg in this case.  At some point later, I'm pretty sure I do mention the possibility of non-square pixels where I use the xw and yw kwargs.  (Yes.  It's demo3.py)
Agree.

On May 22, 2012, at 12:49 AM, Barnaby Rowe wrote:

>> +         * @brief Report interval bounds
>> +         * @param[out] xLower Interval lower bound
>> +         * @param[out] xUpper Interval upper bound
>> +         */
>> +        void getRange(double& xLower, double& xUpper) const {
>> +            xLower = _xLower;
>> +            xUpper = _xUpper;
>> +        }
>> +
>> +        /**
>> +         * @brief Return a list of intervals that divide this one into acceptably small ones.
>> +         *
>> +         * This routine works by recursive bisection.  Intervals that are returned have all had their
>> +         * fluxes integrated.  Intervals are split until the FluxDensity does not vary too much within 
>> +         * an interval, or when their flux is below `smallFlux`.
>> +         * @param[in] smallFlux Flux below which a sub-interval is not further split.
> 
> Was going to ask, out of interest whereabouts, the threshold / "too much" value for the FluxDensity variation interval splitting is set... But then I dug around and found it in `src/OneDimensionalDeviate.cpp`.  It's all personal preference, but I think that as the *.h files are definitely the go-to location for documentation, it might be preferable to define the "magic numbers" there.  How do other people feel about this?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/156/files#r858140


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
Just change it in the original branch.  The pull request is essentially to pull that branch, not the snapshot that existed there when you made the request.
That's better I think.
A test of changes
@zoltax , let's move this function to PhotoAccountingDatalayer, so this Receipt.php will be not needed
the only the
Configure the version as a property, and set in dependencymanagement, in the parent POM file to allow other projects to depend on the same version
new package  brooklyn.util.exceptions ?
\@VisibleForTesting
this could be very useful, to implement entitlements, gui updates, etc -- i expect it will get refactored but seems good for now
Git does not commit empty folders. Unless there is a file within it.
Shouldn't this use the NOTEPADEXE defined above to launch Notepad in Administrator mode via UAC? This shortcut doesn't look like it would launch an editor for sbtconfig.exe with the permissions required to save the file.
stupid coding standard question: should it be PHPCRImage... or PhpcrImage... ?
maybe you should make this a list of rdf types for which to create routes, defaulting to empty array.

if i create a new simplecms document or a new block, i don't need a route for that...
I don't want people to edit the `SymfonyRequirements.php` file.
Does this change the default page to Advanced?
this highly depends of the way you the formatted did things, and should be refactored once you move this to a GelfFormatter
I think we could at least use the ones already exposed via objects in dialer.js :)
Wouldn't cost much, I'll add it to my followup.
Add I18N comment for translators explaining the option
This needs to be changed into "t:RecurrenceId"
derp, yeah, that's a sane default!
def joined member  和 def joined(member) 是不是等价的？  这是rails的新语法吗？

如果是等价的，麻烦以后用 def joined(member)吧，。我过几天会写个新手入门的wiki，这样新手容易理解哈 ：）
required for defer-create test
Еще вопрос, что должен вернуть invoke, если вылетело исключение? Или он должен пробросить исключение дальше?
Сделай тест, в котором проксирующий метод выбрасывает исключение (RuntimeException). Причём надо проверять, что в вызываемом коде именно это исключение прилетело.

А ещё надо проверить ```@Collect``` с void и List.
В тестах должны быть проверки, что правильный формат в логе получается.
Наши велосипеды - самые велосипедистые велосипеды в мире!
EolnNormalizedReader ровно для этого и нужен. Он и \r\n, и \r конвертит в \n.
Add a constructor that takes token and expiration datetime - you never create one of these without both pieces of data anyway.
nit, remove space
add another blank line here.
this really looks wrong. see https://build.pub.meego.com/package/view_file?file=0001-Change-old-RTComTelepathyQt-references-to-TelepathyQ.patch&package=libaccounts-ui&project=home%3Aaard%3Astaging%3Aaccounts
I use this who seems "cleaner" and work like a charm:
    <% @settings.sort.map do |key, value| -%>
Because the prototype told me so. The prototype is gold standard also for the other tests.
After investigation, I think that I have found one main reason why it is slower.

The operation `residual[:, np.newaxis]` make the vector `residual` non continuous 
which lead to a copy in `DecisionTreeRessor.fit`.
Never mind. :blush:
Yes, until we update our dependencies to scipy 0.10+, the sklearn.utils version of arpack should be used.
Maybe it's purely cosmetic now as you allow only read-only access to aliases but from my POV, "{" and "}" are just to identify what the alias is but curly brackets are not part of the alias itself. Depends in the feature requirements.
Well, if it's a "weapon" it kinda asumes it does damage, i thought about this :P
So, to be held differently, it should extend just GenericTool (not sure if that exists :P) :)
Can you move these error reportings to `Expression::checkModifiable` ?
`modifyFieldVar` is not designed as which can report errors in its processing.
as was discussed offline, and tested against android platform, we needn't  set 'source' property here
What's the rationale for having hide in this class?  I was expecting it to go in the UI.View associated class
needn't declare explicit
This is to be a shortcut to alertDialog, not a duplication.  

Should be easily done in the bootstrap, something like:
```javascript
alert = function(msg) 
{
    Ti.UI.createAlertDialog({ message: msg}).show();
}
```
This action does not check either if the citizen has signed the idea already.
The tests can't find that file in runtime and the load fails. Since the file was not compiled, nor included in any project I could find, I assumed that was a failed experiment that I was just re-using to start the unit-tests.

I've added them statically this time. I guess they weren't because there wasn't a nice way to build them like CMake back then... ;)
I'm not sure how useful it would be.  It could have

    default: 
        break;

I think I would leave it until a whole-scale change that adds default branches.
It's not very pretty but you can do this for sure:

```
if 'blah' == 'blah' \
    and 'foo' == 'foo':
```

Generally really long "if" statements are a sign you should structure things a bit differently, it's ok to indent a few levels if it makes things more readable.

Generally I'd prefer this:

```
if release['featured']:
    if release['product'] == product and release['release']:
        pass
````

Over stuffing it all on one line, it gives you more opportunity to handle other cases via else/elif.

Maybe @peterbe or @lonnen can think of something nicer here.
What's the point of translating exceptions ?
should we include `for="resident"`? Not sure if that means anything within a toolbar, but would be correct...
there seems to be some issue with indentation
Isn't this redundant with the test and `continue` above?
add a check function for data
.Net kept these methods for back compat and just added the get reference ones. I can see since we dont have a huge backstory in java we could take this change, we should discuss further.
just make sure you have a ReplSet object for each db connection. if you need to share the ReplSet the correct way is to instantiate one Db object and then use the

var someotherdb = db.db("someotherdb");
Can be just ```framework```.  No need to get it off of the ```client``` object.
Maybe handler isn't necessary here
I really have the feeling it should be an exploit... since you're going to execute "a payload" (embedded in a binary). I would like to listen feedback from a more experienced developer about that. I'm going to ask for it.
````!!(@allow_aliases)````
Personally, I don't favor either of those. Change it to your liking.
If you comment out line 3 of observer.js the observer_spec.js will fail because the test on line 45 checks if bind is called on the source object. The #unbindFromAll test will pass though because I don't test if bind is called. My thoughts were that this was something more in the domain of the observer_spec than the composite_view_spec but I can add a test to #unbindFromAll to check that bind is called on the source object if you think it needs one.
Instead of stubbing self (!), I'd create a stub: `controller = stub("Controller", :post => nil)` and pass it into the matcher instead of self.
I suppose that works for this case, and as of yet I have not found a Twig Extension that does anything interesting in `initRuntime` except set the environment (thus suggesting that your point of using a setter is all that is needed).

OK looking at the code (both Twig and TwigJs), we can see that the purpose of the `initRuntime` method is for the Environment to call upon all extensions and give them a last chance to do something to the environment (e.g. load more filters, globals, etc.) or themselves before the template gets created, no? In which case, does this (contrived) example support keeping `initRuntime`?

```js
/**
 * @param {twig.Environment} environment
 */
twig.MyExtension.prototype.initRuntime = function(environment) {
    this.env_ = environment;

    // load Some more filters if environment is in debug
    // note: this is a conditional load so it is not done in getFilters
    if (this.env_.isDebug()) {
        thiis.env_.setFilter('some_debug_related_filter');
    }
};
```
Same comment as setShow.
What happens if `outerRing` is `undefined`?  What does `eliminateHoles` do below?  We should just ignore it.
Is `return` considered better style than `return undefined`?  I always do the later because it is explicit and more like C++, but the former is more concise.  CC @shunter
Error is an ES5-defined global type.  http://es5.github.com/#x15.11  I think we can drop the exception handling.
Okay, I'm still learning glsl, so maybe I'm being overzealous, but couldn't I avoid the vec2 construction and simplify your suggestion like this?

```
vec2 clampedXY = mix(positionWC.xy, floor(positionWC.xy), u_clampToPixel);
gl_Position = czm_viewportOrthographic * vec4(clampedXY, -positionWC.z, 1.0);
```

Seems to work great, but I wasn't sure if there was a reason you wrote the original version like you did.
Looking forward to optimizing this.  I still have no good ideas other than copying it into an already allocated array as discussed.  Although I don't like it, it might not be noticeable performance-wise all things considered.

Since these WebGL functions take both arrays and typed arrays, we should see which one is faster.  Around December, I thought it only took typed arrays, and I would allocate and copy into one, and that was much slower than just passing in the array.  However, I had some other copies too that I removed.
The pattern I've been following for scratch variables is to use the name of the method in the variable name so it's easy to tell where it's used, so instead of `scratchCartesian3` I would make this `distanceCartesian3`.  Obviously this isn't in the coding standards (maybe it should be) what do other's think? @shunter @pjcozzi
Fix has been merged (https://github.com/appcelerator/titanium_mobile/pull/2373) so the workaround doc is no longer required. Both iOS and Android require a location fix to supply a valid trueHeading value--iOS is just quieter about it.
add mobileweb.
The creation dict "url" from the app could be null, but I check if (path!= null) before setProperty(TiC.PROPERTY_URL, path). Therefore the value of property "url" won't be null.
Remove the default value entirely, since it only confuses the issue.
Leave one empty space before each new rule.
Essa variável não é inicializada para todos os tipos de figura. Se eu fizer 

```java
Circulo c = new Circulo(2);
c.getTipoGeometrico(); //Retorna nulo
```
Qual seria o tipo geométrico de círculo?
This doesn't work and crash the application, if the list is empty.
I just deleted it.
Bug# 8138 breaks attribute inferrence pretty thoroughly at this point. It seems like only the top level functions get inferred rather than the entire template, and that's a big problem.
Again...no need to copy v
It was a multi-threading problem. The tests were running in parallel, but they shared state. Should be fixed now.
This should be runtime scope
Replace ) with }
Evaluate `localClientSelection()` and `localClientSelectionArgs()` outside the `Runnable`; it will help the JIT, and simplifies this bit.
Source formatting note: If you're going to reference a property that JS passes by reference (an object or array) inside of a loop, then cache that property to a local variable so that it doesn't have to relookup the property every run of the loop.
this is cleaner if we add a datetimeObsResultForPatient helper method in the base class.