labofsahil/github-event-dataset-2012 huggingface dataset:
if it used only in if-context and store different values then this different vars by use. Compiler will be merge used space for its. But from code correctness better have local in if-context varibles...
me2 me2!
We're already in the `Mendibot` namespace, so we don't need to prefix this call.

It also would be nice to add a class method to `Config` to check if someone is staff. Perhaps `Config.is_staff?`

```ruby
def self.is_staff?(nick)
  STAFF_MEMBERS.include? nick
end
```
on Wed Jan 11 2012, Dimitri Fontaine <reply+c-858471-582d22a5e0363513d16ffd1de5c6012485e0dd27-44065-AT-reply.github.com> wrote:

> I never was interested much into parallel as I am in async. Then, your
> model did have its share of bugs I didn't know how to fix, like how to
> handle installing several packages sharing a dependency.  

Just FWIW, there's no reason my code should have had any trouble at all
with a scenario like that.  The logic should Just Work(TM) and in
practice it did.  I had no problem at all when doing shared-dependency
installations.  I think you may be mis-ascribing any problems you saw to
that code.  But that's all water under the bridge now.

> As the code maintainer, I find the new way so much simpler to maintain
> than I won't ever consider going back to race conditions and the like.

That's fine, as I said.
Nitpick: have the array declaration on one / two lines, and put the 'unofficial TLD' comment above the entire array declaration (e.g. `'onion' is an unoffical TLD...`).
Maybe ;-). If you want to change it change it. It is anyway just a workaround.
We can't directly depend on postgresql like this, as we support non-Homebrew installs of it.
Oh, I guess I should have been more clear. This was supposed to string the parentheticals from the value, but include them in a comment in the line above.
@Th0ar @pzi1win2go3
Will this be tagged 3.0.5 soon or do you have more in mind before the tag?
Всё теперь с боссами всё гуд. Спасибо
one too many newlines!
Thx to Maibenrai for report it. Sorry for the inconvenience.
Use `unless` instead of `if !`.
I followed the [settings guide](http://www.sublimetext.com/docs/2/settings.html) and only kept [those files](https://github.com/prathe/dotfiles/tree/master/sublime2/User).
Spent time discussing this with @JonFerraiolo and @billreed63 today... decided the best approach is to add a widget-specific property to set the innerHTML, and I've opened #1635 for that. However, note that #1635 is dependent on #725.
How about everybody jot down their name here so we know who worked on this project?
Expanded on the comment for the new $x12_gs03 field.
random.seed(chunk.getWorld.getSeed()); won't do?
you don't need this...
there is a method "calc()" in BSTNode which recalculates size, height, and sum of heights for the given node..
calc() is called automatically by rotate() so you don't need to care about that
Renaming the methods seems the best option. Going for .ssh() and .ssh_interactive() (clearer than .issh())
Adding the logout action. This action tries to log the user out of the current Auth instance. If it fails, they receive a notice. Either way we redirect to the homepage.
"set set" might just need to be "set"
received unexpected opcode CMSG_CANCEL_TRADE (0x011C, status: STATUS_LOGGEDIN_OR_RECENTLY_LOGGOUT) the player has not logged in yet and not recently logout
Don't merge the last commit, it's broken.
I think we need to add the ajax setup to both of these lines, no?
Ok. I'll leave you to find the correct place for these docs to go after the Big Reshuffle...
get rid of ` scroll left top transparent`
After this change, stripes.less and bootstrap.css should point to the right directory where images are.

At the moment of this commit, no icons are shown at the docs.
You dont need the lastTarget != null check after the || operator.
If its null, the second part won't be executed.
Overall formatting is different from Yii style. I've marked some differences. Others are about extra spaces as well.
if u script normal and heroic entry in one script that is correct
Hi @lbosque - this is great. Please merge with devel.
You can use `attr_reader`, which is a bit faster on MRI.

```
class <<self
  attr_reader :bytes
```
Don't check in your password.
I'm not sure if these are the names you would use.
Excellent Andre.
shouldn´t we use the static-tag instead of {{ STATIC_URL }}grappelli/?
I think I tried "Software/*//[@computer='%s']" which is different from what you suggested. I tried your suggestion and it works, so let me redo the code and submit.
если константа - то объявляй final
was just accidentally casue ive merged my offline core with a newer TC so this was a core before the changes were happened
!self.Owner.Shroud.IsTargetable(Target.Actor) causes a problem with non-turreted units. You can't send an attack order to any structures under fog with an arty/v2/ttnk/apc as a result of this. Is !self.Owner.Shroud.IsVisible(Target.Actor) what we want instead? That actually works, but now I'm wondering if  IsTargetable is not working as intended here? It's targetable...
```<cfquery name="myqry" /* you can't put comments inside */ >```
Why did u remove this
Coding style: hugging *s.
Not needed.  I would do a cherry-pick.
Кузня бы работала, если бы sql к ней приложили.
В логах ошибки по скриптам, он их не находит (проблема в заглавных и маленьких буквах в названиях скриптов).
http://pastebin.com/xSmNX1Gd
Спасибо!, а я то думаю почему у меня консоль спамит ID которых нет в scriptdev2 дб.
only BELGARISTRASZ gossip from when he walks out of cage is a little buggy but ytdb bug and im not that great with gossip set up yet ... few things missing off top of my head dragons arent suppose to have all abilities til urom is dead and 20 min drakos death to eregos death achi.. most quest support is implented but only optional atm ( meaning u can do instance without asking for quest yet but there their )
Cool - I'll submit a pull request once I got something working and tested. BTW, I'd suggest mocha for a test framework for this lib.
We should be reserving the package names, admins shouldn't be defining them because they aren't technically "writing" them
It throws an exception `Error: Syntax Error: Token '[' is not valid json at column 2 of the expression [{[]}] starting at [[]}].`

And if you call it outside of angular, it will be just unhandled exception.
That's correct I think.
Yeah, this does break gcov. It seems like we should let each daemon control how they handle SIGTERM anyway, like they did before d1dbeaf59d976d354518c1a40fb35a8add28c326.
Hi,

I'm wondering how one would use the list[A](mapping: Mapping[A]) function to validate/bind via a case class:

case class User(username: String, permissions:Set[Permission])

val form = Form(
  of(User.apply _, User.unapply _)
  (USER_NAME -> nonEmptyText(5), USER_PERMISSIONS -> /* here comes the binding */ )
)

My question is what to assign to USER_PERMISSIONS ?

Thanks for your time and keep up the good work!
Not sure what the root cause is. Momentum scrolling is a bit weird because it's simulating wheel events after you stop touching the touchpad. It seems like the simulated events get mysteriously stopped/cancelled if a new element appears under the mouse. But in other testing I've done it seems like the mouse position behaves as if the pointer has moved, even though it hasn't.

If you scroll slowly you never see the issue, but if you do a two-fingered flick with scroll momentum on you might see stutters and stops. Also Lion's iOS-style elastic-page-scroll-limit behavior is triggered, so perhaps the scroll is being applied at the window level instead of on the map parent where it would be canceled.
I think it would be better if an exception is thrown if the argument string could not be parsed into an int.
IE!!! Very interesting -Like usual with IE, I wonder why the heck they would do that..
I was able to find more here http://stackoverflow.com/questions/1219860/javascript-jquery-html-encoding

In [this answer](http://stackoverflow.com/a/4025774) a workaround is suggested.  What do you think?  I only prefer this because then we can escape all things like &raquo; and &mdash; correctly
This option decides whether during an edit the encounter form is updated or saved as new.
tisk tisk.  No new line at end of file!
Oh, and if World should become Glue, where should the running of hooks happen? Probably abstract it up to the Scenario level? and just get the hook information from there? Can probably move it into Runtime at least....
do not like the use of br. Use (not inline) css instead.
Nice code wrapper and use of apply
I know it looks confusing, but what the condition is saying here is if you aren't connected (as we have disconnected after the previous send), and the interval has passed, proceed to sendData. In sendData we re-connect to api.pachube.com and transmit the info. It could probably do with some refactoring for clarity though.
@ibolmo just change the version inside `Slick.Finder.js` and create the tag. It's done there. Just saying so you can release a future version if needed.
Puts'ing from a method is a side effect, as such it should be clearly demarcated, as you say in a print method. You can also see here that there is a clear delineation between the 'library' and the use of the library. Now you are more free to use the anagram finder in another situation.
ok
is that my error or core and db missing sql´s files ?
Why o why
There a thread in dev-list about this. By default, the JSON generated by VRaptor is not indented, to better performance. The original code generates not indented JSON. Why change this now?
Please use try-finally
这个比较过程单独写一个函数
Nice examples. My only feedback is that it could be confusing to use the "Image3" class for both the enclosing `div` and the `img`.
Wow i screwed this up, do not use this!
These ALL scripts to different zones (Searing Gorge and Westfall) belong to the Atlantiss Project. 

As a member of the Atlantiss Project I would like this to be removed.

1. I dont want to be anonymous

2. I give away my code when I want to and when I think it's done and that a project deserves it

3. I gave you guys already my Halls Of Origination scripts and all you did is deleted my name from the scripts and wrote a commit "Thank you arcania and SF Devs" FTW? Are You guys joking me? Plz delete my fixes + my teams fixes from your repo.
Experienced this bug, and fixed with the line below.
Haven't even tested this yet. I figured this would be fun to write together though. Things shouldn't even be working yet, and I still have to figure out how the chef-solo command to run it lol.
Oh wait, I misunderstood what the package was for. I was asking, how do I *install* the latest Chocolatey? I want to try the prereleased features from my command line with all the batch file magic (`cinst packages.config` etc).
Is there an equivalent commit to Bukkit-Bleeding exposing the API to plugins?
Typo I guess, should be 99867-94913159.
The problem was in my config/unicorn.rb file (path reference for app root) - deleting this fork. Thanks.
What do you mean by "cluster the `GET`-related requests"? Do you mean serializing the code as you explain in your comment above? I considered making a `ClientDownloadDelegate` as well in symmetry with the `ClientUploadDelegate` to make this less confusing. Does that sound helpful?
no problem!!

how is the port going on??

I mean I saw you forked my source and was wondering if it's working OK...

you should merge all my new commits it really makes ICS go faster!!

also does BT calling works for you? I get reports that no audio is 
passing trough

On 01/22/2012 02:23 PM, febycv wrote:
> Yea, sorry about that....really messed up....
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/febycv/android_device_htc_ace/commit/ca4aeb2a6e70f2c96c611261624e3529a22cc88f#commitcomment-889908
>
Rather than computing <tt>now</tt>, use

<pre>  return (int)(date.getTime() - System.currentTimeMillis());</pre>
Interesting. I'm pretty sure that I tested/compiled on my Ubuntu, and I didn't get any build errors. 
Where exactly did you get them? All those four occurences you changed in PR 911? Cause this line doesn't even add char*, so I don't see how this could lead to a problem..
`ofLog(OF_LOG_NOTICE, "[%i] = %s", devices[k].getDeviceID(), devices[k].getDeviceName().c_str());`
Missing are the changes from your conditional statement that ONLY passed our test example (clever :) ) because Git wanted me to commit that change before checking out the old commit with NegativeNumberError in it.  Still, I replaced it with one line.
I'm [not](https://github.com/ruby-amqp/ruby-amqp.github.com/pull/2) lazy, I swear \*whistles innocently\* :)
Лидирующие запятые всё же выглядят неестественно. Лучше запятые в конец строки. В конце списка можно делать "лишнюю" запятую например `[item, item,]`.
It is good to be cautious when providing instructions that could potentially remove sensitive data. At first I had written `rm -rf anything`, but found that to aggressive.

You are correct in assuming that the point is ease of experimentation. Would executing a script be a better solution? If so I would like to write one.

I will look into the "farm" capabilities as a other venue of easy experimentation.
good catch! awesome api btw.
This would allow empty usernames because a username with the length of 0 is still less than 25.
Yes. It's true. But LG P500 support combo devices.
thats IS cross comapt
wrong suffix on "rapporterad"
urlsplit is in urlparse; it just happens to also be in httplib since that module imports it from urlparse, but it's not part of the public API so it could disappear. Use 'from urlparse import urlsplit' instead
Thanks. Any chance of it gettting to ICS branch too?
these two lines broke my build producing the following scope errors:

frameworks/base/services/surfaceflinger/SurfaceFlinger.cpp: In constructor 'android::GraphicBufferAlloc::GraphicBufferAlloc()':
frameworks/base/services/surfaceflinger/SurfaceFlinger.cpp:2717:5: error: 'mFreedIndex' was not declared in this scope
frameworks/base/services/surfaceflinger/SurfaceFlinger.cpp:2718:5: error: 'mSize' was not declared in this scope
Lol I was thinking like "yeah those guys know their job, no need to init any more"
Please preserve spacing to be consistent with the other widget definitions.  Consistency enhances readability and comprehension.
Actually, may have found a better way to handle ajax exceptions:
http://spring-json.sourceforge.net/quick_exceptionresolver.html
as the append op? sure.
I'm confused. Shouldn't this show the diff with master. Looks like something is missing.
https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/RemoteActorRefProvider.scala#L196

Make sure that the changes I did here are not lost: https://github.com/akka/akka/commit/49500ab
Why doesn't this delegate to the toCamelUri that takes the ConsumerConfig and passes in "ActorEndpointPath.consumerConfig". Also, why doesn't the docs mention that ActorEndpointPath.consumerConfig is used? (and why are they used?)
No it's fine.
I think this is a slightly unorthodox method name which is way costlier than the name implies.
I would say:
Translate the surface for a specific distance along a specific azimuth direction.
Toggling of the property should happen in DropDown, such that lines 128, 131, and 135 should not be necessary.

As a quick fix, I'd drop it somewhere in Dropdown.open. In the long term, I think it makes more sense to rename open to toggle (since, in theory, it may not always be opening anything).
typo: "a some"
This is misleading. If the phrasing throws off the developer during his sprint review, there's a good chance users will be even more confused. Need to think about a different way to convey the information at hand.
Fixed; this was a ported file and I did it for new stuff but hadn't cleaned up the existing docstrings.
GetType() could return "artist" (although it should never happen here) which we don't handle so I'd do something like
```cpp
else if (item->HasMusicInfoTag() && !item->GetMusicInfoTag()->GetType().empty())
{
  std::string type = item->GetMusicInfoTag()->GetType();
  if (type == "album" || type == "song")
    object["type"] = type;
}
```
instead. That way we are 100% sure that object["type"] won't contain anything that is not specified in the JSON schema.
Please advise, so that I can update the PR
the license header should be the same than in other files of the library
Bit of a confusing method name?
There is a function in `MRJobRunner` with that name claiming to "clean up jobs on EMR." It was empty and `EMRJobRunner` did not override it. Now it does. No problem to change, I just don't care what the function is called.
Почему тут не используется переменная ie, объявленная выше?
чиго?
Actually not a waning message, an error message :)
Needs some options here like persist: false (look at the other virtual attributes in the same file to see what options they give)
This can be simplified as ``maze_components = datamodel.maze_components`` OSLT.
Thinking about whether we want to wrap the backends emit into a an else clause or let the backend somehow know that the metrics processing failed.  Just passing the potentially erroneous metrics to the backend is probably not the right thing to do.
:-1: This should use a pattern similar to `NSView.enclosingScrollView` – we should never depend on a certain view hierarchy setup.
This name should be changed to prevent `self.view` confusion. Perhaps `header`?
See the latest added commit. On a side note, it would be a sensible option to rebase the two commits together before pushing to the main repo. Yes, I've signed the CLA.
scope should be Mapper.$scope instead.
you should right a mapper for this. So it can be Carousel:Viewport. This will also let you put a hasDependancies flag.
It would be nice, if it could be done without this function.
PyArray_CanCastTypeTo already requires the GIL -- it allocates and DECREFs dtype objects.
Add: ``These will be considered different taxonomic groups.``
Both tests have the same description.
I think there's no need for `Array.wrap`, could just use `Array()` instead?
@jeremy yeah, looks like some bug in TimeWithZone. But I think it's a different issue and it should be fixed separately. Need some time to investigate.
https://github.com/lifo/docrails/commit/0c294e0010810e3d9a4bcfa72ab96ff2af0240a6 has yet to be merged.
We could probably get away with just `Array(fields)` to support that though (I think).
do you think the above comment (not the part you wrote, but the line above) is correct? it seems that `inSelfSuperCall` is only used in `Context#implicitss`, and it has nothing to do with the visibility of fields.
Not to mention I don't know how many methods implementing mkString("(", ", ", ")"), more than one no doubt written by me.  I've never managed to standardize, although you can see one abortive attempt in TypeDebugging:

    def parentheses(xs: List[_]): String     = xs.mkString("(", ", ", ")")
    def brackets(xs: List[_]): String        = if (xs.isEmpty) "" else xs.mkString("[", ", ", "]")
    def tparams(tparams: List[Type]): String = brackets(tparams map debug)
    def parents(ps: List[Type]): String      = (ps map debug).mkString(" with ")
    def refine(defs: Scope): String          = defs.toList.mkString("{", " ;\n ", "}")
The other stub methods return `NoType` / `NoSymbol` etc., but what do we do here?

We need to know what the callers expectation is.

```scala
def checkIsClass(expectation: Boolean) = if (expectation != isClass) abort(...)
```

So... tricky.
If you use ```.equals``` here instead of ```==``` then we'll eventually be able to extend this method to MatrixExpr's
stopping here, too.
Oh. I must have undone something and forgotten about it. Sorry and thanks!!
The problem is that the API allows to define any kind of expand method.  For example, there's the `expand(commutator=True)` in the quantum module.
Instead of all this complicated logic of nested ifs you can use a default key word argument, can't you?
All sympy code should be very careful in this matter...when dealing with boolean queries, it might be better to phrase them only as `if foo` and `if not foo`. Using the `is` will exclude 1 and 0 from consideration:


```
>>> var('i', integer=1)
i
>>> if i.is_integer is True: print 42
... 
>>> if i.is_integer: print 42
... 
42
```
Yes, sounds better.
Using form current URL if no URL specified is a standard browser behavior and we're following it. No need to mention it.
So is there something to fix here?
I guess I'll need to remove the `assert(flags == 0)` checks...
I'm not so sure about that. We can have separate statistics for the module as a while which would be all setup/teardown/tests. The statistics for the tests should imho not include setup/teardown as those can be inherited from a global setup/teardown and other stuff frameworks may have.
Ну да, блок то один
function named
If you want the check elsewhere, it'll require an extra DB query.
Then you should add one.
"doesnt" needs apostrophe
Get rid of inline assignment.
`phpBB's official website` or `the official website of phpBB` - needs a apostrophe the way you have it right now
Language should be improved here.
Is left join required?
Please see http://area51.phpbb.com/docs/30x/coding-guidelines.html#codelayout "Use spaces between tokens:" apart from that it should be fine
`unique_filename($name)` ?
Use `$this->config->set()`.
added a constants file into util/constants.lua
Doar partea asta pentru dinamic.
Article is odd.
Check.

Good to know the background on that. :smile:
I'm going to punt on this, since the RS redesign didn't *remove* the comment.
hala git ya gif?
Зачем удалил? Что будет если не получилось подключиться?
Graag altijd en overal inspringen met 4 spaties. Dan ook meteen graag de =-tekens uitlijnen (of voor en na ieder = teken 1 spatie plaatsen).
What's this for ? i though `(filter, isEnter)` wolud be enough
Save some idiv in the generated code. Should probably replaced by a aligned_below(in_sz,N), like the align_on function.
Had to put back the switch statement ,sorry,your code didn't cut it :smile:  Added extensive tests
jsbeautify.org
isinstance(updates, theano.gof.python25.OrderedDict)
Do you know who wrote this? We should ask him (I don't understand either).
It would need new C code. The old C code depended on a special case property of add, and my new C code for max depends on a special case property of max. You'd also need to write new tests for mul, or figure out a way to make the tests generic. The tests for sum weren't generic and I didn't try to make them generic when I added the tests for max.
Remove ``and``
Attach this IP address to the device.
Use %r instead of %s, otherwise special characters will break the error reporting code.
Instead of removing this match, shouldn't it deregister at the end of tests? Or maybe `riak_api_pb_service` should have an `unregister` function.
Code style:

```js
return exports.readFile(path)
    .then(function(source) {

        // ...

    });
```
Ноды создаются по этому списку. При создании html ноды нужно чтобы ее зависимости были уже созданы.
True, one is enough, but then it does not really matter I think.
This error will be impossible to hit.  ```SELECT count(*) FROM table``` will ALWAYS return 1 row.
yep. I fixed the problem by 
1. I deleted the interactive mode. Because it is confusing and meaningless.
2. Simply merge the document 3 with document 1 and 2.  It is meaningless to separate them
3. I add 'truncate table viterbi_mtbl, viterbi_rtbl' at the beginning of text_feature_extraction function.

I need to test it before pushing to the github. But my  workstation is occupied by  running a large data set.
I will push the code tomorrow morning.

Thanks and have a good night.

On May 1, 2012, at 10:04 PM, Hitoshi Harada wrote:

>> + * <pre>
>> + *        0  1  2  3  4...44
>> + * token1 a  a  a  a  a...a
>> + * token2 a  a  a  a  a...a</pre>
>> + *
>> + * @param segmenttbl Name of table containing all the testing sentences.
>> + * @param dictionary Name of table containing the dictionary.
>> + * @param labeltbl Name of table containing the the label space used in POS or other NLP tasks.
>> + * @param regextbl Name of table containing all the regular expressions to capture regex features.
>> + * @param viterbi_mtbl Name of table to store the m factors.
>> + * @param viterbi_rtbl Name of table to store the r factors.
>> + * @param document_id The id of the sentence to be extracted features, -1 means extracting features for all testing sentences.
>> + *
>> + */
>> +
>> +CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.text_feature_extraction(segmenttbl text, dictionary  text, labeltbl text, regextbl text, featuretbl text,
> 
> Looking at the result of install_test(), the result table, extraction has duplicated rows, which comes from duplicated rows in viterbi_mtbl. I tried truncate for viterbi_mtbl and viterbi_rtbl at the beginning of this function, and it seems kind of fine, but the process for document 3 results in only two terms, "his" and "actions" and rest of words disappeared.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/madlib/madlib/pull/103/files#r759697
>
This is on GP4.0:

    schopf=# SELECT ARRAY(SELECT id FROM dummy ORDER BY id) AS not_really_sorted;
       not_really_sorted    
    ------------------------
     {2,4,6,8,10,1,3,5,7,9}
    (1 row)
Oh, oops. I was trying to revert this back to how you had it before. I should have checked instead of relying on memory.
I'm thinking we can just remove this whole file, and let people use the README.md in the main directory.
Not the homebrew people being responsible, but the extremely capable and motivated Mac users on the list, for now.

Let's merge this, and down the road there will be a prettier solution for all. I have the same reaction to frankenstein software as you do.
As long was we're messing with stuff, would you mind changing the user-facing text to say "directory" instead of "folder"?

I don't care as much about method names, but I think the UI should always say directory.
ok, removed

The point made by the comment does still stand, though.
There should be direct return here in case self.required is empty to short-circuit processing in case no restrictions are defined.
I suggest renaming this function to resample_img, and having a Niimg in and a Nimg out.
I think this PR is currently stalled because we need to decide if we want to go this route?
I was surprised to see that there were zero tests for this entire module. As such, I did a bit more test writing than normal for a bug fix. I know the tests here fall short of the coverage we really want, but writing tests for untested code is outside the scope of this assigned bug. That said, I did throw in the TestContentCommand because I'll sleep a little easier knowing that there is at least a modicum of test coverage for that function.
I guess you didn't try running this code?
It's not really mocking, it's just pointing out a design flaw in a more amusing way, the flaw is still there.
nt: translate.bind(null, component) is smarter :)
Can you update this to use the same doc format as we have elsewhere? Eg:

`# * <tt>:domain</tt> - the domain to query for. E.g.: "domain1.com"`
you should send message_ack before exiting
I think it's likely that users will want to be able to override the formatting of the directory listing, to make it prettier, enhance with more information, etc. 

How about introducing a new class that takes care of the formatting, and allow users to pass in their own implementation if they want to replace it?
The current configuration works for me. It's just about a problem, that may occur if we only work with a recommendation for the Hamcrest version. [1.3, 2.0) is a good solution.
can we do any validation that the image is actually displaying?
This is from the original code, but it looks like `this` could be wrong here.
Typo close paren ``{DOMNode)``
Based on offline conversation, we're going to leave this as is.
Should all the fail() cases be calling finalizeMeasurement() instead?  It seems like the timing of the error cases could be very different from the normal case and we might not want to lump them together into one average.
I figured we could roll in new parameters when we wanted them, but that in
general having a tight API would make things easier and cleaner.

In general i'm not a fan of *args and **kwargs unless there's a real reason
for them (e.g. string formatting or django model fields).

On Tue, Oct 16, 2012 at 10:54 AM, Daniel Roberts
<notifications@github.com>wrote:

> In corehq/apps/reports/dispatcher.py:
>
> > @@ -61,7 +61,7 @@ def permissions_check(self, report, request, *args, **kwargs):
> >          """
> >          return True
> >
> > -    def get_reports(self, request, *args, **kwargs):
> > +    def get_reports(self, domain=None):
>
> This is the superclass, right? I think Biyeun intentionally left it open
> for the subclass to decide what's taken into account when getting reports.
> Admin reports for example aren't dependent on domain. I'd just pass this by
> her.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/core-hq/pull/115/files#r1854938>.
>
>
As far as i understand the code calling 'beforeCreateFile' & 'beforeWriteContent' the object path is passed both times. Can you give me a hint, how you would write a unittest for that?
ooops, do we really need to introduce specific cases for each report type ?
Aren't they tabs ? I think we should avoid them...
OK, but does it work, in C, with literal strings ?
Meaning, I've this code:
```
git__strdup(branch_name +strlen(GIT_REFS_HEADS_DIR))
```
and
```
#define GIT_REFS_HEADS_DIR GIT_REFS_DIR "heads/"
```
if `branch_name` points to an "UTF-8" string, I'm not sure it will work (i.e. the literal strings in C are ASCII-8 no ?)
Why not `getattr(item['raw'], 'visible', True)`?
Not empty lines. Indent!
Why? It is defined in `fields`, no?
I hadn't realized that we could figure out the type of change just be looking at data_version - very nice!
merge these two var blocks into one
good call. should I move the file out of src/core/views too?
These vars should be declared at the top of the function
I'm just preparing for having more tests, really. Seems like great boilerplate code to have in all test modules.
The check for `projectBackup` can just happen once here (if you wrap this in another if block) removing the need for the `else if` below (just becomes an `else`).
use braces for one statement if  (it will help to place comment near/above the statement also)
You probably didn't mean for the semicolon to be placed where it is now?
Sorry, some day-job stuff came up yesterday and I didn't end up getting to it. I'm taking care of it right now, and will commit in a few minutes.
Can probably use chaining.
It seems safer and clearer to check explicitly whether dwParentSourceContext is 0 (i.e. not specified) here.
You're welcome! Model makers are a great idea, never used them before.
Yeah. My bad. I'll fix it and send a new request later.
On Jul 20, 2012 7:37 PM, "William Woodall" <
reply@reply.github.com>
wrote:

> > @@ -23,13 +23,17 @@ macro(build_serial)
> >      endif()
> >    endif(UNIX)
> >
> > +  IF(DEFINED BUILD_NO_CLANG)
>
> Should this be `IF(NOT DEFINED BUILD_NO_CLANG)`?  I would think you only
> want to set it if it isn't already defined...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wjwwood/serial/pull/21/files#r1210205
>
This isn't needed as you are re-defining it below.
RFC2316 does not mention MX, SRV or priority explicitly. This means we should treat priority as part of RDATA, and this means that in a WHERE, we should always have both prio+content, or neither :)
According to this

https://github.com/Katello/katello/blob/master/cli/src/katello/client/utils/printer.py#L292

it should be add_column. Why addColumn? Did you change that method? I dont see it in this branch. I vote for not changing it.
Might be worthwhile to indicate that the refresh is going to regenerate a new version of the view in the Library.
Explained over IRC, just for record, it is done in https://github.com/Katello/katello/pull/1209/files#diff-27
Can we change to:
/// <summary>Adds a callback that will be invoked when the connection is started but before the request is made to the server</summary>
It's a small style thing, but should we have this as a single comment block instead of being separated in this way?
@iguananaut  @astrofrog  - I'm working on the caching now for Time.  In light of discussions related to Coordinates there is some need for caution about how much to cache.  If I understand, `@lazyproperty` will cache every attribute, so if someone accesses every time scale and lots of formats that could amount to a potentially large memory footprint.  Does that sound right?  Do you have suggestions?

My first order thought if `lazyproperty` won't be OK here is to cache just the last scale or format attribute access.  That means in typical use each Time object might consume up to 3-ish times the nominal memory that would be used without caching.  

```python
t = Time(..., scale='tai')
t.utc.iso  # caches the utc scale transform first as a new Time object.  
                # Then the cached utc object itself caches the iso output.
t.utc.yday  # cache hit for utc, miss for yday, so that becomes the new cached attr.
```

Other schemes are possible for caching on a global basis instead of a per-object basis.  That would impose a firm limit on the memory cache used in sum by `astropy.time` objects, at the cost of some code complexity.
@iguananaut - I just realized that `__setattr__` is not defined so the user is free to do `t.mjd = 10.0`, with undesirable consequences.  The metaclass solution will not allow this right?
Since all you use from multiprocessing is the Pool class you could just `from multiprocessing import Pool`.  That won't introduce a different "multiprocessing" to the local namespace.
It's trying to make sure that the rings it generates do not have wraparound violations.  While tinkering with the algorithm I was trying to answer questions like how large does a ring need to be to satisfy diversity constraints, so was allowing the ring to grow until it was met, but as rings had to be a power of 2 I needed a mechanism to generate good rings when closing the loop.

A better option would be to speculatively close the ring  and if that fails, continue on without the constraint, but the function had served it's purpose by then.
Actually, it's only used in one place and it cannot be `repair`.  I know...this is confusing.
Почему переменная называется `HTML_O`?
Она ж не про оптимизированные файлы.
Couldn't that import run in an own thread and just block usage of the status bar for other stuff, while doing that?
I changed this with the last commit, would be nice if you could take a look. That GUI stuff is pretty new.
It only uses boost::interprocess::file_lock in init.cpp, so it's not needed there.
Yes, we can ;-)
I just realised that I was wrong about suggesting not to call size. That will call "count" under the hood, so in fact it's exactly the right thing to do here.
No, it was a duplicate. Just a way to get all of the children added to the parent. I cleaned up the mess. The code now gets the list of children for a given parent using a lookup_object call on the list of object_id.
Agreed, a better regex would be:

    ^[ \t%A-Z][A-Za-z0-9]+

If all non-blank lines don't satisfy this regex, the program isn't standard MUMPS code (I believe).
node-int64
Why does it say this if there's an actual implementation?  Normally you see that message for methods that aren't really meant to be used (NotImplemented or similar).  But there seems to be an actual implementation here, so I'm a little confused.
is this a safe singleton?
Why do we care about the remote's name? FETCH_HEAD uses the url, and to decide which entry to mark for-merge, we should only need to know whether the current branch is tracking one that we're fetching, so we can put that one or the default. Or am I overlooking some part of this?
can you also make a pull request against Fiber
Consider changing the default pattern "\\s+"
Please remove this additional whitespace
you want to point these links somewhere I assume :) use the ``url(...)`` helper. Look at the mozorg app to see how it's used there.
Yeah, if I add `value = tzinfo.localize(value)` here, I get my local time correctly.
Using one PHP block would be more readable here
Replacing water with fire seems like an odd thing to do, IMHO
Here and above checks against `null` should look like: `null === ...`.
Maybe a boolean cast ?
typo: `return` instead of `$return`
What exception can be throw ?
The reason simply is that the implementation of nextBytes() is easy to get
wrong, and then jeopardizes the entire class. Why would you like to extend
it?

I understand that you might want to have predictable values for tests,
that's why we need to ensure that for the same starting seed, and the same
method calls, the same results are being returned. This was not the case
the last time I checked, but it is fixable. That is also the reason why
removing the seed provider entirely is not a good idea.


On Mon, Oct 15, 2012 at 2:36 PM, Bernhard Schussek <notifications@github.com
> wrote:

> In src/Symfony/Component/Security/Core/Util/Prng.php:
>
> > + * (c) Fabien Potencier <fabien@symfony.com>
> > + *
> > + * For the full copyright and license information, please view the LICENSE
> > + * file that was distributed with this source code.
> > + */
> > +
> > +namespace Symfony\Component\Security\
> Core\Util;
> > +
> > +use Symfony\Component\HttpKernel\Log\LoggerInterface;
> > +
> > +/**
> > + * A secure random number generator implementation.
> > + *
> > + * @author Johannes M. Schmitt <schmittjoh@gmail.com>
> > + */
> > +final class Prng
>
> Is there any compelling reason for making this class final?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/4763/files#r1841268>.
>
>
`_` should be removed.
buildViewBottomUp was removed completely. Do you think there's any point in leaving it in? People *need* to adapt their form types anyway.
This is improved in another PR that I already have waiting locally.
It also breaks https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Routing/Loader/RestXmlCollectionLoader.php#L108
which makes fos routes not valid anymore.
Is there any way to get a PR like this merged if it breaks backwards compatibility? IMO the break is pretty small. I could resubmit with the additions only but then the attributes would be inconsistent.
Typo here, should be: `will`
Omitting shows only services which are tagged grouped by tag, so you can see all the registered tags and which services are tagged with them.

Looking at it,  getting the tags in the ```execute``` method is wrong a they are only used in the ```outputTags``` method
In symfony, we usually put the parenthesis even if there is not constructor argument.
docstring mis-documenting a bit

also not really necessary for a private (_-prefixed) method like this. comment it if the method name isn't descriptive enough (this one is)
@JosephPeng 其实我也觉得这样的注释风格不太好……
能不能再提供几个参考的样例？
我记得你之前发过一个，但是好像当时不太认同那种风格
或者是不是把所有一级和二级的那些注释都去掉？
%%%%% 'buaathesis.cls' %%%%% BEGIN
%%%%%%%%%% class clarification %%%%%%%%%% BEGIN
只留下三级的注释，并且再把END的那一行和BEGIN那一行的BEGIN字眼都给去掉能稍微好一点？
If the code excepts before this line, the lock is not released.
Also, I think it is going to need to define a ```__hash__``` method for the performance tests to pass?
Space was added for purely aestetical purposes - this is of course not right, it is not separating content from style. Probably the space should instead be added through styling of the A tag wrapping the terms, and we might do away with the commas as well while we're at it.
There is more stuff to do to cancel the dragging state. I think this function should look like this:

```
    def _drag_mouse_leave(self, event):
        if self.end_drag_on_leave:
            self._cancel_drag()
        return False
```
I know that the "hidden" column in the eztags is not required because of a default value, but I would still like to see "INSERT INTO eztags" SQL query, having it.
Why does this need to save the configuration?  It doesn't look like it touches the global config.
changed function name to indicate that it warns, it cant save... due to the inabilty to run async code on browser exit as mentioned above.
ah, it should be moved down and changed to "two methods"
We still need a container that could wrap the header and the content, even if we use the inline-block trick or the table display one.
We can change the `<div>` for a `<section>` but we must have the same wrapper for the title and the content.
I've modified the structure in conversation list item. I use a unread class to control the highlight(before pseudo element) and tag show/hide.
The Wikipedia page says the underscores are part of the prefix. I'd just add them to these strings here.
And since you have to do some minor follows ups for stas, may as well get rid of this
console.log with more info, this is impossible to know that this error came from the blutooth :)
This line is only going to be reached if there is already an enumeration pending.  And if there is, I would expect that launching a new enumeration will just slow things down more, especially since advancedEnumerate() just has to loop through the records.

So this feels unnecessarily complex and inefficient.
Also this function is faulty. You don't know if it is the sleep menu is visible or something else that use the list menu is visible.
this should be done once import has finished and not only when there are unSelected friends
I was in doubt before doing this. Thought that if you put your password wrong, would be better to clean it as being hidden with *, and if u put ir right, would never matter. But if you have other thoughts and prefer to leave it as it was written, I can change it, not a conviction.
Yes, I think it is better to rename `_on*` with more meaningful names.
Also we have to implement this 'Resend' functionality properly (is not working in the device...)
This builds a hash consisting of

<pre>
{ 'bmc' => ProjectRazor::Slice::BMC,
...
}
</pre>

This avoids the need to do Object.full_const_get(SLICE_PREFIX + @namespace.capitalize) previously.
下面这部分的文档描述对不上代码中的 UploadToken(opts)
Because [strip_trailing_zeros](https://github.com/twe4ked/rspec-core/blob/efeb4973293b7018377a2697c30289c2539a28f4/lib/rspec/core/formatters/helpers.rb#L26-29) returns a string and [format_seconds](https://github.com/twe4ked/rspec-core/blob/efeb4973293b7018377a2697c30289c2539a28f4/lib/rspec/core/formatters/helpers.rb#L20-24) uses that and it gets passed to the `pluralize` method.
why do we need it here anyway if it is just an empty method?
It seems something is wrong here. It should be the other way round. Only save the ghost if the time is less (thous faster) ... :wink:
Or actually, something more descriptive would be even better. Something indicating that it's used to restore the old config
not clear what this means. Do you require associativity here? If so, is it not acceptable to require an implicit Monoid[T]?
Commented out code (hey, at least this test will always pass)
Done. The ZooKeeperInterface uses this method when it logs what it's writing to ZK, and since we always just pass in whatever we're writing, it may not always pass a Hash in. This is why this guard is present.
Like before, use a hash here to clean up how the caller uses this class.
Erase out commented lines.
s/binded/bound/
include <Module>, c'est le using namespace du ruby, ca clarifie pas vraiment les choses...

Faut que je regarde l'utilisation des helpers de plus pres...
But that was a good catch. Proposed fix on commit cf5a239661b05d05c1db120f7c2c1e378d274ff4.
IMO it should be a do...while, what about just moving `$form  = $form->getParent()` in the loop body, the rest is easy to undertsand, no ?
No priority implied.  I just want a shared list of what needs to be done.  Can you add that to the TODO after I land it?
Since we are dumping debug info for the rulesets only I would expect this code to be in ruleset:
Again, this is just there for usability reasons, without it presently if you don't have unix utils installed on windows, you can't download composer via CLI. This one might be solvable by shipping a windows MSI installer though, at which point I would happily remove the eval hack.

As for what @EvanDotPro suggested (adding CA roots) AFAIK it's only added to ~/.composer/trusted-ca-bundle.crt, which is composer specific and will not affect anything else. Obviously it is still a problem if it contains revoked CAs, so I guess the build-ca or similar command would be a good solution and could be done as part of the installer script as well.
again, this feels a bit dirty for a template, but due to the complexity of the football-nav's usage (it ends up on section/tag pages as well as football ones, so making them share a common model is quite hard) this seems the best place for this logic.
I really don't like assigning the results of an if statement - it makes for hard to read code.  Could you please do the assignment inside the if?
Yes, is there some specificity that prevent to use the factorized code in util-runmodes.c ? For example, you can have a look at : https://github.com/regit/suricata/blob/master/src/runmode-pfring.c#L407
Just 2012 here.
The signature clearly mentions `items`, I don't see a reason to break English rules (noun as adjective being single) here.
Could you please add comment explaining where that property could have came from. Also assuming that `CO` is not undefined feels little fragile tome. Could you please add `|| {}`  at least ?
Cause CFX-py spots it and rejects to build an add-on :(
Doh, it should be dev.myfavoritebeer.org, not www.myfavoritebeer.org.
Lets leave it as is given that is mostly a copy of the tabbrowser.xml file's content. Therefor please note that in the jsdoc comment of the function.  It should be clear that you copied that over.
On Tue, Nov 20, 2012 at 1:47 PM, Colin Hebert <notifications@github.com>wrote:

> I think that adding the exception as a parameter for the log would be more
> helpful as it would provide the entire stacktrace to the logging system
>
This is mainly aimed as tracking down misconfiguration (sysadmins) rather
than for developers so I think just logging that it fails is sensible.

-- 
  Matthew Buckett
`@return array` ?
It is! I'm changing it to `setParentSchema` and `getParentSchema` then
This gets included in a *whole* lot of places, and defines a broad API for a number of classes outside of the DSL.

You need to note that, at least, here - so that people are aware that this module also defines public API on the compiler, the node environment, the resource, and the type loader.

That is important, because every change to this class is a change to the API of those other classes.
I'm very uncomfortable with this hard coded assumption about the sequence of calls an agent is going to make. Unless there is some detrimental effect on the system, I think we would be better off just always checking the certificate.
Object allocation is reasonably expensive in Ruby - there doesn't seem to be any reason to recreate this every time it is used, rather than to preserve it in a (possibly lazy) accessor?
@daniel-pittman updated
I think the schema name should be checked in malformed request and return 400 if it doesn't exist.
Alright, so, I implemented the suggestions on the newer commit, including the changes to the documentation.
we should also display the same lineno since we're introducing a new line
Right, fair enough - this is always evaluated of course.
I'm adding one
This should test `method_exists($this->session, $name)` before trying to call it.
Had an error using the static keyword - the function keyword wouldn't parse with it. Ended up pushing the closures to protected variables instead.
Never liked cloning items... Maybe this should be handled somewhere else, like `$this->getTargetElement()->getCopy()` or something like that. Also, remove the commented code
+1 for the comment.
-1 for still declaring the var
Surely there's a better way of doing this? Change the method signature for `EntityHuman.a(int, int, int)` to `EntityHuman.a(int, int, int, boolean)` and make `EntityHuman.a(int, int, int)` call that method with `false`?