labofsahil/github-event-dataset-2012 huggingface dataset:
Good to know. I have often wondered if the "second" line should be indented to align with `$title` or with `string` since both versions occurs in the core.
Yes, The ``@Enum`` works just for ``integer | string`` values, cascade is a string array.
should this not default to HYDRATE_DOCUMENT?
`logger.debug session[:return_to].to_s`
Would it be useful to have split with negative indexes in Enum? In this
case we need to remove current limitation of Enum.split which is it only
works for ordered collections.

On Thu, Aug 30, 2012 at 8:10 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/module.ex:
>
> > @@ -462,6 +462,52 @@ defmodule Module do
> >      end
> >    end
> >
> > +  @doc """
> > +  Split the given module name into components.
> > +
> > +  ## Examples
> > +
> > +      Module.split_name Very.Long.Module.Name.And.Even.Longer
> > +      #=> [Very, Long, Module, Name, And, Even, Longer]
>
> The current implementation is actually returning a list of binaries or a
> list of lists. Should we return atoms?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/446/files#r1497661>.
>
>
Not that slow, I am just being overly cautious — it is better to say it might take a minute and it will only take 10 seconds... makes you feel better
This JOIN caused articles to be lost if category mapping didn't exit.
Also, I'm wondering if we shouldn't make this by default. Why do we need 'html' to be specified explicitely somewhere?
log.error will raise the EasyBuildError (the raise was there from before this was the case)
break description into multiple lines
Nice catch. Did you stop test execution and drop into the Firebug console, or is there an easier way I could have caught this?
this is wrong. This file is deprecated and triggers an E_USER_DEPRECATED error, which makes PHPUnit fial due to its error reporting. And the file will be removed in a few days. You should use ``vendor/autoload.php`` which is the new location since more than a month
Did you tried: `curl_setopt($curl, CURLOPT_PROXYPORT, $proxy->getPort();` ?
I suspect this will fail as it doesn't match one of the choices. We could allow it to fall back to the default value (and optionally change the default value). Otherwise we should either find a way to allow options outside the list of choices, or remove the list of choices until we construct/update the jobs on demand.
I think this is breaking lint
You rock for adding this test!
indent brace by 2.
i think we should probably add a .to_s to the @vm attribute (this would break other compute providers)
Or not. I personnaly think scrollbars are useless in that situation, except as an indicator of where you are in the view.
@zmoazeni @jlee42 I will double check - there seemed to be a difference in how Harvest responded.
AFAIK, in square brackets the only things that need to be escaped are ```-``` and ```]```.
Can you name the file after the module? `display_pods.rb`
These `<`s need to be replaced with `&lt;`s to work in IE

ok.. there are a bunch of cases of this... I'll stop pointing them out now
Don't know ... probably because the comment was here
This looks inconsistent with the description
Didn't even see that this had already been merged before my last comment. Thanks @fabpot :)
I don't think I've ever encountered a more helpful comment. All mystery and intrigue of why I hadn't already done this dissipated in an instant!
you should/would get an `AttributeError` if `STATIC_URL` is not defined in the base settings. you're probably best off doing `getattr(settings, 'STATIC_URL', None) or settings.MEDIA_URL`.
This is basically just for Directory Indexes so both of these work:

    activate :directory_indexes
    page "/about.html"
    page "/about/index.html"

I realized all our tests target the original path, even when Directory Indexes is turned on.

I really hate the having more than one path.
I do not know the exact reason why, but when using the .scrollto class the test do as intended.
When using the id locator, sometimes the click was made on "View All Reviews" link.
Feel free to test my theory out, but this is what i've encountered when running the tests locally and i've seen that this test was also failing sporadically on grid.
I've also tested it with selenium 2.19 & 2.21, with FF 9 & 11.
You're not wrong but I heard that `until_not` might be deprecated because it's the same as just using `not`.
Changed it to "Export as CSV"
This seems good to me. We end up overwriting `other_hash['title']` with the "actual" title before making the edge anyway, right?
Can we call the callback before the `getUser`, just to make it clearer that getting the user and re-indexing happens *after* the `updateUser` is finished?
module.exports.hasRole = function(principal, subjectPrincipal, roleId, callback) ?
You can check for a logged in user here as well, in which case the 'ctx.user()' check on line 204 shouldn't be necessary anymore.
I'd be tempted to split revisions out into a separate file, to make sure that the content API doesn't become too large.
I think we can move to a default limit instead of requiring it. Simon has already started doing this.
typo: Disbale -> Disable
we do not use the fqn in the annotation when there is a use statement for that class. (though i admit the existing code is not consistent about that)
Old style. Will change this.
The Windows version of dmd.conf is called "sc.ini", but I'm not sure how to find it reliably.
@lilumi когда возникнет желание в main.m у какого-нибудь объекта вызвать метод createDNA:(int)capacity.
Согласен. Хотя в рамках условий данной задачи можно было обойтись вообще без нее.
Хех, я тоже на делфи писал, как тока он появился. Лет 7 писал... 
А динамическая типизация — местами хороша :) Главное — правильно готовить.
Matched the editor; just a sloppy indent.  Thanks!
Why wouldn't we use a serial GCD queue + queue-specific data to represent this?
I didn't catch this in my initial review, but it's legal for a signal to error without sending an `NSError` (i.e., `[subject sendError:nil]`). Maybe this should be flipped, to check for equality with `@YES` first.

It'd also be great to add a unit test for this.
How do you feel about making this a `respond` instead of `hear`? Seems to me there'd be too many false positives when doing a hear.
Why did you do this change ?
@xumingming 不用吧，http://dev.clojure.org/display/design/Library+Coding+Standards里头说：  Don't use a special notation for constants; everything is assumed a constant unless specified otherwise.
> good.. I'm thinking of a way to update the sample data incrementally.. (similar to rsync) like that things won't break if it is outdated

cron job to make the tar.gz and automatic email to paul ? :)
Would it be better to have this accept an Option[CSRF.Token] implicitly, and then also provide

    implicit def csrfToken(implicit request: RequestHeader): Option[CSRF.Token] = ...

It could make testing of templates simpler, since templates that just depended on the token would not have to have a whole fake request mocked with the token added to it.
Can `@announce` be removed once this is passing and ready to go?
Yes, we should assume that.
版本以后
版本开始
并不是所有的连接都会被模块计数；只有那些正在被处理的请求（这些请求的头信息已被完全读入）所在的连接才会被计数。
again, it should be `to.equal false`, please change this everywhere...
Children are automatically stopped when parent is stopped
doneSync isn't used, intentional?
Huh?? This should be `Piecewise((x, x > 1), 0)`.
oops:  self.gens_dict = dict(zip(self.pol_gens, xrange(self.ngens)))
Та же хрень с кастом и неймспейсами.
Здесь вполне бы подошло auto.
叫 `dist-tabs` 但裡面又包很不是 tabs 的內容, 這樣不合理   要換別的名字
I like to see message boxes on the task bar on my apps but if your rules need that false, i can add it.
check out [pluralize](http://api.rubyonrails.org/classes/ActionView/Helpers/TextHelper.html#method-i-pluralize), so your app never says `1 points`
This should just re-render `new` to preserve the user's input and maintain the errors on the object.  This would become `render :new`
wrong indent ?
If you add a repo, please generate it and add it to the source tree
Please declare all used namespacein file header
please remove the `protected static $_instances = array();` declaration
please remove this new line
should use ===
Yup, I saw this dependency with underscores in Andy's event directive first and was wondering how it works... This is a total mystery for now: both how and why it works :-)
Thank you!

Merge done. :thumbsup:
@coolwanglu removed. Overlooked :)
That is what I did, but I think the github said that I removed it. The line below says it correctly.
My god, why so much import space
So if I understand it right, we'll simply stride on if the b_d_m is None? That's what the new change reflects, anyway.
When 1.2 has been defined :)

I assume this workaround to support 1.0/1.1 versions of hash topology headers works fine with the Hot Rod client tests?

I'm very pleasantly surprised that you remembered to take into account this important use case into account.

A JIRA to design Hot Rod protcol 1.2 should be created asap. If you already have any ideas of what to send to the clients and how to do it efficiently, please document it in the jira or the design document. This would be a good opportunity to include https://issues.jboss.org/browse/ISPN-1293 into the new version of the protocol.
Just wondering, the default number of owners is 2 and you're configuring a 2 node distribution test. Wouldn't you want to test how it behaves when some data is not present locally? Is this relevant for the test?
This is leaking file handles
Those lines are added because our repos are bare, they don't have a working dir and hence no .git folder
Ok. I'm satisfied that the behaviour is intentional (even if I am uncomfortable with it). I think it is worthy of a comment at this code point to mention that there is a different behaviour between None and not supplying anything. Other than that, I think this line of code is fine.

Thanks
Since you have extended the capability of this function (file handles are now supported), can you improve the doctoring a little. Perhaps the variable name ```frame``` is not longer appropriate - maybe something like ```img_file```?
Adding the space after the unary minus looks a bit odd, doesn't it?
what do you mean by real delegates?
а isset(static::$names[$id]) не работает?
not required, simply pack it on this one

On Tue, Aug 7, 2012 at 4:36 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/TCP/TCPProtocol.cs:
>
> > @@ -0,0 +1,98 @@
> > +﻿using System;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using System.Text;
> > +using System.Collections;
> > +using Org.Openengsb.Loom.CSharp.Bridge.Interfaces;
> > +
> > +namespace Org.Openengsb.Loom.CSharp.Bridge.Protocol.Tcp
> > +{
> > +    /// <summary>
> > +    /// Simulation of the TCP protocol
> > +    /// </summary>
>
> ok. I will include them today or tommorrow. Should I do a diffrent pull
> request?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321857>.
>
>
Ah, in loom-java, I designed this to be an attribute of the DomainFactory.
Why does the DomainFactory contain attributes like "serviceId" and "domainType" but not "destination"?
Is that thing thread-safe?
agreed :-)
shouldn't this be #customZoomOut - I don't think it matters in practice, just for consistency
huh? version is weird?
It should, I also added a data attribute to distinguish the buttons instead of adding 4 handlers.
@arnodeclercq We probably don't need the `.each` in here.

Apart from that I also don't think we should use the jQuery `Attribute Contains Selector` in here.
Since that will be triggered for all files under `/dev/skins/'.
We should only select a specific world skin.
Id prefer a friend class since this shouldnt be touched from outside
ok even better - could you add a function in LatentLabels - obtain_from_generic that returns the LatenLabels object (look at BinaryLabels.h for an example) - so you only need error handling once and good.
that's for the case when em is closed. when you get it from doctrine it creates a new one so other tests can run after a failure
$p_ - we don't need this.
I am confused :/
jellydoughnut, when they change the allowed length it will break/change all mods that use this function with default value. Also the change that was made here, is just a lazy work around. as I said, the function calls should be changed and not the default value.
Should the type for parameter ``$privilege`` not be "string|null" instead of "string"?
Are you sure ``!(function_exists('apc_s...'apc'), '3.0.17', '>=')`` has the correct type as ``*`` is not a sub-type of ``boolean``?
Are you sure you want to override the parameter ``$tagName``? This often makes code less readable.
Making a Test comment
DocumEntation ;)
use a var for `"run-button-" fnar` as it's used twice
You couldn't  swallow errors
I'd recommend you also put this into your global .gitignore :)
Removing, since sql parser logs incoming sql anyway.
Without the `map`:
~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
Ouch. I'll fix it.
Or is there a different lwrp for installing via epel?
`station_info` -> `stations_data`
`(collapsed == true)` -> `(collapsed)`
For what do you use `datetime`?
Don't understand your comment. And I also see that mine is on the strange line.
You are still using JSON?
NOOOOOOOOOOOOOOOO. You made some big copy-pasting here. You know that I don't like it. You know why libraries are? Because they can be *used*. Not because you copy-paste the code. The idea is that if library is updated, you get its update for free. Not that you have to keep things in sync.

So, django-missing is a library and you should add it to our project. How we are adding libraries to our project?
It would be nice to at least log this, but AFAIK we can't easily log anything from XULRunner.
This is done automatically when declaring a dependency on a keg-only formula.
I would suggest leaving this and TeraSmartArray undeprecated. They're still functional, and potentially usable in various situations unless you have metrics showing they are strictly inferior to your replacement in all situations.
STATUS_LOGGEDIN for SMSG?
why innitialize you instance not?
Inner Will not Inner Focus, but the spellId is correct ,-)
Make instance a member variable, NAO.
I was thinking more about having a `DoctrineAdapterOptions` that has the fields we needed, but I suppose this will do the trick too.
Better: 

JavaScript also creates a __Local Scope__ inside each function body. For exampmle:
Should add a bit more to this comment to say why we're doing that
nitpicking here, but why aren't you either using `color` everywhere or renaming the parameter to `color_name`?
here it seems that the lookup can fail. Maybe should you use self.commands.get(args.command, None) and then do a test with `cmd is None`
Nope, sorry, could be why it was crashing for you. Mr. D included them and
then it worked.

On Sun, Sep 16, 2012 at 11:03 PM, Todd Pickell <notifications@github.com>wrote:

> In
> GroceryInventorySystem/GroceryInventorySystem/GroceryInventorySystem.cpp:
>
> > @@ -1,11 +1,24 @@
> >  // GroceryInventorySystem.cpp : main project file.
> >
> > -#include "stdafx.h"
> > -
> > +#include "stdafx.h"				//standard header
>
> #include goes into the stdafx.h file only #include "local.h" in the CPP
> files
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/myappleguy/ciss243Final/pull/3/files#r1615847>.
>
>
The `_mapping` is an old relict from the times when we has the elastic search based datastore. 

The idea for the datastore is the following:
`datastore_create`: for create, alter and bulk insertion when you create a resource
`datastore_upsert`: for insert, update, upsert once the resource has been created. There might be different authorisations for both endpoints. 

If you think this too confusing, I'll have a think about it and change it in the next version of the datastore.
This particular line triggers a reflow, but I don't quite get the purpose of `this.textarea.style.height = this.textarea.scrollHeight + 'px';`afterwards. Is it to cope with some painting issue ?
But then all extensions get exactly the same name for older versions? That is IMO not better. The id was used so that they are at least different.
As far as my theme is concerned, I'm not happy with the behaviour of `%~` whether or not `cdable_vars` is enabled, so I'd really prefer to keep the existing string substitution.
iterations should go on results instance

see for example: https://github.com/statsmodels/statsmodels/blob/master/statsmodels/genmod/generalized_linear_model.py#L413
Please spell out whole words: *db* -> *database*.
Remove trailing `/`. Not in name, but in regular expression at the beginning!
Can this test use a Hosted repository (or mocks) to avoid starting up jetty?
Better now? :)
This was intentional.  According to the PD spec, page 14, you'll see that the oid root is in the message, but the homeCommunityId is built on top of that with the prefix:

<!-- Used to carry the homeCommunityId --> 
<agent classCode="AGENT">
<organization classCode="ORG" determinerCode="INSTANCE"> <!-- homeCommunityId=urn:oid:1.2.3 -->
  <id root="1.2.3"/>
</organization>
Do we need else part? As /authenticate is default as authorize_path
Will trust you that changing this from warn to debug is right.
It looks surprising: will the underlying exception ever get logged to the user? Should we be logging once at warn and then guarding subsequent log messages to just be debug?
Would be nice to have a unit-test for this (though I see it is tested by ShellSensorAdapterTest)
It looks similar to ExecUtils and some code in StartStopSshDriver. Are they related? Could they be merged or share code?
Wow, any big changes we should be aware of upgrading to groovy 2.0.5? Is it all backwards compatible with 1.8.x?
Great we can finally do this now that grails is gone!
Can you use the annotation instead? Keeps it consistent with the rest of the library tests.

See: https://github.com/catchamonkey/phighcharts/blob/master/tests/unit/ChartTest.php#L50-52
Wanted to do that but phpunit won't let me set the default 'Exception' as setExpectedException .. wants me to create a custom exception type for testing this .. bit of an overkill :(

The other way is to catch the exception and assert on the exception message .. that's a bit messy
If `approved` is on
Ahh. Ofcourse. Neat trick :)
doesn't really matter, but I propose you put this in Utilities/python
Ouch. That's going to make writing tests for the browser app pretty much impossible. Why is this necessary?
Yeah, it should be that way, that's my fault.
Es lo que tiene diseñar un código y luego no acordarte del diseño que pensaste, creo que esto tampoco se usa xD. Va fuera también.
Trebuie puse acolade la blocurile if chiar daca au o singura instructiune (Code Conventions -> pag 12 - 13).
It isn't bad to have it, though. It's an advantage to choose between 3 or use multiple ones.
Ааа, лучше в цикле добавлять. Либо Arrays.asList
При возникновении ошибок надо сигнализировать об этом.
This awkward code is a sign that some object similar to `PointSet` should exist for aggregating regions.
These are the "easy" characters. You should also include troublesome ones. For example, "\uB2E4\uB974\uB2E4\uB294\u0625 \u064A\u062F\u064A\u0648"
Typo here. Should be "NSImage" not "NSimage"
Ok, didn't realise it was temperamental in certain 2.6s. In that case it shouldn't cause a problem.
Will this always be present in dev?
If we click Next and stay on the same (Statistics) page we don't need to return Statistics again because we already have it :)
wrong indentation (tabs vs spaces ptobably)
@melissalinkert, tests are green, but what impact does this have? Where might it be used from? And lastly, is the behavior documented anywhere?
Hey Tony!

I renamed it to `label_field` instead because I was already using `labels`
to be `np.unique(ar)`, and it makes sense in that use. Does that work?

Tests pass with this change. =)

Juan.

On Sat, Dec 15, 2012 at 3:54 AM, Tony S Yu <notifications@github.com> wrote:

> In skimage/segmentation/_join.py:
>
> > +    ...                [0, 1, 1, 1]])
> > +    >>> join_segmentations(s1, s2)
> > +    array([[0, 1, 3, 2],
> > +           [0, 5, 3, 2],
> > +           [4, 5, 5, 3]])
> > +    """
> > +    if s1.shape != s2.shape:
> > +        raise ValueError("Cannot join segmentations of different shape. " +
> > +                         "s1.shape: %s, s2.shape: %s" % (s1.shape, s2.shape))
> > +    s1 = relabel_from_one(s1)[0]
> > +    s2 = relabel_from_one(s2)[0]
> > +    j = (s2.max() + 1) * s1 + s2
> > +    j = relabel_from_one(j)[0]
> > +    return j
> > +
> > +def relabel_from_one(ar):
>
> @jni <https://github.com/jni> What do you think about renaming ar to
> labels? Otherwise, I'm happy to merge the PR.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-image/scikit-image/pull/377/files#r2422489>.
>
>
This looks correct, but it seems to me that would be faster if everything would be done in place instead of allocating extra sets... Not critical as of now.
This is what `@expect` is for:)
I don't believe this should be necessary anymore now that you're yielding inside the same process.
We should probably refactor these repeated blocks of code that post the notifications into a couple methods.  Something like `- (void)postUploadCompletedNotificationForRequest:(RZWebServiceRequest*)request successful:(BOOL)success;`
Aah ok, cool, thanks.
Feels like it could be better, but how about:
```ruby
links_by_index = recommended_links.group_by { |link| link.search_index || :default }
links_by_index.each do |search_index, links|
  if search_index == :default
    Rummageable.index(links.map(&:to_index))
  else
    Rummageable.index(links.map(&:to_index), "/#{search_index}")
  end
end
```
Yes, I have the default mac installation 1.8.7. 
Nonetheless, it took me a few minutes to figure it out :)
shall we call it _hibernate-search-modules_ ? (plural)
I suggested assert because it's supposedly removed on release builds, in which you should only execute for development or testing purposes, and an assert is generally better than an exception in that case (you have the throwing, not the catching point).
yes it depends on quite a few settings a user cannot provide (and I don't want to hard code) so the config file seems to be the best solution
Should this be called something like gatherTotalRows()?
The comment in the code here is referring to the decision that the implementers of git made, not any decision that I made...

Once again. the behaviour of my directoryIterator needs to mirror what the standard CDirectoryIterator in jlib does, so that existing code can continue to work seamlessly
Having 10 log archives when the service is running with --max-files=3 looks like a bug from a user perspective, and this is something a test scenario would spot as a bug. Maybe scanning the whole directory can be done at startup time only.
Why isn't `signature` part of `query_string` above?
Yeah it actually does. The insane thing is, if removed vendor and then did the submodule update, things looked fine and only moments later vender showed up as modified again. I removed it again and did the update, same story
If you look at all the methods it seems to be the same for [2.3-stable](https://github.com/rails/rails/blob/2-3-stable/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L367), [3.1-stable](https://github.com/rails/rails/blob/3-1-stable/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L414), and [3.2-stable](https://github.com/rails/rails/blob/3-2-stable/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L422).  2.3 uses `tables.detect` instead of the later `table_exists?` however the `table_exists?` method does exist for it, so it should still work as expected.
Do not include gaia changes on your pull request, please
Do we really need to support both the modes?
Because on every syslog daemon I checked, the "default" source is s_src and not barely src
If remove this._super() the private variable of _ignoreAnchorPointForPosition is false, otherwise it is true. It will affect scene's drawing.
remove the buisness id
@shacker please create a follow up PR to change this to `!==` instead
Why not `template_values[insight_name] = insight`?
Myös merkkijonoja voi vertailla `=` funktiolla.
`(not (empty? live-ones))` would a bit cleaner.
Oh, I noticed that you ended up unpacking all of the `lstsq` calls to `[a0, a1, ...]`. My original suggestion for the code comment was for the instances where you set `params` as the return value of `lstsq` (and then used reshaping on the `params` array). The comment is no longer necessary, in my opinion, but it's up to you.
``rows`` or ``rows/2`` ?
I'm not sure why I used `c3`here... must have been a reason for this. Nevertheless changed.
We can also remove this and let fidx = range(len(self.files))[n] be the test for if a the type is a good "slicer".  The errors this raises by default might not be as informative.
This can then also be changed to `projection.project(this._ellipsoid.cartesianToCartographic(p, p));`
Is this general enough that it beyonds here in the `Specs` directory?  Or should it be in `Specs/DynamicScene?`
Right, the instructions in a rule have to be tabbed because Make is weird. Everything else, spaces.
@alexrp  Actually [phobos/posix.mak](https://github.com/D-Programming-Language/phobos/blob/master/posix.mak). Btw, there will be different pull requests for changing all posix.mak files.
Should TI.UI really be called a module? Seems inconsistent with how we use the term elsewhere.
Looks like this was meant to be for TIMOB-8362 :)
We should be using window.console.log over print in dart:html applications?
is_embedded_doc, 2 d's
After re-reading the original wording, I think it was clearer--but maybe it's because I've stared at it so much.  I like that the original captured the total ordering simply by specifying it for 2 handlers (the later and earlier).  This newest wording also seems to overlap with 2.2.2 and 2.2.3.
El create (a mí) me da la pauta que crea la estructura y que copia el bitarray que se le pasa como argumento. Y el destroy, que libera tanto la estructura como el field. Qué opinan?
Я думал, что utils — это что-то типа набора общих, не привяанных к аплодкеру вещей. Нет?
Ah, good point.  That was actually a remnant from when one of the forms *had* been a subform (i.e. before I broke out the tree-trace function).
Tried it, but for negative angles, it gave a negative value and for positive angles it gave a positive value, so it wasn't ideal for comparison. I used this as an alternative. Seems to work without any issues.
Maybe we should skip db seeding if skip_migrations option is present too?
现在咋玩的？
Ok, glad that is cleared up. Ill make those changes tonight
if I can; then leave it here for review. Once reviewed, Ill rebase, squash and ready it for merge.

Sent from my iPhone

On 21/08/2012, at 3:08, Jonathan M Davis <notifications@github.com> wrote:

> In std/range.d:
> 
> > @@ -4418,6 +4427,19 @@ unittest
> >      assert(odds.front == 5);
> >  }
> >  
> > +unittest
> > +{
> > +    auto odds = sequence!("a[0] + n * a[1]")(1, 2);
> > +    auto odds2 = odds; // copy
> > +
> > +    assert(equal(odds[0 .. 5], std.range.take(odds2, 5)));
> > +
> > +    odds2.popFront();
> > +    odds2.popFront();
> > +    odds2.popFront();
> opSlice must be relative. For instance,
> 
> auto slice = range[5 .. 15];
> must be equivalent to
> 
> range.popFrontN(5);
> auto slice = range[0 .. 10];
> If that's not currently the case with your code, then I clearly didn't read it over carefully enough, and it needs to be fixed before it can be merged in.
> 
> —
> Reply to this email directly or view it on GitHub.
>
`size_t`, not `ulong`.
The idea is that `r[1 .. 2]` must be of the type `typeof(take(r, 1))` for infinite ranges. So, using `auto` would defeat the purpose of the test.
Jason.

I didn't understand what you mean.
Good idea. This is old-style. :-)
You need to put spaces as well ... see @philsturgeon's example.
Not exactly sure if this is really working due to how configurations work, but keeping just in case.
The whitespace inside the `{}` is inconsistent here.
are packages always .tgz or can they be .tar.gz too?
static members like `$TEST_QUEUE_NAMES` would be named as regular variables. Only constants are defined with all caps
It might read better to only have a single test for the value of `isCommodityTree` and then do all of the assignments within the `then` and `else` branches?
I would replace this with `LOGGER.trace(...) / debug(...)`
Generate a new id here
Needs to be `Time.zone.parse()`.
this is wrong as it can be a registry
Oder FindByOrder(Order $order)
Вообще лучше стараться в роли пустой строки юзать `QString ()`, а не `""`.
on a general note, the pull has many parts in which unmodified parts of code were reformanted. This is not ideal beacuse it might create unneeded conflicts during the commit, makes the review process more difficult and end up with code not looking consistent. We provide code style settings for eclipse and idea[1]: using these should make sure that , even if you re-fromat an entire class, it would be only new lines of code that are affected.  If you haven't used the styles, would you mind doing so and reformat to the original lines of code? If you did use a style config please let me know as there is a problem with the config files and I'll look into that.


[1] see "Style Requirements" here:
https://docs.jboss.org/author/display/ISPN/Contributing+to+Infinispan
, and the actual setting here https://github.com/infinispan/infinispan/tree/master/ide-settings
all classes should inherit from `object`, this should be `class UserCache(object):`
hmm, i guess the text part of the email should not contain html links? should we just list the job numbers here? let's do the simplest thing possible and then wait for people to complain/fix it.
If the process exists with code 127 it should be because the node executable/script was unable to run. I think that treating this differently is a good thing as it is a bit easier to understand why it fails rather than getting this:

```
Assetic\Exception\FilterException: An error occurred while running:
'vendor/uglifyjs/bin/uglifyjs' '-o' '/tmp/outputH92B5Y' '/tmp/inputKjLw7I'

Error Output:
/usr/bin/env: node2: No such file or directory


Input:
...
```
One hint that there's something wrong here is that these `self` vars are not initialized in an `__init__` method for the `CaseImporter` instance. That's a strong signal that they aren't really instance-wide state and don't belong on `self`.
Yer, I know this will be "compiled" out... but by having #pragma once at the top of the file, we ensure nothing sneaks in that shouldn't be there!
La idea es que cada "NPN" tenga una serie de capas, que son objetos de canvas individuales. Pueden usarse como hojas independendientes o literalmente como capas (pensando en programas de dibujo).
A la hora de dibujar se usa la referencia this.actualLayer, así que cambiar de capa es solo cambiar esta referencia. El orden de las capas habría que cambiarlo en otro método.
Yes, Amol, I understand.
I'm about this JavaDoc: it's not reflect the reality of resulted txAdvice.
However, I think this code will be moved somewhere up, when Mark will give agree to implement https://jira.springsource.org/browse/INT-2481
I talked to Mark about this yesterday and we felt the Assert was right because it's invalid configuration - and unlikely to break an existing app because it would mean they have variables that are ignored.

That said, I'm OK with a warning too - Mark can change when he merges if he changes his mind.
The XML Namespace Support (described further below) is also very	
flexible in that regard<b>(s)</b> and provides configuration attributes for
each JPA component to pass in and EntityManagerFactory, EntityManager
or JpaOperations reference.

Also we can have the <classname> tag around the EMF, EM and JpaOperations.
Given that capacity is __final__, you could restructure this as

    if (this.capacity != Integer.MAX_VALUE) {
        while(...    {
            ...
        }
    }

to avoid the test on every iteration of the loops (same thing below).
You think I should call `onblur()` directly? This would be kind of messy, I would rather go for moving the code which does the default text insertion 
into a separate function (e.g. `insertDefaultText`) which is then called by `onblur` as well as the `ajaxComplete` handler.

What do you think?
The old name was correct. This is the class name not the header name
Yes, it would be more space efficient, but it might be more expensive when counting cycles depending upon whether flip requires a traversal. At the end of the day, space wins, I'll change it up.
why don't you do ``if k != category and not k in urls:``?
["refworks", "endnote", "pusheasybib"].include? params[:format]
`no` &rarr; `not`
I wouldn't mind a docstring for these small helper functions.
Added a comment, I agree it is but I think it's slightly better for code seperationq
Or actually, to match Bf command line page should be bolded items and not bullet points...
@christianv Can you remove the word 'get' here?
Can you remove this change ?
Assume this was generated from appraisal, but again, local paths bad :)
shouldn't you accept registering a listener for an event if this one has not been initialized yet, even if another event is ?
In alphabetical order please.
the span8 is a vital part of the Twitter Bootstrip grid and has several other effects. Removing it might have unforeseen side-effects (for example in the responsive behaviour
I would prefer "Document classification" than NLP.
will be getNotification now.
Destructors might not do it, we were leaving it to chance. In the long run, I plan to deprecate ```detach()``` and leave delete as an atomic operation (it's not today).
"node" in that case is just a Javascript object designed to look (roughly) like a DOM Node. It's all Javascript. I could add a firstChild getter, but it would (probably) have the same performance costs.
OK I think I didn't get it - we should talk about it tomorrow, but should I reference the Person object itself in the Requirements model or just the ID of the person?
I'm kind of embarrassed to peek behind the curtain.  But maybe a link to the Scala Luxury Puzzle Cabinet.  I'd forgotten about that.

I just implemented your suggestions.

Just building a library with StringBuilder.++=(CharSequence) instead of (String).  I think that's less suboptimal; it makes the "copy the contents before padding" less painful.
Should we start using generic version irrelevant names such as cordova.jar, so that new versions will simply involve swapping out the jar?
Not sure what you have in mind, but it needs to be connected to a host, so the second part here is really just running a normal testcase. What we need to ensure with the initial steps is that the configuration of the ECMAScript debugger is done with the default settings. I have tried to clarify the first part a bit.
This is, however, not part of this PR. Whatsmore, %1$s is here because user can close chat box with Esc or another key it is bind to it. We really should keep this wording.
OK, I will add. But this function is overtaken
Chybka pri slucovani
Кстати, зачем эта проверочка?
Could you do it in if() to set less variables
what is this line for? Surely a newly created mock (created in setUp method) doesn't need resetting immediately?