labofsahil/github-event-dataset-2012 huggingface dataset:
should this interface extend Collection to allow typehinting on it and still exxpecting the Collection interface ?
It is possible only for NSString
This little guy should be indented.
We generally avoid putting "list" etc in function names - this should probably just be `conquerable_stations`.
I'll rewrite it in Scala
I may be missing something. I'm a bit surprised that this works. Indeed, LibGit2Sharp probes for the git2.dll is a specific relative subdirectory structure. See this for more [info](https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/Core/NativeMethods.cs#L18-29) about this.
When I make these unicode literals, I get:

    AttributeError: 'unicode' object attribute '__doc__' is read-only

Should I leave them as str literals, then?
remove \@Nullable
I closed the original request as it was already done by someone else.

I have since added support for capInsets which you might want to consider.

Since its not possible to set strechable images on buttons in IB i added the support to the css module.

Regards

Ash

On 11 Oct 2012, at 18:43, Jeff Verkoeyen wrote:

> In src/css/src/NICSSRuleset.h:
> 
> > @@ -140,6 +142,9 @@
> >  - (BOOL)hasScrollViewIndicatorStyle;
> >  - (UIScrollViewIndicatorStyle)scrollViewIndicatorStyle; // -ios-scroll-view-indicator-style
> >  
> > +- (BOOL)hasImageCapInsets;
> > +- (UIEdgeInsets)imageCapInsets; // -ios-scroll-view-indicator-style
> Should be -ios-image-capinsets
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
We definitely need to document that the array of objects in the form element must either be NSStrings or UIImages. Can you also provide a picture of what these cells look like with both types of objects?
Javadoc, specially regarding exception cases (New cases where it throws exeption)
This one can be just `alt=""`
I could have cleaned this searcher code up, but it's Sphinx-related now and I figured I'll just leave it as is until we remove it.
Maybe the name should be updated to reflect the comment? idsFromFile or something similar would make it more clear in the code without resorting to the comment above. Also, if it remains with the same name better make it defragged (2 g)
Ha!  I almost like `varton-t` better.  :smile:
why ``raw`` ?
It's still not clear to me, sorry...

I think `;`, `,` and `=` should be either encoded or raw according to their meaning (part of path or part of the path parameters). I don't think your PR allows this ? If it doesn't I fail to see how "It just allows users to use it".
I think this exception shouldn't be enforced in the interface.
The implementation might throw this exception so people get warned about false usage. On the other hand, it also throws false positives:
Why am I not allowed to pass array('mykey' => 'optionname')? It limits the use unnecessarily.
Anyway, IMO it should not be in the interface.
If we disable error bubbling on complex forms, errors will end up somewhere inside the form, but not associated to any specific field. Would that be better?
Well that's not exactly right, you don't need to be administrator, you only need the right to "Create symbolic links" see secpol.msc > Local Policies > User Rights Assignment > Create symbolic links
whyusing sprintf when you don't have any placeholder ?
Looks like he ran a script to remove all trailing whitespace. A nice thing to do, but it makes reviewing the pull request harder...
Formatting and indentation doesn't seem right. Please use Xcode style, e.g.:
```objective-c
        [[[UIAlertView alloc] initWithTitle:@""
                                    message:@"You have to be checked in to this venue to comment or +1."
                                   delegate:self
                          cancelButtonTitle:@"OK"
                          otherButtonTitles: nil]  show];
```
Casing.. Perhaps you want "Check In"?
Hanging comma
You can mutate stubbed objects.

Sent from my iPhone

On Dec 7, 2012, at 2:01 PM, Adarsh Pandit <notifications@github.com> wrote:

In spec/helpers/mailer_helper_spec.rb:

> @@ -0,0 +1,34 @@
> +require 'spec_helper'
> +require 'mail_helper'
> +
> +describe MailHelper, '#get_first_line_of_invitation' do
> +  it 'returns the string without the event owner name repeated when the event owner is sender' do
> +    invitation = build_stubbed(:invitation)
> +    invitation.sender = invitation.event.owner

Not sure if you can mutate a build_stubbed object. Maybe it's ok if you
don't save?

Consider this approach which may be clearer to read

event = build_stubbed(:event)owner = event.ownerinvitation =
build_stubbed(:invitation, sender: owner, event: event)poll_link =
link_to(
  event.name,
  event_url(event, guest_email: invitation.invitee.email),
  html_options = { style: 'color: #HEX })

 —
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/245/files#r2352932>.
Why is it removed here ?
I'm in favour of using the standard config. Because this makes it actually configurable. They can use any handlers that fits what they're doing ... syslog, files, rotating files, nothing, whatever.
I did the following changes and it plays using VDPAU and software rendering OK:
In ResetRenderBuffer() I set the minimum value of m_iNumRenderBuffers to 3.
EnableBuffering() and NotifyDisplayFlip() do nothing if iNumRenderBuffers is less than 4.
GetStats set bufferLevel to -1 if less than 4.
In NotifyDisplayFlip() the released buffer is now 2 frames behind the current buffer as you specified.
ditto for TemplateManager, these feel like they should be injected into the Route constructor
actually:
from cms.utils.page_resolver import get_page_from_request, get_page_from_path

only  get_page_from_path should be removed :)
I find it easier to read with the variables embedded:
```
"  -an $start_time_arg -an -r 1 -vframes 1"
```
Fixed! Silly mistake ;)
Done in #2381
This schema has already been part of a release, we will need a 1.4 schema to support this.
Yeah, I'd like to switch to a button here.
We will change it for a raise instead of a warning.
lol, yeah its replaced automatically but I will get rid of it nice catch
I don't think @benturner is not going to kill me if I let you land some code using localStorage. Which alternative do you have?
please don’t land such filenames and try to be consistent with the existing files.

Remember that we don’t want any uppercase character (nor dashes) in these file names, and please check the Gaia guidelines.
Where does this.kKeyRepeatTimeout comes from?
not sure the bug is filed or not ... ping @kk1fff
On 19/07/2012 14:22, Etienne Segonzac wrote:
>> @@ -326,7 +326,7 @@ const GridManager = (function() {
>>         }
>>   
>>         // if the page is not full
>> -      if (page.getNumApps() < max) {
>> +      if (page.getNumApps() <= max) {
> I'll let you get away with it _this time_. But drive safe, and don't do drugs.

Thanks sir! ;)
What about making a IdleTimer class that takes ms, idleCallback, activeCallback in the constructor. This object will expose a clear() method that prevent it from firing. You won't have to deal with a registry and ids and mimick a pretty old API.
we can add here :
padding-right: 0;
Could you modify this to REM?
It's because the shared confirm.css selectors all use form[role="dialog"][data-type="confirm"], and that doesn't match any of the other system dialogs.
Oh right. We split this off into its own file, so I think we should delete the duplicate cloud config in the file above.
I will remove as this is for last n feature.  I happen to write the parser at the same time.   However, we talked on Fri and this feature may not happen.
Not sure how to fit it into that last sentence, but I'd like to mention that you can copy modules synced from puppet forge into other repos based on their organizational needs. Perhaps somehow mention the idea of promotions where they can have a repository hosting blessed modules and another with staging/testing modules.
Use `&&` instead of `and` and rename the header to `X-XHR-Referer`.
I'd move this to after the s.Del(), to avoid inconsistencies.
Yeah that's a better solution.
We usually increase the number if we intend to submit the package. Do you intend to submit the package?
I'm not going to accept changes that will change our public API to include hacks or workarounds.

We just need to find better way to do this.
http://api.4chan.org/doc/sys/accepted_data_submission.html

You don't send anything but forms.
Why not drop the else anyway.
Let's do these commands on a separate line, indented as code.
Don't be lazy. Add comments :)
I know this is a bit annoying (although hopefully not *too* much more than copy-and-paste from `aperture_photometry`), but I think you should have ``Parameters`` and ``Returns`` sections here and the other functions below.  People will certainly be doing ``aperture_circular?`` from ipython, and it would be helpful for them to see the complete doscstrings
Ahh, this may be the problem.  New flow is: add_nic() then activate_netdev() then activate_nic().  There is a new convenience method vm.hotplug_nic() which combines everything into a single call.  Seeing a floating  add_nic() here smells like trouble to me.
I just added self._ref_key() to LRUCache.put().  Seems reasonable to always ref the key when put() is called.  Anyways, this is the only place the put is even called, so it's a bit academic.
This needed to be so specific to prevent MediaElement's styles from overriding it.
better write it:
```
var config = require('config').webhook;
```

... and check that it's not empty before initializing the http_options object.
It's ok.

the grack server file is over here: https://github.com/gitlabhq/grack/blob/master/lib/grack/server.rb
if `orig_height` = 10, and $height = 0, wont this fail? (it shouldn't because either w / h can be 0 )
No, all elements are initialized before being put in the list.
get_item_prices sounds like 'get all prices of single item'. Is this expected meaning here?
Shouldn't we keep RICHTEXT and just add LONGTEXT ? I don't know if there are people that depend on it...
I think I renamed it error
Just a knit with a reason. Roll whichever way.
yeah this makes a lot more sense now! :D fixed
I think the conditional should be data[aType].isIncremental
We kind of need it as now we're gonna be able to schedule update on demand.
We also have response with recommendations which are gonna be saved in database.
I stole some of this from @ednapiranha. Maybe not.
You mean "canonicalize" here, rather than "canonize" - we are not declaring the function to be a saint. ;)
This would be a good candidate for using the nested exceptions. It was a minor fix in the first commit so I could debug what I was doing, before the nested exception work was finished. (And yes, normal ruby raise takes a backtrace as the third argument.)
yes, sorry removed it.
Can we call this `WriteOnlyYaml`? I kept look at the name and couldn't quite figure out what it meant for a little while. I'm just not sure what the symbol for configuration would be.
The class name and the description are at odds with each other: if this should only support resources, you should enforce that.  If it is a general purpose mechanism to define additional functionality on hash-like objects, it should probably be named to match that.
Can you compile this regex up at the top, then just apply it?
This can simply be written as
```js
width: this.$element[0].offsetWidth || 0
```
Surround method names (e.g., "select()", "Zend\Db\Sql\Select::where()") with the <methodname></methodname> docbook tag; this should be done throughout.
We might to leave this line with 'multicheckbox' just in case...so there's no breaking changes for users with existing forms that use this type string? 
This probably has a low probability of causing problems (and easy to fix), but just wanted to note it.
I'd do it as:
```php
if ($string === '') {
    return true;
}
return (bool) preg_match('/^./su', $string);
```
This makes the fact that two conditions are being tested more clear, and removes the need for the elseif.
Carefoul with this and https://bugs.php.net/bug.php?id=55169
* It looks like you've meant == and not = :)
* Also add space before << please.
I think "." might be more obvious.
Definitely a fan of the simplification of logic that's happening here.
No worries. It's likely not just you. :-)
We're try to fix. but to separate from #1032.
Great.  NCP is higher priority.  Definitely do that first.
That can't be, it was working fine before. The rest of this PR looks fine so I'll go ahead and pull it and look into this later today. :)
No extraneous parenthesis. Just "if $u && $u->is-community" will be fine.
Would this work?

```ruby
def short_link
  link.gsub(/\Ahttps?/i, '')
end
```
Going to remove this block as well since it's seemingly useless.
Extraneous space at the end of the line
Is this correct for Velvet? Implementation doesn't show this.
If something is plural, use The, not A
Random whitespace here.
With an even more recent one, it's `for (auto &f : m) fpm->run(f);` or something like that ;)
See above. I think the standard rule of thumb for docstrings is "one line, then newline, then more". But that's just a nit. Don't bother unless there's other stuff to patch up.
Can you explain to me what you mean by a magic string. Further down in the code these are used as default values for privacy options.
Nit: but this could be lined up in a prettier way (attributes lining up makes HTML easier to read).
Please remove the width and height declarations and resize the image to 84 x 22 pixels.
Please do not force updates for a pull request in the future. It will make it hard to see the latest changes.
You can remove the vid variable, and just check against p1.controls();

Should return true or false.
we should remove this line
remove the blank line from the end of the file
stuck on solution for this. How to pass Users credential to  verify Edit page title? Help?
Yikes, yes. Looking at this again, grep can't find any usages of `set_io_encoding` at all which makes me think it can be removed (or does any plugin use it?)
Excellent.

Todd Sedano
Director of Software Engineering
Carnegie Mellon University
Silicon Valley Campus
Developing Software Leaders (TM)
T: 650-335-2812





On Tue, Nov 27, 2012 at 4:20 PM, John Lee <notifications@github.com> wrote:

> In app/controllers/users_controller.rb:
>
> >        end
> >      end
> >    end
> >
> >    def unsubscribe
> > -    puts(params.inspect)
> > -    User.find_by_slug(params[:id]).update_attributes(:digest_frequency => '')
> > +    User.find(params[:id]).update_attributes(:digest_frequency => '')
> >
>
> Yes, we decide to use the _id for security reasons as the unsubscribe link
> would be:
>
> http://craftsmanship.sv.cmu.edu/unsubscribe/50a71f70a3559903f4000001
>
> vs
>
> http://craftsmanship.sv.cmu.edu/unsubscribe/johnleee
>
> We don't believe it'll ever happen but this will make it difficult for
> malicious users to unsubscribe other users based on the github id.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/professor/Hibiscus/pull/40/files#r2244564>.
>
>
Utils is a collection of misc utilities that is not meant to be opened. This justifies having a separate Stdlib. Rutils is also justified because it's only about Resampling.
```ruby
unless args.empty?
```
my bad, we should just use `dir + '/' + file` here
Fixed... almost forget this javascript "feature" :)
we will have a different patch to fix it.
Removing this explicit dependency is fine because the `slf4j-log4j12` dependency has a transitive dependency on the Log4J artifact?
Did you run `rake db:seed`? That installs a bunch of default data.
Nitpick: I'd rather assign a `null` value as a default instead :-P
@dpobel I would better say no.

eZDebug::writeError() may log **RunTime** errors but is not really suitable for errors that is the direct result of bad programming and should fail hard like if a typo was made in a class or method name.
PLEASE :D  Honestly, and since you use get_visible() 2 times you probably should rather do something like

```C
#if ! GTK_CHECK_VERSION(2,18,0)
# define gtk_widget_get_visible(w) (GTK_WIDGET_VISIBLE((w)))
#endif
```

or simply use the deprecated `GTK_WIDGET_VISIBLE()` all the way
компараторы обычно копируют
Also,

can not understand significant difference between:  samplesFromTerminatedThreads and samplesLeft 

both are counters of requests done. Why don't remove one of them?
Oh! Got it now. I will remove the parameter code for now.
I've just realised my comment above appears to be reviewing the work of the last month.

What we should be reviewing in this pull is the appropriateness of these commits for the production branch. Hence my comment above should read 'Is Firebug OK to use in production?'
This isn't required, user's can just check the enumeration
Maybe have the constructor only take `name` and `widget_config` and then add a `from_config_file` class method that reads the config and returns a new object? We use this pattern in various places in vumi.
I suppose that theoretically, the old catalogs will get reclaimed as part of DB garbage collection (as their hashes aren't pointed to by anything else). Same with the old resources and such.

The consequence of that idea, though, is that new catalogs will get treated as though they're "new" in terms of dedupe, so perf may be reduced until we get a single new catalog for each node. But I think that's a totally reasonable compromise for the simplicity. Plus, with the other perf changes in this branch it may be fast enough even doing the extra work. :)
2-space indentation.
should assert that there was no error.
The expected format for configValues should be specified.
Yes, I meant ``JavaJUnit4TestFinder`` :)
space between if and opening parens
You should call the parent::setup() method setup DokuWikis test environment.
When doing this you can delete the $this->oldConfig stuff.
навіщо cache-bundle в require?
i think we want to take this out of the if. otherwise if there is a content set and a content_id but no contentRepository, the content_id will stay in the parameters. (edge case, i know, but still)
might be nice to use `<% include head %>` and `<% include foot %>` here to illustrate how you can do "layouts" with EJS
The code breaks in a bad way if you do it.  Working on the fix.  Can remove the notice when it's done.
подход фактически верный и рабочий, но есть существенный недостаток
если выставить например mutate:100, то этот цикл прокрутится от 300 до 800 раз прежде чем найдет свободный индекс когда их останется уже мало
у меня в реквесте еще комментарии по этому поводу
We're no longer noting stat in the name of the move on purpose.
リソースが増えている…?
Does `youtube-dl` really output `eta` sometimes instead of `ETA`? If so, why not use the i flag on the regexp instead here?
> Good idea about the warning. What is the general rule for the minimum epoch length?

I would say 3 cycles so 300ms for 10Hz.
my bad... maybe add a note then.
Hmm. I think we do need it.

If the request is for the nonexistent page /exists/missing/, and the slug "exists" will be matched - if that inexact page is added to extra_context then the page view won't raise a 404 as it should.

The check could be moved to the page view though, if there's any potential use for the inexactly-matched page in the page view?
No problem, but what is a single backtick used for? Found it somewhere else (`cookbook/templating/twig_extension.rst`) and assumed, that they were used for keywords.
punktuation missing: ... session ID. Do not ...
Thank you, I will edit it!
``ContainerBuilder``, not ``ContainerBundle``
Yea, this sentence is a bit weird / mis-leading, though you do hear "entities" so much around Symfony2 (because of Doctrine), that some note might be helpful. I'd first talk about "models" in Propel, and then maybe a quick note that "models" are the same idea as "entities" in Doctrine.
How about updating this section to use the `parameter.yml` which has been introduced?
No need to receive the block as argument here, since we are using yield. :)
for what? you want docblocks for every getter/setter? seems overkill and unnecessary.
Пробелы внутри: `{ member, dataField };`
Нет. Там стоит editable combobox. И написанный текст найдет с индексом = -1.  Все это получено опытным путем.
```haml
= render :partial => 'pic', :locals => { :size => :large}
= render :partial => 'pic', :locals => { :size => :small}
```
I think it should probably be in WebRequest, but I don't really have a strong preference for one or the other.  You?
Should we keep the option to use :tabedit with argument ? for example: :tabe /tmp/x or :tabe newfile should still work quite well
это лучше тоже вынести в какой-нить отдельный файл. пока хз как лучше сделать. ты питонщик, тебе виднее )
I was hoping you would have a multiply method that took both 2 arguments: multiply(3, 4) or an array: multiply([2, 3, 3])
shouldn't it be the log method called ?
Maybe the comment above is worded incorrectly.
This method works fine, if you are using only a few segments in a moveq, since you can calculate the number of samples by adding up all the times. If there are going to be multiple moveq's, then you have to determine the number manually.
I really need to write something that will automatically chop it up and send in multiple packets, and hide it all in a single method.
I suggest to check for the file existence using file.canRead() (and to return with on the external storage in the list then). I don't want to see IOExceptions coming up if this file doesn't exist.
@ferventcoder can't figure out how to get $packagefolder to the helper... only the main functions know...
Maybe have it extend AbstractMatrix?
Could we just make this class extend AbstractMatrix?
Note that this has never been an issue because ```options[:id]``` is always defined... Now if only I knew the exact purpose of the IDs in the first place.
But it looks like the unlink will fail if files are there...

Maybe should be shutil.rmtree() instead of unlink().
I use 'throws' for 'raises' all the time

COME AT ME, TIM
This wont work as intended if the collection is something like `[1 false]`. Unfortunately the tests won't catch this, so full points from this one.
Yeah, I saw that, but I couldn't resist commenting on it :)
I'll create a JIRA for this.
you should either indent the comment or drop it
On Saturday, September 22, 2012, Phil Elson wrote:

> In lib/mpl_toolkits/mplot3d/axes3d.py:
>
> > @@ -1937,8 +1937,11 @@ def scatter(self, xs, ys, zs=0, zdir='z', s=20, c='b', *args, **kwargs):
> >          zs = np.ma.ravel(zs)
> >          if xs.size != ys.size:
> >              raise ValueError("x and y must be the same size")
> > -        if xs.size != zs.size and zs.size == 1:
> > -            zs = np.array(zs[0] * xs.size)
> > +        if xs.size != zs.size:
> > +            if zs.size == 1:
> > +                zs = np.array(zs[0] * xs.size)
>
> Was the logic faulty in the first place? I can't see that multiplying the
> z value by the size of x is a sensible thing to be doing... I would have
> thought the purpose of this line was more along the lines of: np.array([z[0]]
> * x.size).
>
> Better yet would be np.tile(z[0], x.size).
>
> @WeatherGod <https://github.com/WeatherGod> : Any thoughts?
>

Good catch.  Probably should use something like np.broadcast_arrays()?


>
Please store the jQuery element `$("#last_check_date")` in a var in order to avoid DOM manipulation each time
I change also did change the path to find the wallpaper button
uber-nit: available
cleanup so map.destroy()
Yes, I think this will do
@gsilver there should always be a space after the `:` [1]

[1] http://oae-widgets.sakaiproject.org/sdk/widgetdesignandstyle/cssguide
@schmittjoh uses CS of Symfony2, so remove the spaces around `!`.
It may be a better refactoring to rename the definition into schema the doc definition contain a schema.
Neither is subsilver2 ;-)

EDIT: This is existing code…
Is it possible to define the element type for the array of parameter ``$evaluation`` (using ``array<SomeType>``, or ``SomeType[]``)?
Are you sure the method ``setRouteMatch`` can be called on ``$page`` (of type "array")?
This indention looks off.
Huh. I just tried logging the value of 'attribute' and only see the 3 values. I guess that makes "Javascript: the Good Parts" (p24) out of date, at least in the Chrome JS engine? Either that or 1) I don't know JS and 2) I can't even bloody read.
should you keep a ref to the conn.getProperties instead of keeping the conn around?
I think we should change this to:
    
    return new InvalidArgumentException((string) $element['label']);

The exception type takes care of the "invalid field" in the former message.
The point is each user has his or her own file storage with unique URIs.
:clap:  Good job on conforming to their documentation style.
Sorry, that will break on Windows, right?
fixed. I forgot the "_" in the var names.
Shouldn't this also be false if there are no secure env vars AND the build is not a pull request build?
I would rename this file to `providers.py`.
So... Change all that can be changed to camelcase?
(And no spaces.)

Because duplicate elimination will not work if there is any space or newline difference.
In fact you should be needing to move this to the end, because you are using "document ready" in all your jQuery code, don't you? :-) So when that will be called, `API_POST_URL` will be already defined.
What is this? Camel case? Where is consistency?

`usrnm`??? You want me to get a heart attack?
In which way it does not work? Is there any error displayed?
Please group imports as we are grouping them elsewhere (by library, first build-in, then django, then others, then piplmesh).
You can rather use `mail_managers` here. You don't have to set `fail_silently` to False, that is already default.
Can this be a new issue, because on windows OS is this differently then on linux and mac
Since the other solutions are for Visual Studio 2010 this one should also target the same version of Visual Studio.
In the future, if you could stay within 120 chars, it would make it easier for me to review here on GitHub, because that would mean that I could avoid vertical scrolling :)

Actually, I personally constrain myself to 80 character widths...
Actually from the videos I've seen , the creatures should disappear each time you start a new event.
For method invocations, generally the second line is indented with spaces until the position after the open paren on the above line.
I had no idea something like dt_get_wtime exists :) I can take a look & rebase to current master
I'm not sure I'd put these in the RADIUS package. These are not really some RADIUS specific constants...
Shouldn't we put them in SNMP ?
That should return $FALSE ?
There is no return in case of errors?
DEFAULT_SETTINGS["placeholder"] needs to be changed to "settings.placeholder"
One per logical change (which may include multiple commits), unless they're interdependent in which case all-in-one is ok, but please provide a bullet list of if what's changing. Also I suck at math (though @johnbartholomew doesn't), so if I end up reviewing I'm mostly going to rely on you to say the math is right. Though there's three of you keeping an eye on this stuff, so its probably going to be ok.

Basically, make sure its clear and obvious what's going on :)
Fyi, this causes a warning under GCC. Our usual practice is to write `FlightEconomy(rd.Int32())`. Don't stress it though, its no functional change and we usually grab them during merge.
On second thought, doing that actually messes a bunch of things up.  For example, `Languages.translate_language("Russian", :en, :blarg)` should return `nil`, but instead returns "Russia" because it defaulted to the English translation.
Ok, let's leave it that way for now.
Please ad JDoc
We should use real test email addresses we control whenever possible - don't want to risk sending email to randoms.  So I agree that this should change but unless we own and maintain "example.org" let's pick an address we control.
как вариант
seems inconsistent with our tendency to use more descriptive names for keywords... how about n_photons?
This would be more efficient as `im / (im.sum() * dx**2)`  I think what you do will create `im / im.sum()` by dividing each term, and then make another copy in order to divide through by the second factor of `dx**2`.
Sorry, I was confused, ignore me ... probably remove my comment at some point, but not grave so merging
They are not exclusive. If you are dependent on another cookbook, regardless of how the dependency gets resolved (role, include_recipe), then it should be in the metadata.

As for when to use role vs. include_recipe, it's not black and white. I try to limit the hard-coded dependencies if possible. Perhaps I'm thinking more from a reusable within the larger community perspective (outside company).

With that in mind, this is probably fine.
Erm... Shouldn't this be `$(this)` instead of just `this`? I need to check why I went ahead with this...
This seems a bit odd.  I suppose it means that ``django_sorting`` does not need to be added to ``INSTALLED_APPS``.  Is that the main reason?
I would like this code to not broke in a regular firefox desktop build. It is possible to do 

        var wifiManager = navigator.mozWifiManager || {
          connected: false
        };
I thought a harmless change would ok, but I have reverted it as asked.
nit: 

      queryList.push({
        prefix: solutionPrefix,
        pattern: '^' + solutionPattern + '$'
      });
`count` shows number of things and `num_pages` the number of pages.
If you copy paste, at least get it right.  You want to replace the instances of "pink" above and below with "tox"
readLine может вернуть null
Надо использовать Character.isDigit
No need to cast it because this class is generic:
class AbstractScoreDirector<F extends AbstractScoreDirectorFactory>
The disconnect here from the calcentral.js config file is the assumption that calcentral was bound above to window/global.
Why not leave \t, \r, and \n un-encoded? They are allowed as is, and help maintain readability.
If a user wants to create just a spell they use this method. If they want to do more then they should be able to make a plugin that accesses everything.
Zac this the best, and most optimal way I thought I could test the two scenarios.
I you have any idea on a different approach on how to test the manifest_url link is not editable please do share:) 
https://marketplace-dev.allizom.org/developers/app/marble-run-1352822110/edit
https://marketplace-dev.allizom.org/developers/app/marble-run-1352821375/edit
These are the scenarios for manifest url: the first one is the one i don't know how to test, beside what is done in the test; the second one can be tested with several scenarios.
Dusko,
[cid:C9FDC134-7893-4922-A826-187951B89748]
Good improvement. The only big red block left is the equals method in Address.java.
Regards,

From: Vesin Dusko <notifications@github.com<mailto:notifications@github.com>>
Reply-To: nedap/kadaster-bag-client <reply@reply.github.com<mailto:reply@reply.github.com>>
To: nedap/kadaster-bag-client <kadaster-bag-client@noreply.github.com<mailto:kadaster-bag-client@noreply.github.com>>
Cc: Wout Slakhorst <wout.slakhorst@nedap.com<mailto:wout.slakhorst@nedap.com>>
Subject: Re: [kadaster-bag-client] Test coverage improvements (#3)


In api/src/main/java/com/nedap/healthcare/kadasterbagclient/api/dao/AbstractGenericHibernateDao.java:

> -    /**
> -     * Use this inside subclasses as a convenience method.
> -     *
> -     * @param criterion
> -     *            Criterion[]
> -     * @return T
> -     */
> -    @SuppressWarnings("unchecked")
> -    protected T findUniqueByCriteria(final Criterion... criterion) {
> -        final Criteria crit = getCurrentSession().createCriteria(getPersistentClass());
> -        for (final Criterion c : criterion) {
> -            crit.add(c);
> -        }
> -        return (T) crit.uniqueResult();
> -    }
> +    // /**


You are right, it will be deleted.

—
Reply to this email directly or view it on GitHub<https://github.com/nedap/kadaster-bag-client/pull/3/files#r1863462>.
@alanwww1 MythTV addon 0.5 was merged just before you synced the language files. In 0.5 this string here changed (from 0.25 to 0.26) and your PR overrides it back. Any advise how we can prevent this?
Don't use eval (much, if at all).  Instead use

    app.send(control_method)

.send invokes a method (called a "message") the same as it would be if you invoked directly.
In my opinion, it would be worth stating explicitly that the score is not very sensitive to the regularization strength alpha on this dataset hence this fluctuation of the CV tuned alpha is expected.
You might precise the behavior when `sample_weight=None`.
If you rename a parameter, you can not immediately remove the old one because of backwards compatibility.
I would use a simple `info` instead of progress here. The zoomable progress report does not make sense in that context.
add a space after # for readbility
A better option might be to merge this example with `plot_forest_iris.py`.
you should state that `"modified_huber"` provides probability estimates too
thanks my original goal was to get small window video size but with good quality (video stream 320x240 but web cam resolutoon 640x480) etc, but ill add this patch and add switch/flag to enable/dislable preview window scaling (stream==camera or stream!=camera)

thx
This seems wrong, i'm pretty sure show and hide are actually supposed to do something.

A `TODO: Implement` would be more appropriate
Couldn't these lines be simplified to the following?
```
QColor qcolor(*v8colorString);
```
Ti_DEBUG should be all caps
Line too long (120 char max)
Autre proposition : Récupère la notice d'indexation du document (selon que l'on récupère l'intégralité des champs de description documentaire). Du coup, adapter la ligne 36
`there boxes` ??
Maybe not the best design, ```assignedName``` returns the id if there is one, or zero if none. ```assignName``` gets the assigned, if any, or creates a new one otherwise.

I need the functionality, but am still coming on terms with the right amount of repetition / simplicity.
Not really, just unifying the timeouts as a #define (SDS_CONNECT_TIMEOUT)
It may be easier to catch if you say that `backgroundify` accept a second argument, then you list only one argument: `close` and put this explaination there. (i.e. describing this option like you did for other functions)
all the packages **that are required**
You want to keep as much gunk out of a string as possible. I'd suggest:

<p class='no-cookies'>
<%- format(gettext("Please close this window, <a target='_blank' href='%s'>enable cookies</a> and try again",
                   'http://support.mozilla.org/en-US/kb/Websites%20say%20cookies%20are%20blocked') %>
</p>

Is target critical? Can we add this attribute via JavaScript? ``$('#no-cookies a').attr('target', '_blank')``. We can leave it in to KISS, of course, but URLs should never be in strings, as they might change.
Very good spot by @shacker !
Each of these constants is only used once. Please inline them.
use 1 function instead of 2
GitRevision doesn't fill out its members in constructor.
Same here as with `alive?`.
This is a minor nit-pick, but add a space between the `=` operator and your ruby code. For example:

```haml
= form_tag do
  = lable_tag "Blah"
```
I'd be tempted to make these all caps as they are constants.
Yes, of course. I didn't know GConf was part of MLite. Will change.
Don't know what you exactly mean, but line 946 is necessary to get a working exe file.
Yup, done
You mostly use `nrows = 2*halfRows` in this loop. It would be easier to read using this definition and then just calling `nrows/2` for the couple of instances you need it. Same for `halfCols`.
This docstring is not so user friendly. Maybe replace with:


"""Copy `b` into each channel of `a`.

If `b` is grayscale, each color channel of `a` is set to `b`.
If `b` is RGB, then `a` is set to `b`
"""
Actually, I can't tell if this docstring is true. If `b` is RGB, are the color channels in the first axis (while for `a` they're in the last axis)?
Oh, bourne's not in this project. In that case:


```ruby
model = stub("Model", :count => nil)
model.expects(:count).with("arguments")
model.should_not query_the_database.when_calling(:count).with("arguments")
```
Won't the average user just use existing materials by calling `Material.fromId`?  If that's the most common case, shouldn't be have that be the primary example?  While I love verbose documentation, these current examples might confuse the user and might be better off to just be on the wiki documentation.
Consider: Make this (and GetWebRole and GetRole) extension methods on AzureService, then you can write:

```C#
var role = new AzureService(servicePath, null).GetWorkerRole("worker");
```

Just a thought.
{ should be on the same line as try, and if
Specifying ApplicationContext again in the constructor is redundant.
Case classes could work. But I'm uncomfortable with a case class with a `getValue: () => T` attribute.
To get more coverage, be sure to test that the commands throw the proper exceptions.
the way it is in your current version it is correct. i did not look enough before, so i thought there was a general section and then the ones about transports, but actually both are together. so its all fine like this.
А мы не обсуждали эту фигню?

```coffee
context
  .op
  .newContext
    .op
    .op
```
Why the `$` here but nowhere else?
I understood the reason.
However, there is two points of anxiety.
The first point is performance. Because memory copying occurs, the method to initialize with T.init is slower than explicit non-initializing about the execution speed. This is a very slight difference, but, in a characteristic of move, can have possibilities to be called in a loop repeatedly. I think that it is desirable for this function to work as possible fast.
The second point is an apparent problem. The thing which is not safe should show it not to be safe. Because a frame pointer is initialized in null, the nested struct initialized in T.init cannot be used until it is handled correctly. In this case, I think that you should perform explicit non-initialization to assert that anyone must not touch it until initialize it correctly.
For these reasons, I think that it is better to attempt a method to initialize in void.
Looks like a tab issue here.
The `Throws` clause says that. It _always_ checks for `empty`, so I don't see any point in singling out `R.init`.
This documentation is misleading: assocArray will not work on a static array. Not sure there is a point in mentioning arrays at all, if it works on any generic range.
Not sure what "that this imple" means. Guessing the comment got cut short.
That's strange. I cannot remember writing that code. 
``` Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").address``` should be ok though
You convinced me. I tried your commit and it did not have any negative performance issue. I guess having hashCode and equals is nicer. I pushed your commit.
TextureTarget should be lowercase
If I'm interepreting this correctly.. this would still execute the action for N seconds, but if N > defined value, then connection is closed once the response is ready? Shouldn't we return on defined value instead with hard cutoff?
If that's for your own debugging, you can use the `Log.debug` facility, that will dump to the console, and do nothing in release builds.
**Ideally**, at most two levels of namespaces. We'll have to start implementing a few things to see exactly what we're dealing with...
Shouldn't this line be widget.previous_version.event instead of widget.versions.last.event?
Are you saying description may be null?  Or you are worried about appendValue()? appendValue() is null ready.

Anyway, added a null check.
This string is hard to read; let's pull it out and use a heredoc.
Needs to be commented as well, it's specific to annotations stored as comments. The code is fine, it's safe, but it needs a little explanation.
We should use a localized format, ala: `WoopleThemeI18n.l(completed_on.to_date)`
that seems odd - the style should already do that via: 
<label form="short" text-case="capitalize-first" suffix=". " strip-periods="true"/>

That said - looking at the manual this seems wrong - shouldn't "Ed." come after the editor?
even this part should not be needed when using an uptodate composer
The `updatePlaceholders` method no longer exists, so this throws an error.
reported as JMSBot/php-code-analysis#7
$grade = null;

Und $auto gibts nicht mehr....
Я бы все это в файлик типа `secureutil.{h,cpp}` вынес.
Wouldn't `this` point to the global object here?
here I'm appending the "suites" section of the JSON.  In cases, I append the suite names for each case.  Then, yeah, the import call actually does the suite creation/import.
We shouldn't be modifying the license file imo.
Not Setting, but AuthProvider here
@nicolaasmatthijs - When you look at the jQuery source code for the CSS [1] it seems like they add it for all numbers except for some properties [2] e.g. line-height.
Also made a [tiny test](http://jsfiddle.net/n86Gg/) to check whether it happens for other properties.

IMO we don't have to change this right now but it's good to know anyway.

[1] https://github.com/jquery/jquery/blob/master/src/css.js#L97
[2] https://github.com/jquery/jquery/blob/master/src/css.js#L49
I am actually further restructuring the code ti eliminate that confusion
When you have temporary destination per request (our old functionality) and selector-less consumer
These files are picked up by the Javadocs build and provide package-level comments. There are parallels in the services/servicebus and serviceruntime directories, and similar files need to be added for blob and table, too.
Of course. This is what I proposed. And how it is also done in jQuery. So you can configure global things, or pass options.

In jQuery Visage you can also see the third option for customization: that you define functions, which return this. So somebody can override the function to have some dynamic way of generating URL. And you can override this function on a per-instance basis or globally.
It cannot be ``Zend\Loader\PluginLoader``, as that's a ZF1 class. In ZF2 it should be ``Zend\Filter\FilterPluginManager`` which extends ``Zend\ServiceManager\AbstractPluginManager``.
oh, and the bundle depends on FrameworkBundle too
Are there any backwards compatibility risks with making this change?
can confirm this crash chaplain!
1024 那里应该有个PANGO的常数，我记得。叫PANGO SCALE 之类的
另外我怎么记得字体可以是 pt 为单位？
could you add a use statement for PDOConnection?
``.. versionadded:: 1.3`` should show the message in the doc, like in the Symfony one. The only issue is that there is an extra space before the ``::``
This check is wrong. If you pass an empty class name, the code in ``markEntityToUpload`` will be broken
I was concerned about this being a bit to permissive. I'll try it though.
Instead of writing your own buffer, you could probably just wrap a MemoryStream.
ina ro chera injori neveshti?
dg -moz- ya transform nemikhad
```javascript
rotate : Math.random(-90,90)+'deg'
If we are clinking inside the menu, only close it if we clicked inside an item of the list
switch the order of the if else, so that we have something like if (idMap.containsKey(x)){..} else {...} 
Easier to read positive conditions than those with a "!"
missing ``public`` here
вообще не очень клевая идея так хранить... внизу одни вершины, а в середине другие. А может наоборот клевая. что-то не могу понять...
а роботать лучше с просто const указателями и в этой строке тоже
I changed the code to use the current constants. If they are going away later, we can deal with it then. Until then, this means that we are at parity with the other platforms.
Why are we even checking for `fileType` here? `fileType` isn't a standard property, it is specific to the bug in the test case
I'm a bit worried that by raising an exception here will keep update_product_details from running (if it tries to import stuff while setting up Django). We do use product_details to detect languages in settings.py, so it needs to work without the files being present at first.
I understand what you mean and I agree with you :-)

But..I didn’t did the change 'cause in that case in order to get it working I should move locale directory into frepo directory, the directory containing the settings file. 

what do you suggest to do?

Really the correct way to get the all thing working correctly would be to create a locale and templates directory in each app.. isn’t?
So this line should be removed
Hmm, now that I'm thinking about it, do we need to `require $self->mech_class` first before this can work?
all those changes must be included in '0.7.2-dev2' version.
Add the **splunkVersion** property: 

    splunkVersion = '0.8.0'
how does it looks now?
You are correct, this is redundant. The switch statement was there initially so I assumed all events will go through here.  I get rid of it
What happens if it is already complete? Is that never to happen?
This is never removed
Put a comment after this line, please. Anyway, it's a private variable, so how do you intend to use it? :-)