labofsahil/github-event-dataset-2012 huggingface dataset:
Is this guaranteed to be available by default on all azure images, or do users need to manually install the necessary sdk on their images?  If so, do we need to update our setup.py to declare this as an optional dependency?
Also, can you explain why it explicitly installs old pyzmq?
thx for this.  our enum pattern is to create an additional UNRECOGNIZED used when no others match.  This is here as many providers add new enum values across release, and otherwise jclouds completely fails in this case. http://www.jclouds.org/documentation/devguides/contributing-to-jclouds
I don't think this is going to work out.  templateBuilder should only be able to build based on what is pooled.  Ex. the valid images are only those already on the nodes in the pool, so there is essentially only one template to choose from.
hum, not sure why... we can build an image from a node in the pool, but we can't create pool nodes from it (it won't appear in listImages()). is that so bad?
@arrbee Would you like me to draft something along these lines? ^^
Hmm, I feel like this could be a full error case, not just an assert... Maybe:

```c
giterr_set(GITERR_INVALID, "Cannot merge diffs with different case sensitivity");
return -1;
```

Frankly, this is one of a whole class of errors that merge does not currently handle well. Several of the options including `GIT_DIFF_INCLUDE_IGNORED`, `GIT_DIFF_INCLUDE_UNTRACKED`, etc. will cause unpredictable results if specified on one side the merge but not on the other.

Would you consider extending this to a slightly more generic `DIFF_UNMERGABLE_FLAGS` (either #defined right above the function or in `src/diff.h`) and then just returning an error if `(onto->opts.flags & DIFF_UNMERGABLE_FLAGS) != (from->opts.flags & DIFF_UNMERGABLE_FLAGS)`?
minor

s/bracket/brace
Searches are mostly triggered via ``GET`` requests most of the time, not ``POST``. It also isn't used to distinguish between search requests, it only has a role regarding (session) persistence of search queries.

"``SearchForm`` uses a special query variable named ``s`` to determine whether the current search should be persisted in the session so that it is still active upon the next visit and the same search query does not have to be entered over and over."
nooooooo what happened here - lets do this in build_config instead....
All right, considering it's the same code here and there, and we'll have to change that anyway at CSPifying time, keep it.

Just keep in mind that I'll r- new code with needless inline JS :)
This and the hacking_howto should match but I don't like the way you've got it here for the reasons I mentioned in the hacking_howto comment.
Is this something we have test coverage for yet? Is it something we plan to address prior to merging this?
Yes it is perfectly valid to have characters as normal ones, no HTML encoding is needed. or else the Greek would need to be all HTML coded.
I think we might also want this for other symbols, like `:`, so maybe remove the `if` or something?
Sorry for my ignorance, but why is this problematic?
why whould it return false here when the other case provides a fluent interface ? It does not make sense
``_services`` is node for anonymous services
By older IEs you mean IE 7 and older. Is there any guide line about supported browsers for Symfony2? I'm not sure what are the requirements at the moment. Also keep in mind that Google announced that they'll drop support for IE 8 in November afaik so if everyone moves forward where should we have a point back as reference?
Getting `Warning: spl_object_hash() expects parameter 1 to be object, array given` here.
so what do we do ?
I would have expected a test that asserts the the service was not set after catching the exception.
According to Django documentation, yes they should.
Name confuses me a bit... `vote.no_votes` Does it still make sense if renamed to `vote.not_within_delay_window?`
该块代码是否可以和上面的判断合成为一个？
If the path caching is independent of `format_dict` then it suggests `format_dict` should really be part of the constructor prototype. As it stands, being able to do...
```python
>>> downloader.path({'foo': 'bar'})
'/stuff/bar'
>>> downloader.path({'foo': 'wibble'})
'/stuff/bar'
```
... is pretty weird.
никогда, слышишь, никогда так больше не делай :) Я сейчас приму этот пулл реквести и пофикшу. А ты подумай, что будет если написать
a = b = []
b.append(1)
print (a)
$(shell ..) lijkt een gmake-ding te zijn. Dit werkt ook met (FreeBSD's default) pmake.
Trailing `"""'`
I found that way to make `before` depended on `:copy_vendors`.  Is it ok?
And as noted, it does have the dependencies listed, just there in the parameters to Ember.computed.
When starting it might be okay but refrain from using HTML inside your code. Use a templating engine like Handlebars or similar if possible.
Well I was thinking that the Record class is abstract and is not called AbstractRecord, so why would then the WellKnownRecord be AbstractWellKnown? But it is not important, with or without AbstractXXX in class name is okey.
This function saves a datum, we can try to replace it by calling a save function in the Datum.js file itself when we reroute all saving to one location per object type. 

It triggers the next save by publishing to the "savedDatumToPouch" channel that it succeded or failed. below the ImportEditView file subscribes to this channel and runs the next save event.
On 11/16/2012 11:43 AM, Jaikiran wrote:
> In web/src/main/resources/org/jboss/as/web/LocalDescriptions.properties:
>
>> @@ -164,6 +164,27 @@ web.deployment.servlet.min-time=Minimum processing time of a request
>>  web.deployment.servlet.processingTime=Total execution time of the servlet's service method
>>  web.deployment.servlet.requestCount=Number of requests processed by this servlet
>>
>> +web.valve=A global valve.
>> +web.valve.name=A unique name for the Valve.
>> +web.valve.module=Module where to find the valve.
>> +web.valve.class-name=Name of the class containing the Valve
>> +web.valve.enabled=Defines whether the Valve should be started on startup.
>> +web.valve.param=Parameter for the Valve like param-name="name" param-value="value"
>> +web.valve.param.add-param=Add parameter to the Valve.
>> +web.valve.param.add-param.param-name=Name of the parameter.
>> +web.valve.param.add-param.param-value=Value of the parameter.
>> +web.valve.param.remove-param=Remove parameter from the Valve.
>> +web.valve.param.remove-param.param-name=Name of the parameter.
>> +web.valve.setting=Settings for the valve.
>
> I don't see this in the model definition. Is this relevant?

Not sure what is wrong there:
[standalone@localhost:9999 valve=myvalve] :read-resource-description
{
     "outcome" => "success",
     "result" => {
   ....
         "children" => {"setting" => {
             "description" => "Settings for the valve.",
             "model-description" => undefined
         }}
     }
}
i18n log message please.
no without your help!!!!!!!!
Nope, it's indeed showed only on window.open
Empty rule, if not used please remove!
Can you use file.type instead of the filename extension?  if (file.type === 'audio/mpeg') or 'audio/ogg'.  I don't know if that works, but I think it should
Do you know if there a bug on bugzilla for it? Does it happen only when you use the offline cache or does it always happen?
Don't we need this `left` ?
No, that's not gonna happen, we'll only update ThreadListUI.  I'll make new commits in here fixing the issues along the morning
hint: you don't need the lazily getter since this is loaded with `<script defer>`
nit: console.log -> debug ?
Same here. Use element hidden property to control element show/hide.
Oh wait, forget that, `Cases` does not support level specifiers yet. :) You'd have to rewrite that somehow...
why 25?
fixed by using var.
"alphanumeric" is one word :hamster:
Nice changes :wink2:
I think you actually want to do something like:
```scala
using[Unit,Random](new Random)
  .map(() -> '__shard__) { (r:Random, _:Unit) => r.nextInt(n) }
```
Otherwise, ```new Random``` will get initialized with the time in millis (I think), and two calls might often get the same time.
the proper PATH scenario is handled in https://github.com/mamash/rvm/blob/de8300387ad0f95c8f5f56ad4dce0ae22a6e2c49/scripts/functions/checksum#L6 and https://github.com/mamash/rvm/blob/de8300387ad0f95c8f5f56ad4dce0ae22a6e2c49/scripts/functions/checksum#L11 - so I'm not sure this is necessary ... if in some cases the PATH does not include it and it's some standard location - I would prefer to have it on the end - as it's custom PATH and might contain dangerous/not trusted code from users.
That can be done by using ATOL, but the strict equality should be okay here, cause the needle is copied from the haystack during "fanning_in".
This code will be removed as we move to the new DB version.
-conflicto
Recount isn't complete. It doesn't recount thankyou from every user. Also action like this should be done for all users in a single query (it's a lot of faster).
-filter
to ease Windows support.
I think potential errors could be handled in there. So far no places in `SvnDriver` handled the status code from `$this->io->execute()`. Down the road, it seems either to drop the reference too in order to be able to test the code.

I think this should be addressed in a seperate PR though.
Maybe we should move this code to a central location like mini.c and declarations in mini.h since this code is now duplicated in 3 places.
Ok, done that
Ignore my previous remark, you're constructing the message with both the check AND the checkEvent.
Put this function close in the file to the function for executing one of these remote functions.  They should all be together so the whole implementation can be easily parsed.
You will be sorry if you remove the namespacing from the Ajax endpoints.
I think it is a bit unusual to have 4 version numbers -- why not `2.0.1`?
Did this feature get removed from the platform? Not sure we should document it in that case
I meant could you please add comment above the line saying Will remove this dependency as part of Bug 792644
is `forceIssuer` required? It doesn't look like it in `wsapi/cert_key`.

If it's not passed, then the `undefined` value would trigger an error. Is this correct behavior?
For all of the above use the querySelector method: https://developer.mozilla.org/en/DOM/Document.querySelector

It will look like document.querySelector("#gc .label")
Can you just fix the indentation in this file? It's 4 spaces in Propel2, thank you.
Fixed in https://github.com/puppetlabs/puppet/pull/626
Add comment describing why 'wait-for-state' needs to be included. Best to include a URL.
This is exactly why `LIB_EXT` is public api in the first place ;)
I started with a post, for similar basic reasons.  Then I noted that there are other, similar roots (including one for rebooting an EC2 instance) that are all put requests.  I think consistency is better in this case, and I don't want to change them all.
You could also nest an `include_examples` (although you'd have to make it support a block, or just use `shared_examples`):

```ruby
shared_examples_for "unloaded constant stubbing" do |const_name|
  include_examples 'const helpers', const_name

  it 'allows it to be stubbed' do
    const.should_not eq(7)
  end
end
```

This might be considered "abuse" though....
`formtastic-bootstrap` version 2.0.0 was released on September 5 and it seems to be working with rails 3.2 as well as depending on formtastic 2.2.
small request: can we call it computers or devices or something?  comps isn't very descriptive.
I think that would be good. At least for when I debug stuff.
OK. I'm back :P

One last question TJ. I 've just noted that the code of  `function HTML(runner)` is both in `lib/reporters/html.js` as in `mocha.js`; Do you want me to put these functions into  `lib/reporters/html.js` and then in `mocha.js` I just require the code from there? (to avoid code duplication).
CS, spacing around comparator
Dunno if you wanna correct everything, but you wrote identifier wrong everywhere (idenfitier) :p
For the reviewer: would we prefer this approach or eventually passing the main `ServiceManager` to `__construct`?
I was talking about the CS convenion.

```php
use Zend\Mvc\ModuleRouteListener;
//...
if(isset($params[ModuleRouteListener::ORIGINAL_CONTROLLER])) {
//...
```
@prabhuramachandran The migrations had to be removed due to problems with taggit library. There is no known solution as of now/
For this line and other similar ones below I think it's more readable to use the `get` method of a dictionary to provide a default value:

    size = os.environ.get("SIZE", "small")
Is this meant to be empty?
@Ocramius not if you run it usng the appropriate phpunit.xml file, as this file is the phpunit bootstrap
Please align `=` signs
AFAIK not really, Doctrine don't follow SF2 CS, and allow (look at code) mixing.
Are underscore-prefixed private/protected methods still a convention?
I think the more commonly used one is [bootstrap-sass](https://github.com/thomas-mcdonald/bootstrap-sass), or at least that's what I've used before.
I meant, no need for adding spaces around the ':', but we discussed this: we should use a space after the ':' consistently.
Maybe relax the dependency on graphviz and also just output the .dot file?
Because this bundle supports also version `2.0` which don't have this logic.
Please wrap all ngx related styles into "ngx-text-curtain" class. Use dashes in identifiers instead of camelcase. See existing .less files
`return http.HttpResponse('Event not approved')`
wat

Luckily, they said "preferably", so I can continue to ignore it. :D
The != false is to cover the case where the :dependent_destroy is nill (most likely because it has not been set, as this is the default case) We wanted to maintain the same functionality in the default case.
Should we name this Exception?
`(this.pin, [0x40` => `( this.pin, [ 0x40`
It's pretty much arbitrary. Zotero.read() doesn't provide a mechanism to read the entire file at once, so the file needs to be read in blocks and the blocks have to be concatenated. Larger block sizes should be faster, but in practice I doubt it matters much since files are generally small.
I'm trying to figure out how to satisfy the 2.5.0-rc2 for maven build in guisuite, but its complaining yet. But the docs say it can be done. :)
We use px in one place and percents elsewhere.  This is fairly common to make it so you can increase all sizes at once by changing the px.
у меня есть большая уверенность, что алгоритм неверен. здорово, если это найдется тестами
Try it now. 
I think the reason this happen is your choice to indent the package{} block. That's not how I'm setup, it's pretty common to skip package from indentation. I'll see if I can make the ide do it that way.
remove focus :)

Also, a short comment to explain that the ruby endpoint doesn't delete on demand and only deletes cookbook content via --purge would help explain.
`widget_dict[w_name] = w_config` rather.
Style: opening brace on new line
/s/got/go
Can you do this for the description as well (empty string) ?
nice this has been on my todo list for a while now
Because of the cross-dependencies I'm going to hold off on that until previews and comments are in.
I suspect we might end up with a file that exports some private logic though.
Looks like this query can go. Its results don't seem to be used anymore.
I did it like that to avoid that the ``ScalaJdiEventDispatcherActor`` could get stuck forever, which could happen if  ``eventSet.resume()`` throws an exception (I don't know how likely is that to happen, but I'd rather be defensive here ;-)). That said, I can wrap it in a ``try/finally``. Will do that.
Might be a good candidate for a seperate WorldGuard class, instead of merging with WorldEdit.
You're not my real dad
I dont think that the comments obfuscate what is going on, and if we can start to use a doc generator that is not a bad result.

It's not great, but API generators are a great tool to have along-side our awesome hand-crafted documentation.
окей

пусть index случайное число в даипазоне от 0 до 99
при этом DNA[item] = @"A" но нам нельзя заменять на @"A"

(index + 1 + arc4random()%(kMaxDNAItems - 1))%kMaxDNAItems
(index + 1 + arc4random()%(100 - 1))%100
(index + 1 + 0..99)%100
(100..)%100
(0..99)

Т.е. на выходе случайное число от 0 до 99
где гарантия того что DNA[new_index] != @"A"
Да, тут <=
Кстати, я тут подсмотрел у @moleksyuk хорошо бы написать юнит-тесты на мой взгляд это полезней оттачивания алгоритма
согласен,  но я новичок в obj-c и по сути не было сейчас времени искать подобное
Зачем так поступать с циклом for?)
Правильное решение, но непродуктивное: если понадобится мутировать клетку на 100%, то последние элементы массива indexes будут получены после многократного прогона цикла do-while.
I added `get_javascript_engine()` to BaseLinter, please see the latest repo version of `get_executable()` in javascript.py to see the way to deal with this now.
In french, you need a space before « : »
``<-- BRACKETS_SRC``
good catch, I'll yank it out right now.
This template made my mind esplode.
I'm a bit confused by this comment. Is this about `+iterativeScheduler`?
What if there is no language variety name?
What is going on with whitespace changes?
SourceSpaces.__init__ took care of that. Anyways, I changed the read function so it makes info at least {'fname': fname}, might be useful for later reference sometimes
I know, but then any line added in the scope is executed on the user's thread. It is not only about solving the problem but also about making it clear that they are solved. We can integrate this, but we should certainly limit the scope.
Hallo Stefan,

anscheinend hast du lokal diese Datei bereits manuell geändert, so dass der commit nicht ohne Weiteres rückgängig gemacht werden kann. Du solltest die Änderungen an dieser Datei daher zuerst entfernen (wenn du z.B. Tower als Git-Client verwendest ist das ein Rechtsklick auf die Datei und "Discard Changes") und es dann nochmals probieren.

Gruß
jw


Am 20.12.2012 um 10:00 schrieb Stefan Klein <notifications@github.com>:

> In Frameworks/Ajax/ERJQueryMobile/Sources/er/jquerymobile/components/ERQMHeaderBar.java:
> 
> > @@ -1,10 +1,10 @@
> >  package er.jquerymobile.components;
> >  
> > -import org.apache.log4j.Logger;
> > +import org.apache.log4j.*;
> 
> Hallo Johann, ich melde mich mal auf Deutsch (geht halt doch schneller ;-) ). Ich habe noch nicht so viel mit git gearbeitet und jetzt hat er mir das .gitignore in den commit eingebaut. Wenn ich den commit zurücknehmen will, erhalte ich die Meldung: error: The following untracked working tree files would be overwritten by merge:     .gitignore Please move or remove them before you can merge. Wie kann ich das lösen? Viele Grüße Stefan Mit freundlichen Grüßen Stefan Klein
> ________________________________________  Büro für Softwaredesign und Entwicklung  Dipl. Geogr. Stefan Klein  Im Grund 10  68723 Plankstadt  Tel. : +49 6202 18568  Fax  : +49 6202 26109  EMail: stefan.klein@buero-sde.de  WWW  : http://www.buero-sde.de Am 20.12.12 00:38, schrieb Johann Werner: In Frameworks/Ajax/ERJQueryMobile/Sources/er/jquerymobile/components/ERQMHeaderBar.java: @@ -1,10 +1,10 @@
> package er.jquerymobile.components; -import org.apache.log4j.Logger; +import org.apache.log4j.*;
> Please don't use asterisk imports. — Reply to this email directly or view it on GitHub.
> —
> Reply to this email directly or view it on GitHub.
> 
>
functions prefixed with +borra- are plugins used in:
  zstyle ':prezto:prompt:borra' plugins 'userhost' *'pts'* 'rvm-info' 'vcs-info'
(take a look at line 55)
There's also a `map.rst.inc` file in the `cookbook/` directory that needs a similar change
上下文
配置层级
Move this to the top like `var util = require('util');`
`platform.faq.search.submit`
The following code does the same thing and doesn't need to expose $_d. Please help evaluate it:

~~~
public function mergeWith($data,$recursive=true)
{
	if(!$this->caseSensitive && (is_array($data) || $data is Traversable))
	{
		$d=array();
		foreach($data as $name=>$value)
			$d[strtolower($name)]=$value;
		return parent::mergeWith($d,$recursive);
	}
	parent::mergeWith($data,$recursive);
}
~~~
ясно.
Но я же исправил это.
Porque la clase Attachment (tal vez está mal ese nombre) tiene un campo
PlainContent que es el texto extraído por los extractores configurados en
el sistema. Entonces si el hash del Attachment no es igual al de la
configuración actual de los extractores, el PlainContent es obsoleto.

On Monday, March 12, 2012, Alpha <
reply@reply.github.com>
wrote:
>> @@ -0,0 +1,15 @@
>> +﻿using System;
>> +using System.Collections.Generic;
>> +using System.Linq;
>> +using System.Text;
>> +
>> +namespace CommonJobs.Domain
>> +{
>> +    public class Attachment
>> +    {
>> +        public string Id { get; set; }
>> +        public string ContentType { get; set; }
>> +        public string ContentExtractorConfigurationHash { get; set; }
>
> Y por qué pertenece a una instancia de Attachment? Qué relación tiene con
este attachment en particular?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/30/files#r545697
>
Probably want to set `out.toString` to props. May want to change the name of `props` to `data` and have this be the "getter" for data.
`(mapcat :repos custom-products)`
I would suggest using a context manager here, i.e.

```
with open(run_info_yaml) as fp:
    run_info_structure = yaml.load(fp)
```
What does this comment have to do with converting the messenger fields?
You should avoid using `use` keyword
Interesting topic, i didn't thought about it... i've implemented it that way, but it would be better to have an ordereddict, update the values when accessing and when inserting dropping the lest recent used ones. The bad news is, ordereddict are not from standard library until 2.6/3.2 if you don't add it as an external dependency... :-(
The submodule name was renamed to "samples".

Please update it, thanks.
Ok @tipiirai this hack seems to be necessary to get dynamically inserted video working on android.
I'm not sure how else we can tell from a black box perspective. One idea is we could get the agent to confirm the size for us, but doing that would require adding some agent methods.
Mircea, I understand what you want to do but I do not think this is possible as this interrupted field  will get seralized along with LatchMapper. We can not make it static as LatchMapper.interrupted is then shared amongst all executed LatchMappers
It's not just the comment, but I think maybe we need to remove the SKIP_LOCKING flag as well?
Definitely didn't just copypasta that :trollface:
In this method, both args and kwargs are ignored. Do they need to be there?
I think you accidentally added these hist2d tests to this PR.  Would be more appropriate over in the hist2d PR... with images.
If you would prefer, I am happy to revert the changes to this file. I was tracking down a sphinx warning, but I'm not sure this fixed it anyway...
Is the code here the equivalent of call_definitions.py for entities that have been permanently removed, specifically?
А давайте это условие переформатируем в несколько строчек и напишем комменты к каждому куску.
Сейчас уже невозможно понять, что же оно проверяет и как именно )
Looking at the 1.1.0 schema, I see they removed this option, so ignore my previous comment:

http://schemas.opengis.net/filter/1.1.0/filter.xsd
Here, do

```clojure
(if-not (string? output)
   [output])
```

Instead of that `nil` first.
Since we don't use the event `e` we can remove it here.
please put all implementations like that code here into the .cpp file
I think all you have to do here is use the Linear Kernel with ByteFeatures, so name should be Linear
The description (smaller grey text) has disappeared from the current RC. If that's intentional, we should also remove the styling.
Line indented incorrectly; expected at least 12 spaces, found 10
This is nothing to do with configuration strings in general, as far as I can see.

We're just talking about checkpoint names.  I'd still prefer an "@" prefix there, otherwise we might as well avoid most of the API change and just tell applications to use "WiredTigerInternal" (or rename that to "WiredTigerLast").
Add a return statement here and you don't need the else-branch any more
I always thought `exists` and `alive` are something odd about Flixel. Analyzing `FlxGroup::kill()`, it checks if the object exists, so I think we should do the same. In that case, all you have to do is add the missing `!` to your code.

If we dig too deep, we will end up with all those questions you raised. I think it's enough to test if the object exists before calling `revive()`. It's something like *"if you exist, go back to life; if you are already alive, deal with it yourself"* :smile:
hmm, github strips tags outside code-blocks when rendering the markdown. It is a documented behavior.
missing spaces around the condition ``if (...) {`` and after the comma in the method call
Same comment as above, let's keep this `data[e.index]` construct BB specific and not keep commented out code around
hmm. needs some help here.
just installs the '.so'; people will have to LD_PRELOAD themselves
OK, well I guess we can keep that code until we have a pretty printer then…
¯\_(ツ)_/¯ 

Yeah, talk to Marc. I had the code written for node, but took it out after we talked to him.
Of course...dumb mistake.  Thanks again.  :)
btw, this would remove the need for this ``$dynamicKey`` variable
I think the same, `RAILS_ENV` does not need here.

And in case if it still would be set, it should be
```
"RAILS_ENV=#{ParallelTests::Tasks.rails_env} #{command}"
```
instead of
```
"#{command} RAILS_ENV=#{ParallelTests::Tasks.rails_env}"
```

Because setting environment variables after command call could lead to compatibility issues (environment variables could be interpreted sometime as command arguments.
@stof you have 2 minutes to find a better color ;)
using user specify element for values
You're right. I wrote this after seeing that doing Evaluation.find(1) where no Evaluation with id 1 exists throws an exception. I'll change this.
Not good. Otherwise it should return an empty list. So you return filtered query set if user information is available, otherwise you return an empty list.
`self.kwargs.get('confirmation_token')` and then you do not need that `has_key` check?
`}` into new line.
It is also probably not necessary to use lists. You could create iterator.
No, it can be in one line.

```
google.maps.event.addListener(marker, 'click', function (event) {
    infowindow.open(map, marker);
});
```

Just make sure what all Google event handler receives as arguments.
*ta e-mail naslov za* -> *ta e-mail naslov kot svojega za*
Does it make sense that a single point would be added with an array of times?
why do you `memcpy()` instead of just casting the `ss` struct like this:

```cpp
   struct sockaddr_un* p_saddr = (struct sockaddr_un*) &ss;
   addr_.append (p_saddr->sun_path);
```

any good reason I cannot see? That would avoid an unnecessary memory copy operation.
Extra line, but looks fine. Also, welcome back :)
There is no event.h
I am going to pull this with a small change:

``` python
allowed_attrs = [attr for attr in allowed_attrs.split(",") if attr]
```
I'd like to set up a dev version of Postgres app...never done that before.



On 10/26/2012 08:49 AM, emperorcezar wrote:
>
> In chipy_org/settings.py:
>
> > @@ -30,7 +30,7 @@
> >
> >  MANAGERS = ADMINS
> >
> > -DATABASES = {'default': dj_database_url.config(default='postgres://localhost:5432/chipy_org')}
> > +DATABASES = {'default': dj_database_url.config(default='postgres://postgres:postgres@localhost:5432/chipy_org')}
>
> Here you're setting the default username and password to postgres. 
> This will break other installs. Development versions of postgres, like 
> postgres.app default to no username password.
>
> You'll want to set this in your .env if those are you postgres 
> credentials.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/chicagopython/chipy.org/pull/6/files#r1952964>.
>
Cast to bool. $this->isMethod = (bool) $method;
Here I would suggest passing ``mergedNested.getEntity()`` instead of ``null``.
Fair point. I thought about doing that initially but I was trying to do minimal constructor changes on you. I'll add this though.
when would you want this to be false?
This can be:

    @aggregated[k] ||= ::Aggregate.new

That forces the top-level namespace.
It's a little funky, since you need to wrap calls in functions, but you can make this async (read: more responsive) by changing `loadFile()` to something along the lines of:

```javascript
function loadFile(filename, callback) {
  $.ajax({
    url: filename,
    success: function(result) {
      callback(result.split("\n"));
    },
    failure: function() { // not sure this is the right event name
      callback([]);
    }
  });
}
```

And changing this to:

```javascript
var callback = function(lines) {
  viewHeater.addRelevantLines(lines);

  // load additional data at zoom 15 and above
  if (map.getZoom() >= 15) {
    var callback2 = function(lines) {
      viewHeater.addRelevantLines(lines);
    };

    if (moreLines) {
      callback2(moreLines);
    } else {
      loadFile('elevations3.txt', callback2);
    }
  }

  viewHeater.showNewHeatmap();
};

if (lines) {
  // do this synchronously, since it's already available
  callback(lines);
} else {
  loadFile('elevations.txt', callback);
}
```

*This* is callback hell, since you have to work backwards to define what should happen.  You could simplify it by moving the caching logic into `loadFile()`:

```javascript
function loadFile(filename, cache, callback) {
  if (cache) {
    callback(cache);
    return;
  }

  $.ajax({
    url: filename,
    success: function(result) {
      callback(result.split("\n"));
    },
    failure: function() { // not sure this is the right event name
      callback([]);
    }
  });
}
```

...and simplifying `showStaticElevations()` so that it *looks* asynchronous for all cases, even if it isn't:

```javascript
function showStaticElevations() {
  var viewHeater = new heater(map);

  loadFile('elevations.txt', lines, function(data) {
    viewHeater.addRelevantLines(data);

    if (map.getZoom() >= 15) {
      loadFile('elevations3.txt', moreLines, function(data) {
        viewHeater.addRelevantLines(data);

        // must be done within the callback function otherwise it may fire before data is ready (if it couldn't use the cache)
        viewHeater.showNewHeatmap();
      });
    } else {
      viewHeater.showNewHeatmap();
    }
  });
}
```
the test fails here:
E       assert u'LOGOUT' == '123donetest_1341833227.8875761@restmail.net'
E         - LOGOUT
E         + 123donetest_1341833227.8875761@restmail.net
I suspect that the locator used in the logged_in_user_email() points to "LOGOUT" instead of the user email.
Otherwise you would do `this._logger.get_request_context(NetworkLogger.CONTEXT_TYPE_CRAFTER)`.
AFAICS the code would be more readable if you would do the request_response.is_response check here and call the according template directly.
Would it perhaps be better to write this as a namespace, i.e. ``++fragments++`` to reuse a known pattern?
this was the only line that change why the others?
Hmm... well, I suppose it couldn't hurt.  Thanks for the SO question, that helped explain things.  Let's do it.
previously the build helper exposed a theme_dir method to avoid having to hard-code 'themes' in this -- should we do the same to avoid having to hard-code 'javascript'?
Now that this is a public class and we have less control over the types we will be called with, this cast is unsafe.  We should protect it with an instanceof check.  If that check fails, log (at warn) the bad call  and return Optional.absent().
C'est utile en répartition de charge avec des logs centralisés, donc dans beaucoup de cas
The most common usage here will be ImageS(nx, ny).  Probably worth just putting that here and mentioning that other ways to construct an Image can be found in the dox.
sentence without an end?
>> 
>> 
>> +
>> +#ifdef USE_IMAGES
> 
> I would think so.  That's been bugging me when I've noticed it in a few of the files - I cannot imagine a scenario without them.
> 

The USE_IMAGES is vestigial from when I wanted the code to work before Image business was straightened out.  They could be snipped out of course.
Will add comments and rename VoucherCodeFormat to VoucherCodeImageDisplayFormat
I bumped the version because it wouldn't install - I realized I could pip uninstall then python setup.py install it, so I'll make sure to fix that.
Are we allowing anonymous donations?
LOG.error here. The stdout and stderr won't end up in the log file, so it's a good idea to also do a LOG.error in main() before doing the System.exit.
Ok, seems we have to take a run and find all `int /*long*/` and replace them with their correct types. I can do that after I merge this pull request.
Chrome accepts a 4 dot version, npm accepts a 3 dot plus -tag.
This section is a bit confusing but all I've done is reordered the tests, because getting the instance variables to break depends on the order that you visit the calendar pages.
I'm not everyone, then; I only found out about it a month ago and still have to remind myself every so often. I'll keep it in, if for nothing else than to keep my dumb brain happy. :P
Ideally these credits would be somewhere else, a little bit less in your face... @andreasbovens any suggestions? Source code somewhere maybe?
Deixar a url para o static dinâmico

{% get_static_prefix %}
o teste para esses campos não é mais necessário pois os inlines foram removidos.
"PHPUnit/Extentions/Database/Autoload.php"
should be
"PHPUnit/Extensions/Database/Autoload.php"

This one too. This is great to see composer support being added!
Can we add some comments for good measure?
I suppose you've seen that the runtests.py uses the spec plugin for nose.  Using this means that you can write your tests in a way such that the test output reads like a spec.  To do this, you should name your test classes ``'Test%s' % object_name`` and then name your methods ``'test_%s' % behaviour_description`` so that the spec reads correctly.

See http://darcs.idyll.org/~t/projects/pinocchio/doc/#spec-generate-test-description-from-test-class-method-names
same as above:

      var cancel = buttonts[1];
      cancel.onclick = function onClickCancel(evt) {
        ...
       }
Satchel_ore_box.dm is unchecked, whereas satchel_ore_boxdm.dm is. It seems I wasn't paying attention when I tried to remove all the var/amt_archaeo stuff. That handles putting them in boxes, which we don't wanna do anyway because it's silly to have them run through the machines unharmed. I'd much rather work on a better method of transporting them, instead.
I specifically rewrote this to prevent the put out cig from dropping to the floor.  :/
See: Put out proc.
In order for ModeShape to find this class, it *must* be called `org.modeshape.common.logging.CustomLoggerFactory` (see the static initializer and JavaDoc for [LogFactory](https://github.com/ModeShape/modeshape/blob/master/modeshape-common/src/main/java/org/modeshape/common/logging/LogFactory.java#L63)).

Therefore, this class needs to be named `CustomLoggerFactory` and be in the `org.modeshape.common.logging` package.
"There's only one language, in which you should"

Should probably remove that `,` as its not required and reads funny.
We aren't talking about namespaces, we're talking about exceptions. Let's not confuse things here.

Just because PSR standards are a good way to build classes, does not mean EVERY file EVER is going to be COMPLETELY PSR, namespaced, etc. If we're talking about Exceptons let's just talk about Exceptions.
Такое клонирование будет работать только с примитивами.

```javascript
var a = {};
var b = [a];
var c = b.slice(0);

c[0] === a; // true
```
is this a real requirement of serve?
Мне интересна твоя мотивация.
Опять print вместо println
Весь массив args является одним выражением.
Странное ограничение.
Т.е. можно просто передать дефис, и он будет проигнорирован?
I thought that http://www.python.org/dev/peps/pep-0257/ indicated that multi-line docstrings should have an empty line before the closing triple quote. You are saying that you would prefer no blank lines before the closing triple quote?
#container > #page[data-context] locator contains information about the content of the current page.
The bodyclass property can be used to identify the current page.

we use this because driver.title returns false on the android driver and marketplace
A list of IDs
typo: assumption
> @GaelVaroquaux I should be careful if I become even more picky than you ;)

No, I am so happy: I can rely on you!
there is a method called utils.check_random_state to do this
Get it. Then I could alter all the parameters to be passed into the function by arguments rather than class attributes. But should I validate the input again, i.e. random_state should be checked both in ```fit``` as well as in the standalone ```spectral_embedding```?
I've dropped the entire paragraph. Users can figure some stuff out for themselves, and questions on the ML or SO will point out which parts they don't understand :)

(I often update the docs when SO questions point out flaws.)
You should be using a 'c +=' here.
Yeah I can totally believe that. I just had the impression you reimplemented apply_tree instead of calling it - well it's just a couple of lines so it probably doesn't matter much.
``new_users`` might be a clearer name since all of the users are unique.
Done in my pullrequest.


Le 6 mars 2012  13:02, Jacques-Olivier Lachaud a crit :

> I had to modify NumberTraits.h and NumberTraits.cpp

----------------
David Coeurjolly - Directeur de recherche CNRS
CNRS, LIRIS-UMR 5205
Universit de Lyon
Batiment Nautibus
43 boulevard du 11 novembre 1918, 69622 Villeurbanne cedex, France
Tel : (+33) [0]4.72.44.82.40  Fax : (+33) [0]4.72.43.15.36
http://liris.cnrs.fr/david.coeurjolly
functional test?
Ah yes, I've misread and thought `targ` was a temporary. :)
fixed/ammended/rebased
again bounding
`Beware !` > `Beware!`
The copyright header is missing here
I'm not sure if that necessarily makes sense.

I don't know how the monitor queue works or what it is, but IF it's used for filemonitor jobs (to fire events when contents of a directory changes) I don;t think I would expect such events to stop occurring just because the DFU spray/desray job queue is suspended.
Given quoteToStrip is passed as argument, I decided to pass unescape as well, but seeing how I have to cancel it after every call, made me reconsider using a member variable for this purpose, though the "contract" would be hidden away.

Still unsure what's the best design here...
The ", " is added before "s", so it is correct removing the first two. This is done in many other places, and TBH, I prefer it this way than adding a conditional to every iteration of the loop.
Until such time as we cannot live without it, you should make the inclusion of this (and the other URI references in this file) conditional on USE_URIPARSER, so that Windows users can still build without having to stop and build/install uriparser
Could also possibly common up oldnext.
What I meant was, why is it not
..SharedObject so;
public:
..
..LoadedOejct(const char *name)
..{
....so.load(name,true);
..}


It should probably be in jlib as well, thought there was something like this already actually, but can't see it.
@jakesmith I think this would have always evaluated as true, so the function would have always returned 0.  What effect would that have had?
The thing is that I had the 00000+ problem after enabling the sharing feature in the plugin, while I had never ever faced it before without the sharing option.

That is why I thought about creating a test for the specific scenario where I found the problem, which led me to SharingSCMTest instead of the MercurialSCMTest.

If you prefer it, I can move it to the MercurialSCMTest one.
This method needs a clean-up, as it's doing many more things than was originally intended. It now contains more more code about deciding whether to process the enclosure than it does about actually processing it. That decision, or the influencing factors, should be refactored into separate methods.

Python has [built-in time deltas](http://docs.python.org/library/datetime.html) and Django has [time formatting functions](https://docs.djangoproject.com/en/dev/ref/templates/builtins/#std:templatefilter-timesince), both of which would clean this code up considerably.
you might expand this a bit, something like ".. which means, if you use these modules from your code, you may need to rewrite your code for future versions of the SDK", but with better words :)
Why is this removed? Was it intentional? If so, can you elaborate, so we have a record in the PR as to why it's now gone?
Use `@expectedException SolverProblemsException` instead of this try/catch wreck :)
Please use the node's component as the parameter instead of the node directly.
self.assertEqual(expected, sessions) should work. If it doesn't, you can try self.assertEqual(expected.all(), sessions.all())
Tästä voi tulla varsin sotkuinen funktio, mutta mitenpä tätä pilkkoisi?
I don't think so - the only place we every throw a ServiceTimeoutException is from here, and we go through this codepath only once during a request, in the Exception Processors.
Oops, sorry - thought I deleted this in yesterday's commit. Thanks.
@raydavis agreed.
const QString & is going to be a lot faster
Do you mean you prefer the current naming, or do you simply not care?
This, and `#less_than`, `#greater_than_or_equal_to`, …, would be easier to read as:

    def greater_than(number)
      if number
        @greater_than = number
      end
      @greater_than_message ||= :greater_than
      self
    end

However, I question the usefulness of `if number`. None of the examples in the docs show it, and I can't think of a use case.
Or are you saying that passenger doesn't load capistrano, but that it does load rvm-capistrano?
Leave it for now.
Looks like there is a test for the other one that calls this one.  That is OK with me if it is OK with you.
OK with me I suppose, but `0.0` is the default height.  Perhaps it wasn't when you made this change?
My build environment doesn't have either have these variables
But do we support get/setDraggable and get/setAnimate?

As currently written, the doc says we do.
`force` is since ant 1.8.2, and for example when I test under Ubuntu 10.04, the apt-get options for ant (out of the box -- not sure about updates) don't include 1.8.2, so it failed when I tested.   I think `overwrite` is probably enough.

I tried without `force` twice in a row (so that the second time would have existing files there already), and it was okay.
#if defined(DEBUG) || defined(DEVELOPER). Also as per styling guidelines this must not be indented
window.escape === escape even without this.
Why did you add the finder ?
Rather than leaving uncommented code I suggest you remove the code. We have version control to see old revision of the code - no reason to leave old code here. It is bound to confuse somebody else in the future.
Ouch. Will fix.
Hm, I always thought about popping the used elements off the RNG as part of its implicit contract – not sure whether this is actually documented anywhere, though.
Actually, it looks like the static assert is wrong now that the check with `takeNone` is there. I'll remove it.
Had no idea. I'll change it back then.
This condition is unneeded. If you pass NULL as the `save_path` for the `convert_to_pdf()` method, then a temporary file path [will be generated](https://github.com/Qballinternet/kohana-HTML2PDF/blob/67e74e23cc6f85f08edf7133adf7df9b13eee6c6/classes/Kohana/HTML2PDF/Document.php#L220)
I like the way I fixed this.
You could sort these if you want to pander to the OCD developer crowd. I'm fine with it either way :)
Normally I object to changes like this. Returning a sorted list means you incur the sort cost on everyone, even if they don't care about the sort. Now you also actually have to unit-test that it returns names in the properly sorted list.

Why even care about the order of the file names?
I think you need to say "The produced entity" or something to indicate you mean what comes out of this producer method.
The quickstart name doesn't match the quickstart folder name.  This name should probably be deltaspike-beanmanagerprovider to match the folder name.
bad javadoc.  Also, long comment is long.  Use Eclipse's format region, and then delete trailing whitespace.
Sounds reasonable. Also makes more sense than "new Version(1, 0, 0)" which is currently there
This comment seems a little bit cryptic to me :)
more candidates for commoning up...
Does npm no longer require the chdir?!?! This is great news!!!
Should this be input[ 0 ].checked?
I rewrote this test as `test/handle-test.coffee`. The tests in the `tests` directory aren't being run.
was working on it.  added now
Yes. It's 4 spaces per tabulation.
You can change it to `unless options[:description]` if you want. There's no reason here we can't rely on truthiness.
boring CS police .. curly on the next line .. oh and add ``public`` to the functions
El estado debería modelarse con un strategy
This should also be aligned. Also, if we want to be Puppet 2.6 compatible then the last parameter should not have a trailing `,`
@drnextgis any chance to have your page display in IE 6 and 7 so we can run tests in these browsers too? Thanks.
If we need to do this in multiple places, can we centralize this so we don't have to maintain it in multiple places?
same as above

```ruby
elsif verbose and not dump_header
```

avoid double negatives like `!_v.nil?` which is the same as `_v`
Child context will push the changes to the parent context when save. So we don't need to merge changes from child context again.
@alexrp to save yourself work just write "throughout" the second time around and don't mention it again.
Rendering secondary plugins require the solr class to build url parameters now.
Missing docs - if you add these tags, they need docs (otherwise we get warnings out of javadoc). Also line 142
@markfisher What should be the best way to refactor this? Should we create a common util class under org.springframework.integration.util where we store common XML Config Parsing utility methods?
I think we need to explain the preferred constructor is the one receiving an SPE.
I would change the order of $allowJsonp and the empty check
Should be ->defaultNull()
(And this is why I use null. But some people ever redefine undefined, so this is why you have to do such tricks as you are doing above.)
I've extended the description of  `getHeaders()` to better describe it, and also add a link to the `Zend\Http\Headers` documentation.

[Direct link to changed lines](https://github.com/zendframework/zf2-documentation/pull/346/files#L5L118)
どうしてここだけ withName による判定じゃないのでしょう?
When I want to find a Customer, I find by escaped_name
That previous comment also made me realize that using `class` instead of `singleton_class` will end up adding these attributes *for all classes* (because `self.class` is `Class`).  Instead you should do:

```ruby
self.singleton_class.class_eval { attr_reader cattr }
```
Likely this should be the other way around and the service info on server-binary-repo should be here. I can **completely** understand if that should be a different PR :smile:
Can you add the new key on each catalogue files ?
Instead, I'd avoid backing up globals in `tests/phpunit.xml`. After all, we don't suggest usage of globals. Does this make sense to you? :)
I think the inherited ```Gateway#amount``` method covers this functionality, no?
Move the brace to the next line.
test, verify event is fired, and configure is called
why isn't it working with master?
but if at all we should probably say ``2.2.*`` here ..
have a look at efde308 and see if it makes sense
As per previous discussion, I think that we probably want to have a separate spec_helper entry point for modules so that we can maintain an entry point for other things that aren't modules.
Yah, I was hoping to, but was unable to stub the search properly without it.  Threw in the towel for now.
**Error:** Space before closing parenthesis of function call prohibited
add `type=""`
Is this class really required for feature 1?