labofsahil/github-event-dataset-2012 huggingface dataset:
You don't need to pass innerRings by reference to modify the contents of the list inside the method.  The only reason you need to pass by reference is if the method is going to assign a new instance of type `List<List<Cartographic>>` to innerRings.  Keep in mind, in C#, all instances of classes (but not structs) are passed by reference automatically.  When you use the ref keyword, you're specifying that the _reference_ should be passed by reference.  It's kind of like a pointer to a point in C++.
I __know__ I'd added this to the example gen in the past; I have no idea how it didn't make it across in the trip to lite.
Glad you've saved it and added it again.
Just to know, are you planning to do anything for this, like tests? Or should we do things? Just not to duplicate the effort.
I don't want to use a property when there is a method doing this job. It's some kind of a habit.

So, I use "b._getItems() instead of "b.items".

Anyway, I can change it easily.
It's crashing if there is an unusual map size. (such as 22x124)


Exception in thread "Thread-3" java.lang.ArrayIndexOutOfBoundsException: 729
	at com.mojang.mojam.screen.Bitmap.blit(Bitmap.java:104)
	at com.mojang.mojam.screen.Screen.blit(Screen.java:30)
	at com.mojang.mojam.gui.LevelButton.render(LevelButton.java:120)
	at com.mojang.mojam.gui.GuiMenu.render(GuiMenu.java:52)
	at com.mojang.mojam.gui.LevelSelect.render(LevelSelect.java:134)
	at com.mojang.mojam.MojamComponent.render(MojamComponent.java:440)
	at com.mojang.mojam.MojamComponent.run(MojamComponent.java:392)
	at java.lang.Thread.run(Thread.java:722)
Any reason, besides our own internal specs, to expose this? If not, I'd prefer to hide it to reduce surface area. I'm also not sold on the `ExpectationTarget` name, and this sorta locks it in.
Should probably return a view model with a set template name (not relevant now, but it will help you in future)
why isn't this nested in the runs function above?
Delete the override
We have had so much problems with the plot directive (in particular that it is fairly sensitive to the matplotlib version). We now prefer to use examples, that are executed during the build process and generate images if the filename starts with 'plot_'. We then use the corresponding image and link to the generate example html file.
This is supposed to return if they have a cell number.  Sometimes it is useful for the mods to check that. I think we have used it as a factor in OZ determinations before.
great, put please note the comment I have made about whether or not the get_or_create method actually saves the newly created object.
Done. Incorporated all comments. Should be clean as a whistle. We could
extract this into the TCK, with a few changes.
Not sure about this comment. We should plan on working with only one repo (plus developers forks) otherwise it will be a nightmare.
Lets use all defaults for now, will customize later
Yes for Oracle too
:) Great great - really nice :)
And you really done only one change: 2.1.5320 ? 
I had problem with this :) thanks. Your sonar project looks great even each line is marked. GREAT :)
This is actually the *old* syslog instance, per getAndSet.  You then go on to return the old value.
On Fri, Mar 2, 2012 at 12:06 AM, Ken Barber <
reply@reply.github.com
> wrote:

> > @@ -14,6 +14,18 @@
> >  class Facter::Util::DotD
> >      require 'yaml'
> >
> > +    # Class helper methods
> > +    class << self
> > +      def puppet_confdir
> > +        begin
> > +          Module.const_get("Puppet")
>
> I guess my point is, puppetversion.rb (sorry I meant this one) already
> attempts to load puppet and 'do stuff' in a clean simple manner and if it
> fails it returns nil. I could be mistaken, but what you are doing does seem
> more complicated and perhaps not entirely necessary for the majority of
> people. Although I can see the value in a block doing a yield as your doing
> now, your saving maybe 2 lines of code when users go to use it, but adding
> something that seems harder to read to me.
>

What I'm doing is slightly more complicated but it's better.

As it stands, puppetversion.rb will _always_ bring Puppet into memory if
Puppet happens to be in the load path.  This behavior totally disregards if
the user specified --puppet or not.

What I'm doing is looking to see if Puppet is loaded in memory before
leaping into it.  If it's not loaded, I don't do anything.

I don't see the need to load the entire Puppet code base just to get a
version string.  I'm pretty sure puppetversion.rb should be fixed in
Puppet.  In fact, I'm pretty sure we've moved the version constant out into
it's own modules so we can require it nice and quickly without also
bringing in all of Puppet.

 I'm really focusing on the code where you use the function you have
created. So your code below:

   Facter::Util::PuppetSettings.with_puppet do
>      Puppet[:vardir]
>    end
>
> Compared to what I'm suggesting:
>
>    begin
>      require 'puppet'
>      Puppet[:vardir]
>    rescue LoadError
>      nil
>    end
>
> I would vote number #2 is much more readable as users don't have to have
> prior knowledge of your wrapper.
>

These two chunks of code aren't doing the same thing at all.  I'm happy to
rename the method 'with_puppet' to something like "do_if_puppet" or
whatever, but I'm quite confident my approach is superior, if not named
well.

-Jeff
Had a problem with it because it was being passed an object and jasmine wouldn't allow comparisons of objects for some reason, even if the string was exactly the same as it was expecting
shouldn't this be private?
Also dateRetired.
Without  a name for the field this is of little value to the caller.
init the map with zero.
On 12 July 2012 14:09, Alex Rønne Petersen
<reply@reply.github.com>
wrote:
>>        $(TD all)
>>        $(TD GDC)
>>       )
>>
>>       $(TR
>> +      $(TD $(LINK2 https://bitbucket.org/goshawk/gdc/downloads, GDC))
>
> Unrelated to the pull request itself: Why not host them on the GitHub downloads page?
>


Better ask Daniel for that. :-)


-- 
Iain Buclaw

*(p < e ? p++ : p) = (c & 0x0f) + '0';