Fix CS phpdoc FormConfigEditorInterface
merged branch ruian/fix_cs_docblock (PR #4466)

Commits
-------

26f5ac4 Fix CS phpdoc FormConfigEditorInterface

Discussion
----------

Fix CS phpdoc FormConfigEditorInterface

Just a CS fixer
Accept calling setLenient(false)
MethodNotImplementedException -> MethodArgumentValueNotImplementedException
merged branch frosas/patch-1 (PR #4469)

Commits
-------

d55f7ed MethodNotImplementedException -> MethodArgumentValueNotImplementedException
cea6489 Accept calling setLenient(false)

Discussion
----------

Avoid IntlDateFormatter::setLenient(false) to throw an exception

Right now it is breaking because the changes introduced here:

https://github.com/symfony/symfony/commit/f541844c781309b63d899f82525c93731c4c2fef

---------------------------------------------------------------------------

by travisbot at 2012-05-31T01:35:44Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1483621) (merged cea6489d into 49e213ce).
getClientIp() will now only return valid IP addresses, rather than assuming the X_FORWARDED_FOR is the first comma seperated value.
Since getClientIp() no longer takes a parameter, removed that old test

Added a new test for HTTP_X_FORWARDED_FOR that starts with 'unknown, '
[Bridge][Form] Rename some deprecated methods
merged branch nomack84/rename_form_methods (PR #4473)

Commits
-------

cbc9944 [Bridge][Form] Rename some deprecated methods

Discussion
----------

[Bridge][Form] Rename some deprecated methods

This pull request is for renaming some deprecated Form's methods from the Bridge namespace.

---------------------------------------------------------------------------

by travisbot at 2012-05-31T12:20:59Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1486874) (merged cbc99442 into 78747e6c).

---------------------------------------------------------------------------

by nomack84 at 2012-05-31T12:27:29Z

The fail is not my fault.
merged branch neilferreira/master (PR #4472)

Commits
-------

85db221 Since getClientIp() no longer takes a parameter, removed that old test
7b5328f getClientIp() will now only return valid IP addresses, rather than assuming the X_FORWARDED_FOR is the first comma seperated value.

Discussion
----------

getClientIp() will now only return valid IP addresses, rather than assuming the X_FORWARDED_FOR is the first comma seperated value.

Fixes #4471

I'm not sure why an empty string was being returned in the first place, rather than null.  Any ideas?

---------------------------------------------------------------------------

by travisbot at 2012-05-31T08:59:12Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1485615) (merged 68c17e07 into 78747e6c).

---------------------------------------------------------------------------

by travisbot at 2012-05-31T09:02:57Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1485634) (merged 9c1ba1c4 into 78747e6c).

---------------------------------------------------------------------------

by neilferreira at 2012-05-31T09:04:16Z

Sorted, I'm guessing I need to squash the commits?

---------------------------------------------------------------------------

by travisbot at 2012-05-31T09:21:30Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1485732) (merged 7b5328f1 into 78747e6c).

---------------------------------------------------------------------------

by igorw at 2012-05-31T09:38:07Z

With what value did it fail? Can you add a test case for that `HTTP_X_FORWARDED_FOR ` value?

---------------------------------------------------------------------------

by neilferreira at 2012-05-31T10:45:11Z

Anyone have any idea why that function returns an empty string instead of null ?

---------------------------------------------------------------------------

by neilferreira at 2012-05-31T11:34:12Z

@igorw done, I've also removed an old test that should have been removed when getClientIp() started using the 'trust proxy' variable concept.

---------------------------------------------------------------------------

by travisbot at 2012-05-31T11:38:19Z

This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1486534) (merged 85db2213 into 78747e6c).
Validator Collection Constraint by Groups

fix ValueMetadata::setConstraints to set instead of append
make suggested changes and update 1 more test
merge origin
suggested changes