labofsahil/github-event-dataset-2012 huggingface dataset:
You're testing that the sentence() method returns at least one character, while you should be testing that it returns at least one word...
same for the next test.
This and the rest of the parsing and setting into ModelNode is better done via the SimpleAttributeDefinition.parseAndSetParameter method.
Why not extends AbstractAddStepHandler ?
dollar price 我准备实时取汇率来得到。这个模块忘记做哦，但是可以实时得到。
I would say Código instead Clave
The grid was never designed in a wireframe. I created some guidelines for the homescreen, but i'm afraid they're quite old. Originally the proposed size for the icons was 60x60px including the shadow. You can find a screenshot here explaining how the home screen grid was originally built: https://www.dropbox.com/s/w1rwbf9w1fc1g7c/homescreen_guides.png

The reason behind using that size was because we were designing over a 5px grid, so it was strange to use the 64px size, and using 65px left a really small horizontal space between icons.

Anyway this is quite old, and the newest icons have been redesigned by @patrykdesign so maybe he can help you on clarifying this.
This is not exactly it. One of the possible solution is to *not* use the default styling of the browser (but I don't think that's a good idea) so the comment does not reflect the reality.
make app.manifest.entry_points a local variable and use them to not introspect the object everytime
nit: group it with the "bluetooth-dialer-command" message
please remove all these `class="menu-item-desc"`, as they break the indentation in this panel.
This 'if' block is not needed with the following ones isn't?
We are doing this twice. Can we put it in a separate method?
BTW, typo here: `This element must contain data-keycode attributes.`
Mmmm, I think the name is unfortunate. It is not related with FTE at all. It only controls some code that should only happen once. Let me change it.
wow this is really nested :) You can also use multiple setup blocks if that makes it easier.
typo: current
At first I thought of doing it  like you have said but I didn't get it directly from the sources because:
* The source directories don't have all the files that are included on the .zip 
and
* The .zip is built in Javascript (build/webapps-zip.js) and I can't (or I don't know how a simple way to) call a shell script from javascript
Can you use `an+b` rules to save a few lines?

https://developer.mozilla.org/en-US/docs/CSS/:nth-child

(don't use `:-moz-any()` though)
should this go to the develop branch? or we need it also on production setups?
The docs seem weird here... it doesn't seem like `path` or `archive_format` (from below) are optional, since they're part of the url. I only confirmed that `ref` was optional. 

@pengwynn see my comment on the docs [here](https://github.com/github/developer.github.com/commit/d2e774cce7e37f5daefb014e219c73a380a6e896#commitcomment-1476855)
Can we leave the label.  Would be handy when you are using a keyboard to navigate.
I'm glad we're getting some docs in place for the DRb stuff, but I'm not sure that these scenarios have much documentation value...they don't demonstrate what the DRb options do; they just show that when you set them, the configuration object stores the values you set.

This is going to sound funny given that I'm the lead maintainer for rspec now...but I'm not even sure how to use the DRb options (I've never used the options).  I know spork uses it but it'd be nice to document how to use it w/o spork.  Not sure how feasible it is to demonstrate that with a scenario here, but if it was feasible, it would be a huge improvement, I think.  Or, even if it's not feasible, maybe some additional text at the top explaining why you would want to use the options and how you would use it?
~~~
オプション定義フォームはいくつかのエリアにわけられています:
~~~

~~~
オプション定義フォームはいくつかのエリアに分けられています:
~~~
~~~
"Add an option" リンクをおすと、新しいパラメータを定義するためのフォームがオープンします。
~~~

~~~
"Add an option" リンクを押すと、新しいパラメータを定義するためのフォームがオープンします。
~~~
What exactly? All the listener code or?
... and the optimal choice of density cutoff is also sensitive to T.  I was envisioning that the user would put

```implicit val myMonoid = new SparseIndexedSeq[MyType](myLen, mySparseFactor)```

somewhere in scope before using this feature.
;-), that comment has been here for 3 years. Thought I'd keep it around for good time!
isAjax() can be true but AjaxRequestTarget.get() is null
Consider using optiflag to parse command-line arguments.
Document each of these globals.
@iNecas good idea, done
true, i guess I over engineered here a bit to much convenience methods in..
It's a shame to lose this but best for now. We should bring it back when we revisit our API approach for this sort of data.
This can be done away with if we have mochiweb as an included app in the escript.
Until the DBI changes all at once to return epoch times, yes.
We are consistently using DB instead of Db.
And a third os.sep vs. /
Let me ask Ricardo tomorrow (or this week, since he is busy on WWDC and getting owned in basketball *cough* =P )

--------
Letters were harmed in this message!

On Jun 12, 2012, at 12:37 AM, minggo<reply@reply.github.com> wrote:

>> 
>>                 dataSize = widthBlocks * heightBlocks * ((blockSize  * bpp) / 8);
>> -                unsigned int packetLength = (dataLength-dataOffset);
>> +                float packetLength = (dataLength - dataOffset);
> 
> Yeap, it is stranger.
> It should use "unsigned int" instead.
> But cocos2d-iphone use "float" here.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cocos2d/cocos2d-x/pull/1000/files#r965357
i afraid we'll get undefined method `custom_port` at line 39 if `web_custom_port?` is false
I don't think there's any point in this - all the email addresses are already publicly available on CRAN.
jQuery(document).**ready**
Please add a space before `(`.
What's `next` here ?
As I write in the bug, I think the stacktrace would be more useful if it doesn't show the `deprecate.js` module source, but it stop from the function the developers trying to use but it's deprecated.

For instance, if `require("api-utils/utils/data").base64Encode` is used, the last two traceback entries displayed are:

  File "resource://jid1-bccwqbm65t8cba-at-jetpack/test-ui/lib/main.js", line 37, in null
    console.log(base64Encode("hello, world!"))
  File "resource://jid1-bccwqbm65t8cba-at-jetpack/api-utils/lib/deprecate.js", line 19, in deprecated
    deprecatedUsage(msg);

Likewise with `deprecatedUsage`:

 File "resource://jid1-bccwqbm65t8cba-at-jetpack/test-ui/lib/main.js", line 35, in null
    console.log(getChromeURIContent(chromeURI));
  File "resource://jid1-bccwqbm65t8cba-at-jetpack/api-utils/lib/utils/data.js", line 66, in deprecated_getChromeURIContent
    'require("api-utils/utils/data").getChromeURIContent is deprecated, ' +

So in order to keep those tests for `deprecateUsage`, I just wrap it in a function.
I'm not sure it's a good idea. I think we should dispatch our custom notification and handle it from `addon/runner`
This passes for the new user case because of the comment I made in network.js - https://github.com/mozilla/browserid/pull/1410/files#r670265.  Since the user's userID is never set, shouldAskUserAboutHerComputer is called with an undefined userid, which returns false and prevents the question from being asked.
Yea they do. This simply catchs the interrupt signal, which is usually Ctrl-C, which doesn't typically mean to shutdown. However, I guess we want Ctrl-C to shutdown everything. This would send SIGINT to the child processes, and then the above `lib/shutdown.js` would properly close DB connections and so forth.
Can you clarify what you mean by this? I chose RangeError because it's commonly used for this type of error: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/RangeError .
No need to reference the issue in the code comment. Just describe what the code is supposed to do.
I've fixed the footer. I've just need help in fixing the header.
it would be possible to just set all the 'HINTS' and do one 'find_path' but i have seen find_path be very buggy in various situations and perferred to keep the calls to find_path extremely simple and straightforward.
may want to call out that the pull request URL should be specified in the `branch` field in the ticket
Is this behavior changed in Ruby 2.0? If not, the version guard should just be "1.9" instead of trying to exclude what will be Ruby 2.0
Hi, Scott Actually I hadn't cought this issue  while I was developing this patch, and this perfectly works in IE6-8( see www.yandex.ru ) Unfortunately I still don't understand why does it work  :/I'v tried to reproduce this issue and succeded   that i know: -- it reproduces only on first page load-- the reason isn't the cache  You can see it on http://ikondrat.name/mquery If you know more about this ussue please share details 02.10.2012, 17:13, "Scott Jehl" <notifications@github.com>:In respond.src.js:>  				}
>  			}
> +
> +			for(i = 0, l = $styles.length; i < l; i++ ){
> +
> +				elm = $styles[i];
> +				inlineStyleContent = elm.innerHTML || elm.innerText || elm.textContent;
Interesting changes, here, thanks! Have you tested this in IE6-8? I'm curious how you've worked around the issue of all un-supported media types/queries being converted into @media UNKNOWN when fetching the text in IE.— Reply to this email directly or view it on GitHub.-- Kondrat Shmoylov
consider calculating (col_en - col_st)/2 and (row_en-row_st)/2 outside the if statement for better readability.
all internal vars should be marked as private. here and elsewhere.
You're probably right that it doesn't matter much - although whether the file instance is del'ed quite soon is implementation-specific, isn't it? If so then using 'with' seems cleaner.
Can these IDE hints be done without using docblock notation? I.e., use the following:
```php
/* @var \Zend\Server\Reflection\ReflectionParameter[] $params */
```
I ask, as in vim, it messes up syntax highlighting when the extra "*" is in there. If it can't that's fine; just curious.
That not have any sense. You don't create a test with accidental wrong values. Check this because seems that you have a lack in the test design.
The convention within the framework is to use "null === $this->listenersToDetach", or, if you despise yoda conditions, "$this->listenersToDetach === null", instead of is_null().
We have to put it here for the repo itself, as it's a dependency for one of the components. For the packages we build, it will be a requirement on packages for Zend\Code only.
Never mind -- per conversation on IRC, this is not an issue.
No, do you want me to add it in "server/dispatch/AbstractActionHandler" here : https://github.com/ArcBees/ArcBees-Infrastructure/tree/master/arcbees-core/src/main/java/com/arcbees/core
Has been added even though a similar node exists in fmTools. The difference is that this node accumulates key presses and that it includes a scale factor to make twist messages fit to the m/s-rad/s standard
In my tests, 1024x600 appeared as 16:9, which is what I desired. That resolution seems to have gained the 16:9 designation even if it's technically 16:9.375. I'd rather not confuse the users.
This broke tests
This folder doesn't actually get used as far as I can tell... but Azure Diagnostics won't work without it... I'm investigating further, but for now it's needed. I might be able to crank down the sizeInMB.
Yes.  I am thinking about adding a "transport" concept that would abstract the task queue interface.
Remove the extra space between variable name and unary operator `++`.
I saw some hard-coded mentioning of that prefix in the above code (Symfony related). Maybe that one should access the config instead?
http://dev.gentoo.org/~ulm/pms/4/pms.html#x1-140002.2

In your case just using EAPI="4" is ok, I think )
I wasn't even born!
Even though it is already closed: ppn=All doesn't seem to work via the python api.
`'site' in cryptBlock` is more typical.
Yes, I know I'm commenting on stuff you didn't change, but I think it's worth fixing up whilst we are here :-)

On 1 Apr 2012, at 15:57, sgilda wrote:

>> 
>> -After a user is successfully added to the database, a message is produced container the 
>> -details of the user. An example MDB will dequeue this message and print the contents as such:
>> +
>> +Access the application 
>> +---------------------
>> +
>> +The application will be running at the following URL:  <http://localhost:8080/jboss-as-cmt/>.
>> +
>> +You will be presented with a simple form for adding customers to a database.
>> +
>> +After a user is successfully added to the database, a message is produced container the details of the user. An example MDB will dequeue this message and print the contents as such:
> 
> I didn't edit much of what was there. I agree about "as such". Changed it to read: "An example MDB will dequeue this message and print the following contents:"
> 
> This also doesn't make any sense: "a message is produced container the details of the user"
> I believe they meant: "a message is produced containing the details of the user"
> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r630782
Probably should be "test" not "run", as this is not a deployable quickstart.
Ohh I get what you're saying :D
See my note above, but this all gets a lot easier if we use integer values for constants like `VOUCHED` instead of chars. Then we should just abstract some way of figuring out what level the user is:

```python
def get_level(user):
    """Figure out if the user is vouched, superuser, staff, whatever."""
    if user.is_superuser:
        return ADMIN
    if user.groups.contains('staff'):  # That's not how this works, I know.
        return STAFF
    if user.is_vouched:
        return VOUCHED
    return PUBLIC
```

And the docstring, or some doc, should really elaborate about the levels we do have.
Why? There should be a comment in the code explaining this and its effects.
I have a feeling we'll be doing these few steps in a numver of tests. I wonder if a log_in method in the base page might be useful.
comment indentation level
Oke, deleted that part.
I would like to make it configurable, and if possible, not a required dependency.

I can see two ways to try that:
1. move the gem definition from gemfile to bundler.d/jsonp.rb
2. add a settings to config/settings, and if that value is true, then add and configure jsonp?
Ok, I've created another commit which uses LayoutKind.Explicit.
stat.st_atim.tv_nsec = 5;
will work now.

st_atime etc. probably should be properties instead of fields, but changing them to properties would break the ABI. (It also breaks the API, but only if someone passes a st_atime field by reference to somewhere, which seems to be rather unlikely.)
It might be a good idea to change them to properties the next time Mono.Posix gets a new version number.

I've updated create-native-map to allow ignoring
Unnecessary line breaks


.
lists -> arrays to be consistent (or change all "array" to "list")
pDis2 will be at most half of the size of pDis1 and pDis1 can be very big (I tested with a dataset containing 100 million unique record ids and 5 columns (so pDis1 had 400 million records and pDis2 w/ 100 mill)).
,MERGE?
I separate locators in "regions" for better readability
For clarity, perhaps `VidscraperCommandHandler`?
`(fn? :foo)` returns false, so I don't think is going to work correctly. I think you want `(ifn? fn)` instead.
Need top-level docs
There is no Expand/Collapse icon for this when I run it (Chrome)
It's fine to have this here, but I would prefer that the target folder is deleted after the tests.
The extra functionality and the visibility hiding is starting to be a bit over the place. Might be worth thinking about consolidating that a bit more. I'd be okay with changing the contract a bit, for example actually sending the extra data back in an extra object.
this looks like a bug to me
Instead of hardcoding in _site, could it deploy the current working directory or take an argument?
De `== true` is een beetje overbodig. 

Dit:

```js
if (foo == true) {
  // do something
}
```

is het zelfde als:

```js
if (foo) {
  //do something
}
```
Ok, but whatever is picked it needs to consistent, right now it's half n half.

Emailing from my iPhone 4S like a BOSS!

On 2 May 2012, at 08:07, Andrey Andreev<reply@reply.github.com> wrote:

>> @@ -36,16 +36,38 @@
>>  */
>> class CI_Cache extends CI_Driver_Library {
>> 
>> -    protected $valid_drivers    = array(
>> -                        'cache_apc',
>> -                        'cache_file',
>> -                        'cache_memcached',
>> -                        'cache_dummy',
>> -                        'cache_wincache'
>> -                    );
>> -
>> -    protected $_cache_path        = NULL;    // Path of cache files (if file-based cache)
>> -    protected $_adapter        = 'dummy';
>> +    /**
> 
> I'm with @derekjones on this one, even though I'm not that concerned with how it affects parsing. It really makes it harder to read and a 4+ line comment block for 1 line of code just sounds like a waste to me.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/1296/files#r760215
Strange that we have these to params defaulting to NULL here and FALSE in the class. Surely we need to pick one? 

Yep I know `$secure` was like this before, but this seems as good a time as any to address this.
To fix issue #113 properly, change this line to:

```
if ( ! in_array('required', $rules) AND in_array($postdata, array('', FALSE, NULL), TRUE))
```
Вы абсолютно правы. =)
У вас одновременно обьявлены и переменная NSMutableArray *DNA и @property NSMutableArray *DNA, нужно выбрать что-то одно и работать только с ним.
да, лучше пересчитать.
не пересчитывал, думал 100% -- 100 chars
1 к 1-му
Здесь правильнее будет int i = arc4random() % [arrayOfChars length];
В этом случае можно не фильтровать exclude на символы в arrayOfChars. Ну и в качестве "побочного эффекта" можно избавиться от функции randomCharacter, вместо нее вызывая [self replaceCharacter: @" "] (ну, или не @" ", а любой другой символ не из множества {AGCT})
Помимо этого, данную функцию вполне можно сделать функцией класса
Только учтите, что static переменная видна только в пределах того блока, в котором она была объявленна (максимум - в пределах одного файла).
Вообще советую познакомиться со спецификаторами static и extern и с директивой #define языка C, если вы не знакомы. И с самим языком тоже.

В пример от @aspcartman было бы круто добавить еще ключевое слово const после static.)
Спасибо. Таки забыл исправить на 100 (для отладки и интереса делал 10 и выводил геном на экран).

Тем не менее, если ничего не менять в коде, то клетки инициализируются с длиной 100.
It appears that Brent and I may have stumbled on a typo that was causing the cordova 2.0 code to clobber the top window and frame, rather than just the frame:

If you change window to win on this line, the problem goes away, and the top window has the Chrome FileReader while the frame has the Cordova FileReader (ideal outcome, IMO).

https://github.com/blackberry/Ripple-UI/blob/next/lib/ripple/platform/cordova/2.0.0/spec.js#L53
I still think https://github.com/github/ReactiveCocoa/issues/94#issuecomment-10820187 is going to be an issue. Maybe we should continue that discussion at the top level here.
因为是队列，建议直接写offer，而不是addLast。
The goal of this function is to find the 'slide-design' docinfo node that precedes the current node. It's a bit ugly probably, but it works quite well, and allows to reset the slide design several times in the document, affecting only the nodes following.
add "add titles=dict(grad='Residual (grad)')"
no need for the extra spaces between the operands. Just use one space before the equality operator and one after it.
I'm curious what that shouldn't be `create_index=False`?
No need for the trailing comma.
We have to test if we don't need a precondition here i.e. it must not fail if you first drop not null constraint and then run this changeset.
You should put here: if (containsName) break;
this should be true.
Change this to `:pt`
`Change Router Configuration Parameters`

I'm not perfect about it, but we basically try to capitalize nouns, but not verbs and adjectives/adverbs. In this case, I think case, by that definition, I think `router` and `configuration` should be lowercase, but I think it just looks funny.
,该模块尚处于试验阶段，其指令在未来可能会发生改变

文景已经向nginx提了bug，新版本不含此句。
This was an artifact of my earlier changes that I forgot to remove. Good catch. Gone!
Don't you want Option(properties) here since it's Java and they like to null?
I still need to go through all of the Java stuff.  I think that's on the agenda for today/tomorrow.

On Feb 27, 2012, at 2:32 AM, viktorklang wrote:

>> +
>> +import java.util.concurrent.CountDownLatch;
>> +import java.util.concurrent.TimeUnit;
>> +
>> +@SuppressWarnings({"unchecked"})
>> +public class ExampleSessionJava {
>> +
>> +    //Timeout timeout = new Timeout(Duration.parse("2 seconds"));
>> +    ActorSystem system = ActorSystem.create("ExampleSessionJava" , ConfigFactory.load().getConfig("example"));
>> +
>> +    final SettingsImpl settings = new SettingsImpl(system.settings().config());
>> +    Timeout timeout = new Timeout(settings.Timeout());
>> +
>> +    ActorRef amqp = system.actorOf(new Props(AMQPActor.class));
>> +    // defaults to amqp://guest:guest@localhost:5672/
>> +    Future<Object> future = Patterns.ask(amqp, new ConnectionRequest(new ConnectionParameters()), timeout);
> 
> What type do I get back here?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jboner/akka/pull/350/files#r490574
but the semantic here is more a scope than a prefix. You group all attributes under the User model scope.
Scope would be a name for that property but it is already blocked by AR scopes...
Estaría bueno, eso no trae problemas?
This look identical, just moved up 40 lines. Necessary?
Why is the final keyword being removed and a setter being added?  Is there a problem with the constructor?
The goal is to be able to say "I only want the columns X and Y visible". That's why I used to call it "white list" but now the name is rather confusing.
This line is commented out, is that intentional?

Otherwise, I think you need to change it to something like:

ext = os.path.splitext(fname)[1]
if ext != ".fastq" and ext != ".gz": continue
use the config for the init:

https://github.com/aerogear/aerogear-ios/blob/master/AeroGear-iOS/AeroGear-iOS/security/AGRestAuthentication.h#L26
Unary operator are no more wrapped by spaces

Check your formatting options in netbeans

```php
if (!$tsbas[$ksbas]['domct']) {
You are using old capp templates, that was changed to `setFullPlatformWindow` a long time ago. Can you please change that?
I'd prefer a hash here that we can than iterate (see application cookbook):

```ruby
default['redmine']['gems'].each do |gem,ver|
  gem_package gem do
    action :install
    version ver if ver && ver.length > 0
  end
end
```

Same for packages below.
You can remove this line if it is not used any more.
Yeah it will break that - I didn't run the tests since I made the pull over github, will try to do it now
Same thing if it succeeds. Basically once the task is done, the state we report to the user (assuming no other task is running and the server status is ACTIVE) depends solely on the MySQL status. The guest restarts MySQL and doesn't return until it determines the *real* state of MySQL. So usually its ACTIVE, unless something goes wrong, in which case the service status is something like CRASHED or SHUTDOWN which we want to message the user about via the REST API anyway.
Ok, you should document the design decision as javadoc then :)
One more think came to mind here..
I think it's okay for the thread pool we created to be shutdown in the stop method.
But the other constructors, that receive a thread pool from the user should not shut it down on stop: it's a good rule of resource management for the creator of the resource (thread pool for us) to manage the shutdown as well.
So here's how I think this can be solved:
1. Add a new Ctor that besides the pool also has a flag to allow us to take ownership of the pool (i.e. we'll destroy it when the DistExec is shutdow)
2. leave the current constructor as it is, make it internally invoke 1. with takeOwnership=true (this would preserve backward compatibility)
3. amend the executor to only shutdown the thread pool if it has ownership
4. document the threadpool ownership in all constructors

This is not in the scope of this JIRA, I guess you can either fix it as a new commit or create a JIRA for it..
Recently the memory cost of java collections has been demostrated in presentations such as:
http://www.cs.virginia.edu/kim/publicity/pldi09tutorials/memory-efficient-java-tutorial.pdf

And the presentation particularly mentions HashSet as quite a memory consumer. If the uniqueness is already guaranteed somewhere else and the collection is relatively small, it might be worth switching to an array list?

Just making sure you take this into account.
I think it would still be a problem when the user restarts the cache, because the leave request could reach the coordinator after the join request (which is sync, so OOB).
Also, note how we insert "dirname" to the path.  What is the reasoning for *not* including plot_working_directory into the path (or dirname)?
If z-axis sharing is supported, why not just remove these three lines?
Let's do this in a followup.
self is missing from the inside of the is_element_visible method
Nobody seems to be using it, but let's leave the event in place for now in the interest of doing no harm. 

If we leave it in we are essentially making the decision to promote our list of Events to public API status. In doing so we're going to have to document them. I wrote that up as KERN-2932.
I am not 100% sure about this - are you sure that store_model_features will always be called? will it work otherwise too?
Pretty minor, but we use use /** as a standard for commenting methods instead of /*
changing IDs to classes slows down CSS processing an incredible amount.
You should use `<!-- IF . quickmod -->` here, the loop only exists if the user has permissions on at least one so no need to have a second permission check here. Also adding/removing quickmod options can be done without touching the template.
Is it possible to add a ``@param`` annotation for parameter ``$preferredEntities`` which defines the array type; using ``array<SomeType>``, or ``SomeType[]``?
Are you sure ``'json_encode'`` has the correct type as "string" is not a sub-type of "object<callback>"?
This would really be how the tests should have been:

```
assert_equal false, CloneWar.new.war?
```

I think `assert false` will just always fail in Minitest
What happens if it doesn't match?
Shouldn't we also call ``dispose`` on the created widgets, e.g., ``foregroundColorEditorLabel``, ``syntaxForegroundColorEditor``, ...
Samme her, blanding av tab vs space.
We'll soon have to create those dynamically I guess.
Forgot about that, sorry.

e18d58d
Cool, well i think supporting geometryless imports is definitely worth having so let's go with it and fix issues that come up accordingly. It would be nice however to a test case that at least verifies the geometryless case. Any chance you can whip one up?
"al menos" since a category has not been selected.
> echo $OSTYPE 
    darwin11.0

That's what it says in Lion for me. The uname approach seemed a little more universal to all OS X version.
fixed in 9e88520
Something about how we use the response object has changed in Ruby1.9 - if I leave this out I get an error:

E, [2012-06-13T13:05:26.511526 #21978] ERROR -- : undefined method `grep' for "":String

I actually wrote this line a while back, so details are hazy, but I *think* I tried catching an empty string (something like "if response.nil? or response == "" or !response.grep(..." but it didn't seem to work. If you can get around it that way, go for it :)
фиговое название для метода.

Кроме того он неправильный. Ты смотришь совпадения `user_id`, но при этом передаёшь `id` для тега.
This comment is really unnecessary. It does not tell you anything new.
What about when we will have password reset etc.... (was copying nodewatcher) ?
Fixed it. But this code is from previous pull request.
Rename `object` to `horoscope`.
What? What is this? Why not `super(BrowserIDBackend, self).get_user(user_id)`? What way of calling of parent implementation is this? This disables inheritance further one (what if somebody inherit the BrowserIDBackend class?
Don't construct forms manually. Use Django forms for this. (Also that you learn how to use it.)
Also indentation here is strange.
So `var panels = {{ panels|json|safe }}` does not work?

Otherwise, you can try:

```
var panels = $.parseJSON('{{ panels|json|escapejs }}');
```
No need for `name=` because it is the same as function name.
We do care about the return value. You are right, a unit test that verifies the return value has been forgotten. As I like to stick to the mantra "one assert per test", this should be another test.

I am not really sure where you are seeing either Mocks or Stubs in that test?
I actually don't really care for the difference of those two, that's the very reason why I am using NSubstitute :-)
See line 27. If it's not defined the javascript isn't written at all and the text just stays on the page.
Doesn't content already have the datastream dissemination? Fedora is kind of slow, doing two calls seems unnecssary.
gasp, magic numbers
Won't this result in a nil object exception? I don't see `service` getting initialized anywhere.
I don't like the approach of creating separate view for that. NewPaymentView is just enough. It should just decide which response return:
- a HTTPRedirect
- render a template with some additional step to click.

In both cases client will or be redirected automatically by GET, or will click this form submit and will redirect by POST.

There is absolutely no reason to introduce another View for that.
space window in second ?
> as many of the things we do might need such same permissions... 

I think so, too. I believe that Hibernate does this kind of reflections a lot internally. According to the [jedis 2.0.0 javadoc](http://www.jarvana.com/jarvana/view/redis/clients/jedis/2.0.0/jedis-2.0.0-javadoc.jar!/index.html) that `RedisDatastoreProvider` uses as a Redis client, there are 12 properties that can be set. I'll rewrite them as an `enum`.
Accessing internal variable (_technique) violates encapsulation principle. It means you are missing a public API for this operation or that the work should be done elsewhere.
Or maybe the default attribute in the cookbook could float (`7.x-2.x`), but our role here could be pinned to a commit. That might make more sense :)
The function name is confusing; it's hard to tell what it's doing by looking at its name.
That's the body separator, adding `"\n"` as a constant.
looks better

more numpy, but it's not obvious to me that numpy will be faster than python lists in this case
It's not clear to me what the actual shape restriction of the kernels are. 
The docstrings in the individual kernel functions are ambigous. Are the kernels for univariate or single multivariate or really many multivariate observations.
Yup, that's right on the space convention.
I know this isn't yours, but this line is redundant.  n<2 was already tested earlier in this function.
I didn't even know about the latter (comes from using ipython all the time and just using a ?) and I think `help()` is *much* better...
He aled, what is the point? The tomcat entity isn't used anyway in the test. So what is the point of creating it and not using it??
La SOPA est carrement a l'ordre du jour, ils l'ont bashe une fois mais ils vont revenir a la charge

Hadopi et SOPA c'est pas exactement pareil mais c'est tout de meme tres proche dans l'idee. La c'est pas une analyse technique des lois mais plus l'analyse de la tendance a vouloir controler intenret
de toute facon je pense vraiment que cette partie est a reecrire. Si tu veux parle du modele spotify et dit qu'il faudrait le generaliser. Parle aussi de tv-links.eu en disant que c'est ce genre d'interface que devraient fournir les majors et qu'on pourrait tres bien imaginer un modele a la spotify. Mais la c'est pas credible
htmlescape package got deleted because it was originally intended to be part of a larger "web-utility" package, that for various reasons never materialized (basically with corelib rehaul, the library groupings went in a different direction). The same htmlescape functionality can be found in the intl package, but it should be noted that that particular function makes some simplifying assumptions for that particular case and is not a "general purpose" html escape function (we should certainly add one though).
Done. 1548fdac1c42e201aa93c9c832d54dc4b2332c64 moves to using `key in obj`.
it's a stub. actually I don't know what CSS rules should be there - looks
OK for me.

On Tue, Aug 21, 2012 at 6:18 PM, bugzmanov <notifications@github.com> wrote:

> In ui/src/main/resources/assets/css/style.css:
>
> > @@ -302,6 +302,9 @@ table th{
> >      max-width: 80px;
> >  }
> >
> > +#prj-list td.time {
>
> what for?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/griddynamics/OpenGenesis/pull/445/files#r1424631>.
>
>



-- 
Sincerely yours
Andrey Zhuchkov
Software Engineer, Grid Dynamics
+7 927 107 7024 cell
Skype: zhuchkov.andrey
www.griddynamics.com
azhuchkov@griddynamics.com
Maybe I should to change 11 and 12 lines. It appears the same twice (with and without link) if I put link_to in another paragraph below. What do you think?
Why did you add the parenthesis around the `click_on`'s argument?
Can you turn this into class constant. Sorry for my previous comment.
This code looks strange! What are those { }s ??
Actually i have changed all invocations which resulted in warnings so there should be no need to modify the library in this case.
Is it worth removing this method completely? Not sure if we need to be backwards compatible here as existing apps can use the older gem.
Actually, glance add is deprecated... you should be able to change the above lines to follow this pattern:

```
glance image-create --disk-format=XXX --container-format=XXX --is-public --name=XXX
```

There is no more kernel_id=XXX or ramdisk_id=XXX options, so for those, you need to do:

```
--property kernel_id=XXX --property ramdisk_id=XXX
```
Please use $::operatingsystem for facts.
лучше вместо такой длинной проверки сделать в начале вот так `isAscending = isAscending || false;` а потом просто `if (isAscending) {}`
Id say its bad style to use {} for array arguments where it is implicit since this is the standard used everywhere else in the code, we should not be re-writing lines where this is not required.
Здесь происходит очень непроизводительная штука (посмотри в реализацию entrySet(). И код у тебя работает не с Map, а с SortedMap.
Yes. That was my concern. Kind of a knit, merging.
No put it in at line #50 of base.py
if we are keeping this, it needs to import, create, and return the Details object rather than having that be created in the test.

however, in the interest of avoiding the app that doesn't have a long description, it may be the thing to search for a particular app that is known to have the description.

an example can be seen https://github.com/mozilla/marketplace-tests/blob/master/tests/desktop/test_reviews.py#L33
I'm pretty sure I said this made sense earlier today.  After some reflection, I don't think it is.  This allows someone to create a comment in someone else's name.  I have the same problem in my votes model so let's talk about it in the morning.
This is related to @stefanv earlier comment about this suppression loop: You mentioned that simply using a maximum filter with wrapping wouldn't work. Could you instead bad the `hspace_max` array to get the same effect as this loop? Assuming that does work, I'm not sure how performance would be affected (probably slower for few `coords` but faster for many `coords`).
You might need a sparse version of T here. However if this is the cause of the test failing we should find a way to make the exception message more informative as this shape error message is misleading.
Indeed, let's make it a more representative / meaningful example with 5 samples for instance.
> Should fit_path be true by default? (that's a real question: I don't know
> the answer).

I raised the question before. I would say no but they if need to
maintain backward compat to store coef_path_ as attribute
I can add a comment. If n_features <10, ``int(0.1 * n_features) == 0``.
`array2d` followed by `as_float_array` isn't very elegant and may copy the input twice. How about `np.atleast_2d(as_float_array(X, copy=self.copy))`?
Готово, добавил ссылку в примеры и ридми.

Сделал метод op() и описал в доке + в примерах

Добавил возможность указывать постфикс и описал в доке + в примерах
I'm not introducing more funky code. I'm trying to make the existing code better, more readable. Since there are now written guidelines/style guides it seems quite arbitrary what style to follow from the existing code.

But sure, I can play ball and can conform to the existing "style". Is it anything else that need to be changed than the extra newline?
Why commented out ? 
This range is perfectly valid even though privately used.
If I'm not mistaken, you'll want to use `this.withoutCategories.apply(this, arguments)` to properly splat out the `arguments`.
Agreed. I'd rather wait for @ghalliday to define if that's a typo (and should return), or if I could remove the whole thing (which won't change semantics).
I disagree.  

The  whole point is that you can't remove the type cast because the uncast type doesn't have an ordering operation.  Extracting it into a function make that clear.  Other examples could be a blob, and possibly a variation of an alien type.

isOrderedType() should be in deftype though, not here.
I don't think you need this code here since selectmap really needs to be done inline.  The input dataset might need to be executed as a child query, but not the selectmap.  

The equivalent selectnth code is there to prevent all the rows being evaluated in the child, and then selecting one afterwards.
Would it better to rename this get() and 'get' above as query().


I generally assume that if a method is getX an it's a linkable object, then the result has been linked. (And if queryX it is has not linked)
This seems to be very conservative...
Formatting diff still here.
Sorry, but this will not work out - these writers are not writing anything anywhere...
With this change, the scripts output will not be displayed/rendered in the Scriptler UI: Scriptler > Run Script
This is an absolute must, without the output on the UI the user is lost.
This entire file is mixing 2-spaces indentation and 4-spaces indentation. Can you please turn everything to 4-spaces indentation?
Hmmm I think that is a better suggestion than mine. However I wouldn't default it to /etc/timezone, but rather not set TIME_ZONE in the local_settings.py file. Then graphite would default to whatever it uses out of the box.
I'm going to comment on this line, and then change around the commits without changing the line.
Do we have to call this send_report? It's a bit awkward because we will never send but save the report to the local disk.
Shorter:

    else if ( isset( $moduleResult['path'], $moduleResult['path'][count( $moduleResult['path'] ) - 1]['node_id'] ) )

But note that we usually also try to avoid duplicated operations (like the *count()* here), in this precise case I would have done something (untested) like:

    else if ( isset( $moduleResult['path'] )
    {
        $lastPathElement = $moduleResult['path'][count( $moduleResult['path'] ) - 1];
        if ( isset( $lastPathElement['node_id'] ) )
            $currentNodeId = (int) $lastPathElement['node_id'];
    }
Actually, I don't think the fact that it's a routing error ever gets passed along. I do see that the RouteNotFoundStrategy only listens for the dispatch.error event, but we should still probably set the error to static::ERROR_ROUTER_NO_MATCH (and update ExceptionStrategy to ignore it as well)

Though for consistency, perhaps we should still update that to route.error and listen for that in the RouteNotFoundStrategy as well?  (since the dispatch event hasn't even been fired by the time that particular error can occur)
All of the following keys are numeric - `is_numeric() === true`

````php
<?pnp
$foo = array(0 => 'a', ' 1' => 'b', '__200' => 'c', '-1000.9999' => 'd');
var_dump($foo);
````
````
array(4) {
  [0]=>
  string(1) "a"
  [" 1"]=>
  string(1) "b"
  ["__200"]=>
  string(1) "c"
  ["-1000.9999"]=>
  string(1) "d"
}
````
ew, coffeescript
In JavaScript, functions are first class objects, so you could just do:

var predicates = [];
predicates.push(Util.isBase64Encoded);
predicates.push(Util.isValidUri);

And get the exact same result with less effort.
Yes, it should be. Sorry about that.
The ones for links can be removed. The ones for displayed text still need to have the slices because digits filter will also remove any appended letter.
The goal of these slices was to remove "FRC". Now your digits filter will remove them, so you can remove the slices, too.
`reduce` has not been introduced at this point. Functions like `range`, `filter` and `max` should be used instead. This is also not exactly easy to read.
If you have custom CSS and then downgrade, we don't remove the CSS you made; you just can't change it.  I imagine we keep the field around so that it's not changed to "" on save.
I'm not familiar with `/etc/.my.cnf`. Are you thinking of `~/.my.cnf`?
You're storing the password of the IM client, and you're saying this is a SMB password?????????
```send_request_raw``` can return ```nil```, make sure you have a response before calling methods on it. 
```ruby
if (res and res.code != 500 and res.code != 200)
```
Please move this logic to a method.
I can't see any reason why don't use ```_deprecated_function()```, it's widely used by other plugins and app themes: http://bit.ly/TZOov7 and even by 'competitors': https://github.com/woothemes/woocommerce/blob/master/woocommerce-template.php#L111

 > This function is to be used in every function that is deprecated.

https://github.com/WordPress/WordPress/blob/master/wp-includes/functions.php#L2801
Probably not... I'll experiment with removing it.

On Thu, Feb 23, 2012 at 2:20 PM, Sindre Sorhus
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,15 @@
>> +Ext.define('Todo.view.TaskCompleteButton' , {
>> +    extend: 'Ext.Component',
>> +    alias : 'widget.completeButton',
>> +    tpl: new Ext.XTemplate('<a id="clear-completed">{text}</a>', {compiled: true}),
>> +    setText: function (text) {
>> +        this.html = this.tpl.apply({text:text});
>> +    },
>> +    html: '<a id="clear-completed">Clear Completed</a>',
>
> Is this really needed, since it's set in the function above anyway?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/addyosmani/todomvc/pull/106/files#r482657
s/sample/quickstart/
I may seem "pointilleux" but following the style I use, this should be:

```objj
if (!_table)
    return nil;
return [_filteredContent objectsAtIndexes:[_table selectedRowIndexes]];
```
now we rely on the compute api.
I'm pretty sure we always prefer `undefined` to `null` despite some of my older code that probably has `null` in it.
:) really man. Gui is an overloaded term, commonly misused by software developers; thinking it means the widgets, such as canvas, etc.. GUI is not that. Gui in the real sense is the means for interacting with the app. In our case, the bunch of buttons.  But, I will change it.
this changes the default behavior during a crash to show a reasonable alert dialog and then exit -- instead of just killing the app.
When performing an update, do we also need to push the tests specified by the app.js or other configuration information? Or are these tests always bundled with the harness?
Why are we removing the example configurations here?
`TypeError: tegs is undefined` если tegs не будут переданы
Why is the comment after the code instead of before it?
Aqui tem uma questão de nomenclatura: se vcs calculam o semi perimetro, o nome da variavel nao deveria ser semiPerimetro? :D
The only addition was winston. I have sorted the deps. Ok?
What is this indentation :)
Does the note about  using doctrine/orm 2.3 apply to both Jackalope options (or indeed the Midgard one)?
These headers have only limited value anyways. If anything I would remove them from all files. IMO the overall project license is the determining factor.
the entire added code here I mean; it does a single thing it might be better understood if not inlined here, but rather packed into something with a good name
the name was pfactory before, I'll change it
rather not :-) A small labs project?

On Mon, Oct 22, 2012 at 5:49 PM, Christoph Gritschenberger <
notifications@github.com> wrote:

> In
> components/services/src/main/java/org/openengsb/core/services/internal/ConnectorRegistrationManager.java:
>
> > @@ -232,9 +259,9 @@ private void updateAttributes(String domainType, String connectorType, String id
> >
> >      protected ConnectorInstanceFactory getConnectorFactory(String domainType, String connectorType) {
> >          Filter connectorFilter = FilterUtils.makeFilter(ConnectorInstanceFactory.class,
> > -            String.format("(&(%s=%s)(%s=%s))",
> > -                Constants.DOMAIN_KEY, domainType,
> > -                Constants.CONNECTOR_KEY, connectorType));
> > +                String.format("(&(%s=%s)(%s=%s))",
>
> This sounds like a great idea. So great that I actually doubt we are the
> only ones needing such a thing
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/785/files#r1905254>.
>
>
seems like we can abstract this sort of error handling to a common "block builder" (probably not using the correct term here) but basically reduce duplication.
Ah ok, I wasn't sure, because of this https://github.com/borisguery/FOSRestBundle/commit/34f44a7954592cbfcb17279c458cb916ee296286#L0L44.

I'll fix it tomorrow.
Please do the real upgrade: using ``setDefaultOptions`` instead of the BC layer.
This class is not autoloadable using a PSR-0 autoloader. If you would like it to be loadable, it should be in the sub-path "JMS/SerializerBundle/Tests/Fixtures/ChildObjectWithMapFields.php".
блядь, снизу удалил, а сверху нет
Typically this has to be the size of the struct, but you can set this inline:

`cb = STARTUPINFO.sizeof;`
Whenever I remove non-x86 code from DMD's druntime, I always explicitly ask GDC and LDC developers to skip those patches, and this is no exception. I completely recognize how troubling it is to find this kind of information (I've been there too). This patch only removes it from DMD's druntime since it isn't really relevant here. But if you really think there's value in keeping it here, I can refactor it into a comment.

I know that druntime is shared across compilers, but I don't see why the druntime of one compiler should have code that isn't relevant to it. I understand the Phobos arguments, since eventually, it'd be great to be able to build Phobos with one compiler and use it with any compiler, but this is not the case for druntime.
Ditto: use ddoc-style syntax.
a function should be created to limit duplication
I tend to link to the *current* Spring docs: http://static.springsource.org/spring/docs/current/spring-framework-reference/html/jms.html (on the **current** path)
**FIXED.**
Where is the local variable 'vm' defined?
GHMMMAMMAMFDMS.
Sure. This is my first time doing this stuff though, so I have no idea how exactly to re-edit my commit. A little help please? Teach a man to fish...
phps is not a valid Pygment's lexer
true as fourth param
Tässä on juuri oikeaa ideaa. Sekvenssin pituudestakin voitaisiin vielä pitää kirjaa summaa laskettaessa:
~~~clojure
(loop [summa 0
      pituus 0
      jono a-seq]
  (if (empty? jono)
    (/ summa pituus)
    (recur (+ summa (first jono))
           (inc pituus)
           (rest jono))))
~~~
Can you remove the ``abstract`` keyword ?
The cache bundle should use the ``2.0.*`` branch