labofsahil/github-event-dataset-2012 huggingface dataset:
Since there is no return outside this `if (argc == 0) {` block, a "control reaches end of non-void function" error will be generated.

This will crash ruby. You should handle argc > 0 here.
Not at the moment, but with SAVE_AHEAD implemented in zookeeper for Timestamp it could happen
not used?...and I think dangerous
else...
This is already the default usage format.
I was given the file from you, who got it from Steve / made it somehow from prod data. I'm not sure if this is a standard, but it is the way you guys gave me the data.
Call this RestrictedString or something like that, Language is too generic/ambiguous.
Hm, weird. the main correction (row 95) didn't survive the commit :/
I will commit the change later on again
If you like, I'l change it back. We also can apply changes to the whole cursor layer, instead of each cursor.
This pattern match is dependent on it being a 2-tuple with those fields being in that specific order, this isn't very forwards compatible if more metadata is added.
Moved it to winpty.gyp, but i could not get it to work without adding the include directory in binding.gyp also. What am i doing wrong?
since the docs use markdown, the code sample here needs to be indented four spaces to show correctly.
Personally I disagree, but will change :)
Ridiculous indentation + SPACES = :-1:
This should use C99 designated initializer syntax for clarity:

`info = { .bounds = patternBounds, .contentsScale = view.layer.contentsScale }`
Please assign the copyright to Horde LLC, otherwise we cannot incorporate it.
The function definition should be moved up here as well.
Implemented. Tests are on the other use-case.
Without fix, it won't print out these books (or any following)
Remove this file ?
Well, I don't think the spec is exactly clear on what you're supposed to do here. While I was researching it, I read that you can actually use 0..textureSize instead of 0..1 in special cases, although I never have... :/.
Added in the section on commit messages.
I don't recall looking at that. The one we use should support normalize relative references.
отступ в 2 таба, запятые на новых строках
у этих строк вплоть до { нужен отступ в 2 таба
oi, this should have not been checked in. lemme fix this
why have you change `klass` to `@klass`?
I think that we should not add `netaddr` gem as Active Record dependency because we will only use it with PostgreSQL.
You can fix this pull request and push with `-f`
There's a typo on `serialized_attributes`. Also, can you change the example from `stored` to `serialized`? I think that `stored_attributes` doesn't exist on 3-2, they were added to master only, so they're not the big deal (perhaps we could even remove the `stored_attributes` mention here?).
Is there any time that ENV['rails_version'] would be passed when it wouldn't be a branch or tag name? Or rather, when it would be a short commit hash?
Text was being sanitized only once, before the gsub calls, I think it's ok to keep the same logic instead of sanitizing each block.
yes, it works also and is much clear
I'm toying around with removing the name_counter variable from the partial renderer / locals and just setting up a method delegating to the iterator index. But tbh at the moment the module eval context in the template class is doing my head in =) Also it feels really dirty adding code to the template class for something that is just used for partials with collections, but I do not see a different way to do it yet.
```
Fixed a bug that ignores constraints on a glob route. This was caused because the constraint regular
expression is overwritten when the `routes.rb` file is processed.
Fixes #7924

*Maura Fitzgerald*

```
We also broke source compatibility with some changes in implicit lookup that I've noticed.

I don't know how much of an issue breaking source compatibility further is, so I conservatively recommended keeping it this way.
But personally, I'd bite the bullet and make the method abstract as it really should be.
I think the guiding principle should be:
- exclude internal exceptions by default (also applies to `NonFatal`)
- still allow handling internal exceptions by compiler/library writers

Now, first off, I think `NotImplementedError` should be fatal. Clearly, calling a method which isn't implemented is fatal.
However, if we can agree on that, we have nice solutions for both user and compiler code:

Users would write:

    catch {
      case NonFatal(e) => // will not catch fatal or internal Throwables
    }

And library/compiler writers that deal with an internal exception could do:

    catch {
      case ct: ControlThrowable => //...
      case NonFatal(e) => //...
    }

I think having both `ControlThrowable` and `NonFatal` is enough to categorize these sorts of exceptions.
Here's what I get when commenting out the `override def emitIdentifierDeprecationWarnings = false`:

```
22:19 ~/Projects/Kepler_ident-deprecation-warnings/test (topic/ident-deprecation-warnings)$ ./partest files/neg/macro-false-deprecation-warning

Testing individual files
testing: [...]/files/neg/macro-false-deprecation-warning              [FAILED]
1,3d0
< Impls_Macros_1.scala:13: warning: macro is now a reserved word; usage as an identifier is deprecated
<     def unapplySeq[T](x: List[T]): Option[Seq[T]] = macro impl[T]
<                                                     ^
7d3
< one warning found
1 of 1 tests failed (elapsed time: 00:00:01)
```
Did you ever find a solution for this? I'm now seeing the same error when search orders and the email field is included in search params. The error is only present when using Postgres though, it seems to work fine with sqlite3.
IndexedBase is non-commutative. So I can't use it here.
At the same time I wanted that the case of infinity indexed object will pass always in the future (even if Poly will be embeded).

But now I see that Poly fails and for ordinary symbols.

Will remove this test.
a brief docstring would be good.
There were some old tests that dealt with this. I passed them (though not the first time). Let me know if you can think of a good test to stress this code.
No need for `&& $query['distinct']` here.
```
}
else
{
```
为什么要预先知道多少行呢？
See comment https://github.com/joyent/libuv/pull/567#issuecomment-9033115
This *query* returns all documents that have a coordinate pair in the ``loc`` field.
Why is there a new document introduced here?  There is already a similar one above.
If you do not have an index on the timestamp field then create one before perusing other optimizations.
before the comment?
Use something like `array[$id] = $id`; in order to avoid array_unique. Also make sure $id is integer.
nit, mixed quotes for less escaping.
Gets -> Get here and all over? Ya have 'Rotate around X axis', not 'Rotates around X axis' for instance.
We should avoid using constructors like this (see comment on RequestConfig above)
How about "grantPriv" as a name for this?
`S8.pack . T.unpack` may not be the right thing, in general. `Data.Text.Encoding` exports converters between Text and ByteString
Done and done, and I will bear that in mind for the future.
Y.JSON
Do you think this cast is necessary?  It looks like if it's used it eventually gets divided by 1000.0 anyway, so the cast seems meaningless to me.
Was done here: https://github.com/tomauer/MOL/commit/20696cf40cf52465625ccb0e281f83c9aa83c1f9
All properties in Exception class are virtual. Same is for ArgumentNullException (for example). It appears to me that's the accepted standard for implementing exceptions in the core library, and I followed it.

Of course, It can be changed if requested, if it violates Nancy's coding standards.
this comment applies throughout: Rather than using arg and passing a "string", it's better to just create methods. 

toolbarAdd()
toolbarSync()
toolbarInventory()
toolbarLogout()
toolbarResources()

would be 
* easier to use than "doToolbar(<x>)"
* could throw an error at pre-runtime (method doesn't exist) rather than later
* if you make a typo now and write "loggout" instead of "logout", right now nothing will happen and it will fail silently (no error occurs, rather ```doToolbar("loggout")```  would get called but all the else statements would fail to be called --> nothing would happen). This is confusing.
Initially I included only this function (there was no ``cosine_latitude_weights``) as this is likely to be the one people use most often (it is the most common choice for weighting data prior to EOF analysis). I wanted to make it obvious that this scheme exists, to discourage people from incorrectly using ``cosine_latitude_weights`` for EOF analysis simply (though lazily) because it is the only option provided...
The `geocs` (which should really be called something like `geog_cs` or `ellipsoid`), needs to be an optional argument. I think the projection-specific arguments are mandatory. Hence something like:
```
    def __init__(self, longitude_of_projection_origin, latitude_of_projection_origin,
                 scale_factor_at_central_meridian,
                 false_easting, false_nothing,
                 ellipsoid=None):
```
Re-factored in my (imminent) PR.
If a different exception is raised, namely AttributeError in the grad of argmax because the code ignores that gmax can be None and treats it as a numpy array, the test fails. I'm basically testing to see if I can compute the symbolic gradient through argmax and I do not care if it is correct or not.
Same question here, why does this return java SQL timestamp?
Why is the example changed? I'm not sure what this adds?
ah, crap. missed this when I did the cleanup. thanks.
cut&paste comment fail.
maybe better to use IndexOf("xen", StringComparison.OrdinalIgnoreCase) ?
What if someone removes some memory chips since the last discovery?
I believe we keep under 80 characters a line in docs as well.
Put it all in a separate file.
i see that the MassDeployment name lukasz requested would require rewrite major of code below, where you use Multiple Deployment name.
please revert this to ( ! $toSchema with spaces, also the two occurances below.
There is an empty TODO comment here. Is this intended?
The reason why it is null is because it only applies to certain calc modes, i.e., event-based. In the context of a classical calculation, it wouldn't make sense for this parameter to even be present. (Same applies for the other boolean fields above: complete_logic_tree_{ses, gmf}, ground_motion_fields, etc.) That's the rough convention that I've been following. Additionally, these fields are optional even in the context of an event-based calculation.

So that's my rationale for modeling it that way. I don't have a strong opinion one way or the other, but this make sense to me. Thoughts?
That sounds like a better solution to me ;) But still, the list of timestamp could be used to track (for information) when an episode was successfully flattred.
I think this should merge on top of existing curl options rather than replace them
Numbered arguments are awful... These need to be given something meaningful
Ok, will use palloc/palloc0 directly. Thanks
This must be updated.
Whoops! You're right. I didn't realize what file I was looking at. My bad.
Yes, indeed. I don't understand your concern. What's the difference?
add f_classif scores with -np.log10(p_values)
don't we have these define somewhere as class variables in `vumi/message.py` ?
По интуиции поставил тире, ошибся. Действительно, в данном случае тире между подлежащим и сказуемым не ставится. Поправлю.
Да, безобразие :)
Могу ещё добавить:
- разработчики Git'а — это не то же самое, что и разработчики, использующие Git (имелись в виду, по всей видимости, вторые). В книге про Git, я думаю, можно не уточнять постоянно, что речь идёт о Git-репозитории или разработчиках, использующих Git (это было необходимо только при сравнении Git с другими СУВ).
- вести/осуществлять рабочий процесс — как можно осуществить процесс? Почему только «идея», когда это вполне сформировавшаяся практика? 
- второе предложение и вовсе перевёрнуто с ног на голову. В оригинале говорится, что ветка master содержит только стабильный код — это понятно и логично. На русском почему-то оказалось, что стабильный код есть только в ветке master. Данное утверждение абсурдным образом допускает, что в ветке master также может быть и нестабильный код, зато стабильный код в других ветках быть не может. Ерунда.
- не уверен, что названия веток надо переводить. Слово “master”, например, не переводим, “iss53” (от issue) тоже.
- зачем говорить <i>другая</i> параллельная? Очевидно же, что не та же самая. Аналогично «код успешно проходит тесты»: не доводилось слышать, чтобы говорили «код неуспешно проходит тесты», обычно говорят «код не проходит тесты».

Предлагаю:
> Многие разработчики придерживаются такого подхода,  при котором ветка master содержит исключительно стабильный код — единственный выпускаемый код. Для разработки и тестирования используется параллельная ветка, называемая develop или next, она может не быть стабильной постоянно, но в стабильные моменты её можно слить в master. Эта ветка используется для объединения завершённых задач из тематических веток (временных веток наподобие `iss53`), чтобы удостовериться, что эти изменения проходят все тесты и не вызывают ошибок.
I really like how you've laid out `__all__` w/ the comments :smile:
This line should be
```scala
implicit val streamInstance: Traverse[Stream] with MonadPlus[Stream] with Each[Stream] with Index[Stream] with Length[Stream] with Zip[Stream] with Unzip[Stream] with IsEmpty[Stream] = 
  new Traverse[Stream] with MonadPlus[Stream] with Each[Stream] with Index[Stream] with Length[Stream] with Zip[Stream] with Unzip[Stream] with IsEmpty[Stream]
```

not modified `streamInstance` type
:+1: I was thinking the same. Since we're bumping the minor version, this is a good time to clean this up.
I've modified this to take a TypeMirror. I'll look into the visitor more this evening.
hm.. probably better to link to our official one: https://github.com/twitter/bower-server
Does this mean that DEV_MODE has been replaced with the performance logging mode, or am I missing something?
No - for some reason these were separate when I copied them. I can merge them together.
I think this method should have specs.
Missing accent? Sin título
Passing _FSEncodings.UTF8 to Encodings._IANAToFS() will cause it to return undefined, so this should be Encodings.UTF8.
What is this (lazdir)?
`return !(/\/plugins-client\/cloud9.core$/.test(plugin) || ...);`
why are you adding an id to the dom node instead of the apf node?
if you use it for the styling only you could add a class to the apf element and add the styling either in the skin or in the css again
call free_itr instead of cleanup code
Can we default it to the group id in brackets?  Thats a field feature
currently
On Oct 23, 2012 3:22 PM, "Daniel Roberts" <notifications@github.com> wrote:

> In corehq/apps/groups/models.py:
>
> > @@ -96,8 +96,6 @@ def get_users(self, is_active=True, only_commcare=False):
> >              return users
> >
> >      def save(self, *args, **kwargs):
>
> You can just delete the function, right?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/core-hq/pull/133/files#r1920314>.
>
>
2 spaces to the left plz
I like

```
{ :data => { :target => ".nav-collapse", :toggle => : collapse } }
```
Because all our list up to date, have "list-style: none;", and DOM structure (as I understand) also wants that all classes are used as much as possible(and repetitions reduced if possible). And all our list styles have/had list-style set to none. Such repetition is unnecessary. And if one in three of lists wants different list-style, that one will overwrite this atribute. I thought this is more logical?
I can extend? I just get a warning:

```
FutureWarning: User uses inheritance, the default for allow_inheritance is changing to off by default.  Please add it to the document meta.
```

The only thing I have done (for testing, you should be more precise) is to:

```
from mongoengine.django import auth

class User(auth.User):
    birthdate = DateTimeField()
    gender = StringField(max_length=6)
    facebook_id = IntField()
    facebook_token = StringField(max_length=150)
```

So removed all parent fields. And I could register?
The default values for those are False unless I am missing something. Source: https://github.com/hmarr/mongoengine/blob/master/mongoengine/django/auth.py
Maybe with tag?
django.core.exceptions.ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details.
Please add docstrings for all methods.
Rather, it was supposed to be.
add an -o prefix too.
Let's change the way checkJS and checkCSS work.  Instead of passing an array, just pass the args and have them use arguments to get an array.

checkJS( SRC_DIR, EDITORS_DIR );
Why did these get removed?
You could use the existing page IDs for this
Changed! Good spot on that, thanks!
Will the routes be generic? If you're doing simplistic pluralization you'll wind up with some weird URLs.
Rather than putting all this code in a giant branch, why not do a `goto cleanup` in the if from L402 and add the label down near bufrelease?
I'm not sure, setup.py may need to be standalone. I'm looking into it.
Err. This is left from old edits. I'll fix this soon...
confusing name to me. I think you mean "after all tests were run' running is present test
copyright should be inserted here
Vielä primary key tähän.
Javadoc here that describes the job
here we have the problem about opacity and canvases, if you uncomment this code, all icons are placed behind all icons, i don't know to explain the behavior very well jejjee :)
Added to the message, fixed locally.
Was this a test-in-progress? Commented-out code shouldn't really be in the repository as it's already in Git's history, unless there is a good reason.
Thanks.. these were both covered by the previous review :)


On Fri, Nov 30, 2012 at 2:02 PM, Markus Bachmann
<notifications@github.com>wrote:

> In src/Monolog/Handler/PusherHandler.php:
>
> > +
> > +use Monolog\Logger;
> > +use Monolog\Formatter\
> JsonFormatter;
> > +use Pusher;
> > +
> > +
> > +class PusherHandler extends AbstractProcessingHandler
> > +{
> > +    /**
> > +     * @var internal variables
> > +     */
> > +    protected $pusherKey;
> > +    protected $pusherSecret;
> > +    protected $pusherApp_id;
> > +    protected $channel;
> > +    protected $event;
>
> protected vs private?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Seldaek/monolog/pull/132/files#r2277603>.
>
>
Please revert it. OS specific files should not be ignored by the project but by your local setup (potentially globally to avoid doing it each time you clone a repo as you never want to commit a ``.DS_STORE``): https://help.github.com/articles/ignoring-files
Instead of doing this, just pass the method and make the dictionary case insensitive.
nit: not a big deal but this does not fit Gaia's coding guideline - https://wiki.mozilla.org/Gaia#Coding_Style 

      if (displayedApp === url)
        return;
`} else if {`
You need to provide UI feedback for unsuccessful unlock.

Really important -- many SIMs only allow 3 attempts and it would lock you out forever.
I'm not a big fan of super in the case where the class `__init__`s have different call signatures.  It requires an extra mental step to confirm that the right arguments are being used.  But if others don't agree, I can change it.
I would say change this to ``:maxdepth: 2`` so we can see the developer main TOC on the front page.  Right now it looks pretty lonely with just the index page.
Since the `requires_optional_dependencies` already takes variable arguments I figured one would just call it like `requires_optional_dependencies('foo', 'bar', 'baz')`  This is much simpler and makes the single-string format superfluous.  It will also be less error prone should we in the future add support for version specifiers and environment markers ;)
It might be worth making this into an exception class instead.  Fewer stack levels to unwind that way.
@icedfish 不过可以考虑默认加上对老代码的兼容。但是不太想这么做，因为以前那样的用法很奇怪。
`emit proxyIpValid(fProxyIpValid)`?
Huh, it may be that something went wrong. For example, why is this message being removed from all languages? It's still there in `forms/addressbookpage.ui`.
Same as below, I wanted this to be similar to the other functions, perhaps it would be a good idea to update all these to be more C++ style then? But I'm not sure if core devs would ACK such a change on that code-part?
Updated to "S&ignatures" (&S is used by "Send Coins").
See: https://github.com/davidfowl/JabbR/pull/495#commitcomment-1353163
the ORM ? not necessarely
you should remove the underscore in the function name
Could the cache grow infinitely if a frame is refreshing again and again?
Honza
now that i merged master into my branch, this disappears.
Probably going to need an index on the {source, dest, tag} tuple; see other collections for examples.

MongoDB indexes on multiple keys have some fairly specific characteristics. If you index on {A, B, C}, you can use the index to speed up searches for {A}, {A, B}, or {A, B, C} -- the ordering matters. This may or may not be useful -- it seems that you only search for documents keyed on "source" or {"source", "dest", "tag"}, so that ordering is probably fine.
Obviously, we will need to make these `cmd` lines general before we can merge this.  But I think it will be helped if we can create the ruby package and use ruby to find the location of kernel.rb.  I guess we need to learn more about ruby packaging and command line installation...
probably should put spaces after the commas here? simple style..
Use git__free() instead of free(), please - it is just a #define for now, but I have a branch that uses it to do allocation logging
No inline JavaScript please. Make this a separate file and add it to a bundle in settings/base.py. Thanks!
webtrends.js has a *gasp* `document.write` in it. So we can't load asynchronously. I wonder if this has been screwing up our data.
I had originally broken the line at the first open `(` but I didn't like the result. I'll try this way.
need extra line here
No, that line: 

``from socorro.external.postgresql.base import PostgreSQLBase``

imports only the PostgreSQLBase class from base, nothing else. What you can do is write:

``from socorro.external.postgresql.base import add_param_to_dict, PostgreSQLBase``

to import both the class and the function. And then you can simply call ``add_param_to_dict``. Without any ``self.`` because it is not part of your class.
I've seen code where they use sockets to determine the hostname of self. Is that better?
I had the strange issue that it displayed the username each character (red colored) per line including (red) ANSI codes, but today I used `width.append([colored.red('('+ issue['user']['login']+')'), None])` again and it worked. I'll change it back.
Thanks. I'd like to do more, but this is a start.
Why is this JS not the same as the JS above?
I was thinking about to make a test function only for fill the array and use the @depend clause for this function, because it's used in other function and I think that this will be c&p again and again... but I'm not sure that's neccessary.
What do you think, in general, about the test? something improvable? I was reading the phpunit manual and I didn't find much more to improve the test :-/
i agree with @bschussek
Okay, accepted. :)
`public` should not be specified on ifs
yeah that was the problem... Even in drass.c It cannot pass the float value. Integer values can be passed correctly. Dont know y
If we're going to use this, we should probably export this to a separate file instead of copying the code.
Why 3? It's used in the ```license``` method too. Perhaps a separate method with a clear name like ```read_license``` along with a comment why there is this integer needed would make it more transparent and would make it DRY as well.
put newline before `^` and decrease indention of whole block
as an effect of `return` there is no need for `else` block
And this one would like:
```ruby
def invite(investigation)
  if in_network(investigation.sender)
    UserPrivateMessenger.new(invitation, invitation.sender).invitation
 else
    UserMailer.invitation(invitation, sender)
  end
end 
```
有个小小的疑问，出发 onstart 方法？不知道你是不是想表达 触发 ？一般是触发事件，触发方法表述是否恰当
corrected for both
Sorry, I'm too impatient to read this in detail and !@#$ GitHub doesn't do proper side-by-side diffs.  Can you explain what's going on in this section that changed so much of the code?  Most of it looks pretty similar, is there a big change to whitespace or something?
The directory structure and file naming conventions need to be documented somewhere.
Yes. See #94.
Can you include a description of the format of this?  It's not immediately obvious what needs to go here, as different Kerberos libraries require this info in different formats.
Remove these changes.
The error leading to that case was pretty confusing. If the hand is empty then player_hand is "", which means Cucumber complains about not finding the step "Then Bob should have discarded". Reminds me of the early bugged MtG Generator cases saying "When ~ CIP, draw cards" or similar. I considered enhancing the step definition to accept that as meaning "should have discarded nothing", but it's a bit of a confusing way to phrase it....

Maybe player_hand = @hand_contents[this_name].join(", ") || "nothing"? Along with an enhancement to understand "should have discarded nothing"?
Dommage de réserver au minimum autant de mémoire qu'on en aurait besoin au maximum...
Проявляют инициативу.
fixed, in the setup method there was also a dublicated mock init, removed both
mod_cluster uses the term "load balance factor" (or "load factor") and "load balance factor provider" (or "load factor provider").  We should probably keep this consistent to avoid confusion, e.g. SIMPLE_LOAD_FACTOR_PROVIDER
This seems like a really weak node inference. Is this supposed to support AMD as well?
I'm not sure but do we need to have right padding '0.5rem' and bottom padding '0.1rem' here ?
@jmcanterafonseca  Is ok to put the strong but we must specify a font-size, in this case 1.4rem for that paragraph.
We should an entire rule for controlling paragraphs in #contacts-detail.
Shouldn't this selector be parametrized as well?
indentation seems broken at some point of the DOM hierarchy.
I'm planning to have the BBs (not pushed yet) stuff under <app>/shared/style, is that correct?
no need for self.
I don't understand. Why is there different speed based on the direction of the pan?
bit confused by this at first glance can you clarify the intent here?
It sounds better "Almacenamiento USB habilitado" but it is up to you.
I'm really not liking MZFFO.  I'd prefer  _FXOS or MOZFF.  Basically, I've never seen Mozilla abbreviated as MZ or "OS" abbreviated O. I know it is bikeshedding, but let's not get stuck with something we don't like.  I vote for _FXOS
Sure, you are right, will let the system to handle this case.
OMFG, I really need some vacation. Wow. :-s
leftover from debugging?
nit: lower camel case for function naming.
I modified the original tz_world.json file slightly to compress it.  With Scelfo's changes, I think I'll change it back to the original tz_word.json format
Get rid of the ```this.```
you'll need to extend the MssqlSchemaParser to change the visibility of the `cleanDelimitedIdentifiers()` method.
That code was copied almost directly from Flay, so I most certainly did not. That'll have to be fixed before an actual release is done.
> I am an `\n` with no purpose
Call this "IS_PROFILING_ON".
Document what this is used for.
This line is unnecessary, right?
needs a better name
I am not sure, but it seems, that it might happen that  ```[self sendDidFailWithError:error];``` and subsequently ```[self shouldReloginWithPendingAction:SHKPendingSend];``` will be called too. It should be either first one, or second, so that in case revoked access there is no alert (as consequence of sendDidFailWithError). Other than this minor thing the new sharer seems to be OK
I was more concerned that java was creating a new object for each and every item loaded into the database, only to basically call a simple replaceAll() funciton a String.
I'm not up to speed on how the JVM optimizes that sort of thing lately; as they are essentially identical objects, either java's being smart and re-using a single `FilenameCleaner` object for every call, or its actually creating a unique `FilenameCleaner` for every item.

Static works, but it seems a bit hollow since there's only really 1 line of code here.  Which do you prefer?
1) Reinstate `FilenameCleaner` as a static class.
2) Changing `GsonEquipmentDatabase.cleanFilename()` to be `protected` and change the unit test to call that function?
Would something like the following make sense?

{ok, State} -> sends 1 unit stat + ElapsedUs
{ok, [{Op, Units, ElapsedUs}], State} -> sends a list of {Op, Units, ElapsedUs} 

This way, we can have a single op that generates a series of individual actions for finer grained control.
Except that there will be jQuery 1.9 which will be still maintained for years…
How about checking pRet before using it?
Sure thing, I will try this later today and let you know if it works fine.
For the same prefix like "Prefix" = ["p1", "p2"] but not from different packages, I've had issues with this. But I will test again.
How about:

> Like the `init` command, `require` allows you to search for packages.
negation could be remove here
That really doesn't matter..
imho, this should be in the plugin's config - not check-dependent. And also, the plugin should allow more than one recipient.
1601?
Can you wrap start - p->payload in ()?
Should be ^member/$
I think this should be ```STEEL_SLIST_H``` instead of ```STEEL_SINGLY_LINKED_LIST_H```
Taken blindly from http://ruby-doc.org/stdlib-1.9.2/libdoc/csv/rdoc/CSV.html
I will make it explicit
`m` is not defined. Perhaps you intended `this.options.model`?
It's little confusing why do you you use https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsICommandLine for this
I didn't wanted to make the current_env in the conf.js, but it certainly can be added ...
__whimboo__
> ... Given that file is new we could find our coding styles here. What do you think?

Sure! 
Then please nit all kind of styles here which doesn't fit! Of course You could also comment on #87
I'm sorry may be I did something wrong. I've added only sf2 validator to my composer.json and then I run "composer.phar install". I've never written anything in composer.lock: this line was added automatically by composer.
Dan, doesn't this line remove the need for the line immediately before it?
This is required because the CA is one of the code-paths that differentiate behaviour based on run-mode outside the settings.
Ah.  Do you think the wording of this comment is misleading for future devs, then?
== described_class
Oh, I see.
I believed and can't doubt it is not FileUtils.rm_r, because, you know, I'm ruby people ;-)
I think it is mspec's bug too.
that's true :)
Do you will apply the same refactor to the rest of exception messages?
This renaming involves a BC Break, isn't it?
Does c883a1d01ff9e869f4318b66341b682561f64536 make sense? Perhaps in the stream writer, you'd want the `PHP_EOL` append behavior to be optional?
This test need to be updated with the same notes described in #1588
Is there a reason that self::SPECIFICATION_WHERE is not in this list? If so, there should probably be a comment why it is missing or why only these four are valid.
Take a look to the new refactored tests to see how to remove this dependency
@Ocramius +1
For awoiding conflicts I'd "pin" ``BeautifulSoup!=4.0b`` as in the dependency ftw.pdfgenerator.
See https://github.com/4teamwork/ftw.pdfgenerator/commit/39a676c5ed60188919c22dcee28ae80a6edc2a74
(Not sure why 4.0b is ignored but as I remember it didn't play well in ftw.pdfgenerator.. This will make the tests pass again.)
Again, this is not related to this pull request.
Can't use pkg-config on Windows? What a pity..
Possibly, but the default is specified in ``execute``, so effectively the default is indeed ``HYDRATE_DOCUMENT``
Zo stderr nikde necitas, takze ak by mplayer nieco pisal na vystup, po chvilke sa zablokuje. Ak stderr nepouzivame, nepresmerovavajme ho do PIPE. Mozes dat trebars stderr=None a presmeruje sa na nas stderr.
what do you mean, get rid of them? also, what values are you talking about?
maven is great. it's like my very own neckbeard
Does this line need a semicolon?
I didn't like having things in there that weren't up to date. It seems better to look at form code to see how we do validation instead of writing it in a document.
I kept the list here because I kept getting "No handlers could be found for logger "django.request"" errors when running tests when it was removed.
File this.
Given our style guide, you don't need whitespace before the "{" when there is nothing else in it on this line. It is one of thee exceptions.

The other being the same deal, but with arrays, and the last being:

  foo(function() { 
  
  });

I know we have old code that existed before the style guide, that has the space when not needed, and if you copy and pasted from there, you have my sympathies.
@munoh = Munoh.find(params[:id]) はおなじコントローラーに三回出てくるので、メソッド化してbefore_filterで必要なアクションに掛けてください。
These can end with a `/` too
Ah. See. Do the same to the `cleared` field in terms of more descriptive constants.
```javascript
$.getJSON('/manage/templates/env-autofill', {'template': selected},, function(data) {
    $('#id_template_environment').val(data['variables']);
});
```
Rather than adding more latency to the trigger event why not just bind our own ready event to propagate this to all children?
Can you add spaces after these comments? `# Filter the list...`
Should be chemical/x-mdl-sdfile
same comment as in Consumer
Are there unit tests to exercise all possible variants (code paths) here?
Shit. You're right. Hold on, I'll make changes.
The only change to the JSON Schema for ModeShape's configuration files is the addition of a new "`cacheConfiguration`" field in the "`workspaces`" nested document. By default, ModeShape will use a CacheContainer created (by the Environment) using the `org/modeshape/jcr/default-workspace-cache-config.xml` file.
Oh, and we really need some lifecycle methods, since some connectors will need to maintain their own connections (and other resources) to the external system and will need to know when they can/should be closed.
oups :d, change !
Use:

for (var i = 0;......

Instead

for (i = 0;......

To prevent issues with global variables
а почему заглавная?  может лучше греческую букву? почему бы не написать в одну строку?
I try :)
Well that does not w ork either and I am not sure why. All Helpers method should be available on all views indeed. 
I added a TagHelper (I also tried with TagsHelper just in case in was one other implicit conventions) but the method is not available. I get
a nice `NoMethodError in Monologue/posts#index` 
If I move the code to ApplicationHelper, it works...
Things that should work and does not is highly annoying!!
well..What to do for headers information
Yeah I don't like this either.  But before, we were simply swallowing the exception.  And there's nothing about this function on its own that guarantees that the caller would be treating the response as "it's a new database", so it seems kind of weird to log that here... thoughts?
This could be shortened to:

```
3.times { Factory(:refinery_user) }
```

Not sure about the :page factory, but it could probably be shortened as well.
hint: it did, but don't ask me why, see test in line 236ff
It needs to be passed into the options of `express.bodyParser` at server start up. Making it configurable in the admin UI would require us to restart express.

The documentation doesn't really make it clear but it only sets the temp folder where uploads can be buffered before handing the request over the rest.js. U'll update the docs
Fixed. don't forget `npm install -d` when trying out.
These calls and the other `getTenantUser` calls can go through the REST API, right?
Yea at the time it was thought that there would be a need to use the API to get both direct role association (`getDirectRole`) and indirect role association, and rather than implementing methods `getDirect...` and `getIndirect...` I opted to just form the distinction between roles and permissions to be less confusing :) In hindsight it looks like there really doesn't need to be a notion of direct roles at all (`getDirectRole` is not used externally of the AuthzAPI...).

That said, we could probably just completely internalize `getDirectRole`, and then when we expand to add permissions, all of the current usage of `hasRole`/`hasAnyRole`/`getAllRoles` can be directly changed to `isAllowed`/`hasAnyPermission`/`getPermissions`.

So I guess the only change I'd suggest here would be to internalize getDirectRole.
I changed it to `val index = EmptyIndex`
Luc is right, the prefix does not contain dots.
`Object.getPrototypeOf(instance)===Object.prototype` is necessary to . JSON Schema objects are guaranteed to be direct instances of ECMAScript Objects, not ECMAScript 'object's!
You can store this in an instance variable.... '@mi_attempt'
Player is niet een entity. Player ben jij, robert popijus. Ben jij een entity?
These should probably all have the `CI_` prefix.
I never managed to find documentation for it.  I just tried to match what the tool output.  If you have clang, you can give it the -code-complete-at  option.
Зачем нам выполнять все начиная с этой строки, если mutatePercent == 0?
У вас получился довольно сложный для восприятия код. Можно было все это упростить.
Старайтесь НИКОГДА не называть переменные с подчёркивания.
I don't think we use the category_id field in this table.
Why not just make this an `NSInteger`, and avoid the casts below?
Missing commands doc and nothing says anything about what it keys off of.
please change the hardcoded headpin to System.getProperty("katello.engine", "katello") way. ty
not a major issue, merging with a mood to make it back to en_US ;)
Sure, you are right! 
the changes are already done... I'm commiting them.
2012/10/18 Martin Luessi <notifications@github.com>

> In mne/fiff/raw.py:
>
> >          List of channels' names
> >
> > -    verbose : bool
> > -        Use verbose output.
> > -
> > -    preload : bool
> > -        Are data preloaded from disk?
> > -
> > -    proj : bool
> > -        Apply or not the SSPs projections taken from info['projs']
> > -        when accessing data.
> > -    """
> > +    projs : list of projectors
> > +        The signal space projectors. Note: Do not manipulate this list
> > +        directly, use the add_proj and del_proj methods.
>
> Unfortunately it's not as simple as toggling the proj on/off.. since
> "active"=True means has been applied to the data (i.e. ca no longer be
> removed) and "active"=False that it will be applied later (when computing
> inv. etc.)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/149/files#r1881112>.
>
>

right....
I was midlead from the interactive experience in mne_browse_raw where you
can indeed toggle...
Wdyt about adding a switch for this? Could also imagine a scenario where you just don't want to respond, as you click.
The idea is to allow users to write named parameters when they call the reverse router:

```scala
routes.Application.route(`case` = "42")
```

But the backtick trick won’t work in patterns :(
So when you generate code for pattern matching expression you have to produce a different identifier, as you did.
last one moved getting files and directories here (before creating the destination)
We don't need to specify uplink Target, the uplink target is selected by our server. Please remove these fields. Uplink test does not need any parameter.
as *the* first argument
we should probably mark the optional params: ``asset(path, packageName = null)``
Arrays are mutable. Use something like a Seq
It's part of our coding standards and it's good for the IDE autocomplete.  Someone will have to do it so it's better done now than later.
Недоумение будет, когда чувак нажмет add feed, слегка промажет и
останется без состояния прочитанности.
Ок. Расскажи мне как в short версии сделать hh
Ya el mensaje tiene las excepciones, lo hice para no tener problemas si la
excepción no se puede materializar

On Tue, May 1, 2012 at 10:56 AM, Alpha <
reply@reply.github.com
> wrote:

> > @@ -54,6 +54,14 @@
> >  </body>
> >  </html>
> >
> > +@helper Info(MigrationDescriptor migration)
> > +{
> > +  if (migration.Messages.Any())
> > +  {
> > +    <span title="@string.Join("\n\n",
> migration.Messages.OrderByDescending(x => x.Date).Select(x =>
> string.Format("{0} on {1} action: '{2}'", x.Date, x.Action,
> x.Message)))"><b>(i)</b></span>
>
> Quizá también deberías mostrar las Excepcions acá.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/61/files#r755846
>
You'll need to pull individual items out of `Icons.xaml` into this project, because this will create a circular reference.
Does this need to be a public method, or could we just encapsulate the citation object a bit more?
Change BIBTEX to EASYBIB
No, this is an interface. If you look at the other functions, you'll find they're all empty.
This is very nice and thorough documentation, but I't would be more streamlined to use the `help` parameter in `optparse` (or `argparse`). Example:

```
parser.add_argument('--sum', dest='accumulate', action='store_const',
                   const=sum, default=max,
                   help='sum the integers (default: find the max)')
```
Should this not have a test which asserts that `''` is neither an exact nor a potential match?
No worries.  Done: https://github.com/arbenson/libtypedbytes/commit/275d0701fb8d00e7598bed408d883f6bee107cad
Looks like this comment still includes the "body.admin_namespace" class. Can we update this to "body.active_admin"?
it is now @hub-cap
'as' FTW but this is in common so I'd rather not change it.
Tämä ei kyllä vetele, tarkoituksena on kuitenkin harjoitella rekursiota :). Saat toki korjata vastaustasi, jos haluat tästä pisteen.
@maniksurtani That's the case when using this Cache Loader - it'll fully depend on JPA 2.0.  No Hibernate jars will be included.  It's primarily used for testing.  I don't know how else hibernate is used in the source though (since it was already in parent/pom.xml)
But how would each node create a cache per MapReduceTask?
Ok I've done something along these lines. Check it out
Is there such a thing? I did not find it.
all of this new documentation should be in creating-response -> "class location" and "declare a response"
Original was better.
Honestly, I have no idea why I started using global variables for rc stuff. Maybe because I thought that rc params are not supposed to change after creating a figure? Anyways, this problem is addressed in a commit now.
I should probably work on making the documentation prettier, a bit more...
I think this still looks a little clumsy. Maybe put `U, V,` on the line above and just have this function call wrap to two lines? Or:

```python
max_lim = np.abs(self.ax.dataLim.extents).max()
angles, lengths = self._angles_length(U, V, max_lim)
```
Blank line contains white spaces.
i think i've moved most of the prints, but i left one that was very very useful in debugging.
Can't you use getServerZoom here?
I did. See http://blog.teamtreehouse.com/increase-your-sites-performance-with-hardware-accelerated-css.
@rintaun - with all due respect, we didn't compile the PSR wording expecting to fight a court battle over it. If we were to be so exhaustive the PSRs would be unreadable and confusing to just about everyone who wrote it. Legal language requires wording that is super verbose. But read over the discussions, we were always trying to use examples so we didn't have to be overly-verbose and lawyer/legalistic about it. I can't really say more than this. This is really about trying to give some consistency.
I removed all of the empty ones.
Ok, then it's not a no-op. Never mind me!
yea its a known deficiency. My hesitation to add it is I don't like the type `Map[HTTPHeader, List[String]]` because the common case is `"SomeValue" :: Nil` which usually adds more verbosity to implementing code. Long term this will be something like `Map[HTTPHeader, QueryParam]` where query param abstracts that ugliness away.
Cool; seems like we should define and extensibility mechanism in `preview-to-editor-mapping`, since we now have multiple compelling prototypes which hack this file (see also e.g. toolness/friendlycode@7fa2dccad0faff0417b8a72208cfcb171ec30fee).
I'm not seeing where we set enabled to true for a new experiment.
I've changed this to:
```
total btree, LSM, table or file object key/value pairs
```

which might be sufficient.

I'm not sure what else to do; no data source counts this value unless it is, underneath, a btree, so I'm not sure what else we could do with it that makes things better.
I don't think we can get there with a value of 0 any more:

```
        for (request_session = conn->sessions,
            i = 0; i < conn->session_cnt; ++request_session, ++i)
                if (request_session->active && request_session->syncop != 0)
                        break;
        if (i == conn->session_cnt) {
                __wt_errx(session,
                    "failed to find handle's sync operation request");
                return (0);
        }
        
        syncop = request_session->syncop;
        request_session->syncop = 0;
```

For syncop to be 0  where the assert was testing it, we'd have to NOT break out of the loop, and that's caught by "i == conn->session_cnt".   If we break out of the loop, we know that request_session->syncop != 0, so syncop != 0, so I didn't see any further use for the assertion.

Is there a path through here I'm missing?
Okay. Well I guess now we know. @astrofrog: Is there a PEP ?
Can we use something like "yes" and "no" or "present"/"missing" or something meaningful? Blue and red belong in the stylesheet.
Why not use ternary here?
Tried it: Doesn't seem to enforce parentheses when calling. Compiles and tests correctly with every combination of the function and the call having parentheses or not.
We should decide on a guideline here: Do we want to leave out parentheses where possible, do we put them on methods with side-effects and do we put them on the calls?
Should the type for parameter ``$options`` not be ``string|array|\Zend\Config\Config|null``? Maybe you can also make the array more specific, something like ``array<String>``, or ``String[]``?
Is it possible to define the element type for the returned array (using ``array<SomeType>``, or ``SomeType[]``)? I also found this on lines 149, 166, and 183.
Are you sure the class "MongoDate" actually exists, or did you maybe forget to add a USE statement?
you are right, erroneous copy and paste. Corrected.
Adding API definition just for future reference:

    Releases this Statement object's database and JDBC resources immediately instead of waiting for this to happen when it is automatically closed. It is generally good practice to release resources as soon as you are finished with them to avoid tying up database resources.

    Calling the method close on a Statement object that is already closed has no effect.

    Note: A Statement object is automatically closed when it is garbage collected. When a Statement object is closed, its current ResultSet object, if one exists, is also closed.

    Throws:
        SQLException - if a database access error occurs
maybe add an

			expect(div.style.filter).toEqual('blur(strength=50) alpha(opacity=40)');

to that test would be cool
add a comment that this is typically the first component of velocity
Interesting. I can't get it to take longer that 3s on my local network. Try adding '--max-rtt-timeout 100ms' and see if it helps.

Also, try the full command on a subnet - for my network, 'nmap -sn -PR -PE -PP -PS22,80,443 --max-rtt-timeout 100ms 172.20.10.*' returned all 10 hosts in 2.7s. That's compered to 1.2s for a single host. So once we merge this I can look at how to make use of this ;)
I'll refactor this into a helper function in MTurkUtils. Sounds good.
OK, you should also rewrap those translated strings. I talked about this in one prior comment.