labofsahil/github-event-dataset-2012 huggingface dataset:
Type: `userlist`

`message` -> `username`?

The point is what are you sending. You could send simply:

```
{
    'type': 'userlist',
    'action': 'JOIN',
    'username': request.user.username,
}
```
But use something semantic.
You should define also a field where you will store time when this data was fetched/updated. By that you can see if data is current. If I understand correctly, timestamp just tells you when the information about the station has changed. Not how recent the data is. So we need to keep track of how recent the information is ourselves. And if by any reason (our background job crashes, their website crashes) data is not recent enough, we should first display a warning if it just little stale data, or otherwise simply don't display it.
You really don't have to exaggerate. Please use some smaller number. :-)
Space before `,`.
Željena stran ne obstaja.
You mean space after comma? I fixed that.
There should be newline after `~~~`.
What are you talking about?

**Old method:**
Look at current element in `ret` and
   * If we're collecting executable scripts AND this element is one, detach it and push into the scripts array
   * Otherwise,
     1. Find all descendant executable scripts
     2. `splice` them into `ret` after the current element (making the loop longer and guaranteeing that they will be rechecked and pass the above condition if `scripts` exists)
     3. Append the current element to `fragment`

**New Method:**
Look at the current element in `ret` and
   * If it is an executable script, handle it with the appropriate method (array push or fragment append)
   * Otherwise,
     1. Append it to `fragment`
     2. Find all descendant scripts
     3. Immediately handle them with the appropriate method
     4. `splice` them into `ret`
     5. Advance the index beyond the new inserts, since they've already been addressed
А почему тут count от where?
Hm, good idea. I do that in the next pull request =)
Why not create the hash object down here?

```js
if (typeof this.hash === 'string') {
  this.hash = crypto.createHash(this.hash);
}
```

Lets you avoid the delete call / mutating the passed in options object.
That would be fine with `_before_search` and other `_before_*`, as at that point most logical use cases would be modification of request parameters/query or abortion if authorisation check fails.

However `_after_*` methods may want to return something else than default response. E.g. `_before_search` to return `jsonify([model1, model2])` instead of `jsonify({'objects': [model1, model2], 'page': 1})`.

On the other hand, convention could be that `_after_*` method gets `data` parameter which holds data ready to be sent back. Then extending class may modify this object (or change it to anything it wants). But this wouldn't work in case of `DELETE` as no data is sent back when this method is used.
No.  I think I'm conflating `Heater` with a non-existent `HeaterManager` that would manage multiple heater instances and take care of holding onto data that's intended to be shared across multiple rendering stages (and potentially own `showElevations`).
I assume you meant `result` and not just "result".
OK. But, for .dlls, I would think they need to be copied to the executable directory, unless the path is changed by archive.py to the data files directory prior to executing the module.
${PWD/$HOME/\~} should work just as well, and save a few characters. stupid but I'm bored :-p
When I add interpolation utility function from gettext this line will be replaced with a call to this function.
@camertron already commented below about preferring `||` and `&&` over `or` and `and`. Just don't forget this one too. And as the condition body is only one line you can convert into a

```ruby
unit = calculate_unit(seconds.abs) if unit.nil? || unit == :default
```

but it's more like a personal preference, so it's up to you to decide which form you like more. Same for explicit `self` usage.
Better written as:

servers.any?
I believe there's a constant somewhere for that string.  Please find + use.
I think the direct stores should be named like the following:  direct-public.jks, direct-private.jks and and direct-ca.jks. In otherwords don't use gateway
Actually, it occurs to me that the first case also needs `gain : 0` to work correctly.  And I had been calling `sky_level` a required attribute.  So I wonder if that one is more or less clear as the super simple case:
```
image :
    noise :
        sky_level : 0
        gain : 0
        read_noise : 30 
```
versus
```
image :
    noise :
        type : Gaussian
        sigma : 30
```
On the other hand, I agree that `type : Poisson` was probably too confusing, so I think using `type : CCDNoise` instead for BD2 is better.  We can also have the noise type default to CCDNoise, so people can omit it if they want that, since it is probably the normal case that people will want most of the time.  

@rmandelb Rachel, do you have any thoughts about this?
@master-lincoln Deleted!
I hope the intent here is clear. I think this is a kinda neat solution to the "I need to update this JSON value" problem.

The easiest way I found was to say `json["data"]["globalRestApiSettings"]["baseUrl"] = some_new_value`. Since the incoming slashy-path is dynamic in the recipe, this is what I came up with.
Yeah, there's no reason to keep around `loadPSManifest` and `initPSManifest`, with your `questions` object.
Use `zmq.Context.instance()` to get global thread-safe Context instead of creating a new one every time function is called.
any reason for this not to be final?
why .get?
On Mon, 17 Sep 2012, Hannes Magnusson wrote:

> > +		/* Grab server information */
> > +		mongo_server_split_hash(ptr->connection->hash, (char **)&host, (int *)&port, &database, (char **)&username, (int *)&pid);
> > +
> > +		add_assoc_string(server, "host", host, 0);
> > +		add_assoc_long(server, "port", port);
> > +		if (database) {
> > +			add_assoc_string(server, "database", database, 1);
> > +		}
> > +		if (username) {
> > +			add_assoc_string(server, "username", username, 1);
> > +		}
> > +		add_assoc_long(server, "pid", pid);
> > +
> > +		/* Grab connection info */
> > +		add_assoc_long(connection, "last_ping", ptr->connection->last_ping);
> > +		add_assoc_long(connection, "ping_master", ptr->connection->last_is_master);
> 
> The command is 'ismaster' though.. So how about "last_ismaster" ? That 
> should making it more obvious how we actually got the data.

It's "is_master" in ever log message - hence I suggested last_is_master. 
It reads better too IMO.
Can you add a docstring describing what this collection is?
Why this backwards-incompatible semantics change?
upsss, pardon
`if (type_x === type_y)`
Hmm... this is big enough that we might consider making an object out of it for the next version.
I don’t understand why you’ve changed this function to do I/O instead of return a value — it’s no longer pure, why is this good?

If we do keep this change, then I think we should rename the function to something like “print-rollup-as-csv” so it’s clear what it does.
oh, that does make more sense. thanks
it's just based on a PHP setting. I get your point, thanx
This is a copy/paste from the MySQL template -- Percona behaves identically. I didn't want to remove any TODO's here since when this is actually addressed in MySQL I'll remember to move it over.
what we have to modify is, just adding "equal statement" to retry handling.
It's enough :)
I would rather create an interface class to be inherited by the various types of devices and check if the cast succeeds.
Исключение в конструкторе EOLNNormalizedReader и FileReader не будет закрыт.
I'm starting to see your point here...
I will update the code
i changed it to chunks. but on second thought, this might be confusing, as $chunksize does not specify a size of these chunks, but how many of these should be indexed at once. it's no big thing, so i do not care any way.
Required params should be listed first.
from what I remember this is dangerous. Can you check that it's equal to "noise = noise + noise.T"
I didn't realize that it was possible. Thanks for pointing that out!
use u and v are 2d it should be U and V
This will break because it will assume that ``verbose`` is ``alpha`` based on the position of the argument. Please. pass verbose as a keyword argument and run the tests in order to make sure that everything works ok.
Could you please add a whitespace after the `#` sign of inline comments? That makes those more readable and consistent with the rest of the source base.
Would be a good idea to check for the correct error message here
I believe what you mean here is just `else`.

Because `@state_of_the_switch` was `false` in line #23 it can only be `true` in this line #29.

In Ruby there is also `elsif` which you can use when you want to test for different conditions subsequently, like so:

```ruby
a = rand * 100
if a < 25
  # lesser than 25
elsif a < 50
  # between 25 and 50
else
  # everything else
end
Maybe its clearer to use the constant `DATE_RFC822` instead of `"r"`?
Isn't the convention that tryXXX is non blocking... like for example in Semaphore, acquire vs tryAcquire or similar? How would the method make that clearer?

And Condition could be called Goal or something instead, because it returns an object.
My internet is back on :D
So, getting intelliJ just for that "gitbash" you talked about :)
1) That's a workaround for Maven's activation system: If any profile is enabled, all <activeByDefault> are disabled. Using this, the profile is really always enabled.
2)  That's right. I need to figure out something better. I'll probably revert to not changing DB by default.
3) There are licensing problems. We can't distribute JDBC drivers at free will. At least not all we need.
    I could refer to globally accessible JDBC, but that would be very hardly maintainable.
    So I came up with this scheme of having a special repo for drivers, which could also be QA's central point for managing JDBC drivers.
    I think having the URL in POM is not a problem, there are many references to internal URLs everywhere anyway - in Jiras, bugzillas, mailing lists, irc...
You forgot about this line ;)
Other code assumes both these checks should always be true so I don't think they need to be done.
As you may see in the TiV8EventContainer, we are supporting multiple handlers, so it needed to check eventChange_  for nullness
Please use forward declaration of Activity Indicator here instead of using include
Clean les imports, tout n'est pas utilisé
No whitespace here
I'd advise against nesting parenthesis..
Just had a couple more comments in-code about the blurScreen function
You probably need a new simplify line for simplifying the different DICTIONARY expressions down to a single value.
Yes I think flawed, element 'i' might be in it's correct position, but the keys that are unreachable could still be beyond it.
And yes as I say, I'm not sure it's worth it.. as it's a filter, it's 'ok' to have missed here.
typo cleaed
I wouldn't change it now, since that will cause conflicts on the merge back to master.
It doesn't know at this stage, it _could_ delay it a bit, but in the meantime it will be waiting on others.
It needs to wait for a) all others to signal stopping and b) for all of them to be told everything is stopping, before it would really know if local gather is not needed.
But as they're all independent, it gathers and starts sending in chunks.

The alternative to this approach, which I considered, is add a barrier before any start and broadcast if all are stopping.

But this is very unusual, it's better to cater for the normal case and start gathering and sending and detect on 1st chunk.
oh yea new line.
indeed, this would break things for Windows whereas the previous command worked on it too
The length of this line gives me bad feelings, but it's ok for now.  Also, for many downloads I'm worried about creating many Gem::UriFormatter objects.

This should be checked with a profile run when your work is complete.
it'd be nice to include the URL of the unicode.org XML file here too
please correct the spelling of appointmentlink
@raydavis True, it works fine without. Just an old habit. Removing.
@shacker it seems like this `button` class adds a hand cursor when you hover over it, can we just add `radius` for now?
If that doesn't work, just add `border-radius` on the `cc-emitter` class
@shacker Can you find out whether we actually need the `href="#"` here?
Sorry about this Gary, but we cannot change the size limits
`if(` => `if (`
ack, compount booleans with a negated boolean makes my eyes hurt. :)
::Rex::ConnectionError covers all of these
Nit: Aligning attributes is prettier. Like:

    <img class="span4" id="photo-collage"
         src="{{ MEDIA_URL }}img/about-photo-collage.png"
         alt="{{ _('Photo collage of Mozillians') }}">

Not a big deal though.
does this one really need to be in the dist file ?
@jone yes it would be easier but also slower since I have to get the Member everytime for the email. When I don't get the email there is no need for that.
lol.  I like to think of it as social norms.
I had the same concern and talked it over with @shunter The guideline we agreed on what this.  The `from` functions are really conversion functions, you take an object in one representation and turn it into another.  So fromCamera, fromColumnMajorArray, etc.. Meanwhile the `compute` functions aren't converting anything, they are creating a new instances based on a set of parameters, essentially constructor overloads.  For example `fromOrthographicOffCenter` doesn't make any sense, since I don't have a orthographic transformation but I'm instead creating one.  In this case `computeOrthographicOffCenter` makes more sense.  I thought about using `create` instead of `compute`, but since we had the result parameter I settled on the later.  I think Matrix4 is probably a special case and at one point considered pulling all of the `compute` functions out into separate stand-alone functions, but I figured from an API standpoint, this was cleaner.  I'm totally open to `from` versions of the names if we can find ones that make sense, this way we'll be consistent.
I might be OK keeping this, but need to think through the memory trade-offs.  In particular, if an atlas falls just short of accommodating a large image, the texture atlas resize will waste all the previously available space, right?  Can we avoid that?
Do we really need the explict check, `=== true`?  I thought less was more.
type is unecessary
there seems to be an extra space in between `determine  the` , i don't know if it matter or not.
If the change regarding beforeTextChange is made, this should be changed back to protected
This could be tightened up a bit:

    var nodeParent = node._parent;
    return value !== UI.INHERIT ? value : nodeParent && getInheritedValue(nodeParent[parameter], parameter, nodeParent);
Returning at this point leaks the statement object memory
This feels really nasty. Can you please put the "var" directly before the distanceThreshold variable. I don't want those variables to accidentally be scoped globally.
well you have a black shadow of offset (0,0 ). so it s equivalent to no shadow.
So i think both case above work.
Why do we need an about page? This is short. Why can't this content exist on the front page? While I'm not opposed to an about page, I ask mainly because all other parts of this merge request seem to be misguided. Maybe this is actually a good idea? I don't know.
Oh really? Is there any place that describes that in more detail? Also, do you need me to change anything here?
виртуальность?
ok .. after talking it through with @cordoval we realized that dependency should rather be on doctrine/phpcr-odm and doctrine/phpcr-bundle
Lines like this won't appear in the generated dox, right? If so, you may want to replace "///" with "//" throughout. Thanks!
(throughout)
functionAttributes in code font
general question: how is `style-map` different from using `style="{{x}}"`?
I don't know much about `ng-style` in angular, but it seems like a normal attribute binding for `style` would work?
An example (for Boost, coincidentally) can be seen in the easyblock for Armadillo: https://github.com/hpcugent/easybuild-easyblocks/blob/master/easybuild/easyblocks/a/armadillo.py .
Do we need this file at all?
Since autoload is being required in common.php, this line can go away.
Can you tighten up the spacing a bit in this block?
This should be more like:

    sprintf('%s | %s', sprintf('%s Forums', 'bbsub'), bbp_get_reply_author_display_name($reply_id));

Simply appending "Forums" after the site name isn't great for localisation. e.g. it might be something like "Forums of My Site"

Also, I feel like this should be customisable via the UI if it's going to be not just the author's name. Something like `{site} Forums | {user}` with possibly other tags in there.

----

I think the better option might be to add a filter on this instead so that it can be customised, but not via the UI.
Não devia ter acrescentado essa classe.
Yes, leftover. Replaced with:

// refresh the annotations displayed on the document when an annotation is deleted as a comment, that is from the comments tab when annotations are merged with comments
Not entirely convinced that this is a good thing for 2 reasons:

* We lose out on the caching benefits of loading a single `application.js`
* The browser now makes more requests than before, each of which has a chance of failing independently. This could lead to strange heisenbehaviours.

I'm not extremely concerned by this change though, and am okay accepting with it.
please move this tests to zojax.content.attachment
And the CSL style seems to follow the style guide just fine for book chapters, so close this pull request.
See https://github.com/hpcugent/easybuild-framework/pull/377

@fgeorgatos: Can you adjust the source line in this pull request to:

```
sources = [('abinit-%s_x86_64_linux_gnu4.5.bz2' % version, 'tar xfj %s')]
```

Using the tuple approach with the template for the extract command as 2nd element should be supported by the pull request mentioned above.

If you update this easyconfig, that would be the perfect testcase for it.
Right, I think it was more clear to simply always do it.  "The trailing path should always have leading path separators removed."

If it's empty the gsub won't actually do anything, if it's not empty it might.
alter kommentar
refactored this stuff into classes that I think are a cleaner approach.  I hope you agree.  :)
The username doesn't matter here, if you use the factory you don't need to provide it: ``user = self.F.UserFactory.create(email="sumbudee@mozilla.com")``
rssItem method takes values from admin page, but can be overridden to take full control.
I see you've found another workaround about 'not-properly destroyed Derby DB'...
Maybe is it necessary to investigate more?
Also to save your time: if I don't answer to your comments - I agree.
I simply did what Artem suggested...


	<enricher id="enricher" input-channel="input" 
	                        request-channel="requests" request-timeout="1234"
	                        reply-timeout="9876"
	                        order="99" should-clone-payload="true" output-channel="output">
		<property name="name" expression="payload.sourceName"/>
		<property name="age" value="42"/>
		<property name="gender" expression="@testBean"/>
		<property name="@testBean2.name" expression="@testBean"/>
	</enricher>

	<beans:bean id="testBean" class="java.lang.String">
		<beans:constructor-arg value="male"/>
	</beans:bean>

	<beans:bean id="testBean2" class="org.springframework.integration.config.xml.EnricherParserTests.Target" />

and put a breakpoint in Target.setName(); sure enough it's called with "male" as one would expect.

Not sure how you could write a positive test to assert this is not possible.
Hello

Yes, I understand.
But just look at this two methods again.
1. `addAll` makes `writeLock.lock()`
2. Than there is a cycle, where is invoked `this.add(object)`
3. `add` also makes `writeLock.lock()`, but it's OK: we already locked it
4. Then in the finaly block `add` calls `writeLock.unlock()` which makes effect for `addAll`
5. We may have a few iterations yet, which may be non-Ordered, so current Thread will be unlocked
Right? Isn't it?
I think the convention we use is to have argument name in single quites (e.g., "'dispositionExpression ' must not be null")
I agree with what you have - it won't break any existing uses. We just need to explain if you use a header and there is none in a message, there will be no delay (without a default).
Good point and I think knowing what we know now we can only throw the ambiguity exception here
Please remove this. Editor-specific files don't belong in individual repos. Add this to your global excludesfile.
please remove this file .. it was only meant for the sandbox to reset the fixtures in case someone broke things via the admintool
OK. But URL still should not be hard-coded but configured somehow. So this still has to be done.
@asm89 the issue is not about the ``null`` part but about the ``OAuthResourceOwnerInterface`` part. You return an array
I feel like this would be more appropriate as a change to the `parameterList` rule. What do you think?
Please use PEP008 styling and use cursor, user, .. like other functions/methods in this module
We can debate whether "Insight webstart" is the right spelling, since it's our name, but even under products it should be "Java Web Start"
@apex13 Can we change this to `create`?
throwing an exception here means that the client of your site is able to break things by passing a GET param.
Latest version includes a `module_spec_helper.rb` file, which requires `puppet_spec_helper` then runs this code
I guess it just doesn't feel very DRY - only thing that is changing btwn these 4 lines is the mapping key and the position
This documentation block must exist directly above `class Iterator`. Can you move it below your new modules.
Should this be #{source}?
This description is redundant with the `@return` value, we should probably make mention of the Javascript event listener API here, i.e:

`Check to see if this object has event listeners added through {@link EventEmitter#addEventListener}`
I have some question about whether or not it's appropriate to fire 'touchstart' along with click events (although this is what we do now that there are gesture recognizers) but that is possibly a regression in the whole system. For now this is fine for consistency.
} else if (minor > o.minor) {
  return 1;
}
link to relevant manual-chapter
Switched out the double quote for single because there were nested double quotes.
assigning anything here is redundant since you assign below ...
Why did you remove "sn-" part of the string?
please use java.util.logging.Logger.log(Level.SEVERE) to do that.
you could use constants for names. no random in test.
`(< 12 age 20)` would be sufficient, as it returns a boolean.
Ympäröivä `if` on tarpeeton. Lausekkeella `(= 0 (mod n divisor))` on jo haluttu totuusarvo