labofsahil/github-event-dataset-2012 huggingface dataset:
Two things:

1. This object is big and seems to contain and arbitrary length array of the albums. Probably worth deleting that field (it's called `entry` -- fucking xml).

2. Speaking of XML, feels like we should clean this object up to make it more JSON-y. Simple improvements would be:
    • Get rid of the top level `$` field
    • `title: "me@email.com"` instead of `title:[{"_":"two570@gmail.com","$":{"type":"text"}}]`, and same for `link`, `category`, and `author`
    • Reformat `user:XXX` field into a top-level `user` field with sub fields
    • Convert single field arrays into regular key-values. e.g. `"rights":["Copyright (C) Shutterfly 1999-2012. All rights reserved."]` → `"rights":"Copyright (C) Shutterfly 1999-2012. All rights reserved."`
    • Convert to real date: `"updated":["2010-01-31T08:00:00Z"]` → `"updated": 1264924800000`
Nope, it's a temporary step until we can get people off the old system.
nitpick: `datalist` should be camelCase `dataList` and also to disambiguate it a bit more from an html5 `<datalist>` element.
this should go in `/app/mulberry/style/_animations.scss`
Remove ``\\ For testing only``
this code is using the API in a way it wasn't designed since it doesn't actually return the query string and returns an object instead. I see why you are doing this however. I think this function can be changed to getQueryInfo() that returns an object. The google closure return type would be:
@return {Object.<queryStr: string, ...}. 

TagHints.prototype.getQueryString will need to be modified as well and then the search() function should take an queryInfo object instead of a string
Could you document the allowed values of ```operation```?  (I'm assuming it's just "sum" and ```undefined``` for now, but that might change down the road)
Are you sure you want to set true in this case? It looks like the value is not yet set.
Yeah, I was debating whether or not this should be added.

On one hand, having an explicitly-declared (and commented) style makes it easier to discover. On the other hand, as you mention, this style declaration is not needed.

I don't feel strongly either way. I'll bring it up in the parking lot today and see if anyone has any opinions.
(same comment applies to line 133 below too)

I think this branch should only accept ```selectionInfo.endCh === selectionInfo.startCh``` if ```startLine===endLine``` too. As is, you get some buggy behavior like this:
```
        if (blah) {
            foo;
            bar;
            baz;
        }
```

If you select from just beneath the "i" in "if" (i.e. 4 spaces to the left of "foo") to just before the "}", the block comment will include the "}" even though it's not in the selection.  Same if you select from just before the "if" to just before the "}'.
please use python 2 here, per PEP 394. The only distro that I've tested that this doesn't work with is debian (ubuntu and fedora worked fine).
Sure-- it would be great if it could go away. It's been in there the whole time, but I was curious about it myself. It's easier to see things after the struggle of getting them to merely work is past.
I think it should be

```jinja
{{ 'now'|date(constant('ISO_8601')) }}
```

You code does not look like being valid (did you try to render the template ?)

Btw, you should remove the spaces around the filter operator to follow the official Twig coding standards: http://twig.sensiolabs.org/doc/coding_standards.html
It's possible. Honestly, I just tried to cherry-pick everyone's commits, I'm sure the individual code can be cleaned up. If you want to, grab my stuff, make a change, and ping me and I'll pull it in here.
Can we at least return some text with this? e.g. "Bad data - check your date is formatted as YYYY-MM-DD, e.g. 2012-05-29"
Oh, of course, because you added another function, yes it goes in yet another level when you have another child. That's an annoying inconsistency that still remains in the code formatting, maybe we'll decide to always indent at that level whether there's a second `var` child or not.

Formatting is allowed to be a little more relaxed in the tests, I don't mind that so much (hence the deeper indenting in places like this function!), I'd just prefer there to be as little noise in the commit history as possible so it's easier to track changes (nothing worse than trying to do a 'blame' when the same line has been simply reformatted again and again in the commit history).
good call. we actually weren't doing that previously so I wrote a function to do that + unit test to check it
Nice functionality, just I would prefer shorter name. Consider usage: UI::Dialog.current_dialog ... I think that simple UI.Dialog.current is better. And maybe we can use better name current is not much intuitive. What about 'selected', 'active' or 'top_level'?
Never ever define classes in Python without extending at least `object`. Otherwise you are defining old-style Python classes which you really do not want to define.
Can't this whole block be simplified to:

    if ( popcornOptions.photsetId ) {
      galleryHandler();
    } else {
      tagHandler();
    }
Kindly remove.
top = Math.max( 0, top );
Needs an `s` on the end.
So when there is no nano on the mix there will be collision....
Try using a case class to label the entries in the map (if possible in Scalding). See for example: http://daily-scala.blogspot.com/2010/05/zipwithindex.html
Ano, o to šlo: "issue" není "chyba", může to být i varování.
I needed to access to dg directly, but maybe it's better to cast in the tests.
I like the icons--they add a lot. However, I don't like breaking it up into columns. The problem is when the text exceeds the width allotted, it wraps to the next line and then it looks weird.

Also, I'd merge the two datetime columns into one column:

    ICON Created: timestamp Updated: timestamp

Maybe also put the permalink on the next line?
Just tested using `lua_isnil(L, -1) == 0` locally, and the unittest still passes.
I might just remove the need for jl_ios_mem to simplify this (i.e. use bare malloc).
So you have removed this bit, but where is it moved to? I mean, we still need Puppet to generate the passphrase file. If it's not generated (present), both Password.encrypt and katello-passwd will fail ("Error: Could not find passphrase file" or something like that).
Named arguments can appear in any order.
actually, not sure that we should?  As its looking a pulp task.  I think it should stay right there.
Although the ES index was being updated by this action prior to the commit, I am curious why it must be done here.  Is this something that cannot currently be done at the model layer?  If not, I'd recommend a comment to document why it cannot be done elsewhere.

Also, is there a corresponding action in an API controller that needs to do the same?
See 7c2be2233dabc1dbf0aa8c25c872a1d52963df1b
It makes me feel a bit uncomfortable because the tests framework will break if we change the behavior of something. I think that will be fine if you check the value of screen.mozEnabled after the click on the HOME button. This way if something has changed in Gaia and the test framework has done the assumption that it is working you can inform the developer of that.
On 19/04/2012 17:47, Ben Francis wrote:
>>     },
>>   
>>     urlBlur: function browser_urlBlur() {
>> -    if (this.currentTitle)
>> -      this.urlbar.value = this.currentTitle;
>> -    else
>> -      this.urlbar.value = this.currentUrl;
>> +    if (this.urlBar.value == this.currentUrl) {
>> +      if (this.currentTitle)
>> +        this.urlBar.value = this.currentTitle;
>> +      this.goButton.src = 'style/images/refresh.png';
>> +      this.goIsRefresh = true;
> Because if the title is being displayed instead of the URL, there's nothing to compare to.

What about keeping the current url as an attribute of the input, like 
data-url?
@wkerzendorf, @iguananaut  - I definitely agree that in general we want to pass back fixes to the numpy/scipy community, but in this particular case, it doesn't nececessarily make sense. The main issue is compatibility: numpy supports versions of python before 2.6, and that's when the concept of Abstract Base Classes was first defined in python (which is what `collections.Iterable` is based on).  So because the meaning of the term "iterable" sort of changed meaning in 2.6, it may be that they need to keep their version to keep some of the numpy internals working.  But maybe that's a question for the numpy people... Here, and it definitely makes sense for us to do it this way because 2.6 is our minimal version.
isset() is always true here. !empty() would work. But this should probably be fixed on a much higher level in ProfileRepository directly, so that this checks don't have to be done everywhere ``$profile['name']`` is used.

I think jeena is a special case, because even his cached profile is messed up.
That was an oversight, I'll make this read chunks and hash as it goes.
Ok. I've reverted it.
I'd be curious to see what happens if you run this experiment on testnet:

+ Create 100 transactions, each with 1 well-aged input and (oh, I dunno) 100 output that all go to the same wallet (100 different addresses, though).
+ Now send them all at the same time.

If the inputs are old enough and large enough, you could perform the above attack paying minimal transaction fees.

I predict Bad Things will happen as the bitcoin process forks 10,000 times.  -blocknotify doesn't have to worry about these issues because we've got one block on average every 10 minutes.

-walletnotify=/path/to/named_pipe would be safer.  Actually, -blocknotify=/path/to/named_pipe might be useful, too...
ok, changed (although I'm fairly certain it was better before this change).
Missing spaces after `,`.  Please use the code sniffer for these types of errors.
I don't really see the point in separating string/array if the index/slice operators work the same on them.
This is the part I don't understand.

<li><p class="first">Set your web server's document root to <tt class="docutils literal"><span class="pre">/path/to/phorkie-0.2.0/www/</span></tt></p>

Then next line produces:

<li><p class="first">Set your web server's document root to <tt class="docutils literal">/path/to/phorkie/www/</tt></p>

Where did the span go?
Not sure I follow you? Before you switch to the popup you store the handle, then use that to switch back. There's no assumptions here afaict.
Typo here on "people"
Well, I think the cleanest solution here would be to catch this condition during validation. Of course, this is an entire new can of worms, but at least with a validation rule, you could give the user meaningful feedback
Are you sure no simultaneous calls will be made to this method? Otherwise, selecting a pseudo-random name for the temp file might be safer (`Guid.NewGuid().ToString()` or whatever)
No, but I don't think this test should actually fetch the image - it's just preparing an HTML `<img>` tag.
The `break` here is techincally redundant, but I'll leave it for clarity... Mergning now. Thanks!
Why the explicit call to list here? map always returns a list, so I'm not sure why you need this one...
Done.

On 8/5/12, Fernando Perez
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,88 @@
>> +"""Display classes for the XTK JavaScript library.
>> +
>> +The XTK JavaScript library uses WebGL to render 3D visualizations. It
>> can
>> +generate those visualizations based a range of standard 3D data files
>> types,
>> +including .vtk and .stl.  This module makes it possible to render these
>> +visualizations in the IPython Notebook.
>> +
>> +A simple example would be::
>> +
>> +    from xtkdisplay import Mesh
>
> This should read `from IPython.lib.xtdksiplay...`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/2258/files#r1308432
>


-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
I'll make the change but I can see this becoming a pain for people consuming the builder.  I mean, you have to check the value you're passing into the builder method before you call it.  For example, I backported this request to the GetMetricStatistics and ListMetricOptions classes and because of this, I had to rewrite CloudWatch.listMetrics so that it checked namespace/metricName/dimensions/nextToken before using the builder method.  So a single chained builder usage now becomes a multi-step operation.  My original thoughts were to make using the builder effortless and let the build() do the real validation.  If any of this changes your mind, let me know and I'll undo my local changes.  Otherwise, I'll keep what I have and update the pull request.
rename to VSphereProperties
values here should be moved to ApiMetadata.
there is an identity. In google's case its the account number email.
my question was related to the "oauth.credential" property and the use of file credentials. Specifically, I was wondering if, in the case of using file-based credentials, such as pk's the *.credential property would store the path to the file.
The current ctor args are:

@Identity String identity,
@Credential String keystorePath,
@Named(PKCS_CERTIFICATE_KEY_NAME) String keyName,
@Named(PKCS_CERITIFICATE_KEY_PASSWORD) String keyPassword
The algorithm description in wikipedia mentions that "The algorithm terminates when no more augmenting paths are found in the breadth first search part of one of the phases."  And this is represented in the pseudocode via "repeat ... until P is the empty set".

I don't see the required looping here.  Did I miss it?
If you tell it it's both a local and a remote-tracking branch, you've failed so you get no love from the code :p

I have to wonder what your plans are for remote-tracking branches. You (as the user) don't create them or are able to do much with them. It's fetch and push that modify them and trying to do so anywhere else is probably a bug.
I don't think there's any non-ASCII characters in there but for sanity, we should use UTF-8.
One interesting thing to note is that 8 lines below this one is an implementation of ``helpful_vote`` which looks like what you might want. It doesn't do anything based on the revision, though.

Also, now that I'm looking at this code, it's kind of lame it doesn't handle the revision_id case correctly. That's true of all the model makers in this file, though. The ones in apps/questions/tests/__init__.py do. That's just a side remark, though--I wouldn't change it as part of this pull request.
Again, i'd like to suffer the delusion that we will have less than 9,999,999,999 candidate credential sources. I'd be fine with unsigned tinyint(3) for this.
Should use a template here as well.
Ya, I think it's a change required in smartmin.


On Thu, Nov 8, 2012 at 1:33 PM, Nic Pottier <notifications@github.com>wrote:

> In jukebox/users/views.py:
>
> > @@ -28,3 +52,47 @@ def post_save(self, obj):
> >              obj.groups.add(group)
> >
> >              return obj
> > +
> > +     class Forget(SmartFormView):
> > +          form_class = UserForgetForm
> > +          permission = None
> > +          success_message = "An Email has beeen sent to your account."
> > +          success_url = "users.user_login"
> > +          fields = ('email', )
> > +
> > +          def get_success_url(self):
> > +               return reverse(self.success_url)
> > +
>
> I don't think so.. it should only require an object if you are using a URL
> in the form 'id@users.user_update'
>
> You should be able to set the success URL to @users.user_login as it is in
> the view above.. if not then we should fix that in Smartmin.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nyaruka/jukebox/pull/6/files#r2068071>.
>
>
I discussed with Lance. The problem is there were 3 sign in links on the page, all of which were being coded to display the dropdown from the top nav sign in button. This button on the right column got kind of covered up by the top nav dropdown, and it looked weird, so we decided to get rid of this one.
After cloning your fork I just did `bundle install && rake test`. Some unrelated tests were skipped, but Stylus one were executed since `stylus` is on the Gemfile. You could try that and see if it works for you.
in case you're curious, we found a weird & interesting bug in this back in September.
http://code.google.com/p/google-gson/issues/detail?id=440

(with no reasonable resolution)
should be `this one returns`.
``break`` is useless here as it will never be reached after the exception
@Tobion to make it clear, is it required that all this char list is not encoded or is is only to generate URL that are easier to read ? (I refer to all the chars excepting "/")
I totally agree with you. Of course I will *not* let this code in place.

So for now, i will duplicate the factory ..
extending Traversable makes it impossible to mock the interface directly. Is it impossible to make it extend either Iterator or IteratorAggregate ?
what is the goal of this class ? And why calling it Service ?
Added relevant information regarding the double bitwise not trick.
UI changes have also been tested in iPhone 5 simulator to be safe? Should be fine since it looks like all of your changes were to an individual cell.
Not sure but it seems like the indents are off here.
Yep. We can add ````Yam.post_activity(params)```` after we integrate with the Yam gem.
Ah, that makes sense. I saw the before filters in invitation controller and got nervous we had left these guys open. They can be removed.
Что за компаратор?
Don't want to create cookbook attributes for these w/ a toggle? As we did w/ the slowlog configuration.
Using the word `green` is somewhat confusing - it's more of a grey/beige.
For future reference, this looks like a behaviour change.
This could have been combined into one if statement...I believe.
This function is racy. If I understand right, this function is called and then the notification chan is received upon. Another gororoutine might receive on that chan in the meantime, flushing out the desired list.

I recommend giving InstanceListener a .List() method that returns a []*Service, and having a separate means of communication to the InstanceMonitor's mux(). Something like:

func (il *InstanceListener) GetInstances() []*Service {
  ilq := InstanceListRequest{ // a new type
    Query: il.Query,
    Results: make(chan []*Service, 1),
  }
  // a new chan in the monitor
  il.monitor.instanceListRequests <- ilq 
  return <-ilq.Results
}
Did you consider using something like a small (Modernizr)[http://modernizr.com/] build for feature detection?
嗯，加载更多其实可以通过一个delegate的方式加在UITableViewController上，以后慢慢重构就好了
Here, rely on Pimple service ``changelog``
BTW, changing the exception type and moving the method to EjbMessages has no impact on the domain test failure.
These statics worry me, it looks like this won't work with :reload operations?
This is a change in a public API, so the old variant needs to be preserved.
No, you're missing a space after the `if`.
thanks @samccone :squirrel:
is just like an small titles for explanation stuff and the are being used in the same way for all the BB,  we are using a classname for do not match any style inside the BB
should `build/settings.json` be part of the repo?
This header will change completely (check Wireframes and Transition document). That's why I've removed it.
What a good question :D, i used to see it, but seems to be some legacy stuff! i will change to h1
Same as in threads execute method.
While the gelam changes are good, just so we're on the same page, these need to be made as a pull request to gaia-email-libs-and-more in data/lib/mailapi/mailapi.js and then propagated across by using the "make install-gaia-email-opt" target.
You really want to return the entire `startup()`?
To insert white spaces after the contact name or number and the number of calls in the group as requested by the UX team, see https://www.dropbox.com/s/oy8vyb86v57rztm/CallLog_vpg_0000_a.png
I might be wrong here, but I tried without anything being done on submit and nothing seems to be broken?
But I may have missed the case where something goes wrong... 

Note that there is something weak with these change buttons.
We are only registering click/change listener to all `#xxxx-configuration` elements.
But these `<button>` elements aren't child of `#xxxxx-configuration` elements!
Buttons appears on top of `#xxxx-configuration` because of the usage of `float: left`, but events shouldn't go through them.
A click event should fire on buttons and form submit should be dispatched as well.
Actually, you can see the top change button failing sometimes, but not always. And when it fails that's because it behaves "correctly": the button eats the event and nothing happen.

With this patch, the event is still eaten (sometimes only) but nothing wrong seems to happen.

Even if that's not the purpose of this bug, I can add listeners to change buttons and try to fix that intermittent failure?
that can work also, if you are happier with that approach I'm fine
same comment as with timezones
Which is the problem we have with applicationFilePath(). I tested the declarative booster, at least, and it has applicationFilePath() as applauncherd.bin, but arguments()[0] is correct with and without using invoker.
Just delete, or maybe put inside an "if self.DEBUG:" block or something.
Oh yes, I can see this making sense in the context of concurrent request, thanks!
QGIS_FW_SUBDIR_REV is not not far enough up the directory tree for a relative path from the ATLOADER location of a binary in a framework.
That's an eventmachine bug. See
http://stackoverflow.com/questions/6927907/ruby-problem-installing-eventmachine-under-windows-7


I'm fixing it now (by upping the version of eventmachine to "1.0.0.rc.4").

Now rackup works on Windows; "rake spec" and "rake run" still fail for
silly reasons which I will fix later.
Hooking into `included` seems a bit indirect compared to using a shared context.  What do you think about this?

``` ruby
shared_context "isolated directory", :isolated_dir do
  tmp_dir = nil
  before { tmp_dir = Dir.mktmpdir }
  around { |ex| Dir.chdir(tmp_dir, &ex) }
  after { FileUtils.remove_entry_secure tmp_dir }
end
```

Then we can just tag the example groups that need this with `:isolated_dir`.

I like that this uses the block form of `Dir.chdir` to transactionally change the current dir, too.
Unindent parameters by one level (see [numpy docstring standard](https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt#sections))
yes, your idea will make IndexedSeqSemigroup semantically  identical to IndexedSeqMonoid, which means we can replace IndexedSeqMonoid entirely with IndexedSeqSemigroup (since it no longer uses zero). I'll do that on the train ride home today.
Yeah, the case for non inproc enpoints should be fixed too - perhaps in another commit.
As for the errno value, I would prefer ENOENT.
Need to work on the wording here and on the app name in general. "Associations" is a classic horrible name for an app or variable. Completely ambiguous. You'll want something more specific and descriptive (eg. "Open Enhancement Requests", "enhancement_tracking", "Enhancements Requiring Notification", etc). The labels should be from the user's perspective and talk about what they actually want to use this tool for (tracking product enhancement against customer requests and then notifying customers upon completion).
sorry type error should return session
So this means buildname is not a key anymore? is it still unique?

I would personnally prefer using string as a key for high level API in order to stay more user-friendly.

data api will be 1:1 with json API, thus used by people in scripts, so I'd rather prefer string identifier instead of ID.

Actually this comment is true also for masterid
Should consider byte order,  how about using CC_SWAP_INT32_LITTLE_TO_HOST to do it?
All our examples use dashes in project names, so this example shouldn't use a dot.
I think I'd prefer to specify here if a reference or comparison screenshot is taken, the current behaviour, although it's the DRYer approach, is a bit too much, "you have to know how it works" for my personal taste since `ensure_screenshot_location` sounds like `ensure_screenshot_location_exists` to me and less like a setter to me. This does resemble in the actual feature, if you ignore the scenario description, the difference between the two seems totally opaque to me.
I removed the line "left: -9999px", I didn't see what it was good for, anyway it hide the textarea
What's a shit? Where is "condition: qbs.targetOS === 'windows'"?
message and details aren't defined for a ping. I think you should only add those if the result is a checkEvent.
@randx is this the correct fix, when the `core.sharedRepository` setting is missing from repos?
It was in a `if` or `else` statement, then? I see. But I thought that `httpd.js` wasn't in Strict Mode.
Hum I forgot about similar exported methods `resolve` and `reject` ...  they are identical the these methods but with the high level API, right?
"You can use as many email addresses as you want, but you still only need one password" isn't totally accurate -- Gmail, Hotmail, Yahoo, and folks with addresses at native Identity Providers will all need to have one password per email address. I'm not sure how to say that in a user-friendly way, though :)
Seems like this docstring may have been copy-pasted and needs updating?
I realise that. You can set the filename property before you do that, and then you don't need the 'release' property or the condition in the 'build' target.
Un l ou deux l ??
```php
<?php
public function getIterator($con = null)
{
    $res = $this->find($con);
    // the rest
}
```

The user can't pass the connection when calling `foreach`, however the signature makes it obvious that this method executes a query.
This, also, should call the newly created method.
@daniel-pittman previously we were either setting the default_mode or the masked mode, but now we are effectively calling `set_mode(get_mode())`. This should do the right thing, but because of how we map "out-of-band" sids, the mode as returned by `get_mode may` be of the form `0200XXXX`. I'm nearly positive `set_mode` will do the right thing when called with such a mode (ignore the higher bits), but it is different behavior than before...
I considered that, but I wanted to leverage Javascript's internal methods for capitalization due to edge cases with foreign alphabets:

`'cigüeña'.toUpperCase()`, for example.

It's possible to make a regex that covers most of these cases, but I felt it might be better handled by Javascript itself.
Whoops - saved by implicit declaration.  I'll have a fix up in a minute.
If you want a Http Schema you can instantiate directly Zend\Uri\Http
If the controller returns a custom response object (e.g. return new StreamResponse), the wrong (old one) response object is registered in Zend\Mvc\Application and Zend\ServiceManager\ServiceManager.
When I try to create the correct response sender object, it would get the wrong response object injected.
Not sure if this is OK?
remove the _ -- with some optimizations we're trying, this may cause issues.
War doch gute mit dem Interface?!? Warum in User geändert?
crossroads.js provides a server-side routing mechanism. Meteor currently doesn't allow server-side rendering (it's coming), instead it compiles and ships all templates to the browser on the initial request... such an approach is far from appropriate for big prod apps, but this is the current state...

considering the current state of Meteor, the only thing we can do is client-side routing... as suggested, this could be achieved with backbone's router or any other third-party libs such as director (https://github.com/flatiron/director)... i don't mind to implement both...

what i see is that modern web applications shift away from the traditional request/response principle... in my opinion, modern web applications will process the initial request by rendering the initial page on the server, adhering to the request/response principle..., everything else will be non-request/response based, meaning presentation, logic and data will be shared in an asynchronous way (i.e. using sockets), but apps still have to support request/response for an arbitrary page to spport search engines (but crawlers will get smarter as well). in this world, server-side routing is not dominant any more, responsibility in regard to presentation shifts to the client... i bet Meteor will go this way so do other web frameworks as well... 

to sum up:

1.) to keep up with this trend, i suggest to replace crossroads.js with a server/client-side routing mechanism such as director in order to support more use cases...

2.) i am fine with the current version of TodoMVC on Meteor... Meteor is rapidly changing and improving, so does TodoMVC on Meteor need to be improved over time as well...
Does this also change the site on organisation pages for organisations that are joining?
Removed in upcoming PR
@samiluukkonen Onko tämä sitä varten, että laskutus lisää ton saman kommentin muuten toisen kerran?
2.0.* is not enough either. Doctrine is fully compatible with the upcoming 2.1 component (as there is no BC break in the Console component) and requiring the 2.0 component would forbid using Doctrine master with Symfony 2.1. And anyway, it should not be a hard requirement here. The explanation about the strict constraint was mainly about educating.
Missing line break after
this should not use ``else`` as the ``if`` returns.
Yes I thing for consistency we should return atoms in this case. Thank you
for catching this.

Best regards,
ILYA

On Thu, Aug 30, 2012 at 8:10 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/module.ex:
>
> > @@ -462,6 +462,52 @@ defmodule Module do
> >      end
> >    end
> >
> > +  @doc """
> > +  Split the given module name into components.
> > +
> > +  ## Examples
> > +
> > +      Module.split_name Very.Long.Module.Name.And.Even.Longer
> > +      #=> [Very, Long, Module, Name, And, Even, Longer]
>
> The current implementation is actually returning a list of binaries or a
> list of lists. Should we return atoms?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/446/files#r1497661>.
>
>
escalus:assert(is_error, [<<"cancel">>, <<"remote-server-not-found">>], Stanza)
why not using $(use_with hepmc hepmc "${EPREFIX}"/usr)
same thing for lines below
https://github.com/gentoo-science/sci/blob/master/skel.metadata.xml
lines to long here...
Hi there,

On Tue, Sep 25, 2012 at 12:01 PM, Kenneth Hoste <notifications@github.com>wrote:

> break description into shorter lines
>
Done and even a new version 5.0.1 has been added;
feel free to drop the previous version, perhaps it is better do so.

I suggest you treat packages mentioned in this list
https://github.com/hpcugent/easybuild/issues/236
as high priority for the Supercomputing 2012 audience.
(there is a reason they are part of DoD HPC Baseline Configuration!)

cheers,
Fotis
fix sanity check paths
introduce more functions? this main function is getting pretty big now...
As discussed on IRC, this will be fixed in another pull request.
This was why I liked linking to the instructions in one file. :-)
We should not commit this file because its possible for someone to accidentally to push their password to github unintentionally.

The better route might be to just improve the error message when this file is missing.
Is there need to add it to the disabled list?

Won't changing `LOWEST_APPROVED_SDK` to 1.8.2 be enough?
extra parens not required here, though I guess they're more explicit.
We dropped linear-gradient prefixes in Firefox 16. I believe we should keep these in for now, but should be removed in the future.
Not that we're particularly likely to have blank categories, but we should cover our bases and have some placeholder text that appears when you click on the faq.title of a blank category -- that is, instead of displaying <li><a href="">Question text</a></li>, it would display <li>There are currently no questions in this category.</li> Otherwise, clicking the title will display an empty ul with no li children, which is less than ideal. Displaying text will let people know that everything is working fine; they didn't misclick or have a javascript hiccup that caused blankness to happen.
Agreed. 

Sent from my digital shackles. 

On Mar 26, 2012, at 10:31 AM, Nirmal Ranganathan<reply@reply.github.com> wrote:

>>             "ips": [
>>                 {
>> -                    "address": "10.0.2.16",
>> +                    "address": "10.0.2.16", 
> 
> Yes... I tried to do this the first time I updated examples and have given up since... wasn't able to fix anything within out code... cos all we are calling is the json prettify stuff, don't want to spend the effort digging thru that.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/430/files#r603560
Please add tests for this new behavior, and for the public `cygwin` method. Thanks!
The class "UsageTrigger"
I think this should work fine, but you might want to combine this loop and the previous one. Also, ```if (newItem.creators[i].firstName.length<1)``` seems unnecessary. Why not just check ```if (!newItem.creators[i].firstName)```?
```i``` -> ```var i```
missing one _e_ in the word "the"
@Gankro to simply the function a bit (and to facilitate serializing Blob URLs, which don't matter as much). I made the if statement construct its text into a local variable that gets appended later. This is just fixing a place I forgot to switch it over.
Yup, I'll remove that :P
maybe add <code> around + and -?
I forgot to comment on this. The format for the dj lines are not IRC hostmasks, though they sure look like it.

The format is:

`name!name@db_username`

So, if you do a call to `.dj` in the IRC with "name", it will look this up in the file and set the DJ to the user with username `db_username`.
It's possible to have asterisks as wildcards in the name entries. Here's an excerpt from our file (called dj.conf, by the way):

    egg*@eggmun
    hipster*!ekureiru*!eclair*@ekureiru
    hiroto*!chitose*@Hiroto
I'd prefer to use "language" in full in the URL patterns. Do you mind making this change?
By the way, thanks for adding sortable to cols. Exactly what I needed for an action column. Now if we can just get Eric to pull in your changes and keep this going.
YouUsedCamelCaps up to this point - why suddenly switch To_Using_Underbars_Too?
If you would like to use this `gravatar_url` helper, could you instead just make it a wrapper around the existing `Gravtastic` functionality? i.e. just have the `gravatar_url` method render an image tag similar to this:

``` ruby
image_tag(player.gravatar_url(:size => size),  :size => size)
```

Let me know if I haven't been clear enough here
Previous experience. But it's a couple of years back so things could have changed. Values too small could cause an overhead while larger values could block the thread. I think we can leave it for now and figure out performance improvements later.
Yup, that's a bug.
I think this needs an array somewhere as well to test for successful extending.
This one can be `...del('/api/content/:contentId/comment/:commentId', ... `
옵션이 올바른지 있는지 없는지를 여기서 체크하는 건 좀 아닌 거 같은데? 이런건 Option 내부에 숨기고 밖에서는 Option이 넘어왔는지 안넘어 왔는지만 확인이 되야 되지 않나?
Make sure to first create the Actor instance, and start it after the object has been fully initialized.
This indeed worries me: A full project index for a non-trivial project can take minutes. While this can be overlooked in an individual refactoring, in a framework class that is intended to be used by many other refactorings this is very bad. 

You need to at least defer this decision to subclasses of `IndexedIdeRefactoring`, so each can decide to be slow on their own. :)
For instance, we use that listener for triggering project's re-built https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaPlugin.scala#L272 (maybe you'll find the example useful...)
How do you know that the part that was closed is exactly the one that you are removing? Why isn't `if fileEditorInput.getPath == scu.getResource.getLocation` needed anymore?
why not select only `not` disabled fields? Would make the check and the error message simpler :sheep:
Sirkitree,
Yeah they work. My only problem is that I couldnt get AJAX to work(I am
pretty sure that I cannot, so need some HELP!!).
But I think that, there is a small logic that I am missing. I want you take
a look at that.

On Tue, Oct 16, 2012 at 3:50 AM, Jerad Bitner <notifications@github.com>wrote:

> In smackdown.js:
>
> > @@ -20,17 +20,15 @@
> >    Drupal.behaviors.smackdown = {
> >      attach: function(context, settings) {
> >        if (typeof Drupal.settings.smackdown !== 'undefined') {
> > -        var field_1 = '.field-' + Drupal.settings.smackdown.field1.name.replace(/_/g, '-');
> > -        var field_2 = '.field-' + Drupal.settings.smackdown.field2.name.replace(/_/g, '-');
> > +        var field_1 = 'field field-name-' + Drupal.settings.smackdown.field1.name.replace(/_/g, '-');
>
> Ah, I see what you did - you changed the selector in the attachVote and
> attachNotice functions below to look for this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sirkitree/smackdown/pull/8/files#r1848259>.
>
>
oops - updated, thx
1) percent у вас не проценты, а количество элементов. Максимальная длина цепочки ДНК может отличаться от 100.
2) Попробуйте передать в эту функцию число 101 и получите бесконечный цикл.
вот здесь вы явно пишете count, когда в задании требовалось задавать в процентах. Путь в данной задаче это одно и то же, но по факту при масштабировании это всплывёт.
p - процентный показатель, а не количественный. Это нужно учитывать.
"А" может замениться на "А". И замена по сути будет бесполензной.
Задание выполнено не полностью: из 5 пунктов выполнены только 2. Я бы оценил вашу работу на 4 балла из 10. Пожалуйста, сообщите, будете ли вы доделывать задание. 

Удачи!
This will restore the window rect, but doesn't restore the maximized flag or the "normal" size. If you maximize the window, quit, then restart, the window size is set to the maximized size, but it isn't maximized (and, at least on my Win 7 machine, the top of the titlebar is a bit off the top of the screen). You may need to use GetWindowPlacement/SetWindowPlacement and save/restore the whole WINDOWPLACEMENT structure.
Saw it done like this throughout `RACSubscribableProtocol.m`, thought there was a reason for it which I couldn't figure out.
I'll change it for now, I'll just change it back in case there actually is a mysterious reason after all. :ghost:
Can you please change this test to only send completed _after_ error (position-wise), and then add a separate test to make sure completed is sent at the correct time (with no zipped errors)? I think that'll make the intention a lot clearer.
These first two streams are used in multiple tests. It'd be nice to factor them out into a `beforeEach` block.
Let's make this DRY.  
```
String url = mStep.getEmded().getOembed().getURL();
mMainWebView.loadUrl(url); 
mMainWebView.setTag(url);
```
I realize this was already in this form, but expand this to an `if`.
Doesn't this function just return a randomly selected epoch?
Fine I can suffer through it :)
Add a test that checks the case of not passing a filter which returns multiple news items, and check the structure of the response.
Should we document the `_all` option?
It's a convention that isSomething should be returning boolean and getSomething should be returning Boolean. I know it's wrong in other places in this class, but let's do it right for new code.
Ok, that is reasonable.
Yes, that's it. But also you'd think wmd you just not do anything if the element you're giving it doesn't exist...
I'd make 13 a var somewhere instead of using a magic number
Good point, updated, thanks.
You  don't need to instantiate this if we're not going to use it later.
Sorry I meant equal not eql. Man to many different words to say the same thing :laughing:
Keys shouldn't be equal to the English text, they should represent the purpose of the text. In this case, I'd use `platform.faq.search.questionHint`.
done.  This was fun.  I have used both options and eithers, but never together.  Is there a nicer way to express this?

if (connectionStatus.isEmpty || connectionStatus.get.left.toOption.map(!_.isOpen).getOrElse(false))
Thanks @exviva ! I'll fix it and send a PR ;-)
А, едрить. Тогда переименуй `manager` в `managerDialog`, что ли.
Ok.
Add several checks for all yours variables before using it.
It may be worth refining this assignment so that it only overwrites `window.allowSave` if it is not already defined:

```
window.allowSave = window.allowSave || function()
```

This then allows people to insert their own `window.allowSave` function, as long as it is above the main core code block in the TW file.
why do not remove (null) default value and check every caller
anyway later : in_array(..., $wanted_subdefs) with $wanted_subdefs=null...
please revert this blank line and the other one
This should be a private (prefixed by "_")
Don't use spaces after the function keyword in an unnamed function (to keep in sync with the style used in the project).
See design document https://community.jboss.org/wiki/Infinispan60-MapReduceEnhancements for details
I'm not sure if this is going to have a visible impact on perf, but we're going to have three extra thread-local accesses (add DEFAULT_LIFESPAN, add DEFAULT_MAXIDLE, remove the thread-local) for every `put(k, v)` call.

If possible, we should replace the thread-local with a decorator like we already do for `CacheImpl.withFlags`, or maybe just add overloads in OperationsFactory that don't take lifespan and maxidle parameters.
.ravel() flatten things out, iirc.
I will do it. I promise.
I would think the docstring three lines above is good enough, but perhaps it is not.
Perhaps change the name to <code>get_random_indexes()</code>
s/alarams/alarms
Зачем $e в строку оборачивать?
Created branch remove_filercss on the lunchbox repo
just call it ``matches``?
Why?  Not arguing, just wondering, since it will add an extra step for
every pull request -- of which there are many right now.

On Sat, Jul 14, 2012 at 8:42 AM, Aaron Steele <
reply@reply.github.com
> wrote:

> > @@ -9,8 +9,8 @@
> >    :jvm-opts ["-XX:MaxPermSize=128M"
> >               "-XX:+UseConcMarkSweepGC"
> >               "-Xms1024M" "-Xmx1048M" "-server"]
> > -  :plugins [[lein-midje "1.0.8"]
> > -            [swank-clojure "1.4.0-SNAPSHOT"]]
> > +  ;; :plugins [[lein-midje "1.0.8"]
>
> Sounds good. Let's keep it uncommented in the repo though, and then
> comment locally as a workaround until we fix this thing. Maybe?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/98/files#r1164114
>
Why do this for non-ec2 clouds?
dateutil contains a very good datetime parser that undertands all the
possible formats that can appear in an XML file: In UTC, with a timezone,
year first, etc.

Maybe there's an already-included way of doing it, but I was unable to find
it. A simple regexp works for GPX because that format is much more strict
about its datetime format.

If you prefer to avoid adding a dependency, I could try a more complex
regexp, but given the quantity of date formats I'd prefer to reuse an
existing solution.
El 03/05/2012 23:34, "Robert Bruce Park" <
reply@reply.github.com>
va escriure:

> >  from gi.repository import GdkPixbuf, GObject
> >  from re import compile as re_compile
> >  from pyexiv2 import ImageMetadata
> >  from time import mktime, clock
> >  from calendar import timegm
> > +from datetime import datetime
> > +import dateutil.parser
>
> `dateutil` is a new dependency that I didn't even have installed on my
> system. Can you tell me a little about this? Was it necessary? Is it faster
> than it's alternatives?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/robru/gottengeography/pull/48/files#r771034
>
Fixed. Will submit a PR to Hilary as well.
Mention that `make-hash` creates a *mutable* hash table
This is related to the comment below. The callback should return the Option already instead of being converted implicitly.

Otherwise the LazyOption is really a nice addition.
does that deal with negative indices?
I didn't find any way. Let me know if you prefer to have a new pull request, if you cherry-pick what you find reasonable or whatever.
In case of .preview-mode-selector there is a reason for that - but in the other two places there is not. Fixing where we can, and commenting otherwise. https://gist.github.com/99c8b9ab0f7735ae0c3a
у нас приняты отступы в 2 пробела
Travis.config.host is dynamic, defaults are static. I think that would be a chicken/egg thing.
This the code that is supposed to handle applications setting truncate cursors to reference implicit or non-existent records, but this time for tables.
Hi Michael,

This change looks good. It should please go ahead and merge.

- Alex

On 02/08/2012, at 10:30 AM, Michael Cahill <reply@reply.github.com> wrote:

>> -	const char *cfgs[] = { cfg, NULL };
>> -	return (__wt_config_get(session, cfgs, key, value));
>> -}
>> -
>> -/*
>> - * __wt_config_getones --
>> - *	Get the value for a given string key from a single config string.
>> - */
>> - int
>> -__wt_config_getones(WT_SESSION_IMPL *session,
>> -    const char *cfg, const char *key, WT_CONFIG_ITEM *value)
>> -{
>> -	const char *cfgs[] = { cfg, NULL };
>> -	return (__wt_config_gets(session, cfgs, key, value));
>> +	else if (cfg[2] == NULL) {
>> +		int ret = __wt_config_getones(session, cfg[1], key, value);
> 
> This is the key part of the change -- just parse the application's config string because we know that the default is zero.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wiredtiger/wiredtiger/pull/280/files#r1289196
The "transactional" config key was already in the API -- this change made the code match what was already documented.

I don't feel strongly about this today: as you note, there is no runtime overhead at the moment for enabling transactions.  That said, I don't want to change the API in incompatible ways later when we need to know whether to deal with log files and run recovery.  On the other hand, once we have a transactional log, we can't ask users to configure "transactional" every time they use a utility.

There is also a product issue: if we ever want to distinguish between transactional and non-transactional use when negotiating a license fee, this would be the place to do it.

One option that did occur to me was to make the flag default to on, so that applications that want to disable transactional support would have to call that out.  That would still give us one place to look when working out what kind of database we're dealing with, but doesn't create extra work for applications.

What's your preference: how do you think this should work once we have durable transactions?
Does it make sense to use a flags here? It seems to overlap with the WT_EVICT_CLEAN/WT_EVICT_DIRTY flags that are local to bt_evict.c at the moment.
I like to debug in the master.
On it in a separate branch.
This is not clear. Where does magic number 1e-5 come from?
Are you sure ``$currentEvent`` has the correct type as ``*`` is not a sub-type of ``object<Zend\Stdlib\CallbackHandler>``?
I agree. I plan to make "Canaryfile" configurable. 

Allowing a list of ignored files is a good idea, I'll add that as well.
Hey, I meant for my forest to be like ye olde forest. Yours is a jungle.
null ist ja immer der Rootnode und sicherlich kein Beer.
Aber du hast recht, werde es zu -1 ändern, sieht besser aus :)
Das müssten wir dann noch als Flag im Domain- und DBModel einfügen, oder?