labofsahil/github-event-dataset-2012 huggingface dataset:
Probably so, but it could depend on the scheduling of the OS TCP
stack. I.e we want next tick to fire after the server has accepted the
connection, sent the data, and our calls to read occurred. Only the do
we know we are blocked on read and not on open and that there is some
data buffered. Not sure  next tick can guarantee that.

On Jun 10, 2012, at 12:07 AM, Ilya Grigorik
<reply@reply.github.com>
wrote:

>> +              EventMachine.synchrony do
>> +                EM::start_server('localhost', 12345, SendAndKeepOpen)
>> +                @socket = EventMachine::Synchrony::TCPSocket.new 'localhost', 12345
>> +                @socket.read(2).size.should eq 2
>> +                @socket.read(1).size.should eq 1
>> +                EM.stop
>> +              end
>> +            end
>> +          end
>> +          context 'with less than the requested data buffered' do
>> +            it 'blocks' do
>> +              EventMachine.synchrony do
>> +                EM::start_server('localhost', 12345, SendAndKeepOpen)
>> +                @socket = EventMachine::Synchrony::TCPSocket.new 'localhost', 12345
>> +                @blocked = true
>> +                EM.add_timer(1) { @blocked.should eq true;  EM.next_tick { EM.stop } }
>
> Instead of relying on a timer, in theory EM.next_tick should give same behavior within test (and coverage). No?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/igrigorik/em-synchrony/pull/127/files#r956635
Let's add a link to the sugar documentation here. You can do this with syntax like this:

[Rcpp sugar](http://cran.r-project.org/web/packages/Rcpp/vignettes/Rcpp-sugar.pdf)
So this is an interesting thing, because while Popcorn uses that spacing, Thimble doesn't... We can use the Popcorn-style spacing for this project but it would be good to settle on one for all cross-mofo thingys.
You're using bridge in entries before and after.
nit: space after ":"
No, get content of `description`. Without tags around. There is probably some function for this?
I would suggest that you peek at [tests](https://github.com/mitar/django-tastypie-mongoengine/blob/master/tests/test_app/documents.py). :-)
You had:

```
$('#post_text').click(function () {
```

But click event handler gets an argument, so it should be:

```
$('#post_text').click(function (event) {
```

The point why we would do like this is that in most cases somebody reading the code after you don't know what all arguments are possible there. You know, because you wrote the handler. But later on it is really hard to remember. And then sometimes you don't know how to do it because you don't see that some variable is available to you.
I dont know why, but everytime I copy paste I lose indentations :S
Why is `<br/>` needed? In general this is something which is related to design. So you can do that with CSS. Probably you just want one div around and it will be same effect?
Ehm, you construct string from parsed values just to parse it again?

I think `datetime.datetime.date(year, month, day)` would be enough. Just get year, month, and day values.
Please always write all arguments function can get. It does not get `error`. You can use something like:

```
    $.ajaxSetup({
        'error': function (jqXHR, textStatus, errorThrown) {
            // ...
        },
        'timeout': 5000,
        'traditional': true
    });
```
isinstance allows a tuple of base classes to be passed as the second argument (i.e., you could write `isinstance(summary, (list, dict))` ).
Need to fix the indentation here; no tabs.
IE8 fox
Same as above.  Isn't it a rogue file?  I see no reference to it in any nova recipes.
After these changes do we need to pull in truncation for anything any more?
If you already have it in mind that you want to manage gemsets externally I can see that, but it actually does more than what you say.

1. Creates  a gemset if you want one
2. Installs bundler & rails into that gemset
3. Runs rails new with the -T option specifically to prevent generation of test-unit garbage
4. Creates an .rvmrc for you to use the new gemset.

If you're concerned with having a pristine gem environment the wrapper helps make sure that happens.
The original purpose is simple to keep the code clean and well understandable to myself first. They are actually notations from a scientific paper discussing about Minkowski Functionals and some of their names are actually long, such as "integrated_extrinsic_curvature" 

It might not be a good habit, but I actually preferred to add some comments in the code and use short standard notations instead of using the long name which is still only understandable to a small number of people.

Anyway, I will make the changes.
Unfortunately we need to turn these AssociationKey's into a DBObject in order to query the database, or store them, and DBObject extends LinkedHashMap. The inner objects are also DBObject, so more HashMaps. I can't see much of a way around this.

Regarding a map implementation over the top of it (which we could pass in as a DBObject constructor), this would end up being copied too unless I'm not mistaken.
some comment on this version and all those following below..
Python 2.5 is the minimum version for Django 1.4
or 'json'?
Unfortunately that's not possible with Jackson, you can't specify how many spaces you want used when indenting. The only way is to use this as a simple on/off flag.
this arg was initially named *force_respawn*, but it didn't feel right, and we didn't find a better name...

self.respawn (on a watcher) is True by default, so the default behavior remains unchanged: if self.respawn, then (re)spawn processes if needed.
However, if self.respawn is False, then check if the arg is True, and in this case only, (re)spawn the processes.

If the watcher.respawn is False, then processes should only be (re)spawned when explicitly asked (on a start() for example), not on each call of manage_processes (which is called periodically).

So, I guess this boils down to: what should the name of this argument be, to make it clear? Is *force_respawn* better?
refer to config.py line 233
1 function?
Kinda easy to figure out where, but alright. :)
Except its not - its only called from GeoSphere.cpp. Am I missing something?

In any case, I think it belongs in SystemBody. I'll move it now.
github messed up my code:
\<img class="MyMenuIcon" src="theme/application-exit" width="16" height="16" onload="fixPNG(this)"/>
Don't use HTML comments, use Django template comments.
This paragraph is obsolete.  The image and scale requirements are now the same as for draw.
This isn't right.  You're probably getting away with it because the shears are small, but the tanh stuff needs to be done on |g| -> |d|, not to each component separately.
(completely forgot to say: this fix looks fine for this issue, thanks!)
End of line whitespace.
"fields" is declared in subclass only so that serialization order is nicer; generally there is quite a lot of info we want to see before the list of fields.  suggest keeping it like this so that XML format is nice, with comment (i'll add) in code.  unless there is a cleaner way to influence field serialization order.
Need at least a TODO or FIXME, rather than just commented out code.

I think I agree, particularly if this is always just a "package default name". But I wonder what might be passed in. From the RPM man page for `-i`:

    In these options, PACKAGE_FILE can be either rpm binary file or ASCII package manifest
    (see PACKAGE SELECTION OPTIONS), and may be specified as an ftp or http URL, in which
    case the package will be downloaded before being installed. See FTP/HTTP OPTIONS for information 
    on rpm's internal ftp and http client support.
Yeah, probably. I don't like it but can't think of anything better...
_Simple rules notwithstanding, build a good go playing program ha proven very difficult_
I added it for clarity of what the date is. It's not permissions. There was confusion about it without it.
I think this needs to be alpha.5, rc2, as viewableAs isn't in alpha.4.

we can block on this PR until central syncs up..
Y U NO USE H2 & H3?  There (should usually)[http://www.flexewebs.com/semantix/semantic-uses-of-h1-h2-h6-html-tags/] only be one H1 on a page.
At some point you need to actually write some proper tests (the longer you leave this the harder it will be).
deveria ser </tr>
for backwards compatibility, where does it default to VERB = 'GET'?  is that unneeded?
s/format/format_str

In fact, let's just call it "format" and change the function signature too.
I18N comment
You know, my rule is if it is not your file, don't touch it unless it is a
necessary change.

-- Amin



On Sat, Mar 3, 2012 at 4:54 PM, Geoffrey Parker <
reply@reply.github.com
> wrote:

> > @@ -14,43 +14,43 @@
> >  * news message.
>
> I don't know.  Invisible formatting I think.  I deleted a blank line at
> the end, but I don't know what those -blank line + blank line pairs are.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/20/files#r515113
>
These two methods could probably be private, no?
sure, I'll remove those, we can't have this type of stuff in production
code...


On Tue, Nov 27, 2012 at 9:52 AM, peabody124 <notifications@github.com>wrote:

> In ground/openpilotgcs/src/plugins/uavtalk/telemetry.cpp:
>
> > @@ -219,36 +225,41 @@ void Telemetry::updateObject(UAVObject* obj, quint32 eventType)
> >          setUpdatePeriod(obj, 0);
> >          // Connect signals for all instances
> >          eventMask = EV_UPDATED_MANUAL | EV_UPDATE_REQ;
> > -        if( dynamic_cast<UAVMetaObject*>(obj) != NULL )
> > -        {
> > +//        if( dynamic_cast<UAVMetaObject*>(obj) != NULL )
>
> Ditto :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/PhoenixPilot/PhoenixPilot/pull/26/files#r2238948>.
>
>
What is the reason to query the database for the template? EmailTemplate object will automatically do that. You probably need a try-catch statement, I think it throws an exception if the template is not found.
It's been working without this association until now.  So are we trying to eager load something here?
Не работает, если класс реализует интерфейс, который реализует этот интерфейс.
project 側に引数に相手の project を受けて同じかどうかを判定する #same? みたいなメソッドを用意すると良いかなあ。
(name が同じかどうかを判定している意図を明示しつつ、もしその条件が変わった場合に差し替えやすくするため)
Nit: spurious capitalization of "First Date"
Nit: s/todays/today's, and s/yesterdays/yesterday's
What you are saying makes sense, but if I change the argument passed to icon_upload to a path that I know does not exist then the test fails, so if this is a false positive it's something related to the test environment. Perhaps try the same thing in the test environment, passing an invalid path and see if it continues to pass?
Could you add the picture from the plot_lle_digits example here.
@amueller @GaelVaroquaux I have question here: I see that pipeline code and checks whether each of the transformer has "transform", and if I delete this, this cannot be put into the pipeline.
```python
        for t in transforms:
            if not (hasattr(t, "fit") or hasattr(t, "fit_transform")) \
              or not hasattr(t, "transform"):
                raise TypeError("All intermediate steps a the chain should "
                        "be transforms and implement fit and transform"
                        "'%s' (type %s) doesn't)" % (t, type(t)))
```
I have not read the codes for pipeline thoroughly so I am not sure how I can deal with this.
pas la peine de mettre des tags [Acc] là
I see there indentation incosistency ( I agree that yast indentation is horrible, but it should be consistent in one file )
Went with the constant.
standalone.xml is consice by it's nature. pom.xml is not.
Do we really need five lines for a feature no one really needs?
Having it in one line helps me focusing on the really important lines, like surefire executions etc.
It's good form to also set it to NULL in case the pointer is referenced somewhere else.
Alex can you provide the actual command that you used, that did not work?
Disabled copy constructor and assignment operator
NativePlatformInterface's getPropertyValue function is static but you're using it from an instance. Would the following work too?
```
return NativePlatformInterface::getPropertyValue(propertyNumber);
```
If this is not yet supported then throw an exception. Same for the others.
I assume parts of a file would be on the same cluster and on the same file-system type.

I think there would be much more serious problems elsewhere if we end up mixing file-systems and OSs within the same cluster...
I've removed most of them. Seemed to still need one to get it not to assert...
This was the primary fix actually, allowing it to cope with small keyed sizes, which had left the initial stab at maxRowGuess as a very small # (<100) after estimate the amount needed for bucket space was high (most of memory).
It ends up falling out as the default # of min buckets below this in such cases.
Good notice, then it's fine for having that
Can we move ids to camelcase because that is more idiomatic for html/js since we are already changing things in this area.
Same problems with the THUMBNAIL_ALIASES here.
Well `table.sequence` can be `None`, if it wasn't defined on `Meta`, and wasn't passed in as an argument.
Should be a header.
Can you explain why we only want to handle the timeout exception if it is wrapped in a CHE? Seems like we could handle all timeouts the same.
I did this knowingly because we have to use this link later on as we switch to latest version of Web Driver. Right now we are using 2.15 and it has some issue with ajax components.

If I delete it then I would forget it to update in future.
Breaking parameter hashes out into ordinal arguments is a bad API design. It forces you to remember the order of arguments rather than their names, which is harder to do. It also forces a backwards incompatible API change every time a new argument is added, whereas using a hash does not require a corresponding code change if a new argument is added as long as it's not a required argument.

What are you uncomfortable about here when it comes to passing `params` down into this method? The method is strictly read-only and does not affect the hash, so mutation is not a concern. Ordinarily you'd want to use Hash#fetch if the keys were required (so as to required complain when keys are not provided), but in this case both `state` and `category` can be nil, and search has to select sensible defaults. It does not make sense to move those defaults up to the controller.

The contract between Discussion.search() and DiscussionController's params() is not wide, so the fact that we pass `params` is only a matter of convenience, we did not introduce new coupling by doing this.

If we wanted to be paranoid, these are valid options from the controller:

```ruby
Discussion.search(:category => params[:category],
                              :state      => params[:state])
```

Or...

```ruby
Discussion.search(params.slice(:category, :state))
```

But the question is what benefit does that offer us? Because passing the whole params object has no danger in non-mutative code, doing so can only help us but would not hurt us.
The reason I have the begin rescue and return in the run_hosts method is for when you are running it against multiple systems.  If it fails on one system for any reason I would just like it to move on to the next host rather than spew out too many lines of errors on the screen.  

This was only my thinking as a novice developer for MSF I am whiling to change this if you tell me how it should be instead.
I've needed to change the regex to

```ruby
data = data.scan(/(.+)\n<br \/>\n<b>Notice<\/b>/m).flatten[0] || ''
```
A comment documenting this constants would be nice.
Maybe integrate these descriptions of `scale` and `sigma` into Parameters section.
Yeah, that's the style in this codebase. Explicit returns for short-circuiting, and implicit for everything else.
Add a story to come back and make non-null returns? Seems like a land mine.
Remove the commented restrictions from all of the presets if they don't apply
Thanks @shunter I fixed my previous comment.
I'm confused - is this `enableTranslate` or `enablePan`.  Panning is more than translating, right?
Use if(typeof context === 'undefined') here instead.  In general, we should stay away from !foo unless we know we're dealing with a boolean value.
There is a `getImdb` function in helpers/variable.
Just curious, do we need to touch the tiapp.xml if we remove the files from the build directory?  Wondering if our scripts already detect that we need a full rebuild if the build directory has been cleared.
Yeah, there are 4 other images referenced in the KitchenSink that were never copied to the new site despite me notifying them on June 19th, 2012.
I agree. I was mostly just wondering if you are OK with this approach for generating the unique IDs.

it seems that you are so I'm going to make it a constant :)
I can use the same code in initializing the module instead of having to repeat it here.
Твой кун-фу силён!
I agree, but apparently, the "Union U" case passes the static if, and then ends up in branch 1, and then fails :/

It is (IMO) VERY strange. I documented it in the bug report, and elevated it because of this.
`For example, $(D ElementType!(T[])) is $(D T) if $(D T[]) isn't a narrow string and $(D dchar)-qualified.` ?
God knows why the javadoc is up here...
Is that required? I think the method is inherited from `AnnotationProcessingOptions`.
This is gnarly.  Replace `untrackRecord` up the hiearchy with `untrackRecords(String[] guids)`.
We like to lean away from the <i> tag here. It is more appropriate to either use the em tag, or leverage css on the application side. Actually, with this being in functions, I'd advise that we return a string only, and format the string in the template instead.
Please remove this entry from the `package_name_map`. It is not required, because your `packages.json` file already specifies the display name for your package.
you should skip the test when Propel isnot available
ditto on Deprecated
ok for now - this really should be a put or post.
Extensions are not included in here, maybe you should?
$accRec ist an dieser Stelle nicht definiert!
Das selbe hier
hmm, in fact, other filters are not consistent about this...
Keep in mind that this code will likely become the de-facto reference for this function.  Any new-comers to this function will be wanting to understand the whys and whats of the code.  These three lines for angles might need some additional comments.  In fact, I am not entirely certain what is going on here.
:thumbsup:

Trailing comma.

:hand:

Alignment with the `=>`arrow wastes some time with adding `space`s that's otherwise spent more wisely. I'm also not sure whether readability is increased when you have (for other reasons) some really, really long array keys.
When I say "use tabs", I mean "use hard tabs". Not "pretend these four spaces are a tab and have your editor detect that".

Use tabs, and have your editor space out a tab as if it were 4 space characters. Or 2. Or 7. But then it's just something your editor can control in the presentation layer, not something you have to dick with in a pre/post-commit hook.
I'll change this function to do its own batch request.
This will result in a GC allocation. Just so you know. I don't know if it's a problem in this particular case.
Use explicit types, not auto here.
55 files changed... first one 44+/48-... all tabs. This is going to be a fun audit.
+1 ;) Nice one
You've already conceded, but just to close it out, constants are for use in a specific context; I would have no problem if there was a general class UtilConstants (although i'm not generally a fan of that either), but in this case you used a constant that belongs to the message headers context in a totally unrelated context.
Add a second word in the value and some spaces - that's what quotes are for, right? So do "test"=\'value of test\'" or something like that.
Actually, my suggestion won't work. And I don't think yours will either. Because when we schedule the build we don't know what system the build will end up on.
Both our ideas assume that all slaves are running the same OS as the master. When in reality that is often not the case.
It could be a mixed cluster with both win, max and *nix.

I know some fixes for things like this has been done before in core but it might not be completely fixed.
Eesh, sorry about that first one, must have tripped up in the dance between
CSR and ember script. Also, not sure if this is a known thing, but after
building a fresh CSR, I get immediate errors. The .js files from the repo
do test just fine though... Any thoughts?

Second change looks good. Any reason in particular + is the better option?

Updates coming post flight home.

On Thursday, December 27, 2012, Michael Ficarra wrote:

> In src/functional-helpers.coffee:
>
> > @@ -49,3 +49,11 @@
> >    mod = if c < 0 then c + b else c
> >    div = Math.floor a / b
> >    [div, mod]
> > +
> > +# The partition function takes a list and predicate fn and returns the pair of lists
> > +# of elements which do and do not satisfy the predicate, respectively.
> > +@partition = (list, fn) ->
> > +  result = [[], []]
> > +  result[Number !fn item].push item for item in list
>
> result[+!fn item]
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/michaelficarra/CoffeeScriptRedux/pull/129/files#r2512336>.
>
>


-- 
===

Alex Matchneer
Co-Founder and Lead Dev
Useful Robot LLC
http://usefulrobot.io
(614) 395-8832
I think the more robust way of doing this is [self.applicationURL URLByAppendingPathComponent:]
this is not the proper exception. RuntimeException will result in a 500 status code whereas the error here is in the requested format and so should be a 4xx response (probably 406)
Doesn't this need to be `{% if app.security.token and is_granted('ROLE_SONATA_ADMIN') %}`

I'm getting the following error message with an unauthenticated user:

> An exception has been thrown during the rendering of a template ("The security context contains no authentication token. One possible reason may be that there is no firewall configured for this URL.") in SonataAdminBundle::standard_layout.html.twig at line 91.
I am aware of this magic string but i decided to put it in until we can get the tag / hash from git
This test makes me realize a big difference with the previous implementation. When it was not pretty printed it was also not sorted. Json does not have any notion of sorting so there is no guarantee that a map will be represented sorted. I liked this behavior in the old implementation because (as you mention it yourself) it is a lot faster to render the string if you do not have to sort. Most of the rest APIs offer you the ability to get pretty print or not. When you don't care about the pretty printing (because consumed by a machine) the penalty of sorting is unnecessary. I would like the old behavior to still exist.
it would be cleaner to have different branches for Symfony 2.0 and Symfony 2.1 to us the real signature. The upcoming BC break will probably force you to do it anyway
A 400 Bad Request exception is expected when the request is no good, a 500 error indicates that the problem is with the server, not the client.
Added to `rails_setup` [v0.0.2](https://github.com/elm-city-craftworks/rails_setup/commit/ec459e663959dd6334a9f9500a0f1b88063254e2)
Hrm. Now I'm confused. We already have a .gitattributes file, so why is github telling me this is a new file?
i guess the parenthesis is an example - but its a bit confusing, as pdo_sqlite is what you *have* to put, while the db name can be anything. maybe make this more explicit.
maybe we should link to the corresponding doc of doctrine dbal here.
You are using `m2m` methods bellow, but here you are setting `is_m2m` to `False`. Is this OK?
Sure, it's doing exactly what it should be doing :)
http://docs.puppetlabs.com/guides/templating.html#testing-for-undefined-variables
no need to wrap the line here
This use is not used and can be removed
what happened to the soundPlayer?
@locale and not @Locale

(sorry ;))
Yeah this should be Submit
yeah. It needs to be a bit smaller.
does it need to extend the ``IOAuth2GrantExtension`` interface ?
This is not critical, these are style beefs and I just wanted to note some alternative approaches.

Where does NotImplemented come from? NotImplemented is close to NotImplementedError from ruby proper but that's for cases of when things like fork() do not work, e.g. on windows (see the ruby docs). If we stick with this route, I would urge you to choose a more distinct name, such as InterfaceError or maybe MethodMissingError, etc.

We could also do this detection in an included hook, e.g.,

```
def self.included(klass)
  raise "not conforming to the interface" unless klass.instance_methods.include?(:download)
end
```

Which would make this happen at "compile" time instead of in the middle of a running program (at the point of class evaluation instead of at the point of method invocation).

There's probably an argument here that we don't need these at all because NoMethodError should be raised in the event they're not implemented. The interface would of course still have to be documented though -- probably worth having a discussion about whether or not we should be documenting the internals sooner than later.
Actually, might be cleaner to check these strings in CDVViewController, and then use an enum internally for backup type?
or rather: "... a central registry is needed"
This needs to be added to the cloudpack.rb file under the add_terminate_options method.  Also, are we sure we want to expose this many ways to terminate nodes?  Users could use this to terminate instances using key-name, architecture, etc.  Seems like a recipe for disaster.  

Also, how do users get a list of attributes they can use with --terminate-id?
If it's easy to convert then i would convert it. There is at least css_value_tokenizer_tests.qunit.html.
Neni sance zobrazit prislusny tab. Muselo by se urpravit cookie a nastavit cookie pro zutne TABy Browseru a ruzne TABy profilu.
A na to uz nemam. Takze toto je prvni reseni, kterym se to da vyresit. Zpusob zobrazeni cele stranky nechavame do 0.7.1
I wonder if having execAsync makes sense at all. By nature, when you call something asynchronously, you don't return the result, result is processed in callback function. Whoever needs to call exec asynchronously would pass a specific callback which do specific things. For this particular case, event registration doesn't care about the result at all, that's why it works. I don't know if there is a need for execAsync, because whoever calls exec asynchronously should supply their own success and fail callbacks, not a generic one like the sync case which always returns the value.
Okay I'm a bit lost, but maybe you can set me level again. When you add an even listener to the viewportChanged, this will get triggered how many times? I see that you store the need to change ALL webviews right, but the only place you decrement is from the pendingViewportChanges.
Yup. Take a look at the "processFeatures" function. It gets called for each and every access list (including local). You can use this to check if push was defined

From: Matthew D'Andrea [mailto:notifications@github.com]
Sent: Monday, September 10, 2012 07:25 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Prevent the auto deferring of networking and JavaScript when using run_when_backgrounded and/or the blackberry.push feature. (#164)


In lib/webview.js:

> @@ -60,6 +60,28 @@ webview =
>              _webviewObj.onNetworkResourceRequested = requestObj.networkResourceRequestedHandler;
>              _webviewObj.onUnknownProtocol = requestObj.unknownProtocolHandler;
>
> +            // Check if we should allow the networking and JavaScript engines to be available
> +            // when the app is running in the background
> +            if (config.permissions && config.permissions.indexOf("run_when_backgrounded") >= 0) {


So, which file in the packager would I have to modify to do this simplification? config-parser.js?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/164/files#r1571835>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.