gh-3120 Bad error when viewing WU result on WU Details page

When a user views WU result on WU Details page and the user
does not have permission for the file, the existing page shows
that 'This section cannot be dispayed due to an exception.'
and original exception is written into log file. This fix
displays the original exception on the WU Details page.

Fixes gh-3120.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
gh-2333 Outdated Optional packages still display in EclWatch

Optional resource packages no longer come with hpcc installation
package. This fix adds a cmake option 'USE_RESOURCE' and the
default value is OFF. As the default, ECLWatch will only
display a web link to the hpcc website for resources and will
not show the download link for the optional packages.

Fixes gh-2333.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
gh-3196 Fix internal error submitting functional definition

If a functional definition had dataset parameters with no default value,
then compiling that attribute as a query would trigger an internal error
because a CHqlExpression was created instead of a CHqlDataset.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
gh-3005 Fix ECLAgent::getPlatform() problem

Currently ICodeContext::getPlatform in eclagent returns "hthor". However
it needs to behave more like getNodes() which looks up the cluster and
returns thor/thorlcr depending on the cluster type. This fix makes calls
to get the cluster name, queries for that cluster's info , and maps the
"platform" attribute to a cluster type string

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
gh-2333 Modify code based on review

The display messages have been modified based on review comments.
I also add code to check whether portal url is set. If not set,
the weblink of BrowseResources will not be displayed.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
gh-2706 Add cli support for comparing state across roxie nodes

Add 'ecl roxie check <process_cluster>" which gathers state from the
roxie process cluster nodes and verifies that they all match.

Fixes gh-2706.

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
gh-3203 Script error on ECLWatch from within ECL IDE

When despraying files from within ECL IDE, the following script
error shows: Unable to get value of the proprety 'options'. The
problem was because of an incorrect access to the 'options'
attribute of the 'DestGroup' select box which does not exist on
the Despray form. (The same xslt script is shared by Despray
and Copy). This fix checks existence of select box before
accessing its attribute.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
Merge pull request #3205 from wangkx/gh3203

gh-3203 Script error on ECLWatch from within ECL IDE

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Now the closedown branch for 6.8.5

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge branch 'gh2333a' of https://github.com/wangkx/HPCC-Platform into wangkx-gh2333a

Conflicts:
	esp/scm/ws_smc.ecm

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
gh-2879 Add spray test

Signed-off-by: Renato Golin <rengolin@hpccsystems.com>
gh-3200 Return StringBuffer reference from appendJSONValue

appendJSONValue was not returning anything, but is defined to return
a StringBuffer&amp;.

Fixes gh-3200

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
Merge pull request #3212 from rengolin/regression

gh-2879 Add spray test

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3214 from afishbeck/appendJSONValue_return

gh-3200 Return StringBuffer reference from appendJSONValue

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
gh-3223 Fix Submit button problem on preflight result page

Run a preflight from EclWatch Target Cluster page. The preflight
result page shows. But, the submit button on that page is
disabled. A user may not be able to submit a preflight request
again if not change the checkboxs. The problem was because the
xslt script did not check the checkboxs correctly when the
preflight page was loaded. This fix uses correct element names to
find out the checkboxs. If any of those checboxes is checked, the
script enables the submit button.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
gh-658 Add user option to eclplus

Previously the meaning of the owner option was overloaded to mean both
user and the owner to filter on when listing workunits, etc.

Add support for a user option to explicitly specify the user running
the command.

If user is not specified owner will still be used as the username for
backward compatability.

Fixes gh-658.

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
gh-2827 Configmgr - Provide msg when validation finds no issue
  - A pop message will indicate when validation completes with no issues

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
gh-3232 ESP to cache password expiry policy

The password expiration policy does not need to be queried very often since
it rarely (if ever) changes. This fix reads it on the first authentication
request in a session and saves it for a period of one minute before being
considered stale.

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
Merge pull request #3204 from afishbeck/ecl_roxie_check

gh-2706 Add cli support for comparing state across roxie nodes

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>