labofsahil/github-event-dataset-2012 huggingface dataset:
According to the doc
http://community.voltdb.com/docs/GettingStarted/HWpartition

the following
CREATE TABLE T1 (
    A INTEGER NOT NULL,
    DESC VARCHAR(300) NOT NULL,
    F FLOAT
);

PARTITION TABLE T1 ON COLUMN A;

should work, right?

Instead, the exception ' "unexpected token: PARTITION" in statement ' is
thrown.

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/planner/TestUnion.java:
>
> > +            aide.compile("select A from T1 EXCEPT ALL select B from T2", 0, false, null);
> > +            fail();
> > +        }
> > +        catch (Exception ex) {}
> > +    }
> > +
> > +    @Override
> > +    protected void setUp() throws Exception {
> > +        aide = new PlannerTestAideDeCamp(TestUnion.class.getResource("
> testjoinorder-ddl.sql"),
> > +                                         "testjoinorder");
> > +
> > +        // Set all tables to non-replicated.
> > +        Cluster cluster = aide.getCatalog().getClusters().get("cluster");
> > +        CatalogMap<Table> tmap = cluster.getDatabases().get("database").getTables();
> > +        for (Table t : tmap) {
> > +            t.setIsreplicated(true);
>
> I'm pretty sure replicated is already the default.
> Also, unioning queries on partitioned or combinations of replicated and
> partitioned is much more interesting.
>
> BTW, fyi, as of recent releases, the preferred way to specify
> replication/partitioning is in the DDL files -- see the doc.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665964>.
>
>
no need for the () around new Date()
@eteq: after a very quick look - `format` looks good to me!
done - I didn't realized that'd make a noticeable difference, but clearly it does for scalars!
cool~ I like it~~
Instead of repeating the path, which is error prone if we want to change it later, you could use info.filePath(). Or define a constant.
I'm not sure it makes sense to exclude unconfirmed/immature transactions from the grouping algorithm?
Definitely not.  This is part of SPV mode (although there are other uses as well).  SPV clients sync up blocks, and then look in the mempool for any transactions they may have missed.

This is also a client-initiated command, so it is the client that is proactively selecting to receive this data.
4 function calls, 1 comparison and a return in a single line over 100 chars long.
Dunno, just copied an existing case and added the id :)
Right, forgot about those :) Will be done!
Missing curly braces required for loop if loop is more than  1 line.
I think it will be easier to keep our features/steps organized if we put the name of the controller/model first and then the name of the action second in the file names. So in this case I think the file should be renamed to `group_add_member.feature`.
@flack: wdyt? the thing is that we should never use short names. maybe we should make the type name expanded in the first place and shorten it in rendering?
If this is intended to be debugging code can you use logging.Debug() instead, otherwise remove this.
Waarom al die optionele parameters typen, deze staan (na de minify) allemaal gelijk met de defaults van de functie. Is er overigens een reden waarom je hier geen minify doet (al dan niet als DEBUG aan/uit staat)?
We have an `AssertPrints` context manager that makes this sort of test easy. It can't do the counting you use below, though.
Do we not have any convenience functions for building an HTML tag out of a dictionary?  I guess I would have expected us to have something like:

```python
attr = {}
attr['src'] = str(self.url)
if self.width:
    attr['width'] = int(self.width)
if self.height:
    attr['height'] = int(self.height)
return render_html_tag('img', **attr)
```

Anyway, in the future this might be written more cleanly as:
```python
width = height = ''
if self.width:
    width = 'width="%d" ' % self.width
if self.height:
    height = 'height="%d" ' % self.height
return u'<img src="%s" %s%s/>' % (self.url, width, height)
```
We have a function `IPython.utils.io.ask_yes_no()` to do this in a consistent way. But remember that the notebook doesn't provide access to stdin, so it will throw a `StdinNotImplementedError`.
Has this been tested with an actual deployment of OpenStack Folsom?

The response JSON will look a little different than this, see https://bugs.launchpad.net/nova/+bug/1046021 and https://review.openstack.org/#/c/13291/1/nova/api/openstack/wsgi.py and https://review.openstack.org/#/c/13291/1/nova/tests/api/openstack/compute/test_limits.py
probably don't need the \n here
above note applies here: regardless of which ctor assignments are made in, extracted simple functions are easy to test and compose!
This is lacking a proper error message. Throw an `INVALID` and let the user know he's a moron for using a `<` character.
`git_packbuilder_new()` would fit more with the naming conventions, no?
Why this? You tell cmake to build 32-bit by passing the right argument to `-G`
We should add javadoc here. But at the very list a line explaning the conditions in wich the exception will be throw.
I think it's compatibility with old systems like Outlook, yuck. The old code does and I think I remember that being right.
Don't use variables here if it's not gonna be translated.

Note: We should really figure out how to handle pages that are not gonna be translated.
Lots of jQuery functions that could be pulled into variables here, like $fill and $video.
Can we use the {{ url() }} format for these links now?
It would be nice to have a comment that explains why the `exploitability` gets reset if it contains an 'ERROR' string.
I'm perfectly happy with that. I like the word "signaling".
Yeah, that's what I meant... I should have been a little more clear.  I blame sleepiness.
Since there are two methods with SSL boolean option parameters, perhaps there should be a `ConnectionManager` class and a `SecureConnectionManager` class extending the prior?  This way both `getConnection` and `handleConnectionSocket` can have their SSL boolean parameters removed.
Can you use annotation instead as this is what we use everywhere else?
There is inside itself. Recursive closures are not the most readable thing
You're right. I was with the the PR in mind and absolutelly forgot this.
The deleted line contains 4 spaces
Default Public User as discussed in class
why add 3 lines to execute 1? replace unregisterFromNotifications in the dealloc with the line being executed, especially because we don't need it anywhere else yet.
Oops sorry :(
I am curious why there should be such strict limits on buffers. I could understand this if the buffers were maintained in their native format e.g. video surfaces for VDPAU. But if we only ever intend to process them as textures (e.g. using OpenGL) then why not copy them to textures and hence decouple the decoder from the display process? The number of buffers would then be limited to the texture memory, which is either graphics card memory or system memory. With VDPAU I believe you only map a video or output surface to a texture in order to display or process it? It would be very easy to instead couple the VDPAU surface texture to a pixel buffer object (PBO) and then copy from the PBO to a texture in your ring buffer/fifo.
The problem with not adding the text files here is that people will then have to change the filter to open such files, even though PlasmaShop can open them fine. I see the reason for removing the external files, but why should text files be hidden?
http://www.minecraftwiki.net/wiki/Enchanting
Great! I'll edit those out. I've also started on Comparators for sorting\searching. They seem fairly easy to implement and are generic enough for either notes or categories.
Testing to see how far I can get with this as a proper code review tool. I can never remember if it's meant to be "unused" or "unchecked".
I could rename the class and a an update to dynamo, would that be better ? The spinner is defined in CSS, so the dependency i very low.
Can you do this in all rubies without getting a warning or exception?
http://rubyquicktips.com/post/1687572267/deep-clone
Let's have just the subscriber in `spree/core/engine.rb`, then.
"Tags suivis", avec un s à la fin
According to PRD there is requirement to make this work in domain mode.
using URLclassloader & file paths on disk invalidates that :(
Sorry about the white spaces, was in a hurry and I didn't notice them.
I'd make moveToTop return a booelean result, `true` if it moved, `false` if it didn't. So:

```js
if ( this.moveToTop() ) {
  this._focusTabbable();
}
Include `osVersion` as well. The old `Platform` used to contain both. This is needed on the user page so that the os version is shown as well.
Yes, `conf` is an 2-level deep object (an object with objects). The variable given is a fresh ini parse, which will be an array of arrays. Casting the main variable to an object will only cast the root level, so I'm looping instead. Although right now all settings are in a subgroup, there may be root settings in the future, hence the check for an array first.

If it's a group, cast the array to an object. Otherwise keep it (a string, number or boolean) as is. See also `./config/testswarm-sample.ini` and `init.php`
Use pylearn2.utils.sharedX so that this will respect theano.config.floatX. numpy.zeros_like will default to float64, so people who expect their shared variables to go on GPU will be disappointed.
мне чет не очень нравятся такие теги, может свои сделать вроде <lor:isModerator>?
its ok to directly override the method, its still on the prototype.
Nit: full uppercase please.
Once again, no internationalization needed here. This is to get the text "9:15 AM  Mobile, Movistar" under the contact name or phone number in each log entry. As said before, maybe I am missing your point here :)
`// turn off airplane mode`
Nit: s/We/we/
does this mean we could get rid of the `style/shared/` directory as well? or at least a significant part of it?
Should be in REMs instead of pixels (8pixels --> 0.8REMS due to 1REM = 10px)
Is top/left no enough?
Hum, I was wrong. This function should not be in `handleEvent` but in the `onfocuschange` callback you moved from keyboard manager.
Ok, I think this is more readable than it seems. It just says: "for viewId in Views if viewId belongs to Views but not its prototype, initialize the view". It is written in such a way you don't need to nest in order to get it readable.

I don't want a list comprehension because I wont gather the result and I'm not creating a list so I'll nest the instructions and add a comment.
The "CallScreen.views.classList.remove('show');" is needed because if we remove it, although the on-call screen is "closed" the keypad keeps shown.
Hmmm how about just, 'Expected array with at least one sort criteria'?
~~~
+この章を読んだあとは、あなたはジョブの概要について理解して、検索したり実行できるようになっていなければなりません。
~~~

→

~~~
この章を読んだあとは、あなたはジョブの概要について理解して、検索したり実行できるようになっているはずです。
~~~
For this kind of utility-funcitons it's nice to save the match data before you match and then restore it afterwards. Otherwise it can cause some very confusing bugs for people that are not aware of the implementation.
You missed that one! Will merge it then!
```scala
def partition[A,R](fs: (Fields, Fields))(fn: (A) => R)(builder: GroupBuilder => GroupBuilder)
  (implicit ... ord: Ordering[R], rset: TupleSetter[R])
```
This is a little tricky. So the way to work this is something like:
```scala
  val tmpFields = new Field("__temp__")
  tmpFields.setComparator("__temp__", ord)
  map(fromFields -> tmpFields)(fn)(/* set the singleSetter TupleSetter here so the whole R object winds up in one cascading fields */)
    .groupBy(tmpFields)(builder)
    // Clean up the single field:
    .map[R,R](tmpFields -> toFields)(identity)(/* use the single getter, and the rset here to unpack R into multiple tuple entries */
```
This way, it is a general groupBy on any scala comparable type. Actually, this is pretty awesome if you ask me.
this stuff is great, Socket was a confused prototype before haha
Add in your e-mail.
It's different and not the same across all dbs.
i think blank? is the opposite of present?, no?
hmm... a 401 or 403 might make even more sense... thoughts?
It would be good to minimize non-functional whitespace diffs like this
```
# JIS X 0401に定められた都道府県コードを定義
# 東北、関東、、などの括りは https://www.lasdec.or.jp/cms/1,0,14.html のものを参照している
```

というコメントというかドキュメントがあるといいかも。
Think we switched to the convention of using spans or buttons for links that don't go anywhere? /cc @phamann
Please end your files with newlines.
moved to `tabs/common.js`
Change this to just user
should be
```
options = [v for v in source_dict.values() if isinstance(v, Option)]
```
s/consequtive/consecutive/
I will do it here and you can sync it with issue #87 later. I think that's a good way. Before I do it I will wait for another update.
Perhaps. Is there an issue with them being in the top level?
This is an artifact of running `rake spec` after bumping the version.
i ++ :D
I not sure bout that, last time I heard wilson say need this things after user logout.
ah, I got your point, even though for debugging purposes I use true, it should always be false when it's in repo.
Isn't?
don't put an extra space before the opening curly bracket
Can all of this be covered by using `Forwardable`? It seems like that should handle this pretty well.
A couple of other methods have the same confusion about error identity; please update them the same way.
When I tried doing that it resulted in test failures for scope.
OK, thanks for a hint.
Sorry for the ugly spec.
Which is correct? Or other?

* Use "should include" matcher
* No define specs for the place of method definition.
I think using `deleteInstanceDir` with Solr's core UNLOAD would do this for you.
> Why not reusing this counter?

You are also leaking that binding to everything that isn't reusing that counter.  So everywhere else in the function you'd need to check for usage/mutation of `i`.  It's almost never worth reusing variables like this, keep the scope of your bindings as small as possible.
we manually hoist all our vars to the top of the functions in bootstrap – just a weird style thing… also, shouldn't you have just needed the first line above
No namespace declaration at the top for the exception.
Move the "implements" keyword to the previous line.
does `document || {}` not do the right thing in a worker?
Space after last )
honestly, with two methods replaced and a hacky method_missing, i think it would be better if we could just add the methods to the instance ... performance testing seems to consistently demonstrate that method_missing is always twice as slow as a regular method...

i tried to add the methods dynamically, based on the @attributes, but i couldn't get it to go (buzzed and late as it is)...
Yep, very good. (the usecase in my head for overriding component config at the installation, environment, or end-user level is not the same motivation as a subclass extending and overriding a parent, so not really solved by this either way, but it's not a bad thing to support as well. SimpleComponent children have been 'final' classes up till now, but probably not for any good reason - eg your FrontEndComponent, although damn I wish we had traits for that.)
I'll do the while loop. However I would argue that combining type coercion with evaluation of a postfix decrement while shorter does require the reader to understand several subtleties which makes it less clear. They need to know that zero will be the only number in the sequence considered "falsey" and that the while loop test will evaluate based upon the value of `i` *before* the decrement operator is applied. Typically, the explicit for loop would be easier to read and is a pattern that everyone is familiar with.
Just use the jQuery methods, the speed benefit is moot anyway. Also don't see the point of those temp vars `link` , `img` etc, just use them directly.
May be this could be a bit simpler:
```
+            save_as = self.settings.get("%s_SAVE_AS" % template.upper(), '%s.html' % template)
+            if not save_as:
+                continue
+            write(save_as, self.get_template(template),
```
we cannot special case "class" attribute in the $compile service. there must be a better solution
suggest default decoder take data instead of response as parameter.
what you can do is simple: declaring the property in the annotation class.
2012/4/9 Rafael Mendonça França
<reply@reply.github.com>:
>> @@ -993,6 +993,19 @@ defmodule Elixir.Builtin do
>>    end
>>
>>    @doc """
>> +  Returns a binary which corresponds to the text representation
>> +  of `some_atom` in UTF8 encoding.
>> +
>> +      atom_to_binary :my_atom #=> "my_atom"
>
> Please add the `## Examples` header

Ok. Did it. Thanks!

-- 
Dickson S. Guedes
e-mail/gtalk: guedes@guedesof.net  - skype: guediz
http://github.com/guedes - http://www.postgresql.org.br
Change to: $(this).unbind(evt);
don't want that in pelican sources :)
Oh yes, I forgot to look at this new `TemplatePagesGenerator`.  Your suggestion of a new signal is fine, I will do that.
I wrote this query to avoid duplicate videos  for extend playlist(currently youtube allows duplicate videos to exist in playlist). Yes check should be for `video_sourceid`, now I feel check should be made before creating video object, and check for entire video list   and ignore if it is in current playlist.
set this on a single line, since it's a single dep
I just noticed that id != file name ("json" != "json3").  This forces the dev to configure a path for this module.  Otherwise, we'll have to fork the file and change or remove* the id in our local fork.  We should change this to be

* This module should definitely be anonymous.  It'll be way way easier to include it into another project since anonymous modules can be relocated easily.  New line:

```js
    define(function () { return JSON3; });
```

I also wrapped the exported value in a function call since this is considered good practice (but not necessary in any popular AMD loader, iiuc).
oh, wait, I see what you meant. A more forgiving API would be achieved by adding this as the first line of the function:

```ruby
collection_keys = collection_keys.flatten
```
Please comment that the callbacks are called with the file as their argument.
only need 2 blank lines.
Fixed indentation of the entire block here.
я для эстетики использую синтаксис definition table rest
```
**name**
    name for new field
``` 
и так далее
оно и в исходнике лучше, и может потом стиль прикрутим удачный
as far as I remember, mutuallyExclusive was to enforce that these tests were not run concurrently.
In this particular case, the order is important, because I'm testing the Test T things with some preconditions that the test T-1 set up. In absence of a fixture-like mechanism, this was the only way I've found :)
isnt it enough to ask if https is enabled?
Nice, but this was `cp .svnignore .gitignore` only. I didn't pay that much attention to that as it worked that way.
Maybe this should be a guess? It seems possible that journals will eventually implement OG, at which point this could be problematic.
No, you didn't do this. I forgot about those cases. I'll fix it.
I think what you mean to do was to move "val replyTo ..." _before_ the shutdown listener
@furf why did you need to change this in addition to the path for gists?
This comment is fairly redundant
Coding Standards :)
Could as well.
But is it worth adding more check when setting the env doesn't affect anything if the executable is not IM?

Or maybe for general purpose:
in the constructor:
$this->handlerName = false;

In static function createFromINI():
$handler->handlerName = $iniGroup;

Then inside convert():
if( $this->handlerName == 'ImageMagick' && preg_match( "|convert|", $executable ) ) ....
You should use `isset` instead.
Change this to Capture Data?
are we sure this does not interfere with multivalue properties? if the node type defines the property must be multivalue, this call should fail with a non-array argument.
This doesn't allow for multiple plugins on the same page.
Ye I am an OCD guy, please remove this line :)
I don't think we need `app/views/main/index.html.haml` because `app/views/main/welcome.index.html.haml` is the splash page and this file isn't being routed to anywhere.
Isn't the default "auto" anyway? I could be wrong...
didn't forget you @parndt. I have some time planned for open source this evening and will do that first.
This is going to break with new config format. The `true` should not be there anymore. Instead, there is now an optional options object that needs to be passed in as the last arguments

```
{
  'tenantOverride': true/false, --> defaults to true
  'suppress': true/false --> defaults to false
}
```
For this one, I don't think we want to allow tenant admins to change this option. We'll probably also want to suppress these values.
This should be createTenant(initializeTenants);
If someone creates a new document resource type and doesn't add a transformer for it, then yes that could happen. I opted for the easiest to develop with rather than one that would show nothing (or give an error or something). The schema allows you to say what is stored or not, which translates to what is returned in a search and not, so you can index on things that don't necessarily get shown to the user.
This doesn't really need a return statement.
@simong: Would it makes sense to create a "createColumnFamily" function that checks whether it already exists and then creates it if it doesn't ? It's a pattern that's coming back all over the place already.
``resume() ``
I would extract the data passed to `fill_in_table` into a variable named accordingly. Something like `cucumber_table_hashes`. This illustrates the usage more clearly.
i think you want to say Document Repository here and not DocumentManager. the interface will be implemented by the repository.
Please take a look at my pr/128 branch, I've added a new function that should be used instead of this. dvb_transport_find3(). Most of the params can be set to 0/NULL and it will search ALL things etc...

See opentv and eit modules for example usage.
sorry, power of hebbitn)
I will change it
Removed in next commit.
В данном случае всё ок, так как массив DNA состоит из ссылок на статичные объекты. Но на будущее - операторы сравнения у объектов будут сравнивать **ссылки** на объекты, а не сами объекты.
Ваш подход замедлен тем, что вместо прямого обращения к массиву вы создаете два строковых объекта из массивов (что медленно).
И чем вам не нравится property - не понятно, т.к. property является инструментом инкапсуляции и идеологию объекта как раз поддерживает полностью.
Если же вы действительно уверенны, что в данном случае property - это зло, вы можете сделать так:
```objective-c
if([DNA objectAtIndex: i] != [someCell->DNA objectAtIndex: i]) { ...
```
я же вот не поленился и проверил, такая конструкция работает именно как arc4random()%100
а нужно, наверное, так:
r = (arc4random()%self.genomeLenght -i) + 1
хотя я все равно до конца не понял, может быть будет просто достаточно (self.genomeLenght - i) ?
Sure. I just removed this, they're done.
This should be `initWithCanExecuteSubscribable:block:` to match the convention of the class methods.

And, can we just put this in the public interface? It's not as convenient as the class methods, but it wouldn't harm anything by being there.
We should probably have assertions that both of these values are `>= 0`.
why you made default to: de_DE please?
function() {*
Good question. I'm not quite sure how that ended up in my repository, so I'm removing it until I investigate it.
As noted by @redoz in the comments, I think it would be a good idea to consider using `TreeBuilder`.
You are correct - I will add the git read-only protocol to the set of tests that are run.
Brakujący przecinek w tym samym miejscu co wyżej.
+1 for concatenate
Same here, just deprecate it instead of deleting
why replace with call to local timeout?
I would change the name from jQuery to something like promises or deferred.
Some of the places you need to fix. I wonder what we call $this , object or pass the Micro ?
Can't use URI and get the scheme from that?
Да, конечно. Я и сказал на будущее.
selenium allows you to just use "new" here http://release.seleniumhq.org/selenium-remote-control/0.9.0/doc/java/com/thoughtworks/selenium/Selenium.html
please remove the test if it is not necessary anymore
I tried updating this and the response was that there is that there was no change. I'm not sure what to do, I am not an expert on submodules.
Right way to define path to load asset!
I'm confused what this solved. If UnprocessableEntity is-a exc.HTTPUnprocessableEntity according to inheritance then why wouldn't this already work? The integration tests looking for the correct UnprocessableEntity status code are passing.
Vladimir, isn't it possible to make this to work with a WithinThreadExecutor?
I'm thinking even if you changed the default, it's still possible for the user to call the other constructor and provide a WithinThreadExecutor explicitly.
:boom:

I can't English.
This alignment is unnecessary. Objective C tends to be less "columny" than you might think.
Can we fix the english here and below from "to" --> "too"?
Looking at this again, I don't see why this very function `colormap` couldn't be used to return a list of colormap names.  This function currently only exists for documentation.
Shouldn't this be av_conv not ffmpeg ? (Also below)
This property is failing, it doesn't appear to have been migrated.

example test `test_that_selecting_exact_version_doesnt_show_other_versions`
I have comprehensive tests that I ran on the code that I can 
formalize, if they're important.
Also - stick this in a separate pull request
https://github.com/zacc/moztrap-tests/blob/68bec9950e23e5d41d98ec084cf1ed4de885512f/tests/test_homepage.py#L42
They're actually just wrappers for flatten and map flatten so that they
work within Cascalog queries. These functions are actually going to go
away later today though.


On Wed, Oct 17, 2012, at 04:10 PM, Sam Ritchie wrote:

  In test/clj/forma/hadoop/jobs/forma_test.clj:
> @@ -151,3 +151,13 @@
>   2            [[4]]
>   0            [[2]]
>   50           [[52]])
> +
> +(fact
> +  "Check `unnest-series`"
> +  (unnest-series [[[1 2 3]]]) => [1 2 3]
> +  (unnest-series [1 2 3]) => [1 2 3])
> +
> +(fact
> +  "Check `unnest-all`"
> +  (unnest-all [[1 2 3]] [[4 5 6]] [7 8 9]) => [[1 2 3] [4 5 6] [7 8 9]])

  isn't this just map flatten?

  —
  Reply to this email directly or [1]view it on GitHub.
  [RkOat9Y1_FdXL0zywX1whpiVA_-tduUyZW7h3XwfS37sIWahrWHoTFgF1DTiGA4g.gi
  f]

References

1. https://github.com/reddmetrics/forma-clj/pull/244/files#r1873381
Made spatial resolution an argument for fires too. We now need to reproject these to our modis pixel coordinates at 500m resolution, not 1000m. Queries have been modified to reflect need for a spatial resolution argument (see changes below).
@apex13 Do we still need this extra property after setting the `border`?
Can these styles be consolidated as well? Seems like all lists would need this.
You're right, I'll do that.
Both those are legal logical_paths, its just not the example I want to show.
Here you can set the server name for all php files!
Needs an isset() check otherwise we get an undefined index error
But this RFC removes the "control" setting of this feature :P
Are you sure you want to override the parameter ``$scrollingStyle``? This often makes code less readable.
It seems like ``$matches`` was never initialized. Although not strictly required by PHP, it is generally a good practice to add ``$matches = array();`` before regardless.
- Are you sure the variable ``$tabs`` exists, or did you maybe forget to declare it?
- Please always use braces to surround the code block of FOREACH statements.
the justShot variable previously was never reset (due to the fact that the medigun subclassed the Draw event

now that I think of it, perhaps the healing beam doesn't work anymore? I've got to test this
Java switch-case kann icht über 'class' "switch-casen" : A switch works with the byte, short, char, and int primitive data types. It also works with enumerated types (discussed in Enum Types), the String class, and a few special classes that wrap certain primitive types: Character, Byte, Short, and Integer (discussed in Numbers and Strings).
NOOOOOOO!

Already committed, good thing it is optional ;)
Can you also do this change in /docs/dev/index.md?
you might also make that a const global to the file and perhaps read on startup so other users can label the default channel any way they see fit. (enhancement bug perhaps?)
Space needed after the ``if``.
Why is the full CC-BY license included here?  I don't have the full text in the main repository...
But then you have to convert to same case everywhere! And this means it is easy to break.
Use datetime field.
??? This is not needed.
Move to very beginning.
*svojega*!
This is a neat trick using a local variable that is not yet defined, but it is confusing. Is there a reason this could not be a return value from this method? What do you think would make the code easiest to read?
I believe you're validating an xml file, not a yaml. Have a higher level check like "validate_app_config" or something because we'll want to check for other required items in the future.
why not?
player->CastSpell(player, spellId, true);
jep, jetzt erscheint der Toast und danach gehts wieder auf den Beercreate zurück. Würde sagen ist so im moment noch ok
Missing line break.
Also, align all `=` signs
Why do we need these global declarations?
need to update package.json to include this, but otherwise I think this is good.
versions should be defined in the parent pom.xml, in the <dependencyManagement> section; otherwise we risk having conflicting versions across different modules. (which might be needed at some point, but better deal with it as a conscious choice)
Thread safe?
we shouldn't need any RecordReaders.
Woops, sorry for misreading
Can you specify here that in that case, it's retrying indefinitely
How come `this._retries == MAX_RETRIES` doesn't mean we should fallback?
This should stay in, cause it's actually possible to run without jsp support
> Can NSUserDefaults get prefs from other apps (not just its own)?

Yeah.

    NSUserDefaults *prefs = [[NSUserDefaults alloc] init];
    NSDictionary *pdict = [prefs persistentDomainForName:@"com.apple.Safari"];

> Anyways, the NSUserDefaults API would probably just call this anyway :)

Maybe you’re right. Whenever I see “CF” instead of “NS”, I think it’s old Carbon crap that isn’t going to work much longer, but that’s not true, is it?
Also, prefixing the '' with a u means that it is a unicode string.  I don't think not including the `u` in this case would change anything, but better to be safe in case this drops unicode
Dependent?
It would be useful if this also took the name of a distribution as a string, that's a bit easier to use (and it's what pandas does).
So basicly just add into the bannedList variable and the server takes care of the rest?
@bnoordhuis valid concern, but this was already the case WAY before when. I'd love to build a different solution, but that probably requires sanitizing the messages a bit. I have plenty of code lying around for that still. Or do you have a different, better idea?

@janjongboom this regexp is already not-greedy, is it not?
It also succeeds at being ambiguous.
never mind, I see what's going on, there's a line break missing (the aberration is way after the #) -- now that I know what's going on, I"ll just fix it myself.  Will push in a few minutes.
I think we're amply demonstrating the capabilities of the config stuff by simply putting the numbers in and showing where they came from... Not reading in actual Python (and thus having the facillity to do these on the fly calculations) is the only major downside of using JSON or YAML, but people who want to make calculations in Python can simply use GalSim as a class library anyway, in exactly the manner of `BasicDemo.py`.  So I'm happy not making this a TODO, but simply saying we use the result.
Should dox mention that no wrapping is done when scaling angles?  Or should we assume that users will expect this behavior?
@tuong was discussing about adding this macro in opam (as we added a bunch of them recently). I'm not sure that's really a good idea at the moment, so I've merged you patches with `sh` as it seems to work fine for you.
please don't use jQuery coding conventions. No spaces between if ( condition )
I think current_remaining is in $$, should this be multiplied by 100?

Also, should we reject a donation if it does over? I think we should just take it
Should be on the same line as the for each, see existing renderers for cs examples
Non saprei...indagherø
Yikes, sorry about that. I should have paid more attention.
And for the tags? :(
Can you move the operators property inside this method. It will make it easy to see the glue between them and this code.
/**
* The user's political view
*/
now that I think of it hough, a recursive call might do the trick.
This line, not the entire thing :)
Problem.
Why not put this variable in the telemetrymonitorwidget since nothing else in the main window uses it?
точка с запятой в конце
Давайте класс положим в отдельный файлик в /lib
Some classes has header doc and other not, how you do you manage that? It would be good to pick one convention and stick to it even if it doesn't require class header doc.
Is locale from the country collection in the json response or something else"?I haven't added this to the movie filters. Let me know what it should do.
Thank you very much. I could not find how to get return type.
if it's meant to be private car you preffix it with _ so _AsScorer ?
The current f1_score doesn't support multiclass. How is f-score defined in the multi-class case?
I am only supporting what was already there, and making it available in GridSearchCV.
you inverted l1_reg and l2_reg

alpha is the coefficient that penalizes the L1 norm
This line also needs a skip. Otherwise +1 for merge.
Is it intented to set the data type for decision trees?  The class seems to be rather general.
ну зачем? я же сказал сделать отдельные тесты для проверки доступа.
I generally use a struct for a value type, and class for a polymorphic one (matching D). This should be a class.
should be a check box. because flexible templates allow picking a particular order of files as well.
So a blacklist and a whitelist? So nodefaults would either be true and compare values or be a whitelist? Or a separate whitelist option maybe?
I think we don't need to set topMargin here, what if some object which doesn't support setTop interface will call it
My fault.
While reading Anders Larsson's reply , quoting:
"Note that since the application and UI is running in different threads, and there is no way for the application to block
the UI thread" 
i had an impression that UI thread should make a callback , and treated to it as a very logical, but that is not the case.
Removed mutexes.
std::string is a bit of overkill because the string will always be perfectly formatted from V8
Done

2012/10/12 Sanne Grinovero <notifications@github.com>

> In
> hibernate-search-documentation/src/main/docbook/en-US/modules/spatial.xml:
>
> > @@ -260,6 +260,12 @@ List results = hibQuery.list();</programlisting>
> >      </example>
> >
> >      <para>Sample code is at SpatialIndexingTest.testSpatialAnnotationOnClassLevel() and in Hotel class.</para>
> > +
> > +    <para>Pro Tip : For advanced usage, there is a Coordinates interface that can be used to pass latitude
>
> Yes.
> See in
> http://docs.jboss.org/hibernate/search/4.2/reference/en-US/html_single/
> Search for "Tip" , you'll find several examples of a nice highlighted box
> with a specific icon.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hibernate/hibernate-search/pull/332/files#r1831267>.
>
>
Isn't resume the opposite of pause? Why not use if (!queue->paused()) rather than creating a new isActive() test (with slightly different but not necessarily desirable semantics...)
No. What I'm saying is independent of the class. If you watch the directory and its subdirectories, two things will happen:

1. If you don't want to recur, you will. All files in all subdirectories will be monitored.
2. If you want to recur, you won't. Only the first level of subdirectories will be monitored, not all the way down
3. If you recur yourself, you'll add two watches per subdirectory, one when you add its parent and one when you add itself.

So you should either:

1. Recur all the way down (by making this part of the code recurring), or
2. Only watch the directory being requested, and not its sub-directories, and leave the recursion to the caller
This is something I really don't like, mainly because it makes diffs bigger for no really good reasons. I agree it makes code a little better and easier to read, but as soon as you add something that is too long, you'll need to change a lot of lines just for style consistency, and that's a bad result to me. 

Anyway, that's just a comment from me and not a real expectation on code quality. Just sayin', in a way... :)
Can we keep it like the old URL which would be `/products/Firefox/builds.rss`
That way we don't need to worry about the legacy of the old URL.
I think here it should be the other way around. The `$aditionalProperties` that you pass should be able to be overwritten by the user
Well `send_report` is called when `mozmill.results.finish` is called, so it needs to have the same name. I would agree that the name is a bit obscure. Maybe `output_report` would be more suitable? This would be a change in Mozmill. I also think the base method should not assume the report is JSON as it may be manipulated by `get_report` as we do here.
Why don't we use belongs_to :user here, as we already have a user model?
why not `styleRules += contentStyle.join('')`
It is a localization feature where you prefer using words instead of numbers for some plural forms.
(Not sure it is common in english...)
you may be more explicit by adding stdout result after each `emit` call, here and in previous example.
@shacker can we use a class instead of using <strong for the whole sentence?
I know it seems obvious but add a short docstring here.
razor policy not razor model
If there isn't CVE atm please delete it until it is published.
nitpick, should be indented
I think this PR is about ready to merge--thanks @ahojnnes!

This is the last thing I think we should improve:

```python
contiguous_rdata = np.ascontiguous(y.astype('double', copy=False))
contiguous_cdata = np.ascontiguousarray(x.astype('double', copy=False))
```
> What happens when you try to compile this on different platforms, or when openmp is missing (or different compilers)? I have no experience using openmp.

Not sure, would you like me to use environment variables instead? Something like `SKIMAGE_CFLAGS`?

> Also, I've read that funroll-loops is almost always a bad idea--comments?

This could be part of some extra env variables (see comment above). Thoughts?
this could lead to misunderstandings, people thinking they should set some requirements instead of letting the repository handle it for them.
This is called for each command, but it doesn't need to be, right?
If people aren't familiar with EventSource, they'll have to look up how to listen to a particular named event. This just is a helper function in our code so that people won't have to go searching to figure it out. I can remove it, but I think it's worth keeping around.
This would result in fewer tests, and I hear less is more.
I'm all for fine-grain tests, this is just some of the earliest code I wrote before I was getting used to them.  I split it up.
"the this" - should be just this?
I'm not 100% certain, but it doesn't look possible to write using a single LINQ query.  The problem seems to be the python.GetSubKeyNames() requires a select many, but I don't see how to combine select many with projection (because select many turns into 2 froms w/o a select, and we need both selects).  Once we call the .SelectMany method call to do the selection we lose access to what would be outer variable loops in the imperative version, e.g. something like this:

                            from key in 
                            from python in 
                                from baseKey in new[] { Registry.LocalMachine, Registry.CurrentUser }
                                select baseKey.OpenSubKey(PythonCorePath)
                                where python != null
                            select python.GetSubKeyNames().SelectMany(x => x)
                            where key == SupportedPythonVersion
                            select python.OpenSubKey(key + "\\" + InstallPathSubKey);


But then again my LINQ-fu isn't very strong, so I could be missing something here.
From a user's point of view, if the user can't see the child, add isn't supported. Users get really frustrated with this. More frustrated than if we throw an exception or something.

Technically, `add` is supported on Android for several of these controls--but there's no way to see the child control.

I'm taking the point of view that if it isn't supported *usefully*, it shouldn't be documented as supported.
should be 'width'
v should already be an utf-8 string, so no need to encode.
Nice offer for a symlink attack. ;-)

Please use mktemp -d to create a temporary directory, and then work inside this directory.
you should remove the ``@version`` annotation
> "Dislike" is not the word. The problem is asFlatStaticArray is a self-serving abstraction: it helps this one function (thus helping the argument "it's practical") without being otherwise useful, and this function uses it (thus closing the circle).

At least it is used in:

1. `_initializeFrom` from this pull
1. `setToInitialState` from pull #928
1. `callPostblits` from pull #928
1. `callDestructors` from pull #928

> I won't pull in a design I don't agree with just to be nice at the cost of creating more work down the road for everybody else.

Yes, you will just force me to agree with your design without any explanations (not personal attack, just a fact as you are a project owner).
Much better! Kind of weird though , because I'm certain I tried that, but the compiler complained. i probably typoe'd something. Sorry for not getting it the first time.

I changed it in the documentation (looks much tidier), and in `autoInit == RefCountedAutoInitialize.no`

Regarding `autoInit == RefCountedAutoInitialize.yes`, there needs to be two actual functions, because the bodies don't acutally match, and because `ensureInitialized` is actually mutating.

Thanks for the tip!
I've separated out the documentation for normal (function), Normal (struct) and normalRNG (convenience function for making structs), using LREF cross-links where appropriate.
Sorry, my mistake (I haven't looked through changes carefully). So I have nothing against a documentation fix.
<issue id="NewApi" severity="ignore" /> to ignore it in the entire library, not just single classes.
@var forgotten
That sounds good:

* XmlMetaDataSource
* AnnotationMetaDataSource
* ProgrammaticMetaDataSource

I could live with that
I didn't realize it was that simple. :) But it does make a lot of sense in retrospect.

Having a `get_variable` function makes sense, it hides the guts of toolchain, which is a good thing (because then we can change it without affecting outsiders).

So... Should we change this everywhere? That's going to be a fun exercise... Hard to test if we got them all too.
This line is quite confusing imho.
"needs" is the correct form
edited with just one d.
The whole if for the matter.  fixed.
next slide ro dobare bebin!!!
mage gharar nist code ha dynamic bashe va ba har tedad ax kar kone
A more comprehensive write XML unit test added.
This should be removed when the digest issues are resolved.  Forcing the calls through the /digest path is not standard behavior.
I think this could be simplified a great deal, using built-in functionality.  See the [`FilePath.list()`] method, which is the more appropriate way to implement Ant-style paths.  You could even enforce a requirement that the pattern must match exactly 1 directory.  If the pattern ends with a "/", it will automatically match only directories.

````java
FilePath[] matches = build.getWorkspace().list(resolveParametersInString(build, listener, reportTarget.getReportDir()));
if (matches.length == 0) {
  listener.error("directory does not exist");
} else if (matches.length > 1) {
  listener.error("more than one path matched the pattern");
} else {
  FilePath archiveDir = matches[0];
  if (!archiveDir.isDirectory()) {
    listener.error("Pattern did not match a directory")
  }
}
````

[`FilePath.list()`]: http://javadoc.jenkins-ci.org/hudson/FilePath.html#list(java.lang.String)
Yeah. I've made the fix, and it behaves as expected.
Requires documentation
Walter is a huge proponent of static asserts like this and pushes for them whenever it comes up. It's exactly the sort of thing that we should be doing.
No you haven't!
we should probably at least log the unmatched (stale) message, even if at DEBUG level
minor: semicolon at end of line
This attribute cannot be provided if http-method-expression has a value
Again hardcoded versions...
Maybe it's your STS on resource update...
I think I'll write some Gradle task for this issue between this and then...
Should you be passing err back out to the callback if there is one?
OK, good to know.  Perhaps we can use "operatingsystemrelease" here as well.
@AmyStephen yes, remove to the JLog message.
I wonder if you want to be testing the hit method, or another method that tests the cards to see if a bust condition was reached. That method would be easier tested, because you could pass it the cards to tell if it it busted or not.

Then, you could test that the hit returns (or at least calls) the bust_condition_test
The reason for wanting a `CollectionView` is because of the automatic child adding and removal but sure, I see your point.

To do this I've overridden this (in coffeescript):
```
render: -> 
  ItemView = @getItemView()
  @addItemView(item, ItemView, index) for item, index in @images 
```

```
buildItemView: (item, ItemView) ->
  new ItemView(_.extend({}, item, model: @model))
```

I've already written my own `addSubview` which proxies `onShow` and `close` using deferreds so I could just as well create a custom view.
The caller needs to know about it if they're going to use the session management feature.  They have to explicitly call

```ruby
UserMfaSession.create(@user)
```

and

```ruby
UserMfaSession.find
```
in finally, close conn.getInputStream()
use node.getID instead of container.getID
locallib.php应该做的是数据抽象，就是向数据库存取数据。界面行为不应该包含在内。这样才能实现MVC分割

所以这里的函数大概应当是像add_question(), get_questions()这样的
this is what i need!
This method is not doing things according to class based view style. These attributes should be accessed via `get_failure_url` and `get_success_url`. this is the standard way for class bassed views.
yup, we could even just augment `.prompt()` to support it:

```js
program.prompt({
  name: 'stuff...',
  age: 'stuff...'
});
```
Sorry @stof but I don't understand what do you mean
Classe!
I appreciate the exacting attention to detail, but the review is to double check the right commits are being merged. This readme already shipped.
True but we haven't yet.
Тут что-то поехало, проверь мб ты мешаешь табы с пробелами. Так же в строчке 10
Adding the step to validate that we see the email and the sign out link. We do not have access to devise current_user helper
@sebap 
Maybe to test for an exsiting session we could check if current_user it's not nil, the same goes for checking for logging out, by checking that current_user is nil.
that number is a bit too low, the correct formula would be (Math.pow(alphabetLength, textLength) - 1) / (alphabetLength - 1) * alphabetLength
yadet nare :D
Having blank lines before and after that one would be better for reading purpose.
please add a space after the closing curly bracket, and a space before the opening curly bracket :)
`Edit`
Put it in the parent pom. It can be used in all submodules. The type should be jar and the scope provided.