labofsahil/github-event-dataset-2012 huggingface dataset:
FWIW, I just filed [bug 747403](https://bugzilla.mozilla.org/show_bug.cgi?id=747403) to remember to put more work into this feature
Cool! Then please update your code and ``git push -f`` to update this pull request. Thanks
;) Thanks!
web.scss genere web.css avec SASS. SASS ecoute pour des changements au fichier .scss et genere le .css apres chaque detection.

La commande pour initier le "watch" est ```$ sass ---watch web.scss:web.css```.
I have changed it now.
IIRC this is only in JS
Looking a second time at this, `$total_revisions` is already a counted value so having a second call to `sizeof` doesn't make sense at all here.
Globals shouldn't be used, pass them as parameters and assign them as class properties for later usage.
As per IRC: This content should probably be in its own template file and should be included from here.
Surely initialising $is_expr to false will mean it will always be false?
So while I thought this was working for some, reason it appears not to work at all. The process just hangs in the end waiting forever for the webserver to terminate. Unless someone else has a better idea, I'll have to bring back the ps solution.
șterge linia asta și linia următoare, te rog.
The names `request` and `response` are confusing here, since they look like the "req"/"res" pair from connect/express.
(BTW, all other users of `contextObj` should probably be using `config.context` instead too.)
lines 13 & 14 use "> ", as does mojito's package.json, so I tried to be consistent.
i just found out currentConfiguration, will use that and move it to FormsAuthenticationConfiguration
+here need to investigate.
camelCase: dispenseLocation
(for lots of vars, keep an eye on this for readability)
There will be some issues if we initialize our service here --  see this commit on how to initialize the service: https://github.com/Raxa/raxacore/commit/dd23ca987fa99631c5e5e1dfad5e1e8c6b1958c0
They can also become Gemm ops. At the same time, can you tell that vector-vector product can be optimized to Ger or CGer?
production_use_date
Missing input validation (doc1 or doc2 could be NULL)?
For our purposes, we require an xpath to be used in selecting an edit region - so I am not sure where an xpath including foo[last() or 2+2=4] will be useful. To help insure convergence, we do not allow positional indicators wrt the sibling axis - as the resulting nodeset is often effected by node order. So indicators such as position(), last(), following-sibling::, preceding-sibling::, and so on will need to be restricted. The ancestor/descendant/self axis should be fine.
Wow ... nice.
My initial comment refers only to the comment immediately preceding it - the one associated with the signature not shown in the github review snipped (the one I quoted).
I'm truly divided on this - I have a natural affinity to top-of-file includes, but this really makes sense here because of the locality in this file for extending the exceptions.  Not a pull-stopper in my opinion.
Would these be better expressed as a dictionary?
no need to use ``else`` as the ``if`` returns:

```php
<?php

if ($this->_results && $this->_className) {
    return;
}

// some code executed only when the condition is false
```
```
does this imply expandable:true?  What happens if you this set but that not set?
eh for this one don't need to close the div.container here. Let the div.container at the bottom of footer close it?
@rkatic agreed. I'd like to know more about the reasoning for all of the changes as well.
again, length is better.
Yes, I've done that already and @steveklabnik said to do it here also. My rails/rails pull request is https://github.com/rails/rails/pull/7851
Why are we continuing to use plpgsql with such reinvention of wheel??  If you have time to invest in this, simply convert driver UDFs to plpython.
re write this as:

```js
var modal = getModal(event);
if (modal) modal.classList.toggle('active');
```
Triple quotes are good for your docstrings
You should really double check spelling on your error messages :)
Maybe just say "HOMEBREW_PREFIX" instead of \`brew --prefix\`
This duplicates a lot of code from `by_index` -- could the functions maybe be combined somehow?
That just displays the count and should only be one line per run. I think it would be useful to have this in the log. I can change it to debug if you strongly feel otherwise.
I'm not wild on the use of `locals()` for these, it seems like unnecessary magic.  But maybe I'm being overly picky.
@daniel-uzunu: didn't we have a toThrowType mathcer that would be more appropriate here since we actually expect a specific type of RainError to be thrown here and we don't really care about the messages
hast du hier in der originalen datei gehackt?
Is this very important in this case?
This one looks good, may actually apply to open/netbsd as well.
* 宣言と初期化は1行でかけるので、まとめると良いでしょう。
   * UIImagePickerController *imagePicker = [[UIImagePickerController alloc] init];
* 変数の"*"は変数名に寄せましょう。
How about "Specifies the failure message for tests that are expected to throw an exception but do not throw any."?
Latest commit sets `this.workers = []` when all workers have shut down. does that do the trick?
`bind` binds the set of arguments to the function when it is called. We want to callback with `nextRun` as the second param, but it's messy to do

```javascript
return process.nextTick(function() {callback(null, nextRun);});
```

more info on bind: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/bind
This should be deleted too.
Would be nice if caller could operate on the object returned from registerContextMenu() and not have to call getMenu()
In this case, yes. These element's don't share the same scope.
No need to go through menuItemMap here -- you're just mapping the menu item ID back to itself.

Also, both this and lin e385 below can use the new Menu._getMenuItemId() API to simplify this code:
`menuItemID = this._getMenuItemId(command)` here, and
`menuItemID = this._getMenuItemId(command.getID()` below
Could remove this diff again since xit() isn't being used (in fact I sort of feel like we should avoid checking in any usage of xit() since it's so easy to miss -- commented out tests are much more obviously disabled).
Before this we didn't have a way to look up whether a user belonged to a group without loading the whole group from the db. (In the case of a large project, a group could have hundreds of users in it.)
css 內容應該和 其名稱一樣單純
.pull-left 用於做 float:left
則 margin 應該透過其他方式定義
Default should be taken from settings.
Better view names. Please, use class-based views.
Oh, I see. If optin is True, you add them to the record, otherwise they aren't added at all.
have to use `parseInt` cause the LESS variables have px
mixin svp
ok I got the test to pass - normally I don't use opendns.com on my laptop, I reverted to using big brother's DNS ( google) and test passes.

But perhaps a note in the test might warn others of this potential problem.
add more test cases here?
Finally got to testing if such a change would work. It does not. Could that mean lua_isnil, doesn't report correctly?
5) It's written in Julia. ;-)
On the line that is commented (which uses attr()), we do want to modify the 'original-title' attribute.  This is the default attribute used by tipsy.

If the comment is to apply to the previous line (which uses html()) ,that is actually the existing code; however, we wanted to change the text that was rendered.  In this case, I believe we can actually use html or text to achieve the same result; however, text may be more appropriate.  Will check and include in a separate pull request if needed (since this one got merged just before the comment)

Thanks for the feedback!
no ... i'm not quite sure what is going on here.  is this an attribute of the converge-ui directory itself in git?
simiar select(:id) and then collect
Ok, what about leaving the code as it is in the puppet module,  removing the options from katello-configure and setting `intstall_foreman=false` and `config_formeman=true` in `katello/modules/params.pp`, This will let katello-configure work as before, but the puppet module will be reusable (e.g. letting you install foreman on different machine, which can't be solved by rpms dependencies, or reuse the module with puppetmaster)
Instead of making this thing return ```Lazy<CancellationTokenSource>``` make it return ```CancellationTokenSource```. Then in your GetOrAdd, do:

```csharp
_connectionCancellationTokens.GetOrAdd(connectionId, key => new Lazy(() => CreateToken(key, connectionIdField))).Value.Token;
```
It's working well.

Just need a pass through `gjslint` :)
Ditto on `str` -> `basestring`
And as for why not use the exception approach, it's because exceptions are slow relative to `hasattr` when the except clause is triggered (factor of ~ x2 in my tests).  That's why they say not to use them for non-"exceptional" cases. But it's not that much of a difference, so the exception approach might be safer.
Not a big deal, but convention is usually just `ok` or `{ok, Something}`.
I agree ;) 
But I did not want to argue on this.
Ah, I see.  It was to silence a clang compiler warning with -Weverything.
A test with no assertions and no annotations looks like a mistake, perhaps add a comment, or assertion ensuring this isn't a mistake.
haha, sry, for that - ever after reading your comment twice i still read "doesnt make sense" :-)
Why not simply creating a class named API ?
This gem shouldn't be here. The newrelic gem is already included at the bottom of the app, as you'll see.
it'd be nice to move this modal into a partial
No it is OK. I delete the script.
This function seems overly specific.  Why not just replace it's one use with `extract_module_locals(1)`?  I see that there is an `extract_vars_above` function, but I don't think it's ever actually used.

Maybe I just bristle at the word above 'above'.  `extract_caller_module_locals` makes a bit more sense to me.
Let's remove this if we aren't using it.
really good, 
I just sed spaces after function I think. 
The only problem is with jQuery chain methods where it put everything on a single line. (need to find a good regexp for that)
I have to try putting // on line end to see if it stops, or try to configure it.
it also always put dictionnary with one key/pair by line for small dict as function argument is useless/less readable.
Used the starts_with helper function to see if the asset source passed contains two forward slashes, as thats how relative urls are started.
Этот файл вернуть нужно
You could have the following configuration:

    [remote "one"]
        url = whatever
        fetch = +refs/heads/*:refs/remotes/foo/*

    [remote "two"]
        url = other
        fetch = +refs/heads/*:refs/remotes/bar/*

    [branch "master"]
        remote = one
        merge = refs/heads/master

If I'm reading it correctly, `git_branch_tracking` for master will give me back a ref named `refs/remotes/foo/master`.  I cannot deduce that `refs/remotes/foo/master` is for the one remote without looking at the value of `branch.master.remote`.
One thing I noticed is that we are doing an AND for these filters. So if you select two topics or products, the documents/questions must have all of them to be returned in the results.

I am not sure if OR is better. Might be worth filing a followup.

Low priority as it only really affects advanced search.
The finally block needs to assume something outside had worked. 

So you could do this:
```connection=None
try:
    connection = self.database.connection()
finally:
    if connection: 
        connection.close()
```
why remove... pep8 blah blah
No-op formatting change.
This should be deleted. There is no reason to duplicate the code
It was done on purpose as this is a "private" class.
Constructors are always defined first.
This condition will never be fulfilled since PHP will only open one session at a time anyway.
This should be a camelCased name
I did it intentionally so that the root only needs to be retrieved once for all routes-to-be-deleted.
I would reorder these conditions as the second is less expensive, but it's just a micro-optimization :)
コメントありがとうございます。
OmniAuthの検証云々ではないのでいらなそうです。
修正します。
This looks not good to me. A constant like this! Also it changes the default profile picture.  I will go ahead and merge this for now. But we need to change this.
Some of these changes seem like duplicates of other PRs. We should review your rebasing-against-master strategy - for some reason these are showing up as new commits. Could be GitHub's fault but let's doublecheck tomorrow morning.
感觉越来越像ubuntu了……我认为最好别用年份，因为一旦2012写好了，以后每年维护的人可能都要修改一下，否则可能到了2016年用户发现还是12年的版本可能就不敢用了。2.3那个不知道是不是我理解错了，2.3修改好了正式发布应该就是3了对吧，那么目前如果正式发布的时候是1.0，那现在的版本就应该比1.0小至少
I guess you can remove these four lines.
If the image is a model of ConstImage, there is no range method
Maybe. But I'd rather leave that to a separate PR (preferably driven by some genuine need).
Could you put a new line in after the speech marks please?
just a suggestion?

does this means that python >= 2.4 is now required for building SW?

What about moving this line above, making Python optional and only upon checking for its success going into AC_ARG_WITH(python...)?
We don't need the module dependency. 

This is only used at runtime when running the management operations, so I think it should always work if the jmx subsystem is installed,  although maybe using the platform MBean server would be better.
This dependency will not be available in the release to nexus, but should be provided. Same for the three below.
The right way (for now) to set scripts is to use the instance variables, see :

https://github.com/jordansissel/fpm/blob/master/lib/fpm/command.rb#L309-328

For now, I think the intention is that 'script(scriptname)' always return the *contents* of a script, not the path to a script. So from your end, you are responsible (at least right now) for reading the file.

```
package.scripts[:after_install] = File.read("/path/to/script")
```

Makes sense? 

I'm super interested in making this easier with respect to API - how can I help there? Open to input :)
IIRC exceptions are raised when you call get_children() on missing paths.
I think only one transaction should be opened as the different numbers should be saved together
Did you mean to completely remove this?  (I see that 'switch-button' moved.)
Love the separation, but if this is for desktop testing, should we include it in the normal build?

I mean, in the phone we will load this piece and it's not needed. Don't know (really don't know) if is better to not to include it by default and people working on desktop include it in their copies.

:S 

Sorry for not being clear, but have my doubts ;)
This likely something is wrong in the manifest.
We have to define how to manage "icon" in our code. "<i>" was a suggestion about this issue. We could discuss it next week.
I believe this won't pass the linter.
I’d prefer a `<li><button>1</button></li>` instead. In general, I don’t think using `href="#"` makes sense.
Thanks!

I've taken a look at alert, confirm, prompt, HTTP authentication, select, and the permissions dialog and I can't see anything obviously wrong.

If anyone wants to double check it might not be a bad idea because to be honest I didn't pay that much attention to how they looked before!
Neither of these files include copyright or license information, so we should include a README file at least in the js/ext directory that says where the code is from, who wrote it, and what license it is released under.  Maybe ask @fzzzy where he found the code? 

@vingtetun: do we have a general policy about how to handle code like this from external sources?
What is the difference between 'contact' and 'c' here? If none, let's use c.id, c.photo to avoid confusion. (it starts to be too many occurences 'contact' version in the same function :( )
I won't comment this since @borjasalguero will soon land his refactoring of the `RecentsDBManager` :)
@jmcanterafonseca I'm missing the purpose of this method, don't know if I'm missing something or is dead code.
The basic idea is that two competing requests won’t come back at exactly the same time. Here we allow 8 (random number) of requests to come in at the same time and then be reshuffled so that the likelihood that the step on each other is smaller. Of course, it all depends on how long each operation actually takes but the assumption is that they are relatively fast.

Henrik

From: David Ebbo [mailto:notifications@github.com]
Sent: Thursday, December 27, 2012 14:31
To: projectkudu/kudu
Cc: Henrik Frystyk Nielsen
Subject: Re: [kudu] Updates to the git-backed VFS controller (#276)


In Kudu.Services/SourceControl/LiveScmEditorController.cs:

> @@ -31,6 +32,19 @@ public class LiveScmEditorController : VfsControllerBase

>          private readonly static MediaTypeHeaderValue _conflictMediaType = MediaTypeHeaderValue.Parse("text/plain");

>          private readonly static char[] _quote = new char[] { '"' };

>

> +        private readonly static TimeSpan _retryAfter = TimeSpan.FromSeconds(2);

> +        private readonly static int[][] _delaySets = new int[][]

> +        {

> +            new int[] { 0, 20, 60, 30, 170, 110, 320, 1280 },

> +            new int[] { 10, 30, 40, 60, 0, 30, 890, 1140 },

> +            new int[] { 0, 10, 20, 100, 140, 590, 180, 1280 },

> +            new int[] { 10, 20, 70, 130, 290, 510, 1150 },

> +            new int[] { 0, 30, 50, 0, 110, 430, 1280 },

> +            new int[] { 10, 0, 20, 40, 260, 350, 1160 },

> +            new int[] { 0, 10, 0, 70, 80, 270, 1280 },

> +            new int[] { 10, 30, 60, 110, 230, 190, 1170 },

> +        };

> +

I still don't understand what it gains from cycling through 8 similar yet different sequences instead of just using one. But maybe you can explain that to me in person later!

—
Reply to this email directly or view it on GitHub<https://github.com/projectkudu/kudu/pull/276/files#r2512174>.
may not even be worth catching if history.state is available.
This should probably be 256 or get the world height seeing as we have words much larger now.
"initialising" is correct british english
Why would you delete the target directory here? what if you didn't create it (it exists before tableslurp runs)? I think you can drop the finally block here since you dropped the temp file testing above
File is a built-in function, this variable should be named something else
Same here.  Go back to joinWithTiny and remove TODO.
Again, use `self.assertEquals`.
The placement of this comment makes me think that there should be some blocking function which waits on all the roles to come up and load. Should this been before add_nodes line right above?
The @Exclude annotation notifies that the annotated class should not be transactified. 
With in-place metadata ALL arrays are transformed into specialized objects, which hold both the original array and its elements' metadata. The @Exclude annotation maintains its semantics (that is, do not transactify this class) but nevertheless arrays are still instrumented. The new @ExcludeInternal annotation is stronger, the class is not transactified and its arrays are kept unmodified.
This description has no meaning to me.
Every function has $override parameter which can be used to ignore Kunena configuration -- and to display data in the backend.
`$.on`d on connection error. is it really worth the trouble to cancel delete requests like thread expansion?
Any issue here with cached schemas vs raw schemas? We do a listkeys over the raw schema bucket and call `get_schema` which will return a cached schema, or trigger a `gen_server:call` to this server to retreive the raw schema, parse it, and write a cached version. So, all raw schema not already in the cache will be parsed and loaded.

On a related note, could we augment the schema cache somehow to avoid needing to do the listkeys?
At that moment I thought that ssid was part of the pickle (and sourcestampsetid would get part of the pickle) so I had to copy the id to the setid. Later I found that ID's are not stored in the pickles so self.sourcestampsetid = self.ssid would always result in None. I wrote a successfull unittest that contained a ssid but that was not conform the truth.
How about optimising a bit this instead?

```coffeescript
callback ?= (view) =>
  display = if included then '' else 'none'
  view.$el.stop(true, true).css('display', display)
  # Update visibleItems list, but do not trigger
  # a `visibilityChange` event immediately
  @updateVisibleItems item, included, false
```
This is not intentional and shouldn't be deleted. See my other comment.
This is useless since the default: entry continues already.
i tried that, but it doesn'l look good.. ^^
sorry, i branched this from my other pull
As far as i can see there is no such option in NginX. But i will check this in the next few days.
This will fail:
* there is no `:new_noteable_id` column any more
* all commit notes will have `:noteable_id` equal `NULL`

`raise ActiveRecord::IrreversibleMigration` would be simpler. ;)
I have set up a new branch and pull request for the features discussed above as I'm concerned this branch will get a little off track from the "front texture" work otherwise. It's here: https://github.com/guardian/frontend/pull/95
that's fine, but we still need a way of changing the host, and as it works on the dev's computers it should default to localhost
Similarly, `bleach.clean` is not needed here and may be harmful.
I may be missing something, but It looks like `model` is no longer useful and we probably be better of by accessing `pbService.privateBrowsingEnabled` directly.
This kind of looks like the same code in scrum/includes/macros.html. I'm skimming it, so I could be wrong.
else isn't necessary
don't particularly like the name "readwrite", perhaps "io" ?
dict subclasses may raise KeyError, where other classes raise AttributeError (especially "attributes exposed" dict subclasses)
So.  qq. I am just adding tests to the Chrome apps generator and I need to
pull in grunt for the template rendering, it seems quite heavy weight just
for one small-ish component, but at the same time I might end up defering
more work to other parts of grunt :\


On 26 November 2012 14:22, Sindre Sorhus <notifications@github.com> wrote:

> In test/test-api-v2.js:
>
> > +  before(generators.test.before(path.join(__dirname, 'temp')));
> > +
> > +  // generators is an instance of event emitter.
> > +  it('generators is an instance of EventEmitter', function() {
> > +    assert.ok(generators instanceof events.EventEmitter, 'Not an instance of EventEmitter');
> > +  });
> > +
> > +  it('generators.Base is the Base generator class', function() {
> > +    assert.equal(generators.Base.prototype.__proto__.constructor, events.EventEmitter, 'Not an EventEmitter');
> > +  });
> > +
> > +  it('generators.NamedBase is inheriting from Base generator class', function() {
> > +    assert.equal(generators.NamedBase.prototype.__proto__.constructor, generators.Base, 'Not a Base class');
> > +  });
> > +
> > +  it('can be hooked using a grunt instance, from which we read cli tasks and options', function() {
>
> I think we should remove all grunt reference from the Generator system. We
> don't need it and it has only caused us problems. I'd rather see us just a
> the arg parser directly. What do you think?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/yeoman/generators/pull/141/files#r2222006>.
>
>
Instead of 'c'  you can use DateTime::ISO8601
Incorrect type `type`
Add `(bool)`
yep, it's showing as correctly indented for me, so will just delete all the spaces and try again
Indent this block
No, this is a stub at current.
See @spako 's comment.
Sizes are normally of type Int. The fact that you are using Float suggests that perhaps "nodeSize" is not the ideal name.

also "leftMap"and "rightMap" are not so informative. These names just say where the maps come from (left or right), but they don't say what the maps store. The issue, maybe, is that "Float" itself is not very informative, and hence "Map[E, Float]" doesn't tell the reader what your maps are actually storing. To improve this, I would suggest choosing one of the following approaches:

1) improve the name of the maps.

2) create a local type alias for Float, with a name that semantically explains what is stored in the Map.
@mike-sandler I belive there is no extensions guaranteed to be available. You should install something like *postgresql-contrib* package. I'll reflect this in README.md for Ubuntu. Please let me know the name of the package in Mac's package managers.
A good reference is the GNU Autotools index on environment variables:

  http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.68/html_node/Preset-Output-Variables.html

For example, `CPPFLAGS` is described thusly:

> This variable's contents should contain options like -I, -D, and -U that affect only the behavior of the preprocessor.

As opposed to the description of `CFLAGS`:

> If a compiler option affects only the behavior of the preprocessor (e.g., -Dname), it should be put into CPPFLAGS instead. If it affects only the linker (e.g., -Ldirectory), it should be put into LDFLAGS instead. If it affects only the compiler proper, CFLAGS is the natural home for it.


Even if a project does not use GNU Autotools, their conventions for environment variable use form a "de facto" standard that buildsystems are expected to follow.
Ah that's the variable I was thinking of. What's the stance on the web server - I see datainsight using unicorn while most other apps are configured for webrick in the profile
We at BC have patterns we apply to extension copyright documentation. One of them is the existence of a clear copyright assignment file with clear documentation on the license of the copywritten works, outside of the ezinfo and extension.xml standards. This file provides for both of these concerns very well for other projects, we think each extension should have one.

We think having doc/LICENSE is simply not enough as that is mearly license distribution not assignment, though again these are BC standards. A README.md is often considered enough but we believe it is better to be more clear than enough.

Duplication here is minimal and would change very infrequently.
Instead of returning strings we should put asserts in here:
```python
self.assertTrue(sorted(files) == sorted(zf.namelist(), msg="error: ...")
```
this looks like a bad idea to me: this code can take lots of time (see the ``set_time_limit`` call and you are making the user wait for it.
`#{self.to_s.downcase}s` should be `#{self.table_name}`
I get an error saying `model_name` is undefined without Validations
I know, but PHP does allow it :)
I asked @docb22 about this way of hiding things from interface and he is ok with it.
the code indicate `SOURCES_GENERATOR`, the doc is `SOURCE_GENERATOR`.
Two spaces in front of inline comments.
Maybe merge these two (same in `DtoCheckPragma`)?
Maybe rather than casting everything to a string you could just call $resource->getName()
part c - line 79-91
.blank? is better
Add a new line, please.
Double quotes are for HTML and strings with apostrophes; single otherwise. 

Matthew Riley MacPherson | http://lonelyvegan.com
(Sent from mobile)


On Friday, 20 July, 2012 at 13:30, Owen Coutts wrote:

> > @@ -39,7 +39,7 @@ html {
> > body {
> > background:#f5f1e8 url(../img/mozorg-gradient.png) repeat-x top center;
> > padding-top:60px;
> > - font:16px/24px Georgia, serif;
> > + font:16px/24px 'Open Sans', "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
> > 
> 
> 
> Are we single or double quoting things?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/276/files#r1207400
> 
>
Thanks.

Updated it in 1d10c1ee2d5d52ab98b9e54224695f8cac6abc68.
this was killing me for so long.
does it make sense for hash[:error_msg] || object.errors.full... ?
Does the DOM Elements never get deleted when this return is reached?
I remove the format part. Logging in the current culture format should be the result the user expect
not really part of this changeset, but why is this 1? It looks to me like this was meant to be `i`, and it also looks like we should be updating `lowestSSE` here as well.
this still
This should be variable, based on how many bytes are actually required to store the length value, not hardcoded to two bytes.
ну это.. как его
Can we use delegate.parseIdRefElement here?
This would cause problems if you will download from an URL which has parameters via `?` attached. Please see our automation testrun scripts how those figuring out the right filename.
With the above comment it would have to be updated to mozdownload:cli
Sorry, that should have been `bool` and `true`/`false`.
Not sure that having to set null here every time is ideal when you want the short format. Maybe adding static methods for getting the short format and the long format would be ideal?
When deleting the file, we do a `getRevisions(.., 1000, ...)`, which means that we'll do a huge multiget. This is proven to be very slow and will be blocking the app server. Is it necessary ?
Should probably be `enabled` to be in line with the application
Should `isUserPrincipal` be renamed to `isUserId` to be consistent with the change made to `isGroupPrincipal`?
Ah overlooked that one. I've removed the defaulting as it's not really an optional method.
Is this new on the global tenant API? Will likely need to be moved to the PrincipalsAPI init.js file.
There are 3 options:

1. package.json sets a main of api.js; I create an empty api.js; Context sits in model.js, and to require you use: `require('oae-context/lib/model').Context`
2. package.json sets a main of model.js; Context sits in model.js, and to require you use: `require('oae-context/lib/model').Context`
3. package.json sets a main of api.js; Context sits in api.js; and to require you use: `require('oae-context').Context

I thought 3 was the best option. Do you prefer #2? In this case, having a main of model.js will make introducing an actual context API a larger impact to existing code (though, "requiring" oae-context should not happen very often any way).
This makes sense as a change, but you should note that you break all plugins with this change ;-)
@davidtyh But the Parser functions here doesn't support multiple shape list. Am I right?
Is there a reason for the custom log handler here?
Two paragraphs down.  I'll change the label back to "Initializing the Class" does it need to be shifted back up?
Он плохо читается, честно. Особенно не сразу понятно было, зачем rangeOfDNAElements = (C + 1) - A
Странно... интересно, откуда такой большой оверхэд... Проверьте еще раз, избавившись от повторного приведения к NSString и подступаясь к элементам как arrayOfChars[i]
"Из процента ещё количество элементов для мутации нужно определить."
Зачем? Элементов всё равно 100. Стоит ли придираться?
nevermind, saw the clarification below
Probably does not need its own subsection anymore.
java.uti.HashMap allows null keys and null values.  In this specific case probably never going to happen, but you should check other places HashMap is being used and keep in mind that map.containsKey(key) can return true and the value can still be null.  You will need more explicit guard against such cases.
I don't know anything about anything, but maybe we should just provide something like an "autoconfigure" callable. Right now we're treating the inclusion of a file as that.

(This is in general, not just the Sidekiq stuff)
This method needs to synchronize on `self` to match the addition.
Why do we have this and `+backgroundScheduler`? They're almost identical in behavior.
Creates a strong reference to self in the current scope (^RACDisposable *(id<RACSubscriber> subscriber))
Hmmm, do you mean I need to use tabs, not spaces? It looks like the project is using tabs, and I'm using spaces.
Hmm, something is off here.  Did test.sh do this?  If so, please revert it manually and file a bug to fix test.sh.
I assumed these are all real numbers, hopefully that is the case...
These actually don't respect the preceding pl.subplot() commands, and take over the entire figure. Should I change this behavior in the .plot() method?
... working on a draft...
this will tell me, how easy it is actually, then it will tell us :)

On 29.10.2012, at 18:58, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/artifacts/ica.py:
> 
> > +        Returns
> > +        -------
> > +        fig : instance of pyplot.Figure
> > +        """
> > +
> > +        sources = self.get_sources_epochs(epochs)
> > +        fig = plot_ica_panel(sources[epoch_idx], start=start, stop=stop,
> > +                             n_components=n_components, source_idx=source_idx,
> > +                             ncol=ncol, nrow=nrow)
> > +        if show:
> > +            fig.show()
> > +
> > +        return fig
> > +
> > +    def find_sources_raw(self, raw, target, sources=None, score_func=None,
> > +                         start=None, stop=None, sort_func=stats.skew):
> Yes, so I think making _find_sources a method, making it smarter so that it handles x-arg and x-y arg score funcs and making it update the .sorted_by attribute would do the trick. Shouldn't be too much of an effort. As a result we would drop sort_sources and we would get around ica.argsort_sources_epochs_very_long_method_name(epochs) ^^ Wdyt?
> sounds good. I would however see while coding how much lines it adds or better removes :) it is a bit hard to tell without a close inspection of the code
> —
> Reply to this email directly or view it on GitHub.
>
an inplace option would be desirable. experimenting is more fun then.
That sounds great to me. And for now, if you want, you can make it so that 'multitaper' is the only supported mode. Or if you really want, you could add a 'dft' mode, since that shouldn't be too hard (that's just a special case for using one multitaper, right?). That way, we'll be future-compatible for adding those other methods when people want them.
My previous comment still stands
Why keep this jsp around?
Should this not just be deprecated rather than deleted to maintain backwards compatibility?
Can we accomplish this same thing by not re-implementing so much of the parent `run` function? For example, couldn't we do `$this->setCatchExceptions(false);` and then call `parent::run()` inside a try-catch?

Also, I think `doRun` might be a more proper method to override, only because that's typically the purpose of the `do*` functions (to offer a clean override hook).

Thanks!
I'm sure this list is not exhaustive, but it is certainly a better start than just `Errno::ECONNRESET`, alone.

I should mention that when I say "over the past several years," it's because I actually do keep a list of them as they happen.  And, in pretty much all of my applications that use Net::HTTP in some way, I have an `HTTP_ERRORS` array setup via initializers (config/initializers/http_errors.rb) which I use by wrapping the Net::HTTP interactions with a begin; rescue; end block for them.

My personal implementation is nearly identical to what's in this pull request, except that I have a few more exceptions in the array (like Timeout::Error), which didn't seem necessary for this implementation (as Faraday already rescues Timeouts).
Done and added to the pull request.
It's not that big of a deal :)
Error in merge I guess. Fixed.
Sorry, but I don't get it ;-). The message is exactly the same as in any other durable mailbox. Can you please clarify?
¿Es a drede ese '\9`? Si es así, ¿qué hace?
Vaya a saber..., pero lo hace. Si te fijás en las anotaciones de MigrationsController vas a ver las referencias a estas entradas de configuración. Es cierto que deberíamos revisar esté código, yo lo encontré por ahí y no lo revisé cuidadosamente aún.
I have merged your code on my  [branch](https://github.com/arlm/antiscroll/commits/pull-resquest), wich is indeed correct. After my pull-request is accepted I can do another one here with your fixes.
missing space between -> and (
What happens when the remote file doesn't contain version?
There is not a need to be exactly equal. Is just to maintain the default of non clustered queries... I've added a comment. :)
https://issues.jboss.org/browse/ISPN-2401. I updated that todo comment to reference this issue.
Ah, it's because that's the only accessor for this property. That behavior makes sense, then.
i think the convention is to have these file names lowercase. if you fix, you should also change the actual filename to lowercase, to not break on case sensitive filesystems
Probably needs to be wrapped.
On 2012/07/20 5:20 PM, Benjamin Root wrote:
>>               if self.extend in ('both', 'min'):
>> -                self.layers[0] = 0.5 * (self.vmin + self._levels[1])
>> +                self.layers[0] = -1e300
>
> I hate magic numbers like this.  Maybe we could use np.INF and np.NINF?

I thought of that, and may yet do so; but I wanted to get out a fix that 
would work, and could not take time to test whether potentially 
dangerous things like INF would cause trouble in practice. Note that mpl 
has other somewhat arbitrary special numbers, because they make it work 
most of the time.
We should remove this print.
got to fix this, it's something I left from an attempt of changing the structure
Shouldn't we also have this in style.css? style.css is what people building apps targeting both desktop and mobile use.
@gsilver Can we remove this `console.log` message?
This still feels like a crude hack. Have just spoken with Hamish, and there is a better way to solve this timing issue. 

The more specific selector will always first (.ss-tabset.ss-ui-action-tabset), so it all depends on when you call this._super(). So this even handler could be replaced with something like:

```js
onadd: function() {
  // Make sure the TabSet has already been applied.
  this._super();
  this.actionTabs();
}

// Remove redraw, it actually doesn't do anything meaningful...
```
In the file head explain why you used call methods but not inheritance.
Yeah, I had followed Tom R's precedent without knowing what was the "right" way. But it seems in his latest PR he has removed the back ticks from exception messages, so I have fixed this in 5e76456.
Why does the encrypted stream not end on destroy?
Done in aktueller Version
This part won't work right now, because `extendArrays` expects an array of arrays. However, extendArrays could be easily modified to iterate over all ownProperties if the first argument is a object instead of an array.

We should write a test that exercises `extendArray` in this case. If you want to assign that task to me, that's okay.
Comment added. I've reformatted as well.
Resolve a naming conflict under GCC 4.7.x stricter scoping rules.
REQUIRED: This looks like it fits on one line.
```js
var self = this;
var cloneNode = function(){
    return self.cloneNode(contents);
};
```
This exception should be in the logs
Its not too relevant, at least for this bug - the code throws an error, or doesn't. Happy to contribute other test coverage that targets the method in a separate pr
then why do we use it if it doesnt work on 1.87?
`$perllocalpod` is not always an arrayref.
minor: You only use these variables once, so maybe just leave them as fields on `task`. Your call.
Why we need user ID exposed?
User visible string.

There is also one other way to do this. Is that you remember the initial state of the textbox and in JavaScript just restore it back every time. So that you do not have hard-coded string all around. Because this means somebody has to keep all this in sync. What if somebody changes text here? How can she know where to change everything else?
No, also subject should be in the template. See [here](https://github.com/wlanslovenija/nodewatcher/tree/master/nodewatcher/frontend/templates/registration).
See how it is done in #252.
Logout? Why logout?
Add here also users.
you mean smat_unicode or complet methos to move to horoscope.py??
Is it *in case* or *in the case*?
Undoubtedly. They actually are defined as constants in TBSite, but because that isn't compiled into the Auth tool, I can't use them here. A shared file between them would fix that.
A general question about these tests:

As far as I can see, there are plenty of tests that verify the uniqueness of numbers, but are there any tests that verify the interval progression of numbers?

E.g. with the default limits, I'd expect the first 255 numbers to be less than 256, and the next 32,512 numbers to be less than 32,768 but greater than 255, etc.
Please include a comment on what to use instead when deprecating things though. :)
I don't know if we need to distinguish between user-originated and network-originated disconnects in order to signal that there was a disconnect.  As it is, this code will actually pop up a dialog box in the RedPhone UI (with no message in it), which seems a little harsh for a network interruption.
I think it is not a bad idea to log to the console too.

Also, what will be display for such an error?  I imagine the raw exception
is not a nice thing to show, which is why a log to the console would be
useful.

What would be really cool is if one could plug in different handlers for
different situations - like ones that log to a file, database or email...

Pete

On 21 October 2012 18:37, Pawel Kozlowski <notifications@github.com> wrote:

> In src/common/services/exceptionHandler.js:
>
> > @@ -0,0 +1,12 @@
> > +angular.module('services.exceptionHandler', ['services.notifications', 'services.localizedMessages']);
> > +angular.module('services.exceptionHandler').factory('$exceptionHandler', ['$injector', 'localizedMessages', function ($injector, localizedMessages) {
>
> Yes, it will override the default one. I was wondering if we should
> delegate to the default one as well (it just logs an error to the console).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/angular-app/angular-app/pull/72/files#r1898899>.
>
>
Named non-optional positional arguments, again.
r_assign? not really self-documentary ;)
ok, I understood. I will correct this problem.
I think this implementation is better, but there's still one thing I do not like. The side effect of using this function is that it alters the input parameter $headers by sorting it. I suggest that you extract keys into a separate array and sort it instead of sorting the original array.
I assume we can't just use `asprintf` because of solaris?

Could we just add a `noit_vasprintf` and `noit_asprintf` based on this code in virgo?

https://github.com/racker/virgo/blob/master/lib/virgo_portable.c#L28-57
display => displays
Oh :)

then write l() please
I would not make a constant for that, IMO it would be harder to read. 204 is not magic in this context.
Don't need "Do all the intialized work for this fetch"; what else would "NgxFetch::Init" do?
Oh let's definitely fix that in mod_pagespeed then :)  Can you send a diff?

-Josh



On Tue, Nov 20, 2012 at 8:54 AM, Otto van der Schaaf <
notifications@github.com> wrote:

> In src/apr_memcache2.c:
>
> > @@ -0,0 +1,1791 @@
> > +/* Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements.  See the NOTICE file distributed with
>
> I agree, however, the reason I pulled this file in is that I made a few
> minor changes (we use strict compiler settings, and fix for a segfault on
> the first request, when all memcached backends are down).
> If these changes could be merged with the original file in mod_pagespeed,
> we could remove this file.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pagespeed/ngx_pagespeed/pull/65/files#r2180660>.
>
>
Why not get this with `NSUserDefaults`?
after merging OLSResults is now duplicated

I don't think we need separate headers for general and specific results classes
what's the difference between ``mu`` and a ``mean``?
If ``mu`` always refers to the mean (expected value), then I would call it ``mean``, so I don't have to guess if it's not something else.
Didn't we discuss using this type of hash traversal in a few other places too?  Can we move this into a module and mix it in to those places?  I'm thinking of plurals and calendars.
I guess so. Don't worry, when I process more CLDR data and get a more complete list of locales tailorings, I'll filter these resources to the regular list of locales we support for other features.
Please use underscores between words.
Translatable strings also in templates.
ok, i'm not a fan of using underscores for *private* vars, but i agree that this is a better idea than what i'm doing. and so i'm doing that now.
also didn't we at some point decide to make dx, wmult into some more descriptive names?  Or maybe that should go in another issue.
I think that's about as good as we're going to get for now!  In the grand scheme of things, it's a minor point anyhow. Minuscule even :)
I like to preserve `get` methods for things the just return a value that is already stored.  However, I think this method calculates the matrix each time.  For that, I think the name `calculateCovarianceSymMatrix` might be better.  

Alternatively, since I think this class is immutable after the original construction, you could have it store a pointer to the SymMatrix.  Then the first time this function is called, it would calculate it (`smptr.reset(new tmv::SymMatrix<...>(...)`) and return `*smptr` as const reference.  This would also save the gratuitous copy on return that may or may not be optimized away by the compiler.
That's good.  I like the notation with the italicized size.  On more thing I noticed here.  All FWHM parameters should be fwhm.
Same here, I will perform manually the generation...

Thu, 4 Oct 2012 16:48:34 -0700, Thomas Gazagnaire :
>
> In packages/liquidsoap.1.0.1-full/opam:
>
> > @@ -1,14 +1,20 @@
> >  opam-version: "1"
> >  maintainer: "contact@ocamlpro.com"
> > +substs: ["opam.patch"]
> >  build: [
> >    ["cp" "PACKAGES.default" "PACKAGES"]
> >    ["ocaml" "str.cma" "unix.cma" "opam.ml" "sed" "_add_expr_" "56" "ocaml-aacplus" "#ocaml-aacplus" "_add_expr_" "92" "ocaml-ladspa" "#ocaml-ladspa" "_add_expr_" "115" "ocaml-dssi" "#ocaml-dssi" "_add_expr_" "122" "ocaml-xmlplaylist" "#ocaml-xmlplaylist" "_add_expr_" "126" "ocaml-lastfm" "#ocaml-lastfm" "PACKAGES"]
>
> same here, you forgot to remove this one as well
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/OCamlPro/opam-repository/pull/105/files#r1768317>.
>
now our route is campaigns/id/manger, user can type campaigns/999/manger to go to the campaign with id=999 even id not exist...
We have to decide whether amounts are in dollars are cents

It doesn't matter which, but pick one
That's fine with me. Will update this soon.
Surprised that guava doesn't have a simple method for this already. Closest thing is:
```
MapDifference<K,V> diff = Maps.difference(sub, bigger)
    return diff.entriesDiffering().isEmpty() && diff.entriesOnlyOnLeft().isEmpty()
}
```
Is the `forall` here necessary?
Have you tested this view after removing the `:locals` argument?
do not extend ActiveRecord in lib, use Railties for that
Agreed, will update
Nice example of `stub_const`. It's a big hammer, but this is a perfect case for it!
I had to do this because the guzzle client https://github.com/AllPlayers/allplayers.php/blob/master/Component/HttpClient.php#L42 is a protected variable, and i have to utilize guzzle client methods here https://github.com/AllPlayers/allplayers.php/pull/10/files#L7R46, if ClientFactory was not extending the allplayers client I could not access the guzzle client variable and I couldn't use its methods when I instantiate the client factory, this can be solved by extending our httpclient to guzzle's but just tried it and there are blockers there, like the get post and put methods overwriting guzzles https://github.com/AllPlayers/allplayers.php/blob/master/Component/HttpClient.php#L222
Please advise how to continue.
I can leave DMA enabled and try to get it working and eventually figure out if there is a problem or not.
Actually if it is working for you it may be that its just flawed the way how i try to use it.
I really would like to get this one merged as my ports rely on serveral things from this.
Passing in the name isn't needed, can you remove it, please?
This seems a little odd because site is a URL but prefix is the first part of a path.
Что означает этот комментарий?