labofsahil/github-event-dataset-2012 huggingface dataset:
We could use as_int if you like. Alternatively we could just let this raise
an error. Which would you prefer?


On Fri, Nov 2, 2012 at 9:45 PM, Christopher Smith
<notifications@github.com>wrote:

> In sympy/matrices/expressions/matmul.py:
>
> >          assert len(tail) != 0
> >
> >          X = head
> >          Y = MatMul(*tail)
> >
> > -        if X.shape[1].is_Number:
> > +        if not isinstance(X.shape[1], Expr) or X.shape[1].is_Number:
>
> Yes...I need a little cheat sheet to remind me when I'm going to get
> burned by certain expressions. I had tried
>
>
> >>> type(S.One) in (int, bool, Integer)
> False
>
> and so I suggested the more verbose form. What you have works, however.
> Does MatExpr use as_int? so a float doesn't slip through?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1608/files#r2023029>.
>
>
No. I am not able to differentiate between tuple of expressions and tuple of ranges as both are of length 3.
Yes, that's exactly what they are.
I think this is the only line that needs to call expand.
You could also use an rst table.
Are these intentionally name mangled?
Remove the `\`.  That makes it show all the whitespace on the next line.  Instead, write it as

```py
raise NotImplementedError("Some functions in the expression %s are "
                          "not supported.  Kindly report this as a bug." % self.expr)
```

In Python, string literals that are next to one another are automatically concatenated (like `"a" "b"` -> `"ab"`), which is why this works.  Just remember to put a space between the words when you do this!
Are there any other functions that as a Basic you should provide that are affected due to dependence on non-Basic types? 

I guess I'm probably biased towards using ImmutableMatrix but I think it would solve these sorts of problems simply. Is there a reason why you use the more complex MutableMatrix instead? Do you need to change entries on the fly?
Again, should be in a separate pull-request.
@klimov-paul, reasons:

1. These static variables used only in `getMimeTypeByExtension()`, so making them class-wide static properties would just make entire class more complicated (more class properties → more things to understand).

2. Method itself is static.
Created an issue for this
Would you mind highlighting the word 'this' in the above (e.g., ...believes that "this" is a...)?  I think that will assist the would-be reader who might otherwise have a hard time interpreting the sentence in isolation.
I've just looked into pyramid_fanstatic.  If I understand correctly it would indeed be not so easy to drop fanstatic when you want to manage resources youself.  OTOH configuration would become only a *little* bit easier (if at all…).

Therefore: -1 on using pyramid_fanstatic from my side (YMMV).
I just asked my roommates, showing them different versions of tree, and they all prefer the small `s`.

Would you go for the `search…` compromise?
The reason for it mysteriously disappeared
yuck - how could I detect this (special) case within my serialization so I can at least throw a NotImplementedError (it seems YAGNI for now)?
You can infer all those details if you're willing to go to the database with specific calls for each object. The point of the `TargetObject` is to allow all the data for making the decision to be encapsulated so the UserDetailsAdapter doesn't need to make any further database calls. I'm also aiming not to do database lookups in order to do work out authorisation.
What parents are we expecting this to create?  Auto-creating directories for paths that are meant to be methods of coordination between multiple services just leads to typos causing split-brain disorder and a helluva time debugging.  If there is some parent dir that it is well known might not exist at this point, let's check for it and only it and make it exist.
we should have a link here to the limits page here.
db.printShardingStatus() isn't a dbcommand.
I would just change the name to match the context in which it happens.
Заюзай плз дефольтный json, который `tests/01.json`.
Там все есть, я не хочу плодить лишние файлы.
If both work fine why should it be forced to use ==?
If more devs support your opinion I'll change...
This part I don't understand. It seems quite off to me. Any output of a controller is automatically passed into `trigger_error`? How do you send output that isn't an error?
Do not add the current post to the revisions array. Just add a get_current_post() method that returns the current post data.
I disagree. See e.g. http://thewritecorner.wordpress.com/2010/01/28/punctuation-%E2%80%93-inside-or-outside-quotation-marks/
Describe return value?
Capital letter in comments
…I don't even know how to reply to this
Then you just have the TimeSync object listen to these events on the promoted object.
И аз бих предпочел да го викам с `:format`, но в точно този invocation няма как да стане, понеже това:

``` ruby
render :format => 'html', :activities => activities
```

ще дефинира локална променлива `format` със стойност "html". Пробвах с `render :partial =>`, но нещо пак не сработи. Иначе това да се подава extension съвсем наскоро разбрах, че е възможно ([от един ruby guide](http://guides.rubyonrails.org/layouts_and_rendering.html#using-render)), така че и аз нямам идея дали е deprecated или не :).
I think this comment can go away now that we have the `adapter.error()` call.
I don't think that ``@alias`` is standard in phpdoc
Minor suggestion: it's better to name vars more descriptive way than 'tmp', e.g. 'attrArray', this simplifies code reading.
+1
Beautify the code before sending the pull request.
This should be fields, correct?
Removed in my PR.
Are these 4 lines necessary? Won't they on;y ever be in degrees if they come from *_get_lat_lon_coords()*?
prolly best to remove these comments?
we don't use comments like this elsewhere.
Such a messy solution. But its not your fault...
Some acknowledgment that this is a hack of expedience would be appropriate here, like

# HACK
# this should really be an Env feature since function should not depend on the details of the gradient mechanism
# but this is so easy that I'm just doing it like this for now. - Ian Goodfellow, Aug 20 / 2012
add line breaks and comments
Actually, it should be enough to do:

return self.splunkusage_set.exists()
We really need a docstring here describing error conditions.
The building of the hashtree in `maybe_build` links the building
process to the index hashtree.  If this build crashes then the index
hashtree crashes.  Since the index hashtree is linked to the vnode it
then will also cause the vnode to crash.  Do we want this behavior?
Also, since this is a spawn-linked process it does not sit under a
supervisor.  Have you considered having a simple one-for-one that
these pids can live under?  That would make it easier to see all the
hashtree builds that are running and kill them if necessary.
Indentation on lines 47-53 looks incorrect to me.
Please use ``{@inheritdoc}`` instead of duplicating the phpdoc
is it a typo?
I don't want to remove also the computed output folder.
Andrea: Okay that's fair. But what about issues 1 and 3 (noted above)?
Wait! You're right. What about `cssExpand` instead of `jQuery.cssExpand`?
I didn't realise that function existed. This request has already been merged so you'd have to open a new one to make the change.
It looks like you create a hash table every time the function gets called (i.e., per one SELECT func()), which seems to me expensive.  Why do you need a hash table instead of plain memory chunk to store those information?
your wish is my command.
done :)
I think I'd pull search_happy out of the request.GET above and then if it's not None do the data validation here and if the data looks ok, apply the filter.
The option should get added to the options array as well.
I think, if we are having "different" context it's nice to "unify them a little bit.
So we can have a self-reference getter of Context:

``` javascript
getter(Context.prototype, 'context', function () {
  return this;
});
```

And something similar right before calling `func` as Stylus helper:

``` javscript
this.context = context;
return func.call(this, o.a, o.b, o.c, o.d, o.e, o.f, o.g, o.h);
```
This is actually harder to read than just using 0 (you have to look up the method, plus someone could change it, which we don't want).  If a command has to report a failure, we actually have a pretty good mechanism for that (exception).  The other mechanism is to return a constant value.  Treating nil as 0 is probably better than having a separate method someone has to understand - for instance, reading:

    (success 'All systems running fine' and return) if open.blank?

has one less thing for someone to understand.  If the user needs to handle an error, they return a non-zero exit code.  

Basically, we don't want people redefining success - it's either 0, returning nil, or returning a constant, but not returning the result of a method.  We want the contract of the command methods to be either throw on failure, return a failure code (when the command is useful in bash scripting), or to be successful.  By removing the need to have a constant or value for that last case (which is the "standard path") we can reduce the number of things someone has to consider.
The commit/rollback was there before, and Kevin changed it to sync. I didn't really look into it. But I think it's good. We don't need a sync here because getting {ok, RowData} means it was a select query. I'll add a comment.
@bartv2 It's a good commit besides the small things. Shouldn't this just be merged?
Made third_party_id_expiry a config option
nice w/ the xor
'ssl' statt 'transport'
I'd prefer to check ```if(typeof item === "object" && item !== null && item.title !== undefined)``` so that non-strings get coerced to strings instead of resulting in an error.
ooops, sorry!
Sorry if I've been confusing.  What I mean is that I find inline comments like this (especially without spaces) hard to read.  So I'm recommending:

```
//Let the process/application complete after timeout expired.
thread.setDaemon(true);
```
No need to waste stack space on `set` :smile:
Shouldn't you look up the chunk here?
should probably rename this method to applicationDocumentsDirectory
5667 looks like a magic number. Replace with constant?
If a provider returns true for hasHints(), but returns null from getHints(), should the CodeHintManager poll the lower-priority again to see if they have any hints?
In general, do we expect people to be passing around and holding onto actual MenuItems, or onto their IDs? If they're going to be dealing with both, then our naming should distinguish between the two, so these should be called `getParentMenuItemID()` and `getParentMenuID()`.
Done (in FindReplace.js too).
I'm not clear on what "removePrefix" does and how it could ever be anything other than true. Please add describe in JSDoc section.
Yeah, good catch!
The reason it grows by 1 is that we're missing a check in ``addPopUp`` ....

```
function addPopUp(...) {
  ...
  if (_popUps.indexOf($popUp[0]) < 0) {
    _popUps.push($popUp[0])
  }
  ...
}
```

I think I see another problem in ``removePopUp`` as well.
This change might be wrong. It seem to change behavior a lot. The original behavior was intended to support right clicking on tabs that are not active. This change removes that behavior.
Indent regression?
The 'copy' action here should be available in readonly mode I think
gotcha, sounds fine for now then.
If this exception is raised, this method will leak memory.  You need to make sure that the structs you're filling out (like `odb` and `obj`) get freed before raising the exception.
*token* -> *facebook_token*?
Registration form now extends auth_forms.UserCreationForm yet again.
Please switch these all to classes
Is zindex needed if you're passing order in as well? Why not just choose one?
We should get in the habit of using path.join in node.js code that builds paths.
I think so - it's pretty baked into Playdoh
damnit, I meant 1 line
User_Id is in DB, so is it I need to rebuilt the DB again??
change User_Id to user_id??
I'm not sure that having multiple ways to do the logging configuration is the way to go, I think in the long run that Log4jConfigurationManager should be removed altogether.
Yeah guess we don't.
note: to make seccomp(1) work with modern glibc's, this will need to be _exit(1), or even syscall(__NR_exit, 1) to ensure it calls exit and not exit_group since these helpers are used in the child and the parent.
Not sure that ```tree``` should be capitalized here. It seems to be used rather loosely.
warn log  used inside a debug block
"load module \" %V \" failed (%s)" -> "load module \"%V\" failed (%s)"
Just return a Set[Array[Byte]] here.
I think in general people like to put any functions that are passed in second in case people want to pass in lambda. You could do something like

`def traverseFileTree(f: File)(func: File => Unit)`

which makes lambdas a bit prettier
I did this to mimic ```syev```. If it a bad idea to condition the return in this way I can change both functions. A few changes in ```eig``` are also needed then.

Hold on anyway, because I better do some testing of this function when only some vectors are requested.
Great catch, got a bit delete happy.  Adding this back and updating where necessary.
Arrrgh, copy & paste  error! :D
It is a common scenario - take eg. Orchard as an example. There is a couple of assemblies directly in /bin folder. All necessary assemblies (ie. modules and their dependencies) are kept aside in /App_Data/Dependencies directory and dynamically loaded at startup. BuildManager won't get them...
顺序、成功与否..
There aren't any centralized library for Gaia :P
Do you think it might be worth logging something to console.log to say that settings wasn't detected? Could help with debugging.
Yup, at the very least we will need SETTINGS_SCREEN, possibly HOME_SCREEN + AWESOME_SCREEN as well, yeh no real need for them to be unique to the url buttons (I miss atoms)
There hasn't been complete consensus, and the logging stuff isn't ready, so I think just using `warnings.warn` for now is the easiest/best and can always be updated later.
In vdc-manage:

./vdc-manage macrange add 1 ffffff1 1
ERROR: Invalid mac address syntax ffffff1 (/root/wakame-vdc/dcmgr/lib/dcmgr/cli/errors.rb:12:in `raise')

In mysql it will just apply 0xFFFFFF

mysql> insert into mac_ranges values(2,"test",1,0xFFFFFF1,1,"desc",now(),now());
Query OK, 1 row affected, 1 warning (0.09 sec)

mysql> select hex(range_begin) from mac_ranges where id = 2;
+------------------+
| hex(range_begin) |
+------------------+
| FFFFFF           |
+------------------+
1 row in set (0.00 sec)
Can this match when neither `-t` nor `-r` are specified, or does the option parsing prevent it?
I didn't know that clear() restores the default text, so yes your suggestion is much nicer. Will re-work this.
Looking much better, but what does this do / change?
Nitpick comment, perhaps include a usage example so the API docs have some meat.
I like that this property is no longer called `required` as that was a bit of a mismatch with what the property did.  While I think validatePresence makes more sense I wonder if `_requireKey` or `_requirePresent` might make for more readable code.

```php

$validate = [
  'title' => ['_requirePresent' => 'create']
];
```
for example.
will fix that.
Where's the download parameter?
Please fix the coding standards. You should always use curly braces.
Might make sense to make this extend ImportError...
Sure, but you can never tell what is actually in the code ;-) Anyway, I did a project-wise search and there are no other references for this trait => great
Because then the name tells you that it returns HTML instead of text, which is what you'd otherwise ordinarily expect from seeing `getPropertyValue`. Good naming is, well, a good thing.
Remove this extraneous ;
I used it to help with the original mongo implementation and testing.  Happy to eliminate completely.
Maybe namespace them like `devtools.github.user` and `devtools.path` ?
This should be updated to say the 2.0 link, right?
`start_completion`
I suppose it should have the word "coerced" in there?  That's why there is the C prefix, to be consistent with other traits.
:)  maybe instead we can use a socket tester?
Same with this file, is it necessary too?
Good catch. Done!
> Alternatively, this could take `const git_reference *` or we could keep it with `const git_oid *`. I'm not sure what's easiest.

When renaming it to `git_commit_ahead_behind`, I'd say request `const git_commit*` from the user. Much effort has been put into consistency recently. We shouldn't trade it now :-)

However, in a longer term, I thing there should also be a `git_branch_ahead_behind( size_t*, size_t*, const git_reference* );` - as that is was the user probably wants to know: How much and in what direction did a branch run away from it's upstream. But that's an higher level API that has to figure the upstream of a reference and ...
This should be png_bytep.  See below
Could just put each string on its own line:

```jinja
{{ build_table(test_builds, 
               _('Localized versions in testing'), 
               _('These localizations aren’t final. We’re waiting for more feedback from the community to perfect them.')) }}
```
This should be localisable.
This slice actually increases the number of documents that come back. For some reason, the number that come back defaults to 10. So this increases it to however many we're requesting.
I've been meaning to ask, why do we need this blank `<img/>` instead of setting the background image on the `<a/>`? I am assuming it is some trick or workaround for something.
For example `_requested_processor_id()` allows it to be a string like `'host'`
In terms of loading, crontabber doesn't care what the format is in the postgres. It chews it up and when it dumps to file it does it pretty-printed. 

What we should consider is pretty-printing it when saving INTO the postgres. Just like we do with the filesystem save. Will fix that.
Please add a space (" ") between ";" and "MinVersion" and add this line after the existing one for a slightly easier to read diff.
You are right, being a bool is probably not a big deal tho, will move.
В конфізі форми для цього поля
->add('file', 'file', array('required' => false))
Соната оперує ним, як файлом, а це ресурс
I think it could be a good idea to add a comment to the class to warn other users
null comparison should be strict !==
I thought about it, but deliberately chose not to. 

If someone decides to add another dumper, this class can act as a delegator, and its public method can receive a second argument $format defaulting to 'yml'.
I still find the naming weird. This method does not find the catalogue as you are already finding it before that to pass it as an argument
Ah, got me there :) An empty collection (or form in general for that sake) doesn't transmit data, so there's nothing to protect, right?
isset($this->currentLine[0]) &&  '-' === $this->currentLine[0]
I don't get what you mean, what is the benefit of mkdir / rm / rmdir around each single test case vs once ?
This should also be moved to `FormType`.
I think this test is not needed
Added a commit to update this
Thanks Enze,

My best shot now is some possible compiler over-optimization (-O3 can be very aggressive sometimes). Any further ideas are welcome @arvestad.
There is a problem, first you set the hidden field and then do the validation. The problem is that if the validation fails the form is not sumitted and then you can click the standard "Save" button. But the hidden field will not be be reset back.

Either reset the hidden field in the "save" handler or set the hidden field **after** successful validation (before sending the form).
How about moving this "Skills" table into the "Endorsements" section as a summary table, prior to the textual endorsements?  Then the column could be labeled "Count".

On Nov 7, 2012, at 12:33 PM, kutecht <notifications@github.com> wrote:

> In candpiosapp/mustaches/UserResume.mustache:
> 
> > @@ -224,7 +220,7 @@
> >                  <table id="skills-table">
> >                      <tr>
> >                          <th>Skill</th>
> > -                        <th>Love</th>
> > +                        <th>Endrsmnts</th>
> Due to space requirements, Endorsements was purposely spelled that way (see 18546).
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
nevermind, noticed the delay. sorry!
What do you think about handling all endpoint URLs in Yam?

I might prefer that as a developer (not having to know much about the endpoints)
be code haye html niga koni motevajeh mishi
moshkel az code hate
man moshkeli too stylus nemibinam
kheyli sade va vazehe
Having a None tag is not a problem, as it will be filtered by the get_metrics() function.
https://github.com/DataDog/dd-agent/blob/master/checks/__init__.py#L256
In all cases None tag won't reach the backend.

For the nginx check, it's allowed for example to have a none tag (when using the old configuration schema)
Good one, thanks.
Will use *math.floor*.
These methods should be private or protected so that they aren't available as actions.
In my version logging is initialized before the daemonization, so closing all the descriptors here kills logging. I will try to come up with better solution.
Читаемость кода же.
This is very bad and will break a lot of things
Might benefit from a http://sphinx.pocoo.org/markup/para.html?highlight=version%20added#directive-versionadded
I don't think there is any need for this: they are the default handlers, and users may want to remove them. (In fact, we want to remove the file handler in geocanopy, for example).

A good pattern for populating this kind of object is: there is an extension point in a plugin, that is synchronized with a trait like this.
I had to alter this to make it work for me:

      'true' == capture("if [ -x \"$(which #{command})\" ]; then echo 'true'; fi").strip
I think you meant "really" awesome but I'm +1 on this PR anyway.
a? :) I'll just change this to a bit more meaningful message before merging.
I think it would be better to use a ServiceVerificationHandler here, rather than a ServiceTracker. Looking at the ServiceTracker code it does not look like it can handle the missing dependency case correctly, as it does not deal with the transaction from START_REQUESTED to PROBLEM. 

You will probably have to mock the OperationContext to use ServiceVerificationHandler, but it also has the advantage that you can use it to print out a service status report in the case of failure.
Do we have a plan for that? Will rewritten draggable handle it?
What's the reasoning behind creating this `shell` method?
These are just small tweaks, but i do agree with you here. They improve readability a bit ;)
I think we were adding the figure element even when the contact hadn't for long names not passing that area. Could you verify with UX that the current behavior is the expected?
Do we not have a separate icon for the active state?
z-indexes within the div should go to their respective css file I think.
"Searching" doesnt have to "repaint". Probably It could be nice for getting innerHTML of DOM element which contains messages and highlight text or conversation that contains text searched. Any suggestions?
See the formatting described above.
merge issue, this line should be removed (it's already being loaded from the shared directory L15)
Deleted by mistake, :-(, thanks
wouldn't it be better to check Array.isArray(obj.tel)?
Why would you need this change for? We don't want IMEs to producing HTML directly within.

If you want to highlight some part of the symbols, may I suggest you do it in a way like `km_showPendingSymbols(symbols, highlightStart, highlightEnd)` ?
Not sure why address is treated differently than tel or email, when all are objects
gotcha, we'll start working on a 'naming' branch to remove all "ffos" references from our code.
Will this eventually produce a list of things you may have missed?  (Like Zimbra's Web UI whenever I go in once every week or so and am barraged by missed things.)
need {} as above.
Wow that's craziness, we need to figure out what we are doing wrong here =/

Month view has painting issues.
Need `{` and `}` if the `if` is followed by `else` or `else if`
i would probably change this one to say localhost b/c most users who will test this out locally will not have that domain handy.
I think we should turn on automatic redirect following and enhance `#archive_link` work in that context. We could:

 * return the canonical URI to the [archive on GitHub](http://developer.github.com/v3/repos/contents/#get-archive-link) rather than trying to fully resolve that link to it's final resting place
 * make a head request, rather than a get, and then return the final effective URI after all the redirections have taken place

The former is better, i think, because it uses the canonical URI for that resource rather than the URI of where those archives happen to be hosted today. If the storage system used to host archives changes, the final resting place URI might change but the GitHub api URI will not. Having links that stay live over time could be important for clients that store or sends these URIs to some other program.

Otoh, it is possible that some programs rely on `#archive_link` returning a URI that will not redirect further which is a plus for the latter approach.
No need for the `_` variables here. It's OK to reassign.
in eigenes template for ClockView :-)
using the 'is' operator instead of equality is more appropriate here I think
I don't think I'll need that even. I'm just going to consider An event with a `date` with today as current. I'll probably have it at `event/`even
I'm actually not a fan of these implicits. They are dealing with basic primitives like ```String```, ```Long```, ```Array[Byte]``` and could lead to really subtle bugs later on.

I think that the right way to deal with this is to override ```transformForRead``` in ```HBaseSource``` to deal with deserializing the fields into their proper types. You might need to take an array of types as an argument to make this work properly.
Pick a more descriptive name.
Checking the sources of Jetty 8, the ErrorHandler class looks the same :(
As for Milton, I'm not aware of any problems with servlet containers other than Jetty 6.

Btw, on re-reading the setStatus() method documentation, I'm not that sure, that it is illegal to use it for error codes. Therefore, you could reject this pull request. If we want to support compression of HTTP responses, we'll have to find a way to work around this issue. I see that our cloud deployment does not support compression either. It would be interesting to see if the same problem occurs with tomcat + gzip.
Should not include inline styles.
i think using `self` is cleaner than inlining an entire function
add help text telling what this field is ?
Yep, which will make more sense to a new reader of the code, as well.

Do you want me to send an interdiff to such a state from this pull request, or how should we approach it? Also, should I pull down the patchset, rebase/fold it together and produce a new one that doesn't have the fix-ups separately (for git history purposes)?
patch_commENT?  is that a typo?
`if @subviews?`
If adding <code>PlatformToolSet</code> to v110_xp, did it work on vs2010?
Why not initialize engineEngine?

Is it more readable if rename "engineObject"  to "g_pEngineObject"?
This only shows up if they're trying to access an https:// URL without openssl enabled, in which case they couldn't make the request anyway, right?
probably the most controversial, I transformed the CB into an interface
Yep, using RVM caused that one to mess up. We every combination and this was the only one that seemed to work.
intentionally disabled?
now empty?
Is this really staying in?
"you can SET"
isn't this redundant to the parameters specified in canopenmaster.yaml? Please delete one of them.
Nice, thanks! You live and learn... ;-)
new code starting here
Ah yes! I'll make the change later today.
indentation again.
I used your first suggestion as using the second one would prevent content script to expose any JS value to the document and would break various usages of unsafeWindow.
That's because mutliple domain principals values can be accessed by single domain principals, even if domains are equal.
See with gabor for more details about that.
We're trying to stick to a following convention (at least in new code):

```js
function Foo() {
  // ...
}
exports.Foo = Foo;
```

Could you please update to follow it ?
The documentation is out of date. There isn't second `propertype` argument anymore.
Nit: no space needed before `(client, categories, callback) {`
The %s is filled in the __init__
I would like to rewrite, like, this whole file. We can talk about why/how in chat, but let us not block merging on it. A pull request just against this file would be a good way to discuss it.
@vrthra Can we delete this now?
We pull this functionality out into `Affix.pin` and `Affix.unpin` methods to allow for triggering.
writeDoubleArrayToFile
not a fan of this, I would rather break that than start collecting dirt this early on
Calling Page#walk 3 times means the page has to be parsed 3 times, which is really no more efficient than creating 3 profiles (one for each level).

For the levels idea to be worthwhile merging I think we need to find a way to only call Page#walk once.
A little indentation wouldn't hurt. Can't say much about the rest of this.

"if it works, it works for me ;)"
Please add the proper `@return` in the Docblock
`@uses` statements has been removed from the repo.
got it, will replace then
but as @Maks3w suggested `Hmac::OUTPUT_BINARY` looks more self-explanatory
Align arrows.
This will be fix at a later stage
Doesn't that print to the console? The exception spam isn't desired: if the player has no inventory cleanly say so and return.
at least "todos_not_completed" and "filter" is used by two different templates, so rather than declaring them multiple times, i declared it as a global helper for reusability... 

i then declared "todos_completed" as global helper as well because it's pretty similar to "todos_not_completed", so for consistency...
use dart.js so you only need one .html file:

    <script type="application/dart" src="app.dart"></script>
    <script src="https://dart.googlecode.com/svn/trunk/dart/client/dart.js"></script>

This works for Dartium and all other browsers
I think auto-submitting to cause a full page refresh would be a pretty bad
experience, so I'd probably prefer they had to trigger the submit manually.
Isn't there multiple contents in the directory? Either way when I say it out our it sounds correct.
See comment above about using a while.
I will take care of that.
Minor style nitpick: why not `[]` instead of `new Array();`
you should remove the underscores for these private properties
`$m` should be `$matches` `$m` is an unclear name as it is not possible to know the intent without reading more of the code.
changed this to look the same in cdcf394
I would validate that link is a valid web address. I would look at this method to get a good regex for that: http://ruby-doc.org/stdlib-1.9.3/libdoc/uri/rdoc/URI.html#method-c-regexp
use `self.moduleGenerator.prependPaths`
Spaces everywhere. I know I am being annoying, no worries.
This will need to be updated to 1.0.1.Final because of a translation bug.
eq_ has a better error message that shows the string representation of both values, which is useful (not so much in this case though) when a function returns an object.
*Personally* I don't like the container label tag, but even more so: let's be consistent and always use separate label tags like we have been doing.
Why is this gone completely?
Is magic happening here? I can't see how `var_path` gets used or exposed as config anywhere.
Ah, this is only for unittesting so I'm not concerned. We also need all events so deque wouldn't help.
There's some duplication between `reifyIterableTree` and `reifyIterableIterableTree`.
```
user_id: active_user
```
`RUBY_ENGINE` is defined everywhere.
Adding the iam role to the image seemed the easiest way to store one for now.  Later, I would like to put a dropdown into the virtual machine attributes page that lists the roles in a similar manner to the regions available, but I did not see an easy way to list the IAM roles with Fog.

I don't want to make the IAM role available as a fact, as we consider that a security issue, since facts are available to any user of an instance.  So, rather than pass it in the YAML, I just pull it in from the image attributes.
Hi Espen, your answer is too conditional :-) I did put try .. finally {
base.shutdown } to the Main.main. Who can tell me for sure if this is st.
we need or not?


2012/11/2 Espen Nersveen <notifications@github.com>

> In
> restapp-bootstrap/src/main/java/org/cloudname/example/restapp/server/WebServer.java:
>
> > +        } else {
> > +            handlers.setHandlers(new Handler[] {
> > +                    idHandler, requestLogHandler });
> > +        }
> > +
> > +        server.setHandler(handlers);
> > +
> > +        try {
> > +            log.log(Level.INFO,
> > +                    "Starting " + serviceName + " server on port " + port + " ( http://0.0.0.0:" + port + " )",
> > +                    new Object[] { serviceName, port, port });
> > +            server.start();
> > +        } catch (Exception e) {
> > +            throw new RuntimeException(e);
> > +        }
> > +    }
>
> If server.start() is a blocking operation that will return if the servers
> exists/crashes, then base.shutdown seems to be a good choice to put in a
> finally block here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Cloudname/cloudname/pull/80/files#r2016405>.
>
>



-- 
*Propaganda in signatures sucks but Clojure is really cool. (And
productive.) :-)
(Vær så snill og hjelp meg med å korrigere min norsk, skriftlig og muntlig.
Takk!)*

Jakub Holy
Solutions Engineer | +47 966 23 666
Iterate AS | www.iterate.no
The Lean Software Development Consultancy
- http://theholyjava.wordpress.com/ -
Right now in stable (but probably not in 10 minutes…).
variables with numbers in them is a sign that you're doing it wrong. Removed and replaced with an array of image objects instead.
That's the [oauth_domain parameter](https://github.com/atmos/warden-github/blob/master/lib/warden-github/proxy.rb#L6).

Without it the specs won't pass.

```
  1) Warden::Github::Oauth::Proxy returns an authorize url
     Failure/Error: @proxy =  Warden::Github::Oauth::Proxy.new(sha[0..19], sha[0..39],
     ArgumentError:
       wrong number of arguments (4 for 5)
     # ./lib/warden-github/proxy.rb:6:in `initialize'
     # ./spec/proxy_spec.rb:6:in `new'
     # ./spec/proxy_spec.rb:6:in `block (2 levels) in <top (required)>'
```
Can you restore the file mode?
SureJohn-- Sent from my HP TouchPadOn Sep 25, 2012 12:28 PM, Mark Bessey <notifications@github.com> wrote: In harmonia/source/ProviderList.js:
> @@ -10,7 +10,7 @@ enyo.kind({
>  		onSelectProvider: ""
>  	},
>  	components: [
> -		{kind: "onyx.Toolbar", components: [
> +		{kind: "onyx.Toolbar", style: "height: 65px;", components: [

Can you remove this change, as it's not relevant, and as commented elsewhere, we'd rather do this with a CSS class?

            
              —
              Reply to this email directly or view it on GitHub.
-----------------------------------------------------------------------

Marc Limotte wants to stay in better touch using some of Google's coolest new
products.

If you already have Gmail or Google Talk, visit:
http://mail.google.com/mail/b-48f5a9f239-e0dcee961f-ME-I-AgDQCTLifXtwwIJ2mboRvw
You'll need to click this link to be able to chat with Marc Limotte.

To get Gmail - a free email account from Google with over 2,800 megabytes of
storage - and chat with Marc Limotte, visit:
http://mail.google.com/mail/a-48f5a9f239-e0dcee961f-ME-I-AgDQCTLifXtwwIJ2mboRvw

Gmail offers:
- Instant messaging right inside Gmail
- Powerful spam protection
- Built-in search for finding your messages and a helpful way of organizing
  emails into "conversations"
- No pop-up ads or untargeted banners - just text ads and related information
  that are relevant to the content of your messages

All this, and its yours for free. But wait, there's more! By opening a Gmail
account, you also get access to Google Talk, Google's instant messaging
service:

http://www.google.com/talk/

Google Talk offers:
- Web-based chat that you can use anywhere, without a download
- A contact list that's synchronized with your Gmail account
- Free, high quality PC-to-PC voice calls when you download the Google Talk
  client

We're working hard to add new features and make improvements, so we might also
ask for your comments and suggestions periodically. We appreciate your help in
making our products even better!

Thanks,
The Google Team

To learn more about Gmail and Google Talk, visit:
http://mail.google.com/mail/help/about.html
http://www.google.com/talk/about.html

(If clicking the URLs in this message does not work, copy and paste them into
the address bar of your browser).
Probably to prevent unintentional deletion of logs. To delete a log you would need to su to root and delete it (cause of the sticky bit) or use sudo. Otherwise the postgres user could also delete logs. But the postgres user definitely needs to write logs.
`{}.merge({})`
You didn't say what happens when the value is null :)
same question about errors as earlier.
Do we want the id in here as well?
I executed the 2.9 test suite and all tests succeeded.
Did you miss this?
could you also verify the error message?
Retain spacing.
The error may come from Jackson, and not necessarily from the StringWriter
We don't write code for auto-doc generators, we write it for humans, and those comment blocks are wasteful and hideous.
Не, можно не менять - на +, я вообще не знаю, будет ли оно так работать. Я лишь подозреваю, что можно сделать функции, доступные только внутри класса. Мне тоже интересен этот вопрос.
Да, недосмотрел. Поправлю.
Sorry for the confusion. You are doing "require 'faker'" twice in the same file. I realize this is the result of running cat on all the db populate files :)
@alony почему другой? у нас я рейтинг ответов делаю.
resources :questions do
     resources :answers do
         get :make_right, as: :member
     end
 end

где-то так
вчера пробовал, не работало.
Are you sure it's safe to do this here? We could call OnBeforeShutdown() from the applicationWillTerminate: handler (on the mac) and the main message loop (on windows).
In AccessTokenRequest you check for an existing token and use it if it's available.

Is there a reason why this is not the case for the PasswordAccessTokenRequest?
The environment variables are listed under the Configuration section, but I added descriptions for them to prevent confusion. I think the instructions to get the values make sense under the notes section. 

I also split up the error messages into separate checks so that they are more helpful.

Thanks for the input!
Fixed. Along with others I found.
These ▲ symbols should be the reference code e.g. &1234;
@codyhoag It would also be good to mention here that the RSA Private key type is also available
用reify更好一些？
default? 应该是:else吧
@carlosmn there's something really fishy here. The `SetHandleAsInvalid()` prevents the `SafeHandle` to invoke `git_index_free()`.
according
Loving your tests, the ``mock.patch`` decorator is one of the best things ever!
Scala supports escaping keywords using backticks, eg:

    scala> val `abstract` = "foo"
    abstract: java.lang.String = foo

    scala> `abstract`.length
    res0: Int = 3

Please use this to escape parameters instead.  This way named parameters in reverse routing will still work intuitively.
shouldn't all the pipe calls actually be then calls.
What's the difference between pipe and then (then seems more intuitive).
html_safe felt a bit more semantic to me.

raw is an actual equivalent to html_safe, but raw is mostly used on view or
controllers.


-- 

Ikenna



On Thu, Dec 13, 2012 at 8:34 PM, Philip Arndt <notifications@github.com>wrote:

> In doc/guides/3 - Advanced Techniques and Tips/3 - Using Custom View or
> Layout Templates.textile:
>
> > @@ -61,6 +61,7 @@ name of the file you whitelisted.
> >
> >  * Inside of this file, you can either +render '/refinery/content_page'+, or you
> >  can use +@page.content_for(:body)+ to output the content of a specific page part.
> > +NB: You may want to invoke html_safe like this (@page.content_for(:body).html_safe) in some cases.
>
> True that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/refinery/refinerycms/pull/2078/files#r2413235>.
>
>
I thought `rem` had greater support, but [looks like it doesn't][1].  These should probably be `1em` then.

[1]: http://caniuse.com/rem
What about making this `if file_does_not_contain`, since this is the only place it's used?  `.any` would then become `.none?`
Discard is needed for unsolicited PONG frames send from a client.

http://tools.ietf.org/html/rfc6455#section-5.5.3
That's one incredibly verbose line!

Maybe do something like the following?

```scala
MarketParticipantPosition(
  nanoSeconds            = 661054256,
  mpid                   = ITCH.toAlpha("ABCD"),
  stock                  = ITCH.toAlpha("SPY     "),
```
why? - it's not meant to be extended
hm... not sure about making getRestPrams() public. then the implementation of @musterknabe's PUT/DELETE via POST has to be moved to getRestParams()...
Oh, that. ;)
Whitespace above function defs, please.
please revert CS
A lot $request->get('..  That should be avoided in the PR  especially  in tasks part
I know, debug code is removed on latest commits. Can you be able to see then?
Allowing a single object to represent multiple apertures has advantages. But keep in mind that it makes the classes a lot more complicated and therefore makes writing a custom Aperture class more difficult. It may also make the API for the Aperture classes less intuitive. We should think about how this would work inside the `aperture_photometry` function before deciding on this. An alternative is to 
have 

    aps1 = [CircularAperture(1.), CircularAperture(2.), CircularAperture(3.)]
    aps1 = [CircularAperture(1.5), CircularAperture(2.5), CircularAperture(3.5)]
    results = aperture_photometry(image, (x, y), [aps1, aps2])
We probably want to have a set of tools to help one build the PSF. Maybe the base class (`PSF`) from which `GaussianPSF` derives should contain provisions to do so. Of course, doing `GaussianPSF(sigma=2.)` is nice, easy and fast. However, one might want to provide an image and a set of coordinates that should be used to evaluate the best-fit PSF (here it would be a matter of adjusting the sigma value). I'm not sure exactly about the right mechanism to do this kind of kernel creation though. Similarly, I'm not sure if it should work from the image and a set of coordinates, or a set of subimages, or whatever else.

Here is a list of PSF subclasses that I think we should provide:
- `GaussianPSF`: Should it be generalized to be a 2D Gaussian having a sigma which could be a covariance matrix? (to allow 2D correlating Gaussians)
- `MoffatPSF`: Same 2D provision
- `LorentzianPSF`: Same 2D provision
- `DiscretePSF`: This one would be built from an actual array of pixels. We should have the option to initialize it from a 2D array, but also to build it from a set of subarrays or an array with coordinates from which the kernel would be extracted. This would would require a kernel size in x and y as well. Option for the kernel statistics would also be appropriate here (i.e. median averaging, mean, etc.). A sampling argument would be good too, so that the image/subarrays can be oversampled because being extracted.

This brings another point to me. How do we deal with the PSF kernel truncation? For kernels that are discrete it's relatively trivial. However, for kernels that are functions, one probably wants to truncate them somewhere otherwise it becomes highly inefficient to carry the calculation over the entire image.
Give him a chance, if he doesn't you'll have to use the technique I posted on the reviewers list for integrating remote repo changes into your local repo.
isn't metadata['blessed'] set to True (https://github.com/dscannell/openstack/blob/ead1f2ac1df5b00085fbab8ebe627a0c066f71ad/nova/gridcentric/nova/extension/manager.py#L205)?
Yes, putIfAbsent is no longer deterministic in absence of locking. Will remove SKIP_LOCKING.
Looking at npm itself, it seems that the existing `invalid` flag is only used in `ls` to print out "INVALID". Is that correct?
I think this looks better:

```python
"""
Update the pixel positions of the annotation text and the arrow
patch.
"""
```
Complete nit-pick: I would typically put the ```warn``` first - because it is as far simpler evaluation (is a boolean True or False **vs** get the value from the dictionary and compare the strings).

I do not expect you to make this change (it is so trivial and adds nothing to the PR), I just wanted to mention it for future consideration.

Thanks,
if the not-quite-mock objects returned by the create_X methods in the base
test class knew how to delete themselves, i could push them into a
self.fixtures list and tell teardown to run each object's delete method,
but the objects rerturned by create_X are just dictionaries and don't know
how to delete themselves.

while i think this would be a good problem to solve, i'm not sure it's a
good idea to try to solve it within the scope of this PR. unless i am
mistaken, all of the test cases in this project have the same issue, it's
just not quite as obvious because they are one-line unmarked teardown
rather than a whole section.

On Tue, Oct 30, 2012 at 9:30 AM, Bob Silverberg <notifications@github.com>wrote:

> In tests/test_manage_runs_page.py:
>
> > +        # add suite2 to the run
> > +        edit_run_pg.add_suite(suite2['name'])
> > +        # re-order suites to run suite2 first
> > +        edit_run_pg.drag_and_drop_suite(suite2['name'], suite1['name'])
> > +        # save
> > +        manage_runs_pg = edit_run_pg.click_save()
> > +        # click edit
> > +        manage_runs_pg.filter_runs_by_name(name=run['name'])
> > +        runs = manage_runs_pg.get_runs
> > +        edit_run_pg = runs[0].edit()
> > +        expected = [suite2['name'], suite1['name']]
> > +        actual = edit_run_pg.included_suite_names
> > +        assert actual == expected
> > +
> > +        # teardown
> > +        self.delete_run(mozwebqa_logged_in, run)
>
> I don't believe that you can have setup or teardown run for a single test
> case (or selected test cases) in a class, but I would think that just
> moving the test into its own file would be an option.
>
> You could look into using a global variable to control the behaviour of
> teardown, but that seems overly complicated to me.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/moztrap-tests/pull/80/files#r1980850>.
>
>
For asynchronous implementations, you'll need to use tile.setImgSrc instead of assigning tile.url. And you have to set tile.url to a blank image data uri before calling `this.cacheControl.getItem()`.
Well if it's expired IMO it shouldn't exist anymore, it should be a
cache miss.
phpcs said they were not ( expecting 4 spaces instead of 1 )
there is a stray whitespace at the end of this line (highlighted in red by git)
@bp323 sure, I missed that one
wants to be repetition
I think this includes some other BC breaks too. ;) Document them maybe?
It is camel_cased now.
Fixed in ff79ebe7e360341b854ab08f3696ac4dc8324424.
Sprintf might be slightly nicer here but meh.
If a username / email combination already exists django will throw a IntegrityError, because username field is marked as unique. This will be caused if we import a list of users which accidentally contain already users that already have accounts.

Personally I'm a big fan of "Better to Apologize than Ask Permission" (aka try / except :) ) that's why I coded it like this. Now that I'm thinking about this I can use User.objects.get_or_create if you think that's better. I'll upload a fixed version asap
What do you think about using debug instead of info? These really seem debug related.